status
stringclasses 1
value | repo_name
stringlengths 9
24
| repo_url
stringlengths 28
43
| issue_id
int64 1
104k
| updated_files
stringlengths 8
1.76k
| title
stringlengths 4
369
| body
stringlengths 0
254k
⌀ | issue_url
stringlengths 37
56
| pull_url
stringlengths 37
54
| before_fix_sha
stringlengths 40
40
| after_fix_sha
stringlengths 40
40
| report_datetime
timestamp[ns, tz=UTC] | language
stringclasses 5
values | commit_datetime
timestamp[us, tz=UTC] |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,365 | ["qa/multi-cluster-search/src/test/java/org/elasticsearch/search/CCSDuelIT.java"] | [CI] CCSDuelIT testFieldCollapsingOneClusterHasNoResults failing | **Build scan:**
https://gradle-enterprise.elastic.co/s/me2w54x4rh5tw/tests/:qa:multi-cluster-search:mixedClusterTest/org.elasticsearch.search.CCSDuelIT/testFieldCollapsingOneClusterHasNoResults
**Reproduction line:**
`./gradlew ':qa:multi-cluster-search:mixedClusterTest' --tests "org.elasticsearch.search.CCSDuelIT.testFieldCollapsingOneClusterHasNoResults" -Dtests.seed=590265B01FD5045C -Dtests.locale=hu -Dtests.timezone=Brazil/Acre -Druntime.java=11`
**Applicable branches:**
master
**Reproduces locally?:**
Yes
**Failure history:**
https://gradle-enterprise.elastic.co/scans/tests?tests.container=org.elasticsearch.search.CCSDuelIT&tests.test=testFieldCollapsingOneClusterHasNoResults
**Failure excerpt:**
```
java.lang.AssertionError: Didn't match expected value:
_clusters:
skipped: same [0]
successful: same [2]
total: same [2]
_shards:
failed: same [0]
skipped: expected Integer [5] but was Integer [0]
successful: same [8]
total: same [8]
hits:
hits:
0:
_id: same [multi_cluster-1]
_index: same [ccs_duel_index]
_score: same [1.0]
_source:
creationDate: same [2019/01/30]
id: same [multi_cluster-1]
join:
name: same [question]
questionId: same [null]
suggest:
input:
0: same [python]
1: same [java]
2: same [php]
tags:
0: same [python]
1: same [java]
2: same [php]
type: same [question]
user: same [user3]
votes: same [6]
fields:
user.keyword:
0: same [user3]
1:
_id: same [multi_cluster-6]
_index: same [ccs_duel_index]
_score: same [1.0]
_source:
creationDate: same [2019/01/21]
id: same [multi_cluster-6]
join:
name: same [question]
questionId: same [null]
suggest:
input:
0: same [html]
tags:
0: same [html]
type: same [question]
user: same [user8]
votes: same [8]
fields:
user.keyword:
0: same [user8]
2:
_id: same [multi_cluster-8]
_index: same [ccs_duel_index]
_score: same [1.0]
_source:
creationDate: same [2019/01/02]
id: same [multi_cluster-8]
join:
name: same [question]
questionId: same [null]
suggest:
input:
0: same [perl]
1: same [ruby]
tags:
0: same [perl]
1: same [ruby]
type: same [question]
user: same [user4]
votes: same [14]
fields:
user.keyword:
0: same [user4]
3:
_id: same [multi_cluster-13]
_index: same [ccs_duel_index]
_score: same [1.0]
_source:
creationDate: same [2019/01/30]
id: same [multi_cluster-13]
join:
name: same [question]
questionId: same [null]
suggest:
input:
0: same [python]
1: same [php]
tags:
0: same [python]
1: same [php]
type: same [question]
user: same [user7]
votes: same [14]
fields:
user.keyword:
0: same [user7]
4:
_id: same [multi_cluster-23]
_index: same [ccs_duel_index]
_score: same [1.0]
_source:
creationDate: same [2019/01/26]
id: same [multi_cluster-23]
join:
name: same [question]
questionId: same [null]
suggest:
input:
0: same [java]
tags:
0: same [java]
type: same [question]
user: same [user5]
votes: same [9]
fields:
user.keyword:
0: same [user5]
5:
_id: same [multi_cluster-28]
_index: same [ccs_duel_index]
_score: same [1.0]
_source:
creationDate: same [2019/01/15]
id: same [multi_cluster-28]
join:
name: same [question]
questionId: same [null]
suggest:
input:
0: same [ruby]
tags:
0: same [ruby]
type: same [question]
user: same [user1]
votes: same [16]
fields:
user.keyword:
0: same [user1]
6:
_id: same [multi_cluster-31]
_index: same [ccs_duel_index]
_score: same [1.0]
_source:
creationDate: same [2019/01/19]
id: same [multi_cluster-31]
join:
name: same [question]
questionId: same [null]
suggest:
input:
0: same [python]
1: same [sql]
2: same [ruby]
tags:
0: same [python]
1: same [sql]
2: same [ruby]
type: same [question]
user: same [user9]
votes: same [12]
fields:
user.keyword:
0: same [user9]
7:
_id: same [multi_cluster-37]
_index: same [ccs_duel_index]
_score: same [1.0]
_source:
creationDate: same [2019/01/28]
id: same [multi_cluster-37]
join:
name: same [question]
questionId: same [null]
suggest:
input:
0: same [python]
1: same [perl]
tags:
0: same [python]
1: same [perl]
type: same [question]
user: same [user6]
votes: same [23]
fields:
user.keyword:
0: same [user6]
8:
_id: same [multi_cluster-55]
_index: same [ccs_duel_index]
_score: same [1.0]
_source:
creationDate: same [2019/01/04]
id: same [multi_cluster-55]
join:
name: same [question]
questionId: same [null]
suggest:
input:
0: same [perl]
1: same [ruby]
tags:
0: same [perl]
1: same [ruby]
type: same [question]
user: same [user2]
votes: same [5]
fields:
user.keyword:
0: same [user2]
9:
_id: same [multi_cluster-1005]
_index: same [ccs_duel_index]
_routing: same [multi_cluster-30]
_score: same [1.0]
_source:
creationDate: same [2019/01/20]
id: same [multi_cluster-1005]
join:
name: same [answer]
parent: same [multi_cluster-30]
questionId: same [multi_cluster-30]
suggest:
input: same [empty list]
tags: same [empty list]
type: same [answer]
user: same [user10]
votes: same [7]
fields:
user.keyword:
0: same [user10]
max_score: same [null]
total:
relation: same [eq]
value: same [204]
timed_out: same [false]
took: same [-1]
at __randomizedtesting.SeedInfo.seed([590265B01FD5045C:92C56F0B55D4C02]:0)
at org.elasticsearch.search.CCSDuelIT.duelSearch(CCSDuelIT.java:771)
at org.elasticsearch.search.CCSDuelIT.testFieldCollapsingOneClusterHasNoResults(CCSDuelIT.java:472)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(NativeMethodAccessorImpl.java:-2)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:566)
at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1758)
at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:946)
at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:982)
at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:996)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at org.apache.lucene.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:44)
at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
at org.apache.lucene.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:45)
at org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
at org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:375)
at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:824)
at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:475)
at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:955)
at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:840)
at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:891)
at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:902)
at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at org.apache.lucene.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:38)
at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at org.apache.lucene.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
at org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
at org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
at org.apache.lucene.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:375)
at com.carrotsearch.randomizedtesting.ThreadLeakControl.lambda$forkTimeoutingTask$0(ThreadLeakControl.java:831)
at java.lang.Thread.run(Thread.java:834)
``` | https://github.com/elastic/elasticsearch/issues/79365 | https://github.com/elastic/elasticsearch/pull/79490 | b6439c5d97052655dd75d7f1de1dc344ba38ecaa | b84cec60d5127d6644e8e746a9c825e93e654a3d | 2021-10-18T14:38:23Z | java | 2021-10-19T18:05:47Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,361 | ["x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/security/authz/accesscontrol/IndicesAccessControl.java", "x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/security/authz/permission/IndicesPermission.java", "x-pack/plugin/security/src/test/java/org/elasticsearch/xpack/security/authz/accesscontrol/IndicesAccessControlTests.java", "x-pack/plugin/security/src/test/java/org/elasticsearch/xpack/security/authz/accesscontrol/IndicesPermissionTests.java"] | NativeRealmIntegTests fail on master and 7.x | **Build scan**:
https://gradle-enterprise.elastic.co/s/voymlnrgccyq2
**Repro line**:
```
REPRODUCE WITH: ./gradlew ':x-pack:plugin:security:internalClusterTest' --tests "org.elasticsearch.xpack.security.authc.esnative.NativeRealmIntegTests.testAddUserAndRoleThenAuth" \
-Dtests.seed=C99E649FE167748C \
-Dtests.locale=ms \
-Dtests.timezone=America/Shiprock \
-Druntime.java=11
REPRODUCE WITH: ./gradlew ':x-pack:plugin:security:internalClusterTest' --tests "org.elasticsearch.xpack.security.authc.esnative.NativeRealmIntegTests.testAddUserAndRoleThenAuth" \
-Dtests.seed=C99E649FE167748C \
-Dtests.locale=ms \
-Dtests.timezone=America/Shiprock \
-Druntime.java=11
```
**Reproduces locally?**:
No
**Applicable branches**:
`master`, `7.x`
**Failure history**:
6 failures this year but 3 new ones (today).
**Failure excerpt**:
```
13:48:14 org.elasticsearch.xpack.security.authc.esnative.NativeRealmIntegTests > testAddUserAndRoleThenAuth FAILED
13:48:14 java.lang.NullPointerException
13:48:14 at __randomizedtesting.SeedInfo.seed([C99E649FE167748C:919ACE55FC4DCE80]:0)
13:48:14 at org.elasticsearch.xpack.core.security.authz.accesscontrol.IndicesAccessControl.getFieldAndDocumentLevelSecurityUsage(IndicesAccessControl.java:72)
13:48:14 at org.elasticsearch.xpack.security.authz.interceptor.DlsFlsLicenseRequestInterceptor.intercept(DlsFlsLicenseRequestInterceptor.java:58)
13:48:14 at org.elasticsearch.xpack.security.authz.AuthorizationService$1.onResponse(AuthorizationService.java:479)
13:48:14 at org.elasticsearch.xpack.security.authz.AuthorizationService$1.onResponse(AuthorizationService.java:475)
13:48:14 at org.elasticsearch.xpack.security.authz.interceptor.FieldAndDocumentLevelSecurityRequestInterceptor.intercept(FieldAndDocumentLevelSecurityRequestInterceptor.java:75)
13:48:14 at org.elasticsearch.xpack.security.authz.interceptor.UpdateRequestInterceptor.intercept(UpdateRequestInterceptor.java:27)
13:48:14 at org.elasticsearch.xpack.security.authz.AuthorizationService$1.onResponse(AuthorizationService.java:479)
13:48:14 at org.elasticsearch.xpack.security.authz.AuthorizationService$1.onResponse(AuthorizationService.java:475)
13:48:14 at org.elasticsearch.xpack.security.authz.interceptor.ResizeRequestInterceptor.intercept(ResizeRequestInterceptor.java:78)
13:48:14 at org.elasticsearch.xpack.security.authz.AuthorizationService.runRequestInterceptors(AuthorizationService.java:474)
13:48:14 at org.elasticsearch.xpack.security.authz.AuthorizationService.handleIndexActionAuthorizationResult(AuthorizationService.java:464)
13:48:14 at org.elasticsearch.xpack.security.authz.AuthorizationService.lambda$authorizeAction$11(AuthorizationService.java:395)
13:48:14 at org.elasticsearch.xpack.security.authz.AuthorizationService$AuthorizationResultListener.onResponse(AuthorizationService.java:781)
13:48:14 at org.elasticsearch.xpack.security.authz.AuthorizationService$AuthorizationResultListener.onResponse(AuthorizationService.java:756)
13:48:14 at org.elasticsearch.action.support.ContextPreservingActionListener.onResponse(ContextPreservingActionListener.java:31)
13:48:14 at org.elasticsearch.xpack.security.authz.RBACEngine.lambda$authorizeIndexAction$3(RBACEngine.java:327)
13:48:14 at org.elasticsearch.action.ActionListener$1.onResponse(ActionListener.java:134)
13:48:14 at org.elasticsearch.common.util.concurrent.ListenableFuture.notifyListenerDirectly(ListenableFuture.java:113)
13:48:14 at org.elasticsearch.common.util.concurrent.ListenableFuture.addListener(ListenableFuture.java:55)
13:48:14 at org.elasticsearch.common.util.concurrent.ListenableFuture.addListener(ListenableFuture.java:41)
13:48:14 at org.elasticsearch.xpack.security.authz.AuthorizationService$CachingAsyncSupplier.getAsync(AuthorizationService.java:828)
13:48:14 at org.elasticsearch.xpack.security.authz.RBACEngine.authorizeIndexAction(RBACEngine.java:318)
13:48:14 at org.elasticsearch.xpack.security.authz.AuthorizationService.authorizeAction(AuthorizationService.java:393)
13:48:14 at org.elasticsearch.xpack.security.authz.AuthorizationService.maybeAuthorizeRunAs(AuthorizationService.java:326)
13:48:14 at org.elasticsearch.xpack.security.authz.AuthorizationService.lambda$authorize$1(AuthorizationService.java:227)
13:48:14 at org.elasticsearch.action.ActionListener$1.onResponse(ActionListener.java:134)
13:48:14 at org.elasticsearch.action.support.ContextPreservingActionListener.onResponse(ContextPreservingActionListener.java:31)
13:48:14 at org.elasticsearch.xpack.security.authz.RBACEngine.lambda$resolveAuthorizationInfo$1(RBACEngine.java:128)
13:48:14 at org.elasticsearch.action.ActionListener$1.onResponse(ActionListener.java:134)
13:48:14 at org.elasticsearch.xpack.security.authz.store.CompositeRolesStore.lambda$buildThenMaybeCacheRole$14(CompositeRolesStore.java:362)
13:48:14 at org.elasticsearch.action.ActionListener$1.onResponse(ActionListener.java:134)
13:48:14 at org.elasticsearch.xpack.security.authz.store.CompositeRolesStore.buildRoleFromDescriptors(CompositeRolesStore.java:509)
13:48:14 at org.elasticsearch.xpack.security.authz.store.CompositeRolesStore.buildThenMaybeCacheRole(CompositeRolesStore.java:342)
13:48:14 at org.elasticsearch.xpack.security.authz.store.CompositeRolesStore.lambda$roles$3(CompositeRolesStore.java:201)
13:48:14 at org.elasticsearch.action.ActionListener$1.onResponse(ActionListener.java:134)
13:48:14 at org.elasticsearch.xpack.security.authz.store.CompositeRolesStore.lambda$loadRoleDescriptorsAsync$18(CompositeRolesStore.java:412)
13:48:14 at org.elasticsearch.action.ActionListener$1.onResponse(ActionListener.java:134)
13:48:14 at org.elasticsearch.action.support.ContextPreservingActionListener.onResponse(ContextPreservingActionListener.java:31)
13:48:14 at org.elasticsearch.xpack.core.common.IteratingActionListener.onResponse(IteratingActionListener.java:127)
13:48:14 at org.elasticsearch.xpack.security.authz.store.CompositeRolesStore.lambda$loadRoleDescriptorsAsync$21(CompositeRolesStore.java:432)
13:48:14 at org.elasticsearch.action.ActionListener$1.onResponse(ActionListener.java:134)
13:48:14 at org.elasticsearch.xpack.security.authz.store.NativeRolesStore.lambda$getRoleDescriptors$5(NativeRolesStore.java:156)
13:48:14 at org.elasticsearch.action.ActionListener$1.onResponse(ActionListener.java:134)
13:48:14 at org.elasticsearch.action.support.ContextPreservingActionListener.onResponse(ContextPreservingActionListener.java:31)
13:48:14 at org.elasticsearch.client.node.NodeClient.lambda$executeLocally$0(NodeClient.java:103)
13:48:14 at org.elasticsearch.tasks.TaskManager$1.onResponse(TaskManager.java:169)
13:48:14 at org.elasticsearch.tasks.TaskManager$1.onResponse(TaskManager.java:163)
13:48:14 at org.elasticsearch.action.support.ContextPreservingActionListener.onResponse(ContextPreservingActionListener.java:31)
13:48:14 at org.elasticsearch.xpack.security.action.filter.SecurityActionFilter.lambda$applyInternal$2(SecurityActionFilter.java:146)
13:48:14 at org.elasticsearch.action.ActionListener$DelegatingFailureActionListener.onResponse(ActionListener.java:217)
13:48:14 at org.elasticsearch.action.get.TransportMultiGetAction$1.finishHim(TransportMultiGetAction.java:123)
13:48:14 at org.elasticsearch.action.get.TransportMultiGetAction$1.onResponse(TransportMultiGetAction.java:106)
13:48:14 at org.elasticsearch.action.get.TransportMultiGetAction$1.onResponse(TransportMultiGetAction.java:98)
13:48:14 at org.elasticsearch.client.node.NodeClient.lambda$executeLocally$0(NodeClient.java:103)
13:48:14 at org.elasticsearch.tasks.TaskManager$1.onResponse(TaskManager.java:169)
13:48:14 at org.elasticsearch.tasks.TaskManager$1.onResponse(TaskManager.java:163)
13:48:14 at org.elasticsearch.action.support.ContextPreservingActionListener.onResponse(ContextPreservingActionListener.java:31)
13:48:14 at org.elasticsearch.xpack.security.action.filter.SecurityActionFilter.lambda$applyInternal$2(SecurityActionFilter.java:146)
13:48:14 at org.elasticsearch.action.ActionListener$DelegatingFailureActionListener.onResponse(ActionListener.java:217)
13:48:14 at org.elasticsearch.action.support.single.shard.TransportSingleShardAction$AsyncSingleAction$2.handleResponse(TransportSingleShardAction.java:240)
```
| https://github.com/elastic/elasticsearch/issues/79361 | https://github.com/elastic/elasticsearch/pull/79415 | 3151198ad60628a126493d3cc4e982447ae2785f | 4ea349d400abd51379a351a9bc993ef0ce35e57a | 2021-10-18T13:31:51Z | java | 2021-10-19T06:29:57Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,359 | ["server/src/test/java/org/elasticsearch/cluster/coordination/CoordinatorTests.java"] | CoordinatorTests fail on master (Windows only) | **Build scan**:
https://gradle-enterprise.elastic.co/s/xdmessnisusse
**Repro line**:
```
REPRODUCE WITH: gradlew ':server:test' --tests "org.elasticsearch.cluster.coordination.CoordinatorTests.testLogsMessagesIfPublicationDelayed" \
-Dtests.seed=671EB775CB544A53 \
-Dtests.locale=ga-IE \
-Dtests.timezone=America/St_Lucia \
-Druntime.java=11
REPRODUCE WITH: gradlew ':server:test' --tests "org.elasticsearch.cluster.coordination.CoordinatorTests.testLogsMessagesIfPublicationDelayed" \
-Dtests.seed=671EB775CB544A53 \
-Dtests.locale=ga-IE \
-Dtests.timezone=America/St_Lucia \
-Druntime.java=11
```
**Reproduces locally?**:
No
**Applicable branches**:
`master`
**Failure history**:
30 failures in the last 3 days
**Failure excerpt**:
```
12:50:35 org.elasticsearch.cluster.coordination.CoordinatorTests > testLogsMessagesIfPublicationDelayed FAILED
12:50:35 java.lang.AssertionError: expected to see hot threads from lagging node but did not
12:50:35 Expected: <true>
12:50:35 but: was <false>
12:50:35 at __randomizedtesting.SeedInfo.seed([8A85993DF64594DB:354021612F7F2505]:0)
12:50:35 at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
12:50:35 at org.elasticsearch.test.MockLogAppender$SeenEventExpectation.assertMatched(MockLogAppender.java:121)
12:50:35 at org.elasticsearch.test.MockLogAppender.assertAllExpectationsMatched(MockLogAppender.java:55)
12:50:35 at org.elasticsearch.cluster.coordination.CoordinatorTests.testLogsMessagesIfPublicationDelayed(CoordinatorTests.java:1880)
```
| https://github.com/elastic/elasticsearch/issues/79359 | https://github.com/elastic/elasticsearch/pull/79363 | 52b4fa67acb98388cfcee96640f60d88189d3f38 | 08d42a133f4f3302127f0d408878ffd8115da825 | 2021-10-18T13:09:15Z | java | 2021-10-18T18:43:37Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,354 | ["x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/security/SecurityContext.java", "x-pack/plugin/security/src/test/java/org/elasticsearch/xpack/security/SecurityContextTests.java", "x-pack/qa/rolling-upgrade/build.gradle", "x-pack/qa/rolling-upgrade/src/test/resources/operator_users.yml", "x-pack/qa/rolling-upgrade/src/test/resources/rest-api-spec/test/mixed_cluster/130_operator_privileges.yml"] | Operator privileges do not work properly in a mixed version cluster | The operator privilege feature works by settng a special header in authenticating user's threadContext. This header is not preserved in a mixed version cluster when the request must be rerouted from a local node to a remote node of different version:
https://github.com/elastic/elasticsearch/blob/6895511df75c261963204ea754eda3adea5fe0da/x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/transport/SecurityServerTransportInterceptor.java#L104-L107
When sending request across nodes of different version, only the authentication object of the original request is preserved and other security related information is dropped. This leads to the remote node not recognising the user as an operator and in turns fails with and "unauthorized" (403) error. | https://github.com/elastic/elasticsearch/issues/79354 | https://github.com/elastic/elasticsearch/pull/79412 | 4416206403ce763e1010fe65a71ae6a74ad9bb21 | 75319f4e949a4f6778d17d95ce93aedf256ed394 | 2021-10-18T12:04:07Z | java | 2021-10-19T08:50:34Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,339 | ["server/build.gradle"] | org.elasticsearch.index.TimeSeriesModeTests fails on master | **Build scan**:
https://gradle-enterprise.elastic.co/s/3e5lelduphc6w
**Repro line**:
```
REPRODUCE WITH: ./gradlew ':server:test' --tests "org.elasticsearch.index.TimeSeriesModeTests.testRequiredRouting" \
-Dtests.seed=79B9B361136DDB62 \
-Dbuild.snapshot=false \
-Dtests.jvm.argline="-Dbuild.snapshot=false" \
-Dtests.locale=fi \
-Dtests.timezone=America/Creston \
-Druntime.java=11
REPRODUCE WITH: ./gradlew ':server:test' --tests "org.elasticsearch.index.TimeSeriesModeTests.testRequiredRouting" \
-Dtests.seed=79B9B361136DDB62 \
-Dbuild.snapshot=false \
-Dtests.jvm.argline="-Dbuild.snapshot=false" \
-Dtests.locale=fi \
-Dtests.timezone=America/Creston \
-Druntime.java=11
```
**Reproduces locally?**:
yes
**Applicable branches**:
master
**Failure history**:
5 failures in the last 3 days.
**Failure excerpt**:
```
09:30:44 org.elasticsearch.index.TimeSeriesModeTests > testRequiredRouting FAILED
09:30:44 junit.framework.AssertionFailedError: Expected exception IllegalArgumentException but no exception was thrown
09:30:44 at __randomizedtesting.SeedInfo.seed([79B9B361136DDB62:C88A62A74DF8013E]:0)
09:30:44 at org.apache.lucene.util.LuceneTestCase.expectThrows(LuceneTestCase.java:2874)
09:30:44 at org.apache.lucene.util.LuceneTestCase.expectThrows(LuceneTestCase.java:2860)
09:30:44 at org.elasticsearch.index.TimeSeriesModeTests.testRequiredRouting(TimeSeriesModeTests.java:73)
``` | https://github.com/elastic/elasticsearch/issues/79339 | https://github.com/elastic/elasticsearch/pull/79366 | fea9c34dd96d56e45d97f5be09b9ab8acf6d6219 | d4f698d16a46658d8b790b2c6e89abc35fba0fb5 | 2021-10-18T07:55:39Z | java | 2021-10-18T17:15:15Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,300 | ["modules/reindex/src/internalClusterTest/java/org/elasticsearch/index/reindex/BulkByScrollUsesAllScrollDocumentsAfterConflictsIntegTests.java"] | [CI] BulkByScrollUsesAllScrollDocumentsAfterConflictsIntegTests testReindex failing | It works fine with 7.x
**Build scan:**
https://gradle-enterprise.elastic.co/s/szvepl3vj7o7y/tests/:modules:reindex:internalClusterTest/org.elasticsearch.index.reindex.BulkByScrollUsesAllScrollDocumentsAfterConflictsIntegTests/testReindex
**Reproduction line:**
`./gradlew ':modules:reindex:internalClusterTest' --tests "org.elasticsearch.index.reindex.BulkByScrollUsesAllScrollDocumentsAfterConflictsIntegTests.testReindex" -Dtests.seed=A5D1900B8EFBFF6F -Dtests.locale=en-NZ -Dtests.timezone=America/Detroit -Druntime.java=11`
**Applicable branches:**
master
**Reproduces locally?:**
Yes
**Failure history:**
https://gradle-enterprise.elastic.co/scans/tests?tests.container=org.elasticsearch.index.reindex.BulkByScrollUsesAllScrollDocumentsAfterConflictsIntegTests&tests.test=testReindex
**Failure excerpt:**
```
java.lang.AssertionError: {"took":94,"errors":true,"items":[{"index":{"_index":"kxbrhijgnw","_id":"62","_version":1,"result":"created","_shards":{"total":1,"successful":1,"failed":0},"_seq_no":10,"_primary_term":1,"status":201}},{"index":{"_index":"kxbrhijgnw","_id":"55","_version":1,"result":"created","_shards":{"total":1,"successful":1,"failed":0},"_seq_no":11,"_primary_term":1,"status":201}},{"index":{"_index":"kxbrhijgnw","_id":"78","_version":1,"result":"created","_shards":{"total":1,"successful":1,"failed":0},"_seq_no":12,"_primary_term":1,"status":201}},{"index":{"_index":"kxbrhijgnw","_id":"98","_version":1,"result":"created","_shards":{"total":1,"successful":1,"failed":0},"_seq_no":13,"_primary_term":1,"status":201}},{"index":{"_index":"kxbrhijgnw","_id":"60","_version":1,"result":"created","_shards":{"total":1,"successful":1,"failed":0},"_seq_no":14,"_primary_term":1,"status":201}},{"index":{"_index":"kxbrhijgnw","_id":"61","_version":1,"result":"created","_shards":{"total":1,"successful":1,"failed":0},"_seq_no":15,"_primary_term":1,"status":201}},{"index":{"_index":"kxbrhijgnw","_id":"73","_version":1,"result":"created","_shards":{"total":1,"successful":1,"failed":0},"_seq_no":16,"_primary_term":1,"status":201}},{"index":{"_index":"kxbrhijgnw","_id":"48","_version":1,"result":"created","_shards":{"total":1,"successful":1,"failed":0},"_seq_no":17,"_primary_term":1,"status":201}},{"index":{"_index":"kxbrhijgnw","_id":"5","_version":1,"result":"created","_shards":{"total":1,"successful":1,"failed":0},"_seq_no":18,"_primary_term":1,"status":201}},{"index":{"_index":"kxbrhijgnw","_id":"46","_version":1,"result":"created","_shards":{"total":1,"successful":1,"failed":0},"_seq_no":19,"_primary_term":1,"status":201}},{"index":{"_index":"kxbrhijgnw","_id":"50","_version":1,"result":"created","_shards":{"total":1,"successful":1,"failed":0},"_seq_no":20,"_primary_term":1,"status":201}},{"index":{"_index":"kxbrhijgnw","_id":"84","status":409,"error":{"type":"version_conflict_engine_exception","reason":"[84]: version conflict, document already exists (current version [1])","index_uuid":"8iU0S2gOQvaHDBVder-WVg","shard":"0","index":"kxbrhijgnw"}}},{"index":{"_index":"kxbrhijgnw","_id":"65","_version":1,"result":"created","_shards":{"total":1,"successful":1,"failed":0},"_seq_no":21,"_primary_term":1,"status":201}},{"index":{"_index":"kxbrhijgnw","_id":"96","_version":1,"result":"created","_shards":{"total":1,"successful":1,"failed":0},"_seq_no":22,"_primary_term":1,"status":201}},{"index":{"_index":"kxbrhijgnw","_id":"99","_version":1,"result":"created","_shards":{"total":1,"successful":1,"failed":0},"_seq_no":23,"_primary_term":1,"status":201}},{"index":{"_index":"kxbrhijgnw","_id":"71","_version":1,"result":"created","_shards":{"total":1,"successful":1,"failed":0},"_seq_no":24,"_primary_term":1,"status":201}},{"index":{"_index":"kxbrhijgnw","_id":"33","_version":1,"result":"created","_shards":{"total":1,"successful":1,"failed":0},"_seq_no":25,"_primary_term":1,"status":201}},{"index":{"_index":"kxbrhijgnw","_id":"10","_version":1,"result":"created","_shards":{"total":1,"successful":1,"failed":0},"_seq_no":26,"_primary_term":1,"status":201}},{"index":{"_index":"kxbrhijgnw","_id":"72","_version":1,"result":"created","_shards":{"total":1,"successful":1,"failed":0},"_seq_no":27,"_primary_term":1,"status":201}},{"index":{"_index":"kxbrhijgnw","_id":"37","_version":1,"result":"created","_shards":{"total":1,"successful":1,"failed":0},"_seq_no":28,"_primary_term":1,"status":201}}]}
Expected: is <false>
but: was <true>
at __randomizedtesting.SeedInfo.seed([A5D1900B8EFBFF6F:36ABCEE70CAE453D]:0)
at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
at org.junit.Assert.assertThat(Assert.java:956)
at org.elasticsearch.index.reindex.BulkByScrollUsesAllScrollDocumentsAfterConflictsIntegTests.executeConcurrentUpdatesOnSubsetOfDocs(BulkByScrollUsesAllScrollDocumentsAfterConflictsIntegTests.java:244)
at org.elasticsearch.index.reindex.BulkByScrollUsesAllScrollDocumentsAfterConflictsIntegTests.testReindex(BulkByScrollUsesAllScrollDocumentsAfterConflictsIntegTests.java:126)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(NativeMethodAccessorImpl.java:-2)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:566)
at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1758)
at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:946)
at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:982)
at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:996)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at org.apache.lucene.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:44)
at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
at org.apache.lucene.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:45)
at org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
at org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:375)
at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:824)
at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:475)
at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:955)
at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:840)
at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:891)
at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:902)
at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at org.apache.lucene.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:38)
at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at org.apache.lucene.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
at org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
at org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
at org.apache.lucene.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:375)
at com.carrotsearch.randomizedtesting.ThreadLeakControl.lambda$forkTimeoutingTask$0(ThreadLeakControl.java:831)
at java.lang.Thread.run(Thread.java:834)
``` | https://github.com/elastic/elasticsearch/issues/79300 | https://github.com/elastic/elasticsearch/pull/79428 | 5b7d3b4c9c50cceb51b99a0e5e44d9c1a666bb40 | ddff83e15db7ad72e21a15fbec66892f733e7ed2 | 2021-10-15T22:29:14Z | java | 2021-10-20T10:28:47Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,270 | ["x-pack/plugin/ml/qa/native-multi-node-tests/src/javaRestTest/java/org/elasticsearch/xpack/ml/integration/RunDataFrameAnalyticsIT.java", "x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/MachineLearning.java", "x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/MlAssignmentNotifier.java", "x-pack/plugin/ml/src/test/java/org/elasticsearch/xpack/ml/MlAssignmentNotifierTests.java"] | [ML] Make the job notifications related to node assignment more user friendly | There are a number of problems with job notifications related to node assignment:
1. They contain low level printouts of the `DiscoveryNode` class, which includes low level detail that's unsuited to UI messages.
2. Assignment failure messages are usually transitory, but are warnings, so result in a yellow triangle next to the job in the UI for 24 hours afterwards.
3. Assignment failure messages are very verbose, and you can get several in quick succession before a successful assignment, which causes them to dominate the job messages tab in the UI.
A potential improvement is as follows:
1. Instead of creating notifications for assignment failures, notify on unassignment. These notifications should be at the info level rather than warning, because usually the job will get assigned to a new node very soon.
2. In both unassignment and successful assignment notifications, just include the node name, not the node ID, IP address or other low level details. The full printout of the `DiscoveryNode` class can still go in the debug log, just not in the user-facing job notification.
This would move from what we have today, which is like:
* INFO: Job assigned to node A, ID 1234567, IP 1.2.3.4
\<days later\>
* WARN: Job could not be assigned because memory requirements are stale
* WARN: Job could not be assigned because indices are not ready
* WARN: Job could not be assigned to node B because x, could not be assigned to node C because y, could not be assigned to node D because z
* INFO: Job assigned to node B, ID 7654321, IP 5.6.7.8
To something less worrying like:
* INFO: Job assigned to node A
\<days later\>
* INFO: Job unassigned from node A
* INFO: Job assigned to node B | https://github.com/elastic/elasticsearch/issues/79270 | https://github.com/elastic/elasticsearch/pull/79578 | 9b92926ed961f73ce95a185629c577dbca43fc14 | 947e3656cccf34a0ee892fdce05b840c63c06ae6 | 2021-10-15T15:26:07Z | java | 2021-10-21T15:43:32Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,249 | ["server/src/test/java/org/elasticsearch/index/shard/ShardPathTests.java"] | [CI] ShardPathTests testShardPathSelection failing | First time seen this and it doesn't reproduce locally.
New test @grcevski ?
**Build scan:**
https://gradle-enterprise.elastic.co/s/gngncnf4clerq/tests/:server:test/org.elasticsearch.index.shard.ShardPathTests/testShardPathSelection
**Reproduction line:**
`./gradlew ':server:test' --tests "org.elasticsearch.index.shard.ShardPathTests.testShardPathSelection" -Dtests.seed=B20B43CD7F805F0C -Dtests.locale=ru-RU -Dtests.timezone=America/Aruba -Druntime.java=8`
**Applicable branches:**
7.x
**Reproduces locally?:**
No
**Failure history:**
https://gradle-enterprise.elastic.co/scans/tests?tests.container=org.elasticsearch.index.shard.ShardPathTests&tests.test=testShardPathSelection
**Failure excerpt:**
```
java.lang.AssertionError: expected:</var/lib/jenkins/workspace/elastic+elasticsearch+7.x+multijob+platform-support-unix/os/ubuntu-16.04&&immutable/server/build/testrun/test/temp/org.elasticsearch.index.shard.ShardPathTests_B20B43CD7F805F0C-001/tempDir-038/nodes/0/indices/0xDEADBEEF/0> but was:</var/lib/jenkins/workspace/elastic+elasticsearch+7.x+multijob+platform-support-unix/os/ubuntu-16.04&&immutable/server/build/testrun/test/temp/org.elasticsearch.index.shard.ShardPathTests_B20B43CD7F805F0C-001/tempDir-039/nodes/0/indices/0xDEADBEEF/0>
at __randomizedtesting.SeedInfo.seed([B20B43CD7F805F0C:EA4AFA8B58878A71]:0)
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:118)
at org.junit.Assert.assertEquals(Assert.java:144)
at org.elasticsearch.index.shard.ShardPathTests.testShardPathSelection(ShardPathTests.java:202)
at sun.reflect.NativeMethodAccessorImpl.invoke0(NativeMethodAccessorImpl.java:-2)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1750)
at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:938)
at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:974)
at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:988)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at org.apache.lucene.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:49)
at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:45)
at org.apache.lucene.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:48)
at org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:64)
at org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:47)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:368)
at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:817)
at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:468)
at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:947)
at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:832)
at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:883)
at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:894)
at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:45)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at org.apache.lucene.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:41)
at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at org.apache.lucene.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
at org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:47)
at org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:64)
at org.apache.lucene.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:54)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:368)
at java.lang.Thread.run(Thread.java:748)
``` | https://github.com/elastic/elasticsearch/issues/79249 | https://github.com/elastic/elasticsearch/pull/79393 | dc071ae524e3bd5736e90eb56e4872200f483138 | 64a946a82d608008ef652cb65013e56b457f4120 | 2021-10-15T13:35:15Z | java | 2021-10-18T22:54:10Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,207 | ["docs/changelog/85393.yaml", "x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/authz/store/RoleDescriptorStore.java", "x-pack/plugin/security/src/test/java/org/elasticsearch/xpack/security/authz/store/CompositeRolesStoreTests.java"] | Warn when a role is skipped due to licensing limitations | When resolving a user's roles, if there are any roles that depend on DLS/FLS, and that is not permitted by the current license, we skip them.
https://github.com/elastic/elasticsearch/blob/f435488484ec844962d49371b8917c135fe6f714/x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/authz/store/CompositeRolesStore.java#L188-L192
However, we do not perform any logging in this circumstance, and rely on the user discovering that their roles are missing.
We should
1. Add a `WARN` log message
2. Add a Warning header
when this occurs. | https://github.com/elastic/elasticsearch/issues/79207 | https://github.com/elastic/elasticsearch/pull/85393 | 8eb920a4212806de48bc3ca340d4a3b58fc0c258 | 83d01f49a793193e077b23162ac1dc274743c809 | 2021-10-14T23:54:02Z | java | 2022-04-01T13:17:04Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,187 | ["docs/reference/cluster/nodes-info.asciidoc", "rest-api-spec/src/main/resources/rest-api-spec/api/nodes.info.json", "rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/nodes.info/50_metrics.yml", "server/src/main/java/org/elasticsearch/action/admin/cluster/node/info/NodesInfoRequest.java", "server/src/main/java/org/elasticsearch/rest/action/admin/cluster/RestNodesInfoAction.java"] | Support something like GET _nodes/<node_selector>/none | Sometimes one needs to get just the identity of some node and doesn't need anything else. For example, if I want to get the name of the currently elected master node I might use:
```
GET _nodes/_master
```
And then I can pick the `"name"` out of the response body. Of course, this returns _far_ more information than I need because of all the metrics, but I can pare it down by picking some arbitrary metric filter:
```
GET _nodes/_master/process
```
But this feels a bit awkward because it does not convey my intent. I don't actually care about the process metrics, so someone reading my code might be confused as to why I'm doing it.
Incidentally, it turns out that you can legally put _whatever you want_ in the metric filter, and if it doesn't match anything, you will get zero metrics (but still get the node identity information). So any of these, for example, seem to work:
```
GET _nodes/_master/none
GET _nodes/_master/foobar
GET _nodes/_master/aManWearingAParticularlyFashionableHat
```
This is probably abuse of an undocumented, accidental feature. It would be great if there was some official way to ask for just node identity information. Perhaps:
```
GET _nodes/_master/_none
``` | https://github.com/elastic/elasticsearch/issues/79187 | https://github.com/elastic/elasticsearch/pull/79223 | dbb1e49e568920239a911e5e2d8264896980555b | 5767d51c2b960d6a9fc0433f4a78a54272114c40 | 2021-10-14T19:01:19Z | java | 2021-10-15T14:57:52Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,186 | ["server/src/internalClusterTest/java/org/elasticsearch/indices/recovery/SnapshotBasedIndexRecoveryIT.java"] | [CI] SnapshotBasedIndexRecoveryIT testRecoveryIsCancelledAfterDeletingTheIndex failing | **Build scan:**
https://gradle-enterprise.elastic.co/s/alnuz22ekab5s/tests/:server:internalClusterTest/org.elasticsearch.indices.recovery.SnapshotBasedIndexRecoveryIT/testRecoveryIsCancelledAfterDeletingTheIndex
**Reproduction line:**
`./gradlew ':server:internalClusterTest' --tests "org.elasticsearch.indices.recovery.SnapshotBasedIndexRecoveryIT.testRecoveryIsCancelledAfterDeletingTheIndex" -Dtests.seed=6EC84510B53C7078 -Dtests.locale=vi-VN -Dtests.timezone=America/Indiana/Vevay -Druntime.java=11`
**Applicable branches:**
master, 7.x
**Reproduces locally?:**
Didn't try
**Failure history:**
https://gradle-enterprise.elastic.co/scans/tests?tests.container=org.elasticsearch.indices.recovery.SnapshotBasedIndexRecoveryIT&tests.test=testRecoveryIsCancelledAfterDeletingTheIndex
**Failure excerpt:**
```
java.lang.Exception: Test abandoned because suite timeout was reached.
at __randomizedtesting.SeedInfo.seed([6EC84510B53C7078]:0)
``` | https://github.com/elastic/elasticsearch/issues/79186 | https://github.com/elastic/elasticsearch/pull/79269 | e59443f7a316db04eafb610e26938a754c583a93 | 510f54a1ffa0dec82d3b2157a807372b28b75ad8 | 2021-10-14T19:00:07Z | java | 2021-10-16T10:43:39Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,128 | ["x-pack/plugin/spatial/src/main/java/org/elasticsearch/xpack/spatial/search/aggregations/GeoLineAggregator.java", "x-pack/plugin/spatial/src/yamlRestTest/resources/rest-api-spec/test/60_geo_line.yml"] | Geoline aggregator might throw an AIOOBE if parent aggregation emits empty buckets | to reproduce the issue:
create two indexes:
```
PUT /test1
{
"mappings": {
"properties": {
"location": {
"type": "geo_point"
},
"date": {
"type": "date"
},
"entity": {
"type": "keyword"
}
}
}
}
PUT /test2
{
"mappings": {
"properties": {
"location": {
"type": "geo_point"
},
"date": {
"type": "date"
},
"entity": {
"type": "keyword"
}
}
}
}
```
Insert some data:
```
POST /_bulk
{ "index" : { "_id" : "1", "_index" : "test2" } }
{ "date" : "2020-01-01T01:00:00.0Z", "entity" : "e1", "location" : { "lat" : 50.3, "lon" : 0.13 } }
{ "index" : { "_id" : "1", "_index" : "test2" } }
{ "date" : "2020-01-01T01:00:00.0Z", "entity" : "e2", "location" : { "lat" : 50.3, "lon" : 0.13 } }
```
execute the following query:
```
GET test1,test2/_search
{
"size": 0,
"aggs": {
"tracks": {
"filters": {
"filters": {
"1": {
"term": {
"entity": "e1"
}
},
"2": {
"term": {
"entity": "e2"
}
}
}
},
"aggs": {
"path": {
"geo_line": {
"point": {
"field": "location"
},
"sort": {
"field": "date"
}
}
}
}
}
}
}
```
you would see something like:
```
{
"shard" : 0,
"index" : "test1",
"node" : "oOjCv2xpQmm-rWmAo0mcZg",
"reason" : {
"type" : "array_index_out_of_bounds_exception",
"reason" : "Index 1 out of bounds for length 1"
}
}
``` | https://github.com/elastic/elasticsearch/issues/79128 | https://github.com/elastic/elasticsearch/pull/79129 | 7ad1424612c08ac148a8b8ae32b3f486559ac797 | 5474d4cdf85f057cd8243512a21fe686a1927ac9 | 2021-10-14T08:53:10Z | java | 2021-10-19T05:17:11Z |
closed | electron/electron | https://github.com/electron/electron | 40,660 | ["shell/browser/ui/inspectable_web_contents.cc", "spec/api-web-contents-spec.ts"] | [Bug]: Can not open devtools after closing | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
28.0.0-beta.10
### What operating system are you using?
Windows
### Operating System Version
10.0.19042
### What arch are you using?
x64
### Last Known Working Electron version
_No response_
### Expected Behavior
Devtools should open
### Actual Behavior
After opening devtools and closing them, it is not possible to reopen the devtools
### Testcase Gist URL
https://gist.github.com/t57ser/9ca91183cb53fd45eb6c73c42f92903e
### Additional Information
_No response_ | https://github.com/electron/electron/issues/40660 | https://github.com/electron/electron/pull/40666 | 344b7f0d068ae7d20fdebafc2ebadcdc0b4f7f68 | 3609fc7402881b1d51f6c56249506d5dd3fcbe93 | 2023-11-30T12:43:35Z | c++ | 2023-12-01T19:37:52Z |
closed | electron/electron | https://github.com/electron/electron | 40,457 | ["docs/api/session.md"] | [Bug]: Wrong types for HidDeviceRemovedDetails and HidDeviceAddedDetails | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
27.0.3
### What operating system are you using?
macOS
### Operating System Version
14.1
### What arch are you using?
arm64 (including Apple Silicon)
### Last Known Working Electron version
_No response_
### Expected Behavior
```typescript
interface HidDeviceAddedDetails {
device: HIDDevice;
frame: WebFrameMain;
}
interface HidDeviceRemovedDetails {
device: HIDDevice;
frame: WebFrameMain;
}
```
### Actual Behavior
```typescript
interface HidDeviceAddedDetails {
device: HIDDevice[];
frame: WebFrameMain;
}
interface HidDeviceRemovedDetails {
device: HIDDevice[];
frame: WebFrameMain;
}
```
### Testcase Gist URL
_No response_
### Additional Information
Currently provided typings for electron assume that device will be an array of HIDDevice while the actual binary provides with only instance. | https://github.com/electron/electron/issues/40457 | https://github.com/electron/electron/pull/40462 | e8d9294d9d51ca0e2eaae22d4f57561e79a08833 | 1ba535296efe87ecf0362759d2fab29b2af8b755 | 2023-11-06T14:18:02Z | c++ | 2023-11-07T22:26:35Z |
closed | electron/electron | https://github.com/electron/electron | 40,439 | ["build/args/all.gn", "filenames.gni", "shell/browser/electron_browser_client.cc", "shell/browser/electron_browser_client.h", "shell/browser/electron_browser_context.cc", "shell/browser/extensions/electron_extension_message_filter.cc", "shell/browser/extensions/electron_extension_message_filter.h"] | Convert legacy IPC calls in extensions code to use mojo | https://chromium-review.googlesource.com/c/chromium/src/+/4995136 turned on the build flag to use the new mojo IPC pipe for messaging in extensions. In #40418 we turned this off because we have not converted our extensions code to use mojo. It appears that in chromium the follow CLs were landed to use mojo in extensions:
- 4947890: [extensions] Convert Extension Messaging APIs over to mojo | https://chromium-review.googlesource.com/c/chromium/src/+/4947890
- 4950041: [extensions] Port Event Acks to mojom | https://chromium-review.googlesource.com/c/chromium/src/+/4950041
- 4902564: [extensions] Move WakeEventPage to mojom::RendererHost | https://chromium-review.googlesource.com/c/chromium/src/+/4902564
- 4956841: [extensions] Port GetMessageBundle over to mojom | https://chromium-review.googlesource.com/c/chromium/src/+/4956841
Once these changes have landed, the following flag override in build/args/all.gn should be removed:
`enable_extensions_legacy_ipc = true` | https://github.com/electron/electron/issues/40439 | https://github.com/electron/electron/pull/40511 | 088affd4a4311e03b8ed400cdf5d82f1db2125a4 | 371bca69b69351dc47d4b4dcfdf9a626f43b3b51 | 2023-11-02T18:50:40Z | c++ | 2023-11-15T14:30:47Z |
closed | electron/electron | https://github.com/electron/electron | 40,391 | ["shell/browser/web_view_guest_delegate.cc"] | [Bug]: App crashes when unloading webview before it finished rendering since Electron 26.1.0 | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
27.0.2
### What operating system are you using?
Windows
### Operating System Version
Windows 10/11
### What arch are you using?
x64
### Last Known Working Electron version
16.0.0
### Expected Behavior
The application should just move on and not crash.
### Actual Behavior
The application closes without any error message shown or logged.
### Testcase Gist URL
https://github.com/wartab/electron-bug
### Additional Information
I previously reported this here, but another customer of ours had this issue happen on a fast PC and I could reproduce it on mine as well.
https://github.com/electron/electron/issues/40288
I can't reproduce it in Electron Fiddle, but the following repository reproduces the issue.
It attempts to load a webview with inline HTML in the src attribute. That HTML is > 3 MB large with inline images. Electron never manages to render this webview, but when unloading the webview, the app crashes.
Simply removing the webview with removeChild() didn't crash the application, so my minimum reproduction is a bit closer to what we actually do. It is in an Angular application. The reproduction contains the app already built in `dist-angular`.
To reproduce:
`npm i`
Optionally: `ng build --base-href .`
`npm run-script build-electron` | https://github.com/electron/electron/issues/40391 | https://github.com/electron/electron/pull/40400 | f501dabc8064fa441e959d2203c706801aa21a22 | 5b18d90597a4a9fd837125786ac29af2151d6931 | 2023-10-31T17:01:30Z | c++ | 2023-11-03T14:36:25Z |
closed | electron/electron | https://github.com/electron/electron | 40,354 | ["shell/browser/web_contents_zoom_controller.cc", "spec/fixtures/pages/webview-zoom-change-persist-host.html", "spec/node-spec.ts", "spec/webview-spec.ts"] | [Bug]: Zoom controller doesn't persist when changing webviews | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
27.0.2
### What operating system are you using?
Windows
### Operating System Version
Windows 11 Pro 22H2 - Build 22621.2428
### What arch are you using?
x64
### Last Known Working Electron version
26.0.0
### Expected Behavior
When switching between different Webviews the Zoom scale persists after going back to the initial webview.
### Actual Behavior
[Ferdium](https://github.com/ferdium/ferdium-app) currently uses multiple Webviews for each service it renders. When switching between Webviews the Zoom scale is not persistent (when switching away the zoom resets - this is visible for some milliseconds before changing to the other webview).
### Testcase Gist URL
_No response_
### Additional Information
I'm logging this issue in Electron given that this was not present in past versions of Electron, but only after `26.0.0` (I'm blaming `26.1.0` as the version who started to cause issues). After some investigation it seems like the PR that caused this unwanted behaviour is: https://github.com/electron/electron/pull/39495 .
Is it possible for you to search and revert this unwanted breakage? We would really need this to be fix because we have several users with this accessibility needs.
Thank you very much in advance!
PS: If this is not the proper way to open an issue on Electron please let me know. | https://github.com/electron/electron/issues/40354 | https://github.com/electron/electron/pull/40650 | 66b4b216468feab79c7527295f2485067ea2cf15 | 10a165a9ff731137b679a4ef3a9e3d18bcdfd514 | 2023-10-27T12:40:22Z | c++ | 2023-12-04T15:39:20Z |
closed | electron/electron | https://github.com/electron/electron | 40,342 | ["shell/browser/api/electron_api_web_contents.cc", "shell/browser/api/electron_api_web_contents_mac.mm", "spec/chromium-spec.ts", "spec/fixtures/pages/modal.html", "spec/webview-spec.ts"] | [Bug]: Navigator.keyboard.lock() icw requestFullscreen does not change behavior to 'Press and Hold Escape' | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
27.0.2
### What operating system are you using?
Windows
### Operating System Version
Windows 10 Pro version 22H2
### What arch are you using?
x64
### Last Known Working Electron version
_No response_
### Expected Behavior
When an element is brought to fullscreen with:
[elem.requestFullscreen()](https://developer.mozilla.org/en-US/docs/Web/API/Element/requestFullscreen)
and an event listener exists like:
```
document.addEventListener('fullscreenchange', async () => {
const nav: any = navigator;
const elem = document.getElementById('app');
if (elem) {
await nav.keyboard.lock(['Escape']);
return;
}
nav.keyboard.unlock();
});
```
I would expect that the behavior of the Esc key changes, where I would now need to press and hold Esc for a few seconds before fullscreen is actually exited. As described here: [https://developer.chrome.com/blog/better-full-screen-mode/](https://developer.chrome.com/blog/better-full-screen-mode/)
I imagine the same behavior change should hold for when [requestPointerLock()](https://developer.mozilla.org/en-US/docs/Web/API/Element/requestPointerLock) is used.
### Actual Behavior
When the Esc key is pressed after bringing an element to fullscreen, it ALWAYS exits fullscreen immediately, even when used in combination with [keyboard.lock() API](https://developer.mozilla.org/en-US/docs/Web/API/Keyboard/lock).
### Testcase Gist URL
_No response_
### Additional Information
_No response_ | https://github.com/electron/electron/issues/40342 | https://github.com/electron/electron/pull/40365 | 4b1c31e4dbd00cd58e159cbc2ab41de3b1ce3a86 | fcdd5cba71b82c13c4f64a3e529dea91ed72d23c | 2023-10-26T09:51:51Z | c++ | 2023-10-31T15:59:39Z |
closed | electron/electron | https://github.com/electron/electron | 40,284 | ["shell/browser/ui/file_dialog_mac.mm"] | [Bug]: Unable to change file format in the openFile Dialog on Mac | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
27.0.0
### What operating system are you using?
macOS
### Operating System Version
macOS Ventura 13.5.2
### What arch are you using?
x64
### Last Known Working Electron version
27.0.0-nightly-20230803
### Expected Behavior
Can change the format:
<img width="649" alt="Screenshot 2023-10-20 at 12 53 48" src="https://github.com/electron/electron/assets/86096075/48d7faa9-6d8a-4360-9d40-bc8f68f76e2d">
### Actual Behavior
Can't change the format:
<img width="645" alt="Screenshot 2023-10-20 at 12 54 37" src="https://github.com/electron/electron/assets/86096075/3d8af0b1-0f40-4336-8325-37ba8b4f0282">
### Testcase Gist URL
_No response_
### Additional Information
Test code
```
// Display native system dialogs for opening and saving files, alerting, etc.
//
// For more info, see:
// https://electronjs.org/docs/api/dialog
const { app, BrowserWindow, dialog } = require('electron')
app.whenReady().then(() => {
const mainWindow = new BrowserWindow({ height: 600, width: 600 })
// Show an "Open File" dialog and attempt to open
// the chosen file in our window.
dialog.showOpenDialog({
properties: ['openFile'],
filters: [
{ name: 'Text files', extensions: ['txt'] },
{ name: 'All files', extensions: ['*']}
],
title: 'hello',
buttonLabel: 'show options',
}).then(result => {
if (result.canceled) {
console.log('Dialog was canceled')
} else {
const file = result.filePaths[0]
mainWindow.loadURL(`file://${file}`)
}
}).catch(err => {
console.log(err)
})
})
``` | https://github.com/electron/electron/issues/40284 | https://github.com/electron/electron/pull/40308 | 621b3ba897031319c214246ef6291ad1d3523f07 | 3f92a983156daa4e4c4d8ab7c7df90d861da2374 | 2023-10-20T04:55:11Z | c++ | 2023-10-26T15:40:02Z |
closed | electron/electron | https://github.com/electron/electron | 40,211 | ["lib/asar/fs-wrapper.ts", "spec/asar-spec.ts"] | [Bug]: Electron 28 breaks `import` of transitive dependencies inside ES modules | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
28.0.0-alpha.2
### What operating system are you using?
Windows
### Operating System Version
Windows 10
### What arch are you using?
x64
### Last Known Working Electron version
27.0.0
### Expected Behavior
Importing an ESM dependency which imports some other dependency (ESM or CJS) should work from inside `app.asar`
### Actual Behavior
The module lookup starts at ```node_modules/<directory where the dependency's `main` file lives>/node_modules```, doesn't find the transitive dependency there and then crashes, never reaching the top-level `node_modules` which is where the transitive dependency actually lives:
### Testcase Gist URL
_No response_
### Additional Information
I've run into this using [this repro](https://github.com/electron/asar/issues/249#issuecomment-1434998313), where the ESM dependency `got` is imported causing the app to crash when looking for the transitive ESM dependency `@sindresorhus/is`. I've put together a minimal reproduction with two local dependencies, which should make it easier to test different variables: https://github.com/erikian/esm-asar-demo
Note that this problem seems to be limited to dependencies inside `node_modules`, i.e. ESM imports across project files work fine:
```ts
// src/main.mjs
import printStuff from './printStuff.js'
printStuff('it works!')
// src/printStuff.js
import logger from './logger.js'
export default function printStuff(...stuff) {
logger(...stuff)
}
// src/logger.js
export default function logger(...args) {
console.log(...args)
}
```
Some findings:
- `const { default: printStuff } = await import('my-esm-dependency')` doesn't work out of the box, but it does work when setting `process.noAsar = true` before importing. Moving the import into the `app.whenReady` callback also doesn't work
- `import printStuff from 'my-esm-dependency'` doesn't work at all, not even with `process.noAsar = true`
- This is not limited to ESM entrypoints. I also get the same errors on the `commonjs-entrypoint` branch, and changing to Electron 27.0.0 fixes the problem. | https://github.com/electron/electron/issues/40211 | https://github.com/electron/electron/pull/40221 | f7b1c75c72a8dcab4157408f92bd3771606d8029 | b6ec19a582579c8f7972a1c140b9404e8b2ccd87 | 2023-10-16T01:14:29Z | c++ | 2023-10-16T16:35:25Z |
closed | electron/electron | https://github.com/electron/electron | 40,133 | ["docs/api/notification.md", "shell/browser/api/electron_api_notification.cc", "shell/browser/notifications/notification.cc", "shell/browser/notifications/notification.h", "shell/browser/notifications/win/windows_toast_notification.cc", "shell/browser/notifications/win/windows_toast_notification.h"] | [Bug]: notification.close() does not work in Windows after the popup has disappeared | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
26.3.0, 27.0.0
### What operating system are you using?
Windows
### Operating System Version
Windows 11 22H2 (22621.2361)
### What arch are you using?
x64
### Last Known Working Electron version
11.x
### Expected Behavior
1. Create Notification with `Electron.Notification`.
2. Wait for the notification popup to disappear and be logged to the Windows notification center.
3. Call `Electron.Notification.close()` on it
The notification is removed from the Windows notification center and the "unread" count in the taskbar decreases
### Actual Behavior
The notification remains in the Windows notification center and the unread count does not change.
### Testcase Gist URL
https://gist.github.com/474863b1c8a398ee00a74950596ab0c3
### Additional Information
Duplicated of #29557, #32260 (These issues are marked as "stale", but still occurred) | https://github.com/electron/electron/issues/40133 | https://github.com/electron/electron/pull/40197 | 73a42d0b7bff9b381349c8c32a46623d63471572 | 666907d50d2d62e31e1c3e7329f45e8350fe73cd | 2023-10-07T04:31:01Z | c++ | 2023-10-17T23:33:00Z |
closed | electron/electron | https://github.com/electron/electron | 40,097 | ["patches/webrtc/.patches", "patches/webrtc/pipewire_capturer_make_restore_tokens_re-usable_more_than_one_time.patch"] | [Bug]: desktopCapturer source IDs are valid for a single use on Wayland | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
27.0.0-beta.9
### What operating system are you using?
Other Linux
### Operating System Version
Fedora Workstation 39
### What arch are you using?
x64
### Last Known Working Electron version
_No response_
### Expected Behavior
1. Get a source ID from desktopCapturer
2. Display the stream using getUserMedia
3. Stop the stream
4. Display the stream again using getUserMedia
### Actual Behavior
XDG desktop portal permission dialog appears again
### Testcase Gist URL
https://gist.github.com/aiddya/cfd89d040661e0553425e4203ce4512b
### Additional Information
The fiddle has a timeout function that displays the stream after 10 seconds. So the steps to test using the fiddle boil down to: select a source, preview it, stop it and then wait 10 seconds. | https://github.com/electron/electron/issues/40097 | https://github.com/electron/electron/pull/40098 | 7ab2a821669d4ce603a118b904f68e342ef3d807 | 3c31246343b3b4e9457d4672eebe46d64c673d0a | 2023-10-05T02:22:27Z | c++ | 2023-10-12T11:17:27Z |
closed | electron/electron | https://github.com/electron/electron | 40,060 | ["patches/node/.patches", "patches/node/lib_fix_broadcastchannel_initialization_location.patch"] | [Bug]: BroadcastChannel support broken in version 26 | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
26.2.4
### What operating system are you using?
Windows
### Operating System Version
Windows 10
### What arch are you using?
x64
### Last Known Working Electron version
25.8.4
### Expected Behavior
Please refer to original issue for the same bug on version 23 --> [https://github.com/electron/electron/issues/37417](37417)
I had the same issue for version 23.1.4. Then, it was fixed in 23.2.0.
[37644](https://github.com/electron/electron/issues/37644)
Now I updated electron version to 26.2.4 which reproduces the same issue. BroadcastChannel does not work in this latest version. As mentioned in this issue above, BrodacastChannel seems to be initialized in `bootstrap/node`.
In working 23.2.0 version, even when I search for `'BrodacastChannel '`, there is no result.
Why is BroadcastChannel is initialized in bootstrap/node in 26.2.4? Any ideas?
PS: BrowserWindow is initialized as `contextIsolation: false`.
Testing for the newest versions of each major version:
* 23.3.13 working 👌
* 24.8.5 working 👌
* 25.8.4 working 👌
* 26.0.0 not working 😞
* 26.2.4 not working 😞
### Actual Behavior
BrowserChannels do not communicate between BrowserWindows when contextIsolation is false.
### Testcase Gist URL
Please refer to the original issue [https://github.com/electron/electron/issues/37417](37417)
### Additional Information
_No response_ | https://github.com/electron/electron/issues/40060 | https://github.com/electron/electron/pull/40049 | d301616f6087f306ac7bc53e5b6803f325255bd3 | 93bcb30c3e84694d9df0d59fb15bd5bdb4617b2a | 2023-10-02T07:45:57Z | c++ | 2023-10-02T08:57:09Z |
closed | electron/electron | https://github.com/electron/electron | 40,041 | ["patches/chromium/.patches", "patches/chromium/ensure_messageports_get_gced_when_not_referenced.patch", "spec/api-ipc-spec.ts"] | [Bug]: Message ports don't close after garbage collection | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
28.0.0 / main
### What operating system are you using?
macOS
### Operating System Version
13.5
### What arch are you using?
arm64 (including Apple Silicon)
### Last Known Working Electron version
Prior to this CL: https://github.com/electron/electron/pull/39944
### Expected Behavior
Message ports will be automatically closed after they are garbage collected
### Actual Behavior
Message ports do not automatically closed after they are garbage collected, and won't close unless close is explicitly called
### Testcase Gist URL
https://gist.github.com/VerteDinde/8caf3292beb8cd8168e776d194f2bc64
### Additional Information
Steps to Repro:
1. Load the above gist
2. Let garbage collection occur, or simulate garbage collection with "Collect Garbage"
3. Take a heap snapshot and search for "message port".
Upstream Chromium bug filed here: https://bugs.chromium.org/p/chromium/issues/detail?id=1487835
This can also be reproduced in Chrome Canary by doing the following:
1. Load Canary, open DevTools
2. Run the following in console:
```
(function () {
const { port2 } = new MessageChannel();
port2.start();
})()
```
3. Simulate garbage collection with "Collect Garbage"
4. Take a heap snapshot and search for "message port" | https://github.com/electron/electron/issues/40041 | https://github.com/electron/electron/pull/40189 | 5d6023ae0dfa289b8ce1427722b0a8c0ab24e648 | bbd2236bdd4fda6ab702c67fa9a5cec13cc6df01 | 2023-09-29T02:54:28Z | c++ | 2023-10-13T20:09:28Z |
closed | electron/electron | https://github.com/electron/electron | 40,039 | ["shell/browser/native_window.cc"] | [Bug]: BrowserWindow vibrancy doesn't apply without transparency | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
27.0.0-beta.2
### What operating system are you using?
macOS
### Operating System Version
macOS Ventura 13.5.2
### What arch are you using?
arm64 (including Apple Silicon)
### Last Known Working Electron version
27.0.0-beta.1
### Expected Behavior
Including `vibrancy: 'titlebar'` in BrowserWindow constructor options results in a window with background vibrancy.
### Actual Behavior
A white background is displayed without window vibrancy.
### Testcase Gist URL
https://gist.github.com/df665de6732858c3536198cef517fae9
### Additional Information
Regression from https://github.com/electron/electron/pull/39708 | https://github.com/electron/electron/issues/40039 | https://github.com/electron/electron/pull/40109 | a55c163db02a3092226ba20731b08292404561d4 | cff50ac65a9c6d4f53aa74570ea42859466c4469 | 2023-09-28T16:54:55Z | c++ | 2023-10-06T18:57:26Z |
closed | electron/electron | https://github.com/electron/electron | 40,031 | ["lib/utility/init.ts", "spec/api-utility-process-spec.ts", "spec/fixtures/api/utility-process/esm.mjs", "spec/fixtures/api/utility-process/exception.mjs"] | [Feature Request]: Support forking ES Modules (.mjs) in electron's utilityProcess | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a feature request that matches the one I want to file, without success.
### Problem Description
As of [#21457], the ES Module has now supported in electron-nightly 28.0. This is great, but still I get an error when trying to fork the ES Module in electron-nightly 28.0's UtilityProcess.
Code example:
```
this.process = utilityProcess.fork('<directory_path_to_esm>/name.mjs', args, {
serviceName,
env,
execArgv,
allowLoadingUnsignedLibraries,
forceAllocationsToV8Sandbox,
stdio
} as ForkOptions);
```
Errors generated:
```
Error [ERR_REQUIRE_ESM]: require() of ES Module '<directory_path_to_esm>/name.mjs' not supported.
Instead change the require of '<directory_path_to_esm>/name.mjs' to a dynamic import() which is available in all CommonJS modules.
at f._load (node:electron/js2c/asar_bundle:2:13330)
at node:electron/js2c/utility_init:2:5946
at node:electron/js2c/utility_init:2:5961
at node:electron/js2c/utility_init:2:5965
at f._load (node:electron/js2c/asar_bundle:2:13330) {
code: 'ERR_REQUIRE_ESM'
}
```
### Proposed Solution
- Request ability to UtilityProcess of forking the ES Module (.mjs) in electron.
This ability leads to increasing the value of using Electron, so that we can dynamically load arbitrary extension code in the Node.js process without having to rely on the AMD loader especially for simplicity.
### Alternatives Considered
None
### Additional Information
_No response_ | https://github.com/electron/electron/issues/40031 | https://github.com/electron/electron/pull/40047 | d6c8ff2e7050f30dffd784915bcbd2a9f993cdb2 | 371e83a8d2390c63bc9171c0b3949b460ab9ad17 | 2023-09-28T11:40:45Z | c++ | 2023-09-29T21:38:37Z |
closed | electron/electron | https://github.com/electron/electron | 40,002 | ["patches/node/.patches", "patches/node/fix_handle_possible_disabled_sharedarraybuffer.patch"] | [Bug]: SubtleCrypto.importKey crash with "Cannot read properties of undefined" on Electron 27 Beta | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
27.0.0-beta.7
### What operating system are you using?
Other Linux
### Operating System Version
Arch Linux: Linux jabba 6.4.12-arch1-1 #1 SMP PREEMPT_DYNAMIC Thu, 24 Aug 2023 00:38:14 +0000 x86_64 GNU/Linux
### What arch are you using?
x64
### Last Known Working Electron version
26.2.2
### Expected Behavior
Web Crypto APIs should work in the worker.
### Actual Behavior
The call to `webcrypto.subtle.importKey(...)` fails in the worker on Electron 27.0.0-beta.7, but not on 26.2.2.
```
Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'prototype')
at isSharedArrayBuffer (node:internal/crypto/webidl:187:57)
at Object.BufferSource (node:internal/crypto/webidl:208:9)
at SubtleCrypto.importKey (node:internal/crypto/webcrypto:585:36)
at worker.js:6:18
```
### Testcase Gist URL
https://gist.github.com/threema-danilo/a53a94800e258a0c2a6adb67ac7bfa72
### Additional Information
Check out the fiddle. Start it and open the debug console. On Electron 26.2.2, it prints "AES key was loaded". On Electron 27.0.0-beta.7, it prints the exception. | https://github.com/electron/electron/issues/40002 | https://github.com/electron/electron/pull/40070 | b0590b6ee874fbeac49bb5615525d145835eb64f | b3a1c6d13cfad8b0519dd7957c2f2db10acf98e8 | 2023-09-27T14:30:16Z | c++ | 2023-10-05T08:46:53Z |
closed | electron/electron | https://github.com/electron/electron | 39,993 | ["shell/browser/ui/views/inspectable_web_contents_view_views.cc"] | [Bug]: BrowserView.setBounds is not appliead immediately on first calls. | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
28, 27, 26 and older
### What operating system are you using?
Windows
### Operating System Version
Windows 10
### What arch are you using?
x64
### Last Known Working Electron version
Probably never
### Expected Behavior
setBounds applied immediately, BrowserView painted in new position.
### Actual Behavior
setBounds sets the data but view is still being painted with old bounds even though getBounds returns new bounds.
### Testcase Gist URL
https://gist.github.com/2e8b6adb97bf44893828212a79b06b22
### Additional Information
Setting same bounds twice will make BrowserView paint correctly. This is because same calling setBounds with same rect immediately triggers layout call on Views (https://source.chromium.org/chromium/chromium/src/+/ba15ffd71335c75897f4bd8501b3c8ed00a284da:ui/views/view.cc;l=386), while different bounds will make it schedule InvalidateLayout call, which is propagated to parent and view is marked as needing layout, expecting to receive it from parent on next layout call . The problem is that BrowserView's view is added as child of InspectableWebContentsViews which does not call setBounds (which triggers layout) on all of it's children when doing it's layout, so it skips propagating Layout call to its children BrowserViews views, even though those were marked as needing layout. | https://github.com/electron/electron/issues/39993 | https://github.com/electron/electron/pull/39994 | 43a646ed8592f31e0c8fa08b684dac329b7bf976 | 94585f5889b83d4961a57619aab4f1f041f5b857 | 2023-09-27T12:30:31Z | c++ | 2023-09-28T15:17:21Z |
closed | electron/electron | https://github.com/electron/electron | 39,991 | ["shell/browser/ui/views/inspectable_web_contents_view_views.cc"] | [Bug]: After minimizing the devtool window and opening it again, the devtool window cannot be found | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
26.1.0
### What operating system are you using?
Windows
### Operating System Version
win 11
### What arch are you using?
x64
### Last Known Working Electron version
_No response_
### Expected Behavior
After minimizing the devtool window, open it again and you can see the window normally
### Actual Behavior
After minimizing the devtool window and opening it again, the devtool window cannot be found
### Testcase Gist URL
https://gist.github.com/c985de2d95ffedb47bc966edaf3bfe8c
### Additional Information
https://github.com/electron/electron/assets/71307878/2b8bc4f7-e33a-415c-8033-76ad46f11954
| https://github.com/electron/electron/issues/39991 | https://github.com/electron/electron/pull/40091 | 8f7a48879ef8633a76279803637cdee7f7c6cd4f | 73553032ea99929b1511d6e873ec81328a42a356 | 2023-09-27T09:08:02Z | c++ | 2023-10-06T00:26:31Z |
closed | electron/electron | https://github.com/electron/electron | 39,987 | ["chromium_src/BUILD.gn", "shell/browser/electron_browser_client.cc", "shell/browser/hid/electron_hid_delegate.cc", "shell/browser/plugins/plugin_utils.cc", "shell/browser/usb/electron_usb_delegate.cc", "shell/renderer/printing/print_render_frame_helper_delegate.cc", "shell/renderer/renderer_client_base.cc"] | [Bug]: build fails with `enable_electron_extensions=false` | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
25.8.2
### What operating system are you using?
Other Linux
### Operating System Version
openSUSE Tumbleweed
### What arch are you using?
ia32
### Last Known Working Electron version
_No response_
### Expected Behavior
I am trying to build Electron 25.8.2 with `enable_electron_extensions=false`.
### Actual Behavior
After fixing the <a href="https://gist.github.com/brjsp/b003b7062be0e080d55235cb8449b09e">obvious misguarded sections of code</a> we are left with several <a href="https://gist.github.com/brjsp/fe8e7342534ae347eeb3a66932e91ad2">linker errors</a>, mostly to stuff under //extensions/browser. I am not sure how to remove the dependency, as some of the uses of the offending types are in constructors eg. <a href=https://github.com/electron/electron/blob/v25.8.2/shell/browser/net/proxying_websocket.cc#L38>in proxying_websocket</a>.
### Testcase Gist URL
_No response_
### Additional Information
(Ignore the fact that the attached buildlog is from ix86 which is unsupported — I only used that architecture because it builds way faster and has clearer linker messages due to no LTO, the problem will be the same on any target) | https://github.com/electron/electron/issues/39987 | https://github.com/electron/electron/pull/40032 | 713d8c4167a07971775db847adca880f49e8d381 | b0590b6ee874fbeac49bb5615525d145835eb64f | 2023-09-27T05:22:12Z | c++ | 2023-10-04T08:40:01Z |
closed | electron/electron | https://github.com/electron/electron | 39,960 | ["shell/browser/native_window_mac.mm"] | [Bug]: macOS modal windows with vibrancy should have rounded corners | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
26.2.1
### What operating system are you using?
macOS
### Operating System Version
macOS Ventura 13.6
### What arch are you using?
x64
### Last Known Working Electron version
_No response_
### Expected Behavior
Modal windows in macOS Big Sur (released in late-2020) and later are centered and should have rounded corners.
[See screenshots of macOS Big Sur changes in this post.](https://morrick.me/archives/9025)
### Actual Behavior
Modal windows with vibrancy on macOS have square corners.
### Testcase Gist URL
https://gist.github.com/davidcann/8fcbdf0ad008ee267fd869c924357f08
### Additional Information
Pull request #24250 in mid-2020 disabled rounded corners for modal windows with vibrancy on macOS. This pull request should be reverted, given the new macOS design. I believe that it's a one-line change.
File [`shell/browser/native_window_mac.mm#L1412`](/electron/electron/blob/main/shell/browser/native_window_mac.mm#L1412) should be changed:
- if (!has_frame() && !is_modal() && !no_rounded_corner) {
+ if (!has_frame() && !no_rounded_corner) {
| https://github.com/electron/electron/issues/39960 | https://github.com/electron/electron/pull/39979 | ad57867594c9f1be91846fedf7fe9ab22403ae81 | 1ba321b7332b0a462f04c4d1f921cefcb337f325 | 2023-09-23T21:57:33Z | c++ | 2023-09-27T13:12:37Z |
closed | electron/electron | https://github.com/electron/electron | 39,914 | ["shell/browser/native_window_mac.mm", "spec/api-browser-window-spec.ts"] | [Bug]: In Mac OS Sonoma (14.0) showInactive, is not inactive anymore | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
26.2.1
### What operating system are you using?
macOS
### Operating System Version
Mac OS Sonoma 14
### What arch are you using?
x64
### Last Known Working Electron version
_No response_
### Expected Behavior
When `window.showIncative()` the focus is still on the app below the window that you just make appear. The menu is still the menu from the app below and not the menu from your app.
My window is in `type: panel`
### Actual Behavior
When window `type: panel` and on `window.showIncative()` the electron js app becomes active, the app's menu shows.
This wasn't the behavior on the previous Mac OS version.
### Testcase Gist URL
_No response_
### Additional Information
_No response_ | https://github.com/electron/electron/issues/39914 | https://github.com/electron/electron/pull/40307 | 7999ea39e2ee9702e64e4125e8e89c314e9f468f | b55d7f4a16293164693618b8a0822370f7f4d46c | 2023-09-19T12:27:14Z | c++ | 2023-11-06T21:38:12Z |
closed | electron/electron | https://github.com/electron/electron | 39,891 | ["shell/renderer/api/electron_api_context_bridge.cc", "shell/renderer/api/electron_api_context_bridge.h", "shell/renderer/api/electron_api_web_frame.cc", "shell/renderer/renderer_client_base.cc", "spec/webview-spec.ts"] | [Bug]: NativeImage methods returned by capturePage fail with "Error: Illegal invocation" | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
22.0.0
### What operating system are you using?
Ubuntu
### Operating System Version
Ubuntu 23.04
### What arch are you using?
x64
### Last Known Working Electron version
_No response_
### Expected Behavior
While calling `<webview-tag>.capturePage()` from renderer process, we should be able to run methods from the returned NativeImage (like `.getSize()`)
### Actual Behavior
While calling `<webview-tag>.capturePage()` from a renderer process, all of the NativeImage methods return the following error. In this example we call `.getSize()`:
```
Uncaught (in promise) Error: Illegal invocation: Function must be called on an object of type NativeImage
```
**Code snippet**
```js
const webviewElement = document.getElementById("webview")
webviewElement.capturePage()
.then((image) => console.log(image.getSize()))
```
**To reproduce**
**1.** Create a webview element in a page (BrowserView) and make set the id-attribute to `webview`
**2.** Execute the snippet above
### Testcase Gist URL
_No response_
### Additional Information
_No response_ | https://github.com/electron/electron/issues/39891 | https://github.com/electron/electron/pull/39978 | 5b105f911f7aa134ee44558fefaf171360d3d9d2 | fd2861117e04a3c62bfab67a1b50cb9c3a55cd4d | 2023-09-18T10:48:18Z | c++ | 2023-10-18T14:21:42Z |
closed | electron/electron | https://github.com/electron/electron | 39,885 | ["shell/browser/native_window.cc", "shell/browser/native_window.h", "shell/browser/native_window_mac.h", "shell/browser/native_window_mac.mm"] | [Bug]: Area where traffic lights is rendered does not receive click events when app is fullscreened with titlebar hidden on macOS | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
26.1.0
### What operating system are you using?
macOS
### Operating System Version
macOS Ventura 13.5.2
### What arch are you using?
arm64 (including Apple Silicon)
### Last Known Working Electron version
N/A
### Expected Behavior
Hi there! Apologies if there is already an opened issue for this, I tried to look in the repo but could not find anything relevant.
As the title suggests, we're currently experiencing an issue in our Mac app, which uses a hidden titlebar and therefore renders the traffic lights inline in our app's header alongside clickable elements such as buttons and popovers, where the leftmost buttons are no longer clickable when the app is maximized.
In debugging this, I realized that those buttons (which we have set up to replace the position of where the traffic lights were in the maximized state) do not receive click events at all (e.g. I can't select them from the Chromium inspector and setting a debugger for `onclick` events in the DOM yields nothing when I click that region.
Other relevant information here is that our header which renders these buttons has `-webkit-app-region: drag` set (so it does not receive DOM click events as expected) but each individual button has `-webkit-app-region: no-drag` set to allow them to be clickable and otherwise work just fine when the app is not maximized and the buttons have not been rendered where the traffic lights were in the un-maximized state.
### Actual Behavior
As described above, the relevant two leftmost buttons in our draggable header (which have `no-drag` set) are clickable when rendered next to the traffic lights while the app is not maximized but no longer receive click events when they replace the traffic lights at the edge of the window when it is maximized.
See demo gif below:
### Testcase Gist URL
https://gist.github.com/sergeichestakov/c84835f4d80182744b99e837268edc7c
### Additional Information
Worth noting that we can only reproduce this so far in macOS Ventura (on an M1 Mac). We also tried macOS Big Sur (on an x86 Mac) but this bug does not reproduce there.
Also relevant, we initialize the BrowserWindow with the following options:
```typescript
const window = new BrowserWindow({
webPreferences: {
preload,
additionalArguments: [
`--app-version=${app.getVersion()}`,
`--platform=${process.platform}`,
],
webviewTag: true,
},
title,
icon,
minWidth: 720,
minHeight: 480,
backgroundColor,
autoHideMenuBar: true,
// on macOS:
titleBarStyle: 'hidden',
titleBarOverlay: { height: 48 },
trafficLightPosition: { x: 20, y: 16 },
});
``` | https://github.com/electron/electron/issues/39885 | https://github.com/electron/electron/pull/40179 | c9f6f15df63e80fa12afe5fb981d17faa1f9772e | f362e089b16252cb65bfb7fb44ee5ae88c1e4fcc | 2023-09-15T19:42:11Z | c++ | 2023-10-16T09:18:31Z |
closed | electron/electron | https://github.com/electron/electron | 39,882 | [".github/workflows/issue-commented.yml"] | Issue Commented: No jobs were run email from Github | Hi, when I comment on issue, I get this email from github that links to:
Issue Commented: No jobs were run
https://github.com/electron/electron/actions/runs/6201054415
Happened twice on https://github.com/electron/electron/issues/27912#issuecomment-1721616197 | https://github.com/electron/electron/issues/39882 | https://github.com/electron/electron/pull/39875 | 65952abc995b86783922094ace75323dcaf36892 | 706653d5e4d06922f75aa5621533a16fc34d3a77 | 2023-09-15T17:44:53Z | c++ | 2023-09-18T02:23:59Z |
closed | electron/electron | https://github.com/electron/electron | 39,790 | ["yarn.lock"] | [Bug]: `TitleBarOverlay` is empty interface | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
26.2.0
### What operating system are you using?
macOS
### Operating System Version
MacOS Sonoma
### What arch are you using?
x64
### Last Known Working Electron version
25.3.2
### Expected Behavior
In [`BrowserWindow`'s documentation](https://www.electronjs.org/docs/latest/api/browser-window) I see this:
```
titleBarOverlay Object | Boolean (optional) - When using a frameless window in conjunction with win.setWindowButtonVisibility(true) on macOS or using a titleBarStyle so that the standard window controls ("traffic lights" on macOS) are visible, this property enables the Window Controls Overlay [JavaScript APIs](https://github.com/WICG/window-controls-overlay/blob/main/explainer.md#javascript-apis) and [CSS Environment Variables](https://github.com/WICG/window-controls-overlay/blob/main/explainer.md#css-environment-variables). Specifying true will result in an overlay with default system colors. Default is false.
color String (optional) Windows - The CSS color of the Window Controls Overlay when enabled. Default is the system color.
symbolColor String (optional) Windows - The CSS color of the symbols on the Window Controls Overlay when enabled. Default is the system color.
height Integer (optional) macOS Windows - The height of the title bar and Window Controls Overlay in pixels. Default is system height.
```
However, in `electron.d.ts` this has the following type: ` titleBarOverlay?: (TitleBarOverlay) | (boolean);` where `TitleBarOverlay` is:
```
interface TitleBarOverlay {
}
```
In Electron 25 it was identical to `TitleBarOverlayOptions`:
```
interface TitleBarOverlayOptions {
/**
* The CSS color of the Window Controls Overlay when enabled.
*
* @platform win32
*/
color?: string;
/**
* The CSS color of the symbols on the Window Controls Overlay when enabled.
*
* @platform win32
*/
symbolColor?: string;
/**
* The height of the title bar and Window Controls Overlay in pixels.
*
* @platform win32
*/
height?: number;
}
```
It may cause a lot of TypeScript checks to fail when Electron users migrate their apps from Electron 25 to Electron 26.
I am not able to investigate this problem further, but it seems as only bug with generating electron.d.ts
| https://github.com/electron/electron/issues/39790 | https://github.com/electron/electron/pull/39799 | aceb432f45287492fa00982a7f2679ee7f6a04a8 | ac040bf734090cef83c954a63463bd9e21656217 | 2023-09-10T09:14:13Z | c++ | 2023-09-11T18:36:36Z |
closed | electron/electron | https://github.com/electron/electron | 39,786 | ["shell/browser/native_window.cc", "shell/browser/native_window_mac.h", "shell/browser/native_window_mac.mm"] | [Bug]: minWidth, minHeight, maxWidth, maxHeight in BrowserWindow are not applied. | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
27.0.0-alpha.6
### What operating system are you using?
macOS
### Operating System Version
macOS Ventura 13.5.1（22G90）
### What arch are you using?
arm64 (including Apple Silicon)
### Last Known Working Electron version
26.2.0
### Expected Behavior
When the following code is executed, the window should only be resized to a width of 600-800 and a height of 400-600.
```js
const win = new BrowserWindow({
minWidth: 600,
width: 700,
maxWidth: 800,
minHeight: 400,
height: 500,
maxHeight: 600
})
```
### Actual Behavior
The window can be resized beyond 600-800 in width and 400-600 in height.
### Testcase Gist URL
https://gist.github.com/cd2632ea636bc4a33be98a8330003dae
### Additional Information
Thanks for the great work you guys do. | https://github.com/electron/electron/issues/39786 | https://github.com/electron/electron/pull/39975 | e61359598214399cab97ca6a8ad541983059c331 | ad57867594c9f1be91846fedf7fe9ab22403ae81 | 2023-09-08T09:20:56Z | c++ | 2023-09-27T09:11:24Z |
closed | electron/electron | https://github.com/electron/electron | 39,704 | ["shell/browser/native_window_mac.h", "shell/browser/native_window_mac.mm", "shell/browser/ui/cocoa/electron_ns_window_delegate.mm", "spec/api-browser-window-spec.ts"] | [Bug]: calling show() on child browser window will show all other children starting [email protected] | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
24.7.0
### What operating system are you using?
macOS
### Operating System Version
macOS Ventura 13.0.1
### What arch are you using?
arm64 (including Apple Silicon)
### Last Known Working Electron version
24.6.5
### Expected Behavior
`show()` should only display the browser window on which it is called
### Actual Behavior
When calling `show()` on a child browser window that is hidden, all child windows linked to its parent show up
### Testcase Gist URL
https://gist.github.com/Maxime117/17e8c7427184038d00e333d4eb0154d8
### Additional Information
_No response_ | https://github.com/electron/electron/issues/39704 | https://github.com/electron/electron/pull/40062 | 5ad69df52ea16a21561992f63b17cbaae866b77d | 3392d9a2e74973960ca516adc1c1684e03f78414 | 2023-08-31T15:32:38Z | c++ | 2023-10-05T13:19:57Z |
closed | electron/electron | https://github.com/electron/electron | 39,630 | ["shell/browser/native_window_mac.mm", "spec/api-browser-window-spec.ts"] | [Bug]: fullscreenable in BrowserWindowConstructorOptions is ignored if resizable flag presents | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
25.6.0
### What operating system are you using?
macOS
### Operating System Version
12.3
### What arch are you using?
arm64 (including Apple Silicon)
### Last Known Working Electron version
_No response_
### Expected Behavior
Windows parameters corresponds to constructor options
### Actual Behavior
It doesn't
### Testcase Gist URL
https://gist.github.com/origin-yaropolk/8770735fda705a6bbc7d2132a30314dc
### Additional Information
_No response_ | https://github.com/electron/electron/issues/39630 | https://github.com/electron/electron/pull/39620 | 2affecd4dd26b9f0cf2644ec115635559f920480 | 33e66b5cd02d2b258b956022c482024c74c13b4b | 2023-08-23T17:00:10Z | c++ | 2023-08-24T20:54:08Z |
closed | electron/electron | https://github.com/electron/electron | 39,614 | ["shell/browser/native_window_mac.mm", "spec/api-browser-window-spec.ts"] | [Bug]: non-fullscreenable, non-resizable child windows get fullscreened when being shown if the parent window is fullscreened | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
26.0.0
### What operating system are you using?
macOS
### Operating System Version
macOS Ventura 13.2.1
### What arch are you using?
arm64 (including Apple Silicon)
### Last Known Working Electron version
_No response_
### Expected Behavior
I expect that if a child window that's configured to be non-fullscreenable is shown while the parent window is fullscreened, the child window won't get fullscreened.
### Actual Behavior
Child window opens fullscreened for some reason and the main window crashes when the child is closed.
### Testcase Gist URL
https://gist.github.com/pushkin-/3b4bcdb219eee85789e95f6d94ec8a92
### Additional Information
1. full screen main window
2. click open window
3. notice that child window is fullscreened even though it shouldn't be able to get fullscreen
4. closing the window makes the parent window go black
seems like the invocation of `BrowserWindow::show()` causes the `enter-full-screen` event to get emitted for some reason.
https://github.com/electron/electron/assets/6374473/f96e2680-4938-4de6-b562-94f80c46ecfb
| https://github.com/electron/electron/issues/39614 | https://github.com/electron/electron/pull/39620 | 2affecd4dd26b9f0cf2644ec115635559f920480 | 33e66b5cd02d2b258b956022c482024c74c13b4b | 2023-08-22T22:41:12Z | c++ | 2023-08-24T20:54:08Z |
closed | electron/electron | https://github.com/electron/electron | 39,610 | ["shell/common/gin_converters/blink_converter.cc", "spec/api-web-contents-spec.ts", "spec/fixtures/pages/key-events.html"] | [Bug]: webContents.sendInputEvent does not work with Space and Enter | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
19.0.9
### What operating system are you using?
Ubuntu
### Operating System Version
20.04
### What arch are you using?
x64
### Last Known Working Electron version
_No response_
### Expected Behavior
webContents.sendInputEvent({ keyCode: "Space", type: "keyDown" });
webContents.sendInputEvent({ keyCode: "Space", type: "char" });
webContents.sendInputEvent({ keyCode: "Space", type: "keyUp" });
Displays "Spa" in my input field.
Same applies for "Enter", which displays "Ent".
Backspace and other simple letters work fine.
### Actual Behavior
"Space" and "Enter" keycodes input the first 3 letters instead of the actual key.
### Testcase Gist URL
_No response_
### Additional Information
_No response_ | https://github.com/electron/electron/issues/39610 | https://github.com/electron/electron/pull/39776 | 470a14d8d4c2748ede41fe78d686f63cff4d6fe3 | ec9c8476fe2c789d8d3bfe94eee6ab88dceeede2 | 2023-08-22T18:06:07Z | c++ | 2023-09-12T09:28:45Z |
closed | electron/electron | https://github.com/electron/electron | 39,550 | ["shell/browser/native_window_views.cc", "shell/browser/native_window_views.h", "shell/browser/native_window_views_win.cc"] | [Bug]: Thumbnail toolbar buttons are removed when Explorer is restarted | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
25.4.0
### What operating system are you using?
Windows
### Operating System Version
Windows 10 Pro 22H2 (19045.3324)
### What arch are you using?
x64
### Last Known Working Electron version
_No response_
### Expected Behavior
After adding buttons with `BrowserWindow.setThumbarButtons`, thumbnail toolbar buttons persist across explorer restarts.
### Actual Behavior
After adding buttons with `BrowserWindow.setThumbarButtons`, thumbnail toolbar buttons are removed when explorer is restarted.
After that, you can't add buttons with `BrowserWindow.setThumbarButtons`.
### Testcase Gist URL
_No response_
### Additional Information
You can restart Explorer by selecting the Explorer context menu from Task Manager. | https://github.com/electron/electron/issues/39550 | https://github.com/electron/electron/pull/39551 | 95bf9d8adb33bc2aaf988977b18663f9a770ef77 | 9937a2bbe8dd6cc01ff3dd0ce32268e33c0ec1de | 2023-08-17T07:07:04Z | c++ | 2023-08-21T00:43:49Z |
closed | electron/electron | https://github.com/electron/electron | 39,535 | ["electron_paks.gni", "spec/chromium-spec.ts"] | [Bug]: cannot open chrome://gpu on Linux | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
25.5.0
### What operating system are you using?
Other Linux
### Operating System Version
openSUSE Tumbleweed
### What arch are you using?
x64
### Last Known Working Electron version
24.7.1
### Expected Behavior
When running `electron chrome://gpu` a page of system diagnostics should open.
### Actual Behavior
Instead a blank window opens and `(node:14996) electron: Failed to load URL: chrome://gpu/ with error: ERR_FAILED` gets printed to console.
### Testcase Gist URL
_No response_
### Additional Information
This issue happens with electron 25 and 26. It was fine in electron 24. | https://github.com/electron/electron/issues/39535 | https://github.com/electron/electron/pull/39556 | c75e193a3e4683b1d55e56152dcef92e93d5eb56 | 95bf9d8adb33bc2aaf988977b18663f9a770ef77 | 2023-08-16T14:34:57Z | c++ | 2023-08-21T00:41:00Z |
closed | electron/electron | https://github.com/electron/electron | 39,470 | ["shell/browser/ui/views/client_frame_view_linux.cc"] | [Bug]: with wayland & gnome, maximizing a window to the side results in margin around the window | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
25.3.1 and 22.3.18
### What operating system are you using?
Other Linux
### Operating System Version
Linux jig 6.1.41-1-MANJARO #1 SMP PREEMPT_DYNAMIC Tue Jul 25 09:17:30 UTC 2023 x86_64 GNU/Linux
### What arch are you using?
x64
### Expected Behavior
The demo app maximizes to the right or the left to take up half the screen, and the window extends to the top, bottom, and side all the way.
### Actual Behavior
The demo app maximizes to the right or the left to take up half the screen, but the borders of the app don't extend all the way to the side and bottom of the screen. The title-bar extends all the way to the top of the screen, but the title bar is double the height it should be, and it seems to only respond to clicks in the bottom half
### Additional information
#### Reproduction steps
- Install Manjaro with GNOME Shell 44.3, use gnome with wayland
```
pamac install electron
electron --ozone-platform=wayland --enable-features=WaylandWindowDecorations
```
- Drag demo app to side of screen to maximize to the right or the left
[Screencast from 2023-08-11 12-25-01.webm](https://github.com/electron/electron/assets/133676745/7e2cec76-df18-4de1-aea3-06c095d8ab68)
Note: maximizing full screen works as intended, but this may be related to https://github.com/electron/electron/issues/33161
| https://github.com/electron/electron/issues/39470 | https://github.com/electron/electron/pull/39523 | 0621f3929693530076b75befbdaa83755f6cd4fa | c75e193a3e4683b1d55e56152dcef92e93d5eb56 | 2023-08-11T16:23:29Z | c++ | 2023-08-17T18:26:49Z |
closed | electron/electron | https://github.com/electron/electron | 39,445 | ["docs/api/browser-window.md"] | [Bug]: `BrowserWindow`'s top offset (`y` value) is set to 25 when trying to set it explicitly below 25 on macOS | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
25.4.0
### What operating system are you using?
macOS
### Operating System Version
macOS Monterey 12.6
### What arch are you using?
arm64 (including Apple Silicon)
### Last Known Working Electron version
_No response_
### Expected Behavior
BrowserWindow's top offset from screen (`y` value) should be respected when explicitly specified to be below 25
### Actual Behavior
BrowserWindow's top offset from screen (`y` value) is always set to 25 when explicitly specified to be below 25
### Testcase Gist URL
https://gist.github.com/7bd49c0498a46da629adf1327fc03160
### Additional Information
Both when creating a new `BrowserWindow` like so:
```js
const win = new BrowserWindow({
x: 15,
y: 16,
})
console.log(win.getBounds()); // logs { x: 15, y: 25, width: 800, height: 600 }
```
or when setting the `BrowserWindow` position after creation like so:
```js
const win = new BrowserWindow();
win.setPosition(15,16);
console.log(win.getBounds()); // logs { x: 15, y: 25, width: 800, height: 600 }
```
When the y-value above is set to anything below 25, it always goes to 25 and never below. However, setting the y-value above 25 works correctly and returns position that was specified.
This issue doesn't seem to exist on Windows and Linux and seems to isolated to MacOS.
I did find a possibly related issue filed [here](https://github.com/electron/electron/issues/39257) | https://github.com/electron/electron/issues/39445 | https://github.com/electron/electron/pull/39512 | dd8df3b0c47102fe5686f516c80e698ab555a6f9 | 31dfde7fa63c19a299e18b2dcef7cdf922d2a400 | 2023-08-09T18:17:51Z | c++ | 2023-08-17T09:02:03Z |
closed | electron/electron | https://github.com/electron/electron | 39,413 | ["shell/browser/native_window_mac.mm", "spec/api-browser-window-spec.ts"] | [Bug]: App crashes with SIGTRAP while creating modal window on Mac | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
25.4.0
### What operating system are you using?
macOS
### Operating System Version
12.3
### What arch are you using?
arm64 (including Apple Silicon)
### Last Known Working Electron version
25.1.1
### Expected Behavior
Not to crash:)
### Actual Behavior
When I create new windows as modal to parent, I get crash with SIGTRAP
Unfortunately, I couldn't reproduce this in small test project. Only fact I have, if I don't set new window as modal, app not crashes.
### Testcase Gist URL
_No response_
### Additional Information
I can provide you part of stack trace and minidump
<img width="872" alt="image" src="https://github.com/electron/electron/assets/25509934/ccfbba1b-13cd-4fee-a04c-1deff56d2dc3">
[2988dcae-9326-4b22-84d3-c0123f13e17f.dmp.zip](https://github.com/electron/electron/files/12292673/2988dcae-9326-4b22-84d3-c0123f13e17f.dmp.zip)
There is very strange call for `ElectronPermissionMessageProvider::IsPrivilegeIncrease`. It seems like it never should be called.
I also think it was affected here https://github.com/electron/electron/issues/38939
| https://github.com/electron/electron/issues/39413 | https://github.com/electron/electron/pull/39499 | f7a7085019bf757700df3c2f8714e0de356203cd | 1eb398b328d304f227deef0e89ca0be7b9e20755 | 2023-08-08T14:52:19Z | c++ | 2023-08-16T11:28:29Z |
closed | electron/electron | https://github.com/electron/electron | 39,377 | ["shell/browser/api/electron_api_base_window.cc"] | [Bug]: removeBrowserView() crashes if view.webContents.close() is called beforehand. | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
25.3.0
### What operating system are you using?
macOS
### Operating System Version
macOs Ventura 13.4.1 (c)
### What arch are you using?
x64
### Last Known Working Electron version
25.2.0
### Expected Behavior
We are using `browserViews` in a `browserWindow`, when closing our view, we need the `window.close` event to be sent, so I'm using the `view.webContents.close()` to close the window (it's hosting a citrix receiver html5 page) before I call `mainWindow.removeBrowserView()`.
Expected behavior is the `browserView` closes, and the `getBrowserViews` list is updated by `removeBrowserView()` call.
### Actual Behavior
The `removeBrowserView` call crashes the electron app. In the fiddle it crashes with `Electron exited with signal SIGSEGV.`
### Testcase Gist URL
https://gist.github.com/Bill77/1db0aefcd338b612f66e09a9f7372d82
### Additional Information
Attached is a Electron Fiddle with the **add** and **close** buttons. To reproduce, add the view and then close it, which works in `25.2.0` but does not in `25.3.0+`. Looking at the change log, it seem it's related to [this PR](https://github.com/electron/electron/pull/38996).
I did try to just use the `webContents.close()` and skip calling `removeBrowserView()` but the view list does not get updated, and we get a list of views that have null `webContents`. Which I suspect is causing the issue in `removeBrowerView()` to crash.
We either need a solution where within `removeBrowserView` it calls the `webContents.close` or the logic in `removeBrowserView` needs null checks on the `webContent` references. Sorry, that's my guess based on not looking at the Electron code directly! 🤷♂️ | https://github.com/electron/electron/issues/39377 | https://github.com/electron/electron/pull/39387 | 1548a2f9fb6d9bf9e0c4f6ace595189cf84b38e9 | 8f4f82618c51029f91cfb6516bc9c75164bfee9a | 2023-08-04T23:22:40Z | c++ | 2023-08-08T08:23:14Z |
closed | electron/electron | https://github.com/electron/electron | 39,322 | ["docs/api/command-line-switches.md", "shell/common/node_bindings.cc"] | [Bug]: --trace-warnings option not doing anything | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
25.3.2
### What operating system are you using?
Other (specify below)
### Operating System Version
any OS
### What arch are you using?
Other (specify below)
### Last Known Working Electron version
_No response_
### Expected Behavior
I expect to get some more information about warning when using `--trace-warnings`
### Actual Behavior
Same behavior as without `--trace-warnings`
` "start": "electron --trace-warnings ."`
```
electron-quick-start git:(main) npm start
> [email protected] start
> electron . --trace-warnings
(node:22471) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 window-all-closed listeners added to [App]. Use emitter.setMaxListeners() to increase limit
(Use `electron --trace-warnings ...` to show where the warning was created)
```
` "start": "electron ."`
```
electron-quick-start git:(main) ✗ npm start
> [email protected] start
> electron .
(node:22616) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 window-all-closed listeners added to [App]. Use emitter.setMaxListeners() to increase limit
(Use `electron --trace-warnings ...` to show where the warning was created)
```
### Testcase Gist URL
https://github.com/hovancik/electron-trace-warnings-isssue
### Additional Information
_No response_ | https://github.com/electron/electron/issues/39322 | https://github.com/electron/electron/pull/39344 | c5b9f766f373f4d403a8af2f75e28ca2d901cc32 | 2e0517c0addc05678e59906d91d72cc8f4860547 | 2023-08-01T15:47:31Z | c++ | 2023-08-04T10:59:40Z |
closed | electron/electron | https://github.com/electron/electron | 39,288 | ["docs/api/command-line-switches.md", "shell/app/node_main.cc", "shell/common/node_bindings.cc", "shell/common/node_bindings.h"] | [Bug]: js-flags not working | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
25.3.1
### What operating system are you using?
macOS
### Operating System Version
10.15.7
### What arch are you using?
x64
### Last Known Working Electron version
no test
### Expected Behavior
`electron --js-flags="--enable-source-maps" .` makes node supports sourcemap
### Actual Behavior
Error: unrecognized flag --enable-source-maps
Try --help for options
### Testcase Gist URL
_No response_
### Additional Information
_No response_ | https://github.com/electron/electron/issues/39288 | https://github.com/electron/electron/pull/39465 | 1d20ec5b990085fb38cc0494435cd6f57e0e8b3e | 22429e21129bd22c06c23f7d714b96d31063d495 | 2023-07-30T11:40:10Z | c++ | 2023-08-15T18:49:21Z |
closed | electron/electron | https://github.com/electron/electron | 39,257 | ["shell/browser/api/electron_api_base_window.cc", "shell/browser/api/electron_api_browser_view.h", "shell/browser/native_browser_view_mac.mm", "spec/api-browser-view-spec.ts"] | [Bug]: BrowserView y-coordinate is not respected on macOS Ventura (13.4.1 and 13.5) | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
25.3.2
### What operating system are you using?
macOS
### Operating System Version
macOS Ventura (13.4.1 and 13.5)
### What arch are you using?
arm64 (including Apple Silicon)
### Last Known Working Electron version
22.3.18
### Expected Behavior
This code should place a BrowserView on top of the default BrowserWindow, respecting the indicated x and y coordinates:
```
const bwin = new BrowserWindow({
width: 300,
height: 500
})
bwin.loadURL('https://electronjs.org/')
const bview = new BrowserView()
bview.setBounds({
x: 0,
y: 0,
width: 300,
height: 300
})
bwin.addBrowserView(bview)
bview.webContents.loadURL('https://github.com/')
```
### Actual Behavior
While the previous code works perfectly on Windows 11, on macOS the y-coordinate of the BrowserView is shifted by the same amount of pixels as the height of BrowserWindow (causing the BrowserView to disappear). So on macOS to correctly position the BrowserView you need to set its y-coordinate to -BrowserViewHeight
```
const bwin = new BrowserWindow({
width: 300,
height: 500
})
bwin.loadURL('https://electronjs.org/')
const bview = new BrowserView()
bview.setBounds({
x: 0,
y: -500, // <------- !!!
width: 300,
height: 300
})
bwin.addBrowserView(bview)
bview.webContents.loadURL('https://github.com/')
```
### Testcase Gist URL
https://gist.github.com/360b53fa59bce4a9e49549954bc23444
### Additional Information
_No response_ | https://github.com/electron/electron/issues/39257 | https://github.com/electron/electron/pull/39605 | 522bba3dc6b4893fdcf4d1a978fec0204b50d63b | a8999bc529390e7a9a2515bfa23445b34b10860a | 2023-07-27T11:07:57Z | c++ | 2023-08-23T13:55:31Z |
closed | electron/electron | https://github.com/electron/electron | 39,186 | ["docs/tutorial/electron-timelines.md"] | Releases page: node version missing for electron 25 | there is already a stable release for electron 25 with node 18.15.0:
https://releases.electronjs.org/release/v25.3.1
But this releases list is missing the node version ("TBD") for electron 25.
https://www.electronjs.org/docs/latest/tutorial/electron-timelines | https://github.com/electron/electron/issues/39186 | https://github.com/electron/electron/pull/39187 | 2c52eb7e1c61aa1ae5e91b4ad062dc7d67fb764e | 1ca3a7d3c988b671d0ebe5f3b62b4890da9faacf | 2023-07-21T07:57:45Z | c++ | 2023-07-24T10:33:10Z |
closed | electron/electron | https://github.com/electron/electron | 39,165 | ["patches/chromium/allow_disabling_blink_scheduler_throttling_per_renderview.patch", "patches/chromium/extend_apply_webpreferences.patch", "spec/api-browser-window-spec.ts", "spec/disabled-tests.json", "spec/fixtures/pages/visibilitychange.html"] | [Bug]: visibility state can be changed to `hidden` when `backgroundThrottling` is disabled | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
25.3.1
### What operating system are you using?
macOS
### Operating System Version
MacOS 13.4.1
### What arch are you using?
x64
### Last Known Working Electron version
_No response_
### Expected Behavior
According to the [API doc](https://www.electronjs.org/docs/latest/api/browser-window#page-visibility), When `backgroundThrottling` is `false, the `document.visibilityState` always return `visible` even if the window is minimized, occluded, or hidden.
> If backgroundThrottling is disabled, the visibility state will remain visible even if the window is minimized, occluded, or hidden.
### Actual Behavior
When `backgroundThrottling` is `false, the `document.visibilityState` always return `hidden` when the window is minimized, occluded, or hidden.
### Testcase Gist URL
https://gist.github.com/xiaofeihan1/4aceba89108f9b1a5b6d577ddd50e565
### Additional Information
https://github.com/electron/electron/assets/107654914/f2b40385-8d51-42aa-a360-3537befe1797
| https://github.com/electron/electron/issues/39165 | https://github.com/electron/electron/pull/39223 | c9bae5da8ef280e310d4c1d03ee94a169c704357 | 6df392162f1d29155e6d8d6f755de7e48c18e709 | 2023-07-20T07:09:11Z | c++ | 2023-07-28T08:48:25Z |
closed | electron/electron | https://github.com/electron/electron | 39,112 | ["patches/webrtc/.patches", "patches/webrtc/fix_mark_pipewire_capturer_as_failed_after_session_is_closed.patch", "shell/browser/api/electron_api_desktop_capturer.cc"] | [Bug]: desktopCapturer fails to generate thumbnails after a PipeWire stream is cancelled externally | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
25.3.0
### What operating system are you using?
Other Linux
### Operating System Version
Fedora 38
### What arch are you using?
x64
### Last Known Working Electron version
_No response_
### Expected Behavior
1. Get screencast sources using `desktopCapturer.getSources()` on Wayland
2. Select a source on the permission popup
3. Start a screencast stream using `navigator.mediaDevices.getUserMedia()`
4. Interrupt the stream by cancelling screen sharing using OS controls, like on the top bar of GNOME shell
5. Try to fetch screencast sources again using `desktopCapturer.getSources()`, with thumbnails
6. Select a source on the permission popup
7. Sources and thumbnails should be returned by `desktopCapturer.getSources()`
### Actual Behavior
The second call to `desktopCapturer.getSources()` does not complete.
### Testcase Gist URL
https://gist.github.com/aiddya/d368bc2cb7f72a9b030b918ee1332299
### Additional Information
Filing this as a known issue. This issue is not reproducible with Chromium, so it's related to how `DesktopCapturer` and `NativeDesktopMediaList` objects are handled in Electron. | https://github.com/electron/electron/issues/39112 | https://github.com/electron/electron/pull/39194 | 38c3d8df2970821f582d7adc6c3ecd400ef265df | fa5b1be6f3d6631c0404097b69ea81b4a1eab7f7 | 2023-07-15T17:46:11Z | c++ | 2023-07-26T08:40:19Z |
closed | electron/electron | https://github.com/electron/electron | 39,079 | ["patches/node/.patches", "patches/node/fix_assert_module_in_the_renderer_process.patch"] | [Bug]: render process: assert.ok(false) throws TypeError instead of AssertionError | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
25.2.0
### What operating system are you using?
Other Linux
### Operating System Version
Fedora 38
### What arch are you using?
x64
### Last Known Working Electron version
11.1.0
### Expected Behavior
`AssertionError [ERR_ASSERTION]: false == true`
### Actual Behavior
`TypeError: call.getFileName is not a function`
### Testcase Gist URL
https://gist.github.com/ianhattendorf/82aeba581323093882168ddf69b6c6c2
### Additional Information
This broke a while back for both main + render processes (https://github.com/electron/electron/issues/24577) and was fixed in **11.0.0** (verified with fiddle). It later regressed, breaking for _only render processes_ in **11.1.1**.
https://github.com/electron/electron/compare/v11.1.0...v11.1.1
@codebytere maybe you remember this from last time? | https://github.com/electron/electron/issues/39079 | https://github.com/electron/electron/pull/39540 | 2481f94b4efe262c9ae2f5f16cd0845eeb6c4efd | ddc7e3ebb3c34357d4999174d692e18124cb7798 | 2023-07-12T22:59:47Z | c++ | 2023-08-23T09:38:47Z |
closed | electron/electron | https://github.com/electron/electron | 39,078 | ["shell/browser/ui/cocoa/electron_ns_window_delegate.h", "shell/browser/ui/cocoa/electron_ns_window_delegate.mm"] | [Bug]: Child window can't be minimized on Mac when it's brought back by activating the parent window rather than through the minimize section of the dock | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
25.2.0
### What operating system are you using?
macOS
### Operating System Version
macOS Ventura 13.2.1
### What arch are you using?
arm64 (including Apple Silicon)
### Last Known Working Electron version
_No response_
### Expected Behavior
I expect to be able to minimize a child window correctly
### Actual Behavior
After the first minimize, if I get the window back by activating the parent window (since I guess the child is brought up since it's supposed to be on top of the parent), I can't minimize/close it.
It needs to be retrieved from the minimize section of the doc
### Testcase Gist URL
https://gist.github.com/pushkin-/c7f43c9692b085adca3a784a390eb89b
### Additional Information
1. start gist
2. click Open Window button
3. minimize the child window (seems to work the first time)
4. then pull it back from the dock (I had to click on some other application and then my app)
5. now the minimize button doesn't do anything. Neither does the X. If I bring the child window back via the minimize section of the dock, then it works fine.
Only happens when the window is a child window. | https://github.com/electron/electron/issues/39078 | https://github.com/electron/electron/pull/39225 | 12548294c0b2639d34c05c544f56545004efee01 | 38c3d8df2970821f582d7adc6c3ecd400ef265df | 2023-07-12T20:21:47Z | c++ | 2023-07-26T08:10:34Z |
closed | electron/electron | https://github.com/electron/electron | 39,077 | ["shell/browser/native_window.cc", "shell/browser/native_window_mac.mm"] | [Bug]: Non-resizable windows can still be maximized on Macs the first time | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
25.2.0
### What operating system are you using?
macOS
### Operating System Version
macOS Ventura 13.2.1
### What arch are you using?
arm64 (including Apple Silicon)
### Last Known Working Electron version
_No response_
### Expected Behavior
I expect that if I set `resizable:false` on a `BrowserWindow`, I won't be able to maximize/fullscreen it.
### Actual Behavior
The green maximize button is enabled and I can maximized. When I click it again however and the window restores to the normal size, then it becomes disabled.
### Testcase Gist URL
https://gist.github.com/pushkin-/67fb41db75da3eb6dbaa34d39d34fabf
### Additional Information
Start the gist, maximize the window, unmaximize it, notice the green maximize button is now correctly disabled.
I also get a bunch of logs in the console when I fullscreen the window for some reason:
```
1 HIToolbox 0x000000018c4905c8 _ZN15MenuBarInstance22EnsureAutoShowObserverEv + 120
2 HIToolbox 0x000000018c490188 _ZN15MenuBarInstance14EnableAutoShowEv + 60
3 HIToolbox 0x000000018c3fd8bc _ZN15MenuBarInstance21UpdateAggregateUIModeE21MenuBarAnimationStylehhh + 1184
4 HIToolbox 0x000000018c490004 _ZN15MenuBarInstance19SetFullScreenUIModeEjj + 180
5 AppKit 0x000000018627fd30 -[NSApplication _setPresentationOptions:instance:flags:] + 956
6 AppKit 0x000000018611593c -[NSApplication _updateFullScreenPresentationOptionsForInstance:] + 404
7 CoreFoundation 0x0000000182d32560 __CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER__ + 148
8 CoreFoundation 0x0000000182dd0044 ___CFXRegistrationPost_block_invoke + 88
9 CoreFoundation 0x0000000182dcff8c _CFXRegistrationPost + 440
10 CoreFoundation 0x0000000182d03b64 _CFXNotificationPost + 708
11 Foundation 0x0000000183bf338c -[NSNotificationCenter postNotificationName:object:userInfo:] + 88
12 AppKit 0x00000001862802b4 spacesNotificationHandler + 96
13 SkyLight 0x000000018796d214 _ZN12_GLOBAL__N_123notify_datagram_handlerEj15CGSDatagramTypePvmS1_ + 896
14 SkyLight 0x0000000187c994d4 _ZN21CGSDatagramReadStream26dispatchMainQueueDatagramsEv + 228
15 SkyLight 0x0000000187c993d0 ___ZN21CGSDatagramReadStream15mainQueueWakeupEv_block_invoke + 28
16 libdispatch.dylib 0x0000000182ad49dc _dispatch_call_block_and_release + 32
17 libdispatch.dylib 0x0000000182ad6504 _dispatch_client_callout + 20
18 libdispatch.dylib 0x0000000182ae4d1c _dispatch_main_queue_drain + 928
19 libdispatch.dylib 0x0000000182ae496c _dispatch_main_queue_callback_4CF + 44
20 CoreFoundation 0x0000000182d7ed40 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 16
21 CoreFoundation 0x0000000182d3c7c0 __CFRunLoopRun + 2036
22 CoreFoundation 0x0000000182d3b878 CFRunLoopRunSpecific + 612
23 HIToolbox 0x000000018c41bfa0 RunCurrentEventLoopInMode + 292
24 HIToolbox 0x000000018c41bde4 ReceiveNextEventCommon + 672
25 HIToolbox 0x000000018c41bb2c _BlockUntilNextEventMatchingListInModeWithFilter + 72
26 AppKit 0x0000000185fc184c _DPSNextEvent + 632
27 AppKit 0x0000000185fc09dc -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 728
28 AppKit 0x0000000185fb4e0c -[NSApplication run] + 464
29 Electron Framework 0x000000010da2e958 _ZN4node23GetMultiIsolatePlatformEPNS_11IsolateDataE + 9089840
30 Electron Framework 0x000000010da2d050 _ZN4node23GetMultiIsolatePlatformEPNS_11IsolateDataE + 9083432
31 Electron Framework 0x000000010d9e0c28 _ZN4node23GetMultiIsolatePlatformEPNS_11IsolateDataE + 8771072
32 Electron Framework 0x000000010d9ab0b4 _ZN4node23GetMultiIsolatePlatformEPNS_11IsolateDataE + 8551052
33 Electron Framework 0x000000010cc9ba10 _ZN2v88internal20SetupIsolateDelegate13SetupBuiltinsEPNS0_7IsolateEb + 3653888
34 Electron Framework 0x000000010cc9d324 _ZN2v88internal20SetupIsolateDelegate13SetupBuiltinsEPNS0_7IsolateEb + 3660308
35 Electron Framework 0x000000010cc9969c _ZN2v88internal20SetupIsolateDelegate13SetupBuiltinsEPNS0_7IsolateEb + 3644812
36 Electron Framework 0x000000010afa5ff4 _ZN2v88internal8compiler10BasicBlock15set_loop_headerEPS2_ + 13524
37 Electron Framework 0x000000010afa6f00 _ZN2v88internal8compiler10BasicBlock15set_loop_headerEPS2_ + 17376
38 Electron Framework 0x000000010afa6d50 _ZN2v88internal8compiler10BasicBlock15set_loop_headerEPS2_ + 16944
39 Electron Framework 0x000000010afa5814 _ZN2v88internal8compiler10BasicBlock15set_loop_headerEPS2_ + 11508
40 Electron Framework 0x000000010afa5a40 _ZN2v88internal8compiler10BasicBlock15set_loop_headerEPS2_ + 12064
41 Electron Framework 0x000000010acd91d8 ElectronMain + 128
42 dyld 0x0000000182933e50 start + 2544
1 HIToolbox 0x000000018c41b90c _ZN15MenuBarInstance22RemoveAutoShowObserverEv + 44
2 HIToolbox 0x000000018c490fbc _ZN15MenuBarInstance15DisableAutoShowEv + 36
3 HIToolbox 0x000000018c4910b0 _ZN15MenuBarInstanceD2Ev + 128
4 HIToolbox 0x000000018c490ee0 _ZN15MenuBarInstance7ReleaseEv + 56
5 AppKit 0x000000018661d4dc -[NSHIPresentationInstance discard] + 228
6 AppKit 0x00000001869dc8b4 -[_NSFullScreenSpace(PresentationInstance) discardPresentationInstance] + 32
7 AppKit 0x00000001869dc90c -[_NSFullScreenSpace(PresentationInstance) activateFullScreenPresentationOptions] + 64
8 AppKit 0x0000000186836968 -[_NSExitFullScreenTransitionController _doSucceededToExitFullScreen] + 40
9 AppKit 0x0000000186837440 __63-[_NSExitFullScreenTransitionController _performExitFullScreen]_block_invoke + 236
10 libxpc.dylib 0x00000001829ce42c _xpc_connection_reply_callout + 124
11 libxpc.dylib 0x00000001829ce31c _xpc_connection_call_reply_async + 88
12 libdispatch.dylib 0x0000000182ad6584 _dispatch_client_callout3 + 20
13 libdispatch.dylib 0x0000000182af4710 _dispatch_mach_msg_async_reply_invoke + 344
14 libdispatch.dylib 0x0000000182ae4c70 _dispatch_main_queue_drain + 756
15 libdispatch.dylib 0x0000000182ae496c _dispatch_main_queue_callback_4CF + 44
16 CoreFoundation 0x0000000182d7ed40 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 16
17 CoreFoundation 0x0000000182d3c7c0 __CFRunLoopRun + 2036
18 CoreFoundation 0x0000000182d3b878 CFRunLoopRunSpecific + 612
19 HIToolbox 0x000000018c41bfa0 RunCurrentEventLoopInMode + 292
20 HIToolbox 0x000000018c41bc30 ReceiveNextEventCommon + 236
21 HIToolbox 0x000000018c41bb2c _BlockUntilNextEventMatchingListInModeWithFilter + 72
22 AppKit 0x0000000185fc184c _DPSNextEvent + 632
23 AppKit 0x0000000185fc09dc -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 728
24 AppKit 0x0000000185fb4e0c -[NSApplication run] + 464
25 Electron Framework 0x000000010da2e958 _ZN4node23GetMultiIsolatePlatformEPNS_11IsolateDataE + 9089840
26 Electron Framework 0x000000010da2d050 _ZN4node23GetMultiIsolatePlatformEPNS_11IsolateDataE + 9083432
27 Electron Framework 0x000000010d9e0c28 _ZN4node23GetMultiIsolatePlatformEPNS_11IsolateDataE + 8771072
28 Electron Framework 0x000000010d9ab0b4 _ZN4node23GetMultiIsolatePlatformEPNS_11IsolateDataE + 8551052
29 Electron Framework 0x000000010cc9ba10 _ZN2v88internal20SetupIsolateDelegate13SetupBuiltinsEPNS0_7IsolateEb + 3653888
30 Electron Framework 0x000000010cc9d324 _ZN2v88internal20SetupIsolateDelegate13SetupBuiltinsEPNS0_7IsolateEb + 3660308
31 Electron Framework 0x000000010cc9969c _ZN2v88internal20SetupIsolateDelegate13SetupBuiltinsEPNS0_7IsolateEb + 3644812
32 Electron Framework 0x000000010afa5ff4 _ZN2v88internal8compiler10BasicBlock15set_loop_headerEPS2_ + 13524
33 Electron Framework 0x000000010afa6f00 _ZN2v88internal8compiler10BasicBlock15set_loop_headerEPS2_ + 17376
34 Electron Framework 0x000000010afa6d50 _ZN2v88internal8compiler10BasicBlock15set_loop_headerEPS2_ + 16944
35 Electron Framework 0x000000010afa5814 _ZN2v88internal8compiler10BasicBlock15set_loop_headerEPS2_ + 11508
36 Electron Framework 0x000000010afa5a40 _ZN2v88internal8compiler10BasicBlock15set_loop_headerEPS2_ + 12064
37 Electron Framework 0x000000010acd91d8 ElectronMain + 128
38 dyld 0x0000000182933e50 start + 2544
``` | https://github.com/electron/electron/issues/39077 | https://github.com/electron/electron/pull/39086 | 455f57322f705fdd67751328e8f1feaf6bd29409 | 12548294c0b2639d34c05c544f56545004efee01 | 2023-07-12T20:04:56Z | c++ | 2023-07-25T16:18:36Z |
closed | electron/electron | https://github.com/electron/electron | 39,055 | ["shell/common/api/electron_api_clipboard.cc"] | [Bug]: 26.0.0-beta.3 clipboard.readImage causes error RAW Bad optional access | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
26.0.0-beta.3
### What operating system are you using?
macOS
### Operating System Version
macOS Monterey 12.3.1
### What arch are you using?
arm64 (including Apple Silicon)
### Last Known Working Electron version
25.2.0
### Expected Behavior
Not to crash
### Actual Behavior
Running clipboard.readImage() completely crashes the app
### Testcase Gist URL
https://gist.github.com/johnlindquist/db52bd78f76afc33366241ccf3d0cb2a
### Additional Information
Make sure to have an image in the clipboard or else it won't crash. | https://github.com/electron/electron/issues/39055 | https://github.com/electron/electron/pull/39069 | 34e7c3696a1375080197ebc68c222d221fbc2ef3 | f61425efdb1357795a2c05a80923e2064158002b | 2023-07-11T16:59:03Z | c++ | 2023-07-13T20:59:14Z |
closed | electron/electron | https://github.com/electron/electron | 39,043 | ["patches/chromium/.patches", "patches/chromium/fix_use_delegated_generic_capturer_when_available.patch", "shell/browser/api/electron_api_desktop_capturer.cc"] | [Feature Request]: Use combined PipeWire Picker for desktopCapturer when windows and screens are requested | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a feature request that matches the one I want to file, without success.
### Problem Description
When calling `desktopCapturer.getSources({ types: ['window', 'screen'] })` it opens two PipeWire pickers, one for a window and one for a screen. It can't get the sources if one of them is canceled (e.g. the user only wants to share a window or screen and cancels the other one).
### Proposed Solution
Use a combined picker if a window and screen capture is requested.
My Pseudo Idea how this could be implemented:
Add a check in [electron_api_desktop_capturer.cc](https://github.com/aiddya/electron/blob/72f357ad773056483518964820700672465a048f/shell/browser/api/electron_api_desktop_capturer.cc#L240) if capture_window and capture_screen are true and a delegated Sourcelist is used.
Then somehow pass `ScreenCastPortal::CaptureSourceType::kAnyScreenContent` as a CaptureType in [screencast_portal.cc](https://webrtc.googlesource.com/src/+/8fcc6df79daf1810cd4ecdb8d2ef1d361abfdc9c/modules/desktop_capture/linux/wayland/screencast_portal.cc#95)
### Alternatives Considered
Ignore if one of the pickers gets canceled.
### Additional Information
Fixing behavior that was out of scope of #38833 | https://github.com/electron/electron/issues/39043 | https://github.com/electron/electron/pull/39111 | a83f9c06d701f1126eaf8da605e27125c90edb87 | 9cd5de75888d67b20bb7faf59ca4272323895c62 | 2023-07-10T20:38:37Z | c++ | 2023-07-21T23:03:01Z |
closed | electron/electron | https://github.com/electron/electron | 39,033 | ["shell/browser/native_window_mac.mm"] | [Bug]: `BrowserWindow.moveAbove()` does not work with child windows | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
26.0.0-beta.2
### What operating system are you using?
macOS
### Operating System Version
macOS Ventura 13.4.1
### What arch are you using?
arm64 (including Apple Silicon)
### Last Known Working Electron version
N/A
### Expected Behavior
Calling `BrowserWindow.moveAbove()` on a child window can move it above another child window.
### Actual Behavior
The window is not moved.
### Testcase Gist URL
https://gist.github.com/ddae3d8489b8efeb9f0963d70eea7838
### Additional Information
_No response_ | https://github.com/electron/electron/issues/39033 | https://github.com/electron/electron/pull/39034 | 9d1a16b2e62cf5838ecd1aeaf195952bb0a83f47 | da3475998f154c19d3102c26fec175b9dd4eecec | 2023-07-10T08:39:07Z | c++ | 2023-07-12T15:42:24Z |
closed | electron/electron | https://github.com/electron/electron | 39,031 | ["lib/browser/api/protocol.ts", "spec/api-protocol-spec.ts"] | [Bug]: protocol.handle() is not working with file protocol | ### Preflight Checklist
- [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
25.2.0
### What operating system are you using?
Other Linux
### Operating System Version
6.4.1-arch2-1
### What arch are you using?
x64
### Last Known Working Electron version
_No response_
### Expected Behavior
When using `protocol.handle()` to intercept the `file` protocol, the handler should be called and `handle()` should be intercepting the request.
### Actual Behavior
`protocol.handle()` is not calling the handler and the request finishes without going through the interceptor.
### Testcase Gist URL
https://gist.github.com/Aasim-A/87b30a9acf3b4cbc61e8102290f9197b
### Additional Information
When I try to do the same thing with `http` or any custom protocol, it works without any issues. | https://github.com/electron/electron/issues/39031 | https://github.com/electron/electron/pull/39048 | f959fb0c963701c40f309eb8256530f788d5851e | b142fce229c5821083ad6b7c9aa6aa5790032127 | 2023-07-09T14:52:37Z | c++ | 2023-07-12T09:42:49Z |
closed | electron/electron | https://github.com/electron/electron | 38,995 | ["shell/browser/notifications/mac/cocoa_notification.mm"] | [Bug]: Notification auto adds the action button 'show' in MacOS | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
25.2.0
### What operating system are you using?
macOS
### Operating System Version
Ventura 13.3.1
### What arch are you using?
arm64 (including Apple Silicon)
### Last Known Working Electron version
22.3.1
### Expected Behavior
Create a notification:
`New Notification('title'); // note that there is no options.`
The notification in the top-right screen should only show a popup with the title.
<img width="364" alt="image" src="https://github.com/electron/electron/assets/28861842/2190fb95-4ffe-4ad4-b04f-b4e7ea51103a">
for bellow example, click the 'click me' button to execute `noti` fn
### Actual Behavior
- The notification popup show with an action button named: 'show' when I hover the popup.
- If I click, there is no action trigger
<img width="369" alt="image" src="https://github.com/electron/electron/assets/28861842/7426041d-d1e4-4630-9666-c8124d820e8f">
### Testcase Gist URL
https://gist.github.com/319ccca16a8cd1ec6263adc2723e994e
### Additional Information
I think this issue is caused by this commit: https://github.com/electron/electron/commit/8fb0f430301578ba94b175f0b097fb2752f5ddf9
`[notification_ setHasActionButton:false];`
removed, but as my research, the default of this value is true. We need to set it to false in case there are no actions added
https://developer.apple.com/documentation/foundation/nsusernotification/1411564-hasactionbutton | https://github.com/electron/electron/issues/38995 | https://github.com/electron/electron/pull/38997 | cc7d724a3b85a858044916e5a4b61269610cab09 | a97028bacfba8c0416e02805897e89d1c013717c | 2023-07-05T07:56:02Z | c++ | 2023-07-06T19:50:08Z |
closed | electron/electron | https://github.com/electron/electron | 38,991 | ["patches/chromium/fix_crash_on_nativetheme_change_during_context_menu_close.patch"] | [Bug]: Windows: Menu drop downs overlap application menu | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
25.2.0
### What operating system are you using?
Windows
### Operating System Version
Windows 11 22H2
### What arch are you using?
x64
### Last Known Working Electron version
25.1.1
### Expected Behavior
After clicking on an item in the application menu, the menu should open *below* that item.
### Actual Behavior
The menu overlaps the clicked item. See screenshot below. This just doesn't look nice but also decreases the usability.
### Testcase Gist URL
_No response_
### Additional Information
Electron versions between 26.0.0-alpha.1 and 26.0.0-alpha.7 display the menu as expected. 26.0.0-alpha.8 and newer also have this bug.
I don't think it is necessary to upload a repro repo (ask for that, if I'm wrong). In Electron Fiddle, I just needed to select the right Electron version. | https://github.com/electron/electron/issues/38991 | https://github.com/electron/electron/pull/38998 | c7a64ab994de826ed6e4c300cce75d9fd88efa20 | cc7d724a3b85a858044916e5a4b61269610cab09 | 2023-07-04T23:45:35Z | c++ | 2023-07-06T13:46:12Z |
closed | electron/electron | https://github.com/electron/electron | 38,975 | ["patches/chromium/printing.patch"] | [Bug]: error callback on print | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
24.1.1
### What operating system are you using?
Windows
### Operating System Version
Windows 10
### What arch are you using?
x64
### Last Known Working Electron version
_No response_
### Expected Behavior
I have no paper in my printer and when I want print it document stay in queue
and electron
window.contents.print(options, (success, errorType) => {
console.log(success)
console.log(errorType)
})
errorType is empty and success return true but i am not printed anything because no paper
if my document not printing success have to return false and if my document in a queue errorType have to return some information about it
### Actual Behavior
success true
and no errorType
### Testcase Gist URL
_No response_
### Additional Information
_No response_ | https://github.com/electron/electron/issues/38975 | https://github.com/electron/electron/pull/38976 | c7bdd907d7e1fdcb7741de02f5ca23d47a436437 | 117a700724074dfc62649e3e561ff284f07e7cae | 2023-07-03T13:55:41Z | c++ | 2023-07-10T13:26:29Z |
closed | electron/electron | https://github.com/electron/electron | 38,961 | ["chromium_src/BUILD.gn", "shell/browser/electron_browser_main_parts.cc", "shell/browser/electron_browser_main_parts.h"] | [Feature Request] Set GTK UIs to dark theme when xdg-desktop-portal prefer dark/light setting is used | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a feature request that matches the one I want to file, without success.
### Problem Description
With chromium 114, xdg-desktop-portal becomes a supported way of setting dark theme. This setting is just a preference(The setting does not set a dark GTK theme by itself) and the task of setting a the appropriate light/dark theme based on the preference lies entirely on the app/library/framework.
Currently, chromium's implementation with GTK UI does not do this, where the setting only affects `prefers-color-scheme` media query and not GTK UIs. So, the task of setting the appropriate GTK theme to GTK UIs will lie on electron.
Why is this important
- Wayland CSD : on GNOME Wayland, electron's CSD will be used, which is GTK
- FIle chooser dialogue : On Linux, electron uses the GTK file chooser
- Native prompt dialogue : Electron's native prompt dialouge is GTK
### Proposed Solution
Set a dark GTK theme to be used in electron when xdg-desktop-portal prefer-dark setting is used
Likewise when prefer-light is use
there is also the "no prefernce" setting to keep in mind
### Alternatives Considered
For this issue to be handled upstream in chromium
### Additional Information
GTK themes have a dark variant if the theme's folder has a `gtk-dark.css` file.
Also where this works currently :
- Firefox
- Libreoffice
- libhandy apps | https://github.com/electron/electron/issues/38961 | https://github.com/electron/electron/pull/38977 | a0ae691a9c1da400904934803818d345c64cd258 | 480f48b2fcf659e031e2440b9af67c38cc061aca | 2023-07-01T00:09:43Z | c++ | 2023-09-27T18:17:40Z |
closed | electron/electron | https://github.com/electron/electron | 38,944 | ["patches/chromium/printing.patch"] | [Bug]: print() crashes on Windows, but works on macOS | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
25.2.0
### What operating system are you using?
Windows
### Operating System Version
Windows 10
### What arch are you using?
x64
### Last Known Working Electron version
_No response_
### Expected Behavior
webContents.print() should work and print page:)
### Actual Behavior
in doesnt. When I call print(), app crashes silently. I can't catch any logs, even with process uncaughtException/unhandledRejection events.
### Testcase Gist URL
_No response_
### Additional Information
I have created new empty project to test this bug. I have empty project with only one window. I just load image to the window and try to print it.
```
const createWindow = () => {
const mainWindow = new BrowserWindow({
width: 800,
height: 600,
});
mainWindow.loadURL(
"https://www.kasandbox.org/programming-images/avatars/leaf-blue.png"
);
mainWindow.webContents.openDevTools();
mainWindow.webContents.on("did-finish-load", () => {
console.log("did-finish-load");
mainWindow.webContents.print({
// silent: true,
// deviceName: "Xprinter XP-365B",
});
});
};
```
I have tested it in different environments and different electron version (including latest ^26.0.0-beta.1). I works on macOS and always crashes on Windows (I've tried different versions: win 10, win 11, parallels, etc).
Can you give me an advice, how it can be fixed? | https://github.com/electron/electron/issues/38944 | https://github.com/electron/electron/pull/38976 | c7bdd907d7e1fdcb7741de02f5ca23d47a436437 | 117a700724074dfc62649e3e561ff284f07e7cae | 2023-06-28T23:10:46Z | c++ | 2023-07-10T13:26:29Z |
closed | electron/electron | https://github.com/electron/electron | 38,941 | ["shell/browser/api/electron_api_web_contents.cc", "spec/fixtures/crash-cases/webview-remove-on-wc-close/index.html", "spec/fixtures/crash-cases/webview-remove-on-wc-close/index.js", "spec/fixtures/crash-cases/webview-remove-on-wc-close/webview.html"] | [Bug]: Crash after removing the webview that fired will-prevent-unload and called event.preventDefault(). | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
22.0.0 or higher
### What operating system are you using?
Windows
### Operating System Version
windows 11 22h2
### What arch are you using?
x64
### Last Known Working Electron version
21.4.4
### Expected Behavior
Not crash.
### Actual Behavior
Crash.
### Testcase Gist URL
https://gist.github.com/asd281533890/aede872ca474bc546185053e2bad9a52
### Additional Information
npm run start. click the webview page text (to trigger will-prevent-unload), then click the close webview button. At this time, the close confirmation dialog will pop up, click to leave, and the app will crash. | https://github.com/electron/electron/issues/38941 | https://github.com/electron/electron/pull/38996 | 5a77c75753f560bbc4fe6560441ba88433a561f8 | c7a64ab994de826ed6e4c300cce75d9fd88efa20 | 2023-06-28T07:41:44Z | c++ | 2023-07-06T08:20:34Z |
closed | electron/electron | https://github.com/electron/electron | 38,939 | ["shell/browser/native_window.h", "shell/browser/native_window_mac.h", "shell/browser/native_window_mac.mm", "spec/api-browser-window-spec.ts"] | [Bug]: Electron often crashes with SIGSEGV error on setParentWindow method | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
25.2.0
### What operating system are you using?
macOS
### Operating System Version
macOS 13.0.1
### What arch are you using?
arm64 (including Apple Silicon)
### Last Known Working Electron version
23.3.8
### Expected Behavior
Second parent window and child window normally show and app continues to work without critical errors.
### Actual Behavior
On `setParentWindow` method the app often crashes with following error:
`Electron exited with signal SIGSEGV.`
### Testcase Gist URL
https://gist.github.com/3b45265f63e8ebfd233665989b81cdab
### Additional Information
Sometimes Electron correctly execute `setParentWindow` method. | https://github.com/electron/electron/issues/38939 | https://github.com/electron/electron/pull/39062 | fa5b1be6f3d6631c0404097b69ea81b4a1eab7f7 | 695fcf3cb265aa2b635e9bfdad4e0affe527c917 | 2023-06-27T15:46:41Z | c++ | 2023-07-26T14:47:32Z |
closed | electron/electron | https://github.com/electron/electron | 38,937 | ["patches/chromium/.patches", "patches/chromium/revert_simplify_dwm_transitions_on_windows.patch", "shell/browser/native_window.cc", "shell/browser/native_window.h", "shell/browser/native_window_views.cc", "shell/browser/native_window_views.h"] | [Test]: Failing BrowserWindow.setAspectRatio(ratio) doesn\'t change bounds when maximum size is set | https://chromium-review.googlesource.com/c/chromium/src/+/4575565 that comes as part of the roll https://github.com/electron/electron/pull/38891 breaks the calculation of content bounds when adjusting the maximum/minimum size.
The calculation done as part of https://github.com/electron/electron/blob/09669f9d215ceb96d7f02f9085d7906e27c2b301/shell/browser/native_window_views.cc#L1526-L1528 conflicts with the adjustments in https://github.com/electron/electron/blob/main/patches/chromium/fix_aspect_ratio_with_max_size.patch leading to the following dcheck failure in the said test
```
FATAL:resize_utils.cc(48)] Check failed: Rect(rect.origin(), *max_window_size).Contains(rect). 312,164 400x400 is larger than the maximum size 390x390
```
I tried to resolve this via the following patch which address the failing test but introduces regression in other bound calculations. @zcbenz can you take a look at this, thanks!
```patch
diff --git a/shell/browser/native_window_views.cc b/shell/browser/native_window_views.cc
index a1581d98d0..48bc8ac23e 100644
--- a/shell/browser/native_window_views.cc
+++ b/shell/browser/native_window_views.cc
@@ -1521,11 +1521,10 @@ gfx::Rect NativeWindowViews::WindowBoundsToContentBounds(
#if BUILDFLAG(IS_WIN)
HWND hwnd = GetAcceleratedWidget();
content_bounds.set_size(DIPToScreenRect(hwnd, content_bounds).size());
- RECT rect;
- SetRectEmpty(&rect);
- DWORD style = ::GetWindowLong(hwnd, GWL_STYLE);
- DWORD ex_style = ::GetWindowLong(hwnd, GWL_EXSTYLE);
- AdjustWindowRectEx(&rect, style, FALSE, ex_style);
+ RECT rect, client_rect;
+ GetClientRect(hwnd, &client_rect);
+ GetWindowRect(hwnd, &rect);
+ CR_DEFLATE_RECT(&rect, &client_rect);
content_bounds.set_width(content_bounds.width() - (rect.right - rect.left));
content_bounds.set_height(content_bounds.height() - (rect.bottom - rect.top));
content_bounds.set_size(ScreenToDIPRect(hwnd, content_bounds).size());
``` | https://github.com/electron/electron/issues/38937 | https://github.com/electron/electron/pull/38974 | 52fe76ca28286400ab61927b2b4e937c52ae9ab5 | 3fa15ebb7e8aef2029cd23370fdc96f382c9d161 | 2023-06-27T13:33:18Z | c++ | 2023-07-05T15:02:05Z |
closed | electron/electron | https://github.com/electron/electron | 38,844 | ["shell/renderer/electron_render_frame_observer.cc", "spec/chromium-spec.ts"] | [Bug]: Preload script not running on child-window "top" frame | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
16.0.5
### What operating system are you using?
Ubuntu
### Operating System Version
20.04
### What arch are you using?
x64
### Last Known Working Electron version
16.0.4
### Expected Behavior
I have an app that uses the preload script on some contexts.
Recently I found out that in some scenarios the preload script is not running.
Im using the setWindowOpenHandler function in order to use the same preload in all future child window that will be created.
Electron fiddle gist is added for refrence.
Bug flow:
1. Go to gmail.com.
2. Click on the "meet" button on the left.
3. Click on "New Meeting"
4. A pop up will open up
5. The expected behaviour is to have preload script running on this window as well.
### Actual Behavior
Bug flow:
1. Go to gmail.com.
2. Click on the "meet" button on the left.
3. Click on "New Meeting"
4. A pop up will open up
5. The actual behaviour is that the preload script does not run at all on the top frame.
### Testcase Gist URL
https://gist.github.com/cbb4249641359cce34b87c0203b55d8a
### Additional Information
Tested also 26.0.0-alpha.7 to make sure its not something that was fixed in newer versions
Looking at the release notes this PR seems to be what's causing this bug: https://github.com/electron/electron/pull/32108 | https://github.com/electron/electron/issues/38844 | https://github.com/electron/electron/pull/38910 | ff6d0df2d534efe1aa8d466e1ea75333290cb0dc | 09669f9d215ceb96d7f02f9085d7906e27c2b301 | 2023-06-19T13:51:28Z | c++ | 2023-06-26T21:04:54Z |
closed | electron/electron | https://github.com/electron/electron | 38,837 | ["lib/browser/api/web-contents.ts"] | [Bug]: webContents.print() fails for immutable object parameter | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
25.1.1
### What operating system are you using?
Windows
### Operating System Version
Windows Version 10.0.19044 Build 19044
### What arch are you using?
x64
### Last Known Working Electron version
24.2.0
### Expected Behavior
Making the following request results in a _printer selection dialog_ being displayed:
```
webContents.print(Object.freeze({
silent: false,
printBackground: true,
}));
```
### Actual Behavior
The app crashes with the following message:
```
(node:54988) UnhandledPromiseRejectionWarning: TypeError: Cannot add property mediaSize, object is not extensible
at _.print (node:electron/js2c/browser_init:2:83987)
at createWindow (C:\Users\xxx\AppData\Local\Temp\electron-fiddle-25576-SCjuZwebgVHq\main.js:21:26)
at C:\Users\xxx\AppData\Local\Temp\electron-fiddle-25576-SCjuZwebgVHq\main.js:31:3
(Use `electron --trace-warnings ...` to show where the warning was created)
(node:54988) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
[54988:0620/131209.732:ERROR:CONSOLE(1)] "Uncaught (in promise) TypeError: Failed to fetch", source: devtools://devtools/bundled/panels/elements/elements.js (1)
```
### Testcase Gist URL
https://gist.github.com/289e2f14fcbcf98e1e0aba55b7204d4e
### Additional Information
_No response_ | https://github.com/electron/electron/issues/38837 | https://github.com/electron/electron/pull/39985 | 689d1b76de36ca6f63e291ef019da004b8ca3559 | c8156c3c57ad8b6e19353725805843202977c1e7 | 2023-06-19T09:10:38Z | c++ | 2023-09-28T08:41:46Z |
closed | electron/electron | https://github.com/electron/electron | 38,786 | ["shell/browser/ui/views/client_frame_view_linux.cc"] | wayland csd on gnome are broke for 25.x and newer. | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
25.1
### What operating system are you using?
Other Linux
### Operating System Version
Arch Linux / 6.3.7-zen1-1-zen
### What arch are you using?
x64
### Last Known Working Electron version
24.5
### Expected Behavior
`$ electron24 --ozone-platform-hint=auto --enable-features=UseOzonePlatform,WaylandWindowDecorations`
### Actual Behavior
`$ electron25 --ozone-platform-hint=auto --enable-features=UseOzonePlatform,WaylandWindowDecorations`
### Testcase Gist URL
_No response_
### Additional Information
any electron version newer than 24 (25/alpha-26/nightbuild-27) are broken | https://github.com/electron/electron/issues/38786 | https://github.com/electron/electron/pull/39003 | f3f3f5390423207bd2d26e398a565bf2f13dc759 | 3e3152008ff569632e0b36d53ac9a24fae515709 | 2023-06-14T13:19:56Z | c++ | 2023-07-10T20:52:12Z |
closed | electron/electron | https://github.com/electron/electron | 38,751 | ["lib/browser/api/web-contents.ts"] | [Bug]: webContens.printPDF preferCSSPageSize throws an error exception message | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
22.2.10
### What operating system are you using?
Windows
### Operating System Version
win 11
### What arch are you using?
x64
### Last Known Working Electron version
_No response_
### Expected Behavior
Error preferCSSPageSize Indicates a preferCSSPageSize error
### Actual Behavior
This is electron source code, path: /lib/browser/api/web-contents.ts/printToPDF
### Testcase Gist URL
_No response_
### Additional Information
_No response_ | https://github.com/electron/electron/issues/38751 | https://github.com/electron/electron/pull/38761 | dc2e822dc7cd4554ba08bbb67e68e377ac936251 | 10852b3fd50865c00e5a62fa934b96973ba5c643 | 2023-06-13T02:13:03Z | c++ | 2023-06-14T14:49:00Z |
closed | electron/electron | https://github.com/electron/electron | 38,732 | ["patches/chromium/fix_crash_on_nativetheme_change_during_context_menu_close.patch"] | [Bug]: Crash if theme is changed via application menu | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
25.0.0
### What operating system are you using?
Windows
### Operating System Version
Windows 11 22H2
### What arch are you using?
x64
### Last Known Working Electron version
24.5.0
### Expected Behavior
The application changes the theme, e.g. the application menu is colored accordingly and it doesn't crash.
### Actual Behavior
As soon the theme is changed via the application menu, the application crashes. On the console appears following output:
```
[36016:0612/045936.512:ERROR:crashpad_client_win.cc(844)] not connected
```
### Testcase Gist URL
https://gist.github.com/c9e0ce78e7811ce716923f4ad7111c8c
### Additional Information
Selecting the currently used theme has no effect.
This bug was introduced with Electron 25.0.0-alpha.1
Electron 26.0.0-alpha.5 is still affected as are (probably) all versions in between (I didn't try all). | https://github.com/electron/electron/issues/38732 | https://github.com/electron/electron/pull/38998 | c7a64ab994de826ed6e4c300cce75d9fd88efa20 | cc7d724a3b85a858044916e5a4b61269610cab09 | 2023-06-12T03:08:39Z | c++ | 2023-07-06T13:46:12Z |
closed | electron/electron | https://github.com/electron/electron | 38,676 | ["docs/api/accelerator.md", "shell/common/keyboard_util.cc"] | [Feature Request]: Document which exact punctuation keys are supported | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a feature request that matches the one I want to file, without success.
### Problem Description
The [docs](https://www.electronjs.org/docs/latest/api/accelerator) are a little vague on the matter, saying:
> `Punctuation like ~, !, @, #, $, etc.`
But like better to be precise with these things. Like presumably `[` is supported, but what happens if I do a `Shift+[`, does that work? Or is that interpreted as a single `{`? And what about weird characters like `§` and `±`, are those supported?
### Proposed Solution
Being very explicit in documenting what exactly the syntax for accelerators is.
### Alternatives Considered
Finding out manually.
### Additional Information
_No response_ | https://github.com/electron/electron/issues/38676 | https://github.com/electron/electron/pull/38740 | f5869b6fb936ba125071f6560ae8c871e4488777 | 678d1aa37d26548004b0ad5df1ac027626c4ab2a | 2023-06-08T09:07:52Z | c++ | 2023-06-13T10:42:55Z |
closed | electron/electron | https://github.com/electron/electron | 38,667 | ["shell/browser/ui/views/win_caption_button_container.cc"] | [Bug]: The zoom out button of the window cannot be displayed properly | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
22.3.12
### What operating system are you using?
Windows
### Operating System Version
windows10，windows11, windows8, windows7
### What arch are you using?
x64
### Last Known Working Electron version
_No response_
### Expected Behavior
During the process of using the BrowserWindow instance option, "titleBarStyle: hidden" and "titleBarOverlay: true" were set, and then the window's setMinimizable (false) was set through ipc; setMaximizable(false); setClosable(false); The result is obvious that the zoom in and zoom in buttons are hidden, and the close button is disabled and displayed. This is normal, but setMinimizable (true) is set in reverse through ipc; setMaximizable(true); setClosable(true); The results show that the close button, zoom in button, and zoom out button are displayed normally
### Actual Behavior
During the process of using the BrowserWindow instance option, "titleBarStyle: hidden" and "titleBarOverlay: true" were set, and then the window's setMinimizable (false) was set through ipc; setMaximizable(false); setClosable(false); The result is obvious that the zoom in and zoom in buttons are hidden, and the close button is disabled and displayed. This is normal, but setMinimizable (true) is set in reverse through ipc; setMaximizable(true); setClosable(true); The result shows that the close button and zoom in button are displayed normally, while the zoom out button cannot be displayed
### Testcase Gist URL
https://gist.github.com/4b725c80ec42886b16a957897431c750
### Additional Information
Even with the latest 25.1.0, it still performs the same!!!! | https://github.com/electron/electron/issues/38667 | https://github.com/electron/electron/pull/38860 | e73edb54817acb8f0e548916a97a9ed9340dfc3f | ce6fe040feefe326a557132fb81137097d4a39c1 | 2023-06-08T06:16:25Z | c++ | 2023-06-21T18:58:33Z |
closed | electron/electron | https://github.com/electron/electron | 38,598 | ["lib/browser/api/web-contents.ts", "spec/api-web-contents-spec.ts", "typings/internal-electron.d.ts"] | [Bug]: webContents.print fails with unspecified options | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
25.0.0
### What operating system are you using?
Windows
### Operating System Version
Windows 10 version 21H2
### What arch are you using?
x64
### Last Known Working Electron version
24.4.1
### Expected Behavior
Calling `webContents.print()`, `webContents.print({})`, or `webContents.print(null)` will result in the system print dialog to appearing.
### Actual Behavior
If `print()` or `print({})` are called, the call will never invoke the provided callback (at least not within 5 minutes, which was the longest I let it sit), nor will it throw any exceptions catchable by a try-catch block. When running the provided gist in Electron Fiddle, I see the following console log: "[19232:0605/173028.939:ERROR:device_event_log_impl.cc(222)] [17:30:28.939] Printer: print_view_manager_base.cc:352 Printer settings invalid for \\epic-print1\vca2cpy-Revenge (destination type kLocal): content size is empty; page size is empty; printable area is empty"
If `print(null)` is called, an exception will be thrown with the error message: "Cannot read properties of null (reading 'pageSize')".
### Testcase Gist URL
https://gist.github.com/mgalla10/7710e8f22830f1122cfe0d98dd99ab08
### Additional Information
_No response_ | https://github.com/electron/electron/issues/38598 | https://github.com/electron/electron/pull/38614 | e8fd5fd3a8250d44a0665ca18da34cb09ea30677 | c0d9764de9d00968a8c9d5ab74ef3b9840aebc09 | 2023-06-05T22:43:02Z | c++ | 2023-06-09T19:41:01Z |
closed | electron/electron | https://github.com/electron/electron | 38,592 | ["shell/browser/browser.cc", "shell/browser/browser.h", "shell/browser/browser_mac.mm", "shell/common/api/electron_api_native_image.cc"] | [Bug]: crash when resizing `nativeImage` before app is ready | ### Preflight Checklist
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
25.0.0
### What operating system are you using?
Ubuntu
### Operating System Version
22.04.2
### What arch are you using?
x64
### Last Known Working Electron version
24.4.0
### Expected Behavior
Electron should start.
### Actual Behavior
Electron doesn't start.
### Testcase Gist URL
_No response_
### Additional Information
_No response_ | https://github.com/electron/electron/issues/38592 | https://github.com/electron/electron/pull/38836 | 2b3902e526d57a37c68f8f7c5dd370358c5c06f7 | f6bbc3465888a113db91e16647e54a2aa4650606 | 2023-06-05T13:27:11Z | c++ | 2023-06-20T16:24:03Z |
closed | electron/electron | https://github.com/electron/electron | 38,588 | ["spec/api-content-tracing-spec.ts"] | Flaky contentTracing v8 sampling spec | `contentTracing captured events include V8 samples from the main process` has been flaking a fair amount on Appveyor as of late.
See [here](https://ci.appveyor.com/project/electron-bot/electron-x64-testing/builds/47184539/job/6ycj2f45a7flb0dc/tests) for example. | https://github.com/electron/electron/issues/38588 | https://github.com/electron/electron/pull/39682 | f27b0340454ada29977a7d08f2dbc8321923e1b1 | 4cc0f6fb781a3efe6b018aa4ef410e4196c03ecf | 2023-06-05T09:38:39Z | c++ | 2023-09-04T12:08:26Z |
closed | electron/electron | https://github.com/electron/electron | 38,562 | ["shell/browser/native_window_mac.h", "shell/browser/native_window_mac.mm", "spec/api-browser-window-spec.ts"] | [Bug]: Crash when opening and closing a child window a few times on macOS | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
25.0.1
### What operating system are you using?
macOS
### Operating System Version
Ventura 13.4
### What arch are you using?
x64
### Last Known Working Electron version
_No response_
### Expected Behavior
A child window should be able to be opened and closed multiple times without crashing.
### Actual Behavior
The Electron app crashes after opening a child window and then closing it. This usually happens after opening the child window a few times in a row.
### Testcase Gist URL
https://gist.github.com/jorodi/cbf4378f978e44de5034ab2d91f30387
### Additional Information
Caught error output from VS code terminal:
```
2023-06-02 08:24:57.023 Electron[80994:4778831] -[__NSCFNumber parentWindow]: unrecognized selector sent to instance 0x3f030a000201160f
2023-06-02 08:24:57.025 Electron[80994:4778831] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[__NSCFNumber parentWindow]: unrecognized selector sent to instance 0x3f030a000201160f'
*** First throw call stack:
(
0 CoreFoundation 0x00007ff802c7918a __exceptionPreprocess + 242
1 libobjc.A.dylib 0x00007ff80279f42b objc_exception_throw + 48
2 CoreFoundation 0x00007ff802d14fef -[NSObject(NSObject) __retain_OA] + 0
3 CoreFoundation 0x00007ff802be4797 ___forwarding___ + 1392
4 CoreFoundation 0x00007ff802be4198 _CF_forwarding_prep_0 + 120
5 Electron Framework 0x000000010b707e38 _ZNK2v88internal11interpreter20BytecodeArrayBuilder5LocalEi + 154760
6 Electron Framework 0x000000010b7073e0 _ZNK2v88internal11interpreter20BytecodeArrayBuilder5LocalEi + 152112
7 Electron Framework 0x000000010b646b23 _ZN2v89CodeEvent10GetCommentEv + 4099
8 Electron Framework 0x000000010b56dc93 ElectronInitializeICUandStartNode + 207619
9 Electron Framework 0x000000010b56f2c4 ElectronInitializeICUandStartNode + 213300
10 Electron Framework 0x000000010b56f9fe ElectronInitializeICUandStartNode + 215150
11 Electron Framework 0x000000010b5634e1 ElectronInitializeICUandStartNode + 164689
12 Electron Framework 0x000000010b5633d3 ElectronInitializeICUandStartNode + 164419
13 Electron Framework 0x000000010c83be34 _ZN2v88internal9Accessors12MakeAccessorEPNS0_7IsolateENS0_6HandleINS0_4NameEEEPFvNS_5LocalINS_4NameEEERKNS_20PropertyCallbackInfoINS_5ValueEEEEPFvS9_NS7_ISB_EERKNSA_INS_7BooleanEEEE + 15780
14 Electron Framework 0x000000010c83b9df _ZN2v88internal9Accessors12MakeAccessorEPNS0_7IsolateENS0_6HandleINS0_4NameEEEPFvNS_5LocalINS_4NameEEERKNS_20PropertyCallbackInfoINS_5ValueEEEEPFvS9_NS7_ISB_EERKNSA_INS_7BooleanEEEE + 14671
15 Electron Framework 0x000000010c83ad24 _ZN2v88internal9Accessors12MakeAccessorEPNS0_7IsolateENS0_6HandleINS0_4NameEEEPFvNS_5LocalINS_4NameEEERKNS_20PropertyCallbackInfoINS_5ValueEEEEPFvS9_NS7_ISB_EERKNSA_INS_7BooleanEEEE + 11412
16 Electron Framework 0x000000010b25edf6 Electron Framework + 826870
17 Electron Framework 0x000000010b1c4ff2 Electron Framework + 196594
)
/Users/jordan/parent-child-error/node_modules/electron/dist/Electron.app/Contents/MacOS/Electron exited with signal SIGILL
``` | https://github.com/electron/electron/issues/38562 | https://github.com/electron/electron/pull/38603 | 9a9d8ae5ea61e17fd01e8975e81ed2a137a5fef6 | 5ee890fb6f7c6acbcfd8e6e765334e6f9aa61850 | 2023-06-02T13:02:06Z | c++ | 2023-06-08T10:18:37Z |
closed | electron/electron | https://github.com/electron/electron | 38,553 | ["lib/browser/api/protocol.ts", "spec/api-protocol-spec.ts"] | [Bug]: TypeError: undefined is not iterable | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
25.0.1
### What operating system are you using?
Ubuntu
### Operating System Version
Ubuntu 23.04
### What arch are you using?
x64
### Last Known Working Electron version
_No response_
### Expected Behavior
When using the `protocol.handle` api and returning an empty object as a result, a helpful error message is displayed to the user.
### Actual Behavior
When using the `protocol.handle` api and returning an empty object as a result, the output is as follows:
```
TypeError: undefined is not iterable
at Function.fromEntries (<anonymous>)
at AsyncFunction.<anonymous> (node:electron/js2c/browser_init:2:57533)
```
This error is kind of hard to debug since the error message doesn't point in the right direction and the stack trace doesn't include any user defined function.
### Testcase Gist URL
https://gist.github.com/SimonSiefke/cf52088c800054d6a63b16633db4d540
### Additional Information
I believe the error is happening here:
https://github.com/electron/electron/blob/d818f35ad4ec44c83f21dd3656ef1072e196c34f/lib/browser/api/protocol.ts#L76C5-L91
One idea could be to check if res is actually of type Response and throw a user-friendly error if not:
```js
if (!res || typeof res !== 'object' || !(res instanceof Response)) { // check if res is valid
throw new Error(`protocol response must be of type Response`) // throw user friendly error
}
``` | https://github.com/electron/electron/issues/38553 | https://github.com/electron/electron/pull/38587 | 5931f69f183bfcd57c9dc7dffe8560ac9163bb45 | 86824c070e31a674f6f523b52426549efc61aa6d | 2023-06-01T15:22:07Z | c++ | 2023-06-07T07:29:04Z |
closed | electron/electron | https://github.com/electron/electron | 38,532 | ["patches/chromium/.patches", "patches/chromium/fix_activate_background_material_on_windows.patch", "shell/browser/api/electron_api_browser_window.cc", "shell/browser/native_window.cc", "shell/browser/native_window.h", "shell/browser/native_window_mac.mm", "shell/browser/native_window_views.cc"] | [Feature Request]: Support full frame transparency with Mica background material | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a feature request that matches the one I want to file, without success.
### Problem Description
The [Mica `backgroundMaterial`](https://github.com/electron/electron/pull/38163) effect does not appear below the WebContents.
### Proposed Solution
The `backgroundMaterial` option should behave the same as when setting the `vibrancy` option.
| macOS: `vibrancy: 'medium-light'` | Windows: `backgroundMaterial: 'acrylic'` | Windows: `backgroundMaterial: 'acrylic'` + `transparent: true` |
| --- | --- | --- |
|  |  |  |
When `vibrancy` is set, the WebContents is transparent by default. The same should apply to `backgroundMaterial`. Setting `transparent: true` doesn't seem to be a valid workaround, but ideally should still work.
The code below needs to be updated:
https://github.com/electron/electron/blob/9ffffdb6ef202bd93be496b53fdd4156dd3504ce/shell/browser/api/electron_api_browser_window.cc#L58-L64
### Alternatives Considered
None.
### Additional Information
Tested on:
```
Edition Windows 11 Pro
Version 22H2
OS build 22621.1778
```
Fiddle gist: https://gist.github.com/34cf667b21a5075d1f6fbe093d7ad7f9 | https://github.com/electron/electron/issues/38532 | https://github.com/electron/electron/pull/39708 | ab185c058f894ddc556f67b2853de4adad2bb10c | d1827941790f23b241ef3f234a9782750ac97e8d | 2023-05-31T20:43:55Z | c++ | 2023-09-11T12:51:54Z |
closed | electron/electron | https://github.com/electron/electron | 38,484 | ["shell/browser/browser_process_impl.cc", "shell/browser/browser_process_impl.h", "shell/browser/electron_browser_main_parts.cc", "spec/chromium-spec.ts"] | [Bug]: navigator.connection.rtt is always 0 | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
24.3.1
### What operating system are you using?
Ubuntu
### Operating System Version
20.04.1
### What arch are you using?
x64
### Last Known Working Electron version
_No response_
### Expected Behavior
Executing `navigator.connection.rtt` should return a non-zero value when configured:
```
window.webContents.session.enableNetworkEmulation({
latency: 500,
downloadThroughput: 6400,
uploadThroughput: 6400
})
```
### Actual Behavior
when executing `navigator.connection.rtt` in the debugger console, this value is always `0`. However calling the same statement in Chromium based browsers returns a variety of values.
[Electron Docs](https://www.electronjs.org/docs/latest/api/session#sesenablenetworkemulationoptions)
### Testcase Gist URL
_No response_
### Additional Information
_No response_ | https://github.com/electron/electron/issues/38484 | https://github.com/electron/electron/pull/38491 | 67f273a6d69eb43fda8a520d5c9bba375a6bcdab | 57147d1b8d1352e8f49d6086b9957869d0d1e75a | 2023-05-30T04:30:26Z | c++ | 2023-05-31T15:06:25Z |
closed | electron/electron | https://github.com/electron/electron | 38,459 | ["shell/browser/native_window.h", "shell/browser/native_window_mac.h", "shell/browser/native_window_mac.mm", "shell/browser/ui/cocoa/electron_ns_window_delegate.mm", "spec/api-browser-window-spec.ts"] | [Bug]: DCHECK when minimizing parent window with non-modal child on macOS | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
[`main@ddcec84`](https://github.com/electron/electron/commit/ddcec84ace5f9f3d4bf705c5bd963abc415160d3)
### What operating system are you using?
macOS
### Operating System Version
macOS Ventura 13.3 (22E252)
### What arch are you using?
arm64 (including Apple Silicon)
### Last Known Working Electron version
N/A
### Expected Behavior
A parent window with a non-modal child can be minimized with no errors.
### Actual Behavior
There is a DCHECK:
<details>
```
[84022:0525/192146.720343:FATAL:native_widget_ns_window_bridge.mm(1688)] Check failed: 0u == CountBridgedWindows([window_ childWindows]) (0 vs. 1)
0 Electron Framework 0x000000011c10ccf8 base::debug::CollectStackTrace(void**, unsigned long) + 28
1 Electron Framework 0x000000011c0fdee8 base::debug::StackTrace::StackTrace() + 24
2 Electron Framework 0x000000011c04a08c logging::LogMessage::~LogMessage() + 156
3 Electron Framework 0x000000011c0360e0 logging::(anonymous namespace)::DCheckLogMessage::~DCheckLogMessage() + 60
4 Electron Framework 0x000000011c035eec logging::CheckError::~CheckError() + 40
5 Electron Framework 0x000000011c035f1c logging::CheckError::~CheckError() + 12
6 Electron Framework 0x000000011db23f58 remote_cocoa::NativeWidgetNSWindowBridge::NotifyVisibilityChangeDown() + 796
7 Electron Framework 0x000000011db23c20 remote_cocoa::NativeWidgetNSWindowBridge::OnVisibilityChanged() + 160
8 Electron Framework 0x0000000117ac4bfc -[ElectronNSWindowDelegate windowDidMiniaturize:] + 48
9 CoreFoundation 0x00000001a5993254 __CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER__ + 148
10 CoreFoundation 0x00000001a5a2ef30 ___CFXRegistrationPost_block_invoke + 88
11 CoreFoundation 0x00000001a5a2ee78 _CFXRegistrationPost + 440
12 CoreFoundation 0x00000001a5964580 _CFXNotificationPost + 704
13 Foundation 0x00000001a68c19e4 -[NSNotificationCenter postNotificationName:object:userInfo:] + 88
14 AppKit 0x00000001a93a58e8 -[NSWindow(NSWindow_Theme) _finishMinimizeToDock] + 244
15 AppKit 0x00000001a8ceb534 _NSCGSDockMessageReceive + 460
16 HIToolbox 0x00000001af1f76ac DockCallback(unsigned int, unsigned int, void*, void*) + 1528
17 HIServices 0x00000001ab11b3f0 _DCXTransactionComplete + 56
18 HIServices 0x00000001ab11b38c _XTransactionComplete + 60
19 HIServices 0x00000001ab10c52c mshMIGPerform + 204
20 CoreFoundation 0x00000001a599eca0 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE1_PERFORM_FUNCTION__ + 60
21 CoreFoundation 0x00000001a599ebc0 __CFRunLoopDoSource1 + 520
22 CoreFoundation 0x00000001a599d5a0 __CFRunLoopRun + 2240
23 CoreFoundation 0x00000001a599c58c CFRunLoopRunSpecific + 612
24 HIServices 0x00000001ab11b30c waitForTransaction + 196
25 AppKit 0x00000001a939de14 minimizeItems + 120
26 AppKit 0x00000001a93a4fa4 -[NSWindow(NSWindow_Theme) _regularMinimizeToDock] + 60
27 Electron Framework 0x000000011db1de00 -[NativeWidgetMacNSWindow _regularMinimizeToDock] + 96
28 AppKit 0x00000001a93a4fe4 -[NSWindow(NSWindow_Theme) _minimizeToDockBypassingWindowManager] + 36
29 AppKit 0x00000001a952113c __75-[NSWMWindowCoordinator clientWindowManager:windowMiniaturizationResponse:]_block_invoke + 424
30 AppKit 0x00000001a952179c ___NSMainRunLoopPerformBlockInModes_block_invoke + 44
31 CoreFoundation 0x00000001a599e2a8 __CFRUNLOOP_IS_CALLING_OUT_TO_A_BLOCK__ + 28
32 CoreFoundation 0x00000001a599e1bc __CFRunLoopDoBlocks + 364
33 CoreFoundation 0x00000001a599d660 __CFRunLoopRun + 2432
34 CoreFoundation 0x00000001a599c58c CFRunLoopRunSpecific + 612
35 HIToolbox 0x00000001af1d1df4 RunCurrentEventLoopInMode + 292
36 HIToolbox 0x00000001af1d1c30 ReceiveNextEventCommon + 648
37 HIToolbox 0x00000001af1d1988 _BlockUntilNextEventMatchingListInModeWithFilter + 76
38 AppKit 0x00000001a8bbbf58 _DPSNextEvent + 636
39 AppKit 0x00000001a8bbb0f4 -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 716
40 AppKit 0x00000001a8baf558 -[NSApplication run] + 464
41 Electron Framework 0x000000011c125054 base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) + 264
42 Electron Framework 0x000000011c1238c4 base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 144
43 Electron Framework 0x000000011c0bd5a8 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, base::TimeDelta) + 472
44 Electron Framework 0x000000011c077344 base::RunLoop::Run(base::Location const&) + 396
45 Electron Framework 0x000000011ae5e304 content::BrowserMainLoop::RunMainMessageLoop() + 140
46 Electron Framework 0x000000011ae60038 content::BrowserMainRunnerImpl::Run() + 44
47 Electron Framework 0x000000011ae5b7f4 content::BrowserMain(content::MainFunctionParams) + 160
48 Electron Framework 0x0000000117c10388 content::RunBrowserProcessMain(content::MainFunctionParams, content::ContentMainDelegate*) + 280
49 Electron Framework 0x0000000117c118a4 content::ContentMainRunnerImpl::RunBrowser(content::MainFunctionParams, bool) + 600
50 Electron Framework 0x0000000117c114b8 content::ContentMainRunnerImpl::Run() + 808
51 Electron Framework 0x0000000117c0f934 content::RunContentProcess(content::ContentMainParams, content::ContentMainRunner*) + 1296
52 Electron Framework 0x0000000117c0fb98 content::ContentMain(content::ContentMainParams) + 112
53 Electron Framework 0x00000001178cad9c ElectronMain + 128
54 dyld 0x00000001a5567f28 start + 2236
Crash keys:
"amfi-status" = "rv=0 status=0x0 allow_everything=0"
"platform" = "darwin"
"process_type" = "browser"
Electron exited with signal SIGTRAP.
```
</details>
### Testcase Gist URL
https://gist.github.com/Levyks/217008d0b1335cb54b0d28101daa69ff
### Additional Information
_No response_ | https://github.com/electron/electron/issues/38459 | https://github.com/electron/electron/pull/38460 | 13f9e2db40df5537c13ee72a92fad13a0c09b730 | 40e724e5ddd92879a73fd3eb53af2b128947e9d6 | 2023-05-25T17:22:21Z | c++ | 2023-05-31T09:57:44Z |
closed | electron/electron | https://github.com/electron/electron | 38,406 | ["docs/fiddles/features/represented-file/main.js"] | [Bug]: the example in the document of represented file creates BrowserWindow twice | doc link: https://www.electronjs.org/docs/latest/tutorial/represented-file
code: https://github.com/electron/electron/blob/d8e7457ab0fa13b16d7c8e10395dd315e6fe2077/docs/fiddles/features/represented-file/main.js#L4-L18
The code in the example creates BrowserWindow both in the `createWindow` function and after `app.whenReady()`, which not loads `index.html` properly.
| https://github.com/electron/electron/issues/38406 | https://github.com/electron/electron/pull/40233 | 666907d50d2d62e31e1c3e7329f45e8350fe73cd | 09bab60a9eb110b031330545885bf07205492a1c | 2023-05-23T06:45:31Z | c++ | 2023-10-18T09:32:10Z |
closed | electron/electron | https://github.com/electron/electron | 38,385 | ["shell/browser/ui/win/electron_desktop_window_tree_host_win.cc", "shell/browser/ui/win/electron_desktop_window_tree_host_win.h"] | [Bug]: Windows look inactive when they're focused on Windows | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
25.0.0-beta.7
### What operating system are you using?
Windows
### Operating System Version
Windows 11 22H2
### What arch are you using?
x64
### Last Known Working Electron version
25.0.0-beta.3
### Expected Behavior
A basic window with a titlebar should look visually different when in focus (brighter titlebar text and icons, translucent Mica background on Windows 11).
Focused:
<img width="886" alt="Screenshot 2023-05-21 at 00 54 25" src="https://github.com/electron/electron/assets/7342119/d4449934-8127-412d-bb5f-7000e287e51e">
Unfocused:
<img width="928" alt="Screenshot 2023-05-21 at 00 54 34" src="https://github.com/electron/electron/assets/7342119/ec514c73-41a2-407f-afbb-b76f9826300f">
### Actual Behavior
As of the last few betas, windows appear inactive even when they have mouse/keyboard focus.
### Additional Information
This bug has implications for the new background material support; the materials will always appear opaque because they only take on styling from the background when the window is focused. | https://github.com/electron/electron/issues/38385 | https://github.com/electron/electron/pull/38468 | ddcec84ace5f9f3d4bf705c5bd963abc415160d3 | 56138d879e57d5d5fce55ecbe3f8d3a8ed08e7f8 | 2023-05-21T04:58:40Z | c++ | 2023-05-28T22:39:13Z |
closed | electron/electron | https://github.com/electron/electron | 38,381 | ["shell/browser/electron_browser_context.cc", "spec/api-media-handler-spec.ts"] | [Bug]: getCaptureHandle not working | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
25.0.0-beta.7
### What operating system are you using?
Windows
### Operating System Version
10.0.19042
### What arch are you using?
x64
### Last Known Working Electron version
_No response_
### Expected Behavior
Calling `getCaptureHandle` on a video track should return the shared data
See: https://developer.chrome.com/docs/web-platform/capture-handle/
### Actual Behavior
Always returns null
### Testcase Gist URL
https://gist.github.com/t57ser/919ff9c9fe623b51fde41772bf4c9207
### Additional Information
Steps to reproduce:
After starting the shared gist, click on the "open presentation" button
This opens a new window with the content that will be shared
Afterwards click "capture"
The content can be seen (shared)
The issue here is that the following text:
"Try sharing a tab that exposes information to capturing applications instead."
should display shared information by the content
| https://github.com/electron/electron/issues/38381 | https://github.com/electron/electron/pull/38390 | f07b040cb998a6126979cec9d562acbac5a23c4c | 16cd486356ec2883b36095da3e147788b71fddd5 | 2023-05-19T09:10:38Z | c++ | 2023-05-24T15:17:08Z |
closed | electron/electron | https://github.com/electron/electron | 38,339 | ["docs/api/desktop-capturer.md", "docs/api/native-image.md", "docs/api/session.md", "docs/api/web-contents.md", "docs/api/webview-tag.md", "spec/api-session-spec.ts", "spec/ts-smoke/electron/main.ts"] | Improve Type Union Typings in the Docs | [The phrasings that `electron/docs-parser` recognizes for string union types](https://github.com/electron/docs-parser/blob/c56164b4cebcf010306e0458729bf179bf69e650/src/markdown-helpers.ts#L459) is fairly narrow, and it looks like there's a handful of places in the docs where the phrasing is not being picked up as string union types.
Fix these and add smoke tests with `// @ts-expect-error` to ensure type unions are being used. See #38336 for an example.
Alternatively, extend the phrasings that `electron/docs-parser` recognizes, and add the smoke tests.
A (possibly non-exhaustive) list of ones which aren't being picked up. There's [an upstream issue](https://github.com/electron/docs-parser/issues/88) preventing certain values from being picked up.
https://github.com/electron/electron/blob/2a16c73834358f85ef20c07e50dfb5178c30bb1e/docs/api/webview-tag.md?plain=1#L1091-L1093
https://github.com/electron/electron/blob/2a16c73834358f85ef20c07e50dfb5178c30bb1e/docs/api/web-contents.md?plain=1#L796-L798
https://github.com/electron/electron/blob/2a16c73834358f85ef20c07e50dfb5178c30bb1e/docs/api/native-image.md?plain=1#L308-L309
https://github.com/electron/electron/blob/2a16c73834358f85ef20c07e50dfb5178c30bb1e/docs/api/session.md?plain=1#L577-L580
https://github.com/electron/electron/blob/2a16c73834358f85ef20c07e50dfb5178c30bb1e/docs/api/session.md?plain=1#L581-L582
https://github.com/electron/electron/blob/e08c583dea42ce70c926825a2f6d455bbddf2089/docs/api/desktop-capturer.md?plain=1#L91-L92 | https://github.com/electron/electron/issues/38339 | https://github.com/electron/electron/pull/39258 | 6df392162f1d29155e6d8d6f755de7e48c18e709 | 2b283724ce689a680b20c9b922384bec854415f6 | 2023-05-17T08:03:04Z | c++ | 2023-07-31T08:32:59Z |
closed | electron/electron | https://github.com/electron/electron | 38,245 | ["shell/browser/electron_autofill_driver.cc"] | [Bug]: datalist positioning issues in browserview are not fully fixed | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
24.2.0
### What operating system are you using?
Windows
### Operating System Version
win 11
### What arch are you using?
x64
### Last Known Working Electron version
_No response_
### Expected Behavior
The position of the datalist should display normally regardless of the x and y values of the browserview setBounds relative to the browserwindow
### Actual Behavior
If the x,y of the browserView setBounds is 0 with respect to the browserWindow, it displays normally
But if the x and y of the browserView setBounds are not 0 with respect to the browserWindow, the position of the datalist is biased
### Testcase Gist URL
https://gist.github.com/467faf384c3e25880d68ac1eba0adfe5
### Additional Information
_No response_ | https://github.com/electron/electron/issues/38245 | https://github.com/electron/electron/pull/38489 | bb2ba35b51609e40c4cae2f3f904a04c795a7430 | b2059f288acba385d91cec0cc86135605bf477cf | 2023-05-10T12:12:20Z | c++ | 2023-06-06T08:21:42Z |
closed | electron/electron | https://github.com/electron/electron | 38,215 | ["docs/api/web-contents.md"] | [Bug]: The `devtools-open-url` event has an incorrect type in typescript | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
24.2.0
### What operating system are you using?
Windows
### Operating System Version
Windows 10 version 22H2
### What arch are you using?
x64
### Last Known Working Electron version
N/A
### Expected Behavior
The `devtools-open-url` event handler is actually called with the following args: `(e: Electron.Event, url: string)`.
The typescript code for it should also reflect that.
### Actual Behavior
The typescript code for this event in electron.d.ts looks like this:
```d.ts
on(event: 'devtools-open-url', listener: (
/**
* URL of the link that was clicked or selected.
*/
url: string) => void): this;
// ... same for once, addListener, removeListener
```
Which does not have the `Event` parameter.
The code that actually works (without a runtime error) throws this error in typescript:
```
No overload matches this call.
The last overload gave the following error.
Argument of type '"devtools-open-url"' is not assignable to parameter of type '"zoom-changed"'. ts(2769)
```
And, obviously, if you follow the typescript rules, you're going to get an `Electron.Event` object instead of the expected `string` one.
### Testcase Gist URL
_No response_
### Additional Information
_No response_ | https://github.com/electron/electron/issues/38215 | https://github.com/electron/electron/pull/38231 | 13e309e1fb2491af7c4bfd6bc6e786dbeb8dfc4b | 2806feede2cf5264b0187dddfdd7fc6cca915fbf | 2023-05-08T22:27:14Z | c++ | 2023-05-10T09:25:50Z |
closed | electron/electron | https://github.com/electron/electron | 38,204 | ["shell/browser/native_window_mac.h", "shell/browser/native_window_mac.mm", "spec/api-browser-window-spec.ts"] | [Feature Request]: Stay in fullscreen when leaving Kiosk mode | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a feature request that matches the one I want to file, without success.
### Problem Description
My issue is the same as described here: https://github.com/electron/electron/issues/8338#issue-198786856. The merged fix from 2017 appears to not have made it to the newer versions of Electron.
Toggling kiosk mode to false forces an Electron app out of fullscreen, which is not the desired behavior.
### Proposed Solution
I'd like to reinstate the merged change from 2017, preserving fullscreen on disabling Kiosk mode.
### Alternatives Considered
No alternatives considered, as `setKiosk` is the only way to toggle kiosk mode.
### Additional Information
_No response_ | https://github.com/electron/electron/issues/38204 | https://github.com/electron/electron/pull/38219 | f432245456e92fe0191ae0b9275fdee60dd45452 | 13e309e1fb2491af7c4bfd6bc6e786dbeb8dfc4b | 2023-05-06T20:26:19Z | c++ | 2023-05-09T16:28:37Z |
closed | electron/electron | https://github.com/electron/electron | 38,180 | ["shell/browser/native_window_views.cc", "spec/api-browser-window-spec.ts"] | [Bug]: getNormalBounds() returns actual window bounds for transparent maximized windows | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
25.0.0
### What operating system are you using?
Windows
### Operating System Version
Windows 10
### What arch are you using?
x64
### Last Known Working Electron version
_No response_
### Expected Behavior
getNormalBounds() should return last bounds before transparent windows is maximized or minimized
### Actual Behavior
getNormalBounds() returning current bounds when transparent windows is maximized or minimized
### Testcase Gist URL
_No response_
### Additional Information
_No response_ | https://github.com/electron/electron/issues/38180 | https://github.com/electron/electron/pull/38218 | ad077125618bb3dc93dd2a660bf6c6956204bae5 | 32d8f84cad9ece93520d6d1764c9b45403284760 | 2023-05-04T08:31:21Z | c++ | 2023-05-17T11:11:43Z |
closed | electron/electron | https://github.com/electron/electron | 38,170 | ["lib/browser/api/browser-window.ts", "spec/api-browser-window-spec.ts"] | [Bug]: Accessing `BrowserWindow.id` throws an error after the window is closed/destroyed | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
24.1.3
### What operating system are you using?
macOS
### Operating System Version
macOS Ventura 13.3.1
### What arch are you using?
arm64 (including Apple Silicon)
### Last Known Working Electron version
_No response_
### Expected Behavior
I want to get the `id` of a `BrowserWindow` object, regardless of whether or not it is closed or destroyed. I expect the following to work:
```
win.on('closed', () => {
console.log('window closed, id=', win.id);
}
```
### Actual Behavior
It throws an error:
```
TypeError: Object has been destroyed
at BrowserWindow.<anonymous> (**/main.js:20:60)
at BrowserWindow.emit (node:events:513:28)
```
### Testcase Gist URL
https://gist.github.com/d1819a38f1a9327ae56d4098b9d382d1
### Additional Information
_No response_ | https://github.com/electron/electron/issues/38170 | https://github.com/electron/electron/pull/38241 | 042663e19058cebc83428a5a354b863d2bb10e31 | 9bd9d312f8d59d3a80defba4aeb760e2c3e7e10c | 2023-05-03T23:06:01Z | c++ | 2023-05-16T07:29:00Z |
closed | electron/electron | https://github.com/electron/electron | 38,161 | ["lib/sandboxed_renderer/init.ts", "spec/chromium-spec.ts", "spec/fixtures/module/preload.js"] | [Feature Request]: Allow commonjs2 scripts as sandboxed preload scripts | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a feature request that matches the one I want to file, without success.
### Problem Description
When calling a preload script in sandboxed mode, `module` is not defined. This makes code that assigns `module.exports` crash with an error like "ReferenceError: module is not defined". This is made even more confusing since electron also emits an error "Unable to load preload script" which implies that the script was not found, and not just partly executed.
This is a problem because many commonjs modules assign the `module.exports` property, as per [Node's documentation](https://nodejs.org/api/modules.html#the-module-object):
> The `module.exports` object is created by the `Module` system. Sometimes this is not acceptable; many want their module to be an instance of some class. To do this, assign the desired export object to `module.exports`.
Problematic commonjs scripts are created by:
- `webpack` in ['commonjs2' mode](https://webpack.js.org/configuration/output/#type-commonjs2), which is the recommended format (see, e.g. Quasar https://github.com/quasarframework/quasar/issues/11759)
- `esbuild`
- `parcel`
It seems that `rollup`, `swc`, and `typescript` do not reassign `module.exports` and so are not affected.
### Proposed Solution
- Pass a `module` object with a mutable `exports` property to the [preload wrapper](https://github.com/electron/electron/blob/a8c0ed890f61664156886356ecb6ab9f73c69cf1/lib/sandboxed_renderer/init.ts#L105-L107).
### Alternatives Considered
- Load the preload script as an ESM module
- Use a module loader (e.g. an actual call to `require`) instead of interpolating the preload script into an `eval` call.
### Additional Information
I'm not sure if this should be regarded as a feature request or a bug. It's quite surprising behavior and probably not intentional, so I'm leaning toward bug. | https://github.com/electron/electron/issues/38161 | https://github.com/electron/electron/pull/39484 | 90865fa97d577105987d23db017c0332029228f6 | 3102a257af400e8b9bdddf4295d901007c65a2d6 | 2023-05-03T07:01:40Z | c++ | 2023-08-22T04:43:08Z |
closed | electron/electron | https://github.com/electron/electron | 38,137 | ["docs/tutorial/tutorial-3-preload.md"] | [Docs] Wrong usage of ipcMain.handle in /tutorial-preload | This is a repost of #35157 . That issue is closed as fixed, but the merged pull request seems to fix a different unrelated issue.
### Steps to Reproduce:
1. Follow tutorial on macOS, including section "Open a window if none are open (macOS)" from [Part 2](https://www.electronjs.org/docs/latest/tutorial/tutorial-first-app#managing-your-apps-window-lifecycle).
2. Build and launch the app.
3. Close the window, open another window.
### Expected Behavior:
- A new window launches without error.
### Actual Behavior:
- An error is thrown and the window launches blank.
This is because `icpMain.handle()` is being called every time a window is created (which can be multiple times on macOS) instead of just once (i.e. inside of `app.whenReady()`)
https://github.com/electron/electron/blob/a2d35e9cf53f324d8153cb56982074e1af5fb177/docs/tutorial/tutorial-3-preload.md?plain=1#L209-L220 | https://github.com/electron/electron/issues/38137 | https://github.com/electron/electron/pull/38138 | a8c0ed890f61664156886356ecb6ab9f73c69cf1 | 7f5364f98dd8d0b0baf4d6530ac23dbb5e2634df | 2023-04-30T05:47:53Z | c++ | 2023-05-03T12:52:02Z |
closed | electron/electron | https://github.com/electron/electron | 38,024 | [".markdownlint.json", "package.json", "script/lib/markdown.ts", "script/lint-docs-links.ts", "script/markdownlint-emd001.js", "yarn.lock"] | `lint:js-in-markdown` Silently Failing | `standard-markdown` won't find JS code blocks in Markdown if they have anything after the language name, and in the docs we use ` ```js title='main.js (Main Process)' ` to add metadata to the code blocks for the website. | https://github.com/electron/electron/issues/38024 | https://github.com/electron/electron/pull/38191 | 911900eae94622e6526c95ca36c66a57e8bebbb9 | 9ccf2275d2e021c44f51cc3719679e927fee10fa | 2023-04-19T04:55:34Z | c++ | 2023-05-08T10:50:42Z |
closed | electron/electron | https://github.com/electron/electron | 37,891 | ["docs/api/app.md", "shell/browser/api/electron_api_app.cc", "shell/browser/api/electron_api_app.h", "shell/browser/browser.cc", "shell/browser/browser.h", "shell/browser/browser_observer.h", "shell/browser/mac/electron_application_delegate.mm"] | [Feature Request]: option to hide window when app is deactivated | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a feature request that matches the one I want to file, without success.
### Problem Description
There is currently no option to hide a window when its app is not active. This is important for, for example, utility or info panels.
### Proposed Solution
Expose the hidesOnDeactivate window option (https://developer.apple.com/documentation/appkit/nswindow/1419777-hidesondeactivate)
This normally defaults to true for NSPanel windows, but it looks like the BrowserWindow panel type is still an NSWindow and so does not get this behavior.
### Alternatives Considered
You could show the panel on the app's activate event, but there is no corresponding deactivate event. You could listen to every window's blur event, but this can become clunky especially when the functionality exists natively.
### Additional Information
_No response_ | https://github.com/electron/electron/issues/37891 | https://github.com/electron/electron/pull/37933 | f4b172b9ec3a2278357f34a0a3b9aa1dd9969377 | 32afdda9ee89b028887f71c3d7ecf8ce8ea99569 | 2023-04-09T23:08:43Z | c++ | 2023-04-18T14:53:39Z |
closed | electron/electron | https://github.com/electron/electron | 37,852 | ["docs/api/browser-window.md"] | [Bug]: setFullScreen not working in conjunction with setFullScreenable | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
23.1.4
### What operating system are you using?
macOS
### Operating System Version
macOS Monterey 12.6.3
### What arch are you using?
x64
### Last Known Working Electron version
11.4.3
### Expected Behavior
Using `setFullScreen(false)` should take the window out of full screen.
### Actual Behavior
When using `setFullScreen(false)` in conjunction with `setFullScreenable(false)` the window does not exit from full screen.
Even in this order, it doesn't work.
```
mainWindow.setFullScreen(false)
mainWindow.setFullScreenable(false)
```
### Testcase Gist URL
https://gist.github.com/jtvberg/b3dde9d24bb8e924aa0e726f77392581
### Additional Information
Works as expected in 11.4.3 and stops working in 11.4.4
Looks like it is associated with this: https://github.com/electron/electron/pull/28773
A work-around is commented out in the gist.
Commenting out
`mainWindow.setFullScreenable(false)`
and then using the second timeout in the comment makes things work as intended.
The initial timeout is just to avoid all the other code to create a UI. | https://github.com/electron/electron/issues/37852 | https://github.com/electron/electron/pull/37921 | f0e1848a5e626232645c90decfaac2553eb30588 | c857c9b7e2575769a26769dfa32e967a3da26e99 | 2023-04-05T23:56:50Z | c++ | 2023-04-17T08:45:40Z |
closed | electron/electron | https://github.com/electron/electron | 37,842 | ["shell/browser/extensions/api/resources_private/resources_private_api.cc"] | [Bug]: PDF viewer - / + buttons don't work | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
23.0.0
### What operating system are you using?
Windows
### Operating System Version
Windows 11 22H2 22621.1485
### What arch are you using?
x64
### Last Known Working Electron version
22.0.0
### Expected Behavior
The + and - buttons of the PDF viewer UI zoom and unzoom the document.
### Actual Behavior
Do nothing. Only ctrl + mouse wheel works.
### Testcase Gist URL
_No response_
### Additional Information
Same problem on version 24.0.0
| https://github.com/electron/electron/issues/37842 | https://github.com/electron/electron/pull/37856 | adb1172066a72a22e7e1e83a04a3504b964f0cbb | c65632d4045fbbe4b37421b27f544e591cc1ef38 | 2023-04-05T18:24:38Z | c++ | 2023-04-11T06:30:36Z |
closed | electron/electron | https://github.com/electron/electron | 37,804 | ["shell/browser/api/electron_api_web_contents.cc", "spec/api-browser-window-spec.ts", "spec/fixtures/cat-spin.mp4"] | [Bug]: webContents did-fail-load is triggered with -3 error code when streaming media | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
23.2.1
### What operating system are you using?
Windows
### Operating System Version
Windows 11 Pro 22H2
### What arch are you using?
x64
### Last Known Working Electron version
_No response_
### Expected Behavior
`WebContents` `did-fail-load` is not triggered when streaming a media file.
### Actual Behavior
`WebContents` `did-fail-load` is triggered when streaming a media file (see fiddle gist).
```
did-fail-load {
code: -3,
description: '',
url: 'https://bestvpn.org/html5demos/assets/dizzy.mp4',
isMainFrame: true,
frameProcessId: 4,
frameRoutingId: 1
}
```
### Testcase Gist URL
https://gist.github.com/nikitakot/ce27a64533979186d22b8b1dde4aa03f
### Additional Information
Tested additionally on Electron v. `21.3.3`. The behaviour is the same, bug is there. | https://github.com/electron/electron/issues/37804 | https://github.com/electron/electron/pull/37824 | 6bfef67aaeae9613e85b3d5d3745da763b3ef7c4 | 251e567eff35440e6a0e3812ab20a7bdc21e3065 | 2023-04-03T11:25:33Z | c++ | 2023-04-06T08:23:34Z |
closed | electron/electron | https://github.com/electron/electron | 37,781 | ["docs/api/app.md"] | [Bug]: Wrong return type for app.getPreferredSystemLanguages() | ### Preflight Checklist
- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
23.2.1
### What operating system are you using?
Other Linux
### Operating System Version
Fedora 36
### What arch are you using?
x64
### Last Known Working Electron version
_No response_
### Expected Behavior
The return type of `app.getPreferredSystemLanguages()` should be `string[]` as is described on the [documentation](https://github.com/electron/electron/blob/main/docs/api/app.md#appgetpreferredsystemlanguages)
### Actual Behavior
The generated TypeScript type definition says `app.getPreferredSystemLanguages()` returns `Array<'app.getLocale()' | 'app.getSystemLocale()' | 'app.getPreferredSystemLanguages()' | 'app.getLocale()' | 'app.getSystemLocale()' | 'app.getPreferredSystemLanguages()'>`. As can be seen in https://unpkg.com/browse/[email protected]/electron.d.ts#L7763
### Testcase Gist URL
_No response_
### Additional Information
This issue is quite similar to https://github.com/electron/electron/issues/35255 but the documentation seems to be well formated https://github.com/electron/electron/blob/main/docs/api/app.md#appgetpreferredsystemlanguageswell-formated | https://github.com/electron/electron/issues/37781 | https://github.com/electron/electron/pull/37821 | b8a21dbcd7d784cc4999754b4826d62e0499307a | be32740991785c066052d710ddabd7a928f9323a | 2023-03-31T15:02:47Z | c++ | 2023-04-05T13:31:53Z |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.