support loading all suites by default; represent multiple suites within dataset with suite_name feature

syntaxgym.py

@@ -53,6 +53,14 @@ class SyntaxGymSuiteConfig(datasets.BuilderConfig):
                          **kwargs)
 
 
+class SyntaxGymAll2020SuitesConfig(datasets.BuilderConfig):
+
+    def __init__(self, **kwargs):
+        super().__init__(
+            name="all-2020",
+            description="All SyntaxGym test suites from Hu et al. (2020).\n" + _DESCRIPTION)
+
+
 SUITE_DATASET_CONDITION_SPEC = {
     "condition_name": datasets.Value("string"),
     "content": datasets.Value("string"),
@@ -63,6 +71,7 @@ SUITE_DATASET_CONDITION_SPEC = {
 }
 
 SUITE_DATASET_SPEC = {
+    "suite_name": datasets.Value("string"),
     "item_number": datasets.Value("int32"),
     "conditions": datasets.Sequence(SUITE_DATASET_CONDITION_SPEC),
     "predictions": datasets.Sequence(datasets.Value("string")),
@@ -86,8 +95,10 @@ class SyntaxGym(datasets.GeneratorBasedBuilder):
         "subordination", "subordination_orc-orc",
         "subordination_pp-pp", "subordination_src-src",
     ]
-    BUILDER_CONFIGS = [SyntaxGymSuiteConfig(suite_name)
-                       for suite_name in SUITES]
+    BUILDER_CONFIGS = \
+        [SyntaxGymSuiteConfig(suite_name) for suite_name in SUITES] + \
+        [SyntaxGymAll2020SuitesConfig()]
+    DEFAULT_CONFIG_NAME = "all-2020"
 
     def _info(self):
         citation = ""
@@ -103,24 +114,32 @@ class SyntaxGym(datasets.GeneratorBasedBuilder):
             citation=citation,
         )
 
-    def _split_generators(self, dl_manager: datasets.DownloadManager) -> List[datasets.SplitGenerator]:
-        download_url = _DOWNLOAD_URL + f"{self.config.name}.json"
-        downloaded_file = dl_manager.download_and_extract(download_url)
-        return [datasets.SplitGenerator(name=datasets.Split.TEST,
-                                        gen_kwargs={"filepath": downloaded_file})]
-
-    def _generate_examples(self, filepath):
-        with open(filepath, "r", encoding="utf-8") as f:
-            suite_json = json.load(f)
+    def _download_suite(self, name, dl_manager: datasets.DownloadManager):
+        return dl_manager.download_and_extract(_DOWNLOAD_URL + f"{name}.json")
 
-        predictions = [p["formula"] for p in suite_json["predictions"]]
-
-        for item in suite_json["items"]:
-            # Convert to sentence input.
-            for cond in item["conditions"]:
-                cond["content"] = condition_to_string(cond)
-
-            item["predictions"] = predictions
-
-            yield item["item_number"], item
+    def _split_generators(self, dl_manager: datasets.DownloadManager) -> List[datasets.SplitGenerator]:
+        if isinstance(self.config, SyntaxGymAll2020SuitesConfig):
+            paths = [self._download_suite(suite_name, dl_manager) for suite_name in self.SUITES]
+        else:
+            paths = [self._download_suite(self.config.name, dl_manager)]
+        
+        return [datasets.SplitGenerator(name=datasets.Split.TEST, gen_kwargs={"paths": paths})]
+
+    def _generate_examples(self, paths):
+        for path in paths:
+            with open(path, "r", encoding="utf-8") as f:
+                suite_json = json.load(f)
+
+            suite_name = suite_json["meta"]["name"]
+            predictions = [p["formula"] for p in suite_json["predictions"]]
+
+            for item in suite_json["items"]:
+                # Convert to sentence input.
+                for cond in item["conditions"]:
+                    cond["content"] = condition_to_string(cond)
+
+                item["suite_name"] = suite_name
+                item["predictions"] = predictions
+
+                yield f"{suite_name}/{item['item_number']}", item