diff --git "a/4456656.csv" "b/4456656.csv" deleted file mode 100644--- "a/4456656.csv" +++ /dev/null @@ -1,9414 +0,0 @@ -issuekey,created,title,description,storypoints -86814622,2019-12-17 20:29:25.751,Pajamas: New UX architecture,"## Problem - -### GitLab is a Gardener -The great George RR Martin once said... -> “I think there are two types of writers, the **architects** and the **gardeners**. The architects plan everything ahead of time, like an architect building a house. They know how many rooms are going to be in the house, what kind of roof they're going to have, where the wires are going to run, what kind of plumbing there's going to be. They have the whole thing designed and blueprinted out before they even nail the first board up. The gardeners dig a hole, drop in a seed and water it. They kind of know what seed it is, they know if planted a fantasy seed or mystery seed or whatever. But as the plant comes up and they water it, they don't know how many branches it's going to have, they find out as it grows. And I'm much more a gardener than an architect.” - -* **Gardener** - Bottom-up, experimental, opportunistic, looking for emerging structures -* **Architect** - Top-down, regimented, tightly-controlled, looking to balance the high level with the lower level from the start - -I think this mindset can be applied to any creative field (such as design), however, I don't think you necessarily need to be either a `Gardener` or an `Architect`. -**IMO... GitLab is culturally over-indexing on the `Gardener` side of things.** - -### The challenge with being a Gardener -Based on my onboarding experience and use of Pajamas, this Gardener mindset has led to a number of pain points... -* The onboarding experience is scary -* Design documentation and resources (from my perspective) are quite diffuse across GitLab -* It's hard to quickly understand what GitLab as a product is - and how it fits together - -...There is an opportunity to restructure the experience and content of our Pajamas Design System to ease the onboarding experience and architect content in a more noob-friendly way. - -## Solution - -Let's introduce just the right amount of `Architect` into our design system... - -I have taken a stab at re-architecting the general experience ([see Pajamas Design System - Architecture Mural](https://app.mural.co/t/gitlab2474/m/gitlab2474/1576610115252/7ba61a8eaf98c494b8d603439d37011757c86b8c?wid=0-1576610284030&outline=open)) - trying to balance a bottom-up *and* top-down approach to a design system. This is WIP and a first iteration of course... I will need input from a broader audience to take into account everything that's important. - -See... -* [Pajamas: Actionable Principles Update](https://gitlab.com/gitlab-org/gitlab-design/issues/797) -* [Pajamas: Define Conceptual Object Model](https://gitlab.com/gitlab-org/gitlab-design/issues/789) - -![Screenshot_2019-12-17_at_19.49.56](/uploads/43991241a1584cc752a129b5b3bc4480/Screenshot_2019-12-17_at_19.49.56.png) - -With a more balanced approach to PJ's UX architecture, I believe we can... -* Make onboarding easier through clarity & purpose -* Simplify the information architecture of http://design.gitlab.com/ -* Provide greater context for our lovely components - -This is very abstract atm... but I will follow up with how this new type of architectural thinking can benefit the new table and sorting components I am working on. - -I would love some feedback! Let me know what you think. - -/cc @gitlab-com/gitlab-ux",5 -27992532,2019-12-05 18:45:56.647,Dogfooding > Set up tracing in Jaeger,"* Set up [Jaeger](https://www.jaegertracing.io/) and configure your application using one of the client libraries. -* Navigate to your project’s `Settings > Operations` and provide the Jaeger URL. -* Click Save changes for the changes to take effect. -* You can now visit `Operations > Tracing` in your project’s sidebar and GitLab will redirect you to the configured Jaeger URL.",2 -27904886,2019-12-03 19:05:18.322,Update Foundation > Iconography docs with more details about counters,"Per https://gitlab.com/gitlab-org/gitlab-design/issues/693#note_253421586, adding documentation to specifically address counters (negative space in an icon). - -/cc @pedroms",1 -27514850,2019-11-24 23:11:59.272,Highlight selected heading in markdown,"If you link someone to an anchor link that is at the bottom of the page, scroll doesn't go all the way there. - -e.g. the following link for Sourcegraph, but has the 'Localization' heading at top of screen https://gitlab.com/help/user/profile/preferences.md#sourcegraph - -![Screen_Shot_2019-11-25_at_9.29.51_am](/uploads/5ecab00a475b7499e670891f830384b6/Screen_Shot_2019-11-25_at_9.29.51_am.png) - -Would be great if we could highlight/outline/underline or somehow indicate that the sourcegraph heading is the target. i.e. - -![Screen_Shot_2019-11-25_at_9.30.45_am](/uploads/710e58a30b83a5c5783dab5e7c698cd5/Screen_Shot_2019-11-25_at_9.30.45_am.png)",1 -27187612,2019-11-18 19:00:32.372,Explore the possibility for a more compressed view of tables,"When we were discussing how to utilize our existing table design to display logs, our engineering team suggested it would be better to have a view of the tables with minimal padding around the content so that users can view a maximal amount of content display onscreen (https://gitlab.com/gitlab-org/gitlab/issues/5696#note_244598777). - -Should we consider a more condensed table view? Or, should we allow users to swap back and forth between our normal view and a more condensed view?",2 -26988714,2019-11-12 16:54:59.374,Set up monitoring for design.gitlab.com,"This project has been moved to running off of a Kubernetes cluster using Auto Devops and internal Operations tools. Right now it is using the out-of-the-box monitoring configuration. This is insufficient for production troubleshooting, as we discovered when troubleshooting this ingress issue: https://gitlab.com/gitlab-com/gl-infra/infrastructure/issues/8319 - -This issue is to discuss setting up additional monitoring and metrics to increase visibility into the deployed instances. - -The ingress issue that we have been seeing centers around the number of incoming connections, so as a first step, it would be nice to have some metrics for the NGINX Ingress controller's incoming and backend connections and their latency.",2 -24551977,2019-09-06 21:23:49.194,Specify positioning and sizing guidelines for modals,"### Problem - -Modals across the product vary in size. Besides this, modals are missing some guidelines regarding positioning and sizing which could be useful in cases like the modal used for querying, listing, and filtering projects in https://gitlab.com/gitlab-org/gitlab-ce/issues/65285#note_213633672. - -| Modal 1 | Modal 2 | Modal 3 | -| ------ | ------ | ------ | -| ![modal-milestone](/uploads/d46df0d55dcf19b9dc5d48a242614a8e/modal-milestone.png) | ![modal-upload](/uploads/520bc72485af92ef51c0211e089ab1c3/modal-upload.png) | ![moda-dashboard](/uploads/cf9b878d096c246e87cd27c9f8f5438e/moda-dashboard.png) | - -### Proposal - -Let's add some **positioning** and **sizing** guidelines for modals. - -Possible additions: -1. Specify space on top and bottom -1. Specify height growth strategy if needed -1. Specify max-height -1. Specify listing guidelines and paginating through elements -1. Specify filtering options (filter box)",2 -24063726,2019-08-22 17:32:59.424,Remove banner from sorting component,"We've implemented a first-pass of the sorting component. We weren't able to finish styling the component because we are waiting on other components to be completed (https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/issues/274, https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/issues/281). - -Our plan is to add a ""this component does not yet conform to the correct styling"" banner to the vue component on design.gitlab.com. This issue is to remove that banner, when all of the resulting style issues have been resolved. - -![Screen_Shot_2019-08-22_at_10.29.48_AM](/uploads/16f28c6207fe71654011760012a7d45d/Screen_Shot_2019-08-22_at_10.29.48_AM.png)",1 -23844795,2019-08-16 14:31:58.020,"Create, Build, and Style > Drawers","This issue is to complete the ~""pajamas::create"", ~""pajamas::build"", ~""pajamas::style"" portion of ~""component::filters"" as part of FY20-Q2 OKR to Improve the quality and consistency of our UI. - -This includes a single-source-of-truth component that is implemented in Vue and thoroughly documented on design.gitlab.com. This does not include implementing the component throughout the product. - -Related epics: - -* [Components of Pajamas Design System: -* [Pajamas component: - -Related issues: - -* [FY20-Q2 UX OKR: Improve the quality and consistency of our UI](https://gitlab.com/gitlab-com/www-gitlab-com/issues/4355) - -## Checklist - -* [x] Usage documentation is included in Pajamas -* [x] Component is built and styled in gitlab-ui according to specs -* [x] Add the design specs to Pajamas https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2719 -* [x] [Create Drawer structure in Figma](https://www.figma.com/file/2XRq1MnIG69iti76Mh9HpJ/branch/DlBySFafHmSJEzgJv2v2Sa/Pajamas-visual-examples?node-id=3487%3A15479) -* [x] Add the structure diagram to Pajamas ([Figma branch](https://www.figma.com/file/2XRq1MnIG69iti76Mh9HpJ/branch/DlBySFafHmSJEzgJv2v2Sa/Pajamas-visual-examples?node-id=3487%3A15479)) [MR](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2737) -* [x] Remove the banner on vue tab that warns of incorrect styling ([MR](https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/2677)) -* [x] Add a reference and link to the completed component in the [Engineer Week in Review](https://docs.google.com/document/d/1Oglq0-rLbPFRNbqCDfHT0-Y3NkVEiHj6UukfYijHyUs/edit) doc",5 -23754265,2019-08-13 20:22:53.355,"Follow-up from ""WIP: Resolve ""Review illustration documentation"" - Add link to icon naming","The following discussion from !1506 should be addressed: - -- [ ] @tauriedavis started a [discussion](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/merge_requests/1506#note_202920888): (+3 comments) - - > Is it possible to link `icon naming` to a section that describes how to name icons? - - -Dependent on https://gitlab.com/gitlab-org/gitlab-design/issues/554",1 -23520285,2019-08-05 19:59:51.418,Update radio styling to be consistent,"The padding around the radios should be consistent. Inline is correct. - -![image](/uploads/4f9f90cdcaba33495ea7c09804d71733/image.png) -![image](/uploads/5e2efda5f8a825cecad3f0cea28d8cf4/image.png)",1 -23261727,2019-07-29 12:06:30.217,Define default delay for popovers,"### Problem - -> At the moment, we don't specify a global delay for any of our popovers - each popover instance specifies its own delay (if any). - -### Further information - -> Looking through the source, I was able to find two places where we manually specify a popover delay - both are `200ms`. For example: https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/assets/javascripts/user_popovers.js#L98. This is the popover that shows when a user's name is hovered. - -### Proposal - -After https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/issues/235#note_195974856 has been concluded, we should look into improving this for popovers as well.",1 -23171745,2019-07-25 21:00:54.198,UX Merge Request Coach,"How can we incorporate UX MR coaches into the current process, especially for repos like Pajamas and gitlab-ui? [See Merge Request Coach page](https://about.gitlab.com/job-families/expert/merge-request-coach/) - -The following discussion from https://gitlab.com/gitlab-com/www-gitlab-com/merge_requests/26512 should be addressed: - -- [ ] @rverissimo started a [discussion](https://gitlab.com/gitlab-com/www-gitlab-com/merge_requests/26512#note_195850582): (+2 comments) - - > I'm not totally sure if this is applicable to designers, but I decided to keep it as it shows in the engineering page. Could you please review and give feedback?",2 -22911881,2019-07-17 08:44:15.357,"Follow-up from ""Update contents/components/tables.md""","The following discussion from !1444 should be addressed: - -- [ ] @matejlatin started a [discussion](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/merge_requests/1444#note_192402923): (+4 comments) - - > Should we also suggest using the lining tabular figures when the tables are numbers-heavy? - > - > ![image](/uploads/864311111597cdb51fd3c23c139d3e35/image.png) - > - > I know that the SF font supports them as an OpenType feature, not sure about Segoe UI though :thinking:",1 -22480486,2019-07-03 12:25:03.237,Add 10 Usability Heuristics for User Interface Design to the Usability menu for the design documentation,"### Problem - -With https://gitlab.com/gitlab-org/design.gitlab.com/merge_requests/1448#note_187568144 we'll be adding error prevention to the usability menu, one of the 10 usability heuristics from NNgroup: https://www.nngroup.com/articles/ten-usability-heuristics/ - -We already have a few others as well. - -### Proposal - -This issue is to discover which other heuristics we can add and what duplicate content we might already have existing in other places.",2 -22213429,2019-06-25 07:02:00.919,Add compact empty state region component variant,"### Problem - -Following the discussion in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/14349#note_184643601 and the need in https://gitlab.com/gitlab-org/gitlab-ce/issues/57086#note_181276839, a new component variant is about to be introduced in https://gitlab.com/gitlab-org/gitlab-ui/merge_requests/592 for **compact empty state**. - -### Proposal - -Let's add some design documentation about this new component variant in Pajamas.",2 -22140807,2019-06-21 18:20:39.305,"Add docs on colors for text, icons, and text+icons",Write guidelines on the logic for applying [color](https://design.gitlab.com/foundations/colors) to text and icons (when alone or paired with text) defined in https://gitlab.com/gitlab-org/gitlab-design/issues/259,2 -22092756,2019-06-20 12:24:02.975,Delete old review apps host,"Once AutoDevops is enabled (https://gitlab.com/gitlab-org/design.gitlab.com/issues/96) and all MRs are rebased, we should go and delete the old host? - -The following discussion from !1216 should be addressed: - -- [ ] @leipert started a [discussion](https://gitlab.com/gitlab-org/design.gitlab.com/merge_requests/1216#note_182856734): - - > Once Auto-Devops is enabled and MRs are rebased we probably should go and delete the current host we have set up for review apps.",1 -21966445,2019-06-17 10:14:40.434,Create nice error pages for design.gitlab.com,"With https://gitlab.com/gitlab-org/design.gitlab.com/merge_requests/1437 we are going to have a nice nginx container for auto-devops. Ths container could serve custom 40x and 50x error pages. Let's create them! - - -The following discussion from !1437 should be addressed: - -- [ ] @leipert started a [discussion](https://gitlab.com/gitlab-org/design.gitlab.com/merge_requests/1437#note_181880339): (+1 comment) - - > @DylanGriffith I am not too familiar with AutoDevOps (shame on me). The built nginx image is run at the end, right? Because if so, we could create a follow-up issue to also provide a nice 40x error template (additionally to the 40x one)",2 -21649019,2019-06-06 17:41:34.399,Add badges demo and update component status,"Adding this as a reminder to add the demo for the ~""component::badges"" after the ~""pajamas::style"" has been completed. - -Also update the status page with the component status: https://design.gitlab.com/components/status",1 -21535127,2019-06-03 17:02:02.999,Add paginated list component,"### Problem - -Following the need in https://gitlab.com/gitlab-org/design.gitlab.com/merge_requests/1183 to facilitate paginated lists with less than 20 items which derived from the discussion in https://gitlab.com/gitlab-org/gitlab-ee/issues/10059, a new component is about to be introduced in https://gitlab.com/gitlab-org/gitlab-ui/merge_requests/350 for **paginated lists**. - -### Proposal - -Let's add some design documentation about this new component in Pajamas. - -This could be added as a) separate component for now or b) variation of the [lists](https://design.gitlab.com/components/lists) component while this could easily become the basis of a [data tables](https://design.gitlab.com/components/data-tables) component in the near future.",3 -20942690,2019-05-15 20:34:44.615,"Create, Build, and Style > Tree","This issue is to complete the ~""pajamas::create"", ~""pajamas::build"", ~""pajamas::style"" portion of ~""component::tree"" as part of FY20-Q2 OKR to Improve the quality and consistency of our UI. - -This includes a single-source-of-truth component that is implemented in Vue and thoroughly documented on design.gitlab.com. This does not include implementing the component throughout the product. - -Related epics: -* [Components of Pajamas Design System](https://gitlab.com/groups/gitlab-org/-/epics/973) -* [Pajamas component: Tree](https://gitlab.com/groups/gitlab-org/-/epics/1124) - -Related issues: -* [FY20-Q2 UX OKR: Improve the quality and consistency of our UI](https://gitlab.com/gitlab-com/www-gitlab-com/issues/4355) - -## Checklist - -* [x] Usage documentation is included in Pajamas -* [x] Design specs are included in Pajamas -* [x] Component is built and styled in gitlab-ui according to specs -* [ ] Banner on vue tab that warns of incorrect styling is removed from Pajamas -* [ ] All demos and todos are complete -* [ ] Status is changed to `Built` in Pajamas -* [ ] Add a reference and link to the completed component in the [Engineer Week in Review](https://docs.google.com/document/d/1Oglq0-rLbPFRNbqCDfHT0-Y3NkVEiHj6UukfYijHyUs/edit) doc - -### Checklist for UI/sketch updates - -Make sure these are completed before closing the issue, with a link to the -relevant commit or issue, if applicable. Get familiar with the [Sketch UI Kit -documentation](https://gitlab.com/gitlab-org/gitlab-design/blob/master/doc/sketch-ui-kit.md) -which has information on updating files, structure, fonts, and symbols. - -1. [x] **Author**: Create a Sketch file in your progress folder with the - changes required for this issue. Try to use existing symbols, layer styles, - and text styles. -1. [x] **Author**: Ask another Product Designer to review your personal Sketch file, linking them to your latest commit so they know where to find it. If they have the capacity, they should assign themselves to this issue. If not, try pinging another person. -1. [x] **Reviewer**: Review and approve author's changes in their personal - Sketch file, according to the [workflow](https://gitlab.com/gitlab-org/gitlab-design/blob/master/doc/sketch-ui-kit.md#sketch-workflow). -1. [x] **Author**: Add your changes to the GitLab Sketch UI Kit (pattern - library and/or instance sheet), following this [step-by-step process](https://gitlab.com/gitlab-org/gitlab-design/blob/master/doc/sketch-ui-kit.md#when-changes-are-approved). -1. [x] **Author**: Ask the reviewer to review your changes to the Sketch UI - Kit files. -1. [x] **Reviewer**: Review and approve author's changes to the Sketch UI Kit - files, according to the [workflow](https://gitlab.com/gitlab-org/gitlab-design/blob/master/doc/sketch-ui-kit.md#sketch-workflow). -1. [x] **Author**: [Create an issue in the Design - System](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/issues/new) - to update the design **specs** and **documentation**. Mark it as related to - this issue. -1. [x] **Author**: Add a read only (FYI) agenda item to the next [UX weekly - call](https://docs.google.com/document/d/189WZO7uTlZCznzae2gqLqFn55koNl3-pHvU-eVnvG9c/edit?usp=sharing) - to inform everyone of these changes, linking to this issue.",3 -20942600,2019-05-15 20:29:50.917,"Create, Build, and Style > Banners","This issue is to complete the ~""pajamas::create"", ~""pajamas::build"", ~""pajamas::style"" portion of ~""component::banners"" as part of FY20-Q2 OKR to Improve the quality and consistency of our UI. - -This includes a single-source-of-truth component that is implemented in Vue and thoroughly documented on design.gitlab.com. This does not include implementing the component throughout the product. - -Related epics: -* [Components of Pajamas Design System](https://gitlab.com/groups/gitlab-org/-/epics/973) -* [Pajamas component: Banners](https://gitlab.com/groups/gitlab-org/-/epics/1136) - -Related issues: -* [FY20-Q2 UX OKR: Improve the quality and consistency of our UI](https://gitlab.com/gitlab-com/www-gitlab-com/issues/4355) - -## Checklist - -* [x] Usage documentation is included in Pajamas -* [x] Design specs are included in Pajamas -* [x] Component is built and styled in gitlab-ui according to specs -* [x] Banner on vue tab that warns of incorrect styling is removed from Pajamas -* [x] All demos and todos are complete -* [ ] Status is changed to `Built` in Pajamas -* [ ] Add a reference and link to the completed component in the [Engineer Week in Review](https://docs.google.com/document/d/1Oglq0-rLbPFRNbqCDfHT0-Y3NkVEiHj6UukfYijHyUs/edit) doc",5 -20942021,2019-05-15 20:02:12.503,"Create, Build, and Style > Lists","This issue is to complete the ~""pajamas::create"", ~""pajamas::build"", ~""pajamas::style"" portion of ~""component::lists"" as part of FY20-Q2 OKR to Improve the quality and consistency of our UI. - -This includes a single-source-of-truth component that is implemented in Vue and thoroughly documented on design.gitlab.com. This does not include implementing the component throughout the product. - -Related epics: -* [Components of Pajamas Design System](https://gitlab.com/groups/gitlab-org/-/epics/973) -* [Pajamas component: Lists](https://gitlab.com/groups/gitlab-org/-/epics/1084) - -Related issues: -* [FY20-Q2 UX OKR: Improve the quality and consistency of our UI](https://gitlab.com/gitlab-com/www-gitlab-com/issues/4355) - -## Checklist - -* [ ] Usage documentation is included in Pajamas -* [ ] Design specs are included in Pajamas -* [ ] Component is built and styled in gitlab-ui according to specs -* [ ] Banner on vue tab that warns of incorrect styling is removed from Pajamas -* [ ] All demos and todos are complete -* [ ] Status is changed to `Built` in Pajamas -* [ ] Add a reference and link to the completed component in the [Engineer Week in Review](https://docs.google.com/document/d/1Oglq0-rLbPFRNbqCDfHT0-Y3NkVEiHj6UukfYijHyUs/edit) doc",3 -20941416,2019-05-15 19:35:09.982,"Create, Build, and Style > Forms","This issue is to complete the ~""pajamas::create"", ~""pajamas::build"", ~""pajamas::style"" portion of ~""component::forms"" as part of FY20-Q2 OKR to Improve the quality and consistency of our UI. - -This includes a single-source-of-truth component that is implemented in Vue and thoroughly documented on design.gitlab.com. This does not include implementing the component throughout the product. - -Related epics: -* [Components of Pajamas Design System](https://gitlab.com/groups/gitlab-org/-/epics/973) -* [Pajamas component: Forms](https://gitlab.com/groups/gitlab-org/-/epics/1021) - -Related issues: -* [FY20-Q2 UX OKR: Improve the quality and consistency of our UI](https://gitlab.com/gitlab-com/www-gitlab-com/issues/4355) - -## Checklist - -* [ ] Usage documentation is included in Pajamas -* [ ] Design specs are included in Pajamas -* [ ] Component is built and styled in gitlab-ui according to specs -* [ ] Banner on vue tab that warns of incorrect styling is removed from Pajamas -* [ ] All demos and todos are complete -* [ ] Status is changed to `Built` in Pajamas -* [ ] Add a reference and link to the completed component in the [Engineer Week in Review](https://docs.google.com/document/d/1Oglq0-rLbPFRNbqCDfHT0-Y3NkVEiHj6UukfYijHyUs/edit) doc",3 -20941377,2019-05-15 19:32:24.884,"Create, Build, and Style > Dropdowns","This issue is to complete the ~""pajamas::create"", ~""pajamas::build"", ~""pajamas::style"" portion of ~""component::dropdowns"" as part of FY20-Q2 OKR to Improve the quality and consistency of our UI. - -This includes a single-source-of-truth component that is implemented in Vue and thoroughly documented on design.gitlab.com. This does not include implementing the component throughout the product. - -Related epics: -* [Components of Pajamas Design System](https://gitlab.com/groups/gitlab-org/-/epics/973) -* [Pajamas component: Dropdowns](https://gitlab.com/groups/gitlab-org/-/epics/1018) - -Related issues: -* [FY20-Q2 UX OKR: Improve the quality and consistency of our UI](https://gitlab.com/gitlab-com/www-gitlab-com/issues/4355) - -## Checklist - -* [ ] Usage documentation is included in Pajamas -* [x] Design specs are included in Pajamas -* [x] Component is built and styled in gitlab-ui according to specs -* [ ] Banner on vue tab that warns of incorrect styling is removed from Pajamas -* [ ] All demos and todos are complete -* [ ] Status is changed to `Built` in Pajamas -* [ ] Add a reference and link to the completed component in the [Engineer Week in Review](https://docs.google.com/document/d/1Oglq0-rLbPFRNbqCDfHT0-Y3NkVEiHj6UukfYijHyUs/edit) doc",3 -19773326,2019-04-05 14:28:08.315,Allow linking to component usage and code documentation,"### Problem - -Following the pending changes in #101, it would nice to be able to link to component usage (_Design_) and code (_Vue Component_) documentation. - -### Proposal - -For example, the Button component could use (`/components/buttons/usage`) for usage documentation and (`/components/buttons/code`) for code documentation.",3 -19668721,2019-04-02 23:48:49.586,Missing examples for color priority 4,"Currently docs on colors say Priorities got from 1-4, then we only describe 3 of them. I assume 4 is `$color-50` and `$color-950` - -Should we have priorities and/or usage examples for -400, -600, and the other unused ones?",1 -17894891,2019-02-01 18:59:46.223,Homepage > Pajamas logo > Animation,"Ensure the animation used on the homepage of design.gitlab.com is following our motion guidelines and/or update motion guidelines as needed. - ---- - -The following discussion from !216 should be addressed: - -- [ ] @tauriedavis started a [discussion](https://gitlab.com/gitlab-org/design.gitlab.com/merge_requests/216#note_134646588): (+5 comments) - - > Do these animations match our motion guidelines? Or do we need to add to our motion guidelines?",1 -17386874,2019-01-16 11:20:18.283,Include a fallback for help links in empty state call to action design specifications,"### Problem - -Previously added empty states contained duplicate primary call to action buttons (see https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22745, https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/21975) but empty states are still being added with duplicate primary call to action buttons (see https://gitlab.com/gitlab-org/gitlab-ee/issues/9233, https://gitlab.com/gitlab-org/gitlab-ee/issues/9230). - -### Proposal - -Include a fallback for help links in empty state [call to action](https://design.gitlab.com/regions/empty-states#call-to-action) design specifications (see [helping users](https://design.gitlab.com/usability/helping-users)). - -`CURRENT` - -> - The call to action button in the empty state should be a primary button. -> - There is only one primary button since there can only be one primary button per form. If there is a need for more than one button, the other should be a secondary button. - -`PROPOSED` - -> - The call to action button in the empty state should be a primary button. -> - There is only one primary button since there can only be one primary button per form. If there is a need for more than one button, the other should be a secondary button. -> - If there is no need for a primary button or the primary button has already been added in the near components (see [tabs](/components/tabs)), there can be one or more help links within the description text (see [helping users](/usability/helping-users))",1 -17383740,2019-01-16 09:41:40.636,Linking directly to (not component) markdown pages gives 404,"### Problem - -GET requests fail for all `/regions` pages. Try open the following URLs in a new tab: - -- https://design.gitlab.com/regions/empty-states -- https://design.gitlab.com/regions/filters -- https://design.gitlab.com/regions/navigation -- https://design.gitlab.com/regions/search",1 -86814665,2018-12-14 13:38:33.739,Discuss: How modals should work on mobile,"Coming from: https://gitlab.com/gitlab-org/gitlab-design/issues/187 - -We should discuss further, how we should support modals on mobile, especially larger modals.",1 -16628364,2018-12-13 10:59:57.196,Component: Add accessibility guidelines for invisible labels to forms documentation,"As outlined in the [W3 guidelines](https://www.w3.org/WAI/tutorials/forms/labels/#hiding-label-text): - ->A label for a form control helps everyone better understand its purpose. In some cases, the purpose may be clear enough from the context when the content is rendered visually. The label can be hidden visually, though it still needs to be provided within the code to support other forms of presentation and interaction, such as for screen reader and speech input users. - -``` - - - -```",1 -54043461,2018-12-04 22:14:57.628,Empty state: design and layout,"Stemming from a conversation on slack about empty states: - -We need to reconsider the layout of empty states and how they refactor on smaller screens. Today the design documentation states: - -#### Description -* If the description needs to wrap on desktop, align it to the left. -* If the title needs to wrap on desktop, align both the title and description to the left. -* If the title and description do not wrap on desktop, center them horizontally. - -This is causing some compromises to the design of empty states. Instead, we should consider a layout that doesn't need to mix center-aligned and left-aligned titles and body copy. - - -@tauriedavis proposed this layout: -![screen_shot_2018-12-04_at_10.15.26_am](/uploads/7802dbc4c79cca91cd21dc8a302672ba/screen_shot_2018-12-04_at_10.15.26_am.png) - -Which eliminates the need to have empty states who's headlining are center-aligned and left-aligned.",2 -16238292,2018-11-30 10:50:16.537,Check for broken links,"(Shamelessly copied from https://gitlab.com/gitlab-org/gitlab-ce/issues/51696) - -### Problem to solve - -Check for broken links, both **internal and external** - -### Further details - -- 404s are bad UX; we should check the docs to assure we don't have them -- The recent change to use the `#` led to broken links, as noted by the community on [Twitter](https://twitter.com/Citizen_Drain/status/1064886792657281024) and [LinkedIn](https://www.linkedin.com/feed/update/urn:li:activity:6473126444728872960/?commentUrn=urn%3Ali%3Acomment%3A(activity%3A6472126819968524288%2C6473126423233077248)) -- There were some broken links that went unnoticed: https://gitlab.com/gitlab-org/design.gitlab.com/merge_requests/165 - -### Proposal - -Implement a broken link checker, preferably in a job (not allowed to fail) that runs with the entire pipeline. As inspiration, checkout how GitLab Docs implemented their external link checker: https://gitlab.com/gitlab-com/gitlab-docs/merge_requests/360 - -### What does success look like, and how can we measure that? - -:thinking: green pipelines == 100% success :stuck\_out\_tongue\_winking\_eye: - -### Links / references - -- Community noticing broken URLs on [Twitter](https://twitter.com/Citizen_Drain/status/1064886792657281024) and [LinkedIn](https://www.linkedin.com/feed/update/urn:li:activity:6473126444728872960/?commentUrn=urn%3Ali%3Acomment%3A(activity%3A6472126819968524288%2C6473126423233077248))",2 -15902616,2018-11-16 14:37:00.439,Dropdowns have no accessibility and behavior documentation defined for small viewports,"### Problem - -Dropdowns have no accessibility and behavior documentation defined for small viewports - -### Further information - -| Current situation | visually improved situation | Actually accessible behaviour situation | -| --- | --- | --- | -| ![_0px-expanded-single-upstream_copy](/uploads/2703f8028c9497192a736ec9c2e16ecc/_0px-expanded-single-upstream_copy.png) | ![_0px-expanded-single-upstream_copy_2](/uploads/140f81d6a055ee71dd294cca915277dc/_0px-expanded-single-upstream_copy_2.png) | ![_0px-expanded-single-upstream_copy_3](/uploads/6c42150fe956b4c473c8ed0f2e8db926/_0px-expanded-single-upstream_copy_3.png) | - -Last mockup is based upon https://developer.apple.com/design/human-interface-guidelines/ios/controls/pickers/ - -Examples are based on designs from https://gitlab.com/gitlab-org/gitlab-ee/issues/2122 - -### Proposal - -- Create documentation detailing accessibility and behavior for dropdowns -- Create pattern library assets supporting the documentation - -#### What does success look like, and how can we measure that? - -- Documentation is created detailing accessibility and behavior for dropdowns -- Pattern library is updated with assets supporting the documentation",3 -15646520,2018-11-07 23:51:02.749,Mixed usage of automatic saving for radio buttons might create a brittle user experience,"### Problem - -Mixed usage of automatic saving for radio buttons might create a brittle user experience — as if anything can happen without warning - -### Origin - -*Follow-up from ""adding radio buttons documentation"" at https://gitlab.com/gitlab-org/design.gitlab.com/merge_requests/106#note_115355022* - -The question was: Should or should users not expect radio buttons to yield immediate results? - -### Further information - -I made the case for them not to be (which is backed up by [nngroup](https://www.nngroup.com/articles/checkboxes-vs-radio-buttons/)), but @tauriedavis suggested otherwise (which is backed up by [existing UI in GitLab](https://gitlab.com/gitlab-org/design.gitlab.com/uploads/1eba37a0e276c02fd9c8bd96588df112/Screen_Shot_2018-11-07_at_11.50.46_AM.png)). - -https://design.gitlab.com/foundations/saving-and-feedback comes into play here as it states we are anticipating saving by default as it has a positive impact on the perceived speed of the application. This is great but there is a potential discrepancies: - -Documented safety measures only account for potential data loss. There is no documentation on how we handle feedback to the user that we will not auto-save data that might have a financial, security, or privacy impact before the user actually interacts with the element. - -### Illustrating situations - -When using radio buttons as an action -```mermaid -graph LR -A[User clicks element] -C[System performs action and saving is implied] - -A --> C -``` - -
- -Radio button usage done as documented -```mermaid -graph LR -A[User clicks element] -B[System saves state] -C[System gives feedback] -D[System performs action] - -A --> B -B --> C -B --> D -``` -
- -Same situation but now handles sensitive information... -```mermaid -graph LR -Z[user sees element] -X[user is unsure if information
is saved immediately yes or no
when using the element] -A[User clicks element] -B[?] - -Z --> X -X --> A -A --> B -``` - -### Quoted information from sources - -from https://www.nngroup.com/articles/checkboxes-vs-radio-buttons - -> Use checkboxes and radio buttons only to change settings, not as action buttons that make something happen. Also, the changed settings should not take effect until the user clicks the command button (labeled ""OK"" for example, or ""Proceed to XXX"" where ""XXX"" is the next step in a process). - -> Conversely, violating the standards makes the user interface feel brittle — as if anything can happen without warning. Say, for example, that you assume you can click on a radio button without any immediate impact, and can thus consider your choices after making a selection but before hitting ""OK."" In such a case, it's jarring when a website violates this standard and unexpectedly moves you to the next page once you enter a selection. Worse, it makes you fear what may happen as you work with forms elsewhere on the site. - -https://design.gitlab.com/foundations/saving-and-feedback - -> Never apply to whole forms (example: adding a personal access token needs a name, expiration date, and access scope; it doesn’t make sense to auto-save the token name field individually). The auto-save method should ideally be only used for data that affects the user editing it. Auto-saving shouldn’t be applied to data that might have financial, security, or privacy impacts, example: changing password or changing the confidentiality of an issue. - -> Instant feedback simply means that we show the expected result of a successfully saved change even before that change has actually been saved—we anticipate that the change will be saved successfully so we show it in the UI immediately. This has a positive impact on the perceived speed of the application. An example of a case when a successful result is expected is changing the assignee on an issue. - -### How does success look like? - -We prevent the user interface from feeling brittle when using radio buttons — as if anything can happen without warning - -### Links/Mentions - -@tauriedavis @matejlatin @pedroms (From prior discussion/involvement) - -cc: @gitlab\-com/gitlab\-ux",3 -14702839,2018-10-04 21:31:10.364,"Follow-up from ""Resolve ""Component: Add Toast documentation""""","The following discussion from !41 should be addressed: - -- [ ] @tauriedavis started a [discussion](https://gitlab.com/gitlab-org/design.gitlab.com/merge_requests/41#note_105879603): (+4 comments) - - > Why does the dismiss icon act different if there are 1 vs. 2 lines? - -- [ ] @dimitrieh - ->I feel we should just do away with dismiss actions. -> ->The text button next to an icon button feels out of place/inconsistent. A group of buttons should either be all text or all icons. -> ->Also taken from [material design guide lines](https://material.io/design/components/snackbars.html#usage): -> ->> Snackbars inform users of a process that an app has performed or will perform. They appear temporarily, towards the bottom of the screen. They shouldn’t interrupt the user experience, and they don’t require user input to disappear. ->> ->> Frequency ->> Only one snackbar may be displayed at a time. ->> ->> Actions ->> A snackbar can contain a single action. Because they disappear automatically, the action shouldn’t be “Dismiss” or “Cancel.”",1 -11902702,2018-06-11 06:25:10.492,Use HTTPS protocol for design.gitlab.com,"While the description of https://gitlab.com/gitlab-org/design.gitlab.com has a link to `http://design.gitlab.com`, it should be `https://design.gitlab.com`.",1 -11796707,2018-06-07 15:01:42.441,Add the Law of Proximity Gestalt principle to the Layout > Spacing page,"Based on this [discussion on Slack](https://gitlab.slack.com/files/UA7DGQSAZ/FB3HHAJJ3/image.png) we concluded that we should add the [Law of Proximity](https://en.wikipedia.org/wiki/Principles_of_grouping#Proximity) Gestalt principle somewhere in our Design System. - ->""objects or shapes that are close to one another appear to form groups"". Even if the shapes, sizes, and objects are radically different, they will appear as a group if they are close. - -![image](/uploads/a9f6478d2ad2a081d190e9dc50b3602c/image.png) -*In [this particular case](https://gitlab.com/gitlab-org/gitlab-ce/commits/issue_44230): A button that navigates to another page, a search box and a 'Subscribe to RSS' button, three things that are completely unrelated seem like they are because of their placement on the page. This makes our interfaces unintuitive and harder to adopt.* - -Atm, our interfaces seem cluttered sometimes and one of the common issues is that we group together things that aren't related. We'll add this principle that is commonly used in graphic and UI design to guide us and prevent this from happening in the future.",1 -10626557,2018-05-02 15:08:14.564,Write guidelines for text colours in Typography section,"I recently noticed that the quotes text colour is way too light on white background and hard to read (gitlab-org/gitlab-design#147). I think we should write down the guidelines for text colours: what is the default text colour, what is the lightest shade allowed to use on the white background. These guidelines should be aligned with the [accessibility standards](https://webaim.org/resources/contrastchecker/).",1 -9584616,2018-03-06 12:19:40.871,Written content of the DS should follow the documentation writing guidelines,"When people are contributing written content to the DS, we should have some guidelines in place so the writing is consistent. - -@rebecca suggested we use https://docs.gitlab.com/ee/development/documentation/styleguide.html - -Maybe we can put a link for that in https://gitlab-org.gitlab.io/design.gitlab.com/getting-started/contributing/",1 -9478103,2018-02-27 19:03:17.965,Design Pattern Library - Component: Links,"Add a new component for links. - -This should include documentation related to styles and usage of anchors as well as documentation regarding truncation of links. - -Transfer/update existing information regarding anchors: https://docs.gitlab.com/ee/development/ux_guide/components.html#anchor-links - -Related: https://gitlab.com/gitlab-org/gitlab-design/issues/122 - -- Buttons vs links: https://gitlab.com/gitlab-org/gitlab-ce/issues/21287#note_17099288 -- https://gitlab.com/gitlab-org/gitlab-ce/issues/21287#note_16963426",3 -34692858,2017-09-29 15:43:54.784,Design for Tabs within tabs (contextual tabs),"### Overview - -We can several places in GitLab where we have top-level tabs for categories but we need further context within and thus we use tabs under the content of top-level tab. One such example is on `/dashboard/projects` page which looks like this; - -![image](/uploads/fb989f15d7e9938485dda1daebd2e3d4/image.png) - -Tabs inside tabs is very common UX pattern and it is generally preferred to have slightly different design for _sub-tabs_ than the one you have to main tabs. - -#### See the discussions around this design in following threads on StackExchange. - -* [Is there evidence to suggest that designing tabs within tabs creates a bad user experience?](https://ux.stackexchange.com/questions/5136/is-there-evidence-to-suggest-that-designing-tabs-within-tabs-creates-a-bad-user) -* [Elegant, simple and obvious sub-tabs?](https://ux.stackexchange.com/questions/16281/elegant-simple-and-obvious-sub-tabs) - -#### Proposal - -Let's discuss possible alternative designs (or reasoning behind current design) :smiley: - -I think [Bootstrap Pills](https://getbootstrap.com/docs/3.3/components/#nav-pills) are ideal choice when we want to have nested tabs but I'll leave our options open. :slight_smile: - -Although I've put together a quick mock up on CodePen which uses Pills under Tabs, check it out [here](https://codepen.io/kushalpandya/pen/zEzEbP). - -![image](/uploads/bb80d08b6ca7fe8c2005dbcde291c5bf/image.png)",5 -88587801,2021-06-11 16:13:20.077,Progress bar > Update docs to utilize new template,"## Background - -As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. - -## Resources - -See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. - -## Proposal - -Update the progress bar component usage tab to be in alignment with the changes. - -This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.",1 -88587800,2021-06-11 16:13:19.872,Popover > Update docs to utilize new template,"## Background - -As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. - -## Resources - -See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. - -## Proposal - -Update the popover component usage tab to be in alignment with the changes. - -This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.",1 -88587799,2021-06-11 16:13:19.670,Path > Update docs to utilize new template,"## Background - -As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. - -## Resources - -See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. - -## Proposal - -Update the path component usage tab to be in alignment with the changes. - -This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.",1 -88587798,2021-06-11 16:13:19.473,Pagination > Update docs to utilize new template,"## Background - -As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. - -## Resources - -See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. - -## Proposal - -Update the pagination component usage tab to be in alignment with the changes. - -This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.",1 -88587797,2021-06-11 16:13:18.503,Modal > Update docs to utilize new template,"## Background - -As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. - -## Resources - -See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. - -## Proposal - -Update the modal component usage tab to be in alignment with the changes. - -This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.",1 -88544766,2021-06-10 22:36:03.504,List > Update docs to utilize new template,"## Background - -As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. - -## Resources - -See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. - -## Proposal - -Update the list component usage tab to be in alignment with the changes. - -This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.",1 -88544765,2021-06-10 22:36:03.309,Label > Update docs to utilize new template,"## Background - -As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. - -## Resources - -See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. - -## Proposal - -Update the label component usage tab to be in alignment with the changes. - -This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.",1 -88544764,2021-06-10 22:36:03.120,Infinite Scroll > Update docs to utilize new template,"## Background - -As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. - -## Resources - -See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. - -## Proposal - -Update the infinite scroll component usage tab to be in alignment with the changes. - -This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.",1 -88544763,2021-06-10 22:36:02.903,Form > Update docs to utilize new template,"## Background - -As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. - -## Resources - -See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. - -## Proposal - -Update the form component usage tab to be in alignment with the changes. - -This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.",1 -88544762,2021-06-10 22:36:02.703,Filter > Update docs to utilize new template,"## Background - -As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. - -## Resources - -See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. - -## Proposal - -Update the filter component usage tab to be in alignment with the changes. - -This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.",1 -88544761,2021-06-10 22:36:02.510,File Uploader > Update docs to utilize new template,"## Background - -As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. - -## Resources - -See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. - -## Proposal - -Update the file uploader component usage tab to be in alignment with the changes. - -This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.",1 -88544760,2021-06-10 22:36:02.312,Dropdown > Update docs to utilize new template,"## Background - -As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. - -## Resources - -See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. - -## Proposal - -- Update the dropdown component usage tab to be in alignment with the template changes. -- Update the content to align with the [results of the accessibility audit](https://gitlab.com/gitlab-org/gitlab-ui/-/issues/1534) where we need to specify the _type_ of dropdown and it's purpose to make the use cases semantically different. - -This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.",1 -88544759,2021-06-10 22:36:02.113,Drawer > Update docs to utilize new template,"## Background - -As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. - -## Resources - -See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. - -## Proposal - -Update the drawer component usage tab to be in alignment with the changes. - -This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.",1 -88544758,2021-06-10 22:36:01.888,Date picker > Update docs to utilize new template,"## Background - -As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. - -## Resources - -See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. - -## Proposal - -Update the date picker component usage tab to be in alignment with the changes. - -This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.",1 -88544757,2021-06-10 22:36:01.682,Checkbox > Update docs to utilize new template,"## Background - -As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. - -## Resources - -See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. - -## Proposal - -Update the checkbox component usage tab to be in alignment with the changes. - -This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.",1 -88544756,2021-06-10 22:36:01.330,Card > Update docs to utilize new template,"## Background - -As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. - -## Resources - -See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. - -## Proposal - -Update the card component usage tab to be in alignment with the changes. - -This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.",1 -88544753,2021-06-10 22:36:00.767,Breadcrumb > Update docs to utilize new template,"## Background - -As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. - -## Resources - -See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. - -## Proposal - -Update the breadcrumb component usage tab to be in alignment with the changes. - -This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.",1 -88544752,2021-06-10 22:35:59.836,Banner > Update docs to utilize new template,"## Background - -As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. - -## Resources - -See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. - -## Proposal - -Update the banner component usage tab to be in alignment with the changes. - -This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.",1 -88544748,2021-06-10 22:35:58.172,Accordion > Update docs to utilize new template,"## Background - -As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. - -## Resources - -See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. - -## Proposal - -Update the accordion component usage tab to be in alignment with the changes. - -This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.",1 -88530002,2021-06-10 15:13:52.856,Remove Helm 3 upgrade CI config,"In https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2411, we introduced a temporary config to upgrade review apps and production environment from Helm 2 to 3. We need to keep this config for a while to make sure all existing review apps can be migrated to Helm 3 by running the `review:helm-2to3:migrate` manual job. Once we are confident that all review apps have been migrated or shut down, we can clean up the CI config by reverting https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2411 altogether. - -/cc @hfyngvason",1 -88430693,2021-06-09 05:43:02.007,Design: Mini pipeline graph component," - -### Description - -The mini pipeline graph appears in multiple places in the product, but it's actually not one single component but multiple instances with varying functionality. It leads to a lot of inconsistency since the updates to one instance don't propagate to the rest of the instances. Having a single mini pipeline graph component will ensure consistency of experience across the product and make it easier to implement further improvements. - -| Mini pipeline graph in MR widget | -| ------ | -| ![image](/uploads/672ba1850f8c1986b42cf75dc349224e/image.png) | - -#### Audit of current component instances - -:link: [Audit: Mini Pipeline Graph Components](https://gitlab.com/gitlab-org/gitlab/-/issues/332948) - -The goal of this issue is to document the mini pipeline graph component and its behavior with minor updates that improve the visual consistency and usability. Any big updates will be addressed as a follow-up. - -### Figma file - - - -:art: [View working file in Figma →](https://www.figma.com/file/s7EYyAa9fs0nVrkT5s8mEg/Mini-pipeline-graph-component?node-id=1%3A70) - -### Checklist - -Make sure the following are completed before closing the issue: - -1. [x] **Assignee**: Design in your working file. When applicable, follow our - [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [FE/UX Foundations designer][foundations-team]. -1. [x] **Assignee**: Update the link to the working file in the issue - description. -1. [x] **Assignee**: Ask a [FE/UX Foundations designer][foundations-team] - to review your design (ensure they have edit permissions in Figma). -1. [x] **Reviewer**: Review and approve assignee’s design. Specific design - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer] - for final review (make sure they have edit permissions in Figma). -1. [x] **Maintainer**: Review and approve assignee’s changes. -1. [x] **Maintainer**: Add the changes or additions to the target file. For - example, you’d copy a final chart design from the working file and paste into the related location in the Data Visualization file. - 1. [x] Ensure that all styles and components now belong to the target file. - 1. [x] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [x] **Maintainer**: When applicable, [publish][publishing] any library - changes along with a clear commit message. -1. [x] **Assignee**: Move your working file to the shared Figma project: - 1. [-] For Component Library changes, move your file to the [**Component archive**][component-archive] project. - 1. [x] For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. [-] If you’re a community contributor, we ask that you [transfer ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -1. [x] **Assignee** (or Maintainer, for community contributions): If it’s a new - pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [x] **Assignee**: When applicable, [create an MR in this repository][new-gitlab-ui-mr] and apply the ""component-guideline"" template - to create or update the component’s documentation page. If you do not have capacity, [create an issue in this repository using the ""Component documentation"" issue template][pajamas-component-documentation-template]. Bring the issue to your team planning session for prioritization and scheduling. Mark the new issue as related to this one. -1. [x] **Assignee**: When applicable, [create an issue in GitLab UI using the ""Component"" issue template][gitlab-ui-component-template] to build or update the component code. Bring the issue to your team planning session for prioritization and scheduling. Mark the new issue as related to this one. -1. [x] **Assignee**: 🎉 Congrats, you made it! You can now close this issue. - -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure -[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/.gitlab/merge_request_templates/component-guideline.md -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component -[pajamas-component-documentation-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation -[new-gitlab-ui-mr]: https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/new",3 -88238523,2021-06-04 21:02:46.860,Icon component names and export components as SVG," - -### Description - -On the ""Icons"" page, I've corrected all layer and component names to have the same name as the label next to the icon (such as renaming from ""chevron-double-left-lg"" to ""chevron-double-lg-left"". This will also affect the export name. Along side this, I've ensured that all icon components will export as a .svg file. - -### Figma file - - - -[View working file in Figma →](https://www.figma.com/file/JBXlrIpgRBr9kIp0I3lSR6/GitLab-Component-Library-Community?node-id=16%3A127) - -### Checklist - -Make sure the following are completed before closing the issue: - -1. [ ] **Assignee**: Design in your working file. When applicable, follow our - [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [FE/UX Foundations designer][foundations-team]. -1. [ ] **Assignee**: Update the link to the working file in the issue - description. -1. [ ] **Assignee**: Ask a [FE/UX Foundations designer][foundations-team] - to review your design (ensure they have edit permissions in Figma). -1. [ ] **Reviewer**: Review and approve assignee’s design. Specific design - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [ ] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer] - for final review (make sure they have edit permissions in Figma). -1. [ ] **Maintainer**: Review and approve assignee’s changes. -1. [ ] **Maintainer**: Add the changes or additions to the target file. For - example, you’d copy a final chart design from the working file and paste into the related location in the Data Visualization file. - 1. [ ] Ensure that all styles and components now belong to the target file. - 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [ ] **Maintainer**: When applicable, [publish][publishing] any library - changes along with a clear commit message. -1. [ ] **Assignee**: Move your working file to the shared Figma project: - 1. [ ] For Component Library changes, move your file to the [**Component archive**][component-archive] project. - 1. [ ] For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. [ ] If you’re a community contributor, we ask that you [transfer ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -1. [ ] **Assignee** (or Maintainer, for community contributions): If it’s a new - pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [ ] **Assignee**: When applicable, [create an MR in this repository][new-gitlab-ui-mr] and apply the ""component-guideline"" template - to create or update the component’s documentation page. If you do not have capacity, [create an issue in this repository using the ""Component documentation"" issue template][pajamas-component-documentation-template]. Bring the issue to your team planning session for prioritization and scheduling. Mark the new issue as related to this one. -1. [ ] **Assignee**: When applicable, [create an issue in GitLab UI using the ""Component"" issue template][gitlab-ui-component-template] to build or update the component code. Bring the issue to your team planning session for prioritization and scheduling. Mark the new issue as related to this one. -1. [ ] **Assignee**: 🎉 Congrats, you made it! You can now close this issue. - -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure -[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/.gitlab/merge_request_templates/component-guideline.md -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component -[pajamas-component-documentation-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation -[new-gitlab-ui-mr]: https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/new",3 -88218996,2021-06-04 13:06:52.884,Review navigation specs,"The following discussion from !2386 should be addressed: - -- [ ] @tomquirk started a [discussion](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2386#note_592680887): (+1 comment) - - > **suggestion (non-blocking)**: I guess we should have a spec or to that tests the `isExpanded` state. Not critical though :shrug: - ---- - -Let's drop the snapshot tests in favor of more relevant specs that won't fail every time we update the navbar.",1 -88166153,2021-06-03 14:39:38.731,Styles leaking into component examples,"When trying to implement `gl-markdown` wrapper on content pages, the component examples inherited some markdown styles.",3 -87943540,2021-05-31 03:12:25.114,Update presentation of when to use and not to use a selection component,"With the update to the toggle documentation https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2356 we have opted to remove the table to make a decision between form components in favour of sections `Usage` and `Do not use a toggle when`. - -Components that should be updated: - -- [ ] Single checkboxes https://design.gitlab.com/components/checkbox -- [ ] Single-select dropdown https://design.gitlab.com/components/dropdown -- [ ] Radio buttons https://design.gitlab.com/components/radio-button -- [ ] Segmented control https://design.gitlab.com/components/segmented-control -- [ ] Multiple checkboxes https://design.gitlab.com/components/checkbox -- [ ] Multi-select dropdown https://design.gitlab.com/components/dropdown",3 -87830111,2021-05-27 16:59:39.407,Getting Started > Structure > Audit and update language,"As our system grows, we're adding more complex elements such as object that include conceptual models and layouts in addition to regions. - -We want to ensure that definitions for each of these are clear to ensure that it is understandable where to add new elements that are larger than individual components. - -## Proposal - -Audit the [Getting Started > Structure](https://design.gitlab.com/get-started/structure) page for clarity. The end result should be a general understanding of what makes something a component vs. a region vs. an object.",2 -87309332,2021-05-18 20:21:55.583,Figma > Markdown type assets," - -### Description - - - -### Figma file - - - -[View working file in Figma →](ADD LINK TO FIGMA FILE/FRAME) - -### Checklist - -Make sure the following are completed before closing the issue: - -1. [ ] **Assignee**: Design in your working file. When applicable, follow our - [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [FE/UX Foundations designer][foundations-team]. -1. [ ] **Assignee**: Update the link to the working file in the issue - description. -1. [ ] **Assignee**: Ask a [FE/UX Foundations designer][foundations-team] - to review your design (ensure they have edit permissions in Figma). -1. [ ] **Reviewer**: Review and approve assignee’s design. Specific design - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [ ] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer] - for final review (make sure they have edit permissions in Figma). -1. [ ] **Maintainer**: Review and approve assignee’s changes. -1. [ ] **Maintainer**: Add the changes or additions to the target file. For - example, you’d copy a final chart design from the working file and paste into the related location in the Data Visualization file. - 1. [ ] Ensure that all styles and components now belong to the target file. - 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [ ] **Maintainer**: When applicable, [publish][publishing] any library - changes along with a clear commit message. -1. [ ] **Assignee**: Move your working file to the shared Figma project: - 1. [ ] For Component Library changes, move your file to the [**Component archive**][component-archive] project. - 1. [ ] For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. [ ] If you’re a community contributor, we ask that you [transfer ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -1. [ ] **Assignee** (or Maintainer, for community contributions): If it’s a new - pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [ ] **Assignee**: When applicable, create a merge request in this repository - with the [component-guideline template][component-guideline-template] - to create or update the component’s documentation page. -1. [ ] **Assignee**: When applicable, [create an issue in GitLab UI][new-gitlab-ui-issue] to build or update the component code. Mark the new issue as related to this one. -1. [ ] **Assignee**: 🎉 Congrats, you made it! You can now close this issue. - -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure -[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/.gitlab/merge_request_templates/component-guideline.md -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[new-gitlab-ui-issue]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new",3 -87205658,2021-05-17 14:14:00.042,Figma update: add description to Toggle like input field," - -### Description - -This is updated Toggle with the description below labels as a result of [previous issue](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=425%3A140) - -| Old | New | -| --- | --- | -| ![Screenshot_2021-05-17_at_16.10.33](/uploads/0e28a1ea02e55420ecac426db8d11e3f/Screenshot_2021-05-17_at_16.10.33.png) |![Screenshot_2021-05-17_at_16.11.37](/uploads/61e69d1ce82eab1209ff21173d9e2560/Screenshot_2021-05-17_at_16.11.37.png)| - - - -### Figma file - - - -[View working file in Figma →](https://www.figma.com/file/05EuMYkJptunHUcVHPcSA8/Untitled?node-id=1%3A375) - -### Checklist - -Make sure the following are completed before closing the issue: - -1. [x] **Assignee**: Design in your working file. When applicable, follow our - [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [FE/UX Foundations designer][foundations-team]. -1. [x] **Assignee**: Update the link to the working file in the issue - description. -1. [ ] **Assignee**: Ask a [FE/UX Foundations designer][foundations-team] - to review your design (ensure they have edit permissions in Figma). -1. [x] **Reviewer**: Review and approve assignee’s design. Specific design - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer] - for final review (make sure they have edit permissions in Figma). -1. [x] **Maintainer**: Review and approve assignee’s changes. -1. [x] **Maintainer**: Add the changes or additions to the target file. For - example, you’d copy a final chart design from the working file and paste into the related location in the Data Visualization file. - 1. [x] Ensure that all styles and components now belong to the target file. - 1. [x] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [x] **Maintainer**: When applicable, [publish][publishing] any library - changes along with a clear commit message. -1. [x] **Assignee**: Move your working file to the shared Figma project: - 1. [x] For Component Library changes, move your file to the [**Component archive**][component-archive] project. - 1. ~~[ ] For all other changes, move your file to the [**Misc archive**][misc-archive] project.~~ - 1. ~~[ ] If you’re a community contributor, we ask that you [transfer ownership of your draft file]~~(https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -1. [x] **Assignee** (or Maintainer, for community contributions): If it’s a new - pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [x] **Assignee**: When applicable, create a merge request in this repository - with the [component-guideline template][component-guideline-template] - to create or update the component’s documentation page. -1. ~~[ ] **Assignee**: When applicable, [create an issue in GitLab UI][new-gitlab-ui-issue] to build or update the component code. Mark the new issue as related to this one.~~ -1. [x] **Assignee**: 🎉 Congrats, you made it! You can now close this issue. - -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure -[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/.gitlab/merge_request_templates/component-guideline.md -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[new-gitlab-ui-issue]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new",3 -87036969,2021-05-13 14:07:18.818,Pajamas nav > Reconsider parent item function,"## Purpose - -In the Pajamas navigation a parent item both expands the subnav and takes a user to the first page of the subnav with the same click. Given that we don't make use of section overview pages this behavior feels a bit odd and misleading. While it's not difficult to determine where you landed, I don't think it's the most intuitive. It can also create a delay when you only wanted to access a page within that category, but have to wait for the first page to load before navigating where you wanted. - -I'd like to propose that the parent item only expands/collapses the subnav list and does not have it's own destination.",1 -87036283,2021-05-13 13:55:45.918,Consider dropping the use of details/summary in the navbar,"The following discussion from !2371 should be addressed: - -- [ ] @jeldergl started a [discussion](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2371#note_574973550): (+3 comments) - - > The use of `details` and `summary` here feels out of place semantically. I need to test this in a screen reader, but I'm wondering what the reason is for using it? - -The navbar currently leverages `
` and `` elements to render collapsible menu items. This might not be a valid use-case for those elements, let's consider dropping them in favor of simple `v-if`s in the Vue components. - -## Implementation plan - -- [x] Drop the use of summary elements in favor uls and v-ifs. -- [x] Do not automatically select the first child item when clicking on a parent. -- [x] Keep the behavior where only one menu section can be expanded at a time. -- [x] Improve navbar's accessibility by leveraing `role` and `aria-` attributes.",2 -86539036,2021-05-05 16:47:04.114,Adjust navigation items under Data Visualization,"Here is the current nav under data visualization in Pajamas: - -![Screen_Shot_2021-05-05_at_9.43.01_AM](/uploads/0ce25114150a3bb0ca96d188b99b3d4c/Screen_Shot_2021-05-05_at_9.43.01_AM.png) - -From discussion on https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2361#note_568114665, it sounds like the order of pages is because the nav items are automatically placed in alphabetical order. In this section, that leaves us with a surprising result - the Overview item is third and the more detailed pages (Charts, Color) are first. - -Should we consider re-ordering the pages in this section based on content rather than alphabetizing? - -If so, perhaps the order could be: - -- Overview -- Color -- Charts -- Single stat",1 -86503119,2021-05-05 09:18:26.731,Document a conceptual object model for Jobs,"## Problem - -Jobs are the main building block of a pipeline. Understanding the essence of Jobs and the concepts associated with them can help us create a better experience around Jobs in GitLab UI. Currently, Jobs are not documented as an object in GitLab. It's difficult to find information around all the concepts associated with jobs and how they're represented in the UI. - -## Proposal - -Document Jobs using the Conceptual Object Model. - -This model allows for proper separation of concerns: concepts (meaning) and user interface (representation). In other words, a conceptual model is only focused on the concepts and how they relate to each other, not how it’s technically implemented or used in the UI. A conceptual model defines the objects and actions, and enumerates the attributes for every object. The language of the conceptual model diagram is meant to be as simple and accessible as possible to everyone, even if they are not familiar with these kinds of diagrams (for more information, see [Object Modeling for Designers](https://medium.com/@hpadkisson/object-modeling-for-designers-an-introduction-7871bdcf8baf). - -Here's an example of how we document the [Merge Request as an object in GitLab.](https://design.gitlab.com/objects/merge-request) - -#### Next steps - -- [x] Document the concepts associated with Jobs -- [x] Map the concepts associated with Jobs -- [x] Document the layouts for the representations of Jobs in GitLab -- [x] Review the Figma file -- [x] Merge to the Conceptual object model file in Figma -- [x] Map the primary Job page layout -- [x] Merge the semantic layout to the Layouts file -- [x] Work on a documentation MR ([MR in review](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2713)) - -## Working Figma files - -* [Job object model](https://www.figma.com/file/J68bePHXIN5OPWqaFFY9ri/branch/bMpqqGQtDoPqty4sAFPUsy/Conceptual-model?node-id=5423%3A453) -* [Job semantic layout](https://www.figma.com/file/shVF8UZwrQtkNfMDjcrsyH/branch/PZruVNvWVcpdNwm69cXgeJ/Semantic-layouts?node-id=4636%3A208)",3 -86477742,2021-05-04 20:35:08.417,Themes > Adding missing color palettes,"Within Pajamas, Figma, and GitLab-UI we define a series of color palettes for each of our available themes. However, we are missing all of the options that are currently available in the product: - -![Screen_Shot_2021-05-04_at_1.34.18_PM](/uploads/e63808429305b01cbab67adc1bebeea1/Screen_Shot_2021-05-04_at_1.34.18_PM.png) - -Ensure there is continuity between the options in the product and the palettes in Pajamas.",2 -86245699,2021-04-29 20:09:27.201,A11y action > Increase input placeholder contrast,"## Purpose - -Placeholder text within a text input should have sufficient contrast (at least a 4.5:1 ratio). - -![image](/uploads/7cefc2c77c090f32fc071b1a7e1ae909/image.png) - -## Solution - -Use `$gray-500` for `placeholder` text. - -This should be updated both in Figma and GitLab UI. - -Source: https://gitlab.com/gitlab-org/gitlab-design/-/issues/1475#note_550956831",1 -86201104,2021-04-29 09:11:31.477,add description to Toggle like input field,"### Problem - -I have a need to use a long description to explain what does this toggle is about instead of short help text like ""disabled by admin"". If I use the help text, it looks like this: - -Those live example copies need to be refined. But the length and format illustrate the problem we will face. Long copy and copy with ""learn more"". I think we should discuss this because in English the copy might be short, but in another language, a two-line description might be common when we face German or another lengthy language. - -| Live Example | Component | -| --- | --- | -| ![Screenshot_2021-04-30_at_09.50.07](/uploads/459b3285064480d5a11b141534095ee5/Screenshot_2021-04-30_at_09.50.07.png)![Screenshot_2021-04-30_at_09.55.32](/uploads/8a2a5f4b8295a4f219879186a4aa3164/Screenshot_2021-04-30_at_09.55.32.png)| ![Screenshot_2021-04-29_at_11.12.38](/uploads/1a80149ee0ae91812bab064f43ee5cbb/Screenshot_2021-04-29_at_11.12.38.png)| - -**This has two problems:** - -1. The description is far from the label it belongs to and closer to the label of the next item. This creates more cognition load for a user to figure out, this description belongs to which one? -1. It is too long and visually looks unbalanced - -### Solution - -| vertical1 - Live Example | vertical1 - Component | -| --- | --- | -| ![Screenshot_2021-04-30_at_09.49.33](/uploads/00c0fce14fbf63669f958ae3e0b2edcd/Screenshot_2021-04-30_at_09.49.33.png) | ![Screenshot_2021-04-29_at_11.09.57](/uploads/f34e95f7f42b2184cb4b8a3e03f6561f/Screenshot_2021-04-29_at_11.09.57.png) | - -
Other explorations - -| vertical2 - Live Example | vertical2 - Component | -| --- | --- | -|![Screenshot_2021-04-30_at_09.49.38](/uploads/eef1aa5fde30dc0c159250a37d7adb15/Screenshot_2021-04-30_at_09.49.38.png)|![Screenshot_2021-04-30_at_09.51.37](/uploads/2c19442d8db58a44c96393cd196ee1b4/Screenshot_2021-04-30_at_09.51.37.png)| - -| horizontal Live Example | horizontal - component | -| ------------ | --------- | -| ![Screenshot_2021-04-30_at_10.51.01](/uploads/75dc9299de6d7b7a760e67b61ba2704a/Screenshot_2021-04-30_at_10.51.01.png) ![Screenshot_2021-04-30_at_10.50.57](/uploads/28982d1f3bcd2c045ee1c60a267a772c/Screenshot_2021-04-30_at_10.50.57.png) | ![Screenshot_2021-04-30_at_10.58.12](/uploads/c0e42bea94330edb606f16cbe4e20dd9/Screenshot_2021-04-30_at_10.58.12.png) | -| ![Screenshot_2021-04-30_at_10.50.53](/uploads/fd33afcfc2aeef24bf8dc21694774f1c/Screenshot_2021-04-30_at_10.50.53.png)| ![Screenshot_2021-04-30_at_10.58.15](/uploads/0c57427e72defa377fbd0440100210f3/Screenshot_2021-04-30_at_10.58.15.png)| - -
- - -cc: @gitlab-com/gitlab-ux/designers",3 -86162773,2021-04-28 18:54:54.496,A11y action > Update audit issues to include severity rating,"# Proposal - -We have a number of [accessibility audit issues](https://gitlab.com/groups/gitlab-org/-/epics/5387) open. We should include a severity rating for each finding. - -# Background - -> One thing I haven’t included in the audits I’ve done so far is the level of severity. I’ll try to do that from now on. -> -> This is the same I’ve used before: -> -> - **Critical:** prevents some or all users from performing critical tasks with no workaround. -> - **High:** prevents some users from performing critical tasks, or where a workaround may exist. -> - **Medium:** prevents some users from performing non-critical tasks, or where the user experience is seriously degraded for users with certain assistive technologies. -> - **Low:** the user experience is degraded for users with certain disabilities or using certain assistive technologies. -> ->This is the rating Deque proposes: -> ->- **Critical:** This issue results in blocked content for individuals with disabilities. Until a solution is implemented content will be completely inaccessible, making the organization highly vulnerable to legal action. ->- **Serious:** This issue results in serious barriers for individuals with disabilities. Until a solution is implemented, some content will be inaccessible, or significant a work-around is required, making the organization vulnerable to legal action. Users with disabilities may experience significant frustration when attempting to access content. ->- **Moderate:** This issue results in some barriers for individuals with disabilities but would not prevent them from accessing fundamental elements or content. Users with disabilities may experience moderate frustration when encountering this issue. ->- **Minor:** This is an issue that may inconvenience a user but would not cause significant frustration in accessing content or accomplishing tasks. - -Source: -https://gitlab.com/gitlab-org/gitlab-design/-/issues/1473#note_545158557, https://gitlab.com/gitlab-org/gitlab-design/-/issues/1473#note_545159441 - -~accessibility ~""Category:FE/UX Foundations""",1 -86162768,2021-04-28 18:54:53.881,A11y action > Add content to Forms > Placeholders,"# Proposal - -Add documentation to ` Forms > Placeholders` that describes the following: - -> the intended use of placeholder text is for extra, non-essential information - -# Background - ->the intended use of placeholder text is for extra, non-essential information. -> ->>I like this little nugget and I think it’d be worth adding something similar in an update to https://design.gitlab.com/components/form#placeholders. - -Source: https://gitlab.com/gitlab-org/gitlab-design/-/issues/1470#note_538076572 - -~accessibility ~""Category:FE/UX Foundations""",1 -86162754,2021-04-28 18:54:51.567,A11y action > Inclusive design presentation,"# Proposal - -Create a presentation that addresses inclusive design and showcase it to the UX Department in order to increase awareness of biases. - -@jeldergl is currently working on a presentation that would be a good fit to satisfy this. - -# Background - ->Some training on how to recognize bias in design would be helpful. In other words, evaluating design against our own bias and examine if we’re meeting the needs of more than just those like us — whatever that us may be. - -Source: https://gitlab.com/gitlab-org/gitlab-design/-/issues/1463#note_499957432 - -~accessibility ~""Category:FE/UX Foundations",4 -85846218,2021-04-23 20:42:01.871,Dig into whether or not the status table is accurate,"As per discussion with Taurie: There is some concern that the [component status table](https://design.gitlab.com/components/status) isn't totally up-to-date. - -The goal for this issue would be to go through the [existing status table](https://design.gitlab.com/components/status) and dig into the `in progress` items to see if they can actually be moved to complete.",3 -85755120,2021-04-22 15:10:38.328,Extend guidelines on labels,"Discussion ---- - -[Labels](https://docs.gitlab.com/ee/user/project/labels.html) in GitLab have historically been tightly coupled with Issues, Epics, and Merge Requests ~""group::project management"". There are other use cases (Compliance Frameworks or Topics) in GitLab where users are creating elements to categorize objects that would benefit from using [label](https://gitlab-org.gitlab.io/gitlab-ui/?path=/story/base-label--default) the component. - -> Scoped labels are a sub-type of labels, and their usage is determined by the user. A scoped label is differentiated from a regular label by the contrasting colors on the left and right sides of the label. - [Pajamas](https://design.gitlab.com/components/label/#usage) - -Pajamas merely states that there is only a differentiation in the UI, but there is a unique feature tied to [exclusivity](https://docs.gitlab.com/ee/user/project/labels.html#scoped-labels) in scoped labels for project management. Compliance Frameworks are currently using scoped labels just for visual flair, although it is not possible to apply more than one Compliance Framework to a project today. - -When considering the `scoped label` attribute, should this UI element always have exclusivity as a corresponding feature?",1 -85687189,2021-04-21 17:40:35.935,Brand > Combine brand basic and resources,"In https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2345, `@ameliabauerly` mentioned that we could combine the Brand basics and Resources content into one page. We could add those links to the bottom of the Brand > Basics page and not need an entirely separate page for them.",1 -85687107,2021-04-21 17:38:54.431,Brand personality / Design principles table,"In https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2345, we are removing outdated brand pages that are no longer shown in the sidebar. This includes the following table: - -![brand personality table](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/uploads/5bdc8d3b977de19a7423bff75925c959/Screen_Shot_2021-04-20_at_11.18.20_AM.png) - -Should we include this somewhere within our brand docs or possibly use it to better define our design principles?",2 -85592955,2021-04-20 19:58:52.988,Collapse sidebar after navigation on mobile devices,"The following discussion from !2301 should be addressed: - -- [ ] @oregand started a [discussion](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2301#note_556227195): (+3 comments) - - > @pgascouvaillancourt - > - > Great work on this, it looks super and feels great to use! I have left a selection of comments for you to check at your own time but your overall approach looks good to me here given the constraints you're working against with the keys && file boostrapping :smile: - > - > I was going to ask if we had supporting specs but see we don't have them in this repo yet :joy: - > - > One ~UX suggestion, we might want to auto close the sidebar on navigation from the search when we're on mobile but that's a non-blocking suggestion! - > - > - > ![R1](/uploads/1cfa51f90106edd08012e080336d4043/R1.mov) - ---- - -On mobile devices, the navigation sidebar can be expanded and overlaps the primary content. From there, clicking any link properly triggers navigation through `vue-router`, but the sidebar remains expanded, hiding the content that's being accessed. - -Let's improve the ~UX by automatically collapsing the sidebar whenever navigation occurs.",2 -85279391,2021-04-15 23:56:05.764,Figma component > Table (updates to sorting and additional states)," - -## Description - - - -This is a follow up issue to [Figma component > Add Tables](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/721). The table currently is still missing responsive states and is not leveraging some of Figma's newer layout features. - -### Summary of overall table updates: - -- All cell content is now `top` aligned by default -- The sorting arrow has been moved closer to the right of the header label, in order to make it clear which header label they belong to -- On hover and on focus states have been to header cells if the configuration is set to sortable -- A new 'compressed` table option has been added (https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/449) -- A new row state has been added (https://gitlab.com/gitlab-org/gitlab-ui/-/issues/884) -- A new `` component has been added (https://gitlab.com/gitlab-org/gitlab-ui/-/issues/1726) -- A top border has been added to the header row in order to better visual understand where the table starts and ends on a page - -### Summary of Figma specific updates: - -Since the first version of the Figma Table component that has been added to our component library, Figma has introduced many new features specific to [Auto Layout](https://help.figma.com/hc/en-us/articles/360040451373-Create-dynamic-designs-with-auto-layout) that make creating tables more flexible. This update will make it easier for designers to create responsive tables in Figma that are easier to customize and lower the need to detach from parent components. - -**Sorting interaction spec:** - -![table-interaction](/uploads/dd95bd2653ad5b3ea6f27e27d91c272e/table-interaction.mp4) - -### Rationale for current updates - -| Overall component usage (last 90 days) | Variants being used (last 90 days) | -| ------ | ------ | -| ![CleanShot_2022-01-13_at_12.27.15_2x](/uploads/e2d38b9540191eac779dcb460a11292c/CleanShot_2022-01-13_at_12.27.15_2x.png) | ![CleanShot_2022-01-13_at_12.28.42_2x](/uploads/f51c5d9412375aea6d004c33619fc742/CleanShot_2022-01-13_at_12.28.42_2x.png) | -| **Insights:**
In the first version of the table component a lot of time was put into creating the multi-line variant which shows no usage. | **Insights:**
The checkbox variant is the second most used. This newer update makes it easier to turn on/off the selectable state for entire rows. | - -Note: Thank you @jeldergl for pulling these metrics from Figma. - - -### Figma file - - - -[View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/Wli6qiEaC8rnXfeQiukJHw/Component-library?node-id=425%3A11) - -### References -- https://getbootstrap.com/docs/5.0/content/tables/ -- https://mdbootstrap.com/docs/b4/jquery/tables/sort/ -- https://material.angular.io/components/table/overview#sorting -- https://material.io/components/data-tables#anatomy - -### Demo walkthrough - -- :tv: https://youtu.be/7tEa-qT_MfY ---- - -### Checklist - -Make sure the following are completed before closing the issue: - -1. [x] **Assignee**: Design in your working file. When applicable, follow our - [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [FE/UX Foundations designer][foundations-team]. -1. [x] **Assignee**: Update the link to the working file in the issue - description. -1. [x] **Assignee**: Ask a [FE/UX Foundations designer][foundations-team] - to review your design (ensure they have edit permissions in Figma). -1. [x] **Reviewer**: Review and approve assignee’s design. Specific design - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer] - for final review (make sure they have edit permissions in Figma). -1. [x] **Maintainer**: Review and approve assignee’s changes. -1. [x] **Maintainer**: Merge the branch or add the changes or additions to the - target file. - 1. [ ] Ensure that all styles and components now belong to the target file. - 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [x] **Maintainer**: When applicable, [publish][publishing] any library - changes along with a clear commit message. -1. [x] **Assignee**: If work was not done in a branch (a merged branch will automatically be archived), move your working file - to the shared Figma project: - 1. [ ] For Component Library changes, move your file to the [**Component archive**][component-archive] project. - 1. [ ] For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. [ ] If you’re a community contributor, please consider [transfering ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -1. [x] **Assignee** (or Maintainer, for community contributions): If it’s a new - pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [x] **Assignee**: When applicable, [create an MR in this repository][new-gitlab-ui-mr] and apply the ""component-guideline"" template - to create or update the component’s documentation page. If you do not have capacity, [create an issue in this repository using the ""Component documentation"" issue template][pajamas-component-documentation-template]. Bring the issue to your team planning session for prioritization and scheduling. Mark the new issue as related to this one. -1. [x] **Assignee**: When applicable, [create an issue in GitLab UI using the ""Component"" issue template][gitlab-ui-component-template] to build or update the component code. Bring the issue to your team planning session for prioritization and scheduling. Mark the new issue as related to this one. -1. [x] **Assignee**: 🎉 Congrats, you made it! You can now close this issue. - -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure -[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/.gitlab/merge_request_templates/component-guideline.md -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component -[pajamas-component-documentation-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation -[new-gitlab-ui-mr]: https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/new",2 -84821078,2021-04-07 20:17:15.813,FY22-Q2 Foundations KR2: Create a maintained backlog of Pajamas issues that enables product designers and engineers to easily find issues and contribute => 79%,"[FY22-Q2 UX Department: Foundations SubTeam OKR](https://gitlab.com/groups/gitlab-org/-/epics/5726) - -Objective: Ensure Engineering is able to iteratively contribute to and utilize Pajamas for stage work deliverables - -**KR2: Create a maintained backlog of Pajamas issues that enables product designers and engineers to easily find issues and contribute** - -- [x] Ensure all issues within the Pajamas repo have a workflow label. See our [workflow label board](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/boards/1835632) 336/336 => 100% -- [ ] Ensure all issues within the Pajamas repo have a weight. See [issues without weights](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues?scope=all&state=opened&weight=None) 197/336 => 18% - -533/672 => 79%",13 -82133985,2021-04-01 16:22:35.504,Figma > Form > Add form_input_group," - -### Description - -`form_input_group` was introduced in GitLab UI (https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/2115) which includes a form input that is grouped together with another element, such as a label or button. - -This component is being used on the `new fork` page, see https://gitlab.com/gitlab-org/gitlab/-/merge_requests/53544 - -We don't currently have this component within our UI Kit and the styling in GitLab UI does not match our visual language. - -The purpose of this issue is to get the component within Figma, and then to open up the needed issues in GitLab UI to correct the styling. - -### Figma file - - - -[View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/cdUPbjyDRc326Rk6KGyxKw/Component-library) (Branch is archived after merge) - -### Checklist - -Make sure the following are completed before closing the issue: - -1. [x] **Assignee**: Design in your working file. When applicable, follow our - [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [FE/UX Foundations designer][foundations-team]. -1. [x] **Assignee**: Update the link to the working file in the issue - description. -1. [x] **Assignee**: ~~Ask a [FE/UX Foundations designer][foundations-team]~~ Assigned to Figma trainee - to review your design (ensure they have edit permissions in Figma). -1. [x] **Reviewer**: Review and approve assignee’s design. Specific design - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer] - for final review (make sure they have edit permissions in Figma). -1. [x] **Maintainer**: Review and approve assignee’s changes. -1. [x] **Maintainer**: Add the changes or additions to the target file. For - example, you’d copy a final chart design from the working file and paste into the related location in the Data Visualization file. - 1. [ ] Ensure that all styles and components now belong to the target file. - 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [x] **Maintainer**: When applicable, [publish][publishing] any library - changes along with a clear commit message. -1. [x] **Assignee**: Move your working file to the shared Figma project: - 1. [x] For Component Library changes, move your file to the [**Component archive**][component-archive] project. - 1. [ ] For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. [ ] If you’re a community contributor, we ask that you [transfer ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -1. [x] **Assignee** (or Maintainer, for community contributions): If it’s a new - pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [ ] **Assignee**: When applicable, create a merge request in this repository - with the [component-guideline template][component-guideline-template] - to create or update the component’s documentation page. -1. [x] **Assignee**: When applicable, [create an issue in GitLab UI][new-gitlab-ui-issue] to build or update the component code. Mark the new issue as related to this one. -1. [ ] **Assignee**: 🎉 Congrats, you made it! You can now close this issue. - -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#structure -[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/.gitlab/merge_request_templates/component-guideline.md -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[new-gitlab-ui-issue]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new",3 -81860969,2021-03-29 16:11:53.212,Include GitLab UI utilities,"The following discussion from !2300 should be addressed: - -- [ ] @markrian started a [discussion](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2300#note_540028499): (+2 comments) - - > **question (non-blocking)**: A quick grep suggests we don't use GitLab UI's utility classes in this repo. Should we?",1 -81418386,2021-03-22 14:45:44.188,Badge > Linked badges > Make examples in Pajamas the SSoT,"## Problem - -Embedded badge examples in Pajamas are different from GitLab UI. Having a SSoT will help accurately complete the badge accessibility audit https://gitlab.com/groups/gitlab-org/-/epics/5664. - -| **Pajamas** | **GitLab UI** | -| ------ | ------ | -| ![CleanShot_2021-03-22_at_15.10.48](/uploads/dce63a5d5d950da45aecb677b3cb1337/CleanShot_2021-03-22_at_15.10.48.gif) | ![CleanShot_2021-03-22_at_15.11.14](/uploads/a5429badcb1749274d21c7eb1b9e6db7/CleanShot_2021-03-22_at_15.11.14.gif) | - -## Solution - -Ensure badge examples align with the [badge design specs](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=425%3A3) and that action badges dont underline text on hover.",2 -81248852,2021-03-19 03:53:26.938,Update guidelines around left menu items," -- [x] Guidelines around what the menu items in the left sidebar - - https://design.gitlab.com/regions/navigation#contextual-navigation - - What should be a primary level item vs secondary - - Updated: https://design.gitlab.com/regions/navigation#left-sidebar - - ⛔️ Should ""Labels"" be allowed to jump between a submenu item to parent level? https://gitlab.com/gitlab-org/gitlab/-/issues/21147#note_525491995 - - We are putting Labels into `Project information` https://gitlab.com/gitlab-org/gitlab/-/issues/329905 -- [x] Landing pages should be the first sub menu item - - https://design.gitlab.com/regions/navigation#product-landing-pages - - -## Draft outline - -### Parent item - -### Submenu items - -- Items in the submenu should help support navigation to the parent JTBD and supporting JTBD -- High level features of the category",3 -81245967,2021-03-19 03:15:30.567,Update documentation for global navigation,"## Proposal - -Relates to this page https://design.gitlab.com/regions/navigation#global-navigation - -- [ ] Update documentation for the consolidated projects/group/more menu -- [ ] Add example of the menus mentioned - -~""Category:Navigation & Settings""",2 -80557737,2021-03-09 13:55:08.340,Update the dropdown component with variants and add missing variants," - -### Description - - - -@lvanc and I noticed that there are some cases are missing in our current dropdown component while adding the filter component. https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/720 - -We can add this to the existing component as variants or/and instances. - -And switch to the variants style structure and make the component more flexible. - -| Icon + Text | Text + Help text | User profile | -| ------ | ------ | ------ | -| ![Screenshot_2021-03-09_at_14.49.36](/uploads/3ed040f1a90dcae4dd36a7fdedb72392/Screenshot_2021-03-09_at_14.49.36.png)| ![Screenshot_2021-03-09_at_14.49.50](/uploads/ae27890d803d8d272d769cf0f09c3403/Screenshot_2021-03-09_at_14.49.50.png) | ![Screenshot_2021-03-09_at_14.49.45](/uploads/abcbd2edb84da991636ef55ce4490570/Screenshot_2021-03-09_at_14.49.45.png) | - -### Figma file - - - -[View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/2OhkWPJsIE6FSbaTugAVPw/Component-library?node-id=425%3A14) - -### Checklist - -Make sure the following are completed before closing the issue: - -1. [x] **Assignee**: Design in your working file. When applicable, follow our - [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [FE/UX Foundations designer][foundations-team]. -1. [x] **Assignee**: Update the link to the working file in the issue - description. -1. [x] **Assignee**: Ask a [FE/UX Foundations designer][foundations-team] - to review your design (ensure they have edit permissions in Figma). -1. [x] **Reviewer**: Review and approve assignee’s design. Specific design - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer] - for final review (make sure they have edit permissions in Figma). -1. [ ] **Maintainer**: Review and approve assignee’s changes. -1. [ ] **Maintainer**: Merge the branch or add the changes or additions to the - target file. - 1. [ ] Ensure that all styles and components now belong to the target file. - 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [ ] **Maintainer**: When applicable, [publish][publishing] any library - changes along with a clear commit message. -1. [ ] **Assignee**: Move your working file to the shared Figma project: - 1. [ ] For Component Library changes, move your file to the [**Component archive**][component-archive] project. - 1. [ ] For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. [ ] If you’re a community contributor, we ask that you [transfer ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -1. [ ] **Assignee** (or Maintainer, for community contributions): If it’s a new - pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [ ] **Assignee**: When applicable, create a merge request in this repository - with the [component-guideline template][component-guideline-template] - to create or update the component’s documentation page. -1. [ ] **Assignee**: When applicable, [create an issue in GitLab UI][new-gitlab-ui-issue] to build or update the component code. Mark the new issue as related to this one. -1. [ ] **Assignee**: 🎉 Congrats, you made it! You can now close this issue. - -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#structure -[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/.gitlab/merge_request_templates/component-guideline.md -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[new-gitlab-ui-issue]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new",2 -80543959,2021-03-09 10:32:29.713,Update segmented control visual style," - -### Description - -create consistent button styles - -| Before | New | -| ------ | --- | -| ![Instances](/uploads/e2b34edc60cc16aa3df336fe52961351/Instances.png) | ![Camellia_WIP_-_instance](/uploads/688c0a4bc64bc4002bdce2f56ef4fd74/Camellia_WIP_-_instance.png) | - - -#### Visual Design Changes - -- Selected states: remove shadows, used a border to indicate selection -- Hover status: a light grey background $gray-50 - -### Figma file - - - -[View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/7FLQ3LnDhj3vI7QnGAkTjn/Component-library) - -### Checklist - -Make sure the following are completed before closing the issue: - -1. [x] **Assignee**: Design in your working file. When applicable, follow our - [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [FE/UX Foundations designer][foundations-team]. -1. [x] **Assignee**: Update the link to the working file in the issue - description. -1. [x] **Assignee**: Ask a [FE/UX Foundations designer][foundations-team] - to review your design (ensure they have edit permissions in Figma). -1. [x] **Reviewer**: Review and approve assignee’s design. Specific design - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer] - for final review (make sure they have edit permissions in Figma). -1. [x] **Maintainer**: Review and approve assignee’s changes. -1. [x] **Maintainer**: Add the changes or additions to the target file. For - example, you’d copy a final chart design from the working file and paste into the related location in the Data Visualization file. - 1. [x] Ensure that all styles and components now belong to the target file. - 1. [x] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [x] **Maintainer**: When applicable, [publish][publishing] any library - changes along with a clear commit message. -1. [-] **Assignee**: Move your working file to the shared Figma project: (File automatically archived since it was a branch.) - 1. [-] For Component Library changes, move your file to the [**Component archive**][component-archive] project. - 1. [-] For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. [-] If you’re a community contributor, we ask that you [transfer ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -1. [x] **Assignee** (or Maintainer, for community contributions): If it’s a new - pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [x] **Assignee**: When applicable, create a merge request in this repository - with the [component-guideline template][component-guideline-template] - to create or update the component’s documentation page. -1. [x] **Assignee**: When applicable, [create an issue in GitLab UI][new-gitlab-ui-issue] to build or update the component code. Mark the new issue as related to this one. -1. [x] **Assignee**: 🎉 Congrats, you made it! You can now close this issue. - -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#structure -[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/.gitlab/merge_request_templates/component-guideline.md -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[new-gitlab-ui-issue]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new",3 -80101565,2021-03-02 15:01:16.599,Update Figma text input to use variants," - -### Description - - - -Figma introduce variants, it is time to update the text input field - -### Figma file - - - -[View working file in Figma →](https://www.figma.com/file/OU6DPkNlneFHnXwcUILWfl/WIP-Update-input-text-field?node-id=1%3A2) - -### Checklist - -Make sure the following are completed before closing the issue: - -1. [x] **Assignee**: Design in your working file. When applicable, follow our - [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [FE/UX Foundations designer][foundations-team]. -1. [x] **Assignee**: Update the link to the working file in the issue - description. -1. [x] **Assignee**: Ask a [FE/UX Foundations designer][foundations-team] - to review your design (ensure they have edit permissions in Figma). -1. [x] **Reviewer**: Review and approve assignee’s design. Specific design - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer] - for final review (make sure they have edit permissions in Figma). -1. [x] **Maintainer**: Review and approve assignee’s changes. -1. [x] **Maintainer**: Add the changes or additions to the target file. For - example, you’d copy a final chart design from the working file and paste into the related location in the Data Visualization file. - 1. [x] Ensure that all styles and components now belong to the target file. - 1. [x] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [x] **Maintainer**: When applicable, [publish][publishing] any library - changes along with a clear commit message. -1. [x] **Assignee**: Move your working file to the shared Figma project: - 1. [x] For Component Library changes, move your file to the [**Component archive**][component-archive] project. - 1. [x] For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. [x] If you’re a community contributor, we ask that you [transfer ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -1. [x] **Assignee** (or Maintainer, for community contributions): If it’s a new - pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [-] **Assignee**: When applicable, create a merge request in this repository - with the [component-guideline template][component-guideline-template] - to create or update the component’s documentation page. -1. [-] **Assignee**: When applicable, [create an issue in GitLab UI][new-gitlab-ui-issue] to build or update the component code. Mark the new issue as related to this one. -1. [x] **Assignee**: 🎉 Congrats, you made it! You can now close this issue. - -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#structure -[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/.gitlab/merge_request_templates/component-guideline.md -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[new-gitlab-ui-issue]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new",4 -79233372,2021-02-17 03:19:08.833,Document tree updates in Pajamas [Tree🌲],"Document any changes to the tree component here to be merged into [Pajamas](https://design.gitlab.com/product-foundations/interaction#drag-and-drop}https://design.gitlab.com/components/tree). - -#### 📌 Merge requests - -* .... - -#### ✨ Overall change highlights - -* ...",3 -86894837,2021-02-12 17:07:47.583,Introduce search to Pajamas,"As part of our [Pajamas engagement survey](https://gitlab.com/gitlab-org/gitlab-design/-/issues/1394), we heard that people would like to be able to search through Pajamas to find exactly the information they need. - -How do we go about introducing search to Pajamas?",3 -78823017,2021-02-10 15:30:54.588,Document drag and drop updates in Pajamas [Drag & drop🤏],"Document any changes to drag & drop here to be merged into [Pajamas](https://design.gitlab.com/product-foundations/interaction#drag-and-drop). - -#### :pushpin: Merge requests -- https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/1941 -- .... - -#### :sparkles: Overall change highlights -- ...",3 -78444893,2021-02-04 16:49:34.972,Create live figma embed for form-group submit button behavior,"Based on my confusion of some documentation, I thought it would be worthwhile to add some visual clarity to what we're explaining, specifically for behaviors.",2 -78193008,2021-02-01 10:22:17.161,Update Figma tooltip component with Variant," - -### Description - - - -I worked a lot recently with a tooltip. I found that the current component is not very easy to use because: - -1. I need to detach it every time because the container doesn't auto grow with the text -1. After detach, I need to resize it and not very easy to keep the spacing manually -1. I need to hide/show arrows in the layers instead of using a variant - -So I updated the tooltip component structure with variants, now it can auto grow, two lines just need to hit enter and use different arrow position can be chosen from variants manual on the right-hand side. Please see the picture below :point_down: or watch this [`video intro`](https://www.loom.com/share/bd509b045e8e41f5ae4eb29fc22fb32f). - - -| Current component | Updated component by using variants | -| --- | --- | -| ![old-tooltip](/uploads/2a76cb80fb194e831d0759129fcffba2/old-tooltip.gif) | ![new-tooltip](/uploads/7d870405a99ce11fb832274a85c27257/new-tooltip.gif)| - - -### Figma file - - - -[View working file in Figma →](https://www.figma.com/file/nmpl8tphpsmcDlMYfiviOS/Tooltip-component-update-Pajama-805?node-id=1%3A2) - -### Checklist - -Make sure the following are completed before closing the issue: - -1. [x] **Assignee**: Design in your working file. When applicable, follow our - [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [FE/UX Foundations designer][foundations-team]. -1. [x] **Assignee**: Update the link to the working file in the issue - description. -1. [ ] **Assignee**: Ask a [FE/UX Foundations designer][foundations-team] - to review your design (ensure they have edit permissions in Figma). -1. [ ] **Reviewer**: Review and approve assignee’s design. Specific design - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [ ] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer] - for final review (make sure they have edit permissions in Figma). -1. [ ] **Maintainer**: Review and approve assignee’s changes. -1. [ ] **Maintainer**: Add the changes or additions to the target file. For - example, you’d copy a final chart design from the working file and paste into the related location in the Data Visualization file. - 1. [ ] Ensure that all styles and components now belong to the target file. - 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [ ] **Maintainer**: When applicable, [publish][publishing] any library - changes along with a clear commit message. -1. [ ] **Assignee**: Move your working file to the shared Figma project: - 1. [ ] For Component Library changes, move your file to the [**Component archive**][component-archive] project. - 1. [ ] For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. [ ] If you’re a community contributor, we ask that you [transfer ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -1. [ ] **Assignee** (or Maintainer, for community contributions): If it’s a new - pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [ ] **Assignee**: When applicable, create a merge request in this repository - with the [component-guideline template][component-guideline-template] - to create or update the component’s documentation page. -1. [ ] **Assignee**: When applicable, [create an issue in GitLab UI][new-gitlab-ui-issue] to build or update the component code. Mark the new issue as related to this one. -1. [ ] **Assignee**: 🎉 Congrats, you made it! You can now close this issue. - -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#structure -[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/.gitlab/merge_request_templates/component-guideline.md -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[new-gitlab-ui-issue]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new",2 -77550425,2021-01-20 14:23:00.232,chore: Point gitlab-ui status links to Storybook,,2 -77176298,2021-01-13 16:46:21.198,Guideline to open help links in new tab or not,"In the [helping users](https://design.gitlab.com/usability/helping-users) section of the pajamas, we make use of two kinds of text links. While it's clear what the text should be, there's no guideline whether that link should open in a new tab or not. - -We do however have some general guidelines about [external links](https://design.gitlab.com/product-foundations/interaction/#links-to-external-resources). - -## More details - -I personally am in favor of the new tab functionality, and this makes sense for GitLab.com where we now redirect all help links to the external site https://docs.gitlab.com. - -For self-managed instances however, the help links still point to the `/help` page of the instance. - -## Accessibility issues - -Best practice for accessibility by default is to use native browser behavior and open in the same window. -Once `target=""_blank""` is used it disables all other browser options, so it’s best to let the user choose. - -## Resources - -- https://css-tricks.com/use-target_blank/ -- Docs guidelines on links https://docs.gitlab.com/ee/development/documentation/#linking-to-help",1 -76702013,2021-01-04 14:19:33.381,Form: multi-column/row of grouped options in forms,"### Background - -This is an issue created based on [another issue](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues). Before we document something we agree on, we want to explore different solution options. - -### Problem - -In some areas, the user needs to set up complicated settings, such as variable sets with some details fine-tuning. Each variables settings is a group, and users need to see them together to have a better overview or comparing different variable groups. - -The design needs to be flexible for desktop and mobile, easy to read and identify the groups. - -| Example 1 | Example 2 | -| --------- | --------- | -| ![Screenshot_2021-01-04_at_14.50.24](/uploads/a728ee6b2e7da9405b5acb2fd876f926/Screenshot_2021-01-04_at_14.50.24.png) | ![Screenshot_2021-01-04_at_14.50.33](/uploads/51b1af1081f717a44c8fb38650461dd9/Screenshot_2021-01-04_at_14.50.33.png) | - - - -### Solution - -| Option 1 - Row grouping | Option 2 - Column grouping | Option 3 -??? | -| --------- | --------- | -------- | -| ![row-based](/uploads/4d44b8f8fdcc9a8928a9edf439c05a8c/row-based.png) | ![column-based](/uploads/b6c90c28d7446e7da1bbf03efdf9b2a9/column-based.png) | | -| | | |",3 -76385293,2020-12-22 13:01:27.956,Examples are sometimes loaded from an incorrect component,"In https://design.gitlab.com/components/accordion/code, the examples are loaded from `GlAccordionItem` instead if `GlAccordion`.",1 -73936334,2020-11-05 19:45:18.779,Content section > Determine how to dedupe documentation with doc styleguide,"# Problem - -There are currently multiple places where we have content guidelines including: - -* Pajamas: [Punctuation](https://design.gitlab.com/content/punctuation), [Terminology](https://design.gitlab.com/content/terminology), [Voice and tone](https://design.gitlab.com/content/voice-tone) -* Docs: [Styleguide](https://docs.gitlab.com/ee/development/documentation/styleguide.html) -* Handbook: [Styleguide](https://about.gitlab.com/handbook/style-guide/), [Markdown](https://about.gitlab.com/handbook/markdown-guide/) - -There is repeated content in all of these sections, making it difficult to know when to go where for what. - -We've started trying to harmonize this content between the different areas, which is resulting in content that is not DRY. For example, see https://gitlab.com/gitlab-org/gitlab/-/merge_requests/26326 and https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2148. - -Tech writing has started to look at both styleguides and align them here: https://gitlab.com/gitlab-org/gitlab-docs/-/issues/636. However, we need to determine the IA in order to ensure that we are not continuing to duplicate content over time. - -# Solution - -Determine how to dedupe content docs in all various locations. This could include: - -- Moving all content docs to one area - - Pros: Everything is in one place, you always know where to go to find what you need. Content isn't duplicated. - - Cons: There are separate use cases for docs and product, so the documentation in this section could be expansive. Good IA would be needed so its easy to find details. -- Keeping documentation docs and product docs separate, with clear cross-linking as needed. - - Pros: Separation of concerns could make it easier to find detailed docs as needed - - Cons: A lot of content overlaps, so it may be difficult to fully dedupe and could mean lots of cross linking and jumping back and forth between sections.",8 -73807957,2020-11-03 14:54:40.845,Move calendar icon in date picker,"Per @cam.x’s great suggestion in https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/726#note_432971319, consider moving the calendar icon to the left of the date picker input. - -**Benefits** - -- Aligns with how the search input is handled. -- Provides more room on the right to use the clear × option. - -![image](/uploads/bce5035304cede9416903d01a15cd98a/image.png) - -/cc @gitlab-com/gitlab-ux/ux-foundations",2 -72858125,2020-10-16 23:12:12.730,Add lock-solid to GitLab UI Kit for Figma," - -### Description - - - -When switching between ![lock-open.svg](/uploads/99da016b31d4ad74b2ece95a03fb9a67/lock-open.svg) and ![lock.svg](/uploads/0f089f836eef9885e029a4f6c8148bc1/lock.svg) there is not enough visual distinction to quickly identify if something is locked or unlocked. - -:new: icon ![lock-solid.svg](/uploads/8d14bd75d006df61d5b43778f860ac37/lock-solid.svg) - -🤚Blocking Merge Request ![merge-request-open.svg](/uploads/92b44dce6523ad469086925c7e5dada2/merge-request-open.svg) - https://gitlab.com/gitlab-org/gitlab-svgs/-/merge_requests/632 - -### Figma file - - - -[View working file in Figma →](https://www.figma.com/file/nLyPs9zeRPQUAAmKckfLjM/Icon-lock-solid?node-id=125%3A35) - -### Checklist - -Make sure the following are completed before closing the issue: - -1. [x] **Assignee**: Design in your working file. When applicable, follow our - [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [FE/UX Foundations designer][foundations-team]. -1. [x] **Assignee**: Update the link to the working file in the issue - description. -1. [x] **Assignee**: Ask a [FE/UX Foundations designer][foundations-team] - to review your design (ensure they have edit permissions in Figma). -1. [ ] **Reviewer**: Review and approve assignee’s design. Specific design - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [ ] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer] - for final review (make sure they have edit permissions in Figma). -1. [ ] **Maintainer**: Review and approve assignee’s changes. -1. [ ] **Maintainer**: Add the changes or additions to the target file. For - example, you’d copy a final chart design from the working file and paste into the related location in the Data Visualization file. - 1. [ ] Ensure that all styles and components now belong to the target file. - 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [ ] **Maintainer**: When applicable, [publish][publishing] any library - changes along with a clear commit message. -1. [x] **Assignee**: Move your working file to the shared Figma project: - 1. [x] For Component Library changes, move your file to the [**Component archive**][component-archive] project. - 1. [ ] For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. [ ] If you’re a community contributor, we ask that you [transfer ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -1. [ ] **Assignee** (or Maintainer, for community contributions): If it’s a new - pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [ ] **Assignee**: When applicable, create a merge request in this repository - with the [component-guideline template][component-guideline-template] - to create or update the component’s documentation page. -1. [x] **Assignee**: When applicable, [create an issue in GitLab UI][new-gitlab-ui-issue] to build or update the component code. Mark the new issue as related to this one. -1. [ ] **Assignee**: 🎉 Congrats, you made it! You can now close this issue. - -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#structure -[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/.gitlab/merge_request_templates/component-guideline.md -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[new-gitlab-ui-issue]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new",1 -72834541,2020-10-16 12:41:20.757,UX Foundations > Pajamas OKR exploration,"During a recent conference, Design Systems & DesignOps, one of the self-work times was dedicated to thinking through what OKRs could look like for your design system. We were given about 40 minutes total to complete a list and then discuss in a small group. These were a few that came to mind, and I found it very helpful to think through objectives specific to the system itself. - -Feel free to add your own, and perhaps we can have further exploration on a few of these. All of the below ramp up to a larger objective of making the product more beautiful, performant and accessible for users, while providing clear _foundational_ answers to common questions so that designers can focus on designing and not on rehashing what should be “boring” decisions. A reoccurring phrase from the workshop was “align the easy thing to do with the right thing to do,” which I think aligns with our goal of building foundational things for the team to build on.",1 -72338921,2020-10-07 16:28:24.133,Dropdown component - Standardising on how to clear selection,"## Problem - -- From this discussion: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/43050#note_422606858 -- There doesn't seem to be a standard way to clear the selection from a dropdown -- For example, in Value Stream Management, the following approach was used... - -![Screenshot_2020-10-07_at_17.19._2x](/uploads/36fa40470131e174987d120cdc6adbd6/Screenshot_2020-10-07_at_17.19._2x.png) - -## Proposal - -Standardise on a solution for clearing the selection from a dropdown: -1. Document approach -1. Add functionality at the component-level - -There are a few ways of going about it... - -### When dropdown is open, the Action area for ""clear selection"" - -| Single selection | Multi selection | -| ------ | ------ | -| ![Screenshot_2020-10-20_at_17.32.16](/uploads/98bc3e80752a4122a9b52da599e49858/Screenshot_2020-10-20_at_17.32.16.png) | ![Screenshot_2020-10-20_at_17.32.22](/uploads/3a098f79146668b7725ab9ca41816add/Screenshot_2020-10-20_at_17.32.22.png) | - - -### after dropdown closes, the action to ""clear selection"" -| Single selection | Multi selection | -| ------ | ------ | -|![Screenshot_2020-10-20_at_17.33.39](/uploads/fcb45fe546a501bf957ff3d6315e3c45/Screenshot_2020-10-20_at_17.33.39.png)| ![Screenshot_2020-10-20_at_17.33.32](/uploads/36b6ddccb9e24009006f1956f17001ed/Screenshot_2020-10-20_at_17.33.32.png)| - - -
Original proposal -

-| Dropdown open clear button | Dropdown closed clear button | Top-level selection clears | -| ------ | ------ | ------ | -| ![image](/uploads/ffe35399c9aeb1e710824e1d39067174/image.png) | ![Screenshot_2020-10-07_at_17.26._2x](/uploads/691adaf0219b08ea608bef2961dd6169/Screenshot_2020-10-07_at_17.26._2x.png) | ![Screenshot_2020-10-07_at_17.19._2x](/uploads/36fa40470131e174987d120cdc6adbd6/Screenshot_2020-10-07_at_17.19._2x.png) | -

-
-@gitlab-com/gitlab-ux/designers",3 -72079844,2020-10-02 13:45:12.687,Mini progress/gauge indicator,"# Problem - -- Current use case: We need to visualise the progress of adoption of individual GitLab stages side-by-side -- General challenge: visualising progress as a percentage or within some target bounds - -# Solution - -- [Figma file →](https://www.figma.com/file/M04p4bPdJSRLJJxZ8DhgmA/Mini-gauge?node-id=785%3A161) -- Create a mini gauge chart that can fit within tables or metric boxes -- Need to be able to look good side-by-side - -![Screenshot_2020-10-02_at_14.36._2x](/uploads/f30b7c854fb12840226f088b01237124/Screenshot_2020-10-02_at_14.36._2x.png) - -# MVC iterations - -1. Implement mini gauge variant with icon (no bounds) -1. Implement mini gauge variant with metric (no bounds) -1. Implement mini gauge variant with target bounds",3 -71028980,2020-09-11 13:48:52.161,WIP: Add complex List Item components to Pajamas," - -### Description - -Currently, in Pajamas, the ""List"" component(s) that are defined speak mostly to the Markdown list and don't include complex list items as seen throughout the product. To address this, I suggest we make 2 large scale changes: - -1. Move the current list descriptions to the `Typography` section of Pajamas. -1. Update the List components to include complex list items as displayed throughout the product (see examples below). - -##### Examples - -| Issue list view | -|---| -|![Screen_Shot_2020-09-09_at_2.49.45_PM](/uploads/ef24b4f65c62dc092242e77fdc014cb0/Screen_Shot_2020-09-09_at_2.49.45_PM.png)| - -| Package list view | -|---| -|![Screen_Shot_2020-09-11_at_15.47.49](/uploads/923786fe38e070c7b30de002245c20a5/Screen_Shot_2020-09-11_at_15.47.49.png)| - - -### Figma file - - - -[View working file in Figma →](ADD LINK TO FIGMA FILE/FRAME) - -### Checklist - -Make sure the following are completed before closing the issue: - -1. [ ] **Assignee**: Design in your working file. When applicable, follow our - [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [FE/UX Foundations designer][foundations-team]. -1. [ ] **Assignee**: Update the link to the working file in the issue - description. -1. [ ] **Assignee**: Ask a [FE/UX Foundations designer][foundations-team] - to review your design (ensure they have edit permissions in Figma). -1. [ ] **Reviewer**: Review and approve assignee’s design. Specific design - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [ ] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer] - for final review (make sure they have edit permissions in Figma). -1. [ ] **Maintainer**: Review and approve assignee’s changes. -1. [ ] **Maintainer**: Add the changes or additions to the target file. For - example, you’d copy a final chart design from the working file and paste into the related location in the Data Visualization file. - 1. [ ] Ensure that all styles and components now belong to the target file. - 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [ ] **Maintainer**: When applicable, [publish][publishing] any library - changes along with a clear commit message. -1. [ ] **Assignee**: Move your working file to the shared Figma project: - 1. [ ] For Component Library changes, move your file to the [**Component archive**][component-archive] project. - 1. [ ] For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. [ ] If you’re a community contributor, we ask that you [transfer ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -1. [ ] **Assignee** (or Maintainer, for community contributions): If it’s a new - pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [ ] **Assignee**: When applicable, create a merge request in this repository - with the [component-guideline template][component-guideline-template] - to create or update the component’s documentation page. -1. [ ] **Assignee**: When applicable, [create an issue in GitLab UI][new-gitlab-ui-issue] to build or update the component code. Mark the new issue as related to this one. -1. [ ] **Assignee**: 🎉 Congrats, you made it! You can now close this issue. - -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#structure -[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/.gitlab/merge_request_templates/component-guideline.md -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[new-gitlab-ui-issue]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new",13 -70889051,2020-09-08 16:55:49.679,UI Kit > Add inline code and code blocks," - -### Description - -Based on the UI changes in https://gitlab.com/gitlab-org/gitlab/-/merge_requests/26731, adding styles/components to the component library for: - -* [x] Inline code -* [x] Code blocks - -### Out of scope - -* Appearance of code when not using the default theme preference. -* Dark UI. -* Other inline text elements (See https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/680) - -### Figma file - - - -[View working file in Figma →](https://www.figma.com/file/omuzKJD8RKLPpqv24CUUyS/Component-Inline-code-and-code-blocks?node-id=1%3A70) - -### Checklist - -Make sure the following are completed before closing the issue: - -1. [x] **Assignee**: Design in your working file. When applicable, follow our - [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [FE/UX Foundations designer][foundations-team]. -1. [x] **Assignee**: Update the link to the working file in the issue - description. -1. [x] **Assignee**: Ask a [FE/UX Foundations designer][foundations-team] - to review your design (ensure they have edit permissions in Figma). -1. [x] **Reviewer**: Review and approve assignee’s design. Specific design - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer] - for final review (make sure they have edit permissions in Figma). -1. [x] **Maintainer**: Review and approve assignee’s changes. -1. [x] **Maintainer**: Add the changes or additions to the target file. For - example, you’d copy a final chart design from the working file and paste into the related location in the Data Visualization file. - 1. [x] Ensure that all styles and components now belong to the target file. - 1. [x] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [x] **Maintainer**: When applicable, [publish][publishing] any library - changes along with a clear commit message. -1. [x] **Assignee**: Move your working file to the shared Figma project: - 1. [x] For Component Library changes, move your file to the [**Component archive**][component-archive] project. - 1. [x] For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. [ ] If you’re a community contributor, we ask that you [transfer ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -1. [x] **Assignee** (or Maintainer, for community contributions): If it’s a new - pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [ ] **Assignee**: When applicable, create a merge request in this repository - with the [component-guideline template][component-guideline-template] - to create or update the component’s documentation page. -1. [ ] **Assignee**: When applicable, [create an issue in GitLab UI][new-gitlab-ui-issue] to build or update the component code. Mark the new issue as related to this one. -1. [x] **Assignee**: 🎉 Congrats, you made it! You can now close this issue. - -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#structure -[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/.gitlab/merge_request_templates/component-guideline.md -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[new-gitlab-ui-issue]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new",1 -70886070,2020-09-08 15:55:39.441,Make responsive segmented control,"### Problem - -Currently our [segmented control component](https://design.gitlab.com/components/segmented-control) isn't very responsive on small screens when the component has many options (see below screenshot). - -![Screen_Shot_2020-08-31_at_9.31.20_AM](/uploads/00c01eef0681be6929cf16273669643d/Screen_Shot_2020-08-31_at_9.31.20_AM.png) - -We don't have a current design for how to fix this. - -### Proposal - -Some possible solutions: - -- [Vertical variation for button groups](https://bootstrap-vue.org/docs/components/button-group#vertical-variation) -- Wrapping the component -- Making the last button a dropdown with the extra options inside of it. - - ![image](/uploads/faa949ce468effb51625e6c4b2046839/image.png)",3 -70830391,2020-09-07 14:39:08.013,"KR: Communicate component lifecycle improvements to the UX department => 0%, TBD","Related to [Clarify the Pajamas component lifecycle process](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/1) - -Key result: Communicate component lifecycle improvements to the UX department (slack, UX weekly announcement).",1 -70830214,2020-09-07 14:36:36.911,"KR: Improve the component checklist by adding links/references to the necessary steps to complete the lifecycle, and move it to the Pajamas project. => 0%, TBD","Related to [Clarify the Pajamas component lifecycle process](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/1) - -Key Result: Improve the component checklist by adding links/references to the necessary steps to complete the lifecycle, and move it to the Pajamas project.",1 -70744870,2020-09-04 16:23:21.236,Skeleton loader for Releases," - -### Description - - - -In https://gitlab.com/gitlab-org/gitlab/-/issues/201959/ we will introduce an update to the ~""component:skeleton-loader"" of the Releases page. This issue adds a variation of the gilab-ui component so that users can be able to see a loading state that always represent Releases in a recognizable way. - -- The component variation should be called: `release-card-skeleton-basic`. -- I propose adding the UI to the Product Pages figma file. - -### Figma file - - - -[View branched working file of Component Library →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/EIhkW34nsNcpDXLKQNte4w/Component-library?node-id=2844%3A3) - -[(Old) View working file in Figma →](https://www.figma.com/file/9Uee1fu4GrNrEhCHRTi2nK/Release-page-skeleton-load-gitlab-201959?node-id=1%3A2) - -### Checklist - -Make sure the following are completed before closing the issue: - -1. [x] **Assignee**: Design in your working file. When applicable, follow our - [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [FE/UX Foundations designer][foundations-team]. -1. [x] **Assignee**: Update the link to the working file in the issue - description. -1. [x] **Assignee**: Ask a [FE/UX Foundations designer][foundations-team] - to review your design (ensure they have edit permissions in Figma). -1. [x] **Reviewer**: Review and approve assignee’s design. Specific design - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer] - for final review (make sure they have edit permissions in Figma). -1. [x] **Maintainer**: Review and approve assignee’s changes. -1. [x] **Maintainer**: Add the changes or additions to the target file. For - example, you’d copy a final chart design from the working file and paste into the related location in the Data Visualization file. - 1. [x] Ensure that all styles and components now belong to the target file. - 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [x] **Maintainer**: When applicable, [publish][publishing] any library - changes along with a clear commit message. -1. [-] **Assignee**: Move your working file to the shared Figma project (file was a branch, so archived by the maintainer using the branch feature). -1. [-] **Assignee** (or Maintainer, for community contributions): If it’s a new - pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [-] **Assignee**: When applicable, create a merge request in this repository - with the [component-guideline template][component-guideline-template] - to create or update the component’s documentation page. -1. [-] **Assignee**: When applicable, [create an issue in GitLab UI][new-gitlab-ui-issue] to build or update the component code. Mark the new issue as related to this one. -1. [x] **Assignee**: 🎉 Congrats, you made it! You can now close this issue. - -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#structure -[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/.gitlab/merge_request_templates/component-guideline.md -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[new-gitlab-ui-issue]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new",2 -70208931,2020-08-24 11:09:35.005,Make mermaid diagrams work in Pajamas,"This is a Follow-up from ""Draft: docs(contribute): Move component lifecycle up"" https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2053/ - -Currently, Pajamas does not render mermaid diagrams in markdown pages. - -Mermaid diagrams render as *code blocks* in markdown files. This is a useful tool for generation of diagrams and flowcharts from text, instead of using static images in the design docs pages. - -See https://docs.gitlab.com/ee/user/markdown.html#mermaid",5 -70023441,2020-08-19 16:12:01.391,Pajamas pages break if a Vue component doesn't exist in component_documentation.js,"Recently, the dropdowns page was broken due to `GlNewDropdown` no longer existing under [`component_documentation.js`](https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/1637/diffs#d836144972fdb1c81b2724a1b894dec15e0973f4_62_62), which Pajamas pulls from when checking if a vue component conforms to the design system [`followsDesignSystem`](components/componentinfo.vue). - -MR that fixed the broken page: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2050",1 -69979688,2020-08-18 21:31:07.000,UI Kit > Create inline text element components,"## Problem - -Several inline text elements need to be added to the component library in Figma. We need to determine where they best fit since they can cross over between UI and markdown. - -![CleanShot_2020-08-18_at_16.23.30_2x](/uploads/44b5bceeb2d14fc6023e1cfff2e87913/CleanShot_2020-08-18_at_16.23.30_2x.png) - -## Solution - -* Audit the product to find inline elements that can’t be created with styles alone (the ones in the image above have backgrounds). -* Create components for each inline variant. -* Determine the best location in the component library and publish the additions. - -/cc @tauriedavis - -### Figma file - - - -[View working file in Figma →](https://www.figma.com/file/YJWAkSuSBsEaIWMbYftE5x/Component-Inline-text-components?node-id=1%3A70) - -### Checklist - -Make sure the following are completed before closing the issue: - -1. [x] **Assignee**: Design in your working file. When applicable, follow our - [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [FE/UX Foundations designer][foundations-team]. -1. [x] **Assignee**: Update the link to the working file in the issue - description. -1. [x] **Assignee**: Ask a [FE/UX Foundations designer][foundations-team] - to review your design (ensure they have edit permissions in Figma). -1. [x] **Reviewer**: Review and approve assignee’s design. Specific design - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer] - for final review (make sure they have edit permissions in Figma). -1. [x] **Maintainer**: Review and approve assignee’s changes. -1. [x] **Maintainer**: Add the changes or additions to the target file. For - example, you’d copy a final chart design from the working file and paste into the related location in the Data Visualization file. - 1. [x] Ensure that all styles and components now belong to the target file. - 1. [x] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [x] **Maintainer**: When applicable, [publish][publishing] any library - changes along with a clear commit message. -1. [x] **Assignee**: Move your working file to the shared Figma project: - 1. [ ] For Component Library changes, move your file to the [**Component archive**][component-archive] project. - 1. [ ] For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. [ ] If you’re a community contributor, we ask that you [transfer ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -1. [x] **Assignee** (or Maintainer, for community contributions): If it’s a new - pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [x] **Assignee**: When applicable, create a merge request in this repository - with the [component-guideline template][component-guideline-template] - to create or update the component’s documentation page. -1. [ ] **Assignee**: When applicable, [create an issue in GitLab UI][new-gitlab-ui-issue] to build or update the component code. Mark the new issue as related to this one. -1. [ ] **Assignee**: 🎉 Congrats, you made it! You can now close this issue. - -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#structure -[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/.gitlab/merge_request_templates/component-guideline.md -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[new-gitlab-ui-issue]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new",2 -69807043,2020-08-13 14:30:26.698,Allow linking to component usage for all region components.,"### Problem -We cannot directly navigate to the Vue component usage section in all region components like [Empty State](https://design.gitlab.com/regions/empty-states/) by visiting `https://design.gitlab.com/regions/empty-states/code` as the url returns 404.",2 -69284313,2020-07-31 08:16:37.509,Document established onboarding & educational patterns: nudge,"Document the findings and learnings from the [suggest a pipeline experiment](https://gitlab.com/groups/gitlab-org/growth/-/epics/14). Based on these learnings, establish a pattern for onboarding and educational purposes, so that other designers can reuse it. - -By the time I'll start working on documenting these we'll have run numerous variations of this experiment: different initial nudges, different copy. - -Include details about: - -* reference the FOGG behaviour model -* components that can be used -* variations of initial nudges and recommendations on when they should be used -* recommendations on the number of steps -* recommendations for writing copy and providing context (why the nudge is shown, what value will the user get from it) -* should only be done to benefit the user",5 -68821525,2020-07-21 18:21:52.775,Update empty state documentation to include details about existing controls,"As part of discussion on https://gitlab.com/gitlab-org/gitlab/-/issues/229636#note_382613266 and https://gitlab.com/gitlab-org/gitlab/-/issues/229350, we realized that we could use a little clarification in our empty state documentation. - -When we have an empty state, should the page controls still appear, but be disabled? Or, should they be completely hidden? - -We currently have both situations in our empty states. Should we clarify when the controls appear, and why?",2 -62159621,2020-07-16 22:33:44.649,Dropdowns > Audit Figma and GitLab UI component,"Review dropdowns in Figma and GitLab UI to ensure parity - -If issues are found, create issues and mark them as blockers to this issue. - -- [ ] All variations exist in Figma and GitLab UI -- [ ] Styling in Figma matches GitLab UI -- [ ] All related issues are closed -- [ ] Status table in Pajamas is updated and accurate",3 -52422757,2020-06-30 18:28:03.741,GitLab UI examples > Add knob options,"On the vue tab for components, you should be able to interact with gitlab ui knobs",5 -52354157,2020-06-30 16:30:31.126,feat(skeletonloader): Extend usage of Skeleton loader vs. Spinner usage,"Clarify when to use spinner vs. skeleton loader in different scenarios. - -From thread https://gitlab.com/gitlab-org/gitlab/-/merge_requests/35265#note_368474339",2 -50091551,2020-06-25 18:41:59.075,Audit principles page,"We have a lot of content on our principles page, including some guidelines. There is note that states our current principles may not follow the guidelines. We need to audit this page and determine what changes, if any, need to occur to the principles and/or guidelines",3 -42999400,2020-06-12 07:57:22.736,Mobile layout has double padding on left/right,"From https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/1963#note_359198356 - -`content` adds left/right padding which was getting doubled, so narrow screens have extra padding - -We can probably move the `.content.limited` rule to `.limited` to fix this - -![Screen_Shot_2020-06-12_at_5.56.02_pm](/uploads/52aaa87a4672e49bd04450409d7a163a/Screen_Shot_2020-06-12_at_5.56.02_pm.png)",1 -35473730,2020-06-05 10:38:08.164,Pajamas UI Kit > Gauge chart," - -### Description - -Gauge chart visualization is useful for monitoring the status of a metric in real time, and to quickly convey the status of the metric in relation to the ranges or a threshold set by the user. A gauge chart is a single metric chart. - -#### Example use case - -An SRE viewing metrics in the Metrics dashboard when investigating an incident. A gauge chart instantly communicates to the user the status of the metric, even when viewed at a small size. At a glance the user understands whether the value is falling within an acceptable range. - -#### Requirements - -- The chart should clearly communicate the current value and show where that value falls within the ranges set by the user (2 or 3 ranges can be set). -- Users can set alerts on the metric, so we need to make sure that when the alert is firing it's immediately visible -- The value ranges don't have to coincide with the alert threshold. The user should be able to set an alert for any value regardless of what range it falls into -- The chart should be readable even at a very small size. It's not uncommon for our users to have multiple gauge charts crammed into a small dashboard area to form a ""speedometer"" of sort. Check out [one of the GitLab dashboards ](https://dashboards.gitlab.com/d/sv_pUrImz/ci-autoscaled-machines-metrics?orgId=1&refresh=5m&from=now-30d&to=now&var-dc=All&var-runner_group=All&var-cpu_mode=nice)for an example. Currently, GitLab Metrics charts aren't resizeable, but they will be in the future. - -#### States/ variants - -- [x] Alert set -- [x] Alert firing -- [x] Low range, mid range, high range -- [x] Large (expanded chart view) -- [x] Small (50%) - -### Additional details - -We will be building the chart using the [Gauge e-charts component.](https://echarts.apache.org/examples/en/editor.html?c=gauge) - -Notes for the docs: -- Leave a note in the component description that states that the header is mandatory but the size should vary depending on page content/hierarchy. - - - - - -### WIP Proposal - -| Medium range | With an alert | With a firing alert | -| ------ | ------ | ------ | -|![Medium_range](/uploads/e7a479f674b47c388a437523bbb7e2a5/Medium_range.png) | ![Gauge_chart_with_alert](/uploads/2428ae6ed48ec615d1828405bca521b2/Gauge_chart_with_alert.png) | ![Gauge_chart_with_firing_alert](/uploads/70daa8d0c1878960f3fdd001d12ca49e/Gauge_chart_with_firing_alert.png) | - -### Figma component - -[View component in Figma →](https://www.figma.com/file/rxA1gTpS6L7wMhAs9rZnaU/Gauge-chart?node-id=0%3A1) - -### Checklist - -Make sure the following are completed before closing the issue: - -1. [x] **Assignee**: Create component in your own draft file in Figma using the -[component template](https://www.figma.com/file/OmvFfWkqEsdGhXAND133ou/%5BComponent%5D), -including all variations and states. -1. [x] **Assignee**: Update the link to the Figma file in the issue description. -1. [x] **Assignee**: Ask a [FE/UX Foundations designer](https://about.gitlab.com/company/team/?department=fe-ux-foundations-team) -to review your component (ensure they have edit permissions in Figma). -1. [ ] **Reviewer**: Review and approve assignee’s addition. Ensure that design -includes all variations/states. -1. [ ] **Reviewer**: Assign to a [Figma maintainer](https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com) for final review (make sure they have edit permissions in Figma). -1. [ ] **Maintainer**: Review and approve assignee’s addition. -1. [ ] **Maintainer**: Add the design to the **Pajamas UI Kit** file, ~~and view -the component in the Assets panel to ensure it aligns with what’s outlined in the -[document and asset library structure](https://gitlab.com/gitlab-org/gitlab-design/-/blob/master/CONTRIBUTING-Figma.md#document-and-asset-library-structure) documentation.~~ (Not applicable for the chart.) -1. [-] **Maintainer**: Publish the library changes along with a clear commit message. -1. [ ] **Assignee**: Move the draft file to the **Component archive** Figma project. If you’re a community contributor, we ask that you [transfer ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -1. [ ] **Assignee** (or Maintainer, for community contributions): If it's a new -pattern or a significant change, add an agenda item to the next UX weekly call -to inform everyone. -1. [ ] **Assignee**: Create a merge request in this repository with the [component-guideline template](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/.gitlab/merge_request_templates/component-guideline.md) -to create or update the component's documentation page. Link it here as a related -merge request. Use `View design in Pajamas UI Kit →` for the link text. This replaces -any link to Sketch Measure specs. Anyone with the link should be able to view the file. -1. [x] **Assignee**: [Create an issue in GitLab UI](https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new) -to build or update the component. Mark the new issue as related to this one. -1. [ ] **Assignee**: 🎉 Congrats, you made it! You can now close this issue.",3 -34251371,2020-05-07 08:20:26.831,feat(filters): Research scroll behavior for filters,"In https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/1343 @matejlatin highlighted filters issue with scrollbar on OS X: - -![image](/uploads/246b9e8c379b487c85e038913c079004/image.png) - -pretty acceptable in Linux & Windows with other scroll type: - -![image](/uploads/ce44e00e23f0d4428fa0f64df34f2e89/image.png) - -We need to research the proper way of handling a lot of scrollable content in filters.",3 -33963045,2020-04-29 17:12:08.465,Add additional chart information to to PJs,"### Description - -PJs doesn't include all chart options available from within gitlab-ui. - -#### Examples - -https://design.gitlab.com/components/charts#types only mentions column charts, line charts, and area charts. - -In addition to these, we also have: - -* Scatter chart - * https://gitlab-org.gitlab.io/gitlab-ui/?path=/story/charts-discrete-scatter-chart--default -* Heatmap - * https://gitlab-org.gitlab.io/gitlab-ui/?path=/story/charts-heatmap--default - -Column charts also support a click interaction - I don't actually think that this is explicitly mentioned in gitlab-ui either. - -#### Additional information -This was raised in discussion over here https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541#note_333095362",4 -33865614,2020-04-27 16:12:27.424,PJs component page template: re-evaluate content based on JTBDs,"## Overview - -Let's re-evaluate the content (and structure) of the PJs component page template to improve the utility and usability for GitLab designers, devs and PMs. This is related to the broader PJs information architecture challenges mentioned in gitlab-org/gitlab-design#798. - -The best way to prioritise, manage and refine the content on the page is by using Jobs to be done. - -## Problem - -The main pain points I found with component page templates today: - -- **Text-heavy** - PJs is much more text-heavy than most other design systems. Much of the text content could be replaced with images and demos. The large amount of content makes it hard to scan and find the information I'm looking for. -- **Usage guidance vs implementation guidance** - Content on implementation guidance ([as discussed here](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/536)) is left in the usage guidelines - adding to the text-heaviness. This also reduces the clarity on the usage guidance in general. -- **Burying the lead** - The current structure is setting pages up in a way where the demo is at the bottom of the page behind a bunch of text which may or may not be relevant for your use case. A new structure is required which front loads the demo and dives into details later. Following similar ideas to the [Minto Principle](https://medium.com/lessons-from-mckinsey/the-pyramid-principle-f0885dd3c5c7). -- **Additional content** - We also have a lot of other content that could be interesting to include in a design system as stated in [this comment](https://gitlab.com/gitlab-org/gitlab-design/-/issues/1111) - this doesn't need to be shown on the page, but could at least be linked, so we see the thought and rationale that has gone into designing the component -- **Variation** - There a lot of inconsistency in how component usage guidelines are written. - -## Idea - -> “If a picture is worth a thousand words, a prototype is worth a thousand meetings” - **David Kelley, IDEO** - -Some general principles for laying out these pages: -- **JTBD & role-informed** - We should differentiate sections and prioritise what content goes on the page based on what our primary personas are trying to achieve -- **Demo-heavy** - We should front-load our component pages with visual content and demos for a quicker understanding -- **Show me > tell me** - We should strip away as much text as possible in favour of demos and programmatically embedding rules, styles and interactions -- **On-page nav** - We should have on-page navigation for quicker access to particular sections -- **Standardise component usage sub-sections** - We should standardise on component usage sub-sections to improve consistency and clarity (e.g.[IBM carbon](https://www.carbondesignsystem.com/components/date-picker/usage#content) standardized on component variations, content guidelines & interactions/functionality). This also makes it easier to spot whether any functionality or styles are missing. - -I think [IBM Carbon](https://www.carbondesignsystem.com/) and [Salesforce Lightning](https://www.lightningdesignsystem.com/) are both great examples of prioritising which JTBD they want to satisfy for designers & devs without being too text-heavy. - -## Jobs to be done - -Create a ranked list of JTBD to prioritise content on the page: - -| Title | Situation | Motivation | Desired outcome | Persona | -| ------ | ------ | ------ | ------ | ------ | -| **General usage guidance** | When I am unfamiliar with a component, | I want a quick and high-level overview of the what the component looks like, how it works and its most popular use cases, | so that I know whether or not I should use it. | All | -| **Design tool component** | When using a component, | I want a representation of that component in Figma/Sketch | so that I can quickly work with it in my designs | Designer | -| **Detailed usage guidance** | When using a component, | I want to understand details of variations, style, functionality and accessibility | so that I use the component in the way it was designed | Designer | -| **Component usage in the product** | When using a component, | I want to where else in the product it is being used, how much it is being used and for what use cases, | so that I | All | -| **Design decisions** | When using a component, | I want to understand how research, discussions & usage helped decide on a specific design, tenet or guideline | so that I understand why the component was designed in that way | Designer | -| **Component gaps** | When using a component, | I want to understand whether this current iteration of the component has the variations, style, additional functionality and accessibility required for my use case | so that I know whether we should update it or not | Designer | -| **Component pipeline** | When using a component, | I want to see if there are any new components or updates in the pipeline | so that I can utilise the component or collaborate with the person who is working on it | Designer | -| **Component development guidance** | When building components, | I want to understand what patterns should be embedded into the component programmatically | so that the component works in the way it was designed. | Developer | -| **design.gitlab, GitLab-ui & figma/sketch sync** | When using a component, | I want to be sure that the component variations, style, additional functionality and accessibility in design.gitlab reflect what is shown in gitlab-ui and figma/sketch | so that I have an accurate representation of what's available and continuity of understanding with other roles in my team | All | -| **Add/edit component** | When reviewing PJs and I see missing/incorrect component content | I would like to add/edit content | so that I contribute to refining our design system | Designer | -| **Integrating component** | When I am integrating a component in our [component lifecycle](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/blob/master/doc/component-lifecycle.md) | I want to ... | so that ... | Developers | - -## Process - -1. **Gather** - Use this issue to collate what the primary the JTBD for designers, devs, PMs, technical writers, researchers -1. **Prioritise** - Prioritise the JTBD to prioritise the content in PJs -1. **Create template** - Create a new content template based on our prioritisation -1. **Create vision mockup** - Create a new vision mockup of what PJs component pages could be - -## Additional ideas - -- On page table of contents -- Additional tabs -- Changing structure of pages to front-load demos and visual content at top of page - - First step would be changing component template file: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/pages/components/template.md - -## Proposal - -- Determine a new structure that allows users to easily find the content they are looking for. The end result of this issue should be working page templates and consistent sections and language.",8 -33393960,2020-04-16 17:28:55.972,Add contrast info to neutral color palette,"The following discussion from !1787 should be addressed: - -- [x] @pedroms started a [discussion](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/1787#note_322602636): (+2 comments) - - > @jeldergl should we also add the `Passing level and contrast ratio` information to the neutral palette?",1 -33058352,2020-04-08 17:00:57.725,Communicating code coverage of each component,"In https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/1804, the status of components that already live inside the GitLab product were moved to `Integrated`. - -I'm curious to hear what would be helpful on the status page. A lot of questions I get are related to why a component in production does not match Pajamas. Even if a component already lives in the product, that does not mean they are fully integrated or used in every instance. How should we be communicating the code coverage of each component? Should that live inside the status page? How can we feasible track this over time?",5 -32794334,2020-04-02 16:59:02.898,Add more clarity around bold 600 decision,"Its not clear from looking at pajamas what font weight we use for bold text. You have to inspect the text or find the variable in GitLab UI. - -We should include the variable name and it's value on the typography page. We can also include explanatory text that explains why we use 600 over 700 - -> It’s because some system fonts have a semi-bold, which would be mapped to 600, and that weight was preferred. For system fonts without a semi-bold it would be mapped to the 700 weight, which is why it could look extra bold in other OSs.",1 -32537602,2020-03-27 12:47:48.959,Add accessibility guidelines and specs for the filters,"gitlab-org/gitlab-services/design.gitlab.com!1744 adds the usage guidelines, next we need to think how to properly build the filter components so that they're accessible. Let's add those guidelines and specs to the Pajamas after that.",3 -35324648,2020-03-19 18:51:00.547,Figma region > Empty states," - - - - - -[View component in Figma →](https://www.figma.com/file/Bp0HvnbtcLcoLYHXbrWwzc/Empty-states?node-id=0%3A1) - -### Checklist - -Make sure the following are completed before closing the issue: - -1. [x] **Assignee**: Create component in your own draft file in Figma using the -[component template](https://www.figma.com/file/OmvFfWkqEsdGhXAND133ou/%5BComponent%5D), -including all variations and states. -1. [x] **Assignee**: Update the link to the Figma file in the issue description. -1. [x] **Assignee**: Ask a [FE/UX Foundations designer](https://about.gitlab.com/company/team/?department=fe-ux-foundations-team) -to review your component (ensure they have edit permissions in Figma). -1. [x] **Reviewer**: Review and approve assignee’s addition. Ensure that component -includes all variations/states and, if applicable, matches existing Sketch specs and -is responsive. -1. [x] **Reviewer**: Assign to a [Figma maintainer](https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com) for final review (make sure they have edit permissions in Figma). -1. [x] **Maintainer**: Review and approve assignee’s addition. -1. [ ] **Maintainer**: Add the component to the **Pajamas UI Kit** file, and view -the component in the Assets panel to ensure it aligns with what’s outlined in the -[document and asset library structure](https://gitlab.com/gitlab-org/gitlab-design/-/blob/master/CONTRIBUTING-Figma.md#document-and-asset-library-structure) documentation. -1. [ ] **Maintainer**: Publish the library changes along with a clear commit message. -1. [x] **Assignee**: Move the draft file to the **Component archive** Figma project. If you're a community contributor, we ask that you [transfer ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -1. [ ] **Assignee** (or Maintainer, for community contributions): If it's a new -pattern or a significant change, add an agenda item to the next UX weekly call -to inform everyone. -1. [ ] **Assignee**: Create a merge request in this repository with the [component-guideline template](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/.gitlab/merge_request_templates/component-guideline.md) -to create or update the component's documentation page. Link it here as a related -merge request. Use `View design in Pajamas UI Kit →` for the link text. This replaces -any link to Sketch Measure specs. Anyone with the link should be able to view the file. -1. [ ] **Assignee**: [Create an issue in GitLab UI](https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new) -to build or update the component. Mark the new issue as related to this one. -1. [x] **Assignee**: 🎉 Congrats, you made it! You can now close this issue. - ---- - -## Empty state examples - -* https://www.carbondesignsystem.com/patterns/empty-states-pattern/ -* https://stackoverflow.design/product/components/empty-states/ -* https://www.lightningdesignsystem.com/guidelines/empty-state/#site-main-content",3 -86304066,2020-03-18 04:24:58.393,Form help and error text should not be separate,"## Problem - -For our form elements, help text and error text are currently defined as two separate text items. This could be confusing as error text could be partially duplicative of the help text. Depending on how the help text is tied to the input for accessibility, this could also add confusion, or cause some info to be missed. Because the help text remains gray, it visually feels disconnected with an input in error state. - -## Solution - -Help text is a single, dynamic text block with the potential for multiple states. - -* By default it is instructional and in a neutral palette -* When an error occurs the help text becomes more explanatory so that a user knows how to correct the error. The danger palette is used. - -In this case there is inly one help text block for instruction and error prevention. - -| **Before** | **After** | -| ------ | ------ | -| ![Frame_1](/uploads/bda6fdfcebb2d5ae11204f5af07e0451/Frame_1.png) | ![Frame_2](/uploads/cffdf4046b706318d38fbd325cdafc68/Frame_2.png) | - -/cc @uhlexsis @tauriedavis @pedroms",1 -31850907,2020-03-10 23:50:22.128,"Combine contents of ""Vue component"" and ""Design"" tabs into a single page","There is often duplicated content between the tabs. For example: ""Alerts allow the application to pass along relevant system information to the user without impeding their journey. Alerts are system generated and may or may not be derived by a user’s action."" is the same in the following two places: - -![Screen_Shot_2020-03-11_at_10.47.50_am](/uploads/00d1732ee0d8d26faf39f809d7f095fd/Screen_Shot_2020-03-11_at_10.47.50_am.png) - -![Screen_Shot_2020-03-11_at_10.48.49_am](/uploads/4cf66e9fa152700f3a9fcc2527a60d97/Screen_Shot_2020-03-11_at_10.48.49_am.png) - -Instead of a tab, we can add a ""Component"" section to the design tab (and then remove the tabs altogether)",8 -31691849,2020-03-06 19:42:44.993,GitLab UI components demos: Reduce style inconsistencies between Storybook and design.gitlab.com,"# What problems are we trying to solve here? - -## 1. `.md` styles leaking into GitLab UI components demos - -`design.gitlab.com` has a set of typography CSS rules being applied on several common HTML elements in the `.md` scope: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/5f1e9246192f9f04dcd50cefa55985d63c0f88ce/assets/stylesheets/framework/_typography.scss#L35-81 - -This has been causing issues with components demos as they are being displayed into the same scope, resulting in some components inheriting unexpected CSS rules, an example is the `GlBanner` component: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/1620#note_245401786 - -This has led us to explicitly setting more and more CSS rules in components stylesheets, solely to override `.md` styles. We have tried to circumvent this specific issue by [wrapping components in a custom element](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/1737) where GitLab UI styles would be injected in the Shadow DOM. While this solution was promising as it stopped all CSS leak issues, some components like tooltips and popovers aren't Shadow DOM-ready and aren't able to render when they don't have access to the global `document`. More generally, this approach brought us back to problem `#2`. - - -## 2. Styling elements in the global scope - -To prevent GitLab UI's styles from conflicting with `design.gitlab.com`'s styles, we have scoped its styles to the `.app-styles` class: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/5f1e9246192f9f04dcd50cefa55985d63c0f88ce/assets/stylesheets/app.scss#L33-36 - -This lets us apply components styles locally, without affecting the rest of the website. - -This is a sensible approach but we've reached its limits as some components are appending elements to the `body` in the global scope. Since those elements are escaping the `.app-styles` scope, they can't be styled properly, unless we can come up with specific workarounds. For example, we've been able to preserve styles for the `GlModal` component by adding the `.app-styles` class to its wrapper element: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/5f1e9246192f9f04dcd50cefa55985d63c0f88ce/layouts/default.vue#L103-114 -There are other cases, like the `GlToast` component, where there is no obvious workaround that we can apply, resulting in a broken looking element in the demo: - -![Screen_Shot_2020-03-06_at_3.16.40_PM](/uploads/d1250bfa79c17a6631ea60fb7f46b350/Screen_Shot_2020-03-06_at_3.16.40_PM.png) - -Overall, we should try to make it as easy as possible to include components demos in `design.gitlab.com`. Having to come up with workarounds makes for a poor developer experience. - -# How can we address these issues? - -## 1. Prevent `.md` styles from leaking too deep in the DOM - -To prevent `.md` styles from affecting too many of their children, let's make sure that the CSS rules only apply to direct children in `.md`. This will prevent the CSS from leaking into component demos, reducing the need for explicitly setting CSS rules in GitLab UI to override Pajamas' styles. - -This approach has a downside: Markdown elements can be nested. For example: `> ### A title in a blockquote`. By applying styles on direct children only, those nested elements will not be styled properly. Since Pajamas doesn't seem to contain any nested Markdown element at the moment, this fix should be acceptable considering its benefits outweigh its disadvantages. - -MR: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/1753 - -## 2. Apply GitLab UI styles globally - -TBD - -MR: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/1740",3 -30733784,2020-02-13 21:33:01.456,Remove radios vue banner and set status to Built,"1. In Pajamas docs, remove the banner on vue tab that warns of incorrect styling -1. In Pajamas docs, set the status to `Built`",1 -53985995,2020-01-23 22:52:10.589,Figma component > Add Card," - - - - - -[View component in Figma →](https://www.figma.com/file/RbS6MpYuRWGvcdxRlUGxAD/Cards?node-id=1%3A496) - -### Checklist - -Make sure the following are completed before closing the issue: - -1. [x] **Assignee**: Create component in your own draft file in Figma using the -[component template](https://www.figma.com/file/OmvFfWkqEsdGhXAND133ou/%5BComponent%5D), -including all variations and states. -1. [ ] **Assignee**: Ask another Figma Pilot Designer to review your component (make sure they have edit permissions). -1. [ ] **Reviewer**: Review and approve assignee’s addition. Ensure that component -matches Sketch specs, includes all current variations and states, and (if applicable) -is responsive. -1. [ ] **Assignee**: Add the component to the **Globals - beta** file, and view -the component in the Assets panel to ensure it aligns with what’s outlined in the -[Figma structure for library](https://gitlab.com/gitlab-org/gitlab-design/issues/791) issue. -1. [ ] **Assignee**: Publish the library changes along with a clear commit message. -1. [ ] **Assignee**: Update component link in the issue. -1. [ ] **Assignee**: Move your draft file to the **Component archive** Figma project.",3 -29712647,2020-01-17 18:48:44.957,Fix fonts size of help text in radios/checkboxes,"The following discussion from !1651 should be addressed: - -- [ ] @pedroms started a [discussion](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/merge_requests/1651#note_271309985): (+4 comments) - - > @jboyson unsure if related to this MR, the help text paragraph `p` has an odd font-size: - > - > ![image](/uploads/d8ae5f82633b62712a852cf88c82b89f/image.png)",1 -105457393,2022-03-24 21:00:12.515,Figma: Change GitLab logo in file thumbnails,"Update the logo in file thumbnails (cover slides) starting with publicly shared files in the Pajamas UI kit and then the other cover template. - -![CleanShot_2022-03-24_at_16.00.51_2x](/uploads/6314dcb6f940c178aa0e7bb2cbea8777/CleanShot_2022-03-24_at_16.00.51_2x.png) - -![CleanShot_2022-03-24_at_16.02.21_2x](/uploads/73a4d1cb5b05d5ae294a83d97ef9c7e6/CleanShot_2022-03-24_at_16.02.21_2x.png)",1 -105236024,2022-03-21 21:27:21.078,UI Kit > Add GitLab tier badge variant," - -### Description - - - -Following https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1242 and https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2728#note_862246994 we should add a GitLab tier badge variant to GitLab UI. - -### Figma file - - - -[View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/H45tzHETZOwB7kJh3YqKj0/Component-library?node-id=19947%3A350E) - -### Checklist - -Make sure the following are completed before closing the issue: - -1. [x] **Assignee**: Design in your working file. When applicable, follow our - [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. -1. [x] **Assignee**: Update the link to the working file in the issue - description. -1. [x] **Assignee**: Ask a [Foundations designer][foundations-team] - to review your design (ensure they have edit permissions in Figma). -1. [x] **Reviewer**: Review and approve assignee’s design. Specific design - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer] - for final review (make sure they have edit permissions in Figma). -1. [x] **Maintainer**: Review and approve assignee’s changes. -1. [x] **Maintainer**: Merge the branch or add the changes or additions to the - target file. - 1. [ ] Ensure that all styles and components now belong to the target file. - 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [ ] **Maintainer**: When applicable, [publish][publishing] any library - changes along with a clear commit message. -1. [ ] **Assignee**: If work was not done in a branch (a merged branch will automatically be archived), move your working file - to the shared Figma project: - 1. [ ] For Component Library changes, move your file to the [**Component archive**][component-archive] project. - 1. [ ] For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. [ ] If you’re a community contributor, please consider [transfering ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -1. [x] **Assignee** (or Maintainer, for community contributions): If it’s a new - pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [x] **Assignee**: When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [x] **Assignee**: When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [ ] **Assignee**: 🎉 Congrats, you made it! You can now close this issue. - -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure -[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/.gitlab/merge_request_templates/component-guideline.md -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component -[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation",1 -104621769,2022-03-11 14:40:50.808,Discussion: Add guidelines for alternate visual treatment for links,"## Problem - -We have the visual treatment for links identified in the GitLab UI, but do not have a dedicated section under Pajamas guidelines to specify them. Today, we treat `copy blue with an underline` as a standard and desired state for links, but from recent feedback on Verify features, we were able to surface a need for multiple visual treatments for the same. - -There are pages in the product that list resources, and for their contextual identification it is vital to retain links to associated resources. Example- a pipeline can be best identified in the presence of the commit name/number, branch name, merge request details and triggerer information. Not every user would make use of all of these link, but the personas interacting with these pages are varied and through research we have learn that removing any of these information can prove to be disruptive to a huge number of users. - -Presence of many different links as a group, with each demanding user's attention can turn out to be very visually disorienting. To combat this discomfort, we should consider providing different visual treatments to those links. For example - the link that belongs to the resources that is primary to the page can have a blue color, while for the other links we can go for a subdued visual affordance, ma be dark gray with an underline? - -We are already doing this on a few pages, such as issues, where we do not give a blue color to link, and at other pages where many different links in a single line have different treatments. To ensure that we provide our users with a coherent experience across platforms, we should document primary and alternate treatments for links and the circumstances under which they should be used. - -### Use cases - -I'm listing use-cases from Verify since I'm more versed in those. - -#### Pipeline Execution: Pipeline index page -| Image | Resources linked | -|------------|-------------| -| ![Screen_Shot_2022-03-11_at_7.53.59_PM](/uploads/cbd212019cf9d1d33c91f430b5297f72/Screen_Shot_2022-03-11_at_7.53.59_PM.png) | Commit, Merge request, Branch, Pipeline | - -#### Release: Environment list view -| Image | Resources linked | -|-------|------------------| -|![Screen_Shot_2022-03-11_at_7.56.55_PM](/uploads/40cc14beba9676504d1cd3b3d2be1d39/Screen_Shot_2022-03-11_at_7.56.55_PM.png) | Commit, Branch, Deployment | - -#### Another example of what to avoid: - -Links with no affordance inline with plain text. Here, they should have at least an underline, and probably different color too. - -| What's a link? | Links | -|-------|------| -|![image](/uploads/da4da55541ce8824ed9c6e13f87f6899/image.png)|![image](/uploads/f060ae0cfb5800fdb4c700711da649ec/image.png)| - ------------ - -### Few consideration highlighted by @jeldergl in a [slack thread](https://gitlab.slack.com/archives/C010NAWPRV4/p1646921391954459): - -> 1. Ensure these are understood as links in context. -> 1. See what can be done to make the gray links look more like a link. -> 1. Be extremely clear when documenting the use case while referencing all of the factors. -> 1. Ensure that what’s decided on and documented here can be abstracted out enough to address similar parts of the UI without creating loopholes. - ------------- - -### Resources - -- [WCAG Success Criteria 1.4.1 Use of Color](https://www.w3.org/TR/WCAG21/#use-of-color) -- https://gitlab-org.gitlab.io/gitlab-ui/?path=/story/base-link--default-link -- https://gitlab.com/groups/gitlab-org/-/epics/6414 -- [UI type scale link style in Pajamas UI Kit](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=542%3A334) -- [Documentation markdown link style in Figma](https://www.figma.com/file/V3HKN83B7rf2T6sseLMrxa/Type-scale---Documentation-Markdown?node-id=1%3A97) -- [Compact markdown link style in Figma](https://www.figma.com/file/mjAZxHkK95TlQ6L14aNp2M/Type-scale---Compact-Markdown?node-id=5%3A44) -- [Link styles (ideal state) in MR widget instances](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=38193%3A30482) - -_Also view linked issues_ - -@gitlab-com/gitlab-ux/designers",5 -104591009,2022-03-11 05:08:17.551,Data visualization - Update mini pipeline graph dropdown tooltips to include trigger job instance," - -### Description - -In https://gitlab.com/gitlab-org/gitlab/-/issues/340194 we're adding a special tooltip text to the trigger jobs tooltips to indicate they they're trigger jobs. This needs to be updated in the Data vis Figma file. - - - -### Figma file - - - -[View working file in Figma →](https://www.figma.com/file/17NxNEMa7i28Is8sMetO2H/branch/pheBqF0DOICBa5DAqE4hID/Data-Visualization) - -### Checklist - -Make sure the following are completed before closing the issue: - -1. [x] **Assignee**: Design in your working file. When applicable, follow our - [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. -1. [x] **Assignee**: Update the link to the working file in the issue - description. -1. [x] **Assignee**: Ask a [Foundations designer][foundations-team] - to review your design (ensure they have edit permissions in Figma). -1. [x] **Reviewer**: Review and approve assignee’s design. Specific design - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer] - for final review (make sure they have edit permissions in Figma). -1. [x] **Maintainer**: Review and approve assignee’s changes. -1. [x] **Maintainer**: Merge the branch or add the changes or additions to the - target file. - 1. [-] Ensure that all styles and components now belong to the target file. - 1. [x] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [-] **Maintainer**: When applicable, [publish][publishing] any library - changes along with a clear commit message. -1. [-] **Assignee**: If work was not done in a branch (a merged branch will automatically be archived), move your working file - to the shared Figma project: - 1. [-] For Component Library changes, move your file to the [**Component archive**][component-archive] project. - 1. [-] For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. [-] If you’re a community contributor, please consider [transfering ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -1. [-] **Assignee** (or Maintainer, for community contributions): If it’s a new - pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [-] **Assignee**: When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [-] **Assignee**: When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [x] **Assignee**: 🎉 Congrats, you made it! You can now close this issue. - -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure -[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/.gitlab/merge_request_templates/component-guideline.md -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component -[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation",1 -104500464,2022-03-09 17:53:17.318,ViewComponents > Determine process and documentation,"https://gitlab.com/gitlab-org/gitlab/-/merge_requests/82118 is our first MR that migrates a component helper to a ViewComponent. This could help with HAML/HTML components, but needs more exploration. - -Docs: https://viewcomponent.org/ - -This issue is to help serve as discussion around View Components, how we might utilize and document them, and where that documentation should live.",4 -104478590,2022-03-09 14:09:34.699,Define standards for edit icon,"### Description - -We do not consistently use the same icon to represent editing an object. This is based on this [slack thread](https://gitlab.slack.com/archives/CLW71KM96/p1646833267140679). - -- [x] Audit edit icons (search for the pencil, pencil-square icon in the codebase) - | pencil | pencil-square | - | ------ | ------ | - | ![Screen_Shot_2022-03-09_at_6.04.38_PM](/uploads/250840781259df86808b320dda78b0a7/Screen_Shot_2022-03-09_at_6.04.38_PM.png) | ![Screen_Shot_2022-03-09_at_6.04.26_PM](/uploads/3cba3b500aa2c8d7253060698c790479/Screen_Shot_2022-03-09_at_6.04.26_PM.png) | -- [x] Come up with a recommendation - | pencil - use for edit | - | ------ | - | ![Screen_Shot_2022-03-09_at_6.04.38_PM](/uploads/250840781259df86808b320dda78b0a7/Screen_Shot_2022-03-09_at_6.04.38_PM.png) | -- [x] Update that icon to include `edit` definition in Figma -- [ ] Add this in Pajamas documentation - most likely [table actions](https://design.gitlab.com/components/table#additional-actions) - [MR](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2901) -- [ ] Replace pencil-square with pencil in GitLab UI - [MR](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/89897) - - - -### Checklist - -Make sure the following are completed before closing the issue: - -1. [x] Assign the correct component label to this issue. -1. [x] Create an MR with the additions or updates needed. -1. [ ] When applicable, [create an issue using the `Figma update` issue template][pajamas-figma-update-template] to update the component in Figma, and mark it as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [ ] When applicable, [create an MR in GitLab UI][gitlab-ui-mr] to update the component. If you do not have capacity or are unable to update the component directly, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template]. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one. -1. [ ] When introducing a major or breaking change, communicate the changes within the Engineering Week in Review and UX Weekly meeting. -1. [ ] 🎉 Congrats, you made it! You can now close this issue. - - - -[gitlab-ui-mr]: https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/new -[component-lifecycle]: https://design.gitlab.com/get-started/lifecycle -[pajamas-figma-update-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Figma%20update -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component",2 -103976000,2022-03-02 16:32:20.303,Popover > Unbox header," - -### Description - -As part of an effort to ""unbox"" the GitLab UI (:arrow_forward: [watch a video with more context](https://www.youtube.com/watch?v=MxpZuWQH-kk)), the popover component could have a simple update to remove the border between the header and body content and padding. See a similar effort for [unboxing the modal](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1221). - -**How does this benefit the UI and support unboxing?** - -- The popover has hierarchy established with different font weights, the dividing border just reenforces the hierarchy that already exists. -- Similar to the results in the modal, this also allows us to remove the extra padding needed when there are two separate sections, effectively reducing popover height. -- Removing the border between the header and content allows for a more natural reading flow between header and content without the visual break that makes them feel less connected. - -![CleanShot_2022-03-02_at_10.21.47_2x](/uploads/30063e66c8421fa282c6b84d4f9099b6/CleanShot_2022-03-02_at_10.21.47_2x.png) - -### Result - -![CleanShot_2022-03-23_at_13.15.56](/uploads/ff6a16400ca5ca585f95489e61b2f22e/CleanShot_2022-03-23_at_13.15.56.gif) - -### Figma file - - - -[View working branch in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/a9sU9h6eO7waDKgaltWEzX/Component-library?node-id=425%3A131) - -### Checklist - -Make sure the following are completed before closing the issue: - -1. [x] **Assignee**: Design in your working file. When applicable, follow our - [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. -1. [x] **Assignee**: Update the link to the working file in the issue - description. -1. [x] **Assignee**: Ask a [Foundations designer][foundations-team] - to review your design (ensure they have edit permissions in Figma). -1. [x] **Reviewer**: Review and approve assignee’s design. Specific design - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [ ] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer] - for final review (make sure they have edit permissions in Figma). -1. [x] **Maintainer**: Review and approve assignee’s changes. -1. [x] **Maintainer**: Merge the branch or add the changes or additions to the - target file. - 1. [ ] Ensure that all styles and components now belong to the target file. - 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [x] **Maintainer**: When applicable, [publish][publishing] any library - changes along with a clear commit message. -1. [ ] **Assignee**: If work was not done in a branch (a merged branch will automatically be archived), move your working file - to the shared Figma project: - 1. [ ] For Component Library changes, move your file to the [**Component archive**][component-archive] project. - 1. [ ] For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. [ ] If you’re a community contributor, please consider [transfering ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -1. [x] **Assignee** (or Maintainer, for community contributions): If it’s a new - pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [x] **Assignee**: When applicable, [create an MR in this repository][new-gitlab-ui-mr] and apply the ""component-guideline"" template - to create or update the component’s documentation page. If you do not have capacity, [create an issue in this repository using the ""Component documentation"" issue template][pajamas-component-documentation-template]. Bring the issue to your team planning session for prioritization and scheduling. Mark the new issue as related to this one. -1. [x] **Assignee**: When applicable, [create an issue in GitLab UI using the ""Component"" issue template][gitlab-ui-component-template] to build or update the component code. Bring the issue to your team planning session for prioritization and scheduling. Mark the new issue as related to this one. -1. [x] **Assignee**: 🎉 Congrats, you made it! You can now close this issue. - -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure -[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/.gitlab/merge_request_templates/component-guideline.md -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component -[pajamas-component-documentation-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation -[new-gitlab-ui-mr]: https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/new",1 -103845979,2022-02-28 16:42:53.121,Dropdown > Update styles,"## Background - -Dropdowns (trigger button that opens a panel of options) in GitLab historically used a check icon to identify a selection. Awhile ago it was proposed to update to using literal checkbox and radio ``s to better represent the selection (single/multi-select). After more learning around what constitutes options within a dropdown, it' seems's clear that using literal form elements is _not_ ideal and doesn't reflect the semantics for options within a [listbox](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/listbox_role) or [combobox](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/combobox_role). - -**Current** - -![image](/uploads/6a2018fb1ac333b0f94f7b04c557d8b4/image.png) - -## Proposal - -Update the design of options within a dropdown panel to represent a selection without using literal form elements. This can be based on the previous design and should include the following states: - -- Rest -- Hover (`:hover`) -- Focus (`:focus`) -- Active/pressed (`:active`) -- Selected - -Since multi-select is a function of the component and context, and not an individual option (that uses `role=""option""`), the design of an option can be the same for single and multi-select. - -**Proposed design**: - -![image](/uploads/6002e7764c2aa09e6f495efc19428139/image.png) - -- Include a tip pointing to the referring trigger. -- Ensure the panel uses the correct [shadow](https://design.gitlab.com/layout/layers#shadows). -- Use a small :mag: icon in the search input to help with alignment and feel more in scale with the text (might consider this elsewhere in the future too). -- Selected item has rounded rectangle container. -- Border radius increased on panel to keep in proportion to border radius of elements within. -- Left aligned header. -- Option for panel action (to clear all, unassign, etc.). - -### Concepts - -There's a matrix of options: - -- Edge-to-edge option vs. inset rounded rectangle. Space is the primary consideration, but more space could benefit distinguishing options at the cost of a bit more scrolling. The inset rounded rectangle would also be closer to how flyouts are handled in the left navigation. -- Gray vs. blue selected item background. While gray keeps the UI more subdued, the use of blue aligns with our prescribed use to indicate a current or active state and also provides more differentiation with hover states. -- Checkmark vs. border selection indicator. Space is also a consideration here, but what type of indicator makes identifying a selection quick, clear, while not impeding readability is most important. - -
👁‍🗨 View initial concepts - -| | **Blue highlight** | **Gray highlight** | -| ------ | ------ | ------ | -| **Edge-to-edge checkmark ✓** | ![image](/uploads/853b75f239fe11992139b5eaace0b749/image.png) | ![image](/uploads/43f06cd9dce1c413726feee9046cc30a/image.png) | -| **Inset rectangle checkmark ✓** | ![image](/uploads/b514790592a5fa37299dd43697a571cd/image.png) | ![image](/uploads/0072c55722317f8e707e09e8410add5a/image.png) | -| **Edge-to-edge border ⎮** | ![image](/uploads/0f7bd70470b6a06512387e197b09792d/image.png) | ![image](/uploads/0ffc282090a3f475310013761ac4594c/image.png) | - -
- -
🎛 View more examples for comparison - -| | **Blue highlight** | **Gray highlight** | -| ------ | ------ | ------ | -| **Edge-to-edge checkmark ✓** | ![image](/uploads/c3ebc834761bccf63bd209894014e882/image.png) | ![image](/uploads/460b5b7655352680db9781e67d550c50/image.png) | -| **Inset rectangle checkmark ✓** | ![image](/uploads/da79ea31840c41c4f27c01bcb0632521/image.png) | ![image](/uploads/1f5d8bb617ee2072a8b4f0bf79655e07/image.png) | -| **Edge-to-edge border ⎮** | ![image](/uploads/5ad4eeb430ec9403a74c455199a716da/image.png) | ![image](/uploads/52dcab7d48a244918e6f30716dd367dc/image.png) | - -
- ---- - -**Additional considerations**: - -![image](/uploads/3bba28255f23804735cafbb7123285ab/image.png) - -1. Tip pointing to trigger element -1. Unbox the header (shadow on scroll) -1. Reduce header text size -1. Universal action placement (for actions like ""Unassign"" or ""Remove all,"" etc.) -1. Smaller search icon in search input -1. Better left edge alignment -1. Smaller label color swatch that also matches the label shape -1. Increased outer border radius for inset rectangle option for accurate border radius scaling",5 -102864498,2022-02-22 13:51:18.609,fix(Toggle): Allows Figma component 'Label' text override persistence between 'top' and 'left' variants.," - -### Description - - - -Currently text overrides to the label don't persist between Top and Left configurations. - -This update changes layer names to allow overrides to persist. - - -| Before | After | -| ------ | ------ | -| ![Screenshot_2022-02-22_at_14.53.45](/uploads/6e67fb82c1995bc41eff5cccf0eeb338/Screenshot_2022-02-22_at_14.53.45.png) | ![Screenshot_2022-02-22_at_14.55.06](/uploads/9f0dd430440f06f3664e6a4ae9629383/Screenshot_2022-02-22_at_14.55.06.png) | - -| Before | After | -| ------ | ------ | -| ![Kapture_2022-02-22_at_14.48.56](/uploads/e93bd7fc869d3348760810eb9a250296/Kapture_2022-02-22_at_14.48.56.gif) | ![Kapture_2022-02-22_at_14.51.50](/uploads/8aba7fd132947669a24e09c9239d0770/Kapture_2022-02-22_at_14.51.50.gif) | - - -#### Bonus - -This branch also updates the `toggle-disabled` variants to use `$gray-200`. - -| Before | After | -| ------ | ------ | -| ![Screenshot_2022-02-28_at_15.43.32](/uploads/d29120e6073be342f2adf982e0ad37e0/Screenshot_2022-02-28_at_15.43.32.png) | ![Screenshot_2022-02-28_at_15.42.39](/uploads/fd78fe0d893d432ffc86628819b896db/Screenshot_2022-02-28_at_15.42.39.png) | - -### Figma file - - - -[View working file in Figma →](https://www.figma.com/file/XizLfOwUBqVhE3X0PAbKb8/?node-id=425%3A140) - -### Checklist - -Make sure the following are completed before closing the issue: - -1. [x] **Assignee**: Design in your working file. When applicable, follow our - [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. -1. [x] **Assignee**: Update the link to the working file in the issue - description. -1. [x] **Assignee**: Ask a [Foundations designer][foundations-team] - to review your design (ensure they have edit permissions in Figma). -1. [x] **Reviewer**: Review and approve assignee’s design. Specific design - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer] - for final review (make sure they have edit permissions in Figma). -1. [x] **Maintainer**: Review and approve assignee’s changes. -1. [x] **Maintainer**: Merge the branch or add the changes or additions to the - target file. - 1. [x] Ensure that all styles and components now belong to the target file. - 1. [x] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [x] **Maintainer**: When applicable, [publish][publishing] any library - changes along with a clear commit message. -1. [-] **Assignee**: If work was not done in a branch (a merged branch will automatically be archived), move your working file - to the shared Figma project: - 1. [-] For Component Library changes, move your file to the [**Component archive**][component-archive] project. - 1. [-] For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. [-] If you’re a community contributor, please consider [transfering ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -1. [-] **Assignee** (or Maintainer, for community contributions): If it’s a new - pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [-] **Assignee**: When applicable, [create an MR in this repository][new-gitlab-ui-mr] and apply the ""component-guideline"" template - to create or update the component’s documentation page. If you do not have capacity, [create an issue in this repository using the ""Component documentation"" issue template][pajamas-component-documentation-template]. Bring the issue to your team planning session for prioritization and scheduling. Mark the new issue as related to this one. -1. [ ] **Assignee**: When applicable, [create an issue in GitLab UI using the ""Component"" issue template][gitlab-ui-component-template] to build or update the component code. Bring the issue to your team planning session for prioritization and scheduling. Mark the new issue as related to this one. -1. [x] **Assignee**: 🎉 Congrats, you made it! You can now close this issue. - -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure -[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/.gitlab/merge_request_templates/component-guideline.md -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component -[pajamas-component-documentation-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation -[new-gitlab-ui-mr]: https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/new",1 -102772320,2022-02-21 08:01:46.106,"Update Figma file permissions to ""Anyone with link can view""","## Problem - -Figma links in the Pajamas component docs are set to `Anyone at GitLab can view` permissions. It means that those outside of GitLab can't view the Figma files that we link to from the Pajamas docs. - -It was discovered in [this MR thread.](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2719#note_838072427) - -## Proposal - -Update the Figma file permissions to be `Anyone with a link can view`.",1 -102039893,2022-02-08 08:08:35.935,Provide guidelines for the usage of Drawers for consistent presentation of in-product Help information,"### Description - -Among other things, Drawers are used to present in-product contextual help information in GitLab. We need to provide guidelines for the usage of Drawers for Help information specifically to ensure consistent experience and a certain standard for the formatting and presentation of help info. - -#### Questions to consider - -* What are the nuances of using a Drawer for Help information? How can we standardize the design of Help drawers in GitLab? -* What kind of content does / does not belong in the drawer? -* What is the order of types of content? -* Where does the content reside for best updating? Right now, it is hardcoded in the product. -* Requirement for TW to be involved in the Help window content creation (this type of content shouldn't extensively duplicate what is already available (potentially - need to think about this one); should not consist of mostly links; should answer very specific targeted questions, should follow our CTRT design guidelines). For example - the types of content in the CI/CD example are concept, task, tip, reference. Great content and the order is helpful. - - - -### Checklist - -Make sure the following are completed before closing the issue: - -1. [x] Assign the correct component label to this issue. -1. [x] Create an MR with the additions or updates needed. -1. [ ] When applicable, [create a new Pajamas issue using the ""Figma update"" issue template][pajamas-figma-update-template] to update the component in Figma. Bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one. -1. [ ] When applicable, [create an MR in GitLab UI][gitlab-ui-mr] to update the component. If you do not have capacity or are unable to update the component directly, [create a new GitLab UI issue using the ""Component""][gitlab-ui-component-template] issue template. Bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one. -1. [ ] When introducing a major or breaking change, communicate the changes within the Engineering Week in Review and UX Weekly meeting. -1. [ ] 🎉 Congrats, you made it! You can now close this issue. - - - -[gitlab-ui-mr]: https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/new -[component-lifecycle]: https://design.gitlab.com/get-started/lifecycle -[pajamas-figma-update-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Figma%20update -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component",3 -102039696,2022-02-08 08:02:35.219,Clarify drawer usage guidelines,"### Description - -This issue is to clarify several questions about the [Drawer component](https://design.gitlab.com/components/drawer/) usage guidelines as surfaced in [this audit. ](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/376#note_750204850) - -#### Questions to answer - -* Should we allow the drawer size to be changed? -* Should the drawer have white or gray background? We have both instances in the product. -* If drawer has a scrollbar, should the width be increased or the usable content area decreased? [Context](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/73955) -* Do drawers have a ""collapsed but still slightly visible"" state? (like our right/left sidebars currently do). Or are they fully visible / fully hidden? -* Can drawers be on the left? Should our sidebars be flipped in RTL layouts (these are more broadly very broken) -* Can drawers be stacked (and overlap slightly)? Or there can be only one at a time. [Context](https://gitlab.com/gitlab-org/gitlab/-/issues/338718#note_752946251) - - - -### Checklist - -Make sure the following are completed before closing the issue: - -1. [x] Assign the correct component label to this issue. -1. [x] Create an MR with the additions or updates needed. -1. [-] When applicable, [create a new Pajamas issue using the ""Figma update"" issue template][pajamas-figma-update-template] to update the component in Figma. Bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one. -1. [x] When applicable, [create an MR in GitLab UI][gitlab-ui-mr] to update the component. If you do not have capacity or are unable to update the component directly, [create a new GitLab UI issue using the ""Component""][gitlab-ui-component-template] issue template. Bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one. -1. [x] When introducing a major or breaking change, communicate the changes within the Engineering Week in Review and UX Weekly meeting. -1. [x] 🎉 Congrats, you made it! You can now close this issue. - - - -[gitlab-ui-mr]: https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/new -[component-lifecycle]: https://design.gitlab.com/get-started/lifecycle -[pajamas-figma-update-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Figma%20update -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component",2 -102008238,2022-02-07 16:00:31.584,Pajamas UI Kit > Form component updates,"## Purpose - -Make updates to the way form components are constructed in the UI kit to reduce the number of component variants. [View the inspiration →](https://www.youtube.com/watch?v=9w0sOpsS90s) - -Figma branch [#1235-form-exploration-JE →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/ubxFCR4pADM7ZfMJ7ZvyOU/Component-library?node-id=3050%3A0)",3 -101895697,2022-02-04 15:29:10.292,Add New Popover with Close Button Variant to Pajamas," - -### Description - -As per https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/2630, we are introducing a close option to our popover component. We need to add it to Figma. - -### Figma file - - - -[View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/mSByfa79OJuwmTqQXudJhB/Component-library?node-id=425%3A131) - -### Checklist - -Make sure the following are completed before closing the issue: - -1. [x] **Assignee**: Design in your working file. When applicable, follow our - [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [FE/UX Foundations designer][foundations-team]. -1. [x] **Assignee**: Update the link to the working file in the issue - description. -1. [x] **Assignee**: Ask a [FE/UX Foundations designer][foundations-team] - to review your design (ensure they have edit permissions in Figma). -1. [x] **Reviewer**: Review and approve assignee’s design. Specific design - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer] - for final review (make sure they have edit permissions in Figma). -1. [x] **Maintainer**: Review and approve assignee’s changes. -1. [x] **Maintainer**: Merge the branch or add the changes or additions to the - target file. - 1. [ ] Ensure that all styles and components now belong to the target file. - 1. [x] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [x] **Maintainer**: When applicable, [publish][publishing] any library - changes along with a clear commit message. -1. [ ] **Assignee**: If work was not done in a branch (a merged branch will automatically be archived), move your working file - to the shared Figma project: - 1. [ ] For Component Library changes, move your file to the [**Component archive**][component-archive] project. - 1. [ ] For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. [ ] If you’re a community contributor, please consider [transfering ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -1. [ ] **Assignee** (or Maintainer, for community contributions): If it’s a new - pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [x] **Assignee**: When applicable, [create an MR in this repository][new-gitlab-ui-mr] and apply the ""component-guideline"" template - to create or update the component’s documentation page. If you do not have capacity, [create an issue in this repository using the ""Component documentation"" issue template][pajamas-component-documentation-template]. Bring the issue to your team planning session for prioritization and scheduling. Mark the new issue as related to this one. -1. [x] **Assignee**: When applicable, [create an issue in GitLab UI using the ""Component"" issue template][gitlab-ui-component-template] to build or update the component code. Bring the issue to your team planning session for prioritization and scheduling. Mark the new issue as related to this one. -1. [x] **Assignee**: 🎉 Congrats, you made it! You can now close this issue. - -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure -[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/.gitlab/merge_request_templates/component-guideline.md -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component -[pajamas-component-documentation-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation -[new-gitlab-ui-mr]: https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/new",1 -101844299,2022-02-03 19:07:37.244,Add browser settings to keyboard audit,"## Purpose - -In https://gitlab.com/gitlab-org/gitlab/-/issues/349787#note_828606021 browser settings were brought up that enable all focusable items to receive focus. This MR adds a note about it to https://design.gitlab.com/accessibility-audits/keyboard-only.",1 -101690996,2022-02-01 23:11:50.007,Alert > Allow fluid layout to determine width,"## Purpose - -In https://gitlab.com/gitlab-org/gitlab/-/merge_requests/79235 it was determined that we should remove the max-width for alert content when the user's layout preference is set to fluid. This issue will update the documentation to remove that requirement.",1 -101399064,2022-01-27 15:41:24.022,Feature idea: Pattern builder,,3 -101274857,2022-01-26 10:06:27.089,Popover > Document close button usage,"### Description - - - -As per https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/2630, we are introducing a close option to our popover component. We need to document its usage. - -### Checklist - -Make sure the following are completed before closing the issue: - -1. [x] Assign the correct component label to this issue. -1. [x] Create an MR with the additions or updates needed. -1. [x] When applicable, [create a new Pajamas issue using the ""Figma update"" issue template][pajamas-figma-update-template] to update the component in Figma. Bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one. -1. [x] When applicable, [create an MR in GitLab UI][gitlab-ui-mr] to update the component. If you do not have capacity or are unable to update the component directly, [create a new GitLab UI issue using the ""Component""][gitlab-ui-component-template] issue template. Bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one. -1. [ ] When introducing a major or breaking change, communicate the changes within the Engineering Week in Review and UX Weekly meeting. -1. [x] 🎉 Congrats, you made it! You can now close this issue. - - - -[gitlab-ui-mr]: https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/new -[component-lifecycle]: https://design.gitlab.com/get-started/lifecycle -[pajamas-figma-update-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Figma%20update -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component",1 -101227845,2022-01-25 15:12:14.168,Empty search results vs empty filter results empty state text guidance,"### Description - -We added some documentation around empty search results recently in https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1210. When I used them for https://gitlab.com/gitlab-org/gitlab/-/issues/339525/designs/Deleted-many-items.png#note_820337312, they didn't quite fit since there were filters applied. There are cases when something is searched within a search input field that will result in no matches, as well as when something is filtered within the filter component that can also result in no matches. We should decide whether or not we want to provide different messaging for those. - - - -### Audit of empty state cases - -| Summary | -| ------ | -| Whether we use a search component to filter down results, or the filter component, we do not consistently provide messages as to why there were no matches. | - -👉 When using the filter component, `7/17` instances use something similar to the following text: - -**Sorry, your filter produced no results** - -To widen your search, change or remove filters above - -👉 When using the search component, `only 3/10` instances use something similar to the following text: - -**Sorry, no projects matched your search** - -
Full audit table - -| Search input field | Filters | -| ------ | ------ | -| Projects ![Screen_Shot_2022-03-08_at_10.28.36_AM](/uploads/800d921a623501b87684a917a5fb2eae/Screen_Shot_2022-03-08_at_10.28.36_AM.png) | Issues ![Screen_Shot_2022-03-08_at_10.27.21_AM](/uploads/7e252021b92bf3f6a56487ef1c68c6ef/Screen_Shot_2022-03-08_at_10.27.21_AM.png) | -| Groups ![Screen_Shot_2022-03-08_at_10.29.49_AM](/uploads/d76975815673a1abcf9b95a7a5787443/Screen_Shot_2022-03-08_at_10.29.49_AM.png) | Members ![Screen_Shot_2022-03-08_at_10.41.39_AM](/uploads/103bfddfddb2efd9b61b427ba0112e32/Screen_Shot_2022-03-08_at_10.41.39_AM.png) | -| Explore topics ![Screen_Shot_2022-03-08_at_10.31.09_AM](/uploads/059de635a1fe4d70d81ad699e7155d9f/Screen_Shot_2022-03-08_at_10.31.09_AM.png) | Requirements ![Screen_Shot_2022-03-08_at_11.05.40_AM](/uploads/240d143eb1b3a07b4aaddd84236bc3ce/Screen_Shot_2022-03-08_at_11.05.40_AM.png) | -| Milestones ![Screen_Shot_2022-03-08_at_10.32.36_AM](/uploads/dfcbc3cbb110fc1e9f212416a52d410c/Screen_Shot_2022-03-08_at_10.32.36_AM.png) | Merge requests ![Screen_Shot_2022-03-08_at_11.16.34_AM](/uploads/b67f41ce9a37bcc88f7a0757be77d996/Screen_Shot_2022-03-08_at_11.16.34_AM.png) | -| Projects sub-menu ![Screen_Shot_2022-03-08_at_10.36.34_AM](/uploads/a9e9eb7735d42c1ec85f23470c30a3dd/Screen_Shot_2022-03-08_at_10.36.34_AM.png) | Pipelines ![Screen_Shot_2022-03-08_at_11.17.10_AM](/uploads/1b7f36dc9e98e27558d6bacea220b898/Screen_Shot_2022-03-08_at_11.17.10_AM.png) | -| Global search ![Screen_Shot_2022-03-08_at_10.37.42_AM](/uploads/f13caf597f02aab91aa7bb6224daa1cd/Screen_Shot_2022-03-08_at_10.37.42_AM.png) | Global search with filters ![Screen_Shot_2022-03-08_at_10.38.38_AM](/uploads/151cf72e385a2f7ac1141db2f02af636/Screen_Shot_2022-03-08_at_10.38.38_AM.png) | -|Labels ![Screen_Shot_2022-03-08_at_10.40.21_AM](/uploads/34c27ed18d7226724ad273e3b7864b69/Screen_Shot_2022-03-08_at_10.40.21_AM.png) | Test cases ![Screen_Shot_2022-03-08_at_11.23.46_AM](/uploads/ae790b5068dc4e65e8c07f499debc9a4/Screen_Shot_2022-03-08_at_11.23.46_AM.png) | -|Commits ![Screen_Shot_2022-03-08_at_10.42.58_AM](/uploads/cfffb64267d3e6cbb4e5e5ccf66aceb7/Screen_Shot_2022-03-08_at_10.42.58_AM.png) | Vulnerability report ![Screen_Shot_2022-03-08_at_11.24.37_AM](/uploads/8773307aa3cbd6fd96d985b675cddcfc/Screen_Shot_2022-03-08_at_11.24.37_AM.png) | -|Branches ![Screen_Shot_2022-03-08_at_10.43.32_AM](/uploads/2b6979168f3eee4502ce7a7813718ccd/Screen_Shot_2022-03-08_at_10.43.32_AM.png) | Policies ![Screen_Shot_2022-03-08_at_11.25.51_AM](/uploads/032253170ef41459e0cc529f50089c21/Screen_Shot_2022-03-08_at_11.25.51_AM.png) | -|Tags ![Screen_Shot_2022-03-08_at_11.02.48_AM](/uploads/7c3e07c24ea5589813a8a628f860ddcc/Screen_Shot_2022-03-08_at_11.02.48_AM.png) | Incidents ![Screen_Shot_2022-03-08_at_11.27.09_AM](/uploads/47fae4bf41508f264eaf2246ebb90136/Screen_Shot_2022-03-08_at_11.27.09_AM.png) | -|cell | Package registry ![Screen_Shot_2022-03-08_at_11.28.09_AM](/uploads/dc1cdf7933dde4f21681d0484bdcaf4c/Screen_Shot_2022-03-08_at_11.28.09_AM.png) | -|cell | Container registry ![Screen_Shot_2022-03-08_at_11.28.53_AM](/uploads/ba160233253ac9bb0294be86feddfe15/Screen_Shot_2022-03-08_at_11.28.53_AM.png) | -|cell | Value stream analytics ![Screen_Shot_2022-03-08_at_1.24.10_PM](/uploads/1a9bd66fb75454bab973ac85d03f94ef/Screen_Shot_2022-03-08_at_1.24.10_PM.png) | -|cell | Code review ![Screen_Shot_2022-03-08_at_1.26.07_PM](/uploads/f5c358c28a61f1305140400701688dd6/Screen_Shot_2022-03-08_at_1.26.07_PM.png) | -|cell | Issue analytics ![Screen_Shot_2022-03-08_at_1.27.43_PM](/uploads/0204d2a5a92998ebe14f51c60eb6c7ef/Screen_Shot_2022-03-08_at_1.27.43_PM.png) | -|cell | Merge Request Analytics ![Screen_Shot_2022-03-08_at_1.28.27_PM](/uploads/a5e4dec7cfa1b70730dae78166edf2c0/Screen_Shot_2022-03-08_at_1.28.27_PM.png) | -|cell | To-Do List ![Screen_Shot_2022-03-08_at_1.29.20_PM](/uploads/abe36a3cd2a979830275adad94e78707/Screen_Shot_2022-03-08_at_1.29.20_PM.png) | - -
- -### Proposal - -#### Search - -If a page uses the [search component](https://design.gitlab.com/components/search), use the following text for empty states: - -**No results found** - -Edit your search and try again. - -#### Filter - -If a page uses the [filter component](https://design.gitlab.com/components/filter), use the following text for empty states: - -**No results found** - -Edit your filters and try again. - -### Checklist - -Make sure the following are completed before closing the issue: - -1. [x] Assign the correct component label to this issue. -1. [x] Create an MR with the additions or updates needed. https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2751 -1. [ ] When applicable, [create a new Pajamas issue using the ""Figma update"" issue template][pajamas-figma-update-template] to update the component in Figma. Bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one. -1. [ ] When applicable, [create an MR in GitLab UI][gitlab-ui-mr] to update the component. If you do not have capacity or are unable to update the component directly, [create a new GitLab UI issue using the ""Component""][gitlab-ui-component-template] issue template. Bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one. -1. [ ] When introducing a major or breaking change, communicate the changes within the Engineering Week in Review and UX Weekly meeting. -1. [ ] 🎉 Congrats, you made it! You can now close this issue. - - - -[gitlab-ui-mr]: https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/new -[component-lifecycle]: https://design.gitlab.com/get-started/lifecycle -[pajamas-figma-update-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Figma%20update -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component",1 -101219535,2022-01-25 14:04:42.470,Update Pajamas with information about the new iconography,"### Description - - - -Updates to https://design.gitlab.com/product-foundations/iconography based on the work done https://about.gitlab.com/blog/2021/12/17/hey-icons-lighten-up/ - -As a designer trying to onboard I had to rely on external sources (and my memory) to read this section of the design system. - -Related to #1202. - -### Checklist - -Make sure the following are completed before closing the issue: - -1. [x] Assign the correct component label to this issue. -1. [x] Create an MR with the additions or updates needed. -1. [ ] When applicable, [create a new Pajamas issue using the ""Figma update"" issue template][pajamas-figma-update-template] to update the component in Figma. Bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one. -1. [ ] When applicable, [create an MR in GitLab UI][gitlab-ui-mr] to update the component. If you do not have capacity or are unable to update the component directly, [create a new GitLab UI issue using the ""Component""][gitlab-ui-component-template] issue template. Bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one. -1. [ ] When introducing a major or breaking change, communicate the changes within the Engineering Week in Review and UX Weekly meeting. -1. [ ] 🎉 Congrats, you made it! You can now close this issue. - - - -[gitlab-ui-mr]: https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/new -[component-lifecycle]: https://design.gitlab.com/get-started/lifecycle -[pajamas-figma-update-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Figma%20update -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component",3 -100940753,2022-01-19 21:57:24.167,UI kit > Update checkbox and radio components,"## Purpose - -- Update components to make better use of variants. -- Add indeterminate (checkboxes only and disabled states. - -### Reference - -There's an [existing Figma branch](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/zuwBQHtdwn2KALwuKRuvvB/Component-library), but it's a bit far behind the main and there are some other approaches to explore so a new branch is preferred. - -Here's an example of what's there though: - -| **Checkbox** | **Radio** | -| ------ | ------ | -| ![CleanShot_2022-01-19_at_15.50.45_2x](/uploads/2a3f115b0190ba89dd60898c522d535f/CleanShot_2022-01-19_at_15.50.45_2x.png) | ![CleanShot_2022-01-19_at_15.50.57_2x](/uploads/2a13010b45f3539ad4acf4cd5f4f8f91/CleanShot_2022-01-19_at_15.50.57_2x.png) |",2 -100450014,2022-01-11 18:37:05.300,Text guidance for blank state,"We don't have consistent text in our blank state pages in the UI. We need to create guidance and apply it. - -Related to: https://gitlab.com/gitlab-org/gitlab/-/issues/339525/designs/Deleted-many-items.png#note_807219530 - -If you look at the following examples, the most effective ones have a call to action. - -Should there be different text, based on the type of page? For example, does it make sense to have a call to action on a search or filter page that shows no results? - -## Current guidance - -I found this info in Pajamas: - -* https://design.gitlab.com/regions/empty-states -* https://design.gitlab.com/regions/empty-states#blank-content - -And there is an empty state template: https://gitlab.com/gitlab-org/gitlab/-/issues/new?issuable_template=Empty%20state - -It does define different types of blank state pages: - -- Blank page with a call to action -- Configuration required -- Higher tier required -- Empty search results - -We should recommend text for each. - -## Examples of empty state pages - -The following are just random examples from the UI. - -### Package Registry - -https://gitlab.com/sselhorn/test-project/-/packages - -![image](/uploads/337202874ce2d5812d6aff7843318635/image.png) - -### Pipelines - -https://gitlab.com/gitlab-org/gitlab/-/pipelines?page=1&scope=finished&username=gdoyle - -![image](/uploads/edd43aa39cc74d0ca7abdd196e210760/image.png) - -### Merge requests - -https://gitlab.com/dashboard/merge_requests?scope=all&state=opened&assignee_username=hmjang1 - -![image](/uploads/097cdf96bee6e98535878a567a703708/image.png) - -### Issues - -https://gitlab.com/gitlab-org/gitlab/-/issues?search=adkfhasidhf&sort=created_date&state=opened - -![image](/uploads/1e816f6ef006334d251d0df1985c4cd5/image.png) - -### Container Registry - -![image](/uploads/4f25fafd8b04bd6348c34590a6f308f9/image.png) - -### Infrastructure Registry - -![image](/uploads/062c78a5474500f98890fd8d56c3a33c/image.png) - -### Monitor > Metrics - -![image](/uploads/e79dd3ec126ef70b65fc21324f584597/image.png) - -### Monitor > Tracing - -![image](/uploads/4e9df16b2280e4a85ee9b152ec99104b/image.png) - -### Monitor > Incidents - -![image](/uploads/def330a4e72dae443f3e278a3f4947ef/image.png) - -### Security & Compliance > Security Dashboard - -![image](/uploads/01553af45a15279dd1b08a2e9b6656ac/image.png) - -### Commit search - -https://gitlab.com/gitlab-org/gitlab/-/commits/master?search=gdgdfg - -![image](/uploads/4d152ecc12a1c48d88ef6de53c927a22/image.png) - -### Repository > Locked files - -![image](/uploads/3f778c560f89e722f1f8c92e3c5fab90/image.png) - -### Issues > Milestones - -https://gitlab.com/sselhorn/test-project/-/milestones - -![image](/uploads/97987952010b6e0b3c9d7c9b318be6ef/image.png) - -### Issues > Requirements - -![image](/uploads/5fb61408cf0b326e3debf55d109b6038/image.png) - -### CI/CD > Schedules - -![image](/uploads/f8f618f52c82f21f812ae27a4213fe7e/image.png) - -### CI/CD > Test cases - -![image](/uploads/4b9d98a9419b19da67ed0e9c49f4d12a/image.png) - -### Deployments > Feature flags - -![image](/uploads/c13856af7966dad0053cdb71256678b4/image.png) - -### Infrastructure > Serverless platform - -![image](/uploads/dde3b5356eda1957978b6921e574dddc/image.png)",2 -99922200,2021-12-30 13:57:34.199,Pajamas UI Kit > Add optional prop to form label,"## Purpose - -Form labels can have ""(optional)"" appended to them. It uses a different text style and would be useful to include as an option in Figma similar to how it is in GitLab UI. The text remains editable. - -Toggling the optional property in GitLab UI: - -![CleanShot_2021-12-29_at_10.40.11](/uploads/14cf536911a8729b2f193b32ad65df25/CleanShot_2021-12-29_at_10.40.11.gif) - -[View the branch in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/QfyaK2zgr2FFlwtDKrdHQy/Component-library?node-id=425%3A10) - -Here's a quick video demo: - -![CleanShot_2021-12-30_at_08.09.23](/uploads/bce1238eb6953ed6fc96612549a82720/CleanShot_2021-12-30_at_08.09.23.mp4) - -**Note**: This implementation doesn't account for text wrapping. If the label happened to be too long then you can either consider a shorter label, or detach the instance to format it in a design comp.",1 -99190879,2021-12-16 18:50:23.448,Single stat documentation,"### Description - - - -### Checklist - -Make sure the following are completed before closing the issue: - -1. [x] Assign the correct component label to this issue. -1. [ ] Create an MR with the additions or updates needed. -1. [ ] When applicable, [create a new Pajamas issue using the ""Figma update"" issue template][pajamas-figma-update-template] to update the component in Figma. Bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one. -1. [ ] When applicable, [create an MR in GitLab UI][gitlab-ui-mr] to update the component. If you do not have capacity or are unable to update the component directly, [create a new GitLab UI issue using the ""Component""][gitlab-ui-component-template] issue template. Bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one. -1. [ ] When introducing a major or breaking change, communicate the changes within the Engineering Week in Review and UX Weekly meeting. -1. [ ] 🎉 Congrats, you made it! You can now close this issue. - - - -[gitlab-ui-mr]: https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/new -[component-lifecycle]: https://design.gitlab.com/get-started/lifecycle -[pajamas-figma-update-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Figma%20update -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component",3 -98955954,2021-12-13 15:58:05.512,Migrate component examples and docs to embedded GitLab UI stories,"With https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1175 closed, we now have a way to embed GitLab UI stories in design.gitlab.com: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/embed-gitlab-ui-stories.md. - -The [initial implementation](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2447) migrated alerts and banners to use this new approach, but several other pages are still using legacy examples and implementation tabs. Let's migrate remaining pages, the only pre-requisite being that the corresponding GitLab UI component(s) must have been migrated to the Component Story Format (https://gitlab.com/groups/gitlab-org/-/epics/5651). - -## Migration steps - -* [ ] In the `.md` file: - * [ ] Migrate the `vueComponents` property to `stories` in the frontmatter. - * [ ] Migrate `[[Example:*]]` tags to `[[Story:*]]` tags. - ```patch - diff --git a/contents/components/accordion.md b/contents/components/accordion.md - index 62da0f1..19fcdb2 100644 - --- a/contents/components/accordion.md - +++ b/contents/components/accordion.md - @@ -1,8 +1,8 @@ - --- - name: Accordion - description: An accordion is used to show and hide content. - -vueComponents: - - - GlAccordion - +stories: - + - base-accordion--default - related: - - modal - - tree - @@ -11,7 +11,7 @@ related: - - ## Examples - - -[[Example:accordion-basic]] - +[[Story:base-accordion--default]] - - [View in Pajamas UI Kit →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Pajamas-UI-Kit?node-id=425%3A0) - - ``` -* [ ] Remove the associated examples from the `examples/` directory. - -## Migration status - -| Component | Can be migrated | Migrated | -| --------------------------------------------------------------------------- | ------------------ | ------------------ | -| [accordion](https://design.gitlab.com/components/accordion) | :white_check_mark: | :white_check_mark: | -| [alert](https://design.gitlab.com/components/alert) | :white_check_mark: | :white_check_mark: | -| [avatar](https://design.gitlab.com/components/avatar) | :white_check_mark: | :white_check_mark: | -| [badge](https://design.gitlab.com/components/badge) | :white_check_mark: | :white_check_mark: | -| [banner](https://design.gitlab.com/components/banner) | :white_check_mark: | :white_check_mark: | -| [breadcrumb](https://design.gitlab.com/components/breadcrumb) | :white_check_mark: | :white_check_mark: | -| [broadcast-message](https://design.gitlab.com/components/broadcast-message) | :white_check_mark: | :white_check_mark: | -| [button](https://design.gitlab.com/components/button) | :white_check_mark: | | -| [card](https://design.gitlab.com/components/card) | :white_check_mark: | :white_check_mark: | -| [checkbox](https://design.gitlab.com/components/checkbox) | :white_check_mark: | :white_check_mark: | -| [color-picker](https://design.gitlab.com/components/color-picker) | | | -| [date-picker](https://design.gitlab.com/components/date-picker) | | | -| [drawer](https://design.gitlab.com/components/drawer) | | | -| [dropdown](https://design.gitlab.com/components/dropdown) | | | -| [file-uploader](https://design.gitlab.com/components/file-uploader) | | | -| [filter](https://design.gitlab.com/components/filter) | | | -| [form](https://design.gitlab.com/components/form) | | | -| [infinite-scroll](https://design.gitlab.com/components/infinite-scroll) | | | -| [label](https://design.gitlab.com/components/label) | :white_check_mark: | :white_check_mark: | -| [list](https://design.gitlab.com/components/list) | | | -| [modal](https://design.gitlab.com/components/modal) | :white_check_mark: | | -| [pagination](https://design.gitlab.com/components/pagination) | :white_check_mark: | | -| [path](https://design.gitlab.com/components/path) | :white_check_mark: | :white_check_mark: | -| [popover](https://design.gitlab.com/components/popover) | | :white_check_mark: | -| [progress-bar](https://design.gitlab.com/components/progress-bar) | :white_check_mark: | :white_check_mark: | -| [radio-button](https://design.gitlab.com/components/radio-button) | :white_check_mark: | | -| [search](https://design.gitlab.com/components/search) | | | -| [segmented-control](https://design.gitlab.com/components/segmented-control) | :white_check_mark: | | -| [skeleton-loader](https://design.gitlab.com/components/skeleton-loader) | :white_check_mark: | | -| [socks](https://design.gitlab.com/components/socks) | | | -| [sorting](https://design.gitlab.com/components/sorting) | :white_check_mark: | | -| [spinner](https://design.gitlab.com/components/spinner) | :white_check_mark: | | -| [table](https://design.gitlab.com/components/table) | | :white_check_mark: | -| [tabs](https://design.gitlab.com/components/tabs) | | | -| [toast](https://design.gitlab.com/components/toast) | | | -| [toggle](https://design.gitlab.com/components/toggle) | :white_check_mark: | :white_check_mark: | -| [token](https://design.gitlab.com/components/token) | :white_check_mark: | :white_check_mark: | -| [tooltip](https://design.gitlab.com/components/tooltip) | :white_check_mark: | | -| [tree](https://design.gitlab.com/components/tree) | | | -| [empty-states](https://design.gitlab.com/regions/empty-states) | :white_check_mark: | :white_check_mark: |",3 -98849054,2021-12-10 18:27:17.578,UI kit > Update components to light icons,"## Purpose - -With https://gitlab.com/gitlab-org/gitlab-svgs/-/issues/178 getting implemented in https://gitlab.com/gitlab-org/gitlab-svgs/-/merge_requests/739 we can update the icons in the Pajamas UI Kit. - -The new icons will be maintained in a separate file from the component library for easier maintenance and sharing. - -**Steps** - -1. [x] Ensure all icons that weren't updated in the recent effort, but are still part of the library, are included in the new icon file. For example, pipeline, issue type, and brand icons. -1. [x] Publish the new icon library and add it to our community page. -1. [x] Replace the icons in the component library with the ones from the new icon library. -1. [x] Deprecate the old icons by removing them from the component library and placing into a separate file that will be archived. -1. [x] Publish an updated version of the component library. -1. [x] Mention the breaking change in the UX Weekly with directions on using the new library. -1. [x] Create a new MR to update the iconography guidelines in Pajamas.",2 -98765575,2021-12-09 16:42:44.763,Illustration > Add more grid information,"## Purpose - -In https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2636 the product illustration guidelines were updated. Based on some feedback there could be more helpful guides specifically around the grid. - -> A link to some resource would be helpful, or at least some examples of illustrations within this grid so it's easier to see what are the focal points and how elements should align to it. https://design.gitlab.com/product-foundations/illustration#focal-point-grid -> -> This grid is specific to illustration, so I wouldn't assume all Product Designers know how to use it if they haven't had experience with graphic design or illustration.",1 -98752241,2021-12-09 13:29:08.659,UI kit > Define & validate shadow style specs,"## Problem - -The current layer shadow style/specs in the UI kit ([modal example](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=4263%3A22)) don't align with what's in [Pajamas](https://design.gitlab.com/layout/layers#large). This issue is to determine the correct specs and where updates are needed. - -[View branch in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/k1Qah0jN5geit4umN5uCYI/Component-library) - -| **UI kit** (Note that both are combined into one shadow) | **Pajamas** | -| ------ | ------ | -| ![CleanShot_2021-12-09_at_07.24.28](/uploads/086b732ca504a3a7dd4cbb93b8db0d7c/CleanShot_2021-12-09_at_07.24.28.png)![CleanShot_2021-12-09_at_07.24.42](/uploads/4f937c1aa0f963cdfeea240c6897250f/CleanShot_2021-12-09_at_07.24.42.png) | ```box-shadow: 0px 0px 4px rgba(0, 0, 0, 0.16), 0px 4px 12px rgba(0, 0, 0, 0.16);``` | - -## Solution - -Consolidated list of styles based on components in production and in the UI kit - -## Shadow styles - -### Small shadow - {+new+} - -| GitLab-ui | GitLab UI kit | Components | CSS | -| ------ | ------ | ------ | ------ | -| $gl-shadow-sm | Small $gl-shadow-sm | Card | `box-shadow: 0px 1px 2px rgba(0, 0, 0, 0.1);` | - -### Medium shadow - {+new+} - -| GitLab-ui | GitLab UI kit | Components | CSS | -| ------ | ------ | ------ | ------ | -| $gl-shadow-md | Medium $gl-shadow-md | Date picker, Dropdown, Menus, Flyout Nav, Card `on_drag` | `box-shadow: 0px 2px 8px rgba(0, 0, 0, 0.16), 0px 0px 2px rgba(0, 0, 0, 0.16);` | - -### Large shadow - -| GitLab-ui | GitLab UI kit | Components | CSS | -| ------ | ------ | ------ | ------ | -| $gl-shadow-lg | Large $gl-shadow-lg | Modal, Drawer | `box-shadow: 0px 4px 12px rgba(0, 0, 0, 0.16), 0px 0px 4px rgba(0, 0, 0, 0.16);` | - - - -## Changes for this issue - -### UI Kit - -- [x] Add missing shadow layer styles (sm & md) -- [x] Update the shadow-sm to be more appropriate for the card on boards. - -### Pajamas - -- [ ] Update documentation to reflect new styles -- [ ] Update images to follow `visual example` patterns - -## GitLab UI - -### In https://gitlab.com/gitlab-org/gitlab-ui/-/issues/615 - -1. Document new shadow styles and audit existing styles -1. Add new shadow styles as utility classes -1. Update instances to use the new GitLab UI utility classes - -``` -Out of scope but worth mentioning; - -* gl-shadow-focus: focus states - -This will remain unchanged in Gitlab-UI -```",1 -98706269,2021-12-08 20:56:53.115,Bug: 404 when opening a component page directly to the /contribute tab,"To recreate: - -Click this link: https://design.gitlab.com/components/table/contribute",3 -98703259,2021-12-08 19:21:00.631,"Follow-up from ""feat(Illustration): Update docs with new guides""","The following discussion from !2636 should be addressed: - -- [x] @tauriedavis started a [discussion](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2636#note_757943934): (+4 comments) - - > **non-blocking:** The figma frame has a purple background which is a bit odd. Can that be updated to be like the one above where it's on the toggle? :thinking:",1 -98620537,2021-12-07 17:46:35.492,Inline note layout broken,"## Problem - -Recently we updated the look of the inline todo, but the change has also been applied to the inline note, which has different design constraints. - -| **Todo** | **Note** | -| ------ | ------ | -| ![CleanShot_2021-12-07_at_11.45.44_2x](/uploads/f874e675facdf617fd3af76a8ac2f9f7/CleanShot_2021-12-07_at_11.45.44_2x.png) | ![CleanShot_2021-12-07_at_10.39.50_2x](/uploads/ca65232993b8b6b48e571ca16200e9f8/CleanShot_2021-12-07_at_10.39.50_2x.png) | - -## Solution - -Use a different layout for an inline note. Ideally the note content could have normal vertical flow to support longer content.",2 -98611089,2021-12-07 14:51:50.639,chore: Organize img folder,,1 -97030215,2021-11-09 17:17:24.992,Update todo note style,"## Purpose - -Update the todo styles to be more streamlined. - -- Take up less vertical space and overall reduce visual weight. -- Allow the ""Create an issue"" link to stand out. -- Use a simple document (note) icon to insinuate that this is a note. - -| **Before** | **After** | -| ------ | ------ | -| ![image](/uploads/550ef72061fe4ae04abc28fdcd7eb572/image.png) | ![image](/uploads/bca4181ff38e7270376c01563e2aad4c/image.png) | - -[View in Figma →](https://www.figma.com/file/0enu1LVbrKOuhTjLsbRsb0/%231182-todo-update?node-id=0%3A1)",1 -96281477,2021-10-27 20:23:12.555,Live example SSoT,"From a Foundations Open Office Hours agenda: - ->Correct me if I’m wrong, but we still have to update Pajamas examples to match GitLab UI stories, right? As I’ve been working through the accessibility audits, my assumption is that any change to the component in GitLab UI will mean that updates have to happen in Pajamas too. Any ideas on being able to have one live example SSoT? - -Generally at the moment I think just about everything could be affected since one version exists in Storybook in either example or CSF format, and there'd be an example in Pajamas. - -Recent example since I was working on auditing breadcrumbs. The separator isn't the same… - -| **GLUI** | **PJs** | -| ------ | ------ | -| ![CleanShot_2021-10-27_at_15.54.48_2x](/uploads/ccdb005c614ac4dbf359f7b5b5c6d35a/CleanShot_2021-10-27_at_15.54.48_2x.png) | ![CleanShot_2021-10-27_at_15.54.25_2x](/uploads/88545b4156f01065ba60ff3e1ef4f0fa/CleanShot_2021-10-27_at_15.54.25_2x.png) | - -Tabs was even more confusing because there are both stories and examples in GitLab UI, and then examples in Pajamas. I've worked on aligning them, but changes had to be made in all three places. - -Another hypothetical example might be where we update the markup in a modal CSF, but then have to update in Pajamas example to match.",3 -96127181,2021-10-26 02:55:24.941,Illustration > Update docs with new guides,"After https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1087 there should be sweeping changes to the [Illustration](https://design.gitlab.com/product-foundations/illustration) documentation to outline the new process and guidelines. - -## Process - -* [x] Update https://design.gitlab.com/product-foundations/illustration. -* [x] Ensure that related issue templates and project docs are current. -* [x] Communicate changes to the UX team.",3 -95823882,2021-10-20 21:08:59.181,Figma > Update Figma for GitLab guide,"With Figma updates and new features and workflows to leverage, it's time to update the [**Figma for GitLab**](https://www.figma.com/file/73OcYdBfOaK2xlChC3tbNX/Figma-for-GitLab?node-id=0%3A1) deck. - -[View the WIP branch →](url)",2 -95815719,2021-10-20 17:49:21.832,Update Figma issue template,"This is related to the effort in https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1130, and ensuring that the issue template also contains accurate, up-to-date information about Figma and our process.",1 -95803680,2021-10-20 14:43:53.580,Update contribution resources to account for Objects,"Update contributor guidelines, MR templates, component lifecycle, and others… - -1. [x] https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2726 and https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2744 — Update [MR template](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/.gitlab/merge_request_templates/component-guideline.md) to be generic for any kind of documentation update, including objects, and update its links. -1. [x] https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2727 — Expand on [object overview](https://design.gitlab.com/objects/overview) page, moving generic content out from the individual object pages. -1. [x] [Figma branch (merged)](https://www.figma.com/file/J68bePHXIN5OPWqaFFY9ri/branch/5tlA0Ov1H7coIxFqihWytc/Conceptual-model?node-id=5823%3A553) — Add example page and legend to conceptual model file with stickies explaining components (object and lines). Add legend component to each object page in Figma. -1. [x] https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2769 — Embed [conceptual model example page](https://www.figma.com/file/J68bePHXIN5OPWqaFFY9ri/?node-id=5823%3A553) in the [objects overview page](https://design.gitlab.com/objects/overview/).",1 -95803660,2021-10-20 14:43:23.983,Review and polish Figma conceptual model file for Objects,"[🖼 Main Figma file](https://www.figma.com/file/J68bePHXIN5OPWqaFFY9ri/Conceptual-model) - -- [x] Convert file cover to standard Pajamas cover -- [x] Add objects “folder” page -- [x] Add icons to help identify pages -- [x] Add Pajamas link at the top of each published object -- [x] [Create variants for object and line components](https://www.figma.com/file/J68bePHXIN5OPWqaFFY9ri/branch/qCgSr8rBqgrm0TCTuwCo4T/Conceptual-model)",2 -95367381,2021-10-13 14:55:21.703,Breadcrumb > Update example to use the GitLab UI story,Use the GitLab UI story as the SSoT for the embedded example.,1 -95286769,2021-10-12 14:04:31.834,Badge > Update accessibility guides,"## Purpose - -I created a quick Codepen test https://codepen.io/lostsatellites/pen/WNEezQd to validate how a badge is announced in context. Because it's a piece of metadata it likely won't make sense on its own, so these additional considerations take that into account.",1 -95123649,2021-10-08 17:15:30.673,Add skip link to Pajamas site,"## Purpose - -The Pajamas website doesn't have a skip link to jump keyboard users to the main content area. This adds one so that as the first focusable item a keyboard user can have focus moved to `main`. This will also aid in being able to access in-page rendered examples quicker instead of tabbing through all of the navigation. - -The pattern outlined in https://css-tricks.com/a-deep-dive-on-skipping-to-content/ will be the starting point.",1 -95106896,2021-10-08 12:16:48.525,Create an Object issue template,"## 🧩 Problem - -We've started documenting objects in Pajamas (see the [MR object](https://design.gitlab.com/objects/merge-request)). Currently we don't have any contribution guidelines for documenting objects. For someone unfamiliar with the purpose and process of object modeling it can be intimidating and difficult to get started. - -The conceptual object model becomes more useful as more objects and layouts are documented since it helps communicate the relationships between different objects. The more objects and layouts we document (even if the model is imperfect at first), the more we'll be able to use it. For example, it can help identify important object relationships and ensure we don't overlook them in our design work. - -## 💡 Proposal - -We don't need to create a perfect set of guidelines and templates to start benefiting from the documented model. The objective is to create an MVC set of guidelines and resources to get more product designers interested in contributing. - -This issue will focus on adding an Object issue template to guide designers as they document the conceptual model and the layouts for the object.",2 -94525527,2021-09-29 10:36:14.286,Date picker - make month/year look more interactive,"# Problem - -- The date picker has a dropdown for the month and year and nobody knows about it! -- Related to #601. From this thread: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/601#note_689319507 - -# Proposal - -- Use a similar pattern to the sidebar - with a tertiary button that goes to `gray-50` on-hover to show interaction... - -![Screenshot_2021-09-29_at_18.09.](/uploads/2b519167e5160104db6465cb57a7268f/Screenshot_2021-09-29_at_18.09..gif) - -# Other ideas - -![Screenshot_2021-09-29_at_11.57._2x](/uploads/597d379e81300df7b0db0159f688a232/Screenshot_2021-09-29_at_11.57._2x.png)",1 -94403493,2021-09-27 19:34:29.155,Triage Build job failure,"## Purpose - -I've noticed that the **Build** job is failing for pipelines in the Pajamas project. This issue is to determine a fix.",1 -94391827,2021-09-27 15:44:40.016,UI Kit > Migrate Drawer component from Sketch to Figma," - -### Description - - - -In https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/376#note_683270630 it was identified that the Drawer component design specs exist in Sketch, but need to be added as a component in Figma. - -### Figma file - - - -[View working file in Figma →](https://www.figma.com/file/5etp1G6sZS5O57yXQ4mxeY/Migrate-Drawer-component-from-Sketch-to-Figma?node-id=1%3A70) - -### Checklist - -Make sure the following are completed before closing the issue: - -1. [x] **Assignee**: Design in your working file. When applicable, follow our - [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [FE/UX Foundations designer][foundations-team]. -1. [x] **Assignee**: Update the link to the working file in the issue - description. -1. [x] **Assignee**: Ask a [FE/UX Foundations designer][foundations-team] - to review your design (ensure they have edit permissions in Figma). -1. [x] **Reviewer**: Review and approve assignee’s design. Specific design - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer] - for final review (make sure they have edit permissions in Figma). -1. [x] **Maintainer**: Review and approve assignee’s changes. -1. [x] **Maintainer**: Add the changes or additions to the target file. For - example, you’d copy a final chart design from the working file and paste into the related location in the Data Visualization file. - 1. [x] Ensure that all styles and components now belong to the target file. - 1. [x] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [x] **Maintainer**: When applicable, [publish][publishing] any library - changes along with a clear commit message. -1. [x] **Assignee**: Move your working file to the shared Figma project: - 1. [x] For Component Library changes, move your file to the [**Component archive**][component-archive] project. - 1. [-] For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. [-] If you’re a community contributor, we ask that you [transfer ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -1. [x] **Assignee** (or Maintainer, for community contributions): If it’s a new - pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [-] **Assignee**: When applicable, [create an MR in this repository][new-gitlab-ui-mr] and apply the ""component-guideline"" template - to create or update the component’s documentation page. If you do not have capacity, [create an issue in this repository using the ""Component documentation"" issue template][pajamas-component-documentation-template]. Bring the issue to your team planning session for prioritization and scheduling. Mark the new issue as related to this one. -1. [-] **Assignee**: When applicable, [create an issue in GitLab UI using the ""Component"" issue template][gitlab-ui-component-template] to build or update the component code. Bring the issue to your team planning session for prioritization and scheduling. Mark the new issue as related to this one. -1. [x] **Assignee**: 🎉 Congrats, you made it! You can now close this issue. - -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure -[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/.gitlab/merge_request_templates/component-guideline.md -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component -[pajamas-component-documentation-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation -[new-gitlab-ui-mr]: https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/new",2 -94158909,2021-09-23 03:54:01.459,"Follow-up from ""feat(Drawer): Update content to utilize new template""","The following discussion from !2546 should be addressed: - -- [x] @tauriedavis started a [discussion](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2546#note_684885183): (+1 comment) - - > - If supplemental content isn't suited for small areas or is part of a flow, consider loading a new page, revealing content with an [accordion](/components/accordion), or using a [modal](/components/modal) instead. - > - >> I'm hesitant to add modal here as an option for when supplemental content isn't suited for small areas. I wonder if there is additional info to add here about where a modal should be used in place of a drawer (such as the line below this one).",1 -93885645,2021-09-17 20:36:40.957,Update Pajamas UI Kit contribution guidelines,"## Purpose - -As new features have been released in Figma, so too we've started using them and changed up a few workflows. The [**Pajamas UI Kit contribution and updating guidelines**](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components) document could use a thorough review along with updates. - -/cc @mle @lvanc @nadia_sotnikova @cam.x @tauriedavis",2 -93667422,2021-09-14 19:01:09.978,Pajamas UI Kit > Text input add-on component variable,"## Purpose - -Recently the [text input base](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=43905%3A45856) was updated to include prefix and suffix options while the add-ons remained unchanged. This issue addresses making the add-ons easier to change and update in a similar way. - -![CleanShot_2021-09-14_at_13.40.09_2x](/uploads/42ee6804da0c816a098adda02d456ca1/CleanShot_2021-09-14_at_13.40.09_2x.png) - -## Scope - -Create a branch of the component library **❖ _Base Add-on** component with the following variants: - -- Character count -- Clear button ([clear](https://gitlab-org.gitlab.io/gitlab-svgs/?q=~clear) icon) to clear entered content -- Show button ([eye](https://gitlab-org.gitlab.io/gitlab-svgs/?q=~eye) icon) for password visibility -- Hide button ([eye-slash](https://gitlab-org.gitlab.io/gitlab-svgs/?q=~eye-slash)) for obscuring password -- Calendar button ([calendar](https://gitlab-org.gitlab.io/gitlab-svgs/?q=~calendar) icon) for date picker - -The character count can be present with the buttons, but only one button can be visible at a time. - -**Additional changes:** - -- The add-ons in the **❖ _Base Field** component will be replaced with the **❖ _Base Add-on** component. -- Currently the add-ons are set to true/false for the **Text input** component and will need to be changed to a dropdown to choose the type of add-on. The **Text area** component can remain as true/false as long as the character count is the only option. -- All component variants will need to be updated to look the same as they do today, only they will have the correct add-on chosen by default. This applies to everything in **Forms**, as well as **Datepicker** and **Dropdown**. - -### Design file - -Figma: https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/5BKoo354GwPXInx3EsPDFa/Component-library?node-id=425%3A10 `1120-working-branch-veethikaa`",3 -93648529,2021-09-14 14:32:11.383,Component template: Component structure image,"This issue is to discuss adding multiple structure images and what state the component should be in for the structure image. Based on https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2520#note_671632056. - -Two main questions: - -1. What state of the component should be the structure image? For example: - -| Beginning | All possible elements (Base component) | -| ------ | ------ | -| ![Screen_Shot_2021-09-14_at_10.35.12_AM](/uploads/5440df806d6010c37e7b7c6e7976faa7/Screen_Shot_2021-09-14_at_10.35.12_AM.png) | ![Screen_Shot_2021-09-14_at_10.35.18_AM](/uploads/b6745b7566efb4ffa2cd2548ee6d173d/Screen_Shot_2021-09-14_at_10.35.18_AM.png) | - -Which should be the structure image? My assumption is to use the base component so we can describe each possible visible element. - -2. Should we include multiple structure images if there are different variants? For example: - -| Single file uploader | Multi file uploader | -| ------ | ------ | -| ![Screen_Shot_2021-09-14_at_10.35.18_AM](/uploads/9e2089c97144d8f97abcf4d75babf39d/Screen_Shot_2021-09-14_at_10.35.18_AM.png) | ![Screen_Shot_2021-09-14_at_10.37.34_AM](/uploads/1d2c201ce6b8bbadb557d5ec17d76a97/Screen_Shot_2021-09-14_at_10.37.34_AM.png) | - -Again, my assumption is we include both, with unique lists for each. Thoughts?",1 -93328872,2021-09-08 13:06:31.718,Frontmatter description doesn't render unless there are tabs,"Currently, we are rendering `description:` at the top of the page, but **only** if the pages contains tabs. This description should always render, regardless of whether there are tabs or not. A lot of pages don't contain tabs, so we'll never be able to utilize the `description:` unless there is a vueComponent associated with that component. - -For example, we are creating an overview page that utilizes the `description:` item: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1105. We are also updating the docs pages to utilize a new doc template, which utilizes the `description:` item, so if the components without a Vue component get updated to the new template, those updates will be blocked until this is resolved.",2 -93192659,2021-09-06 13:21:58.605,Pajamas UI Kit > Update top nav Figma component," - -### Description - - - -### Figma file - - - -[View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/PVS2W2D3IioRPYvwdGmlvb/Component-library?node-id=7580%3A42) `update-consolidated-top-nav` - -### Screenshots - -Variants - -| Before | After | -| ------ | ------ | -| ![image](/uploads/a2738a09139da89e5dfb5ce2cf8ffce1/image.png) | ![image](/uploads/e9021003b00b8126befa25ecb22406f0/image.png) | - -Project menu - -| Before | After | -| ------ | ------ | -| ![image](/uploads/030f4016545153634918e672594d63c6/image.png) | ![image](/uploads/3d54c313974e08fb9c699c0d07aae6a3/image.png) | - -### Checklist - -Make sure the following are completed before closing the issue: - -1. [x] **Assignee**: Design in your working file. When applicable, follow our - [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [FE/UX Foundations designer][foundations-team]. -1. [x] **Assignee**: Update the link to the working file in the issue - description. -1. [x] **Assignee**: Ask a [FE/UX Foundations designer][foundations-team] - to review your design (ensure they have edit permissions in Figma). -1. [x] **Reviewer**: Review and approve assignee’s design. Specific design - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer] - for final review (make sure they have edit permissions in Figma). -1. [x] **Maintainer**: Review and approve assignee’s changes. -1. [x] **Maintainer**: Add the changes or additions to the target file. For - example, you’d copy a final chart design from the working file and paste into the related location in the Data Visualization file. - 1. [ ] Ensure that all styles and components now belong to the target file. - 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [x] **Maintainer**: When applicable, [publish][publishing] any library - changes along with a clear commit message. -1. [x] **Assignee**: Move your working file to the shared Figma project: - 1. [ ] For Component Library changes, move your file to the [**Component archive**][component-archive] project. - 1. [ ] For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. [ ] If you’re a community contributor, we ask that you [transfer ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -1. [x] **Assignee** (or Maintainer, for community contributions): If it’s a new - pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [x] **Assignee**: When applicable, [create an MR in this repository][new-gitlab-ui-mr] and apply the ""component-guideline"" template - to create or update the component’s documentation page. If you do not have capacity, [create an issue in this repository using the ""Component documentation"" issue template][pajamas-component-documentation-template]. Bring the issue to your team planning session for prioritization and scheduling. Mark the new issue as related to this one. -1. [ ] **Assignee**: When applicable, [create an issue in GitLab UI using the ""Component"" issue template][gitlab-ui-component-template] to build or update the component code. Bring the issue to your team planning session for prioritization and scheduling. Mark the new issue as related to this one. -1. [x] **Assignee**: 🎉 Congrats, you made it! You can now close this issue. - -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure -[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/.gitlab/merge_request_templates/component-guideline.md -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component -[pajamas-component-documentation-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation -[new-gitlab-ui-mr]: https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/new",3 -92292719,2021-08-19 19:30:37.860,Avatar > Reverse stack order,"## Problem - -The current stacked order of avatars places the last item at the very bottom. Since this can be an interactive badge I think the order should be reversed. Also, the stacking order infers who was added when. If someone was added later, it makes sense that their avatar is set on top of the one before. - -## Solution - -Continue to order the avatars from left to right, but as they're ordered from left to right, they should stack from bottom to top. This allows the badge (if present) to be the most visible item and have the largest click target when interactive. - -When DOM order and z-index is considered I believe this is a more natural presentation too. - -| **Before** | **After** | -| ------ | ------ | -| ![image](/uploads/e60fd6ae73743e07cb44ce1cba703e73/image.png) | ![image](/uploads/ef0058de0952bbb0b830ae674ce611f5/image.png) | - -[View proposal in Figma →](https://www.figma.com/file/hO6UAuOrF5Ca8ltX4rZUb9/Avatar-stack-order?node-id=2%3A844) (Note: this was a separate file and not a branch because it's only changing instances and not a component or styles.)",1 -92063977,2021-08-16 19:17:26.917,Focus ring: Explore increasing contrast,"## Purpose - -As a result of the audit in the parent epic, the focus ring visual styles should be reviewed to consider the following: - -- Increase focus ring contrast to at least 3:1 (currently 1.97:1). -- While I believe that there is no current failure because for [SC 2.4.7](https://www.w3.org/TR/WCAG21/#focus-visible) there is a visible focus ring, and for [SC 1.4.11](https://www.w3.org/TR/WCAG21/#non-text-contrast) the button text and/or icon has sufficient contrast, there are potential updates per the [WCAG 2.2 Working Draft](https://www.w3.org/TR/WCAG22/) that we could aim to satisfy now. - - [Success Criterion 2.4.11 Focus Appearance (Minimum)](https://www.w3.org/TR/WCAG22/#focus-appearance-minimum) - -**Watch recordings of the audit** (internal) - -[▶︎ Visual scan](https://drive.google.com/file/d/1qCB9-KfC1p-D7ao0QiwzQQMehERZZvUS/view?usp=sharing) - -**Current contrast:** - -![CleanShot_2021-08-16_at_14.45.10_2x](/uploads/97f299ffbc64bbb4b225e4d52978abfd/CleanShot_2021-08-16_at_14.45.10_2x.png) - -(Contrast with opacity checked with [contrast-ratio.com](https://contrast-ratio.com/#rgb%2831%20117%20203%20%2F%2048%25%29-on-white). - -## Resources - -- https://www.sarasoueidan.com/blog/focus-indicators/ -- https://www.w3.org/WAI/WCAG22/Understanding/focus-appearance-minimum.html",2 -91809050,2021-08-11 12:09:41.126,Elevate contribution to a tab,"How can we increase and invite contribution to Pajamas in a ""boring solution"" kind of way? - -Inspired by the **Discussion** tab in https://designsystem.gov.au/components/buttons/discussion/ (thanks @mle for tweeting about this site, it's awesome) I'm exploring a **Contribute** tab. - -What would go in there? - -- A bit of a text preamble with a link to the **Getting started > Contribute** page. -- We already have links in the footer to related issues and merge requests. It'd be worth repeating here when either are available. -- Occasional links to research efforts, polls, questionnaires, hackathons, etc. It'd be great to have some passive, evergreen items like that where someone could provide feedback. - -What does this solve? - -- Reenforcing that ""everyone can contribute,"" while creating more visibility on how. -- What I especially liked about the Australian Government Design System example is how I felt invited into the conversation. It wasn't just one-way information. It also felt very transparent to reference discussion happening behind the scenes that you might normally not be privy to. - -![CleanShot_2021-08-11_at_06.58.24_2x](/uploads/37a795f289176828260a08d1747814db/CleanShot_2021-08-11_at_06.58.24_2x.png)",2 -91748971,2021-08-10 13:29:02.265,feat(markdown): Underline links in body content,"## Purpose - -At the moment, links in the markdown content are not underlined and have low contrast next to static text. This makes it more difficult to discern a link from surrounding text. - -## Solution - -A boring solution is simply to leverage the default `text-decoration: underline` for links within markdown. This is also proposed as an update to markdown in GitLab UI https://gitlab.com/gitlab-org/gitlab-ui/-/issues/1084, but this solution covers the gap until that is updated and Pajamas is using the markdown styles in documentation.",1 -91501194,2021-08-05 13:01:45.577,Pajamas > Add Google Analytics,"## Purpose - -It'd be great to have a high-level understanding of most accessed content in Pajamas and the path users take to get there. - -## Solution - -In https://gitlab.com/gitlab-com/marketing/inbound-marketing/seo/-/issues/129 we were given the ability to add Google Analytics to Pajamas.",3 -91275541,2021-08-02 13:27:31.147,FY22-Q3 KR3: Illustrate empty states for Access Tokens and Admin/Applications using new styles and assets,"Use the new style library and assets to create illustrations for the following empty states: - -- [x] https://gitlab.com/gitlab-org/gitlab-svgs/-/issues/196 -- [x] https://gitlab.com/gitlab-org/gitlab-svgs/-/issues/195",2 -91275453,2021-08-02 13:26:01.826,FY22-Q3 KR2: Create new illustration asset and style library,"Create a new Figma file and build a foundation of styles and assets in alignment with brand illustrations that can be used to update documentation and support a redesign of product illustration. - -Light and dark UI will be considered to determine if there's an efficient way to create illustrations that can also adapt to UI preference. - -* [x] Create a new Figma file with library styles that consider light and dark UI ~~(with mapping between the two)~~. -* [x] Start creating reusable assets as components based on the audit in https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1086 and the resources created by the brand team. ~~Initial focus specifically on assets that will support https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1088.~~ -* [x] ~~Create a POC to test CSS vars and classes within the illustrations that update based on light/dark UI settings.~~ Create a POC to test browser support for SVG with transparency and gauge the result on light/dark UI.",5 -91275385,2021-08-02 13:25:00.072,FY22-Q3 KR1: Audit current empty state illustrations,"Audit all empty state illustrations to determine what elements are repeatable and where there are opportunities to empower designers to create their own unique empty state illustrations that are based on a library of reusable assets. - -* [x] Audit all empty states in https://gitlab-org.gitlab.io/gitlab-svgs/illustrations (can also be referenced from Figma in https://www.figma.com/file/0DhXXlTakscLiHZLKuiJ6C/Illustration-library). -* [x] Create a list of repeating themes, sizes, and elements that could be leveraged to create an illustration library. - ---- - -## Proposed state - -* Use a common grid to layout the illustration — one for large and one for medium (no small identified as empty states in the current illustration library). -* Have a consistent focal-point. Leverage the grid and some keylines to help with object placement. -* Use a consistent color palette for the focal-point element(s). -* Establish guides on when to create a more custom illustration, and when to leverage something that's multi-purpose or more generic. For example, a more custom illustration could be created with a combination of new and existing assets for a new feature or one that isn't enabled, while an empty data state or configuration needed could always use the same asset. - -### Repeating themes - -- New feature -- Upgrade -- Not configured -- No data - -## Sizes - -- Large -- Medium -- Small (new) - -## Elements - -* Ellipses to contain icons or graphics. -* Dashed connectors to establish relationships. -* Shapes to represent placeholder content. -* Small reusable illustrations. For example, to consistently represent no data or needs configuration. -* More TBD after starting to build this out.",3 -91023231,2021-07-28 13:20:24.385,GFM Typescale > Audio > design,"## Task -Create Figma specs for the GitLab Flavored Markdown audio component. See parent epic for detailed information about this component. - - -## [Figma branch (Audio)](https://www.figma.com/file/V3HKN83B7rf2T6sseLMrxa/Type-scale---Documentation-Markdown?node-id=1097%3A10) -![Documentation](/uploads/0bda3b5a88fa7e256a5523fcc954ae7e/Documentation.png)",1 -90925147,2021-07-27 14:17:18.646,GFM Typescale > Inline diff > design,"Create Figma specs for the GitLab Flavored Markdown inline diff component. - -See parent epic for detailed information about this component. - -Figma files: - -- [Documentation markdown - Inline diff](https://www.figma.com/file/V3HKN83B7rf2T6sseLMrxa/Type-scale---Documentation-Markdown?node-id=988%3A10) -- [Compact markdown - Inline diff](https://www.figma.com/file/mjAZxHkK95TlQ6L14aNp2M/Type-scale---Compact-Markdown?node-id=893%3A4)",1 -90843308,2021-07-26 12:10:31.807,GFM Typescale > Code block > design,"Create Figma specs for the GitLab Flavored Markdown code block component. - -See parent epic for detailed information about this component. - -Figma assets: - -- [Documentation markdown - Code block](https://www.figma.com/file/V3HKN83B7rf2T6sseLMrxa/Type-scale---Documentation-Markdown?node-id=985%3A10) -- [Compact markdown - Code block](https://www.figma.com/file/mjAZxHkK95TlQ6L14aNp2M/Type-scale---Compact-Markdown?node-id=890%3A8)",1 -90842445,2021-07-26 12:00:08.892,GFM Typescale > Image > design,"Create Figma specs for the GitLab Flavored Markdown image component. - -See parent epic for detailed information about this component. - -- :pencil2: [Figma branch - Documentation markdown](https://www.figma.com/file/V3HKN83B7rf2T6sseLMrxa/branch/gI2szSJVfByu9N0Etzucr0/Type-scale---Documentation-Markdown?node-id=974%3A10) -- :pencil2: Figma branch - Compact markdown - TBD",1 -90744464,2021-07-23 17:18:14.582,Fix sidebar collapse when section has a collapsable sub-section,"The following discussion from !2469 should be addressed: - -- [ ] @jeldergl started a [discussion](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2469#note_633217411): (+1 comment) - - > @tauriedavis something seems to be broken with this extra nested level. It's always open and looks active by default, even when navigating to other pages. Closing it closes the parent too. I haven't been able to dig into this further, but it makes me wonder if something with the JS has to get updated. - > - > ![CleanShot_2021-07-22_at_08.06.31](/uploads/88b404ed7ab0554f1e081159b338ab41/CleanShot_2021-07-22_at_08.06.31.gif)",2 -90737033,2021-07-23 14:29:02.431,GFM Typescale > Blockquote > design,"Create Figma specs for the GitLab Flavored Markdown blockquote component. - -See parent epic for detailed information about this component. - -### Proposal - -| Compact (current) | Compact (New) | -| ------ | ------ | -| ![Screen_Shot_2022-04-25_at_09.13.25](/uploads/21ff653feded81ff89bb895ab230b107/Screen_Shot_2022-04-25_at_09.13.25.png) | ![Blockquote-compact-md](/uploads/0b2321770d18641b42fc914459cafd8b/Blockquote-compact-md.png) | - -| Documentation (current) | Documentation (New) | -| ------ | ------ | -| ![Screen_Shot_2022-04-25_at_09.12.21](/uploads/bf3713fb90309cd3905cdb6b2ee36040/Screen_Shot_2022-04-25_at_09.12.21.png) | ![Blockquote-doc-md](/uploads/9d8293214f4d4f2eba1c03ff10190ed9/Blockquote-doc-md.png) | - - -**Summary of changes:** -- Left border: `4px` `$gray-100` -- Text: `$gray-700` -- See reasons for color updates: https://gitlab.com/gitlab-org/gitlab/-/issues/231405/ - -### Design source -- :pencil2: [Figma - Documentation markdown](https://www.figma.com/file/V3HKN83B7rf2T6sseLMrxa/branch/eMkpaCMX6MS4JsZhgRB23O/Type-scale---Documentation-Markdown?node-id=1843%3A373) -- :pencil2: [Figma - Compact markdown](https://www.figma.com/file/mjAZxHkK95TlQ6L14aNp2M/branch/ygOLNsF7gZZlJKrrOzaGlu/Type-scale---Compact-Markdown?node-id=1657%3A170) -- :pencil2: [Figma - Component library](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=33967%3A28794)",1 -90701620,2021-07-22 22:08:24.242,GFM Typescale > Table > design,"Create Figma specs for the GitLab Flavored Markdown table component. - -See parent epic for detailed information about this component. - -- :pencil2: [Figma branch - Documentation markdown](https://www.figma.com/file/V3HKN83B7rf2T6sseLMrxa/branch/vO1Ef5cah3JWGlJKq9XvGw/Type-scale---Documentation-Markdown?node-id=1174%3A11) -- :pencil2: [Figma branch - Compact markdown](https://www.figma.com/file/mjAZxHkK95TlQ6L14aNp2M/branch/F0ml9uXBQGWz0Jg5YVjY90/Type-scale---Compact-Markdown?node-id=1554%3A78) - -### Summary of changes -- Removed all vertical borders -- Removed thicker border between header and body row -- Changed cell text color from `$gray-900` :arrow_right: `$gray-700` -- Changed vertical text alignment from `middle` :arrow_right: `top` -- All inner cell content for both header and body cells has a consistent padding of `8px` L/R and `12px` T/B -- Added alternating rows by default",1 -90700782,2021-07-22 21:21:39.168,FY22-Q3 Foundations KR1.5: Identify whether there are additional empty state types that need to be added,"- [x] After reviewing the [four empty state types](https://gitlab.com/groups/gitlab-org/-/epics/6413), identify whether there are additional empty state types that need to be added - - [x] If yes, identify problem statements to test during the validation phase",2 -90700687,2021-07-22 21:15:56.257,"FY22-Q3 Foundations KR1.4: Review ""empty search results"" empty state","Within our empty state documentation, we've identified [four types of empty states](https://design.gitlab.com/regions/empty-states#when-to-use-an-empty-state). In this issue, we will review the `empty search results` empty state. - -Empty search results: Display empty search results. - -- [x] Find 2-3 existing examples of the `empty search results` empty state in the product -- [x] Determine if this type of empty state is a valid use case for the empty state region -- [x] Identify areas of possible improvement by writing problem statements to test during problem validation",1 -90700665,2021-07-22 21:14:11.770,"FY22-Q3 Foundations KR1.3: Review ""error state"" empty state","Within our empty state documentation, we've identified [four types of empty states](https://design.gitlab.com/regions/empty-states#when-to-use-an-empty-state). In this issue, we will review the `error state` empty state. - -Error state: Convey an error state, which will depend on the nature of the error and should be used judiciously. An example of this would be a server response error, that is, 404 or 500. - -- [x] Find 2-3 existing examples of the `error state` empty state in the product -- [x] Determine if this type of empty state is a valid use case for the empty state region -- [x] Identify areas of possible improvement by writing problem statements to test during problem validation - -# Outcome - - -We will want to remove this from empty state guidelines, as it is not a valid use case. Errors are separate and can be handled with anything from an alert to 404 to form validation",1 -90700627,2021-07-22 21:12:33.624,"FY22-Q3 Foundations KR1.2: Review ""blank content"" empty state","Within our empty state documentation, we've identified [four types of empty states](https://design.gitlab.com/regions/empty-states#when-to-use-an-empty-state). In this issue, we will review the `blank content` empty state. - -Blank content: Act as a placeholder for regions in the app left blank intentionally. - -- [x] Find 2-3 existing examples of the `blank content` empty state in the product -- [x] Determine if this type of empty state is a valid use case for the empty state region -- [x] Identify areas of possible improvement by writing problem statements to test during problem validation",1 -90700580,2021-07-22 21:10:07.979,"FY22-Q3 Foundations KR1.1: Review ""unused feature"" empty state","Within our empty state documentation, we've identified [four types of empty states](https://design.gitlab.com/regions/empty-states#when-to-use-an-empty-state). In this issue, we will review the `unused feature` empty state. - -Unused feature: Make users aware that a feature is not configured for use. - -- [x] Find 2-3 existing examples of the `unused feature` empty state in the product -- [x] Determine if this type of empty state is a valid use case for the empty state region -- [x] Identify areas of possible improvement by writing problem statements to test during problem validation - -Proposals: - -* Update category name to `Configuration required`.",1 -90700472,2021-07-22 21:03:18.123,"FY22-Q3 Foundations KR2: Perform problem validation where necessary to understand existing limitations, creating recommendations and performing solution validation to confirm assumptions","[FY22-Q3 UX Department: Foundations SubTeam OKR](https://gitlab.com/groups/gitlab-org/-/epics/6412) - -Objective: Improve learnability of features by researching and providing recommendations for improved empty states with a focus on user on-boarding - -**KR3: Perform problem validation where necessary to understand existing limitations, creating recommendations and performing solution validation to confirm assumptions** - -- [ ] Using the problem statements from the [first KR](https://gitlab.com/groups/gitlab-org/-/epics/6413), perform problem validation to address assumptions -- [ ] Generate recommendations based on research -- [ ] Perform solution validation as needed - -Ally: https://app.ally.io/objectives/1453437?time_period_id=135090",3 -90700269,2021-07-22 20:56:10.949,FY22-Q3 Foundations KR3: Update empty state usage guidelines/design specs using what we've learned from research,"[FY22-Q3 UX Department: Foundations SubTeam OKR](https://gitlab.com/groups/gitlab-org/-/epics/6412) - -Objective: Improve learnability of features by researching and providing recommendations for improved empty states with a focus on user on-boarding - -**KR3: Update empty state usage guidelines/design specs using what we've learned from research** - -- [x] Update [empty state guidelines](https://design.gitlab.com/regions/empty-states) in Pajamas -- [ ] ~~Update design specs in the [Figma UI Kit](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Pajamas-UI-Kit)~~ -- [x] Review [existing empty state issues](https://gitlab.com/groups/gitlab-org/-/epics?scope=all&search=empty+state&state=opened) and close any that are no longer relevant - -Ally: https://app.ally.io/objectives/1453438?time_period_id=135090",3 -90690258,2021-07-22 15:57:42.088,Button > Explore documentation hierarchy,"## Purpose - -When working through some Pajamas research related to https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, I noticed that the concept of button categories and variants was confusing for users. I still mull it over from time to time too. I’m wondering if perhaps we could reconsider the hierarchy of information here to simplify it? - -| **Current** | **Proposed** | -| ------ | ------ | -| **Category:**
- Primary
- Secondary
- Tertiary

**Variants:**
- Confirm
- Default
- Dashed
- Danger
- Link | **Variants:**
- Confirm
  - Primary
  - Secondary
  - Tertiary
- Default
  - _Same pattern as Confirm_
- … | - -This would focus on the variants, and then the options for each variant. I think doing away with the category content as-is would be helpful. We can still identify primary, secondary, and tertiary actions, but secondary to variant. We could always take naming further, but a change like this doesn't require component changes as far as I can tell, just how it's presented.",3 -90680025,2021-07-22 12:50:23.019,GFM Typescale > Code span > design,"Create Figma specs for the GitLab Flavored Markdown code span component. - -See parent epic for detailed information about this component. - -- [Documentation markdown - Code span](https://www.figma.com/file/V3HKN83B7rf2T6sseLMrxa/Type-scale---Documentation-Markdown?node-id=909%3A10) -- [Compact markdown - Code span](https://www.figma.com/file/mjAZxHkK95TlQ6L14aNp2M/Type-scale---Compact-Markdown?node-id=862%3A4)",1 -90567168,2021-07-20 15:06:53.560,Add Pajamas Playground to documentation,"### Problem - -While the Pajamas documentation provides extensive examples and code snippets for our components, there is currently no easy way to try our design system without installing GDK or creating a GitPod instance. - -### Proposal - -This issue proposes adding a Pajamas Playground to our documentation (potentially as a simple iframe), to remedy this gap and enable designers & developers to: - -- Quickly try component code directly in the browser -- Test different component props and combinations -- Easily collaborate and generate code snippets for other developers - -**Question for the Foundations Team**: Do you see this as something useful and worth integrating into the docs? - -You can see a working proof of concept at https://dfosco.gitlab.io/pajamas-playground - -![image](/uploads/34e863f638e349383893a28330476fe3/image.png) - -### Possible Next steps - -The proof of concept above is a very rough prototype, and it can likely break very easily. Possible next steps to integrate this as an official part of our tooling include: - -- Embed playground in a dedicated page of Pajamas docs -- Update code to dynamically import the latest version of _every_ Pajamas component (including new ones) -- Add sharing button to append current code to URL -- see [example on Auth0 docs](https://auth0-cosmos.vercel.app/#/playground) -- General cleanup of the code to meet team standards and reliability",2 -90357136,2021-07-15 20:55:24.985,Pajamas > Move contributing content,"## Problem - -- Recently the **Component lifecycle** content was updated, but it still remains the last item in the menu and could be elevated for more visibility. -- Under the **Contribute** menu heading there is a **Get started** page, but there is already a **Get started** navigation heading above. - -## Solution - -- Move the **Component lifecycle** page under the top **Get started** menu heading. -- Move the **Get started** page under the top **Get started** menu heading and rename the page to ""Contribute."" -- Remove the **Contribute** menu heading. -- Update any Pajamas links to point to the new pages. - -![CleanShot_2021-07-15_at_15.51.59_2x](/uploads/e9501d2bc4269ee76a96fe9ac64cb55b/CleanShot_2021-07-15_at_15.51.59_2x.png)",2 -90289738,2021-07-14 19:19:57.566,Regions > Add merge request reports,"## Purpose - -Add [merge request reports](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=38197%3A204050) to the **Regions** section of Pajamas. The initial content will come from the [Figma file](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=38197%3A204050). This is in preparation of the implementation phase for the MR widgets and having the SSoT in Pajamas.",2 -90287401,2021-07-14 18:11:48.454,"Follow-up from ""feat(Color): Add color theme notes""","The following discussion from !2460 should be addressed: - -- [ ] @jeldergl started a [discussion](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2460#note_625218336): (+6 comments) - - > Note: these changes (and others like it) were brought about by the lint job that runs during a commit. - ---- - -The changes in question was the removal of indentation for HTML within a markdown file. The indentation helps with nesting and understanding the code. Removing it makes the markup harder to read and understand.",1 -89872209,2021-07-07 03:12:00.014,Update Sidebar navigation component," - -### Description - - - -Updating the `Sidebar` component to match the direction of the navigation changes from %""14.0"" - -- Using the gray-900 color instead of having theme color influence the sidebar https://gitlab.com/gitlab-org/gitlab/-/issues/330467 -- Using the name `Infrastructure` instead of `Kubernetes` in instances to reflect https://gitlab.com/gitlab-org/gitlab/-/issues/334011 - -### Figma file - - - -[View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/3wLvv6JyQvhy07Jxkvc630/Component-library?node-id=3050%3A0) `update-sidebar-component` branch - -### Screenshots - -Variants - -| Before | After | -| ------ | ------ | -| ![image](/uploads/09701547d6b8b03ee1a32f4273042fd0/image.png) | ![image](/uploads/a0aed7fd48aa4851924daf691ad99c0b/image.png) | - -Instances - -| Before | After | -| ------ | ------ | -| ![image](/uploads/92de4216179a6d4983d028044a68bed7/image.png) | ![image](/uploads/8ea902918574292a8a156b2d984e558d/image.png) | - -### Checklist - -Make sure the following are completed before closing the issue: - -1. [x] **Assignee**: Design in your working file. When applicable, follow our - [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [FE/UX Foundations designer][foundations-team]. -1. [x] **Assignee**: Update the link to the working file in the issue - description. -1. [x] **Assignee**: Ask a [FE/UX Foundations designer][foundations-team] - to review your design (ensure they have edit permissions in Figma). -1. [x] **Reviewer**: Review and approve assignee’s design. Specific design - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer] - for final review (make sure they have edit permissions in Figma). -1. [x] **Maintainer**: Review and approve assignee’s changes. -1. [x] **Maintainer**: Add the changes or additions to the target file. For - example, you’d copy a final chart design from the working file and paste into the related location in the Data Visualization file. - 1. [x] Ensure that all styles and components now belong to the target file. - 1. [x] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [x] **Maintainer**: When applicable, [publish][publishing] any library - changes along with a clear commit message. -1. [x] **Assignee**: Move your working file to the shared Figma project: - 1. [ ] For Component Library changes, move your file to the [**Component archive**][component-archive] project. - 1. [ ] For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. [ ] If you’re a community contributor, we ask that you [transfer ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -1. [-] **Assignee** (or Maintainer, for community contributions): If it’s a new - pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [-] **Assignee**: When applicable, [create an MR in this repository][new-gitlab-ui-mr] and apply the ""component-guideline"" template - to create or update the component’s documentation page. If you do not have capacity, [create an issue in this repository using the ""Component documentation"" issue template][pajamas-component-documentation-template]. Bring the issue to your team planning session for prioritization and scheduling. Mark the new issue as related to this one. -1. [x] **Assignee**: When applicable, [create an issue in GitLab UI using the ""Component"" issue template][gitlab-ui-component-template] to build or update the component code. Bring the issue to your team planning session for prioritization and scheduling. Mark the new issue as related to this one. -1. [x] **Assignee**: 🎉 Congrats, you made it! You can now close this issue. - -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure -[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/.gitlab/merge_request_templates/component-guideline.md -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component -[pajamas-component-documentation-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation -[new-gitlab-ui-mr]: https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/new",2 -89563039,2021-06-30 19:40:55.756,Update component markdown template,"### Description - -Update the [example component documentation page template](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/pages/components/template.md) after https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2414 has been merged to reflect template updates. - -### Checklist - -Make sure the following are completed before closing the issue: - -1. [x] Assign the correct component label to this issue. -1. [x] Create an MR with the additions or updates needed. -1. [-] When applicable, [create a new Pajamas issue using the ""Figma update"" issue template][pajamas-figma-update-template] to update the component in Figma. Bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one. -1. [-] When applicable, [create an MR in GitLab UI][gitlab-ui-mr] to update the component. If you do not have capacity or are unable to update the component directly, [create a new GitLab UI issue using the ""Component""][gitlab-ui-component-template] issue template. Bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one. -1. [x] When introducing a major or breaking change, communicate the changes within the Engineering Week in Review and UX Weekly meeting. -1. [x] 🎉 Congrats, you made it! You can now close this issue. - - - -[gitlab-ui-mr]: https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/new -[component-lifecycle]: https://design.gitlab.com/contribute/lifecycle -[pajamas-figma-update-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Figma%20update -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component",1 -89489145,2021-06-29 15:26:55.709,Add bot warning for workflow label and weight,"## Purpose - -In https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/850 the UX Foundations team is working on adding workflow labels and weights to each issue. When a new issue is created there's no way for the author to know that a workflow label and weight should be added. - -The proposal is to have a bot notify the author to add the workflow label or weight, or to automatically add a label. - ---- - -Message: - -``` -Hi @[AUTHOR], - -Please add a [workflow label](https://about.gitlab.com/handbook/product-development-flow/) and [weight](https://about.gitlab.com/handbook/engineering/ux/ux-designer/#ux-weight-definitions) to your issue. This helps to categorize and locate issues in the future. - -Thanks for your help! :heart: - ---- - -You are welcome to help [improve this comment](LINK). -```",2 -89486695,2021-06-29 14:47:29.804,Evaluate VPAT against GitLab v14.0,"## Purpose - -In https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2434 we're updating the VPAT version to note that no material changes happened between 13.5 (date of current report) and 14.0. [More context](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1031) - -This effort evaluates 14.0 against the current VPAT report, makes any updates, and updates the version and report date in the VPAT.",2 -89416050,2021-06-28 14:55:53.428,Pajamas competitor analysis,"This issue is to discuss the possibility for doing competitor analysis for Pajamas. I think it will be valuable to do a lightweight version of the UX competitor analysis to gain insight into how we can continue to improve Pajamas, by taking a look at some other design systems. - -I think we have the opportunity to do something from scratch, I have heard from multiple designers that the current competitor analysis in UX is too in depth, perhaps we look at developing our own from scratch that's much simpler. - -- [ ] Determine whether doing a competitor analysis is useful - - [ ] Determine how a formal competitor analysis will be structured",1 -88894335,2021-06-17 16:53:34.548,Where should research insights live that impacts Pajamas?,"## Purpose - -In a recent 1:1 I brought up the idea of using the wiki feature in the Pajamas project to house research insights and more conversational reasoning behind decisions that impact components. From each component page we could link to the relevant section of the wiki. - -This brought up the need to address a few questions at a higher level before solutioning: - -- Where should research live and how should it be incorporated into Pajamas (if at all)? -- Is there still an insights repo that could be linked to? - -Currently, in https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2414 as part of the component page template update a new ""Reference"" section is being added with the intent to add links and commentary. - -The component page documentation should be direct, and we don't want to add to the overhead by having research links throughout that might be private or change. So where could we have a SSoT and how should we reference it?",1 -88587817,2021-06-11 16:13:24.805,Tree > Update docs to utilize new template,"## Background - -As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. - -## Resources - -See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. - -## Proposal - -Update the tree component usage tab to be in alignment with the changes. - -This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.",1 -88587816,2021-06-11 16:13:24.359,Tooltip > Update docs to utilize new template,"## Background - -As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. - -## Resources - -See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. - -## Proposal - -Update the tooltip component usage tab to be in alignment with the changes. - -This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.",1 -88587815,2021-06-11 16:13:24.058,Token > Update docs to utilize new template,"## Background - -As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. - -## Resources - -See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. - -## Proposal - -Update the token component usage tab to be in alignment with the changes. - -This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.",1 -88587814,2021-06-11 16:13:23.841,Toggle > Update docs to utilize new template,"## Background - -As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. - -## Resources - -See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. - -## Proposal - -Update the toggle component usage tab to be in alignment with the changes. - -This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.",1 -88587813,2021-06-11 16:13:23.597,Toast > Update docs to utilize new template,"## Background - -As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. - -## Resources - -See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. - -## Proposal - -Update the toast component usage tab to be in alignment with the changes. - -This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.",1 -88587811,2021-06-11 16:13:22.914,Tabs > Update docs to utilize new template,"## Background - -As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. - -## Resources - -See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. - -## Proposal - -Update the tabs component usage tab to be in alignment with the changes. - -This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.",1 -88587809,2021-06-11 16:13:21.965,Table > Update docs to utilize new template,"## Background - -As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. - -## Resources - -See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. - -## Proposal - -Update the table component usage tab to be in alignment with the changes. - -This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.",1 -88587808,2021-06-11 16:13:21.753,Spinner > Update docs to utilize new template,"## Background - -As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. - -## Resources - -See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. - -## Proposal - -Update the spinner component usage tab to be in alignment with the changes. - -This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.",1 -88587807,2021-06-11 16:13:21.385,Sorting > Update docs to utilize new template,"## Background - -As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. - -## Resources - -See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. - -## Proposal - -Update the sorting component usage tab to be in alignment with the changes. - -This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.",1 -88587806,2021-06-11 16:13:21.189,Socks > Update docs to utilize new template,"## Background - -As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. - -## Resources - -See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. - -## Proposal - -Update the socks component usage tab to be in alignment with the changes. - -This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.",1 -88587805,2021-06-11 16:13:20.977,Skeleton loader > Update docs to utilize new template,"## Background - -As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. - -## Resources - -See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. - -## Proposal - -Update the skeleton loader component usage tab to be in alignment with the changes. - -This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.",1 -88587804,2021-06-11 16:13:20.775,Segmented control > Update docs to utilize new template,"## Background - -As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. - -## Resources - -See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. - -## Proposal - -Update the segmented control component usage tab to be in alignment with the changes. - -This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.",1 -88587803,2021-06-11 16:13:20.495,Search > Update docs to utilize new template,"## Background - -As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. - -## Resources - -See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. - -## Proposal - -Update the search component usage tab to be in alignment with the changes. - -This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.",1 -88587802,2021-06-11 16:13:20.292,Radio button > Update docs to utilize new template,"## Background - -As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. - -## Resources - -See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. - -## Proposal - -Update the radio button component usage tab to be in alignment with the changes. - -This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.",1 -127230475,2023-04-26 19:42:12.971,UI kit > Clarify heading breakpoints,"## Description - -The breakpoint prefixes for heading styles can be perceived as available size options to be chosen from based on preference rather than sizes that need to be applied at a breakpoint. - -## Solution - -Make the size more verbose and clear by adding ""breakpoint"" and clarifying the range. - -[![Figmacon.svg](/uploads/010a2eef1c97a94289ff4ff4991b2aa1/Figmacon.svg) View in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/HHCrSCelPUHKKK0d1QViMT/%F0%9F%93%99-Component-library?t=tGJp4jMMw0kkjMQM-11) - -**Example**: - -| **Before** | **After** | -| ------ | ------ | -| `UI/h1/sm` | `UI/h1/≤md breakpoint` | -| `UI/h1/xl` | `UI/h1/≥xl breakpoint` | -| ![CleanShot_2023-04-27_at_10.16.36_2x](/uploads/9637733e5911a47c4eb65933652a4cb4/CleanShot_2023-04-27_at_10.16.36_2x.png) | ![CleanShot_2023-04-27_at_10.16.58_2x](/uploads/e2fb00375a46dfc51e2ab4e9a2952e5c/CleanShot_2023-04-27_at_10.16.58_2x.png) | - -## Checklist - -Make sure the following are completed before closing the issue: - -### Assignee tasks: - -
Getting started: - -1. [x] Title the issue using this structure ""Figma > [Component name] - [Description]"". For example, Figma > Badges - Fix icon override bug. -1. [x] Add the relevant [component label](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/labels?subscribed=&search=component%3A). For example ~""component:badge"". -1. [x] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. -1. [-] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. -1. [x] Update the link to the working file under the **Figma link** section below. -1. [x] If work was not done in a branch (a merged branch will automatically be archived), move your working file - to the shared Figma project: - 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. - 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360038512093) to the maintainer so they can move it to our archive, along with its version history and comments. -
- -
Prior to review: - -The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: - -1. [-] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** ( + Y) to reveal invisible objects. Use **View > Zoom to Fit** (Shift + 1) to view all items on the page. -1. [-] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. -1. [-] **Frames**: Make spacing within and between frames consistent with components found on other pages. -1. [-] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. -1. [-] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. -1. [-] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. -1. [x] **Comments**: Make sure all comments and discussion are resolved. - -
- -
Requesting a review: - -Ask a [Foundations designer][foundations-team] to review your design. - -1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma. -1. [x] From the dropdown to the right of the file name, select ""Request review"". -1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. -1. [x] Consider [creating a new version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Create_a_new_version) (optional) titled ""Review requested"" in the history which will create a reference point in the file's history. - -Once your file is in review, you should see a yellow ""In review"" badge to the right of the file name. - -
- -
Post review: -Once the Reviewer or Maintainer has approved your update, consider the following tasks: - -1. [-] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [-] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [-] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [x] 🎉 Congrats, you made it! You can now close this issue. - -
- -### Reviewer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [-] Make sure all layers are correctly named and organized. -1. [-] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. -1. [-] Ensure component descriptions and external documentation links are clear and accurate. -1. [x] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. -1. [x] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). -1. [x] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). - -
- -### Maintainer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s changes. - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] Consider adding a new version to the file's [version history](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history) to indicate the state prior to merging the changes. The name of the version and description of the changes are saved in the file history and provide a meaningful reference point. -1. [x] Merge the branch or add the changes or additions to the - target file. - 1. [ ] Ensure that all styles and components now belong to the target file. - 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message. -1. [x] If the file's version history isn't clear, [name the latest version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Name_an_existing_version) and update the details so it's clear what change had been made. - -
- -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=manage-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component -[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation - -",1 -126941915,2023-04-19 20:09:02.337,Labels and linking,"## Purpose - ->>In this context, the text “Code owners” isn't explicit that it navigates to the code owners file, because it's also used as a label for the list of code owners of the current file. -> -> @pedroms I think this is a great point and something we should evaluate — should a label be allowed to link? And how does visual label relate to `label` (which wouldn't necessarily make sense in this context)? At the moment this text only visually appears as a label, and nothing about it, other than the preceding ':' indicates as much, which is why I'm inclined to proceed. - -Per the discussion in https://gitlab.com/gitlab-org/gitlab/-/merge_requests/117251#note_1353052885, this issue is to discuss the following: - -- Should text that _appears_ as a label (although isn't actually a `label`) be allowed to link? - - If yes, what link variant is most appropriate? - -For example, the ""Code owners"" text in the following screenshot. - -![CleanShot_2023-04-19_at_15.11.48_2x](/uploads/dadb264ad9c9ed05fe91fca0e7abd923/CleanShot_2023-04-19_at_15.11.48_2x.png) - -## Next steps - -- Document a decision in Pajamas.",1 -126288606,2023-04-05 14:22:54.150,Figma > Dropdown - decrease min-width,"## Description - -Decrease the min-width of the dropdown by 8px (16rem → 15.5rem) so that it fits within the new sidebar navigation. - -This would have minimal, if any, impact on existing instances and may even slightly improve some where all option text is short. - -| **Before** | **After** | -| ------ | ------ | -| ![image](/uploads/dac60d1b393a00b17f0ecb914bc1af77/image.png) | ![image](/uploads/b2b73f4a7607d2cf69e2c0074bf2fbe1/image.png) | - -- [x] Update component and instances in Figma -- [x] Create an issue to update in GitLab UI - -### Figma file - - - -[❖ View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/n1QvO2JdlHIUUJUGsalyr0/%F0%9F%93%99-Component-library?t=EdntYrUvmvg1Uk3C-11) - -## Checklist - -Make sure the following are completed before closing the issue: - -### Assignee tasks: - -
Getting started: - -1. [x] Title the issue using this structure ""Figma > [Component name] - [Description]"". For example, Figma > Badges - Fix icon override bug. -1. [x] Add the relevant [component label](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/labels?subscribed=&search=component%3A). For example ~""component:badge"". -1. [x] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. -1. [x] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. -1. [x] Update the link to the working file under the **Figma link** section below. -1. [-] If work was not done in a branch (a merged branch will automatically be archived), move your working file - to the shared Figma project: - 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. - 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360038512093) to the maintainer so they can move it to our archive, along with its version history and comments. -
- -
Prior to review: - -The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: - -1. [x] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** ( + Y) to reveal invisible objects. Use **View > Zoom to Fit** (Shift + 1) to view all items on the page. -1. [-] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. -1. [x] **Frames**: Make spacing within and between frames consistent with components found on other pages. -1. [-] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. -1. [-] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. -1. [-] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. -1. [x] **Comments**: Make sure all comments and discussion are resolved. - -
- -
Requesting a review: - -Ask a [Foundations designer][foundations-team] to review your design. - -1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma. -1. [x] From the dropdown to the right of the file name, select ""Request review"". -1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. -1. [x] Consider [creating a new version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Create_a_new_version) (optional) titled ""Review requested"" in the history which will create a reference point in the file's history. - -Once your file is in review, you should see a yellow ""In review"" badge to the right of the file name. - -
- -
Post review: -Once the Reviewer or Maintainer has approved your update, consider the following tasks: - -1. [-] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [-] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [x] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [x] 🎉 Congrats, you made it! You can now close this issue. - -
- -### Reviewer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] Make sure all layers are correctly named and organized. -1. [x] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. -1. [x] Ensure component descriptions and external documentation links are clear and accurate. -1. [x] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. -1. [x] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). -1. [x] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). - -
- -### Maintainer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s changes. - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] Consider adding a new version to the file's [version history](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history) to indicate the state prior to merging the changes. The name of the version and description of the changes are saved in the file history and provide a meaningful reference point. -1. [x] Merge the branch or add the changes or additions to the - target file. - 1. [x] Ensure that all styles and components now belong to the target file. - 1. [x] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message. -1. [x] If the file's version history isn't clear, [name the latest version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Name_an_existing_version) and update the details so it's clear what change had been made. - -
- -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=manage-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component -[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation - -",2 -126156810,2023-04-03 09:25:19.835,Design tokens > Create page,"Create a placeholder page in Pajamas to point people towards when design tokens come up in conversation. - -This also provides a space for MRs to add a lightweight definition and document where we are starting and why.",1 -126018906,2023-03-30 21:43:35.918,Add new design-focused section to Pajamas,"## Purpose - -Create a new section in the Pajamas website to house DesignOps content and make the UI kit documentation more visible and structured. - -### Proposed structure - ---- - -**DesignOps** - -- Component lifecycle -- Pajamas UI Kit - - _Sections from the current md file…_ - - Release notes - ---- - -The content in https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md to this section to break it out into sub pages, make it available in Pajamas search, and have better formatting for visuals.",2 -124789766,2023-03-06 11:31:28.589,Link > Finalise design specs,"Issue to track efforts to finalise the design specs for links - -# Proposed link styles - -The following documents the intention, rather than the prescription for the actual CSS to be used. - -Class names placeholder to make it easier to read. - -There are certainly better ways to achieve the same thing. - -[Play with the styles in context in this codepen](https://codepen.io/danmh/pen/rNZGKbm). - -```scss - -// Inline links assumed the default - -a { - color: $blue-700; - text-decoration: underline; - text-decoration-color: rgba($blue-700, .72); // allows underline tone to match background - text-underline-offset: 2px; // we should make this a relative value, - // as it breaks when the browser font size is changed - transition: background-color 100ms linear, color 100ms linear, - border 100ms linear, text-decoration-color 100ms linear; - // builds on existing link transition styles, adds text-decoration-color - - &:hover { - color: $blue-800; - text-decoration: underline !important; // allows other link types to have underline on hover - // even if they have text-decoration: none for the rest state - text-decoration-color: currentColor; - } - - &:focus-visible { - color: $blue-800; - text-decoration: underline !important; - text-decoration-color: currentColor; - outline: 2px solid #428fdc; // existing focus styles - outline-offset: 2px; // existing focus styles - } - - &:active { - color: $blue-900; - text-decoration: underline; - text-decoration-color: currentColor; - transition: none; // makes the click or press feel snappy - } -} - -a.ui-link { - text-decoration: none; // no underline in rest state -} - -a.meta-link { - text-decoration: none; - - &.meta-link-dark { - color: $grey-900; - &:hover {color: $grey-950;} - &:active {color: $black;} - } - - &.meta-link-subdued { - color: $grey-700; - &:hover {color: $grey-800;} - &:active {color: $grey-900;} - } -} - -a.mention { - padding: 0 2px; // these are no change from existing styles - background-color: $blue-100; - border-radius: 4px; - text-decoration: none; - - &.mention-current { - background-color: $orange-100; - } -} -``` - -## Rational - -Why blue-700 -Why opacity -Why underline at all -etc -etc - -### Next - -- [ ] https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1551+ - -### Unblocks - -- [ ] https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/880+ -- [ ] https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1217+ -- [ ] https://gitlab.com/gitlab-org/gitlab-ui/-/issues/1084+ -- [ ] https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1536+ -- [ ] https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1554+ - - -### Related to - -- https://gitlab.com/gitlab-org/gitlab/-/issues/336819+",2 -124619714,2023-03-02 12:03:45.318,Add structure visual and list. for link,"### Description - - - -Add link structure diagram - -Related to: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1444+ - -### Checklist - -Make sure the following are completed before closing the issue: - -1. [x] Assign the correct component label to this issue. -1. [x] Create an MR with the additions or updates needed. -1. [~] When applicable, [create an issue using the `Figma update` issue template][pajamas-figma-update-template] to update the component in Figma, and mark it as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [~] When applicable, [create an MR in GitLab UI][gitlab-ui-mr] to update the component. If you do not have capacity or are unable to update the component directly, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template]. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one. -1. [~] When introducing a major or breaking change, communicate the changes within the Engineering Week in Review and UX Weekly meeting. -1. [ ] 🎉 Congrats, you made it! You can now close this issue. - - - -[gitlab-ui-mr]: https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/new -[component-lifecycle]: https://design.gitlab.com/get-started/lifecycle -[pajamas-figma-update-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Figma%20update -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component",1 -124074239,2023-02-21 18:18:30.834,Breadcrumb component updates,"# Breadcrumb - -The breadcrumb is a component that is less isolated than other components because it’s navigation based on the page it’s within, and is bound by the layout and behavior constructs of that page along with other content and functionality. - -Updates to the breadcrumb can’t happen without considering the impact to its own UX, and to the UX of the page in which it’s placed. For that reason, there are two parallel categories of considerations that have to be addressed: component-specific, and the relationship with other elements. - -## Component-specific - -
View details - -- Responsive - Wrapping and truncation - - Truncation based on width or character count? Both? - - Where truncation occurs in the string? - - At wider views, should we allow larger strings to be expanded, potentially creating an unwieldy string in primary real estate? -- States - - Interactive states, such as hover and focus - - Current page state -- Design spec updates (border, separator, states, etc.) -- Semantics and [accessibility updates](https://gitlab.com/groups/gitlab-org/-/epics/6879) for current implementation -- Migration - -**Deliverables:** - -- [Updated design specs](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1533) -- Updated Pajamas documentation -- Component updates in GitLab UI -- Component migration - -
- -## Relationship with other elements - -
View details - -- **[Navigation](https://gitlab.com/gitlab-org/gitlab-ui/-/issues/2141) — specifically the sidebar show/hide icon placement and behavior (priority)** -- DOM order with other elements, like alerts, banners, and broadcast messages -- Within [headers](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/3263) - - Sticky behavior - - Page actions -- Fluid and fixed width layout settings - -**Deliverables:** - -- **Navigation + breadcrumb requirements and specs (priority)** -- Identify and document potential patterns that use a breadcrumb -- Updated Pajamas documentation - -
- -## Resources - -- [A collection of 40+ breadcrumb components from various design systems](https://arc.net/e/F3F0AA49-51B1-4254-BD21-A450640C83E1) -- [Pajamas > Breadcrumb](https://design.gitlab.com/components/breadcrumb) -- [GitLab UI > Breadcrumb](https://gitlab-org.gitlab.io/gitlab-ui/?path=/story/base-breadcrumb--default)",5 -123176841,2023-02-07 07:51:38.155,Dropdown > Document height options,"### Description - -Document height options (fit contents height vs. fixed height). There are use cases where we want the dropdown to shrink to it's content (fit contents) and others where we want to keep its initial height (fixed height). - -| Contents size | Keep initial height | -| ------ | ------ | -| ![image](/uploads/79f6e6c264a0dce355312c72599dc237/image.png) | ![image](/uploads/d3d6b212f69cc7da039ccde5184051cc/image.png) | - -### Checklist - -Make sure the following are completed before closing the issue: - -1. [X] Assign the correct component label to this issue. -1. [ ] Create an MR with the additions or updates needed. -1. [ ] When applicable, [create an issue using the `Figma update` issue template][pajamas-figma-update-template] to update the component in Figma, and mark it as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [ ] When applicable, [create an MR in GitLab UI][gitlab-ui-mr] to update the component. If you do not have capacity or are unable to update the component directly, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template]. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one. -1. [ ] When introducing a major or breaking change, communicate the changes within the Engineering Week in Review and UX Weekly meeting. -1. [ ] 🎉 Congrats, you made it! You can now close this issue. - - - -[gitlab-ui-mr]: https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/new -[component-lifecycle]: https://design.gitlab.com/get-started/lifecycle -[pajamas-figma-update-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Figma%20update -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component",1 -122956530,2023-02-02 17:03:00.874,"fix: Add missing ""Contribute"" tabs","## Purpose - -Some component pages are missing the ""Contribute"" tab.",2 -122852029,2023-02-01 15:14:25.849,Figma > Button - Add states,"## Description - -This MR adds missing states to the main components (hover, focus, active). - -### Figma file - -[❖ View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/4VRjxqlOB94BomdQfBNioe/%F0%9F%93%99-Component-library?node-id=425%3A7&t=XFUiIlIv43Z2bxqU-11) - -## Checklist - -Make sure the following are completed before closing the issue: - -### Assignee tasks: - -
Getting started: - -1. [X] Title the issue using this structure ""Figma > [Component name] - [Description]"". For example, Figma > Badges - Fix icon override bug. -1. [X] Add the relevant [component label](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/labels?subscribed=&search=component%3A). For example ~""component:badge"". -1. [X] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. -1. [X] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. -1. [x] Update the link to the working file under the **Figma link** section below. -1. [x] If work was not done in a branch (a merged branch will automatically be archived), move your working file - to the shared Figma project: - 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. - 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360038512093) to the maintainer so they can move it to our archive, along with its version history and comments. -
- -
Prior to review: - -The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: - -1. [x] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** ( + Y) to reveal invisible objects. Use **View > Zoom to Fit** (Shift + 1) to view all items on the page. -1. [x] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. -1. [x] **Frames**: Make spacing within and between frames consistent with components found on other pages. -1. [x] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. -1. [x] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. -1. [x] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. -1. [x] **Comments**: Make sure all comments and discussion are resolved. - -
- -
Requesting a review: - -Ask a [Foundations designer][foundations-team] to review your design. - -1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma. -1. [x] From the dropdown to the right of the file name, select ""Request review"". -1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. -1. [x] Consider [creating a new version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Create_a_new_version) (optional) titled ""Review requested"" in the history which will create a reference point in the file's history. - -Once your file is in review, you should see a yellow ""In review"" badge to the right of the file name. - -
- -
Post review: -Once the Reviewer or Maintainer has approved your update, consider the following tasks: - -1. [x] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [x] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [x] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [x] 🎉 Congrats, you made it! You can now close this issue. - -
- -### Reviewer tasks: - -
See tasks: - -1. [ ] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [ ] Make sure all layers are correctly named and organized. -1. [ ] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. -1. [ ] Ensure component descriptions and external documentation links are clear and accurate. -1. [ ] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. -1. [ ] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). -1. [ ] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). - -
- -### Maintainer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s changes. - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] Consider adding a new version to the file's [version history](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history) to indicate the state prior to merging the changes. The name of the version and description of the changes are saved in the file history and provide a meaningful reference point. -1. [x] Merge the branch or add the changes or additions to the - target file. - 1. [ ] Ensure that all styles and components now belong to the target file. - 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message. -1. [x] If the file's version history isn't clear, [name the latest version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Name_an_existing_version) and update the details so it's clear what change had been made. - -
- -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=manage-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component -[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation - -",1 -122830518,2023-02-01 10:46:33.881,Figma > Toggle - Add states,"## Description - -This MR adds the missing states to the badge component. - -| Before | After | -| ------ | ------ | -| ![image](/uploads/7a40accf6d25e1528a7fcf4cd8bf2755/image.png) | ![image](/uploads/11a641db0eeb9e9a2dc3b51f84dfb24c/image.png) | - -### Figma file - -[❖ View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/QXWDiFqaiOZVtKXdheEc49/%F0%9F%93%99-Component-library?node-id=425%3A140&t=WDnJTGhTFcT4t2TZ-11) - -## Checklist - -Make sure the following are completed before closing the issue: - -### Assignee tasks: - -
Getting started: - -1. [X] Title the issue using this structure ""Figma > [Component name] - [Description]"". For example, Figma > Badges - Fix icon override bug. -1. [X] Add the relevant [component label](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/labels?subscribed=&search=component%3A). For example ~""component:badge"". -1. [x] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. -1. [x] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. -1. [x] Update the link to the working file under the **Figma link** section below. -1. [x] If work was not done in a branch (a merged branch will automatically be archived), move your working file - to the shared Figma project: - 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. - 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360038512093) to the maintainer so they can move it to our archive, along with its version history and comments. -
- -
Prior to review: - -The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: - -1. [x] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** ( + Y) to reveal invisible objects. Use **View > Zoom to Fit** (Shift + 1) to view all items on the page. -1. [x] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. -1. [x] **Frames**: Make spacing within and between frames consistent with components found on other pages. -1. [x] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. -1. [x] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. -1. [x] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. -1. [x] **Comments**: Make sure all comments and discussion are resolved. - -
- -
Requesting a review: - -Ask a [Foundations designer][foundations-team] to review your design. - -1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma. -1. [x] From the dropdown to the right of the file name, select ""Request review"". -1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. -1. [ ] Consider [creating a new version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Create_a_new_version) (optional) titled ""Review requested"" in the history which will create a reference point in the file's history. - -Once your file is in review, you should see a yellow ""In review"" badge to the right of the file name. - -
- -
Post review: -Once the Reviewer or Maintainer has approved your update, consider the following tasks: - -1. [-] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [-] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [x] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [x] 🎉 Congrats, you made it! You can now close this issue. - -
- -### Reviewer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] Make sure all layers are correctly named and organized. -1. [x] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. -1. [x] Ensure component descriptions and external documentation links are clear and accurate. -1. [x] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. -1. [x] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). -1. [x] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). - -
- -### Maintainer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s changes. - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [-] Consider adding a new version to the file's [version history](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history) to indicate the state prior to merging the changes. The name of the version and description of the changes are saved in the file history and provide a meaningful reference point. -1. [x] Merge the branch or add the changes or additions to the - target file. - 1. [ ] Ensure that all styles and components now belong to the target file. - 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message. -1. [x] If the file's version history isn't clear, [name the latest version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Name_an_existing_version) and update the details so it's clear what change had been made. - -
- -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=manage-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component -[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation - -",1 -122729768,2023-01-31 05:05:26.187,Update inline text link hover/focus style to align with docs,From !3205 We currently don't change the color for inline text links on design.gitlab.com so this might be something we should update to align with guidance here in later iterations.,1 -122515620,2023-01-26 21:30:20.938,Figma > Tertiary button multiply,"## Description - -The tertiary buttons use `mix-blend-mode: multiply` ([source](https://gitlab.com/gitlab-org/gitlab-ui/-/blob/main/src/components/base/button/button.scss#L326)) to keep contrast consistent when on different background colors. This updates them in the UI kit to match. - - - -### Figma file - - - -[❖ View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/TT1EM05P5ALuyJv017MFXf/%F0%9F%93%99-Component-library?node-id=425%3A7&t=qOSChFXfSNeeKAdK-11) - -## Checklist - -Make sure the following are completed before closing the issue: - -### Assignee tasks: - -
Getting started: - -1. [x] Title the issue using this structure ""Figma > [Component name] - [Description]"". For example, Figma > Badges - Fix icon override bug. -1. [x] Add the relevant [component label](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/labels?subscribed=&search=component%3A). For example ~""component:badge"". -1. [x] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. -1. [-] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. -1. [x] Update the link to the working file under the **Figma link** section below. -1. [-] If work was not done in a branch (a merged branch will automatically be archived), move your working file - to the shared Figma project: - 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. - 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -
- -
Prior to review: - -The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: - -1. [x] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** ( + Y) to reveal invisible objects. Use **View > Zoom to Fit** (Shift + 1) to view all items on the page. -1. [-] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. -1. [-] **Frames**: Make spacing within and between frames consistent with components found on other pages. -1. [ ] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. -1. [-] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. -1. [-] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. -1. [x] **Comments**: Make sure all comments and discussion are resolved. - -If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference. - -
- -
Requesting a review: - -Ask a [Foundations designer][foundations-team] to review your design. - -1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma. -1. [x] From the dropdown to the right of the file name, select ""Request review"". -1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. -1. [-] Consider [creating a new version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Create_a_new_version) (optional) titled ""Review requested"" in the history which will create a reference point in the file's history. - -Once your file is in review, you should see a yellow ""In review"" badge to the right of the file name. - -
- -
Post review: -Once the Reviewer or Maintainer has approved your update, consider the following tasks: - -1. [ ] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [ ] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [ ] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [x] 🎉 Congrats, you made it! You can now close this issue. - -
- -### Reviewer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] Make sure all layers are correctly named and organized. -1. [x] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. -1. [x] Ensure component descriptions and external documentation links are clear and accurate. -1. [x] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. -1. [x] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). -1. [-] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). - -
- -### Maintainer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s changes. - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [ ] Consider adding a new version to the file's [version history](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history) to indicate the state prior to merging the changes. The name of the version and description of the changes are saved in the file history and provide a meaningful reference point. -1. [x] Merge the branch or add the changes or additions to the - target file. - 1. [ ] Ensure that all styles and components now belong to the target file. - 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message. -1. [ ] If the file's version history isn't clear, [name the latest version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Name_an_existing_version) and update the details so it's clear what change had been made. - -
- -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component -[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation - -",1 -122318319,2023-01-23 17:42:41.455,Dropdown > Update design spec to include min/max width,"## Purpose - -Based on the implementation plan in https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1507#implementation-plan, the **dropdown** design specs should be updated to include the recommended minimum and maximum widths. - -This doesn't have to be a component setting, but that is an option if the configuration is easy enough to implement and the design experience isn't impacted. - -## Specs - -Make dropdown's width more flexible: - -* [x] min-width: 16rem (256px) -* [x] max-width: 28.5rem (456px) -* [x] max-height: 19.5rem (312px)",2 -121186565,2023-01-03 19:31:36.320,Broadcast message > Update variants and instances,"## Description - -Updating the broadcast message component in Figma to: - -- Better account for fixed vs. fluid layout behavior. - - Max-width (954px) is calculated based on the [990px fixed width](https://design.gitlab.com/product-foundations/layout#fixed-layout) minus 16px margin on each side. -- Add description for each variants. Description is visible in the properties panel when an instance is selected. -- Add ability to toggle × close icon. -- Add instances for different states and [example] themes. -- Remove unnecessary todo and note. - -The changes are modeled after what's currently in place for the [alert component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/%F0%9F%93%99-Component-library?node-id=425%3A1&t=zd18xI1uNlssCjAi-11). - -### Figma file - - - -[❖ View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/J0xjeC3YBsx0AeJJx3cGf7/%F0%9F%93%99-Component-library?t=mg4lYg8ii8OcZgwZ-11) - -## Checklist - -Make sure the following are completed before closing the issue: - -### Assignee tasks: - -
Getting started: - -1. [x] Title the issue using this structure ""Figma > [Component name] - [Description]"". For example, Figma > Badges - Fix icon override bug. -1. [x] Add the relevant [component label](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/labels?subscribed=&search=component%3A). For example ~""component:badge"". -1. [x] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. -1. [x] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. -1. [x] Update the link to the working file under the **Figma link** section below. -1. [-] If work was not done in a branch (a merged branch will automatically be archived), move your working file - to the shared Figma project: - 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. - 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -
- -
Prior to review: - -The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: - -1. [x] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** ( + Y) to reveal invisible objects. Use **View > Zoom to Fit** (Shift + 1) to view all items on the page. -1. [x] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. -1. [x] **Frames**: Make spacing within and between frames consistent with components found on other pages. -1. [x] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. -1. [x] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. -1. [x] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. -1. [x] **Comments**: Make sure all comments and discussion are resolved. - -If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference. - -
- -
Requesting a review: - -Ask a [Foundations designer][foundations-team] to review your design. - -1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma. -1. [x] From the dropdown to the right of the file name, select ""Request review"". -1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. -1. [ ] Consider [creating a new version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Create_a_new_version) (optional) titled ""Review requested"" in the history which will create a reference point in the file's history. - -Once your file is in review, you should see a yellow ""In review"" badge to the right of the file name. - -
- -
Post review: -Once the Reviewer or Maintainer has approved your update, consider the following tasks: - -1. [ ] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [ ] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [ ] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [x] 🎉 Congrats, you made it! You can now close this issue. - -
- -### Reviewer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] Make sure all layers are correctly named and organized. -1. [x] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. -1. [x] Ensure component descriptions and external documentation links are clear and accurate. -1. [x] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. -1. [x] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). -1. [x] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). - -
- -### Maintainer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s changes. - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [ ] Consider adding a new version to the file's [version history](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history) to indicate the state prior to merging the changes. The name of the version and description of the changes are saved in the file history and provide a meaningful reference point. -1. [x] Merge the branch or add the changes or additions to the - target file. - 1. [x] Ensure that all styles and components now belong to the target file. - 1. [x] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message. -1. [ ] If the file's version history isn't clear, [name the latest version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Name_an_existing_version) and update the details so it's clear what change had been made. - -
- -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component -[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation - -",1 -121174687,2023-01-03 16:25:24.204,"Dropdown > Direction for rendering overflowing, non-wrapping text within items","In some cases, we might need to display long non-wrapping texts within a dropdown's items. For example, the notification settings display the user's emails, which might overflow the dropdown menu: - -![Screenshot_2023-01-03_at_8.41.24_AM](/uploads/5ca3d1a413d52a539ce89f18ad5e5e4e/Screenshot_2023-01-03_at_8.41.24_AM.png) - -## Implementation plan - -- [ ] `GlTruncate`: ensure the rendered element has an accessible `aria-label` attribute. -- [ ] `GlCollapsibleListbox` - - [ ] Make dropdown's width more flexible: - - [ ] `min-width: 15rem` - - [ ] `max-width: 28.5rem` - - [ ] Leverage `GlTruncate` to truncate long items' names. This should be probably be the consumer's responsibility, so this can be a recommendation in the docs. -- [ ] Ensure the notifications settings render properly as per https://gitlab.com/gitlab-org/gitlab/-/issues/373843#note_1227467886.",2 -120713314,2022-12-20 20:03:20.601,Figma > File uploader enhancements,"## Description - -Address the following items from https://gitlab.com/gitlab-org/gitlab-ui/-/issues/297: - -
Component overrides - -### Component property user experience - -#### Conditional properties - -Changing some of the component properties can override previously selected options. - -![Kapture_2022-11-30_at_15.19.17](/uploads/ff617a5bfb49c1054ef5bb697db961cf/Kapture_2022-11-30_at_15.19.17.gif) - -There is opportunity to improve the user experience here by only showing properties relevant to the selected variation. - -#### Retaining overrides - -Some overrides are not retained when switching versions - -![Kapture_2022-11-30_at_15.22.57](/uploads/e9a020087165a8d6bf15b796219edbb4/Kapture_2022-11-30_at_15.22.57.gif) - -
- -
Recreating the current UI - -### Recreating the current UI - -Using this component it is not possible to recreate the current UI. - -![Kapture_2022-11-30_at_15.26.26](/uploads/7055daa9f66fad5173f801cb439a3885/Kapture_2022-11-30_at_15.26.26.gif) - -
- -
Slider considerations - -Moved to it's own issue -> https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1511+ - -
- -### Figma file - - - -[❖ View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/ccOwOGUNWttGmmMalGjzMQ/%F0%9F%93%99-Component-library?node-id=8000%3A0&t=OsyuPWkvpYs3s9jK-11) - -![CleanShot_2022-12-20_at_14.01.51_2x](/uploads/9f073beb69617b24bea4f703e2dbde79/CleanShot_2022-12-20_at_14.01.51_2x.png) - -## Checklist - -Make sure the following are completed before closing the issue: - -### Assignee tasks: - -
Getting started: - -1. [x] Title the issue using this structure ""Figma > [Component name] - [Description]"". For example, Figma > Badges - Fix icon override bug. -1. [x] Add the relevant [component label](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/labels?subscribed=&search=component%3A). For example ~""component:badge"". -1. [x] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. -1. [x] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. -1. [x] Update the link to the working file under the **Figma link** section below. -1. [x] If work was not done in a branch (a merged branch will automatically be archived), move your working file - to the shared Figma project: - 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. - 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -
- -
Prior to review: - -The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: - -1. [x] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** ( + Y) to reveal invisible objects. Use **View > Zoom to Fit** (Shift + 1) to view all items on the page. -1. [x] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. -1. [x] **Frames**: Make spacing within and between frames consistent with components found on other pages. -1. [x] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. -1. [x] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. -1. [x] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. -1. [x] **Comments**: Make sure all comments and discussion are resolved. - -If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference. - -
- -
Requesting a review: - -Ask a [Foundations designer][foundations-team] to review your design. - -1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma. -1. [x] From the dropdown to the right of the file name, select ""Request review"". -1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. -1. [ ] Consider [creating a new version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Create_a_new_version) (optional) titled ""Review requested"" in the history which will create a reference point in the file's history. - -Once your file is in review, you should see a yellow ""In review"" badge to the right of the file name. - -
- -
Post review: -Once the Reviewer or Maintainer has approved your update, consider the following tasks: - -1. [ ] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [x] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [x] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [x] 🎉 Congrats, you made it! You can now close this issue. - -
- -### Reviewer tasks: - -
See tasks: - -1. [ ] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [ ] Make sure all layers are correctly named and organized. -1. [ ] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. -1. [ ] Ensure component descriptions and external documentation links are clear and accurate. -1. [ ] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. -1. [ ] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). -1. [ ] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). - -
- -### Maintainer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s changes. - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] Consider adding a new version to the file's [version history](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history) to indicate the state prior to merging the changes. The name of the version and description of the changes are saved in the file history and provide a meaningful reference point. -1. [x] Merge the branch or add the changes or additions to the - target file. - 1. [x] Ensure that all styles and components now belong to the target file. - 1. [x] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message. -1. [x] If the file's version history isn't clear, [name the latest version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Name_an_existing_version) and update the details so it's clear what change had been made. - -
- -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component -[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation - -",2 -120437029,2022-12-14 21:43:28.735,Figma > Form elements remove warning state,"## Description - -The warning (orange) state for form elements isn't present in GitLab UI, and it was determined that there isn't a need for it via https://gitlab.com/gitlab-org/gitlab-ui/-/issues/1809. - -This issue is to remove the warning state from the form elements in Figma, and to remove any mention of it Pajamas. - -### Figma file - - - -[❖ View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/qnl2lq49gLpti4TFUCNlhm/%F0%9F%93%99-Component-library?node-id=49840%3A75722&t=0qOhvYOSwOznoAf7-11) - -## Checklist - -Make sure the following are completed before closing the issue: - -### Assignee tasks: - -
Getting started: - -1. [x] Title the issue using this structure ""Figma > [Component name] - [Description]"". For example, Figma > Badges - Fix icon override bug. -1. [x] Add the relevant [component label](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/labels?subscribed=&search=component%3A). For example ~""component:badge"". -1. [x] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. -1. [-] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. -1. [x] Update the link to the working file under the **Figma link** section below. -1. [-] If work was not done in a branch (a merged branch will automatically be archived), move your working file - to the shared Figma project: - 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. - 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -
- -
Prior to review: - -The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: - -1. [x] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** ( + Y) to reveal invisible objects. Use **View > Zoom to Fit** (Shift + 1) to view all items on the page. -1. [-] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. -1. [-] **Frames**: Make spacing within and between frames consistent with components found on other pages. -1. [-] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. -1. [-] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. -1. [-] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. -1. [ ] **Comments**: Make sure all comments and discussion are resolved. - -If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference. - -
- -
Requesting a review: - -Ask a [Foundations designer][foundations-team] to review your design. - -1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma. -1. [x] From the dropdown to the right of the file name, select ""Request review"". -1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. -1. [ ] Consider [creating a new version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Create_a_new_version) (optional) titled ""Review requested"" in the history which will create a reference point in the file's history. - -Once your file is in review, you should see a yellow ""In review"" badge to the right of the file name. - -
- -
Post review: -Once the Reviewer or Maintainer has approved your update, consider the following tasks: - -1. [ ] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [ ] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [ ] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [ ] 🎉 Congrats, you made it! You can now close this issue. - -
- -### Reviewer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] Make sure all layers are correctly named and organized. -1. [x] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. -1. [x] Ensure component descriptions and external documentation links are clear and accurate. -1. [x] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. -1. [x] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). -1. [ ] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). - -
- -### Maintainer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s changes. - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] Consider adding a new version to the file's [version history](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history) to indicate the state prior to merging the changes. The name of the version and description of the changes are saved in the file history and provide a meaningful reference point. -1. [x] Merge the branch or add the changes or additions to the - target file. - 1. [ ] Ensure that all styles and components now belong to the target file. - 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message. -1. [x] If the file's version history isn't clear, [name the latest version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Name_an_existing_version) and update the details so it's clear what change had been made. - -
- -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component -[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation - -",2 -120174557,2022-12-09 19:05:39.341,Figma > Tooltip – Update tooltip component to resize based on content,"## Description - -The tooltip component currently doesn't resize based on content. Additionally, if you change the tip position, the content isn’t persisted. See [discussion in Slack](https://gitlab.slack.com/archives/CNDGX396C/p1670605977187449) and example: - -![Kapture_2022-12-09_at_11.12.03](/uploads/365dd3e332c3d83c3144d6906a2420af/Kapture_2022-12-09_at_11.12.03.mp4) - -We should update the component to fix these issues. - - - - - -### Figma file - - - -[❖ View working file in Figma →](https://www.figma.com/file/UXgoH1IanB4jxRctxXEt50/%231469-tooltip-resize-danmh?node-id=425-142) - -## Checklist - -Make sure the following are completed before closing the issue: - -### Assignee tasks: - -
Getting started: - -1. [x] Title the issue using this structure ""Figma > [Component name] - [Description]"". For example, Figma > Badges - Fix icon override bug. -1. [x] Add the relevant [component label](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/labels?subscribed=&search=component%3A). For example ~""component:badge"". -1. [x] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. -1. [x] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. -1. [x] Update the link to the working file under the **Figma link** section below. -1. [~] If work was not done in a branch (a merged branch will automatically be archived), move your working file - to the shared Figma project: - 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. - 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -
- -
Prior to review: - -The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: - -1. [x] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** ( + Y) to reveal invisible objects. Use **View > Zoom to Fit** (Shift + 1) to view all items on the page. -1. [x] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. -1. [x] **Frames**: Make spacing within and between frames consistent with components found on other pages. -1. [x] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. -1. [x] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. -1. [x] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. -1. [x] **Comments**: Make sure all comments and discussion are resolved. - -If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference. - -
- -
Requesting a review: - -Ask a [Foundations designer][foundations-team] to review your design. - -1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma. -1. [x] From the dropdown to the right of the file name, select ""Request review"". -1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. -1. [x] Consider [creating a new version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Create_a_new_version) (optional) titled ""Review requested"" in the history which will create a reference point in the file's history. - -Once your file is in review, you should see a yellow ""In review"" badge to the right of the file name. - -
- -
Post review: -Once the Reviewer or Maintainer has approved your update, consider the following tasks: - -1. [ ] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [x] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [x] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [x] 🎉 Congrats, you made it! You can now close this issue. - -
- -### Reviewer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] Make sure all layers are correctly named and organized. -1. [x] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. -1. [x] Ensure component descriptions and external documentation links are clear and accurate. -1. [x] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. -1. [x] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). -1. [x] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). - -
- -### Maintainer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s changes. - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] Consider adding a new version to the file's [version history](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history) to indicate the state prior to merging the changes. The name of the version and description of the changes are saved in the file history and provide a meaningful reference point. -1. [x] Merge the branch or add the changes or additions to the - target file. - 1. [x] Ensure that all styles and components now belong to the target file. - 1. [x] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message. -1. [x] If the file's version history isn't clear, [name the latest version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Name_an_existing_version) and update the details so it's clear what change had been made. - -
- -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component -[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation - -",2 -119333804,2022-11-24 14:14:01.574,Figma > Pagination - Refactor component,"## Description - -Refactored the Pagination component to use Variants for the pagination items. Also updated the focus style of the component. - -### Figma file - -[❖ View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/LbJ6WDv08Iznll87TfoOin/%F0%9F%93%99-Component-library?node-id=425%3A130&t=4ijE7d28kTS0Ys92-0) - -## Checklist - -Make sure the following are completed before closing the issue: - -### Assignee tasks: - -
Getting started: - -1. [x] Title the issue using this structure ""Figma > [Component name] - [Description]"". For example, Figma > Badges - Fix icon override bug. -1. [x] Add the relevant [component label](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/labels?subscribed=&search=component%3A). For example ~""component:badge"". -1. [x] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. -1. [x] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. -1. [x] Update the link to the working file under the **Figma link** section below. -1. [x] If work was not done in a branch (a merged branch will automatically be archived), move your working file - to the shared Figma project: - 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. - 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -
- -
Prior to review: - -The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: - -1. [x] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** ( + Y) to reveal invisible objects. Use **View > Zoom to Fit** (Shift + 1) to view all items on the page. -1. [x] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. -1. [x] **Frames**: Make spacing within and between frames consistent with components found on other pages. -1. [x] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. -1. [x] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. -1. [x] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. -1. [x] **Comments**: Make sure all comments and discussion are resolved. - -If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference. - -
- -
Requesting a review: - -Ask a [Foundations designer][foundations-team] to review your design. - -1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma. -1. [x] From the dropdown to the right of the file name, select ""Request review"". -1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. -1. [ ] Consider [creating a new version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Create_a_new_version) (optional) titled ""Review requested"" in the history which will create a reference point in the file's history. - -Once your file is in review, you should see a yellow ""In review"" badge to the right of the file name. - -
- -
Post review: -Once the Reviewer or Maintainer has approved your update, consider the following tasks: - -1. [x] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [x] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [x] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [x] 🎉 Congrats, you made it! You can now close this issue. - -
- -### Reviewer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] Make sure all layers are correctly named and organized. -1. [x] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. -1. [x] Ensure component descriptions and external documentation links are clear and accurate. -1. [x] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. -1. [x] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). -1. [x] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). - -
- -### Maintainer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s changes. - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] Merge the branch or add the changes or additions to the - target file. - 1. [ ] Ensure that all styles and components now belong to the target file. - 1. [x] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message. - -
- -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component -[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation - -",2 -119246695,2022-11-23 10:16:26.707,Figma > Dropbutton - Friendly text first,"## Description - -This is a follow-up to https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1465+ and updates the Dropbutton component to use the friendly text first for filters. - -### Figma file - - - -[❖ View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/NJNiIFOFovDtXJWmMHQY16/%F0%9F%93%99-Component-library?node-id=65182%3A99209&t=Pj6CvbqbaGv71jCQ-1) - -## Checklist - -Make sure the following are completed before closing the issue: - -### Assignee tasks: - -
Getting started: - -1. [x] Title the issue using this structure ""Figma > [Component name] - [Description]"". For example, Figma > Badges - Fix icon override bug. -1. [x] Add the relevant [component label](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/labels?subscribed=&search=component%3A). For example ~""component:badge"". -1. [x] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. -1. [x] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. -1. [x] Update the link to the working file under the **Figma link** section below. -1. [x] If work was not done in a branch (a merged branch will automatically be archived), move your working file - to the shared Figma project: - 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. - 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -
- -
Prior to review: - -The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: - -1. [x] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** ( + Y) to reveal invisible objects. Use **View > Zoom to Fit** (Shift + 1) to view all items on the page. -1. [x] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. -1. [x] **Frames**: Make spacing within and between frames consistent with components found on other pages. -1. [x] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. -1. [x] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. -1. [x] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. -1. [x] **Comments**: Make sure all comments and discussion are resolved. - -If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference. - -
- -
Requesting a review: - -Ask a [Foundations designer][foundations-team] to review your design. - -1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma. -1. [x] From the dropdown to the right of the file name, select ""Request review"". -1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. -1. [x] Consider [creating a new version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Create_a_new_version) (optional) titled ""Review requested"" in the history which will create a reference point in the file's history. - -Once your file is in review, you should see a yellow ""In review"" badge to the right of the file name. - -
- -
Post review: -Once the Reviewer or Maintainer has approved your update, consider the following tasks: - -1. [ ] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [ ] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [ ] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [x] 🎉 Congrats, you made it! You can now close this issue. - -
- -### Reviewer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [ ] Make sure all layers are correctly named and organized. -1. [ ] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. -1. [ ] Ensure component descriptions and external documentation links are clear and accurate. -1. [x] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. -1. [x] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). -1. [x] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). - -
- -### Maintainer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s changes. - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] Merge the branch or add the changes or additions to the - target file. - 1. [ ] Ensure that all styles and components now belong to the target file. - 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message. - -
- -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component -[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation - -",1 -119246302,2022-11-23 10:10:08.478,Figma > Token - Update Focus,"## Description - -Updates the focus to make use of the focus helper component. - -### Figma file - - - -[❖ View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/v4EklPE0xEbS54bngpqjgx/%F0%9F%93%99-Component-library?node-id=425%3A141&t=1OP5Fz5ygJ9NcnCr-0) - -## Checklist - -Make sure the following are completed before closing the issue: - -### Assignee tasks: - -
Getting started: - -1. [x] Title the issue using this structure ""Figma > [Component name] - [Description]"". For example, Figma > Badges - Fix icon override bug. -1. [x] Add the relevant [component label](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/labels?subscribed=&search=component%3A). For example ~""component:badge"". -1. [x] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. -1. [x] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. -1. [x] Update the link to the working file under the **Figma link** section below. -1. [x] If work was not done in a branch (a merged branch will automatically be archived), move your working file - to the shared Figma project: - 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. - 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -
- -
Prior to review: - -The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: - -1. [x] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** ( + Y) to reveal invisible objects. Use **View > Zoom to Fit** (Shift + 1) to view all items on the page. -1. [x] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. -1. [x] **Frames**: Make spacing within and between frames consistent with components found on other pages. -1. [x] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. -1. [x] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. -1. [x] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. -1. [x] **Comments**: Make sure all comments and discussion are resolved. - -If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference. - -
- -
Requesting a review: - -Ask a [Foundations designer][foundations-team] to review your design. - -1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma. -1. [x] From the dropdown to the right of the file name, select ""Request review"". -1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. -1. [x] Consider [creating a new version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Create_a_new_version) (optional) titled ""Review requested"" in the history which will create a reference point in the file's history. - -Once your file is in review, you should see a yellow ""In review"" badge to the right of the file name. - -
- -
Post review: -Once the Reviewer or Maintainer has approved your update, consider the following tasks: - -1. [x] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [x] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [x] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [x] 🎉 Congrats, you made it! You can now close this issue. - -
- -### Reviewer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] Make sure all layers are correctly named and organized. -1. [x] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. -1. [x] Ensure component descriptions and external documentation links are clear and accurate. -1. [x] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. -1. [x] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). -1. [x] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). - -
- -### Maintainer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s changes. - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] Merge the branch or add the changes or additions to the - target file. - 1. [ ] Ensure that all styles and components now belong to the target file. - 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message. - -
- -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component -[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation - -",1 -118936476,2022-11-17 19:57:44.973,Button > Add note about icon indicating action,"## Purpose - -Icon only buttons shouldn't act as a toggle where the icon might change depending on state. For example, ![eye.svg](/uploads/8d7f9c533374ec1ef07ab58fcfbc184f/eye.svg) changing to ![eye-slash.svg](/uploads/c8cdb864cae90e67f1534b8d2f527f92/eye-slash.svg) on click because the state can be confusing. Does it mean that the current state is A and clicking goes to B, or the opposite? - -This issue is to initiate documenting the recommendation.",1 -118776570,2022-11-15 22:42:35.204,Update severity guides for errors,"## Purpose - -In https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/contents/usability/error-prevention.md?plain=1#L13 there's reference to old button content that can be updated. Along with the the entire section will reviewed to make sure it's accurate. - ->The destructive action can easily be undone and no actual data was lost. Consider adding no friction at all in order to streamline the interface, especially in places where the action needs to be performed in bulk. These kinds of destructive actions can be exempt of being **[elementary](/components/button/#elementary) styled and can instead be [neutral](/components/button/#neutral) styled buttons.** (Emphasis added)",1 -118773554,2022-11-15 21:26:13.349,Pajamas navigation refinements,"## Purpose - -A followup from #1443 to further refine the navigation with the following: - -- Update the Pajamas lockup and ensure a common left edge (alignment) for all elements. -- Ability to expand multiple sections at once. This is a common accordion-like pattern that would allow a user to compare the options in different sections. While this UX might not be ideal for some sites, it can be a benefit for a user of Pajamas to get a better understanding why there are **Form elements** in one section, and **Forms** in another. -- Sticky expanded sections. Since some sections (like **Components**) are quite long, having the parent category item sticky when expanded can help a user maintain context for the current section they're navigating. -- Update design of search to be more integrated into the sidebar (inspired by the recent update to the dropdown design). - -| **Before** | **After** | -| ------ | ------ | -| ![CleanShot_2022-11-15_at_15.27.07_2x](/uploads/8301cb427469b78bf66e01a215e5c87f/CleanShot_2022-11-15_at_15.27.07_2x.png) | ![image](/uploads/8f6ee6079020c5cc846a22404d1bfb37/image.png) | - -[![Figmacon.svg](/uploads/45f9a446f4122aef0e50b97cb651f039/Figmacon.svg) View the working file in Figma →](https://www.figma.com/file/qYQOk3DhrswWIsRnoUTJ6J/%231378-Pajamas-IA-JE?node-id=708%3A4482&t=TDoghMezobgvIbnA-11) - -**Note:** The _before_ screenshot is from !3115's review app.",3 -118771757,2022-11-15 20:29:49.833,Figma > Update button size and position in dropdowns,"## Description - -- Buttons in a dropdown ([disclosure](https://design.gitlab.com/components/dropdown-disclosure) only) could use the sm size since they're already in a smaller container and supporting a larger context. -- Buttons in a dropdown ([disclosure](https://design.gitlab.com/components/dropdown-disclosure) only) should be right positioned to follow [alignment](https://4456656-review-1443-updat-77up3w.design-staging.gitlab.com/) guidelines since they are in a constrained container. - -| **Before** | **After** | -| ------ | ------ | -| ![image](/uploads/44a76d2d78c9ab223e76791c52280f37/image.png) | ![image](/uploads/2fcc11088865066ced77ba6ced3f89c3/image.png) | -| ![image](/uploads/1c5acead1180d98d9518df9e797e2794/image.png) | ![image](/uploads/f8594eaaf113b20436b9ec6f78a6abdd/image.png) | - -[![Figmacon.svg](/uploads/8e37dee9c9a9f3f31a0fd70b2cfb721d/Figmacon.svg) View working branch in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/Ec1j6iY0dkjujPqhR8mxMw/%F0%9F%93%99-Component-library?node-id=65182%3A99209&viewport=-2770%2C229%2C1&t=KsEY2muucemu16ht-11) - -### Figma file - - - -[❖ View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/Ec1j6iY0dkjujPqhR8mxMw/%F0%9F%93%99-Component-library) - -## Checklist - -Make sure the following are completed before closing the issue: - -### Assignee tasks: - -
Getting started: - -1. [x] Title the issue using this structure ""Figma > [Component name] - [Description]"". For example, Figma > Badges - Fix icon override bug. -1. [x] Add the relevant [component label](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/labels?subscribed=&search=component%3A). For example ~""component:badge"". -1. [ ] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. -1. [ ] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. -1. [x] Update the link to the working file under the **Figma link** section below. -1. [ ] If work was not done in a branch (a merged branch will automatically be archived), move your working file - to the shared Figma project: - 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. - 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -
- -
Prior to review: - -The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: - -1. [ ] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** ( + Y) to reveal invisible objects. Use **View > Zoom to Fit** (Shift + 1) to view all items on the page. -1. [ ] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. -1. [ ] **Frames**: Make spacing within and between frames consistent with components found on other pages. -1. [ ] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. -1. [ ] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. -1. [ ] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. -1. [x] **Comments**: Make sure all comments and discussion are resolved. - -If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference. - -
- -
Requesting a review: - -Ask a [Foundations designer][foundations-team] to review your design. - -1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma. -1. [x] From the dropdown to the right of the file name, select ""Request review"". -1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. -1. [ ] Consider [creating a new version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Create_a_new_version) (optional) titled ""Review requested"" in the history which will create a reference point in the file's history. - -Once your file is in review, you should see a yellow ""In review"" badge to the right of the file name. - -
- -
Post review: -Once the Reviewer or Maintainer has approved your update, consider the following tasks: - -1. [ ] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [ ] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [ ] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [x] 🎉 Congrats, you made it! You can now close this issue. - -
- -### Reviewer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] Make sure all layers are correctly named and organized. -1. [ ] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. -1. [x] Ensure component descriptions and external documentation links are clear and accurate. -1. [x] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. -1. [x] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). -1. [x] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). - -
- -### Maintainer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s changes. - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] Merge the branch or add the changes or additions to the - target file. - 1. [ ] Ensure that all styles and components now belong to the target file. - 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message. - -
- -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component -[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation - -",1 -118758205,2022-11-15 16:03:32.458,Pajamas site mobile nav,"## Purpose - -As a followup to !3115 there are some additional improvements needed for the mobile navigation of the Pajamas website. - -From https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/3115#note_1171724042: - -> …move from a partial cover to a full-width/overlay menu to: -> -> 1. Add a close button in correct focus order, potentially using a × icon -> 1. Remove overflow scroll of page content while menu is open (swipe moves content body not menu items) -> 1. Allow increase in touch targets in menu for mobile -> 1. Rethink ≡ overlapping page content on scroll",3 -118643439,2022-11-14 04:49:31.441,Homepage images sizing on small screens,Update homepage styles so that images load correctly on mobile. Fix layout to avoid x-axis overflow on smaller screens e.g. `320px`.,1 -118458939,2022-11-10 00:20:20.315,Update documentation heading border styles,"Update heading `border-bottom` styles to be consistent with tab border color. - -Tighten `padding-bottom` to improve vertical rhythm between headings and related content.",1 -118368014,2022-11-08 16:38:04.314,Figma > Remove alert in modal example,"## Description - -Per [Pajamas](https://design.gitlab.com/usability/error-prevention#severity-guidelines): - ->Avoid using alerts to emphasize the content inside a modal. - -and… - ->Any final confirmation that is destructive must use the danger variant (unless a browser dialog is used). - -This removes the alert from the modal example content and reformats the text. - -| **Before** | **After** | -| ------ | ------ | -| ![image](/uploads/375ceb61324612f7b54d67b80a426155/image.png) | ![image](/uploads/fc0002aa8606373b49ffd65a39ad1506/image.png) | - -### Figma file - - - -[❖ View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/WaECLxx4sHP5BfyWgIXYmp/%F0%9F%93%99-Component-library?node-id=425%3A129&viewport=-90%2C25%2C0.93) - -## Checklist - -Make sure the following are completed before closing the issue: - -### Assignee tasks: - -
Getting started: - -1. [x] Title the issue using this structure ""Figma > [Component name] - [Description]"". For example, Figma > Badges - Fix icon override bug. -1. [x] Add the relevant [component label](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/labels?subscribed=&search=component%3A). For example ~""component:badge"". -1. [ ] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. -1. [x] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. -1. [x] Update the link to the working file under the **Figma link** section below. -1. [ ] If work was not done in a branch (a merged branch will automatically be archived), move your working file - to the shared Figma project: - 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. - 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -
- -
Prior to review: - -The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: - -1. [x] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** ( + Y) to reveal invisible objects. Use **View > Zoom to Fit** (Shift + 1) to view all items on the page. -1. [ ] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. -1. [ ] **Frames**: Make spacing within and between frames consistent with components found on other pages. -1. [x] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. -1. [ ] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. -1. [ ] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. -1. [x] **Comments**: Make sure all comments and discussion are resolved. - -If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference. - -
- -
Requesting a review: - -Ask a [Foundations designer][foundations-team] to review your design. - -1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma. -1. [x] From the dropdown to the right of the file name, select ""Request review"". -1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. -1. [ ] Consider [creating a new version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Create_a_new_version) (optional) titled ""Review requested"" in the history which will create a reference point in the file's history. - -Once your file is in review, you should see a yellow ""In review"" badge to the right of the file name. - -
- -
Post review: -Once the Reviewer or Maintainer has approved your update, consider the following tasks: - -1. [ ] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [ ] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [ ] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [ ] 🎉 Congrats, you made it! You can now close this issue. - -
- -### Reviewer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] Make sure all layers are correctly named and organized. -1. [x] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. -1. [x] Ensure component descriptions and external documentation links are clear and accurate. -1. [x] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. -1. [x] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). -1. [x] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). - -
- -### Maintainer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s changes. - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] Merge the branch or add the changes or additions to the - target file. - 1. [x] Ensure that all styles and components now belong to the target file. - 1. [x] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message. - -
- -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component -[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation - -",1 -118308894,2022-11-07 20:54:31.002,Figma > Broadcast message use paragraph style,"## Description - -Use paragraph style instead of label and address any layout regressions (will match GitLab UI). - -| **Before** | **After** | -| ------ | ------ | -| ![image](/uploads/c7a7b17ae050a2a3c97bb0fa2b0c58b3/image.png) | ![image](/uploads/ec71c03708b64d10d151f5f5f41c6cee/image.png) | - -### Figma file - - - -[❖ View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/7pJYvD1VtVfHDvWW7zWump/%F0%9F%93%99-Component-library?node-id=425%3A6&viewport=835%2C400%2C0.8) - -## Checklist - -Make sure the following are completed before closing the issue: - -### Assignee tasks: - -
Getting started: - -1. [x] Title the issue using this structure ""Figma > [Component name] - [Description]"". For example, Figma > Badges - Fix icon override bug. -1. [x] Add the relevant [component label](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/labels?subscribed=&search=component%3A). For example ~""component:badge"". -1. [x] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. -1. [ ] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. -1. [x] Update the link to the working file under the **Figma link** section below. -1. [ ] If work was not done in a branch (a merged branch will automatically be archived), move your working file - to the shared Figma project: - 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. - 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -
- -
Prior to review: - -The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: - -1. [x] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** ( + Y) to reveal invisible objects. Use **View > Zoom to Fit** (Shift + 1) to view all items on the page. -1. [ ] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. -1. [x] **Frames**: Make spacing within and between frames consistent with components found on other pages. -1. [x] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. -1. [ ] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. -1. [ ] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. -1. [x] **Comments**: Make sure all comments and discussion are resolved. - -If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference. - -
- -
Requesting a review: - -Ask a [Foundations designer][foundations-team] to review your design. - -1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma. -1. [x] From the dropdown to the right of the file name, select ""Request review"". -1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. -1. [ ] Consider [creating a new version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Create_a_new_version) (optional) titled ""Review requested"" in the history which will create a reference point in the file's history. - -Once your file is in review, you should see a yellow ""In review"" badge to the right of the file name. - -
- -
Post review: -Once the Reviewer or Maintainer has approved your update, consider the following tasks: - -1. [ ] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [ ] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [ ] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [x] 🎉 Congrats, you made it! You can now close this issue. - -
- -### Reviewer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] Make sure all layers are correctly named and organized. -1. [ ] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. -1. [ ] Ensure component descriptions and external documentation links are clear and accurate. -1. [x] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. -1. [x] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). -1. [x] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). - -
- -### Maintainer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s changes. - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] Merge the branch or add the changes or additions to the - target file. - 1. [ ] Ensure that all styles and components now belong to the target file. - 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message. - -
- -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component -[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation - -",1 -118308781,2022-11-07 20:51:23.656,Figma > Accordion use paragraph instead of labels style,"Update text styles and address any layout regressions (will match GitLab UI). - -| **Before** | **After** | -| ------ | ------ | -| ![image](/uploads/54da8cd9b4f6e8399c75d4c7d01fe1e4/image.png) | ![image](/uploads/a3e5f1efae318904ed0268d36cef599e/image.png) | - -[View working branch in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/4ytND6X78TA9d8IPJGpYJv/%F0%9F%93%99-Component-library?node-id=425%3A0)",1 -118136795,2022-11-04 10:34:40.096,Figma > Merge request reports - update non-ui kit components,"## Description - - - - - -Merge request reports page uses non-ui kit components. - -Issue to switch them to use UI Kit versions. - -| Before | After | -| ------ | ------ | -| ![Screenshot_2022-11-04_at_10.51.28](/uploads/75a009e39285b507cc0341f6b64752c0/Screenshot_2022-11-04_at_10.51.28.png) | ![Screenshot_2022-11-04_at_10.52.31](/uploads/476033e2c464c7e9ca6d34bd16198088/Screenshot_2022-11-04_at_10.52.31.png) | - -Also added the full stop :smile: - -### Figma file - - - -[❖ View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/fAr4qmF4D71mTFF7s8Bn6D/%F0%9F%93%99-Component-library) - -## Checklist - -Make sure the following are completed before closing the issue: - -### Assignee tasks: - -
Getting started: - -1. [x] Title the issue using this structure ""Figma > [Component name] - [Description]"". For example, Figma > Badges - Fix icon override bug. -1. [x] Add the relevant [component label](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/labels?subscribed=&search=component%3A). For example ~""component:badge"". -1. [x] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. -1. [x] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. -1. [x] Update the link to the working file under the **Figma link** section below. -1. [ ] If work was not done in a branch (a merged branch will automatically be archived), move your working file - to the shared Figma project: - 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. - 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -
- -
Prior to review: - -The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: - -1. [x] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** ( + Y) to reveal invisible objects. Use **View > Zoom to Fit** (Shift + 1) to view all items on the page. -1. [x] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. -1. [x] **Frames**: Make spacing within and between frames consistent with components found on other pages. -1. [x] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. -1. [x] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. -1. [x] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. -1. [x] **Comments**: Make sure all comments and discussion are resolved. - -If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference. - -
- -
Requesting a review: - -Ask a [Foundations designer][foundations-team] to review your design. - -1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma. -1. [x] From the dropdown to the right of the file name, select ""Request review"". -1. [ ] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. -1. [ ] Consider [creating a new version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Create_a_new_version) (optional) titled ""Review requested"" in the history which will create a reference point in the file's history. - -Once your file is in review, you should see a yellow ""In review"" badge to the right of the file name. - -
- -
Post review: -Once the Reviewer or Maintainer has approved your update, consider the following tasks: - -1. [ ] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [ ] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [ ] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [ ] 🎉 Congrats, you made it! You can now close this issue. - -
- -### Reviewer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] Make sure all layers are correctly named and organized. -1. [ ] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. -1. [ ] Ensure component descriptions and external documentation links are clear and accurate. -1. [x] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. -1. [x] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). -1. [x] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). - -
- -### Maintainer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s changes. - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] Merge the branch or add the changes or additions to the - target file. - 1. [x] Ensure that all styles and components now belong to the target file. - 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message. - -
- -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component -[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation - -",1 -118079628,2022-11-03 12:47:46.558,Figma > File uploader - Fix instances to use linked components,"## Description - - - - - -There are detached instances in the file uploaded examples. - -Issue to reattach those that can be and ensure correct styles and components are used. - -https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/%F0%9F%93%99-Component-library?node-id=8000%3A1 - -### Figma file - - - -[❖ View working file in Figma →](ADD LINK TO FIGMA FILE/FRAME) - -## Checklist - -Make sure the following are completed before closing the issue: - -### Assignee tasks: - -
Getting started: - -1. [ ] Title the issue using this structure ""Figma > [Component name] - [Description]"". For example, Figma > Badges - Fix icon override bug. -1. [ ] Add the relevant [component label](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/labels?subscribed=&search=component%3A). For example ~""component:badge"". -1. [ ] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. -1. [ ] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. -1. [ ] Update the link to the working file under the **Figma link** section below. -1. [ ] If work was not done in a branch (a merged branch will automatically be archived), move your working file - to the shared Figma project: - 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. - 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -
- -
Prior to review: - -The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: - -1. [ ] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** ( + Y) to reveal invisible objects. Use **View > Zoom to Fit** (Shift + 1) to view all items on the page. -1. [ ] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. -1. [ ] **Frames**: Make spacing within and between frames consistent with components found on other pages. -1. [ ] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. -1. [ ] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. -1. [ ] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. -1. [ ] **Comments**: Make sure all comments and discussion are resolved. - -If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference. - -
- -
Requesting a review: - -Ask a [Foundations designer][foundations-team] to review your design. - -1. [ ] Ensure the designer that will be reviewing your file has edit permissions in Figma. -1. [ ] From the dropdown to the right of the file name, select ""Request review"". -1. [ ] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. -1. [ ] Consider [creating a new version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Create_a_new_version) (optional) titled ""Review requested"" in the history which will create a reference point in the file's history. - -Once your file is in review, you should see a yellow ""In review"" badge to the right of the file name. - -
- -
Post review: -Once the Reviewer or Maintainer has approved your update, consider the following tasks: - -1. [ ] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [ ] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [ ] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [ ] 🎉 Congrats, you made it! You can now close this issue. - -
- -### Reviewer tasks: - -
See tasks: - -1. [ ] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [ ] Make sure all layers are correctly named and organized. -1. [ ] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. -1. [ ] Ensure component descriptions and external documentation links are clear and accurate. -1. [ ] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. -1. [ ] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). -1. [ ] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). - -
- -### Maintainer tasks: - -
See tasks: - -1. [ ] Review and approve assignee’s changes. - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [ ] Merge the branch or add the changes or additions to the - target file. - 1. [ ] Ensure that all styles and components now belong to the target file. - 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [ ] When applicable, [publish][publishing] any library changes along with a clear commit message. - -
- -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component -[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation - -",2 -118001916,2022-11-02 11:44:44.689,Move gl- utils to GitLab UI,"In https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/3113, we have added a few `gl-` CSS utils to support a cleanup initiative. We should eventually move those and any additional utils to GitLab UI.",1 -117950973,2022-11-01 15:36:42.132,Cleanup error page layout,"The following discussions from !3050 should be addressed: - -- [x] @pgascouvaillancourt started a [discussion](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/3050#note_1136458211): - - > **nitpick(non-blocking):** We are repeating the `typography gl--flex-center gl-flex-direction-column gl-h-100vh` wrapper both here and in the `page-not-found` component. Perhaps we could de-duplicate this. - -- [x] @pgascouvaillancourt started a [discussion](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/3050#note_1136458215): - - > **thought(non-blocking):** We seem to be repeating a lot of code from the default layout here. I wonder if we could conditionally render the footer instead of creating a new layout, it would make things a bit easier to maintain. - -- [x] @pgascouvaillancourt started a [discussion](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/3050#note_1136458218): - - > **nitpick(non-blocking):** This might not be relevant in this layout since the homepage uses the default layout anyways.",2 -117759458,2022-10-28 14:26:52.192,Tint neutral palette based on brand,"## Purpose - -In the latest brand updates the brand palette includes neutrals that are slightly more cool (blue) in tone. The current Pajamas neutral palette is completely desaturated and feels more generic than it could. There have been previous efforts to explore introducing both a cool and warm set of neutrals to compliment the current ones, however it became clear that this would be to try and account for the current theme approach (warm neutrals with red theme for example), and add unnecessary complexity to an already minimally used feature. - -Having a neutral palette that skews more towards the temperature of the brand palette will provide more continuity between digital properties and subtly allow us to infuse more of the brand into Pajamas and the product. Given our use of blue for primary actions and links, a more cool palette also helps elements to feel more harmonious. - -## Proposal - -Update the neutral palette to align with the grays in the brand palette. - -| | **Palette** | -| ------ | ------ | -| Brand | ![image](/uploads/415a82d85c280e978fcf32218e192bd4/image.png) | -| Current neutral | ![image](/uploads/684166acb8815214fab2f7a34db1dafb/image.png) | -| Proposed neutral | ![image](/uploads/91da0369d725d7a0ebc47dfde33f86f0/image.png) | - -**[![Figmacon.svg](/uploads/baf691a3cd8db4987642840392ab8c95/Figmacon.svg) View working file in Figma →](https://www.figma.com/file/tjSjgnxomkqPg8BEhPdNFJ/%231452-tine-neutral-palette-%40jeldergl?node-id=0%3A1)** - -**[![Figmacon.svg](/uploads/baf691a3cd8db4987642840392ab8c95/Figmacon.svg) View UI kit branch in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/XRCIH8ZdaAbyBpkJzgxdKG/%F0%9F%93%99-Component-library)** - -**[🎨 View palette in Huetone→](https://huetone.ardov.me/?palette=N4IgdghgtgpiBcIDiAZABAORgVwC4CcIAbAZxABoQALbGM%2BAbVElgRCz0KIpAGMB7Iv3z0GIAMQAzAKwyZPKQAZJyxQoAmAIy1aFmyfv0KAnKbMKAHADZr1hVYeOF0mC5fOATNK8eFAFkUAgIUAZkUwsIUARkkYmJAAXQBfcmZoOEQOAmI0AUEeASERBDEpfQhJdQUYXhqYSQ1edSa4SnFDSV4QhQg-CBCIC0tjC1GqtoB2EImPCaG2qw8rKJtnEOko6XmJPxC-Dz9t8RCTjxCjuJgDxJS01kQAIUIwcb5BYVEJSW%2BfjSj1RTqbptdT-QHAiQQDwQKIQKw9aGw%2BGTPwTKITCAKCao9GYtp%2BaT7PyvcQEokkjyaDwWc4KSnU2ltdFREIeKI3BKUXD8MB0EogKJqSjSIUCxSijzinhhUUBUUi0VWKWUCbKkAWNXGTUim5AA)** - -**Other thoughts…** - -Yes, this is subjective and nuanced. When exploring navigation updates both in the product, and Pajamas, designers have noted that the current neutrals are just too flat. We have an opportunity to better align the recent brand work and the product, and this is a very subtle, but effective way to do so. - -A cool neutral palette could also benefit dark UI and ironically (ignoring the terms) prevent it from feeling too cold or bland. [From this article](https://compilezero.medium.com/dark-mode-ui-design-the-definitive-guide-part-1-color-53dcfaea5129): - -> …you could also use accented neutrals instead of a pure-grey palette, which I personally recommend using due to 2 main reasons, -> -> _Pure greys are not found naturally, and so its a good option to have some tint on those neutrals to give it a more natural vibe._ -> -> _Tinted neutrals, could help give the UI an overall emphasized tone and emotion to look forward to._ - -**Resources** - -- https://designerup.co/blog/practical-guide-to-perfect-ui-color-palettes/ -- https://compilezero.medium.com/dark-mode-ui-design-the-definitive-guide-part-1-color-53dcfaea5129 -- https://graphicdesign.stackexchange.com/questions/119887/dark-ui-design-why-tint-the-dark-gray-colors-with-a-different-primary-color -- https://atmos.style/blog/lch-color-space -- https://stripe.com/blog/accessible-color-systems",2 -117214787,2022-10-20 06:03:01.410,"Pajamas Migration Day: December 2, 2022","As part of our ongoing [component migration push](https://gitlab-org.gitlab.io/frontend/epic-burndown-charts/fy23-q1/), we are hosting another Pajamas Migration Day! - -- **When:** December 2, 2022 -- **Who:** Everyone! FE, BE, Designers, Product, etc. Everyone is encouraged to contribute. -- **Where:** Your very own home or work space, but also join the `#pajamas_migration_day` slack channel to hang out and chat with fellow contributors! -- **Why:** We want to encourage a day of migrating legacy components / css to use Pajamas! -- **Bonus:** If you contribute three merge requests on Pajamas Migration Day, you can expense a meal for up to $25 USD! Please use the ~""Pajamas Migration Day"" and ~""FY23::Q4"" labels on your MRs to be eligible. In Expensify, use the `Meals Company Provided (Non-Client related)` category. - -**Need help?** Ping any member of the [Foundations team](https://about.gitlab.com/company/team/?department=manage-foundations-team) for support or help throughout the day. We are here to assist! - -## How to contribute - -**If you are working on building your coding skills, check out these issues:** - -- [HAML: Buttons](https://gitlab.com/groups/gitlab-org/-/issues/?sort=created_date&state=opened&label_name%5B%5D=Pajamas%20Migration%20Day&label_name%5B%5D=workflow%3A%3Aready%20for%20development&label_name%5B%5D=component%3Abutton&label_name%5B%5D=haml%20migration&first_page_size=20) -- [HAML: Cards](https://gitlab.com/groups/gitlab-org/-/issues/?sort=created_date&state=opened&label_name%5B%5D=Pajamas%20Migration%20Day&label_name%5B%5D=workflow%3A%3Aready%20for%20development&label_name%5B%5D=component%3Acard&label_name%5B%5D=haml%20migration&first_page_size=20) - -**If you are confident in your coding skills, check out these issues:** - -- [Dropdown migrations](https://gitlab.com/groups/gitlab-org/-/issues/?sort=created_date&state=opened&label_name%5B%5D=OKR&label_name%5B%5D=component%3Adropdown&assignee_id=None&first_page_size=20) -- [Remove select2 implementations](https://gitlab.com/groups/gitlab-org/-/epics/8738) -- [Extract Page Specific CSS Files](https://gitlab.com/groups/gitlab-org/-/epics/3694) - -**Tip:** There does not need to be a specific issue open to contribute! Starting with MRs that migrate legacy code is a great way to contribute to the effort. If there are no issues to pick up, treat the day like a scavenger hunt! - -**Reminder:** Please add the ~""Pajamas Migration Day"" and ~""FY23::Q4"" labels to your MRs, as well as the specific component label that relates to your change (for example: ~""component:alert"")",0 -117042973,2022-10-17 15:01:53.774,Add Mermaid diagram capabilities,"In a recent Foundations Open Office Hours meeting we discussed the need to add decision trees, and part of the discussion was what format these should take: Figma embed, SVG, Mermaid, etc. Mermaid would be ideal to keep it in the source and manage changes.",3 -116787230,2022-10-12 23:05:06.327,Update Pajamas navigation as a result of #1378,"## Purpose - -Update the Pajamas navigation (and related pages) based on conclusions and direction from the results of #1378. - -## Scope - -- Update the navigation structure. -- Update the navigation semantics to ensure accessibility. -- Update navigation design. - -## Direction - -[📐 Prototype →](https://codepen.io/lostsatellites/full/rNvbrao) - -![image](/uploads/c0bd6960203d7acd0259db8fecc08e6d/image.png)",3 -116774125,2022-10-12 18:24:03.009,Dropdown > Update docs to align with latest approach,"## Purpose - -As a next iteration we've discussed moving the listbox to a low-level component. What that means is that it isn't something to be used on it's own as an actual dropdown variant, but instead it's consumed by both the disclosure (optional) and combobox (required). - -Likewise, it's been determined that the menu variant isn't something we'll proceed with for now since the disclosure can fir the use cases we have today in the product. - -## Changes - -- Place necessary listbox content within the [combobox](https://design.gitlab.com/components/dropdown-combobox) page. -- Deprecate the [listbox](https://design.gitlab.com/components/dropdown-listbox) page. -- From the [disclosure](https://design.gitlab.com/components/dropdown-disclosure) page, link to the new listbox section under combobox as the SSoT. -- Deprecate the [menu](https://design.gitlab.com/components/dropdown-menu) page. -- Consider adding decision trees in the _when to use_ section(s) to help determine what to use. - -The above changes would leave us with only the disclosure and combobox dropdown variants. To avoid the use of a menu-like option, we could consider adding a line about what `role= menu` is and why we don't use it in both places.",1 -116569759,2022-10-10 10:17:17.158,Disable Google Analytics (and therefore remove Cookie Banner) for design.gitlab.com,"The cookie banner breaks stuff, see for example: - -- https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1436 -- https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/commit/15be27162585b06eb2d390cf0191890100a5622c - -If we do not ship Google Analytics, we need no Cookie Banner, because we are not using Cookies otherwise. - -Given that noone seems to have looked at Analytics in a while (at least when I asked), we should consider removing it and making our lives easier.",1 -116409347,2022-10-06 14:10:38.220,Figma > New Illustration for scheduled actions,"## Description -There's no illustration available in the library for any scheduled activity in the platform. We use and old and very specific illustration for [scheduled pipelines](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/pipeline_schedules but there's a need for something more generic that can be re-used in other contexts as well. - -There's a need to add an empty state to the `Scheduled pipeline` page for which this illustration will come in handy. - -| Current empty state for pipeline schedule page | -|-------| -| ![Screen_Shot_2022-10-14_at_11.07.53_AM](/uploads/a6c39b3038ea9dc61faabade6ae05da0/Screen_Shot_2022-10-14_at_11.07.53_AM.png) | - - - - - -### Concept - -A simple illustration using the latest [illustration guides](https://design.gitlab.com/product-foundations/illustration/) that can universal represent the concept of ""schedules,"" ""scheduling,"" ""scheduled,"" and similar forms. - -### Figma file -TBD - - -[❖ View working file in Figma →](https://www.figma.com/file/1ui9w228X0S5WxaD0SRdIA/branch/k2RyJnTszVzFWLKr9UsvZO/Illustration-library?node-id=441%3A2008) - -## Checklist - -Make sure the following are completed before closing the issue: - -### Assignee tasks: - -
Getting started: - -1. [x] Title the issue using this structure ""Figma > [Component name] - [Description]"". For example, Figma > Badges - Fix icon override bug. -1. [x] Add the relevant [component label](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/labels?subscribed=&search=component%3A). For example ~""component:badge"". -1. [-] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. -1. [-] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. -1. [ ] Update the link to the working file under the **Figma link** section below. -1. [ ] If work was not done in a branch (a merged branch will automatically be archived), move your working file - to the shared Figma project: - 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. - 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -
- -
Prior to review: - -The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: - -1. [ ] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** ( + Y) to reveal invisible objects. Use **View > Zoom to Fit** (Shift + 1) to view all items on the page. -1. [ ] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. -1. [ ] **Frames**: Make spacing within and between frames consistent with components found on other pages. -1. [ ] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. -1. [ ] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. -1. [ ] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. -1. [ ] **Comments**: Make sure all comments and discussion are resolved. - -If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference. - -
- -
Requesting a review: - -Ask a [Foundations designer][foundations-team] to review your design. - -1. [ ] Ensure the designer that will be reviewing your file has edit permissions in Figma. -1. [ ] From the dropdown to the right of the file name, select ""Request review"". -1. [ ] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. -1. [ ] Consider [creating a new version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Create_a_new_version) (optional) titled ""Review requested"" in the history which will create a reference point in the file's history. - -Once your file is in review, you should see a yellow ""In review"" badge to the right of the file name. - -
- -
Post review: -Once the Reviewer or Maintainer has approved your update, consider the following tasks: - -1. [ ] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [ ] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [ ] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [ ] 🎉 Congrats, you made it! You can now close this issue. - -
- -### Reviewer tasks: - -
See tasks: - -1. [ ] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [ ] Make sure all layers are correctly named and organized. -1. [ ] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. -1. [ ] Ensure component descriptions and external documentation links are clear and accurate. -1. [ ] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. -1. [ ] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). -1. [ ] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). - -
- -### Maintainer tasks: - -
See tasks: - -1. [ ] Review and approve assignee’s changes. - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [ ] Merge the branch or add the changes or additions to the - target file. - 1. [ ] Ensure that all styles and components now belong to the target file. - 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [ ] When applicable, [publish][publishing] any library changes along with a clear commit message. - -
- -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component -[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation - - - -/labels ~Figma ~""Pajamas UI Kit"" ~""pajamas::design""",2 -116091745,2022-09-30 18:49:41.164,Discovery > Look into possibilities of displaying ViewComponents in Pajamas,"Now that we have [ViewComponents](https://gitlab.com/groups/gitlab-org/-/epics/8113), it would be great to get those displayed in Pajamas alongside the Vue components. - -As a first iteration, the `Implementation` tab could change to `Vue` and we could introduce a new tab per component called `View`. - -One potential hurdle is that it needs to properly deployed to a Rails application, so we need to determine if this is possible or what options we have. - ---- - -@thutterer - -> Prototype at https://gitlab.com/gitlab-org/frontend/playground/lookbook-app",3 -116025904,2022-09-29 16:29:00.603,Typography: Update Figma to use new default fonts,"## Description - -Update all Pajamas UI Kit assets in Figma to use the shipped version of Inter, which includes variable features. - -## Scope - -All [Pajamas UI Kit](https://www.figma.com/files/project/3802635) files: - -- Component library -- Product icons (labels only) -- Product pages -- Data visualization -- Type scale - Documentation markdown -- Type scale - Compact markdown - -Other: - -- Templates -- Cover slide - -### Out of scope - -- Updating existing design files - -## Related - -The [Type Fundamentals](https://design.gitlab.com/product-foundations/type-fundamentals) page in Pajamas would eventually need to be updated with the latest font stack info. - -### Figma test - -- [Component library →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/HIA8tpxKnRBR7bFP901AsS/%F0%9F%93%99-Component-library?node-id=440%3A0) - -### Figma branches - -- [Component library →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/WM9pPOVoiGnI17U0PSD2os/%F0%9F%93%99-Component-library?node-id=3050%3A0) -- Product icons (labels only) -- Product pages -- Data visualization -- [Type scale - Documentation markdown →](https://www.figma.com/file/V3HKN83B7rf2T6sseLMrxa/branch/nTHaYuIrt7fMmSBrowA9uz/Type-scale---Documentation-Markdown?node-id=3%3A54) -- [Type scale - Compact markdown →](https://www.figma.com/file/mjAZxHkK95TlQ6L14aNp2M/branch/9LMZJBsTtQqMGPbrH8Q07Q/Type-scale---Compact-Markdown?node-id=3%3A54) - -## Checklist - -Make sure the following are completed before closing the issue: - -### Assignee tasks: - -
Getting started: - -1. [x] Title the issue using this structure ""Figma > [Component name] - [Description]"". For example, Figma > Badges - Fix icon override bug. -1. [x] Add the relevant [component label](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/labels?subscribed=&search=component%3A). For example ~""component:badge"". -1. [x] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. -1. [ ] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. -1. [x] Update the link to the working file under the **Figma link** section below. -1. [ ] If work was not done in a branch (a merged branch will automatically be archived), move your working file - to the shared Figma project: - 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. - 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -
- -
Prior to review: - -The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: - -1. [ ] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** ( + Y) to reveal invisible objects. Use **View > Zoom to Fit** (Shift + 1) to view all items on the page. -1. [ ] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. -1. [ ] **Frames**: Make spacing within and between frames consistent with components found on other pages. -1. [ ] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. -1. [ ] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. -1. [ ] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. -1. [x] **Comments**: Make sure all comments and discussion are resolved. - -If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference. - -
- -
Requesting a review: - -Ask a [Foundations designer][foundations-team] to review your design. - -1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma. -1. [x] From the dropdown to the right of the file name, select ""Request review"". -1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. -1. [ ] Consider [creating a new version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Create_a_new_version) (optional) titled ""Review requested"" in the history which will create a reference point in the file's history. - -Once your file is in review, you should see a yellow ""In review"" badge to the right of the file name. - -
- -
Post review: -Once the Reviewer or Maintainer has approved your update, consider the following tasks: - -1. [x] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [x] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [x] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [x] 🎉 Congrats, you made it! You can now close this issue. - -
- -### Reviewer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [ ] Make sure all layers are correctly named and organized. -1. [ ] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. -1. [ ] Ensure component descriptions and external documentation links are clear and accurate. -1. [x] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. -1. [x] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). -1. [x] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). - -
- -### Maintainer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s changes. - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] Merge the branch or add the changes or additions to the - target file. - 1. [x] Ensure that all styles and components now belong to the target file. - 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message. - -
- -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component -[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation - -",3 -113900144,2022-08-26 07:30:21.301,Add structure image for filter,[View working file in Figma (branch) →](https://www.figma.com/file/2XRq1MnIG69iti76Mh9HpJ/branch/X3R2AZyGx5IEAd2IqrMdTj/Pajamas-visual-examples?node-id=9981%3A21053),1 -113719597,2022-08-23 18:36:18.708,Introduce option to put selected items at top of dropdown,"## Problem to solve - -Without a dropdown pattern that shows the selected items at the top, I can't see what those selections are without a lot of scrolling in the dropdown. The truncation in the button suggests that there are more items, but how do I know what these are? Example from https://gitlab.com/gitlab-org/gitlab/-/issues/345430/designs/Runner_tag_field_states.png#note_1074738137: - - - -I'd have to scroll down through potentially hundreds of items to see what the `+2 more` refers to (and/or to unselect them). Sometimes the dropdown doesn't even show the complete list, which makes it impossible to find it unless I know what I'm looking for and can use the search to find it (and unselect it, for example). - -## Proposal - -| 5 items | 6+ items creates a scrollable area | -| ------ | ------ | -| ![image](/uploads/a0519c2f232eda7f84a57b3205f35b41/image.png) | ![image](/uploads/6a4c06a5df719deb4aa02635991d0dac/image.png) | - -In order to prevent the selection from moving around within the input, which could be a frustrating and disorienting experience, the selection should move _after_ the dropdown is closed so it's shown when it's re-opened. This is different than how it currently works in the Assignees dropdown. - -Example: - -![Screen_Shot_2022-08-23_at_3.21.20_PM](/uploads/3d4f5b7fc9b869fa682dc694f9b5bad5/Screen_Shot_2022-08-23_at_3.21.20_PM.png) - -As far as I can tell, this type of dropdown isn't available in [Pajamas](https://design.gitlab.com/components/dropdown-listbox), [gitlab-ui](https://gitlab-org.gitlab.io/gitlab-ui/?path=/story/base-dropdown--default), or the Figma library as a variant (only as an [instance](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/%F0%9F%93%99-Component-library?node-id=12053%3A6)).",5 -113627776,2022-08-22 12:25:32.913,Typography scale(s) exploration,"Update typography scale(s) and make use of them in GitLab UI & the product. - -- Can we unify some of the scales? -- Build a new scale with variables so it can be optimised to different usecases -- Presenting type scales in GitLab UI and Pajamas -- Product integration -- Use base font size of 1rem (16px) -- Change font-sizes to rem (a11y) - -Current scale: [GitLab UI](https://gitlab-org.gitlab.io/gitlab-ui/?path=/story/scss-typescale--default) - -Figma WIP: [Component library →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/8eZJjsriZhPMHL7t1PoVJH/%F0%9F%93%99-Component-library?node-id=440%3A0&t=mKm3NIjPzREZn3q7-0)",3 -113627623,2022-08-22 12:23:03.045,Inter typeface exploration,"### Goal - -Make Inter the new default font in GitLab UI & the product. - -#### Steps -- Explore the use of Inter -- Variable font -- How we can roll this out -- Possible performance impacts -- Language support (i18n) -- Fallbacks - -### Inter - -![image](/uploads/f61bd34d79e9bffa1ae92dbc278b3752/image.png) - -### Figma Test - -[View branch in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/HIA8tpxKnRBR7bFP901AsS/%F0%9F%93%99-Component-library?node-id=440%3A0) - -### Product Test - -| Inter | system-ui in Mac OS (SF Pro) | -| ------ | ------ | -| ![inter](https://gitlab.com/groups/gitlab-org/gitlab-services/-/uploads/bcded4f9cfd68518969ffa3c69226a86/inter.png) | ![system-ui](https://gitlab.com/groups/gitlab-org/gitlab-services/-/uploads/5b8ca6e56c351b906107dcaae3854452/system-ui.png) |",2 -113520415,2022-08-19 10:44:19.333,Revisit the terminology for the filter component parts and guidelines,,2 -113461996,2022-08-18 11:33:17.107,Typography exploration,"Meta issue to explore options regarding typography. - -So far @jeldergl & I discussed to explore: - -- Switching to Inter -- Make use of variable font -- Tweaking/Improving/Streamlining our Typo scales -- Product integration plan/roadmap -- Considering an open source monospace typeface to pair with Inter",5 -113287316,2022-08-15 12:26:14.124,Define pattern for adding items to a list,"### Background - -Based on [the discussion](https://gitlab.com/gitlab-org/gitlab/-/issues/368138#note_1037362165) with @mle, the improvement could be a community improvement. - -So far, we only know that this Region exists in ""Settings"" and ""Security Policy"" if anyone knows where else we are using it, feel free to add. - -cc: @gitlab-com/gitlab-ux/designers, Any suggestions or you notice the change won't work in certain area? - -### Change Proposal - -![select-approval-rule-region-improvement](/uploads/e5df095d660447cd3b0afa3a17de0a35/select-approval-rule-region-improvement.png)",3 -112728442,2022-08-03 13:35:05.333,Typography > Note smallest recommended font size,"## Purpose - -Some instances of type are showing up that are smaller than the 12px allowed by the current type scales (UI type scale). 12px is a good minimum size and should be used in limited capacity for short meta-like copy and actions. There is no minimum mentioned in Pajamas (although it's implied by the type scale styles), and it'd be helpful to document. - -There is subjectivity when it comes to font size and preference, but that's all the more reason to set a baseline and guidance. For example, browsers handle antialiasing differently and rendering ""quality"" will vary. GitLab makes use of system fonts, and some, like Helvetica, have tighter spacing and less character definition so that text is harder to read at small sizes. One user will not have the same eyesight as the next, so setting a minimum can also help remove subjectivity and preference for what should be the minimum size. - -If content is worth displaying, then it should be worth displaying legibly. - -### Considerations - -- On mobile, if the font size of an input is not at least 16px, then input will be scaled up (at least in Safari). -- Typeface, font weight, color, line-height, measure, and style can all impact legibility. -- While WCAG doesn't prescribe a minimum font size, it does address contrast for type -- Pixels are referenced as the unit in this issue, but in code relative units should be used so that a user can scale the type in browser (using pixels prevents this). If a browser's default size is 16px (1rem), then 12px = 0.75rem. -- Screen resolution will impact legibility. - -| **Helvetica, Firefox** | **Helvetica, Firefox, standard resolution** | **San Francisco, Firefox** | -| ------ | ------ | ------ | -| ![CleanShot_2022-08-03_at_08.59.44_2x](/uploads/b0b4cb53e2d29c3a6f4f530c3c5aff49/CleanShot_2022-08-03_at_08.59.44_2x.png) | ![CleanShot_2022-08-03_at_09.00.29_2x](/uploads/38dbe0873fa017a917fa562fb45356df/CleanShot_2022-08-03_at_09.00.29_2x.png) | ![CleanShot_2022-08-03_at_09.01.00_2x](/uploads/eb2235b1a554fb7e1de573d375e42b90/CleanShot_2022-08-03_at_09.01.00_2x.png) | - -### Resources & reference - -- Explore different type sizes and fonts in [CodePen](https://codepen.io/lostsatellites/pen/BarrNoE). -- https://stephaniewalter.design/blog/what-minimum-font-size-for-a-high-density-data-web-app-do-you-suggest/ -- https://css-tricks.com/accessible-font-sizing-explained/",1 -112626672,2022-08-01 22:30:42.059,GitLab UI stories don't load,"GitLab UI stories seem to be unable to load in some cases. Loading a page that contains stories directly seems to result in the viewers remaining blank. - -Stories generally load properly when navigating to a page with stories from within the app although that doesn't seem to be consistently reproducible. - -/cc @jeldergl @danmh",2 -112625838,2022-08-01 21:55:19.462,"FY23 Q3 Foundations KR3: Identify opportunities to increase product designer efficiency in Figma. For example, component structure, libraries, internal plugins, etc","## Purpose - -See [epic description](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/12). - -## Steps - -- [ ] Conduct a survey or host a synchronous brainstorming session to explore potential opportunities and workflows that would increase product designer efficiency in Figma. -- [ ] Identify top 2–3 items that would be the most helpful at this point in time. -- [ ] Create a roadmap for each item. - ---- - -## Retrospection - -### Good -* Some ideas were uncovered during the IA work. - -### Bad -* The IA effort took too long and I didn't get to this. - -### Try -* Breaking down even smaller.",5 -111819368,2022-07-18 23:54:47.955,Rename foundations-color-palette component to color-palette,"The following discussion from !2970 should be addressed: - -- [ ] @pgascouvaillancourt started a [discussion](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2970#note_1025851626): (+1 comment) - - > **note:** I forgot to give this component a more generic name during the initial implementation. Given that it works in both pages that render color palettes, we can probably rename this to simply `color-palette`. I will do that in a follow-up.",1 -110979806,2022-06-30 17:37:30.725,Abstract color palettes out into a reusable Vue component,"The following discussion from !2910 should be addressed: - -- [ ] @pgascouvaillancourt started a [discussion](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2910#note_1010952473): (+2 comments) - - > **thought:** There's a lot of duplicated code in this file. Now that we can use Vue components inside Markdown, we should probably think of a way to abstract the color palettes into a reusable component to clean this up a bit.",2 -110887730,2022-06-29 10:12:21.990,Figma > Icon fill issues,"## Description - - - -Settings icon is behaving like its styled with strokes, rather than fills. This causes some bugs where we rely on fills for overrides — icon dropdown button shown. - -![Kapture_2022-06-28_at_19.22.47](/uploads/de7d92897945044217170b8058c1e629/Kapture_2022-06-28_at_19.22.47.gif) - -I tried to fix it, but I couldn’t work out how to do it without expanding the strokes — which would be destructive. The usual boolean group tricks don’t seem to be working here. - -@nickleonard : - -> I've noticed `check` does this as well; - - - -### Figma file - - - -[❖ View working file in Figma →](https://www.figma.com/file/pEkDaidkvHeHVdnmYp6stC/Icon-fix-test?node-id=2%3A2) - -## Checklist - -Make sure the following are completed before closing the issue: - -### Assignee tasks: - -
Getting started: - -1. [ ] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. -1. [ ] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. -1. [ ] Update the link to the working file under the **Figma link** section below. -1. [ ] If work was not done in a branch (a merged branch will automatically be archived), move your working file - to the shared Figma project: - 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. - 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -
- -
Prior to review: - -The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: - -1. [ ] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** ( + Y) to reveal invisible objects. Use **View > Zoom to Fit** (Shift + 1) to view all items on the page. -1. [ ] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. -1. [ ] **Frames**: Make spacing within and between frames consistent with components found on other pages. -1. [ ] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. -1. [ ] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. -1. [ ] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. -1. [ ] **Comments**: Make sure all comments and discussion are resolved. - -If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference. - -
- -
Requesting a review: - -Ask a [Foundations designer][foundations-team] to review your design. - -1. [ ] Ensure the designer that will be reviewing your file has edit permissions in Figma. -1. [ ] From the dropdown to the right of the file name, select ""Request review"". -1. [ ] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. - -Once your file is in review, you should see a yellow ""In review"" badge to the right of the file name. - -
- -
Post review: -Once the Reviewer or Maintainer has approved your update, consider the following tasks: - -1. [ ] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [ ] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [ ] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [ ] 🎉 Congrats, you made it! You can now close this issue. - -
- -### Reviewer tasks: - -
See tasks: - -1. [ ] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [ ] Make sure all layers are correctly named and organized. -1. [ ] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. -1. [ ] Ensure component descriptions and external documentation links are clear and accurate. -1. [ ] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. -1. [ ] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). -1. [ ] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). - -
- -### Maintainer tasks: - -
See tasks: - -1. [ ] Review and approve assignee’s changes. - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [ ] Merge the branch or add the changes or additions to the - target file. - 1. [ ] Ensure that all styles and components now belong to the target file. - 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [ ] When applicable, [publish][publishing] any library changes along with a clear commit message. - -
- -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component -[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation",1 -110504223,2022-06-21 19:32:54.884,"FY23 Q3 Foundations KR2: Gap analysis that determines what areas of Pajamas are missing or needing further refinement, and what the potential impact is","## Purpose - -See [epic description](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/12). - -## Steps - -- [ ] Conduct an internal survey to better understand what perceived gaps are. -- [ ] Triage open issues to determine what topics and items are most commonly discussed. - - [ ] Create sub-epics or new issues to organize by theme. -- [ ] Identify gaps in Pajamas design language. These are the areas that need clarified in order for anyone to have confidence and continuity when building an experience using the design system. For example, I know what component A does, but do I know how to use it with component B, or in a scenario where multiple components exist? -- [ ] Make proposals to close gaps. - ---- - -## Retrospection - -### Good -* Some ideas were uncovered during the IA work. - -### Bad -* The IA effort took too long and I didn't get to this. - -### Try -* Breaking down even smaller.",3 -110504217,2022-06-21 19:32:37.166,Pajamas > Definitions,"- Evaluate existing definitions found at https://design.gitlab.com/get-started/structure with a primary focus on: Foundations, Components, Regions, and Objects. -- Update definitions and create new ones for sections considered in the [IA exercise](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1378). - -[Working file in Figma →](https://www.figma.com/file/qYQOk3DhrswWIsRnoUTJ6J/%231378-Pajamas-IA-JE?node-id=0%3A1)",3 -110504207,2022-06-21 19:32:21.456,FY23 Q3 Foundations KR1: Updated Pajamas IA that takes into account new and updated definitions and organization,"## Purpose - -See [epic description](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/12). - -## Steps - -- [x] Evaluate existing IA to determine opportunities for improvement. -- [x] Evaluate existing definitions found at https://design.gitlab.com/get-started/structure with a primary focus on: Foundations, Components, Regions, and Objects. -- [x] Propose definition updates and work through internal discussion. -- [x] Test updated definitions internally to make sure categories and meaning are clear. -- [x] Update IA and structure by incorporating definitions and other content organization changes. - -## Before / after - -
Definitions - -### Definitions - -| | **Before** | **After** | -| ------ | ------ | ------ | -| **Foundations** | Foundations represent perceptual patterns. These are less tangible aspects of the design system. Together they create a certain aesthetic for the product. For example, colors, typography, and icons. | Foundational items communicate the opinionated way in which basic visual design attributes, elements, and concepts come together to create a distinct GitLab personality that’s expressed in the UI. For example, color, typography, and iconography. | -| **Components** | A small design primitive. Components build upon the design foundations (typography, spacing, motion, colors, iconography, etc.) and are the reusable building blocks of the interface. For example, buttons, tabs, and input fields. | A component is a UI element that serves a singular purpose or function. Two or more simple components can combine to form a composite component that still has a single function. For example, an avatar, button, or combobox. | -| **Regions** | Regions are areas formed by combining multiple components, creating a layout section that can be reused across various pages. For example, the comments and activity feed in issues or merge requests. | _Deprecated_ | -| **Patterns** | _N/A_ | A pattern combines components and/or content elements into a repeatable, consistent group that has a shared purpose, content association, or both. For example, filtering, forms, or navigation. | -| **Page templates** | _N/A_ | A template prescribes layout and behavior for a page or common content layout. For example, an issuable, settings, or search results. | -| **Objects** | Objects capture and organize data as a single source of truth around specific tasks and user interactions. Objects are described in terms of attributes (what they contain), functions (what they do), and relationships (what they interact with). When documented as a conceptual model, objects help understand how the product works and fits together on a system level, detached from the constraints of the user interface. An effective object model tightly aligns our user's mental model with the product's data model. For example, issue, group, and merge request. | An object is a conceptual building block or concept that defines how we think about something independent of its visual representation or interaction model. For example, a job, merge request, or repository. | -
- -
Information Architecture (IA) - -### IA - -| **Before** | **After** | -| ------ | ------ | -| ![image](/uploads/e7416965f7f3a1b0db814c3e8a2bfb87/image.png) | ![image](/uploads/78262d88e192afad89d4e67b01eebca1/image.png) | -| ![image](/uploads/570c6fa88e0655ab4caf753dd74a3c01/image.png) | ![image](/uploads/fecd2dca3dcd6916f19e71d6b927710d/image.png) | - -
- -[![Figmacon.svg](/uploads/f326197d14f6fb1e342a1034e12e4386/Figmacon.svg) Working file in Figma →](https://www.figma.com/file/qYQOk3DhrswWIsRnoUTJ6J/%231378-Pajamas-IA-JE?node-id=0%3A1) - ---- - -## Retrospection - -### Good -* The IA and navigation are being updated and there were some good insights learned. - -### Bad -* This effort took so long that the other KRs didn't get worked on. - -### Try -* Breaking down even smaller.",8 -110282801,2022-06-17 09:44:52.650,Pajamas UI Kit > Form component: Update disabled state update (a11y),"## Description - -Disabled state of form items does currently not pass ~accessibility in terms of minimum contrast.\ -This updates the disabled state of the component to pass ~accessibility - -### Proposal -- Change background color from `#fafafa` -> `$gray-10` (`#f5f5f5`) -- Update Label from `$gray-400` to `$gray-500` for passing contrast (5.28:1) - -| Before | After | -| ------ | ------ | -| ![before](/uploads/552e664cab082df26eaf246f8dd465e4/before.png) | ![after](/uploads/4332494659e7cef1bd46ffe43d991dd7/after.png) | -| ![contrast_before](/uploads/7f44caa039a948a2c9e0ba37ee2bc2a2/contrast_before.png) | ![contrast_after](/uploads/a94bc76442c9f1b6351ea78b09c61d7d/contrast_after.png) | - -### Figma file - -[❖ View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/9wDCmYQtWqbclCzhE6k2TJ/Component-library?node-id=49840%3A75722) - -## Checklist - -Make sure the following are completed before closing the issue: - -### Assignee tasks: - -
Getting started: - -1. [x] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. -1. [x] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. -1. [x] Update the link to the working file under the **Figma link** section below. -1. [x] If work was not done in a branch (a merged branch will automatically be archived), move your working file - to the shared Figma project: - 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. - 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -
- -
Prior to review: - -The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: - -1. [x] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** ( + Y) to reveal invisible objects. Use **View > Zoom to Fit** (Shift + 1) to view all items on the page. -1. [x] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. -1. [x] **Frames**: Make spacing within and between frames consistent with components found on other pages. -1. [x] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. -1. [x] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. -1. [x] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. -1. [x] **Comments**: Make sure all comments and discussion are resolved. - -If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference. - -
- -
Requesting a review: - -Ask a [Foundations designer][foundations-team] to review your design. - -1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma. -1. [x] From the dropdown to the right of the file name, select ""Request review"". -1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. - -Once your file is in review, you should see a yellow ""In review"" badge to the right of the file name. - -
- -
Post review: -Once the Reviewer or Maintainer has approved your update, consider the following tasks: - -1. [x] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [x] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [x] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [x] 🎉 Congrats, you made it! You can now close this issue. - -
- -### Reviewer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] Make sure all layers are correctly named and organized. -1. [x] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. -1. [x] Ensure component descriptions and external documentation links are clear and accurate. -1. [x] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. -1. [x] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). -1. [x] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). - -
- -### Maintainer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s changes. - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] Merge the branch or add the changes or additions to the - target file. - 1. [ ] Ensure that all styles and components now belong to the target file. - 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message. - -
- -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component -[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation",1 -110124885,2022-06-14 23:01:49.627,"Draft: Pajamas scaffolding, structure, and ops","## Purpose - -Pajamas provides foundational styles and element, component guidelines, abstracted objects, and UX content, but it's less clear on how to assemble all of these disparate parts. It's these middle guiding layers of the design system that need built out to provide more visual design direction and UI consistency when it comes to implementation. - -At the same time, Pajamas needs a common vernacular with agreed upon definitions and categorization. For example, terms like ""patterns,"" ""organisms,"" and ""regions"" mean different things to everyone and time spent aligning on meaning stifles additions and system maturity. A large part of the initial effort will be to refine the GitLab design language and provide the consistent groundwork that efforts like ""unboxing"" and ""beautification"" — and future ones like them — need to stand on. Pajamas is not just _what_, but _how_, and this is what it means to have a design language and not just a design system. - -## Phases - -1. **Pajamas scaffolding** (%""15.2"") - - Definitions - - Website / design system IA and content mapping - - Gap analysis: - - Gaps in Pajamas design language - - Gaps between Pajamas and product -2. **Pajamas structure** (TBD) - - Website updates: Implement IA changes - - SSoT: What would it take to make the Pajamas site the go-to? -3. **PajamasOps** (TBD) - - Storybook: Playground, features, robust layouts, accessibility testing - - Figma: Internal plugins, designer efficiency - - Triage and contributions - - Prioritization - -## Outcomes - -- Consistency in design execution and user experience -- Shared design language -- More informed decisions and contribution -- Pajamas → Product planning and prioritization - -## Considerations - -- Pajamas documentation should be prescriptive when necessary, and guiding when not. The aim is not to have a draconian system, but one that provides meaningful constraints to foster collaboration, provide clear and informed guidance, and inspire new possibilities. -- Refining the design language gives space for efforts like tokenizing and theming to have a meaningful place. -- Gap analysis helps to define not only what areas need building out, but also the size and impact of gaps between Pajamas and the product. For example, typography is foundational, but not consumed by the product. - -## Resources and reference - -- [IBM Design Language](https://www.ibm.com/design/language/) -- [Visual Design Language: The Building Blocks Of Design](https://www.smashingmagazine.com/2020/03/visual-design-language-building-blocks/)",5 -110053010,2022-06-13 21:07:54.979,Illustration > Add XS grid size,"## Purpose - -A new extra small (XS) grid is being added to provide a size that illustration elements can be created at when they're used alongside other UI or to comprise part of a larger design. - -For example, in https://gitlab.com/gitlab-org/gitlab-svgs/-/merge_requests/794 a ""bidirectional-xs"" illustration is being added to connect two logos. Because of our third-party trademark policy we didn't want to add this to one of the logos or combine them. The 72px grid here would've been too large in relation to the logos and placed emphasis in the wrong place. - -36px was chosen instead of 32px (and base 8) in order to follow the illustration pattern where each size increases at 2x.",1 -109899028,2022-06-10 08:01:19.741,Color > Adjust $gray-10 from #fafafa to #f5f5f5,"## Description - -This is a follow-up to https://gitlab.com/gitlab-org/gitlab/-/merge_requests/87817 & https://gitlab.com/gitlab-org/gitlab/-/merge_requests/89533. - -This is a proposal to adjust the `$gray-10` we have defined in the Pajamas Design System to a bit darker nuance. -FYI: In the product we use a `$gray-normal` which is actally using the same HEX value as this proposed darker nuance. - -In https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/2868 we will update `$gray-10` for GitLab UI. - -### Proposal - -Let's add the following gray's to GitLab UI: - -| $gray10 before | $gray10 after | -| ------ | ------ | -| `#fafafa` | `#f5f5f5` | - -### Figma file - -[❖ View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/eLtdBEfc42kw2eshsyILwK/Component-library) - -## Checklist - -Make sure the following are completed before closing the issue: - -### Assignee tasks: - -
Getting started: - -1. [x] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. -1. [x] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. -1. [x] Update the link to the working file under the **Figma link** section below. -1. [x] If work was not done in a branch (a merged branch will automatically be archived), move your working file - to the shared Figma project: - 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. - 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -
- -
Prior to review: - -The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: - -1. [x] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** ( + Y) to reveal invisible objects. Use **View > Zoom to Fit** (Shift + 1) to view all items on the page. -1. [x] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. -1. [x] **Frames**: Make spacing within and between frames consistent with components found on other pages. -1. [x] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. -1. [x] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. -1. [x] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. -1. [x] **Comments**: Make sure all comments and discussion are resolved. - -If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference. - -
- -
Requesting a review: - -Ask a [Foundations designer][foundations-team] to review your design. - -1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma. -1. [x] From the dropdown to the right of the file name, select ""Request review"". -1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. - -Once your file is in review, you should see a yellow ""In review"" badge to the right of the file name. - -
- -
Post review: -Once the Reviewer or Maintainer has approved your update, consider the following tasks: - -1. [ ] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [ ] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [ ] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [ ] 🎉 Congrats, you made it! You can now close this issue. - -
- -### Reviewer tasks: - -
See tasks: - -1. [ ] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [ ] Make sure all layers are correctly named and organized. -1. [ ] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. -1. [ ] Ensure component descriptions and external documentation links are clear and accurate. -1. [ ] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. -1. [ ] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). -1. [ ] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). - -
- -### Maintainer tasks: - -
See tasks: - -1. [ ] Review and approve assignee’s changes. - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [ ] Merge the branch or add the changes or additions to the - target file. - 1. [ ] Ensure that all styles and components now belong to the target file. - 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [ ] When applicable, [publish][publishing] any library changes along with a clear commit message. - -
- -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component -[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation",1 -109573190,2022-06-03 17:12:59.765,Navigation > Document naming conventions,"In the `Menu menu discussion` meeting, it was said that we should document naming conventions for navigation. This issue is to investigate what conventions we may be able to create and then document those in Pajamas.",2 -109572586,2022-06-03 17:06:26.462,Navigation > Cross link nav docs,"In the `Menu menu discussion` meeting, it was said that there are multiple navigation docs that exist outside of Pajamas. We should cross link to these pages so it's easy to find/access. We should also consider consolidating where it makes sense. - -On the navigation page, we currently cross link to https://about.gitlab.com/handbook/engineering/ux/navigation/",1 -109510113,2022-06-02 13:44:38.428,Helping users > Update content guideline formatting,"Follow up from https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2857#note_957102484: - ->1. Make the ""GitLab repository `/doc` directory"" a link to that directory. ->1. Format the Content Guidelines as a list. I noticed it follows the same ""when… do this"" type of pattern from other sections and might be easier to parse each consideration as a separate bullet.",1 -109465890,2022-06-01 19:58:04.689,Dropdowns > Add validation notes,"Per this thread https://gitlab.com/gitlab-org/gitlab-ui/-/issues/1242#note_967906969, we should document that certain dropdowns can have validation, namely the listbox and combobox.",1 -109401960,2022-05-31 18:45:35.428,Clarify in Pajamas whether a successful save should be an alert or a toast,"### Problem to solve - -We use an info alert on the user settings page to confirm a change, but elsewhere (e.g. the Vulnerability Report), after a successful bulk action, we use a toast notification to confirm the change has been made. - -On the [alerts](https://design.gitlab.com/components/alert/#when-to-use) page, Pajamas says: -> Reaffirm to the user that a prior action, likely in a different location or context, has been successful. - -""When to use"" on the [toast](https://design.gitlab.com/components/toast/#when-to-use) page, on the other hand, says: -> Provide a contextual message based on a user's action in the same view the action took place. - -### Proposal - -With all the types of alerts we can have in one area at one time (error, warning, etc) in some places, especially the security tab of the pipeline page (see designs in https://gitlab.com/gitlab-org/gitlab/-/issues/352880#note_961677263), we should use toast notifications to confirm a saved change. - -Either way, we should update the Pajamas docs accordingly (toast, alert, and [Instant Feedback](https://design.gitlab.com/product-foundations/saving-and-feedback#instant-feedback)) to be more clear which is the suggested pattern.",3 -109024003,2022-05-24 09:10:30.482,Update the sticky component text color to match the background color,"## Description - -Update the sticky component text color to match the background color. :sparkles: - -| Before | After| -| ------ | ------ | -| ![image](/uploads/d2f7041452ae0d3a040cf6067f06518b/image.png) | ![image](/uploads/b88dbf14ec32fc65a2276ee24503dd8a/image.png) | - - - - - -### Figma file - - - -[❖ View working branch in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/wnc5x3SEy35JfUMIbtrupv/Component-library?node-id=1663%3A0) - -## Checklist - -Make sure the following are completed before closing the issue: - -### Assignee tasks: - -
Getting started: - -1. [x] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. -1. [x] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. -1. [x] Update the link to the working file under the **Figma link** section below. -1. [-] If work was not done in a branch (a merged branch will automatically be archived), move your working file - to the shared Figma project: - 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. - 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -
- -
Prior to review: - -The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: - -1. [x] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** ( + Y) to reveal invisible objects. Use **View > Zoom to Fit** (Shift + 1) to view all items on the page. -1. [x] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. -1. [x] **Frames**: Make spacing within and between frames consistent with components found on other pages. -1. [x] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. -1. [x] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. -1. [x] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. -1. [x] **Comments**: Make sure all comments and discussion are resolved. - -If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference. - -
- -
Requesting a review: - -Ask a [Foundations designer][foundations-team] to review your design. - -1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma. -1. [x] From the dropdown to the right of the file name, select ""Request review"". -1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. - -Once your file is in review, you should see a yellow ""In review"" badge to the right of the file name. - -
- -
Post review: -Once the Reviewer or Maintainer has approved your update, consider the following tasks: - -1. [ ] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [ ] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [ ] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [x] 🎉 Congrats, you made it! You can now close this issue. - -
- -### Reviewer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] Make sure all layers are correctly named and organized. -1. [x] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. -1. [x] Ensure component descriptions and external documentation links are clear and accurate. -1. [x] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. -1. [x] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). -1. [x] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). - -
- -### Maintainer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s changes. - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] Merge the branch or add the changes or additions to the - target file. - 1. [ ] Ensure that all styles and components now belong to the target file. - 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message. - -
- -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component -[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation",1 -108985322,2022-05-23 15:14:02.446,UI Kit > Fix label variant switch,"## Description - -Updated label component to make use of new component properties and added missing states to it. - -| Before | After | -| ------ | ------ | -| ![labels_problem](/uploads/e3e33493eaafadd322d8dc1b5d1a17e3/labels_problem.gif) | ![label_fix](/uploads/25bac93d543784d9a1bcb68b90dd2676/label_fix.gif) | - -### Figma file - -[❖ View working file in Figma →](https://www.figma.com/file/tWdQ8eIy7Br3Uk3qSIWOkf/) - -## Checklist - -Make sure the following are completed before closing the issue: - -### Assignee tasks: - -
Getting started: - -1. [x] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. -1. [ ] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. -1. [x] Update the link to the working file under the **Figma link** section below. -1. [ ] If work was not done in a branch (a merged branch will automatically be archived), move your working file - to the shared Figma project: - 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. - 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -
- -
Prior to review: - -The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: - -1. [x] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** ( + Y) to reveal invisible objects. Use **View > Zoom to Fit** (Shift + 1) to view all items on the page. -1. [x] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. -1. [x] **Frames**: Make spacing within and between frames consistent with components found on other pages. -1. [x] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. -1. [x] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. -1. [x] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. -1. [x] **Comments**: Make sure all comments and discussion are resolved. - -If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference. - -
- -
Requesting a review: - -Ask a [Foundations designer][foundations-team] to review your design. - -1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma. -1. [x] From the dropdown to the right of the file name, select ""Request review"". -1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. - -Once your file is in review, you should see a yellow ""In review"" badge to the right of the file name. - -
- -
Post review: -Once the Reviewer or Maintainer has approved your update, consider the following tasks: - -1. [ ] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [ ] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [ ] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [ ] 🎉 Congrats, you made it! You can now close this issue. - -
- -### Reviewer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] Make sure all layers are correctly named and organized. -1. [x] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. -1. [x] Ensure component descriptions and external documentation links are clear and accurate. -1. [x] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. -1. [x] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). -1. [x] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). - -
- -### Maintainer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s changes. - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] Merge the branch or add the changes or additions to the - target file. - 1. [x] Ensure that all styles and components now belong to the target file. - 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message. - -
- -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component -[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation",1 -108779154,2022-05-19 03:11:36.579,UI kit > Refactor banner,"## Description - -Refactoring the banner component in Figma in light of recent app updates. - -| **Before** | **After** | -| ------ | ------ | -| ![image](/uploads/43b95397ec893e9647aa9bb7579731e3/image.png) | ![image](/uploads/f67dfbae0cb8f338fd9d8a7e02228bde/image.png) | -| ![CleanShot_2022-05-18_at_22.33.12_2x](/uploads/a36286fa731eae25bd8ce60499617f59/CleanShot_2022-05-18_at_22.33.12_2x.png) | ![CleanShot_2022-05-18_at_22.28.48_2x](/uploads/41eeb14364c73d03da692e8c4f8e4e66/CleanShot_2022-05-18_at_22.28.48_2x.png) | - -### Figma file - - - -[❖ View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/jHZaeQQxK6D21f9lrjfj3c/Component-library?node-id=425%3A4) - -## Checklist - -Make sure the following are completed before closing the issue: - -### Assignee tasks: - -
Getting started: - -1. [x] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. -1. [x] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. -1. [x] Update the link to the working file under the **Figma link** section below. -1. [-] If work was not done in a branch (a merged branch will automatically be archived), move your working file - to the shared Figma project: - 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. - 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -
- -
Prior to review: - -The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: - -1. [x] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** ( + Y) to reveal invisible objects. Use **View > Zoom to Fit** (Shift + 1) to view all items on the page. -1. [x] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. -1. [x] **Frames**: Make spacing within and between frames consistent with components found on other pages. -1. [x] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. -1. [x] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. -1. [x] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. -1. [x] **Comments**: Make sure all comments and discussion are resolved. - -If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference. - -
- -
Requesting a review: - -Ask a [Foundations designer][foundations-team] to review your design. - -1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma. -1. [x] From the dropdown to the right of the file name, select ""Request review"". -1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. - -Once your file is in review, you should see a yellow ""In review"" badge to the right of the file name. - -
- -
Post review: -Once the Reviewer or Maintainer has approved your update, consider the following tasks: - -1. [ ] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [ ] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [ ] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [x] 🎉 Congrats, you made it! You can now close this issue. - -
- -### Reviewer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] Make sure all layers are correctly named and organized. -1. [x] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. -1. [x] Ensure component descriptions and external documentation links are clear and accurate. -1. [x] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. -1. [x] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). -1. [x] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). - -
- -### Maintainer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s changes. - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] Merge the branch or add the changes or additions to the - target file. - 1. [ ] Ensure that all styles and components now belong to the target file. - 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message. - -
- -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component -[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation",1 -108778498,2022-05-19 02:41:04.304,UI kit > Refactor popover,"## Description - -Refactoring the popover component in Figma in light of recent app updates. - -| **Before** | **After** | -| ------ | ------ | -| ![image](/uploads/2e18f6a97229155afe804668543d0082/image.png) | ![image](/uploads/03d9b9e2d6ea9f58f820249dab96fd2f/image.png) | -| ![CleanShot_2022-05-18_at_22.04.49_2x](/uploads/319c38984a2529dceefcf48f71e02b53/CleanShot_2022-05-18_at_22.04.49_2x.png) | ![CleanShot_2022-05-18_at_22.04.29_2x](/uploads/639fb11fbe35a749822c25be3ca0c2cb/CleanShot_2022-05-18_at_22.04.29_2x.png) | - -### Figma file - - - -[❖ View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/UrBmc6IhZN2zWQCz3HoitL/Component-library) - -## Checklist - -Make sure the following are completed before closing the issue: - -### Assignee tasks: - -
Getting started: - -1. [x] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. -1. [x] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. -1. [x] Update the link to the working file under the **Figma link** section below. -1. [-] If work was not done in a branch (a merged branch will automatically be archived), move your working file - to the shared Figma project: - 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. - 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -
- -
Prior to review: - -The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: - -1. [x] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** ( + Y) to reveal invisible objects. Use **View > Zoom to Fit** (Shift + 1) to view all items on the page. -1. [x] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. -1. [x] **Frames**: Make spacing within and between frames consistent with components found on other pages. -1. [x] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. -1. [x] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. -1. [x] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. -1. [x] **Comments**: Make sure all comments and discussion are resolved. - -If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference. - -
- -
Requesting a review: - -Ask a [Foundations designer][foundations-team] to review your design. - -1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma. -1. [x] From the dropdown to the right of the file name, select ""Request review"". -1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. - -Once your file is in review, you should see a yellow ""In review"" badge to the right of the file name. - -
- -
Post review: -Once the Reviewer or Maintainer has approved your update, consider the following tasks: - -1. [ ] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [ ] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [ ] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [x] 🎉 Congrats, you made it! You can now close this issue. - -
- -### Reviewer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] Make sure all layers are correctly named and organized. -1. [x] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. -1. [x] Ensure component descriptions and external documentation links are clear and accurate. -1. [x] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. -1. [x] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). -1. [x] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). - -
- -### Maintainer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s changes. - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] Merge the branch or add the changes or additions to the - target file. - 1. [ ] Ensure that all styles and components now belong to the target file. - 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message. - -
- -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component -[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation",1 -108700135,2022-05-17 18:53:48.379,"Pajamas Migration Day: June 10, 2022","As part of our ongoing [component migration push](https://gitlab-org.gitlab.io/frontend/epic-burndown-charts/fy23-q1/), we are hosting another Pajamas Migration Day! - -- **When:** June 10, 2022 -- **Who:** Everyone! FE, BE, Designers, Product, etc. Everyone is encouraged to contribute. -- **Where:** Your very own home or work space, but also join the `#pajamas_migration_day` slack channel to hang out and chat with fellow contributors! -- **Why:** We want to encourage a day of migrating legacy components / css to use Pajamas! -- **Bonus:** If you contribute three merge requests on Pajamas Migration Day, you can expense a meal for up to $25 USD! Please use the ~""Pajamas Migration Day"" label on your MRs to be eligible. In Expensify, use the `Meals Company Provided (Non-Client related)` category. - -**Need help?** Ping any member of the [Foundations team](https://about.gitlab.com/company/team/?department=ecosystem-foundations-team) for support or help throughout the day. We are here to assist! - -## How to contribute - -- ~~[Migrate a few angle icons to chevrons →](https://gitlab.com/groups/gitlab-org/-/epics/8087)~~ All assigned -- Or if you like buttons more than chevrons :see_no_evil: - you can pick one of the [Haml/Ruby button to Pajamas::ButtonComponent migrations](https://gitlab.com/groups/gitlab-org/-/epics/8153) -- ~~There are also a couple of [""banners"" to migrate to `Pajamas::BannerComponent`](https://gitlab.com/groups/gitlab-org/-/epics/8076) ViewComponent.~~ All assigned -- Treat migration day like a scavenger hunt! Review the product and find components/legacy CSS and update it to align with Pajamas! -- Pick up any issue that that is [ready for development](https://gitlab.com/gitlab-org/gitlab/-/issues/?sort=created_date&state=opened&label_name%5B%5D=pajamas%3A%3Aintegrate&label_name%5B%5D=OKR&assignee_id=None&first_page_size=20). - -There does not need to be a specific issue open to contribute! Starting with MRs that migrate legacy code is a great way to contribute to the effort. - -**Reminder:** Please add the ~""Pajamas Migration Day"" label to your MRs, as well as the specific component label that relates to your change (for example: ~""component:alert"")",1 -108699933,2022-05-17 18:47:40.487,Consistent dast_environment_deploy job failure in main branch,"Our pipelines are reliably failing in the `dast_environment_deploy` job with the following error message: - -> Error: release dast-default failed, and has been uninstalled due to atomic being set: Ingress.extensions ""dast-default-auto-deploy"" is invalid: annotations.kubernetes.io/ingress.class: Invalid value: ""nginx"": can not be set when the class field is also set - -Not sure who to ping regarding this issue. It looks like the [Jobs/DAST-Default-Branch-Deploy.gitlab-ci.yml](https://gitlab.com/gitlab-org/gitlab-foss/blob/master/lib/gitlab/ci/templates/Jobs/DAST-Default-Branch-Deploy.gitlab-ci.yml) template was updated recently, perhaps this is related? - -https://gitlab.com/gitlab-org/gitlab/-/commit/a91bd39f2c - -/cc @hfyngvason @jeldergl",1 -108680374,2022-05-17 12:38:53.806,Dropdown > Reconsider component naming,"## Purpose - -Discuss renaming the current **listbox** component while simplifying the dropdown variants. - -In https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2832 the dropdown component naming was discussed, specifically in regards to the listbox. A `listbox` itself can be part of a disclosure or a `combobox`, but at the moment we're identifying it as its own component that includes the trigger button to reveal it. - -It's possible we could reduce the number of documented dropdown variants by treating the listbox as a base component used in composite components. - -For example: - -- **Disclosure widget**: - - Button that opens panel of links or a mix of links and actions (buttons). - - Button that opens a `listbox` containing options (`role=""option""`). -- **Combobox**: - - Text input that opens a `listbox` containing options (`role=""option""`). -- **Menu**: - - Button that opens a panel of JavaScript app-like actions. - -### Comments from the original MR - ->This definition makes me wonder whether `GlListbox` is correctly named, since it implements the button *and* listbox … Maybe whether or not this matters depends on whether we'd ever want to implement a ""bare"" listbox that's always visible and not just in a popup. - ->We could name it`GlCollapsibleListbox` as it is named in [the specs example](https://www.w3.org/TR/wai-aria-practices-1.1/examples/listbox/listbox-collapsible.html).",2 -108306864,2022-05-10 12:19:36.328,Improve disabled & focus states of Checkboxes/Radios,"The current disabled state is quite inconsistant with other form elements and has a weak contrast. -In addition we should update the component to also allow other states as focus & disabled in instances. - -Feature branch: https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/DGZF5tMtAdIHpX0oKK7fLn/Component-library?node-id=425%3A10 - -| Before | After | -| ------ | ------ | -| ![before](/uploads/79ad6ebf0002219adacc31a97eea86c9/before.png) | ![after](/uploads/710091118ec1dc4e008e4dd617ae980e/after.png) |",1 -108072847,2022-05-05 11:28:18.294,Figma > File uploader: Align file uploader with updates from Gitlab UI,"## Description - -The file uploader dashed outline has a weak contrast. Also the indication when dropping files could be improved. - -### Proposal - -| State | Before | After | -| ------ | ------ | ------ | -| Default | ![file_upload_before](/uploads/b2397eab6ed09200a01cccce7e84b905/file_upload_before.png) | ![file_upload_after](/uploads/75f4e9a7b49ac6569a8879ba828909d4/file_upload_after.png) | -| Drag | ![file_upload_before_drop](/uploads/7afaa0b53886e0480e1a2e52b79038cf/file_upload_before_drop.png) | ![file_upload_after_drop](/uploads/c5217fb4f5637e1d0258dd740190aeae/file_upload_after_drop.png) | -| Focus | ![focus_before](/uploads/2323dabc676378571f08b0fd0892d343/focus_before.png) | ![focus_after](/uploads/c7b179d3d07a2f493c61e23532991ecf/focus_after.png) | - -### Figma file - -[❖ View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/laimESW8ZnHkoAdexjX2UB/%F0%9F%93%99-Component-library?t=BEXsPzdk4w9xJ71g-0) - -## Checklist - -Make sure the following are completed before closing the issue: - -### Assignee tasks: - -
Getting started: - -1. [x] Title the issue using this structure ""Figma > [Component name] - [Description]"". For example, Figma > Badges - Fix icon override bug. -1. [x] Add the relevant [component label](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/labels?subscribed=&search=component%3A). For example ~""component:badge"". -1. [x] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. -1. [x] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. -1. [x] Update the link to the working file under the **Figma link** section below. -1. [x] If work was not done in a branch (a merged branch will automatically be archived), move your working file - to the shared Figma project: - 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. - 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -
- -
Prior to review: - -The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: - -1. [x] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** ( + Y) to reveal invisible objects. Use **View > Zoom to Fit** (Shift + 1) to view all items on the page. -1. [x] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. -1. [x] **Frames**: Make spacing within and between frames consistent with components found on other pages. -1. [x] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. -1. [x] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. -1. [x] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. -1. [x] **Comments**: Make sure all comments and discussion are resolved. - -If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference. - -
- -
Requesting a review: - -Ask a [Foundations designer][foundations-team] to review your design. - -1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma. -1. [x] From the dropdown to the right of the file name, select ""Request review"". -1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. -1. [ ] Consider [creating a new version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Create_a_new_version) (optional) titled ""Review requested"" in the history which will create a reference point in the file's history. - -Once your file is in review, you should see a yellow ""In review"" badge to the right of the file name. - -
- -
Post review: -Once the Reviewer or Maintainer has approved your update, consider the following tasks: - -1. [ ] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [x] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [ ] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [x] 🎉 Congrats, you made it! You can now close this issue. - -
- -### Reviewer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] Make sure all layers are correctly named and organized. -1. [x] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. -1. [x] Ensure component descriptions and external documentation links are clear and accurate. -1. [x] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. -1. [x] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). -1. [x] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). - -
- -### Maintainer tasks: - -
See tasks: - -1. [x] Review and approve assignee’s changes. - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] Merge the branch or add the changes or additions to the - target file. - 1. [x] Ensure that all styles and components now belong to the target file. - 1. [x] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message. - -
- -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component -[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation - -",1 -107923187,2022-05-03 12:57:25.153,List > Deprecate list as a component,"In https://gitlab.com/gitlab-org/gitlab-ui/-/issues/1198#note_930969297 it was proposed and validated that **List** should not be a component for these reasons: - ->We don't create components of other semantic markup elements, like headings, etc., and I don't think we need to here. - -As an outcome of this issue, we'll deprecate the current [List](https://design.gitlab.com/components/list) page in Pajamas and determine if any of the content from that page should be repurposed elsewhere. - -We should also determine if the ~""component:list"" label should be updated with a deprecation notice or removed. The assumption is removal since there was never a component built in GitLab UI to begin with.",2 -107914223,2022-05-03 09:59:53.771,Create structure diagram for the Form component,"### Description - -Create structure diagram for the Form component. - -### Checklist - -Make sure the following are completed before closing the issue: - -1. [ ] Assign the correct component label to this issue. -1. [ ] Create an MR with the additions or updates needed. -1. [ ] When applicable, [create an issue using the `Figma update` issue template][pajamas-figma-update-template] to update the component in Figma, and mark it as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [ ] When applicable, [create an MR in GitLab UI][gitlab-ui-mr] to update the component. If you do not have capacity or are unable to update the component directly, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template]. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one. -1. [ ] When introducing a major or breaking change, communicate the changes within the Engineering Week in Review and UX Weekly meeting. -1. [ ] 🎉 Congrats, you made it! You can now close this issue. - - - -[gitlab-ui-mr]: https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/new -[component-lifecycle]: https://design.gitlab.com/get-started/lifecycle -[pajamas-figma-update-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Figma%20update -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component",1 -107905924,2022-05-03 07:52:07.390,Add guidelines for hiding the UI on empty states,"@dmoraBerlin and I have been chatting on Slack about the work we're doing on the empty group page: https://gitlab.com/gitlab-org/gitlab/-/issues/267014 This issue has been open for a while and now we've aligned on showing the main two options that make most sense in an empty group and hiding the UI that is usually on a group page. Daniel then warned me about Taurie's comment on another issue that could be related: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/78012#note_923457878 - -## Proposal - -Let's add some guidance to the empty state guidelines, establish that it's ok to hide the UI in some occasions but that it needs to be carefully thought through as there are cases when showing the UI, even if there's seemingly nothing to show still makes sense and offers more value to the user and hence produces a better user experience.",2 -107880281,2022-05-02 15:40:10.198,Content Security Policy (CSP) blocks iFrames on design.gitlab.com,"## Problem to solve - -User on LinkedIn reported - ->>> -FYI, I noticed that the CSP blocks some iFrames on multiple pages. ->>> - -![image](/uploads/c2b451667dce7e4e233641327aeac38e/image.png) - -Created this issue following the contribution guide in https://design.gitlab.com/get-started/contribute - - -## Resources - -- LinkedIn comment: https://www.linkedin.com/feed/update/urn:li:activity:6925139998321053697?commentUrn=urn%3Ali%3Acomment%3A%28activity%3A6925139998321053697%2C6926915289175490563%29",1 -107880056,2022-05-02 15:34:13.247,Figma: add icon to component library,"As Figma now supports Emojis in Filenames to be set as Tab Icon, I'd vote -that we set one for the Pajamas Component library. - -This can be very helpful to easier identify the tab of the component library! - -### Proposal -Add the orange book emoji 📙\ -Other Emoji proposals are welcome, too - -| Before | After | -| ------ | ------ | -| ![figma_before](/uploads/0d43d503085af6bf018c2b5ce772b8a2/figma_before.png) | ![figma_after](/uploads/4e73d78166ab8caa093207f0e1169d6f/figma_after.png) | - -### What's needed -Change Filename from `Component library` to `📙 Component library`, that's it! :rocket:",1 -107853598,2022-05-02 08:14:58.025,Alert component: make icon optional,"As in https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/2784 (and https://gitlab.com/gitlab-org/gitlab/-/merge_requests/86006 for the HAML version) we introduced the option to hide the icon, this issue will cover the Figma part to show/hide it. - -| with Icon | without Icon | -| ------ | ------ | -| ![image](/uploads/d81d17c2ec54d8dcb19fdcb2fbc316e4/image.png) | ![image](/uploads/02be21754330b881ac77d4698d93b8d7/image.png) | - -### Figma -I created a branch with the needed changes to make the icon optional: -https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/jChRnVS9BonCCiQNlXaFPj/Component-library?node-id=425%3A1",1 -107372004,2022-04-28 09:50:30.636,Figma pages list improvements,"Let's improve the Figma pages list to add some visual hiearchy. - -| Before | After | -| ------ | ------ | -| ![pages_before](/uploads/3746d088f6ca6a08477fc6e0915e52d3/pages_before.png) | ![pages_after](/uploads/ca0a0a804186df1ed5700541acc7e3b1/pages_after.png) | - -Branch: https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/nrjAlk336791WXFtpC88w0/Component-library?node-id=3050%3A0",1 -107361787,2022-04-28 07:43:09.236,Dropdown > Consider consistent widths for the dropdown panel and inputs,"## Problem - - - -Currently we use inconsistent widths for the dropdown inputs and the dropdown panels. The problems I see: - -- Often times the panel width doesn't match the dropdown button or input width -- The dropdown buttons and inputs are sometimes too long for the content - -| The dropdown could match the input in width. | The dropdown could match the dropdown button in width. | -| ------ | ------ | -|![image__60_](/uploads/01772f1fddf7728f1151dce5bfaf3bfa/image__60_.png) | ![image](/uploads/33f92e2a7863589bb685e08ddf111532/image.png) | - -| Example in the ""new MR"" page with matching input and dropdown panel width | -| ------ | -| ![image](/uploads/d3c584301531d987e7d1b0a02c55481a/image.png) | - -## Proposal - -I wonder if having set input field widths like `sm` `md` `lg` and `xl` would cover most cases in the product. If we already have fixed sizes for the dropdown button, input, and the dropdown panels, can we make the sizes match so the panel width can be same as the input in most cases? - -The width of the dropdown button or input will be selected based on the average expected input string length, and the dropdown width should match the button/input width, except when the input is shorter than the dropdown panel min width. - -It'd make the input much more consistent visually. - -### Checklist - -Make sure the following are completed before closing the issue: - -1. [ ] Assign the correct component label to this issue. -1. [ ] Create an MR with the additions or updates needed. -1. [ ] When applicable, [create an issue using the `Figma update` issue template][pajamas-figma-update-template] to update the component in Figma, and mark it as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [ ] When applicable, [create an MR in GitLab UI][gitlab-ui-mr] to update the component. If you do not have capacity or are unable to update the component directly, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template]. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one. -1. [ ] When introducing a major or breaking change, communicate the changes within the Engineering Week in Review and UX Weekly meeting. -1. [ ] 🎉 Congrats, you made it! You can now close this issue. - - - -[gitlab-ui-mr]: https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/new -[component-lifecycle]: https://design.gitlab.com/get-started/lifecycle -[pajamas-figma-update-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Figma%20update -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component",2 -107333098,2022-04-27 21:31:33.210,Update homepage banner,"## Purpose - -Update the Pajamas homepage to incorporate elements from the brand update and to remove elements from the background image that could become out of date (also, this will scale better than the current image that gets squished). - -[View Figma working file →](https://www.figma.com/file/5ymbd6NElkEPD027vK570d/%231326-Pajamas-banner-JE?node-id=4%3A20) - -| **Before** | **After** | -| ------ | ------ | -| ![image](/uploads/b81ecb7c4c1a519cf8fe10d7509bd614/image.png) | ![image](/uploads/273bcc77b145ae356ea78d41d719ca27/image.png) |",1 -107241908,2022-04-26 19:34:21.883,VPAT > Introduce VPAT 2.4 WCAG template,"## Purpose - -GitLab currently uses the [VPAT 2.4 508 template](https://www.itic.org/dotAsset/7d1524dc-e602-47be-8276-ce32bdd58d6c.doc) that uses WCAG 2.0 Level AA Success Criteria as a reference. This doesn't satisfy the needs of those wanting to know where GitLab stands with WCAG 2.1, which is the latest release (WCAG 2.2 is still in draft). For that, there's a separate [VPAT 2.4 WCAG](https://www.itic.org/dotAsset/7edcd54d-c6a6-4649-8375-4a0f0c68eff2.doc) template that we can introduce. For a list of all VPAT templates, visit https://www.itic.org/policy/accessibility/vpat. - -### Process - -- Update navigation in Pajamas to create a ""GitLab Accessibility Conformance Report"" dropdown that reveals two options: - - VPAT 2.4 508 - - VPAT 2.4 WCAG -- Update the current ""GitLab Accessibility Conformance Report"" page title to ""VPAT 2.4 508"" -- Add a new ""VPAT 2.4 WCAG"" page - - Copy the WCAG 2.0 2.0 data from the VPAT 2.4 508 page into this page - - Complete an evaluation that adds conformance findings for the [success criteria added in WCAG 2.1](https://www.w3.org/WAI/standards-guidelines/wcag/new-in-21/) -- Clarify VPAT and WCAG level on the [Statement of Compliance](https://design.gitlab.com/accessibility/a11y) page",3 -106528622,2022-04-12 13:29:27.580,Migrate to embedded stories in components/tooltip.md,"Migrate away from legacy examples to embedded stories in `components/tooltip.md` - -- [ ] Migrated the `vueComponents` property to `stories` in the frontmatter. -- [ ] Migrated `` components to ``. -- [ ] Removed the associated examples from the examples/ directory.",1 -106528619,2022-04-12 13:29:25.809,Migrate to embedded stories in components/sorting.md,"Migrate away from legacy examples to embedded stories in `components/sorting.md` - -- [ ] Migrated the `vueComponents` property to `stories` in the frontmatter. -- [ ] Migrated `` components to ``. -- [ ] Removed the associated examples from the examples/ directory.",1 -106528613,2022-04-12 13:29:22.922,Migrate to embedded stories in components/infinite-scroll.md,"Migrate away from legacy examples to embedded stories in `components/infinite-scroll.md` - -- [ ] Migrated the `vueComponents` property to `stories` in the frontmatter. -- [ ] Migrated `` components to ``. -- [ ] Removed the associated examples from the examples/ directory.",2 -106528611,2022-04-12 13:29:21.088,Migrate to embedded stories in components/spinner.md,"Migrate away from legacy examples to embedded stories in `components/spinner.md` - -- [ ] Migrated the `vueComponents` property to `stories` in the frontmatter. -- [ ] Migrated `` components to ``. -- [ ] Removed the associated examples from the examples/ directory.",1 -106190995,2022-04-06 16:34:16.384,Illustration library > Update Figma assets to align with brand,"Update the [Illustration library](https://www.figma.com/file/1ui9w228X0S5WxaD0SRdIA/Illustration-library?node-id=0%3A1) in Figma to align with updates in https://gitlab.com/groups/gitlab-com/marketing/corporate_marketing/-/epics/201 and https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1288. - -Updates will have to happen to: - -- Styles -- Grid -- Components -- Other? - -[View working file in Figma →](https://www.figma.com/file/1ui9w228X0S5WxaD0SRdIA/branch/tMPk4cKFcvn2A0GAp0M932/Illustration-library?node-id=0%3A1) - -Updates to tanuki avatars and specific illustrations in the library will happen based on the results of https://gitlab.com/groups/gitlab-org/-/epics/7847 and will be handled on an individual basis.",8 -106190897,2022-04-06 16:33:52.339,Illustration guidelines > Update to align with brand,"Update https://design.gitlab.com/product-foundations/illustration to align with updates in https://gitlab.com/groups/gitlab-com/marketing/corporate_marketing/-/epics/201. - -Adaptations may have to be made to account for: - -- Grid (dimensions) -- Figma -- Color -- Light/dark UI -– etc.",3 -106036928,2022-04-04 14:03:13.058,Text input > Move or remove character counter add-on," - -### Description - -In https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1283, the proposal is to move the character counter outside of the textarea bounds. Given that a similar character counter exists as an add-on in the text input, this issue is to help determine if the character counter should be moved outside of the input bounds and treated as help text (which it is), or to remove it altogether if it's unused. - -**Note**: The character counter add-on doesn't currently exist in GitLab UI. - -### Proposal - -Two options: - -1. Remove the character counter from the text input altogether if there are no use cases to support it. - - Benefits: - - No need to have a build effort in GitLab UI. - - Removing unneeded/unused options. -1. Move the character-counter outside of the input bounds and treat as help text. - - Benefits: - - More room for content within the input bounds. - - Better UX by providing more helpful feedback than just a single number. - - More consistency with textarea proposal and use of help text. - - Simplification of component both in the UI kit, and in code. - - More accessible by providing meaningful feedback outside of the input bounds. - -| Option A | Option B* | -| ------ | ------ | -| ![CleanShot_2022-04-04_at_08.59.57_2x](/uploads/e7247028197e4afb335ea9c39c165a2f/CleanShot_2022-04-04_at_08.59.57_2x.png) | ![image](/uploads/f1ca563e3cab0169b40ae5a2de5f839c/image.png) | - -\* Option B could either use a {#/#} pattern or more natural text. Also explored in https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1283#proposal. - -**Questions** - -- Is there anywhere in the product that currently uses a character counter on a text input? -- Is there a current use case for the character counter that some form of help text wouldn't satisfy? - -### Figma file - - - -[View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/ubxFCR4pADM7ZfMJ7ZvyOU/Component-library?node-id=49840%3A75722) - -### Checklist - -Make sure the following are completed before closing the issue: - -1. [x] **Assignee**: Design in your working file. When applicable, follow our - [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. -1. [x] **Assignee**: Update the link to the working file in the issue - description. -1. [x] **Assignee**: Ask a [Foundations designer][foundations-team] - to review your design (ensure they have edit permissions in Figma). -1. [ ] **Reviewer**: Review and approve assignee’s design. Specific design - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [ ] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer] - for final review (make sure they have edit permissions in Figma). -1. [ ] **Maintainer**: Review and approve assignee’s changes. -1. [ ] **Maintainer**: Merge the branch or add the changes or additions to the - target file. - 1. [ ] Ensure that all styles and components now belong to the target file. - 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [ ] **Maintainer**: When applicable, [publish][publishing] any library - changes along with a clear commit message. -1. [ ] **Assignee**: If work was not done in a branch (a merged branch will automatically be archived), move your working file - to the shared Figma project: - 1. [ ] For Component Library changes, move your file to the [**Component archive**][component-archive] project. - 1. [ ] For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. [ ] If you’re a community contributor, please consider [transfering ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -1. [ ] **Assignee** (or Maintainer, for community contributions): If it’s a new - pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [ ] **Assignee**: When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [ ] **Assignee**: When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [ ] **Assignee**: 🎉 Congrats, you made it! You can now close this issue. - -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure -[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/.gitlab/merge_request_templates/component-guideline.md -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component -[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation",1 -105911042,2022-04-01 20:29:38.942,Dropdowns > Determine Pajamas IA to support new variants,"## Purpose - -In order to support the new ""dropdown"" components from the work in https://gitlab.com/groups/gitlab-org/-/epics/1059, we should consider how we might update the Pajamas navigation to help make it clear that there's more than one type of what is considered a dropdown. For example, a listbox, menu, or disclosure widget, etc. - -## Proposal - -Use ""Dropdown"" as a component category and have individual pages underneath for each type of implementation.",1 -105906122,2022-04-01 18:27:07.360,Textarea > Update character counter UX and placement," - -### Description - -Reconsider the placement of the character counter text and reconsider how the information can be more clearly conveyed. The current counter shows one number, but doesn't provide any comparison. - -As uncovered in https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/2738#note_896569524, the current placement of the counter collides with both text within the textarea and the scrollbar. - -### Proposal - -- Move the character counter outside of the textarea bounding box. -- Left align the character counter. This follows other form practices where labels and controls are left aligned and help with scanability. -- Use either a text explanation of what's happening with the counter, or two values so that the limit is always visible. -- The character counter is basically help text, so it seems to make sense to treat it as such. Additional help text and any validation messages would be below the character counter. -- Remove text highlight (adds a lot of development complexity). -- Only change the color for text when the count has been exceeded. The blue conflicts with text that is linked. - -| **Current** | **Option A with {#}/{#}** | **Option B with text** | -| ------ | ------ | ------ | -| ![image](/uploads/60ce1c2017854ba471fb0035dc0658cb/image.png) | ![image](/uploads/24d0d967ee662bd2ad3c0e1fe2ea63b1/image.png) | ![image](/uploads/5685967d635bcde1e9975bda9ef49221/image.png) | - -#### Accessibility considerations - -- Visible feedback should also be available/announced for screen reader users. For example, after a pause in typing the limit status is announced via an `aria-live=""polite""` region. -- The placement of the counter could be out of view with screen magnification turned on, but form validation should help with any error remediation. - -### Figma file - - - -[View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/ubxFCR4pADM7ZfMJ7ZvyOU/Component-library?node-id=49840%3A75722) - -### Checklist - -Make sure the following are completed before closing the issue: - -1. [x] **Assignee**: Design in your working file. When applicable, follow our - [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. -1. [x] **Assignee**: Update the link to the working file in the issue - description. -1. [x] **Assignee**: Ask a [Foundations designer][foundations-team] - to review your design (ensure they have edit permissions in Figma). -1. [x] **Reviewer**: Review and approve assignee’s design. Specific design - questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. -1. [x] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer] - for final review (make sure they have edit permissions in Figma). -1. [ ] **Maintainer**: Review and approve assignee’s changes. -1. [ ] **Maintainer**: Merge the branch or add the changes or additions to the - target file. - 1. [ ] Ensure that all styles and components now belong to the target file. - 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. -1. [ ] **Maintainer**: When applicable, [publish][publishing] any library - changes along with a clear commit message. -1. [ ] **Assignee**: If work was not done in a branch (a merged branch will automatically be archived), move your working file - to the shared Figma project: - 1. [ ] For Component Library changes, move your file to the [**Component archive**][component-archive] project. - 1. [ ] For all other changes, move your file to the [**Misc archive**][misc-archive] project. - 1. [ ] If you’re a community contributor, please consider [transfering ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. -1. [ ] **Assignee** (or Maintainer, for community contributions): If it’s a new - pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. -1. [ ] **Assignee**: When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [ ] **Assignee**: When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. -1. [ ] **Assignee**: 🎉 Congrats, you made it! You can now close this issue. - -[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations -[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components -[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team -[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com -[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes -[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure -[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/.gitlab/merge_request_templates/component-guideline.md -[component-archive]: https://www.figma.com/files/project/5472112/Component-archive -[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive -[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component -[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation",1 -105744407,2022-03-30 10:56:41.008,Badge > 12px and 16px icon Figma variants behave the same way,"# Issue - -Following on from the changes in #1280+ - -Badges with 16px icons retain their icon overrides when changing variation. - -Badges with 12px icons do not retain their icon overrides when changing variation. - -| Behaviour (16px) | Behaviour (12px) | -| ------ | ------ | -| ![Kapture_2022-03-30_at_11.45.21](/uploads/afd07cf52d0cadefca2d28095909dc60/Kapture_2022-03-30_at_11.45.21.gif) | ![Kapture_2022-03-30_at_11.47.10](/uploads/76a448e35ccffb43c6bd7818bebf8035/Kapture_2022-03-30_at_11.47.10.gif) | - -# Proposal - -Make 12px and 16px icon Figma variants behave the same way. - -As discussed in the Figma branch for #1280 there are some tradeoffs to be aware of: - -- Lose a 'sensible' default - -### [Figma branch for review :eyes:](https://www.figma.com/file/xIqrqxGgcl50I8akiQzfmG/%231281-badge-12px-and-16px-icon-override-parity?node-id=19947%3A350) - -
Full conversation: - -Hey Jeremy Elder Nadia Sotnikova - -here's a little bug fix for the 12px icon variants to fix -- Colour persistence when changing icon -- Icon persistence when changing variant - -This makes the 12px icon behaviour the same as the 16px icon behaviour. - -However, it does come with some tradeoffs -- Lose the 'sensible default' icon for each status - -wdyt? - -Changes: -- base components: Rename icon symbol layers -- base components: Relink icons to icon library -- variant components: Update to use naming from base component -- variant components: use the same icon to allow icon change persistence - ---- - -Dan MH ""Lose the 'sensible default' icon for each status"" might be a dealbreaker for me. These have specific icon/color relationships that should exist out of the box. - ---- - -Jeremy Elder I respect and understand that. - -I found this unexpected behaviour when trying to add a badge to the Single Stat - https://www.figma.com/file/17NxNEMa7i28Is8sMetO2H/Data-Visualization?node-id=383%3A72 - -It is a pretty high friction process in its current form. And the defaults aren't sensible here. -To clarify — my expectation was for these to follow the same persistence rules as 16px icons. - -The good news is, I'm 90% sure there is an alternative way we can set these up: -- Icon swaps use the right colour -- Variant (colour) swaps change the icon to the icon defined in the variant. - ---- - -Dan MH would you be good with me updating this branch to the latest? It'll include the new tier badge. - ---- - -Jeremy Elder I'd prefer to do it so I can remember what the changes were see_no_evil emoji - -But only if we think we will proceed with any of these updates? - -Otherwise we can just delete the branch - ---- - ->But only if we think we will proceed with any of these updates? - -I think it's a valid proposal if you're 90% sure it can be done! -Applied changes from main, so it may have reset the icons here. - ---- - -To confirm the desired/proposed behaviour: - -- 12px icon badges come bundled with an icon -- Icon changes maintain the correct colour to match the badge pill -- Changing the colour variant changes the icon to the bundled icon - -If I'm tying myself in knots trying to explain I can jump on a quick sync at some point - -Ok thats all done, and I think it is an improvement as is. :) - -However, for many of my use cases the 'sensible defaults' hinder rather than help — so it would be nice to consider changing this behaviour to match the 16px icons in the future! - ---- - -Dan MH after some consideration, I don't know that it's helpful to be as prescriptive here. - -I had to circle back and through about the ability for you to extend these for your use case, but then that indeed would mean overriding this use case, but this use case is prescriptive and not universal, which isn't what we're going for here. Follow? - -So… I'm up for reworking these to use generic defaults that can be updated at the time of use. - -What could be helpful, would be adding out instances of the different color/icon/size associations commonly found. Thoughts? - ---- - -Thanks for the continued discussion here Jeremy Elder . - -Honestly I do see both sides of it. - -My workaround was going to be to create extension of these (and other) symbols that match Optimizes use case and maintain them in an Optimize library. - -I don't know what is best for the system and its users. Happy to follow your lead here. - -I do think merging as-is would be an improvement, perhaps we could open this conversation wider for the last bit? - ---- - -Dan MH Figma is having a tough go at spelling out what the changes are that I'm approving, could you unpack it a little further in the review description when you have a moment? - ---- - -Jeremy Elder I've documented it in this issue https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1280 - -I wasn't expecting this much discussion, otherwise I would have created it sooner :D -
",1