diff --git "a/7071551.csv" "b/7071551.csv" deleted file mode 100644--- "a/7071551.csv" +++ /dev/null @@ -1,4885 +0,0 @@ -issuekey,created,title,description,storypoints -14034537,2018-09-10 14:00:59.295,Add bootstrap-vue's alert,Add https://bootstrap-vue.js.org/docs/components/alert to gitlab-ui,4 -13900356,2018-09-04 19:16:14.202,Formalize utility-first css preference,"## Proposal - -Let's formalize a ""utility-first"" CSS preference (this is different than ""utility-only""): - -1. Start with utility classes. -2. If composing utility classes into a component class removes code duplication and encapsulates a clear responsibility, do it. - -**Why?** - -- ""utility-first"" encourages the organic growth of component classes. -- It prevents the creation of one off not reusable classes. -- It keeps component classes cohesive, since they can be combined with other utility classes. -- It also encourages the creation of design-centered classes (e.g. button, alert, input), rather than domain-centered classes (e.g. security-report-widget, commit-header-icon). - -**Inspiration:** - -- [Tailwind](https://tailwindcss.com/docs/extracting-components/) - -## Description - -Throughout all Frontend projects, it is unclear when to prefer utility classes vs. component classes. Let's formalize our preference and add it to our FE documentation. - -**What are utility classes?** - -`.d-flex.prepend-top-default.append-bottom-default` - -[Bootstrap4 introduced many utility classes](https://getbootstrap.com/docs/4.1/utilities/) that each apply a single CSS rule. We've also adopted this pattern and created some custom utility classes. These are helpful for quickly overriding styles that are highly specific. - -**What are component classes?** - -`.component-header` - -This is the common practice of creating CSS classes that encapsulate a logical set of rules. - -## Analysis - -**What are our goals?** - -- Increase maintainability -- Reduce CSS bloat - -**Advantages of utility classes:** - -- Prevents the need for one-off CSS classes that are never reused - -**Disadvantages of utility classes:** - -- Harder to read -- Harder to edit in the browser inspector -- The set of utility classes applied to an element is not reusable (although the Vue component itself is reusable) - -**Advantages of component classes:** - -- Easier to read -- Easier to edit in the browser inspector -- Reusable -- Semantically describes the HTML element - -**Disadvantages of component classes:** - -- When reused in the wrong place, it can cause coupling of unrelated elements, hurting modifiability. -- Naming of these classes can easily be inconsistent and unintuitive (e.g. wrapper, container, content, etc. - -## Conclusion - -There is nothing keeping us from doing both, but using either inappropriately leads to a brittle style sheet. `utility-first` is a pragmatic way to ensure we are creating the right kind of component classes. - -## Related Resources - -- https://davidtheclark.com/on-utility-classes/ -- https://adamwathan.me/css-utility-classes-and-separation-of-concerns/",1 -13436092,2018-08-14 17:57:10.748,Document contribution steps on how to create wrapped components,"Document contribution steps on how to create wrapped components - -## Steps -1. Select a component -1. Determine the scenarios (different types of implementations) in which this component is used in gitlab-ce/ee -1. Document those scenarios in an issue -1. Select a scenario that is implemented in gitlab-ce/ee that you will replace with your component -1. Create a MR to [gitlab-ui](https://gitlab.com/gitlab-org/gitlab-ui/) implementing your new component - 1. Be sure to name your MR `feat: ` as that is needed for our npm release CI job - 1. Create `component.vue` in `components/` directory - 1. Create a story `component.js` in `stories/` directory - 1. Run `yarn test --updateSnapshot` to generate your image snapshots for diffing -1. Create a MR to gitlab-ce/ee to replace the scenario implementation that you previously selected - 1. Update your `package.json` dependency reference of `@gitlab-org/gitlab-ui` to the URL output of the `upload_artifacts` ci job in your gitlab-ui MR - 1. Run `yarn install` to make sure that the `gitlab-ui` contents are installed - 1. Add a new component import to `app/assets/javascripts/commons/gitlab_ui.js` so that your component is globally registered -1. Once you've verified that your integration MR to gitlab-ce/ee is working, assign a maintainer to review both gitlab-ui and gitlab-ce/ee MRs -1. Maintainer will merge the gitlab-ui MR, run the manual CI job on `master` to make a new release onto NPM -1. (You or maintainer) will update your integration MR `package.json` dependency reference to the newly released `gitlab-ui` version -1. Maintainer will merge the integration MR - -## Methods to streamline steps -1. Create CLI (eg. yeoman) to create templates for gitlab-ui MR https://gitlab.com/gitlab-org/gitlab-ui/issues/14 - 1. Auto generate `component.vue` in components directory - 1. Auto generate `component.js` in stories directory -1. Create system for checking commit messages and MR titles so that they fit the semantic release format",2 -13320937,2018-08-08 14:59:03.009,Add bootstrap-vue's pagination,"Add bootstrap-vue's pagination - -## Existing Scenarios in CE - -- Navigation-based Vue component: pagination buttons are links to next/previous result pages (requires page reload) - -## Existing Implementations in CE - -- [table_pagination.vue](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/assets/javascripts/vue_shared/components/table_pagination.vue) is used in: - - [container.vue](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/assets/javascripts/environments/components/container.vue) - - [groups.vue](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/assets/javascripts/groups/components/groups.vue) - - [pipelines.vue](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/assets/javascripts/pipelines/components/pipelines.vue) - - [table_registry.vue](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/assets/javascripts/registry/components/table_registry.vue) -",4 -13320871,2018-08-08 14:55:30.738,Add bootstrap vue's tooltip," -",4 -13319763,2018-08-08 13:56:36.035,Add bootstrap vue's modal to gitlab-ui,"## Scenarios of modal's in GitLab -- Dynamic content modal - - One modal DOM element with dynamic data loaded across multiple button triggers -- 1 to 1 modal - - One modal DOM element mapped to one button trigger -- Button in HAML, Modal in Vue - -## Current implementations of modal's in GitLab -- [gl_modal.vue](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/assets/javascripts/vue_shared/components/gl_modal.vue) - 11 instances in CE - - Dynamic content modal (4 count) - - 1:1 (3 count) - - button in HAML (4 count) -- [deprecated_modal.vue](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/assets/javascripts/vue_shared/components/deprecated_modal.vue) - 7 instances in CE - - Dynamic content modal (1 count) - - 1:1 (1 count) - - button in HAML (5 count)",4 -13309501,2018-08-08 07:22:52.428,add lint,we should copy eslint (and probably prettier) config from gitlab-ce repo - https://gitlab.com/gitlab-org/gitlab-ce/blob/master/.eslintrc.yml,3 -30791244,2018-07-10 10:46:23.914,Frontend for showing × on label to remove the label in sidebar,"We add a chip with an `x` icon (`icn/close`) that can be clicked to delete the label. The chip will change its style and show a background on hover and active states. - -The shape of the chip will be a `16px x 16px` circle. The icon inside should be `8px x 8px`. The margin with the label name is `2px` and the padding on the right side of the chip is `4px`. Spec previous will be uploaded with all these measurements. - -The target area of the chip will be a `16px x 16px` square independently of its shape. - -The hover state for the circle should revert to the color in the label when a white background is used (such as with scoped labels) and the 'x' icon color should be the same color as either the label color or the text color when on a white background (if applicable). - -### Solution -![Screen_Recording_2020-06-16_at_11.24.51_AM](/uploads/196aa5750ce9b3b6f770fb27e740977a/Screen_Recording_2020-06-16_at_11.24.51_AM.mov) - -[See Figma UI Pajamas kit for more details on tokens](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Pajamas-UI-Kit?node-id=425%3A141) - -
-### Previous solution proposal - -We currently underline the label's name when hovering. This underline should be removed when hovering over the chip. - -| States | Sidebar | -| ------ | ------- | -| | - -The colors of the badge are based on the label name color: - -| | Resting | Hover | Active | -| --- | ------- | ----- | ------ | -| Icon | Color: `same as text`, Opacity: `100%` | Color: `same as text`, Opacity: `100%` | Color: `same as label`, Opacity: `100%` | -| Icon Background | Color: `none`, Opacity: `0%` | Color: ` same as text`, Opacity: `30%` | Color: `same as text`, Opacity: `100%` | -
- -### In scope -- This should apply to issue, merge request, and epic pages. -- This should apply to the slide out board sidebar for project boards and group boards.",2 -12117018,2018-06-18 11:24:57.593,Automated documentation for components,We need a way to build automated documentation for our components and automatically publish them,3 -18439101,2017-01-03 22:31:32.158,Update search components in gitlab-ui,"Guidelines: -https://design.gitlab.com/components/search - -Specs: https://gitlab-org.gitlab.io/gitlab-design/hosted/design-gitlab-specs/search-spec-previews/ - -A list of all searchboxes throughout the application (WIP): -https://docs.google.com/spreadsheets/d/13y5NMHi7VUs8jNeEBuMd5C5PcR_hdUfDdwKxLOyIjWU/edit#gid=0 - -## Proposal - - -| **1. Search by typing** | **2. Search by enter/click** | -|------------------|-----------------------| -| ![image](/uploads/d5acb38884e6d7f1ec20b39a45419628/image.png)
*Default -> Typing (spinner indicates background activity) -> Show the clear icon when there's no background activity*

- Search icon placed in the left edge of search box
- Lack of button indicates automatic search
- Focus search box when clear icon is clicked
- Hide the clear icon when search box is empty | ![image](/uploads/62102ff170506ba0f7c13268f2faf679/image.png)
*Default -> Typing (show clear icon)*

- Search icon in the button
- Button indicates the need for confirming/triggering search
- Focus search box when clear icon is clicked
- Hide the clear icon when search box is empty | - -And also update the most commonly and prominently used one so it's better aligned with the 2. from above. - -![image](/uploads/c19521fd99e7a30a269bb30a056b303e/image.png) - -Old description: - -
-### Resources -FE @timzallmann - -We have a number of differently styles search boxes across the site. - -Here are three different examples all on the same page: - -![Screen_Recording_2017-01-03_at_02.29_PM](/uploads/bfa158f950e2786c4fed39153c7838de/Screen_Recording_2017-01-03_at_02.29_PM.gif) - -Let's standarize all the search boxes. The magnifying glass icon should remain, even when text is entered into the search field. We should remove the clear icon, as it doesn't provide enough value. - -### Proposal - -Update the related search components in `gitlab-ui` - -![Screen_Shot_2017-06-19_at_3.37.13_PM](https://gitlab.com/gitlab-org/gitlab-ce/uploads/a759276a6e90da5be69de47ce801c4d3/Screen_Shot_2017-06-19_at_3.37.13_PM.png) - -![Screen_Shot_2017-06-19_at_3.46.34_PM](https://gitlab.com/gitlab-org/gitlab-ce/uploads/eb73c41970e0145abf52e68d369ebb2f/Screen_Shot_2017-06-19_at_3.46.34_PM.png) - -
",5 -56241907,2020-07-14 00:41:11.270,GlIcon: Add `data-testid` attribute,"Per this thread: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/36240#note_378455487 - -Occasionally we need to click on an icon in E2E tests. To avoid using CSS classes we should add a `data-testid=""{icon_name}-icon""` attribute to `GlIcon`. - -Update https://gitlab.com/gitlab-org/gitlab/-/blob/e044f3946a8773cdeeb4bc8b283ef12b906bfc52/qa/qa/ee/page/group/settings/general.rb#L69 once this is completed",1 -54331804,2020-07-11 13:18:25.674,Upgrade BootstrapVue to v2.21.2 & Bootstrap to v4.5.x,"- BootstrapVue v2.21.2 changelog: https://bootstrap-vue.org/docs/reference/changelog#v2212 -- Bootstrap v4.5.3 changelog: https://github.com/twbs/bootstrap/releases/tag/v4.5.3 - -Let's make sure that GitLab UI uses BootstrapVue's latest version so that we can benefit from all the features of the underlying components library. This will be especially useful as we work towards upgrading to Vue 3, as we'll want to make sure that our libraries are compatible with Vue's new APIs. - -Note that as of writing this, BootstapVue is not yet compatible with Vue 3: https://github.com/bootstrap-vue/bootstrap-vue/issues/5196 - -Since we're currently several versions behind the latest BootstrapVue, we will proceed by upgrading to each minor version individually so that we can better evaluate the impacts and fix what needs to be fixed. - -| Version | MR | -| ------------------------------------------------------------------- | ------------------------------------------------------------- | -| [v2.14.0](https://bootstrap-vue.org/docs/reference/changelog#v2140) | https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/2150 | -| [v2.15.0](https://bootstrap-vue.org/docs/reference/changelog#v2150) | https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/2151 | -| [v2.16.0](https://bootstrap-vue.org/docs/reference/changelog#v2160) | https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/2169 | -| [v2.17.3](https://bootstrap-vue.org/docs/reference/changelog#v2173) | https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/2189 | -| [v2.18.1](https://bootstrap-vue.org/docs/reference/changelog#v2181) | https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/2195 | -| [v2.19.0](https://bootstrap-vue.org/docs/reference/changelog#v2190) | https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/2403 | -| [v2.20.1](https://bootstrap-vue.org/docs/reference/changelog#v2201) | https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/2413 | -| [v2.21.2](https://bootstrap-vue.org/docs/reference/changelog#v2212) | TBC |",3 -54297806,2020-07-10 13:48:08.401,Text area for editing wiki page won't expand taller than 500 pixels,"When editing a Gitlab Wiki page in version 13.0.3, the editor area can be dragged no taller than 500 pixels, which is pretty restrictive. The limitation seems to be the `.markdown-area` style, which has a `max-height` property of `500px`. Using Chrome/Inspect, changing this to `1000px` allows a taller editing window. - -(You would think that using the ""Go full screen"" button would be a workaround, but it isn't; the resulting display has larger text and a narrower editing field, which adds unnecessary line wraps. I've filed this separately as issue #880.)",1 -53978942,2020-07-06 15:52:43.942,Proposal: Merge GlSkeletonLoading functionality into GlSkeletonLoader and deprecate GlSkeletonLoading,"[`GlSkeletonLoading`](https://gitlab-org.gitlab.io/gitlab-ui/?path=/story/base-skeleton-loading--default) and [`GlSkeletonLoader`](https://gitlab-org.gitlab.io/gitlab-ui/?path=/story/base-skeleton-loader--default) have very similar functionality that could be combined to reduce confusion and make GitLab UI more maintainable. - -# Proposal - -### Changes to [`GlSkeletonLoader`](https://gitlab-org.gitlab.io/gitlab-ui/?path=/story/base-skeleton-loader--default) - -- Add `DEFAULT_LINE_WIDTH_PERCENTAGES` as a constant from https://gitlab.com/gitlab-org/gitlab-ui/-/blob/master/src/components/base/skeleton_loading/skeleton_loading.scss#L4 -- Add `lines` prop that defaults to `3` and is used to render the default [`slot`](https://gitlab.com/gitlab-org/gitlab-ui/-/blob/master/src/components/base/skeleton_loader/skeleton_loader.vue#L53) value. -- Add `equal-width-lines` prop that defaults to `false`. The default lines will be the same width if this is `true`. -- Add default value to [`slot`](https://gitlab.com/gitlab-org/gitlab-ui/-/blob/master/src/components/base/skeleton_loader/skeleton_loader.vue#L53). This default value would be a SVG rectangle that is rendered based on the `lines` prop, `equal-width-lines` prop and `DEFAULT_LINE_WIDTH_PERCENTAGES` constant. - -### Changes to [`GlSkeletonLoading`](https://gitlab-org.gitlab.io/gitlab-ui/?path=/story/base-skeleton-loading--default) -- Add deprecated message. ""This component is deprecated, please use [`GlSkeletonLoader`](https://gitlab-org.gitlab.io/gitlab-ui/?path=/story/base-skeleton-loader--default).""",3 -49944004,2020-06-23 09:12:56.293,Chart legend clickability hover-state,"### Problem - -- From: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/614#note_364422937 -- Charts do not easily let users know that they can click on the chart legend to show/hide values - -### Solution - -- Add additional signifiers to the chart's on-hover interaction - -[See prototype](https://www.figma.com/proto/GevTEMYLCPyWn2bo564C2V/Grouped-Stacked-Column?node-id=24%3A16&viewport=1665%2C1559%2C2.4460501670837402&scaling=min-zoom)",1 -49943761,2020-06-23 09:07:42.580,Reverse order of popover values in stacked column chart,"From: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/614#note_364403374 - -### Problem - -- Values are in reverse order for stacked column chart's popover - -### Solution - -- Put them in the same order as how they appear in the chart - -![image](/uploads/32ec59acb3139dad1566cbe03395687b/image.png)",1 -44633171,2020-06-16 03:43:34.853,Single util class for a 1px solid $border-color'd border,"Currently it takes lots of typing to add a border - -```html -class=""gl-border-b-1 gl-border-b-gray-200 gl-border-b-solid"" -``` - -We should add a `.gl-border-bottom` util class that adds width, style, and color at the same time. They are usually `1px`, `solid`, and `$border-color`ed. - -Similar to https://gitlab.com/gitlab-org/gitlab-ui/-/issues/844",1 -38376510,2020-06-09 18:31:35.550,GlButton > Icon buttons > Add borderless variant,"We need a borderless icon button variant for instances such as actions in the headers: - -![Screen_Shot_2020-06-09_at_11.32.07_AM](/uploads/944b8d9ce5fc6e9a58a297eef19148fa/Screen_Shot_2020-06-09_at_11.32.07_AM.png)",1 -36482565,2020-06-08 22:10:28.418,Add an off click directive,"Throughout the gitlab codebase we are building diff types of off click handlers, per recommendations from multiple maintainers this should be abstracted to a directive or a component.",2 -35353115,2020-06-02 20:48:57.267,Heat map > Toggling legend,"You can toggle the data points off using the legend on all the chart types. But, I notice this doesn't work on the heat maps. You can toggle the groups off...but nothing happens :sweat_smile: We should either disable the toggling feature OR make sure it works - -## Proposal - -Ensure that toggling heat map legend options correctly toggles content in heat map.",2 -35353050,2020-06-02 20:45:39.116,Heat map > Spacing of x axis label,"In the design, we have 8px space between the x-axis label and the top of the legend. Right now, it looks like there's no space between the container holding the legend and the container holding the x-axis label. - -![space](https://gitlab.com/gitlab-org/gitlab-ui/uploads/76dc02653d3596f0dc73d6bea7f75e04/space.png)",2 -35201188,2020-05-29 20:10:47.059,Segmented control > Update styling of selected button,"The selected button styling for segmented controls needs to be updated to match the new style displayed in Figma - -|Current GitLab UI|Figma| -|--|--| -| ![Screen_Shot_2020-05-29_at_1.10.06_PM](/uploads/9f8ec212c16de2a5ef0cd745742d41d1/Screen_Shot_2020-05-29_at_1.10.06_PM.png) | ![Screen_Shot_2020-05-29_at_1.10.12_PM](/uploads/400a2ae4d19769c952dc5be274096b39/Screen_Shot_2020-05-29_at_1.10.12_PM.png) | - -https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Pajamas-UI-Kit?node-id=3280%3A6829",1 -35196572,2020-05-29 18:07:15.665,Radio and checkbox groups > Only allow stacked version,"In our UI Kit, we've determined that radio and checkbox groups should only be stacked vertically. The horizontal version should be removed from GitLab UI as an option.",1 -35152428,2020-05-29 05:35:16.634,Allow only safe urls in GlLink,"[GlLink Component](https://gitlab.com/gitlab-org/gitlab-ui/-/blob/master/src/components/base/link/link.vue) should accept only safe (secure) URLs and thus preventing `javascript://` XSSes. - -* should allow URLs only with the following protocols (http, https, ftp, mailto) -* should take care of encoded URIs -* should render as `span` tag when the `href` is unsafe",5 -35152277,2020-05-29 05:28:10.875,Vue Directive to Sanitize HTML,Add a Vue Directive `v-safe-html` which would allow you to sanitize html in Vue.,3 -35055290,2020-05-27 10:05:35.025,Selected item from Recent searches doesn't populate search input,"Passing a `historyItems` array to `GlFilteredSearch` lists will render those items under a dropdown. Selecting an item from the list will trigger a `search`. However, the search input field won't get populated with the selected item. If we decided that this should not be part of the component's implementation, then we should at expose an event that the outside world can listen to. - -![recent_searches](/uploads/ebf0e7fd579e8d841517bc5436a2561a/recent_searches.mp4)",1 -35035949,2020-05-26 21:08:37.367,Allow colorize token in filters,"It seems we have already two use cases of using colored token: -Status: ![image](/uploads/77c2d528edf6f00fe497434968fc13f1/image.png) -and labels, where token inherits color of label - -We need to provide a way in ~""component:filter"" to create such tokens -/cc @tauriedavis @wortschi",2 -35009539,2020-05-26 10:09:34.275,Consider adding lighter-weight table components,"A recent MR made it clear how heavy a component `GlTable` (i.e., `BTable`) really is: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/31471#note_346621145 - -In short, it adds ~120KB to a page bundle. - -This is no doubt why `bootstrap-vue` also has `BTableLite` and `BTableSimple` components! We should consider wrapping those as well in GitLab UI. - -**Implementation Plan:** - -- [x] Add TableLite component to GitLabUI -- [x] Add TableSimple component to GitLabUI -- [x] Update GitLab to the latest GitLabUI package -- [x] create Epic to reconsider using lightweight tables on existing GlTables in Gitlab",3 -35001386,2020-05-26 06:48:15.832,"Create ""NewCard"" Component","This issue captures the implementation of the UI-component for https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/287 - -Related epics: - -* [Components of Pajamas Design System](https://gitlab.com/groups/gitlab-org/-/epics/973) -* [Pajamas component: Cards](https://gitlab.com/groups/gitlab-org/-/epics/1118) - -Related issues: - -* [FY20-Q2 UX OKR: Improve the quality and consistency of our UI](https://gitlab.com/gitlab-com/www-gitlab-com/issues/4355) -* [Pajamas](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/287) - -Related discussion / Context: - -* [Why `NewCard`?](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/287#note_347484969) - -## Implementation Plan - -* [ ] Rebase / Update https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/1314 -* [ ] Finish work (eg.: add documentation)",3 -34909090,2020-05-22 19:17:24.396,Make GlBanner follow design system again,"!1280 revealed that more components than we are expected do not follow design system. `GlBanner` is one of such components, we need to update CSS to make it compatible once again - -Figma specs: https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=19944%3A6",1 -34907572,2020-05-22 18:01:55.618,"Create ""Token Selector"" component","## Objective - -- Create a token selector that can be used for this feature: https://gitlab.com/gitlab-org/gitlab/-/issues/33143 (Thread discussing design: https://gitlab.com/gitlab-org/gitlab/-/issues/33143#note_333784563) -- Make it flexible enough to be able to replace the ""Invite user dropdown"" (used to add users to projects/groups) in the future -![Screen_Shot_2020-05-22_at_10.24.27_AM](/uploads/31f185ec08f4a3dc1ebbf9dc2d09db39/Screen_Shot_2020-05-22_at_10.24.27_AM.png) - -## Examples - -See !1460 - -## Proposed API - -### Props -| Name | Description | Type | Required? | Default Value | -| ------ | ------ | ------ | ------ | ------ | -| `dropdown-items` | Items to display in dropdown | `Array` | `false` | `[]` | -| `selected-tokens` | Tokens that are selected. This prop will automatically be added when using `v-model`. | `Array` | `true` | `[]` | -| `allow-user-defined-tokens` | Should users be allowed to add tokens that are not in the `dropdown-items` | `Function` or `Boolean` | `false` | `true` | -| `loading` | Dropdown options are loading, can be used when requesting new dropdown options | `Boolean` | `false` | `false` | -| `hide-dropdown-with-no-items` | Hide the dropdown if `dropdown-items` is empty. Will show `no-results-content` slot if this is `false` | `Boolean` | `false` | `false` | - -### Slots -| Name | Description | Default | Scoped Props | -| ------ | ------ | ------ | ------ | -| `no-results-content` | Content to display when `dropdown-items` is empty and `allow-user-defined-tokens` is `false` | `No matches found` | N/A | -| `user-defined-token-content` | Content to display when adding a user defined token | `Add ""{{ inputText }}""` | `inputText` | -| `token-content` | Content to pass to the token component slot. Can be used to add an avatar to the token | `token.name` | `token` | -| `dropdown-item-content` | Dropdown item content | `dropdownItem.name` | `dropdownItem` | -| `loading-content` | Loading content | `Searching...` | N/A - -### Events -| Name | Description | Arguments | -| ------ | ------ | ------ | -| `text-input` | Fired when user types in the text input | `inputText` | -| `input` | Fired when a token is add or removed | `selectedTokens` | -| `focus` | Input focus event | `event` | -| `blur` | Input blur event | `event` | -| `token-add` | Fired when a token is added | `token` | -| `token-remove` | Fired when a token is removed | `token` | - -`v-model` will return array of selected tokens - -### Keyboard navigation -Based on [Material Chips](https://material.angular.io/components/chips/overview#keyboard-interaction) - -| Key | Action | -| ------ | ------ | -| `enter` | Adds selected dropdown as token | -| `escape` | Closes dropdown and clears text input | -| `backspace` | Select last token. `backspace` again to delete | -| `left/right arrows` | Move between selected tokens | -| `up/down arrows` | Move between dropdown options | -| `home` | When token is selected, move focus to first token. When dropdown item is selected, move to first dropdown item | -| `end` | When token is selected, move focus to last token. When dropdown item is selected, move to last dropdown item | - -### A11y - -References: - -- [`ARIA: listbox role`](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/listbox_role) -- [Material Chips](https://material.angular.io/components/chips/overview#keyboard-interaction) - -#### Token container attributes - -| Attribute | -| ------ | -| `role=""listbox""` | -| `aria-multiselectable=""false""` | -| `aria-orientation=""horizontal""` | - -#### Token - -| Attribute | -| ------ | -| `role=""option""` |",5 -34614415,2020-05-15 16:24:03.986,Change GlInfiniteScroll to not display totalItems in its legend if it wasn't supplied,"This will fix the underlying cause for how [this bug](https://gitlab.com/gitlab-org/gitlab/-/issues/196526) occurred. - -Rationale: - -* `GlInfiniteScroll`'s `totalItems` prop is optional; unfortunately, the component *always* renders its ""legend"". Since `totalItems` defaults to `0`, the legend in this case will say `Showing n items of 0`, which is precisely what caused the [bug](https://gitlab.com/gitlab-org/gitlab/-/issues/196526). - * `GlInfiniteScroll` should change the legend to not display `totalItems` if it wasn't supplied.",1 -34229428,2020-05-06 17:08:04.455,Create a component for truncating filepaths,"We need a component for secure that truncates filepaths intelligently. - -Consider the following string, `ee/app/assets/javascripts/vue_shared/security_reports/store/utils.js`: - -1. Truncate end: `ee/app/assets/javascript…` -1. Truncate start: `…y_reports/store/utils.js` -1. Smart truncation: `ee/app/…/store/utils.js` - -If we truncate the end of the string, we cut out the most important imformation. -If we truncate the start of the string, we could also cut out important information. -The final solution would be ideal, but tricky to impliment. - -I've made a quick CSS POC that should help getting started. -https://codepen.io/samdbeckham/pen/JjYpNMd - -cc @gitlab-org/secure/frontend - -Related: -https://gitlab.com/gitlab-org/gitlab/-/issues/196148",3 -34113464,2020-05-04 14:35:28.413,Automatically add the appropriate `rel` attribute when using `GlButton` with `href`,"When using `GlButton` with an `href` attribute (i.e. ``), the developer needs to remember to add a `rel` attribute (if appropriate): - -```html -Click me -``` - -We should update `GlButton` to automatically apply the appropriate `rel` attribute, similar to what `GlLink` does. This would save developers from having to remember to add the `rel` attribute manually and enforce a consistent usage of `rel` across our product. - -Based on an internal conversation with @ealcantara (https://gitlab.slack.com/archives/C0GQHHPGW/p1588601058335600?thread_ts=1588600819.335400&cid=C0GQHHPGW), this should relatively simple by including the `rel_mixin` in `button.vue`.",1 -33925660,2020-04-28 21:06:43.285,Follow-up: Style form_input/textarea readonly and disabled states following Pajamas specs,"The purpose of this follow-up issue is styling the form_input/textarea readonly/disabled states following Pajamas specs. - -The following discussion from !1341 should be addressed: - -- [ ] @tauriedavis started a [discussion](https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/1341#note_333107121): (+1 comment) - - > Looks great! I think this is ready to merge. - > - > The ~~invalid~~ readonly/disabled textarea is incorrect, is there a separate issue to fix that or should we create one? - > - > Also I'm not sure about the two way bound input. Do we use that anywhere? Can it be removed or do we need to update the text underneath to use the current font/spacing? This seems separate from this MR so happy to open a separate issue to take a look.",1 -33333565,2020-04-15 17:02:06.588,Upgrade BootstrapVue to latest stable version,"# Our current dependencies state - -## GitLab UI - -- [`bootstrap-vue@2.1.0`](https://gitlab.com/gitlab-org/gitlab-ui/-/blob/a8223b33965371f052eea14ce10f0d927d4428f2/package.json#L60) (direct dependency) -- [`bootstrap@4.3.1`](https://gitlab.com/gitlab-org/gitlab-ui/-/blob/a8223b33965371f052eea14ce10f0d927d4428f2/package.json#L75) (peer dependency) - -## GitLab - -- [`bootstrap@4.3.1`](https://gitlab.com/gitlab-org/gitlab/-/blob/fcdb26339eeb7f4a160fe2f663886eefe82f6157/package.json#L57) (direct dependency, matches `@gitlab/ui` peer dependency) - -# BootstrapVue's current state - -- `bootstrap-vue`'s latest version: [`2.13.1`](https://github.com/bootstrap-vue/bootstrap-vue/blob/dev/package.json#L3) -- [`bootstrap@4.4.1`](https://github.com/bootstrap-vue/bootstrap-vue/blob/dev/package.json#L94) (direct dependency) - -# What we're aiming for - -## GitLab UI - -- `bootstrap-vue@2.13.1` (direct dependency) -- `bootstrap@4.4.1` (peer dependency) - -## GitLab - -- `bootstrap@4.4.1` (direct dependency, matches `@gitlab/ui` peer dependency) - -# Migration plan - -- [x] Upgrade to `bootstrap-vue@2.13.1` and `bootstrap@4.4.1` in GitLab UI: https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/1354 -- [x] Upgrade to `bootstrap@4.4.1` and `@gitlab/ui@next` in GitLab: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/30846 - - [x] By looking at Bootstrap's changelog, estimate what changes could present a risk to GitLab - - [x] Document a migration path for every risky change - - [ ] Proceed with the upgrade and smoke test the app - - -# BootstrapVue's Changelogs from `2.1.0` to `2.13.1` - -
- -## [v2.13.1](https://github.com/bootstrap-vue/bootstrap-vue/compare/v2.13.0...v2.13.1) - -Released: 2020-05-05 - -### Bug Fixes v2.13.1 - -- **b-table, b-table-lite, b-table-simple:** handle head/foot variant for sticky columns (fixes - [#5278](https://github.com/bootstrap-vue/bootstrap-vue/issues/5278)) - ([#5279](https://github.com/bootstrap-vue/bootstrap-vue/issues/5279)) - ([53e309e](https://github.com/bootstrap-vue/bootstrap-vue/commit/53e309e947b4710fcf8d989cc9ef0f31c58487ae)) - -### Other v2.13.1 - -- documentation updates -- dev dependency updates - -## [v2.13.0](https://github.com/bootstrap-vue/bootstrap-vue/compare/v2.12.0...v2.13.0) - -Released: 2020-04-27 - -### Features v2.13.0 - -- **b-calendar, b-form-datepicker:** relax `YYYY-MM-DD` string parsing (closes - [#5232](https://github.com/bootstrap-vue/bootstrap-vue/issues/5232)) - ([#5242](https://github.com/bootstrap-vue/bootstrap-vue/issues/5242)) - ([f362802](https://github.com/bootstrap-vue/bootstrap-vue/commit/f362802b2794f0e5d294bbb004d91ccd623a1e25)) -- **b-form-rating:** add `show-value-max` prop to show possible max rating when `show-value` is - `true` ([#5200](https://github.com/bootstrap-vue/bootstrap-vue/issues/5200)) - ([e9d54e6](https://github.com/bootstrap-vue/bootstrap-vue/commit/e9d54e6c6a736b2a4f9dbf232dd2b20afa0e990c)) -- **b-overlay:** add support for overlay `click` event (closes - [#5243](https://github.com/bootstrap-vue/bootstrap-vue/issues/5243)) - ([#5248](https://github.com/bootstrap-vue/bootstrap-vue/issues/5248)) - ([582560f](https://github.com/bootstrap-vue/bootstrap-vue/commit/582560ff97690ab1e5c1f609d76804b7b3daa104)) - -### Bug Fixes v2.13.0 - -- **b-avatar:** set `align-items: center` for default slot content (fixes: - [#5205](https://github.com/bootstrap-vue/bootstrap-vue/issues/5205)) - ([#5207](https://github.com/bootstrap-vue/bootstrap-vue/issues/5207)) - ([c4981fd](https://github.com/bootstrap-vue/bootstrap-vue/commit/c4981fd098253840a37e731331de65b0e732fc79)) -- **b-calendar, b-form-datepicker:** minor adjustments to styling and example updates - ([#5211](https://github.com/bootstrap-vue/bootstrap-vue/issues/5211)) - ([f0d8ffe](https://github.com/bootstrap-vue/bootstrap-vue/commit/f0d8ffe4253079939008108fe86529a2f69553f1)) -- **b-form-datepicker, b-form-timepicker:** fix menu padding in button only mode (fixes - [#5251](https://github.com/bootstrap-vue/bootstrap-vue/issues/5251)) - ([#5252](https://github.com/bootstrap-vue/bootstrap-vue/issues/5252)) - ([d57a643](https://github.com/bootstrap-vue/bootstrap-vue/commit/d57a643f0c6b5e805a42a3387fb0db4443bfc01f)) -- **b-form-datepicker, b-form-timepicker:** adjust scss to support input-groups - ([#5231](https://github.com/bootstrap-vue/bootstrap-vue/issues/5231)) - ([7b1adc4](https://github.com/bootstrap-vue/bootstrap-vue/commit/7b1adc460f11c2ee54466fe0d204579f3f6f1bd2)) -- **b-form-datepicker, b-form-timepicker:** prevent duplicate validation icons (fixes - [#5237](https://github.com/bootstrap-vue/bootstrap-vue/issues/5237)) - ([#5238](https://github.com/bootstrap-vue/bootstrap-vue/issues/5238)) - ([6354e6e](https://github.com/bootstrap-vue/bootstrap-vue/commit/6354e6eb90b93e668c2794b3b4c2117a7cfc0ab0)) -- **types:** update table field definition types to include sticky column (fixes - [#5263](https://github.com/bootstrap-vue/bootstrap-vue/issues/5263)) - ([#5265](https://github.com/bootstrap-vue/bootstrap-vue/issues/5265)) - ([20eb3ac](https://github.com/bootstrap-vue/bootstrap-vue/commit/20eb3ac9e22ddbcc41d1f1aa923871007abe0dc0)) -- handle nested form options normalization - ([#5247](https://github.com/bootstrap-vue/bootstrap-vue/issues/5247)) - ([0c57ffe](https://github.com/bootstrap-vue/bootstrap-vue/commit/0c57ffe31c946475498fa3554b8b4aba4e9d19df)) - -### Other v2.13.0 - -- dev dependencies updates -- documentation updates -- new docs domain [`https://bootstrap-vue.org/`](https://bootstrap-vue.org/) - - - -## [v2.12.0](https://github.com/bootstrap-vue/bootstrap-vue/compare/v2.11.0...v2.12.0) - -Released: 2020-04-20 - -### Features v2.12.0 - -- **b-avatar:** add support for badges on avatars - ([#5124](https://github.com/bootstrap-vue/bootstrap-vue/issues/5124)) - ([a2e465b](https://github.com/bootstrap-vue/bootstrap-vue/commit/a2e465b6457cabb88e42bcefd86a86e36c4602de)) -- **b-avatar:** if `variant` is empty string, then remove spacing around image (closes - [#5154](https://github.com/bootstrap-vue/bootstrap-vue/issues/5154)) - ([#5156](https://github.com/bootstrap-vue/bootstrap-vue/issues/5156)) - ([7ff87fc](https://github.com/bootstrap-vue/bootstrap-vue/commit/7ff87fc560a2ad005bdca394cccf1fafa9d5e696)) -- **b-calendar, b-form-datepicker:** add prop `weekday-header-format` to specify weekday header - length (closes [#5171](https://github.com/bootstrap-vue/bootstrap-vue/issues/5171)) - ([#5175](https://github.com/bootstrap-vue/bootstrap-vue/issues/5175)) - ([8241644](https://github.com/bootstrap-vue/bootstrap-vue/commit/8241644477b174042bb163ba1741c3066165d9f9)) -- **b-calendar, b-form-datepicker:** add scoped slots for date navigation buttons (closes - [#5117](https://github.com/bootstrap-vue/bootstrap-vue/issues/5117)) - ([#5147](https://github.com/bootstrap-vue/bootstrap-vue/issues/5147)) - ([5f69864](https://github.com/bootstrap-vue/bootstrap-vue/commit/5f69864497a13a9b18a96b508af6b9ba89a43add)) -- **b-form-datepicker:** add pass through prop `date-info-fn` (closes - [#4826](https://github.com/bootstrap-vue/bootstrap-vue/issues/4826)) - ([#5150](https://github.com/bootstrap-vue/bootstrap-vue/issues/5150)) - ([bf35f80](https://github.com/bootstrap-vue/bootstrap-vue/commit/bf35f80d1c4619cf4494dc8a6256d093140d4052)) -- **b-form-rating:** new `b-form-rating` custom component - ([#5132](https://github.com/bootstrap-vue/bootstrap-vue/issues/5132)) - ([30ad7fe](https://github.com/bootstrap-vue/bootstrap-vue/commit/30ad7fe746cd6187311c86319abf6e9519b81f15)) -- **b-sidebar:** add optional backdrop support - ([#5182](https://github.com/bootstrap-vue/bootstrap-vue/issues/5182)) - ([c6375e5](https://github.com/bootstrap-vue/bootstrap-vue/commit/c6375e5513cb0ec33a9bc9fc894a123d74cf7768)) -- **custom components:** avoid using padding/margin utility classes where possible (closes - [#5117](https://github.com/bootstrap-vue/bootstrap-vue/issues/5117)) - ([#5121](https://github.com/bootstrap-vue/bootstrap-vue/issues/5121)) - ([8c6cfe0](https://github.com/bootstrap-vue/bootstrap-vue/commit/8c6cfe0af919a4e54667bcb4b29d2ba6b6576b67)) -- **icons:** new `throb` and `fade` animations - ([#5122](https://github.com/bootstrap-vue/bootstrap-vue/issues/5122)) - ([bc0117c](https://github.com/bootstrap-vue/bootstrap-vue/commit/bc0117cc794c948b202daf2e17f22eb4c36235cc)) - -### Bug Fixes v2.12.0 - -- **b-alert:** fix memory leak by using the correct method to clear the countdown timeout - ([#5158](https://github.com/bootstrap-vue/bootstrap-vue/issues/5158)) - ([7a7f33d](https://github.com/bootstrap-vue/bootstrap-vue/commit/7a7f33d74f906e5feecf2bf177636c7f85bc4537)) -- **b-avatar:** fix button type font size inheritance - ([#5177](https://github.com/bootstrap-vue/bootstrap-vue/issues/5177)) - ([441ebdc](https://github.com/bootstrap-vue/bootstrap-vue/commit/441ebdc8a262c6c6ed494ddc6a6c0c06604045ef)) -- **b-calendar:** use `Intl.NumberFormat` for formatting the number in the date buttons (closes - [#5171](https://github.com/bootstrap-vue/bootstrap-vue/issues/5171)) - ([#5179](https://github.com/bootstrap-vue/bootstrap-vue/issues/5179)) - ([cbf2cd0](https://github.com/bootstrap-vue/bootstrap-vue/commit/cbf2cd007cce81a5f664fa649b08af6735fe16e4)) -- **b-form-datepicker:** make datepicker respect `no-highlight-today` prop - ([#5159](https://github.com/bootstrap-vue/bootstrap-vue/issues/5159)) - ([c4ead33](https://github.com/bootstrap-vue/bootstrap-vue/commit/c4ead3302b176e4a90fbfcfe6380de0edc22640f)) - -### Other v2.12.0 - -- documentation updates -- dev dependency updates - - - -## [v2.11.0](https://github.com/bootstrap-vue/bootstrap-vue/compare/v2.10.1...v2.11.0) - -Released: 2020-04-07 - -### Features v2.11.0 - -- **b-avatar:** if image `src` fails to load, then show icon, text or fallback icon - ([#5079](https://github.com/bootstrap-vue/bootstrap-vue/issues/5079)) - ([ed6704d](https://github.com/bootstrap-vue/bootstrap-vue/commit/ed6704d0971ade485393b7f711f05d93ca42ebc3)) -- **b-calendar, b-form-datepicker:** add optional decade navigation buttons (addresses - [#4976](https://github.com/bootstrap-vue/bootstrap-vue/issues/4976)) - ([#5112](https://github.com/bootstrap-vue/bootstrap-vue/issues/5112)) - ([b1f74a8](https://github.com/bootstrap-vue/bootstrap-vue/commit/b1f74a84f4021022e606360ee6824c6645b6fbd0)) - -### Bug Fixes v2.11.0 - -- **b-calendar, b-form-datepicker:** handle keyboard navigation when selected date is out of range - (fixes [#5057](https://github.com/bootstrap-vue/bootstrap-vue/issues/5057)) - ([#5108](https://github.com/bootstrap-vue/bootstrap-vue/issues/5108)) - ([6ed09f4](https://github.com/bootstrap-vue/bootstrap-vue/commit/6ed09f40ae1594c7ad96dedc8c3d7c2a54d4d9c7)) -- **b-link:** don't render `target` or `rel` attrs when `router-tag` other than `a` or `area` - provided ([#5107](https://github.com/bootstrap-vue/bootstrap-vue/issues/5107)) - ([33c6cef](https://github.com/bootstrap-vue/bootstrap-vue/commit/33c6cefc2f46ab8110e39f110d984f230d525c86)) -- **tooltip, popover:** handle `'click blur'` trigger on iOS webkit browsers (fixes - [#5099](https://github.com/bootstrap-vue/bootstrap-vue/issues/5099)) - ([#5103](https://github.com/bootstrap-vue/bootstrap-vue/issues/5103)) - ([27da76c](https://github.com/bootstrap-vue/bootstrap-vue/commit/27da76cdc70449b0564e31f5733df97d758652ea)) - -### Other v2.11.0 - -- additional unit testing -- dev dependencies updates -- minor documentation updates - - - -## [v2.10.1](https://github.com/bootstrap-vue/bootstrap-vue/compare/v2.10.0...v2.10.1) - -Released: 2020-04-02 - -### Bug Fixes v2.10.1 - -- **b-avatar:** remove default padding when in button mode (fixes - [#5073](https://github.com/bootstrap-vue/bootstrap-vue/issues/5073)) - ([#5076](https://github.com/bootstrap-vue/bootstrap-vue/issues/5076)) - ([26377b3](https://github.com/bootstrap-vue/bootstrap-vue/commit/26377b3479f323baa2d702fab7f5200949ed680d)) -- **b-table:** fix context object `currentPage` issue introduced in v2.10.0 (fixes - [#5065](https://github.com/bootstrap-vue/bootstrap-vue/issues/5065)) - ([#5067](https://github.com/bootstrap-vue/bootstrap-vue/issues/5067)) - ([874dca2](https://github.com/bootstrap-vue/bootstrap-vue/commit/874dca2c8c385fecf7cec76e6cfa44eda9fcabf4)) - -### Other v2.10.1 - -- dev dependency updates - - - -## [v2.10.0](https://github.com/bootstrap-vue/bootstrap-vue/compare/v2.9.0...v2.10.0) - -Released: 2020-04-01 - -### Features v2.10.0 - -- **b-sidebar:** new custom component `` (closes - [#3324](https://github.com/bootstrap-vue/bootstrap-vue/issues/3324), - [#3210](https://github.com/bootstrap-vue/bootstrap-vue/issues/3210), - [#1702](https://github.com/bootstrap-vue/bootstrap-vue/issues/1702)) - ([#5021](https://github.com/bootstrap-vue/bootstrap-vue/issues/5021)) - ([a77866f](https://github.com/bootstrap-vue/bootstrap-vue/commit/a77866f6d032f1a5a22be2d12d60be507825769c)) - -### Bug Fixes v2.10.0 - -- **b-avatar:** remove duplicate button variant class - ([#5056](https://github.com/bootstrap-vue/bootstrap-vue/issues/5056)) - ([9f78f32](https://github.com/bootstrap-vue/bootstrap-vue/commit/9f78f32d964b187f35a1feffb7aa4bc264587923)) -- **b-card:** handle `header-html` and `footer-html` props correctly (fixes - [#5038](https://github.com/bootstrap-vue/bootstrap-vue/issues/5038)) - ([#5039](https://github.com/bootstrap-vue/bootstrap-vue/issues/5039)) - ([f378aef](https://github.com/bootstrap-vue/bootstrap-vue/commit/f378aeffdebdc7922f6ad4c5d513642dfb93cf1d)) -- **types:** add missing declaration for `b-form-timepicker` (closes - [#5035](https://github.com/bootstrap-vue/bootstrap-vue/issues/5035)) - ([#5036](https://github.com/bootstrap-vue/bootstrap-vue/issues/5036)) - ([ae84118](https://github.com/bootstrap-vue/bootstrap-vue/commit/ae841184dc3037b5d6f365311cc668bccb0e85da)) - -### Other v2.10.0 - -- documentation site improvements and updates -- dev dependency updates - - - -## [v2.9.0](https://github.com/bootstrap-vue/bootstrap-vue/compare/v2.8.0...v2.9.0) - -Released: 2020-03-25 - -### Features v2.9.0 - -- **b-aspect:** new custom component `` - ([#5008](https://github.com/bootstrap-vue/bootstrap-vue/issues/5008)) - ([662c8e0](https://github.com/bootstrap-vue/bootstrap-vue/commit/662c8e0709c8c73fb2119976d1906943cfe6daad)) -- **b-avatar:** add `alt` prop for adding alt attribute to image and icon avatars (closes - [#4990](https://github.com/bootstrap-vue/bootstrap-vue/issues/4990)) - ([#4991](https://github.com/bootstrap-vue/bootstrap-vue/issues/4991)) - ([d1474f2](https://github.com/bootstrap-vue/bootstrap-vue/commit/d1474f28729e4e13ad97b75a87d56f85543d4c96)) -- **b-drodpown-item-button, b-drodpown-item-button:** add `button-class` and `link-class` prop - ([#5014](https://github.com/bootstrap-vue/bootstrap-vue/issues/5014)) - ([b39d31c](https://github.com/bootstrap-vue/bootstrap-vue/commit/b39d31cede76b594b5608fa472d53e3dac525e2b)) -- **b-form-datepicker, b-form-timepicker:** emit `shown` and `hidden` events - ([#5004](https://github.com/bootstrap-vue/bootstrap-vue/issues/5004)) - ([eb259b9](https://github.com/bootstrap-vue/bootstrap-vue/commit/eb259b998dfd3e88a1b04ed8d3f4c97560f69dbb)) -- **b-navbar-toggle:** make default slot scoped - ([#4995](https://github.com/bootstrap-vue/bootstrap-vue/issues/4995)) - ([144d45f](https://github.com/bootstrap-vue/bootstrap-vue/commit/144d45fb0e4d66bbf243b4a4df39d7f3b9b5c7cc)) - -### Docs v2.9.0 - -- Ensure that the `IconsPlugin` is imported when exporting from playground to CodePen, CodeSandbox, - and JsFiddle ([#5003](https://github.com/bootstrap-vue/bootstrap-vue/issues/5003)) - -### Other v2.9.0 - -- dev dependency updates - - - -## [v2.8.0](https://github.com/bootstrap-vue/bootstrap-vue/compare/v2.7.0...v2.8.0) - -Released: 2020-03-22 - -### Features v2.8.0 - -- **icons:** upgrade to Bootstrap Icons `1.0.0.alpha3` - ([#4966](https://github.com/bootstrap-vue/bootstrap-vue/issues/4966)) - ([d481365](https://github.com/bootstrap-vue/bootstrap-vue/commit/d481365c9f8014e1573026881c3588f2d51999ee)) - - 200+ new icons - - `skip-*` icon names fixed (closes [#4733](https://github.com/bootstrap-vue/bootstrap-vue/4733)) - - `document-*` icons renamed to `file-*` - - `alert-*` icons renamed to `exclamation-*` - - `columns-gutters` icon renamed to `columns-gap` - - `diamond` icon renamed to `gem` because of new `diamond-*` shape icons -- **b-avatar:** new `` component - ([#4974](https://github.com/bootstrap-vue/bootstrap-vue/issues/4974)) - ([b2325a3](https://github.com/bootstrap-vue/bootstrap-vue/commit/b2325a3f87a58207603be0bad41afb3059a575a1)) -- **b-form-spinbutton:** add slots for increment and decrement button content (closes - [#4958](https://github.com/bootstrap-vue/bootstrap-vue/issues/4958)) - ([#4963](https://github.com/bootstrap-vue/bootstrap-vue/issues/4963)) - ([5684405](https://github.com/bootstrap-vue/bootstrap-vue/commit/5684405197c8dd03b0711b0efc11ab6d76fb7714)) - -### Other v2.8.0 - -- docs updates -- dev dependencies updates - - - -## [v2.7.0](https://github.com/bootstrap-vue/bootstrap-vue/compare/v2.6.1...v2.7.0) - -Released: 2020-03-14 - -### Features v2.7.0 - -- **b-overlay:** new component `b-overlay` - ([#4907](https://github.com/bootstrap-vue/bootstrap-vue/issues/4907)) - ([134d64d](https://github.com/bootstrap-vue/bootstrap-vue/commit/134d64d073bb64fecd74ffc521476bfd97a99fc0)) -- **b-calendar, b-form-datepicker:** add new `initial-date` prop, and constrain today/current month - buttons between `min` and `max` (closes - [#4899](https://github.com/bootstrap-vue/bootstrap-vue/issues/4899)) - ([#4906](https://github.com/bootstrap-vue/bootstrap-vue/issues/4906)) - ([1d957eb](https://github.com/bootstrap-vue/bootstrap-vue/commit/1d957ebd78a8693e91a8116d12c28fe24bd7c19c)) -- **b-form-datepicker, b-form-timepicker:** add support for icon button only mode (closes - [#4888](https://github.com/bootstrap-vue/bootstrap-vue/issues/4888)) - ([#4915](https://github.com/bootstrap-vue/bootstrap-vue/issues/4915)) - ([13660c3](https://github.com/bootstrap-vue/bootstrap-vue/commit/13660c3ad02f6c692d306ec95f0d2b19212f9423)) -- **b-icon:** add animated icon options (closes - [#4720](https://github.com/bootstrap-vue/bootstrap-vue/issues/4720)) - ([#4934](https://github.com/bootstrap-vue/bootstrap-vue/issues/4934), - [#4945](https://github.com/bootstrap-vue/bootstrap-vue/issues/4945), - [#4948](https://github.com/bootstrap-vue/bootstrap-vue/issues/4948)) - ([7c781fa](https://github.com/bootstrap-vue/bootstrap-vue/commit/7c781faea78315a753b2db903b12c500d6547ae1), - [b786f67](https://github.com/bootstrap-vue/bootstrap-vue/commit/b786f671c3d69bbf9dbfb088840a332d4a066b14), - [927c234](https://github.com/bootstrap-vue/bootstrap-vue/commit/927c234a6b5d68e23e86f7d1782b179b1ccb8786)) - -### Bug Fixes v2.7.0 - -- **b-form-file:** fix value prop validation when using directory mode (fixes - [#4912](https://github.com/bootstrap-vue/bootstrap-vue/issues/4912)) - ([#4913](https://github.com/bootstrap-vue/bootstrap-vue/issues/4913)) - ([498a262](https://github.com/bootstrap-vue/bootstrap-vue/commit/498a26219571bb6108aaa7134dc25c8e1ff6c98f)) -- **b-form-file:** make sure to catch all errors when resetting the input - ([#4936](https://github.com/bootstrap-vue/bootstrap-vue/issues/4936)) - ([682bc46](https://github.com/bootstrap-vue/bootstrap-vue/commit/682bc46028cacfdb570fe416a051160ee9789fe2)) - -### Other v2.7.0 - -- `deps`: update devDependency rollup to 2.0.x -- minor docs updates - - - -## [v2.6.1](https://github.com/bootstrap-vue/bootstrap-vue/compare/v2.6.0...v2.6.1) - -Released: 2020-03-06 - -### Bug Fixes v2.6.1 - -- **b-form-spinbutton:** respect step value for initial decrement when `wrap` enabled (closes - [#4884](https://github.com/bootstrap-vue/bootstrap-vue/issues/4884)) - ([#4885](https://github.com/bootstrap-vue/bootstrap-vue/issues/4885)) - ([28e7245](https://github.com/bootstrap-vue/bootstrap-vue/commit/28e724536be4762382328648f203bd46d8f52fdc)) - -### Other v2.6.1 - -- documentation updates and fixes -- dev dependency updates - - - -## [v2.6.0](https://github.com/bootstrap-vue/bootstrap-vue/compare/v2.5.0...v2.6.0) - -Released: 2020-03-05 - -### Features v2.6.0 - -- **b-calendar, b-form-datepicker:** allow customization of in-component displayed date format - (closes [#4797](https://github.com/bootstrap-vue/bootstrap-vue/issues/4797)) - ([#4835](https://github.com/bootstrap-vue/bootstrap-vue/issues/4835)) - ([85c7e75](https://github.com/bootstrap-vue/bootstrap-vue/commit/85c7e759bc78d2ffb5b026cb5ee484b2567136aa)) -- **b-form-datepicker:** add `button-content` optionally scoped slot for calendar icon - ([#4795](https://github.com/bootstrap-vue/bootstrap-vue/issues/4795)) - ([7a00910](https://github.com/bootstrap-vue/bootstrap-vue/commit/7a0091099025d8bdcf953b00d8619726b54fa937)) -- **b-form-datepicker:** add `calendar-width` prop (closes - [#4817](https://github.com/bootstrap-vue/bootstrap-vue/issues/4817)) - ([#4822](https://github.com/bootstrap-vue/bootstrap-vue/issues/4822)) - ([91b77bc](https://github.com/bootstrap-vue/bootstrap-vue/commit/91b77bc9a6b1a4796698ce3185c0b354156ce563)) -- **b-pagination, b-pagination-nav:** improve aria accessibility - changes to inner structure and - aria attributes (closes: [#4811](https://github.com/bootstrap-vue/bootstrap-vue/issues/4811), - [#4160](https://github.com/bootstrap-vue/bootstrap-vue/issues/4160)) - ([#4810](https://github.com/bootstrap-vue/bootstrap-vue/issues/4810)) - ([7ee4baa](https://github.com/bootstrap-vue/bootstrap-vue/commit/7ee4baa9a843411cd30a3ee499fc7272b7cf48f2)) -- **b-tabs:** add ability to provide custom tab button attributes (closes: - [#4803](https://github.com/bootstrap-vue/bootstrap-vue/issues/4803)) - ([#4806](https://github.com/bootstrap-vue/bootstrap-vue/issues/4806)) - ([c541d3d](https://github.com/bootstrap-vue/bootstrap-vue/commit/c541d3d89ae88f3193305b61ae8ddc735aa6ec03)) -- **b-time, b-form-timepicker:** new components `b-time` and `b-form-timepicker` - ([#4783](https://github.com/bootstrap-vue/bootstrap-vue/issues/4783)) - ([417ef8f](https://github.com/bootstrap-vue/bootstrap-vue/commit/417ef8f2165e68d182e942219d847511b0fd6e9c)) - -### Bug Fixes v2.6.0 - -- **b-form-datepicker:** menu focus handling for Firefox and Safari on MacOS, and fix v-model update - issue (closes [#4814](https://github.com/bootstrap-vue/bootstrap-vue/issues/4814), - [#4827](https://github.com/bootstrap-vue/bootstrap-vue/issues/4827)) - ([#4824](https://github.com/bootstrap-vue/bootstrap-vue/issues/4824)) - ([09fa920](https://github.com/bootstrap-vue/bootstrap-vue/commit/09fa920e4a904c6340c60586b40451dce94efc44)) -- **b-form-spinbutton:** prevent buttons from re-ordering when parent element is RTL - ([#4802](https://github.com/bootstrap-vue/bootstrap-vue/issues/4802)) - ([ae2cce9](https://github.com/bootstrap-vue/bootstrap-vue/commit/ae2cce9d593bd310b3d2256ade41df0243447970)) -- **b-form-spinbutton:** prevent double increment/decrement on mobile (fixes - [#4838](https://github.com/bootstrap-vue/bootstrap-vue/issues/4838)) - ([#4842](https://github.com/bootstrap-vue/bootstrap-vue/issues/4842)) - ([9c2c700](https://github.com/bootstrap-vue/bootstrap-vue/commit/9c2c700a91d7a6e57572f579f68996eaceda5c00)) - -### Other v2.6.0 - -- documentation updates -- dev dependency updates - - - -## [v2.5.0](https://github.com/bootstrap-vue/bootstrap-vue/compare/v2.4.2...v2.5.0) - -Released: 2020-02-18 - -### Features v2.5.0 - -- **b-calendar, b-form-datepicker:** new components `b-calendar` and `b-form-datepicker` (closes - [#3676](https://github.com/bootstrap-vue/bootstrap-vue/issues/3676), - [#1428](https://github.com/bootstrap-vue/bootstrap-vue/issues/1428)) - ([#4712](https://github.com/bootstrap-vue/bootstrap-vue/issues/4712)) - ([af0ded0](https://github.com/bootstrap-vue/bootstrap-vue/commit/af0ded0a3bdc9d69653e9c55f874d550e4909662)) -- **b-form-spinbutton:** new form control component `b-form-spinbutton` - ([#4744](https://github.com/bootstrap-vue/bootstrap-vue/issues/4744)) - ([da5e473](https://github.com/bootstrap-vue/bootstrap-vue/commit/da5e473bee8866f2940e027e5e7e87e3a2ff8f11)) -- **v-b-hover:** new directive for reacting to hover changes - ([#4771](https://github.com/bootstrap-vue/bootstrap-vue/issues/4771)) - ([b7adc6d](https://github.com/bootstrap-vue/bootstrap-vue/commit/b7adc6dc726f75c0578b3de5208f112bef58b4ad)) - -### Bug Fixes v2.5.0 - -- **b-form-tags:** improve accessibility for screen reader users - ([#4775](https://github.com/bootstrap-vue/bootstrap-vue/issues/4775)) - ([2328630](https://github.com/bootstrap-vue/bootstrap-vue/commit/2328630542defc395912165a964a95107f8a4ba9)) -- **b-modal:** additional fixes for show transition behaviour (closes - [#4761](https://github.com/bootstrap-vue/bootstrap-vue/issues/4761)) - ([#4777](https://github.com/bootstrap-vue/bootstrap-vue/issues/4777)) - ([1113c6f](https://github.com/bootstrap-vue/bootstrap-vue/commit/1113c6f951d86b7e6e6ba2161f935d2b6e0b5ce8)) - -### Other v2.5.0 - -- documentation updates -- documentation accessibility improvements -- dev dependency updates - - - -## [v2.4.2](https://github.com/bootstrap-vue/bootstrap-vue/compare/v2.4.1...v2.4.2) - -Released: 2020-02-15 - -### Bug Fixes v2.4.2 - -- **b-button:** when `href` is ""#"" add `role=button` and appropriate keydown handlers for A11Y - ([#4768](https://github.com/bootstrap-vue/bootstrap-vue/issues/4768)) - ([087a128](https://github.com/bootstrap-vue/bootstrap-vue/commit/087a1283977061c44d5b059c203f13d2326dabae)) -- **b-modal:** fix transition show enter timing (closes - [#4761](https://github.com/bootstrap-vue/bootstrap-vue/issues/4761)) - ([#4766](https://github.com/bootstrap-vue/bootstrap-vue/issues/4766)) - ([968c957](https://github.com/bootstrap-vue/bootstrap-vue/commit/968c95758e45610a8c002507790c79d87d8fe956)) - -### Other v2.4.2 - -- documentation updates -- dev dependency updates - - - -## [v2.4.1](https://github.com/bootstrap-vue/bootstrap-vue/compare/v2.4.0...v2.4.1) - -Released: 2020-02-12 - -### Bug Fixes v2.4.1 - -- **b-form-input, b-form-textarea:** handle change event for all mobile device keyboards (closes - [#4724](https://github.com/bootstrap-vue/bootstrap-vue/issues/4724)) - ([#4739](https://github.com/bootstrap-vue/bootstrap-vue/issues/4739)) - ([166a932](https://github.com/bootstrap-vue/bootstrap-vue/commit/166a932fb11fa552714aba7df67992e1265b9047)) -- **b-tooltip, v-b-tooltip:** fix arrow margin - ([#4727](https://github.com/bootstrap-vue/bootstrap-vue/issues/4727)) - ([865a655](https://github.com/bootstrap-vue/bootstrap-vue/commit/865a6557fbf49115c05326f9a96c4f9fdf135e96)) - -### Other v2.4.1 - -- dev dependency updates -- minor docs updates - - - -## [v2.4.0](https://github.com/bootstrap-vue/bootstrap-vue/compare/v2.3.0...v2.4.0) - -Released: 2020-02-01 - -### Features v2.4.0 - -- **b-modal:** add `ignore-enforce-focus-selector` prop (closes - [#4537](https://github.com/bootstrap-vue/bootstrap-vue/issues/4537)) - ([#4702](https://github.com/bootstrap-vue/bootstrap-vue/issues/4702)) - ([c3ac992](https://github.com/bootstrap-vue/bootstrap-vue/commit/c3ac99283927b5261d1df05d3c479c534011d7c5)) -- **b-nav-item-dropdown:** add `boundary` prop, applicable when not in `b-navbar` (closes - [#4684](https://github.com/bootstrap-vue/bootstrap-vue/issues/4684)) - ([#4691](https://github.com/bootstrap-vue/bootstrap-vue/issues/4691)) - ([3a50ad8](https://github.com/bootstrap-vue/bootstrap-vue/commit/3a50ad85e85e1c6dc55a36665062180687078708)) - -### Bug Fixes v2.4.0 - -- **b-dropdown:** focus-in handling for Safari and Firefox on macOS/iOS (closes - [#4328](https://github.com/bootstrap-vue/bootstrap-vue/issues/4328)) - ([#4426](https://github.com/bootstrap-vue/bootstrap-vue/issues/4426)) - ([2eab55b](https://github.com/bootstrap-vue/bootstrap-vue/commit/2eab55b4672a35a487b30f0f64c63b887b361473)) -- **b-form-input, b-form-textarea:** properly handle out-of-sync values (closes - [#4695](https://github.com/bootstrap-vue/bootstrap-vue/issues/4695)) - ([#4701](https://github.com/bootstrap-vue/bootstrap-vue/issues/4701)) - ([954176d](https://github.com/bootstrap-vue/bootstrap-vue/commit/954176d733dccdd074f5b6cb31c4041081a3b206)) - - - -## [v2.3.0](https://github.com/bootstrap-vue/bootstrap-vue/compare/v2.2.2...v2.3.0) - -Released: 2020-01-24 - -### Features v2.3.0 - -- **b-button-close:** add `content` prop - ([#4574](https://github.com/bootstrap-vue/bootstrap-vue/issues/4574)) - ([7379c6d](https://github.com/bootstrap-vue/bootstrap-vue/commit/7379c6dd0bac76307720645080741b3b0ed7ed99)) -- **b-form-tags:** new option to specify input type (closes - [#4644](https://github.com/bootstrap-vue/bootstrap-vue/issues/4644)) - ([#4645](https://github.com/bootstrap-vue/bootstrap-vue/issues/4645)) - ([b899fac](https://github.com/bootstrap-vue/bootstrap-vue/commit/b899faceb4c1fd8562454fa93432e70d7113401b)) -- **b-pagination, b-pagination-nav:** add page button class props and option to show first/last page - numbers (closes [#4597](https://github.com/bootstrap-vue/bootstrap-vue/issues/4597), - [#4533](https://github.com/bootstrap-vue/bootstrap-vue/issues/4533)) - ([#4622](https://github.com/bootstrap-vue/bootstrap-vue/issues/4622)) - ([3a3ee1d](https://github.com/bootstrap-vue/bootstrap-vue/commit/3a3ee1dc9312a1a8c530a5ea42d1d239d5a24351)) -- **icons:** add stacking support - ([#4658](https://github.com/bootstrap-vue/bootstrap-vue/issues/4658)) - ([b185cdb](https://github.com/bootstrap-vue/bootstrap-vue/commit/b185cdb686ddddcde1b98585b1fbc48859fc541a)) - -### Bug Fixes v2.3.0 - -- **v-b-modal:** only unbind/rebind during componentUpdated hook if trigger element or modal ID - changes (closes [#4669](https://github.com/bootstrap-vue/bootstrap-vue/issues/4669)) - ([#4672](https://github.com/bootstrap-vue/bootstrap-vue/issues/4672)) - ([e53a05d](https://github.com/bootstrap-vue/bootstrap-vue/commit/e53a05d960a9de0ca9636ee31e0197e7e554ddbc)) -- **utils:** pass all Array/Object util shortcuts as functions, for handling late loaded polyfills - ([#4647](https://github.com/bootstrap-vue/bootstrap-vue/issues/4647)) - ([f584425](https://github.com/bootstrap-vue/bootstrap-vue/commit/f5844256a03d2f4b8006900419acfa2c5e3803c3)) - - - -## [v2.2.2](https://github.com/bootstrap-vue/bootstrap-vue/compare/v2.2.1...v2.2.2) - -Released: 2020-01-15 - -### Bug Fixes v2.2.2 - -- **nuxt module:** remove unnecessary export statements - ([#4624](https://github.com/bootstrap-vue/bootstrap-vue/issues/4624)) - ([27f066c](https://github.com/bootstrap-vue/bootstrap-vue/commit/27f066cfa07ee311fe1e312d9a9ebd0eb76750c7)) - -### Other v2.2.2 - -- dev dependencies updates -- minor docs updates - - - -## [v2.2.1](https://github.com/bootstrap-vue/bootstrap-vue/compare/v2.2.0...v2.2.1) - -Released: 2020-01-13 - -### Bug Fixes v2.2.1 - -- **icons:** make icon transform props work with IE 11 (closes - [#4607](https://github.com/bootstrap-vue/bootstrap-vue/issues/4607)) - ([#4608](https://github.com/bootstrap-vue/bootstrap-vue/issues/4608)) - ([899779f](https://github.com/bootstrap-vue/bootstrap-vue/commit/899779f20015f719198a763136137eea01aa11ea)) -- **types:** add missing declarations for `b-form-select-option` & `b-form-select-option-group` - ([#4595](https://github.com/bootstrap-vue/bootstrap-vue/issues/4595)) - ([8d60832](https://github.com/bootstrap-vue/bootstrap-vue/commit/8d60832d38e74231a4bda15aa045b84aae97d2ed)) -- **types:** include named export BootstrapVue in declaration file - ([#4590](https://github.com/bootstrap-vue/bootstrap-vue/issues/4590)) - ([603307a](https://github.com/bootstrap-vue/bootstrap-vue/commit/603307aeccf6141b94eff2186baee4ec43439033)) -- **modal, tooltips, popovers**: remove `nextTick` delay when updating content in transporter portal - (closes [#4589](https://github.com/bootstrap-vue/bootstrap-vue/issues/4589)) - ([#4604](https://github.com/bootstrap-vue/bootstrap-vue/issues/4604)) - ([0e3e7e0](https://github.com/bootstrap-vue/bootstrap-vue/commit/0e3e7e03370685367ac69949e596c9fff5c68163)) -- **utils:** correct `identity` spelling error - ([#4579](https://github.com/bootstrap-vue/bootstrap-vue/issues/4579)) - ([7fed191](https://github.com/bootstrap-vue/bootstrap-vue/commit/7fed1911d6d9f7eae81526010483c71e1679e770)) - -### Docs v2.2.1 - -- add live validation examples in validation reference section - ([#4584](https://github.com/bootstrap-vue/bootstrap-vue/issues/4584)) - ([aca4a5c](https://github.com/bootstrap-vue/bootstrap-vue/commit/aca4a5c8f9a9ed0d7526de396ff072f0c1f4ebdf)) - -### Other v2.2.1 - -- dev dependencies updates - - - -## [v2.2.0](https://github.com/bootstrap-vue/bootstrap-vue/compare/v2.1.0...v2.2.0) - -Released: 2020-01-08 - -### Overview v2.2.0 - -- New optional icon components based on `BootstrapIcons v1.0.0-alpha2` -- New tagged input component `` -- Support for `Bootstrap v4.4.1` CSS/SCSS - -### Features v2.2.0 - -- **icons:** new optional icon components - ([#4489](https://github.com/bootstrap-vue/bootstrap-vue/issues/4489)) - ([d2bef17](https://github.com/bootstrap-vue/bootstrap-vue/commit/d2bef1715636fcb83de6d51808683e6feda671d0)) -- **b-collapse:** add new prop `appear` to animate an initially visible collapse - ([#4317](https://github.com/bootstrap-vue/bootstrap-vue/issues/4317)) - ([136a72b](https://github.com/bootstrap-vue/bootstrap-vue/commit/136a72b0352d4bb1339ab31f791087cbcda42fa5)) -- **b-collapse:** add optional scoping to default slot - ([#4405](https://github.com/bootstrap-vue/bootstrap-vue/issues/4405)) - ([8e95bac](https://github.com/bootstrap-vue/bootstrap-vue/commit/8e95bacf9d00562f2676689d067ae0db009cbbb6)) -- **b-container:** add support for Bootstrap v4.4.x new responsive containers - ([0e318f4](https://github.com/bootstrap-vue/bootstrap-vue/commit/0e318f4755e65eb569dcc579938d0d72c02abd62)) -- **b-dropdown:** add splitClass property to dropdown component - ([#4394](https://github.com/bootstrap-vue/bootstrap-vue/issues/4394)) - ([a5f342e](https://github.com/bootstrap-vue/bootstrap-vue/commit/a5f342e0e4de2186259e36e42cecda8c20e1c8ab)) -- **b-dropdown-form:** new `form-class` prop for adding classes to the form element (closes - [#4474](https://github.com/bootstrap-vue/bootstrap-vue/issues/4474)) - ([#4475](https://github.com/bootstrap-vue/bootstrap-vue/issues/4475)) - ([eef4200](https://github.com/bootstrap-vue/bootstrap-vue/commit/eef4200976f7921b1bb03f50c0ece8ee7c41ed0e)) -- **b-form-select:** add group/tree support and dedicated option and option-group components (closes - [#3222](https://github.com/bootstrap-vue/bootstrap-vue/issues/3222)) - ([#4267](https://github.com/bootstrap-vue/bootstrap-vue/issues/4267)) - ([f1ed017](https://github.com/bootstrap-vue/bootstrap-vue/commit/f1ed0177c20f9d7e7e340a8815d1b6bc66f7cb76)) -- **b-form-select:** support paths for `valueField`, `textField`, `htmlField` and `disabledField` - props ([#4386](https://github.com/bootstrap-vue/bootstrap-vue/issues/4386)) - ([ed3b736](https://github.com/bootstrap-vue/bootstrap-vue/commit/ed3b7360af415dc3cc56f0b6662c9d48cc165781)) -- **b-form-tags:** new tagged input component - ([#4409](https://github.com/bootstrap-vue/bootstrap-vue/issues/4409)) - ([00eb9d9](https://github.com/bootstrap-vue/bootstrap-vue/commit/00eb9d9fd460adca8227b3b344284b5cc49a734f)) -- **b-row:** add Bootstrap v4.4 row columns support - ([#4439](https://github.com/bootstrap-vue/bootstrap-vue/issues/4439)) - ([833b028](https://github.com/bootstrap-vue/bootstrap-vue/commit/833b028a2d6101d01b7012a7378359db1c801695)) -- **b-table:** better sort labeling for screen readers (closes - [#4487](https://github.com/bootstrap-vue/bootstrap-vue/issues/4487)) - ([#4488](https://github.com/bootstrap-vue/bootstrap-vue/issues/4488)) - ([d4e66fa](https://github.com/bootstrap-vue/bootstrap-vue/commit/d4e66fa48fdd1cd7fd4b93907fe999de3fc577f8)) -- **b-table, b-table-lite:** new `tbody-tr-attr` prop for arbitrary row attributes (closes - [#1864](https://github.com/bootstrap-vue/bootstrap-vue/issues/1864)) - ([#4481](https://github.com/bootstrap-vue/bootstrap-vue/issues/4481)) - ([4acf6ed](https://github.com/bootstrap-vue/bootstrap-vue/commit/4acf6ed863dd5edd85897a01b099c42322097d1b)) -- **b-tooltip:** add `noninteractive` prop (closes - [#4556](https://github.com/bootstrap-vue/bootstrap-vue/issues/4556)) - ([#4563](https://github.com/bootstrap-vue/bootstrap-vue/issues/4563)) - ([b3ad726](https://github.com/bootstrap-vue/bootstrap-vue/commit/b3ad7264d9b10fb1b8dfba70c62eed11a56519d6)) -- **build:** configure pre-commit hook (closes - [#4532](https://github.com/bootstrap-vue/bootstrap-vue/issues/4532)) - ([#4552](https://github.com/bootstrap-vue/bootstrap-vue/issues/4552)) - ([1bf9e59](https://github.com/bootstrap-vue/bootstrap-vue/commit/1bf9e59e8888a7a2cd6f135665103419f603a32d)) - -### Bug Fixes v2.2.0 - -- **b-table, b-table-lite:** handle edge case with row events when table is removed from dom. - instantiate row event handlers only when listeners are registered (fixes - [#4384](https://github.com/bootstrap-vue/bootstrap-vue/issues/4384)) - ([#4388](https://github.com/bootstrap-vue/bootstrap-vue/issues/4388)) - ([9a81cd4](https://github.com/bootstrap-vue/bootstrap-vue/commit/9a81cd414a2c534b96de0d82c3d00d94651e5a7b)) -- **b-toast:** fix internal `ensureToaster` method call when toaster name changes - ([#4468](https://github.com/bootstrap-vue/bootstrap-vue/issues/4468)) - ([744bb7a](https://github.com/bootstrap-vue/bootstrap-vue/commit/744bb7a77092a04184af31bf285e432110e1ab44)) -- **tooltips, popovers:** fix memory leak (closes - [#4400](https://github.com/bootstrap-vue/bootstrap-vue/issues/4400)) - ([#4401](https://github.com/bootstrap-vue/bootstrap-vue/issues/4401)) - ([c71352d](https://github.com/bootstrap-vue/bootstrap-vue/commit/c71352d674347e5e2d72fe8b82334fc87a4ffd8c)) -- **docs:** handle undocumented breaking changes in babel-standalone for IE 11 - ([#4484](https://github.com/bootstrap-vue/bootstrap-vue/issues/4484)) - ([56f8bb5](https://github.com/bootstrap-vue/bootstrap-vue/commit/56f8bb5af7fb7188da035210e8be28d7ae1c7bc1)) - - -
- - -# Bootstrap's Changelogs from `4.3.1` to `4.4.1` - -
- -### v4.4.1 - -- Fix Dart Sass compatibility -- Add :disabled for disabled fieldset - -### v4.4.0 - -Highlights -Here's what you need to know about v4.4.0. Remember that with every minor and major release of Bootstrap, we ship a new URL for our hosted docs to ensure URLs continue to work.- New responsive containers! Over a year in the making, fluid up to a particular breakpoint, available for all responsive tiers. - -- New responsive .row-cols classes for quickly specifying the number of columns across breakpoints. This one is huge for those of you who have asked for responsive card decks. -- New escape-svg() function for simplifying our embedded background-image SVGs for forms and more. -- New add() and subtract() functions for avoiding errors and zero values from CSS's built in calc feature. -- New make-col-auto() mixin to make our .col-auto class available with custom HTML. -- Fixed an issue with Microsoft Edge not picking up :disabled styles by moving selectors to [disabled]. -- Deprecated: bg-variant(), nav-divider(), and form-control-focus() mixins are now deprecated as they're going away in v5. -- Updated our spacing and alignment for modal footer elements like buttons to automatically wrap when space is constrained. -- More flexible form control validation styles thanks to fewer chained selectors. Also updated the :invalid validation icon to be an alert instead of an × to avoid confusion with browser functionality for clearing the form field value. -- Fixed a couple dozen CSS and JS bugs. -- Moved to GitHub Actions for CI/CD! Expect more updates to our CI setup over time here while Actions evolves. -- Updated documentation to fix links and typos, improved landmarks for secondary navigation, and a new security doc for guidelines on reporting potential vulnerabilities. - -
- -# Key takeaways - -Looking at BootsrapVue's and Bootstrap's changelogs, here a few key takeaways that we might want to consider. - -Upgrading to BootstrapVue `2.13.0` brings in a few new components and directives, most notably: - -- [``](https://bootstrap-vue.org/docs/components/form-datepicker) -- [``](https://bootstrap-vue.org/docs/components/calendar) -- [``](https://bootstrap-vue.org/docs/components/sidebar) -- [``](https://bootstrap-vue.org/docs/components/aspect) -- [``](https://bootstrap-vue.org/docs/components/form-spinbutton) -- [``](https://bootstrap-vue.org/docs/components/time) -- [``](https://bootstrap-vue.org/docs/components/form-tags) -- [`v-b-visible`](https://bootstrap-vue.org/docs/directives/visible) - -Bootstrap itself comes with some style updates, some of which seem to impact our components visually: - -- Modals' footer spacing has been adjusted, resulting in slight visual diff in `GlModal`: - -![storyshots-spec-js-image-storyshots-base-modal-opened-modal-1-diff](/uploads/47200cf4d2501eae297451019d0e7780/storyshots-spec-js-image-storyshots-base-modal-opened-modal-1-diff.png) - -Modals are widely used in GitLab's projects, but this impact seems acceptable considering that `GlModal` doesn't comply with Pajamas specifications at the moment. Let's smoke test a few modals in GitLab anyway, to make sure there aren't unexpected effect to this change. - - -- [Flush list groups](https://getbootstrap.com/docs/4.0/components/list-group/#flush) now remove the top border from the first list item, which impacts `GlPaginatedList`: - -![storyshots-spec-js-image-storyshots-base-paginated-list-default-1-diff](/uploads/a406894af3b047e280586e3016769940/storyshots-spec-js-image-storyshots-base-paginated-list-default-1-diff.png) - -This has a very low impact on GitLab as `GlPaginatedList` is only used in the **License Compliance** app: - -| **Before** | **After** | -| ------ | ------ | -| ![image](/uploads/97010196daa37cf7f97bfe38baf6180f/image.png) | ![image](/uploads/a8ac7a3b6ed956f196805d8d453594e5/image.png) | - - -Overall, there doesn't seem to be any negative impact. - -/cc @ealcantara",3 -32748785,2020-04-01 18:00:41.320,Remove outdated links from new_button.md,Fix outdated link in `src/components/base/new_button/new_button.md`,1 -31943476,2020-03-13 01:10:18.404,Improve GlIntersectionObserver performance,"## Description - -The [`GlIntersectionObserver`](https://gitlab.com/gitlab-org/gitlab-ui/blob/314dda4b7e37ba103daaa797c37a718d504a5b3c/src/components/utilities/intersection_observer/intersection_observer.vue#L1) creates an [IntersectionObserver](https://developer.mozilla.org/en-US/docs/Web/API/IntersectionObserver) for every instance. When implementing the [`GlResizeObserver`](https://gitlab.com/gitlab-org/gitlab-ui/blob/225bf66a8818cbf7f74ae1339b8f19b856f25352/src/directives/resize_observer/resize_observer.js#L6) we learned that these observers are [meant to be shared](https://github.com/WICG/ResizeObserver/issues/59). This is because there's a bottleneck with passing messages from the native environment to the JavaScript environment. - -## Demo - -Here's a patch that creates a 100x10 table filled with `gl-intersection-observers` which each update with the [`intersectionRatio`](https://developer.mozilla.org/en-US/docs/Web/API/IntersectionObserverEntry/intersectionRatio) of the triggered event. - -[0001-wip-big-table-example.patch](/uploads/287d49589b28d2182f76f6fc1298341f/0001-wip-big-table-example.patch) - -| Observers created for every instance (on `master`) | Observers shared (this proposal) | -|---------|----------| -| ![20200311_lots_of_intersection_observers_slow](/uploads/8fae9d5c39c6db4d1eabd1afd4c05b1f/20200311_lots_of_intersection_observers_slow.mp4) | ![20200311_shared_intersection_observer](/uploads/a530a94a856ba91e2e5f9e99cbd5380b/20200311_shared_intersection_observer.mp4) | - -- Notice that the first example the numbers take a long time to update. This is because there's a huge lag for triggering every ""IntersectionObservable"" callback. -- *side note:* I'm not sure where the decimals come from, but I think this has to do with the experimental nature of IntersectionObserver :shrug: -- Here's a dummy WIP patch used for the ""Observers shared"" example: [0002-wip-shared-intersection-observer.patch](/uploads/a4e94b9cce363c0a1b8f9660f46e98ab/0002-wip-shared-intersection-observer.patch) - - -## Proposal - -I suggest following the implementation of [`ResizeObserver`](https://gitlab.com/gitlab-org/gitlab-ui/blob/225bf66a8818cbf7f74ae1339b8f19b856f25352/src/directives/resize_observer/resize_observer.js#L6) as an example for this behavior: - -- Let's just create one intersection observable for now (later we can figure out what to do if we want some more explicit options) -- Let's move this to a directive (this way we don't create unnecessary `
`s)",2 -31614405,2020-03-05 12:37:13.315,Extend generate component to include basic unit test,"When you run `yarn generate:component`, there is no base unit test created alongside the component file scaffold, nor is there any indication of where to add a test. - -So we will: - -1. Add a very basic unit test scaffold to `yarn generate:component` -2. Extend the [contribute guide](https://gitlab.com/gitlab-org/gitlab-ui/-/doc/contributing/adding_components.md) to include information about adding component unit tests.",1 -31532459,2020-03-04 08:18:42.229,Add Navbar Component,"Coming from this comment: https://gitlab.com/gitlab-org/status-page/-/merge_requests/3#note_298425624 - -We are currently building the status page MVC and using the `gitlab/ui` lib heavily. - -One thing we would like is the ability to import a navbar/header from `gitlab/ui` which relies on the [bootstrap-vue navbar](https://bootstrap-vue.js.org/docs/components/navbar/) instead of needing to maintain custom header vue files and css. - -Given that, I am opening this issue to tackle the idea of adding a header/navbar component to the library.",2 -31081051,2020-02-20 14:56:21.173,GlSearchBoxByType debounce prop support,"## The issue - -Based on a conversation with @kushalpandya found here: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/25061#note_290719425 - -`GlSearchBoxByType` wraps `BFormInput` but doesn't support the `debounce` functionality that the bootstrap form input does. - -More information can be read here: https://bootstrap-vue.js.org/docs/components/form-input/#debounce-support - -## Examples - -```html - -``` - -**Network Tab:** -![Screen_Shot_2020-02-20_at_8.44.20_AM](/uploads/793a13dbf3ba09e83890ed7da22acb24/Screen_Shot_2020-02-20_at_8.44.20_AM.png) - -```html - -``` - -**Network Tab:** -![Screen_Shot_2020-02-20_at_8.43.10_AM](/uploads/a4cb18063d65b213eccbeda3390de162/Screen_Shot_2020-02-20_at_8.43.10_AM.png) - -## Proposal - -**Support the following props** - -```js -debounce: { - type: Integer -} -``` - -This would stop the model from updating until the debounce time has occurred",2 -29876826,2020-01-23 10:00:23.127,GlAvatarsInline: Add tooltip to badge,"When using `GlAvatarsInline`, a badge next to the avatars shows the number of remaining avatars when the total number of avatars exceeds the given `maxVisible` prop. Let's add a tooltip to the badge which shows the names. - -We should consider the following: -1. We need to specify a prop which will be used for the tooltip content -2. We might need to add a threshold prop (either a `max characters to display` or `max names to display` so in case the of a large number of remaining avatars, the tooltip won't bloat. -3. We should also truncate the tooltip text via JS (and append `...`) when the threshold from (2) is exceeded. - -",1 -29819740,2020-01-21 19:30:02.777,Add operator to filtered search,"In https://gitlab.com/gitlab-org/gitlab/merge_requests/19011, we added the ability to have an operator filter (NOT, AND). In order to integrate filtered search into the GitLab product completely, we'll have to add this to filtered-search in gitlab-ui.",3 -29712681,2020-01-17 18:48:44.957,Fix fonts size of help text in radios/checkboxes,"The following discussion from gitlab-org/gitlab-services/design.gitlab.com!1651 should be addressed: - -- [ ] @pedroms started a [discussion](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/merge_requests/1651#note_271309985): (+4 comments) - - > @jboyson unsure if related to this MR, the help text paragraph `p` has an odd font-size: - > - > ![image](/uploads/ee7235e8b6dbb5c4fc7c245a234a0685/image.png)",1 -29604263,2020-01-14 18:50:23.211,Add disabled option to radio example,"The following discussion from !1651 should be addressed: - -- [ ] @jboyson started a [discussion](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/merge_requests/1651#note_261290489): (+4 comments) - - > @pedroms review please. Please let me know if you think we need a more detailed example.",1 -29588969,2020-01-14 12:16:16.893,"Follow-up from ""ci: add automated integration branch CI job""","When https://gitlab.com/gitlab-org/gitlab/issues/22638 is merged, let's refactor the `create_integration_branch` CI job so it reads the package's URL from environment variables rather than passing through file artifacts. - -The following discussion from !1007 should be addressed: - -- [ ] @pgascouvaillancourt started a [discussion](https://gitlab.com/gitlab-org/gitlab-ui/merge_requests/1007#note_270619808): (+1 comment) - - > **note:** We won't need to write the URL to a file anymore once https://gitlab.com/gitlab-org/gitlab/issues/22638 is resolved",1 -29434322,2020-01-09 09:04:54.047,Abstract access to `nextTick()` in Jest tests into a utility function,"This is about craziness like `wrapper.vm.nextTick()` and it's bad-brother `vm.vm.nextTick()`. - -The following discussion from !999 should be addressed: - -- [ ] @ntepluhina started a [discussion](https://gitlab.com/gitlab-org/gitlab-ui/merge_requests/999#note_268989062): (+1 comment) - - > **nitpick**: out of the scope of the MR but `vm.vm` is triggering me so much :sweat_smile: could we use something like `wrapper` in future tests to distinguish VTU `Wrapper` from the actual Vue instance? - -One of the possible solutions: manually update all suits with [the suggestion](https://gitlab.com/gitlab-org/gitlab-ui/merge_requests/999#note_268739060) from https://gitlab.com/gitlab-org/gitlab-ui/merge_requests/999. - -However, a more abstract universal utility shared between all suits automatically would be preferable.",2 -53813668,2020-01-08 23:16:56.800,"Follow-up from ""Add Search examples and mark search as built""","The following discussion from gitlab-org/gitlab-services/design.gitlab.com!1655 should be addressed: - -- [ ] @tauriedavis started a [discussion](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/merge_requests/1655#note_268796592): (+3 comments) - - > Also I don't understand this text that says to set the content to ""Something else"" - > - > ![Screen_Shot_2020-01-08_at_10.44.30_AM](/uploads/2df1808315cbf97977e710871bfaf4f3/Screen_Shot_2020-01-08_at_10.44.30_AM.png) - > - > Should that be removed? - -# Solution - -Remove text button from below search bar",1 -29367090,2020-01-07 12:18:37.081,Migrate away from deprecated slots syntax,"The following discussion from !993 should be addressed: - -- [ ] @ntepluhina started a [discussion](https://gitlab.com/gitlab-org/gitlab-ui/merge_requests/993#note_267967306): - - > **nitpick**: Again, outside the current MR's scope :sweat_smile: `slot` attribute has been deprecated since Vue 2.6, could we please create a follow-up issue to replace them with `v-slot` directive? Warning: this might affect unit tests as vue-test-utils still work with Vue 2.5 syntax and you will need to stub a component to test its slots.",2 -27266277,2019-11-20 16:28:50.674,Prevent style leaking into components,"## The issue - -Inheritable styles are being overridden. For example, Pajamas often leaks `line-height` and adds margins to headings (see image below). - -## The fix? :thinking: - -Create a class that explicitly sets all known inheritable properties, and use this class on all components. - -ex: - -```css -.gl-reset { - line-height: 1rem; - font-size: 1rem; - ... -} -``` - -## Build tool update? :thinking: - -Remembering to add `.gl-reset` to every component is potentially error-prone. Is it possible to update webpack to auto-include this class for every component? - -## List of known inheritable properties - -* border-collapse -* border-spacing -* caption-side -* color -* cursor -* direction -* empty-cells -* font-family -* font-size -* font-style -* font-variant -* font-weight -* font-size-adjust -* font-stretch -* font -* letter-spacing -* line-height -* list-style-image -* list-style-position -* list-style-type -* list-style -* orphans -* quotes -* tab-size -* text-align -* text-align-last -* text-decoration-color -* text-indent -* text-justify -* text-shadow -* text-transform -* visibility -* white-space -* widows -* word-break -* word-spacing -* word-wrap - -## Example of the issue - -https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/merge_requests/1620#note_245401786 - -![image](/uploads/3927ca1641e8f80faad09d30a6676136/image.png) - -## What success looks like - -* [ ] Ensure all current demos on design tab match design specs",2 -26686666,2019-11-04 22:44:46.435,Use sass functions for box-shadow utilities,"box-shadows do not lend themselves well to be ""just"" utility classes. We need some functions to make it easier to maintain shadows for use in components such as toggles, and buttons. - -The following discussion from !876 should be addressed: - -- [ ] @jboyson started a [discussion](https://gitlab.com/gitlab-org/gitlab-ui/merge_requests/876#note_239100122): (+4 comments) - - > @ealcantara can I get some feedback on how I'm proceeding with these? This is the duplicate ""boilerplate"" code I was talking about.",1 -26532167,2019-10-31 16:52:34.039,Add toggle and label composition examples,"Add examples for different use cases with toggles. - -For example, label on either side, above, with help text. - -Details :point_right: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/issues/279#note_237461152",1 -26498291,2019-10-30 18:41:00.865,Use default import for files using `raw-loader`,"## Description - -There are a number of files where we use - -``` -import * as description form './something.md'; -``` - -instead of a simple - -``` -import description from './something.md'; -``` - -It's surprising that these both work, but let's try to be consistent and use the [expected default export](https://github.com/webpack-contrib/raw-loader). - -## The list - -``` -git grep -E ""import \\*.*md['\""]"" - -src/components/base/avatar/avatar.documentation.js -src/components/base/avatar_labeled/avatar_labeled.documentation.js -src/components/base/avatar_link/avatar_link.documentation.js -src/components/base/breadcrumb/breadcrumb.documentation.js -src/components/base/button/button.documentation.js -src/components/base/button_group/button_group.documentation.js -src/components/base/datepicker/datepicker.documentation.js -src/components/base/daterange_picker/daterange_picker.documentation.js -src/components/base/dropdown/dropdown.documentation.js -src/components/base/dropdown/dropdown_divider.documentation.js -src/components/base/dropdown/dropdown_header.documentation.js -src/components/base/dropdown/dropdown_item.documentation.js -src/components/base/form/form_checkbox/form_checkbox.documentation.js -src/components/base/form/form_group/form_group.documentation.js -src/components/base/form/form_input/form_input.documentation.js -src/components/base/form/form_radio/form_radio.documentation.js -src/components/base/form/form_select/form_select.documentation.js -src/components/base/form/form_textarea/form_textarea.documentation.js -src/components/base/friendly_wrap/friendly_wrap.documentation.js -src/components/base/icon/icon.documentation.js -src/components/base/infinite_scroll/infinite_scroll.documentation.js -src/components/base/intersperse/intersperse.documentation.js -src/components/base/link/link.documentation.js -src/components/base/loading_icon/loading_icon.documentation.js -src/components/base/modal/modal.documentation.js -src/components/base/new_button/new_button.documentation.js -src/components/base/new_dropdown/dropdown_divider.documentation.js -src/components/base/new_dropdown/dropdown_header.documentation.js -src/components/base/new_dropdown/dropdown_item.documentation.js -src/components/base/new_dropdown/new_dropdown.documentation.js -src/components/base/paginated_list/paginated_list.documentation.js -src/components/base/pagination/pagination.documentation.js -src/components/base/search_box_by_click/search_box_by_click.documentation.js -src/components/base/search_box_by_type/search_box_by_type.documentation.js -src/components/base/skeleton_loading/skeleton_loading.documentation.js -src/components/base/sorting/sorting.documentation.js -src/components/base/sorting/sorting_item.documentation.js -src/components/base/table/table.documentation.js -src/components/base/tabs/tab/tab.documentation.js -src/components/base/tabs/tabs/tabs.documentation.js -src/components/base/toast/toast.documentation.js -src/components/base/tooltip/tooltip.documentation.js -src/components/charts/area/area.documentation.js -src/components/charts/chart/chart.documentation.js -src/components/charts/column/column.documentation.js -src/components/charts/discrete_scatter/discrete_scatter.documentation.js -src/components/charts/heatmap/heatmap.documentation.js -src/components/charts/legend/legend.documentation.js -src/components/charts/line/line.documentation.js -src/components/charts/series_label/series_label.documentation.js -src/components/charts/single_stat/single_stat.documentation.js -src/components/charts/stacked_column/stacked_column.documentation.js -src/components/charts/tooltip/tooltip.documentation.js -src/components/regions/dashboard_skeleton/dashboard_skeleton.documentation.js -src/components/regions/empty_state/empty_state.documentation.js -src/directives/resize_observer/resize_observer.documentation.js -```",1 -26329461,2019-10-25 20:38:56.437,Prevent `segmented_control` forever loop edge case,"## Description - -There's an extreme edge case where usage of `segmented_control` could produce a forever loop. Let's figure out a nice way to prevent this from **ever** happening. - -## Context - -The following discussion from !689 should be addressed: - -- [ ] @pslaughter started a [discussion](https://gitlab.com/gitlab-org/gitlab-ui/merge_requests/689#note_235853534): (+3 comments) - - > **suggestion (non-blocking):** I just realized that there's some cases where this `$emit('input')` on `watch('checked')` can cause a forever loop. Obviously we can't prevent the client of this component from doing something dangerous... If you think we can improve this, maybe it's worth a follow up issue :shrug: - > - > While we're here what do you think of adding this bit where we don't submit a `oldValue` suggestion if it's equal to the new value (which can happen if they are objects/arrays). It's a bit paranoid I know.... - > - >
- > - > ```patch - > diff --git a/src/components/base/segmented_control/segmented_control.vue b/src/components/base/segmented_control/segmented_control.vue - > index 5906b8dd..0f8e63e2 100644 - > --- a/src/components/base/segmented_control/segmented_control.vue - > +++ b/src/components/base/segmented_control/segmented_control.vue - > @@ -47,8 +47,12 @@ export default { - > if (!this.enabledOptions.some(({ value }) => value === newValue)) { - > // eslint-disable-next-line no-console - > console.warn(genericErrorMessage); - > + - > + // prevent a forever loop when values are objects - > + const suggestion = oldValue && newValue !== oldValue ? oldValue : null; - > + - > if (this.enabledOptions.length) { - > - this.$emit('input', oldValue || this.enabledOptions[0].value); - > + this.$emit('input', suggestion || this.enabledOptions[0].value); - > } - > } - > }, - > - > ``` - > - >
- -/cc @xanf",2 -26011100,2019-10-16 17:01:37.290,Build text badges,"Build **text-only** variations of badges: https://gitlab-org.gitlab.io/gitlab-design/hosted/design-gitlab-specs/badges-spec-previews/ - -Take into account **size** and **color** variations. - -![image](/uploads/a6cf8a393ea1a169e9aba4e3b3842e4d/image.png)",1 -26011010,2019-10-16 16:57:17.568,Style text badges,"Style **text-only** variations of badges: https://design.gitlab.com/components/badge#design-specifications - -Take into account **size** and **color** variations, and ignore the icons for now. - -![Screenshot_from_2020-04-21_15-33-00](/uploads/0bc742ac131af789a037a0e422bea929/Screenshot_from_2020-04-21_15-33-00.png) - -## Tasks - -* [x] Implement in GitLab UI https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/1248 - * [x] Make old `GlBadge` available as `GlDeprecatedBadge` - * [x] Implement new badge available as `GlBadge` -* [ ] Create integration MR for GitLab ~~https://gitlab.com/gitlab-org/gitlab/-/merge_requests/28356~~ https://gitlab.com/gitlab-org/gitlab/-/merge_requests/31646 -* [ ] Create integration MR for [Status Page](https://gitlab.com/gitlab-org/status-page/) ~~(currently blocked by https://gitlab.com/gitlab-org/status-page/-/merge_requests/78)~~ https://gitlab.com/gitlab-org/status-page/-/merge_requests/90 -* [-] Create integration MR for [Customer Portal](https://gitlab.com/gitlab-org/customers-gitlab-com) - * It turns out the Customer Portal doesn't use `GlBadge`, so no integration MR is necessary! -* [x] Create epic to migrate `GlDeprecatedBadge` usage to `GlBadge` https://gitlab.com/groups/gitlab-org/-/epics/3280 -* [x] Open issue under https://gitlab.com/groups/gitlab-org/-/epics/2964 to tackle slightly-wrong colours (https://gitlab.com/gitlab-org/gitlab/-/merge_requests/28356#note_337466265) - * https://gitlab.com/gitlab-org/gitlab/-/issues/213570 will address the grays being different between gitlab-ui and GitLab. ",2 -26004139,2019-10-16 14:31:12.260,Add a close button component,"Some components (e.g., [alert](#454), [banner](#453)) include a close/dismiss button. It makes sense to extract this into a dedicated component, much like [BootstrapVue does](https://github.com/bootstrap-vue/bootstrap-vue/blob/v2.0.0-rc.28/src/components/button/button-close.js). - -cc @samdbeckham",1 -25935762,2019-10-15 04:37:10.710,gl-popover-title margin 0,"From https://gitlab.com/gitlab-org/gitlab/merge_requests/18543#note_230295935 - -currently `.md h3` adds styles to popovers in markdown areas (i.e. chart tooltips). We should explicitly set `margin: 0` in the [popover styles](https://gitlab.com/gitlab-org/gitlab-ui/blob/79f157f1433bfc691f56aa3516f3b319bc3d0055/components/base/popover/popover.scss#L45) to prevent this",1 -25705004,2019-10-08 00:35:33.404,Customizable heatmap tooltip content,"Add slot content similar to other chart components. - -Currently the tooltip just displays the value (as the default tooltip used to). - -It should instead have overridable slot similar to other charts",1 -25549831,2019-10-02 15:35:54.323,Remove the Wiki,"After adding the [`FAQ.md`](https://gitlab.com/gitlab-org/gitlab-ui/blob/master/FAQ.md) to the repo, I realized that there was already one in the Wiki: https://gitlab.com/gitlab-org/gitlab-ui/wikis/Frequently-asked-questions - -When I asked on Slack what we should to about this, @gtsiolis suggested the following: - -> **Suggestion**: To avoid this from happening again, I vote for removing wiki altogether. -Wiki is already hidden for members and completely inaccessible for anonymous users because of the missing home page. See https://gitlab.com/gitlab-org/gitlab/issues/22319, https://gitlab.com/gitlab-org/gitlab/issues/22319, etc. Not sure if dogfooding two (one of them obsolete) wiki pages brings in much value. -> -> **To-do**: Let’s merge FAQ contents and also go through the roadmap page where most of the items have been completed or replaced with newer initiatives. Maybe consider moving one or two items from the roadmap wiki to the WG epic in https://gitlab.com/groups/gitlab-org/-/epics/950 if needed. - -# Todos - -- [x] Move [questions](https://gitlab.com/gitlab-org/gitlab-ui/wikis/Frequently-asked-questions) from the wiki to [`FAQ.md`](https://gitlab.com/gitlab-org/gitlab-ui/blob/master/FAQ.md) -- [x] Move [items from the roadmap](https://gitlab.com/gitlab-org/gitlab-ui/wikis/Roadmap) to the [epic](https://gitlab.com/groups/gitlab-org/-/epics/950) as needed -- [x] Remove the Wiki",2 -25395588,2019-09-27 20:41:55.077,Reimplement storyshots integration to allow for local testing,"Currently it is not possible to run visual regression tests locally (or update them locally) because the generated screenshots render differently from thew way they do in our CI job. This is due to a difference in operating system and browser versions (different core OS elements, different font-rendering, etc). - -I propose that we encapsulate our puppeteer/browser/os scripting for storyshots into a docker image that can be run both locally and in CI to produce deterministic visual regression snapshots regardless of ones working environment.",2 -24498021,2019-09-05 13:52:28.333,Increase Chart type maintainability: Explore declarative child components,"Seems like we have a lot of chart components that have overlapping options and duplicated code. We should evaluate how to move forward with maintaining new chart types with echarts so we reduce complexity and duplication. - -One suggestion can be found at https://gitlab.com/gitlab-org/gitlab-ce/issues/66393#note_207221124 and https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/32361#note_211103506",5 -23981163,2019-08-20 17:10:09.087,Form style updates,"1. Textarea padding should be `8px 12px` (it's currently `6px 10px`) -2. Help text should be `#707070` (it's currently `#919191`) -3. Inputs are missing the clear icon -4. disabled inputs styling is wrong - -![Screen_Shot_2019-08-20_at_12.01.52_PM](/uploads/e02e53e354b5c741ae027bd83a219660/Screen_Shot_2019-08-20_at_12.01.52_PM.png) - -4. I don't see this green validation in the specs so I'm not sure we need it here :thinking: - -![Screen_Shot_2019-08-20_at_12.04.44_PM](/uploads/cd3629764623ca9d3e5c7e32f10d9d67/Screen_Shot_2019-08-20_at_12.04.44_PM.png) - - - - -Also, we're missing several examples specified in the [specs](https://gitlab-org.gitlab.io/gitlab-design/hosted/design-gitlab-specs/forms-spec-previews/). For example, I didn't see these: -* an input with a character limit -* input sizes -* help text with a `more information` link",3 -23850064,2019-08-16 18:24:23.458,Legend in stacked line chart needs spacing,"The visualMap/legend in the stacked line chart needs spacing: - -![image](/uploads/8b507a0ad9fdef29227934835b568740/image.png) - -Correct spacing should be 8px",1 -23822672,2019-08-16 00:25:06.125,Fix spacing in yAxis labels for charts,"The yAxis has no spacing between the labels and the borders, like so: - -![Screen_Shot_2019-08-15_at_5.20.16_PM](/uploads/75bfdcedad99c8422780c33981441395/Screen_Shot_2019-08-15_at_5.20.16_PM.png) - -This is a problem in the following charts: - -* Area Chart -* Chart -* Discreet Scatter Chart -* Line Chart - -It should match what's in [GitLab UI](https://gitlab-org.gitlab.io/gitlab-ui/?path=/story/charts-area-chart--default).",1 -23809467,2019-08-15 14:04:39.915,Update token component to add avatar,The token component has been updated in Pajamas to include an avatar in some cases. Specs can be found here https://gitlab-org.gitlab.io/gitlab-design/hosted/design-gitlab-specs/tokens-spec-previews/,1 -23637535,2019-08-09 11:33:48.722,Use rems for everything instead of pixels,"Follow-up to the discussion in https://gitlab.com/gitlab-org/gitlab-ui/merge_requests/684#note_200806252 - -All spacing utility classes use pixels, based on Pajamas’ spacing specifications that use an 8px grid spacing system. However, using pixels doesn't allow elements and spacing to scale correctly if the user adjusts their browser zoom level (see https://gitlab.com/gitlab-org/gitlab-ui/merge_requests/684#note_201375954) - -Use rems for everything instead of pixels fixes this. - -The `8px` spacing system from Pajamas uses pixels instead of rems because it's easier for everyone to understand the concept that way, and also because UI design software uses pixels. It would be harder to explain it if we said “We use 0.5rem as the base for determining our spacial system.” as this doesn't mean anything if we don't know the root size, so we would need to add “The root size is 16px”. - -When translating designs to the browser, the expectation is that 16px in the design translates to 16px **rendered** in the browser, but that doesn't mean we can't use rems to specify it. So the current spacing utility classes implementation took a literal approach to the `8px` spacing system.",2 -23584330,2019-08-07 18:09:46.334,Replace bootstrap overrides in the breadcrumb component,"### Problem - -The breadcrumb component was added in https://gitlab.com/gitlab-org/gitlab-ui/merge_requests/387 but this also added some style overrides which affected existing components in the product like the breadcrumb for the repository path. See also relevant slack [discussion](https://gitlab.slack.com/archives/CK75EF2A2/p1565117360157200) (internal). - -### Proposal - -Let's replace the [overrides](https://gitlab.com/gitlab-org/gitlab-ui/blob/master/components/base/breadcrumb/breadcrumb.scss#L31-43) with `gl-*` classes.",1 -23581229,2019-08-07 15:57:48.300,Add support for breadcrumb truncation,"### Problem - -The initial breadcrumb component [implementation](https://gitlab.com/gitlab-org/gitlab-ui/merge_requests/387) does *not* support breadcrumb truncation. - -### Proposal - -Let's add support for breadcrumb truncation per [specs](https://gitlab-org.gitlab.io/gitlab-design/hosted/design-gitlab-specs/breadcrumbs-spec-previews/). See also component [documenation](https://design.gitlab.com/components/breadcrumbs#truncation) for truncation: - -> Breadcrumbs should use the following rules to truncate items: -> - Use an ellipsis button to hide groups when there are three or more subgroups in the path. -> - Use an ellipsis button to hide all Wiki page breadcrumb items except the current page. -> - The top-level group and the subgroup closest to the project are never collapsed. -> - All breadcrumb items except the last one are truncated to 128px if there isn’t enough horizontal space to fit them on one line.",3 -23547603,2019-08-06 15:40:52.557,Add support for opt-in avatar on every step of the breadcrumb component,"### Problem - -Following the dicsussion in https://gitlab.com/gitlab-org/gitlab-ui/merge_requests/387#note_199608310, the initial breadcrumb component implemented does _not_ support opt-in avatar on every step of the breadcrumb. Since the current implementation of the breadcrumb hides or shows the avatar per need, adding support for opt-in avatar on every step of the breadcrumb component could help make this more useful. - -### Proposal - -Let's add support for opt-in avatar on every step of the breadcrumb.",2 -23523138,2019-08-05 23:28:14.362,Add live demo of toggles,"Add demo of stacked and inline checkboxes here https://design.gitlab.com/components/toggles -Add `Vue Component` tab",1 -23523123,2019-08-05 23:25:22.165,Add live demo of grouped radio buttons,"Add demo of stacked and inline checkboxes here https://design.gitlab.com/components/radio-buttons -Add `Vue Component` tab",1 -23411982,2019-08-01 19:52:43.869,Avatars > avatars can be links > build,"Given the [goal of moving shared UI components](https://gitlab.com/groups/gitlab-org/-/epics/672) from gitlab-ce to gitlab-ui, gitlab-ui avatar component needs to support the features supported gitlab-ce avatar component. Clicking an avatar can take the user to a different URL. See https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/assets/javascripts/vue_shared/components/user_avatar/user_avatar_link.vue for more information of gitlab-ce avatar component",2 -23411894,2019-08-01 19:46:33.072,Avatars > Add tooltip support > build,"Given the [goal of moving shared UI components](https://gitlab.com/groups/gitlab-org/-/epics/672) from gitlab-ce to gitlab-ui, gitlab-ui avatar component needs to support the features supported gitlab-ce avatar component. Tooltips support is one of them. See https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/assets/javascripts/vue_shared/components/user_avatar/user_avatar_image.vue for more information of gitlab-ce avatar component",2 -23363483,2019-07-31 21:52:53.410,Follow-up: Generate arrays from SCSS lists in scss_variables module,"From this [discussion](https://gitlab.com/gitlab-org/gitlab-ui/merge_requests/623#note_198433120): - -`scss_variables` does a great job serving as a SSOT to share concepts such a colors, spacing scales, etc. between JavaScript and CSS. There is a problem in the JS side though. SASSList objects are not converted into JS Array objects by the script that generates `scss_variables.js`. Let’s improve the scss_variables generator to generate matching JS data types for SASS Lists and Maps.",2 -23206553,2019-07-26 18:35:15.566,Implement new type scale specifications,"Implement type-scale according to pajamas specifications: - -* [prototype](https://gitlab-org.gitlab.io/gitlab-design/hosted/pedro/%23168-responsive-type-prototype-html-previews/) -* [design specs](https://gitlab-org.gitlab.io/gitlab-design/hosted/pedro/%23168-responsive-type-spec-previews/). - -Note: See related issues for a breakdown of the individual type scale components.",3 -23171534,2019-07-25 20:54:43.178,Create separate variables for each design system spacing scale value,"In `variables.scss` the current representation of the spacing scale is the following: - -```scss -$gl-spacing-scale: ( - 0: 0, - 1: #{0.25 * $grid-size}, - 2: #{0.5 * $grid-size}, - 3: $grid-size, - 4: #{1.5 * $grid-size}, - 5: #{2 * $grid-size}, - 6: #{3 * $grid-size}, - 7: #{4 * $grid-size}, - 8: #{5 * $grid-size} -); -``` - -This representation was conceived with the purpose of automating the creation of utility classes. Since we are declaring such utilities manually, using this data structure is cumbersome. Let’s change it to separate variables: - -```scss -$gl-spacing-scale-0: 0; -$gl-spacing-scale-1: 0.25 * $grid-size; -// etc -```",1 -23095606,2019-07-23 21:19:42.919,Styling the Dropdown Pajamas Component within gitlab-ui,"Iterating on the the dropdown component within https://gitlab-org.gitlab.io/gitlab-ui/?path=/story/base-dropdown--default -to match the specs and usage detailed in https://design.gitlab.com/components/dropdowns/",3 -23004297,2019-07-19 15:33:00.351,Label component: remove ? from scoped labels,"Once interactive popups are complete, we can use that instead of the question mark on scoped labels. - -**Blocked by: https://gitlab.com/gitlab-org/gitlab/issues/27324/**",1 -22974775,2019-07-18 12:59:27.583,First radio button should be `checked` in Vue example,"### Problem: - -We have it as a requirement that one radio button in a set should be selected by default, however, the Vue example does not have one with the `checked` attribute. - -![Screen_Shot_2019-07-18_at_7.52.26_AM](/uploads/f138c025e1f2085ba7d118628c285b9e/Screen_Shot_2019-07-18_at_7.52.26_AM.png) - -### Solution: - -Add `checked` to the first radio button in the group. - -![Screen_Shot_2019-07-18_at_7.54.34_AM](/uploads/61e2ece3c73d395c78a3ccdff2e7c758/Screen_Shot_2019-07-18_at_7.54.34_AM.png) - -### Reason: - -It’s a good practice to have elements in states where they can be undone. In the case of radio buttons, once one in a group is selected, you can never unselect all to get back to the original state. For this reason, one radio button in a group should have the `checked attribute`, and typically it’s the first one unless the state reflects a previous choice. - -/cc @tauriedavis",1 -22703894,2019-07-11 13:33:38.127,Migrate GlProgressBar styles to gitlab-ui,Follow the guidelines described in the migration epic https://gitlab.com/groups/gitlab-org/-/epics/1590,2 -22610365,2019-07-08 17:56:34.757,Update heat map tooltip to chart popover,"The current heat map component uses the default ECharts tooltip. We should use the GitLab popover component instead so that the heat map is consistent with the rest of the charts. - -Current tooltip: - -![Screen_Shot_2019-07-08_at_10.53.50_AM](/uploads/02e10c01c9754697d5626e4f5c871a0e/Screen_Shot_2019-07-08_at_10.53.50_AM.png) - -[Expected popover](https://gitlab-org.gitlab.io/gitlab-ui/?path=/story/charts-chart-tooltip--default): - -![Screen_Shot_2019-07-08_at_10.55.57_AM](/uploads/8fc8f5521d2c0d37fec18c0ee5f5c7fc/Screen_Shot_2019-07-08_at_10.55.57_AM.png)",2 -22515122,2019-07-04 09:22:47.153,Remove onUpdated handler from several charts,"Since we're using `v-on=""$listeners""` on most our charts, we can remove the `onUpdated` handler as long as the handler does not implement any logic except for emitting the `updated` event.",1 -22293660,2019-06-26 19:28:07.587,Document styling components guidelines,"I find it useful to have a documented pattern with code examples, like our [Vuex documentation](https://docs.gitlab.com/ee/development/fe_guide/vuex.html). I propose to have something similar for styling components in gitlab-ui. - -The documentation is based on the styling component decisions documented in the RFC https://gitlab.com/gitlab-org/frontend/rfcs/issues/2 - -",3 -21640112,2019-06-06 12:48:58.608,Toggle > Add proper styling,"This is a follow up of https://gitlab.com/gitlab-org/gitlab-ui/issues/55. - -Should add the styling as is spec'ed in: -[Sketch Measure Preview for toggles](https://gitlab-org.gitlab.io/gitlab-design/hosted/design-gitlab-specs/toggles-spec-previews/) - -![Screen_Shot_2019-06-06_at_13.48.20](/uploads/91dee90cdbb78f7620a5fb947b68f75c/Screen_Shot_2019-06-06_at_13.48.20.png)",3 -21415757,2019-05-29 16:24:03.537,Toasts > Multiple toasts should stack,"Currently if multiple toasts are introduced, they will dismiss the previous toast prematurely. - -We have updated the usage guidelines to say that toasts should stack of there are more than one on a page. This needs to be implemented still.",3 -21415700,2019-05-29 16:21:58.752,Toasts > Steep width change,"When a second toast is introduced, the width of the toast takes the width of the first toast before rending the correct width. - -Multiple toasts should render their correct width: - -![Screen_Shot_2020-06-01_at_11.07.13_AM](/uploads/a48857ca2e29d8bc6e94d253d78a526e/Screen_Shot_2020-06-01_at_11.07.13_AM.png)",2 -21414491,2019-05-29 15:39:28.971,Ensure avatar examples don't rely on external images,"Currently, for our [Avatar stories and examples](https://gitlab.com/gitlab-org/gitlab-ui/blob/6232eb434adf190c8085aafd5787b17dd3b895b4/components/base/avatar/avatar.stories.js#L14), we use an image which is sourced from gitlab.com - -This is not ideal and could potentially cause our visual regression test suite to fail in the event that the image changes or becomes unavailable. - -## Solution - -Ideally, we should be using an image from within gitlab-ui.",2 -20640280,2019-05-07 06:48:49.965,Improve/simplify toast styling,"## Summary - -Currently, we use vue-toasted as a dependency for our toast component, which means that we're forced to override vue-toasted's styles in order to apply our own styling. - -Since we're overriding vue-toasted's styling we end up with nested CSS which becomes difficult to maintain. - -## Improvements - -We should come up with a way to make us less dependent on vue-toasted's stylesheet and make our CSS more maintainable. - -Perhaps there's a way we can disable their stylesheet entirely?",3 -20443271,2019-04-29 15:27:51.403,Switch from vue-toasted to BootstrapVue's toast component,"Our [current toast component](https://gitlab-org.gitlab.io/gitlab-ui/?path=/story/base-toast--default) relies on `vue-toasted`. - -BootstrapVue now includes its [own toast component](https://bootstrap-vue.js.org/docs/components/toast), which is in beta as of writing this. - -Let's remove the extra dependency on `vue-toasted` by switching to BootstrapVue's component once it's out of beta. - -This plan was discussed here: https://gitlab.com/gitlab-org/gitlab-ui/issues/238#note_162944906",3 -20440205,2019-04-29 14:05:38.803,Internationalization on chart legend - avg and max,"I noticed that the chart legend `Avg` and `Max` text isn't internationalizable: - -![Screenshot_2019-04-29_at_16.04.18](/uploads/8e4717f1b4ba608269a3ab74ea894a7c/Screenshot_2019-04-29_at_16.04.18.png) - -It is not possible to internationalize text within gitlab-ui. This could become a bigger issue as more components that contain text are added to gitlab-ui. - -This instance could be solved by making the text directly configurable via a prop.",2 -19939655,2019-04-10 20:09:47.635,Prettier job failures are confusing,"When Prettier fails in CI, it doesn't print a useful error message. All we get is a lousy `console.log` warning from eslint - -Example output: - -``` -$ yarn lint -yarn run v1.13.0 -$ eslint --ext .js,.vue . - -/builds/gitlab-org/gitlab-ui/components/base/loading_icon/loading_icon.vue - 68:7 warning Unexpected console statement no-console - -✖ 1 problem (0 errors, 1 warning) - -Done in 7.92s. -$ yarn prettier --list-different '**/*.{js,vue}' -yarn run v1.13.0 -$ /builds/gitlab-org/gitlab-ui/node_modules/.bin/prettier --list-different '**/*.{js,vue}' -components/base/form/form_select/form_select.vue -error Command failed with exit code 1. -info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. -ERROR: Job failed: exit code 1 -``` - -Better would be message saying ""please run `prettier --write` to fix the errors""",1 -19767198,2019-04-05 12:05:39.740,Add label component,"https://design.gitlab.com/components/label/ - -**Note** This should encompass both regular labels and scoped labels - -- Specs: https://gitlab-org.gitlab.io/gitlab-design/hosted/design-gitlab-specs/labels-spec-previews/",2 -25764601,2019-03-28 00:40:56.149,Scoped labels restyled,"From https://gitlab.com/gitlab-org/gitlab-ee/issues/9175#note_154807790 - -| Different sizes/colors | In sidebar | -| ------ | ------ | -| ![Screen_Shot_2019-04-11_at_1.08.25_PM](/uploads/8313885213bd48454a1f6473fdb1a143/Screen_Shot_2019-04-11_at_1.08.25_PM.png) | ![130CFA63-2847-460C-851C-FC1DCBEBA930](/uploads/fa97c4af2921f11d434ab65fcee9cdf1/130CFA63-2847-460C-851C-FC1DCBEBA930.png) | - - -Note that for this iteration, **the question mark icon will still be in the label**, so they'll look like this: - - - - -### Design notes/specs - -* Border on large labels is `2px`; on small labels it's `1px` -* We currently choose the text color based on which color the user selected as background. If the label background is dark, it has white text, if it is light, it has dark text - * For labels with white text, the label value should have a white background, and the text color should match the background of the scope portion (revert the 2 colors) - * For labels with dark text, the label value should still have a white background, but the text color should still be the standard dark text color - * The question mark icon is `$gray-500`: `#a7a7a7` -* Specs- https://gitlab-org.gitlab.io/gitlab-design/hosted/annabel/%23282-scoped-labels-spec-previews/",2 -25729794,2019-03-14 12:01:50.531,Update labels in gitlab-ui to use interactive popover,"gitlab-ce~9594407 since GitLabbers use labels heavily. - ---- - -### Problem to solve - -We currently have links included in label tooltips, which are not particularly helpful as tooltips disappear as soon as you hover outside the element. - -![Screen_Shot_2019-03-14_at_6.59.15_AM](/uploads/91b79cf042d492a0cd8091cf52983a25/Screen_Shot_2019-03-14_at_6.59.15_AM.png) - -### Design Solution - -| Labels | New label form | -| ------ | ------ | -| ![links_in_labels](/uploads/38dbb21948d34b39c62127c980313375/links_in_labels.png) | ![Label_Popover](/uploads/4ec5209918011aef1a1219107f3b519a/Label_Popover.png) | - - - -
-| New label form | Labels | -| ------ | ------ | -| ![Screen_Shot_2019-10-30_at_12.48.57_PM](/uploads/b32f1abc9dc6572af50d30ee12b1c304/Screen_Shot_2019-10-30_at_12.48.57_PM.png) | ![Screen_Shot_2019-10-30_at_12.49.08_PM](/uploads/51507808cb24099a25d5bcd1c376412b/Screen_Shot_2019-10-30_at_12.49.08_PM.png) | -| Links should be blue, scoped labels `?` should link to docs | Convert description `input` to `textarea`; add markdown help text | - - -Previous design -From @cperessini's comment in https://gitlab.com/gitlab-org/gitlab-design/issues/282#note_150466105 - -![Screen_Shot_2019-03-14_at_6.58.24_AM](/uploads/04c9ef1af30b048e54054d58578cd2c4/Screen_Shot_2019-03-14_at_6.58.24_AM.png) -
- -**Blocked by:** https://gitlab.com/gitlab-org/gitlab-ui/merge_requests/855",2 -18765462,2019-03-04 07:47:55.125,Standalone `gl-form-radio` components do not work without a `gl-form-radio-group` ancestor,"As of writing, our `gl-form-radio` component wrapper is unusable. Once !192 is merged, it will be usable, but *only* as a descendant of a `gl-form-radio-group` component. - -The underlying `b-form-radio` components we wrap *can* be used *without* any ancestor `b-form-radio-group` component, however. The issue is that we're not correctly forwarding the `v-model` directive from the `gl-form-radio` component down to the `b-form-radio`. - -Part of #135.",2 -17389480,2019-01-16 12:47:23.127,Search box icon is positioned incorrectly in Safari,"spotted in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/8591#note_132045635 - -The dropdown search icon appears to be positioned incorrectly in Safari - -![Screenshot_2019-01-16_at_12.58.22](/uploads/35ec58b1df39e81dbe8af7e76d1235c2/Screenshot_2019-01-16_at_12.58.22.png)",1 -16752951,2018-12-18 12:28:18.551,Add bootstrap-vue's radio button components,To support browser consistent radio buttons we need to wrap https://bootstrap-vue.js.org/docs/components/form-radio for https://design.gitlab.com/components/radio-buttons/ and https://design.gitlab.com/components/segmented-control,2 -16630702,2018-12-13 12:20:58.363,Fix spacing in search box component,"From https://gitlab.com/gitlab-org/gitlab-ui/issues/93#note_119655757: - -For the paddings I currently use the Bootstrap helpers which results in a different spacing than in the design specs: - -![Screen_Shot_2018-11-23_at_12.59.44](https://gitlab.com/gitlab-org/gitlab-ui/uploads/4a4afac9de55c2cedde412e84a9eba92/Screen_Shot_2018-11-23_at_12.59.44.png) - -![Screen_Shot_2018-11-23_at_12.59.32](https://gitlab.com/gitlab-org/gitlab-ui/uploads/2a3fbdb345a75455923778e60e7b7c94/Screen_Shot_2018-11-23_at_12.59.32.png) - -> I would prefer to have a new css file in gitlab-ce specifically for these kind of use cases, that way it's easier to remove them later on and they aren't scoped to these vue files - -> I created https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/23760 now. - -> The padding helper classes are now merged but the existing paddings (for example of `.form-control`) take precedence. :disappointed: Do we want to go down the `!important` route as Bootstrap does? Or should we go with https://gitlab.com/gitlab-org/gitlab-ce/issues/55256?",1 -16239820,2018-11-30 11:58:26.931,Add bootstrap-vue`s Breadcrumb component,Wrap the component from here https://bootstrap-vue.js.org/docs/components/breadcrumb/,2 -15869192,2018-11-15 11:14:21.875,Create a search / filter input field component,"We need a new component that follows the criteria of ""Search by typing"" from https://design.gitlab.com/components/search: - -> - The search action is triggered immediately after users start typing -> - a spinner is added in the right corner of the search box -> - A clear icon appears in the right corner when the search box contains content and there is no search activity happening in the background -> - Clicking the clear icon removes the content, focuses the input field (if not already), and hides itself -> - A magnifying glass icon is placed in the left corner of the search box -> - The placeholder in a search box should ideally be just “Search” - -![image](https://gitlab.com/gitlab-org/gitlab-ee/uploads/f764adeed9112f69c932a001f9f13979/image.png) - -design specs: https://gitlab-org.gitlab.io/gitlab-design/hosted/design-gitlab-specs/search-spec-previews/",3 -15868541,2018-11-15 10:49:16.907,Wrap Vue bootstrap dropdown components,"The following components from https://bootstrap-vue.js.org/docs/components/dropdown need to be wrapped: - -- [x] `` -- [x] `` -- [x] `` -- [x] `` -- [x] ``",5 -15795769,2018-11-13 14:22:58.115,Create avatar component,"Migrate existing or create new avatar component in gitlab-ui. - -Design documentation to be added via https://gitlab.com/gitlab-org/design.gitlab.com/issues/129. Documented avatar sizes can be found at https://gitlab.com/gitlab-org/gitlab-design/issues/196 - -Should leverage vue-bootstrap where possible, such as rounding corners: https://bootstrap-vue.js.org/docs/components/image. Perhaps it should wrap `b-img`?",3 -14665658,2018-10-03 21:03:47.560,Move package to new npm namespace,"Now that we've reclaimed the `@gitlab` namespace in npm, let's rename our packages. - -1. Update the namespace from `@gitlab-org` to `@gitlab`. -2. Update the package from `gitlab-ui` to just `ui`, since the namespace makes this redundant. - -Ultimately we can change our package imports in gitlab-ce like so: - -```javascript -// old -import { ProgressBar } from '@gitlab-org/gitlab-ui'; - -// new -import { ProgressBar } from '@gitlab/ui'; -``` - -Let's also make sure we deprecate the old package namespace with `npm deprecate`. This will place a friendly warning at the top of the npm page, and in the console when a user installs the old package (we need to make sure this warning message doesn't break old GitLab stable branches). - -See [jade (renamed to pug)](https://www.npmjs.com/package/jade) as an example of this.",3 -14384275,2018-09-21 19:14:17.028,Follow up from the link component,"In order to preserve the `rel` attribute state, this is required to do - -https://gitlab.com/gitlab-org/gitlab-ui/merge_requests/39#note_103511198 - -Also for href's which target the same domain, we might not want to set the `rel` attribute with `noreferrer noopener`",2 -14324673,2018-09-20 05:44:11.873,Toggle > Add to gitlab-ui,"- Add a new button with on, off, and loading state. -- Can have **label** (above) and **help text** (below), using the existing [`form-group` component](https://gitlab-org.gitlab.io/gitlab-ui/?path=/story/base-form-form-group--default) - -![Screen_Shot_2018-09-20_at_07.41.40](/uploads/c621e2b16860b9749bd3f851b00b6681/Screen_Shot_2018-09-20_at_07.41.40.png) - -![Screen_Shot_2018-09-20_at_07.42.02](/uploads/75182ca682309b03060d6206573a283c/Screen_Shot_2018-09-20_at_07.42.02.png) - - -From the comments we are going to roll our own based on [our current implementation](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/assets/javascripts/vue_shared/components/toggle_button.vue)",2 -14034828,2018-09-10 14:11:59.549,Move skeleton loading container from gitlab-ce to gitlab-ui,Move https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/assets/javascripts/vue_shared/components/skeleton_loading_container.vue to gitlab-ui,2 -14034744,2018-09-10 14:09:20.593,Move loading icon from CE to gitlab-ui,Move https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/assets/javascripts/vue_shared/components/loading_icon.vue to gitlab-ui,2 -14034604,2018-09-10 14:03:55.615,Add Text Button,"Create a wrapped component using bootstrap-vue's button that only works for text. - -This should also include button links (html that renders href but visually looks like buttons)",5 -14034558,2018-09-10 14:01:48.101,Add Bootstrap Vue's links,Add https://bootstrap-vue.js.org/docs/components/link to gitlab-ui,4 -85278252,2021-04-15 22:57:41.609,F/u/f gitlab!59537: Add needed CSS utility classes,"Moves the needed CSS utility classes from the `gitlab` codebase to the `gitlab-ui` codebase as part of the cleanup of [the “Highlight Paid Features During Active Trial” experiment](https://gitlab.com/groups/gitlab-org/-/epics/4721) (clean-up issue yet to be made). - -The following utility classes need to be migrated over: - -```scss -.gl-order-1 { - order: 1; -} - -.gl-sm-order-init { - @media (min-width: $breakpoint-sm) { - order: initial; - } -} - -.gl-xs-ml-3 { - @media (max-width: $breakpoint-sm) { - @include gl-ml-3; - } -} - -.gl-sm-mr-3 { - @media (min-width: $breakpoint-sm) { - @include gl-mr-3; - } -} -```",1 -85228948,2021-04-15 08:18:13.357,Allow only safe urls in GlButton,"### Proposal - -[GlButton](https://gitlab.com/gitlab-org/gitlab-ui/-/blob/main/src/components/base/button/button.vue) component should accept only secure and valid URLs. This means that it should prevent `javascript://` links. - -* should allow URLs only with the following protocols (http, https, ftp, mailto) -* should take care of encoded URIs -* should render as `span` tag when the `href` is unsafe - -[`GlSafeLinkDirective`](https://gitlab-org.gitlab.io/gitlab-ui/?path=/story/directives-safe-html-directive--default) can be used for that purpose. - -Since GitLab also relies on data URLs in some cases, we'll want to provide a way to set ""unsafe"" URLs that will skip the sanitization step. An idea would be to expose an `unsafe-url` prop. - -### Why - -The javascript links can lead to cross-site scripting bugs. For example, https://gitlab.com/gitlab-org/gitlab/-/issues/212630. It has been fixed by validating the zoom meeting links which should fix this particular security issue. However, other `GlButton` usages are still vulnerable if we miss any such validations. - -### Related Issues - -- [Allow only safe urls in GlLink](https://gitlab.com/gitlab-org/gitlab-ui/-/issues/823) -- [Preventing URL Injection](https://gitlab.com/gitlab-org/gitlab/-/issues/219124#prevent-url-injection) -- [XSS Retrospective](https://gitlab.com/gitlab-org/gitlab/-/issues/327824)",2 -84613078,2021-04-04 21:04:58.776,Safe Html v-safe-html Documentation Confusion,"Sorry I'm not overly familiar with the project (gitlab-ui) and the documentation etc but there are a few things that strike me as odd: - -https://gitlab-org.gitlab.io/gitlab-ui/?path=/docs/directives-safe-html-directive--default - -Renders the example like: - -![image](/uploads/642e43282c3d7b8b851d830e45124449/image.png) - -![image](/uploads/bb8a5bbeedf5eabdaba71da2a87f308a/image.png) - -So the ` **issue (ux, safari):** Unfortunately, it looks like the `scrollTo` with options is not supported by Safari ([see MDN](https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollTo#browser_compatibility)), which I believe is one of our support browsers... - > - > ![20210331_scrollable_tabs_safari](/uploads/8b65223522764200bf562fec3f6fa051/20210331_scrollable_tabs_safari.mp4) - > - > WDYT @jareko & @fguibert? You'll also notice the gradient blur isn't quite working the way we expect here :disappointed: - > - > @fguibert, if needed we might also have a smooth scroll function in GitLab which has some polyfilled support :thinking: - -Our list of supported browsers changed in %15.2: https://docs.gitlab.com/ee/update/removals.html#support-for-older-browsers. So it looks like we only need to worry about Safari >=14.1.",3 -81933792,2021-03-30 14:22:28.732,GlAvatar: size validator fails for valid values,"In https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/2102 we introduced some custom logic in `GlAvatar`'s `size` prop validator to log a more helpful error message when the provided size is invalid. A conditional was unfortunately reversed, which resulted in errors being thrown for any valid value.",1 -81672516,2021-03-25 21:24:48.829,Form select > Validation > Remove background image icon,"On select fields, we should remove the background image icon that appears on validations (red explanation mark in circle) - -![Screen_Shot_2021-03-25_at_2.23.56_PM](/uploads/7e95a1941161e4d048cf94edf2a0ea19/Screen_Shot_2021-03-25_at_2.23.56_PM.png)",1 -81672460,2021-03-25 21:22:43.620,Form inputs > Validation > Correct resting state,"From https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/2107#note_538237248, resting states of our form validations should utilize `red-400` for the border color. `red-500` should be used on hover/focus. Currently `red-500` is being used for all states.",1 -95058282,2021-03-22 14:45:44.188,Badge > Linked badges > Make examples in Pajamas the SSoT,"## Problem - -Embedded badge examples in Pajamas are different from GitLab UI. Having a SSoT will help accurately complete the badge accessibility audit https://gitlab.com/groups/gitlab-org/-/epics/5664. - -| **Pajamas** | **GitLab UI** | -| ------ | ------ | -| ![CleanShot_2021-03-22_at_15.10.48](/uploads/bae696a1643959a3567d5fe814ceebb9/CleanShot_2021-03-22_at_15.10.48.gif) | ![CleanShot_2021-03-22_at_15.11.14](/uploads/d9021a99ace7f666979d007b82bc8735/CleanShot_2021-03-22_at_15.11.14.gif) | - -## Solution - -Ensure badge examples align with the [badge design specs](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=425%3A3) and that action badges dont underline text on hover.",2 -81191940,2021-03-18 14:15:31.549,Migrate base/form/form_group stories to Component Story Format," -Migrate `base/form/form_group` stories to the [Component Story Format (CSF)](https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format). - -- [ ] Migrated `documentedStoriesOf` usages to the Component Story Format. -- [ ] Migrated or removed examples. -- [ ] Migrated props, slots and events documentation. - - [ ] If needed, migrated the `bootstrapComponent` parameter. -- [ ] Cleanup - - [ ] Component's README: - - [ ] Removed ``. - - [ ] Removed component's title. - - [ ] `documentation/documented_stories.js`: - - [ ] Added component's PascalCase name to `disableForComponents`. - -More details about the migration can be found in the epic: https://gitlab.com/groups/gitlab-org/-/epics/5651",2 -81191949,2021-03-18 14:15:31.497,Migrate charts/line stories to Component Story Format," -Migrate `charts/line` stories to the [Component Story Format (CSF)](https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format). - -- [ ] Migrated `documentedStoriesOf` usages to the Component Story Format. -- [ ] Migrated or removed examples. -- [ ] Migrated props, slots and events documentation. - - [ ] If needed, migrated the `bootstrapComponent` parameter. -- [ ] Cleanup - - [ ] Component's README: - - [ ] Removed ``. - - [ ] Removed component's title. - - [ ] `documentation/documented_stories.js`: - - [ ] Added component's PascalCase name to `disableForComponents`. - -More details about the migration can be found in the epic: https://gitlab.com/groups/gitlab-org/-/epics/5651",2 -81191912,2021-03-18 14:15:31.461,Migrate charts/legend stories to Component Story Format," -Migrate `charts/legend` stories to the [Component Story Format (CSF)](https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format). - -- [ ] Migrated `documentedStoriesOf` usages to the Component Story Format. -- [ ] Migrated or removed examples. -- [ ] Migrated props, slots and events documentation. - - [ ] If needed, migrated the `bootstrapComponent` parameter. -- [ ] Cleanup - - [ ] Component's README: - - [ ] Removed ``. - - [ ] Removed component's title. - - [ ] `documentation/documented_stories.js`: - - [ ] Added component's PascalCase name to `disableForComponents`. - -More details about the migration can be found in the epic: https://gitlab.com/groups/gitlab-org/-/epics/5651",2 -81191901,2021-03-18 14:15:30.995,Migrate base/navbar stories to Component Story Format,"Migrate `base/navbar` stories to the [Component Story Format (CSF)](https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format). - -Follow the steps described in the epic: https://gitlab.com/groups/gitlab-org/-/epics/5651",2 -81191902,2021-03-18 14:15:30.922,Migrate utilities/intersection_observer stories to Component Story Format," -Migrate `utilities/intersection_observer` stories to the [Component Story Format (CSF)](https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format). - -- [ ] Migrated `documentedStoriesOf` usages to the Component Story Format. -- [ ] Migrated or removed examples. -- [ ] Migrated props, slots and events documentation. - - [ ] If needed, migrated the `bootstrapComponent` parameter. -- [ ] Cleanup - - [ ] Component's README: - - [ ] Removed ``. - - [ ] Removed component's title. - - [ ] `documentation/documented_stories.js`: - - [ ] Added component's PascalCase name to `disableForComponents`. - -More details about the migration can be found in the epic: https://gitlab.com/groups/gitlab-org/-/epics/5651",2 -81191948,2021-03-18 14:15:30.768,Migrate base/toggle stories to Component Story Format,"Migrate `base/toggle` stories to the [Component Story Format (CSF)](https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format). - -Follow the steps described in the epic: https://gitlab.com/groups/gitlab-org/-/epics/5651",2 -81191950,2021-03-18 14:15:30.755,Migrate base/tooltip stories to Component Story Format," -Migrate `base/tooltip` stories to the [Component Story Format (CSF)](https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format). - -- [x] Migrated `documentedStoriesOf` usages to the Component Story Format. -- [x] Migrated or removed examples. -- [x] Migrated props, slots and events documentation. - - [x] If needed, migrated the `bootstrapComponent` parameter. -- [x] Cleanup - - [x] Component's README: - - [x] Removed ``. - - [x] Removed component's title. - - [x] `documentation/documented_stories.js`: - - [x] Added component's PascalCase name to `disableForComponents`. - -More details about the migration can be found in the epic: https://gitlab.com/groups/gitlab-org/-/epics/5651",2 -81191915,2021-03-18 14:15:30.673,Migrate regions/empty_state stories to Component Story Format,"Migrate `regions/empty_state` stories to the [Component Story Format (CSF)](https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format). - -Follow the steps described in the epic: https://gitlab.com/groups/gitlab-org/-/epics/5651",2 -81191974,2021-03-18 14:15:30.656,Migrate base/tabs stories to Component Story Format," -Migrate `base/tabs` stories to the [Component Story Format (CSF)](https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format). - -- [ ] Migrated `documentedStoriesOf` usages to the Component Story Format. -- [ ] Migrated or removed examples. -- [ ] Migrated props, slots and events documentation. - - [ ] If needed, migrated the `bootstrapComponent` parameter. -- [ ] Cleanup - - [ ] Component's README: - - [ ] Removed ``. - - [ ] Removed component's title. - - [ ] `documentation/documented_stories.js`: - - [ ] Added component's PascalCase name to `disableForComponents`. - -More details about the migration can be found in the epic: https://gitlab.com/groups/gitlab-org/-/epics/5651",2 -81191955,2021-03-18 14:15:30.640,Migrate base/button stories to Component Story Format,"Migrate `base/button` stories to the [Component Story Format (CSF)](https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format). - -Follow the steps described in the epic: https://gitlab.com/groups/gitlab-org/-/epics/5651",2 -81191967,2021-03-18 14:15:30.580,Migrate base/path stories to Component Story Format," -Migrate `base/path` stories to the [Component Story Format (CSF)](https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format). - -- [x] Migrated `documentedStoriesOf` usages to the Component Story Format. -- [x] Migrated or removed examples. -- [x] Migrated props, slots and events documentation. - - [x] If needed, migrated the `bootstrapComponent` parameter. -- [x] Cleanup - - [x] Component's README: - - [x] Removed ``. - - [x] Removed component's title. - - [x] `documentation/documented_stories.js`: - - [x] Added component's PascalCase name to `disableForComponents`. - -More details about the migration can be found in the epic: https://gitlab.com/groups/gitlab-org/-/epics/5651",2 -81191925,2021-03-18 14:15:30.551,Migrate base/token stories to Component Story Format,"Migrate `base/token` stories to the [Component Story Format (CSF)](https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format). - -Follow the steps described in the epic: https://gitlab.com/groups/gitlab-org/-/epics/5651",2 -81191972,2021-03-18 14:15:30.548,Migrate base/progress_bar stories to Component Story Format,"Migrate `base/progress_bar` stories to the [Component Story Format (CSF)](https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format). - -Follow the steps described in the epic: https://gitlab.com/groups/gitlab-org/-/epics/5651",2 -81191926,2021-03-18 14:15:30.548,Migrate utilities/sprintf stories to Component Story Format,"Migrate `utilities/sprintf` stories to the [Component Story Format (CSF)](https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format). - -Follow the steps described in the epic: https://gitlab.com/groups/gitlab-org/-/epics/5651",2 -81191939,2021-03-18 14:15:30.546,Migrate base/dropdown stories to Component Story Format," -Migrate `base/dropdown` stories to the [Component Story Format (CSF)](https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format). - -- [ ] Migrated `documentedStoriesOf` usages to the Component Story Format. -- [ ] Migrated or removed examples. -- [ ] Migrated props, slots and events documentation. - - [ ] If needed, migrated the `bootstrapComponent` parameter. -- [ ] Cleanup - - [ ] Component's README: - - [ ] Removed ``. - - [ ] Removed component's title. - - [ ] `documentation/documented_stories.js`: - - [ ] Added component's PascalCase name to `disableForComponents`. - -More details about the migration can be found in the epic: https://gitlab.com/groups/gitlab-org/-/epics/5651",2 -81191956,2021-03-18 14:15:30.546,Migrate utilities/friendly_wrap stories to Component Story Format," -Migrate `utilities/friendly_wrap` stories to the [Component Story Format (CSF)](https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format). - -- [x] Migrated `documentedStoriesOf` usages to the Component Story Format. -- [x] Migrated or removed examples. -- [x] Migrated props, slots and events documentation. - - [x] If needed, migrated the `bootstrapComponent` parameter. -- [x] Cleanup - - [x] Component's README: - - [x] Removed ``. - - [x] Removed component's title. - - [x] `documentation/documented_stories.js`: - - [x] Added component's PascalCase name to `disableForComponents`. - -More details about the migration can be found in the epic: https://gitlab.com/groups/gitlab-org/-/epics/5651",2 -81191891,2021-03-18 14:15:30.539,Migrate charts/chart stories to Component Story Format,"Migrate `charts/chart` stories to the [Component Story Format (CSF)](https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format). - -Follow the steps described in the epic: https://gitlab.com/groups/gitlab-org/-/epics/5651",2 -81191895,2021-03-18 14:15:30.532,Migrate base/datepicker stories to Component Story Format," -Migrate `base/datepicker` stories to the [Component Story Format (CSF)](https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format). - -- [ ] Migrated `documentedStoriesOf` usages to the Component Story Format. -- [ ] Migrated or removed examples. -- [ ] Migrated props, slots and events documentation. - - [ ] If needed, migrated the `bootstrapComponent` parameter. -- [ ] Cleanup - - [ ] Component's README: - - [ ] Removed ``. - - [ ] Removed component's title. - - [ ] `documentation/documented_stories.js`: - - [ ] Added component's PascalCase name to `disableForComponents`. - -More details about the migration can be found in the epic: https://gitlab.com/groups/gitlab-org/-/epics/5651",2 -81191528,2021-03-18 14:12:04.577,Migrate regions/dashboard_skeleton stories to Component Story Format,"Migrate `regions/dashboard_skeleton` stories to the [Component Story Format (CSF)](https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format). - -Follow the steps described in the epic: https://gitlab.com/groups/gitlab-org/-/epics/5651",2 -81190918,2021-03-18 14:07:21.943,Migrate base/alert stories to Component Story Format,"Migrate `base/alert` stories to the [Component Story Format (CSF)](https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format). - -Follow the steps described in the epic: https://gitlab.com/groups/gitlab-org/-/epics/5651",2 -80701091,2021-03-11 09:21:01.974,Form: Add GlFormInvalidFeedback Component,"https://bootstrap-vue.org/docs/components/input-group#input-groups - -> Bootstrap v4 currently does not support contextual state styling (i.e. valid or invalid) of input groups. However, the inputs inside the input group do support contextual state. - -So we end up having something like this: - -| GlFormInputGroup | Other form input (for comparison) | -| ------ | ------ | -| ![image](/uploads/bcdb3fc58f1035783d068a8445441630/image.png) | ![image](/uploads/75598818f3a41b3e7cc5fc62a93d8f6f/image.png) | - -## Problem: No feedback message shown - -We use the general sibling selector `~` to display the invalid feedback message, like this: - - - -However, this doesn't work for `GlFormInputGroup` because the HTML structure is different. So the general sibling selector doesn't work here. - - - -## Proposal - -Let's ensure the feedback is displayed, so it looks like this: - -![image](/uploads/4aef69bf97cb323d0b220a7338bb7fe1/image.png) - -## Solution - -Alternatively, we can just use the `b-form-invalid-feedback` > https://bootstrap-vue.org/docs/components/form#comp-ref-b-form-invalid-feedback - -It was suggested here > https://github.com/bootstrap-vue/bootstrap-vue/issues/1251#issuecomment-340065341 - -(So instead of doing some funky css magic, I think this is the best route to take. I've tested it locally and it works perfectly 👍) - -## Follow-up - -~~1. We might also want to consider look into changing the default message if it's a `