type
stringclasses 14
values | public
bool 1
class | payload
stringlengths 2
363k
| repo
dict | actor
dict | org
dict | created_at
timestamp[us] | id
stringlengths 10
10
| other
stringlengths 31
69
|
|---|---|---|---|---|---|---|---|---|
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/percona/percona-server/pulls/comments/174672248","pull_request_review_id":104069693,"id":174672248,"diff_hunk":"@@ -23,25 +23,713 @@ Copyright (c) 2006, 2015, Percona and/or its affiliates. All rights reserved.\n \n #ident \"Copyright (c) 2006, 2015, Percona and/or its affiliates. All rights reserved.\"\n \n-#if TOKU_INCLUDE_ALTER_56\n-\n-#if 100000 <= MYSQL_VERSION_ID && MYSQL_VERSION_ID <= 100099\n-#define TOKU_ALTER_RENAME ALTER_RENAME\n-#elif (50600 <= MYSQL_VERSION_ID && MYSQL_VERSION_ID <= 50699) || \\\n- (50700 <= MYSQL_VERSION_ID && MYSQL_VERSION_ID <= 50799)\n #define TOKU_ALTER_RENAME ALTER_RENAME\n-#elif 50500 <= MYSQL_VERSION_ID && MYSQL_VERSION_ID <= 50599\n-#define TOKU_ALTER_RENAME ALTER_RENAME_56\n-#else\n-#error\n-#endif\n \n-#include \"ha_tokudb_alter_common.cc\"\n #include <sql_array.h>\n #include <sql_base.h>\n \n #include <vector>\n \n+TOKUDB_UNUSED(static bool tables_have_same_keys(TABLE* table,\n+ TABLE* altered_table,\n+ bool print_error,\n+ bool check_field_index));\n+\n+static bool tables_have_same_keys(TABLE* table,\n+ TABLE* altered_table,\n+ bool print_error,\n+ bool check_field_index) {\n+ bool retval;\n+ if (table->s->keys != altered_table->s->keys) {\n+ if (print_error) {\n+ sql_print_error(\"tables have different number of keys\");\n+ }\n+ retval = false;\n+ goto cleanup;\n+ }\n+ if (table->s->primary_key != altered_table->s->primary_key) {\n+ if (print_error) {\n+ sql_print_error(\"Tables have different primary keys, %d %d\",\n+ table->s->primary_key,\n+ altered_table->s->primary_key);\n+ }\n+ retval = false;\n+ goto cleanup;\n+ }\n+ for (uint32_t i = 0; i < table->s->keys; i++) {\n+ KEY* curr_orig_key = &table->key_info[i];\n+ KEY* curr_altered_key = &altered_table->key_info[i];\n+ if (strcmp(curr_orig_key->name, curr_altered_key->name)) {\n+ if (print_error) {\n+ sql_print_error(\"key %d has different name, %s %s\",\n+ i,\n+ curr_orig_key->name,\n+ curr_altered_key->name);\n+ }\n+ retval = false;\n+ goto cleanup;\n+ }\n+ if (key_is_clustering(curr_orig_key) !=\n+ key_is_clustering(curr_altered_key)) {\n+ if (print_error) {\n+ sql_print_error(\n+ \"keys disagree on if they are clustering, %d, %d\",\n+ curr_orig_key->user_defined_key_parts,\n+ curr_altered_key->user_defined_key_parts);\n+ }\n+ retval = false;\n+ goto cleanup;\n+ }\n+ if (((curr_orig_key->flags & HA_NOSAME) == 0) !=\n+ ((curr_altered_key->flags & HA_NOSAME) == 0)) {\n+ if (print_error) {\n+ sql_print_error(\"keys disagree on if they are unique, %d, %d\",\n+ curr_orig_key->user_defined_key_parts,\n+ curr_altered_key->user_defined_key_parts);\n+ }\n+ retval = false;\n+ goto cleanup;\n+ }\n+ if (curr_orig_key->user_defined_key_parts !=\n+ curr_altered_key->user_defined_key_parts) {\n+ if (print_error) {\n+ sql_print_error(\"keys have different number of parts, %d, %d\",\n+ curr_orig_key->user_defined_key_parts,\n+ curr_altered_key->user_defined_key_parts);\n+ }\n+ retval = false;\n+ goto cleanup;\n+ }\n+ //\n+ // now verify that each field in the key is the same\n+ //\n+ for (uint32_t j = 0; j < curr_orig_key->user_defined_key_parts; j++) {\n+ KEY_PART_INFO* curr_orig_part = &curr_orig_key->key_part[j];\n+ KEY_PART_INFO* curr_altered_part = &curr_altered_key->key_part[j];\n+ Field* curr_orig_field = curr_orig_part->field;\n+ Field* curr_altered_field = curr_altered_part->field;\n+ if (curr_orig_part->length != curr_altered_part->length) {\n+ if (print_error) {\n+ sql_print_error(\"Key %s has different length at index %d\",\n+ curr_orig_key->name,\n+ j);\n+ }\n+ retval = false;\n+ goto cleanup;\n+ }\n+ bool are_fields_same;\n+ are_fields_same =\n+ (check_field_index)\n+ ? (curr_orig_part->fieldnr == curr_altered_part->fieldnr &&\n+ fields_are_same_type(curr_orig_field,\n+ curr_altered_field))\n+ : (are_two_fields_same(curr_orig_field,\n+ curr_altered_field));\n+\n+ if (!are_fields_same) {\n+ if (print_error) {\n+ sql_print_error(\"Key %s has different field at index %d\",\n+ curr_orig_key->name,\n+ j);\n+ }\n+ retval = false;\n+ goto cleanup;\n+ }\n+ }\n+ }\n+\n+ retval = true;\n+cleanup:\n+ return retval;\n+}\n+\n+// MySQL sets the null_bit as a number that you can bit-wise AND a byte to\n+// to evaluate whether a field is NULL or not. This value is a power of 2, from\n+// 2^0 to 2^7. We return the position of the bit within the byte, which is\n+// lg null_bit\n+TOKUDB_UNUSED(static inline uint32_t get_null_bit_position(uint32_t null_bit));\n+static inline uint32_t get_null_bit_position(uint32_t null_bit) {\n+ uint32_t retval = 0;\n+ switch (null_bit) {\n+ case (1):\n+ retval = 0;\n+ break;\n+ case (2):\n+ retval = 1;\n+ break;\n+ case (4):\n+ retval = 2;\n+ break;\n+ case (8):\n+ retval = 3;\n+ break;\n+ case (16):\n+ retval = 4;\n+ break;\n+ case (32):\n+ retval = 5;\n+ break;\n+ case (64):\n+ retval = 6;\n+ break;\n+ case (128):\n+ retval = 7;\n+ break;\n+ default:\n+ assert_unreachable();\n+ }\n+ return retval;\n+}\n+\n+// returns the index of the null bit of field.\n+TOKUDB_UNUSED(\n+ static inline uint32_t get_overall_null_bit_position(TABLE* table,\n+ Field* field));\n+static inline uint32_t get_overall_null_bit_position(TABLE* table,\n+ Field* field) {\n+ uint32_t offset = get_null_offset(table, field);\n+ uint32_t null_bit = field->null_bit;\n+ return offset * 8 + get_null_bit_position(null_bit);\n+}\n+\n+// not static since 51 uses this and 56 does not\n+TOKUDB_UNUSED(static bool are_null_bits_in_order(TABLE* table));\n+static bool are_null_bits_in_order(TABLE* table) {\n+ uint32_t curr_null_pos = 0;\n+ bool first = true;\n+ bool retval = true;\n+ for (uint i = 0; i < table->s->fields; i++) {\n+ Field* curr_field = table->field[i];\n+ bool nullable = (curr_field->null_bit != 0);\n+ if (nullable) {\n+ uint32_t pos = get_overall_null_bit_position(table, curr_field);\n+ if (!first && pos != curr_null_pos + 1) {\n+ retval = false;\n+ break;\n+ }\n+ first = false;\n+ curr_null_pos = pos;\n+ }\n+ }\n+ return retval;\n+}\n+\n+TOKUDB_UNUSED(static uint32_t get_first_null_bit_pos(TABLE* table));\n+static uint32_t get_first_null_bit_pos(TABLE* table) {\n+ uint32_t table_pos = 0;\n+ for (uint i = 0; i < table->s->fields; i++) {\n+ Field* curr_field = table->field[i];\n+ bool nullable = (curr_field->null_bit != 0);\n+ if (nullable) {\n+ table_pos = get_overall_null_bit_position(table, curr_field);\n+ break;\n+ }\n+ }\n+ return table_pos;\n+}\n+\n+TOKUDB_UNUSED(static bool is_column_default_null(TABLE* src_table,\n+ uint32_t field_index));\n+static bool is_column_default_null(TABLE* src_table, uint32_t field_index) {\n+ Field* curr_field = src_table->field[field_index];\n+ bool is_null_default = false;\n+ bool nullable = curr_field->null_bit != 0;\n+ if (nullable) {\n+ uint32_t null_bit_position =\n+ get_overall_null_bit_position(src_table, curr_field);\n+ is_null_default = is_overall_null_position_set(\n+ src_table->s->default_values, null_bit_position);\n+ }\n+ return is_null_default;\n+}\n+\n+static uint32_t fill_static_row_mutator(uchar* buf,\n+ TABLE* orig_table,\n+ TABLE* altered_table,\n+ KEY_AND_COL_INFO* orig_kc_info,\n+ KEY_AND_COL_INFO* altered_kc_info,\n+ uint32_t keynr) {\n+ //\n+ // start packing extra\n+ //\n+ uchar* pos = buf;\n+ // says what the operation is\n+ pos[0] = UP_COL_ADD_OR_DROP;\n+ pos++;\n+\n+ //\n+ // null byte information\n+ //\n+ memcpy(pos, &orig_table->s->null_bytes, sizeof(orig_table->s->null_bytes));\n+ pos += sizeof(orig_table->s->null_bytes);\n+ memcpy(\n+ pos, &altered_table->s->null_bytes, sizeof(orig_table->s->null_bytes));\n+ pos += sizeof(altered_table->s->null_bytes);\n+\n+ //\n+ // num_offset_bytes\n+ //\n+ assert_always(orig_kc_info->num_offset_bytes <= 2);\n+ pos[0] = orig_kc_info->num_offset_bytes;\n+ pos++;\n+ assert_always(altered_kc_info->num_offset_bytes <= 2);\n+ pos[0] = altered_kc_info->num_offset_bytes;\n+ pos++;\n+\n+ //\n+ // size of fixed fields\n+ //\n+ uint32_t fixed_field_size = orig_kc_info->mcp_info[keynr].fixed_field_size;\n+ memcpy(pos, &fixed_field_size, sizeof(fixed_field_size));\n+ pos += sizeof(fixed_field_size);\n+ fixed_field_size = altered_kc_info->mcp_info[keynr].fixed_field_size;\n+ memcpy(pos, &fixed_field_size, sizeof(fixed_field_size));\n+ pos += sizeof(fixed_field_size);\n+\n+ //\n+ // length of offsets\n+ //\n+ uint32_t len_of_offsets = orig_kc_info->mcp_info[keynr].len_of_offsets;\n+ memcpy(pos, &len_of_offsets, sizeof(len_of_offsets));\n+ pos += sizeof(len_of_offsets);\n+ len_of_offsets = altered_kc_info->mcp_info[keynr].len_of_offsets;\n+ memcpy(pos, &len_of_offsets, sizeof(len_of_offsets));\n+ pos += sizeof(len_of_offsets);\n+\n+ uint32_t orig_start_null_pos = get_first_null_bit_pos(orig_table);\n+ memcpy(pos, &orig_start_null_pos, sizeof(orig_start_null_pos));\n+ pos += sizeof(orig_start_null_pos);\n+ uint32_t altered_start_null_pos = get_first_null_bit_pos(altered_table);\n+ memcpy(pos, &altered_start_null_pos, sizeof(altered_start_null_pos));\n+ pos += sizeof(altered_start_null_pos);\n+\n+ assert_always((pos - buf) == STATIC_ROW_MUTATOR_SIZE);\n+ return pos - buf;\n+}\n+\n+static uint32_t fill_dynamic_row_mutator(uchar* buf,\n+ uint32_t* columns,\n+ uint32_t num_columns,\n+ TABLE* src_table,\n+ KEY_AND_COL_INFO* src_kc_info,\n+ uint32_t keynr,\n+ bool is_add,\n+ bool* out_has_blobs) {\n+ uchar* pos = buf;\n+ bool has_blobs = false;\n+ uint32_t cols = num_columns;\n+ memcpy(pos, &cols, sizeof(cols));\n+ pos += sizeof(cols);\n+ for (uint32_t i = 0; i < num_columns; i++) {\n+ uint32_t curr_index = columns[i];\n+ Field* curr_field = src_table->field[curr_index];\n+\n+ pos[0] = is_add ? COL_ADD : COL_DROP;\n+ pos++;\n+ //\n+ // NULL bit information\n+ //\n+ bool is_null_default = false;\n+ bool nullable = curr_field->null_bit != 0;\n+ if (!nullable) {\n+ pos[0] = 0;\n+ pos++;\n+ } else {\n+ pos[0] = 1;\n+ pos++;\n+ // write position of null byte that is to be removed\n+ uint32_t null_bit_position =\n+ get_overall_null_bit_position(src_table, curr_field);\n+ memcpy(pos, &null_bit_position, sizeof(null_bit_position));\n+ pos += sizeof(null_bit_position);\n+ //\n+ // if adding a column, write the value of the default null_bit\n+ //\n+ if (is_add) {\n+ is_null_default = is_overall_null_position_set(\n+ src_table->s->default_values, null_bit_position);\n+ pos[0] = is_null_default ? 1 : 0;\n+ pos++;\n+ }\n+ }\n+ if (is_fixed_field(src_kc_info, curr_index)) {\n+ // we have a fixed field being dropped\n+ // store the offset and the number of bytes\n+ pos[0] = COL_FIXED;\n+ pos++;\n+ // store the offset\n+ uint32_t fixed_field_offset =\n+ src_kc_info->cp_info[keynr][curr_index].col_pack_val;\n+ memcpy(pos, &fixed_field_offset, sizeof(fixed_field_offset));\n+ pos += sizeof(fixed_field_offset);\n+ // store the number of bytes\n+ uint32_t num_bytes = src_kc_info->field_lengths[curr_index];\n+ memcpy(pos, &num_bytes, sizeof(num_bytes));\n+ pos += sizeof(num_bytes);\n+ if (is_add && !is_null_default) {\n+ uint curr_field_offset = field_offset(curr_field, src_table);\n+ memcpy(pos,\n+ src_table->s->default_values + curr_field_offset,\n+ num_bytes);\n+ pos += num_bytes;\n+ }\n+ } else if (is_variable_field(src_kc_info, curr_index)) {\n+ pos[0] = COL_VAR;\n+ pos++;\n+ // store the index of the variable column\n+ uint32_t var_field_index =\n+ src_kc_info->cp_info[keynr][curr_index].col_pack_val;\n+ memcpy(pos, &var_field_index, sizeof(var_field_index));\n+ pos += sizeof(var_field_index);\n+ if (is_add && !is_null_default) {\n+ uint curr_field_offset = field_offset(curr_field, src_table);\n+ uint32_t len_bytes = src_kc_info->length_bytes[curr_index];\n+ uint32_t data_length = get_var_data_length(\n+ src_table->s->default_values + curr_field_offset,\n+ len_bytes);\n+ memcpy(pos, &data_length, sizeof(data_length));\n+ pos += sizeof(data_length);\n+ memcpy(pos,\n+ src_table->s->default_values + curr_field_offset +\n+ len_bytes,\n+ data_length);\n+ pos += data_length;\n+ }\n+ } else {\n+ pos[0] = COL_BLOB;\n+ pos++;\n+ has_blobs = true;\n+ }\n+ }\n+ *out_has_blobs = has_blobs;\n+ return pos - buf;\n+}\n+\n+static uint32_t fill_static_blob_row_mutator(uchar* buf,\n+ TABLE* src_table,\n+ KEY_AND_COL_INFO* src_kc_info) {\n+ uchar* pos = buf;\n+ // copy number of blobs\n+ memcpy(pos, &src_kc_info->num_blobs, sizeof(src_kc_info->num_blobs));\n+ pos += sizeof(src_kc_info->num_blobs);\n+ // copy length bytes for each blob\n+ for (uint32_t i = 0; i < src_kc_info->num_blobs; i++) {\n+ uint32_t curr_field_index = src_kc_info->blob_fields[i];\n+ Field* field = src_table->field[curr_field_index];\n+ uint32_t len_bytes = field->row_pack_length();\n+ assert_always(len_bytes <= 4);\n+ pos[0] = len_bytes;\n+ pos++;\n+ }\n+\n+ return pos - buf;\n+}\n+\n+static uint32_t fill_dynamic_blob_row_mutator(uchar* buf,\n+ uint32_t* columns,\n+ uint32_t num_columns,\n+ TABLE* src_table,\n+ KEY_AND_COL_INFO* src_kc_info,\n+ bool is_add) {\n+ uchar* pos = buf;\n+ for (uint32_t i = 0; i < num_columns; i++) {\n+ uint32_t curr_field_index = columns[i];\n+ Field* curr_field = src_table->field[curr_field_index];\n+ if (is_blob_field(src_kc_info, curr_field_index)) {\n+ // find out which blob it is\n+ uint32_t blob_index = src_kc_info->num_blobs;\n+ for (uint32_t j = 0; j < src_kc_info->num_blobs; j++) {\n+ if (curr_field_index == src_kc_info->blob_fields[j]) {\n+ blob_index = j;\n+ break;\n+ }\n+ }\n+ // assert we found blob in list\n+ assert_always(blob_index < src_kc_info->num_blobs);\n+ pos[0] = is_add ? COL_ADD : COL_DROP;\n+ pos++;\n+ memcpy(pos, &blob_index, sizeof(blob_index));\n+ pos += sizeof(blob_index);\n+ if (is_add) {\n+ uint32_t len_bytes = curr_field->row_pack_length();\n+ assert_always(len_bytes <= 4);\n+ pos[0] = len_bytes;\n+ pos++;\n+\n+ // create a zero length blob field that can be directly copied\n+ // in for now, in MySQL, we can only have blob fields\n+ // that have no default value\n+ memset(pos, 0, len_bytes);\n+ pos += len_bytes;\n+ }\n+ }\n+ }\n+ return pos - buf;\n+}\n+\n+// TODO: carefully review to make sure that the right information is used\n+// TODO: namely, when do we get stuff from share->kc_info and when we get\n+// TODO: it from altered_kc_info, and when is keynr associated with the right\n+// thing\n+uint32_t ha_tokudb::fill_row_mutator(uchar* buf,\n+ uint32_t* columns,\n+ uint32_t num_columns,\n+ TABLE* altered_table,\n+ KEY_AND_COL_INFO* altered_kc_info,\n+ uint32_t keynr,\n+ bool is_add) {\n+ if (TOKUDB_UNLIKELY(TOKUDB_DEBUG_FLAGS(TOKUDB_DEBUG_ALTER_TABLE))) {\n+ TOKUDB_HANDLER_TRACE(\"*****some info:*************\");\n+ TOKUDB_HANDLER_TRACE(\n+ \"old things: num_null_bytes %d, num_offset_bytes %d, \"\n+ \"fixed_field_size %d, fixed_field_size %d\",\n+ table->s->null_bytes,\n+ share->kc_info.num_offset_bytes,\n+ share->kc_info.mcp_info[keynr].fixed_field_size,\n+ share->kc_info.mcp_info[keynr].len_of_offsets);\n+ TOKUDB_HANDLER_TRACE(\n+ \"new things: num_null_bytes %d, num_offset_bytes %d, \"\n+ \"fixed_field_size %d, fixed_field_size %d\",\n+ altered_table->s->null_bytes,\n+ altered_kc_info->num_offset_bytes,\n+ altered_kc_info->mcp_info[keynr].fixed_field_size,\n+ altered_kc_info->mcp_info[keynr].len_of_offsets);\n+ TOKUDB_HANDLER_TRACE(\"****************************\");\n+ }\n+ uchar* pos = buf;\n+ bool has_blobs = false;\n+ pos += fill_static_row_mutator(\n+ pos, table, altered_table, &share->kc_info, altered_kc_info, keynr);\n+\n+ if (is_add) {\n+ pos += fill_dynamic_row_mutator(pos,\n+ columns,\n+ num_columns,\n+ altered_table,\n+ altered_kc_info,\n+ keynr,\n+ is_add,\n+ &has_blobs);\n+ } else {\n+ pos += fill_dynamic_row_mutator(pos,\n+ columns,\n+ num_columns,\n+ table,\n+ &share->kc_info,\n+ keynr,\n+ is_add,\n+ &has_blobs);\n+ }\n+ if (has_blobs) {\n+ pos += fill_static_blob_row_mutator(pos, table, &share->kc_info);\n+ if (is_add) {\n+ pos += fill_dynamic_blob_row_mutator(pos,\n+ columns,\n+ num_columns,\n+ altered_table,\n+ altered_kc_info,\n+ is_add);\n+ } else {\n+ pos += fill_dynamic_blob_row_mutator(\n+ pos, columns, num_columns, table, &share->kc_info, is_add);\n+ }\n+ }\n+ return pos - buf;\n+}\n+\n+static bool all_fields_are_same_type(TABLE* table_a, TABLE* table_b) {\n+ if (table_a->s->fields != table_b->s->fields)\n+ return false;\n+ for (uint i = 0; i < table_a->s->fields; i++) {\n+ Field* field_a = table_a->field[i];\n+ Field* field_b = table_b->field[i];\n+ if (!fields_are_same_type(field_a, field_b))\n+ return false;\n+ }\n+ return true;\n+}\n+\n+TOKUDB_UNUSED(static bool column_rename_supported(TABLE* orig_table,","path":"storage/tokudb/ha_tokudb_alter.cc","position":542,"original_position":542,"commit_id":"a6065a0b5286a947e6068812a393d275044d9f87","original_commit_id":"a6065a0b5286a947e6068812a393d275044d9f87","user":{"login":"laurynas-biveinis","id":58894,"avatar_url":"https://avatars3.githubusercontent.com/u/58894?v=4","gravatar_id":"","url":"https://api.github.com/users/laurynas-biveinis","html_url":"https://github.com/laurynas-biveinis","followers_url":"https://api.github.com/users/laurynas-biveinis/followers","following_url":"https://api.github.com/users/laurynas-biveinis/following{/other_user}","gists_url":"https://api.github.com/users/laurynas-biveinis/gists{/gist_id}","starred_url":"https://api.github.com/users/laurynas-biveinis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laurynas-biveinis/subscriptions","organizations_url":"https://api.github.com/users/laurynas-biveinis/orgs","repos_url":"https://api.github.com/users/laurynas-biveinis/repos","events_url":"https://api.github.com/users/laurynas-biveinis/events{/privacy}","received_events_url":"https://api.github.com/users/laurynas-biveinis/received_events","type":"User","site_admin":false},"body":"Likewise","created_at":"2018-03-15T04:05:42Z","updated_at":"2018-03-15T04:13:53Z","html_url":"https://github.com/percona/percona-server/pull/2231#discussion_r174672248","pull_request_url":"https://api.github.com/repos/percona/percona-server/pulls/2231","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/percona/percona-server/pulls/comments/174672248"},"html":{"href":"https://github.com/percona/percona-server/pull/2231#discussion_r174672248"},"pull_request":{"href":"https://api.github.com/repos/percona/percona-server/pulls/2231"}}},"pull_request":{"url":"https://api.github.com/repos/percona/percona-server/pulls/2231","id":175081517,"html_url":"https://github.com/percona/percona-server/pull/2231","diff_url":"https://github.com/percona/percona-server/pull/2231.diff","patch_url":"https://github.com/percona/percona-server/pull/2231.patch","issue_url":"https://api.github.com/repos/percona/percona-server/issues/2231","number":2231,"state":"open","locked":false,"title":"Ps 5.7 tdb 129","user":{"login":"georgelorchpercona","id":5247783,"avatar_url":"https://avatars2.githubusercontent.com/u/5247783?v=4","gravatar_id":"","url":"https://api.github.com/users/georgelorchpercona","html_url":"https://github.com/georgelorchpercona","followers_url":"https://api.github.com/users/georgelorchpercona/followers","following_url":"https://api.github.com/users/georgelorchpercona/following{/other_user}","gists_url":"https://api.github.com/users/georgelorchpercona/gists{/gist_id}","starred_url":"https://api.github.com/users/georgelorchpercona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgelorchpercona/subscriptions","organizations_url":"https://api.github.com/users/georgelorchpercona/orgs","repos_url":"https://api.github.com/users/georgelorchpercona/repos","events_url":"https://api.github.com/users/georgelorchpercona/events{/privacy}","received_events_url":"https://api.github.com/users/georgelorchpercona/received_events","type":"User","site_admin":false},"body":"TDB-134 : TokuDB 5.7 is missing minor optimization for read-only transactions.\r\nTDB-135 : TokuDB 5.7 missing mrr implementation as it seems compiled out of 5.7\r\nTDB-129 : Normalize TokuDB ALTER code to remove 5.5 and version dependent compilation\r\nTDB-129 : 'Fix' tokub conditional compilation dependent on version id starting in 5.7","created_at":"2018-03-14T20:52:17Z","updated_at":"2018-03-15T04:13:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"357efa7f1b6f6c8acbffb9763b12b4dc57741896","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/percona/percona-server/pulls/2231/commits","review_comments_url":"https://api.github.com/repos/percona/percona-server/pulls/2231/comments","review_comment_url":"https://api.github.com/repos/percona/percona-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/percona/percona-server/issues/2231/comments","statuses_url":"https://api.github.com/repos/percona/percona-server/statuses/a6065a0b5286a947e6068812a393d275044d9f87","head":{"label":"georgelorchpercona:ps-5.7-TDB-129","ref":"ps-5.7-TDB-129","sha":"a6065a0b5286a947e6068812a393d275044d9f87","user":{"login":"georgelorchpercona","id":5247783,"avatar_url":"https://avatars2.githubusercontent.com/u/5247783?v=4","gravatar_id":"","url":"https://api.github.com/users/georgelorchpercona","html_url":"https://github.com/georgelorchpercona","followers_url":"https://api.github.com/users/georgelorchpercona/followers","following_url":"https://api.github.com/users/georgelorchpercona/following{/other_user}","gists_url":"https://api.github.com/users/georgelorchpercona/gists{/gist_id}","starred_url":"https://api.github.com/users/georgelorchpercona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgelorchpercona/subscriptions","organizations_url":"https://api.github.com/users/georgelorchpercona/orgs","repos_url":"https://api.github.com/users/georgelorchpercona/repos","events_url":"https://api.github.com/users/georgelorchpercona/events{/privacy}","received_events_url":"https://api.github.com/users/georgelorchpercona/received_events","type":"User","site_admin":false},"repo":{"id":32110095,"name":"percona-server","full_name":"georgelorchpercona/percona-server","owner":{"login":"georgelorchpercona","id":5247783,"avatar_url":"https://avatars2.githubusercontent.com/u/5247783?v=4","gravatar_id":"","url":"https://api.github.com/users/georgelorchpercona","html_url":"https://github.com/georgelorchpercona","followers_url":"https://api.github.com/users/georgelorchpercona/followers","following_url":"https://api.github.com/users/georgelorchpercona/following{/other_user}","gists_url":"https://api.github.com/users/georgelorchpercona/gists{/gist_id}","starred_url":"https://api.github.com/users/georgelorchpercona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgelorchpercona/subscriptions","organizations_url":"https://api.github.com/users/georgelorchpercona/orgs","repos_url":"https://api.github.com/users/georgelorchpercona/repos","events_url":"https://api.github.com/users/georgelorchpercona/events{/privacy}","received_events_url":"https://api.github.com/users/georgelorchpercona/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/georgelorchpercona/percona-server","description":null,"fork":true,"url":"https://api.github.com/repos/georgelorchpercona/percona-server","forks_url":"https://api.github.com/repos/georgelorchpercona/percona-server/forks","keys_url":"https://api.github.com/repos/georgelorchpercona/percona-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/georgelorchpercona/percona-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/georgelorchpercona/percona-server/teams","hooks_url":"https://api.github.com/repos/georgelorchpercona/percona-server/hooks","issue_events_url":"https://api.github.com/repos/georgelorchpercona/percona-server/issues/events{/number}","events_url":"https://api.github.com/repos/georgelorchpercona/percona-server/events","assignees_url":"https://api.github.com/repos/georgelorchpercona/percona-server/assignees{/user}","branches_url":"https://api.github.com/repos/georgelorchpercona/percona-server/branches{/branch}","tags_url":"https://api.github.com/repos/georgelorchpercona/percona-server/tags","blobs_url":"https://api.github.com/repos/georgelorchpercona/percona-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/georgelorchpercona/percona-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/georgelorchpercona/percona-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/georgelorchpercona/percona-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/georgelorchpercona/percona-server/statuses/{sha}","languages_url":"https://api.github.com/repos/georgelorchpercona/percona-server/languages","stargazers_url":"https://api.github.com/repos/georgelorchpercona/percona-server/stargazers","contributors_url":"https://api.github.com/repos/georgelorchpercona/percona-server/contributors","subscribers_url":"https://api.github.com/repos/georgelorchpercona/percona-server/subscribers","subscription_url":"https://api.github.com/repos/georgelorchpercona/percona-server/subscription","commits_url":"https://api.github.com/repos/georgelorchpercona/percona-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/georgelorchpercona/percona-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/georgelorchpercona/percona-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/georgelorchpercona/percona-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/georgelorchpercona/percona-server/contents/{+path}","compare_url":"https://api.github.com/repos/georgelorchpercona/percona-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/georgelorchpercona/percona-server/merges","archive_url":"https://api.github.com/repos/georgelorchpercona/percona-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/georgelorchpercona/percona-server/downloads","issues_url":"https://api.github.com/repos/georgelorchpercona/percona-server/issues{/number}","pulls_url":"https://api.github.com/repos/georgelorchpercona/percona-server/pulls{/number}","milestones_url":"https://api.github.com/repos/georgelorchpercona/percona-server/milestones{/number}","notifications_url":"https://api.github.com/repos/georgelorchpercona/percona-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/georgelorchpercona/percona-server/labels{/name}","releases_url":"https://api.github.com/repos/georgelorchpercona/percona-server/releases{/id}","deployments_url":"https://api.github.com/repos/georgelorchpercona/percona-server/deployments","created_at":"2015-03-12T23:58:07Z","updated_at":"2017-03-06T16:05:12Z","pushed_at":"2018-03-15T01:05:21Z","git_url":"git://github.com/georgelorchpercona/percona-server.git","ssh_url":"[email protected]:georgelorchpercona/percona-server.git","clone_url":"https://github.com/georgelorchpercona/percona-server.git","svn_url":"https://github.com/georgelorchpercona/percona-server","homepage":null,"size":584382,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1,"open_issues":0,"watchers":0,"default_branch":"5.7"}},"base":{"label":"percona:5.7","ref":"5.7","sha":"5ad34027f29334098f27e66b73cf19a6ccd5925b","user":{"login":"percona","id":1683025,"avatar_url":"https://avatars0.githubusercontent.com/u/1683025?v=4","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"repo":{"id":30753733,"name":"percona-server","full_name":"percona/percona-server","owner":{"login":"percona","id":1683025,"avatar_url":"https://avatars0.githubusercontent.com/u/1683025?v=4","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/percona/percona-server","description":"Percona Server","fork":false,"url":"https://api.github.com/repos/percona/percona-server","forks_url":"https://api.github.com/repos/percona/percona-server/forks","keys_url":"https://api.github.com/repos/percona/percona-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/percona/percona-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/percona/percona-server/teams","hooks_url":"https://api.github.com/repos/percona/percona-server/hooks","issue_events_url":"https://api.github.com/repos/percona/percona-server/issues/events{/number}","events_url":"https://api.github.com/repos/percona/percona-server/events","assignees_url":"https://api.github.com/repos/percona/percona-server/assignees{/user}","branches_url":"https://api.github.com/repos/percona/percona-server/branches{/branch}","tags_url":"https://api.github.com/repos/percona/percona-server/tags","blobs_url":"https://api.github.com/repos/percona/percona-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/percona/percona-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/percona/percona-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/percona/percona-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/percona/percona-server/statuses/{sha}","languages_url":"https://api.github.com/repos/percona/percona-server/languages","stargazers_url":"https://api.github.com/repos/percona/percona-server/stargazers","contributors_url":"https://api.github.com/repos/percona/percona-server/contributors","subscribers_url":"https://api.github.com/repos/percona/percona-server/subscribers","subscription_url":"https://api.github.com/repos/percona/percona-server/subscription","commits_url":"https://api.github.com/repos/percona/percona-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/percona/percona-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/percona/percona-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/percona/percona-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/percona/percona-server/contents/{+path}","compare_url":"https://api.github.com/repos/percona/percona-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/percona/percona-server/merges","archive_url":"https://api.github.com/repos/percona/percona-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/percona/percona-server/downloads","issues_url":"https://api.github.com/repos/percona/percona-server/issues{/number}","pulls_url":"https://api.github.com/repos/percona/percona-server/pulls{/number}","milestones_url":"https://api.github.com/repos/percona/percona-server/milestones{/number}","notifications_url":"https://api.github.com/repos/percona/percona-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/percona/percona-server/labels{/name}","releases_url":"https://api.github.com/repos/percona/percona-server/releases{/id}","deployments_url":"https://api.github.com/repos/percona/percona-server/deployments","created_at":"2015-02-13T11:32:01Z","updated_at":"2018-03-14T21:22:37Z","pushed_at":"2018-03-15T01:40:58Z","git_url":"git://github.com/percona/percona-server.git","ssh_url":"[email protected]:percona/percona-server.git","clone_url":"https://github.com/percona/percona-server.git","svn_url":"https://github.com/percona/percona-server","homepage":"https://www.percona.com/software/mysql-database/percona-server","size":584650,"stargazers_count":409,"watchers_count":409,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":172,"mirror_url":null,"archived":false,"open_issues_count":39,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":172,"open_issues":39,"watchers":409,"default_branch":"5.7"}},"_links":{"self":{"href":"https://api.github.com/repos/percona/percona-server/pulls/2231"},"html":{"href":"https://github.com/percona/percona-server/pull/2231"},"issue":{"href":"https://api.github.com/repos/percona/percona-server/issues/2231"},"comments":{"href":"https://api.github.com/repos/percona/percona-server/issues/2231/comments"},"review_comments":{"href":"https://api.github.com/repos/percona/percona-server/pulls/2231/comments"},"review_comment":{"href":"https://api.github.com/repos/percona/percona-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/percona/percona-server/pulls/2231/commits"},"statuses":{"href":"https://api.github.com/repos/percona/percona-server/statuses/a6065a0b5286a947e6068812a393d275044d9f87"}},"author_association":"CONTRIBUTOR"}} | {
"id": 30753733,
"name": "percona/percona-server",
"url": "https://api.github.com/repos/percona/percona-server"
} | {
"id": 58894,
"login": "laurynas-biveinis",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/58894?",
"url": "https://api.github.com/users/laurynas-biveinis"
} | {
"id": 1683025,
"login": "percona",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1683025?",
"url": "https://api.github.com/orgs/percona"
} | 2018-03-15T04:05:42 | 7382348257 | {"actor":{"display_login":"laurynas-biveinis"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/gitextensions/gitextensions/pulls/comments/197621963","pull_request_review_id":131405009,"id":197621963,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzYyMTk2Mw==","diff_hunk":"@@ -0,0 +1,91 @@\n+using System;\n+using System.Drawing;\n+using System.Windows.Forms;\n+using System.Windows.Forms.VisualStyles;\n+\n+namespace DeleteUnusedBranches\n+{\n+ public delegate void CheckBoxClickedHandler(bool state);\n+\n+ public class DataGridViewCheckBoxHeaderCellEventArgs : EventArgs","path":"Plugins/DeleteUnusedBranches/DataGridViewCheckBoxHeaderCell.cs","position":null,"original_position":10,"commit_id":"a5c7b16bbad7a3de2968e0b891fe8295861baa35","original_commit_id":"b066a57429706927b17b9a08791551b11b5a05ab","user":{"login":"oriash93","id":14019835,"node_id":"MDQ6VXNlcjE0MDE5ODM1","avatar_url":"https://avatars0.githubusercontent.com/u/14019835?v=4","gravatar_id":"","url":"https://api.github.com/users/oriash93","html_url":"https://github.com/oriash93","followers_url":"https://api.github.com/users/oriash93/followers","following_url":"https://api.github.com/users/oriash93/following{/other_user}","gists_url":"https://api.github.com/users/oriash93/gists{/gist_id}","starred_url":"https://api.github.com/users/oriash93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oriash93/subscriptions","organizations_url":"https://api.github.com/users/oriash93/orgs","repos_url":"https://api.github.com/users/oriash93/repos","events_url":"https://api.github.com/users/oriash93/events{/privacy}","received_events_url":"https://api.github.com/users/oriash93/received_events","type":"User","site_admin":false},"body":"Done. Also renamed it to `CheckBoxHeaderCellEventArgs`","created_at":"2018-06-23T20:33:46Z","updated_at":"2018-06-23T20:33:46Z","html_url":"https://github.com/gitextensions/gitextensions/pull/5100#discussion_r197621963","pull_request_url":"https://api.github.com/repos/gitextensions/gitextensions/pulls/5100","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/gitextensions/gitextensions/pulls/comments/197621963"},"html":{"href":"https://github.com/gitextensions/gitextensions/pull/5100#discussion_r197621963"},"pull_request":{"href":"https://api.github.com/repos/gitextensions/gitextensions/pulls/5100"}},"in_reply_to_id":197610804},"pull_request":{"url":"https://api.github.com/repos/gitextensions/gitextensions/pulls/5100","id":196191658,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MTkxNjU4","html_url":"https://github.com/gitextensions/gitextensions/pull/5100","diff_url":"https://github.com/gitextensions/gitextensions/pull/5100.diff","patch_url":"https://github.com/gitextensions/gitextensions/pull/5100.patch","issue_url":"https://api.github.com/repos/gitextensions/gitextensions/issues/5100","number":5100,"state":"open","locked":false,"title":"Added \"Select All\" feature to Delete Unused Branches plugin","user":{"login":"oriash93","id":14019835,"node_id":"MDQ6VXNlcjE0MDE5ODM1","avatar_url":"https://avatars0.githubusercontent.com/u/14019835?v=4","gravatar_id":"","url":"https://api.github.com/users/oriash93","html_url":"https://github.com/oriash93","followers_url":"https://api.github.com/users/oriash93/followers","following_url":"https://api.github.com/users/oriash93/following{/other_user}","gists_url":"https://api.github.com/users/oriash93/gists{/gist_id}","starred_url":"https://api.github.com/users/oriash93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oriash93/subscriptions","organizations_url":"https://api.github.com/users/oriash93/orgs","repos_url":"https://api.github.com/users/oriash93/repos","events_url":"https://api.github.com/users/oriash93/events{/privacy}","received_events_url":"https://api.github.com/users/oriash93/received_events","type":"User","site_admin":false},"body":"<!-- Please read CONTRIBUTING.md before submitting a pull request -->\r\n\r\nFixes #3522\r\n\r\nChanges proposed in this pull request:\r\n- Added \"Select All\" feature to Delete Unused Branches plugin\r\n \r\nScreenshots before and after (if PR changes UI):\r\n- Before:\r\n\r\n\r\n- After:\r\n\r\n\r\n\r\nWhat did I do to test the code and ensure quality:\r\n- Pressed the button and made sure it selects all branches.\r\n\r\nHas been tested on (remove any that don't apply):\r\n- GIT 2.10 and above\r\n- Windows 10\r\n","created_at":"2018-06-20T16:00:25Z","updated_at":"2018-06-23T20:33:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a6d27da7bdfb60a952f41468cef7f17ebd5f79e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gitextensions/gitextensions/pulls/5100/commits","review_comments_url":"https://api.github.com/repos/gitextensions/gitextensions/pulls/5100/comments","review_comment_url":"https://api.github.com/repos/gitextensions/gitextensions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gitextensions/gitextensions/issues/5100/comments","statuses_url":"https://api.github.com/repos/gitextensions/gitextensions/statuses/a5c7b16bbad7a3de2968e0b891fe8295861baa35","head":{"label":"oriash93:oriash93/3522","ref":"oriash93/3522","sha":"a5c7b16bbad7a3de2968e0b891fe8295861baa35","user":{"login":"oriash93","id":14019835,"node_id":"MDQ6VXNlcjE0MDE5ODM1","avatar_url":"https://avatars0.githubusercontent.com/u/14019835?v=4","gravatar_id":"","url":"https://api.github.com/users/oriash93","html_url":"https://github.com/oriash93","followers_url":"https://api.github.com/users/oriash93/followers","following_url":"https://api.github.com/users/oriash93/following{/other_user}","gists_url":"https://api.github.com/users/oriash93/gists{/gist_id}","starred_url":"https://api.github.com/users/oriash93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oriash93/subscriptions","organizations_url":"https://api.github.com/users/oriash93/orgs","repos_url":"https://api.github.com/users/oriash93/repos","events_url":"https://api.github.com/users/oriash93/events{/privacy}","received_events_url":"https://api.github.com/users/oriash93/received_events","type":"User","site_admin":false},"repo":{"id":135933616,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU5MzM2MTY=","name":"gitextensions","full_name":"oriash93/gitextensions","owner":{"login":"oriash93","id":14019835,"node_id":"MDQ6VXNlcjE0MDE5ODM1","avatar_url":"https://avatars0.githubusercontent.com/u/14019835?v=4","gravatar_id":"","url":"https://api.github.com/users/oriash93","html_url":"https://github.com/oriash93","followers_url":"https://api.github.com/users/oriash93/followers","following_url":"https://api.github.com/users/oriash93/following{/other_user}","gists_url":"https://api.github.com/users/oriash93/gists{/gist_id}","starred_url":"https://api.github.com/users/oriash93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oriash93/subscriptions","organizations_url":"https://api.github.com/users/oriash93/orgs","repos_url":"https://api.github.com/users/oriash93/repos","events_url":"https://api.github.com/users/oriash93/events{/privacy}","received_events_url":"https://api.github.com/users/oriash93/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oriash93/gitextensions","description":"Git Extensions is a standalone UI tool for managing git repositories. It also integrates with Windows Explorer and Microsoft Visual Studio (2010/2012/2013/2015/2017).","fork":true,"url":"https://api.github.com/repos/oriash93/gitextensions","forks_url":"https://api.github.com/repos/oriash93/gitextensions/forks","keys_url":"https://api.github.com/repos/oriash93/gitextensions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oriash93/gitextensions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oriash93/gitextensions/teams","hooks_url":"https://api.github.com/repos/oriash93/gitextensions/hooks","issue_events_url":"https://api.github.com/repos/oriash93/gitextensions/issues/events{/number}","events_url":"https://api.github.com/repos/oriash93/gitextensions/events","assignees_url":"https://api.github.com/repos/oriash93/gitextensions/assignees{/user}","branches_url":"https://api.github.com/repos/oriash93/gitextensions/branches{/branch}","tags_url":"https://api.github.com/repos/oriash93/gitextensions/tags","blobs_url":"https://api.github.com/repos/oriash93/gitextensions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oriash93/gitextensions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oriash93/gitextensions/git/refs{/sha}","trees_url":"https://api.github.com/repos/oriash93/gitextensions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oriash93/gitextensions/statuses/{sha}","languages_url":"https://api.github.com/repos/oriash93/gitextensions/languages","stargazers_url":"https://api.github.com/repos/oriash93/gitextensions/stargazers","contributors_url":"https://api.github.com/repos/oriash93/gitextensions/contributors","subscribers_url":"https://api.github.com/repos/oriash93/gitextensions/subscribers","subscription_url":"https://api.github.com/repos/oriash93/gitextensions/subscription","commits_url":"https://api.github.com/repos/oriash93/gitextensions/commits{/sha}","git_commits_url":"https://api.github.com/repos/oriash93/gitextensions/git/commits{/sha}","comments_url":"https://api.github.com/repos/oriash93/gitextensions/comments{/number}","issue_comment_url":"https://api.github.com/repos/oriash93/gitextensions/issues/comments{/number}","contents_url":"https://api.github.com/repos/oriash93/gitextensions/contents/{+path}","compare_url":"https://api.github.com/repos/oriash93/gitextensions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oriash93/gitextensions/merges","archive_url":"https://api.github.com/repos/oriash93/gitextensions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oriash93/gitextensions/downloads","issues_url":"https://api.github.com/repos/oriash93/gitextensions/issues{/number}","pulls_url":"https://api.github.com/repos/oriash93/gitextensions/pulls{/number}","milestones_url":"https://api.github.com/repos/oriash93/gitextensions/milestones{/number}","notifications_url":"https://api.github.com/repos/oriash93/gitextensions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oriash93/gitextensions/labels{/name}","releases_url":"https://api.github.com/repos/oriash93/gitextensions/releases{/id}","deployments_url":"https://api.github.com/repos/oriash93/gitextensions/deployments","created_at":"2018-06-03T19:23:40Z","updated_at":"2018-06-18T16:18:29Z","pushed_at":"2018-06-23T20:32:07Z","git_url":"git://github.com/oriash93/gitextensions.git","ssh_url":"[email protected]:oriash93/gitextensions.git","clone_url":"https://github.com/oriash93/gitextensions.git","svn_url":"https://github.com/oriash93/gitextensions","homepage":"http://gitextensions.github.io/","size":75166,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gitextensions:master","ref":"master","sha":"be53c0671b26a8ccd194dd032dac9ad3bbbb3a4d","user":{"login":"gitextensions","id":1700077,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MDAwNzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1700077?v=4","gravatar_id":"","url":"https://api.github.com/users/gitextensions","html_url":"https://github.com/gitextensions","followers_url":"https://api.github.com/users/gitextensions/followers","following_url":"https://api.github.com/users/gitextensions/following{/other_user}","gists_url":"https://api.github.com/users/gitextensions/gists{/gist_id}","starred_url":"https://api.github.com/users/gitextensions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitextensions/subscriptions","organizations_url":"https://api.github.com/users/gitextensions/orgs","repos_url":"https://api.github.com/users/gitextensions/repos","events_url":"https://api.github.com/users/gitextensions/events{/privacy}","received_events_url":"https://api.github.com/users/gitextensions/received_events","type":"Organization","site_admin":false},"repo":{"id":85953,"node_id":"MDEwOlJlcG9zaXRvcnk4NTk1Mw==","name":"gitextensions","full_name":"gitextensions/gitextensions","owner":{"login":"gitextensions","id":1700077,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MDAwNzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1700077?v=4","gravatar_id":"","url":"https://api.github.com/users/gitextensions","html_url":"https://github.com/gitextensions","followers_url":"https://api.github.com/users/gitextensions/followers","following_url":"https://api.github.com/users/gitextensions/following{/other_user}","gists_url":"https://api.github.com/users/gitextensions/gists{/gist_id}","starred_url":"https://api.github.com/users/gitextensions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitextensions/subscriptions","organizations_url":"https://api.github.com/users/gitextensions/orgs","repos_url":"https://api.github.com/users/gitextensions/repos","events_url":"https://api.github.com/users/gitextensions/events{/privacy}","received_events_url":"https://api.github.com/users/gitextensions/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gitextensions/gitextensions","description":"Git Extensions is a standalone UI tool for managing git repositories. It also integrates with Windows Explorer and Microsoft Visual Studio (2010/2012/2013/2015/2017).","fork":false,"url":"https://api.github.com/repos/gitextensions/gitextensions","forks_url":"https://api.github.com/repos/gitextensions/gitextensions/forks","keys_url":"https://api.github.com/repos/gitextensions/gitextensions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gitextensions/gitextensions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gitextensions/gitextensions/teams","hooks_url":"https://api.github.com/repos/gitextensions/gitextensions/hooks","issue_events_url":"https://api.github.com/repos/gitextensions/gitextensions/issues/events{/number}","events_url":"https://api.github.com/repos/gitextensions/gitextensions/events","assignees_url":"https://api.github.com/repos/gitextensions/gitextensions/assignees{/user}","branches_url":"https://api.github.com/repos/gitextensions/gitextensions/branches{/branch}","tags_url":"https://api.github.com/repos/gitextensions/gitextensions/tags","blobs_url":"https://api.github.com/repos/gitextensions/gitextensions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gitextensions/gitextensions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gitextensions/gitextensions/git/refs{/sha}","trees_url":"https://api.github.com/repos/gitextensions/gitextensions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gitextensions/gitextensions/statuses/{sha}","languages_url":"https://api.github.com/repos/gitextensions/gitextensions/languages","stargazers_url":"https://api.github.com/repos/gitextensions/gitextensions/stargazers","contributors_url":"https://api.github.com/repos/gitextensions/gitextensions/contributors","subscribers_url":"https://api.github.com/repos/gitextensions/gitextensions/subscribers","subscription_url":"https://api.github.com/repos/gitextensions/gitextensions/subscription","commits_url":"https://api.github.com/repos/gitextensions/gitextensions/commits{/sha}","git_commits_url":"https://api.github.com/repos/gitextensions/gitextensions/git/commits{/sha}","comments_url":"https://api.github.com/repos/gitextensions/gitextensions/comments{/number}","issue_comment_url":"https://api.github.com/repos/gitextensions/gitextensions/issues/comments{/number}","contents_url":"https://api.github.com/repos/gitextensions/gitextensions/contents/{+path}","compare_url":"https://api.github.com/repos/gitextensions/gitextensions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gitextensions/gitextensions/merges","archive_url":"https://api.github.com/repos/gitextensions/gitextensions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gitextensions/gitextensions/downloads","issues_url":"https://api.github.com/repos/gitextensions/gitextensions/issues{/number}","pulls_url":"https://api.github.com/repos/gitextensions/gitextensions/pulls{/number}","milestones_url":"https://api.github.com/repos/gitextensions/gitextensions/milestones{/number}","notifications_url":"https://api.github.com/repos/gitextensions/gitextensions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gitextensions/gitextensions/labels{/name}","releases_url":"https://api.github.com/repos/gitextensions/gitextensions/releases{/id}","deployments_url":"https://api.github.com/repos/gitextensions/gitextensions/deployments","created_at":"2008-12-06T09:18:59Z","updated_at":"2018-06-23T17:45:45Z","pushed_at":"2018-06-23T20:32:08Z","git_url":"git://github.com/gitextensions/gitextensions.git","ssh_url":"[email protected]:gitextensions/gitextensions.git","clone_url":"https://github.com/gitextensions/gitextensions.git","svn_url":"https://github.com/gitextensions/gitextensions","homepage":"https://gitextensions.github.io/","size":75213,"stargazers_count":2883,"watchers_count":2883,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1024,"mirror_url":null,"archived":false,"open_issues_count":668,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1024,"open_issues":668,"watchers":2883,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gitextensions/gitextensions/pulls/5100"},"html":{"href":"https://github.com/gitextensions/gitextensions/pull/5100"},"issue":{"href":"https://api.github.com/repos/gitextensions/gitextensions/issues/5100"},"comments":{"href":"https://api.github.com/repos/gitextensions/gitextensions/issues/5100/comments"},"review_comments":{"href":"https://api.github.com/repos/gitextensions/gitextensions/pulls/5100/comments"},"review_comment":{"href":"https://api.github.com/repos/gitextensions/gitextensions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gitextensions/gitextensions/pulls/5100/commits"},"statuses":{"href":"https://api.github.com/repos/gitextensions/gitextensions/statuses/a5c7b16bbad7a3de2968e0b891fe8295861baa35"}},"author_association":"CONTRIBUTOR"}} | {
"id": 85953,
"name": "gitextensions/gitextensions",
"url": "https://api.github.com/repos/gitextensions/gitextensions"
} | {
"id": 14019835,
"login": "oriash93",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14019835?",
"url": "https://api.github.com/users/oriash93"
} | {
"id": 1700077,
"login": "gitextensions",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1700077?",
"url": "https://api.github.com/orgs/gitextensions"
} | 2018-06-23T20:33:46 | 7868350936 | {"actor":{"display_login":"oriash93"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/adessoAG/budgeteer/pulls/comments/197784402","pull_request_review_id":131593284,"id":197784402,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Nzc4NDQwMg==","diff_hunk":"@@ -1,163 +1,171 @@\n package org.wickedsource.budgeteer.importer.aproda;\n \n+import java.io.IOException;\n+import java.util.*;\n+\n import org.apache.poi.ss.usermodel.Cell;\n import org.apache.poi.ss.usermodel.Row;\n import org.apache.poi.ss.usermodel.Sheet;\n import org.apache.poi.ss.usermodel.Workbook;\n import org.apache.poi.xssf.usermodel.XSSFWorkbook;\n import org.wickedsource.budgeteer.imports.api.*;\n \n-import java.io.IOException;\n-import java.util.*;\n-\n public class AprodaWorkRecordsImporter implements WorkRecordsImporter {\n \n- private static int SHEET_INDEX = 2;\n-\n- private static int COLUMN_INVOICABLE = 8;\n-\n- private static int COLUMN_DATE = 1;\n-\n- private static int COLUMN_PERSON = 0;\n-\n- private static int COLUMN_BUDGET = 5;\n-\n- private static int COLUMN_HOURS = 7;\n-\n- private List<List<String>> skippedRecords = new LinkedList<List<String>>();\n-\n- @Override\n- public List<ImportedWorkRecord> importFile(ImportFile file) throws ImportException, InvalidFileFormatException {\n- return read(file);\n- }\n-\n- @Override\n- public String getDisplayName() {\n- return \"Aproda Working Hours Importer\";\n- }\n-\n- @Override\n- public List<String> getSupportedFileExtensions() {\n- return Arrays.asList(\".xlsx\");\n- }\n-\n- @Override\n- public ExampleFile getExampleFile() {\n- ExampleFile file = new ExampleFile();\n- file.setFileName(\"aproda_report.xlsx\");\n- file.setInputStream(getClass().getResourceAsStream(\"/example_aproda_report.xlsx\"));\n- file.setContentType(\"application/vnd.openxmlformats-officedocument.spreadsheetml.sheet\");\n- return file;\n- }\n-\n- @Override\n- public List<List<String>> getSkippedRecords() {\n- //if just an empty row at the beginning and the filename is in the List of skipped records, return an empty List\n- if(skippedRecords != null && skippedRecords.size() == 2){\n- skippedRecords = new LinkedList<List<String>>();\n- }\n- return skippedRecords;\n- }\n-\n- public List<ImportedWorkRecord> read(ImportFile file) throws ImportException, InvalidFileFormatException {\n- try {\n- skippedRecords.add(new LinkedList<String>());\n- //Adds the name of the imported file at the beginning of the list of skipped data sets..\n- List<String> fileName = new LinkedList<String>();\n- fileName.add(file.getFilename());\n- skippedRecords.add(fileName);\n-\n- List<ImportedWorkRecord> resultList = new ArrayList<ImportedWorkRecord>();\n- Workbook workbook = new XSSFWorkbook(file.getInputStream());\n- if(!checkValidity(workbook)){\n- throw new InvalidFileFormatException(\"Invalid file\", file.getFilename());\n- }\n- Sheet sheet = workbook.getSheetAt(SHEET_INDEX);\n- int i = 3;\n- Row row = sheet.getRow(i);\n- while (row != null && row.getCell(0).getStringCellValue() != null) {\n- if (isImportable(row)) {\n- ImportedWorkRecord record = parseRow(row, file);\n- resultList.add(record);\n- } else {\n- skippedRecords.add(getRowAsStrings(row, i));\n- }\n- i++;\n- row = sheet.getRow(i);\n- }\n- return resultList;\n- } catch (IOException e) {\n- throw new ImportException(e);\n- }\n- }\n-\n- private boolean checkValidity(Workbook workbook) {\n- boolean isValid = workbook.getNumberOfSheets() >= SHEET_INDEX ;\n- if(isValid){\n- Sheet sheet = workbook.getSheetAt(SHEET_INDEX);\n- if(sheet.getRow(2) == null){\n- isValid = false ;\n- } else {\n- Row r = sheet.getRow(2);\n- try {\n- isValid = r.getCell(COLUMN_PERSON).getStringCellValue().equals(\"Name\") &&\n- r.getCell(COLUMN_DATE).getStringCellValue().equals(\"Tag\") &&\n- r.getCell(COLUMN_BUDGET).getStringCellValue().equals(\"Subgruppe\") &&\n- r.getCell(COLUMN_HOURS).getStringCellValue().equals(\"Aufwand [h]\");\n- }catch (Exception e){\n- isValid = false;\n- }\n- }\n- }\n- return isValid;\n- }\n-\n- private List<String> getRowAsStrings(Row row, int index) {\n- List<String> result = new LinkedList<String>();\n- for(short i=row.getFirstCellNum(); i<row.getLastCellNum(); i++) {\n- Cell cell = row.getCell(i);\n- if(cell == null) {\n- result.add(\"\");\n- continue;\n- }\n- result.add(cell.toString());\n- }\n- result.add(\"\");\n- result.add(\"Line: \" + index);\n- result.add(\"Record is not importable\");\n- return result;\n- }\n-\n- private ImportedWorkRecord parseRow(Row row, ImportFile file) throws ImportException {\n- try {\n- String personName = row.getCell(COLUMN_PERSON).getStringCellValue();\n- Date date = row.getCell(COLUMN_DATE).getDateCellValue();\n- String budgetName = row.getCell(COLUMN_BUDGET).getStringCellValue();\n- double hours = row.getCell(COLUMN_HOURS).getNumericCellValue();\n-\n- ImportedWorkRecord record = new ImportedWorkRecord();\n- record.setDate(date);\n- record.setBudgetName(budgetName);\n- record.setPersonName(personName);\n- record.setMinutesWorked((int) Math.round(hours * 60));\n-\n- if (record.getDate() == null) {\n- throw new ImportException(String.format(\"Missing date in row %d and column %d of file %s\", row.getRowNum() + 1, COLUMN_DATE + 1, file.getFilename()));\n- }\n-\n- return record;\n- } catch (ImportException e) {\n- throw e;\n- } catch (Exception e) {\n- throw new ImportException(e);\n- }\n- }\n-\n- private boolean isImportable(Row row) {\n- return row != null && (\"ja\".equalsIgnoreCase(row.getCell(COLUMN_INVOICABLE).getStringCellValue()))\n- && (row.getCell(COLUMN_BUDGET).getStringCellValue() != null)\n- && (!\"\".equals(row.getCell(COLUMN_BUDGET).getStringCellValue().trim()))\n- && (row.getCell(COLUMN_PERSON).getStringCellValue() != null)\n- && (!\"\".equals(row.getCell(COLUMN_PERSON).getStringCellValue().trim()));\n- }\n+private static int SHEET_INDEX = 2;","path":"budgeteer-aproda-importer/src/main/java/org/wickedsource/budgeteer/importer/aproda/AprodaWorkRecordsImporter.java","position":166,"original_position":166,"commit_id":"8f4780ae03260bbb4c6f97ea433f15f2de2deeff","original_commit_id":"8f4780ae03260bbb4c6f97ea433f15f2de2deeff","user":{"login":"maximAtanasov","id":32562426,"node_id":"MDQ6VXNlcjMyNTYyNDI2","avatar_url":"https://avatars2.githubusercontent.com/u/32562426?v=4","gravatar_id":"","url":"https://api.github.com/users/maximAtanasov","html_url":"https://github.com/maximAtanasov","followers_url":"https://api.github.com/users/maximAtanasov/followers","following_url":"https://api.github.com/users/maximAtanasov/following{/other_user}","gists_url":"https://api.github.com/users/maximAtanasov/gists{/gist_id}","starred_url":"https://api.github.com/users/maximAtanasov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximAtanasov/subscriptions","organizations_url":"https://api.github.com/users/maximAtanasov/orgs","repos_url":"https://api.github.com/users/maximAtanasov/repos","events_url":"https://api.github.com/users/maximAtanasov/events{/privacy}","received_events_url":"https://api.github.com/users/maximAtanasov/received_events","type":"User","site_admin":false},"body":"Nevermind, I see, yeah it's messed up","created_at":"2018-06-25T12:54:41Z","updated_at":"2018-06-25T12:54:41Z","html_url":"https://github.com/adessoAG/budgeteer/pull/233#discussion_r197784402","pull_request_url":"https://api.github.com/repos/adessoAG/budgeteer/pulls/233","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/adessoAG/budgeteer/pulls/comments/197784402"},"html":{"href":"https://github.com/adessoAG/budgeteer/pull/233#discussion_r197784402"},"pull_request":{"href":"https://api.github.com/repos/adessoAG/budgeteer/pulls/233"}},"in_reply_to_id":197783178},"pull_request":{"url":"https://api.github.com/repos/adessoAG/budgeteer/pulls/233","id":193599498,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNTk5NDk4","html_url":"https://github.com/adessoAG/budgeteer/pull/233","diff_url":"https://github.com/adessoAG/budgeteer/pull/233.diff","patch_url":"https://github.com/adessoAG/budgeteer/pull/233.patch","issue_url":"https://api.github.com/repos/adessoAG/budgeteer/issues/233","number":233,"state":"open","locked":false,"title":"Spotless Code Formatter configuration.","user":{"login":"maximAtanasov","id":32562426,"node_id":"MDQ6VXNlcjMyNTYyNDI2","avatar_url":"https://avatars2.githubusercontent.com/u/32562426?v=4","gravatar_id":"","url":"https://api.github.com/users/maximAtanasov","html_url":"https://github.com/maximAtanasov","followers_url":"https://api.github.com/users/maximAtanasov/followers","following_url":"https://api.github.com/users/maximAtanasov/following{/other_user}","gists_url":"https://api.github.com/users/maximAtanasov/gists{/gist_id}","starred_url":"https://api.github.com/users/maximAtanasov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximAtanasov/subscriptions","organizations_url":"https://api.github.com/users/maximAtanasov/orgs","repos_url":"https://api.github.com/users/maximAtanasov/repos","events_url":"https://api.github.com/users/maximAtanasov/events{/privacy}","received_events_url":"https://api.github.com/users/maximAtanasov/received_events","type":"User","site_admin":false},"body":"This pull request contains a gradle configuration for the spotless code formatter as suggested in #185 \r\n\r\n~~Currently this will not build, as the formatting changes have not been applied.~~\r\nBefore applying them I would like to have some feedback on the way the code is formatted.\r\nThe code formatted by this configuration can be browsed here: \r\nhttps://github.com/adessoAG/budgeteer/commit/ef0b21c3fede649b5e84fb3cd73f99d4f370635f\r\n\r\nSuggestions on improving this configuration are welcome. \r\n","created_at":"2018-06-08T12:30:15Z","updated_at":"2018-06-25T12:54:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"388ab037cb23eadc8afc7357b485320a5d0e9343","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/adessoAG/budgeteer/pulls/233/commits","review_comments_url":"https://api.github.com/repos/adessoAG/budgeteer/pulls/233/comments","review_comment_url":"https://api.github.com/repos/adessoAG/budgeteer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/adessoAG/budgeteer/issues/233/comments","statuses_url":"https://api.github.com/repos/adessoAG/budgeteer/statuses/8f4780ae03260bbb4c6f97ea433f15f2de2deeff","head":{"label":"adessoAG:spotlessConfig","ref":"spotlessConfig","sha":"8f4780ae03260bbb4c6f97ea433f15f2de2deeff","user":{"login":"adessoAG","id":1710422,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTA0MjI=","avatar_url":"https://avatars1.githubusercontent.com/u/1710422?v=4","gravatar_id":"","url":"https://api.github.com/users/adessoAG","html_url":"https://github.com/adessoAG","followers_url":"https://api.github.com/users/adessoAG/followers","following_url":"https://api.github.com/users/adessoAG/following{/other_user}","gists_url":"https://api.github.com/users/adessoAG/gists{/gist_id}","starred_url":"https://api.github.com/users/adessoAG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adessoAG/subscriptions","organizations_url":"https://api.github.com/users/adessoAG/orgs","repos_url":"https://api.github.com/users/adessoAG/repos","events_url":"https://api.github.com/users/adessoAG/events{/privacy}","received_events_url":"https://api.github.com/users/adessoAG/received_events","type":"Organization","site_admin":false},"repo":{"id":24379703,"node_id":"MDEwOlJlcG9zaXRvcnkyNDM3OTcwMw==","name":"budgeteer","full_name":"adessoAG/budgeteer","owner":{"login":"adessoAG","id":1710422,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTA0MjI=","avatar_url":"https://avatars1.githubusercontent.com/u/1710422?v=4","gravatar_id":"","url":"https://api.github.com/users/adessoAG","html_url":"https://github.com/adessoAG","followers_url":"https://api.github.com/users/adessoAG/followers","following_url":"https://api.github.com/users/adessoAG/following{/other_user}","gists_url":"https://api.github.com/users/adessoAG/gists{/gist_id}","starred_url":"https://api.github.com/users/adessoAG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adessoAG/subscriptions","organizations_url":"https://api.github.com/users/adessoAG/orgs","repos_url":"https://api.github.com/users/adessoAG/repos","events_url":"https://api.github.com/users/adessoAG/events{/privacy}","received_events_url":"https://api.github.com/users/adessoAG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/adessoAG/budgeteer","description":"Simple Project Budget Monitoring via Web Browser","fork":false,"url":"https://api.github.com/repos/adessoAG/budgeteer","forks_url":"https://api.github.com/repos/adessoAG/budgeteer/forks","keys_url":"https://api.github.com/repos/adessoAG/budgeteer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adessoAG/budgeteer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adessoAG/budgeteer/teams","hooks_url":"https://api.github.com/repos/adessoAG/budgeteer/hooks","issue_events_url":"https://api.github.com/repos/adessoAG/budgeteer/issues/events{/number}","events_url":"https://api.github.com/repos/adessoAG/budgeteer/events","assignees_url":"https://api.github.com/repos/adessoAG/budgeteer/assignees{/user}","branches_url":"https://api.github.com/repos/adessoAG/budgeteer/branches{/branch}","tags_url":"https://api.github.com/repos/adessoAG/budgeteer/tags","blobs_url":"https://api.github.com/repos/adessoAG/budgeteer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adessoAG/budgeteer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adessoAG/budgeteer/git/refs{/sha}","trees_url":"https://api.github.com/repos/adessoAG/budgeteer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adessoAG/budgeteer/statuses/{sha}","languages_url":"https://api.github.com/repos/adessoAG/budgeteer/languages","stargazers_url":"https://api.github.com/repos/adessoAG/budgeteer/stargazers","contributors_url":"https://api.github.com/repos/adessoAG/budgeteer/contributors","subscribers_url":"https://api.github.com/repos/adessoAG/budgeteer/subscribers","subscription_url":"https://api.github.com/repos/adessoAG/budgeteer/subscription","commits_url":"https://api.github.com/repos/adessoAG/budgeteer/commits{/sha}","git_commits_url":"https://api.github.com/repos/adessoAG/budgeteer/git/commits{/sha}","comments_url":"https://api.github.com/repos/adessoAG/budgeteer/comments{/number}","issue_comment_url":"https://api.github.com/repos/adessoAG/budgeteer/issues/comments{/number}","contents_url":"https://api.github.com/repos/adessoAG/budgeteer/contents/{+path}","compare_url":"https://api.github.com/repos/adessoAG/budgeteer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adessoAG/budgeteer/merges","archive_url":"https://api.github.com/repos/adessoAG/budgeteer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adessoAG/budgeteer/downloads","issues_url":"https://api.github.com/repos/adessoAG/budgeteer/issues{/number}","pulls_url":"https://api.github.com/repos/adessoAG/budgeteer/pulls{/number}","milestones_url":"https://api.github.com/repos/adessoAG/budgeteer/milestones{/number}","notifications_url":"https://api.github.com/repos/adessoAG/budgeteer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adessoAG/budgeteer/labels{/name}","releases_url":"https://api.github.com/repos/adessoAG/budgeteer/releases{/id}","deployments_url":"https://api.github.com/repos/adessoAG/budgeteer/deployments","created_at":"2014-09-23T16:30:14Z","updated_at":"2018-06-25T12:38:58Z","pushed_at":"2018-06-25T12:49:00Z","git_url":"git://github.com/adessoAG/budgeteer.git","ssh_url":"[email protected]:adessoAG/budgeteer.git","clone_url":"https://github.com/adessoAG/budgeteer.git","svn_url":"https://github.com/adessoAG/budgeteer","homepage":null,"size":14471,"stargazers_count":17,"watchers_count":17,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":12,"open_issues":62,"watchers":17,"default_branch":"master"}},"base":{"label":"adessoAG:master","ref":"master","sha":"7f0ba1afdff570dc377d06a0b59951ceb74972b8","user":{"login":"adessoAG","id":1710422,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTA0MjI=","avatar_url":"https://avatars1.githubusercontent.com/u/1710422?v=4","gravatar_id":"","url":"https://api.github.com/users/adessoAG","html_url":"https://github.com/adessoAG","followers_url":"https://api.github.com/users/adessoAG/followers","following_url":"https://api.github.com/users/adessoAG/following{/other_user}","gists_url":"https://api.github.com/users/adessoAG/gists{/gist_id}","starred_url":"https://api.github.com/users/adessoAG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adessoAG/subscriptions","organizations_url":"https://api.github.com/users/adessoAG/orgs","repos_url":"https://api.github.com/users/adessoAG/repos","events_url":"https://api.github.com/users/adessoAG/events{/privacy}","received_events_url":"https://api.github.com/users/adessoAG/received_events","type":"Organization","site_admin":false},"repo":{"id":24379703,"node_id":"MDEwOlJlcG9zaXRvcnkyNDM3OTcwMw==","name":"budgeteer","full_name":"adessoAG/budgeteer","owner":{"login":"adessoAG","id":1710422,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTA0MjI=","avatar_url":"https://avatars1.githubusercontent.com/u/1710422?v=4","gravatar_id":"","url":"https://api.github.com/users/adessoAG","html_url":"https://github.com/adessoAG","followers_url":"https://api.github.com/users/adessoAG/followers","following_url":"https://api.github.com/users/adessoAG/following{/other_user}","gists_url":"https://api.github.com/users/adessoAG/gists{/gist_id}","starred_url":"https://api.github.com/users/adessoAG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adessoAG/subscriptions","organizations_url":"https://api.github.com/users/adessoAG/orgs","repos_url":"https://api.github.com/users/adessoAG/repos","events_url":"https://api.github.com/users/adessoAG/events{/privacy}","received_events_url":"https://api.github.com/users/adessoAG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/adessoAG/budgeteer","description":"Simple Project Budget Monitoring via Web Browser","fork":false,"url":"https://api.github.com/repos/adessoAG/budgeteer","forks_url":"https://api.github.com/repos/adessoAG/budgeteer/forks","keys_url":"https://api.github.com/repos/adessoAG/budgeteer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adessoAG/budgeteer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adessoAG/budgeteer/teams","hooks_url":"https://api.github.com/repos/adessoAG/budgeteer/hooks","issue_events_url":"https://api.github.com/repos/adessoAG/budgeteer/issues/events{/number}","events_url":"https://api.github.com/repos/adessoAG/budgeteer/events","assignees_url":"https://api.github.com/repos/adessoAG/budgeteer/assignees{/user}","branches_url":"https://api.github.com/repos/adessoAG/budgeteer/branches{/branch}","tags_url":"https://api.github.com/repos/adessoAG/budgeteer/tags","blobs_url":"https://api.github.com/repos/adessoAG/budgeteer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adessoAG/budgeteer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adessoAG/budgeteer/git/refs{/sha}","trees_url":"https://api.github.com/repos/adessoAG/budgeteer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adessoAG/budgeteer/statuses/{sha}","languages_url":"https://api.github.com/repos/adessoAG/budgeteer/languages","stargazers_url":"https://api.github.com/repos/adessoAG/budgeteer/stargazers","contributors_url":"https://api.github.com/repos/adessoAG/budgeteer/contributors","subscribers_url":"https://api.github.com/repos/adessoAG/budgeteer/subscribers","subscription_url":"https://api.github.com/repos/adessoAG/budgeteer/subscription","commits_url":"https://api.github.com/repos/adessoAG/budgeteer/commits{/sha}","git_commits_url":"https://api.github.com/repos/adessoAG/budgeteer/git/commits{/sha}","comments_url":"https://api.github.com/repos/adessoAG/budgeteer/comments{/number}","issue_comment_url":"https://api.github.com/repos/adessoAG/budgeteer/issues/comments{/number}","contents_url":"https://api.github.com/repos/adessoAG/budgeteer/contents/{+path}","compare_url":"https://api.github.com/repos/adessoAG/budgeteer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adessoAG/budgeteer/merges","archive_url":"https://api.github.com/repos/adessoAG/budgeteer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adessoAG/budgeteer/downloads","issues_url":"https://api.github.com/repos/adessoAG/budgeteer/issues{/number}","pulls_url":"https://api.github.com/repos/adessoAG/budgeteer/pulls{/number}","milestones_url":"https://api.github.com/repos/adessoAG/budgeteer/milestones{/number}","notifications_url":"https://api.github.com/repos/adessoAG/budgeteer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adessoAG/budgeteer/labels{/name}","releases_url":"https://api.github.com/repos/adessoAG/budgeteer/releases{/id}","deployments_url":"https://api.github.com/repos/adessoAG/budgeteer/deployments","created_at":"2014-09-23T16:30:14Z","updated_at":"2018-06-25T12:38:58Z","pushed_at":"2018-06-25T12:49:00Z","git_url":"git://github.com/adessoAG/budgeteer.git","ssh_url":"[email protected]:adessoAG/budgeteer.git","clone_url":"https://github.com/adessoAG/budgeteer.git","svn_url":"https://github.com/adessoAG/budgeteer","homepage":null,"size":14471,"stargazers_count":17,"watchers_count":17,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":12,"open_issues":62,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/adessoAG/budgeteer/pulls/233"},"html":{"href":"https://github.com/adessoAG/budgeteer/pull/233"},"issue":{"href":"https://api.github.com/repos/adessoAG/budgeteer/issues/233"},"comments":{"href":"https://api.github.com/repos/adessoAG/budgeteer/issues/233/comments"},"review_comments":{"href":"https://api.github.com/repos/adessoAG/budgeteer/pulls/233/comments"},"review_comment":{"href":"https://api.github.com/repos/adessoAG/budgeteer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/adessoAG/budgeteer/pulls/233/commits"},"statuses":{"href":"https://api.github.com/repos/adessoAG/budgeteer/statuses/8f4780ae03260bbb4c6f97ea433f15f2de2deeff"}},"author_association":"MEMBER"}} | {
"id": 24379703,
"name": "adessoAG/budgeteer",
"url": "https://api.github.com/repos/adessoAG/budgeteer"
} | {
"id": 32562426,
"login": "maximAtanasov",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/32562426?",
"url": "https://api.github.com/users/maximAtanasov"
} | {
"id": 1710422,
"login": "adessoAG",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1710422?",
"url": "https://api.github.com/orgs/adessoAG"
} | 2018-06-25T12:54:41 | 7872932297 | {"actor":{"display_login":"maximAtanasov"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/pulls/comments/189684794","pull_request_review_id":121912167,"id":189684794,"diff_hunk":"@@ -0,0 +1,51 @@\n+\"\"\"EasyBuild container (https://github.com/easybuilders/easybuild)\n+ Set the user argument 'easyconfig' to specify the EasyConfig to\n+ build. Otherwise, it will just build a base EasyBuild container\n+ image.\n+\n+ Sample workflow:\n+$ hpccm.py --recipe recipes/easybuild.py --userarg easyconfig=GROMACS-2016.3-foss-2016b-GPU-enabled.eb > Dockerfile.gromacs.eb\n+$ docker build -t gromacs.eb -f Dockerfile.gromacs.eb .\n+$ nvidia-docker run --rm -ti gromacs.eb bash -l\n+container:/tmp> module load GROMACS\n+...\n+\"\"\"\n+# pylint: disable=invalid-name, undefined-variable, used-before-assignment\n+import os\n+\n+Stage0 += comment(__doc__, reformat=False)\n+\n+Stage0.baseimage('ubuntu:16.04')\n+\n+# Base dependencies\n+Stage0 += python()\n+Stage0 += gnu()\n+Stage0 += ofed()\n+\n+# Additional dependencies\n+ospackages = ['build-essential', 'bzip2', 'file', 'git', 'gzip',\n+ 'libssl-dev', 'libtool', 'lmod', 'make', 'patch',\n+ 'python-pip', 'python-setuptools', 'tar', 'wget',\n+ 'unzip', 'xz-utils']\n+Stage0 += apt_get(ospackages=ospackages)\n+\n+# lmod setup\n+Stage0 += shell(commands=[\n+ 'ln -s /usr/share/lmod/lmod/init/profile /etc/profile.d/lmod.sh'])\n+\n+# Setup and install EasyBuild\n+Stage0 += shell(commands=['useradd -m easybuild',\n+ 'mkdir -p /opt/easybuild',\n+ 'chown easybuild:easybuild /opt/easybuild',\n+ 'easy_install easybuild'])\n+\n+Stage0 += environment(variables={'MODULEPATH': '/opt/easybuild/modules/all:/home/easybuild/.local/easybuild/modules/all:$MODULEPATH'})\n+\n+easyconfig = USERARG.get('easyconfig', None)\n+if easyconfig:\n+ # If the easyconfig is a file in the local build context, inject it\n+ # into the container image\n+ if os.path.isfile(easyconfig):\n+ Stage0 += copy(src=easyconfig, dest='/home/easybuild')","path":"recipes/easybuild.py","position":49,"original_position":49,"commit_id":"8177e21ab78d3a23a7a20af975a1a1dac865c0b4","original_commit_id":"8177e21ab78d3a23a7a20af975a1a1dac865c0b4","user":{"login":"samcmill","id":18687225,"avatar_url":"https://avatars2.githubusercontent.com/u/18687225?v=4","gravatar_id":"","url":"https://api.github.com/users/samcmill","html_url":"https://github.com/samcmill","followers_url":"https://api.github.com/users/samcmill/followers","following_url":"https://api.github.com/users/samcmill/following{/other_user}","gists_url":"https://api.github.com/users/samcmill/gists{/gist_id}","starred_url":"https://api.github.com/users/samcmill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samcmill/subscriptions","organizations_url":"https://api.github.com/users/samcmill/orgs","repos_url":"https://api.github.com/users/samcmill/repos","events_url":"https://api.github.com/users/samcmill/events{/privacy}","received_events_url":"https://api.github.com/users/samcmill/received_events","type":"User","site_admin":false},"body":"Agree. This covers the most basic case. The most complex case you describe would currently require the user to write their own recipe (using the provided EasyBuild recipe as a starting point). The complex case should also be considered if / when a `easybuild` building block is added.","created_at":"2018-05-21T19:08:04Z","updated_at":"2018-05-21T19:08:04Z","html_url":"https://github.com/NVIDIA/hpc-container-maker/pull/23#discussion_r189684794","pull_request_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/pulls/23","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NVIDIA/hpc-container-maker/pulls/comments/189684794"},"html":{"href":"https://github.com/NVIDIA/hpc-container-maker/pull/23#discussion_r189684794"},"pull_request":{"href":"https://api.github.com/repos/NVIDIA/hpc-container-maker/pulls/23"}},"in_reply_to_id":189683596},"pull_request":{"url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/pulls/23","id":188151880,"html_url":"https://github.com/NVIDIA/hpc-container-maker/pull/23","diff_url":"https://github.com/NVIDIA/hpc-container-maker/pull/23.diff","patch_url":"https://github.com/NVIDIA/hpc-container-maker/pull/23.patch","issue_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/issues/23","number":23,"state":"closed","locked":false,"title":"Add EasyBuild recipe","user":{"login":"samcmill","id":18687225,"avatar_url":"https://avatars2.githubusercontent.com/u/18687225?v=4","gravatar_id":"","url":"https://api.github.com/users/samcmill","html_url":"https://github.com/samcmill","followers_url":"https://api.github.com/users/samcmill/followers","following_url":"https://api.github.com/users/samcmill/following{/other_user}","gists_url":"https://api.github.com/users/samcmill/gists{/gist_id}","starred_url":"https://api.github.com/users/samcmill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samcmill/subscriptions","organizations_url":"https://api.github.com/users/samcmill/orgs","repos_url":"https://api.github.com/users/samcmill/repos","events_url":"https://api.github.com/users/samcmill/events{/privacy}","received_events_url":"https://api.github.com/users/samcmill/received_events","type":"User","site_admin":false},"body":"This is a HPCCM recipe for a container that includes EasyBuild (http://easybuild.readthedocs.io/en/latest/index.html).\r\n\r\nBy default, it includes only EasyBuild itself. If the optional userarg is specified, then it will also build the specified EasyBuild application recipe (easyconfig).\r\n\r\nThis could turn into a `easybuild` HPCCM building block to make it even easier on the use.\r\n\r\n@boegel and #20 ","created_at":"2018-05-15T14:41:07Z","updated_at":"2018-05-21T19:08:04Z","closed_at":"2018-05-21T14:00:59Z","merged_at":"2018-05-21T14:00:59Z","merge_commit_sha":"ccc3986cc9277050bf7886c4c412591873a41e1c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/pulls/23/commits","review_comments_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/pulls/23/comments","review_comment_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/issues/23/comments","statuses_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/statuses/8177e21ab78d3a23a7a20af975a1a1dac865c0b4","head":{"label":"NVIDIA:easybuild","ref":"easybuild","sha":"8177e21ab78d3a23a7a20af975a1a1dac865c0b4","user":{"login":"NVIDIA","id":1728152,"avatar_url":"https://avatars2.githubusercontent.com/u/1728152?v=4","gravatar_id":"","url":"https://api.github.com/users/NVIDIA","html_url":"https://github.com/NVIDIA","followers_url":"https://api.github.com/users/NVIDIA/followers","following_url":"https://api.github.com/users/NVIDIA/following{/other_user}","gists_url":"https://api.github.com/users/NVIDIA/gists{/gist_id}","starred_url":"https://api.github.com/users/NVIDIA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NVIDIA/subscriptions","organizations_url":"https://api.github.com/users/NVIDIA/orgs","repos_url":"https://api.github.com/users/NVIDIA/repos","events_url":"https://api.github.com/users/NVIDIA/events{/privacy}","received_events_url":"https://api.github.com/users/NVIDIA/received_events","type":"Organization","site_admin":false},"repo":{"id":126385168,"name":"hpc-container-maker","full_name":"NVIDIA/hpc-container-maker","owner":{"login":"NVIDIA","id":1728152,"avatar_url":"https://avatars2.githubusercontent.com/u/1728152?v=4","gravatar_id":"","url":"https://api.github.com/users/NVIDIA","html_url":"https://github.com/NVIDIA","followers_url":"https://api.github.com/users/NVIDIA/followers","following_url":"https://api.github.com/users/NVIDIA/following{/other_user}","gists_url":"https://api.github.com/users/NVIDIA/gists{/gist_id}","starred_url":"https://api.github.com/users/NVIDIA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NVIDIA/subscriptions","organizations_url":"https://api.github.com/users/NVIDIA/orgs","repos_url":"https://api.github.com/users/NVIDIA/repos","events_url":"https://api.github.com/users/NVIDIA/events{/privacy}","received_events_url":"https://api.github.com/users/NVIDIA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NVIDIA/hpc-container-maker","description":"HPC Container Maker","fork":false,"url":"https://api.github.com/repos/NVIDIA/hpc-container-maker","forks_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/forks","keys_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/teams","hooks_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/hooks","issue_events_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/issues/events{/number}","events_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/events","assignees_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/assignees{/user}","branches_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/branches{/branch}","tags_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/tags","blobs_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/git/refs{/sha}","trees_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/statuses/{sha}","languages_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/languages","stargazers_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/stargazers","contributors_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/contributors","subscribers_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/subscribers","subscription_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/subscription","commits_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/commits{/sha}","git_commits_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/git/commits{/sha}","comments_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/comments{/number}","issue_comment_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/issues/comments{/number}","contents_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/contents/{+path}","compare_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/merges","archive_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/downloads","issues_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/issues{/number}","pulls_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/pulls{/number}","milestones_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/milestones{/number}","notifications_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/labels{/name}","releases_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/releases{/id}","deployments_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/deployments","created_at":"2018-03-22T19:26:41Z","updated_at":"2018-05-21T14:01:17Z","pushed_at":"2018-05-21T17:34:59Z","git_url":"git://github.com/NVIDIA/hpc-container-maker.git","ssh_url":"[email protected]:NVIDIA/hpc-container-maker.git","clone_url":"https://github.com/NVIDIA/hpc-container-maker.git","svn_url":"https://github.com/NVIDIA/hpc-container-maker","homepage":null,"size":182,"stargazers_count":42,"watchers_count":42,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":5,"open_issues":2,"watchers":42,"default_branch":"master"}},"base":{"label":"NVIDIA:master","ref":"master","sha":"0f294bd769828c12cbd723159d09dfc8392d40f3","user":{"login":"NVIDIA","id":1728152,"avatar_url":"https://avatars2.githubusercontent.com/u/1728152?v=4","gravatar_id":"","url":"https://api.github.com/users/NVIDIA","html_url":"https://github.com/NVIDIA","followers_url":"https://api.github.com/users/NVIDIA/followers","following_url":"https://api.github.com/users/NVIDIA/following{/other_user}","gists_url":"https://api.github.com/users/NVIDIA/gists{/gist_id}","starred_url":"https://api.github.com/users/NVIDIA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NVIDIA/subscriptions","organizations_url":"https://api.github.com/users/NVIDIA/orgs","repos_url":"https://api.github.com/users/NVIDIA/repos","events_url":"https://api.github.com/users/NVIDIA/events{/privacy}","received_events_url":"https://api.github.com/users/NVIDIA/received_events","type":"Organization","site_admin":false},"repo":{"id":126385168,"name":"hpc-container-maker","full_name":"NVIDIA/hpc-container-maker","owner":{"login":"NVIDIA","id":1728152,"avatar_url":"https://avatars2.githubusercontent.com/u/1728152?v=4","gravatar_id":"","url":"https://api.github.com/users/NVIDIA","html_url":"https://github.com/NVIDIA","followers_url":"https://api.github.com/users/NVIDIA/followers","following_url":"https://api.github.com/users/NVIDIA/following{/other_user}","gists_url":"https://api.github.com/users/NVIDIA/gists{/gist_id}","starred_url":"https://api.github.com/users/NVIDIA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NVIDIA/subscriptions","organizations_url":"https://api.github.com/users/NVIDIA/orgs","repos_url":"https://api.github.com/users/NVIDIA/repos","events_url":"https://api.github.com/users/NVIDIA/events{/privacy}","received_events_url":"https://api.github.com/users/NVIDIA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NVIDIA/hpc-container-maker","description":"HPC Container Maker","fork":false,"url":"https://api.github.com/repos/NVIDIA/hpc-container-maker","forks_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/forks","keys_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/teams","hooks_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/hooks","issue_events_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/issues/events{/number}","events_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/events","assignees_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/assignees{/user}","branches_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/branches{/branch}","tags_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/tags","blobs_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/git/refs{/sha}","trees_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/statuses/{sha}","languages_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/languages","stargazers_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/stargazers","contributors_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/contributors","subscribers_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/subscribers","subscription_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/subscription","commits_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/commits{/sha}","git_commits_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/git/commits{/sha}","comments_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/comments{/number}","issue_comment_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/issues/comments{/number}","contents_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/contents/{+path}","compare_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/merges","archive_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/downloads","issues_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/issues{/number}","pulls_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/pulls{/number}","milestones_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/milestones{/number}","notifications_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/labels{/name}","releases_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/releases{/id}","deployments_url":"https://api.github.com/repos/NVIDIA/hpc-container-maker/deployments","created_at":"2018-03-22T19:26:41Z","updated_at":"2018-05-21T14:01:17Z","pushed_at":"2018-05-21T17:34:59Z","git_url":"git://github.com/NVIDIA/hpc-container-maker.git","ssh_url":"[email protected]:NVIDIA/hpc-container-maker.git","clone_url":"https://github.com/NVIDIA/hpc-container-maker.git","svn_url":"https://github.com/NVIDIA/hpc-container-maker","homepage":null,"size":182,"stargazers_count":42,"watchers_count":42,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":5,"open_issues":2,"watchers":42,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NVIDIA/hpc-container-maker/pulls/23"},"html":{"href":"https://github.com/NVIDIA/hpc-container-maker/pull/23"},"issue":{"href":"https://api.github.com/repos/NVIDIA/hpc-container-maker/issues/23"},"comments":{"href":"https://api.github.com/repos/NVIDIA/hpc-container-maker/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/NVIDIA/hpc-container-maker/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/NVIDIA/hpc-container-maker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NVIDIA/hpc-container-maker/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/NVIDIA/hpc-container-maker/statuses/8177e21ab78d3a23a7a20af975a1a1dac865c0b4"}},"author_association":"CONTRIBUTOR"}} | {
"id": 126385168,
"name": "NVIDIA/hpc-container-maker",
"url": "https://api.github.com/repos/NVIDIA/hpc-container-maker"
} | {
"id": 18687225,
"login": "samcmill",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18687225?",
"url": "https://api.github.com/users/samcmill"
} | {
"id": 1728152,
"login": "NVIDIA",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1728152?",
"url": "https://api.github.com/orgs/NVIDIA"
} | 2018-05-21T19:08:04 | 7706510655 | {"actor":{"display_login":"samcmill"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/seqan/seqan3/pulls/comments/210304354","pull_request_review_id":146488864,"id":210304354,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDMwNDM1NA==","diff_hunk":"@@ -0,0 +1,352 @@\n+// ============================================================================\n+// SeqAn - The Library for Sequence Analysis\n+// ============================================================================\n+//\n+// Copyright (c) 2006-2018, Knut Reinert & Freie Universitaet Berlin\n+// Copyright (c) 2016-2018, Knut Reinert & MPI Molekulare Genetik\n+// All rights reserved.\n+//\n+// Redistribution and use in source and binary forms, with or without\n+// modification, are permitted provided that the following conditions are met:\n+//\n+// * Redistributions of source code must retain the above copyright\n+// notice, this list of conditions and the following disclaimer.\n+// * Redistributions in binary form must reproduce the above copyright\n+// notice, this list of conditions and the following disclaimer in the\n+// documentation and/or other materials provided with the distribution.\n+// * Neither the name of Knut Reinert or the FU Berlin nor the names of\n+// its contributors may be used to endorse or promote products derived\n+// from this software without specific prior written permission.\n+//\n+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS \"AS IS\"\n+// AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE\n+// IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE\n+// ARE DISCLAIMED. IN NO EVENT SHALL KNUT REINERT OR THE FU BERLIN BE LIABLE\n+// FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL\n+// DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR\n+// SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER\n+// CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT\n+// LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY\n+// OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH\n+// DAMAGE.\n+//\n+// ============================================================================\n+/*!\\file\n+ * \\brief Provides the seqan3::sequence_file_format_sam class.\n+ * \\author Hannes Hauswedell <hannes.hauswedell AT fu-berlin.de>\n+ */\n+#pragma once\n+#include <iterator>\n+#include <string>\n+#include <string_view>\n+#include <vector>\n+#include <range/v3/algorithm/copy.hpp>\n+#include <range/v3/utility/iterator.hpp>\n+#include <range/v3/view/chunk.hpp>\n+#include <range/v3/view/drop_while.hpp>\n+#include <range/v3/view/join.hpp>\n+#include <range/v3/view/remove_if.hpp>\n+#include <range/v3/view/take_while.hpp>\n+#include <seqan3/alphabet/nucleotide/dna5.hpp>\n+#include <seqan3/alphabet/quality/aliases.hpp>\n+#include <seqan3/core/metafunction/range.hpp>\n+#include <seqan3/io/detail/ignore_output_iterator.hpp>\n+#include <seqan3/io/detail/output_iterator_conversion_adaptor.hpp>\n+#include <seqan3/io/sequence/sequence_file_in_options.hpp>\n+#include <seqan3/io/sequence/sequence_file_out_options.hpp>\n+#include <seqan3/io/stream/parse_condition.hpp>\n+#include <seqan3/range/view/char_to.hpp>\n+#include <seqan3/range/view/to_char.hpp>\n+#include <seqan3/std/concept/range.hpp>\n+#include <seqan3/std/view/subrange.hpp>\n+#include <seqan3/std/view/transform.hpp>\n+namespace seqan3\n+{\n+/*!\\brief The sam format.\n+ * \\implements sequence_file_format_concept\n+ * \\ingroup sequence\n+ *\n+ * \\details\n+ *\n+ * ### Introduction\n+ *\n+ * SAM stores sequence alignments to a reference, but is sometimes used to store the seqeuences itself. See the\n+ * [article on wikipedia](https://en.wikipedia.org/wiki/SAM_(file_format)) for a an in-depth description of the format.\n+ *\n+ * ### Fields\n+ *\n+ * The SAM format provides the fields seqan3::field::SEQ, seqan3::field::ID and seqan3::field::SEQ_QUAL. All fields are required when writing.\n+ *\n+ * ### Implementation notes\n+ *\n+ */\n+class sequence_file_format_sam\n+{\n+public:\n+ /*!\\name Constructors, destructor and assignment\n+ * \\brief Rule of five explicitly defaulted.\n+ * \\{\n+ */\n+ sequence_file_format_sam() = default;\n+ sequence_file_format_sam(sequence_file_format_sam const &) = delete;\n+ sequence_file_format_sam & operator=(sequence_file_format_sam const &) = delete;\n+ sequence_file_format_sam(sequence_file_format_sam &&) = default;\n+ sequence_file_format_sam & operator=(sequence_file_format_sam &&) = default;\n+ //!\\}\n+ //!\\brief The valid file extensions for this format; note that you can modify this value.\n+ static inline std::vector<std::string> file_extensions\n+ {\n+ { \"sam\" },\n+ };\n+ //!\\copydoc sequence_file_in_format_concept::read\n+ template <typename stream_type, // constraints checked by file\n+ typename seq_legal_alph_type,\n+ typename seq_type, // other constraints checked inside function\n+ typename id_type,\n+ typename qual_type,\n+ typename seq_qual_type>\n+ void read(stream_type & stream,\n+ sequence_file_in_options<seq_legal_alph_type> const & options,\n+ seq_type & sequence,\n+ id_type & id,\n+ qual_type & qualities,\n+ seq_qual_type & seq_qual)\n+ {\n+ static_assert(detail::decays_to_ignore_v<seq_type> || detail::decays_to_ignore_v<seq_qual_type>,\n+ \"Either the sequence field, or the seq_qual field need to be set to std::ignore.\");\n+ static_assert(detail::decays_to_ignore_v<qual_type> || detail::decays_to_ignore_v<seq_qual_type>,\n+ \"Either the qualities field, or the seq_qual field need to be set to std::ignore.\");\n+ auto stream_view = view::subrange<decltype(std::istreambuf_iterator<char>{stream}),\n+ decltype(std::istreambuf_iterator<char>{})>\n+ {std::istreambuf_iterator<char>{stream},\n+ std::istreambuf_iterator<char>{}};\n+ auto stream_it = ranges::begin(stream_view);\n+ if(*stream_it != '@') { //Ignore comment lines\n+ // ID\n+ read_id(stream_view, options, id);\n+ // Sequence\n+ if constexpr (!detail::decays_to_ignore_v<seq_type>) // sequence\n+ read_seq(stream_view, options, sequence);\n+ else\n+ read_seq(stream_view, options, seq_qual); // seq_qual (possibly std::ignore, too)\n+ // Qualities\n+ if constexpr (!detail::decays_to_ignore_v<qual_type>) // qualities\n+ read_qual(stream_view, qualities);\n+ else\n+ read_qual(stream_view, seq_qual); // seq_qual (possibly std::ignore, too)\n+ //TODO read_qual who returns seq_qual with correct output format\n+ // make sure \"buffer at end\" implies \"stream at end\"\n+ if ((std::istreambuf_iterator<char>{stream} == std::istreambuf_iterator<char>{}) &&\n+ (!stream.eof()))\n+ {\n+ stream.get(); // triggers error in stream and sets eof\n+ }\n+ }\n+ else{\n+ while(*stream_it != '\\n')\n+ {++stream_it;}\n+ }\n+ // Jump over the new line character in the end\n+ ++stream_it;\n+ }\n+ //!\\copydoc sequence_file_out_format_concept::write\n+ template <typename stream_type, // constraints checked by file\n+ typename seq_type, // other constraints checked inside function\n+ typename id_type,\n+ typename qual_type,\n+ typename seq_qual_type>\n+ void write(stream_type & stream,\n+ sequence_file_out_options const & options,\n+ seq_type && sequence,\n+ id_type && id,\n+ // qual_type && SEQAN3_DOXYGEN_ONLY(qualities),\n+ qual_type && qualities,\n+ seq_qual_type && seq_qual)\n+ {\n+ static_assert(detail::decays_to_ignore_v<seq_type> || detail::decays_to_ignore_v<seq_qual_type>,\n+ \"Either the sequence field, or the seq_qual field need to be set to std::ignore.\");\n+ static_assert(detail::decays_to_ignore_v<qual_type> || detail::decays_to_ignore_v<seq_qual_type>,\n+ \"Either the qualities field, or the seq_qual field need to be set to std::ignore.\");\n+ ranges::ostreambuf_iterator stream_it{stream};\n+ // ID\n+ if constexpr (detail::decays_to_ignore_v<id_type>)\n+ {\n+ throw std::logic_error{\"The ID field may not be set to ignore when writing sam files.\"};","path":"include/seqan3/io/sequence/sequence_file_format_sam.hpp","position":174,"original_position":174,"commit_id":"d0a37acc55870d54629245b85c74c5225ea53cab","original_commit_id":"d0a37acc55870d54629245b85c74c5225ea53cab","user":{"login":"h-2","id":2996863,"node_id":"MDQ6VXNlcjI5OTY4NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/2996863?v=4","gravatar_id":"","url":"https://api.github.com/users/h-2","html_url":"https://github.com/h-2","followers_url":"https://api.github.com/users/h-2/followers","following_url":"https://api.github.com/users/h-2/following{/other_user}","gists_url":"https://api.github.com/users/h-2/gists{/gist_id}","starred_url":"https://api.github.com/users/h-2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-2/subscriptions","organizations_url":"https://api.github.com/users/h-2/orgs","repos_url":"https://api.github.com/users/h-2/repos","events_url":"https://api.github.com/users/h-2/events{/privacy}","received_events_url":"https://api.github.com/users/h-2/received_events","type":"User","site_admin":false},"body":"Are you sure? I think they can be set to `*` and the file will still be valid, or not?","created_at":"2018-08-15T15:18:18Z","updated_at":"2018-08-15T15:27:44Z","html_url":"https://github.com/seqan/seqan3/pull/368#discussion_r210304354","pull_request_url":"https://api.github.com/repos/seqan/seqan3/pulls/368","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/comments/210304354"},"html":{"href":"https://github.com/seqan/seqan3/pull/368#discussion_r210304354"},"pull_request":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/368"}}},"pull_request":{"url":"https://api.github.com/repos/seqan/seqan3/pulls/368","id":208285130,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4Mjg1MTMw","html_url":"https://github.com/seqan/seqan3/pull/368","diff_url":"https://github.com/seqan/seqan3/pull/368.diff","patch_url":"https://github.com/seqan/seqan3/pull/368.patch","issue_url":"https://api.github.com/repos/seqan/seqan3/issues/368","number":368,"state":"open","locked":false,"title":"[feature] start sam io","user":{"login":"MitraDarja","id":16179144,"node_id":"MDQ6VXNlcjE2MTc5MTQ0","avatar_url":"https://avatars2.githubusercontent.com/u/16179144?v=4","gravatar_id":"","url":"https://api.github.com/users/MitraDarja","html_url":"https://github.com/MitraDarja","followers_url":"https://api.github.com/users/MitraDarja/followers","following_url":"https://api.github.com/users/MitraDarja/following{/other_user}","gists_url":"https://api.github.com/users/MitraDarja/gists{/gist_id}","starred_url":"https://api.github.com/users/MitraDarja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MitraDarja/subscriptions","organizations_url":"https://api.github.com/users/MitraDarja/orgs","repos_url":"https://api.github.com/users/MitraDarja/repos","events_url":"https://api.github.com/users/MitraDarja/events{/privacy}","received_events_url":"https://api.github.com/users/MitraDarja/received_events","type":"User","site_admin":false},"body":"Start of the sam io\r\nthere are still some TODOs open and I think more tests are necessary to check if it really works. Specifically, a test case with actual qualities are necessary.","created_at":"2018-08-14T13:39:53Z","updated_at":"2018-08-15T15:27:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e242a070a3b8b44ae9e7bacd339cf590eb9ce5a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/seqan/seqan3/pulls/368/commits","review_comments_url":"https://api.github.com/repos/seqan/seqan3/pulls/368/comments","review_comment_url":"https://api.github.com/repos/seqan/seqan3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/seqan/seqan3/issues/368/comments","statuses_url":"https://api.github.com/repos/seqan/seqan3/statuses/d0a37acc55870d54629245b85c74c5225ea53cab","head":{"label":"MitraDarja:sam_new","ref":"sam_new","sha":"d0a37acc55870d54629245b85c74c5225ea53cab","user":{"login":"MitraDarja","id":16179144,"node_id":"MDQ6VXNlcjE2MTc5MTQ0","avatar_url":"https://avatars2.githubusercontent.com/u/16179144?v=4","gravatar_id":"","url":"https://api.github.com/users/MitraDarja","html_url":"https://github.com/MitraDarja","followers_url":"https://api.github.com/users/MitraDarja/followers","following_url":"https://api.github.com/users/MitraDarja/following{/other_user}","gists_url":"https://api.github.com/users/MitraDarja/gists{/gist_id}","starred_url":"https://api.github.com/users/MitraDarja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MitraDarja/subscriptions","organizations_url":"https://api.github.com/users/MitraDarja/orgs","repos_url":"https://api.github.com/users/MitraDarja/repos","events_url":"https://api.github.com/users/MitraDarja/events{/privacy}","received_events_url":"https://api.github.com/users/MitraDarja/received_events","type":"User","site_admin":false},"repo":{"id":139714198,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk3MTQxOTg=","name":"seqan3","full_name":"MitraDarja/seqan3","owner":{"login":"MitraDarja","id":16179144,"node_id":"MDQ6VXNlcjE2MTc5MTQ0","avatar_url":"https://avatars2.githubusercontent.com/u/16179144?v=4","gravatar_id":"","url":"https://api.github.com/users/MitraDarja","html_url":"https://github.com/MitraDarja","followers_url":"https://api.github.com/users/MitraDarja/followers","following_url":"https://api.github.com/users/MitraDarja/following{/other_user}","gists_url":"https://api.github.com/users/MitraDarja/gists{/gist_id}","starred_url":"https://api.github.com/users/MitraDarja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MitraDarja/subscriptions","organizations_url":"https://api.github.com/users/MitraDarja/orgs","repos_url":"https://api.github.com/users/MitraDarja/repos","events_url":"https://api.github.com/users/MitraDarja/events{/privacy}","received_events_url":"https://api.github.com/users/MitraDarja/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MitraDarja/seqan3","description":"The modern C++ library for sequence analysis. Contains version 3 of the library and API docs.","fork":true,"url":"https://api.github.com/repos/MitraDarja/seqan3","forks_url":"https://api.github.com/repos/MitraDarja/seqan3/forks","keys_url":"https://api.github.com/repos/MitraDarja/seqan3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MitraDarja/seqan3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MitraDarja/seqan3/teams","hooks_url":"https://api.github.com/repos/MitraDarja/seqan3/hooks","issue_events_url":"https://api.github.com/repos/MitraDarja/seqan3/issues/events{/number}","events_url":"https://api.github.com/repos/MitraDarja/seqan3/events","assignees_url":"https://api.github.com/repos/MitraDarja/seqan3/assignees{/user}","branches_url":"https://api.github.com/repos/MitraDarja/seqan3/branches{/branch}","tags_url":"https://api.github.com/repos/MitraDarja/seqan3/tags","blobs_url":"https://api.github.com/repos/MitraDarja/seqan3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MitraDarja/seqan3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MitraDarja/seqan3/git/refs{/sha}","trees_url":"https://api.github.com/repos/MitraDarja/seqan3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MitraDarja/seqan3/statuses/{sha}","languages_url":"https://api.github.com/repos/MitraDarja/seqan3/languages","stargazers_url":"https://api.github.com/repos/MitraDarja/seqan3/stargazers","contributors_url":"https://api.github.com/repos/MitraDarja/seqan3/contributors","subscribers_url":"https://api.github.com/repos/MitraDarja/seqan3/subscribers","subscription_url":"https://api.github.com/repos/MitraDarja/seqan3/subscription","commits_url":"https://api.github.com/repos/MitraDarja/seqan3/commits{/sha}","git_commits_url":"https://api.github.com/repos/MitraDarja/seqan3/git/commits{/sha}","comments_url":"https://api.github.com/repos/MitraDarja/seqan3/comments{/number}","issue_comment_url":"https://api.github.com/repos/MitraDarja/seqan3/issues/comments{/number}","contents_url":"https://api.github.com/repos/MitraDarja/seqan3/contents/{+path}","compare_url":"https://api.github.com/repos/MitraDarja/seqan3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MitraDarja/seqan3/merges","archive_url":"https://api.github.com/repos/MitraDarja/seqan3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MitraDarja/seqan3/downloads","issues_url":"https://api.github.com/repos/MitraDarja/seqan3/issues{/number}","pulls_url":"https://api.github.com/repos/MitraDarja/seqan3/pulls{/number}","milestones_url":"https://api.github.com/repos/MitraDarja/seqan3/milestones{/number}","notifications_url":"https://api.github.com/repos/MitraDarja/seqan3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MitraDarja/seqan3/labels{/name}","releases_url":"https://api.github.com/repos/MitraDarja/seqan3/releases{/id}","deployments_url":"https://api.github.com/repos/MitraDarja/seqan3/deployments","created_at":"2018-07-04T11:41:43Z","updated_at":"2018-08-14T13:27:18Z","pushed_at":"2018-08-14T13:36:07Z","git_url":"git://github.com/MitraDarja/seqan3.git","ssh_url":"[email protected]:MitraDarja/seqan3.git","clone_url":"https://github.com/MitraDarja/seqan3.git","svn_url":"https://github.com/MitraDarja/seqan3","homepage":"http://www.seqan.de","size":1275,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"seqan:master","ref":"master","sha":"03969aaf54fecd06cfe3adb4a7e4b80725f32386","user":{"login":"seqan","id":1752144,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NTIxNDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1752144?v=4","gravatar_id":"","url":"https://api.github.com/users/seqan","html_url":"https://github.com/seqan","followers_url":"https://api.github.com/users/seqan/followers","following_url":"https://api.github.com/users/seqan/following{/other_user}","gists_url":"https://api.github.com/users/seqan/gists{/gist_id}","starred_url":"https://api.github.com/users/seqan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seqan/subscriptions","organizations_url":"https://api.github.com/users/seqan/orgs","repos_url":"https://api.github.com/users/seqan/repos","events_url":"https://api.github.com/users/seqan/events{/privacy}","received_events_url":"https://api.github.com/users/seqan/received_events","type":"Organization","site_admin":false},"repo":{"id":55410078,"node_id":"MDEwOlJlcG9zaXRvcnk1NTQxMDA3OA==","name":"seqan3","full_name":"seqan/seqan3","owner":{"login":"seqan","id":1752144,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NTIxNDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1752144?v=4","gravatar_id":"","url":"https://api.github.com/users/seqan","html_url":"https://github.com/seqan","followers_url":"https://api.github.com/users/seqan/followers","following_url":"https://api.github.com/users/seqan/following{/other_user}","gists_url":"https://api.github.com/users/seqan/gists{/gist_id}","starred_url":"https://api.github.com/users/seqan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seqan/subscriptions","organizations_url":"https://api.github.com/users/seqan/orgs","repos_url":"https://api.github.com/users/seqan/repos","events_url":"https://api.github.com/users/seqan/events{/privacy}","received_events_url":"https://api.github.com/users/seqan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/seqan/seqan3","description":"The modern C++ library for sequence analysis. Contains version 3 of the library and API docs.","fork":false,"url":"https://api.github.com/repos/seqan/seqan3","forks_url":"https://api.github.com/repos/seqan/seqan3/forks","keys_url":"https://api.github.com/repos/seqan/seqan3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seqan/seqan3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seqan/seqan3/teams","hooks_url":"https://api.github.com/repos/seqan/seqan3/hooks","issue_events_url":"https://api.github.com/repos/seqan/seqan3/issues/events{/number}","events_url":"https://api.github.com/repos/seqan/seqan3/events","assignees_url":"https://api.github.com/repos/seqan/seqan3/assignees{/user}","branches_url":"https://api.github.com/repos/seqan/seqan3/branches{/branch}","tags_url":"https://api.github.com/repos/seqan/seqan3/tags","blobs_url":"https://api.github.com/repos/seqan/seqan3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seqan/seqan3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seqan/seqan3/git/refs{/sha}","trees_url":"https://api.github.com/repos/seqan/seqan3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seqan/seqan3/statuses/{sha}","languages_url":"https://api.github.com/repos/seqan/seqan3/languages","stargazers_url":"https://api.github.com/repos/seqan/seqan3/stargazers","contributors_url":"https://api.github.com/repos/seqan/seqan3/contributors","subscribers_url":"https://api.github.com/repos/seqan/seqan3/subscribers","subscription_url":"https://api.github.com/repos/seqan/seqan3/subscription","commits_url":"https://api.github.com/repos/seqan/seqan3/commits{/sha}","git_commits_url":"https://api.github.com/repos/seqan/seqan3/git/commits{/sha}","comments_url":"https://api.github.com/repos/seqan/seqan3/comments{/number}","issue_comment_url":"https://api.github.com/repos/seqan/seqan3/issues/comments{/number}","contents_url":"https://api.github.com/repos/seqan/seqan3/contents/{+path}","compare_url":"https://api.github.com/repos/seqan/seqan3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seqan/seqan3/merges","archive_url":"https://api.github.com/repos/seqan/seqan3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seqan/seqan3/downloads","issues_url":"https://api.github.com/repos/seqan/seqan3/issues{/number}","pulls_url":"https://api.github.com/repos/seqan/seqan3/pulls{/number}","milestones_url":"https://api.github.com/repos/seqan/seqan3/milestones{/number}","notifications_url":"https://api.github.com/repos/seqan/seqan3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seqan/seqan3/labels{/name}","releases_url":"https://api.github.com/repos/seqan/seqan3/releases{/id}","deployments_url":"https://api.github.com/repos/seqan/seqan3/deployments","created_at":"2016-04-04T12:39:15Z","updated_at":"2018-08-15T15:09:09Z","pushed_at":"2018-08-15T15:09:05Z","git_url":"git://github.com/seqan/seqan3.git","ssh_url":"[email protected]:seqan/seqan3.git","clone_url":"https://github.com/seqan/seqan3.git","svn_url":"https://github.com/seqan/seqan3","homepage":"http://www.seqan.de","size":1211,"stargazers_count":31,"watchers_count":31,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":129,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":25,"open_issues":129,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/368"},"html":{"href":"https://github.com/seqan/seqan3/pull/368"},"issue":{"href":"https://api.github.com/repos/seqan/seqan3/issues/368"},"comments":{"href":"https://api.github.com/repos/seqan/seqan3/issues/368/comments"},"review_comments":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/368/comments"},"review_comment":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/368/commits"},"statuses":{"href":"https://api.github.com/repos/seqan/seqan3/statuses/d0a37acc55870d54629245b85c74c5225ea53cab"}},"author_association":"CONTRIBUTOR"}} | {
"id": 55410078,
"name": "seqan/seqan3",
"url": "https://api.github.com/repos/seqan/seqan3"
} | {
"id": 2996863,
"login": "h-2",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2996863?",
"url": "https://api.github.com/users/h-2"
} | {
"id": 1752144,
"login": "seqan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1752144?",
"url": "https://api.github.com/orgs/seqan"
} | 2018-08-15T15:18:18 | 8117663275 | {"actor":{"display_login":"h-2"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/pythonindia/inpycon2018/pulls/comments/192167671","pull_request_review_id":124891132,"id":192167671,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjE2NzY3MQ==","diff_hunk":"@@ -0,0 +1,172 @@\n+<!DOCTYPE html>\n+<html lang=\"en\">\n+\n+<head>\n+ <meta charset=\"utf-8\">\n+ <meta name=\"viewport\" content=\"width=device-width, initial-scale=1.0\">\n+ <meta name=\"description\" content=\"PyCon India, the premier conference in India on using and developing the Python programming language is conducted annually by the Python developer community and it attracts the best Python programmers from across the country and abroad.\">\n+ <meta name=\"author\" content=\"\">\n+ <title>PyCon India 2018 in Hyderabad | October 5th to 9th </title>\n+\n+ <!-- canonical URL -->\n+ <link rel=\"canonical\" href=\"https://in.pycon.org/2018/faq.html\">\n+\n+ <!-- Bootstrap Core CSS -->\n+ <link href=\"custom/css/bootstrap.min.css\" rel=\"stylesheet\" type=\"text/css\">\n+\n+ <!-- Global site tag (gtag.js) - Google Analytics -->\n+ <script async src=\"https://www.googletagmanager.com/gtag/js?id=UA-111617773-1\"></script>\n+ <script>\n+ window.dataLayer = window.dataLayer || [];\n+ function gtag(){dataLayer.push(arguments);}\n+ gtag('js', new Date());\n+\n+ gtag('config', 'UA-111617773-1');\n+ </script>\n+\n+\n+ <!-- Fonts -->\n+ <link href=\"font-awesome/css/font-awesome.min.css\" rel=\"stylesheet\" type=\"text/css\">\n+ <link href=\"custom/css/animate.css\" rel=\"stylesheet\" />\n+ <link href=\"custom/css/style.css\" rel=\"stylesheet\">\n+ <link href=\"custom/css/scroll.css\" rel=\"stylesheet\">\n+ <link href=\"custom/css/reset.css\" rel=\"stylesheet\">\n+ <link href=\"custom/css/default.css\" rel=\"stylesheet\">\n+ <link href=\"custom/css/buttons.css\" rel=\"stylesheet\">\n+ <link href=\"https://fonts.googleapis.com/css?family=Montserrat+Alternates:300,400,500,600\" rel=\"stylesheet\">\n+ <link href=\"https://fonts.googleapis.com/css?family=Roboto:300,400,500,700\" rel=\"stylesheet\">\n+</head>\n+\n+<body id=\"page-top\" data-spy=\"scroll\" data-target=\".navbar-custom\">\n+ <!-- Preloader -->\n+ <!-- <div id=\"preloader\">\n+ <div id=\"load\"></div>\n+ </div> -->\n+ <nav class=\"navbar navbar-custom navbar-fixed-top\" style=\"-webkit-box-shadow: 0 1px 30px rgba(0, 0, 0, .1);\">\n+ <div class=\"container\">\n+ <img src=\"img/banner-logo.png\" class=\"logo\" alt=\"banner-logo\" id=\"logo\" style=\"width: 150px;\">\n+ <div class=\"navbar-header\">\n+ <button type=\"button\" class=\"navbar-toggle collapsed\" data-toggle=\"collapse\" data-target=\"#bs-example-navbar-collapse-1\" aria-expanded=\"false\">\n+ <span class=\"sr-only\">Toggle navigation</span>\n+ <span class=\"icon-bar\"></span>\n+ <span class=\"icon-bar\"></span>\n+ <span class=\"icon-bar\"></span>\n+ </button>\n+ </div>\n+\n+ <div class=\"collapse navbar-collapse\" id=\"bs-example-navbar-collapse-1\">\n+ <ul class=\"nav nav-justified\">\n+ <li><a href=\"index.html#home\">Home</a></li>\n+ <li><a href=\"index.html#journey\">Journey</a></li>\n+ <li><a href=\"index.html#tickets\">Tickets</a></li>","path":"convince-my-boss.html","position":61,"original_position":61,"commit_id":"d459faaa6f77db515a160fbf5b402c6e4618dea9","original_commit_id":"d459faaa6f77db515a160fbf5b402c6e4618dea9","user":{"login":"ananyo2012","id":10486343,"node_id":"MDQ6VXNlcjEwNDg2MzQz","avatar_url":"https://avatars1.githubusercontent.com/u/10486343?v=4","gravatar_id":"","url":"https://api.github.com/users/ananyo2012","html_url":"https://github.com/ananyo2012","followers_url":"https://api.github.com/users/ananyo2012/followers","following_url":"https://api.github.com/users/ananyo2012/following{/other_user}","gists_url":"https://api.github.com/users/ananyo2012/gists{/gist_id}","starred_url":"https://api.github.com/users/ananyo2012/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ananyo2012/subscriptions","organizations_url":"https://api.github.com/users/ananyo2012/orgs","repos_url":"https://api.github.com/users/ananyo2012/repos","events_url":"https://api.github.com/users/ananyo2012/events{/privacy}","received_events_url":"https://api.github.com/users/ananyo2012/received_events","type":"User","site_admin":false},"body":"So I think we should create a dropdown in the tickets where we should add the link for convince the boss. Also can you add the dropdown in all of the pages to keep it consistent?","created_at":"2018-05-31T16:57:13Z","updated_at":"2018-05-31T16:57:13Z","html_url":"https://github.com/pythonindia/inpycon2018/pull/108#discussion_r192167671","pull_request_url":"https://api.github.com/repos/pythonindia/inpycon2018/pulls/108","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pythonindia/inpycon2018/pulls/comments/192167671"},"html":{"href":"https://github.com/pythonindia/inpycon2018/pull/108#discussion_r192167671"},"pull_request":{"href":"https://api.github.com/repos/pythonindia/inpycon2018/pulls/108"}}},"pull_request":{"url":"https://api.github.com/repos/pythonindia/inpycon2018/pulls/108","id":191733817,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNzMzODE3","html_url":"https://github.com/pythonindia/inpycon2018/pull/108","diff_url":"https://github.com/pythonindia/inpycon2018/pull/108.diff","patch_url":"https://github.com/pythonindia/inpycon2018/pull/108.patch","issue_url":"https://api.github.com/repos/pythonindia/inpycon2018/issues/108","number":108,"state":"open","locked":false,"title":"Add Convince my Boss page","user":{"login":"vipulgupta2048","id":22801822,"node_id":"MDQ6VXNlcjIyODAxODIy","avatar_url":"https://avatars0.githubusercontent.com/u/22801822?v=4","gravatar_id":"","url":"https://api.github.com/users/vipulgupta2048","html_url":"https://github.com/vipulgupta2048","followers_url":"https://api.github.com/users/vipulgupta2048/followers","following_url":"https://api.github.com/users/vipulgupta2048/following{/other_user}","gists_url":"https://api.github.com/users/vipulgupta2048/gists{/gist_id}","starred_url":"https://api.github.com/users/vipulgupta2048/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vipulgupta2048/subscriptions","organizations_url":"https://api.github.com/users/vipulgupta2048/orgs","repos_url":"https://api.github.com/users/vipulgupta2048/repos","events_url":"https://api.github.com/users/vipulgupta2048/events{/privacy}","received_events_url":"https://api.github.com/users/vipulgupta2048/received_events","type":"User","site_admin":false},"body":"- Made a new page for Convince for Boss content. \r\n\r\n**Roadblocks** \r\n1. The Navbar is not fixed as seen in other HTML pages, such as [FAQ](https://vipulgupta2048.github.io/inpycon2018/faq.html)\r\n2. This content needs to be linked. Hence the url would be www.in.pycon.org/convince-my-boss.html when PR is merged. I have taken the liberty of doing some myself. Like here - https://github.com/pythonindia/inpycon-blog/pull/144 \r\n\r\n**Preview**\r\nhttps://vipulgupta2048.github.io/inpycon2018/convince-my-boss.html\r\n@pythonindia/pycon-2018-team Please review. This is still WIP as links need to be added. ","created_at":"2018-05-31T12:10:21Z","updated_at":"2018-05-31T16:57:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb69b940e3e09d39e7f7e517ab6989759ac51ec2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pythonindia/inpycon2018/pulls/108/commits","review_comments_url":"https://api.github.com/repos/pythonindia/inpycon2018/pulls/108/comments","review_comment_url":"https://api.github.com/repos/pythonindia/inpycon2018/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pythonindia/inpycon2018/issues/108/comments","statuses_url":"https://api.github.com/repos/pythonindia/inpycon2018/statuses/d459faaa6f77db515a160fbf5b402c6e4618dea9","head":{"label":"vipulgupta2048:develop","ref":"develop","sha":"d459faaa6f77db515a160fbf5b402c6e4618dea9","user":{"login":"vipulgupta2048","id":22801822,"node_id":"MDQ6VXNlcjIyODAxODIy","avatar_url":"https://avatars0.githubusercontent.com/u/22801822?v=4","gravatar_id":"","url":"https://api.github.com/users/vipulgupta2048","html_url":"https://github.com/vipulgupta2048","followers_url":"https://api.github.com/users/vipulgupta2048/followers","following_url":"https://api.github.com/users/vipulgupta2048/following{/other_user}","gists_url":"https://api.github.com/users/vipulgupta2048/gists{/gist_id}","starred_url":"https://api.github.com/users/vipulgupta2048/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vipulgupta2048/subscriptions","organizations_url":"https://api.github.com/users/vipulgupta2048/orgs","repos_url":"https://api.github.com/users/vipulgupta2048/repos","events_url":"https://api.github.com/users/vipulgupta2048/events{/privacy}","received_events_url":"https://api.github.com/users/vipulgupta2048/received_events","type":"User","site_admin":false},"repo":{"id":129397414,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkzOTc0MTQ=","name":"inpycon2018","full_name":"vipulgupta2048/inpycon2018","owner":{"login":"vipulgupta2048","id":22801822,"node_id":"MDQ6VXNlcjIyODAxODIy","avatar_url":"https://avatars0.githubusercontent.com/u/22801822?v=4","gravatar_id":"","url":"https://api.github.com/users/vipulgupta2048","html_url":"https://github.com/vipulgupta2048","followers_url":"https://api.github.com/users/vipulgupta2048/followers","following_url":"https://api.github.com/users/vipulgupta2048/following{/other_user}","gists_url":"https://api.github.com/users/vipulgupta2048/gists{/gist_id}","starred_url":"https://api.github.com/users/vipulgupta2048/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vipulgupta2048/subscriptions","organizations_url":"https://api.github.com/users/vipulgupta2048/orgs","repos_url":"https://api.github.com/users/vipulgupta2048/repos","events_url":"https://api.github.com/users/vipulgupta2048/events{/privacy}","received_events_url":"https://api.github.com/users/vipulgupta2048/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vipulgupta2048/inpycon2018","description":"PyCon India 2018 site","fork":true,"url":"https://api.github.com/repos/vipulgupta2048/inpycon2018","forks_url":"https://api.github.com/repos/vipulgupta2048/inpycon2018/forks","keys_url":"https://api.github.com/repos/vipulgupta2048/inpycon2018/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vipulgupta2048/inpycon2018/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vipulgupta2048/inpycon2018/teams","hooks_url":"https://api.github.com/repos/vipulgupta2048/inpycon2018/hooks","issue_events_url":"https://api.github.com/repos/vipulgupta2048/inpycon2018/issues/events{/number}","events_url":"https://api.github.com/repos/vipulgupta2048/inpycon2018/events","assignees_url":"https://api.github.com/repos/vipulgupta2048/inpycon2018/assignees{/user}","branches_url":"https://api.github.com/repos/vipulgupta2048/inpycon2018/branches{/branch}","tags_url":"https://api.github.com/repos/vipulgupta2048/inpycon2018/tags","blobs_url":"https://api.github.com/repos/vipulgupta2048/inpycon2018/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vipulgupta2048/inpycon2018/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vipulgupta2048/inpycon2018/git/refs{/sha}","trees_url":"https://api.github.com/repos/vipulgupta2048/inpycon2018/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vipulgupta2048/inpycon2018/statuses/{sha}","languages_url":"https://api.github.com/repos/vipulgupta2048/inpycon2018/languages","stargazers_url":"https://api.github.com/repos/vipulgupta2048/inpycon2018/stargazers","contributors_url":"https://api.github.com/repos/vipulgupta2048/inpycon2018/contributors","subscribers_url":"https://api.github.com/repos/vipulgupta2048/inpycon2018/subscribers","subscription_url":"https://api.github.com/repos/vipulgupta2048/inpycon2018/subscription","commits_url":"https://api.github.com/repos/vipulgupta2048/inpycon2018/commits{/sha}","git_commits_url":"https://api.github.com/repos/vipulgupta2048/inpycon2018/git/commits{/sha}","comments_url":"https://api.github.com/repos/vipulgupta2048/inpycon2018/comments{/number}","issue_comment_url":"https://api.github.com/repos/vipulgupta2048/inpycon2018/issues/comments{/number}","contents_url":"https://api.github.com/repos/vipulgupta2048/inpycon2018/contents/{+path}","compare_url":"https://api.github.com/repos/vipulgupta2048/inpycon2018/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vipulgupta2048/inpycon2018/merges","archive_url":"https://api.github.com/repos/vipulgupta2048/inpycon2018/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vipulgupta2048/inpycon2018/downloads","issues_url":"https://api.github.com/repos/vipulgupta2048/inpycon2018/issues{/number}","pulls_url":"https://api.github.com/repos/vipulgupta2048/inpycon2018/pulls{/number}","milestones_url":"https://api.github.com/repos/vipulgupta2048/inpycon2018/milestones{/number}","notifications_url":"https://api.github.com/repos/vipulgupta2048/inpycon2018/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vipulgupta2048/inpycon2018/labels{/name}","releases_url":"https://api.github.com/repos/vipulgupta2048/inpycon2018/releases{/id}","deployments_url":"https://api.github.com/repos/vipulgupta2048/inpycon2018/deployments","created_at":"2018-04-13T12:11:59Z","updated_at":"2018-05-31T06:19:38Z","pushed_at":"2018-05-31T13:37:34Z","git_url":"git://github.com/vipulgupta2048/inpycon2018.git","ssh_url":"[email protected]:vipulgupta2048/inpycon2018.git","clone_url":"https://github.com/vipulgupta2048/inpycon2018.git","svn_url":"https://github.com/vipulgupta2048/inpycon2018","homepage":"https://in.pycon.org/2018/","size":7692,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pythonindia:master","ref":"master","sha":"231bf825ef5352d8a291e8d4a1bd1d13d1d39762","user":{"login":"pythonindia","id":1763047,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NjMwNDc=","avatar_url":"https://avatars1.githubusercontent.com/u/1763047?v=4","gravatar_id":"","url":"https://api.github.com/users/pythonindia","html_url":"https://github.com/pythonindia","followers_url":"https://api.github.com/users/pythonindia/followers","following_url":"https://api.github.com/users/pythonindia/following{/other_user}","gists_url":"https://api.github.com/users/pythonindia/gists{/gist_id}","starred_url":"https://api.github.com/users/pythonindia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pythonindia/subscriptions","organizations_url":"https://api.github.com/users/pythonindia/orgs","repos_url":"https://api.github.com/users/pythonindia/repos","events_url":"https://api.github.com/users/pythonindia/events{/privacy}","received_events_url":"https://api.github.com/users/pythonindia/received_events","type":"Organization","site_admin":false},"repo":{"id":111204820,"node_id":"MDEwOlJlcG9zaXRvcnkxMTEyMDQ4MjA=","name":"inpycon2018","full_name":"pythonindia/inpycon2018","owner":{"login":"pythonindia","id":1763047,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NjMwNDc=","avatar_url":"https://avatars1.githubusercontent.com/u/1763047?v=4","gravatar_id":"","url":"https://api.github.com/users/pythonindia","html_url":"https://github.com/pythonindia","followers_url":"https://api.github.com/users/pythonindia/followers","following_url":"https://api.github.com/users/pythonindia/following{/other_user}","gists_url":"https://api.github.com/users/pythonindia/gists{/gist_id}","starred_url":"https://api.github.com/users/pythonindia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pythonindia/subscriptions","organizations_url":"https://api.github.com/users/pythonindia/orgs","repos_url":"https://api.github.com/users/pythonindia/repos","events_url":"https://api.github.com/users/pythonindia/events{/privacy}","received_events_url":"https://api.github.com/users/pythonindia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pythonindia/inpycon2018","description":"PyCon India 2018 site","fork":false,"url":"https://api.github.com/repos/pythonindia/inpycon2018","forks_url":"https://api.github.com/repos/pythonindia/inpycon2018/forks","keys_url":"https://api.github.com/repos/pythonindia/inpycon2018/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pythonindia/inpycon2018/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pythonindia/inpycon2018/teams","hooks_url":"https://api.github.com/repos/pythonindia/inpycon2018/hooks","issue_events_url":"https://api.github.com/repos/pythonindia/inpycon2018/issues/events{/number}","events_url":"https://api.github.com/repos/pythonindia/inpycon2018/events","assignees_url":"https://api.github.com/repos/pythonindia/inpycon2018/assignees{/user}","branches_url":"https://api.github.com/repos/pythonindia/inpycon2018/branches{/branch}","tags_url":"https://api.github.com/repos/pythonindia/inpycon2018/tags","blobs_url":"https://api.github.com/repos/pythonindia/inpycon2018/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pythonindia/inpycon2018/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pythonindia/inpycon2018/git/refs{/sha}","trees_url":"https://api.github.com/repos/pythonindia/inpycon2018/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pythonindia/inpycon2018/statuses/{sha}","languages_url":"https://api.github.com/repos/pythonindia/inpycon2018/languages","stargazers_url":"https://api.github.com/repos/pythonindia/inpycon2018/stargazers","contributors_url":"https://api.github.com/repos/pythonindia/inpycon2018/contributors","subscribers_url":"https://api.github.com/repos/pythonindia/inpycon2018/subscribers","subscription_url":"https://api.github.com/repos/pythonindia/inpycon2018/subscription","commits_url":"https://api.github.com/repos/pythonindia/inpycon2018/commits{/sha}","git_commits_url":"https://api.github.com/repos/pythonindia/inpycon2018/git/commits{/sha}","comments_url":"https://api.github.com/repos/pythonindia/inpycon2018/comments{/number}","issue_comment_url":"https://api.github.com/repos/pythonindia/inpycon2018/issues/comments{/number}","contents_url":"https://api.github.com/repos/pythonindia/inpycon2018/contents/{+path}","compare_url":"https://api.github.com/repos/pythonindia/inpycon2018/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pythonindia/inpycon2018/merges","archive_url":"https://api.github.com/repos/pythonindia/inpycon2018/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pythonindia/inpycon2018/downloads","issues_url":"https://api.github.com/repos/pythonindia/inpycon2018/issues{/number}","pulls_url":"https://api.github.com/repos/pythonindia/inpycon2018/pulls{/number}","milestones_url":"https://api.github.com/repos/pythonindia/inpycon2018/milestones{/number}","notifications_url":"https://api.github.com/repos/pythonindia/inpycon2018/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pythonindia/inpycon2018/labels{/name}","releases_url":"https://api.github.com/repos/pythonindia/inpycon2018/releases{/id}","deployments_url":"https://api.github.com/repos/pythonindia/inpycon2018/deployments","created_at":"2017-11-18T12:44:28Z","updated_at":"2018-05-31T01:26:38Z","pushed_at":"2018-05-31T13:37:47Z","git_url":"git://github.com/pythonindia/inpycon2018.git","ssh_url":"[email protected]:pythonindia/inpycon2018.git","clone_url":"https://github.com/pythonindia/inpycon2018.git","svn_url":"https://github.com/pythonindia/inpycon2018","homepage":"https://in.pycon.org/2018/","size":7995,"stargazers_count":21,"watchers_count":21,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":35,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":35,"open_issues":18,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pythonindia/inpycon2018/pulls/108"},"html":{"href":"https://github.com/pythonindia/inpycon2018/pull/108"},"issue":{"href":"https://api.github.com/repos/pythonindia/inpycon2018/issues/108"},"comments":{"href":"https://api.github.com/repos/pythonindia/inpycon2018/issues/108/comments"},"review_comments":{"href":"https://api.github.com/repos/pythonindia/inpycon2018/pulls/108/comments"},"review_comment":{"href":"https://api.github.com/repos/pythonindia/inpycon2018/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pythonindia/inpycon2018/pulls/108/commits"},"statuses":{"href":"https://api.github.com/repos/pythonindia/inpycon2018/statuses/d459faaa6f77db515a160fbf5b402c6e4618dea9"}},"author_association":"MEMBER"}} | {
"id": 111204820,
"name": "pythonindia/inpycon2018",
"url": "https://api.github.com/repos/pythonindia/inpycon2018"
} | {
"id": 10486343,
"login": "ananyo2012",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10486343?",
"url": "https://api.github.com/users/ananyo2012"
} | {
"id": 1763047,
"login": "pythonindia",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1763047?",
"url": "https://api.github.com/orgs/pythonindia"
} | 2018-05-31T16:57:13 | 7757640839 | {"actor":{"display_login":"ananyo2012"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/elifesciences/elife-xpub/pulls/comments/227732925","pull_request_review_id":167823604,"id":227732925,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzczMjkyNQ==","diff_hunk":"@@ -0,0 +1,434 @@\n+import React from 'react'\n+import { H1, H2 } from '@pubsweet/ui'\n+\n+import Paragraph from '../../ui/atoms/Paragraph'\n+import ExternalLink from '../../ui/atoms/ExternalLink'\n+import List from '../../ui/atoms/List'\n+\n+const Full = props => (\n+ <React.Fragment>\n+ <H1>Full Submissions</H1>\n+\n+ <Paragraph>\n+ If an author is invited to submit a Full Submission, they will receive a\n+ link to the article submission system, which will take them to a page\n+ incorporating existing information about their Initial Submission. The\n+ corresponding author is then required to build on the existing information\n+ to support the peer-review process. Once the full submission is complete,\n+ all co-authors will be contacted to verify their authorship, contribution,\n+ and competing interest statements. Please note that Research Advances\n+ bypass the Initial Submission step.\n+ </Paragraph>\n+\n+ <H2>Submission Files</H2>\n+\n+ <Paragraph>\n+ At this point, authors can either upload another single PDF of their\n+ manuscript (with the text and figures combined), or they can upload the\n+ source files separately if they prefer.\n+ </Paragraph>\n+\n+ <Paragraph>\n+ Either way, authors are strongly encouraged to think creatively about the\n+ presentation of their work, to take advantage of the flexibility and file\n+ formats eLife offers, and to keep the article as concise as possible. To\n+ assist the review process, please organise and format the manuscript so\n+ that it is easily readable. Please include page and line numbers, double\n+ spacing, and a legible font size for the main text and figure legends.\n+ </Paragraph>\n+\n+ <Paragraph>\n+ Regarding the use of supplementary data, our vision is presented in{' '}\n+ <ExternalLink\n+ href=\"https://elifesciences.org/inside-elife/6f32c567/supplementary-data\"\n+ target=\"_blank\"\n+ >\n+ this blog post\n+ </ExternalLink>\n+ . In short, we strive to make supplementary data, if applicable, easily\n+ searchable, discoverable, and citable, and made available in the most\n+ useful format for reuse.\n+ </Paragraph>\n+\n+ <List.Ordered>\n+ <li>\n+ <strong>eLife Transparent Reporting Form: </strong>\n+ <Paragraph>\n+ To facilitate the interpretation and replication of experiments,\n+ authors should, where appropriate, provide detailed information in\n+ areas relating to sample-size estimation, replicates, and statistical\n+ reporting. At the Full Submission step, authors should be ready to\n+ upload a completed version of this form (\n+ <ExternalLink\n+ href=\"https://submit.elifesciences.org/html/transparent_reporting.pdf\"\n+ target=\"_blank\"\n+ >\n+ PDF\n+ </ExternalLink>\n+ ;{' '}\n+ <ExternalLink\n+ href=\"https://submit.elifesciences.org/html/transparent_reporting.docx\"\n+ target=\"_blank\"\n+ >\n+ Word\n+ </ExternalLink>\n+ ), which should describe the places within the submission where this\n+ information has been included.\n+ </Paragraph>\n+ <Paragraph>\n+ Please note that we publish the completed Transparent Reporting Form\n+ for submissions accepted for publication. This will be available to\n+ download as a supplementary file in the format provided by the\n+ authors.\n+ </Paragraph>\n+ </li>\n+\n+ <li>\n+ <strong>Figures and Figure Supplements: </strong>\n+ <Paragraph>\n+ eLife does not have space or printing constraints, so any number of\n+ colour figures can be included within Research Articles, although we\n+ urge authors to present their results as concisely as possible. Short\n+ Reports should not contain more than three or four display items. We\n+ also recognise that some figures are more central to the narrative of\n+ the paper than others, and so we therefore support ‘child’ figures\n+ (examples of which can be found in{' '}\n+ <ExternalLink\n+ href=\"http://elifesciences.org/content/1/e00181#F3\"\n+ traget=\"_blank\"\n+ >\n+ eLife 2012;1:e00181\n+ </ExternalLink>\n+ ). These "Figure Supplements" must be linked to one of the\n+ primary figures: they can, for example, provide additional examples of\n+ analyses or data shown in a primary figure.\n+ </Paragraph>\n+ <Paragraph />\n+ <Paragraph>\n+ There is no limit on the number of Figure Supplements for any one\n+ primary figure. Each figure supplement should be clearly labelled,\n+ Figure 1–figure supplement 1, Figure 1–figure supplement 2, Figure\n+ 2–figure supplement 1 and so on, and have a short title (and optional\n+ legend). Figure Supplements should be referred to in the legend of the\n+ associated primary figure, and should also be listed at the end of the\n+ article text file.\n+ </Paragraph>\n+ <Paragraph>\n+ Authors should provide information about data processing and analysis\n+ in their figure legends, including any statistical tests applied, with\n+ exact sample number, p values of tests, criteria for data inclusion or\n+ exclusion, and details of replicates. In some cases, it might be\n+ unwieldy to have this information in the legend of a figure, in which\n+ case the information can be provided in a source data file – see\n+ below.\n+ </Paragraph>\n+ <Paragraph>\n+ Although we understand that authors sometimes need to provide\n+ composite figures as main figures, we urge authors not to make such\n+ figures (and their legends) too large to avoid the figure and its\n+ legend extending beyond one page in the PDF. We also encourage authors\n+ to avoid composite figure supplements wherever possible.\n+ </Paragraph>\n+ <Paragraph>\n+ When preparing figures, we recommend that authors follow the\n+ principles of{' '}\n+ <ExternalLink\n+ href=\"http://jfly.iam.u-tokyo.ac.jp/color/\"\n+ target=\"_blank\"\n+ >\n+ Colour Universal Design\n+ </ExternalLink>{' '}\n+ (Masataka, Okabe and Kei Ito, J*Fly), whereby colour schemes are\n+ chosen to ensure maximum accessibility for all types of colour vision.\n+ </Paragraph>\n+ <Paragraph>\n+ Figures can be uploaded individually in the following formats: TIFF,\n+ GIF, JPG, EPS, AI, PDF and Corel Draw. If you would like to supply PDF\n+ images please ensure that they are saved in a Vector image format.\n+ </Paragraph>\n+ </li>\n+\n+ <li>\n+ <strong>Source Data Files, for Figures and Tables: </strong>\n+ <Paragraph>\n+ eLife encourages authors to provide Source Data files, for example,\n+ for figures such as histograms or tables showing summary data (as\n+ shown in{' '}\n+ <ExternalLink\n+ href=\"http://elifesciences.org/content/1/e00109/#DC1\"\n+ target=\"_blank\"\n+ >\n+ eLife 2012;1:e00109\n+ </ExternalLink>\n+ ). Each Source data file should relate directly to a single figure or\n+ table, whereas major datasets generated in the course of the work\n+ should be deposited externally, as explained below. Each source data\n+ file should be clearly labelled, 'Figure 1–Source Data 1',\n+ 'Table 1–Source Data 1' and so on, and have a short title\n+ (and optional legend). Source data files should be referred to in the\n+ relevant figure legend or table footnote, and they should also be\n+ listed at the end of the article text file.\n+ </Paragraph>\n+ <Paragraph>\n+ In addition, authors should provide information about data processing\n+ and analysis, including any statistical tests applied, with exact\n+ sample number, p values of tests, criteria for data inclusion or\n+ exclusion, and details of replicates. In some cases, it might be\n+ unwieldy to have this information in the legend of a figure, in which\n+ case the information should be provided along with the source data\n+ file.\n+ </Paragraph>\n+ </li>\n+\n+ <li>\n+ <strong>Rich Media Files: </strong>\n+ <Paragraph>\n+ Rich media files encompass forms of presentation that go beyond static\n+ presentation: for example, videos, audio clips, animations,\n+ slideshows, and interactive diagrams. Rich media files should be\n+ supplied as AVI, WMV, MOV, MP4, or H264. Where an audio track is\n+ present, we recommend a sampling rate of 44100, 22050, or 11025 Hz to\n+ avoid encoding and quality issues. Each file should be accompanied by\n+ a concise title/legend at the end of the article file. If the article\n+ is published, videos are embedded within the main body of the article\n+ (they are not presented as supplementary files) with the same status\n+ as primary figures (as shown in{' '}\n+ <ExternalLink\n+ href=\"http://elifesciences.org/content/1/e00007#media-1\"\n+ target=\"_blank\"\n+ >\n+ eLife 2012;1:e00007\n+ </ExternalLink>\n+ ).\n+ </Paragraph>\n+ <Paragraph>\n+ eLife supports JMOL, a Java viewer for three-dimensional chemical\n+ structures, and we encourage authors to provide{' '}\n+ <ExternalLink\n+ href=\"http://wiki.jmol.org/index.php/File_formats/Coordinates\"\n+ target=\"_blank\"\n+ >\n+ compatible files\n+ </ExternalLink>\n+ .\n+ </Paragraph>\n+ </li>\n+\n+ <li>\n+ <strong>Source Code: </strong>\n+ <Paragraph>\n+ Relevant software or source code should be deposited in an open\n+ software archive. Where appropriate, authors can upload source code\n+ files to the submission system (for example, MATLAB, R, Python, C,\n+ C++, Java). Any code provided should be properly documented, in line\n+ with{' '}\n+ <ExternalLink\n+ href=\"http://journals.plos.org/ploscompbiol/s/materials-and-software-sharing#loc-sharing-software\"\n+ target=\"_blank\"\n+ >\n+ these instructions\n+ </ExternalLink>{' '}\n+ (courtesy of PLOS). Please also refer to our{' '}\n+ <ExternalLink href=\"/author-guide/journal-policies\">\n+ Software sharing policy\n+ </ExternalLink>\n+ .\n+ </Paragraph>\n+ </li>\n+\n+ <li>\n+ <strong>Reporting Standards Documents: </strong>\n+ <Paragraph>\n+ eLife encourages authors to upload any relevant reporting standards\n+ documents.\n+ </Paragraph>\n+ </li>\n+\n+ <li>\n+ <strong>Supplementary Files: </strong>\n+ <Paragraph>\n+ Authors are discouraged from uploading large PDFs of data and/or text\n+ as supplementary files for the reasons explained above. However,\n+ information not central to the narrative, that falls outside of the\n+ other formats specified above, such as long lists of strains or\n+ plasmids, are welcome as supplementary files, provided they are\n+ uploaded in the most useful format. Supplementary files, if provided,\n+ should be labelled as Supplementary File 1, Supplementary File 2 and\n+ so on, and have a title (and optional legend). Supplementary files\n+ should be listed at the end of the article file.\n+ </Paragraph>\n+ </li>\n+\n+ <li>\n+ <strong>Related Manuscripts: </strong>\n+ <Paragraph>\n+ Any related manuscripts should be described in the cover letter and\n+ uploaded using the Related Manuscript file type.\n+ </Paragraph>\n+ </li>\n+ </List.Ordered>\n+\n+ <H2>Submission Metadata</H2>\n+\n+ <Paragraph>\n+ The Full Submission requires additional information about the article and\n+ all authors. This allows eLife to propagate published content to a wide\n+ range of resources and indexes, so that accepted articles are widely\n+ discoverable and can be used by the broadest possible audience. During the\n+ full submission process, the corresponding author will also be asked to\n+ link their existing ORCID record to their eLife profile, or create an\n+ ORCID record, if he or she does not already have one. An ORCID iD is a\n+ unique and persistent digital identifier that distinguishes you from other\n+ researchers and reliably connects you with your research contributions and\n+ affiliations, to help ensure that your work is properly attributed and\n+ credited (\n+ <ExternalLink\n+ href=\"https://elifesciences.org/inside-elife/e2bf15ca/publishers-to-require-orcid-identifiers-for-authors\"\n+ target=\"_blank\"\n+ >\n+ learn more\n+ </ExternalLink>\n+ ).\n+ </Paragraph>\n+\n+ <List.Ordered>\n+ <li>\n+ <strong>Impact Statement: </strong>\n+ <Paragraph>\n+ The impact statement is single sentence (typically 15-30 words) that\n+ summarises the most important finding of the work: it needs to\n+ complement (rather than repeat) the title, and should avoid acronyms\n+ that are not well known to a broad readership. It also needs to be\n+ written in third-person (i.e., it should not use “we” or “our”).\n+ </Paragraph>\n+ </li>\n+\n+ <li>\n+ <strong>Complete Author Information: </strong>\n+ <Paragraph>\n+ Co-author details should be entered: in addition to the full author\n+ name and affiliation (department, institution, city, and country), a\n+ competing interests statement is required for each author. All\n+ financial and non-financial competing interests that could reasonably\n+ be perceived to be relevant to the work should be declared.\n+ </Paragraph>\n+ <Paragraph>\n+ Information about individual author contributions should be provided\n+ using the Contributor Roles Taxonomy: Conceptualization; Methodology;\n+ Software; Validation; Formal analysis; Investigation; Resources; Data\n+ curation; Writing – original draft preparation; Writing – review &\n+ editing; Visualization; Supervision; Project administration; Funding\n+ acquisition (\n+ <ExternalLink\n+ href=\"https://elifesciences.org/inside-elife/f39cfcf5/enabling-the-contributor-roles-taxonomy-for-author-contributions?_ga=2.172472675.1994204094.1499675694-1424042520.1478607646\"\n+ target=\"_blank\"\n+ >\n+ read more\n+ </ExternalLink>\n+ ).\n+ </Paragraph>\n+ <Paragraph>\n+ During the Full Submission process, an email is sent to all authors to\n+ confirm that they approve of the submission of the manuscript, its\n+ content, authorship, and the order of authorship. It is also possible\n+ to indicate joint first authorship during the submission process.\n+ </Paragraph>\n+ <Paragraph>\n+ If one or more author groups or consortia are indicated as authors, to\n+ ensure that individual collaborators are searchable on resources such\n+ as PubMed, please provide the list of collaborators in an Excel file\n+ (uploaded as file type Collaborators). Please ensure given names and\n+ surnames are listed in separate columns per collaborator. They will be\n+ listed under the acknowledgements on publication.\n+ </Paragraph>\n+ </li>\n+\n+ <li>\n+ <strong>Funding: </strong>\n+ <Paragraph>\n+ In addition to a list of the sources of funding, authors are also\n+ expected to provide the relevant grant numbers, where possible, and\n+ list the authors associated with the specific funding sources. Please\n+ do not include information about direct funding in the\n+ acknowledgements to avoid duplication.\n+ </Paragraph>\n+ <Paragraph>\n+ Authors are also required to state whether the funding sources were\n+ involved in study design, data collection and interpretation, or the\n+ decision to submit the work for publication.\n+ </Paragraph>\n+ </li>\n+\n+ <li>\n+ <strong>Datasets: </strong>\n+ <Paragraph>\n+ All datasets used in a publication should be cited in the text and\n+ listed in the reference section and/or data availability statement.\n+ References for data sets and program code should include a persistent\n+ identifier, for example a Digital Object Identifier (DOI) or accession\n+ number.\n+ </Paragraph>\n+ <Paragraph>\n+ In the submission form, authors should provide the following\n+ information about newly generated and previously published datasets in\n+ the following format: Author(s), Year, Dataset Title, Dataset ID\n+ and/or URL, Database, License and Accessibility Information. This\n+ information will be used to create a list of the relevant major\n+ datasets in the published article (such as{' '}\n+ <ExternalLink\n+ href=\"http://elifesciences.org/content/1/e00070/article-data\"\n+ target=\"_blank\"\n+ >\n+ eLife 2012;1:e00070\n+ </ExternalLink>\n+ ), to indicate their location along with unique identifiers, and\n+ licensing information – or any other factors – affecting access to or\n+ reuse of the datasets. For newly generated datasets, we encourage the\n+ use of the Creative Commons{' '}\n+ <ExternalLink\n+ href=\"https://creativecommons.org/publicdomain/zero/1.0/\"\n+ target=\"_blank\"\n+ >\n+ CC0 public domain dedication\n+ </ExternalLink>\n+ .\n+ </Paragraph>\n+ <Paragraph>\n+ Where appropriate, data analysis tools should also be made available\n+ to assist interested researchers in the manipulation and use of the\n+ data.\n+ </Paragraph>\n+ </li>\n+\n+ <li>\n+ <strong>\n+ Ethics Statement for Human Subjects Research or Animal\n+ Experimentation:{' '}\n+ </strong>\n+ <Paragraph>\n+ Authors are required to provide an ethics statement during submission\n+ to indicate the institutional review board or ethics committee that\n+ has approved the study and/or the guidelines that have been followed.\n+ </Paragraph>\n+ </li>\n+\n+ <li>\n+ <strong>Editor and Reviewer Suggestions/Exclusions: </strong>\n+ <Paragraph>\n+ We request that authors provide suggestions for at least four\n+ potential reviewers of the work. To encourage diversity, please\n+ consider specifically suggesting reviewers at an early stage of their\n+ career, women, and experts from places other than USA and Europe.\n+ Please do not list colleagues who are close associates, collaborators,\n+ or family members. Authors may also provide the names of reviewers or\n+ editors who they would prefer to exclude from the assessment of the\n+ article. We will make every effort to follow author requests for\n+ excluded individuals unless the editors judge that such exclusion\n+ would interfere with the rigorous assessment of the work.\n+ </Paragraph>\n+ </li>\n+ </List.Ordered>","path":"app/components/pages/AuthorGuide/Full.js","position":430,"original_position":430,"commit_id":"69b981364934fbca7c57e16c22e26a1c3504f0f7","original_commit_id":"69b981364934fbca7c57e16c22e26a1c3504f0f7","user":{"login":"tamlyn","id":115310,"node_id":"MDQ6VXNlcjExNTMxMA==","avatar_url":"https://avatars2.githubusercontent.com/u/115310?v=4","gravatar_id":"","url":"https://api.github.com/users/tamlyn","html_url":"https://github.com/tamlyn","followers_url":"https://api.github.com/users/tamlyn/followers","following_url":"https://api.github.com/users/tamlyn/following{/other_user}","gists_url":"https://api.github.com/users/tamlyn/gists{/gist_id}","starred_url":"https://api.github.com/users/tamlyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamlyn/subscriptions","organizations_url":"https://api.github.com/users/tamlyn/orgs","repos_url":"https://api.github.com/users/tamlyn/repos","events_url":"https://api.github.com/users/tamlyn/events{/privacy}","received_events_url":"https://api.github.com/users/tamlyn/received_events","type":"User","site_admin":false},"body":"Missing final paragraph:\r\n> If your Full Submission has been peer reviewed and you have been asked to make revisions, please review our guidelines for Revised Submissions.","created_at":"2018-10-24T10:32:59Z","updated_at":"2018-10-24T10:51:25Z","html_url":"https://github.com/elifesciences/elife-xpub/pull/849#discussion_r227732925","pull_request_url":"https://api.github.com/repos/elifesciences/elife-xpub/pulls/849","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/elifesciences/elife-xpub/pulls/comments/227732925"},"html":{"href":"https://github.com/elifesciences/elife-xpub/pull/849#discussion_r227732925"},"pull_request":{"href":"https://api.github.com/repos/elifesciences/elife-xpub/pulls/849"}}},"pull_request":{"url":"https://api.github.com/repos/elifesciences/elife-xpub/pulls/849","id":224641173,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NjQxMTcz","html_url":"https://github.com/elifesciences/elife-xpub/pull/849","diff_url":"https://github.com/elifesciences/elife-xpub/pull/849.diff","patch_url":"https://github.com/elifesciences/elife-xpub/pull/849.patch","issue_url":"https://api.github.com/repos/elifesciences/elife-xpub/issues/849","number":849,"state":"open","locked":false,"title":"simple static content components","user":{"login":"jsms90","id":15656538,"node_id":"MDQ6VXNlcjE1NjU2NTM4","avatar_url":"https://avatars2.githubusercontent.com/u/15656538?v=4","gravatar_id":"","url":"https://api.github.com/users/jsms90","html_url":"https://github.com/jsms90","followers_url":"https://api.github.com/users/jsms90/followers","following_url":"https://api.github.com/users/jsms90/following{/other_user}","gists_url":"https://api.github.com/users/jsms90/gists{/gist_id}","starred_url":"https://api.github.com/users/jsms90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsms90/subscriptions","organizations_url":"https://api.github.com/users/jsms90/orgs","repos_url":"https://api.github.com/users/jsms90/repos","events_url":"https://api.github.com/users/jsms90/events{/privacy}","received_events_url":"https://api.github.com/users/jsms90/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\n- Creates content components listed in issue #832 - i.e. those under the \"Author Guide\", \"Reviewer Guide\" & \"Contact Us\" headings, which do not require any more sub-components to be built\r\n- Removes underlining from our internal links (`Link` from pubsweet), so they look the same as our external links\r\n- Adds correct font to list items\r\n- Add change margin to padding on all headings (H1, H2, etc) so that they align to the 24px baseline grid (see [typography page in Zeplin](https://app.zeplin.io/project/5bacf042615a8b6e20e84a5f/screen/5bc0cddca55ed15fd3fb3973))\r\n- Add margin-bottom to `Paragraph` & `SmallParagraph` (except when they're the last child), so we have `24px` between elements\r\n\r\nPlease be aware:\r\n- Internal application links will not lead anywhere until #505 is complete & I anticipate potential issues with the internal page link to the FAQ section - see this issue on `react-router-dom`: https://github.com/ReactTraining/react-router/issues/394\r\n\r\n#### Any relevant tickets\r\nfixes #832 \r\nrelates #840 \r\n\r\n#### How has this been tested?\r\nVisually","created_at":"2018-10-22T10:32:38Z","updated_at":"2018-10-24T10:51:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4e6071e2a6c387da3a1160ef96a1eb741e877a1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Cooryd","id":22455561,"node_id":"MDQ6VXNlcjIyNDU1NTYx","avatar_url":"https://avatars1.githubusercontent.com/u/22455561?v=4","gravatar_id":"","url":"https://api.github.com/users/Cooryd","html_url":"https://github.com/Cooryd","followers_url":"https://api.github.com/users/Cooryd/followers","following_url":"https://api.github.com/users/Cooryd/following{/other_user}","gists_url":"https://api.github.com/users/Cooryd/gists{/gist_id}","starred_url":"https://api.github.com/users/Cooryd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cooryd/subscriptions","organizations_url":"https://api.github.com/users/Cooryd/orgs","repos_url":"https://api.github.com/users/Cooryd/repos","events_url":"https://api.github.com/users/Cooryd/events{/privacy}","received_events_url":"https://api.github.com/users/Cooryd/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/elifesciences/elife-xpub/pulls/849/commits","review_comments_url":"https://api.github.com/repos/elifesciences/elife-xpub/pulls/849/comments","review_comment_url":"https://api.github.com/repos/elifesciences/elife-xpub/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elifesciences/elife-xpub/issues/849/comments","statuses_url":"https://api.github.com/repos/elifesciences/elife-xpub/statuses/69b981364934fbca7c57e16c22e26a1c3504f0f7","head":{"label":"elifesciences:simple-static-content-components","ref":"simple-static-content-components","sha":"69b981364934fbca7c57e16c22e26a1c3504f0f7","user":{"login":"elifesciences","id":1777367,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzczNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1777367?v=4","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"repo":{"id":100492246,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA0OTIyNDY=","name":"elife-xpub","full_name":"elifesciences/elife-xpub","private":false,"owner":{"login":"elifesciences","id":1777367,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzczNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1777367?v=4","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elifesciences/elife-xpub","description":"eLife is an open-access journal and technology provider that publishes promising research in the life and biomedical sciences. This is their implementation of a submission and peer review system based on Coko PubSweet and xPub.","fork":false,"url":"https://api.github.com/repos/elifesciences/elife-xpub","forks_url":"https://api.github.com/repos/elifesciences/elife-xpub/forks","keys_url":"https://api.github.com/repos/elifesciences/elife-xpub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elifesciences/elife-xpub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elifesciences/elife-xpub/teams","hooks_url":"https://api.github.com/repos/elifesciences/elife-xpub/hooks","issue_events_url":"https://api.github.com/repos/elifesciences/elife-xpub/issues/events{/number}","events_url":"https://api.github.com/repos/elifesciences/elife-xpub/events","assignees_url":"https://api.github.com/repos/elifesciences/elife-xpub/assignees{/user}","branches_url":"https://api.github.com/repos/elifesciences/elife-xpub/branches{/branch}","tags_url":"https://api.github.com/repos/elifesciences/elife-xpub/tags","blobs_url":"https://api.github.com/repos/elifesciences/elife-xpub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elifesciences/elife-xpub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elifesciences/elife-xpub/git/refs{/sha}","trees_url":"https://api.github.com/repos/elifesciences/elife-xpub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elifesciences/elife-xpub/statuses/{sha}","languages_url":"https://api.github.com/repos/elifesciences/elife-xpub/languages","stargazers_url":"https://api.github.com/repos/elifesciences/elife-xpub/stargazers","contributors_url":"https://api.github.com/repos/elifesciences/elife-xpub/contributors","subscribers_url":"https://api.github.com/repos/elifesciences/elife-xpub/subscribers","subscription_url":"https://api.github.com/repos/elifesciences/elife-xpub/subscription","commits_url":"https://api.github.com/repos/elifesciences/elife-xpub/commits{/sha}","git_commits_url":"https://api.github.com/repos/elifesciences/elife-xpub/git/commits{/sha}","comments_url":"https://api.github.com/repos/elifesciences/elife-xpub/comments{/number}","issue_comment_url":"https://api.github.com/repos/elifesciences/elife-xpub/issues/comments{/number}","contents_url":"https://api.github.com/repos/elifesciences/elife-xpub/contents/{+path}","compare_url":"https://api.github.com/repos/elifesciences/elife-xpub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elifesciences/elife-xpub/merges","archive_url":"https://api.github.com/repos/elifesciences/elife-xpub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elifesciences/elife-xpub/downloads","issues_url":"https://api.github.com/repos/elifesciences/elife-xpub/issues{/number}","pulls_url":"https://api.github.com/repos/elifesciences/elife-xpub/pulls{/number}","milestones_url":"https://api.github.com/repos/elifesciences/elife-xpub/milestones{/number}","notifications_url":"https://api.github.com/repos/elifesciences/elife-xpub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elifesciences/elife-xpub/labels{/name}","releases_url":"https://api.github.com/repos/elifesciences/elife-xpub/releases{/id}","deployments_url":"https://api.github.com/repos/elifesciences/elife-xpub/deployments","created_at":"2017-08-16T13:26:53Z","updated_at":"2018-10-24T09:50:28Z","pushed_at":"2018-10-24T10:23:48Z","git_url":"git://github.com/elifesciences/elife-xpub.git","ssh_url":"[email protected]:elifesciences/elife-xpub.git","clone_url":"https://github.com/elifesciences/elife-xpub.git","svn_url":"https://github.com/elifesciences/elife-xpub","homepage":"https://elifesciences.org/","size":5608,"stargazers_count":15,"watchers_count":15,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":179,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":179,"watchers":15,"default_branch":"develop"}},"base":{"label":"elifesciences:develop","ref":"develop","sha":"cf26178c761f2ed0be5b70ca19b342e94946924c","user":{"login":"elifesciences","id":1777367,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzczNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1777367?v=4","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"repo":{"id":100492246,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA0OTIyNDY=","name":"elife-xpub","full_name":"elifesciences/elife-xpub","private":false,"owner":{"login":"elifesciences","id":1777367,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzczNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1777367?v=4","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elifesciences/elife-xpub","description":"eLife is an open-access journal and technology provider that publishes promising research in the life and biomedical sciences. This is their implementation of a submission and peer review system based on Coko PubSweet and xPub.","fork":false,"url":"https://api.github.com/repos/elifesciences/elife-xpub","forks_url":"https://api.github.com/repos/elifesciences/elife-xpub/forks","keys_url":"https://api.github.com/repos/elifesciences/elife-xpub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elifesciences/elife-xpub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elifesciences/elife-xpub/teams","hooks_url":"https://api.github.com/repos/elifesciences/elife-xpub/hooks","issue_events_url":"https://api.github.com/repos/elifesciences/elife-xpub/issues/events{/number}","events_url":"https://api.github.com/repos/elifesciences/elife-xpub/events","assignees_url":"https://api.github.com/repos/elifesciences/elife-xpub/assignees{/user}","branches_url":"https://api.github.com/repos/elifesciences/elife-xpub/branches{/branch}","tags_url":"https://api.github.com/repos/elifesciences/elife-xpub/tags","blobs_url":"https://api.github.com/repos/elifesciences/elife-xpub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elifesciences/elife-xpub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elifesciences/elife-xpub/git/refs{/sha}","trees_url":"https://api.github.com/repos/elifesciences/elife-xpub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elifesciences/elife-xpub/statuses/{sha}","languages_url":"https://api.github.com/repos/elifesciences/elife-xpub/languages","stargazers_url":"https://api.github.com/repos/elifesciences/elife-xpub/stargazers","contributors_url":"https://api.github.com/repos/elifesciences/elife-xpub/contributors","subscribers_url":"https://api.github.com/repos/elifesciences/elife-xpub/subscribers","subscription_url":"https://api.github.com/repos/elifesciences/elife-xpub/subscription","commits_url":"https://api.github.com/repos/elifesciences/elife-xpub/commits{/sha}","git_commits_url":"https://api.github.com/repos/elifesciences/elife-xpub/git/commits{/sha}","comments_url":"https://api.github.com/repos/elifesciences/elife-xpub/comments{/number}","issue_comment_url":"https://api.github.com/repos/elifesciences/elife-xpub/issues/comments{/number}","contents_url":"https://api.github.com/repos/elifesciences/elife-xpub/contents/{+path}","compare_url":"https://api.github.com/repos/elifesciences/elife-xpub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elifesciences/elife-xpub/merges","archive_url":"https://api.github.com/repos/elifesciences/elife-xpub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elifesciences/elife-xpub/downloads","issues_url":"https://api.github.com/repos/elifesciences/elife-xpub/issues{/number}","pulls_url":"https://api.github.com/repos/elifesciences/elife-xpub/pulls{/number}","milestones_url":"https://api.github.com/repos/elifesciences/elife-xpub/milestones{/number}","notifications_url":"https://api.github.com/repos/elifesciences/elife-xpub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elifesciences/elife-xpub/labels{/name}","releases_url":"https://api.github.com/repos/elifesciences/elife-xpub/releases{/id}","deployments_url":"https://api.github.com/repos/elifesciences/elife-xpub/deployments","created_at":"2017-08-16T13:26:53Z","updated_at":"2018-10-24T09:50:28Z","pushed_at":"2018-10-24T10:23:48Z","git_url":"git://github.com/elifesciences/elife-xpub.git","ssh_url":"[email protected]:elifesciences/elife-xpub.git","clone_url":"https://github.com/elifesciences/elife-xpub.git","svn_url":"https://github.com/elifesciences/elife-xpub","homepage":"https://elifesciences.org/","size":5608,"stargazers_count":15,"watchers_count":15,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":179,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":179,"watchers":15,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/elifesciences/elife-xpub/pulls/849"},"html":{"href":"https://github.com/elifesciences/elife-xpub/pull/849"},"issue":{"href":"https://api.github.com/repos/elifesciences/elife-xpub/issues/849"},"comments":{"href":"https://api.github.com/repos/elifesciences/elife-xpub/issues/849/comments"},"review_comments":{"href":"https://api.github.com/repos/elifesciences/elife-xpub/pulls/849/comments"},"review_comment":{"href":"https://api.github.com/repos/elifesciences/elife-xpub/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elifesciences/elife-xpub/pulls/849/commits"},"statuses":{"href":"https://api.github.com/repos/elifesciences/elife-xpub/statuses/69b981364934fbca7c57e16c22e26a1c3504f0f7"}},"author_association":"CONTRIBUTOR"}} | {
"id": 100492246,
"name": "elifesciences/elife-xpub",
"url": "https://api.github.com/repos/elifesciences/elife-xpub"
} | {
"id": 115310,
"login": "tamlyn",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/115310?",
"url": "https://api.github.com/users/tamlyn"
} | {
"id": 1777367,
"login": "elifesciences",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1777367?",
"url": "https://api.github.com/orgs/elifesciences"
} | 2018-10-24T10:32:59 | 8472311325 | {"actor":{"display_login":"tamlyn"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/pulls/comments/209964542","pull_request_review_id":146075030,"id":209964542,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTk2NDU0Mg==","diff_hunk":"@@ -122,14 +130,18 @@ final class KYCPersonalDetailsController: UIViewController, ValidationFormView,\n guard let email = WalletManager.shared.wallet.getEmail() else { return }\n validationFields.forEach({$0.resignFocus()})\n \n- let details = PersonalDetails(\n- identifier: \"\",\n- firstName: firstNameField.text ?? \"\",\n- lastName: lastNameField.text ?? \"\",\n+ guard let details = PersonalDetails(\n+ id: \"\",","path":"Blockchain/KYC/Personal/KYCPersonalDetailsController.swift","position":54,"original_position":54,"commit_id":"1ac9c845c47cc437c7782fdef15a528b8c9d0cc7","original_commit_id":"1ac9c845c47cc437c7782fdef15a528b8c9d0cc7","user":{"login":"jstxx","id":1316251,"node_id":"MDQ6VXNlcjEzMTYyNTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1316251?v=4","gravatar_id":"","url":"https://api.github.com/users/jstxx","html_url":"https://github.com/jstxx","followers_url":"https://api.github.com/users/jstxx/followers","following_url":"https://api.github.com/users/jstxx/following{/other_user}","gists_url":"https://api.github.com/users/jstxx/gists{/gist_id}","starred_url":"https://api.github.com/users/jstxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jstxx/subscriptions","organizations_url":"https://api.github.com/users/jstxx/orgs","repos_url":"https://api.github.com/users/jstxx/repos","events_url":"https://api.github.com/users/jstxx/events{/privacy}","received_events_url":"https://api.github.com/users/jstxx/received_events","type":"User","site_admin":false},"body":"🤔 Will we be generating a NONCE for this?","created_at":"2018-08-14T14:06:38Z","updated_at":"2018-08-14T14:08:19Z","html_url":"https://github.com/blockchain/My-Wallet-V3-iOS/pull/393#discussion_r209964542","pull_request_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/pulls/393","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/pulls/comments/209964542"},"html":{"href":"https://github.com/blockchain/My-Wallet-V3-iOS/pull/393#discussion_r209964542"},"pull_request":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/pulls/393"}}},"pull_request":{"url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/pulls/393","id":208045557,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MDQ1NTU3","html_url":"https://github.com/blockchain/My-Wallet-V3-iOS/pull/393","diff_url":"https://github.com/blockchain/My-Wallet-V3-iOS/pull/393.diff","patch_url":"https://github.com/blockchain/My-Wallet-V3-iOS/pull/393.patch","issue_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/issues/393","number":393,"state":"open","locked":false,"title":"feat(KYC): User Drop Off for KYC","user":{"login":"thisisalexmcgregor","id":41585563,"node_id":"MDQ6VXNlcjQxNTg1NTYz","avatar_url":"https://avatars1.githubusercontent.com/u/41585563?v=4","gravatar_id":"","url":"https://api.github.com/users/thisisalexmcgregor","html_url":"https://github.com/thisisalexmcgregor","followers_url":"https://api.github.com/users/thisisalexmcgregor/followers","following_url":"https://api.github.com/users/thisisalexmcgregor/following{/other_user}","gists_url":"https://api.github.com/users/thisisalexmcgregor/gists{/gist_id}","starred_url":"https://api.github.com/users/thisisalexmcgregor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thisisalexmcgregor/subscriptions","organizations_url":"https://api.github.com/users/thisisalexmcgregor/orgs","repos_url":"https://api.github.com/users/thisisalexmcgregor/repos","events_url":"https://api.github.com/users/thisisalexmcgregor/events{/privacy}","received_events_url":"https://api.github.com/users/thisisalexmcgregor/received_events","type":"User","site_admin":false},"body":"## Objective\r\n\r\nThis is for handling when a user exits and resumes the KYC flow. \r\n\r\n*Note: This PR is marked DNM as it's not complete. I would like to get 👀 on it prior to completion.*\r\n\r\n## Description\r\n\r\n`KYCPageType` - My thinking is that each screen should be associated with a `KYCPageType`. Some types have a model (optional). Should it have said model, the screen will be pre-populated with that data. \r\n`KYCUser` - This is the user model. It's from the user model that we determine what `KYCPageType` the user is at. \r\n\r\n## How to Test\r\n\r\nN/A\r\n\r\n## Screenshot\r\n\r\nN/A\r\n\r\n## Related Information\r\n\r\n* Ticket Number: IOS-1142\r\n\r\n## Merge Checklist\r\n\r\n- [ ] The PR uses a title supported by [.changelogrc](https://github.com/blockchain/My-Wallet-V3-iOS/blob/dev/.changelogrc#L6...L69).\r\n- [ ] Areas of technical debt are marked with a `// TICKET:` comment that includes a ticket number.\r\n- [ ] All unit tests pass.\r\n- [x] New files added are within the correct directory. (e.g. if a file is required for unit tests to compile, be sure it is added to the tests target.)\r\n","created_at":"2018-08-13T17:16:47Z","updated_at":"2018-08-14T14:08:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa78134e1ed55d0915cfed07314475f45ff05799","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1010627324,"node_id":"MDU6TGFiZWwxMDEwNjI3MzI0","url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/labels/Ready%20for%20Review","name":"Ready for Review","color":"037c3c","default":false},{"id":810245474,"node_id":"MDU6TGFiZWw4MTAyNDU0NzQ=","url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/labels/don't%20merge%20yet","name":"don't merge yet","color":"d83f24","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/pulls/393/commits","review_comments_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/pulls/393/comments","review_comment_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/issues/393/comments","statuses_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/statuses/1ac9c845c47cc437c7782fdef15a528b8c9d0cc7","head":{"label":"blockchain:alex/feature/IOS-1142","ref":"alex/feature/IOS-1142","sha":"1ac9c845c47cc437c7782fdef15a528b8c9d0cc7","user":{"login":"blockchain","id":1777722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Nzc3MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1777722?v=4","gravatar_id":"","url":"https://api.github.com/users/blockchain","html_url":"https://github.com/blockchain","followers_url":"https://api.github.com/users/blockchain/followers","following_url":"https://api.github.com/users/blockchain/following{/other_user}","gists_url":"https://api.github.com/users/blockchain/gists{/gist_id}","starred_url":"https://api.github.com/users/blockchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blockchain/subscriptions","organizations_url":"https://api.github.com/users/blockchain/orgs","repos_url":"https://api.github.com/users/blockchain/repos","events_url":"https://api.github.com/users/blockchain/events{/privacy}","received_events_url":"https://api.github.com/users/blockchain/received_events","type":"Organization","site_admin":false},"repo":{"id":26277947,"node_id":"MDEwOlJlcG9zaXRvcnkyNjI3Nzk0Nw==","name":"My-Wallet-V3-iOS","full_name":"blockchain/My-Wallet-V3-iOS","owner":{"login":"blockchain","id":1777722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Nzc3MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1777722?v=4","gravatar_id":"","url":"https://api.github.com/users/blockchain","html_url":"https://github.com/blockchain","followers_url":"https://api.github.com/users/blockchain/followers","following_url":"https://api.github.com/users/blockchain/following{/other_user}","gists_url":"https://api.github.com/users/blockchain/gists{/gist_id}","starred_url":"https://api.github.com/users/blockchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blockchain/subscriptions","organizations_url":"https://api.github.com/users/blockchain/orgs","repos_url":"https://api.github.com/users/blockchain/repos","events_url":"https://api.github.com/users/blockchain/events{/privacy}","received_events_url":"https://api.github.com/users/blockchain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/blockchain/My-Wallet-V3-iOS","description":"Blockchain iOS Wallet","fork":false,"url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS","forks_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/forks","keys_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/teams","hooks_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/hooks","issue_events_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/events","assignees_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/tags","blobs_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/languages","stargazers_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/stargazers","contributors_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/contributors","subscribers_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/subscribers","subscription_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/subscription","commits_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/merges","archive_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/downloads","issues_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/labels{/name}","releases_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/deployments","created_at":"2014-11-06T16:07:58Z","updated_at":"2018-08-14T13:57:19Z","pushed_at":"2018-08-14T13:57:28Z","git_url":"git://github.com/blockchain/My-Wallet-V3-iOS.git","ssh_url":"[email protected]:blockchain/My-Wallet-V3-iOS.git","clone_url":"https://github.com/blockchain/My-Wallet-V3-iOS.git","svn_url":"https://github.com/blockchain/My-Wallet-V3-iOS","homepage":"https://itunes.apple.com/us/app/blockchain-bitcoin-wallet/id493253309","size":90071,"stargazers_count":91,"watchers_count":91,"language":"Assembly","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":63,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":63,"open_issues":7,"watchers":91,"default_branch":"dev"}},"base":{"label":"blockchain:dev","ref":"dev","sha":"c57989403e71e4de6205066264a92a1c52923471","user":{"login":"blockchain","id":1777722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Nzc3MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1777722?v=4","gravatar_id":"","url":"https://api.github.com/users/blockchain","html_url":"https://github.com/blockchain","followers_url":"https://api.github.com/users/blockchain/followers","following_url":"https://api.github.com/users/blockchain/following{/other_user}","gists_url":"https://api.github.com/users/blockchain/gists{/gist_id}","starred_url":"https://api.github.com/users/blockchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blockchain/subscriptions","organizations_url":"https://api.github.com/users/blockchain/orgs","repos_url":"https://api.github.com/users/blockchain/repos","events_url":"https://api.github.com/users/blockchain/events{/privacy}","received_events_url":"https://api.github.com/users/blockchain/received_events","type":"Organization","site_admin":false},"repo":{"id":26277947,"node_id":"MDEwOlJlcG9zaXRvcnkyNjI3Nzk0Nw==","name":"My-Wallet-V3-iOS","full_name":"blockchain/My-Wallet-V3-iOS","owner":{"login":"blockchain","id":1777722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Nzc3MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1777722?v=4","gravatar_id":"","url":"https://api.github.com/users/blockchain","html_url":"https://github.com/blockchain","followers_url":"https://api.github.com/users/blockchain/followers","following_url":"https://api.github.com/users/blockchain/following{/other_user}","gists_url":"https://api.github.com/users/blockchain/gists{/gist_id}","starred_url":"https://api.github.com/users/blockchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blockchain/subscriptions","organizations_url":"https://api.github.com/users/blockchain/orgs","repos_url":"https://api.github.com/users/blockchain/repos","events_url":"https://api.github.com/users/blockchain/events{/privacy}","received_events_url":"https://api.github.com/users/blockchain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/blockchain/My-Wallet-V3-iOS","description":"Blockchain iOS Wallet","fork":false,"url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS","forks_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/forks","keys_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/teams","hooks_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/hooks","issue_events_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/events","assignees_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/tags","blobs_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/languages","stargazers_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/stargazers","contributors_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/contributors","subscribers_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/subscribers","subscription_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/subscription","commits_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/merges","archive_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/downloads","issues_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/labels{/name}","releases_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/deployments","created_at":"2014-11-06T16:07:58Z","updated_at":"2018-08-14T13:57:19Z","pushed_at":"2018-08-14T13:57:28Z","git_url":"git://github.com/blockchain/My-Wallet-V3-iOS.git","ssh_url":"[email protected]:blockchain/My-Wallet-V3-iOS.git","clone_url":"https://github.com/blockchain/My-Wallet-V3-iOS.git","svn_url":"https://github.com/blockchain/My-Wallet-V3-iOS","homepage":"https://itunes.apple.com/us/app/blockchain-bitcoin-wallet/id493253309","size":90071,"stargazers_count":91,"watchers_count":91,"language":"Assembly","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":63,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":63,"open_issues":7,"watchers":91,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/pulls/393"},"html":{"href":"https://github.com/blockchain/My-Wallet-V3-iOS/pull/393"},"issue":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/issues/393"},"comments":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/issues/393/comments"},"review_comments":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/pulls/393/comments"},"review_comment":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/pulls/393/commits"},"statuses":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/statuses/1ac9c845c47cc437c7782fdef15a528b8c9d0cc7"}},"author_association":"COLLABORATOR"}} | {
"id": 26277947,
"name": "blockchain/My-Wallet-V3-iOS",
"url": "https://api.github.com/repos/blockchain/My-Wallet-V3-iOS"
} | {
"id": 1316251,
"login": "jstxx",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1316251?",
"url": "https://api.github.com/users/jstxx"
} | {
"id": 1777722,
"login": "blockchain",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1777722?",
"url": "https://api.github.com/orgs/blockchain"
} | 2018-08-14T14:06:38 | 8111466917 | {"actor":{"display_login":"jstxx"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/CruGlobal/godtools-android/pulls/comments/226016263","pull_request_review_id":165738243,"id":226016263,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjAxNjI2Mw==","diff_hunk":"@@ -0,0 +1,17 @@\n+package org.cru.godtools.articles.aem.service;\n+\n+import android.content.Context;\n+\n+public class AEMFutureRunnable implements Runnable {\n+ private AEMDownloadManger mManager;\n+\n+ public AEMFutureRunnable(Context context) {\n+ mManager = AEMDownloadManger.getInstance(context);\n+ }\n+\n+ @Override\n+ public void run() {\n+ mManager.extractAemImportsFromManifestsTask();\n+ mManager.syncStaleAemImportsTask();","path":"ui/articles-aem-renderer/src/main/java/org/cru/godtools/articles/aem/service/AEMFutureRunnable.java","position":15,"original_position":15,"commit_id":"2aa7d01e189adb72843d2579431b0b8994ddecef","original_commit_id":"2aa7d01e189adb72843d2579431b0b8994ddecef","user":{"login":"gyasistory","id":970048,"node_id":"MDQ6VXNlcjk3MDA0OA==","avatar_url":"https://avatars3.githubusercontent.com/u/970048?v=4","gravatar_id":"","url":"https://api.github.com/users/gyasistory","html_url":"https://github.com/gyasistory","followers_url":"https://api.github.com/users/gyasistory/followers","following_url":"https://api.github.com/users/gyasistory/following{/other_user}","gists_url":"https://api.github.com/users/gyasistory/gists{/gist_id}","starred_url":"https://api.github.com/users/gyasistory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gyasistory/subscriptions","organizations_url":"https://api.github.com/users/gyasistory/orgs","repos_url":"https://api.github.com/users/gyasistory/repos","events_url":"https://api.github.com/users/gyasistory/events{/privacy}","received_events_url":"https://api.github.com/users/gyasistory/received_events","type":"User","site_admin":false},"body":"@frett I created this class so I didn't have to change the access modifier for any methods. Let me know if this and the way I handled the Future Task are the headed in the right direction.","created_at":"2018-10-17T17:02:01Z","updated_at":"2018-10-17T17:02:01Z","html_url":"https://github.com/CruGlobal/godtools-android/pull/526#discussion_r226016263","pull_request_url":"https://api.github.com/repos/CruGlobal/godtools-android/pulls/526","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CruGlobal/godtools-android/pulls/comments/226016263"},"html":{"href":"https://github.com/CruGlobal/godtools-android/pull/526#discussion_r226016263"},"pull_request":{"href":"https://api.github.com/repos/CruGlobal/godtools-android/pulls/526"}}},"pull_request":{"url":"https://api.github.com/repos/CruGlobal/godtools-android/pulls/526","id":223616235,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNjE2MjM1","html_url":"https://github.com/CruGlobal/godtools-android/pull/526","diff_url":"https://github.com/CruGlobal/godtools-android/pull/526.diff","patch_url":"https://github.com/CruGlobal/godtools-android/pull/526.patch","issue_url":"https://api.github.com/repos/CruGlobal/godtools-android/issues/526","number":526,"state":"open","locked":false,"title":"GT-527 - WIP: add swipe to refresh view","user":{"login":"gyasistory","id":970048,"node_id":"MDQ6VXNlcjk3MDA0OA==","avatar_url":"https://avatars3.githubusercontent.com/u/970048?v=4","gravatar_id":"","url":"https://api.github.com/users/gyasistory","html_url":"https://github.com/gyasistory","followers_url":"https://api.github.com/users/gyasistory/followers","following_url":"https://api.github.com/users/gyasistory/following{/other_user}","gists_url":"https://api.github.com/users/gyasistory/gists{/gist_id}","starred_url":"https://api.github.com/users/gyasistory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gyasistory/subscriptions","organizations_url":"https://api.github.com/users/gyasistory/orgs","repos_url":"https://api.github.com/users/gyasistory/repos","events_url":"https://api.github.com/users/gyasistory/events{/privacy}","received_events_url":"https://api.github.com/users/gyasistory/received_events","type":"User","site_admin":false},"body":"https://jira.cru.org/browse/GT-527#","created_at":"2018-10-17T14:01:10Z","updated_at":"2018-10-17T17:02:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"83c948832231039598adb5249017de23ad67d588","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CruGlobal/godtools-android/pulls/526/commits","review_comments_url":"https://api.github.com/repos/CruGlobal/godtools-android/pulls/526/comments","review_comment_url":"https://api.github.com/repos/CruGlobal/godtools-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CruGlobal/godtools-android/issues/526/comments","statuses_url":"https://api.github.com/repos/CruGlobal/godtools-android/statuses/2aa7d01e189adb72843d2579431b0b8994ddecef","head":{"label":"CruGlobal:GT-527-Swipe-to-Refresh-Article-List","ref":"GT-527-Swipe-to-Refresh-Article-List","sha":"2aa7d01e189adb72843d2579431b0b8994ddecef","user":{"login":"CruGlobal","id":1785912,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODU5MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/1785912?v=4","gravatar_id":"","url":"https://api.github.com/users/CruGlobal","html_url":"https://github.com/CruGlobal","followers_url":"https://api.github.com/users/CruGlobal/followers","following_url":"https://api.github.com/users/CruGlobal/following{/other_user}","gists_url":"https://api.github.com/users/CruGlobal/gists{/gist_id}","starred_url":"https://api.github.com/users/CruGlobal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CruGlobal/subscriptions","organizations_url":"https://api.github.com/users/CruGlobal/orgs","repos_url":"https://api.github.com/users/CruGlobal/repos","events_url":"https://api.github.com/users/CruGlobal/events{/privacy}","received_events_url":"https://api.github.com/users/CruGlobal/received_events","type":"Organization","site_admin":false},"repo":{"id":23581760,"node_id":"MDEwOlJlcG9zaXRvcnkyMzU4MTc2MA==","name":"godtools-android","full_name":"CruGlobal/godtools-android","private":false,"owner":{"login":"CruGlobal","id":1785912,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODU5MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/1785912?v=4","gravatar_id":"","url":"https://api.github.com/users/CruGlobal","html_url":"https://github.com/CruGlobal","followers_url":"https://api.github.com/users/CruGlobal/followers","following_url":"https://api.github.com/users/CruGlobal/following{/other_user}","gists_url":"https://api.github.com/users/CruGlobal/gists{/gist_id}","starred_url":"https://api.github.com/users/CruGlobal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CruGlobal/subscriptions","organizations_url":"https://api.github.com/users/CruGlobal/orgs","repos_url":"https://api.github.com/users/CruGlobal/repos","events_url":"https://api.github.com/users/CruGlobal/events{/privacy}","received_events_url":"https://api.github.com/users/CruGlobal/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CruGlobal/godtools-android","description":"GodTools Android App","fork":false,"url":"https://api.github.com/repos/CruGlobal/godtools-android","forks_url":"https://api.github.com/repos/CruGlobal/godtools-android/forks","keys_url":"https://api.github.com/repos/CruGlobal/godtools-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CruGlobal/godtools-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CruGlobal/godtools-android/teams","hooks_url":"https://api.github.com/repos/CruGlobal/godtools-android/hooks","issue_events_url":"https://api.github.com/repos/CruGlobal/godtools-android/issues/events{/number}","events_url":"https://api.github.com/repos/CruGlobal/godtools-android/events","assignees_url":"https://api.github.com/repos/CruGlobal/godtools-android/assignees{/user}","branches_url":"https://api.github.com/repos/CruGlobal/godtools-android/branches{/branch}","tags_url":"https://api.github.com/repos/CruGlobal/godtools-android/tags","blobs_url":"https://api.github.com/repos/CruGlobal/godtools-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CruGlobal/godtools-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CruGlobal/godtools-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/CruGlobal/godtools-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CruGlobal/godtools-android/statuses/{sha}","languages_url":"https://api.github.com/repos/CruGlobal/godtools-android/languages","stargazers_url":"https://api.github.com/repos/CruGlobal/godtools-android/stargazers","contributors_url":"https://api.github.com/repos/CruGlobal/godtools-android/contributors","subscribers_url":"https://api.github.com/repos/CruGlobal/godtools-android/subscribers","subscription_url":"https://api.github.com/repos/CruGlobal/godtools-android/subscription","commits_url":"https://api.github.com/repos/CruGlobal/godtools-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/CruGlobal/godtools-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/CruGlobal/godtools-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/CruGlobal/godtools-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/CruGlobal/godtools-android/contents/{+path}","compare_url":"https://api.github.com/repos/CruGlobal/godtools-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CruGlobal/godtools-android/merges","archive_url":"https://api.github.com/repos/CruGlobal/godtools-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CruGlobal/godtools-android/downloads","issues_url":"https://api.github.com/repos/CruGlobal/godtools-android/issues{/number}","pulls_url":"https://api.github.com/repos/CruGlobal/godtools-android/pulls{/number}","milestones_url":"https://api.github.com/repos/CruGlobal/godtools-android/milestones{/number}","notifications_url":"https://api.github.com/repos/CruGlobal/godtools-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CruGlobal/godtools-android/labels{/name}","releases_url":"https://api.github.com/repos/CruGlobal/godtools-android/releases{/id}","deployments_url":"https://api.github.com/repos/CruGlobal/godtools-android/deployments","created_at":"2014-09-02T14:28:04Z","updated_at":"2018-10-15T13:28:31Z","pushed_at":"2018-10-17T16:55:20Z","git_url":"git://github.com/CruGlobal/godtools-android.git","ssh_url":"[email protected]:CruGlobal/godtools-android.git","clone_url":"https://github.com/CruGlobal/godtools-android.git","svn_url":"https://github.com/CruGlobal/godtools-android","homepage":"","size":33560,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":0,"open_issues":6,"watchers":6,"default_branch":"develop"}},"base":{"label":"CruGlobal:articles","ref":"articles","sha":"9d89e9112c3282838992080520c37bac8999efc8","user":{"login":"CruGlobal","id":1785912,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODU5MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/1785912?v=4","gravatar_id":"","url":"https://api.github.com/users/CruGlobal","html_url":"https://github.com/CruGlobal","followers_url":"https://api.github.com/users/CruGlobal/followers","following_url":"https://api.github.com/users/CruGlobal/following{/other_user}","gists_url":"https://api.github.com/users/CruGlobal/gists{/gist_id}","starred_url":"https://api.github.com/users/CruGlobal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CruGlobal/subscriptions","organizations_url":"https://api.github.com/users/CruGlobal/orgs","repos_url":"https://api.github.com/users/CruGlobal/repos","events_url":"https://api.github.com/users/CruGlobal/events{/privacy}","received_events_url":"https://api.github.com/users/CruGlobal/received_events","type":"Organization","site_admin":false},"repo":{"id":23581760,"node_id":"MDEwOlJlcG9zaXRvcnkyMzU4MTc2MA==","name":"godtools-android","full_name":"CruGlobal/godtools-android","private":false,"owner":{"login":"CruGlobal","id":1785912,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODU5MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/1785912?v=4","gravatar_id":"","url":"https://api.github.com/users/CruGlobal","html_url":"https://github.com/CruGlobal","followers_url":"https://api.github.com/users/CruGlobal/followers","following_url":"https://api.github.com/users/CruGlobal/following{/other_user}","gists_url":"https://api.github.com/users/CruGlobal/gists{/gist_id}","starred_url":"https://api.github.com/users/CruGlobal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CruGlobal/subscriptions","organizations_url":"https://api.github.com/users/CruGlobal/orgs","repos_url":"https://api.github.com/users/CruGlobal/repos","events_url":"https://api.github.com/users/CruGlobal/events{/privacy}","received_events_url":"https://api.github.com/users/CruGlobal/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CruGlobal/godtools-android","description":"GodTools Android App","fork":false,"url":"https://api.github.com/repos/CruGlobal/godtools-android","forks_url":"https://api.github.com/repos/CruGlobal/godtools-android/forks","keys_url":"https://api.github.com/repos/CruGlobal/godtools-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CruGlobal/godtools-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CruGlobal/godtools-android/teams","hooks_url":"https://api.github.com/repos/CruGlobal/godtools-android/hooks","issue_events_url":"https://api.github.com/repos/CruGlobal/godtools-android/issues/events{/number}","events_url":"https://api.github.com/repos/CruGlobal/godtools-android/events","assignees_url":"https://api.github.com/repos/CruGlobal/godtools-android/assignees{/user}","branches_url":"https://api.github.com/repos/CruGlobal/godtools-android/branches{/branch}","tags_url":"https://api.github.com/repos/CruGlobal/godtools-android/tags","blobs_url":"https://api.github.com/repos/CruGlobal/godtools-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CruGlobal/godtools-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CruGlobal/godtools-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/CruGlobal/godtools-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CruGlobal/godtools-android/statuses/{sha}","languages_url":"https://api.github.com/repos/CruGlobal/godtools-android/languages","stargazers_url":"https://api.github.com/repos/CruGlobal/godtools-android/stargazers","contributors_url":"https://api.github.com/repos/CruGlobal/godtools-android/contributors","subscribers_url":"https://api.github.com/repos/CruGlobal/godtools-android/subscribers","subscription_url":"https://api.github.com/repos/CruGlobal/godtools-android/subscription","commits_url":"https://api.github.com/repos/CruGlobal/godtools-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/CruGlobal/godtools-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/CruGlobal/godtools-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/CruGlobal/godtools-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/CruGlobal/godtools-android/contents/{+path}","compare_url":"https://api.github.com/repos/CruGlobal/godtools-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CruGlobal/godtools-android/merges","archive_url":"https://api.github.com/repos/CruGlobal/godtools-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CruGlobal/godtools-android/downloads","issues_url":"https://api.github.com/repos/CruGlobal/godtools-android/issues{/number}","pulls_url":"https://api.github.com/repos/CruGlobal/godtools-android/pulls{/number}","milestones_url":"https://api.github.com/repos/CruGlobal/godtools-android/milestones{/number}","notifications_url":"https://api.github.com/repos/CruGlobal/godtools-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CruGlobal/godtools-android/labels{/name}","releases_url":"https://api.github.com/repos/CruGlobal/godtools-android/releases{/id}","deployments_url":"https://api.github.com/repos/CruGlobal/godtools-android/deployments","created_at":"2014-09-02T14:28:04Z","updated_at":"2018-10-15T13:28:31Z","pushed_at":"2018-10-17T16:55:20Z","git_url":"git://github.com/CruGlobal/godtools-android.git","ssh_url":"[email protected]:CruGlobal/godtools-android.git","clone_url":"https://github.com/CruGlobal/godtools-android.git","svn_url":"https://github.com/CruGlobal/godtools-android","homepage":"","size":33560,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":0,"open_issues":6,"watchers":6,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/CruGlobal/godtools-android/pulls/526"},"html":{"href":"https://github.com/CruGlobal/godtools-android/pull/526"},"issue":{"href":"https://api.github.com/repos/CruGlobal/godtools-android/issues/526"},"comments":{"href":"https://api.github.com/repos/CruGlobal/godtools-android/issues/526/comments"},"review_comments":{"href":"https://api.github.com/repos/CruGlobal/godtools-android/pulls/526/comments"},"review_comment":{"href":"https://api.github.com/repos/CruGlobal/godtools-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CruGlobal/godtools-android/pulls/526/commits"},"statuses":{"href":"https://api.github.com/repos/CruGlobal/godtools-android/statuses/2aa7d01e189adb72843d2579431b0b8994ddecef"}},"author_association":"CONTRIBUTOR"}} | {
"id": 23581760,
"name": "CruGlobal/godtools-android",
"url": "https://api.github.com/repos/CruGlobal/godtools-android"
} | {
"id": 970048,
"login": "gyasistory",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/970048?",
"url": "https://api.github.com/users/gyasistory"
} | {
"id": 1785912,
"login": "CruGlobal",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1785912?",
"url": "https://api.github.com/orgs/CruGlobal"
} | 2018-10-17T17:02:01 | 8437068727 | {"actor":{"display_login":"gyasistory"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments/180118554","pull_request_review_id":110483546,"id":180118554,"diff_hunk":"@@ -56,11 +56,39 @@ def dump_schema\n @database_host,\n CartoDB::DataMover::Config[:user_dbport],\n @database_name\n- )} -f #{@path}/#{@database_schema}.schema.sql -n #{@database_schema} --verbose --no-tablespaces --quote-all-identifiers -Z 0\")\n+ )} #{skip_orphan_overview_tables} -f #{@path}/#{@database_schema}.schema.sql -n #{@database_schema} --verbose --no-tablespaces --quote-all-identifiers -Z 0\")\n end\n \n private\n \n+ def user_pg_conn\n+ @user_pg_conn ||= PGconn.connect(host: @database_host,\n+ user: CartoDB::DataMover::Config[:dbuser],\n+ dbname: @database_name,\n+ port: CartoDB::DataMover::Config[:user_dbport],","path":"services/user-mover/export_user.rb","position":23,"original_position":23,"commit_id":"ddb4e78ba4bf5725b6f2b65a7c203cdfe60ccfc7","original_commit_id":"ddb4e78ba4bf5725b6f2b65a7c203cdfe60ccfc7","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Align the elements of a hash literal if they span more than one line.","created_at":"2018-04-09T14:45:20Z","updated_at":"2018-04-09T14:45:20Z","html_url":"https://github.com/CartoDB/cartodb/pull/13819#discussion_r180118554","pull_request_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/13819","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments/180118554"},"html":{"href":"https://github.com/CartoDB/cartodb/pull/13819#discussion_r180118554"},"pull_request":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/13819"}}},"pull_request":{"url":"https://api.github.com/repos/CartoDB/cartodb/pulls/13819","id":180324337,"html_url":"https://github.com/CartoDB/cartodb/pull/13819","diff_url":"https://github.com/CartoDB/cartodb/pull/13819.diff","patch_url":"https://github.com/CartoDB/cartodb/pull/13819.patch","issue_url":"https://api.github.com/repos/CartoDB/cartodb/issues/13819","number":13819,"state":"open","locked":false,"title":"Skip orphan overview tables","user":{"login":"amartinj","id":1821052,"avatar_url":"https://avatars0.githubusercontent.com/u/1821052?v=4","gravatar_id":"","url":"https://api.github.com/users/amartinj","html_url":"https://github.com/amartinj","followers_url":"https://api.github.com/users/amartinj/followers","following_url":"https://api.github.com/users/amartinj/following{/other_user}","gists_url":"https://api.github.com/users/amartinj/gists{/gist_id}","starred_url":"https://api.github.com/users/amartinj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amartinj/subscriptions","organizations_url":"https://api.github.com/users/amartinj/orgs","repos_url":"https://api.github.com/users/amartinj/repos","events_url":"https://api.github.com/users/amartinj/events{/privacy}","received_events_url":"https://api.github.com/users/amartinj/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-09T14:16:57Z","updated_at":"2018-04-09T14:45:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a18c8fe7ec7a729920a7584e7046677a4b8d6ba8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/13819/commits","review_comments_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/13819/comments","review_comment_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/issues/13819/comments","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/ddb4e78ba4bf5725b6f2b65a7c203cdfe60ccfc7","head":{"label":"CartoDB:2193SkipOrphanRasterOverviews","ref":"2193SkipOrphanRasterOverviews","sha":"ddb4e78ba4bf5725b6f2b65a7c203cdfe60ccfc7","user":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":4909355,"name":"cartodb","full_name":"CartoDB/cartodb","owner":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CartoDB/cartodb","description":"Location Intelligence & Data Visualization tool","fork":false,"url":"https://api.github.com/repos/CartoDB/cartodb","forks_url":"https://api.github.com/repos/CartoDB/cartodb/forks","keys_url":"https://api.github.com/repos/CartoDB/cartodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/cartodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/cartodb/teams","hooks_url":"https://api.github.com/repos/CartoDB/cartodb/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/cartodb/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/cartodb/events","assignees_url":"https://api.github.com/repos/CartoDB/cartodb/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/cartodb/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/cartodb/tags","blobs_url":"https://api.github.com/repos/CartoDB/cartodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/cartodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/cartodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/cartodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/cartodb/languages","stargazers_url":"https://api.github.com/repos/CartoDB/cartodb/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/cartodb/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/cartodb/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/cartodb/subscription","commits_url":"https://api.github.com/repos/CartoDB/cartodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/cartodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/cartodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/cartodb/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/cartodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/cartodb/merges","archive_url":"https://api.github.com/repos/CartoDB/cartodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/cartodb/downloads","issues_url":"https://api.github.com/repos/CartoDB/cartodb/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/cartodb/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/cartodb/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/cartodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/cartodb/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/cartodb/releases{/id}","deployments_url":"https://api.github.com/repos/CartoDB/cartodb/deployments","created_at":"2012-07-05T15:23:45Z","updated_at":"2018-04-09T14:08:55Z","pushed_at":"2018-04-09T14:45:07Z","git_url":"git://github.com/CartoDB/cartodb.git","ssh_url":"[email protected]:CartoDB/cartodb.git","clone_url":"https://github.com/CartoDB/cartodb.git","svn_url":"https://github.com/CartoDB/cartodb","homepage":"http://carto.com","size":370112,"stargazers_count":1816,"watchers_count":1816,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":494,"mirror_url":null,"archived":false,"open_issues_count":474,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":494,"open_issues":474,"watchers":1816,"default_branch":"master"}},"base":{"label":"CartoDB:master","ref":"master","sha":"459b7bf88188dd3233ccf3625823ac34de843695","user":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":4909355,"name":"cartodb","full_name":"CartoDB/cartodb","owner":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CartoDB/cartodb","description":"Location Intelligence & Data Visualization tool","fork":false,"url":"https://api.github.com/repos/CartoDB/cartodb","forks_url":"https://api.github.com/repos/CartoDB/cartodb/forks","keys_url":"https://api.github.com/repos/CartoDB/cartodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/cartodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/cartodb/teams","hooks_url":"https://api.github.com/repos/CartoDB/cartodb/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/cartodb/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/cartodb/events","assignees_url":"https://api.github.com/repos/CartoDB/cartodb/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/cartodb/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/cartodb/tags","blobs_url":"https://api.github.com/repos/CartoDB/cartodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/cartodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/cartodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/cartodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/cartodb/languages","stargazers_url":"https://api.github.com/repos/CartoDB/cartodb/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/cartodb/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/cartodb/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/cartodb/subscription","commits_url":"https://api.github.com/repos/CartoDB/cartodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/cartodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/cartodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/cartodb/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/cartodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/cartodb/merges","archive_url":"https://api.github.com/repos/CartoDB/cartodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/cartodb/downloads","issues_url":"https://api.github.com/repos/CartoDB/cartodb/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/cartodb/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/cartodb/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/cartodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/cartodb/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/cartodb/releases{/id}","deployments_url":"https://api.github.com/repos/CartoDB/cartodb/deployments","created_at":"2012-07-05T15:23:45Z","updated_at":"2018-04-09T14:08:55Z","pushed_at":"2018-04-09T14:45:07Z","git_url":"git://github.com/CartoDB/cartodb.git","ssh_url":"[email protected]:CartoDB/cartodb.git","clone_url":"https://github.com/CartoDB/cartodb.git","svn_url":"https://github.com/CartoDB/cartodb","homepage":"http://carto.com","size":370112,"stargazers_count":1816,"watchers_count":1816,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":494,"mirror_url":null,"archived":false,"open_issues_count":474,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":494,"open_issues":474,"watchers":1816,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/13819"},"html":{"href":"https://github.com/CartoDB/cartodb/pull/13819"},"issue":{"href":"https://api.github.com/repos/CartoDB/cartodb/issues/13819"},"comments":{"href":"https://api.github.com/repos/CartoDB/cartodb/issues/13819/comments"},"review_comments":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/13819/comments"},"review_comment":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/13819/commits"},"statuses":{"href":"https://api.github.com/repos/CartoDB/cartodb/statuses/ddb4e78ba4bf5725b6f2b65a7c203cdfe60ccfc7"}},"author_association":"CONTRIBUTOR"}} | {
"id": 4909355,
"name": "CartoDB/cartodb",
"url": "https://api.github.com/repos/CartoDB/cartodb"
} | {
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
} | {
"id": 1799254,
"login": "CartoDB",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1799254?",
"url": "https://api.github.com/orgs/CartoDB"
} | 2018-04-09T14:45:20 | 7501125139 | {"actor":{"display_login":"houndci-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments/229271570","pull_request_review_id":169727936,"id":229271570,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTI3MTU3MA==","diff_hunk":"@@ -0,0 +1,14 @@\n+require 'carto/db/migration_helper'\n+\n+include Carto::Db::MigrationHelper","path":"db/migrate/20181023112320_add_password_reset_to_users.rb","position":3,"original_position":3,"commit_id":"13049ebeba11bf4940cf97e3ab21fee90271dc78","original_commit_id":"13049ebeba11bf4940cf97e3ab21fee90271dc78","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"include is used at the top level. Use inside class or module.","created_at":"2018-10-30T11:37:30Z","updated_at":"2018-10-30T11:37:30Z","html_url":"https://github.com/CartoDB/cartodb/pull/14378#discussion_r229271570","pull_request_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/14378","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments/229271570"},"html":{"href":"https://github.com/CartoDB/cartodb/pull/14378#discussion_r229271570"},"pull_request":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/14378"}}},"pull_request":{"url":"https://api.github.com/repos/CartoDB/cartodb/pulls/14378","id":226886973,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2ODg2OTcz","html_url":"https://github.com/CartoDB/cartodb/pull/14378","diff_url":"https://github.com/CartoDB/cartodb/pull/14378.diff","patch_url":"https://github.com/CartoDB/cartodb/pull/14378.patch","issue_url":"https://api.github.com/repos/CartoDB/cartodb/issues/14378","number":14378,"state":"open","locked":false,"title":"Add forgot password fields to user","user":{"login":"gonzaloriestra","id":14979109,"node_id":"MDQ6VXNlcjE0OTc5MTA5","avatar_url":"https://avatars0.githubusercontent.com/u/14979109?v=4","gravatar_id":"","url":"https://api.github.com/users/gonzaloriestra","html_url":"https://github.com/gonzaloriestra","followers_url":"https://api.github.com/users/gonzaloriestra/followers","following_url":"https://api.github.com/users/gonzaloriestra/following{/other_user}","gists_url":"https://api.github.com/users/gonzaloriestra/gists{/gist_id}","starred_url":"https://api.github.com/users/gonzaloriestra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonzaloriestra/subscriptions","organizations_url":"https://api.github.com/users/gonzaloriestra/orgs","repos_url":"https://api.github.com/users/gonzaloriestra/repos","events_url":"https://api.github.com/users/gonzaloriestra/events{/privacy}","received_events_url":"https://api.github.com/users/gonzaloriestra/received_events","type":"User","site_admin":false},"body":"Migration to add required password reset fields to user (`password_reset_token` and `password_reset_sent_at`), and also to import/export operations in `UserMetadataExportService`.","created_at":"2018-10-30T11:37:15Z","updated_at":"2018-10-30T11:37:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7578a077b13848c2e32f7bf072042f7203e0aa3a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/14378/commits","review_comments_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/14378/comments","review_comment_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/issues/14378/comments","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/13049ebeba11bf4940cf97e3ab21fee90271dc78","head":{"label":"CartoDB:revert-14377-revert-14371-forgot-password-migration","ref":"revert-14377-revert-14371-forgot-password-migration","sha":"13049ebeba11bf4940cf97e3ab21fee90271dc78","user":{"login":"CartoDB","id":1799254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTkyNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":4909355,"node_id":"MDEwOlJlcG9zaXRvcnk0OTA5MzU1","name":"cartodb","full_name":"CartoDB/cartodb","private":false,"owner":{"login":"CartoDB","id":1799254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTkyNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CartoDB/cartodb","description":"Location Intelligence & Data Visualization tool","fork":false,"url":"https://api.github.com/repos/CartoDB/cartodb","forks_url":"https://api.github.com/repos/CartoDB/cartodb/forks","keys_url":"https://api.github.com/repos/CartoDB/cartodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/cartodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/cartodb/teams","hooks_url":"https://api.github.com/repos/CartoDB/cartodb/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/cartodb/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/cartodb/events","assignees_url":"https://api.github.com/repos/CartoDB/cartodb/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/cartodb/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/cartodb/tags","blobs_url":"https://api.github.com/repos/CartoDB/cartodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/cartodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/cartodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/cartodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/cartodb/languages","stargazers_url":"https://api.github.com/repos/CartoDB/cartodb/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/cartodb/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/cartodb/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/cartodb/subscription","commits_url":"https://api.github.com/repos/CartoDB/cartodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/cartodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/cartodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/cartodb/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/cartodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/cartodb/merges","archive_url":"https://api.github.com/repos/CartoDB/cartodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/cartodb/downloads","issues_url":"https://api.github.com/repos/CartoDB/cartodb/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/cartodb/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/cartodb/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/cartodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/cartodb/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/cartodb/releases{/id}","deployments_url":"https://api.github.com/repos/CartoDB/cartodb/deployments","created_at":"2012-07-05T15:23:45Z","updated_at":"2018-10-30T11:00:58Z","pushed_at":"2018-10-30T11:37:16Z","git_url":"git://github.com/CartoDB/cartodb.git","ssh_url":"[email protected]:CartoDB/cartodb.git","clone_url":"https://github.com/CartoDB/cartodb.git","svn_url":"https://github.com/CartoDB/cartodb","homepage":"http://carto.com","size":383582,"stargazers_count":1983,"watchers_count":1983,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":546,"mirror_url":null,"archived":false,"open_issues_count":377,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":546,"open_issues":377,"watchers":1983,"default_branch":"master"}},"base":{"label":"CartoDB:master","ref":"master","sha":"232e5d6fdea0147935530ce722c84e6167bea587","user":{"login":"CartoDB","id":1799254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTkyNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":4909355,"node_id":"MDEwOlJlcG9zaXRvcnk0OTA5MzU1","name":"cartodb","full_name":"CartoDB/cartodb","private":false,"owner":{"login":"CartoDB","id":1799254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTkyNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CartoDB/cartodb","description":"Location Intelligence & Data Visualization tool","fork":false,"url":"https://api.github.com/repos/CartoDB/cartodb","forks_url":"https://api.github.com/repos/CartoDB/cartodb/forks","keys_url":"https://api.github.com/repos/CartoDB/cartodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/cartodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/cartodb/teams","hooks_url":"https://api.github.com/repos/CartoDB/cartodb/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/cartodb/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/cartodb/events","assignees_url":"https://api.github.com/repos/CartoDB/cartodb/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/cartodb/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/cartodb/tags","blobs_url":"https://api.github.com/repos/CartoDB/cartodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/cartodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/cartodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/cartodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/cartodb/languages","stargazers_url":"https://api.github.com/repos/CartoDB/cartodb/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/cartodb/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/cartodb/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/cartodb/subscription","commits_url":"https://api.github.com/repos/CartoDB/cartodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/cartodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/cartodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/cartodb/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/cartodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/cartodb/merges","archive_url":"https://api.github.com/repos/CartoDB/cartodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/cartodb/downloads","issues_url":"https://api.github.com/repos/CartoDB/cartodb/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/cartodb/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/cartodb/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/cartodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/cartodb/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/cartodb/releases{/id}","deployments_url":"https://api.github.com/repos/CartoDB/cartodb/deployments","created_at":"2012-07-05T15:23:45Z","updated_at":"2018-10-30T11:00:58Z","pushed_at":"2018-10-30T11:37:16Z","git_url":"git://github.com/CartoDB/cartodb.git","ssh_url":"[email protected]:CartoDB/cartodb.git","clone_url":"https://github.com/CartoDB/cartodb.git","svn_url":"https://github.com/CartoDB/cartodb","homepage":"http://carto.com","size":383582,"stargazers_count":1983,"watchers_count":1983,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":546,"mirror_url":null,"archived":false,"open_issues_count":377,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":546,"open_issues":377,"watchers":1983,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/14378"},"html":{"href":"https://github.com/CartoDB/cartodb/pull/14378"},"issue":{"href":"https://api.github.com/repos/CartoDB/cartodb/issues/14378"},"comments":{"href":"https://api.github.com/repos/CartoDB/cartodb/issues/14378/comments"},"review_comments":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/14378/comments"},"review_comment":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/14378/commits"},"statuses":{"href":"https://api.github.com/repos/CartoDB/cartodb/statuses/13049ebeba11bf4940cf97e3ab21fee90271dc78"}},"author_association":"CONTRIBUTOR"}} | {
"id": 4909355,
"name": "CartoDB/cartodb",
"url": "https://api.github.com/repos/CartoDB/cartodb"
} | {
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
} | {
"id": 1799254,
"login": "CartoDB",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1799254?",
"url": "https://api.github.com/orgs/CartoDB"
} | 2018-10-30T11:37:30 | 8504391075 | {"actor":{"display_login":"houndci-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ocaml/ocaml/pulls/comments/198936275","pull_request_review_id":132959911,"id":198936275,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODkzNjI3NQ==","diff_hunk":"@@ -224,9 +223,9 @@ while : ; do\n -with-flambda-invariants|--with-flambda-invariants)\n with_flambda_invariants=true;;\n -with-cplugins|--with-cplugins)\n- with_cplugins=true;;\n+ err \"--with-cplugins is no longer supported\";; # Transitional?\n -no-cplugins|--no-cplugins)\n- ;; # Ignored for backward compatibility\n+ ;; # Ignored for backward compatibility; transitional?","path":"configure","position":16,"original_position":16,"commit_id":"4f23048e36a26b025d5ecd925fcffb9412ebb46c","original_commit_id":"4f23048e36a26b025d5ecd925fcffb9412ebb46c","user":{"login":"dra27","id":5250680,"node_id":"MDQ6VXNlcjUyNTA2ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/5250680?v=4","gravatar_id":"","url":"https://api.github.com/users/dra27","html_url":"https://github.com/dra27","followers_url":"https://api.github.com/users/dra27/followers","following_url":"https://api.github.com/users/dra27/following{/other_user}","gists_url":"https://api.github.com/users/dra27/gists{/gist_id}","starred_url":"https://api.github.com/users/dra27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dra27/subscriptions","organizations_url":"https://api.github.com/users/dra27/orgs","repos_url":"https://api.github.com/users/dra27/repos","events_url":"https://api.github.com/users/dra27/events{/privacy}","received_events_url":"https://api.github.com/users/dra27/received_events","type":"User","site_admin":false},"body":"In general, I think it’s nicer to have the flag preserved with the warning. Apart from anything else, if anything like it is ever reintroduced, it means care is implied not to re-use the old flag name without considering whether the new flag has the same meaning as the old one (largely academic I expect here, of course)","created_at":"2018-06-28T18:12:40Z","updated_at":"2018-06-28T18:12:41Z","html_url":"https://github.com/ocaml/ocaml/pull/1867#discussion_r198936275","pull_request_url":"https://api.github.com/repos/ocaml/ocaml/pulls/1867","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/comments/198936275"},"html":{"href":"https://github.com/ocaml/ocaml/pull/1867#discussion_r198936275"},"pull_request":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/1867"}},"in_reply_to_id":198934194},"pull_request":{"url":"https://api.github.com/repos/ocaml/ocaml/pulls/1867","id":198108711,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MTA4NzEx","html_url":"https://github.com/ocaml/ocaml/pull/1867","diff_url":"https://github.com/ocaml/ocaml/pull/1867.diff","patch_url":"https://github.com/ocaml/ocaml/pull/1867.patch","issue_url":"https://api.github.com/repos/ocaml/ocaml/issues/1867","number":1867,"state":"open","locked":false,"title":"Remove the C plugins mechanism","user":{"login":"xavierleroy","id":3845810,"node_id":"MDQ6VXNlcjM4NDU4MTA=","avatar_url":"https://avatars0.githubusercontent.com/u/3845810?v=4","gravatar_id":"","url":"https://api.github.com/users/xavierleroy","html_url":"https://github.com/xavierleroy","followers_url":"https://api.github.com/users/xavierleroy/followers","following_url":"https://api.github.com/users/xavierleroy/following{/other_user}","gists_url":"https://api.github.com/users/xavierleroy/gists{/gist_id}","starred_url":"https://api.github.com/users/xavierleroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xavierleroy/subscriptions","organizations_url":"https://api.github.com/users/xavierleroy/orgs","repos_url":"https://api.github.com/users/xavierleroy/repos","events_url":"https://api.github.com/users/xavierleroy/events{/privacy}","received_events_url":"https://api.github.com/users/xavierleroy/received_events","type":"User","site_admin":false},"body":"The C plugins mechanism was introduced by @lefessan in #668 to support interception for some system calls in the OCaml runtime system.\r\n\r\nTwo years and a [CVE](https://nvd.nist.gov/vuln/detail/CVE-2017-9772) later, it's unclear that this mechanism is used at all. Moreover, it complicates the runtime system and is not very general (only a few system functions are instrumented). There are other ways to intercept system calls that are more general and require no modification to the source code of the runtime system.\r\n\r\nFollowing discussions with other core Caml developers, this PR proposes to jsut remove this plugin mechanism. Let the discussion begin!\r\n\r\n\r\n","created_at":"2018-06-28T18:04:24Z","updated_at":"2018-06-28T18:12:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"567d16b8524f0bbb014f993f7c2b66dd67e6da74","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ocaml/ocaml/pulls/1867/commits","review_comments_url":"https://api.github.com/repos/ocaml/ocaml/pulls/1867/comments","review_comment_url":"https://api.github.com/repos/ocaml/ocaml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ocaml/ocaml/issues/1867/comments","statuses_url":"https://api.github.com/repos/ocaml/ocaml/statuses/4f23048e36a26b025d5ecd925fcffb9412ebb46c","head":{"label":"xavierleroy:no-cplugins","ref":"no-cplugins","sha":"4f23048e36a26b025d5ecd925fcffb9412ebb46c","user":{"login":"xavierleroy","id":3845810,"node_id":"MDQ6VXNlcjM4NDU4MTA=","avatar_url":"https://avatars0.githubusercontent.com/u/3845810?v=4","gravatar_id":"","url":"https://api.github.com/users/xavierleroy","html_url":"https://github.com/xavierleroy","followers_url":"https://api.github.com/users/xavierleroy/followers","following_url":"https://api.github.com/users/xavierleroy/following{/other_user}","gists_url":"https://api.github.com/users/xavierleroy/gists{/gist_id}","starred_url":"https://api.github.com/users/xavierleroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xavierleroy/subscriptions","organizations_url":"https://api.github.com/users/xavierleroy/orgs","repos_url":"https://api.github.com/users/xavierleroy/repos","events_url":"https://api.github.com/users/xavierleroy/events{/privacy}","received_events_url":"https://api.github.com/users/xavierleroy/received_events","type":"User","site_admin":false},"repo":{"id":45117244,"node_id":"MDEwOlJlcG9zaXRvcnk0NTExNzI0NA==","name":"ocaml","full_name":"xavierleroy/ocaml","owner":{"login":"xavierleroy","id":3845810,"node_id":"MDQ6VXNlcjM4NDU4MTA=","avatar_url":"https://avatars0.githubusercontent.com/u/3845810?v=4","gravatar_id":"","url":"https://api.github.com/users/xavierleroy","html_url":"https://github.com/xavierleroy","followers_url":"https://api.github.com/users/xavierleroy/followers","following_url":"https://api.github.com/users/xavierleroy/following{/other_user}","gists_url":"https://api.github.com/users/xavierleroy/gists{/gist_id}","starred_url":"https://api.github.com/users/xavierleroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xavierleroy/subscriptions","organizations_url":"https://api.github.com/users/xavierleroy/orgs","repos_url":"https://api.github.com/users/xavierleroy/repos","events_url":"https://api.github.com/users/xavierleroy/events{/privacy}","received_events_url":"https://api.github.com/users/xavierleroy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xavierleroy/ocaml","description":"The core OCaml system: compilers, runtime system, base libraries","fork":true,"url":"https://api.github.com/repos/xavierleroy/ocaml","forks_url":"https://api.github.com/repos/xavierleroy/ocaml/forks","keys_url":"https://api.github.com/repos/xavierleroy/ocaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xavierleroy/ocaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xavierleroy/ocaml/teams","hooks_url":"https://api.github.com/repos/xavierleroy/ocaml/hooks","issue_events_url":"https://api.github.com/repos/xavierleroy/ocaml/issues/events{/number}","events_url":"https://api.github.com/repos/xavierleroy/ocaml/events","assignees_url":"https://api.github.com/repos/xavierleroy/ocaml/assignees{/user}","branches_url":"https://api.github.com/repos/xavierleroy/ocaml/branches{/branch}","tags_url":"https://api.github.com/repos/xavierleroy/ocaml/tags","blobs_url":"https://api.github.com/repos/xavierleroy/ocaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xavierleroy/ocaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xavierleroy/ocaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/xavierleroy/ocaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xavierleroy/ocaml/statuses/{sha}","languages_url":"https://api.github.com/repos/xavierleroy/ocaml/languages","stargazers_url":"https://api.github.com/repos/xavierleroy/ocaml/stargazers","contributors_url":"https://api.github.com/repos/xavierleroy/ocaml/contributors","subscribers_url":"https://api.github.com/repos/xavierleroy/ocaml/subscribers","subscription_url":"https://api.github.com/repos/xavierleroy/ocaml/subscription","commits_url":"https://api.github.com/repos/xavierleroy/ocaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/xavierleroy/ocaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/xavierleroy/ocaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/xavierleroy/ocaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/xavierleroy/ocaml/contents/{+path}","compare_url":"https://api.github.com/repos/xavierleroy/ocaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xavierleroy/ocaml/merges","archive_url":"https://api.github.com/repos/xavierleroy/ocaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xavierleroy/ocaml/downloads","issues_url":"https://api.github.com/repos/xavierleroy/ocaml/issues{/number}","pulls_url":"https://api.github.com/repos/xavierleroy/ocaml/pulls{/number}","milestones_url":"https://api.github.com/repos/xavierleroy/ocaml/milestones{/number}","notifications_url":"https://api.github.com/repos/xavierleroy/ocaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xavierleroy/ocaml/labels{/name}","releases_url":"https://api.github.com/repos/xavierleroy/ocaml/releases{/id}","deployments_url":"https://api.github.com/repos/xavierleroy/ocaml/deployments","created_at":"2015-10-28T14:17:04Z","updated_at":"2018-06-08T07:38:39Z","pushed_at":"2018-06-28T17:53:47Z","git_url":"git://github.com/xavierleroy/ocaml.git","ssh_url":"[email protected]:xavierleroy/ocaml.git","clone_url":"https://github.com/xavierleroy/ocaml.git","svn_url":"https://github.com/xavierleroy/ocaml","homepage":"","size":146502,"stargazers_count":2,"watchers_count":2,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":2,"default_branch":"trunk"}},"base":{"label":"ocaml:trunk","ref":"trunk","sha":"d3e73595e55e84250fa77f04e9c239dee1224b7b","user":{"login":"ocaml","id":1841483,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NDE0ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/1841483?v=4","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"repo":{"id":6786166,"node_id":"MDEwOlJlcG9zaXRvcnk2Nzg2MTY2","name":"ocaml","full_name":"ocaml/ocaml","owner":{"login":"ocaml","id":1841483,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NDE0ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/1841483?v=4","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ocaml/ocaml","description":"The core OCaml system: compilers, runtime system, base libraries","fork":false,"url":"https://api.github.com/repos/ocaml/ocaml","forks_url":"https://api.github.com/repos/ocaml/ocaml/forks","keys_url":"https://api.github.com/repos/ocaml/ocaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocaml/ocaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocaml/ocaml/teams","hooks_url":"https://api.github.com/repos/ocaml/ocaml/hooks","issue_events_url":"https://api.github.com/repos/ocaml/ocaml/issues/events{/number}","events_url":"https://api.github.com/repos/ocaml/ocaml/events","assignees_url":"https://api.github.com/repos/ocaml/ocaml/assignees{/user}","branches_url":"https://api.github.com/repos/ocaml/ocaml/branches{/branch}","tags_url":"https://api.github.com/repos/ocaml/ocaml/tags","blobs_url":"https://api.github.com/repos/ocaml/ocaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocaml/ocaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocaml/ocaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocaml/ocaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocaml/ocaml/statuses/{sha}","languages_url":"https://api.github.com/repos/ocaml/ocaml/languages","stargazers_url":"https://api.github.com/repos/ocaml/ocaml/stargazers","contributors_url":"https://api.github.com/repos/ocaml/ocaml/contributors","subscribers_url":"https://api.github.com/repos/ocaml/ocaml/subscribers","subscription_url":"https://api.github.com/repos/ocaml/ocaml/subscription","commits_url":"https://api.github.com/repos/ocaml/ocaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocaml/ocaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocaml/ocaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocaml/ocaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocaml/ocaml/contents/{+path}","compare_url":"https://api.github.com/repos/ocaml/ocaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocaml/ocaml/merges","archive_url":"https://api.github.com/repos/ocaml/ocaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocaml/ocaml/downloads","issues_url":"https://api.github.com/repos/ocaml/ocaml/issues{/number}","pulls_url":"https://api.github.com/repos/ocaml/ocaml/pulls{/number}","milestones_url":"https://api.github.com/repos/ocaml/ocaml/milestones{/number}","notifications_url":"https://api.github.com/repos/ocaml/ocaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocaml/ocaml/labels{/name}","releases_url":"https://api.github.com/repos/ocaml/ocaml/releases{/id}","deployments_url":"https://api.github.com/repos/ocaml/ocaml/deployments","created_at":"2012-11-20T22:18:22Z","updated_at":"2018-06-28T15:52:43Z","pushed_at":"2018-06-28T18:04:25Z","git_url":"git://github.com/ocaml/ocaml.git","ssh_url":"[email protected]:ocaml/ocaml.git","clone_url":"https://github.com/ocaml/ocaml.git","svn_url":"https://github.com/ocaml/ocaml","homepage":"","size":172324,"stargazers_count":1861,"watchers_count":1861,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":467,"mirror_url":null,"archived":false,"open_issues_count":157,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":467,"open_issues":157,"watchers":1861,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/1867"},"html":{"href":"https://github.com/ocaml/ocaml/pull/1867"},"issue":{"href":"https://api.github.com/repos/ocaml/ocaml/issues/1867"},"comments":{"href":"https://api.github.com/repos/ocaml/ocaml/issues/1867/comments"},"review_comments":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/1867/comments"},"review_comment":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/1867/commits"},"statuses":{"href":"https://api.github.com/repos/ocaml/ocaml/statuses/4f23048e36a26b025d5ecd925fcffb9412ebb46c"}},"author_association":"CONTRIBUTOR"}} | {
"id": 6786166,
"name": "ocaml/ocaml",
"url": "https://api.github.com/repos/ocaml/ocaml"
} | {
"id": 5250680,
"login": "dra27",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5250680?",
"url": "https://api.github.com/users/dra27"
} | {
"id": 1841483,
"login": "ocaml",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1841483?",
"url": "https://api.github.com/orgs/ocaml"
} | 2018-06-28T18:12:40 | 7893483351 | {"actor":{"display_login":"dra27"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/spatialdev/osmquality/pulls/comments/244546478","pull_request_review_id":188451861,"id":244546478,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDU0NjQ3OA==","diff_hunk":"@@ -0,0 +1,204 @@\n+import json\n+import numpy as np\n+import os\n+import csv\n+import sys\n+import matplotlib\n+matplotlib.use('Agg')\n+import matplotlib.pyplot as plt\n+\n+\n+class Utility:\n+ \"\"\" Uitlity class.\n+\n+ This class consists of several file-writer and data-generator functions and a distribution-computation function.\n+ \n+ \"\"\"\n+ \n+ def __init__(self):\n+ \"\"\" The docstring of the __init__ method.\n+\n+ write out a blank line to standard error\n+ \n+ \"\"\"\n+ sys.stderr.write('\\n')\n+\n+ def __del__(self):\n+ \"\"\" The doctring of the __del__ method.\n+\n+ write out a message of deleting Utility module to standard error\n+ \n+ \"\"\"\n+ sys.stderr.write(\"deling\" + str(self) + '\\n')","path":"utility.py","position":null,"original_position":32,"commit_id":"270da3ee13481c6ce02982753cb7db177fe4dbb4","original_commit_id":"6ec7be2cada263b93c234d7c50447b45ee003f1c","user":{"login":"Li-Yun","id":12319140,"node_id":"MDQ6VXNlcjEyMzE5MTQw","avatar_url":"https://avatars3.githubusercontent.com/u/12319140?v=4","gravatar_id":"","url":"https://api.github.com/users/Li-Yun","html_url":"https://github.com/Li-Yun","followers_url":"https://api.github.com/users/Li-Yun/followers","following_url":"https://api.github.com/users/Li-Yun/following{/other_user}","gists_url":"https://api.github.com/users/Li-Yun/gists{/gist_id}","starred_url":"https://api.github.com/users/Li-Yun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Li-Yun/subscriptions","organizations_url":"https://api.github.com/users/Li-Yun/orgs","repos_url":"https://api.github.com/users/Li-Yun/repos","events_url":"https://api.github.com/users/Li-Yun/events{/privacy}","received_events_url":"https://api.github.com/users/Li-Yun/received_events","type":"User","site_admin":false},"body":"fixed.","created_at":"2018-12-30T22:11:14Z","updated_at":"2018-12-30T22:11:14Z","html_url":"https://github.com/spatialdev/osmquality/pull/1#discussion_r244546478","pull_request_url":"https://api.github.com/repos/spatialdev/osmquality/pulls/1","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/spatialdev/osmquality/pulls/comments/244546478"},"html":{"href":"https://github.com/spatialdev/osmquality/pull/1#discussion_r244546478"},"pull_request":{"href":"https://api.github.com/repos/spatialdev/osmquality/pulls/1"}},"in_reply_to_id":238830237},"pull_request":{"url":"https://api.github.com/repos/spatialdev/osmquality/pulls/1","id":219497137,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NDk3MTM3","html_url":"https://github.com/spatialdev/osmquality/pull/1","diff_url":"https://github.com/spatialdev/osmquality/pull/1.diff","patch_url":"https://github.com/spatialdev/osmquality/pull/1.patch","issue_url":"https://api.github.com/repos/spatialdev/osmquality/issues/1","number":1,"state":"open","locked":false,"title":"Mqm","user":{"login":"Li-Yun","id":12319140,"node_id":"MDQ6VXNlcjEyMzE5MTQw","avatar_url":"https://avatars3.githubusercontent.com/u/12319140?v=4","gravatar_id":"","url":"https://api.github.com/users/Li-Yun","html_url":"https://github.com/Li-Yun","followers_url":"https://api.github.com/users/Li-Yun/followers","following_url":"https://api.github.com/users/Li-Yun/following{/other_user}","gists_url":"https://api.github.com/users/Li-Yun/gists{/gist_id}","starred_url":"https://api.github.com/users/Li-Yun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Li-Yun/subscriptions","organizations_url":"https://api.github.com/users/Li-Yun/orgs","repos_url":"https://api.github.com/users/Li-Yun/repos","events_url":"https://api.github.com/users/Li-Yun/events{/privacy}","received_events_url":"https://api.github.com/users/Li-Yun/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-01T19:59:59Z","updated_at":"2018-12-30T22:11:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"783328468495b0d19ef1225b97ee9b2151ac100c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"danielduhh","id":1947857,"node_id":"MDQ6VXNlcjE5NDc4NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1947857?v=4","gravatar_id":"","url":"https://api.github.com/users/danielduhh","html_url":"https://github.com/danielduhh","followers_url":"https://api.github.com/users/danielduhh/followers","following_url":"https://api.github.com/users/danielduhh/following{/other_user}","gists_url":"https://api.github.com/users/danielduhh/gists{/gist_id}","starred_url":"https://api.github.com/users/danielduhh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielduhh/subscriptions","organizations_url":"https://api.github.com/users/danielduhh/orgs","repos_url":"https://api.github.com/users/danielduhh/repos","events_url":"https://api.github.com/users/danielduhh/events{/privacy}","received_events_url":"https://api.github.com/users/danielduhh/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spatialdev/osmquality/pulls/1/commits","review_comments_url":"https://api.github.com/repos/spatialdev/osmquality/pulls/1/comments","review_comment_url":"https://api.github.com/repos/spatialdev/osmquality/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spatialdev/osmquality/issues/1/comments","statuses_url":"https://api.github.com/repos/spatialdev/osmquality/statuses/270da3ee13481c6ce02982753cb7db177fe4dbb4","head":{"label":"Li-Yun:MQM","ref":"MQM","sha":"270da3ee13481c6ce02982753cb7db177fe4dbb4","user":{"login":"Li-Yun","id":12319140,"node_id":"MDQ6VXNlcjEyMzE5MTQw","avatar_url":"https://avatars3.githubusercontent.com/u/12319140?v=4","gravatar_id":"","url":"https://api.github.com/users/Li-Yun","html_url":"https://github.com/Li-Yun","followers_url":"https://api.github.com/users/Li-Yun/followers","following_url":"https://api.github.com/users/Li-Yun/following{/other_user}","gists_url":"https://api.github.com/users/Li-Yun/gists{/gist_id}","starred_url":"https://api.github.com/users/Li-Yun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Li-Yun/subscriptions","organizations_url":"https://api.github.com/users/Li-Yun/orgs","repos_url":"https://api.github.com/users/Li-Yun/repos","events_url":"https://api.github.com/users/Li-Yun/events{/privacy}","received_events_url":"https://api.github.com/users/Li-Yun/received_events","type":"User","site_admin":false},"repo":{"id":151125168,"node_id":"MDEwOlJlcG9zaXRvcnkxNTExMjUxNjg=","name":"osmquality","full_name":"Li-Yun/osmquality","private":false,"owner":{"login":"Li-Yun","id":12319140,"node_id":"MDQ6VXNlcjEyMzE5MTQw","avatar_url":"https://avatars3.githubusercontent.com/u/12319140?v=4","gravatar_id":"","url":"https://api.github.com/users/Li-Yun","html_url":"https://github.com/Li-Yun","followers_url":"https://api.github.com/users/Li-Yun/followers","following_url":"https://api.github.com/users/Li-Yun/following{/other_user}","gists_url":"https://api.github.com/users/Li-Yun/gists{/gist_id}","starred_url":"https://api.github.com/users/Li-Yun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Li-Yun/subscriptions","organizations_url":"https://api.github.com/users/Li-Yun/orgs","repos_url":"https://api.github.com/users/Li-Yun/repos","events_url":"https://api.github.com/users/Li-Yun/events{/privacy}","received_events_url":"https://api.github.com/users/Li-Yun/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Li-Yun/osmquality","description":"Heat map approach to summarizing OpenStreetMap errors within relevant grids ","fork":true,"url":"https://api.github.com/repos/Li-Yun/osmquality","forks_url":"https://api.github.com/repos/Li-Yun/osmquality/forks","keys_url":"https://api.github.com/repos/Li-Yun/osmquality/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Li-Yun/osmquality/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Li-Yun/osmquality/teams","hooks_url":"https://api.github.com/repos/Li-Yun/osmquality/hooks","issue_events_url":"https://api.github.com/repos/Li-Yun/osmquality/issues/events{/number}","events_url":"https://api.github.com/repos/Li-Yun/osmquality/events","assignees_url":"https://api.github.com/repos/Li-Yun/osmquality/assignees{/user}","branches_url":"https://api.github.com/repos/Li-Yun/osmquality/branches{/branch}","tags_url":"https://api.github.com/repos/Li-Yun/osmquality/tags","blobs_url":"https://api.github.com/repos/Li-Yun/osmquality/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Li-Yun/osmquality/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Li-Yun/osmquality/git/refs{/sha}","trees_url":"https://api.github.com/repos/Li-Yun/osmquality/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Li-Yun/osmquality/statuses/{sha}","languages_url":"https://api.github.com/repos/Li-Yun/osmquality/languages","stargazers_url":"https://api.github.com/repos/Li-Yun/osmquality/stargazers","contributors_url":"https://api.github.com/repos/Li-Yun/osmquality/contributors","subscribers_url":"https://api.github.com/repos/Li-Yun/osmquality/subscribers","subscription_url":"https://api.github.com/repos/Li-Yun/osmquality/subscription","commits_url":"https://api.github.com/repos/Li-Yun/osmquality/commits{/sha}","git_commits_url":"https://api.github.com/repos/Li-Yun/osmquality/git/commits{/sha}","comments_url":"https://api.github.com/repos/Li-Yun/osmquality/comments{/number}","issue_comment_url":"https://api.github.com/repos/Li-Yun/osmquality/issues/comments{/number}","contents_url":"https://api.github.com/repos/Li-Yun/osmquality/contents/{+path}","compare_url":"https://api.github.com/repos/Li-Yun/osmquality/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Li-Yun/osmquality/merges","archive_url":"https://api.github.com/repos/Li-Yun/osmquality/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Li-Yun/osmquality/downloads","issues_url":"https://api.github.com/repos/Li-Yun/osmquality/issues{/number}","pulls_url":"https://api.github.com/repos/Li-Yun/osmquality/pulls{/number}","milestones_url":"https://api.github.com/repos/Li-Yun/osmquality/milestones{/number}","notifications_url":"https://api.github.com/repos/Li-Yun/osmquality/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Li-Yun/osmquality/labels{/name}","releases_url":"https://api.github.com/repos/Li-Yun/osmquality/releases{/id}","deployments_url":"https://api.github.com/repos/Li-Yun/osmquality/deployments","created_at":"2018-10-01T17:02:50Z","updated_at":"2018-10-01T17:02:52Z","pushed_at":"2018-12-30T22:02:27Z","git_url":"git://github.com/Li-Yun/osmquality.git","ssh_url":"[email protected]:Li-Yun/osmquality.git","clone_url":"https://github.com/Li-Yun/osmquality.git","svn_url":"https://github.com/Li-Yun/osmquality","homepage":null,"size":66,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spatialdev:master","ref":"master","sha":"0cd4158ffb39bfb96b46347c3d3718278fe3e67d","user":{"login":"spatialdev","id":1851648,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NTE2NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/1851648?v=4","gravatar_id":"","url":"https://api.github.com/users/spatialdev","html_url":"https://github.com/spatialdev","followers_url":"https://api.github.com/users/spatialdev/followers","following_url":"https://api.github.com/users/spatialdev/following{/other_user}","gists_url":"https://api.github.com/users/spatialdev/gists{/gist_id}","starred_url":"https://api.github.com/users/spatialdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatialdev/subscriptions","organizations_url":"https://api.github.com/users/spatialdev/orgs","repos_url":"https://api.github.com/users/spatialdev/repos","events_url":"https://api.github.com/users/spatialdev/events{/privacy}","received_events_url":"https://api.github.com/users/spatialdev/received_events","type":"Organization","site_admin":false},"repo":{"id":150300013,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAzMDAwMTM=","name":"osmquality","full_name":"spatialdev/osmquality","private":false,"owner":{"login":"spatialdev","id":1851648,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NTE2NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/1851648?v=4","gravatar_id":"","url":"https://api.github.com/users/spatialdev","html_url":"https://github.com/spatialdev","followers_url":"https://api.github.com/users/spatialdev/followers","following_url":"https://api.github.com/users/spatialdev/following{/other_user}","gists_url":"https://api.github.com/users/spatialdev/gists{/gist_id}","starred_url":"https://api.github.com/users/spatialdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatialdev/subscriptions","organizations_url":"https://api.github.com/users/spatialdev/orgs","repos_url":"https://api.github.com/users/spatialdev/repos","events_url":"https://api.github.com/users/spatialdev/events{/privacy}","received_events_url":"https://api.github.com/users/spatialdev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spatialdev/osmquality","description":"Heat map approach to summarizing OpenStreetMap errors within relevant grids ","fork":false,"url":"https://api.github.com/repos/spatialdev/osmquality","forks_url":"https://api.github.com/repos/spatialdev/osmquality/forks","keys_url":"https://api.github.com/repos/spatialdev/osmquality/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spatialdev/osmquality/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spatialdev/osmquality/teams","hooks_url":"https://api.github.com/repos/spatialdev/osmquality/hooks","issue_events_url":"https://api.github.com/repos/spatialdev/osmquality/issues/events{/number}","events_url":"https://api.github.com/repos/spatialdev/osmquality/events","assignees_url":"https://api.github.com/repos/spatialdev/osmquality/assignees{/user}","branches_url":"https://api.github.com/repos/spatialdev/osmquality/branches{/branch}","tags_url":"https://api.github.com/repos/spatialdev/osmquality/tags","blobs_url":"https://api.github.com/repos/spatialdev/osmquality/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spatialdev/osmquality/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spatialdev/osmquality/git/refs{/sha}","trees_url":"https://api.github.com/repos/spatialdev/osmquality/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spatialdev/osmquality/statuses/{sha}","languages_url":"https://api.github.com/repos/spatialdev/osmquality/languages","stargazers_url":"https://api.github.com/repos/spatialdev/osmquality/stargazers","contributors_url":"https://api.github.com/repos/spatialdev/osmquality/contributors","subscribers_url":"https://api.github.com/repos/spatialdev/osmquality/subscribers","subscription_url":"https://api.github.com/repos/spatialdev/osmquality/subscription","commits_url":"https://api.github.com/repos/spatialdev/osmquality/commits{/sha}","git_commits_url":"https://api.github.com/repos/spatialdev/osmquality/git/commits{/sha}","comments_url":"https://api.github.com/repos/spatialdev/osmquality/comments{/number}","issue_comment_url":"https://api.github.com/repos/spatialdev/osmquality/issues/comments{/number}","contents_url":"https://api.github.com/repos/spatialdev/osmquality/contents/{+path}","compare_url":"https://api.github.com/repos/spatialdev/osmquality/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spatialdev/osmquality/merges","archive_url":"https://api.github.com/repos/spatialdev/osmquality/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spatialdev/osmquality/downloads","issues_url":"https://api.github.com/repos/spatialdev/osmquality/issues{/number}","pulls_url":"https://api.github.com/repos/spatialdev/osmquality/pulls{/number}","milestones_url":"https://api.github.com/repos/spatialdev/osmquality/milestones{/number}","notifications_url":"https://api.github.com/repos/spatialdev/osmquality/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spatialdev/osmquality/labels{/name}","releases_url":"https://api.github.com/repos/spatialdev/osmquality/releases{/id}","deployments_url":"https://api.github.com/repos/spatialdev/osmquality/deployments","created_at":"2018-09-25T16:57:10Z","updated_at":"2018-09-25T16:57:13Z","pushed_at":"2018-12-30T22:02:28Z","git_url":"git://github.com/spatialdev/osmquality.git","ssh_url":"[email protected]:spatialdev/osmquality.git","clone_url":"https://github.com/spatialdev/osmquality.git","svn_url":"https://github.com/spatialdev/osmquality","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spatialdev/osmquality/pulls/1"},"html":{"href":"https://github.com/spatialdev/osmquality/pull/1"},"issue":{"href":"https://api.github.com/repos/spatialdev/osmquality/issues/1"},"comments":{"href":"https://api.github.com/repos/spatialdev/osmquality/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/spatialdev/osmquality/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/spatialdev/osmquality/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spatialdev/osmquality/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/spatialdev/osmquality/statuses/270da3ee13481c6ce02982753cb7db177fe4dbb4"}},"author_association":"COLLABORATOR"}} | {
"id": 150300013,
"name": "spatialdev/osmquality",
"url": "https://api.github.com/repos/spatialdev/osmquality"
} | {
"id": 12319140,
"login": "Li-Yun",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12319140?",
"url": "https://api.github.com/users/Li-Yun"
} | {
"id": 1851648,
"login": "spatialdev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1851648?",
"url": "https://api.github.com/orgs/spatialdev"
} | 2018-12-30T22:11:14 | 8817310991 | {"actor":{"display_login":"Li-Yun"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/cerner/terra-core/pulls/comments/231094944","pull_request_review_id":171982388,"id":231094944,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTA5NDk0NA==","diff_hunk":"@@ -1,16 +1,11 @@\n-const {\n- viewports,\n- withActionsThemeables,\n- withoutActionsThemeables,\n-} = require('./common');\n+const { viewports } = require('./common');\n \n describe('ActionFooter', () => {\n describe('Empty', () => {","path":"packages/terra-action-footer/tests/wdio/action-footer-spec.js","position":9,"original_position":9,"commit_id":"49a2f11b89dba323f140a8728c14bc0d868ddc96","original_commit_id":"f46d16aa672c8709ba4e66eaef12b4d93bf9bc80","user":{"login":"bjankord","id":633148,"node_id":"MDQ6VXNlcjYzMzE0OA==","avatar_url":"https://avatars1.githubusercontent.com/u/633148?v=4","gravatar_id":"","url":"https://api.github.com/users/bjankord","html_url":"https://github.com/bjankord","followers_url":"https://api.github.com/users/bjankord/followers","following_url":"https://api.github.com/users/bjankord/following{/other_user}","gists_url":"https://api.github.com/users/bjankord/gists{/gist_id}","starred_url":"https://api.github.com/users/bjankord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjankord/subscriptions","organizations_url":"https://api.github.com/users/bjankord/orgs","repos_url":"https://api.github.com/users/bjankord/repos","events_url":"https://api.github.com/users/bjankord/events{/privacy}","received_events_url":"https://api.github.com/users/bjankord/received_events","type":"User","site_admin":false},"body":"Let's remove it.","created_at":"2018-11-06T11:56:22Z","updated_at":"2018-11-06T11:56:22Z","html_url":"https://github.com/cerner/terra-core/pull/2021#discussion_r231094944","pull_request_url":"https://api.github.com/repos/cerner/terra-core/pulls/2021","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/cerner/terra-core/pulls/comments/231094944"},"html":{"href":"https://github.com/cerner/terra-core/pull/2021#discussion_r231094944"},"pull_request":{"href":"https://api.github.com/repos/cerner/terra-core/pulls/2021"}},"in_reply_to_id":230907133},"pull_request":{"url":"https://api.github.com/repos/cerner/terra-core/pulls/2021","id":228429815,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NDI5ODE1","html_url":"https://github.com/cerner/terra-core/pull/2021","diff_url":"https://github.com/cerner/terra-core/pull/2021.diff","patch_url":"https://github.com/cerner/terra-core/pull/2021.patch","issue_url":"https://api.github.com/repos/cerner/terra-core/issues/2021","number":2021,"state":"open","locked":false,"title":"[terra-action-footer] - Restructure theme tests","user":{"login":"StephenEsser","id":6720991,"node_id":"MDQ6VXNlcjY3MjA5OTE=","avatar_url":"https://avatars0.githubusercontent.com/u/6720991?v=4","gravatar_id":"","url":"https://api.github.com/users/StephenEsser","html_url":"https://github.com/StephenEsser","followers_url":"https://api.github.com/users/StephenEsser/followers","following_url":"https://api.github.com/users/StephenEsser/following{/other_user}","gists_url":"https://api.github.com/users/StephenEsser/gists{/gist_id}","starred_url":"https://api.github.com/users/StephenEsser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StephenEsser/subscriptions","organizations_url":"https://api.github.com/users/StephenEsser/orgs","repos_url":"https://api.github.com/users/StephenEsser/repos","events_url":"https://api.github.com/users/StephenEsser/events{/privacy}","received_events_url":"https://api.github.com/users/StephenEsser/received_events","type":"User","site_admin":false},"body":"### Summary\r\nMoved theme tests into a separate file and theme directory.\r\n\r\n### Additional Details\r\nPart of #2006 \r\n\r\nThanks for contributing to Terra. \r\n@cerner/terra\r\n\r\n[CONTRIBUTORS.md]: ../blob/master/CONTRIBUTORS.md\r\n[License]: ../blob/master/LICENSE\r\n","created_at":"2018-11-05T17:22:41Z","updated_at":"2018-11-06T11:56:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d0eb4eae078f1017a3fcacee293bc7d2e89da93","assignee":{"login":"StephenEsser","id":6720991,"node_id":"MDQ6VXNlcjY3MjA5OTE=","avatar_url":"https://avatars0.githubusercontent.com/u/6720991?v=4","gravatar_id":"","url":"https://api.github.com/users/StephenEsser","html_url":"https://github.com/StephenEsser","followers_url":"https://api.github.com/users/StephenEsser/followers","following_url":"https://api.github.com/users/StephenEsser/following{/other_user}","gists_url":"https://api.github.com/users/StephenEsser/gists{/gist_id}","starred_url":"https://api.github.com/users/StephenEsser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StephenEsser/subscriptions","organizations_url":"https://api.github.com/users/StephenEsser/orgs","repos_url":"https://api.github.com/users/StephenEsser/repos","events_url":"https://api.github.com/users/StephenEsser/events{/privacy}","received_events_url":"https://api.github.com/users/StephenEsser/received_events","type":"User","site_admin":false},"assignees":[{"login":"StephenEsser","id":6720991,"node_id":"MDQ6VXNlcjY3MjA5OTE=","avatar_url":"https://avatars0.githubusercontent.com/u/6720991?v=4","gravatar_id":"","url":"https://api.github.com/users/StephenEsser","html_url":"https://github.com/StephenEsser","followers_url":"https://api.github.com/users/StephenEsser/followers","following_url":"https://api.github.com/users/StephenEsser/following{/other_user}","gists_url":"https://api.github.com/users/StephenEsser/gists{/gist_id}","starred_url":"https://api.github.com/users/StephenEsser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StephenEsser/subscriptions","organizations_url":"https://api.github.com/users/StephenEsser/orgs","repos_url":"https://api.github.com/users/StephenEsser/repos","events_url":"https://api.github.com/users/StephenEsser/events{/privacy}","received_events_url":"https://api.github.com/users/StephenEsser/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"bjankord","id":633148,"node_id":"MDQ6VXNlcjYzMzE0OA==","avatar_url":"https://avatars1.githubusercontent.com/u/633148?v=4","gravatar_id":"","url":"https://api.github.com/users/bjankord","html_url":"https://github.com/bjankord","followers_url":"https://api.github.com/users/bjankord/followers","following_url":"https://api.github.com/users/bjankord/following{/other_user}","gists_url":"https://api.github.com/users/bjankord/gists{/gist_id}","starred_url":"https://api.github.com/users/bjankord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjankord/subscriptions","organizations_url":"https://api.github.com/users/bjankord/orgs","repos_url":"https://api.github.com/users/bjankord/repos","events_url":"https://api.github.com/users/bjankord/events{/privacy}","received_events_url":"https://api.github.com/users/bjankord/received_events","type":"User","site_admin":false},{"login":"mjhenkes","id":1588747,"node_id":"MDQ6VXNlcjE1ODg3NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/1588747?v=4","gravatar_id":"","url":"https://api.github.com/users/mjhenkes","html_url":"https://github.com/mjhenkes","followers_url":"https://api.github.com/users/mjhenkes/followers","following_url":"https://api.github.com/users/mjhenkes/following{/other_user}","gists_url":"https://api.github.com/users/mjhenkes/gists{/gist_id}","starred_url":"https://api.github.com/users/mjhenkes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjhenkes/subscriptions","organizations_url":"https://api.github.com/users/mjhenkes/orgs","repos_url":"https://api.github.com/users/mjhenkes/repos","events_url":"https://api.github.com/users/mjhenkes/events{/privacy}","received_events_url":"https://api.github.com/users/mjhenkes/received_events","type":"User","site_admin":false},{"login":"tbiethman","id":1711637,"node_id":"MDQ6VXNlcjE3MTE2Mzc=","avatar_url":"https://avatars3.githubusercontent.com/u/1711637?v=4","gravatar_id":"","url":"https://api.github.com/users/tbiethman","html_url":"https://github.com/tbiethman","followers_url":"https://api.github.com/users/tbiethman/followers","following_url":"https://api.github.com/users/tbiethman/following{/other_user}","gists_url":"https://api.github.com/users/tbiethman/gists{/gist_id}","starred_url":"https://api.github.com/users/tbiethman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbiethman/subscriptions","organizations_url":"https://api.github.com/users/tbiethman/orgs","repos_url":"https://api.github.com/users/tbiethman/repos","events_url":"https://api.github.com/users/tbiethman/events{/privacy}","received_events_url":"https://api.github.com/users/tbiethman/received_events","type":"User","site_admin":false},{"login":"JakeLaCombe","id":2552573,"node_id":"MDQ6VXNlcjI1NTI1NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/2552573?v=4","gravatar_id":"","url":"https://api.github.com/users/JakeLaCombe","html_url":"https://github.com/JakeLaCombe","followers_url":"https://api.github.com/users/JakeLaCombe/followers","following_url":"https://api.github.com/users/JakeLaCombe/following{/other_user}","gists_url":"https://api.github.com/users/JakeLaCombe/gists{/gist_id}","starred_url":"https://api.github.com/users/JakeLaCombe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JakeLaCombe/subscriptions","organizations_url":"https://api.github.com/users/JakeLaCombe/orgs","repos_url":"https://api.github.com/users/JakeLaCombe/repos","events_url":"https://api.github.com/users/JakeLaCombe/events{/privacy}","received_events_url":"https://api.github.com/users/JakeLaCombe/received_events","type":"User","site_admin":false},{"login":"ryanthemanuel","id":4873279,"node_id":"MDQ6VXNlcjQ4NzMyNzk=","avatar_url":"https://avatars3.githubusercontent.com/u/4873279?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanthemanuel","html_url":"https://github.com/ryanthemanuel","followers_url":"https://api.github.com/users/ryanthemanuel/followers","following_url":"https://api.github.com/users/ryanthemanuel/following{/other_user}","gists_url":"https://api.github.com/users/ryanthemanuel/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanthemanuel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanthemanuel/subscriptions","organizations_url":"https://api.github.com/users/ryanthemanuel/orgs","repos_url":"https://api.github.com/users/ryanthemanuel/repos","events_url":"https://api.github.com/users/ryanthemanuel/events{/privacy}","received_events_url":"https://api.github.com/users/ryanthemanuel/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":847445018,"node_id":"MDU6TGFiZWw4NDc0NDUwMTg=","url":"https://api.github.com/repos/cerner/terra-core/labels/action%20footer","name":"action footer","color":"63d356","default":false},{"id":681010787,"node_id":"MDU6TGFiZWw2ODEwMTA3ODc=","url":"https://api.github.com/repos/cerner/terra-core/labels/testing","name":"testing","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cerner/terra-core/pulls/2021/commits","review_comments_url":"https://api.github.com/repos/cerner/terra-core/pulls/2021/comments","review_comment_url":"https://api.github.com/repos/cerner/terra-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cerner/terra-core/issues/2021/comments","statuses_url":"https://api.github.com/repos/cerner/terra-core/statuses/49a2f11b89dba323f140a8728c14bc0d868ddc96","head":{"label":"cerner:ActionFooterSpecs","ref":"ActionFooterSpecs","sha":"49a2f11b89dba323f140a8728c14bc0d868ddc96","user":{"login":"cerner","id":1873208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzMyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1873208?v=4","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"repo":{"id":83073156,"node_id":"MDEwOlJlcG9zaXRvcnk4MzA3MzE1Ng==","name":"terra-core","full_name":"cerner/terra-core","private":false,"owner":{"login":"cerner","id":1873208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzMyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1873208?v=4","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cerner/terra-core","description":"Terra offers a set of configurable React components designed to help build scalable and modular application UIs. The library easily integrates with webpack-based workflows and was created to solve real-world issues in projects we work on day to day.","fork":false,"url":"https://api.github.com/repos/cerner/terra-core","forks_url":"https://api.github.com/repos/cerner/terra-core/forks","keys_url":"https://api.github.com/repos/cerner/terra-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cerner/terra-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cerner/terra-core/teams","hooks_url":"https://api.github.com/repos/cerner/terra-core/hooks","issue_events_url":"https://api.github.com/repos/cerner/terra-core/issues/events{/number}","events_url":"https://api.github.com/repos/cerner/terra-core/events","assignees_url":"https://api.github.com/repos/cerner/terra-core/assignees{/user}","branches_url":"https://api.github.com/repos/cerner/terra-core/branches{/branch}","tags_url":"https://api.github.com/repos/cerner/terra-core/tags","blobs_url":"https://api.github.com/repos/cerner/terra-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cerner/terra-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cerner/terra-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/cerner/terra-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cerner/terra-core/statuses/{sha}","languages_url":"https://api.github.com/repos/cerner/terra-core/languages","stargazers_url":"https://api.github.com/repos/cerner/terra-core/stargazers","contributors_url":"https://api.github.com/repos/cerner/terra-core/contributors","subscribers_url":"https://api.github.com/repos/cerner/terra-core/subscribers","subscription_url":"https://api.github.com/repos/cerner/terra-core/subscription","commits_url":"https://api.github.com/repos/cerner/terra-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/cerner/terra-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/cerner/terra-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/cerner/terra-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/cerner/terra-core/contents/{+path}","compare_url":"https://api.github.com/repos/cerner/terra-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cerner/terra-core/merges","archive_url":"https://api.github.com/repos/cerner/terra-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cerner/terra-core/downloads","issues_url":"https://api.github.com/repos/cerner/terra-core/issues{/number}","pulls_url":"https://api.github.com/repos/cerner/terra-core/pulls{/number}","milestones_url":"https://api.github.com/repos/cerner/terra-core/milestones{/number}","notifications_url":"https://api.github.com/repos/cerner/terra-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cerner/terra-core/labels{/name}","releases_url":"https://api.github.com/repos/cerner/terra-core/releases{/id}","deployments_url":"https://api.github.com/repos/cerner/terra-core/deployments","created_at":"2017-02-24T18:57:33Z","updated_at":"2018-11-05T18:02:53Z","pushed_at":"2018-11-05T22:20:50Z","git_url":"git://github.com/cerner/terra-core.git","ssh_url":"[email protected]:cerner/terra-core.git","clone_url":"https://github.com/cerner/terra-core.git","svn_url":"https://github.com/cerner/terra-core","homepage":"http://terra-ui.com","size":54492,"stargazers_count":108,"watchers_count":108,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":79,"mirror_url":null,"archived":false,"open_issues_count":188,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":79,"open_issues":188,"watchers":108,"default_branch":"master"}},"base":{"label":"cerner:master","ref":"master","sha":"3f07d070203796d623d5594badd825797f624168","user":{"login":"cerner","id":1873208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzMyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1873208?v=4","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"repo":{"id":83073156,"node_id":"MDEwOlJlcG9zaXRvcnk4MzA3MzE1Ng==","name":"terra-core","full_name":"cerner/terra-core","private":false,"owner":{"login":"cerner","id":1873208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzMyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1873208?v=4","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cerner/terra-core","description":"Terra offers a set of configurable React components designed to help build scalable and modular application UIs. The library easily integrates with webpack-based workflows and was created to solve real-world issues in projects we work on day to day.","fork":false,"url":"https://api.github.com/repos/cerner/terra-core","forks_url":"https://api.github.com/repos/cerner/terra-core/forks","keys_url":"https://api.github.com/repos/cerner/terra-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cerner/terra-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cerner/terra-core/teams","hooks_url":"https://api.github.com/repos/cerner/terra-core/hooks","issue_events_url":"https://api.github.com/repos/cerner/terra-core/issues/events{/number}","events_url":"https://api.github.com/repos/cerner/terra-core/events","assignees_url":"https://api.github.com/repos/cerner/terra-core/assignees{/user}","branches_url":"https://api.github.com/repos/cerner/terra-core/branches{/branch}","tags_url":"https://api.github.com/repos/cerner/terra-core/tags","blobs_url":"https://api.github.com/repos/cerner/terra-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cerner/terra-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cerner/terra-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/cerner/terra-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cerner/terra-core/statuses/{sha}","languages_url":"https://api.github.com/repos/cerner/terra-core/languages","stargazers_url":"https://api.github.com/repos/cerner/terra-core/stargazers","contributors_url":"https://api.github.com/repos/cerner/terra-core/contributors","subscribers_url":"https://api.github.com/repos/cerner/terra-core/subscribers","subscription_url":"https://api.github.com/repos/cerner/terra-core/subscription","commits_url":"https://api.github.com/repos/cerner/terra-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/cerner/terra-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/cerner/terra-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/cerner/terra-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/cerner/terra-core/contents/{+path}","compare_url":"https://api.github.com/repos/cerner/terra-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cerner/terra-core/merges","archive_url":"https://api.github.com/repos/cerner/terra-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cerner/terra-core/downloads","issues_url":"https://api.github.com/repos/cerner/terra-core/issues{/number}","pulls_url":"https://api.github.com/repos/cerner/terra-core/pulls{/number}","milestones_url":"https://api.github.com/repos/cerner/terra-core/milestones{/number}","notifications_url":"https://api.github.com/repos/cerner/terra-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cerner/terra-core/labels{/name}","releases_url":"https://api.github.com/repos/cerner/terra-core/releases{/id}","deployments_url":"https://api.github.com/repos/cerner/terra-core/deployments","created_at":"2017-02-24T18:57:33Z","updated_at":"2018-11-05T18:02:53Z","pushed_at":"2018-11-05T22:20:50Z","git_url":"git://github.com/cerner/terra-core.git","ssh_url":"[email protected]:cerner/terra-core.git","clone_url":"https://github.com/cerner/terra-core.git","svn_url":"https://github.com/cerner/terra-core","homepage":"http://terra-ui.com","size":54492,"stargazers_count":108,"watchers_count":108,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":79,"mirror_url":null,"archived":false,"open_issues_count":188,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":79,"open_issues":188,"watchers":108,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cerner/terra-core/pulls/2021"},"html":{"href":"https://github.com/cerner/terra-core/pull/2021"},"issue":{"href":"https://api.github.com/repos/cerner/terra-core/issues/2021"},"comments":{"href":"https://api.github.com/repos/cerner/terra-core/issues/2021/comments"},"review_comments":{"href":"https://api.github.com/repos/cerner/terra-core/pulls/2021/comments"},"review_comment":{"href":"https://api.github.com/repos/cerner/terra-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cerner/terra-core/pulls/2021/commits"},"statuses":{"href":"https://api.github.com/repos/cerner/terra-core/statuses/49a2f11b89dba323f140a8728c14bc0d868ddc96"}},"author_association":"CONTRIBUTOR"}} | {
"id": 83073156,
"name": "cerner/terra-core",
"url": "https://api.github.com/repos/cerner/terra-core"
} | {
"id": 633148,
"login": "bjankord",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/633148?",
"url": "https://api.github.com/users/bjankord"
} | {
"id": 1873208,
"login": "cerner",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1873208?",
"url": "https://api.github.com/orgs/cerner"
} | 2018-11-06T11:56:22 | 8542156115 | {"actor":{"display_login":"bjankord"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/cerner/terra-core/pulls/comments/243336551","pull_request_review_id":187080134,"id":243336551,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzMzNjU1MQ==","diff_hunk":"@@ -18,7 +18,7 @@\n background: #d3d4d5;\n border-radius: var(--terra-progress-bar-border-radius, 0.5em);\n display: block;\n- height: var(--terra-progress-bar-height-small, 0.8rem);\n+ height: var(--terra-progress-bar-small-height, 0.8rem);","path":"packages/terra-progress-bar/src/ProgressBar.module.scss","position":null,"original_position":5,"commit_id":"5c574263d2b9623f566e5a204c0aee960e26aadb","original_commit_id":"a3506cef10701a7f7581ac4212d9294c04917a28","user":{"login":"yuderekyu","id":14063284,"node_id":"MDQ6VXNlcjE0MDYzMjg0","avatar_url":"https://avatars0.githubusercontent.com/u/14063284?v=4","gravatar_id":"","url":"https://api.github.com/users/yuderekyu","html_url":"https://github.com/yuderekyu","followers_url":"https://api.github.com/users/yuderekyu/followers","following_url":"https://api.github.com/users/yuderekyu/following{/other_user}","gists_url":"https://api.github.com/users/yuderekyu/gists{/gist_id}","starred_url":"https://api.github.com/users/yuderekyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuderekyu/subscriptions","organizations_url":"https://api.github.com/users/yuderekyu/orgs","repos_url":"https://api.github.com/users/yuderekyu/repos","events_url":"https://api.github.com/users/yuderekyu/events{/privacy}","received_events_url":"https://api.github.com/users/yuderekyu/received_events","type":"User","site_admin":false},"body":"https://github.com/cerner/terra-core/pull/2125/commits/febefb0fcb70b1260987d9b4a6758f730eadba72","created_at":"2018-12-20T16:32:01Z","updated_at":"2018-12-20T16:32:02Z","html_url":"https://github.com/cerner/terra-core/pull/2125#discussion_r243336551","pull_request_url":"https://api.github.com/repos/cerner/terra-core/pulls/2125","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/cerner/terra-core/pulls/comments/243336551"},"html":{"href":"https://github.com/cerner/terra-core/pull/2125#discussion_r243336551"},"pull_request":{"href":"https://api.github.com/repos/cerner/terra-core/pulls/2125"}},"in_reply_to_id":243329927},"pull_request":{"url":"https://api.github.com/repos/cerner/terra-core/pulls/2125","id":238836758,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4ODM2NzU4","html_url":"https://github.com/cerner/terra-core/pull/2125","diff_url":"https://github.com/cerner/terra-core/pull/2125.diff","patch_url":"https://github.com/cerner/terra-core/pull/2125.patch","issue_url":"https://api.github.com/repos/cerner/terra-core/issues/2125","number":2125,"state":"open","locked":false,"title":"[theme-variables] Abide by stylelint theme variable rules","user":{"login":"BenBoersma","id":39568848,"node_id":"MDQ6VXNlcjM5NTY4ODQ4","avatar_url":"https://avatars2.githubusercontent.com/u/39568848?v=4","gravatar_id":"","url":"https://api.github.com/users/BenBoersma","html_url":"https://github.com/BenBoersma","followers_url":"https://api.github.com/users/BenBoersma/followers","following_url":"https://api.github.com/users/BenBoersma/following{/other_user}","gists_url":"https://api.github.com/users/BenBoersma/gists{/gist_id}","starred_url":"https://api.github.com/users/BenBoersma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenBoersma/subscriptions","organizations_url":"https://api.github.com/users/BenBoersma/orgs","repos_url":"https://api.github.com/users/BenBoersma/repos","events_url":"https://api.github.com/users/BenBoersma/events{/privacy}","received_events_url":"https://api.github.com/users/BenBoersma/received_events","type":"User","site_admin":false},"body":"### Summary\r\nRefactor terra-core theme variables to abide by style lint rules. \r\n\r\nThanks for contributing to Terra. \r\n@cerner/terra\r\n\r\n[CONTRIBUTORS.md]: ../blob/master/CONTRIBUTORS.md\r\n[License]: ../blob/master/LICENSE\r\n","created_at":"2018-12-14T20:41:21Z","updated_at":"2018-12-20T16:32:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a411aedca15efb8cfdf9a7ba0ac4495cfb752a4c","assignee":{"login":"yuderekyu","id":14063284,"node_id":"MDQ6VXNlcjE0MDYzMjg0","avatar_url":"https://avatars0.githubusercontent.com/u/14063284?v=4","gravatar_id":"","url":"https://api.github.com/users/yuderekyu","html_url":"https://github.com/yuderekyu","followers_url":"https://api.github.com/users/yuderekyu/followers","following_url":"https://api.github.com/users/yuderekyu/following{/other_user}","gists_url":"https://api.github.com/users/yuderekyu/gists{/gist_id}","starred_url":"https://api.github.com/users/yuderekyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuderekyu/subscriptions","organizations_url":"https://api.github.com/users/yuderekyu/orgs","repos_url":"https://api.github.com/users/yuderekyu/repos","events_url":"https://api.github.com/users/yuderekyu/events{/privacy}","received_events_url":"https://api.github.com/users/yuderekyu/received_events","type":"User","site_admin":false},"assignees":[{"login":"yuderekyu","id":14063284,"node_id":"MDQ6VXNlcjE0MDYzMjg0","avatar_url":"https://avatars0.githubusercontent.com/u/14063284?v=4","gravatar_id":"","url":"https://api.github.com/users/yuderekyu","html_url":"https://github.com/yuderekyu","followers_url":"https://api.github.com/users/yuderekyu/followers","following_url":"https://api.github.com/users/yuderekyu/following{/other_user}","gists_url":"https://api.github.com/users/yuderekyu/gists{/gist_id}","starred_url":"https://api.github.com/users/yuderekyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuderekyu/subscriptions","organizations_url":"https://api.github.com/users/yuderekyu/orgs","repos_url":"https://api.github.com/users/yuderekyu/repos","events_url":"https://api.github.com/users/yuderekyu/events{/privacy}","received_events_url":"https://api.github.com/users/yuderekyu/received_events","type":"User","site_admin":false},{"login":"BenBoersma","id":39568848,"node_id":"MDQ6VXNlcjM5NTY4ODQ4","avatar_url":"https://avatars2.githubusercontent.com/u/39568848?v=4","gravatar_id":"","url":"https://api.github.com/users/BenBoersma","html_url":"https://github.com/BenBoersma","followers_url":"https://api.github.com/users/BenBoersma/followers","following_url":"https://api.github.com/users/BenBoersma/following{/other_user}","gists_url":"https://api.github.com/users/BenBoersma/gists{/gist_id}","starred_url":"https://api.github.com/users/BenBoersma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenBoersma/subscriptions","organizations_url":"https://api.github.com/users/BenBoersma/orgs","repos_url":"https://api.github.com/users/BenBoersma/repos","events_url":"https://api.github.com/users/BenBoersma/events{/privacy}","received_events_url":"https://api.github.com/users/BenBoersma/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"mjhenkes","id":1588747,"node_id":"MDQ6VXNlcjE1ODg3NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/1588747?v=4","gravatar_id":"","url":"https://api.github.com/users/mjhenkes","html_url":"https://github.com/mjhenkes","followers_url":"https://api.github.com/users/mjhenkes/followers","following_url":"https://api.github.com/users/mjhenkes/following{/other_user}","gists_url":"https://api.github.com/users/mjhenkes/gists{/gist_id}","starred_url":"https://api.github.com/users/mjhenkes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjhenkes/subscriptions","organizations_url":"https://api.github.com/users/mjhenkes/orgs","repos_url":"https://api.github.com/users/mjhenkes/repos","events_url":"https://api.github.com/users/mjhenkes/events{/privacy}","received_events_url":"https://api.github.com/users/mjhenkes/received_events","type":"User","site_admin":false},{"login":"tbiethman","id":1711637,"node_id":"MDQ6VXNlcjE3MTE2Mzc=","avatar_url":"https://avatars3.githubusercontent.com/u/1711637?v=4","gravatar_id":"","url":"https://api.github.com/users/tbiethman","html_url":"https://github.com/tbiethman","followers_url":"https://api.github.com/users/tbiethman/followers","following_url":"https://api.github.com/users/tbiethman/following{/other_user}","gists_url":"https://api.github.com/users/tbiethman/gists{/gist_id}","starred_url":"https://api.github.com/users/tbiethman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbiethman/subscriptions","organizations_url":"https://api.github.com/users/tbiethman/orgs","repos_url":"https://api.github.com/users/tbiethman/repos","events_url":"https://api.github.com/users/tbiethman/events{/privacy}","received_events_url":"https://api.github.com/users/tbiethman/received_events","type":"User","site_admin":false},{"login":"JakeLaCombe","id":2552573,"node_id":"MDQ6VXNlcjI1NTI1NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/2552573?v=4","gravatar_id":"","url":"https://api.github.com/users/JakeLaCombe","html_url":"https://github.com/JakeLaCombe","followers_url":"https://api.github.com/users/JakeLaCombe/followers","following_url":"https://api.github.com/users/JakeLaCombe/following{/other_user}","gists_url":"https://api.github.com/users/JakeLaCombe/gists{/gist_id}","starred_url":"https://api.github.com/users/JakeLaCombe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JakeLaCombe/subscriptions","organizations_url":"https://api.github.com/users/JakeLaCombe/orgs","repos_url":"https://api.github.com/users/JakeLaCombe/repos","events_url":"https://api.github.com/users/JakeLaCombe/events{/privacy}","received_events_url":"https://api.github.com/users/JakeLaCombe/received_events","type":"User","site_admin":false},{"login":"ryanthemanuel","id":4873279,"node_id":"MDQ6VXNlcjQ4NzMyNzk=","avatar_url":"https://avatars3.githubusercontent.com/u/4873279?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanthemanuel","html_url":"https://github.com/ryanthemanuel","followers_url":"https://api.github.com/users/ryanthemanuel/followers","following_url":"https://api.github.com/users/ryanthemanuel/following{/other_user}","gists_url":"https://api.github.com/users/ryanthemanuel/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanthemanuel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanthemanuel/subscriptions","organizations_url":"https://api.github.com/users/ryanthemanuel/orgs","repos_url":"https://api.github.com/users/ryanthemanuel/repos","events_url":"https://api.github.com/users/ryanthemanuel/events{/privacy}","received_events_url":"https://api.github.com/users/ryanthemanuel/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":634724816,"node_id":"MDU6TGFiZWw2MzQ3MjQ4MTY=","url":"https://api.github.com/repos/cerner/terra-core/labels/tech-only","name":"tech-only","color":"bfd4f2","default":false},{"id":595531418,"node_id":"MDU6TGFiZWw1OTU1MzE0MTg=","url":"https://api.github.com/repos/cerner/terra-core/labels/theming","name":"theming","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cerner/terra-core/pulls/2125/commits","review_comments_url":"https://api.github.com/repos/cerner/terra-core/pulls/2125/comments","review_comment_url":"https://api.github.com/repos/cerner/terra-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cerner/terra-core/issues/2125/comments","statuses_url":"https://api.github.com/repos/cerner/terra-core/statuses/5c574263d2b9623f566e5a204c0aee960e26aadb","head":{"label":"cerner:refactor-core-theme-variables","ref":"refactor-core-theme-variables","sha":"5c574263d2b9623f566e5a204c0aee960e26aadb","user":{"login":"cerner","id":1873208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzMyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1873208?v=4","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"repo":{"id":83073156,"node_id":"MDEwOlJlcG9zaXRvcnk4MzA3MzE1Ng==","name":"terra-core","full_name":"cerner/terra-core","private":false,"owner":{"login":"cerner","id":1873208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzMyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1873208?v=4","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cerner/terra-core","description":"Terra offers a set of configurable React components designed to help build scalable and modular application UIs. The library easily integrates with webpack-based workflows and was created to solve real-world issues in projects we work on day to day.","fork":false,"url":"https://api.github.com/repos/cerner/terra-core","forks_url":"https://api.github.com/repos/cerner/terra-core/forks","keys_url":"https://api.github.com/repos/cerner/terra-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cerner/terra-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cerner/terra-core/teams","hooks_url":"https://api.github.com/repos/cerner/terra-core/hooks","issue_events_url":"https://api.github.com/repos/cerner/terra-core/issues/events{/number}","events_url":"https://api.github.com/repos/cerner/terra-core/events","assignees_url":"https://api.github.com/repos/cerner/terra-core/assignees{/user}","branches_url":"https://api.github.com/repos/cerner/terra-core/branches{/branch}","tags_url":"https://api.github.com/repos/cerner/terra-core/tags","blobs_url":"https://api.github.com/repos/cerner/terra-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cerner/terra-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cerner/terra-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/cerner/terra-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cerner/terra-core/statuses/{sha}","languages_url":"https://api.github.com/repos/cerner/terra-core/languages","stargazers_url":"https://api.github.com/repos/cerner/terra-core/stargazers","contributors_url":"https://api.github.com/repos/cerner/terra-core/contributors","subscribers_url":"https://api.github.com/repos/cerner/terra-core/subscribers","subscription_url":"https://api.github.com/repos/cerner/terra-core/subscription","commits_url":"https://api.github.com/repos/cerner/terra-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/cerner/terra-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/cerner/terra-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/cerner/terra-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/cerner/terra-core/contents/{+path}","compare_url":"https://api.github.com/repos/cerner/terra-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cerner/terra-core/merges","archive_url":"https://api.github.com/repos/cerner/terra-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cerner/terra-core/downloads","issues_url":"https://api.github.com/repos/cerner/terra-core/issues{/number}","pulls_url":"https://api.github.com/repos/cerner/terra-core/pulls{/number}","milestones_url":"https://api.github.com/repos/cerner/terra-core/milestones{/number}","notifications_url":"https://api.github.com/repos/cerner/terra-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cerner/terra-core/labels{/name}","releases_url":"https://api.github.com/repos/cerner/terra-core/releases{/id}","deployments_url":"https://api.github.com/repos/cerner/terra-core/deployments","created_at":"2017-02-24T18:57:33Z","updated_at":"2018-12-14T23:06:31Z","pushed_at":"2018-12-20T16:31:13Z","git_url":"git://github.com/cerner/terra-core.git","ssh_url":"[email protected]:cerner/terra-core.git","clone_url":"https://github.com/cerner/terra-core.git","svn_url":"https://github.com/cerner/terra-core","homepage":"http://terra-ui.com","size":99554,"stargazers_count":113,"watchers_count":113,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":83,"mirror_url":null,"archived":false,"open_issues_count":181,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":83,"open_issues":181,"watchers":113,"default_branch":"master"}},"base":{"label":"cerner:ocs-theme-variables","ref":"ocs-theme-variables","sha":"946e23758cb55c3163dc13bb2dbc7c93f1b0f7d4","user":{"login":"cerner","id":1873208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzMyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1873208?v=4","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"repo":{"id":83073156,"node_id":"MDEwOlJlcG9zaXRvcnk4MzA3MzE1Ng==","name":"terra-core","full_name":"cerner/terra-core","private":false,"owner":{"login":"cerner","id":1873208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzMyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1873208?v=4","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cerner/terra-core","description":"Terra offers a set of configurable React components designed to help build scalable and modular application UIs. The library easily integrates with webpack-based workflows and was created to solve real-world issues in projects we work on day to day.","fork":false,"url":"https://api.github.com/repos/cerner/terra-core","forks_url":"https://api.github.com/repos/cerner/terra-core/forks","keys_url":"https://api.github.com/repos/cerner/terra-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cerner/terra-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cerner/terra-core/teams","hooks_url":"https://api.github.com/repos/cerner/terra-core/hooks","issue_events_url":"https://api.github.com/repos/cerner/terra-core/issues/events{/number}","events_url":"https://api.github.com/repos/cerner/terra-core/events","assignees_url":"https://api.github.com/repos/cerner/terra-core/assignees{/user}","branches_url":"https://api.github.com/repos/cerner/terra-core/branches{/branch}","tags_url":"https://api.github.com/repos/cerner/terra-core/tags","blobs_url":"https://api.github.com/repos/cerner/terra-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cerner/terra-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cerner/terra-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/cerner/terra-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cerner/terra-core/statuses/{sha}","languages_url":"https://api.github.com/repos/cerner/terra-core/languages","stargazers_url":"https://api.github.com/repos/cerner/terra-core/stargazers","contributors_url":"https://api.github.com/repos/cerner/terra-core/contributors","subscribers_url":"https://api.github.com/repos/cerner/terra-core/subscribers","subscription_url":"https://api.github.com/repos/cerner/terra-core/subscription","commits_url":"https://api.github.com/repos/cerner/terra-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/cerner/terra-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/cerner/terra-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/cerner/terra-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/cerner/terra-core/contents/{+path}","compare_url":"https://api.github.com/repos/cerner/terra-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cerner/terra-core/merges","archive_url":"https://api.github.com/repos/cerner/terra-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cerner/terra-core/downloads","issues_url":"https://api.github.com/repos/cerner/terra-core/issues{/number}","pulls_url":"https://api.github.com/repos/cerner/terra-core/pulls{/number}","milestones_url":"https://api.github.com/repos/cerner/terra-core/milestones{/number}","notifications_url":"https://api.github.com/repos/cerner/terra-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cerner/terra-core/labels{/name}","releases_url":"https://api.github.com/repos/cerner/terra-core/releases{/id}","deployments_url":"https://api.github.com/repos/cerner/terra-core/deployments","created_at":"2017-02-24T18:57:33Z","updated_at":"2018-12-14T23:06:31Z","pushed_at":"2018-12-20T16:31:13Z","git_url":"git://github.com/cerner/terra-core.git","ssh_url":"[email protected]:cerner/terra-core.git","clone_url":"https://github.com/cerner/terra-core.git","svn_url":"https://github.com/cerner/terra-core","homepage":"http://terra-ui.com","size":99554,"stargazers_count":113,"watchers_count":113,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":83,"mirror_url":null,"archived":false,"open_issues_count":181,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":83,"open_issues":181,"watchers":113,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cerner/terra-core/pulls/2125"},"html":{"href":"https://github.com/cerner/terra-core/pull/2125"},"issue":{"href":"https://api.github.com/repos/cerner/terra-core/issues/2125"},"comments":{"href":"https://api.github.com/repos/cerner/terra-core/issues/2125/comments"},"review_comments":{"href":"https://api.github.com/repos/cerner/terra-core/pulls/2125/comments"},"review_comment":{"href":"https://api.github.com/repos/cerner/terra-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cerner/terra-core/pulls/2125/commits"},"statuses":{"href":"https://api.github.com/repos/cerner/terra-core/statuses/5c574263d2b9623f566e5a204c0aee960e26aadb"}},"author_association":"CONTRIBUTOR"}} | {
"id": 83073156,
"name": "cerner/terra-core",
"url": "https://api.github.com/repos/cerner/terra-core"
} | {
"id": 14063284,
"login": "yuderekyu",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14063284?",
"url": "https://api.github.com/users/yuderekyu"
} | {
"id": 1873208,
"login": "cerner",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1873208?",
"url": "https://api.github.com/orgs/cerner"
} | 2018-12-20T16:32:01 | 8786744951 | {"actor":{"display_login":"yuderekyu"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/nukeviet/nukeviet/pulls/comments/212576071","pull_request_review_id":149239651,"id":212576071,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjU3NjA3MQ==","diff_hunk":"@@ -0,0 +1,58 @@\n+/**\n+ * @Project NUKEVIET 4.x\n+ * @Author VINADES.,JSC ([email protected])\n+ * @Copyright (C) 2014 VINADES.,JSC. All rights reserved\n+ * @License GNU/GPL version 2 or any later version\n+ * @Createdate 19/3/2010 22:58\n+ */\n+\n+$(document).ready(function() {\n+ // Đổi mã bảo mật\n+ $('#changevimg').on('click', function(e) {\n+ e.preventDefault();\n+ $('#vimg').attr('src', nv_base_siteurl + \"index.php?scaptcha=captcha&nocache=\" + nv_randomPassword(10));\n+ $('#nv_seccode').val('');\n+ });\n+\n+ // Đổi kiểu xác thực hai bước\n+ $('.login2step-change').on('click', function(e) {\n+ e.preventDefault();\n+ $('.nv-login2step-opt').find('[type=\"text\"]').val('');\n+ $('.nv-login2step-opt').toggleClass('d-none');\n+ });\n+\n+ // Kiểm tra các input nhập khi submit form\n+ $('#admin-login-form').submit(function(e) {\n+ var uname = $('#nv_login'),\n+ upass = $('#nv_password'),\n+ otp = $('#nv_totppin'),\n+ backupcode = $('#nv_backupcodepin'),\n+ seccode = $('#seccode'),\n+ validForm = true;\n+\n+ if (uname.val() == '') {\n+ uname.focus();\n+ validForm = false;\n+ } else if (upass.val() == '') {\n+ upass.focus();\n+ validForm = false;\n+ } else if (otp.is(':visible') && otp.val() == '') {\n+ otp.focus();\n+ validForm = false;\n+ } else if (backupcode.is(':visible') && backupcode.val() == '') {","path":"src/themes/admin_nv5/js/nv.login.js","position":42,"original_position":42,"commit_id":"5b9756ff6500ce7102eb9ed40bd3a33582250447","original_commit_id":"5b9756ff6500ce7102eb9ed40bd3a33582250447","user":{"login":"codacy-bot","id":19940114,"node_id":"MDQ6VXNlcjE5OTQwMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":" Issue found: [Strings must use doublequote. (quotes)](https://app.codacy.com/app/nukeviet/nukeviet/pullRequest?prid=2089848)","created_at":"2018-08-24T09:45:57Z","updated_at":"2018-08-24T09:45:57Z","html_url":"https://github.com/nukeviet/nukeviet/pull/2716#discussion_r212576071","pull_request_url":"https://api.github.com/repos/nukeviet/nukeviet/pulls/2716","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/nukeviet/nukeviet/pulls/comments/212576071"},"html":{"href":"https://github.com/nukeviet/nukeviet/pull/2716#discussion_r212576071"},"pull_request":{"href":"https://api.github.com/repos/nukeviet/nukeviet/pulls/2716"}}},"pull_request":{"url":"https://api.github.com/repos/nukeviet/nukeviet/pulls/2716","id":210690032,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNjkwMDMy","html_url":"https://github.com/nukeviet/nukeviet/pull/2716","diff_url":"https://github.com/nukeviet/nukeviet/pull/2716.diff","patch_url":"https://github.com/nukeviet/nukeviet/pull/2716.patch","issue_url":"https://api.github.com/repos/nukeviet/nukeviet/issues/2716","number":2716,"state":"open","locked":false,"title":"Update NukeViet 5","user":{"login":"hoaquynhtim99","id":2421714,"node_id":"MDQ6VXNlcjI0MjE3MTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2421714?v=4","gravatar_id":"","url":"https://api.github.com/users/hoaquynhtim99","html_url":"https://github.com/hoaquynhtim99","followers_url":"https://api.github.com/users/hoaquynhtim99/followers","following_url":"https://api.github.com/users/hoaquynhtim99/following{/other_user}","gists_url":"https://api.github.com/users/hoaquynhtim99/gists{/gist_id}","starred_url":"https://api.github.com/users/hoaquynhtim99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoaquynhtim99/subscriptions","organizations_url":"https://api.github.com/users/hoaquynhtim99/orgs","repos_url":"https://api.github.com/users/hoaquynhtim99/repos","events_url":"https://api.github.com/users/hoaquynhtim99/events{/privacy}","received_events_url":"https://api.github.com/users/hoaquynhtim99/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-24T09:41:36Z","updated_at":"2018-08-24T09:45:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a30db65f2f101dbecbc227ba03c63e57a0b21f8f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nukeviet/nukeviet/pulls/2716/commits","review_comments_url":"https://api.github.com/repos/nukeviet/nukeviet/pulls/2716/comments","review_comment_url":"https://api.github.com/repos/nukeviet/nukeviet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nukeviet/nukeviet/issues/2716/comments","statuses_url":"https://api.github.com/repos/nukeviet/nukeviet/statuses/5b9756ff6500ce7102eb9ed40bd3a33582250447","head":{"label":"hoaquynhtim99:develop","ref":"develop","sha":"5b9756ff6500ce7102eb9ed40bd3a33582250447","user":{"login":"hoaquynhtim99","id":2421714,"node_id":"MDQ6VXNlcjI0MjE3MTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2421714?v=4","gravatar_id":"","url":"https://api.github.com/users/hoaquynhtim99","html_url":"https://github.com/hoaquynhtim99","followers_url":"https://api.github.com/users/hoaquynhtim99/followers","following_url":"https://api.github.com/users/hoaquynhtim99/following{/other_user}","gists_url":"https://api.github.com/users/hoaquynhtim99/gists{/gist_id}","starred_url":"https://api.github.com/users/hoaquynhtim99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoaquynhtim99/subscriptions","organizations_url":"https://api.github.com/users/hoaquynhtim99/orgs","repos_url":"https://api.github.com/users/hoaquynhtim99/repos","events_url":"https://api.github.com/users/hoaquynhtim99/events{/privacy}","received_events_url":"https://api.github.com/users/hoaquynhtim99/received_events","type":"User","site_admin":false},"repo":{"id":40585207,"node_id":"MDEwOlJlcG9zaXRvcnk0MDU4NTIwNw==","name":"nukeviet","full_name":"hoaquynhtim99/nukeviet","owner":{"login":"hoaquynhtim99","id":2421714,"node_id":"MDQ6VXNlcjI0MjE3MTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2421714?v=4","gravatar_id":"","url":"https://api.github.com/users/hoaquynhtim99","html_url":"https://github.com/hoaquynhtim99","followers_url":"https://api.github.com/users/hoaquynhtim99/followers","following_url":"https://api.github.com/users/hoaquynhtim99/following{/other_user}","gists_url":"https://api.github.com/users/hoaquynhtim99/gists{/gist_id}","starred_url":"https://api.github.com/users/hoaquynhtim99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoaquynhtim99/subscriptions","organizations_url":"https://api.github.com/users/hoaquynhtim99/orgs","repos_url":"https://api.github.com/users/hoaquynhtim99/repos","events_url":"https://api.github.com/users/hoaquynhtim99/events{/privacy}","received_events_url":"https://api.github.com/users/hoaquynhtim99/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hoaquynhtim99/nukeviet","description":"NukeViet CMS is multi Content Management System. NukeViet CMS is the 1st open source content management system in Vietnam. NukeViet was awarded the Vietnam Talent 2011, the Ministry of Education and Training Vietnam officially encouraged to use.","fork":true,"url":"https://api.github.com/repos/hoaquynhtim99/nukeviet","forks_url":"https://api.github.com/repos/hoaquynhtim99/nukeviet/forks","keys_url":"https://api.github.com/repos/hoaquynhtim99/nukeviet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hoaquynhtim99/nukeviet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hoaquynhtim99/nukeviet/teams","hooks_url":"https://api.github.com/repos/hoaquynhtim99/nukeviet/hooks","issue_events_url":"https://api.github.com/repos/hoaquynhtim99/nukeviet/issues/events{/number}","events_url":"https://api.github.com/repos/hoaquynhtim99/nukeviet/events","assignees_url":"https://api.github.com/repos/hoaquynhtim99/nukeviet/assignees{/user}","branches_url":"https://api.github.com/repos/hoaquynhtim99/nukeviet/branches{/branch}","tags_url":"https://api.github.com/repos/hoaquynhtim99/nukeviet/tags","blobs_url":"https://api.github.com/repos/hoaquynhtim99/nukeviet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hoaquynhtim99/nukeviet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hoaquynhtim99/nukeviet/git/refs{/sha}","trees_url":"https://api.github.com/repos/hoaquynhtim99/nukeviet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hoaquynhtim99/nukeviet/statuses/{sha}","languages_url":"https://api.github.com/repos/hoaquynhtim99/nukeviet/languages","stargazers_url":"https://api.github.com/repos/hoaquynhtim99/nukeviet/stargazers","contributors_url":"https://api.github.com/repos/hoaquynhtim99/nukeviet/contributors","subscribers_url":"https://api.github.com/repos/hoaquynhtim99/nukeviet/subscribers","subscription_url":"https://api.github.com/repos/hoaquynhtim99/nukeviet/subscription","commits_url":"https://api.github.com/repos/hoaquynhtim99/nukeviet/commits{/sha}","git_commits_url":"https://api.github.com/repos/hoaquynhtim99/nukeviet/git/commits{/sha}","comments_url":"https://api.github.com/repos/hoaquynhtim99/nukeviet/comments{/number}","issue_comment_url":"https://api.github.com/repos/hoaquynhtim99/nukeviet/issues/comments{/number}","contents_url":"https://api.github.com/repos/hoaquynhtim99/nukeviet/contents/{+path}","compare_url":"https://api.github.com/repos/hoaquynhtim99/nukeviet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hoaquynhtim99/nukeviet/merges","archive_url":"https://api.github.com/repos/hoaquynhtim99/nukeviet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hoaquynhtim99/nukeviet/downloads","issues_url":"https://api.github.com/repos/hoaquynhtim99/nukeviet/issues{/number}","pulls_url":"https://api.github.com/repos/hoaquynhtim99/nukeviet/pulls{/number}","milestones_url":"https://api.github.com/repos/hoaquynhtim99/nukeviet/milestones{/number}","notifications_url":"https://api.github.com/repos/hoaquynhtim99/nukeviet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hoaquynhtim99/nukeviet/labels{/name}","releases_url":"https://api.github.com/repos/hoaquynhtim99/nukeviet/releases{/id}","deployments_url":"https://api.github.com/repos/hoaquynhtim99/nukeviet/deployments","created_at":"2015-08-12T06:57:30Z","updated_at":"2018-08-24T07:38:21Z","pushed_at":"2018-08-24T09:39:39Z","git_url":"git://github.com/hoaquynhtim99/nukeviet.git","ssh_url":"[email protected]:hoaquynhtim99/nukeviet.git","clone_url":"https://github.com/hoaquynhtim99/nukeviet.git","svn_url":"https://github.com/hoaquynhtim99/nukeviet","homepage":"http://nukeviet.vn","size":101041,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"nukeviet4.3"}},"base":{"label":"nukeviet:develop","ref":"develop","sha":"1fe3725ac823d8e73496dbddb1696d9898476ff8","user":{"login":"nukeviet","id":1892954,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4OTI5NTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1892954?v=4","gravatar_id":"","url":"https://api.github.com/users/nukeviet","html_url":"https://github.com/nukeviet","followers_url":"https://api.github.com/users/nukeviet/followers","following_url":"https://api.github.com/users/nukeviet/following{/other_user}","gists_url":"https://api.github.com/users/nukeviet/gists{/gist_id}","starred_url":"https://api.github.com/users/nukeviet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nukeviet/subscriptions","organizations_url":"https://api.github.com/users/nukeviet/orgs","repos_url":"https://api.github.com/users/nukeviet/repos","events_url":"https://api.github.com/users/nukeviet/events{/privacy}","received_events_url":"https://api.github.com/users/nukeviet/received_events","type":"Organization","site_admin":false},"repo":{"id":6841181,"node_id":"MDEwOlJlcG9zaXRvcnk2ODQxMTgx","name":"nukeviet","full_name":"nukeviet/nukeviet","owner":{"login":"nukeviet","id":1892954,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4OTI5NTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1892954?v=4","gravatar_id":"","url":"https://api.github.com/users/nukeviet","html_url":"https://github.com/nukeviet","followers_url":"https://api.github.com/users/nukeviet/followers","following_url":"https://api.github.com/users/nukeviet/following{/other_user}","gists_url":"https://api.github.com/users/nukeviet/gists{/gist_id}","starred_url":"https://api.github.com/users/nukeviet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nukeviet/subscriptions","organizations_url":"https://api.github.com/users/nukeviet/orgs","repos_url":"https://api.github.com/users/nukeviet/repos","events_url":"https://api.github.com/users/nukeviet/events{/privacy}","received_events_url":"https://api.github.com/users/nukeviet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nukeviet/nukeviet","description":"NukeViet CMS is multi Content Management System. NukeViet CMS is the 1st open source content management system in Vietnam. NukeViet was awarded the Vietnam Talent 2011, the Ministry of Education and Training Vietnam officially encouraged to use.","fork":false,"url":"https://api.github.com/repos/nukeviet/nukeviet","forks_url":"https://api.github.com/repos/nukeviet/nukeviet/forks","keys_url":"https://api.github.com/repos/nukeviet/nukeviet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nukeviet/nukeviet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nukeviet/nukeviet/teams","hooks_url":"https://api.github.com/repos/nukeviet/nukeviet/hooks","issue_events_url":"https://api.github.com/repos/nukeviet/nukeviet/issues/events{/number}","events_url":"https://api.github.com/repos/nukeviet/nukeviet/events","assignees_url":"https://api.github.com/repos/nukeviet/nukeviet/assignees{/user}","branches_url":"https://api.github.com/repos/nukeviet/nukeviet/branches{/branch}","tags_url":"https://api.github.com/repos/nukeviet/nukeviet/tags","blobs_url":"https://api.github.com/repos/nukeviet/nukeviet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nukeviet/nukeviet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nukeviet/nukeviet/git/refs{/sha}","trees_url":"https://api.github.com/repos/nukeviet/nukeviet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nukeviet/nukeviet/statuses/{sha}","languages_url":"https://api.github.com/repos/nukeviet/nukeviet/languages","stargazers_url":"https://api.github.com/repos/nukeviet/nukeviet/stargazers","contributors_url":"https://api.github.com/repos/nukeviet/nukeviet/contributors","subscribers_url":"https://api.github.com/repos/nukeviet/nukeviet/subscribers","subscription_url":"https://api.github.com/repos/nukeviet/nukeviet/subscription","commits_url":"https://api.github.com/repos/nukeviet/nukeviet/commits{/sha}","git_commits_url":"https://api.github.com/repos/nukeviet/nukeviet/git/commits{/sha}","comments_url":"https://api.github.com/repos/nukeviet/nukeviet/comments{/number}","issue_comment_url":"https://api.github.com/repos/nukeviet/nukeviet/issues/comments{/number}","contents_url":"https://api.github.com/repos/nukeviet/nukeviet/contents/{+path}","compare_url":"https://api.github.com/repos/nukeviet/nukeviet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nukeviet/nukeviet/merges","archive_url":"https://api.github.com/repos/nukeviet/nukeviet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nukeviet/nukeviet/downloads","issues_url":"https://api.github.com/repos/nukeviet/nukeviet/issues{/number}","pulls_url":"https://api.github.com/repos/nukeviet/nukeviet/pulls{/number}","milestones_url":"https://api.github.com/repos/nukeviet/nukeviet/milestones{/number}","notifications_url":"https://api.github.com/repos/nukeviet/nukeviet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nukeviet/nukeviet/labels{/name}","releases_url":"https://api.github.com/repos/nukeviet/nukeviet/releases{/id}","deployments_url":"https://api.github.com/repos/nukeviet/nukeviet/deployments","created_at":"2012-11-24T15:39:39Z","updated_at":"2018-08-05T00:26:35Z","pushed_at":"2018-08-24T09:41:37Z","git_url":"git://github.com/nukeviet/nukeviet.git","ssh_url":"[email protected]:nukeviet/nukeviet.git","clone_url":"https://github.com/nukeviet/nukeviet.git","svn_url":"https://github.com/nukeviet/nukeviet","homepage":"http://nukeviet.vn","size":97432,"stargazers_count":92,"watchers_count":92,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":177,"mirror_url":null,"archived":false,"open_issues_count":96,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":177,"open_issues":96,"watchers":92,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/nukeviet/nukeviet/pulls/2716"},"html":{"href":"https://github.com/nukeviet/nukeviet/pull/2716"},"issue":{"href":"https://api.github.com/repos/nukeviet/nukeviet/issues/2716"},"comments":{"href":"https://api.github.com/repos/nukeviet/nukeviet/issues/2716/comments"},"review_comments":{"href":"https://api.github.com/repos/nukeviet/nukeviet/pulls/2716/comments"},"review_comment":{"href":"https://api.github.com/repos/nukeviet/nukeviet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nukeviet/nukeviet/pulls/2716/commits"},"statuses":{"href":"https://api.github.com/repos/nukeviet/nukeviet/statuses/5b9756ff6500ce7102eb9ed40bd3a33582250447"}},"author_association":"CONTRIBUTOR"}} | {
"id": 6841181,
"name": "nukeviet/nukeviet",
"url": "https://api.github.com/repos/nukeviet/nukeviet"
} | {
"id": 19940114,
"login": "codacy-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19940114?",
"url": "https://api.github.com/users/codacy-bot"
} | {
"id": 1892954,
"login": "nukeviet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1892954?",
"url": "https://api.github.com/orgs/nukeviet"
} | 2018-08-24T09:45:57 | 8162061687 | {"actor":{"display_login":"codacy-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/systemd/systemd/pulls/comments/185818085","pull_request_review_id":117282933,"id":185818085,"diff_hunk":"@@ -71,26 +76,26 @@ void probe_smart_media(int mtd_fd, mtd_info_t* info) {\n break;\n }\n \n- for (offset = 0 ; offset < block_size * spare_count ;\n- offset += sector_size) {\n- lseek(mtd_fd, SEEK_SET, offset);\n+ for (offset = 0; offset < block_size * spare_count; offset += sector_size) {\n+ (void) lseek(mtd_fd, SEEK_SET, offset);\n+\n if (read(mtd_fd, cis_buffer, SM_SECTOR_SIZE) == SM_SECTOR_SIZE) {\n cis_found = 1;\n break;\n }\n }\n \n- if (!cis_found)\n- goto exit;\n+ if (!cis_found) {\n+ log_debug(\"CIS not found\");\n+ return -EINVAL;\n+ }\n \n if (memcmp(cis_buffer, cis_signature, sizeof(cis_signature)) != 0 &&\n- (memcmp(cis_buffer + SM_SMALL_PAGE, cis_signature,\n- sizeof(cis_signature)) != 0))\n- goto exit;\n+ (memcmp(cis_buffer + SM_SMALL_PAGE, cis_signature, sizeof(cis_signature)) != 0)) {","path":"src/udev/mtd_probe/probe_smartmedia.c","position":71,"original_position":71,"commit_id":"e491ad0fef28a992178ca13f2f30d8aa702cccee","original_commit_id":"e491ad0fef28a992178ca13f2f30d8aa702cccee","user":{"login":"yuwata","id":14157143,"avatar_url":"https://avatars3.githubusercontent.com/u/14157143?v=4","gravatar_id":"","url":"https://api.github.com/users/yuwata","html_url":"https://github.com/yuwata","followers_url":"https://api.github.com/users/yuwata/followers","following_url":"https://api.github.com/users/yuwata/following{/other_user}","gists_url":"https://api.github.com/users/yuwata/gists{/gist_id}","starred_url":"https://api.github.com/users/yuwata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuwata/subscriptions","organizations_url":"https://api.github.com/users/yuwata/orgs","repos_url":"https://api.github.com/users/yuwata/repos","events_url":"https://api.github.com/users/yuwata/events{/privacy}","received_events_url":"https://api.github.com/users/yuwata/received_events","type":"User","site_admin":false},"body":"Redundant parenthesis.","created_at":"2018-05-03T14:30:08Z","updated_at":"2018-05-03T14:31:15Z","html_url":"https://github.com/systemd/systemd/pull/8805#discussion_r185818085","pull_request_url":"https://api.github.com/repos/systemd/systemd/pulls/8805","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/systemd/systemd/pulls/comments/185818085"},"html":{"href":"https://github.com/systemd/systemd/pull/8805#discussion_r185818085"},"pull_request":{"href":"https://api.github.com/repos/systemd/systemd/pulls/8805"}}},"pull_request":{"url":"https://api.github.com/repos/systemd/systemd/pulls/8805","id":183784686,"html_url":"https://github.com/systemd/systemd/pull/8805","diff_url":"https://github.com/systemd/systemd/pull/8805.diff","patch_url":"https://github.com/systemd/systemd/pull/8805.patch","issue_url":"https://api.github.com/repos/systemd/systemd/issues/8805","number":8805,"state":"open","locked":false,"title":"mtd: some basic code cleanups","user":{"login":"poettering","id":2130732,"avatar_url":"https://avatars1.githubusercontent.com/u/2130732?v=4","gravatar_id":"","url":"https://api.github.com/users/poettering","html_url":"https://github.com/poettering","followers_url":"https://api.github.com/users/poettering/followers","following_url":"https://api.github.com/users/poettering/following{/other_user}","gists_url":"https://api.github.com/users/poettering/gists{/gist_id}","starred_url":"https://api.github.com/users/poettering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poettering/subscriptions","organizations_url":"https://api.github.com/users/poettering/orgs","repos_url":"https://api.github.com/users/poettering/repos","events_url":"https://api.github.com/users/poettering/events{/privacy}","received_events_url":"https://api.github.com/users/poettering/received_events","type":"User","site_admin":false},"body":"While looking at our exit() invocations I noticed that the mtd_probe\r\nstuff uses 'exit(-1)' at various places, which is not really a good\r\nidea, as exit codes of processes on Linux are supposed to be in the\r\nrange of 0…255.\r\n\r\nThis patch cleans that up a bit, and fixes a number of other things:\r\n\r\n1. Let's always let main() exit, nothing intermediary. We generally\r\n don't like code that invokes exit() on its own.\r\n\r\n2. Close the file descriptors opened.\r\n\r\n3. Some logging for errors is added, mostly on debug level.\r\n\r\nPlease review this with extra care. As I don't have the right hardware\r\nto test this patch I only did superficial testing.","created_at":"2018-04-24T15:54:21Z","updated_at":"2018-05-03T14:31:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"01b0a628d4024b8e39bdc744a199023beefc091c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":219549617,"url":"https://api.github.com/repos/systemd/systemd/labels/udev","name":"udev","color":"f7c6c7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/systemd/systemd/pulls/8805/commits","review_comments_url":"https://api.github.com/repos/systemd/systemd/pulls/8805/comments","review_comment_url":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/systemd/systemd/issues/8805/comments","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/e491ad0fef28a992178ca13f2f30d8aa702cccee","head":{"label":"poettering:mtd-exit-fixo","ref":"mtd-exit-fixo","sha":"e491ad0fef28a992178ca13f2f30d8aa702cccee","user":{"login":"poettering","id":2130732,"avatar_url":"https://avatars1.githubusercontent.com/u/2130732?v=4","gravatar_id":"","url":"https://api.github.com/users/poettering","html_url":"https://github.com/poettering","followers_url":"https://api.github.com/users/poettering/followers","following_url":"https://api.github.com/users/poettering/following{/other_user}","gists_url":"https://api.github.com/users/poettering/gists{/gist_id}","starred_url":"https://api.github.com/users/poettering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poettering/subscriptions","organizations_url":"https://api.github.com/users/poettering/orgs","repos_url":"https://api.github.com/users/poettering/repos","events_url":"https://api.github.com/users/poettering/events{/privacy}","received_events_url":"https://api.github.com/users/poettering/received_events","type":"User","site_admin":false},"repo":{"id":37097921,"name":"systemd","full_name":"poettering/systemd","owner":{"login":"poettering","id":2130732,"avatar_url":"https://avatars1.githubusercontent.com/u/2130732?v=4","gravatar_id":"","url":"https://api.github.com/users/poettering","html_url":"https://github.com/poettering","followers_url":"https://api.github.com/users/poettering/followers","following_url":"https://api.github.com/users/poettering/following{/other_user}","gists_url":"https://api.github.com/users/poettering/gists{/gist_id}","starred_url":"https://api.github.com/users/poettering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poettering/subscriptions","organizations_url":"https://api.github.com/users/poettering/orgs","repos_url":"https://api.github.com/users/poettering/repos","events_url":"https://api.github.com/users/poettering/events{/privacy}","received_events_url":"https://api.github.com/users/poettering/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/poettering/systemd","description":"systemd upstream","fork":true,"url":"https://api.github.com/repos/poettering/systemd","forks_url":"https://api.github.com/repos/poettering/systemd/forks","keys_url":"https://api.github.com/repos/poettering/systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/poettering/systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/poettering/systemd/teams","hooks_url":"https://api.github.com/repos/poettering/systemd/hooks","issue_events_url":"https://api.github.com/repos/poettering/systemd/issues/events{/number}","events_url":"https://api.github.com/repos/poettering/systemd/events","assignees_url":"https://api.github.com/repos/poettering/systemd/assignees{/user}","branches_url":"https://api.github.com/repos/poettering/systemd/branches{/branch}","tags_url":"https://api.github.com/repos/poettering/systemd/tags","blobs_url":"https://api.github.com/repos/poettering/systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/poettering/systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/poettering/systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/poettering/systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/poettering/systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/poettering/systemd/languages","stargazers_url":"https://api.github.com/repos/poettering/systemd/stargazers","contributors_url":"https://api.github.com/repos/poettering/systemd/contributors","subscribers_url":"https://api.github.com/repos/poettering/systemd/subscribers","subscription_url":"https://api.github.com/repos/poettering/systemd/subscription","commits_url":"https://api.github.com/repos/poettering/systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/poettering/systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/poettering/systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/poettering/systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/poettering/systemd/contents/{+path}","compare_url":"https://api.github.com/repos/poettering/systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/poettering/systemd/merges","archive_url":"https://api.github.com/repos/poettering/systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/poettering/systemd/downloads","issues_url":"https://api.github.com/repos/poettering/systemd/issues{/number}","pulls_url":"https://api.github.com/repos/poettering/systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/poettering/systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/poettering/systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/poettering/systemd/labels{/name}","releases_url":"https://api.github.com/repos/poettering/systemd/releases{/id}","deployments_url":"https://api.github.com/repos/poettering/systemd/deployments","created_at":"2015-06-08T23:07:59Z","updated_at":"2018-04-25T10:39:07Z","pushed_at":"2018-05-03T11:30:31Z","git_url":"git://github.com/poettering/systemd.git","ssh_url":"[email protected]:poettering/systemd.git","clone_url":"https://github.com/poettering/systemd.git","svn_url":"https://github.com/poettering/systemd","homepage":"http://www.freedesktop.org/wiki/Software/systemd/","size":89238,"stargazers_count":12,"watchers_count":12,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":2,"open_issues":0,"watchers":12,"default_branch":"master"}},"base":{"label":"systemd:master","ref":"master","sha":"8e766630f006fcb17ad575bd4f3000e2d2dc890f","user":{"login":"systemd","id":1918868,"avatar_url":"https://avatars0.githubusercontent.com/u/1918868?v=4","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"repo":{"id":32873313,"name":"systemd","full_name":"systemd/systemd","owner":{"login":"systemd","id":1918868,"avatar_url":"https://avatars0.githubusercontent.com/u/1918868?v=4","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/systemd/systemd","description":"⚙️ 🐧 systemd System and Service Manager ","fork":false,"url":"https://api.github.com/repos/systemd/systemd","forks_url":"https://api.github.com/repos/systemd/systemd/forks","keys_url":"https://api.github.com/repos/systemd/systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/systemd/systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/systemd/systemd/teams","hooks_url":"https://api.github.com/repos/systemd/systemd/hooks","issue_events_url":"https://api.github.com/repos/systemd/systemd/issues/events{/number}","events_url":"https://api.github.com/repos/systemd/systemd/events","assignees_url":"https://api.github.com/repos/systemd/systemd/assignees{/user}","branches_url":"https://api.github.com/repos/systemd/systemd/branches{/branch}","tags_url":"https://api.github.com/repos/systemd/systemd/tags","blobs_url":"https://api.github.com/repos/systemd/systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/systemd/systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/systemd/systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/systemd/systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/systemd/systemd/languages","stargazers_url":"https://api.github.com/repos/systemd/systemd/stargazers","contributors_url":"https://api.github.com/repos/systemd/systemd/contributors","subscribers_url":"https://api.github.com/repos/systemd/systemd/subscribers","subscription_url":"https://api.github.com/repos/systemd/systemd/subscription","commits_url":"https://api.github.com/repos/systemd/systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/systemd/systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/systemd/systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/systemd/systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/systemd/systemd/contents/{+path}","compare_url":"https://api.github.com/repos/systemd/systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/systemd/systemd/merges","archive_url":"https://api.github.com/repos/systemd/systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/systemd/systemd/downloads","issues_url":"https://api.github.com/repos/systemd/systemd/issues{/number}","pulls_url":"https://api.github.com/repos/systemd/systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/systemd/systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/systemd/systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/systemd/systemd/labels{/name}","releases_url":"https://api.github.com/repos/systemd/systemd/releases{/id}","deployments_url":"https://api.github.com/repos/systemd/systemd/deployments","created_at":"2015-03-25T15:27:27Z","updated_at":"2018-05-03T14:23:48Z","pushed_at":"2018-05-03T14:23:34Z","git_url":"git://github.com/systemd/systemd.git","ssh_url":"[email protected]:systemd/systemd.git","clone_url":"https://github.com/systemd/systemd.git","svn_url":"https://github.com/systemd/systemd","homepage":"https://www.freedesktop.org/wiki/Software/systemd/","size":89163,"stargazers_count":3103,"watchers_count":3103,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1224,"mirror_url":null,"archived":false,"open_issues_count":914,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":1224,"open_issues":914,"watchers":3103,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/systemd/systemd/pulls/8805"},"html":{"href":"https://github.com/systemd/systemd/pull/8805"},"issue":{"href":"https://api.github.com/repos/systemd/systemd/issues/8805"},"comments":{"href":"https://api.github.com/repos/systemd/systemd/issues/8805/comments"},"review_comments":{"href":"https://api.github.com/repos/systemd/systemd/pulls/8805/comments"},"review_comment":{"href":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/systemd/systemd/pulls/8805/commits"},"statuses":{"href":"https://api.github.com/repos/systemd/systemd/statuses/e491ad0fef28a992178ca13f2f30d8aa702cccee"}},"author_association":"OWNER"}} | {
"id": 32873313,
"name": "systemd/systemd",
"url": "https://api.github.com/repos/systemd/systemd"
} | {
"id": 14157143,
"login": "yuwata",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14157143?",
"url": "https://api.github.com/users/yuwata"
} | {
"id": 1918868,
"login": "systemd",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1918868?",
"url": "https://api.github.com/orgs/systemd"
} | 2018-05-03T14:30:08 | 7623236983 | {"actor":{"display_login":"yuwata"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/comments/193448205","pull_request_review_id":126421746,"id":193448205,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzQ0ODIwNQ==","diff_hunk":"@@ -13,13 +13,79 @@ if [ \"$1\" -eq 0 ]; then\n exit 0\n fi\n \n-ram_size_kb=$(awk '/MemTotal/{print $2}' /proc/meminfo)\n+# List and disable any active swap areas\n+active_swaps=$(swapon --show=NAME --raw --noheadings)\n+echo \"Active swap areas before $(basename $0): ${active_swaps}\"\n+swapoff -a\n \n+# Enable zram\n+ram_size_kb=$(awk '/MemTotal/{print $2}' /proc/meminfo)\n if [ ! -e /sys/block/zram0 ]; then\n modprobe zram\n fi\n echo $(($ram_size_kb * 2))K > /sys/block/zram0/disksize\n-# For now, disable the swap partition if in use\n-swapoff -a\n mkswap /dev/zram0\n swapon /dev/zram0\n+\n+if [ -z \"${active_swaps}\" ]; then\n+ exit 0\n+fi\n+\n+# Find root partition, root partition number, root disk, and table type\n+orig_root_part=$(systemctl show -p What sysroot.mount)\n+orig_root_part=${orig_root_part#What=}\n+root_part=$(readlink -f \"${orig_root_part}\")\n+case ${root_part} in\n+ /dev/sd??)\n+ root_disk=${root_part%?}\n+ ;;\n+ /dev/*p[0-9])\n+ root_disk=${root_part%p?}\n+ ;;\n+esac\n+\n+case ${orig_root_part} in\n+ /dev/mapper/endless-image?)\n+ root_disk=${orig_root_part%?}\n+ ;;\n+esac\n+\n+if [ -z \"${root_disk}\" ]; then\n+ exit 0\n+fi\n+\n+get_last_char() {\n+ ret=$1\n+ while [ \"${#ret}\" != \"1\" ]; do\n+ ret=${ret#?}\n+ done\n+ echo $ret\n+}\n+partno=$(get_last_char ${root_part})\n+pt_label=$(blkid -o value -s PTTYPE $root_disk)\n+if [ -z \"$pt_label\" ]; then\n+ echo \"blkid -o value -s PTTYPE '$root_disk' failed\"\n+ exit 0","path":"eos-enable-zram","position":87,"original_position":59,"commit_id":"aa5b25659fc1d9f1274b15d56cd5bc389b0b1d09","original_commit_id":"630370153f836415c3dd07d5b42f4a757d5ac61c","user":{"login":"wjt","id":86760,"node_id":"MDQ6VXNlcjg2NzYw","avatar_url":"https://avatars2.githubusercontent.com/u/86760?v=4","gravatar_id":"","url":"https://api.github.com/users/wjt","html_url":"https://github.com/wjt","followers_url":"https://api.github.com/users/wjt/followers","following_url":"https://api.github.com/users/wjt/following{/other_user}","gists_url":"https://api.github.com/users/wjt/gists{/gist_id}","starred_url":"https://api.github.com/users/wjt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjt/subscriptions","organizations_url":"https://api.github.com/users/wjt/orgs","repos_url":"https://api.github.com/users/wjt/repos","events_url":"https://api.github.com/users/wjt/events{/privacy}","received_events_url":"https://api.github.com/users/wjt/received_events","type":"User","site_admin":false},"body":"Shouldn't this be a non-zero exit?","created_at":"2018-06-06T15:13:16Z","updated_at":"2018-06-06T15:22:03Z","html_url":"https://github.com/endlessm/eos-boot-helper/pull/211#discussion_r193448205","pull_request_url":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/211","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/comments/193448205"},"html":{"href":"https://github.com/endlessm/eos-boot-helper/pull/211#discussion_r193448205"},"pull_request":{"href":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/211"}}},"pull_request":{"url":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/211","id":192846338,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyODQ2MzM4","html_url":"https://github.com/endlessm/eos-boot-helper/pull/211","diff_url":"https://github.com/endlessm/eos-boot-helper/pull/211.diff","patch_url":"https://github.com/endlessm/eos-boot-helper/pull/211.patch","issue_url":"https://api.github.com/repos/endlessm/eos-boot-helper/issues/211","number":211,"state":"open","locked":false,"title":"Reclaim disk space from old swap partitions","user":{"login":"jprvita","id":73894,"node_id":"MDQ6VXNlcjczODk0","avatar_url":"https://avatars3.githubusercontent.com/u/73894?v=4","gravatar_id":"","url":"https://api.github.com/users/jprvita","html_url":"https://github.com/jprvita","followers_url":"https://api.github.com/users/jprvita/followers","following_url":"https://api.github.com/users/jprvita/following{/other_user}","gists_url":"https://api.github.com/users/jprvita/gists{/gist_id}","starred_url":"https://api.github.com/users/jprvita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jprvita/subscriptions","organizations_url":"https://api.github.com/users/jprvita/orgs","repos_url":"https://api.github.com/users/jprvita/repos","events_url":"https://api.github.com/users/jprvita/events{/privacy}","received_events_url":"https://api.github.com/users/jprvita/received_events","type":"User","site_admin":false},"body":"We are dropping the use of swap partitions in favor of zram, so lets reclaim the space we have previously allocated to swap partitions for the root filesystem.\r\n\r\nhttps://phabricator.endlessm.com/T22832","created_at":"2018-06-05T21:49:58Z","updated_at":"2018-06-06T15:22:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fed4f19f82fdc1b41af87547317b5d056a8e12bb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dsd","id":81864,"node_id":"MDQ6VXNlcjgxODY0","avatar_url":"https://avatars2.githubusercontent.com/u/81864?v=4","gravatar_id":"","url":"https://api.github.com/users/dsd","html_url":"https://github.com/dsd","followers_url":"https://api.github.com/users/dsd/followers","following_url":"https://api.github.com/users/dsd/following{/other_user}","gists_url":"https://api.github.com/users/dsd/gists{/gist_id}","starred_url":"https://api.github.com/users/dsd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsd/subscriptions","organizations_url":"https://api.github.com/users/dsd/orgs","repos_url":"https://api.github.com/users/dsd/repos","events_url":"https://api.github.com/users/dsd/events{/privacy}","received_events_url":"https://api.github.com/users/dsd/received_events","type":"User","site_admin":false},{"login":"rshuler","id":2050162,"node_id":"MDQ6VXNlcjIwNTAxNjI=","avatar_url":"https://avatars0.githubusercontent.com/u/2050162?v=4","gravatar_id":"","url":"https://api.github.com/users/rshuler","html_url":"https://github.com/rshuler","followers_url":"https://api.github.com/users/rshuler/followers","following_url":"https://api.github.com/users/rshuler/following{/other_user}","gists_url":"https://api.github.com/users/rshuler/gists{/gist_id}","starred_url":"https://api.github.com/users/rshuler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rshuler/subscriptions","organizations_url":"https://api.github.com/users/rshuler/orgs","repos_url":"https://api.github.com/users/rshuler/repos","events_url":"https://api.github.com/users/rshuler/events{/privacy}","received_events_url":"https://api.github.com/users/rshuler/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/211/commits","review_comments_url":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/211/comments","review_comment_url":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/endlessm/eos-boot-helper/issues/211/comments","statuses_url":"https://api.github.com/repos/endlessm/eos-boot-helper/statuses/aa5b25659fc1d9f1274b15d56cd5bc389b0b1d09","head":{"label":"endlessm:T22832","ref":"T22832","sha":"aa5b25659fc1d9f1274b15d56cd5bc389b0b1d09","user":{"login":"endlessm","id":1930958,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MzA5NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1930958?v=4","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"repo":{"id":17601935,"node_id":"MDEwOlJlcG9zaXRvcnkxNzYwMTkzNQ==","name":"eos-boot-helper","full_name":"endlessm/eos-boot-helper","owner":{"login":"endlessm","id":1930958,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MzA5NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1930958?v=4","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/endlessm/eos-boot-helper","description":"Endless OS services required for booting","fork":false,"url":"https://api.github.com/repos/endlessm/eos-boot-helper","forks_url":"https://api.github.com/repos/endlessm/eos-boot-helper/forks","keys_url":"https://api.github.com/repos/endlessm/eos-boot-helper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endlessm/eos-boot-helper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endlessm/eos-boot-helper/teams","hooks_url":"https://api.github.com/repos/endlessm/eos-boot-helper/hooks","issue_events_url":"https://api.github.com/repos/endlessm/eos-boot-helper/issues/events{/number}","events_url":"https://api.github.com/repos/endlessm/eos-boot-helper/events","assignees_url":"https://api.github.com/repos/endlessm/eos-boot-helper/assignees{/user}","branches_url":"https://api.github.com/repos/endlessm/eos-boot-helper/branches{/branch}","tags_url":"https://api.github.com/repos/endlessm/eos-boot-helper/tags","blobs_url":"https://api.github.com/repos/endlessm/eos-boot-helper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endlessm/eos-boot-helper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endlessm/eos-boot-helper/git/refs{/sha}","trees_url":"https://api.github.com/repos/endlessm/eos-boot-helper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endlessm/eos-boot-helper/statuses/{sha}","languages_url":"https://api.github.com/repos/endlessm/eos-boot-helper/languages","stargazers_url":"https://api.github.com/repos/endlessm/eos-boot-helper/stargazers","contributors_url":"https://api.github.com/repos/endlessm/eos-boot-helper/contributors","subscribers_url":"https://api.github.com/repos/endlessm/eos-boot-helper/subscribers","subscription_url":"https://api.github.com/repos/endlessm/eos-boot-helper/subscription","commits_url":"https://api.github.com/repos/endlessm/eos-boot-helper/commits{/sha}","git_commits_url":"https://api.github.com/repos/endlessm/eos-boot-helper/git/commits{/sha}","comments_url":"https://api.github.com/repos/endlessm/eos-boot-helper/comments{/number}","issue_comment_url":"https://api.github.com/repos/endlessm/eos-boot-helper/issues/comments{/number}","contents_url":"https://api.github.com/repos/endlessm/eos-boot-helper/contents/{+path}","compare_url":"https://api.github.com/repos/endlessm/eos-boot-helper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endlessm/eos-boot-helper/merges","archive_url":"https://api.github.com/repos/endlessm/eos-boot-helper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endlessm/eos-boot-helper/downloads","issues_url":"https://api.github.com/repos/endlessm/eos-boot-helper/issues{/number}","pulls_url":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls{/number}","milestones_url":"https://api.github.com/repos/endlessm/eos-boot-helper/milestones{/number}","notifications_url":"https://api.github.com/repos/endlessm/eos-boot-helper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endlessm/eos-boot-helper/labels{/name}","releases_url":"https://api.github.com/repos/endlessm/eos-boot-helper/releases{/id}","deployments_url":"https://api.github.com/repos/endlessm/eos-boot-helper/deployments","created_at":"2014-03-10T17:39:28Z","updated_at":"2018-06-04T21:04:01Z","pushed_at":"2018-06-05T21:49:59Z","git_url":"git://github.com/endlessm/eos-boot-helper.git","ssh_url":"[email protected]:endlessm/eos-boot-helper.git","clone_url":"https://github.com/endlessm/eos-boot-helper.git","svn_url":"https://github.com/endlessm/eos-boot-helper","homepage":"","size":476,"stargazers_count":5,"watchers_count":5,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":3,"open_issues":6,"watchers":5,"default_branch":"master"}},"base":{"label":"endlessm:master","ref":"master","sha":"6d6cb9e22593b74f374b908b05ce2137a8cf655d","user":{"login":"endlessm","id":1930958,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MzA5NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1930958?v=4","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"repo":{"id":17601935,"node_id":"MDEwOlJlcG9zaXRvcnkxNzYwMTkzNQ==","name":"eos-boot-helper","full_name":"endlessm/eos-boot-helper","owner":{"login":"endlessm","id":1930958,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MzA5NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1930958?v=4","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/endlessm/eos-boot-helper","description":"Endless OS services required for booting","fork":false,"url":"https://api.github.com/repos/endlessm/eos-boot-helper","forks_url":"https://api.github.com/repos/endlessm/eos-boot-helper/forks","keys_url":"https://api.github.com/repos/endlessm/eos-boot-helper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endlessm/eos-boot-helper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endlessm/eos-boot-helper/teams","hooks_url":"https://api.github.com/repos/endlessm/eos-boot-helper/hooks","issue_events_url":"https://api.github.com/repos/endlessm/eos-boot-helper/issues/events{/number}","events_url":"https://api.github.com/repos/endlessm/eos-boot-helper/events","assignees_url":"https://api.github.com/repos/endlessm/eos-boot-helper/assignees{/user}","branches_url":"https://api.github.com/repos/endlessm/eos-boot-helper/branches{/branch}","tags_url":"https://api.github.com/repos/endlessm/eos-boot-helper/tags","blobs_url":"https://api.github.com/repos/endlessm/eos-boot-helper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endlessm/eos-boot-helper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endlessm/eos-boot-helper/git/refs{/sha}","trees_url":"https://api.github.com/repos/endlessm/eos-boot-helper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endlessm/eos-boot-helper/statuses/{sha}","languages_url":"https://api.github.com/repos/endlessm/eos-boot-helper/languages","stargazers_url":"https://api.github.com/repos/endlessm/eos-boot-helper/stargazers","contributors_url":"https://api.github.com/repos/endlessm/eos-boot-helper/contributors","subscribers_url":"https://api.github.com/repos/endlessm/eos-boot-helper/subscribers","subscription_url":"https://api.github.com/repos/endlessm/eos-boot-helper/subscription","commits_url":"https://api.github.com/repos/endlessm/eos-boot-helper/commits{/sha}","git_commits_url":"https://api.github.com/repos/endlessm/eos-boot-helper/git/commits{/sha}","comments_url":"https://api.github.com/repos/endlessm/eos-boot-helper/comments{/number}","issue_comment_url":"https://api.github.com/repos/endlessm/eos-boot-helper/issues/comments{/number}","contents_url":"https://api.github.com/repos/endlessm/eos-boot-helper/contents/{+path}","compare_url":"https://api.github.com/repos/endlessm/eos-boot-helper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endlessm/eos-boot-helper/merges","archive_url":"https://api.github.com/repos/endlessm/eos-boot-helper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endlessm/eos-boot-helper/downloads","issues_url":"https://api.github.com/repos/endlessm/eos-boot-helper/issues{/number}","pulls_url":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls{/number}","milestones_url":"https://api.github.com/repos/endlessm/eos-boot-helper/milestones{/number}","notifications_url":"https://api.github.com/repos/endlessm/eos-boot-helper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endlessm/eos-boot-helper/labels{/name}","releases_url":"https://api.github.com/repos/endlessm/eos-boot-helper/releases{/id}","deployments_url":"https://api.github.com/repos/endlessm/eos-boot-helper/deployments","created_at":"2014-03-10T17:39:28Z","updated_at":"2018-06-04T21:04:01Z","pushed_at":"2018-06-05T21:49:59Z","git_url":"git://github.com/endlessm/eos-boot-helper.git","ssh_url":"[email protected]:endlessm/eos-boot-helper.git","clone_url":"https://github.com/endlessm/eos-boot-helper.git","svn_url":"https://github.com/endlessm/eos-boot-helper","homepage":"","size":476,"stargazers_count":5,"watchers_count":5,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":3,"open_issues":6,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/211"},"html":{"href":"https://github.com/endlessm/eos-boot-helper/pull/211"},"issue":{"href":"https://api.github.com/repos/endlessm/eos-boot-helper/issues/211"},"comments":{"href":"https://api.github.com/repos/endlessm/eos-boot-helper/issues/211/comments"},"review_comments":{"href":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/211/comments"},"review_comment":{"href":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/211/commits"},"statuses":{"href":"https://api.github.com/repos/endlessm/eos-boot-helper/statuses/aa5b25659fc1d9f1274b15d56cd5bc389b0b1d09"}},"author_association":"CONTRIBUTOR"}} | {
"id": 17601935,
"name": "endlessm/eos-boot-helper",
"url": "https://api.github.com/repos/endlessm/eos-boot-helper"
} | {
"id": 86760,
"login": "wjt",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/86760?",
"url": "https://api.github.com/users/wjt"
} | {
"id": 1930958,
"login": "endlessm",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1930958?",
"url": "https://api.github.com/orgs/endlessm"
} | 2018-06-06T15:13:16 | 7785249564 | {"actor":{"display_login":"wjt"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/haiwen/seahub/pulls/comments/205031541","pull_request_review_id":140219297,"id":205031541,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTAzMTU0MQ==","diff_hunk":"@@ -115,6 +115,7 @@ def base(request):\n 'enable_guest_invitation': ENABLE_GUEST_INVITATION,\n 'enable_terms_and_conditions': config.ENABLE_TERMS_AND_CONDITIONS,\n 'show_logout_icon': SHOW_LOGOUT_ICON,\n+ 'enable_user_clean': config.ENABLE_USER_CLEAN_TRASH,","path":"seahub/base/context_processors.py","position":13,"original_position":13,"commit_id":"cb5eb9bcb73a6f0095c18d58e60c94a5ed1b28d4","original_commit_id":"cb5eb9bcb73a6f0095c18d58e60c94a5ed1b28d4","user":{"login":"freeplant","id":109339,"node_id":"MDQ6VXNlcjEwOTMzOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/109339?v=4","gravatar_id":"","url":"https://api.github.com/users/freeplant","html_url":"https://github.com/freeplant","followers_url":"https://api.github.com/users/freeplant/followers","following_url":"https://api.github.com/users/freeplant/following{/other_user}","gists_url":"https://api.github.com/users/freeplant/gists{/gist_id}","starred_url":"https://api.github.com/users/freeplant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freeplant/subscriptions","organizations_url":"https://api.github.com/users/freeplant/orgs","repos_url":"https://api.github.com/users/freeplant/repos","events_url":"https://api.github.com/users/freeplant/events{/privacy}","received_events_url":"https://api.github.com/users/freeplant/received_events","type":"User","site_admin":false},"body":"enable_user_clean -> enable_user_clean_trash","created_at":"2018-07-25T08:57:13Z","updated_at":"2018-07-25T09:01:41Z","html_url":"https://github.com/haiwen/seahub/pull/2230#discussion_r205031541","pull_request_url":"https://api.github.com/repos/haiwen/seahub/pulls/2230","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/haiwen/seahub/pulls/comments/205031541"},"html":{"href":"https://github.com/haiwen/seahub/pull/2230#discussion_r205031541"},"pull_request":{"href":"https://api.github.com/repos/haiwen/seahub/pulls/2230"}}},"pull_request":{"url":"https://api.github.com/repos/haiwen/seahub/pulls/2230","id":203765002,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNzY1MDAy","html_url":"https://github.com/haiwen/seahub/pull/2230","diff_url":"https://github.com/haiwen/seahub/pull/2230.diff","patch_url":"https://github.com/haiwen/seahub/pull/2230.patch","issue_url":"https://api.github.com/repos/haiwen/seahub/issues/2230","number":2230,"state":"open","locked":false,"title":"new clean","user":{"login":"guopengda","id":38339714,"node_id":"MDQ6VXNlcjM4MzM5NzE0","avatar_url":"https://avatars3.githubusercontent.com/u/38339714?v=4","gravatar_id":"","url":"https://api.github.com/users/guopengda","html_url":"https://github.com/guopengda","followers_url":"https://api.github.com/users/guopengda/followers","following_url":"https://api.github.com/users/guopengda/following{/other_user}","gists_url":"https://api.github.com/users/guopengda/gists{/gist_id}","starred_url":"https://api.github.com/users/guopengda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guopengda/subscriptions","organizations_url":"https://api.github.com/users/guopengda/orgs","repos_url":"https://api.github.com/users/guopengda/repos","events_url":"https://api.github.com/users/guopengda/events{/privacy}","received_events_url":"https://api.github.com/users/guopengda/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-25T08:51:30Z","updated_at":"2018-07-25T09:01:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41d99adce9b109ecc71fe53e0c095ea290ed526e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/haiwen/seahub/pulls/2230/commits","review_comments_url":"https://api.github.com/repos/haiwen/seahub/pulls/2230/comments","review_comment_url":"https://api.github.com/repos/haiwen/seahub/pulls/comments{/number}","comments_url":"https://api.github.com/repos/haiwen/seahub/issues/2230/comments","statuses_url":"https://api.github.com/repos/haiwen/seahub/statuses/cb5eb9bcb73a6f0095c18d58e60c94a5ed1b28d4","head":{"label":"haiwen:enable-clean","ref":"enable-clean","sha":"cb5eb9bcb73a6f0095c18d58e60c94a5ed1b28d4","user":{"login":"haiwen","id":1948782,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDg3ODI=","avatar_url":"https://avatars3.githubusercontent.com/u/1948782?v=4","gravatar_id":"","url":"https://api.github.com/users/haiwen","html_url":"https://github.com/haiwen","followers_url":"https://api.github.com/users/haiwen/followers","following_url":"https://api.github.com/users/haiwen/following{/other_user}","gists_url":"https://api.github.com/users/haiwen/gists{/gist_id}","starred_url":"https://api.github.com/users/haiwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haiwen/subscriptions","organizations_url":"https://api.github.com/users/haiwen/orgs","repos_url":"https://api.github.com/users/haiwen/repos","events_url":"https://api.github.com/users/haiwen/events{/privacy}","received_events_url":"https://api.github.com/users/haiwen/received_events","type":"Organization","site_admin":false},"repo":{"id":6556815,"node_id":"MDEwOlJlcG9zaXRvcnk2NTU2ODE1","name":"seahub","full_name":"haiwen/seahub","owner":{"login":"haiwen","id":1948782,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDg3ODI=","avatar_url":"https://avatars3.githubusercontent.com/u/1948782?v=4","gravatar_id":"","url":"https://api.github.com/users/haiwen","html_url":"https://github.com/haiwen","followers_url":"https://api.github.com/users/haiwen/followers","following_url":"https://api.github.com/users/haiwen/following{/other_user}","gists_url":"https://api.github.com/users/haiwen/gists{/gist_id}","starred_url":"https://api.github.com/users/haiwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haiwen/subscriptions","organizations_url":"https://api.github.com/users/haiwen/orgs","repos_url":"https://api.github.com/users/haiwen/repos","events_url":"https://api.github.com/users/haiwen/events{/privacy}","received_events_url":"https://api.github.com/users/haiwen/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/haiwen/seahub","description":"The web end of seafile server.","fork":false,"url":"https://api.github.com/repos/haiwen/seahub","forks_url":"https://api.github.com/repos/haiwen/seahub/forks","keys_url":"https://api.github.com/repos/haiwen/seahub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haiwen/seahub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haiwen/seahub/teams","hooks_url":"https://api.github.com/repos/haiwen/seahub/hooks","issue_events_url":"https://api.github.com/repos/haiwen/seahub/issues/events{/number}","events_url":"https://api.github.com/repos/haiwen/seahub/events","assignees_url":"https://api.github.com/repos/haiwen/seahub/assignees{/user}","branches_url":"https://api.github.com/repos/haiwen/seahub/branches{/branch}","tags_url":"https://api.github.com/repos/haiwen/seahub/tags","blobs_url":"https://api.github.com/repos/haiwen/seahub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haiwen/seahub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haiwen/seahub/git/refs{/sha}","trees_url":"https://api.github.com/repos/haiwen/seahub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haiwen/seahub/statuses/{sha}","languages_url":"https://api.github.com/repos/haiwen/seahub/languages","stargazers_url":"https://api.github.com/repos/haiwen/seahub/stargazers","contributors_url":"https://api.github.com/repos/haiwen/seahub/contributors","subscribers_url":"https://api.github.com/repos/haiwen/seahub/subscribers","subscription_url":"https://api.github.com/repos/haiwen/seahub/subscription","commits_url":"https://api.github.com/repos/haiwen/seahub/commits{/sha}","git_commits_url":"https://api.github.com/repos/haiwen/seahub/git/commits{/sha}","comments_url":"https://api.github.com/repos/haiwen/seahub/comments{/number}","issue_comment_url":"https://api.github.com/repos/haiwen/seahub/issues/comments{/number}","contents_url":"https://api.github.com/repos/haiwen/seahub/contents/{+path}","compare_url":"https://api.github.com/repos/haiwen/seahub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haiwen/seahub/merges","archive_url":"https://api.github.com/repos/haiwen/seahub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haiwen/seahub/downloads","issues_url":"https://api.github.com/repos/haiwen/seahub/issues{/number}","pulls_url":"https://api.github.com/repos/haiwen/seahub/pulls{/number}","milestones_url":"https://api.github.com/repos/haiwen/seahub/milestones{/number}","notifications_url":"https://api.github.com/repos/haiwen/seahub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haiwen/seahub/labels{/name}","releases_url":"https://api.github.com/repos/haiwen/seahub/releases{/id}","deployments_url":"https://api.github.com/repos/haiwen/seahub/deployments","created_at":"2012-11-06T05:07:24Z","updated_at":"2018-07-23T10:04:05Z","pushed_at":"2018-07-25T08:51:31Z","git_url":"git://github.com/haiwen/seahub.git","ssh_url":"[email protected]:haiwen/seahub.git","clone_url":"https://github.com/haiwen/seahub.git","svn_url":"https://github.com/haiwen/seahub","homepage":"seafile.com","size":87730,"stargazers_count":314,"watchers_count":314,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":253,"mirror_url":null,"archived":false,"open_issues_count":118,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":253,"open_issues":118,"watchers":314,"default_branch":"master"}},"base":{"label":"haiwen:6.3","ref":"6.3","sha":"d3337c44c5d929be92e249338c3fe5349ed36d9b","user":{"login":"haiwen","id":1948782,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDg3ODI=","avatar_url":"https://avatars3.githubusercontent.com/u/1948782?v=4","gravatar_id":"","url":"https://api.github.com/users/haiwen","html_url":"https://github.com/haiwen","followers_url":"https://api.github.com/users/haiwen/followers","following_url":"https://api.github.com/users/haiwen/following{/other_user}","gists_url":"https://api.github.com/users/haiwen/gists{/gist_id}","starred_url":"https://api.github.com/users/haiwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haiwen/subscriptions","organizations_url":"https://api.github.com/users/haiwen/orgs","repos_url":"https://api.github.com/users/haiwen/repos","events_url":"https://api.github.com/users/haiwen/events{/privacy}","received_events_url":"https://api.github.com/users/haiwen/received_events","type":"Organization","site_admin":false},"repo":{"id":6556815,"node_id":"MDEwOlJlcG9zaXRvcnk2NTU2ODE1","name":"seahub","full_name":"haiwen/seahub","owner":{"login":"haiwen","id":1948782,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDg3ODI=","avatar_url":"https://avatars3.githubusercontent.com/u/1948782?v=4","gravatar_id":"","url":"https://api.github.com/users/haiwen","html_url":"https://github.com/haiwen","followers_url":"https://api.github.com/users/haiwen/followers","following_url":"https://api.github.com/users/haiwen/following{/other_user}","gists_url":"https://api.github.com/users/haiwen/gists{/gist_id}","starred_url":"https://api.github.com/users/haiwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haiwen/subscriptions","organizations_url":"https://api.github.com/users/haiwen/orgs","repos_url":"https://api.github.com/users/haiwen/repos","events_url":"https://api.github.com/users/haiwen/events{/privacy}","received_events_url":"https://api.github.com/users/haiwen/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/haiwen/seahub","description":"The web end of seafile server.","fork":false,"url":"https://api.github.com/repos/haiwen/seahub","forks_url":"https://api.github.com/repos/haiwen/seahub/forks","keys_url":"https://api.github.com/repos/haiwen/seahub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haiwen/seahub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haiwen/seahub/teams","hooks_url":"https://api.github.com/repos/haiwen/seahub/hooks","issue_events_url":"https://api.github.com/repos/haiwen/seahub/issues/events{/number}","events_url":"https://api.github.com/repos/haiwen/seahub/events","assignees_url":"https://api.github.com/repos/haiwen/seahub/assignees{/user}","branches_url":"https://api.github.com/repos/haiwen/seahub/branches{/branch}","tags_url":"https://api.github.com/repos/haiwen/seahub/tags","blobs_url":"https://api.github.com/repos/haiwen/seahub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haiwen/seahub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haiwen/seahub/git/refs{/sha}","trees_url":"https://api.github.com/repos/haiwen/seahub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haiwen/seahub/statuses/{sha}","languages_url":"https://api.github.com/repos/haiwen/seahub/languages","stargazers_url":"https://api.github.com/repos/haiwen/seahub/stargazers","contributors_url":"https://api.github.com/repos/haiwen/seahub/contributors","subscribers_url":"https://api.github.com/repos/haiwen/seahub/subscribers","subscription_url":"https://api.github.com/repos/haiwen/seahub/subscription","commits_url":"https://api.github.com/repos/haiwen/seahub/commits{/sha}","git_commits_url":"https://api.github.com/repos/haiwen/seahub/git/commits{/sha}","comments_url":"https://api.github.com/repos/haiwen/seahub/comments{/number}","issue_comment_url":"https://api.github.com/repos/haiwen/seahub/issues/comments{/number}","contents_url":"https://api.github.com/repos/haiwen/seahub/contents/{+path}","compare_url":"https://api.github.com/repos/haiwen/seahub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haiwen/seahub/merges","archive_url":"https://api.github.com/repos/haiwen/seahub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haiwen/seahub/downloads","issues_url":"https://api.github.com/repos/haiwen/seahub/issues{/number}","pulls_url":"https://api.github.com/repos/haiwen/seahub/pulls{/number}","milestones_url":"https://api.github.com/repos/haiwen/seahub/milestones{/number}","notifications_url":"https://api.github.com/repos/haiwen/seahub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haiwen/seahub/labels{/name}","releases_url":"https://api.github.com/repos/haiwen/seahub/releases{/id}","deployments_url":"https://api.github.com/repos/haiwen/seahub/deployments","created_at":"2012-11-06T05:07:24Z","updated_at":"2018-07-23T10:04:05Z","pushed_at":"2018-07-25T08:51:31Z","git_url":"git://github.com/haiwen/seahub.git","ssh_url":"[email protected]:haiwen/seahub.git","clone_url":"https://github.com/haiwen/seahub.git","svn_url":"https://github.com/haiwen/seahub","homepage":"seafile.com","size":87730,"stargazers_count":314,"watchers_count":314,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":253,"mirror_url":null,"archived":false,"open_issues_count":118,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":253,"open_issues":118,"watchers":314,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/haiwen/seahub/pulls/2230"},"html":{"href":"https://github.com/haiwen/seahub/pull/2230"},"issue":{"href":"https://api.github.com/repos/haiwen/seahub/issues/2230"},"comments":{"href":"https://api.github.com/repos/haiwen/seahub/issues/2230/comments"},"review_comments":{"href":"https://api.github.com/repos/haiwen/seahub/pulls/2230/comments"},"review_comment":{"href":"https://api.github.com/repos/haiwen/seahub/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/haiwen/seahub/pulls/2230/commits"},"statuses":{"href":"https://api.github.com/repos/haiwen/seahub/statuses/cb5eb9bcb73a6f0095c18d58e60c94a5ed1b28d4"}},"author_association":"NONE"}} | {
"id": 6556815,
"name": "haiwen/seahub",
"url": "https://api.github.com/repos/haiwen/seahub"
} | {
"id": 109339,
"login": "freeplant",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/109339?",
"url": "https://api.github.com/users/freeplant"
} | {
"id": 1948782,
"login": "haiwen",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1948782?",
"url": "https://api.github.com/orgs/haiwen"
} | 2018-07-25T08:57:13 | 8015123440 | {"actor":{"display_login":"freeplant"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/cirope/mawidabp/pulls/comments/189750972","pull_request_review_id":121990207,"id":189750972,"diff_hunk":"@@ -289,6 +289,9 @@ es:\n manager_attribute: 'Atributo con el superior'\n test_user: 'Usuario'\n test_password: 'Contraseña'\n+ service_user: 'Usuario de servicio'","path":"config/locales/models.es.yml","position":4,"original_position":4,"commit_id":"05a417289718c17e22e1e9ad7b1a72719c424f40","original_commit_id":"05a417289718c17e22e1e9ad7b1a72719c424f40","user":{"login":"Shelvak","id":873323,"avatar_url":"https://avatars3.githubusercontent.com/u/873323?v=4","gravatar_id":"","url":"https://api.github.com/users/Shelvak","html_url":"https://github.com/Shelvak","followers_url":"https://api.github.com/users/Shelvak/followers","following_url":"https://api.github.com/users/Shelvak/following{/other_user}","gists_url":"https://api.github.com/users/Shelvak/gists{/gist_id}","starred_url":"https://api.github.com/users/Shelvak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shelvak/subscriptions","organizations_url":"https://api.github.com/users/Shelvak/orgs","repos_url":"https://api.github.com/users/Shelvak/repos","events_url":"https://api.github.com/users/Shelvak/events{/privacy}","received_events_url":"https://api.github.com/users/Shelvak/received_events","type":"User","site_admin":false},"body":"me encantaría que me tires un mejor nombre para esto jaja","created_at":"2018-05-22T00:45:48Z","updated_at":"2018-05-22T00:46:10Z","html_url":"https://github.com/cirope/mawidabp/pull/63#discussion_r189750972","pull_request_url":"https://api.github.com/repos/cirope/mawidabp/pulls/63","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/cirope/mawidabp/pulls/comments/189750972"},"html":{"href":"https://github.com/cirope/mawidabp/pull/63#discussion_r189750972"},"pull_request":{"href":"https://api.github.com/repos/cirope/mawidabp/pulls/63"}}},"pull_request":{"url":"https://api.github.com/repos/cirope/mawidabp/pulls/63","id":189521746,"html_url":"https://github.com/cirope/mawidabp/pull/63","diff_url":"https://github.com/cirope/mawidabp/pull/63.diff","patch_url":"https://github.com/cirope/mawidabp/pull/63.patch","issue_url":"https://api.github.com/repos/cirope/mawidabp/issues/63","number":63,"state":"open","locked":false,"title":"Ldap ServiceUser for async import","user":{"login":"Shelvak","id":873323,"avatar_url":"https://avatars3.githubusercontent.com/u/873323?v=4","gravatar_id":"","url":"https://api.github.com/users/Shelvak","html_url":"https://github.com/Shelvak","followers_url":"https://api.github.com/users/Shelvak/followers","following_url":"https://api.github.com/users/Shelvak/following{/other_user}","gists_url":"https://api.github.com/users/Shelvak/gists{/gist_id}","starred_url":"https://api.github.com/users/Shelvak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shelvak/subscriptions","organizations_url":"https://api.github.com/users/Shelvak/orgs","repos_url":"https://api.github.com/users/Shelvak/repos","events_url":"https://api.github.com/users/Shelvak/events{/privacy}","received_events_url":"https://api.github.com/users/Shelvak/received_events","type":"User","site_admin":false},"body":"- Agregamos un usuario \"de servicio\" para poder importar asincronamente.\r\n- Metemos lógica de modelo + test\r\n\r\n- Faltaría agregar la vista, si estamos de acuerdo con lo hecho","created_at":"2018-05-22T00:43:33Z","updated_at":"2018-05-22T00:46:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76151a8d3a323790ca24f38c0189b464715b2f8c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"francocatena","id":85371,"avatar_url":"https://avatars3.githubusercontent.com/u/85371?v=4","gravatar_id":"","url":"https://api.github.com/users/francocatena","html_url":"https://github.com/francocatena","followers_url":"https://api.github.com/users/francocatena/followers","following_url":"https://api.github.com/users/francocatena/following{/other_user}","gists_url":"https://api.github.com/users/francocatena/gists{/gist_id}","starred_url":"https://api.github.com/users/francocatena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/francocatena/subscriptions","organizations_url":"https://api.github.com/users/francocatena/orgs","repos_url":"https://api.github.com/users/francocatena/repos","events_url":"https://api.github.com/users/francocatena/events{/privacy}","received_events_url":"https://api.github.com/users/francocatena/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":23640138,"url":"https://api.github.com/repos/cirope/mawidabp/labels/improvement","name":"improvement","color":"02e10c","default":false},{"id":931800840,"url":"https://api.github.com/repos/cirope/mawidabp/labels/proposal","name":"proposal","color":"9af4f0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cirope/mawidabp/pulls/63/commits","review_comments_url":"https://api.github.com/repos/cirope/mawidabp/pulls/63/comments","review_comment_url":"https://api.github.com/repos/cirope/mawidabp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cirope/mawidabp/issues/63/comments","statuses_url":"https://api.github.com/repos/cirope/mawidabp/statuses/05a417289718c17e22e1e9ad7b1a72719c424f40","head":{"label":"cirope:ldap_service_import","ref":"ldap_service_import","sha":"05a417289718c17e22e1e9ad7b1a72719c424f40","user":{"login":"cirope","id":2007113,"avatar_url":"https://avatars2.githubusercontent.com/u/2007113?v=4","gravatar_id":"","url":"https://api.github.com/users/cirope","html_url":"https://github.com/cirope","followers_url":"https://api.github.com/users/cirope/followers","following_url":"https://api.github.com/users/cirope/following{/other_user}","gists_url":"https://api.github.com/users/cirope/gists{/gist_id}","starred_url":"https://api.github.com/users/cirope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cirope/subscriptions","organizations_url":"https://api.github.com/users/cirope/orgs","repos_url":"https://api.github.com/users/cirope/repos","events_url":"https://api.github.com/users/cirope/events{/privacy}","received_events_url":"https://api.github.com/users/cirope/received_events","type":"Organization","site_admin":false},"repo":{"id":1271571,"name":"mawidabp","full_name":"cirope/mawidabp","owner":{"login":"cirope","id":2007113,"avatar_url":"https://avatars2.githubusercontent.com/u/2007113?v=4","gravatar_id":"","url":"https://api.github.com/users/cirope","html_url":"https://github.com/cirope","followers_url":"https://api.github.com/users/cirope/followers","following_url":"https://api.github.com/users/cirope/following{/other_user}","gists_url":"https://api.github.com/users/cirope/gists{/gist_id}","starred_url":"https://api.github.com/users/cirope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cirope/subscriptions","organizations_url":"https://api.github.com/users/cirope/orgs","repos_url":"https://api.github.com/users/cirope/repos","events_url":"https://api.github.com/users/cirope/events{/privacy}","received_events_url":"https://api.github.com/users/cirope/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cirope/mawidabp","description":"Audit asistant web application","fork":false,"url":"https://api.github.com/repos/cirope/mawidabp","forks_url":"https://api.github.com/repos/cirope/mawidabp/forks","keys_url":"https://api.github.com/repos/cirope/mawidabp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cirope/mawidabp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cirope/mawidabp/teams","hooks_url":"https://api.github.com/repos/cirope/mawidabp/hooks","issue_events_url":"https://api.github.com/repos/cirope/mawidabp/issues/events{/number}","events_url":"https://api.github.com/repos/cirope/mawidabp/events","assignees_url":"https://api.github.com/repos/cirope/mawidabp/assignees{/user}","branches_url":"https://api.github.com/repos/cirope/mawidabp/branches{/branch}","tags_url":"https://api.github.com/repos/cirope/mawidabp/tags","blobs_url":"https://api.github.com/repos/cirope/mawidabp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cirope/mawidabp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cirope/mawidabp/git/refs{/sha}","trees_url":"https://api.github.com/repos/cirope/mawidabp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cirope/mawidabp/statuses/{sha}","languages_url":"https://api.github.com/repos/cirope/mawidabp/languages","stargazers_url":"https://api.github.com/repos/cirope/mawidabp/stargazers","contributors_url":"https://api.github.com/repos/cirope/mawidabp/contributors","subscribers_url":"https://api.github.com/repos/cirope/mawidabp/subscribers","subscription_url":"https://api.github.com/repos/cirope/mawidabp/subscription","commits_url":"https://api.github.com/repos/cirope/mawidabp/commits{/sha}","git_commits_url":"https://api.github.com/repos/cirope/mawidabp/git/commits{/sha}","comments_url":"https://api.github.com/repos/cirope/mawidabp/comments{/number}","issue_comment_url":"https://api.github.com/repos/cirope/mawidabp/issues/comments{/number}","contents_url":"https://api.github.com/repos/cirope/mawidabp/contents/{+path}","compare_url":"https://api.github.com/repos/cirope/mawidabp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cirope/mawidabp/merges","archive_url":"https://api.github.com/repos/cirope/mawidabp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cirope/mawidabp/downloads","issues_url":"https://api.github.com/repos/cirope/mawidabp/issues{/number}","pulls_url":"https://api.github.com/repos/cirope/mawidabp/pulls{/number}","milestones_url":"https://api.github.com/repos/cirope/mawidabp/milestones{/number}","notifications_url":"https://api.github.com/repos/cirope/mawidabp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cirope/mawidabp/labels{/name}","releases_url":"https://api.github.com/repos/cirope/mawidabp/releases{/id}","deployments_url":"https://api.github.com/repos/cirope/mawidabp/deployments","created_at":"2011-01-19T17:09:32Z","updated_at":"2018-05-22T00:37:46Z","pushed_at":"2018-05-22T00:43:34Z","git_url":"git://github.com/cirope/mawidabp.git","ssh_url":"[email protected]:cirope/mawidabp.git","clone_url":"https://github.com/cirope/mawidabp.git","svn_url":"https://github.com/cirope/mawidabp","homepage":"","size":16099,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":13,"watchers":1,"default_branch":"master"}},"base":{"label":"cirope:master","ref":"master","sha":"aca983cdb76602821e9412e7a6d6065ffbc9b8fa","user":{"login":"cirope","id":2007113,"avatar_url":"https://avatars2.githubusercontent.com/u/2007113?v=4","gravatar_id":"","url":"https://api.github.com/users/cirope","html_url":"https://github.com/cirope","followers_url":"https://api.github.com/users/cirope/followers","following_url":"https://api.github.com/users/cirope/following{/other_user}","gists_url":"https://api.github.com/users/cirope/gists{/gist_id}","starred_url":"https://api.github.com/users/cirope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cirope/subscriptions","organizations_url":"https://api.github.com/users/cirope/orgs","repos_url":"https://api.github.com/users/cirope/repos","events_url":"https://api.github.com/users/cirope/events{/privacy}","received_events_url":"https://api.github.com/users/cirope/received_events","type":"Organization","site_admin":false},"repo":{"id":1271571,"name":"mawidabp","full_name":"cirope/mawidabp","owner":{"login":"cirope","id":2007113,"avatar_url":"https://avatars2.githubusercontent.com/u/2007113?v=4","gravatar_id":"","url":"https://api.github.com/users/cirope","html_url":"https://github.com/cirope","followers_url":"https://api.github.com/users/cirope/followers","following_url":"https://api.github.com/users/cirope/following{/other_user}","gists_url":"https://api.github.com/users/cirope/gists{/gist_id}","starred_url":"https://api.github.com/users/cirope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cirope/subscriptions","organizations_url":"https://api.github.com/users/cirope/orgs","repos_url":"https://api.github.com/users/cirope/repos","events_url":"https://api.github.com/users/cirope/events{/privacy}","received_events_url":"https://api.github.com/users/cirope/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cirope/mawidabp","description":"Audit asistant web application","fork":false,"url":"https://api.github.com/repos/cirope/mawidabp","forks_url":"https://api.github.com/repos/cirope/mawidabp/forks","keys_url":"https://api.github.com/repos/cirope/mawidabp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cirope/mawidabp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cirope/mawidabp/teams","hooks_url":"https://api.github.com/repos/cirope/mawidabp/hooks","issue_events_url":"https://api.github.com/repos/cirope/mawidabp/issues/events{/number}","events_url":"https://api.github.com/repos/cirope/mawidabp/events","assignees_url":"https://api.github.com/repos/cirope/mawidabp/assignees{/user}","branches_url":"https://api.github.com/repos/cirope/mawidabp/branches{/branch}","tags_url":"https://api.github.com/repos/cirope/mawidabp/tags","blobs_url":"https://api.github.com/repos/cirope/mawidabp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cirope/mawidabp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cirope/mawidabp/git/refs{/sha}","trees_url":"https://api.github.com/repos/cirope/mawidabp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cirope/mawidabp/statuses/{sha}","languages_url":"https://api.github.com/repos/cirope/mawidabp/languages","stargazers_url":"https://api.github.com/repos/cirope/mawidabp/stargazers","contributors_url":"https://api.github.com/repos/cirope/mawidabp/contributors","subscribers_url":"https://api.github.com/repos/cirope/mawidabp/subscribers","subscription_url":"https://api.github.com/repos/cirope/mawidabp/subscription","commits_url":"https://api.github.com/repos/cirope/mawidabp/commits{/sha}","git_commits_url":"https://api.github.com/repos/cirope/mawidabp/git/commits{/sha}","comments_url":"https://api.github.com/repos/cirope/mawidabp/comments{/number}","issue_comment_url":"https://api.github.com/repos/cirope/mawidabp/issues/comments{/number}","contents_url":"https://api.github.com/repos/cirope/mawidabp/contents/{+path}","compare_url":"https://api.github.com/repos/cirope/mawidabp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cirope/mawidabp/merges","archive_url":"https://api.github.com/repos/cirope/mawidabp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cirope/mawidabp/downloads","issues_url":"https://api.github.com/repos/cirope/mawidabp/issues{/number}","pulls_url":"https://api.github.com/repos/cirope/mawidabp/pulls{/number}","milestones_url":"https://api.github.com/repos/cirope/mawidabp/milestones{/number}","notifications_url":"https://api.github.com/repos/cirope/mawidabp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cirope/mawidabp/labels{/name}","releases_url":"https://api.github.com/repos/cirope/mawidabp/releases{/id}","deployments_url":"https://api.github.com/repos/cirope/mawidabp/deployments","created_at":"2011-01-19T17:09:32Z","updated_at":"2018-05-22T00:37:46Z","pushed_at":"2018-05-22T00:43:34Z","git_url":"git://github.com/cirope/mawidabp.git","ssh_url":"[email protected]:cirope/mawidabp.git","clone_url":"https://github.com/cirope/mawidabp.git","svn_url":"https://github.com/cirope/mawidabp","homepage":"","size":16099,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":13,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cirope/mawidabp/pulls/63"},"html":{"href":"https://github.com/cirope/mawidabp/pull/63"},"issue":{"href":"https://api.github.com/repos/cirope/mawidabp/issues/63"},"comments":{"href":"https://api.github.com/repos/cirope/mawidabp/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/cirope/mawidabp/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/cirope/mawidabp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cirope/mawidabp/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/cirope/mawidabp/statuses/05a417289718c17e22e1e9ad7b1a72719c424f40"}},"author_association":"COLLABORATOR"}} | {
"id": 1271571,
"name": "cirope/mawidabp",
"url": "https://api.github.com/repos/cirope/mawidabp"
} | {
"id": 873323,
"login": "Shelvak",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/873323?",
"url": "https://api.github.com/users/Shelvak"
} | {
"id": 2007113,
"login": "cirope",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2007113?",
"url": "https://api.github.com/orgs/cirope"
} | 2018-05-22T00:45:48 | 7707776951 | {"actor":{"display_login":"Shelvak"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/makimo/django-eav2/pulls/comments/197079548","pull_request_review_id":130749726,"id":197079548,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzA3OTU0OA==","diff_hunk":"@@ -595,6 +603,16 @@ def get_value_by_attribute(self, attribute):\n '''\n return self.get_values().get(attribute=attribute)\n \n+ def get_object_attributes(self):","path":"eav/models.py","position":167,"original_position":167,"commit_id":"7e9a60daba7b8c8261f667159c322d4e03c0f0ff","original_commit_id":"7e9a60daba7b8c8261f667159c322d4e03c0f0ff","user":{"login":"IwoHerka","id":9204550,"node_id":"MDQ6VXNlcjkyMDQ1NTA=","avatar_url":"https://avatars1.githubusercontent.com/u/9204550?v=4","gravatar_id":"","url":"https://api.github.com/users/IwoHerka","html_url":"https://github.com/IwoHerka","followers_url":"https://api.github.com/users/IwoHerka/followers","following_url":"https://api.github.com/users/IwoHerka/following{/other_user}","gists_url":"https://api.github.com/users/IwoHerka/gists{/gist_id}","starred_url":"https://api.github.com/users/IwoHerka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IwoHerka/subscriptions","organizations_url":"https://api.github.com/users/IwoHerka/orgs","repos_url":"https://api.github.com/users/IwoHerka/repos","events_url":"https://api.github.com/users/IwoHerka/events{/privacy}","received_events_url":"https://api.github.com/users/IwoHerka/received_events","type":"User","site_admin":false},"body":"The last one is cool. :)\r\n\r\nOkay, so I take it there are no objections in using `__dict__`. I was worried about that.","created_at":"2018-06-21T10:08:47Z","updated_at":"2018-06-21T10:08:48Z","html_url":"https://github.com/makimo/django-eav2/pull/17#discussion_r197079548","pull_request_url":"https://api.github.com/repos/makimo/django-eav2/pulls/17","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/makimo/django-eav2/pulls/comments/197079548"},"html":{"href":"https://github.com/makimo/django-eav2/pull/17#discussion_r197079548"},"pull_request":{"href":"https://api.github.com/repos/makimo/django-eav2/pulls/17"}},"in_reply_to_id":197068556},"pull_request":{"url":"https://api.github.com/repos/makimo/django-eav2/pulls/17","id":196362216,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MzYyMjE2","html_url":"https://github.com/makimo/django-eav2/pull/17","diff_url":"https://github.com/makimo/django-eav2/pull/17.diff","patch_url":"https://github.com/makimo/django-eav2/pull/17.patch","issue_url":"https://api.github.com/repos/makimo/django-eav2/issues/17","number":17,"state":"open","locked":false,"title":"Validate against illegal assignments","user":{"login":"IwoHerka","id":9204550,"node_id":"MDQ6VXNlcjkyMDQ1NTA=","avatar_url":"https://avatars1.githubusercontent.com/u/9204550?v=4","gravatar_id":"","url":"https://api.github.com/users/IwoHerka","html_url":"https://github.com/IwoHerka","followers_url":"https://api.github.com/users/IwoHerka/followers","following_url":"https://api.github.com/users/IwoHerka/following{/other_user}","gists_url":"https://api.github.com/users/IwoHerka/gists{/gist_id}","starred_url":"https://api.github.com/users/IwoHerka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IwoHerka/subscriptions","organizations_url":"https://api.github.com/users/IwoHerka/orgs","repos_url":"https://api.github.com/users/IwoHerka/repos","events_url":"https://api.github.com/users/IwoHerka/events{/privacy}","received_events_url":"https://api.github.com/users/IwoHerka/received_events","type":"User","site_admin":false},"body":"Throw exception if user makes value assignment for attributes excluded for the entity.\r\n\r\nAdditionally, rename misleading `self.model` to `self.instance` and make minor style changes.\r\n\r\nSolves #12.","created_at":"2018-06-21T07:43:09Z","updated_at":"2018-06-21T10:08:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df5d87623219e3c82322c88f4d1fecfb418b25f6","assignee":{"login":"IwoHerka","id":9204550,"node_id":"MDQ6VXNlcjkyMDQ1NTA=","avatar_url":"https://avatars1.githubusercontent.com/u/9204550?v=4","gravatar_id":"","url":"https://api.github.com/users/IwoHerka","html_url":"https://github.com/IwoHerka","followers_url":"https://api.github.com/users/IwoHerka/followers","following_url":"https://api.github.com/users/IwoHerka/following{/other_user}","gists_url":"https://api.github.com/users/IwoHerka/gists{/gist_id}","starred_url":"https://api.github.com/users/IwoHerka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IwoHerka/subscriptions","organizations_url":"https://api.github.com/users/IwoHerka/orgs","repos_url":"https://api.github.com/users/IwoHerka/repos","events_url":"https://api.github.com/users/IwoHerka/events{/privacy}","received_events_url":"https://api.github.com/users/IwoHerka/received_events","type":"User","site_admin":false},"assignees":[{"login":"IwoHerka","id":9204550,"node_id":"MDQ6VXNlcjkyMDQ1NTA=","avatar_url":"https://avatars1.githubusercontent.com/u/9204550?v=4","gravatar_id":"","url":"https://api.github.com/users/IwoHerka","html_url":"https://github.com/IwoHerka","followers_url":"https://api.github.com/users/IwoHerka/followers","following_url":"https://api.github.com/users/IwoHerka/following{/other_user}","gists_url":"https://api.github.com/users/IwoHerka/gists{/gist_id}","starred_url":"https://api.github.com/users/IwoHerka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IwoHerka/subscriptions","organizations_url":"https://api.github.com/users/IwoHerka/orgs","repos_url":"https://api.github.com/users/IwoHerka/repos","events_url":"https://api.github.com/users/IwoHerka/events{/privacy}","received_events_url":"https://api.github.com/users/IwoHerka/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"dragonee","id":937024,"node_id":"MDQ6VXNlcjkzNzAyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/937024?v=4","gravatar_id":"","url":"https://api.github.com/users/dragonee","html_url":"https://github.com/dragonee","followers_url":"https://api.github.com/users/dragonee/followers","following_url":"https://api.github.com/users/dragonee/following{/other_user}","gists_url":"https://api.github.com/users/dragonee/gists{/gist_id}","starred_url":"https://api.github.com/users/dragonee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dragonee/subscriptions","organizations_url":"https://api.github.com/users/dragonee/orgs","repos_url":"https://api.github.com/users/dragonee/repos","events_url":"https://api.github.com/users/dragonee/events{/privacy}","received_events_url":"https://api.github.com/users/dragonee/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":881428936,"node_id":"MDU6TGFiZWw4ODE0Mjg5MzY=","url":"https://api.github.com/repos/makimo/django-eav2/labels/enhancement","name":"enhancement","color":"33ddb0","default":true}],"milestone":{"url":"https://api.github.com/repos/makimo/django-eav2/milestones/1","html_url":"https://github.com/makimo/django-eav2/milestone/1","labels_url":"https://api.github.com/repos/makimo/django-eav2/milestones/1/labels","id":3354371,"node_id":"MDk6TWlsZXN0b25lMzM1NDM3MQ==","number":1,"title":"Re-release","description":"What needs to be fixed/added/documented before re-releasing the package.","creator":{"login":"IwoHerka","id":9204550,"node_id":"MDQ6VXNlcjkyMDQ1NTA=","avatar_url":"https://avatars1.githubusercontent.com/u/9204550?v=4","gravatar_id":"","url":"https://api.github.com/users/IwoHerka","html_url":"https://github.com/IwoHerka","followers_url":"https://api.github.com/users/IwoHerka/followers","following_url":"https://api.github.com/users/IwoHerka/following{/other_user}","gists_url":"https://api.github.com/users/IwoHerka/gists{/gist_id}","starred_url":"https://api.github.com/users/IwoHerka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IwoHerka/subscriptions","organizations_url":"https://api.github.com/users/IwoHerka/orgs","repos_url":"https://api.github.com/users/IwoHerka/repos","events_url":"https://api.github.com/users/IwoHerka/events{/privacy}","received_events_url":"https://api.github.com/users/IwoHerka/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":4,"state":"open","created_at":"2018-05-17T11:35:57Z","updated_at":"2018-06-21T07:43:09Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/makimo/django-eav2/pulls/17/commits","review_comments_url":"https://api.github.com/repos/makimo/django-eav2/pulls/17/comments","review_comment_url":"https://api.github.com/repos/makimo/django-eav2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/makimo/django-eav2/issues/17/comments","statuses_url":"https://api.github.com/repos/makimo/django-eav2/statuses/7e9a60daba7b8c8261f667159c322d4e03c0f0ff","head":{"label":"makimo:improvement/disallowed-attr-validation","ref":"improvement/disallowed-attr-validation","sha":"7e9a60daba7b8c8261f667159c322d4e03c0f0ff","user":{"login":"makimo","id":2085227,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODUyMjc=","avatar_url":"https://avatars0.githubusercontent.com/u/2085227?v=4","gravatar_id":"","url":"https://api.github.com/users/makimo","html_url":"https://github.com/makimo","followers_url":"https://api.github.com/users/makimo/followers","following_url":"https://api.github.com/users/makimo/following{/other_user}","gists_url":"https://api.github.com/users/makimo/gists{/gist_id}","starred_url":"https://api.github.com/users/makimo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makimo/subscriptions","organizations_url":"https://api.github.com/users/makimo/orgs","repos_url":"https://api.github.com/users/makimo/repos","events_url":"https://api.github.com/users/makimo/events{/privacy}","received_events_url":"https://api.github.com/users/makimo/received_events","type":"Organization","site_admin":false},"repo":{"id":127006653,"node_id":"MDEwOlJlcG9zaXRvcnkxMjcwMDY2NTM=","name":"django-eav2","full_name":"makimo/django-eav2","owner":{"login":"makimo","id":2085227,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODUyMjc=","avatar_url":"https://avatars0.githubusercontent.com/u/2085227?v=4","gravatar_id":"","url":"https://api.github.com/users/makimo","html_url":"https://github.com/makimo","followers_url":"https://api.github.com/users/makimo/followers","following_url":"https://api.github.com/users/makimo/following{/other_user}","gists_url":"https://api.github.com/users/makimo/gists{/gist_id}","starred_url":"https://api.github.com/users/makimo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makimo/subscriptions","organizations_url":"https://api.github.com/users/makimo/orgs","repos_url":"https://api.github.com/users/makimo/repos","events_url":"https://api.github.com/users/makimo/events{/privacy}","received_events_url":"https://api.github.com/users/makimo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/makimo/django-eav2","description":"Django EAV 2 - EAV storage for Django","fork":false,"url":"https://api.github.com/repos/makimo/django-eav2","forks_url":"https://api.github.com/repos/makimo/django-eav2/forks","keys_url":"https://api.github.com/repos/makimo/django-eav2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/makimo/django-eav2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/makimo/django-eav2/teams","hooks_url":"https://api.github.com/repos/makimo/django-eav2/hooks","issue_events_url":"https://api.github.com/repos/makimo/django-eav2/issues/events{/number}","events_url":"https://api.github.com/repos/makimo/django-eav2/events","assignees_url":"https://api.github.com/repos/makimo/django-eav2/assignees{/user}","branches_url":"https://api.github.com/repos/makimo/django-eav2/branches{/branch}","tags_url":"https://api.github.com/repos/makimo/django-eav2/tags","blobs_url":"https://api.github.com/repos/makimo/django-eav2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/makimo/django-eav2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/makimo/django-eav2/git/refs{/sha}","trees_url":"https://api.github.com/repos/makimo/django-eav2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/makimo/django-eav2/statuses/{sha}","languages_url":"https://api.github.com/repos/makimo/django-eav2/languages","stargazers_url":"https://api.github.com/repos/makimo/django-eav2/stargazers","contributors_url":"https://api.github.com/repos/makimo/django-eav2/contributors","subscribers_url":"https://api.github.com/repos/makimo/django-eav2/subscribers","subscription_url":"https://api.github.com/repos/makimo/django-eav2/subscription","commits_url":"https://api.github.com/repos/makimo/django-eav2/commits{/sha}","git_commits_url":"https://api.github.com/repos/makimo/django-eav2/git/commits{/sha}","comments_url":"https://api.github.com/repos/makimo/django-eav2/comments{/number}","issue_comment_url":"https://api.github.com/repos/makimo/django-eav2/issues/comments{/number}","contents_url":"https://api.github.com/repos/makimo/django-eav2/contents/{+path}","compare_url":"https://api.github.com/repos/makimo/django-eav2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/makimo/django-eav2/merges","archive_url":"https://api.github.com/repos/makimo/django-eav2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/makimo/django-eav2/downloads","issues_url":"https://api.github.com/repos/makimo/django-eav2/issues{/number}","pulls_url":"https://api.github.com/repos/makimo/django-eav2/pulls{/number}","milestones_url":"https://api.github.com/repos/makimo/django-eav2/milestones{/number}","notifications_url":"https://api.github.com/repos/makimo/django-eav2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/makimo/django-eav2/labels{/name}","releases_url":"https://api.github.com/repos/makimo/django-eav2/releases{/id}","deployments_url":"https://api.github.com/repos/makimo/django-eav2/deployments","created_at":"2018-03-27T15:19:48Z","updated_at":"2018-06-20T13:51:14Z","pushed_at":"2018-06-21T09:00:28Z","git_url":"git://github.com/makimo/django-eav2.git","ssh_url":"[email protected]:makimo/django-eav2.git","clone_url":"https://github.com/makimo/django-eav2.git","svn_url":"https://github.com/makimo/django-eav2","homepage":"","size":629,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":11,"watchers":3,"default_branch":"master"}},"base":{"label":"makimo:master","ref":"master","sha":"6f3329d2ae97a8423798fa6462b46f2a617b5b49","user":{"login":"makimo","id":2085227,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODUyMjc=","avatar_url":"https://avatars0.githubusercontent.com/u/2085227?v=4","gravatar_id":"","url":"https://api.github.com/users/makimo","html_url":"https://github.com/makimo","followers_url":"https://api.github.com/users/makimo/followers","following_url":"https://api.github.com/users/makimo/following{/other_user}","gists_url":"https://api.github.com/users/makimo/gists{/gist_id}","starred_url":"https://api.github.com/users/makimo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makimo/subscriptions","organizations_url":"https://api.github.com/users/makimo/orgs","repos_url":"https://api.github.com/users/makimo/repos","events_url":"https://api.github.com/users/makimo/events{/privacy}","received_events_url":"https://api.github.com/users/makimo/received_events","type":"Organization","site_admin":false},"repo":{"id":127006653,"node_id":"MDEwOlJlcG9zaXRvcnkxMjcwMDY2NTM=","name":"django-eav2","full_name":"makimo/django-eav2","owner":{"login":"makimo","id":2085227,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODUyMjc=","avatar_url":"https://avatars0.githubusercontent.com/u/2085227?v=4","gravatar_id":"","url":"https://api.github.com/users/makimo","html_url":"https://github.com/makimo","followers_url":"https://api.github.com/users/makimo/followers","following_url":"https://api.github.com/users/makimo/following{/other_user}","gists_url":"https://api.github.com/users/makimo/gists{/gist_id}","starred_url":"https://api.github.com/users/makimo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makimo/subscriptions","organizations_url":"https://api.github.com/users/makimo/orgs","repos_url":"https://api.github.com/users/makimo/repos","events_url":"https://api.github.com/users/makimo/events{/privacy}","received_events_url":"https://api.github.com/users/makimo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/makimo/django-eav2","description":"Django EAV 2 - EAV storage for Django","fork":false,"url":"https://api.github.com/repos/makimo/django-eav2","forks_url":"https://api.github.com/repos/makimo/django-eav2/forks","keys_url":"https://api.github.com/repos/makimo/django-eav2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/makimo/django-eav2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/makimo/django-eav2/teams","hooks_url":"https://api.github.com/repos/makimo/django-eav2/hooks","issue_events_url":"https://api.github.com/repos/makimo/django-eav2/issues/events{/number}","events_url":"https://api.github.com/repos/makimo/django-eav2/events","assignees_url":"https://api.github.com/repos/makimo/django-eav2/assignees{/user}","branches_url":"https://api.github.com/repos/makimo/django-eav2/branches{/branch}","tags_url":"https://api.github.com/repos/makimo/django-eav2/tags","blobs_url":"https://api.github.com/repos/makimo/django-eav2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/makimo/django-eav2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/makimo/django-eav2/git/refs{/sha}","trees_url":"https://api.github.com/repos/makimo/django-eav2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/makimo/django-eav2/statuses/{sha}","languages_url":"https://api.github.com/repos/makimo/django-eav2/languages","stargazers_url":"https://api.github.com/repos/makimo/django-eav2/stargazers","contributors_url":"https://api.github.com/repos/makimo/django-eav2/contributors","subscribers_url":"https://api.github.com/repos/makimo/django-eav2/subscribers","subscription_url":"https://api.github.com/repos/makimo/django-eav2/subscription","commits_url":"https://api.github.com/repos/makimo/django-eav2/commits{/sha}","git_commits_url":"https://api.github.com/repos/makimo/django-eav2/git/commits{/sha}","comments_url":"https://api.github.com/repos/makimo/django-eav2/comments{/number}","issue_comment_url":"https://api.github.com/repos/makimo/django-eav2/issues/comments{/number}","contents_url":"https://api.github.com/repos/makimo/django-eav2/contents/{+path}","compare_url":"https://api.github.com/repos/makimo/django-eav2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/makimo/django-eav2/merges","archive_url":"https://api.github.com/repos/makimo/django-eav2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/makimo/django-eav2/downloads","issues_url":"https://api.github.com/repos/makimo/django-eav2/issues{/number}","pulls_url":"https://api.github.com/repos/makimo/django-eav2/pulls{/number}","milestones_url":"https://api.github.com/repos/makimo/django-eav2/milestones{/number}","notifications_url":"https://api.github.com/repos/makimo/django-eav2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/makimo/django-eav2/labels{/name}","releases_url":"https://api.github.com/repos/makimo/django-eav2/releases{/id}","deployments_url":"https://api.github.com/repos/makimo/django-eav2/deployments","created_at":"2018-03-27T15:19:48Z","updated_at":"2018-06-20T13:51:14Z","pushed_at":"2018-06-21T09:00:28Z","git_url":"git://github.com/makimo/django-eav2.git","ssh_url":"[email protected]:makimo/django-eav2.git","clone_url":"https://github.com/makimo/django-eav2.git","svn_url":"https://github.com/makimo/django-eav2","homepage":"","size":629,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":11,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/makimo/django-eav2/pulls/17"},"html":{"href":"https://github.com/makimo/django-eav2/pull/17"},"issue":{"href":"https://api.github.com/repos/makimo/django-eav2/issues/17"},"comments":{"href":"https://api.github.com/repos/makimo/django-eav2/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/makimo/django-eav2/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/makimo/django-eav2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/makimo/django-eav2/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/makimo/django-eav2/statuses/7e9a60daba7b8c8261f667159c322d4e03c0f0ff"}},"author_association":"COLLABORATOR"}} | {
"id": 127006653,
"name": "makimo/django-eav2",
"url": "https://api.github.com/repos/makimo/django-eav2"
} | {
"id": 9204550,
"login": "IwoHerka",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9204550?",
"url": "https://api.github.com/users/IwoHerka"
} | {
"id": 2085227,
"login": "makimo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2085227?",
"url": "https://api.github.com/orgs/makimo"
} | 2018-06-21T10:08:47 | 7857250429 | {"actor":{"display_login":"IwoHerka"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/comments/174954225","pull_request_review_id":104405264,"id":174954225,"diff_hunk":"@@ -66,8 +76,9 @@ format_unittest: $(GTEST_LIB) format_unittest.o $(SRC_DIR)/format.o\n \t$(CXX) $(LDFLAGS) $^ $(LDLIBS) -o $@\n base64_unittest: $(GTEST_LIB) base64_unittest.o $(SRC_DIR)/base64.o\n \t$(CXX) $(LDFLAGS) $^ $(LDLIBS) -o $@\n-\n+configuration_unittest: $(GTEST_LIB) configuration_unittest.o $(SRC_DIR)/configuration.o $(YAML_CPP_LIBS)\n+\t$(CXX) $(LDFLAGS) $^ $(LDLIBS) -o $@\n time_unittest: $(GTEST_LIB) time_unittest.o $(SRC_DIR)/time.o\n \t$(CXX) $(LDFLAGS) $^ $(LDLIBS) -o $@\n \n-.PHONY: all test clean purge\n+.PHONY: all test clean purge yaml-cpp","path":"test/Makefile","position":48,"original_position":48,"commit_id":"6a9cc6961c4eea5d2acacdbf4902c168d8c34bb5","original_commit_id":"6a9cc6961c4eea5d2acacdbf4902c168d8c34bb5","user":{"login":"igorpeshansky","id":7594381,"avatar_url":"https://avatars1.githubusercontent.com/u/7594381?v=4","gravatar_id":"","url":"https://api.github.com/users/igorpeshansky","html_url":"https://github.com/igorpeshansky","followers_url":"https://api.github.com/users/igorpeshansky/followers","following_url":"https://api.github.com/users/igorpeshansky/following{/other_user}","gists_url":"https://api.github.com/users/igorpeshansky/gists{/gist_id}","starred_url":"https://api.github.com/users/igorpeshansky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igorpeshansky/subscriptions","organizations_url":"https://api.github.com/users/igorpeshansky/orgs","repos_url":"https://api.github.com/users/igorpeshansky/repos","events_url":"https://api.github.com/users/igorpeshansky/events{/privacy}","received_events_url":"https://api.github.com/users/igorpeshansky/received_events","type":"User","site_admin":false},"body":"You've removed the `yaml-cpp` target, right?","created_at":"2018-03-15T22:41:02Z","updated_at":"2018-03-15T22:50:21Z","html_url":"https://github.com/Stackdriver/metadata-agent/pull/80#discussion_r174954225","pull_request_url":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/80","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/comments/174954225"},"html":{"href":"https://github.com/Stackdriver/metadata-agent/pull/80#discussion_r174954225"},"pull_request":{"href":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/80"}}},"pull_request":{"url":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/80","id":175087173,"html_url":"https://github.com/Stackdriver/metadata-agent/pull/80","diff_url":"https://github.com/Stackdriver/metadata-agent/pull/80.diff","patch_url":"https://github.com/Stackdriver/metadata-agent/pull/80.patch","issue_url":"https://api.github.com/repos/Stackdriver/metadata-agent/issues/80","number":80,"state":"open","locked":false,"title":"Support configuration testing","user":{"login":"ACEmilG","id":37227825,"avatar_url":"https://avatars1.githubusercontent.com/u/37227825?v=4","gravatar_id":"","url":"https://api.github.com/users/ACEmilG","html_url":"https://github.com/ACEmilG","followers_url":"https://api.github.com/users/ACEmilG/followers","following_url":"https://api.github.com/users/ACEmilG/following{/other_user}","gists_url":"https://api.github.com/users/ACEmilG/gists{/gist_id}","starred_url":"https://api.github.com/users/ACEmilG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ACEmilG/subscriptions","organizations_url":"https://api.github.com/users/ACEmilG/orgs","repos_url":"https://api.github.com/users/ACEmilG/repos","events_url":"https://api.github.com/users/ACEmilG/events{/privacy}","received_events_url":"https://api.github.com/users/ACEmilG/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-14T21:15:15Z","updated_at":"2018-03-15T22:50:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"604d5df1d22df3ebbafcf246a22d13fb0921f4fb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/80/commits","review_comments_url":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/80/comments","review_comment_url":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Stackdriver/metadata-agent/issues/80/comments","statuses_url":"https://api.github.com/repos/Stackdriver/metadata-agent/statuses/6a9cc6961c4eea5d2acacdbf4902c168d8c34bb5","head":{"label":"Stackdriver:ACEmilG-configuration-unit-tests","ref":"ACEmilG-configuration-unit-tests","sha":"6a9cc6961c4eea5d2acacdbf4902c168d8c34bb5","user":{"login":"Stackdriver","id":2104369,"avatar_url":"https://avatars3.githubusercontent.com/u/2104369?v=4","gravatar_id":"","url":"https://api.github.com/users/Stackdriver","html_url":"https://github.com/Stackdriver","followers_url":"https://api.github.com/users/Stackdriver/followers","following_url":"https://api.github.com/users/Stackdriver/following{/other_user}","gists_url":"https://api.github.com/users/Stackdriver/gists{/gist_id}","starred_url":"https://api.github.com/users/Stackdriver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stackdriver/subscriptions","organizations_url":"https://api.github.com/users/Stackdriver/orgs","repos_url":"https://api.github.com/users/Stackdriver/repos","events_url":"https://api.github.com/users/Stackdriver/events{/privacy}","received_events_url":"https://api.github.com/users/Stackdriver/received_events","type":"Organization","site_admin":false},"repo":{"id":81396310,"name":"metadata-agent","full_name":"Stackdriver/metadata-agent","owner":{"login":"Stackdriver","id":2104369,"avatar_url":"https://avatars3.githubusercontent.com/u/2104369?v=4","gravatar_id":"","url":"https://api.github.com/users/Stackdriver","html_url":"https://github.com/Stackdriver","followers_url":"https://api.github.com/users/Stackdriver/followers","following_url":"https://api.github.com/users/Stackdriver/following{/other_user}","gists_url":"https://api.github.com/users/Stackdriver/gists{/gist_id}","starred_url":"https://api.github.com/users/Stackdriver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stackdriver/subscriptions","organizations_url":"https://api.github.com/users/Stackdriver/orgs","repos_url":"https://api.github.com/users/Stackdriver/repos","events_url":"https://api.github.com/users/Stackdriver/events{/privacy}","received_events_url":"https://api.github.com/users/Stackdriver/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Stackdriver/metadata-agent","description":"Stackdriver metadata agent","fork":false,"url":"https://api.github.com/repos/Stackdriver/metadata-agent","forks_url":"https://api.github.com/repos/Stackdriver/metadata-agent/forks","keys_url":"https://api.github.com/repos/Stackdriver/metadata-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Stackdriver/metadata-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Stackdriver/metadata-agent/teams","hooks_url":"https://api.github.com/repos/Stackdriver/metadata-agent/hooks","issue_events_url":"https://api.github.com/repos/Stackdriver/metadata-agent/issues/events{/number}","events_url":"https://api.github.com/repos/Stackdriver/metadata-agent/events","assignees_url":"https://api.github.com/repos/Stackdriver/metadata-agent/assignees{/user}","branches_url":"https://api.github.com/repos/Stackdriver/metadata-agent/branches{/branch}","tags_url":"https://api.github.com/repos/Stackdriver/metadata-agent/tags","blobs_url":"https://api.github.com/repos/Stackdriver/metadata-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Stackdriver/metadata-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Stackdriver/metadata-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/Stackdriver/metadata-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Stackdriver/metadata-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/Stackdriver/metadata-agent/languages","stargazers_url":"https://api.github.com/repos/Stackdriver/metadata-agent/stargazers","contributors_url":"https://api.github.com/repos/Stackdriver/metadata-agent/contributors","subscribers_url":"https://api.github.com/repos/Stackdriver/metadata-agent/subscribers","subscription_url":"https://api.github.com/repos/Stackdriver/metadata-agent/subscription","commits_url":"https://api.github.com/repos/Stackdriver/metadata-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/Stackdriver/metadata-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/Stackdriver/metadata-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/Stackdriver/metadata-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/Stackdriver/metadata-agent/contents/{+path}","compare_url":"https://api.github.com/repos/Stackdriver/metadata-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Stackdriver/metadata-agent/merges","archive_url":"https://api.github.com/repos/Stackdriver/metadata-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Stackdriver/metadata-agent/downloads","issues_url":"https://api.github.com/repos/Stackdriver/metadata-agent/issues{/number}","pulls_url":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/Stackdriver/metadata-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/Stackdriver/metadata-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Stackdriver/metadata-agent/labels{/name}","releases_url":"https://api.github.com/repos/Stackdriver/metadata-agent/releases{/id}","deployments_url":"https://api.github.com/repos/Stackdriver/metadata-agent/deployments","created_at":"2017-02-09T01:48:50Z","updated_at":"2018-03-15T18:25:31Z","pushed_at":"2018-03-15T22:33:11Z","git_url":"git://github.com/Stackdriver/metadata-agent.git","ssh_url":"[email protected]:Stackdriver/metadata-agent.git","clone_url":"https://github.com/Stackdriver/metadata-agent.git","svn_url":"https://github.com/Stackdriver/metadata-agent","homepage":"","size":355,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2,"open_issues":6,"watchers":4,"default_branch":"master"}},"base":{"label":"Stackdriver:master","ref":"master","sha":"633c6e93c67ae258a48836222cbef4995b9aeafa","user":{"login":"Stackdriver","id":2104369,"avatar_url":"https://avatars3.githubusercontent.com/u/2104369?v=4","gravatar_id":"","url":"https://api.github.com/users/Stackdriver","html_url":"https://github.com/Stackdriver","followers_url":"https://api.github.com/users/Stackdriver/followers","following_url":"https://api.github.com/users/Stackdriver/following{/other_user}","gists_url":"https://api.github.com/users/Stackdriver/gists{/gist_id}","starred_url":"https://api.github.com/users/Stackdriver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stackdriver/subscriptions","organizations_url":"https://api.github.com/users/Stackdriver/orgs","repos_url":"https://api.github.com/users/Stackdriver/repos","events_url":"https://api.github.com/users/Stackdriver/events{/privacy}","received_events_url":"https://api.github.com/users/Stackdriver/received_events","type":"Organization","site_admin":false},"repo":{"id":81396310,"name":"metadata-agent","full_name":"Stackdriver/metadata-agent","owner":{"login":"Stackdriver","id":2104369,"avatar_url":"https://avatars3.githubusercontent.com/u/2104369?v=4","gravatar_id":"","url":"https://api.github.com/users/Stackdriver","html_url":"https://github.com/Stackdriver","followers_url":"https://api.github.com/users/Stackdriver/followers","following_url":"https://api.github.com/users/Stackdriver/following{/other_user}","gists_url":"https://api.github.com/users/Stackdriver/gists{/gist_id}","starred_url":"https://api.github.com/users/Stackdriver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stackdriver/subscriptions","organizations_url":"https://api.github.com/users/Stackdriver/orgs","repos_url":"https://api.github.com/users/Stackdriver/repos","events_url":"https://api.github.com/users/Stackdriver/events{/privacy}","received_events_url":"https://api.github.com/users/Stackdriver/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Stackdriver/metadata-agent","description":"Stackdriver metadata agent","fork":false,"url":"https://api.github.com/repos/Stackdriver/metadata-agent","forks_url":"https://api.github.com/repos/Stackdriver/metadata-agent/forks","keys_url":"https://api.github.com/repos/Stackdriver/metadata-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Stackdriver/metadata-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Stackdriver/metadata-agent/teams","hooks_url":"https://api.github.com/repos/Stackdriver/metadata-agent/hooks","issue_events_url":"https://api.github.com/repos/Stackdriver/metadata-agent/issues/events{/number}","events_url":"https://api.github.com/repos/Stackdriver/metadata-agent/events","assignees_url":"https://api.github.com/repos/Stackdriver/metadata-agent/assignees{/user}","branches_url":"https://api.github.com/repos/Stackdriver/metadata-agent/branches{/branch}","tags_url":"https://api.github.com/repos/Stackdriver/metadata-agent/tags","blobs_url":"https://api.github.com/repos/Stackdriver/metadata-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Stackdriver/metadata-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Stackdriver/metadata-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/Stackdriver/metadata-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Stackdriver/metadata-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/Stackdriver/metadata-agent/languages","stargazers_url":"https://api.github.com/repos/Stackdriver/metadata-agent/stargazers","contributors_url":"https://api.github.com/repos/Stackdriver/metadata-agent/contributors","subscribers_url":"https://api.github.com/repos/Stackdriver/metadata-agent/subscribers","subscription_url":"https://api.github.com/repos/Stackdriver/metadata-agent/subscription","commits_url":"https://api.github.com/repos/Stackdriver/metadata-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/Stackdriver/metadata-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/Stackdriver/metadata-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/Stackdriver/metadata-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/Stackdriver/metadata-agent/contents/{+path}","compare_url":"https://api.github.com/repos/Stackdriver/metadata-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Stackdriver/metadata-agent/merges","archive_url":"https://api.github.com/repos/Stackdriver/metadata-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Stackdriver/metadata-agent/downloads","issues_url":"https://api.github.com/repos/Stackdriver/metadata-agent/issues{/number}","pulls_url":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/Stackdriver/metadata-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/Stackdriver/metadata-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Stackdriver/metadata-agent/labels{/name}","releases_url":"https://api.github.com/repos/Stackdriver/metadata-agent/releases{/id}","deployments_url":"https://api.github.com/repos/Stackdriver/metadata-agent/deployments","created_at":"2017-02-09T01:48:50Z","updated_at":"2018-03-15T18:25:31Z","pushed_at":"2018-03-15T22:33:11Z","git_url":"git://github.com/Stackdriver/metadata-agent.git","ssh_url":"[email protected]:Stackdriver/metadata-agent.git","clone_url":"https://github.com/Stackdriver/metadata-agent.git","svn_url":"https://github.com/Stackdriver/metadata-agent","homepage":"","size":355,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2,"open_issues":6,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/80"},"html":{"href":"https://github.com/Stackdriver/metadata-agent/pull/80"},"issue":{"href":"https://api.github.com/repos/Stackdriver/metadata-agent/issues/80"},"comments":{"href":"https://api.github.com/repos/Stackdriver/metadata-agent/issues/80/comments"},"review_comments":{"href":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/80/comments"},"review_comment":{"href":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/80/commits"},"statuses":{"href":"https://api.github.com/repos/Stackdriver/metadata-agent/statuses/6a9cc6961c4eea5d2acacdbf4902c168d8c34bb5"}},"author_association":"COLLABORATOR"}} | {
"id": 81396310,
"name": "Stackdriver/metadata-agent",
"url": "https://api.github.com/repos/Stackdriver/metadata-agent"
} | {
"id": 7594381,
"login": "igorpeshansky",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7594381?",
"url": "https://api.github.com/users/igorpeshansky"
} | {
"id": 2104369,
"login": "Stackdriver",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2104369?",
"url": "https://api.github.com/orgs/Stackdriver"
} | 2018-03-15T22:41:02 | 7387784751 | {"actor":{"display_login":"igorpeshansky"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/comments/189434831","pull_request_review_id":121619464,"id":189434831,"diff_hunk":"@@ -331,7 +331,7 @@ namespace BitTorrent\n void setName(const QString &name);\n void setSequentialDownload(bool b);\n void toggleSequentialDownload();\n- void setFirstLastPiecePriority(bool b);\n+ void setFirstLastPiecePriority(const bool enabled);","path":"src/base/bittorrent/torrenthandle.h","position":5,"original_position":5,"commit_id":"9feeee9706c30bcb81956927490e21f5dbbd7ebf","original_commit_id":"4a732051e447438f47909239b24a9e40d35872cd","user":{"login":"Chocobo1","id":9395168,"avatar_url":"https://avatars2.githubusercontent.com/u/9395168?v=4","gravatar_id":"","url":"https://api.github.com/users/Chocobo1","html_url":"https://github.com/Chocobo1","followers_url":"https://api.github.com/users/Chocobo1/followers","following_url":"https://api.github.com/users/Chocobo1/following{/other_user}","gists_url":"https://api.github.com/users/Chocobo1/gists{/gist_id}","starred_url":"https://api.github.com/users/Chocobo1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chocobo1/subscriptions","organizations_url":"https://api.github.com/users/Chocobo1/orgs","repos_url":"https://api.github.com/users/Chocobo1/repos","events_url":"https://api.github.com/users/Chocobo1/events{/privacy}","received_events_url":"https://api.github.com/users/Chocobo1/received_events","type":"User","site_admin":false},"body":"Then in the cpp file it will have `const` while the header won't, is it ok for you?","created_at":"2018-05-19T13:44:30Z","updated_at":"2018-05-19T13:44:30Z","html_url":"https://github.com/qbittorrent/qBittorrent/pull/8954#discussion_r189434831","pull_request_url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/8954","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/comments/189434831"},"html":{"href":"https://github.com/qbittorrent/qBittorrent/pull/8954#discussion_r189434831"},"pull_request":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/8954"}},"in_reply_to_id":189428397},"pull_request":{"url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/8954","id":189174518,"html_url":"https://github.com/qbittorrent/qBittorrent/pull/8954","diff_url":"https://github.com/qbittorrent/qBittorrent/pull/8954.diff","patch_url":"https://github.com/qbittorrent/qBittorrent/pull/8954.patch","issue_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/8954","number":8954,"state":"open","locked":false,"title":"Relax behavior of \"Download first and last piece first\"","user":{"login":"Chocobo1","id":9395168,"avatar_url":"https://avatars2.githubusercontent.com/u/9395168?v=4","gravatar_id":"","url":"https://api.github.com/users/Chocobo1","html_url":"https://github.com/Chocobo1","followers_url":"https://api.github.com/users/Chocobo1/followers","following_url":"https://api.github.com/users/Chocobo1/following{/other_user}","gists_url":"https://api.github.com/users/Chocobo1/gists{/gist_id}","starred_url":"https://api.github.com/users/Chocobo1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chocobo1/subscriptions","organizations_url":"https://api.github.com/users/Chocobo1/orgs","repos_url":"https://api.github.com/users/Chocobo1/repos","events_url":"https://api.github.com/users/Chocobo1/events{/privacy}","received_events_url":"https://api.github.com/users/Chocobo1/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-19T06:51:55Z","updated_at":"2018-05-19T13:44:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2cfc1a3a92fec29f8b8d1b361c07b11c0373f699","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/8954/commits","review_comments_url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/8954/comments","review_comment_url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/8954/comments","statuses_url":"https://api.github.com/repos/qbittorrent/qBittorrent/statuses/9feeee9706c30bcb81956927490e21f5dbbd7ebf","head":{"label":"Chocobo1:firstlast","ref":"firstlast","sha":"9feeee9706c30bcb81956927490e21f5dbbd7ebf","user":{"login":"Chocobo1","id":9395168,"avatar_url":"https://avatars2.githubusercontent.com/u/9395168?v=4","gravatar_id":"","url":"https://api.github.com/users/Chocobo1","html_url":"https://github.com/Chocobo1","followers_url":"https://api.github.com/users/Chocobo1/followers","following_url":"https://api.github.com/users/Chocobo1/following{/other_user}","gists_url":"https://api.github.com/users/Chocobo1/gists{/gist_id}","starred_url":"https://api.github.com/users/Chocobo1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chocobo1/subscriptions","organizations_url":"https://api.github.com/users/Chocobo1/orgs","repos_url":"https://api.github.com/users/Chocobo1/repos","events_url":"https://api.github.com/users/Chocobo1/events{/privacy}","received_events_url":"https://api.github.com/users/Chocobo1/received_events","type":"User","site_admin":false},"repo":{"id":30459428,"name":"qBittorrent","full_name":"Chocobo1/qBittorrent","owner":{"login":"Chocobo1","id":9395168,"avatar_url":"https://avatars2.githubusercontent.com/u/9395168?v=4","gravatar_id":"","url":"https://api.github.com/users/Chocobo1","html_url":"https://github.com/Chocobo1","followers_url":"https://api.github.com/users/Chocobo1/followers","following_url":"https://api.github.com/users/Chocobo1/following{/other_user}","gists_url":"https://api.github.com/users/Chocobo1/gists{/gist_id}","starred_url":"https://api.github.com/users/Chocobo1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chocobo1/subscriptions","organizations_url":"https://api.github.com/users/Chocobo1/orgs","repos_url":"https://api.github.com/users/Chocobo1/repos","events_url":"https://api.github.com/users/Chocobo1/events{/privacy}","received_events_url":"https://api.github.com/users/Chocobo1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Chocobo1/qBittorrent","description":"qBittorrent BitTorrent client","fork":true,"url":"https://api.github.com/repos/Chocobo1/qBittorrent","forks_url":"https://api.github.com/repos/Chocobo1/qBittorrent/forks","keys_url":"https://api.github.com/repos/Chocobo1/qBittorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Chocobo1/qBittorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Chocobo1/qBittorrent/teams","hooks_url":"https://api.github.com/repos/Chocobo1/qBittorrent/hooks","issue_events_url":"https://api.github.com/repos/Chocobo1/qBittorrent/issues/events{/number}","events_url":"https://api.github.com/repos/Chocobo1/qBittorrent/events","assignees_url":"https://api.github.com/repos/Chocobo1/qBittorrent/assignees{/user}","branches_url":"https://api.github.com/repos/Chocobo1/qBittorrent/branches{/branch}","tags_url":"https://api.github.com/repos/Chocobo1/qBittorrent/tags","blobs_url":"https://api.github.com/repos/Chocobo1/qBittorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Chocobo1/qBittorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Chocobo1/qBittorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/Chocobo1/qBittorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Chocobo1/qBittorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/Chocobo1/qBittorrent/languages","stargazers_url":"https://api.github.com/repos/Chocobo1/qBittorrent/stargazers","contributors_url":"https://api.github.com/repos/Chocobo1/qBittorrent/contributors","subscribers_url":"https://api.github.com/repos/Chocobo1/qBittorrent/subscribers","subscription_url":"https://api.github.com/repos/Chocobo1/qBittorrent/subscription","commits_url":"https://api.github.com/repos/Chocobo1/qBittorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/Chocobo1/qBittorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/Chocobo1/qBittorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/Chocobo1/qBittorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/Chocobo1/qBittorrent/contents/{+path}","compare_url":"https://api.github.com/repos/Chocobo1/qBittorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Chocobo1/qBittorrent/merges","archive_url":"https://api.github.com/repos/Chocobo1/qBittorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Chocobo1/qBittorrent/downloads","issues_url":"https://api.github.com/repos/Chocobo1/qBittorrent/issues{/number}","pulls_url":"https://api.github.com/repos/Chocobo1/qBittorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/Chocobo1/qBittorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/Chocobo1/qBittorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Chocobo1/qBittorrent/labels{/name}","releases_url":"https://api.github.com/repos/Chocobo1/qBittorrent/releases{/id}","deployments_url":"https://api.github.com/repos/Chocobo1/qBittorrent/deployments","created_at":"2015-02-07T15:14:20Z","updated_at":"2018-05-19T06:59:16Z","pushed_at":"2018-05-19T13:39:19Z","git_url":"git://github.com/Chocobo1/qBittorrent.git","ssh_url":"[email protected]:Chocobo1/qBittorrent.git","clone_url":"https://github.com/Chocobo1/qBittorrent.git","svn_url":"https://github.com/Chocobo1/qBittorrent","homepage":"http://www.qbittorrent.org","size":158573,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"qbittorrent:master","ref":"master","sha":"e157ca24300656f19cd0f33f2e4782c6090f4f8c","user":{"login":"qbittorrent","id":2131270,"avatar_url":"https://avatars2.githubusercontent.com/u/2131270?v=4","gravatar_id":"","url":"https://api.github.com/users/qbittorrent","html_url":"https://github.com/qbittorrent","followers_url":"https://api.github.com/users/qbittorrent/followers","following_url":"https://api.github.com/users/qbittorrent/following{/other_user}","gists_url":"https://api.github.com/users/qbittorrent/gists{/gist_id}","starred_url":"https://api.github.com/users/qbittorrent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qbittorrent/subscriptions","organizations_url":"https://api.github.com/users/qbittorrent/orgs","repos_url":"https://api.github.com/users/qbittorrent/repos","events_url":"https://api.github.com/users/qbittorrent/events{/privacy}","received_events_url":"https://api.github.com/users/qbittorrent/received_events","type":"Organization","site_admin":false},"repo":{"id":3351871,"name":"qBittorrent","full_name":"qbittorrent/qBittorrent","owner":{"login":"qbittorrent","id":2131270,"avatar_url":"https://avatars2.githubusercontent.com/u/2131270?v=4","gravatar_id":"","url":"https://api.github.com/users/qbittorrent","html_url":"https://github.com/qbittorrent","followers_url":"https://api.github.com/users/qbittorrent/followers","following_url":"https://api.github.com/users/qbittorrent/following{/other_user}","gists_url":"https://api.github.com/users/qbittorrent/gists{/gist_id}","starred_url":"https://api.github.com/users/qbittorrent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qbittorrent/subscriptions","organizations_url":"https://api.github.com/users/qbittorrent/orgs","repos_url":"https://api.github.com/users/qbittorrent/repos","events_url":"https://api.github.com/users/qbittorrent/events{/privacy}","received_events_url":"https://api.github.com/users/qbittorrent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qbittorrent/qBittorrent","description":"qBittorrent BitTorrent client","fork":false,"url":"https://api.github.com/repos/qbittorrent/qBittorrent","forks_url":"https://api.github.com/repos/qbittorrent/qBittorrent/forks","keys_url":"https://api.github.com/repos/qbittorrent/qBittorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qbittorrent/qBittorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qbittorrent/qBittorrent/teams","hooks_url":"https://api.github.com/repos/qbittorrent/qBittorrent/hooks","issue_events_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/events{/number}","events_url":"https://api.github.com/repos/qbittorrent/qBittorrent/events","assignees_url":"https://api.github.com/repos/qbittorrent/qBittorrent/assignees{/user}","branches_url":"https://api.github.com/repos/qbittorrent/qBittorrent/branches{/branch}","tags_url":"https://api.github.com/repos/qbittorrent/qBittorrent/tags","blobs_url":"https://api.github.com/repos/qbittorrent/qBittorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qbittorrent/qBittorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qbittorrent/qBittorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/qbittorrent/qBittorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qbittorrent/qBittorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/qbittorrent/qBittorrent/languages","stargazers_url":"https://api.github.com/repos/qbittorrent/qBittorrent/stargazers","contributors_url":"https://api.github.com/repos/qbittorrent/qBittorrent/contributors","subscribers_url":"https://api.github.com/repos/qbittorrent/qBittorrent/subscribers","subscription_url":"https://api.github.com/repos/qbittorrent/qBittorrent/subscription","commits_url":"https://api.github.com/repos/qbittorrent/qBittorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/qbittorrent/qBittorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/qbittorrent/qBittorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/qbittorrent/qBittorrent/contents/{+path}","compare_url":"https://api.github.com/repos/qbittorrent/qBittorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qbittorrent/qBittorrent/merges","archive_url":"https://api.github.com/repos/qbittorrent/qBittorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qbittorrent/qBittorrent/downloads","issues_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues{/number}","pulls_url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/qbittorrent/qBittorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/qbittorrent/qBittorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qbittorrent/qBittorrent/labels{/name}","releases_url":"https://api.github.com/repos/qbittorrent/qBittorrent/releases{/id}","deployments_url":"https://api.github.com/repos/qbittorrent/qBittorrent/deployments","created_at":"2012-02-04T09:37:46Z","updated_at":"2018-05-19T13:10:42Z","pushed_at":"2018-05-19T13:39:21Z","git_url":"git://github.com/qbittorrent/qBittorrent.git","ssh_url":"[email protected]:qbittorrent/qBittorrent.git","clone_url":"https://github.com/qbittorrent/qBittorrent.git","svn_url":"https://github.com/qbittorrent/qBittorrent","homepage":"https://www.qbittorrent.org","size":163267,"stargazers_count":4351,"watchers_count":4351,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":823,"mirror_url":null,"archived":false,"open_issues_count":3057,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":823,"open_issues":3057,"watchers":4351,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/8954"},"html":{"href":"https://github.com/qbittorrent/qBittorrent/pull/8954"},"issue":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/8954"},"comments":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/8954/comments"},"review_comments":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/8954/comments"},"review_comment":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/8954/commits"},"statuses":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/statuses/9feeee9706c30bcb81956927490e21f5dbbd7ebf"}},"author_association":"MEMBER"}} | {
"id": 3351871,
"name": "qbittorrent/qBittorrent",
"url": "https://api.github.com/repos/qbittorrent/qBittorrent"
} | {
"id": 9395168,
"login": "Chocobo1",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9395168?",
"url": "https://api.github.com/users/Chocobo1"
} | {
"id": 2131270,
"login": "qbittorrent",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2131270?",
"url": "https://api.github.com/orgs/qbittorrent"
} | 2018-05-19T13:44:30 | 7699526849 | {"actor":{"display_login":"Chocobo1"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/pulls/comments/225059600","pull_request_review_id":164573541,"id":225059600,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTA1OTYwMA==","diff_hunk":"@@ -97,7 +97,7 @@ class HoverBar extends Component {\n 'element-editor__add-block-hover-bar',\n {\n 'element-editor__add-block-hover-bar--delay': !calledInstantaneously,\n- 'element-editor__add-block-hover-bar--inst': calledInstantaneously,\n+ 'element-editor__add-block-hover-bar--inst': calledInstantaneously","path":"client/src/components/ElementEditor/HoverBar.js","position":36,"original_position":36,"commit_id":"8627186b84ee9231aa015fbb3c37ba853443ad4a","original_commit_id":"8627186b84ee9231aa015fbb3c37ba853443ad4a","user":{"login":"ScopeyNZ","id":3260989,"node_id":"MDQ6VXNlcjMyNjA5ODk=","avatar_url":"https://avatars2.githubusercontent.com/u/3260989?v=4","gravatar_id":"","url":"https://api.github.com/users/ScopeyNZ","html_url":"https://github.com/ScopeyNZ","followers_url":"https://api.github.com/users/ScopeyNZ/followers","following_url":"https://api.github.com/users/ScopeyNZ/following{/other_user}","gists_url":"https://api.github.com/users/ScopeyNZ/gists{/gist_id}","starred_url":"https://api.github.com/users/ScopeyNZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScopeyNZ/subscriptions","organizations_url":"https://api.github.com/users/ScopeyNZ/orgs","repos_url":"https://api.github.com/users/ScopeyNZ/repos","events_url":"https://api.github.com/users/ScopeyNZ/events{/privacy}","received_events_url":"https://api.github.com/users/ScopeyNZ/received_events","type":"User","site_admin":false},"body":"This change isn't required - it's arguably nicer to leave trailing commas if they're supported - smaller diffs means less chances to conflict!","created_at":"2018-10-15T07:20:32Z","updated_at":"2018-10-15T07:35:22Z","html_url":"https://github.com/dnadesign/silverstripe-elemental/pull/443#discussion_r225059600","pull_request_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/pulls/443","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dnadesign/silverstripe-elemental/pulls/comments/225059600"},"html":{"href":"https://github.com/dnadesign/silverstripe-elemental/pull/443#discussion_r225059600"},"pull_request":{"href":"https://api.github.com/repos/dnadesign/silverstripe-elemental/pulls/443"}}},"pull_request":{"url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/pulls/443","id":222763529,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNzYzNTI5","html_url":"https://github.com/dnadesign/silverstripe-elemental/pull/443","diff_url":"https://github.com/dnadesign/silverstripe-elemental/pull/443.diff","patch_url":"https://github.com/dnadesign/silverstripe-elemental/pull/443.patch","issue_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/issues/443","number":443,"state":"open","locked":false,"title":"Pulls/4.0/transmutation","user":{"login":"NightJar","id":778003,"node_id":"MDQ6VXNlcjc3ODAwMw==","avatar_url":"https://avatars2.githubusercontent.com/u/778003?v=4","gravatar_id":"","url":"https://api.github.com/users/NightJar","html_url":"https://github.com/NightJar","followers_url":"https://api.github.com/users/NightJar/followers","following_url":"https://api.github.com/users/NightJar/following{/other_user}","gists_url":"https://api.github.com/users/NightJar/gists{/gist_id}","starred_url":"https://api.github.com/users/NightJar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NightJar/subscriptions","organizations_url":"https://api.github.com/users/NightJar/orgs","repos_url":"https://api.github.com/users/NightJar/repos","events_url":"https://api.github.com/users/NightJar/events{/privacy}","received_events_url":"https://api.github.com/users/NightJar/received_events","type":"User","site_admin":false},"body":"Resolves #340 \r\nResolves #294 \r\nAllows a user to add an element without having to browse to a new form in order to fill in default information. This allows speedier content entry and reinforces inline editing as the standard way to edit elements.","created_at":"2018-10-15T02:18:30Z","updated_at":"2018-10-15T07:35:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed3ad8425afeb7d74ed1bde253542a462182c0f0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"robbieaverill","id":5170590,"node_id":"MDQ6VXNlcjUxNzA1OTA=","avatar_url":"https://avatars1.githubusercontent.com/u/5170590?v=4","gravatar_id":"","url":"https://api.github.com/users/robbieaverill","html_url":"https://github.com/robbieaverill","followers_url":"https://api.github.com/users/robbieaverill/followers","following_url":"https://api.github.com/users/robbieaverill/following{/other_user}","gists_url":"https://api.github.com/users/robbieaverill/gists{/gist_id}","starred_url":"https://api.github.com/users/robbieaverill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robbieaverill/subscriptions","organizations_url":"https://api.github.com/users/robbieaverill/orgs","repos_url":"https://api.github.com/users/robbieaverill/repos","events_url":"https://api.github.com/users/robbieaverill/events{/privacy}","received_events_url":"https://api.github.com/users/robbieaverill/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/pulls/443/commits","review_comments_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/pulls/443/comments","review_comment_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/issues/443/comments","statuses_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/statuses/8627186b84ee9231aa015fbb3c37ba853443ad4a","head":{"label":"creative-commoners:pulls/4.0/transmutation","ref":"pulls/4.0/transmutation","sha":"8627186b84ee9231aa015fbb3c37ba853443ad4a","user":{"login":"creative-commoners","id":28884460,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODg0NDYw","avatar_url":"https://avatars2.githubusercontent.com/u/28884460?v=4","gravatar_id":"","url":"https://api.github.com/users/creative-commoners","html_url":"https://github.com/creative-commoners","followers_url":"https://api.github.com/users/creative-commoners/followers","following_url":"https://api.github.com/users/creative-commoners/following{/other_user}","gists_url":"https://api.github.com/users/creative-commoners/gists{/gist_id}","starred_url":"https://api.github.com/users/creative-commoners/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/creative-commoners/subscriptions","organizations_url":"https://api.github.com/users/creative-commoners/orgs","repos_url":"https://api.github.com/users/creative-commoners/repos","events_url":"https://api.github.com/users/creative-commoners/events{/privacy}","received_events_url":"https://api.github.com/users/creative-commoners/received_events","type":"Organization","site_admin":false},"repo":{"id":104701100,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ3MDExMDA=","name":"silverstripe-elemental","full_name":"creative-commoners/silverstripe-elemental","private":false,"owner":{"login":"creative-commoners","id":28884460,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODg0NDYw","avatar_url":"https://avatars2.githubusercontent.com/u/28884460?v=4","gravatar_id":"","url":"https://api.github.com/users/creative-commoners","html_url":"https://github.com/creative-commoners","followers_url":"https://api.github.com/users/creative-commoners/followers","following_url":"https://api.github.com/users/creative-commoners/following{/other_user}","gists_url":"https://api.github.com/users/creative-commoners/gists{/gist_id}","starred_url":"https://api.github.com/users/creative-commoners/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/creative-commoners/subscriptions","organizations_url":"https://api.github.com/users/creative-commoners/orgs","repos_url":"https://api.github.com/users/creative-commoners/repos","events_url":"https://api.github.com/users/creative-commoners/events{/privacy}","received_events_url":"https://api.github.com/users/creative-commoners/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/creative-commoners/silverstripe-elemental","description":"Compose your SilverStripe content of Elements / Widgets","fork":true,"url":"https://api.github.com/repos/creative-commoners/silverstripe-elemental","forks_url":"https://api.github.com/repos/creative-commoners/silverstripe-elemental/forks","keys_url":"https://api.github.com/repos/creative-commoners/silverstripe-elemental/keys{/key_id}","collaborators_url":"https://api.github.com/repos/creative-commoners/silverstripe-elemental/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/creative-commoners/silverstripe-elemental/teams","hooks_url":"https://api.github.com/repos/creative-commoners/silverstripe-elemental/hooks","issue_events_url":"https://api.github.com/repos/creative-commoners/silverstripe-elemental/issues/events{/number}","events_url":"https://api.github.com/repos/creative-commoners/silverstripe-elemental/events","assignees_url":"https://api.github.com/repos/creative-commoners/silverstripe-elemental/assignees{/user}","branches_url":"https://api.github.com/repos/creative-commoners/silverstripe-elemental/branches{/branch}","tags_url":"https://api.github.com/repos/creative-commoners/silverstripe-elemental/tags","blobs_url":"https://api.github.com/repos/creative-commoners/silverstripe-elemental/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/creative-commoners/silverstripe-elemental/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/creative-commoners/silverstripe-elemental/git/refs{/sha}","trees_url":"https://api.github.com/repos/creative-commoners/silverstripe-elemental/git/trees{/sha}","statuses_url":"https://api.github.com/repos/creative-commoners/silverstripe-elemental/statuses/{sha}","languages_url":"https://api.github.com/repos/creative-commoners/silverstripe-elemental/languages","stargazers_url":"https://api.github.com/repos/creative-commoners/silverstripe-elemental/stargazers","contributors_url":"https://api.github.com/repos/creative-commoners/silverstripe-elemental/contributors","subscribers_url":"https://api.github.com/repos/creative-commoners/silverstripe-elemental/subscribers","subscription_url":"https://api.github.com/repos/creative-commoners/silverstripe-elemental/subscription","commits_url":"https://api.github.com/repos/creative-commoners/silverstripe-elemental/commits{/sha}","git_commits_url":"https://api.github.com/repos/creative-commoners/silverstripe-elemental/git/commits{/sha}","comments_url":"https://api.github.com/repos/creative-commoners/silverstripe-elemental/comments{/number}","issue_comment_url":"https://api.github.com/repos/creative-commoners/silverstripe-elemental/issues/comments{/number}","contents_url":"https://api.github.com/repos/creative-commoners/silverstripe-elemental/contents/{+path}","compare_url":"https://api.github.com/repos/creative-commoners/silverstripe-elemental/compare/{base}...{head}","merges_url":"https://api.github.com/repos/creative-commoners/silverstripe-elemental/merges","archive_url":"https://api.github.com/repos/creative-commoners/silverstripe-elemental/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/creative-commoners/silverstripe-elemental/downloads","issues_url":"https://api.github.com/repos/creative-commoners/silverstripe-elemental/issues{/number}","pulls_url":"https://api.github.com/repos/creative-commoners/silverstripe-elemental/pulls{/number}","milestones_url":"https://api.github.com/repos/creative-commoners/silverstripe-elemental/milestones{/number}","notifications_url":"https://api.github.com/repos/creative-commoners/silverstripe-elemental/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/creative-commoners/silverstripe-elemental/labels{/name}","releases_url":"https://api.github.com/repos/creative-commoners/silverstripe-elemental/releases{/id}","deployments_url":"https://api.github.com/repos/creative-commoners/silverstripe-elemental/deployments","created_at":"2017-09-25T03:51:26Z","updated_at":"2018-08-20T13:37:15Z","pushed_at":"2018-10-15T05:23:54Z","git_url":"git://github.com/creative-commoners/silverstripe-elemental.git","ssh_url":"[email protected]:creative-commoners/silverstripe-elemental.git","clone_url":"https://github.com/creative-commoners/silverstripe-elemental.git","svn_url":"https://github.com/creative-commoners/silverstripe-elemental","homepage":"http://dna.co.nz","size":2650,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dnadesign:master","ref":"master","sha":"88f69afa78706a4662b67c4909f2934d17d9bb9b","user":{"login":"dnadesign","id":2148312,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNDgzMTI=","avatar_url":"https://avatars1.githubusercontent.com/u/2148312?v=4","gravatar_id":"","url":"https://api.github.com/users/dnadesign","html_url":"https://github.com/dnadesign","followers_url":"https://api.github.com/users/dnadesign/followers","following_url":"https://api.github.com/users/dnadesign/following{/other_user}","gists_url":"https://api.github.com/users/dnadesign/gists{/gist_id}","starred_url":"https://api.github.com/users/dnadesign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnadesign/subscriptions","organizations_url":"https://api.github.com/users/dnadesign/orgs","repos_url":"https://api.github.com/users/dnadesign/repos","events_url":"https://api.github.com/users/dnadesign/events{/privacy}","received_events_url":"https://api.github.com/users/dnadesign/received_events","type":"Organization","site_admin":false},"repo":{"id":23339883,"node_id":"MDEwOlJlcG9zaXRvcnkyMzMzOTg4Mw==","name":"silverstripe-elemental","full_name":"dnadesign/silverstripe-elemental","private":false,"owner":{"login":"dnadesign","id":2148312,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNDgzMTI=","avatar_url":"https://avatars1.githubusercontent.com/u/2148312?v=4","gravatar_id":"","url":"https://api.github.com/users/dnadesign","html_url":"https://github.com/dnadesign","followers_url":"https://api.github.com/users/dnadesign/followers","following_url":"https://api.github.com/users/dnadesign/following{/other_user}","gists_url":"https://api.github.com/users/dnadesign/gists{/gist_id}","starred_url":"https://api.github.com/users/dnadesign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnadesign/subscriptions","organizations_url":"https://api.github.com/users/dnadesign/orgs","repos_url":"https://api.github.com/users/dnadesign/repos","events_url":"https://api.github.com/users/dnadesign/events{/privacy}","received_events_url":"https://api.github.com/users/dnadesign/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dnadesign/silverstripe-elemental","description":"Create pages in SilverStripe using content blocks","fork":false,"url":"https://api.github.com/repos/dnadesign/silverstripe-elemental","forks_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/forks","keys_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/teams","hooks_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/hooks","issue_events_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/issues/events{/number}","events_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/events","assignees_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/assignees{/user}","branches_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/branches{/branch}","tags_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/tags","blobs_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/git/refs{/sha}","trees_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/statuses/{sha}","languages_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/languages","stargazers_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/stargazers","contributors_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/contributors","subscribers_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/subscribers","subscription_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/subscription","commits_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/commits{/sha}","git_commits_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/git/commits{/sha}","comments_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/comments{/number}","issue_comment_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/issues/comments{/number}","contents_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/contents/{+path}","compare_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/merges","archive_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/downloads","issues_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/issues{/number}","pulls_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/pulls{/number}","milestones_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/milestones{/number}","notifications_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/labels{/name}","releases_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/releases{/id}","deployments_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/deployments","created_at":"2014-08-26T05:27:34Z","updated_at":"2018-10-09T21:05:34Z","pushed_at":"2018-10-15T05:23:55Z","git_url":"git://github.com/dnadesign/silverstripe-elemental.git","ssh_url":"[email protected]:dnadesign/silverstripe-elemental.git","clone_url":"https://github.com/dnadesign/silverstripe-elemental.git","svn_url":"https://github.com/dnadesign/silverstripe-elemental","homepage":"http://dna.co.nz","size":2342,"stargazers_count":62,"watchers_count":62,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"archived":false,"open_issues_count":60,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":55,"open_issues":60,"watchers":62,"default_branch":"3"}},"_links":{"self":{"href":"https://api.github.com/repos/dnadesign/silverstripe-elemental/pulls/443"},"html":{"href":"https://github.com/dnadesign/silverstripe-elemental/pull/443"},"issue":{"href":"https://api.github.com/repos/dnadesign/silverstripe-elemental/issues/443"},"comments":{"href":"https://api.github.com/repos/dnadesign/silverstripe-elemental/issues/443/comments"},"review_comments":{"href":"https://api.github.com/repos/dnadesign/silverstripe-elemental/pulls/443/comments"},"review_comment":{"href":"https://api.github.com/repos/dnadesign/silverstripe-elemental/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dnadesign/silverstripe-elemental/pulls/443/commits"},"statuses":{"href":"https://api.github.com/repos/dnadesign/silverstripe-elemental/statuses/8627186b84ee9231aa015fbb3c37ba853443ad4a"}},"author_association":"CONTRIBUTOR"}} | {
"id": 23339883,
"name": "dnadesign/silverstripe-elemental",
"url": "https://api.github.com/repos/dnadesign/silverstripe-elemental"
} | {
"id": 3260989,
"login": "ScopeyNZ",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3260989?",
"url": "https://api.github.com/users/ScopeyNZ"
} | {
"id": 2148312,
"login": "dnadesign",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2148312?",
"url": "https://api.github.com/orgs/dnadesign"
} | 2018-10-15T07:20:32 | 8419636264 | {"actor":{"display_login":"ScopeyNZ"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/pulls/comments/244741603","pull_request_review_id":188684382,"id":244741603,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDc0MTYwMw==","diff_hunk":"@@ -11,11 +12,9 @@ def update\n \n if @form.save\n if legal_aid_application.own_home == 'mortgage'","path":"app/controllers/providers/property_values_controller.rb","position":11,"original_position":11,"commit_id":"a61c1ff7ba7a87aba3a481caf06eff7b1bd3c563","original_commit_id":"a61c1ff7ba7a87aba3a481caf06eff7b1bd3c563","user":{"login":"stephenrichards","id":115617,"node_id":"MDQ6VXNlcjExNTYxNw==","avatar_url":"https://avatars1.githubusercontent.com/u/115617?v=4","gravatar_id":"","url":"https://api.github.com/users/stephenrichards","html_url":"https://github.com/stephenrichards","followers_url":"https://api.github.com/users/stephenrichards/followers","following_url":"https://api.github.com/users/stephenrichards/following{/other_user}","gists_url":"https://api.github.com/users/stephenrichards/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenrichards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenrichards/subscriptions","organizations_url":"https://api.github.com/users/stephenrichards/orgs","repos_url":"https://api.github.com/users/stephenrichards/repos","events_url":"https://api.github.com/users/stephenrichards/events{/privacy}","received_events_url":"https://api.github.com/users/stephenrichards/received_events","type":"User","site_admin":false},"body":"done\r\n","created_at":"2019-01-02T13:56:54Z","updated_at":"2019-01-02T13:56:54Z","html_url":"https://github.com/ministryofjustice/laa-apply-for-legal-aid/pull/174#discussion_r244741603","pull_request_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/pulls/174","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/pulls/comments/244741603"},"html":{"href":"https://github.com/ministryofjustice/laa-apply-for-legal-aid/pull/174#discussion_r244741603"},"pull_request":{"href":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/pulls/174"}},"in_reply_to_id":244691647},"pull_request":{"url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/pulls/174","id":240777007,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNzc3MDA3","html_url":"https://github.com/ministryofjustice/laa-apply-for-legal-aid/pull/174","diff_url":"https://github.com/ministryofjustice/laa-apply-for-legal-aid/pull/174.diff","patch_url":"https://github.com/ministryofjustice/laa-apply-for-legal-aid/pull/174.patch","issue_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/issues/174","number":174,"state":"open","locked":false,"title":"AP-249 save as draft","user":{"login":"stephenrichards","id":115617,"node_id":"MDQ6VXNlcjExNTYxNw==","avatar_url":"https://avatars1.githubusercontent.com/u/115617?v=4","gravatar_id":"","url":"https://api.github.com/users/stephenrichards","html_url":"https://github.com/stephenrichards","followers_url":"https://api.github.com/users/stephenrichards/followers","following_url":"https://api.github.com/users/stephenrichards/following{/other_user}","gists_url":"https://api.github.com/users/stephenrichards/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenrichards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenrichards/subscriptions","organizations_url":"https://api.github.com/users/stephenrichards/orgs","repos_url":"https://api.github.com/users/stephenrichards/repos","events_url":"https://api.github.com/users/stephenrichards/events{/privacy}","received_events_url":"https://api.github.com/users/stephenrichards/received_events","type":"User","site_admin":false},"body":"## What\r\n\r\n[Link to story](https://dsdmoj.atlassian.net/browse/AP-249)\r\n\r\nThis PR implements a Save and Return feature to the provider journey.\r\nEach page now has a new Save as draft button which will save the updates to\r\nthe database and redirect to the Provider applications page, in addition to\r\nthe existing Continue button which saves the changes and progresses on to\r\nthe next page in the journey.\r\n\r\nIn the views, forms that previously had a submit button\r\nnow render a partial `share/forms/continue_and_draft_buttons` which renders\r\nthe two buttons if required (most forms in whch this partial is included are\r\nused for the citizens journey as well, so the partial requires a local variable `show_draft`\r\nto be set to true or false to determine whether or not to render the Save as Draft button).\r\n\r\nPages which were not previously forms, and had the continue\r\nbutton rendered with a `button_to` link now submit a form with just the two\r\nbuttons, via the partial `shared/forms/continue_and_draft_button_form`.\r\n\r\nIn the controllers, the logic of determining which button was used to submit the\r\nform and redirect accordingly is in a concern `SaveAsDraftable`, which provides a method\r\n`continue_or_save_draft'.\r\n\r\nAs well as providing a Save as draft button on all the provider pages, all the\r\npages are now wired up to continue to the next page in the journey, so the PR incorporates\r\nsome logic to provide for that as well.\r\n\r\nThis PR does NOT address the Back link, which still needs to be wired up correctly\r\non all the provider pages, nor the forward journey in the Citizen path.\r\n\r\n## Checklist\r\n\r\nBefore you ask people to review this PR:\r\n\r\n- [x] Tests and rubocop should be passing: `bundle exec rake`\r\n- [x] Github should not be reporting conflicts; you should have recently run `git rebase master`.\r\n- [x] There should be no unneccessary whitespace changes. These make diffs harder to read and conflicts more likely. \r\n- [x] The PR description should say what you changed and why, with a link to the JIRA story.\r\n- [x] You should have looked at the diff against master and ensured that nothing unexpected is included in your changes.\r\n- [x] You should have checked that the commit messages say why the change was made.\r\n","created_at":"2018-12-24T13:41:38Z","updated_at":"2019-01-02T13:56:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6fddf359c0bbf66c3b18ef528e388eb3c23381a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1055569074,"node_id":"MDU6TGFiZWwxMDU1NTY5MDc0","url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/labels/ready%20for%20review","name":"ready for review","color":"8dfc9a","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/pulls/174/commits","review_comments_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/pulls/174/comments","review_comment_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/issues/174/comments","statuses_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/statuses/a61c1ff7ba7a87aba3a481caf06eff7b1bd3c563","head":{"label":"ministryofjustice:ap-249-save-as-draft","ref":"ap-249-save-as-draft","sha":"a61c1ff7ba7a87aba3a481caf06eff7b1bd3c563","user":{"login":"ministryofjustice","id":2203574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDM1NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2203574?v=4","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"repo":{"id":143924174,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM5MjQxNzQ=","name":"laa-apply-for-legal-aid","full_name":"ministryofjustice/laa-apply-for-legal-aid","private":false,"owner":{"login":"ministryofjustice","id":2203574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDM1NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2203574?v=4","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ministryofjustice/laa-apply-for-legal-aid","description":"This api will provide various services to create a legal aid application","fork":false,"url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid","forks_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/forks","keys_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/teams","hooks_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/hooks","issue_events_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/issues/events{/number}","events_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/events","assignees_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/assignees{/user}","branches_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/branches{/branch}","tags_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/tags","blobs_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/git/refs{/sha}","trees_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/statuses/{sha}","languages_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/languages","stargazers_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/stargazers","contributors_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/contributors","subscribers_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/subscribers","subscription_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/subscription","commits_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/commits{/sha}","git_commits_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/git/commits{/sha}","comments_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/comments{/number}","issue_comment_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/issues/comments{/number}","contents_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/contents/{+path}","compare_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/merges","archive_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/downloads","issues_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/issues{/number}","pulls_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/pulls{/number}","milestones_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/milestones{/number}","notifications_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/labels{/name}","releases_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/releases{/id}","deployments_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/deployments","created_at":"2018-08-07T20:34:48Z","updated_at":"2018-12-31T12:39:21Z","pushed_at":"2019-01-02T12:21:17Z","git_url":"git://github.com/ministryofjustice/laa-apply-for-legal-aid.git","ssh_url":"[email protected]:ministryofjustice/laa-apply-for-legal-aid.git","clone_url":"https://github.com/ministryofjustice/laa-apply-for-legal-aid.git","svn_url":"https://github.com/ministryofjustice/laa-apply-for-legal-aid","homepage":"","size":1841,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":11,"license":null,"forks":0,"open_issues":11,"watchers":3,"default_branch":"master"}},"base":{"label":"ministryofjustice:master","ref":"master","sha":"2419e3948fdd250290b778fff910088fec2619e5","user":{"login":"ministryofjustice","id":2203574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDM1NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2203574?v=4","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"repo":{"id":143924174,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM5MjQxNzQ=","name":"laa-apply-for-legal-aid","full_name":"ministryofjustice/laa-apply-for-legal-aid","private":false,"owner":{"login":"ministryofjustice","id":2203574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDM1NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2203574?v=4","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ministryofjustice/laa-apply-for-legal-aid","description":"This api will provide various services to create a legal aid application","fork":false,"url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid","forks_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/forks","keys_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/teams","hooks_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/hooks","issue_events_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/issues/events{/number}","events_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/events","assignees_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/assignees{/user}","branches_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/branches{/branch}","tags_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/tags","blobs_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/git/refs{/sha}","trees_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/statuses/{sha}","languages_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/languages","stargazers_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/stargazers","contributors_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/contributors","subscribers_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/subscribers","subscription_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/subscription","commits_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/commits{/sha}","git_commits_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/git/commits{/sha}","comments_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/comments{/number}","issue_comment_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/issues/comments{/number}","contents_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/contents/{+path}","compare_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/merges","archive_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/downloads","issues_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/issues{/number}","pulls_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/pulls{/number}","milestones_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/milestones{/number}","notifications_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/labels{/name}","releases_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/releases{/id}","deployments_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/deployments","created_at":"2018-08-07T20:34:48Z","updated_at":"2018-12-31T12:39:21Z","pushed_at":"2019-01-02T12:21:17Z","git_url":"git://github.com/ministryofjustice/laa-apply-for-legal-aid.git","ssh_url":"[email protected]:ministryofjustice/laa-apply-for-legal-aid.git","clone_url":"https://github.com/ministryofjustice/laa-apply-for-legal-aid.git","svn_url":"https://github.com/ministryofjustice/laa-apply-for-legal-aid","homepage":"","size":1841,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":11,"license":null,"forks":0,"open_issues":11,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/pulls/174"},"html":{"href":"https://github.com/ministryofjustice/laa-apply-for-legal-aid/pull/174"},"issue":{"href":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/issues/174"},"comments":{"href":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/issues/174/comments"},"review_comments":{"href":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/pulls/174/comments"},"review_comment":{"href":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/pulls/174/commits"},"statuses":{"href":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/statuses/a61c1ff7ba7a87aba3a481caf06eff7b1bd3c563"}},"author_association":"COLLABORATOR"}} | {
"id": 143924174,
"name": "ministryofjustice/laa-apply-for-legal-aid",
"url": "https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid"
} | {
"id": 115617,
"login": "stephenrichards",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/115617?",
"url": "https://api.github.com/users/stephenrichards"
} | {
"id": 2203574,
"login": "ministryofjustice",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2203574?",
"url": "https://api.github.com/orgs/ministryofjustice"
} | 2019-01-02T13:56:54 | 8823516130 | {"actor":{"display_login":"stephenrichards"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/pulls/comments/232283924","pull_request_review_id":173449927,"id":232283924,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjI4MzkyNA==","diff_hunk":"@@ -71,7 +71,7 @@\n \n it 'renders the form again if validation fails' do\n post_request\n- expect(response.body).to include(\"Enter your client's address manually\")\n+ expect(response.body).to include(CGI.escapeHTML(\"Enter your client's address manually\"))","path":"spec/requests/providers/addresses_request_spec.rb","position":14,"original_position":14,"commit_id":"d14dabc554a07733134fbc1af75e7c1c30f286fb","original_commit_id":"d14dabc554a07733134fbc1af75e7c1c30f286fb","user":{"login":"lostie","id":67125,"node_id":"MDQ6VXNlcjY3MTI1","avatar_url":"https://avatars2.githubusercontent.com/u/67125?v=4","gravatar_id":"","url":"https://api.github.com/users/lostie","html_url":"https://github.com/lostie","followers_url":"https://api.github.com/users/lostie/followers","following_url":"https://api.github.com/users/lostie/following{/other_user}","gists_url":"https://api.github.com/users/lostie/gists{/gist_id}","starred_url":"https://api.github.com/users/lostie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lostie/subscriptions","organizations_url":"https://api.github.com/users/lostie/orgs","repos_url":"https://api.github.com/users/lostie/repos","events_url":"https://api.github.com/users/lostie/events{/privacy}","received_events_url":"https://api.github.com/users/lostie/received_events","type":"User","site_admin":false},"body":"[Ditto](https://github.com/ministryofjustice/laa-apply-for-legal-aid/pull/71/files#r232283856)","created_at":"2018-11-09T15:06:46Z","updated_at":"2018-11-09T15:06:46Z","html_url":"https://github.com/ministryofjustice/laa-apply-for-legal-aid/pull/71#discussion_r232283924","pull_request_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/pulls/71","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/pulls/comments/232283924"},"html":{"href":"https://github.com/ministryofjustice/laa-apply-for-legal-aid/pull/71#discussion_r232283924"},"pull_request":{"href":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/pulls/71"}}},"pull_request":{"url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/pulls/71","id":229707196,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NzA3MTk2","html_url":"https://github.com/ministryofjustice/laa-apply-for-legal-aid/pull/71","diff_url":"https://github.com/ministryofjustice/laa-apply-for-legal-aid/pull/71.diff","patch_url":"https://github.com/ministryofjustice/laa-apply-for-legal-aid/pull/71.patch","issue_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/issues/71","number":71,"state":"open","locked":false,"title":"Address lookup and selection page styling amendments (AP-179)","user":{"login":"LAACharlesBoardman","id":27214797,"node_id":"MDQ6VXNlcjI3MjE0Nzk3","avatar_url":"https://avatars2.githubusercontent.com/u/27214797?v=4","gravatar_id":"","url":"https://api.github.com/users/LAACharlesBoardman","html_url":"https://github.com/LAACharlesBoardman","followers_url":"https://api.github.com/users/LAACharlesBoardman/followers","following_url":"https://api.github.com/users/LAACharlesBoardman/following{/other_user}","gists_url":"https://api.github.com/users/LAACharlesBoardman/gists{/gist_id}","starred_url":"https://api.github.com/users/LAACharlesBoardman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LAACharlesBoardman/subscriptions","organizations_url":"https://api.github.com/users/LAACharlesBoardman/orgs","repos_url":"https://api.github.com/users/LAACharlesBoardman/repos","events_url":"https://api.github.com/users/LAACharlesBoardman/events{/privacy}","received_events_url":"https://api.github.com/users/LAACharlesBoardman/received_events","type":"User","site_admin":false},"body":"## What\r\n\r\n[Link to story](https://dsdmoj.atlassian.net/browse/AP-179)\r\n\r\n- Added a new local variable to the Text Field partial that determines if a hint is displayed\r\nThis means on one page we can display the postcode field with a hint and on another without the hint\r\n- Correcting the postcode text field partial call seemed to have fixed the error anchor link\r\n- Added some logic that determines which title the manual address page should display depending on whether the user chose to input the address manual or was redirected after a lookup fail\r\n\r\n## Checklist\r\n\r\nBefore you ask people to review this PR:\r\n\r\n- [x] Tests and rubocop should be passing: `bundle exec rake`\r\n- [x] Github should not be reporting conflicts; you should have recently run `git rebase master`.\r\n- [x] There should be no unneccessary whitespace changes. These make diffs harder to read and conflicts more likely. \r\n- [x] The PR description should say what you changed and why, with a link to the JIRA story.\r\n- [x] You should have looked at the diff against master and ensured that nothing unexpected is included in your changes.\r\n- [x] You should have checked that the commit messages say why the change was made.\r\n","created_at":"2018-11-09T14:17:40Z","updated_at":"2018-11-09T15:06:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b3cdb886112d75da89d1518621ea0aa667ced787","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/pulls/71/commits","review_comments_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/pulls/71/comments","review_comment_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/issues/71/comments","statuses_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/statuses/d14dabc554a07733134fbc1af75e7c1c30f286fb","head":{"label":"ministryofjustice:ap-179","ref":"ap-179","sha":"d14dabc554a07733134fbc1af75e7c1c30f286fb","user":{"login":"ministryofjustice","id":2203574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDM1NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2203574?v=4","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"repo":{"id":143924174,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM5MjQxNzQ=","name":"laa-apply-for-legal-aid","full_name":"ministryofjustice/laa-apply-for-legal-aid","private":false,"owner":{"login":"ministryofjustice","id":2203574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDM1NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2203574?v=4","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ministryofjustice/laa-apply-for-legal-aid","description":"This api will provide various services to create a legal aid application","fork":false,"url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid","forks_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/forks","keys_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/teams","hooks_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/hooks","issue_events_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/issues/events{/number}","events_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/events","assignees_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/assignees{/user}","branches_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/branches{/branch}","tags_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/tags","blobs_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/git/refs{/sha}","trees_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/statuses/{sha}","languages_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/languages","stargazers_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/stargazers","contributors_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/contributors","subscribers_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/subscribers","subscription_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/subscription","commits_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/commits{/sha}","git_commits_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/git/commits{/sha}","comments_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/comments{/number}","issue_comment_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/issues/comments{/number}","contents_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/contents/{+path}","compare_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/merges","archive_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/downloads","issues_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/issues{/number}","pulls_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/pulls{/number}","milestones_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/milestones{/number}","notifications_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/labels{/name}","releases_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/releases{/id}","deployments_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/deployments","created_at":"2018-08-07T20:34:48Z","updated_at":"2018-11-09T11:11:03Z","pushed_at":"2018-11-09T14:19:44Z","git_url":"git://github.com/ministryofjustice/laa-apply-for-legal-aid.git","ssh_url":"[email protected]:ministryofjustice/laa-apply-for-legal-aid.git","clone_url":"https://github.com/ministryofjustice/laa-apply-for-legal-aid.git","svn_url":"https://github.com/ministryofjustice/laa-apply-for-legal-aid","homepage":"","size":1084,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":7,"license":null,"forks":0,"open_issues":7,"watchers":2,"default_branch":"master"}},"base":{"label":"ministryofjustice:master","ref":"master","sha":"41a222df3cc4726bda9da57ae7c93440e2b8804a","user":{"login":"ministryofjustice","id":2203574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDM1NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2203574?v=4","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"repo":{"id":143924174,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM5MjQxNzQ=","name":"laa-apply-for-legal-aid","full_name":"ministryofjustice/laa-apply-for-legal-aid","private":false,"owner":{"login":"ministryofjustice","id":2203574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDM1NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2203574?v=4","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ministryofjustice/laa-apply-for-legal-aid","description":"This api will provide various services to create a legal aid application","fork":false,"url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid","forks_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/forks","keys_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/teams","hooks_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/hooks","issue_events_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/issues/events{/number}","events_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/events","assignees_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/assignees{/user}","branches_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/branches{/branch}","tags_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/tags","blobs_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/git/refs{/sha}","trees_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/statuses/{sha}","languages_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/languages","stargazers_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/stargazers","contributors_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/contributors","subscribers_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/subscribers","subscription_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/subscription","commits_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/commits{/sha}","git_commits_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/git/commits{/sha}","comments_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/comments{/number}","issue_comment_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/issues/comments{/number}","contents_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/contents/{+path}","compare_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/merges","archive_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/downloads","issues_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/issues{/number}","pulls_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/pulls{/number}","milestones_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/milestones{/number}","notifications_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/labels{/name}","releases_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/releases{/id}","deployments_url":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/deployments","created_at":"2018-08-07T20:34:48Z","updated_at":"2018-11-09T11:11:03Z","pushed_at":"2018-11-09T14:19:44Z","git_url":"git://github.com/ministryofjustice/laa-apply-for-legal-aid.git","ssh_url":"[email protected]:ministryofjustice/laa-apply-for-legal-aid.git","clone_url":"https://github.com/ministryofjustice/laa-apply-for-legal-aid.git","svn_url":"https://github.com/ministryofjustice/laa-apply-for-legal-aid","homepage":"","size":1084,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":7,"license":null,"forks":0,"open_issues":7,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/pulls/71"},"html":{"href":"https://github.com/ministryofjustice/laa-apply-for-legal-aid/pull/71"},"issue":{"href":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/issues/71"},"comments":{"href":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid/statuses/d14dabc554a07733134fbc1af75e7c1c30f286fb"}},"author_association":"NONE"}} | {
"id": 143924174,
"name": "ministryofjustice/laa-apply-for-legal-aid",
"url": "https://api.github.com/repos/ministryofjustice/laa-apply-for-legal-aid"
} | {
"id": 67125,
"login": "lostie",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/67125?",
"url": "https://api.github.com/users/lostie"
} | {
"id": 2203574,
"login": "ministryofjustice",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2203574?",
"url": "https://api.github.com/orgs/ministryofjustice"
} | 2018-11-09T15:06:46 | 8563817779 | {"actor":{"display_login":"lostie"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/trailofbits/algo/pulls/comments/187803093","pull_request_review_id":119656510,"id":187803093,"diff_hunk":"@@ -0,0 +1,5 @@\n+---","path":"roles/dns_adblocking/tasks/arch_set_nogroup.yml","position":1,"original_position":1,"commit_id":"7c753cddfa3a270c3d6d72ef90b5646183ba056b","original_commit_id":"7c753cddfa3a270c3d6d72ef90b5646183ba056b","user":{"login":"gagarski","id":6356608,"avatar_url":"https://avatars0.githubusercontent.com/u/6356608?v=4","gravatar_id":"","url":"https://api.github.com/users/gagarski","html_url":"https://github.com/gagarski","followers_url":"https://api.github.com/users/gagarski/followers","following_url":"https://api.github.com/users/gagarski/following{/other_user}","gists_url":"https://api.github.com/users/gagarski/gists{/gist_id}","starred_url":"https://api.github.com/users/gagarski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gagarski/subscriptions","organizations_url":"https://api.github.com/users/gagarski/orgs","repos_url":"https://api.github.com/users/gagarski/repos","events_url":"https://api.github.com/users/gagarski/events{/privacy}","received_events_url":"https://api.github.com/users/gagarski/received_events","type":"User","site_admin":false},"body":"Perhaps I could've moved this part to `arch.yml` but then I'd have to rearrange items in `main.yml`.","created_at":"2018-05-13T14:37:33Z","updated_at":"2018-05-13T14:37:58Z","html_url":"https://github.com/trailofbits/algo/pull/943#discussion_r187803093","pull_request_url":"https://api.github.com/repos/trailofbits/algo/pulls/943","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/trailofbits/algo/pulls/comments/187803093"},"html":{"href":"https://github.com/trailofbits/algo/pull/943#discussion_r187803093"},"pull_request":{"href":"https://api.github.com/repos/trailofbits/algo/pulls/943"}}},"pull_request":{"url":"https://api.github.com/repos/trailofbits/algo/pulls/943","id":187671003,"html_url":"https://github.com/trailofbits/algo/pull/943","diff_url":"https://github.com/trailofbits/algo/pull/943.diff","patch_url":"https://github.com/trailofbits/algo/pull/943.patch","issue_url":"https://api.github.com/repos/trailofbits/algo/issues/943","number":943,"state":"open","locked":false,"title":"Arch Linux support","user":{"login":"gagarski","id":6356608,"avatar_url":"https://avatars0.githubusercontent.com/u/6356608?v=4","gravatar_id":"","url":"https://api.github.com/users/gagarski","html_url":"https://github.com/gagarski","followers_url":"https://api.github.com/users/gagarski/followers","following_url":"https://api.github.com/users/gagarski/following{/other_user}","gists_url":"https://api.github.com/users/gagarski/gists{/gist_id}","starred_url":"https://api.github.com/users/gagarski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gagarski/subscriptions","organizations_url":"https://api.github.com/users/gagarski/orgs","repos_url":"https://api.github.com/users/gagarski/repos","events_url":"https://api.github.com/users/gagarski/events{/privacy}","received_events_url":"https://api.github.com/users/gagarski/received_events","type":"User","site_admin":false},"body":"Tested on new DO Droplet with Debian 9.4 converted to Arch Linux with [this script](https://github.com/gh2o/digitalocean-debian-to-arch)","created_at":"2018-05-13T13:47:17Z","updated_at":"2018-05-13T14:37:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8bf5df900eb4100f912d8c73488664ccbd9ab407","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/trailofbits/algo/pulls/943/commits","review_comments_url":"https://api.github.com/repos/trailofbits/algo/pulls/943/comments","review_comment_url":"https://api.github.com/repos/trailofbits/algo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/trailofbits/algo/issues/943/comments","statuses_url":"https://api.github.com/repos/trailofbits/algo/statuses/7c753cddfa3a270c3d6d72ef90b5646183ba056b","head":{"label":"gagarski:archlinux","ref":"archlinux","sha":"7c753cddfa3a270c3d6d72ef90b5646183ba056b","user":{"login":"gagarski","id":6356608,"avatar_url":"https://avatars0.githubusercontent.com/u/6356608?v=4","gravatar_id":"","url":"https://api.github.com/users/gagarski","html_url":"https://github.com/gagarski","followers_url":"https://api.github.com/users/gagarski/followers","following_url":"https://api.github.com/users/gagarski/following{/other_user}","gists_url":"https://api.github.com/users/gagarski/gists{/gist_id}","starred_url":"https://api.github.com/users/gagarski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gagarski/subscriptions","organizations_url":"https://api.github.com/users/gagarski/orgs","repos_url":"https://api.github.com/users/gagarski/repos","events_url":"https://api.github.com/users/gagarski/events{/privacy}","received_events_url":"https://api.github.com/users/gagarski/received_events","type":"User","site_admin":false},"repo":{"id":133239572,"name":"algo","full_name":"gagarski/algo","owner":{"login":"gagarski","id":6356608,"avatar_url":"https://avatars0.githubusercontent.com/u/6356608?v=4","gravatar_id":"","url":"https://api.github.com/users/gagarski","html_url":"https://github.com/gagarski","followers_url":"https://api.github.com/users/gagarski/followers","following_url":"https://api.github.com/users/gagarski/following{/other_user}","gists_url":"https://api.github.com/users/gagarski/gists{/gist_id}","starred_url":"https://api.github.com/users/gagarski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gagarski/subscriptions","organizations_url":"https://api.github.com/users/gagarski/orgs","repos_url":"https://api.github.com/users/gagarski/repos","events_url":"https://api.github.com/users/gagarski/events{/privacy}","received_events_url":"https://api.github.com/users/gagarski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gagarski/algo","description":"Set up a personal IPSEC VPN in the cloud","fork":true,"url":"https://api.github.com/repos/gagarski/algo","forks_url":"https://api.github.com/repos/gagarski/algo/forks","keys_url":"https://api.github.com/repos/gagarski/algo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gagarski/algo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gagarski/algo/teams","hooks_url":"https://api.github.com/repos/gagarski/algo/hooks","issue_events_url":"https://api.github.com/repos/gagarski/algo/issues/events{/number}","events_url":"https://api.github.com/repos/gagarski/algo/events","assignees_url":"https://api.github.com/repos/gagarski/algo/assignees{/user}","branches_url":"https://api.github.com/repos/gagarski/algo/branches{/branch}","tags_url":"https://api.github.com/repos/gagarski/algo/tags","blobs_url":"https://api.github.com/repos/gagarski/algo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gagarski/algo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gagarski/algo/git/refs{/sha}","trees_url":"https://api.github.com/repos/gagarski/algo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gagarski/algo/statuses/{sha}","languages_url":"https://api.github.com/repos/gagarski/algo/languages","stargazers_url":"https://api.github.com/repos/gagarski/algo/stargazers","contributors_url":"https://api.github.com/repos/gagarski/algo/contributors","subscribers_url":"https://api.github.com/repos/gagarski/algo/subscribers","subscription_url":"https://api.github.com/repos/gagarski/algo/subscription","commits_url":"https://api.github.com/repos/gagarski/algo/commits{/sha}","git_commits_url":"https://api.github.com/repos/gagarski/algo/git/commits{/sha}","comments_url":"https://api.github.com/repos/gagarski/algo/comments{/number}","issue_comment_url":"https://api.github.com/repos/gagarski/algo/issues/comments{/number}","contents_url":"https://api.github.com/repos/gagarski/algo/contents/{+path}","compare_url":"https://api.github.com/repos/gagarski/algo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gagarski/algo/merges","archive_url":"https://api.github.com/repos/gagarski/algo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gagarski/algo/downloads","issues_url":"https://api.github.com/repos/gagarski/algo/issues{/number}","pulls_url":"https://api.github.com/repos/gagarski/algo/pulls{/number}","milestones_url":"https://api.github.com/repos/gagarski/algo/milestones{/number}","notifications_url":"https://api.github.com/repos/gagarski/algo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gagarski/algo/labels{/name}","releases_url":"https://api.github.com/repos/gagarski/algo/releases{/id}","deployments_url":"https://api.github.com/repos/gagarski/algo/deployments","created_at":"2018-05-13T13:30:11Z","updated_at":"2018-05-13T13:30:13Z","pushed_at":"2018-05-13T14:34:34Z","git_url":"git://github.com/gagarski/algo.git","ssh_url":"[email protected]:gagarski/algo.git","clone_url":"https://github.com/gagarski/algo.git","svn_url":"https://github.com/gagarski/algo","homepage":"https://blog.trailofbits.com/2016/12/12/meet-algo-the-vpn-that-works/","size":1236,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"trailofbits:master","ref":"master","sha":"6f3ec658fe73ce2d85e60d628c9aaafb882d186b","user":{"login":"trailofbits","id":2314423,"avatar_url":"https://avatars0.githubusercontent.com/u/2314423?v=4","gravatar_id":"","url":"https://api.github.com/users/trailofbits","html_url":"https://github.com/trailofbits","followers_url":"https://api.github.com/users/trailofbits/followers","following_url":"https://api.github.com/users/trailofbits/following{/other_user}","gists_url":"https://api.github.com/users/trailofbits/gists{/gist_id}","starred_url":"https://api.github.com/users/trailofbits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trailofbits/subscriptions","organizations_url":"https://api.github.com/users/trailofbits/orgs","repos_url":"https://api.github.com/users/trailofbits/repos","events_url":"https://api.github.com/users/trailofbits/events{/privacy}","received_events_url":"https://api.github.com/users/trailofbits/received_events","type":"Organization","site_admin":false},"repo":{"id":58842707,"name":"algo","full_name":"trailofbits/algo","owner":{"login":"trailofbits","id":2314423,"avatar_url":"https://avatars0.githubusercontent.com/u/2314423?v=4","gravatar_id":"","url":"https://api.github.com/users/trailofbits","html_url":"https://github.com/trailofbits","followers_url":"https://api.github.com/users/trailofbits/followers","following_url":"https://api.github.com/users/trailofbits/following{/other_user}","gists_url":"https://api.github.com/users/trailofbits/gists{/gist_id}","starred_url":"https://api.github.com/users/trailofbits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trailofbits/subscriptions","organizations_url":"https://api.github.com/users/trailofbits/orgs","repos_url":"https://api.github.com/users/trailofbits/repos","events_url":"https://api.github.com/users/trailofbits/events{/privacy}","received_events_url":"https://api.github.com/users/trailofbits/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/trailofbits/algo","description":"Set up a personal IPSEC VPN in the cloud","fork":false,"url":"https://api.github.com/repos/trailofbits/algo","forks_url":"https://api.github.com/repos/trailofbits/algo/forks","keys_url":"https://api.github.com/repos/trailofbits/algo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trailofbits/algo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trailofbits/algo/teams","hooks_url":"https://api.github.com/repos/trailofbits/algo/hooks","issue_events_url":"https://api.github.com/repos/trailofbits/algo/issues/events{/number}","events_url":"https://api.github.com/repos/trailofbits/algo/events","assignees_url":"https://api.github.com/repos/trailofbits/algo/assignees{/user}","branches_url":"https://api.github.com/repos/trailofbits/algo/branches{/branch}","tags_url":"https://api.github.com/repos/trailofbits/algo/tags","blobs_url":"https://api.github.com/repos/trailofbits/algo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trailofbits/algo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trailofbits/algo/git/refs{/sha}","trees_url":"https://api.github.com/repos/trailofbits/algo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trailofbits/algo/statuses/{sha}","languages_url":"https://api.github.com/repos/trailofbits/algo/languages","stargazers_url":"https://api.github.com/repos/trailofbits/algo/stargazers","contributors_url":"https://api.github.com/repos/trailofbits/algo/contributors","subscribers_url":"https://api.github.com/repos/trailofbits/algo/subscribers","subscription_url":"https://api.github.com/repos/trailofbits/algo/subscription","commits_url":"https://api.github.com/repos/trailofbits/algo/commits{/sha}","git_commits_url":"https://api.github.com/repos/trailofbits/algo/git/commits{/sha}","comments_url":"https://api.github.com/repos/trailofbits/algo/comments{/number}","issue_comment_url":"https://api.github.com/repos/trailofbits/algo/issues/comments{/number}","contents_url":"https://api.github.com/repos/trailofbits/algo/contents/{+path}","compare_url":"https://api.github.com/repos/trailofbits/algo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trailofbits/algo/merges","archive_url":"https://api.github.com/repos/trailofbits/algo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trailofbits/algo/downloads","issues_url":"https://api.github.com/repos/trailofbits/algo/issues{/number}","pulls_url":"https://api.github.com/repos/trailofbits/algo/pulls{/number}","milestones_url":"https://api.github.com/repos/trailofbits/algo/milestones{/number}","notifications_url":"https://api.github.com/repos/trailofbits/algo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trailofbits/algo/labels{/name}","releases_url":"https://api.github.com/repos/trailofbits/algo/releases{/id}","deployments_url":"https://api.github.com/repos/trailofbits/algo/deployments","created_at":"2016-05-15T03:42:48Z","updated_at":"2018-05-13T14:26:59Z","pushed_at":"2018-05-13T14:34:35Z","git_url":"git://github.com/trailofbits/algo.git","ssh_url":"[email protected]:trailofbits/algo.git","clone_url":"https://github.com/trailofbits/algo.git","svn_url":"https://github.com/trailofbits/algo","homepage":"https://blog.trailofbits.com/2016/12/12/meet-algo-the-vpn-that-works/","size":1229,"stargazers_count":8588,"watchers_count":8588,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":687,"mirror_url":null,"archived":false,"open_issues_count":84,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":687,"open_issues":84,"watchers":8588,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/trailofbits/algo/pulls/943"},"html":{"href":"https://github.com/trailofbits/algo/pull/943"},"issue":{"href":"https://api.github.com/repos/trailofbits/algo/issues/943"},"comments":{"href":"https://api.github.com/repos/trailofbits/algo/issues/943/comments"},"review_comments":{"href":"https://api.github.com/repos/trailofbits/algo/pulls/943/comments"},"review_comment":{"href":"https://api.github.com/repos/trailofbits/algo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/trailofbits/algo/pulls/943/commits"},"statuses":{"href":"https://api.github.com/repos/trailofbits/algo/statuses/7c753cddfa3a270c3d6d72ef90b5646183ba056b"}},"author_association":"NONE"}} | {
"id": 58842707,
"name": "trailofbits/algo",
"url": "https://api.github.com/repos/trailofbits/algo"
} | {
"id": 6356608,
"login": "gagarski",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6356608?",
"url": "https://api.github.com/users/gagarski"
} | {
"id": 2314423,
"login": "trailofbits",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2314423?",
"url": "https://api.github.com/orgs/trailofbits"
} | 2018-05-13T14:37:33 | 7666859491 | {"actor":{"display_login":"gagarski"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/framgia/fitm/pulls/comments/170860371","pull_request_review_id":99609907,"id":170860371,"diff_hunk":"@@ -24,4 +24,14 @@ def check_register course\n return unless current_user\n current_user.register_courses.find_by(course_id: course.id)\n end\n+\n+ def arr_group_name _args\n+ @parent_paths = @user.groups.pluck :parrent_path","path":"app/helpers/application_helper.rb","position":6,"original_position":6,"commit_id":"cac3ea6971e388ff5e28035e13a41d3f1e48ca72","original_commit_id":"cac3ea6971e388ff5e28035e13a41d3f1e48ca72","user":{"login":"dothidiemthao","id":21377118,"avatar_url":"https://avatars0.githubusercontent.com/u/21377118?v=4","gravatar_id":"","url":"https://api.github.com/users/dothidiemthao","html_url":"https://github.com/dothidiemthao","followers_url":"https://api.github.com/users/dothidiemthao/followers","following_url":"https://api.github.com/users/dothidiemthao/following{/other_user}","gists_url":"https://api.github.com/users/dothidiemthao/gists{/gist_id}","starred_url":"https://api.github.com/users/dothidiemthao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dothidiemthao/subscriptions","organizations_url":"https://api.github.com/users/dothidiemthao/orgs","repos_url":"https://api.github.com/users/dothidiemthao/repos","events_url":"https://api.github.com/users/dothidiemthao/events{/privacy}","received_events_url":"https://api.github.com/users/dothidiemthao/received_events","type":"User","site_admin":false},"body":"@parent_paths mí cái này lấy đâu ra đây em, nhận tham số vào làm chứ\r\n","created_at":"2018-02-27T09:29:07Z","updated_at":"2018-02-27T09:29:07Z","html_url":"https://github.com/framgia/fitm/pull/16#discussion_r170860371","pull_request_url":"https://api.github.com/repos/framgia/fitm/pulls/16","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/framgia/fitm/pulls/comments/170860371"},"html":{"href":"https://github.com/framgia/fitm/pull/16#discussion_r170860371"},"pull_request":{"href":"https://api.github.com/repos/framgia/fitm/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/framgia/fitm/pulls/16","id":170670631,"html_url":"https://github.com/framgia/fitm/pull/16","diff_url":"https://github.com/framgia/fitm/pull/16.diff","patch_url":"https://github.com/framgia/fitm/pull/16.patch","issue_url":"https://api.github.com/repos/framgia/fitm/issues/16","number":16,"state":"open","locked":false,"title":"User profile","user":{"login":"namkidd","id":33993830,"avatar_url":"https://avatars2.githubusercontent.com/u/33993830?v=4","gravatar_id":"","url":"https://api.github.com/users/namkidd","html_url":"https://github.com/namkidd","followers_url":"https://api.github.com/users/namkidd/followers","following_url":"https://api.github.com/users/namkidd/following{/other_user}","gists_url":"https://api.github.com/users/namkidd/gists{/gist_id}","starred_url":"https://api.github.com/users/namkidd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/namkidd/subscriptions","organizations_url":"https://api.github.com/users/namkidd/orgs","repos_url":"https://api.github.com/users/namkidd/repos","events_url":"https://api.github.com/users/namkidd/events{/privacy}","received_events_url":"https://api.github.com/users/namkidd/received_events","type":"User","site_admin":false},"body":"\r\n\r\n\r\n\r\n","created_at":"2018-02-22T06:57:11Z","updated_at":"2018-02-27T09:29:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"521d130abdd616b175b1c960a96bb55da46a8e60","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/framgia/fitm/pulls/16/commits","review_comments_url":"https://api.github.com/repos/framgia/fitm/pulls/16/comments","review_comment_url":"https://api.github.com/repos/framgia/fitm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/framgia/fitm/issues/16/comments","statuses_url":"https://api.github.com/repos/framgia/fitm/statuses/cac3ea6971e388ff5e28035e13a41d3f1e48ca72","head":{"label":"namkidd:user-profile","ref":"user-profile","sha":"cac3ea6971e388ff5e28035e13a41d3f1e48ca72","user":{"login":"namkidd","id":33993830,"avatar_url":"https://avatars2.githubusercontent.com/u/33993830?v=4","gravatar_id":"","url":"https://api.github.com/users/namkidd","html_url":"https://github.com/namkidd","followers_url":"https://api.github.com/users/namkidd/followers","following_url":"https://api.github.com/users/namkidd/following{/other_user}","gists_url":"https://api.github.com/users/namkidd/gists{/gist_id}","starred_url":"https://api.github.com/users/namkidd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/namkidd/subscriptions","organizations_url":"https://api.github.com/users/namkidd/orgs","repos_url":"https://api.github.com/users/namkidd/repos","events_url":"https://api.github.com/users/namkidd/events{/privacy}","received_events_url":"https://api.github.com/users/namkidd/received_events","type":"User","site_admin":false},"repo":{"id":120562947,"name":"fitm","full_name":"namkidd/fitm","owner":{"login":"namkidd","id":33993830,"avatar_url":"https://avatars2.githubusercontent.com/u/33993830?v=4","gravatar_id":"","url":"https://api.github.com/users/namkidd","html_url":"https://github.com/namkidd","followers_url":"https://api.github.com/users/namkidd/followers","following_url":"https://api.github.com/users/namkidd/following{/other_user}","gists_url":"https://api.github.com/users/namkidd/gists{/gist_id}","starred_url":"https://api.github.com/users/namkidd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/namkidd/subscriptions","organizations_url":"https://api.github.com/users/namkidd/orgs","repos_url":"https://api.github.com/users/namkidd/repos","events_url":"https://api.github.com/users/namkidd/events{/privacy}","received_events_url":"https://api.github.com/users/namkidd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/namkidd/fitm","description":null,"fork":true,"url":"https://api.github.com/repos/namkidd/fitm","forks_url":"https://api.github.com/repos/namkidd/fitm/forks","keys_url":"https://api.github.com/repos/namkidd/fitm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/namkidd/fitm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/namkidd/fitm/teams","hooks_url":"https://api.github.com/repos/namkidd/fitm/hooks","issue_events_url":"https://api.github.com/repos/namkidd/fitm/issues/events{/number}","events_url":"https://api.github.com/repos/namkidd/fitm/events","assignees_url":"https://api.github.com/repos/namkidd/fitm/assignees{/user}","branches_url":"https://api.github.com/repos/namkidd/fitm/branches{/branch}","tags_url":"https://api.github.com/repos/namkidd/fitm/tags","blobs_url":"https://api.github.com/repos/namkidd/fitm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/namkidd/fitm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/namkidd/fitm/git/refs{/sha}","trees_url":"https://api.github.com/repos/namkidd/fitm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/namkidd/fitm/statuses/{sha}","languages_url":"https://api.github.com/repos/namkidd/fitm/languages","stargazers_url":"https://api.github.com/repos/namkidd/fitm/stargazers","contributors_url":"https://api.github.com/repos/namkidd/fitm/contributors","subscribers_url":"https://api.github.com/repos/namkidd/fitm/subscribers","subscription_url":"https://api.github.com/repos/namkidd/fitm/subscription","commits_url":"https://api.github.com/repos/namkidd/fitm/commits{/sha}","git_commits_url":"https://api.github.com/repos/namkidd/fitm/git/commits{/sha}","comments_url":"https://api.github.com/repos/namkidd/fitm/comments{/number}","issue_comment_url":"https://api.github.com/repos/namkidd/fitm/issues/comments{/number}","contents_url":"https://api.github.com/repos/namkidd/fitm/contents/{+path}","compare_url":"https://api.github.com/repos/namkidd/fitm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/namkidd/fitm/merges","archive_url":"https://api.github.com/repos/namkidd/fitm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/namkidd/fitm/downloads","issues_url":"https://api.github.com/repos/namkidd/fitm/issues{/number}","pulls_url":"https://api.github.com/repos/namkidd/fitm/pulls{/number}","milestones_url":"https://api.github.com/repos/namkidd/fitm/milestones{/number}","notifications_url":"https://api.github.com/repos/namkidd/fitm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/namkidd/fitm/labels{/name}","releases_url":"https://api.github.com/repos/namkidd/fitm/releases{/id}","deployments_url":"https://api.github.com/repos/namkidd/fitm/deployments","created_at":"2018-02-07T04:29:51Z","updated_at":"2018-02-07T04:29:53Z","pushed_at":"2018-02-27T08:22:16Z","git_url":"git://github.com/namkidd/fitm.git","ssh_url":"[email protected]:namkidd/fitm.git","clone_url":"https://github.com/namkidd/fitm.git","svn_url":"https://github.com/namkidd/fitm","homepage":null,"size":1750,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"framgia:develop","ref":"develop","sha":"8497232d3179231ed55ca3524bdeff6717bd4162","user":{"login":"framgia","id":2322183,"avatar_url":"https://avatars3.githubusercontent.com/u/2322183?v=4","gravatar_id":"","url":"https://api.github.com/users/framgia","html_url":"https://github.com/framgia","followers_url":"https://api.github.com/users/framgia/followers","following_url":"https://api.github.com/users/framgia/following{/other_user}","gists_url":"https://api.github.com/users/framgia/gists{/gist_id}","starred_url":"https://api.github.com/users/framgia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/framgia/subscriptions","organizations_url":"https://api.github.com/users/framgia/orgs","repos_url":"https://api.github.com/users/framgia/repos","events_url":"https://api.github.com/users/framgia/events{/privacy}","received_events_url":"https://api.github.com/users/framgia/received_events","type":"Organization","site_admin":false},"repo":{"id":118543442,"name":"fitm","full_name":"framgia/fitm","owner":{"login":"framgia","id":2322183,"avatar_url":"https://avatars3.githubusercontent.com/u/2322183?v=4","gravatar_id":"","url":"https://api.github.com/users/framgia","html_url":"https://github.com/framgia","followers_url":"https://api.github.com/users/framgia/followers","following_url":"https://api.github.com/users/framgia/following{/other_user}","gists_url":"https://api.github.com/users/framgia/gists{/gist_id}","starred_url":"https://api.github.com/users/framgia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/framgia/subscriptions","organizations_url":"https://api.github.com/users/framgia/orgs","repos_url":"https://api.github.com/users/framgia/repos","events_url":"https://api.github.com/users/framgia/events{/privacy}","received_events_url":"https://api.github.com/users/framgia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/framgia/fitm","description":null,"fork":false,"url":"https://api.github.com/repos/framgia/fitm","forks_url":"https://api.github.com/repos/framgia/fitm/forks","keys_url":"https://api.github.com/repos/framgia/fitm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/framgia/fitm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/framgia/fitm/teams","hooks_url":"https://api.github.com/repos/framgia/fitm/hooks","issue_events_url":"https://api.github.com/repos/framgia/fitm/issues/events{/number}","events_url":"https://api.github.com/repos/framgia/fitm/events","assignees_url":"https://api.github.com/repos/framgia/fitm/assignees{/user}","branches_url":"https://api.github.com/repos/framgia/fitm/branches{/branch}","tags_url":"https://api.github.com/repos/framgia/fitm/tags","blobs_url":"https://api.github.com/repos/framgia/fitm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/framgia/fitm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/framgia/fitm/git/refs{/sha}","trees_url":"https://api.github.com/repos/framgia/fitm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/framgia/fitm/statuses/{sha}","languages_url":"https://api.github.com/repos/framgia/fitm/languages","stargazers_url":"https://api.github.com/repos/framgia/fitm/stargazers","contributors_url":"https://api.github.com/repos/framgia/fitm/contributors","subscribers_url":"https://api.github.com/repos/framgia/fitm/subscribers","subscription_url":"https://api.github.com/repos/framgia/fitm/subscription","commits_url":"https://api.github.com/repos/framgia/fitm/commits{/sha}","git_commits_url":"https://api.github.com/repos/framgia/fitm/git/commits{/sha}","comments_url":"https://api.github.com/repos/framgia/fitm/comments{/number}","issue_comment_url":"https://api.github.com/repos/framgia/fitm/issues/comments{/number}","contents_url":"https://api.github.com/repos/framgia/fitm/contents/{+path}","compare_url":"https://api.github.com/repos/framgia/fitm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/framgia/fitm/merges","archive_url":"https://api.github.com/repos/framgia/fitm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/framgia/fitm/downloads","issues_url":"https://api.github.com/repos/framgia/fitm/issues{/number}","pulls_url":"https://api.github.com/repos/framgia/fitm/pulls{/number}","milestones_url":"https://api.github.com/repos/framgia/fitm/milestones{/number}","notifications_url":"https://api.github.com/repos/framgia/fitm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/framgia/fitm/labels{/name}","releases_url":"https://api.github.com/repos/framgia/fitm/releases{/id}","deployments_url":"https://api.github.com/repos/framgia/fitm/deployments","created_at":"2018-01-23T02:06:18Z","updated_at":"2018-01-29T07:49:21Z","pushed_at":"2018-02-27T09:19:50Z","git_url":"git://github.com/framgia/fitm.git","ssh_url":"[email protected]:framgia/fitm.git","clone_url":"https://github.com/framgia/fitm.git","svn_url":"https://github.com/framgia/fitm","homepage":null,"size":1737,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":7,"license":null,"forks":9,"open_issues":7,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/framgia/fitm/pulls/16"},"html":{"href":"https://github.com/framgia/fitm/pull/16"},"issue":{"href":"https://api.github.com/repos/framgia/fitm/issues/16"},"comments":{"href":"https://api.github.com/repos/framgia/fitm/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/framgia/fitm/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/framgia/fitm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/framgia/fitm/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/framgia/fitm/statuses/cac3ea6971e388ff5e28035e13a41d3f1e48ca72"}},"author_association":"CONTRIBUTOR"}} | {
"id": 118543442,
"name": "framgia/fitm",
"url": "https://api.github.com/repos/framgia/fitm"
} | {
"id": 21377118,
"login": "dothidiemthao",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21377118?",
"url": "https://api.github.com/users/dothidiemthao"
} | {
"id": 2322183,
"login": "framgia",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2322183?",
"url": "https://api.github.com/orgs/framgia"
} | 2018-02-27T09:29:07 | 7302366975 | {"actor":{"display_login":"dothidiemthao"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/framgia/Music_08/pulls/comments/185977014","pull_request_review_id":117478307,"id":185977014,"diff_hunk":"@@ -1,3 +1,15 @@\n <resources>\n <string name=\"app_name\">TMusic</string>\n+ <string name=\"title_activity_test\">TestActivity</string>\n+ <string name=\"navigation_drawer_open\">Open navigation drawer</string>\n+ <string name=\"navigation_drawer_close\">Close navigation drawer</string>\n+ <string name=\"nav_header_title\">Android Studio</string>\n+ <string name=\"nav_header_subtitle\">[email protected]</string>\n+ <string name=\"nav_header_desc\">Navigation header</string>\n+ <string name=\"action_settings\">Settings</string>\n+\n+ <string name=\"title_tab_home\">Trang chủ</string>","path":"app/src/main/res/values/strings.xml","position":11,"original_position":11,"commit_id":"fcd2c9e0b4445f06b526ceb170aa98abd777dc6b","original_commit_id":"fcd2c9e0b4445f06b526ceb170aa98abd777dc6b","user":{"login":"DoanVanToan","id":21195010,"avatar_url":"https://avatars3.githubusercontent.com/u/21195010?v=4","gravatar_id":"","url":"https://api.github.com/users/DoanVanToan","html_url":"https://github.com/DoanVanToan","followers_url":"https://api.github.com/users/DoanVanToan/followers","following_url":"https://api.github.com/users/DoanVanToan/following{/other_user}","gists_url":"https://api.github.com/users/DoanVanToan/gists{/gist_id}","starred_url":"https://api.github.com/users/DoanVanToan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoanVanToan/subscriptions","organizations_url":"https://api.github.com/users/DoanVanToan/orgs","repos_url":"https://api.github.com/users/DoanVanToan/repos","events_url":"https://api.github.com/users/DoanVanToan/events{/privacy}","received_events_url":"https://api.github.com/users/DoanVanToan/received_events","type":"User","site_admin":false},"body":"thống nhất 1 ngôn ngữ, muốn đang ngôn ngữ thì sử dụng các file values","created_at":"2018-05-04T01:40:27Z","updated_at":"2018-05-04T01:42:56Z","html_url":"https://github.com/framgia/Music_08/pull/4#discussion_r185977014","pull_request_url":"https://api.github.com/repos/framgia/Music_08/pulls/4","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/framgia/Music_08/pulls/comments/185977014"},"html":{"href":"https://github.com/framgia/Music_08/pull/4#discussion_r185977014"},"pull_request":{"href":"https://api.github.com/repos/framgia/Music_08/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/framgia/Music_08/pulls/4","id":185874770,"html_url":"https://github.com/framgia/Music_08/pull/4","diff_url":"https://github.com/framgia/Music_08/pull/4.diff","patch_url":"https://github.com/framgia/Music_08/pull/4.patch","issue_url":"https://api.github.com/repos/framgia/Music_08/issues/4","number":4,"state":"open","locked":false,"title":"init main","user":{"login":"ngocthai69","id":16415400,"avatar_url":"https://avatars2.githubusercontent.com/u/16415400?v=4","gravatar_id":"","url":"https://api.github.com/users/ngocthai69","html_url":"https://github.com/ngocthai69","followers_url":"https://api.github.com/users/ngocthai69/followers","following_url":"https://api.github.com/users/ngocthai69/following{/other_user}","gists_url":"https://api.github.com/users/ngocthai69/gists{/gist_id}","starred_url":"https://api.github.com/users/ngocthai69/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngocthai69/subscriptions","organizations_url":"https://api.github.com/users/ngocthai69/orgs","repos_url":"https://api.github.com/users/ngocthai69/repos","events_url":"https://api.github.com/users/ngocthai69/events{/privacy}","received_events_url":"https://api.github.com/users/ngocthai69/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-04T01:13:36Z","updated_at":"2018-05-04T01:42:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"460eada04b8093891fda2ce590ccb89e74c6ccc0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/framgia/Music_08/pulls/4/commits","review_comments_url":"https://api.github.com/repos/framgia/Music_08/pulls/4/comments","review_comment_url":"https://api.github.com/repos/framgia/Music_08/pulls/comments{/number}","comments_url":"https://api.github.com/repos/framgia/Music_08/issues/4/comments","statuses_url":"https://api.github.com/repos/framgia/Music_08/statuses/fcd2c9e0b4445f06b526ceb170aa98abd777dc6b","head":{"label":"ngocthai69:init_main","ref":"init_main","sha":"fcd2c9e0b4445f06b526ceb170aa98abd777dc6b","user":{"login":"ngocthai69","id":16415400,"avatar_url":"https://avatars2.githubusercontent.com/u/16415400?v=4","gravatar_id":"","url":"https://api.github.com/users/ngocthai69","html_url":"https://github.com/ngocthai69","followers_url":"https://api.github.com/users/ngocthai69/followers","following_url":"https://api.github.com/users/ngocthai69/following{/other_user}","gists_url":"https://api.github.com/users/ngocthai69/gists{/gist_id}","starred_url":"https://api.github.com/users/ngocthai69/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngocthai69/subscriptions","organizations_url":"https://api.github.com/users/ngocthai69/orgs","repos_url":"https://api.github.com/users/ngocthai69/repos","events_url":"https://api.github.com/users/ngocthai69/events{/privacy}","received_events_url":"https://api.github.com/users/ngocthai69/received_events","type":"User","site_admin":false},"repo":{"id":131789100,"name":"Music_08","full_name":"ngocthai69/Music_08","owner":{"login":"ngocthai69","id":16415400,"avatar_url":"https://avatars2.githubusercontent.com/u/16415400?v=4","gravatar_id":"","url":"https://api.github.com/users/ngocthai69","html_url":"https://github.com/ngocthai69","followers_url":"https://api.github.com/users/ngocthai69/followers","following_url":"https://api.github.com/users/ngocthai69/following{/other_user}","gists_url":"https://api.github.com/users/ngocthai69/gists{/gist_id}","starred_url":"https://api.github.com/users/ngocthai69/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngocthai69/subscriptions","organizations_url":"https://api.github.com/users/ngocthai69/orgs","repos_url":"https://api.github.com/users/ngocthai69/repos","events_url":"https://api.github.com/users/ngocthai69/events{/privacy}","received_events_url":"https://api.github.com/users/ngocthai69/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ngocthai69/Music_08","description":null,"fork":true,"url":"https://api.github.com/repos/ngocthai69/Music_08","forks_url":"https://api.github.com/repos/ngocthai69/Music_08/forks","keys_url":"https://api.github.com/repos/ngocthai69/Music_08/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ngocthai69/Music_08/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ngocthai69/Music_08/teams","hooks_url":"https://api.github.com/repos/ngocthai69/Music_08/hooks","issue_events_url":"https://api.github.com/repos/ngocthai69/Music_08/issues/events{/number}","events_url":"https://api.github.com/repos/ngocthai69/Music_08/events","assignees_url":"https://api.github.com/repos/ngocthai69/Music_08/assignees{/user}","branches_url":"https://api.github.com/repos/ngocthai69/Music_08/branches{/branch}","tags_url":"https://api.github.com/repos/ngocthai69/Music_08/tags","blobs_url":"https://api.github.com/repos/ngocthai69/Music_08/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ngocthai69/Music_08/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ngocthai69/Music_08/git/refs{/sha}","trees_url":"https://api.github.com/repos/ngocthai69/Music_08/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ngocthai69/Music_08/statuses/{sha}","languages_url":"https://api.github.com/repos/ngocthai69/Music_08/languages","stargazers_url":"https://api.github.com/repos/ngocthai69/Music_08/stargazers","contributors_url":"https://api.github.com/repos/ngocthai69/Music_08/contributors","subscribers_url":"https://api.github.com/repos/ngocthai69/Music_08/subscribers","subscription_url":"https://api.github.com/repos/ngocthai69/Music_08/subscription","commits_url":"https://api.github.com/repos/ngocthai69/Music_08/commits{/sha}","git_commits_url":"https://api.github.com/repos/ngocthai69/Music_08/git/commits{/sha}","comments_url":"https://api.github.com/repos/ngocthai69/Music_08/comments{/number}","issue_comment_url":"https://api.github.com/repos/ngocthai69/Music_08/issues/comments{/number}","contents_url":"https://api.github.com/repos/ngocthai69/Music_08/contents/{+path}","compare_url":"https://api.github.com/repos/ngocthai69/Music_08/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ngocthai69/Music_08/merges","archive_url":"https://api.github.com/repos/ngocthai69/Music_08/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ngocthai69/Music_08/downloads","issues_url":"https://api.github.com/repos/ngocthai69/Music_08/issues{/number}","pulls_url":"https://api.github.com/repos/ngocthai69/Music_08/pulls{/number}","milestones_url":"https://api.github.com/repos/ngocthai69/Music_08/milestones{/number}","notifications_url":"https://api.github.com/repos/ngocthai69/Music_08/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ngocthai69/Music_08/labels{/name}","releases_url":"https://api.github.com/repos/ngocthai69/Music_08/releases{/id}","deployments_url":"https://api.github.com/repos/ngocthai69/Music_08/deployments","created_at":"2018-05-02T02:44:37Z","updated_at":"2018-05-02T02:44:39Z","pushed_at":"2018-05-04T01:34:56Z","git_url":"git://github.com/ngocthai69/Music_08.git","ssh_url":"[email protected]:ngocthai69/Music_08.git","clone_url":"https://github.com/ngocthai69/Music_08.git","svn_url":"https://github.com/ngocthai69/Music_08","homepage":null,"size":258,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"framgia:develop","ref":"develop","sha":"04dd28d60fbde7bac858bfe0d741325f838d1c03","user":{"login":"framgia","id":2322183,"avatar_url":"https://avatars3.githubusercontent.com/u/2322183?v=4","gravatar_id":"","url":"https://api.github.com/users/framgia","html_url":"https://github.com/framgia","followers_url":"https://api.github.com/users/framgia/followers","following_url":"https://api.github.com/users/framgia/following{/other_user}","gists_url":"https://api.github.com/users/framgia/gists{/gist_id}","starred_url":"https://api.github.com/users/framgia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/framgia/subscriptions","organizations_url":"https://api.github.com/users/framgia/orgs","repos_url":"https://api.github.com/users/framgia/repos","events_url":"https://api.github.com/users/framgia/events{/privacy}","received_events_url":"https://api.github.com/users/framgia/received_events","type":"Organization","site_admin":false},"repo":{"id":131787759,"name":"Music_08","full_name":"framgia/Music_08","owner":{"login":"framgia","id":2322183,"avatar_url":"https://avatars3.githubusercontent.com/u/2322183?v=4","gravatar_id":"","url":"https://api.github.com/users/framgia","html_url":"https://github.com/framgia","followers_url":"https://api.github.com/users/framgia/followers","following_url":"https://api.github.com/users/framgia/following{/other_user}","gists_url":"https://api.github.com/users/framgia/gists{/gist_id}","starred_url":"https://api.github.com/users/framgia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/framgia/subscriptions","organizations_url":"https://api.github.com/users/framgia/orgs","repos_url":"https://api.github.com/users/framgia/repos","events_url":"https://api.github.com/users/framgia/events{/privacy}","received_events_url":"https://api.github.com/users/framgia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/framgia/Music_08","description":null,"fork":false,"url":"https://api.github.com/repos/framgia/Music_08","forks_url":"https://api.github.com/repos/framgia/Music_08/forks","keys_url":"https://api.github.com/repos/framgia/Music_08/keys{/key_id}","collaborators_url":"https://api.github.com/repos/framgia/Music_08/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/framgia/Music_08/teams","hooks_url":"https://api.github.com/repos/framgia/Music_08/hooks","issue_events_url":"https://api.github.com/repos/framgia/Music_08/issues/events{/number}","events_url":"https://api.github.com/repos/framgia/Music_08/events","assignees_url":"https://api.github.com/repos/framgia/Music_08/assignees{/user}","branches_url":"https://api.github.com/repos/framgia/Music_08/branches{/branch}","tags_url":"https://api.github.com/repos/framgia/Music_08/tags","blobs_url":"https://api.github.com/repos/framgia/Music_08/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/framgia/Music_08/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/framgia/Music_08/git/refs{/sha}","trees_url":"https://api.github.com/repos/framgia/Music_08/git/trees{/sha}","statuses_url":"https://api.github.com/repos/framgia/Music_08/statuses/{sha}","languages_url":"https://api.github.com/repos/framgia/Music_08/languages","stargazers_url":"https://api.github.com/repos/framgia/Music_08/stargazers","contributors_url":"https://api.github.com/repos/framgia/Music_08/contributors","subscribers_url":"https://api.github.com/repos/framgia/Music_08/subscribers","subscription_url":"https://api.github.com/repos/framgia/Music_08/subscription","commits_url":"https://api.github.com/repos/framgia/Music_08/commits{/sha}","git_commits_url":"https://api.github.com/repos/framgia/Music_08/git/commits{/sha}","comments_url":"https://api.github.com/repos/framgia/Music_08/comments{/number}","issue_comment_url":"https://api.github.com/repos/framgia/Music_08/issues/comments{/number}","contents_url":"https://api.github.com/repos/framgia/Music_08/contents/{+path}","compare_url":"https://api.github.com/repos/framgia/Music_08/compare/{base}...{head}","merges_url":"https://api.github.com/repos/framgia/Music_08/merges","archive_url":"https://api.github.com/repos/framgia/Music_08/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/framgia/Music_08/downloads","issues_url":"https://api.github.com/repos/framgia/Music_08/issues{/number}","pulls_url":"https://api.github.com/repos/framgia/Music_08/pulls{/number}","milestones_url":"https://api.github.com/repos/framgia/Music_08/milestones{/number}","notifications_url":"https://api.github.com/repos/framgia/Music_08/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/framgia/Music_08/labels{/name}","releases_url":"https://api.github.com/repos/framgia/Music_08/releases{/id}","deployments_url":"https://api.github.com/repos/framgia/Music_08/deployments","created_at":"2018-05-02T02:31:18Z","updated_at":"2018-05-03T09:09:42Z","pushed_at":"2018-05-04T01:34:57Z","git_url":"git://github.com/framgia/Music_08.git","ssh_url":"[email protected]:framgia/Music_08.git","clone_url":"https://github.com/framgia/Music_08.git","svn_url":"https://github.com/framgia/Music_08","homepage":null,"size":246,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/framgia/Music_08/pulls/4"},"html":{"href":"https://github.com/framgia/Music_08/pull/4"},"issue":{"href":"https://api.github.com/repos/framgia/Music_08/issues/4"},"comments":{"href":"https://api.github.com/repos/framgia/Music_08/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/framgia/Music_08/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/framgia/Music_08/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/framgia/Music_08/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/framgia/Music_08/statuses/fcd2c9e0b4445f06b526ceb170aa98abd777dc6b"}},"author_association":"NONE"}} | {
"id": 131787759,
"name": "framgia/Music_08",
"url": "https://api.github.com/repos/framgia/Music_08"
} | {
"id": 21195010,
"login": "DoanVanToan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21195010?",
"url": "https://api.github.com/users/DoanVanToan"
} | {
"id": 2322183,
"login": "framgia",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2322183?",
"url": "https://api.github.com/orgs/framgia"
} | 2018-05-04T01:40:27 | 7626197628 | {"actor":{"display_login":"DoanVanToan"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/framgia/Music_04/pulls/comments/186941103","pull_request_review_id":118618240,"id":186941103,"diff_hunk":"@@ -1,3 +1,12 @@\n Rails.application.routes.draw do\n root \"site_pages#index\"\n+\n+ get \"/signup\", to: \"users#new\"","path":"config/routes.rb","position":4,"original_position":4,"commit_id":"26ad3848f4c941b697d4e07ae89ada876d009b93","original_commit_id":"26ad3848f4c941b697d4e07ae89ada876d009b93","user":{"login":"hungnh103","id":22311747,"avatar_url":"https://avatars0.githubusercontent.com/u/22311747?v=4","gravatar_id":"","url":"https://api.github.com/users/hungnh103","html_url":"https://github.com/hungnh103","followers_url":"https://api.github.com/users/hungnh103/followers","following_url":"https://api.github.com/users/hungnh103/following{/other_user}","gists_url":"https://api.github.com/users/hungnh103/gists{/gist_id}","starred_url":"https://api.github.com/users/hungnh103/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hungnh103/subscriptions","organizations_url":"https://api.github.com/users/hungnh103/orgs","repos_url":"https://api.github.com/users/hungnh103/repos","events_url":"https://api.github.com/users/hungnh103/events{/privacy}","received_events_url":"https://api.github.com/users/hungnh103/received_events","type":"User","site_admin":false},"body":"thừa khoảng trắng","created_at":"2018-05-09T06:24:53Z","updated_at":"2018-05-09T06:25:38Z","html_url":"https://github.com/framgia/Music_04/pull/5#discussion_r186941103","pull_request_url":"https://api.github.com/repos/framgia/Music_04/pulls/5","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/framgia/Music_04/pulls/comments/186941103"},"html":{"href":"https://github.com/framgia/Music_04/pull/5#discussion_r186941103"},"pull_request":{"href":"https://api.github.com/repos/framgia/Music_04/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/framgia/Music_04/pulls/5","id":186805487,"html_url":"https://github.com/framgia/Music_04/pull/5","diff_url":"https://github.com/framgia/Music_04/pull/5.diff","patch_url":"https://github.com/framgia/Music_04/pull/5.patch","issue_url":"https://api.github.com/repos/framgia/Music_04/issues/5","number":5,"state":"open","locked":false,"title":"user sign up","user":{"login":"s2snowflakes","id":23006936,"avatar_url":"https://avatars0.githubusercontent.com/u/23006936?v=4","gravatar_id":"","url":"https://api.github.com/users/s2snowflakes","html_url":"https://github.com/s2snowflakes","followers_url":"https://api.github.com/users/s2snowflakes/followers","following_url":"https://api.github.com/users/s2snowflakes/following{/other_user}","gists_url":"https://api.github.com/users/s2snowflakes/gists{/gist_id}","starred_url":"https://api.github.com/users/s2snowflakes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s2snowflakes/subscriptions","organizations_url":"https://api.github.com/users/s2snowflakes/orgs","repos_url":"https://api.github.com/users/s2snowflakes/repos","events_url":"https://api.github.com/users/s2snowflakes/events{/privacy}","received_events_url":"https://api.github.com/users/s2snowflakes/received_events","type":"User","site_admin":false},"body":"\r\n","created_at":"2018-05-09T02:59:20Z","updated_at":"2018-05-09T06:25:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86665b6d2100b61f355f8ceb31b3cde654e2307e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/framgia/Music_04/pulls/5/commits","review_comments_url":"https://api.github.com/repos/framgia/Music_04/pulls/5/comments","review_comment_url":"https://api.github.com/repos/framgia/Music_04/pulls/comments{/number}","comments_url":"https://api.github.com/repos/framgia/Music_04/issues/5/comments","statuses_url":"https://api.github.com/repos/framgia/Music_04/statuses/26ad3848f4c941b697d4e07ae89ada876d009b93","head":{"label":"s2snowflakes:user_signup","ref":"user_signup","sha":"26ad3848f4c941b697d4e07ae89ada876d009b93","user":{"login":"s2snowflakes","id":23006936,"avatar_url":"https://avatars0.githubusercontent.com/u/23006936?v=4","gravatar_id":"","url":"https://api.github.com/users/s2snowflakes","html_url":"https://github.com/s2snowflakes","followers_url":"https://api.github.com/users/s2snowflakes/followers","following_url":"https://api.github.com/users/s2snowflakes/following{/other_user}","gists_url":"https://api.github.com/users/s2snowflakes/gists{/gist_id}","starred_url":"https://api.github.com/users/s2snowflakes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s2snowflakes/subscriptions","organizations_url":"https://api.github.com/users/s2snowflakes/orgs","repos_url":"https://api.github.com/users/s2snowflakes/repos","events_url":"https://api.github.com/users/s2snowflakes/events{/privacy}","received_events_url":"https://api.github.com/users/s2snowflakes/received_events","type":"User","site_admin":false},"repo":{"id":132565731,"name":"Music_04","full_name":"s2snowflakes/Music_04","owner":{"login":"s2snowflakes","id":23006936,"avatar_url":"https://avatars0.githubusercontent.com/u/23006936?v=4","gravatar_id":"","url":"https://api.github.com/users/s2snowflakes","html_url":"https://github.com/s2snowflakes","followers_url":"https://api.github.com/users/s2snowflakes/followers","following_url":"https://api.github.com/users/s2snowflakes/following{/other_user}","gists_url":"https://api.github.com/users/s2snowflakes/gists{/gist_id}","starred_url":"https://api.github.com/users/s2snowflakes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s2snowflakes/subscriptions","organizations_url":"https://api.github.com/users/s2snowflakes/orgs","repos_url":"https://api.github.com/users/s2snowflakes/repos","events_url":"https://api.github.com/users/s2snowflakes/events{/privacy}","received_events_url":"https://api.github.com/users/s2snowflakes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/s2snowflakes/Music_04","description":null,"fork":true,"url":"https://api.github.com/repos/s2snowflakes/Music_04","forks_url":"https://api.github.com/repos/s2snowflakes/Music_04/forks","keys_url":"https://api.github.com/repos/s2snowflakes/Music_04/keys{/key_id}","collaborators_url":"https://api.github.com/repos/s2snowflakes/Music_04/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/s2snowflakes/Music_04/teams","hooks_url":"https://api.github.com/repos/s2snowflakes/Music_04/hooks","issue_events_url":"https://api.github.com/repos/s2snowflakes/Music_04/issues/events{/number}","events_url":"https://api.github.com/repos/s2snowflakes/Music_04/events","assignees_url":"https://api.github.com/repos/s2snowflakes/Music_04/assignees{/user}","branches_url":"https://api.github.com/repos/s2snowflakes/Music_04/branches{/branch}","tags_url":"https://api.github.com/repos/s2snowflakes/Music_04/tags","blobs_url":"https://api.github.com/repos/s2snowflakes/Music_04/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/s2snowflakes/Music_04/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/s2snowflakes/Music_04/git/refs{/sha}","trees_url":"https://api.github.com/repos/s2snowflakes/Music_04/git/trees{/sha}","statuses_url":"https://api.github.com/repos/s2snowflakes/Music_04/statuses/{sha}","languages_url":"https://api.github.com/repos/s2snowflakes/Music_04/languages","stargazers_url":"https://api.github.com/repos/s2snowflakes/Music_04/stargazers","contributors_url":"https://api.github.com/repos/s2snowflakes/Music_04/contributors","subscribers_url":"https://api.github.com/repos/s2snowflakes/Music_04/subscribers","subscription_url":"https://api.github.com/repos/s2snowflakes/Music_04/subscription","commits_url":"https://api.github.com/repos/s2snowflakes/Music_04/commits{/sha}","git_commits_url":"https://api.github.com/repos/s2snowflakes/Music_04/git/commits{/sha}","comments_url":"https://api.github.com/repos/s2snowflakes/Music_04/comments{/number}","issue_comment_url":"https://api.github.com/repos/s2snowflakes/Music_04/issues/comments{/number}","contents_url":"https://api.github.com/repos/s2snowflakes/Music_04/contents/{+path}","compare_url":"https://api.github.com/repos/s2snowflakes/Music_04/compare/{base}...{head}","merges_url":"https://api.github.com/repos/s2snowflakes/Music_04/merges","archive_url":"https://api.github.com/repos/s2snowflakes/Music_04/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/s2snowflakes/Music_04/downloads","issues_url":"https://api.github.com/repos/s2snowflakes/Music_04/issues{/number}","pulls_url":"https://api.github.com/repos/s2snowflakes/Music_04/pulls{/number}","milestones_url":"https://api.github.com/repos/s2snowflakes/Music_04/milestones{/number}","notifications_url":"https://api.github.com/repos/s2snowflakes/Music_04/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/s2snowflakes/Music_04/labels{/name}","releases_url":"https://api.github.com/repos/s2snowflakes/Music_04/releases{/id}","deployments_url":"https://api.github.com/repos/s2snowflakes/Music_04/deployments","created_at":"2018-05-08T06:41:57Z","updated_at":"2018-05-08T06:41:59Z","pushed_at":"2018-05-09T03:01:33Z","git_url":"git://github.com/s2snowflakes/Music_04.git","ssh_url":"[email protected]:s2snowflakes/Music_04.git","clone_url":"https://github.com/s2snowflakes/Music_04.git","svn_url":"https://github.com/s2snowflakes/Music_04","homepage":null,"size":43,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"framgia:master","ref":"master","sha":"206a83c546fe5b35ddd77c4baa526a3facec11ef","user":{"login":"framgia","id":2322183,"avatar_url":"https://avatars3.githubusercontent.com/u/2322183?v=4","gravatar_id":"","url":"https://api.github.com/users/framgia","html_url":"https://github.com/framgia","followers_url":"https://api.github.com/users/framgia/followers","following_url":"https://api.github.com/users/framgia/following{/other_user}","gists_url":"https://api.github.com/users/framgia/gists{/gist_id}","starred_url":"https://api.github.com/users/framgia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/framgia/subscriptions","organizations_url":"https://api.github.com/users/framgia/orgs","repos_url":"https://api.github.com/users/framgia/repos","events_url":"https://api.github.com/users/framgia/events{/privacy}","received_events_url":"https://api.github.com/users/framgia/received_events","type":"Organization","site_admin":false},"repo":{"id":131780717,"name":"Music_04","full_name":"framgia/Music_04","owner":{"login":"framgia","id":2322183,"avatar_url":"https://avatars3.githubusercontent.com/u/2322183?v=4","gravatar_id":"","url":"https://api.github.com/users/framgia","html_url":"https://github.com/framgia","followers_url":"https://api.github.com/users/framgia/followers","following_url":"https://api.github.com/users/framgia/following{/other_user}","gists_url":"https://api.github.com/users/framgia/gists{/gist_id}","starred_url":"https://api.github.com/users/framgia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/framgia/subscriptions","organizations_url":"https://api.github.com/users/framgia/orgs","repos_url":"https://api.github.com/users/framgia/repos","events_url":"https://api.github.com/users/framgia/events{/privacy}","received_events_url":"https://api.github.com/users/framgia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/framgia/Music_04","description":null,"fork":false,"url":"https://api.github.com/repos/framgia/Music_04","forks_url":"https://api.github.com/repos/framgia/Music_04/forks","keys_url":"https://api.github.com/repos/framgia/Music_04/keys{/key_id}","collaborators_url":"https://api.github.com/repos/framgia/Music_04/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/framgia/Music_04/teams","hooks_url":"https://api.github.com/repos/framgia/Music_04/hooks","issue_events_url":"https://api.github.com/repos/framgia/Music_04/issues/events{/number}","events_url":"https://api.github.com/repos/framgia/Music_04/events","assignees_url":"https://api.github.com/repos/framgia/Music_04/assignees{/user}","branches_url":"https://api.github.com/repos/framgia/Music_04/branches{/branch}","tags_url":"https://api.github.com/repos/framgia/Music_04/tags","blobs_url":"https://api.github.com/repos/framgia/Music_04/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/framgia/Music_04/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/framgia/Music_04/git/refs{/sha}","trees_url":"https://api.github.com/repos/framgia/Music_04/git/trees{/sha}","statuses_url":"https://api.github.com/repos/framgia/Music_04/statuses/{sha}","languages_url":"https://api.github.com/repos/framgia/Music_04/languages","stargazers_url":"https://api.github.com/repos/framgia/Music_04/stargazers","contributors_url":"https://api.github.com/repos/framgia/Music_04/contributors","subscribers_url":"https://api.github.com/repos/framgia/Music_04/subscribers","subscription_url":"https://api.github.com/repos/framgia/Music_04/subscription","commits_url":"https://api.github.com/repos/framgia/Music_04/commits{/sha}","git_commits_url":"https://api.github.com/repos/framgia/Music_04/git/commits{/sha}","comments_url":"https://api.github.com/repos/framgia/Music_04/comments{/number}","issue_comment_url":"https://api.github.com/repos/framgia/Music_04/issues/comments{/number}","contents_url":"https://api.github.com/repos/framgia/Music_04/contents/{+path}","compare_url":"https://api.github.com/repos/framgia/Music_04/compare/{base}...{head}","merges_url":"https://api.github.com/repos/framgia/Music_04/merges","archive_url":"https://api.github.com/repos/framgia/Music_04/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/framgia/Music_04/downloads","issues_url":"https://api.github.com/repos/framgia/Music_04/issues{/number}","pulls_url":"https://api.github.com/repos/framgia/Music_04/pulls{/number}","milestones_url":"https://api.github.com/repos/framgia/Music_04/milestones{/number}","notifications_url":"https://api.github.com/repos/framgia/Music_04/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/framgia/Music_04/labels{/name}","releases_url":"https://api.github.com/repos/framgia/Music_04/releases{/id}","deployments_url":"https://api.github.com/repos/framgia/Music_04/deployments","created_at":"2018-05-02T01:14:38Z","updated_at":"2018-05-09T02:23:42Z","pushed_at":"2018-05-09T03:01:35Z","git_url":"git://github.com/framgia/Music_04.git","ssh_url":"[email protected]:framgia/Music_04.git","clone_url":"https://github.com/framgia/Music_04.git","svn_url":"https://github.com/framgia/Music_04","homepage":null,"size":41,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/framgia/Music_04/pulls/5"},"html":{"href":"https://github.com/framgia/Music_04/pull/5"},"issue":{"href":"https://api.github.com/repos/framgia/Music_04/issues/5"},"comments":{"href":"https://api.github.com/repos/framgia/Music_04/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/framgia/Music_04/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/framgia/Music_04/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/framgia/Music_04/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/framgia/Music_04/statuses/26ad3848f4c941b697d4e07ae89ada876d009b93"}},"author_association":"CONTRIBUTOR"}} | {
"id": 131780717,
"name": "framgia/Music_04",
"url": "https://api.github.com/repos/framgia/Music_04"
} | {
"id": 22311747,
"login": "hungnh103",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22311747?",
"url": "https://api.github.com/users/hungnh103"
} | {
"id": 2322183,
"login": "framgia",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2322183?",
"url": "https://api.github.com/orgs/framgia"
} | 2018-05-09T06:24:53 | 7647813125 | {"actor":{"display_login":"hungnh103"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/framgia/fashionOnline_01/pulls/comments/207094842","pull_request_review_id":142636586,"id":207094842,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzA5NDg0Mg==","diff_hunk":"@@ -0,0 +1,30 @@\n+/*price range*/\n+\n+ $('#sl2').slider();\n+\n+\tvar RGBChange = function() {\n+\t $('#RGB').css('background', 'rgb('+r.getValue()+','+g.getValue()+','+b.getValue()+')')\n+\t};\t\n+\t\t\n+/*scroll to top*/\n+\n+$(document).ready(function(){\n+\t$(function () {","path":"public/js/main.js","position":12,"original_position":12,"commit_id":"029648dd6a1864c7c7a52d11a44b22afdaceb86b","original_commit_id":"029648dd6a1864c7c7a52d11a44b22afdaceb86b","user":{"login":"BunnyPi04","id":32006118,"node_id":"MDQ6VXNlcjMyMDA2MTE4","avatar_url":"https://avatars2.githubusercontent.com/u/32006118?v=4","gravatar_id":"","url":"https://api.github.com/users/BunnyPi04","html_url":"https://github.com/BunnyPi04","followers_url":"https://api.github.com/users/BunnyPi04/followers","following_url":"https://api.github.com/users/BunnyPi04/following{/other_user}","gists_url":"https://api.github.com/users/BunnyPi04/gists{/gist_id}","starred_url":"https://api.github.com/users/BunnyPi04/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BunnyPi04/subscriptions","organizations_url":"https://api.github.com/users/BunnyPi04/orgs","repos_url":"https://api.github.com/users/BunnyPi04/repos","events_url":"https://api.github.com/users/BunnyPi04/events{/privacy}","received_events_url":"https://api.github.com/users/BunnyPi04/received_events","type":"User","site_admin":false},"body":"tab lại cả file","created_at":"2018-08-02T03:51:52Z","updated_at":"2018-08-02T03:53:38Z","html_url":"https://github.com/framgia/fashionOnline_01/pull/3#discussion_r207094842","pull_request_url":"https://api.github.com/repos/framgia/fashionOnline_01/pulls/3","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/framgia/fashionOnline_01/pulls/comments/207094842"},"html":{"href":"https://github.com/framgia/fashionOnline_01/pull/3#discussion_r207094842"},"pull_request":{"href":"https://api.github.com/repos/framgia/fashionOnline_01/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/framgia/fashionOnline_01/pulls/3","id":205608711,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NjA4NzEx","html_url":"https://github.com/framgia/fashionOnline_01/pull/3","diff_url":"https://github.com/framgia/fashionOnline_01/pull/3.diff","patch_url":"https://github.com/framgia/fashionOnline_01/pull/3.patch","issue_url":"https://api.github.com/repos/framgia/fashionOnline_01/issues/3","number":3,"state":"open","locked":false,"title":"add a template + change some layouts","user":{"login":"jamesnguyen259","id":31663158,"node_id":"MDQ6VXNlcjMxNjYzMTU4","avatar_url":"https://avatars0.githubusercontent.com/u/31663158?v=4","gravatar_id":"","url":"https://api.github.com/users/jamesnguyen259","html_url":"https://github.com/jamesnguyen259","followers_url":"https://api.github.com/users/jamesnguyen259/followers","following_url":"https://api.github.com/users/jamesnguyen259/following{/other_user}","gists_url":"https://api.github.com/users/jamesnguyen259/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesnguyen259/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesnguyen259/subscriptions","organizations_url":"https://api.github.com/users/jamesnguyen259/orgs","repos_url":"https://api.github.com/users/jamesnguyen259/repos","events_url":"https://api.github.com/users/jamesnguyen259/events{/privacy}","received_events_url":"https://api.github.com/users/jamesnguyen259/received_events","type":"User","site_admin":false},"body":"add layout","created_at":"2018-08-02T03:28:05Z","updated_at":"2018-08-02T03:53:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e4ef66136a74d20c3d0c7b1479b0d9e67da8e2e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/framgia/fashionOnline_01/pulls/3/commits","review_comments_url":"https://api.github.com/repos/framgia/fashionOnline_01/pulls/3/comments","review_comment_url":"https://api.github.com/repos/framgia/fashionOnline_01/pulls/comments{/number}","comments_url":"https://api.github.com/repos/framgia/fashionOnline_01/issues/3/comments","statuses_url":"https://api.github.com/repos/framgia/fashionOnline_01/statuses/029648dd6a1864c7c7a52d11a44b22afdaceb86b","head":{"label":"jamesnguyen259:template","ref":"template","sha":"029648dd6a1864c7c7a52d11a44b22afdaceb86b","user":{"login":"jamesnguyen259","id":31663158,"node_id":"MDQ6VXNlcjMxNjYzMTU4","avatar_url":"https://avatars0.githubusercontent.com/u/31663158?v=4","gravatar_id":"","url":"https://api.github.com/users/jamesnguyen259","html_url":"https://github.com/jamesnguyen259","followers_url":"https://api.github.com/users/jamesnguyen259/followers","following_url":"https://api.github.com/users/jamesnguyen259/following{/other_user}","gists_url":"https://api.github.com/users/jamesnguyen259/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesnguyen259/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesnguyen259/subscriptions","organizations_url":"https://api.github.com/users/jamesnguyen259/orgs","repos_url":"https://api.github.com/users/jamesnguyen259/repos","events_url":"https://api.github.com/users/jamesnguyen259/events{/privacy}","received_events_url":"https://api.github.com/users/jamesnguyen259/received_events","type":"User","site_admin":false},"repo":{"id":142981862,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI5ODE4NjI=","name":"fashionOnline_01","full_name":"jamesnguyen259/fashionOnline_01","owner":{"login":"jamesnguyen259","id":31663158,"node_id":"MDQ6VXNlcjMxNjYzMTU4","avatar_url":"https://avatars0.githubusercontent.com/u/31663158?v=4","gravatar_id":"","url":"https://api.github.com/users/jamesnguyen259","html_url":"https://github.com/jamesnguyen259","followers_url":"https://api.github.com/users/jamesnguyen259/followers","following_url":"https://api.github.com/users/jamesnguyen259/following{/other_user}","gists_url":"https://api.github.com/users/jamesnguyen259/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesnguyen259/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesnguyen259/subscriptions","organizations_url":"https://api.github.com/users/jamesnguyen259/orgs","repos_url":"https://api.github.com/users/jamesnguyen259/repos","events_url":"https://api.github.com/users/jamesnguyen259/events{/privacy}","received_events_url":"https://api.github.com/users/jamesnguyen259/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jamesnguyen259/fashionOnline_01","description":null,"fork":true,"url":"https://api.github.com/repos/jamesnguyen259/fashionOnline_01","forks_url":"https://api.github.com/repos/jamesnguyen259/fashionOnline_01/forks","keys_url":"https://api.github.com/repos/jamesnguyen259/fashionOnline_01/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jamesnguyen259/fashionOnline_01/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jamesnguyen259/fashionOnline_01/teams","hooks_url":"https://api.github.com/repos/jamesnguyen259/fashionOnline_01/hooks","issue_events_url":"https://api.github.com/repos/jamesnguyen259/fashionOnline_01/issues/events{/number}","events_url":"https://api.github.com/repos/jamesnguyen259/fashionOnline_01/events","assignees_url":"https://api.github.com/repos/jamesnguyen259/fashionOnline_01/assignees{/user}","branches_url":"https://api.github.com/repos/jamesnguyen259/fashionOnline_01/branches{/branch}","tags_url":"https://api.github.com/repos/jamesnguyen259/fashionOnline_01/tags","blobs_url":"https://api.github.com/repos/jamesnguyen259/fashionOnline_01/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jamesnguyen259/fashionOnline_01/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jamesnguyen259/fashionOnline_01/git/refs{/sha}","trees_url":"https://api.github.com/repos/jamesnguyen259/fashionOnline_01/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jamesnguyen259/fashionOnline_01/statuses/{sha}","languages_url":"https://api.github.com/repos/jamesnguyen259/fashionOnline_01/languages","stargazers_url":"https://api.github.com/repos/jamesnguyen259/fashionOnline_01/stargazers","contributors_url":"https://api.github.com/repos/jamesnguyen259/fashionOnline_01/contributors","subscribers_url":"https://api.github.com/repos/jamesnguyen259/fashionOnline_01/subscribers","subscription_url":"https://api.github.com/repos/jamesnguyen259/fashionOnline_01/subscription","commits_url":"https://api.github.com/repos/jamesnguyen259/fashionOnline_01/commits{/sha}","git_commits_url":"https://api.github.com/repos/jamesnguyen259/fashionOnline_01/git/commits{/sha}","comments_url":"https://api.github.com/repos/jamesnguyen259/fashionOnline_01/comments{/number}","issue_comment_url":"https://api.github.com/repos/jamesnguyen259/fashionOnline_01/issues/comments{/number}","contents_url":"https://api.github.com/repos/jamesnguyen259/fashionOnline_01/contents/{+path}","compare_url":"https://api.github.com/repos/jamesnguyen259/fashionOnline_01/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jamesnguyen259/fashionOnline_01/merges","archive_url":"https://api.github.com/repos/jamesnguyen259/fashionOnline_01/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jamesnguyen259/fashionOnline_01/downloads","issues_url":"https://api.github.com/repos/jamesnguyen259/fashionOnline_01/issues{/number}","pulls_url":"https://api.github.com/repos/jamesnguyen259/fashionOnline_01/pulls{/number}","milestones_url":"https://api.github.com/repos/jamesnguyen259/fashionOnline_01/milestones{/number}","notifications_url":"https://api.github.com/repos/jamesnguyen259/fashionOnline_01/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jamesnguyen259/fashionOnline_01/labels{/name}","releases_url":"https://api.github.com/repos/jamesnguyen259/fashionOnline_01/releases{/id}","deployments_url":"https://api.github.com/repos/jamesnguyen259/fashionOnline_01/deployments","created_at":"2018-07-31T07:58:09Z","updated_at":"2018-07-31T07:58:10Z","pushed_at":"2018-08-02T03:24:36Z","git_url":"git://github.com/jamesnguyen259/fashionOnline_01.git","ssh_url":"[email protected]:jamesnguyen259/fashionOnline_01.git","clone_url":"https://github.com/jamesnguyen259/fashionOnline_01.git","svn_url":"https://github.com/jamesnguyen259/fashionOnline_01","homepage":null,"size":168,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"framgia:develop","ref":"develop","sha":"c8919ecc2812b305a9bae72ad6f3af129c9a0a25","user":{"login":"framgia","id":2322183,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjIxODM=","avatar_url":"https://avatars3.githubusercontent.com/u/2322183?v=4","gravatar_id":"","url":"https://api.github.com/users/framgia","html_url":"https://github.com/framgia","followers_url":"https://api.github.com/users/framgia/followers","following_url":"https://api.github.com/users/framgia/following{/other_user}","gists_url":"https://api.github.com/users/framgia/gists{/gist_id}","starred_url":"https://api.github.com/users/framgia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/framgia/subscriptions","organizations_url":"https://api.github.com/users/framgia/orgs","repos_url":"https://api.github.com/users/framgia/repos","events_url":"https://api.github.com/users/framgia/events{/privacy}","received_events_url":"https://api.github.com/users/framgia/received_events","type":"Organization","site_admin":false},"repo":{"id":142093245,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIwOTMyNDU=","name":"fashionOnline_01","full_name":"framgia/fashionOnline_01","owner":{"login":"framgia","id":2322183,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjIxODM=","avatar_url":"https://avatars3.githubusercontent.com/u/2322183?v=4","gravatar_id":"","url":"https://api.github.com/users/framgia","html_url":"https://github.com/framgia","followers_url":"https://api.github.com/users/framgia/followers","following_url":"https://api.github.com/users/framgia/following{/other_user}","gists_url":"https://api.github.com/users/framgia/gists{/gist_id}","starred_url":"https://api.github.com/users/framgia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/framgia/subscriptions","organizations_url":"https://api.github.com/users/framgia/orgs","repos_url":"https://api.github.com/users/framgia/repos","events_url":"https://api.github.com/users/framgia/events{/privacy}","received_events_url":"https://api.github.com/users/framgia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/framgia/fashionOnline_01","description":null,"fork":false,"url":"https://api.github.com/repos/framgia/fashionOnline_01","forks_url":"https://api.github.com/repos/framgia/fashionOnline_01/forks","keys_url":"https://api.github.com/repos/framgia/fashionOnline_01/keys{/key_id}","collaborators_url":"https://api.github.com/repos/framgia/fashionOnline_01/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/framgia/fashionOnline_01/teams","hooks_url":"https://api.github.com/repos/framgia/fashionOnline_01/hooks","issue_events_url":"https://api.github.com/repos/framgia/fashionOnline_01/issues/events{/number}","events_url":"https://api.github.com/repos/framgia/fashionOnline_01/events","assignees_url":"https://api.github.com/repos/framgia/fashionOnline_01/assignees{/user}","branches_url":"https://api.github.com/repos/framgia/fashionOnline_01/branches{/branch}","tags_url":"https://api.github.com/repos/framgia/fashionOnline_01/tags","blobs_url":"https://api.github.com/repos/framgia/fashionOnline_01/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/framgia/fashionOnline_01/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/framgia/fashionOnline_01/git/refs{/sha}","trees_url":"https://api.github.com/repos/framgia/fashionOnline_01/git/trees{/sha}","statuses_url":"https://api.github.com/repos/framgia/fashionOnline_01/statuses/{sha}","languages_url":"https://api.github.com/repos/framgia/fashionOnline_01/languages","stargazers_url":"https://api.github.com/repos/framgia/fashionOnline_01/stargazers","contributors_url":"https://api.github.com/repos/framgia/fashionOnline_01/contributors","subscribers_url":"https://api.github.com/repos/framgia/fashionOnline_01/subscribers","subscription_url":"https://api.github.com/repos/framgia/fashionOnline_01/subscription","commits_url":"https://api.github.com/repos/framgia/fashionOnline_01/commits{/sha}","git_commits_url":"https://api.github.com/repos/framgia/fashionOnline_01/git/commits{/sha}","comments_url":"https://api.github.com/repos/framgia/fashionOnline_01/comments{/number}","issue_comment_url":"https://api.github.com/repos/framgia/fashionOnline_01/issues/comments{/number}","contents_url":"https://api.github.com/repos/framgia/fashionOnline_01/contents/{+path}","compare_url":"https://api.github.com/repos/framgia/fashionOnline_01/compare/{base}...{head}","merges_url":"https://api.github.com/repos/framgia/fashionOnline_01/merges","archive_url":"https://api.github.com/repos/framgia/fashionOnline_01/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/framgia/fashionOnline_01/downloads","issues_url":"https://api.github.com/repos/framgia/fashionOnline_01/issues{/number}","pulls_url":"https://api.github.com/repos/framgia/fashionOnline_01/pulls{/number}","milestones_url":"https://api.github.com/repos/framgia/fashionOnline_01/milestones{/number}","notifications_url":"https://api.github.com/repos/framgia/fashionOnline_01/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/framgia/fashionOnline_01/labels{/name}","releases_url":"https://api.github.com/repos/framgia/fashionOnline_01/releases{/id}","deployments_url":"https://api.github.com/repos/framgia/fashionOnline_01/deployments","created_at":"2018-07-24T02:24:00Z","updated_at":"2018-08-01T01:30:03Z","pushed_at":"2018-08-02T03:28:06Z","git_url":"git://github.com/framgia/fashionOnline_01.git","ssh_url":"[email protected]:framgia/fashionOnline_01.git","clone_url":"https://github.com/framgia/fashionOnline_01.git","svn_url":"https://github.com/framgia/fashionOnline_01","homepage":null,"size":169,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":3,"open_issues":2,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/framgia/fashionOnline_01/pulls/3"},"html":{"href":"https://github.com/framgia/fashionOnline_01/pull/3"},"issue":{"href":"https://api.github.com/repos/framgia/fashionOnline_01/issues/3"},"comments":{"href":"https://api.github.com/repos/framgia/fashionOnline_01/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/framgia/fashionOnline_01/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/framgia/fashionOnline_01/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/framgia/fashionOnline_01/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/framgia/fashionOnline_01/statuses/029648dd6a1864c7c7a52d11a44b22afdaceb86b"}},"author_association":"CONTRIBUTOR"}} | {
"id": 142093245,
"name": "framgia/fashionOnline_01",
"url": "https://api.github.com/repos/framgia/fashionOnline_01"
} | {
"id": 32006118,
"login": "BunnyPi04",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/32006118?",
"url": "https://api.github.com/users/BunnyPi04"
} | {
"id": 2322183,
"login": "framgia",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2322183?",
"url": "https://api.github.com/orgs/framgia"
} | 2018-08-02T03:51:52 | 8054220854 | {"actor":{"display_login":"BunnyPi04"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/framgia/club_management_01/pulls/comments/167465980","pull_request_review_id":95686801,"id":167465980,"diff_hunk":"@@ -85,4 +85,8 @@ def namespace\n def current_ability\n @current_ability ||= Ability.new current_user, namespace\n end\n+\n+ def key_money_event\n+ Event.event_categories.except(:money, :get_money_member, :donate, :subsidy).keys","path":"app/controllers/application_controller.rb","position":6,"original_position":6,"commit_id":"699d0b4c036fc32d773104878b2a2411f4912e0a","original_commit_id":"699d0b4c036fc32d773104878b2a2411f4912e0a","user":{"login":"nvtanh","id":5591946,"avatar_url":"https://avatars1.githubusercontent.com/u/5591946?v=4","gravatar_id":"","url":"https://api.github.com/users/nvtanh","html_url":"https://github.com/nvtanh","followers_url":"https://api.github.com/users/nvtanh/followers","following_url":"https://api.github.com/users/nvtanh/following{/other_user}","gists_url":"https://api.github.com/users/nvtanh/gists{/gist_id}","starred_url":"https://api.github.com/users/nvtanh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvtanh/subscriptions","organizations_url":"https://api.github.com/users/nvtanh/orgs","repos_url":"https://api.github.com/users/nvtanh/repos","events_url":"https://api.github.com/users/nvtanh/events{/privacy}","received_events_url":"https://api.github.com/users/nvtanh/received_events","type":"User","site_admin":false},"body":"hàm này e cho vào model event đi e","created_at":"2018-02-12T03:50:42Z","updated_at":"2018-02-12T03:50:42Z","html_url":"https://github.com/framgia/club_management_01/pull/345#discussion_r167465980","pull_request_url":"https://api.github.com/repos/framgia/club_management_01/pulls/345","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/framgia/club_management_01/pulls/comments/167465980"},"html":{"href":"https://github.com/framgia/club_management_01/pull/345#discussion_r167465980"},"pull_request":{"href":"https://api.github.com/repos/framgia/club_management_01/pulls/345"}}},"pull_request":{"url":"https://api.github.com/repos/framgia/club_management_01/pulls/345","id":168165320,"html_url":"https://github.com/framgia/club_management_01/pull/345","diff_url":"https://github.com/framgia/club_management_01/pull/345.diff","patch_url":"https://github.com/framgia/club_management_01/pull/345.patch","issue_url":"https://api.github.com/repos/framgia/club_management_01/issues/345","number":345,"state":"open","locked":false,"title":"Hoatdong event","user":{"login":"vannam1996","id":33271344,"avatar_url":"https://avatars0.githubusercontent.com/u/33271344?v=4","gravatar_id":"","url":"https://api.github.com/users/vannam1996","html_url":"https://github.com/vannam1996","followers_url":"https://api.github.com/users/vannam1996/followers","following_url":"https://api.github.com/users/vannam1996/following{/other_user}","gists_url":"https://api.github.com/users/vannam1996/gists{/gist_id}","starred_url":"https://api.github.com/users/vannam1996/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vannam1996/subscriptions","organizations_url":"https://api.github.com/users/vannam1996/orgs","repos_url":"https://api.github.com/users/vannam1996/repos","events_url":"https://api.github.com/users/vannam1996/events{/privacy}","received_events_url":"https://api.github.com/users/vannam1996/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-09T06:47:27Z","updated_at":"2018-02-12T03:50:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b8c80ce7bb2f3beae9159849bba2bcd618505d5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/framgia/club_management_01/pulls/345/commits","review_comments_url":"https://api.github.com/repos/framgia/club_management_01/pulls/345/comments","review_comment_url":"https://api.github.com/repos/framgia/club_management_01/pulls/comments{/number}","comments_url":"https://api.github.com/repos/framgia/club_management_01/issues/345/comments","statuses_url":"https://api.github.com/repos/framgia/club_management_01/statuses/699d0b4c036fc32d773104878b2a2411f4912e0a","head":{"label":"vannam1996:hoatdong-event","ref":"hoatdong-event","sha":"699d0b4c036fc32d773104878b2a2411f4912e0a","user":{"login":"vannam1996","id":33271344,"avatar_url":"https://avatars0.githubusercontent.com/u/33271344?v=4","gravatar_id":"","url":"https://api.github.com/users/vannam1996","html_url":"https://github.com/vannam1996","followers_url":"https://api.github.com/users/vannam1996/followers","following_url":"https://api.github.com/users/vannam1996/following{/other_user}","gists_url":"https://api.github.com/users/vannam1996/gists{/gist_id}","starred_url":"https://api.github.com/users/vannam1996/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vannam1996/subscriptions","organizations_url":"https://api.github.com/users/vannam1996/orgs","repos_url":"https://api.github.com/users/vannam1996/repos","events_url":"https://api.github.com/users/vannam1996/events{/privacy}","received_events_url":"https://api.github.com/users/vannam1996/received_events","type":"User","site_admin":false},"repo":{"id":115096736,"name":"club_management_01","full_name":"vannam1996/club_management_01","owner":{"login":"vannam1996","id":33271344,"avatar_url":"https://avatars0.githubusercontent.com/u/33271344?v=4","gravatar_id":"","url":"https://api.github.com/users/vannam1996","html_url":"https://github.com/vannam1996","followers_url":"https://api.github.com/users/vannam1996/followers","following_url":"https://api.github.com/users/vannam1996/following{/other_user}","gists_url":"https://api.github.com/users/vannam1996/gists{/gist_id}","starred_url":"https://api.github.com/users/vannam1996/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vannam1996/subscriptions","organizations_url":"https://api.github.com/users/vannam1996/orgs","repos_url":"https://api.github.com/users/vannam1996/repos","events_url":"https://api.github.com/users/vannam1996/events{/privacy}","received_events_url":"https://api.github.com/users/vannam1996/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vannam1996/club_management_01","description":null,"fork":true,"url":"https://api.github.com/repos/vannam1996/club_management_01","forks_url":"https://api.github.com/repos/vannam1996/club_management_01/forks","keys_url":"https://api.github.com/repos/vannam1996/club_management_01/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vannam1996/club_management_01/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vannam1996/club_management_01/teams","hooks_url":"https://api.github.com/repos/vannam1996/club_management_01/hooks","issue_events_url":"https://api.github.com/repos/vannam1996/club_management_01/issues/events{/number}","events_url":"https://api.github.com/repos/vannam1996/club_management_01/events","assignees_url":"https://api.github.com/repos/vannam1996/club_management_01/assignees{/user}","branches_url":"https://api.github.com/repos/vannam1996/club_management_01/branches{/branch}","tags_url":"https://api.github.com/repos/vannam1996/club_management_01/tags","blobs_url":"https://api.github.com/repos/vannam1996/club_management_01/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vannam1996/club_management_01/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vannam1996/club_management_01/git/refs{/sha}","trees_url":"https://api.github.com/repos/vannam1996/club_management_01/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vannam1996/club_management_01/statuses/{sha}","languages_url":"https://api.github.com/repos/vannam1996/club_management_01/languages","stargazers_url":"https://api.github.com/repos/vannam1996/club_management_01/stargazers","contributors_url":"https://api.github.com/repos/vannam1996/club_management_01/contributors","subscribers_url":"https://api.github.com/repos/vannam1996/club_management_01/subscribers","subscription_url":"https://api.github.com/repos/vannam1996/club_management_01/subscription","commits_url":"https://api.github.com/repos/vannam1996/club_management_01/commits{/sha}","git_commits_url":"https://api.github.com/repos/vannam1996/club_management_01/git/commits{/sha}","comments_url":"https://api.github.com/repos/vannam1996/club_management_01/comments{/number}","issue_comment_url":"https://api.github.com/repos/vannam1996/club_management_01/issues/comments{/number}","contents_url":"https://api.github.com/repos/vannam1996/club_management_01/contents/{+path}","compare_url":"https://api.github.com/repos/vannam1996/club_management_01/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vannam1996/club_management_01/merges","archive_url":"https://api.github.com/repos/vannam1996/club_management_01/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vannam1996/club_management_01/downloads","issues_url":"https://api.github.com/repos/vannam1996/club_management_01/issues{/number}","pulls_url":"https://api.github.com/repos/vannam1996/club_management_01/pulls{/number}","milestones_url":"https://api.github.com/repos/vannam1996/club_management_01/milestones{/number}","notifications_url":"https://api.github.com/repos/vannam1996/club_management_01/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vannam1996/club_management_01/labels{/name}","releases_url":"https://api.github.com/repos/vannam1996/club_management_01/releases{/id}","deployments_url":"https://api.github.com/repos/vannam1996/club_management_01/deployments","created_at":"2017-12-22T08:53:40Z","updated_at":"2017-12-22T08:53:42Z","pushed_at":"2018-02-12T02:06:47Z","git_url":"git://github.com/vannam1996/club_management_01.git","ssh_url":"[email protected]:vannam1996/club_management_01.git","clone_url":"https://github.com/vannam1996/club_management_01.git","svn_url":"https://github.com/vannam1996/club_management_01","homepage":null,"size":25517,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"new_develop"}},"base":{"label":"framgia:new_develop","ref":"new_develop","sha":"202fc6e1e3d5bb952b00a3c00eb70a236c6f19fe","user":{"login":"framgia","id":2322183,"avatar_url":"https://avatars3.githubusercontent.com/u/2322183?v=4","gravatar_id":"","url":"https://api.github.com/users/framgia","html_url":"https://github.com/framgia","followers_url":"https://api.github.com/users/framgia/followers","following_url":"https://api.github.com/users/framgia/following{/other_user}","gists_url":"https://api.github.com/users/framgia/gists{/gist_id}","starred_url":"https://api.github.com/users/framgia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/framgia/subscriptions","organizations_url":"https://api.github.com/users/framgia/orgs","repos_url":"https://api.github.com/users/framgia/repos","events_url":"https://api.github.com/users/framgia/events{/privacy}","received_events_url":"https://api.github.com/users/framgia/received_events","type":"Organization","site_admin":false},"repo":{"id":76230190,"name":"club_management_01","full_name":"framgia/club_management_01","owner":{"login":"framgia","id":2322183,"avatar_url":"https://avatars3.githubusercontent.com/u/2322183?v=4","gravatar_id":"","url":"https://api.github.com/users/framgia","html_url":"https://github.com/framgia","followers_url":"https://api.github.com/users/framgia/followers","following_url":"https://api.github.com/users/framgia/following{/other_user}","gists_url":"https://api.github.com/users/framgia/gists{/gist_id}","starred_url":"https://api.github.com/users/framgia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/framgia/subscriptions","organizations_url":"https://api.github.com/users/framgia/orgs","repos_url":"https://api.github.com/users/framgia/repos","events_url":"https://api.github.com/users/framgia/events{/privacy}","received_events_url":"https://api.github.com/users/framgia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/framgia/club_management_01","description":null,"fork":false,"url":"https://api.github.com/repos/framgia/club_management_01","forks_url":"https://api.github.com/repos/framgia/club_management_01/forks","keys_url":"https://api.github.com/repos/framgia/club_management_01/keys{/key_id}","collaborators_url":"https://api.github.com/repos/framgia/club_management_01/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/framgia/club_management_01/teams","hooks_url":"https://api.github.com/repos/framgia/club_management_01/hooks","issue_events_url":"https://api.github.com/repos/framgia/club_management_01/issues/events{/number}","events_url":"https://api.github.com/repos/framgia/club_management_01/events","assignees_url":"https://api.github.com/repos/framgia/club_management_01/assignees{/user}","branches_url":"https://api.github.com/repos/framgia/club_management_01/branches{/branch}","tags_url":"https://api.github.com/repos/framgia/club_management_01/tags","blobs_url":"https://api.github.com/repos/framgia/club_management_01/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/framgia/club_management_01/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/framgia/club_management_01/git/refs{/sha}","trees_url":"https://api.github.com/repos/framgia/club_management_01/git/trees{/sha}","statuses_url":"https://api.github.com/repos/framgia/club_management_01/statuses/{sha}","languages_url":"https://api.github.com/repos/framgia/club_management_01/languages","stargazers_url":"https://api.github.com/repos/framgia/club_management_01/stargazers","contributors_url":"https://api.github.com/repos/framgia/club_management_01/contributors","subscribers_url":"https://api.github.com/repos/framgia/club_management_01/subscribers","subscription_url":"https://api.github.com/repos/framgia/club_management_01/subscription","commits_url":"https://api.github.com/repos/framgia/club_management_01/commits{/sha}","git_commits_url":"https://api.github.com/repos/framgia/club_management_01/git/commits{/sha}","comments_url":"https://api.github.com/repos/framgia/club_management_01/comments{/number}","issue_comment_url":"https://api.github.com/repos/framgia/club_management_01/issues/comments{/number}","contents_url":"https://api.github.com/repos/framgia/club_management_01/contents/{+path}","compare_url":"https://api.github.com/repos/framgia/club_management_01/compare/{base}...{head}","merges_url":"https://api.github.com/repos/framgia/club_management_01/merges","archive_url":"https://api.github.com/repos/framgia/club_management_01/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/framgia/club_management_01/downloads","issues_url":"https://api.github.com/repos/framgia/club_management_01/issues{/number}","pulls_url":"https://api.github.com/repos/framgia/club_management_01/pulls{/number}","milestones_url":"https://api.github.com/repos/framgia/club_management_01/milestones{/number}","notifications_url":"https://api.github.com/repos/framgia/club_management_01/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/framgia/club_management_01/labels{/name}","releases_url":"https://api.github.com/repos/framgia/club_management_01/releases{/id}","deployments_url":"https://api.github.com/repos/framgia/club_management_01/deployments","created_at":"2016-12-12T06:56:07Z","updated_at":"2018-01-24T03:26:11Z","pushed_at":"2018-02-12T03:41:22Z","git_url":"git://github.com/framgia/club_management_01.git","ssh_url":"[email protected]:framgia/club_management_01.git","clone_url":"https://github.com/framgia/club_management_01.git","svn_url":"https://github.com/framgia/club_management_01","homepage":null,"size":25493,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":20,"license":null,"forks":13,"open_issues":20,"watchers":1,"default_branch":"new_develop"}},"_links":{"self":{"href":"https://api.github.com/repos/framgia/club_management_01/pulls/345"},"html":{"href":"https://github.com/framgia/club_management_01/pull/345"},"issue":{"href":"https://api.github.com/repos/framgia/club_management_01/issues/345"},"comments":{"href":"https://api.github.com/repos/framgia/club_management_01/issues/345/comments"},"review_comments":{"href":"https://api.github.com/repos/framgia/club_management_01/pulls/345/comments"},"review_comment":{"href":"https://api.github.com/repos/framgia/club_management_01/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/framgia/club_management_01/pulls/345/commits"},"statuses":{"href":"https://api.github.com/repos/framgia/club_management_01/statuses/699d0b4c036fc32d773104878b2a2411f4912e0a"}},"author_association":"CONTRIBUTOR"}} | {
"id": 76230190,
"name": "framgia/club_management_01",
"url": "https://api.github.com/repos/framgia/club_management_01"
} | {
"id": 5591946,
"login": "nvtanh",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5591946?",
"url": "https://api.github.com/users/nvtanh"
} | {
"id": 2322183,
"login": "framgia",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2322183?",
"url": "https://api.github.com/orgs/framgia"
} | 2018-02-12T03:50:42 | 7230297437 | {"actor":{"display_login":"nvtanh"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ros-planning/moveit_tutorials/pulls/comments/199353240","pull_request_review_id":133457844,"id":199353240,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTM1MzI0MA==","diff_hunk":"@@ -0,0 +1,221 @@\n+STOMP Planner\n+=============\n+\n+.. image:: stomp.png\n+ :width: 700px\n+\n+Stochastic Trajectory Optimization for Motion Planning (STOMP) is a novel probabilistic optimization framework (Kalakrishnan et al. 2011). STOMP Produces smooth well behaved collision free paths within reasonable times. The approach relies on generating noisy trajectories to explore the space around an initial (possibly infeasible) trajectory which are then combined o produce an updated trajectory with lower cost. A cost function based on a combination of obstacle and smoothness cost is optimized in each iteration. No gradient information is required for the particular optimization algorithm that we use and so general costs for which derivatives may not be available (e.g. costs corresponding to constraints and motor torques) can be included in the cost function. Some of the strengths of STOMP include, it can incorporate additional objective functions such as torque limits, energy and tool constraints. Stomp can handle cost functions which do not need to be differentiable. It uses distance field and spherical approximations to quickly compute distance queries and collision costs. Integration into latest version of MoveIt! is work in progress. `More info <https://personalrobotics.ri.cmu.edu/files/courses/papers/Kalakrishnan11-stomp.pdf>`_\n+\n+\n+\n+Getting Started\n+---------------\n+If you haven't already done so, make sure you've completed the steps in `Getting Started <../getting_started/getting_started.html>`_.\n+\n+You should also have gone through the steps in `Visualization with MoveIt! RViz Plugin <../quickstart_in_rviz/quickstart_in_rviz_tutorial.html>`_\n+\n+Prerequisites\n+-------------\n+ 1. You must have the latest version of MoveIt! installed. On ROS Kinetic you will need to build MoveIt! from source. A build from source is required as STOMP is not part of the official release yet. It is therefore not included in the binary packages. We will go through the steps for doing this below.\n+ 2. To use STOMP with your robot you must already have a MoveIt! configuration package for your robot already. For example, if you have a Panda robot, it's probably called ``panda_moveit_config``. This is typically built using the `MoveIt! Setup Assistant <../setup_assistant/setup_assistant_tutorial.html>`_.\n+ 3. You must also have built `ros-industrial/industrial_moveit package <https://github.com/ros-industrial/industrial_moveit>`_ from source. This needs to be built from source since industrial_moveit is not released as a debian yet. You only need to build the `stomp_core <https://github.com/ros-industrial/industrial_moveit/tree/kinetic-devel/stomp_core>`_ package from industrial_moveit as other packages are not required for the bare minimum functionality of STOMP with moveIt.\n+\n+Installing MoveIt! from Source\n+------------------------------\n+As you add and remove packages from your workspace you will need to clean your workspace and re-run the command to install new missing dependencies. Clean your workspace to remove references to the system wide installation of MoveIt!: ::\n+\n+ cd ~/ws_moveit/src\n+ catkin clean\n+\n+Now follow the instructions on the MoveIt! homepage for `installing MoveIt! Kinetic from source <http://moveit.ros.org/install/source/>`_. Note that you can skip the **Prerequisites** section since you should already have a Catkin workspace.\n+\n+Re-source the setup files: ::\n+\n+ source ~/ws_moveit/devel/setup.bash\n+\n+Using STOMP with Your Robot\n+---------------------------\n+**Note:** if you are following this demo using the ``panda_moveit_config`` from the `ros-planning/panda_moveit_config <https://github.com/ros-planning/panda_moveit_config>`_ repository, these steps are already done for you and you can skip steps 1-3 and you only need to do step 4.\n+\n+#. Simply download `stomp_planning_pipeline.launch.xml <https://github.com/ros-planning/panda_moveit_config/blob/master/launch/stomp_planning_pipeline.launch.xml>`_ file into the launch directory of your MoveIt! config package. In our case, we will save this file in the ``panda_moveit_config/launch`` directory. Place the file \"*stomp_planning_pipeline.launch.xml*\" file in the **launch** directory of your **moveit_config** package. The file should contain the following: ::\n+ \n+ <launch>\n+ <!-- Stomp Plugin for MoveIt! -->\n+ <arg name=\"planning_plugin\" value=\"stomp_moveit/StompPlannerManager\" />\n+\n+ <!-- The request adapters (plugins) ORDER MATTERS -->\n+ <arg name=\"planning_adapters\" value=\"default_planner_request_adapters/FixWorkspaceBounds\n+ default_planner_request_adapters/FixStartStateBounds\n+ default_planner_request_adapters/FixStartStateCollision\n+ default_planner_request_adapters/FixStartStatePathConstraints\" />\n+ <arg name=\"start_state_max_bounds_error\" value=\"0.1\" />\n+ <param name=\"planning_plugin\" value=\"$(arg planning_plugin)\" />\n+ <param name=\"request_adapters\" value=\"$(arg planning_adapters)\" />\n+ <param name=\"start_state_max_bounds_error\" value=\"$(arg start_state_max_bounds_error)\" />\n+ <rosparam command=\"load\" file=\"$(find panda_moveit_config)/config/stomp_planning.yaml\"/>\n+ </launch>\n+ \n+ \n+ **>** Take notice of the **stomp_planning.yaml** configuration file, this file must exists in moveit_config package.\n+\n+#. Adjust the line ``<rosparam command=\"load\" file=\"$(find panda_moveit_config)/config/stomp_planning.yaml\" />`` to ``<rosparam command=\"load\" file=\"$(find <robot_moveit_config>)/config/stomp_planning.yaml\" />`` replacing ``<robot_moveit_config>`` with the name of your MoveIt! configuration package.\n+#. Download `stomp_planning.yaml <https://github.com/ros-planning/panda_moveit_config/blob/master/config/stomp_planning.yaml>`_ file into the config directory of your MoveIt! config package. In our case, we will save this file in the ``panda_moveit_config/config`` directory. Create the \"*stomp_planning.yaml*\" configuration file. This file contains the parameters required by STOMP. The parameters are specific to each ''planning group'' defined in the SRDF file. So if there are three planning groups, then the configuration file defines a specific set of parameters for each planning group. In our case there is only one planning group, the \"panda_arm\": ::\n+\n+ stomp/manipulator_rail:\n+ group_name: panda_arm\n+ optimization:\n+ num_timesteps: 60\n+ num_iterations: 40\n+ num_iterations_after_valid: 0 \n+ num_rollouts: 30\n+ max_rollouts: 30 \n+ initialization_method: 1 #[1 : LINEAR_INTERPOLATION, 2 : CUBIC_POLYNOMIAL, 3 : MININUM_CONTROL_COST\n+ control_cost_weight: 0.0\n+ task:\n+ noise_generator:\n+ - class: stomp_moveit/NormalDistributionSampling\n+ stddev: [0.05, 0.8, 1.0, 0.8, 0.4, 0.4, 0.4]\n+ cost_functions:\n+ - class: stomp_moveit/CollisionCheck\n+ collision_penalty: 1.0\n+ cost_weight: 1.0\n+ kernel_window_percentage: 0.2\n+ longest_valid_joint_move: 0.05 \n+ noisy_filters:\n+ - class: stomp_moveit/JointLimits\n+ lock_start: True\n+ lock_goal: True\n+ - class: stomp_moveit/MultiTrajectoryVisualization\n+ line_width: 0.02\n+ rgb: [255, 255, 0]\n+ marker_array_topic: stomp_trajectories\n+ marker_namespace: noisy\n+ update_filters:\n+ - class: stomp_moveit/PolynomialSmoother\n+ poly_order: 6\n+ - class: stomp_moveit/TrajectoryVisualization\n+ line_width: 0.05\n+ rgb: [0, 191, 255]\n+ error_rgb: [255, 0, 0]\n+ publish_intermediate: True\n+ marker_topic: stomp_trajectory\n+ marker_namespace: optimized \n+ \n+ **>** *Save this file in the* **config** *directory of the moveit_config package*. Also make sure that the dimensionality of the `stddev` array parameter is the same as the number of joints present in the planning group name of your robot.\n+\n+#. Modify the **move_group.launch** file. Open the **move_group.launch** in the launch directory and change the ```pipeline``` parameter value to ```stomp``` as shown below: ::\n+\n+ .\n+ .\n+ .\n+ <!-- move_group settings -->\n+ <arg name=\"allow_trajectory_execution\" default=\"true\"/>\n+ <arg name=\"fake_execution\" default=\"false\"/>\n+ <arg name=\"max_safe_path_cost\" default=\"1\"/>\n+ <arg name=\"jiggle_fraction\" default=\"0.05\" />\n+ <arg name=\"publish_monitored_planning_scene\" default=\"true\"/>\n+\n+ <!-- Planning Functionality -->\n+ <include ns=\"move_group\" file=\"$(find myworkcell_moveit_config)/launch/planning_pipeline.launch.xml\">\n+ <arg name=\"pipeline\" value=\"stomp\" />\n+ </include>\n+\n+ .\n+ .\n+ .\n+ \n+\n+Running the Demo\n+----------------\n+If you have the ``panda_moveit_config`` from the `ros-planning/panda_moveit_config <https://github.com/ros-planning/panda_moveit_config>`_ repository you should be able to simply run the demo: ::\n+\n+ roslaunch panda_moveit_config demo.launch\n+\n+Running STOMP with Obstacles in the Scene\n++++++++++++++++++++++++++++++++++++++++++\n+To run STOMP in an evironment with obstacles, you can run the sample python script:\n+\n+ :codedir:`collision_scene_example.py<chomp_planner/scripts/collision_scene_example.py>`.\n+\n+This scripts creates a cluttered scene with four ostacles or a simple scene with one obstacle depending on the argument given to the script. One can also change the position/size of the obstacles to change the scene. \n+\n+To run the STOMP planner with obstacles, open two shells. In the first shell start RViz and wait for everything to finish loading: ::\n+\n+ roslaunch panda_moveit_config demo_stomp.launch\n+\n+In the second shell, run either of the two commands: ::\n+\n+ rosrun moveit_tutorials collision_scene_example.py cluttered\n+\n+or: ::\n+\n+ rosrun moveit_tutorials collision_scene_example.py sparse\n+\n+Next, in RViz, select STOMP in the MotionPlanning pannel under the Context tab. Set the desired start and goal states by moving the end-effector around with the imarker and then click on the Plan button under the Planning tab in the MotionPlanning pannel to start planning. The planner will now attempt to find a feasible solution between the given start and end position. STOMP performs better than CHOMP in avoiding obstacles. This is due to its stochastoc nature which produces non-jerky trajectories which are often produced by CHOMP to avoid obstacles\n+\n+Tweaking some of the parameters for STOMP","path":"doc/stomp_planner/stomp_planner_tutorial.rst","position":109,"original_position":156,"commit_id":"3f37617d64745732e312f9cf403624b2a0a2f39e","original_commit_id":"cc156db6bfa3c9644d6539df095d9657255915cd","user":{"login":"raghavendersahdev","id":5405862,"node_id":"MDQ6VXNlcjU0MDU4NjI=","avatar_url":"https://avatars1.githubusercontent.com/u/5405862?v=4","gravatar_id":"","url":"https://api.github.com/users/raghavendersahdev","html_url":"https://github.com/raghavendersahdev","followers_url":"https://api.github.com/users/raghavendersahdev/followers","following_url":"https://api.github.com/users/raghavendersahdev/following{/other_user}","gists_url":"https://api.github.com/users/raghavendersahdev/gists{/gist_id}","starred_url":"https://api.github.com/users/raghavendersahdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raghavendersahdev/subscriptions","organizations_url":"https://api.github.com/users/raghavendersahdev/orgs","repos_url":"https://api.github.com/users/raghavendersahdev/repos","events_url":"https://api.github.com/users/raghavendersahdev/events{/privacy}","received_events_url":"https://api.github.com/users/raghavendersahdev/received_events","type":"User","site_admin":false},"body":"thanks :-)","created_at":"2018-07-01T15:43:01Z","updated_at":"2018-07-01T15:43:01Z","html_url":"https://github.com/ros-planning/moveit_tutorials/pull/185#discussion_r199353240","pull_request_url":"https://api.github.com/repos/ros-planning/moveit_tutorials/pulls/185","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ros-planning/moveit_tutorials/pulls/comments/199353240"},"html":{"href":"https://github.com/ros-planning/moveit_tutorials/pull/185#discussion_r199353240"},"pull_request":{"href":"https://api.github.com/repos/ros-planning/moveit_tutorials/pulls/185"}},"in_reply_to_id":199285740},"pull_request":{"url":"https://api.github.com/repos/ros-planning/moveit_tutorials/pulls/185","id":198316355,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MzE2MzU1","html_url":"https://github.com/ros-planning/moveit_tutorials/pull/185","diff_url":"https://github.com/ros-planning/moveit_tutorials/pull/185.diff","patch_url":"https://github.com/ros-planning/moveit_tutorials/pull/185.patch","issue_url":"https://api.github.com/repos/ros-planning/moveit_tutorials/issues/185","number":185,"state":"open","locked":false,"title":"Added tutorial for STOMP Motion planner","user":{"login":"raghavendersahdev","id":5405862,"node_id":"MDQ6VXNlcjU0MDU4NjI=","avatar_url":"https://avatars1.githubusercontent.com/u/5405862?v=4","gravatar_id":"","url":"https://api.github.com/users/raghavendersahdev","html_url":"https://github.com/raghavendersahdev","followers_url":"https://api.github.com/users/raghavendersahdev/followers","following_url":"https://api.github.com/users/raghavendersahdev/following{/other_user}","gists_url":"https://api.github.com/users/raghavendersahdev/gists{/gist_id}","starred_url":"https://api.github.com/users/raghavendersahdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raghavendersahdev/subscriptions","organizations_url":"https://api.github.com/users/raghavendersahdev/orgs","repos_url":"https://api.github.com/users/raghavendersahdev/repos","events_url":"https://api.github.com/users/raghavendersahdev/events{/privacy}","received_events_url":"https://api.github.com/users/raghavendersahdev/received_events","type":"User","site_admin":false},"body":"This PR is a part of 2018 Google Summer of code work done by Raghavender Sahdev. This PR adds the following functionality:\r\n- tutorial for STOMP motion planner\r\n","created_at":"2018-06-29T13:23:59Z","updated_at":"2018-07-01T15:43:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"081d9a3fd4ade58b096bf9318370c2ea8785ece7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ros-planning/moveit_tutorials/pulls/185/commits","review_comments_url":"https://api.github.com/repos/ros-planning/moveit_tutorials/pulls/185/comments","review_comment_url":"https://api.github.com/repos/ros-planning/moveit_tutorials/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros-planning/moveit_tutorials/issues/185/comments","statuses_url":"https://api.github.com/repos/ros-planning/moveit_tutorials/statuses/3f37617d64745732e312f9cf403624b2a0a2f39e","head":{"label":"raghavendersahdev:kinetic-devel","ref":"kinetic-devel","sha":"3f37617d64745732e312f9cf403624b2a0a2f39e","user":{"login":"raghavendersahdev","id":5405862,"node_id":"MDQ6VXNlcjU0MDU4NjI=","avatar_url":"https://avatars1.githubusercontent.com/u/5405862?v=4","gravatar_id":"","url":"https://api.github.com/users/raghavendersahdev","html_url":"https://github.com/raghavendersahdev","followers_url":"https://api.github.com/users/raghavendersahdev/followers","following_url":"https://api.github.com/users/raghavendersahdev/following{/other_user}","gists_url":"https://api.github.com/users/raghavendersahdev/gists{/gist_id}","starred_url":"https://api.github.com/users/raghavendersahdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raghavendersahdev/subscriptions","organizations_url":"https://api.github.com/users/raghavendersahdev/orgs","repos_url":"https://api.github.com/users/raghavendersahdev/repos","events_url":"https://api.github.com/users/raghavendersahdev/events{/privacy}","received_events_url":"https://api.github.com/users/raghavendersahdev/received_events","type":"User","site_admin":false},"repo":{"id":139151822,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkxNTE4MjI=","name":"moveit_tutorials","full_name":"raghavendersahdev/moveit_tutorials","owner":{"login":"raghavendersahdev","id":5405862,"node_id":"MDQ6VXNlcjU0MDU4NjI=","avatar_url":"https://avatars1.githubusercontent.com/u/5405862?v=4","gravatar_id":"","url":"https://api.github.com/users/raghavendersahdev","html_url":"https://github.com/raghavendersahdev","followers_url":"https://api.github.com/users/raghavendersahdev/followers","following_url":"https://api.github.com/users/raghavendersahdev/following{/other_user}","gists_url":"https://api.github.com/users/raghavendersahdev/gists{/gist_id}","starred_url":"https://api.github.com/users/raghavendersahdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raghavendersahdev/subscriptions","organizations_url":"https://api.github.com/users/raghavendersahdev/orgs","repos_url":"https://api.github.com/users/raghavendersahdev/repos","events_url":"https://api.github.com/users/raghavendersahdev/events{/privacy}","received_events_url":"https://api.github.com/users/raghavendersahdev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/raghavendersahdev/moveit_tutorials","description":"A sphinx-based centralized documentation repo for MoveIt!","fork":true,"url":"https://api.github.com/repos/raghavendersahdev/moveit_tutorials","forks_url":"https://api.github.com/repos/raghavendersahdev/moveit_tutorials/forks","keys_url":"https://api.github.com/repos/raghavendersahdev/moveit_tutorials/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raghavendersahdev/moveit_tutorials/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raghavendersahdev/moveit_tutorials/teams","hooks_url":"https://api.github.com/repos/raghavendersahdev/moveit_tutorials/hooks","issue_events_url":"https://api.github.com/repos/raghavendersahdev/moveit_tutorials/issues/events{/number}","events_url":"https://api.github.com/repos/raghavendersahdev/moveit_tutorials/events","assignees_url":"https://api.github.com/repos/raghavendersahdev/moveit_tutorials/assignees{/user}","branches_url":"https://api.github.com/repos/raghavendersahdev/moveit_tutorials/branches{/branch}","tags_url":"https://api.github.com/repos/raghavendersahdev/moveit_tutorials/tags","blobs_url":"https://api.github.com/repos/raghavendersahdev/moveit_tutorials/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raghavendersahdev/moveit_tutorials/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raghavendersahdev/moveit_tutorials/git/refs{/sha}","trees_url":"https://api.github.com/repos/raghavendersahdev/moveit_tutorials/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raghavendersahdev/moveit_tutorials/statuses/{sha}","languages_url":"https://api.github.com/repos/raghavendersahdev/moveit_tutorials/languages","stargazers_url":"https://api.github.com/repos/raghavendersahdev/moveit_tutorials/stargazers","contributors_url":"https://api.github.com/repos/raghavendersahdev/moveit_tutorials/contributors","subscribers_url":"https://api.github.com/repos/raghavendersahdev/moveit_tutorials/subscribers","subscription_url":"https://api.github.com/repos/raghavendersahdev/moveit_tutorials/subscription","commits_url":"https://api.github.com/repos/raghavendersahdev/moveit_tutorials/commits{/sha}","git_commits_url":"https://api.github.com/repos/raghavendersahdev/moveit_tutorials/git/commits{/sha}","comments_url":"https://api.github.com/repos/raghavendersahdev/moveit_tutorials/comments{/number}","issue_comment_url":"https://api.github.com/repos/raghavendersahdev/moveit_tutorials/issues/comments{/number}","contents_url":"https://api.github.com/repos/raghavendersahdev/moveit_tutorials/contents/{+path}","compare_url":"https://api.github.com/repos/raghavendersahdev/moveit_tutorials/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raghavendersahdev/moveit_tutorials/merges","archive_url":"https://api.github.com/repos/raghavendersahdev/moveit_tutorials/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raghavendersahdev/moveit_tutorials/downloads","issues_url":"https://api.github.com/repos/raghavendersahdev/moveit_tutorials/issues{/number}","pulls_url":"https://api.github.com/repos/raghavendersahdev/moveit_tutorials/pulls{/number}","milestones_url":"https://api.github.com/repos/raghavendersahdev/moveit_tutorials/milestones{/number}","notifications_url":"https://api.github.com/repos/raghavendersahdev/moveit_tutorials/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raghavendersahdev/moveit_tutorials/labels{/name}","releases_url":"https://api.github.com/repos/raghavendersahdev/moveit_tutorials/releases{/id}","deployments_url":"https://api.github.com/repos/raghavendersahdev/moveit_tutorials/deployments","created_at":"2018-06-29T13:18:51Z","updated_at":"2018-07-01T14:30:20Z","pushed_at":"2018-07-01T14:30:18Z","git_url":"git://github.com/raghavendersahdev/moveit_tutorials.git","ssh_url":"[email protected]:raghavendersahdev/moveit_tutorials.git","clone_url":"https://github.com/raghavendersahdev/moveit_tutorials.git","svn_url":"https://github.com/raghavendersahdev/moveit_tutorials","homepage":"http://docs.ros.org/kinetic/api/moveit_tutorials/html/","size":19183,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"kinetic-devel"}},"base":{"label":"ros-planning:kinetic-devel","ref":"kinetic-devel","sha":"3d270a7fa9b1e153a3f9d478da385d4089db69a9","user":{"login":"ros-planning","id":2328631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjg2MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/2328631?v=4","gravatar_id":"","url":"https://api.github.com/users/ros-planning","html_url":"https://github.com/ros-planning","followers_url":"https://api.github.com/users/ros-planning/followers","following_url":"https://api.github.com/users/ros-planning/following{/other_user}","gists_url":"https://api.github.com/users/ros-planning/gists{/gist_id}","starred_url":"https://api.github.com/users/ros-planning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros-planning/subscriptions","organizations_url":"https://api.github.com/users/ros-planning/orgs","repos_url":"https://api.github.com/users/ros-planning/repos","events_url":"https://api.github.com/users/ros-planning/events{/privacy}","received_events_url":"https://api.github.com/users/ros-planning/received_events","type":"Organization","site_admin":false},"repo":{"id":66317561,"node_id":"MDEwOlJlcG9zaXRvcnk2NjMxNzU2MQ==","name":"moveit_tutorials","full_name":"ros-planning/moveit_tutorials","owner":{"login":"ros-planning","id":2328631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjg2MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/2328631?v=4","gravatar_id":"","url":"https://api.github.com/users/ros-planning","html_url":"https://github.com/ros-planning","followers_url":"https://api.github.com/users/ros-planning/followers","following_url":"https://api.github.com/users/ros-planning/following{/other_user}","gists_url":"https://api.github.com/users/ros-planning/gists{/gist_id}","starred_url":"https://api.github.com/users/ros-planning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros-planning/subscriptions","organizations_url":"https://api.github.com/users/ros-planning/orgs","repos_url":"https://api.github.com/users/ros-planning/repos","events_url":"https://api.github.com/users/ros-planning/events{/privacy}","received_events_url":"https://api.github.com/users/ros-planning/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros-planning/moveit_tutorials","description":"A sphinx-based centralized documentation repo for MoveIt!","fork":false,"url":"https://api.github.com/repos/ros-planning/moveit_tutorials","forks_url":"https://api.github.com/repos/ros-planning/moveit_tutorials/forks","keys_url":"https://api.github.com/repos/ros-planning/moveit_tutorials/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros-planning/moveit_tutorials/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros-planning/moveit_tutorials/teams","hooks_url":"https://api.github.com/repos/ros-planning/moveit_tutorials/hooks","issue_events_url":"https://api.github.com/repos/ros-planning/moveit_tutorials/issues/events{/number}","events_url":"https://api.github.com/repos/ros-planning/moveit_tutorials/events","assignees_url":"https://api.github.com/repos/ros-planning/moveit_tutorials/assignees{/user}","branches_url":"https://api.github.com/repos/ros-planning/moveit_tutorials/branches{/branch}","tags_url":"https://api.github.com/repos/ros-planning/moveit_tutorials/tags","blobs_url":"https://api.github.com/repos/ros-planning/moveit_tutorials/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros-planning/moveit_tutorials/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros-planning/moveit_tutorials/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros-planning/moveit_tutorials/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros-planning/moveit_tutorials/statuses/{sha}","languages_url":"https://api.github.com/repos/ros-planning/moveit_tutorials/languages","stargazers_url":"https://api.github.com/repos/ros-planning/moveit_tutorials/stargazers","contributors_url":"https://api.github.com/repos/ros-planning/moveit_tutorials/contributors","subscribers_url":"https://api.github.com/repos/ros-planning/moveit_tutorials/subscribers","subscription_url":"https://api.github.com/repos/ros-planning/moveit_tutorials/subscription","commits_url":"https://api.github.com/repos/ros-planning/moveit_tutorials/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros-planning/moveit_tutorials/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros-planning/moveit_tutorials/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros-planning/moveit_tutorials/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros-planning/moveit_tutorials/contents/{+path}","compare_url":"https://api.github.com/repos/ros-planning/moveit_tutorials/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros-planning/moveit_tutorials/merges","archive_url":"https://api.github.com/repos/ros-planning/moveit_tutorials/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros-planning/moveit_tutorials/downloads","issues_url":"https://api.github.com/repos/ros-planning/moveit_tutorials/issues{/number}","pulls_url":"https://api.github.com/repos/ros-planning/moveit_tutorials/pulls{/number}","milestones_url":"https://api.github.com/repos/ros-planning/moveit_tutorials/milestones{/number}","notifications_url":"https://api.github.com/repos/ros-planning/moveit_tutorials/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros-planning/moveit_tutorials/labels{/name}","releases_url":"https://api.github.com/repos/ros-planning/moveit_tutorials/releases{/id}","deployments_url":"https://api.github.com/repos/ros-planning/moveit_tutorials/deployments","created_at":"2016-08-23T00:12:38Z","updated_at":"2018-06-27T21:16:04Z","pushed_at":"2018-07-01T14:30:20Z","git_url":"git://github.com/ros-planning/moveit_tutorials.git","ssh_url":"[email protected]:ros-planning/moveit_tutorials.git","clone_url":"https://github.com/ros-planning/moveit_tutorials.git","svn_url":"https://github.com/ros-planning/moveit_tutorials","homepage":"http://docs.ros.org/kinetic/api/moveit_tutorials/html/","size":18877,"stargazers_count":70,"watchers_count":70,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":148,"mirror_url":null,"archived":false,"open_issues_count":30,"license":null,"forks":148,"open_issues":30,"watchers":70,"default_branch":"kinetic-devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ros-planning/moveit_tutorials/pulls/185"},"html":{"href":"https://github.com/ros-planning/moveit_tutorials/pull/185"},"issue":{"href":"https://api.github.com/repos/ros-planning/moveit_tutorials/issues/185"},"comments":{"href":"https://api.github.com/repos/ros-planning/moveit_tutorials/issues/185/comments"},"review_comments":{"href":"https://api.github.com/repos/ros-planning/moveit_tutorials/pulls/185/comments"},"review_comment":{"href":"https://api.github.com/repos/ros-planning/moveit_tutorials/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros-planning/moveit_tutorials/pulls/185/commits"},"statuses":{"href":"https://api.github.com/repos/ros-planning/moveit_tutorials/statuses/3f37617d64745732e312f9cf403624b2a0a2f39e"}},"author_association":"CONTRIBUTOR"}} | {
"id": 66317561,
"name": "ros-planning/moveit_tutorials",
"url": "https://api.github.com/repos/ros-planning/moveit_tutorials"
} | {
"id": 5405862,
"login": "raghavendersahdev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5405862?",
"url": "https://api.github.com/users/raghavendersahdev"
} | {
"id": 2328631,
"login": "ros-planning",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2328631?",
"url": "https://api.github.com/orgs/ros-planning"
} | 2018-07-01T15:43:01 | 7903235302 | {"actor":{"display_login":"raghavendersahdev"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/codice/ddf/pulls/comments/242362799","pull_request_review_id":185853080,"id":242362799,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjM2Mjc5OQ==","diff_hunk":"@@ -77,7 +78,8 @@ public void process(Exchange exchange) throws Exception {\n }\n }\n \n- private MetacardTransformer lookupTransformerReference(String metacardTransformerId) {\n+ @VisibleForTesting\n+ MetacardTransformer lookupTransformerReference(String metacardTransformerId) {\n Bundle bundle = FrameworkUtil.getBundle(this.getClass());","path":"catalog/core/catalog-core-camelcomponent/src/main/java/ddf/camel/component/catalog/metacardtransformer/MetacardTransformerProducer.java","position":15,"original_position":15,"commit_id":"11c488b1fb38cf9d577000b059f4453d22bf4745","original_commit_id":"11c488b1fb38cf9d577000b059f4453d22bf4745","user":{"login":"lessarderic","id":11377558,"node_id":"MDQ6VXNlcjExMzc3NTU4","avatar_url":"https://avatars1.githubusercontent.com/u/11377558?v=4","gravatar_id":"","url":"https://api.github.com/users/lessarderic","html_url":"https://github.com/lessarderic","followers_url":"https://api.github.com/users/lessarderic/followers","following_url":"https://api.github.com/users/lessarderic/following{/other_user}","gists_url":"https://api.github.com/users/lessarderic/gists{/gist_id}","starred_url":"https://api.github.com/users/lessarderic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lessarderic/subscriptions","organizations_url":"https://api.github.com/users/lessarderic/orgs","repos_url":"https://api.github.com/users/lessarderic/repos","events_url":"https://api.github.com/users/lessarderic/events{/privacy}","received_events_url":"https://api.github.com/users/lessarderic/received_events","type":"User","site_admin":false},"body":"❓Should we inject a `Function<Class<T>, Bundle> bundleLookup` and use `bundleLookup.apply(this.getClass())` here instead of making the whole method `@VisibleForTesting` and having to change its visibility? This would also help not decrease the code coverage.","created_at":"2018-12-18T00:00:29Z","updated_at":"2018-12-18T00:44:43Z","html_url":"https://github.com/codice/ddf/pull/4141#discussion_r242362799","pull_request_url":"https://api.github.com/repos/codice/ddf/pulls/4141","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments/242362799"},"html":{"href":"https://github.com/codice/ddf/pull/4141#discussion_r242362799"},"pull_request":{"href":"https://api.github.com/repos/codice/ddf/pulls/4141"}}},"pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/4141","id":238549214,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NTQ5MjE0","html_url":"https://github.com/codice/ddf/pull/4141","diff_url":"https://github.com/codice/ddf/pull/4141.diff","patch_url":"https://github.com/codice/ddf/pull/4141.patch","issue_url":"https://api.github.com/repos/codice/ddf/issues/4141","number":4141,"state":"open","locked":false,"title":"DDF-4403 Remove PowerMock to support Java11","user":{"login":"brjeter","id":8130140,"node_id":"MDQ6VXNlcjgxMzAxNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/8130140?v=4","gravatar_id":"","url":"https://api.github.com/users/brjeter","html_url":"https://github.com/brjeter","followers_url":"https://api.github.com/users/brjeter/followers","following_url":"https://api.github.com/users/brjeter/following{/other_user}","gists_url":"https://api.github.com/users/brjeter/gists{/gist_id}","starred_url":"https://api.github.com/users/brjeter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brjeter/subscriptions","organizations_url":"https://api.github.com/users/brjeter/orgs","repos_url":"https://api.github.com/users/brjeter/repos","events_url":"https://api.github.com/users/brjeter/events{/privacy}","received_events_url":"https://api.github.com/users/brjeter/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\nRefactors classes to allow for Mockito spying and method stubbing instead of using PowerMock.\r\n\r\n#### Who is reviewing it? \r\n@blen-desta @paouelle \r\n#### Select relevant component teams: \r\n@codice/test \r\n#### Ask 2 committers to review/merge the PR and tag them here.\r\n@coyotesqrl \r\n@lessarderic \r\n#### How should this be tested?\r\n#### Any background context you want to provide?\r\n#### What are the relevant tickets?\r\n[DDF-4403](https://codice.atlassian.net/browse/DDF-4403)\r\n#### Screenshots\r\n<!--(if appropriate)-->\r\n#### Checklist:\r\n- [ ] Documentation Updated\r\n- [X] Update / Add Unit Tests\r\n- [ ] Update / Add Integration Tests\r\n\r\n#### Notes on Review Process\r\nPlease see [Notes on Review Process](https://codice.atlassian.net/wiki/spaces/DDF/pages/71946981/Pull+Request+Guidelines) for further guidance on requirements for merging and abbreviated reviews. \r\n\r\n#### Review Comment Legend:\r\n- ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist. \r\n- ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.\r\n- ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.\r\n","created_at":"2018-12-13T22:12:22Z","updated_at":"2018-12-18T00:44:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b3b1671471effc28f5e5c0c4277700a8613131ea","assignee":{"login":"coyotesqrl","id":1469860,"node_id":"MDQ6VXNlcjE0Njk4NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/1469860?v=4","gravatar_id":"","url":"https://api.github.com/users/coyotesqrl","html_url":"https://github.com/coyotesqrl","followers_url":"https://api.github.com/users/coyotesqrl/followers","following_url":"https://api.github.com/users/coyotesqrl/following{/other_user}","gists_url":"https://api.github.com/users/coyotesqrl/gists{/gist_id}","starred_url":"https://api.github.com/users/coyotesqrl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coyotesqrl/subscriptions","organizations_url":"https://api.github.com/users/coyotesqrl/orgs","repos_url":"https://api.github.com/users/coyotesqrl/repos","events_url":"https://api.github.com/users/coyotesqrl/events{/privacy}","received_events_url":"https://api.github.com/users/coyotesqrl/received_events","type":"User","site_admin":false},"assignees":[{"login":"coyotesqrl","id":1469860,"node_id":"MDQ6VXNlcjE0Njk4NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/1469860?v=4","gravatar_id":"","url":"https://api.github.com/users/coyotesqrl","html_url":"https://github.com/coyotesqrl","followers_url":"https://api.github.com/users/coyotesqrl/followers","following_url":"https://api.github.com/users/coyotesqrl/following{/other_user}","gists_url":"https://api.github.com/users/coyotesqrl/gists{/gist_id}","starred_url":"https://api.github.com/users/coyotesqrl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coyotesqrl/subscriptions","organizations_url":"https://api.github.com/users/coyotesqrl/orgs","repos_url":"https://api.github.com/users/coyotesqrl/repos","events_url":"https://api.github.com/users/coyotesqrl/events{/privacy}","received_events_url":"https://api.github.com/users/coyotesqrl/received_events","type":"User","site_admin":false},{"login":"lessarderic","id":11377558,"node_id":"MDQ6VXNlcjExMzc3NTU4","avatar_url":"https://avatars1.githubusercontent.com/u/11377558?v=4","gravatar_id":"","url":"https://api.github.com/users/lessarderic","html_url":"https://github.com/lessarderic","followers_url":"https://api.github.com/users/lessarderic/followers","following_url":"https://api.github.com/users/lessarderic/following{/other_user}","gists_url":"https://api.github.com/users/lessarderic/gists{/gist_id}","starred_url":"https://api.github.com/users/lessarderic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lessarderic/subscriptions","organizations_url":"https://api.github.com/users/lessarderic/orgs","repos_url":"https://api.github.com/users/lessarderic/repos","events_url":"https://api.github.com/users/lessarderic/events{/privacy}","received_events_url":"https://api.github.com/users/lessarderic/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"stustison","id":4391679,"node_id":"MDQ6VXNlcjQzOTE2Nzk=","avatar_url":"https://avatars0.githubusercontent.com/u/4391679?v=4","gravatar_id":"","url":"https://api.github.com/users/stustison","html_url":"https://github.com/stustison","followers_url":"https://api.github.com/users/stustison/followers","following_url":"https://api.github.com/users/stustison/following{/other_user}","gists_url":"https://api.github.com/users/stustison/gists{/gist_id}","starred_url":"https://api.github.com/users/stustison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stustison/subscriptions","organizations_url":"https://api.github.com/users/stustison/orgs","repos_url":"https://api.github.com/users/stustison/repos","events_url":"https://api.github.com/users/stustison/events{/privacy}","received_events_url":"https://api.github.com/users/stustison/received_events","type":"User","site_admin":false},{"login":"rzwiefel","id":9013416,"node_id":"MDQ6VXNlcjkwMTM0MTY=","avatar_url":"https://avatars0.githubusercontent.com/u/9013416?v=4","gravatar_id":"","url":"https://api.github.com/users/rzwiefel","html_url":"https://github.com/rzwiefel","followers_url":"https://api.github.com/users/rzwiefel/followers","following_url":"https://api.github.com/users/rzwiefel/following{/other_user}","gists_url":"https://api.github.com/users/rzwiefel/gists{/gist_id}","starred_url":"https://api.github.com/users/rzwiefel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rzwiefel/subscriptions","organizations_url":"https://api.github.com/users/rzwiefel/orgs","repos_url":"https://api.github.com/users/rzwiefel/repos","events_url":"https://api.github.com/users/rzwiefel/events{/privacy}","received_events_url":"https://api.github.com/users/rzwiefel/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1089005428,"node_id":"MDU6TGFiZWwxMDg5MDA1NDI4","url":"https://api.github.com/repos/codice/ddf/labels/%E2%98%95%20J11%20Upgrade","name":"☕ J11 Upgrade","color":"7bfc97","default":false},{"id":1119782270,"node_id":"MDU6TGFiZWwxMTE5NzgyMjcw","url":"https://api.github.com/repos/codice/ddf/labels/%F0%9F%93%88%20Improvement","name":"📈 Improvement","color":"726FD7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/codice/ddf/pulls/4141/commits","review_comments_url":"https://api.github.com/repos/codice/ddf/pulls/4141/comments","review_comment_url":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codice/ddf/issues/4141/comments","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/11c488b1fb38cf9d577000b059f4453d22bf4745","head":{"label":"brjeter:DDF-4403","ref":"DDF-4403","sha":"11c488b1fb38cf9d577000b059f4453d22bf4745","user":{"login":"brjeter","id":8130140,"node_id":"MDQ6VXNlcjgxMzAxNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/8130140?v=4","gravatar_id":"","url":"https://api.github.com/users/brjeter","html_url":"https://github.com/brjeter","followers_url":"https://api.github.com/users/brjeter/followers","following_url":"https://api.github.com/users/brjeter/following{/other_user}","gists_url":"https://api.github.com/users/brjeter/gists{/gist_id}","starred_url":"https://api.github.com/users/brjeter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brjeter/subscriptions","organizations_url":"https://api.github.com/users/brjeter/orgs","repos_url":"https://api.github.com/users/brjeter/repos","events_url":"https://api.github.com/users/brjeter/events{/privacy}","received_events_url":"https://api.github.com/users/brjeter/received_events","type":"User","site_admin":false},"repo":{"id":70073166,"node_id":"MDEwOlJlcG9zaXRvcnk3MDA3MzE2Ng==","name":"ddf","full_name":"brjeter/ddf","private":false,"owner":{"login":"brjeter","id":8130140,"node_id":"MDQ6VXNlcjgxMzAxNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/8130140?v=4","gravatar_id":"","url":"https://api.github.com/users/brjeter","html_url":"https://github.com/brjeter","followers_url":"https://api.github.com/users/brjeter/followers","following_url":"https://api.github.com/users/brjeter/following{/other_user}","gists_url":"https://api.github.com/users/brjeter/gists{/gist_id}","starred_url":"https://api.github.com/users/brjeter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brjeter/subscriptions","organizations_url":"https://api.github.com/users/brjeter/orgs","repos_url":"https://api.github.com/users/brjeter/repos","events_url":"https://api.github.com/users/brjeter/events{/privacy}","received_events_url":"https://api.github.com/users/brjeter/received_events","type":"User","site_admin":false},"html_url":"https://github.com/brjeter/ddf","description":"Distributed Data Framework - an open source, modular integration framework.","fork":true,"url":"https://api.github.com/repos/brjeter/ddf","forks_url":"https://api.github.com/repos/brjeter/ddf/forks","keys_url":"https://api.github.com/repos/brjeter/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brjeter/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brjeter/ddf/teams","hooks_url":"https://api.github.com/repos/brjeter/ddf/hooks","issue_events_url":"https://api.github.com/repos/brjeter/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/brjeter/ddf/events","assignees_url":"https://api.github.com/repos/brjeter/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/brjeter/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/brjeter/ddf/tags","blobs_url":"https://api.github.com/repos/brjeter/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brjeter/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brjeter/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/brjeter/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brjeter/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/brjeter/ddf/languages","stargazers_url":"https://api.github.com/repos/brjeter/ddf/stargazers","contributors_url":"https://api.github.com/repos/brjeter/ddf/contributors","subscribers_url":"https://api.github.com/repos/brjeter/ddf/subscribers","subscription_url":"https://api.github.com/repos/brjeter/ddf/subscription","commits_url":"https://api.github.com/repos/brjeter/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/brjeter/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/brjeter/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/brjeter/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/brjeter/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/brjeter/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brjeter/ddf/merges","archive_url":"https://api.github.com/repos/brjeter/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brjeter/ddf/downloads","issues_url":"https://api.github.com/repos/brjeter/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/brjeter/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/brjeter/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/brjeter/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brjeter/ddf/labels{/name}","releases_url":"https://api.github.com/repos/brjeter/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/brjeter/ddf/deployments","created_at":"2016-10-05T15:24:28Z","updated_at":"2016-10-05T15:24:46Z","pushed_at":"2018-12-17T18:44:00Z","git_url":"git://github.com/brjeter/ddf.git","ssh_url":"[email protected]:brjeter/ddf.git","clone_url":"https://github.com/brjeter/ddf.git","svn_url":"https://github.com/brjeter/ddf","homepage":"http://ddf.codice.org","size":210964,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codice:master","ref":"master","sha":"c35076fbd73d3b7abee65dabba721c6004ffabbb","user":{"login":"codice","id":2386734,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzODY3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2386734?v=4","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"repo":{"id":15173563,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE3MzU2Mw==","name":"ddf","full_name":"codice/ddf","private":false,"owner":{"login":"codice","id":2386734,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzODY3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2386734?v=4","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/codice/ddf","description":"DDF Distributed Data Framework - an open source, modular integration framework.","fork":false,"url":"https://api.github.com/repos/codice/ddf","forks_url":"https://api.github.com/repos/codice/ddf/forks","keys_url":"https://api.github.com/repos/codice/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codice/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codice/ddf/teams","hooks_url":"https://api.github.com/repos/codice/ddf/hooks","issue_events_url":"https://api.github.com/repos/codice/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/codice/ddf/events","assignees_url":"https://api.github.com/repos/codice/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/codice/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/codice/ddf/tags","blobs_url":"https://api.github.com/repos/codice/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codice/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codice/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/codice/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/codice/ddf/languages","stargazers_url":"https://api.github.com/repos/codice/ddf/stargazers","contributors_url":"https://api.github.com/repos/codice/ddf/contributors","subscribers_url":"https://api.github.com/repos/codice/ddf/subscribers","subscription_url":"https://api.github.com/repos/codice/ddf/subscription","commits_url":"https://api.github.com/repos/codice/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/codice/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/codice/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/codice/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/codice/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/codice/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codice/ddf/merges","archive_url":"https://api.github.com/repos/codice/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codice/ddf/downloads","issues_url":"https://api.github.com/repos/codice/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/codice/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/codice/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/codice/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codice/ddf/labels{/name}","releases_url":"https://api.github.com/repos/codice/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/codice/ddf/deployments","created_at":"2013-12-13T20:38:28Z","updated_at":"2018-12-17T21:16:55Z","pushed_at":"2018-12-18T00:20:28Z","git_url":"git://github.com/codice/ddf.git","ssh_url":"[email protected]:codice/ddf.git","clone_url":"https://github.com/codice/ddf.git","svn_url":"https://github.com/codice/ddf","homepage":"http://ddf.codice.org","size":415969,"stargazers_count":92,"watchers_count":92,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":158,"mirror_url":null,"archived":false,"open_issues_count":34,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":158,"open_issues":34,"watchers":92,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/4141"},"html":{"href":"https://github.com/codice/ddf/pull/4141"},"issue":{"href":"https://api.github.com/repos/codice/ddf/issues/4141"},"comments":{"href":"https://api.github.com/repos/codice/ddf/issues/4141/comments"},"review_comments":{"href":"https://api.github.com/repos/codice/ddf/pulls/4141/comments"},"review_comment":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codice/ddf/pulls/4141/commits"},"statuses":{"href":"https://api.github.com/repos/codice/ddf/statuses/11c488b1fb38cf9d577000b059f4453d22bf4745"}},"author_association":"CONTRIBUTOR"}} | {
"id": 15173563,
"name": "codice/ddf",
"url": "https://api.github.com/repos/codice/ddf"
} | {
"id": 11377558,
"login": "lessarderic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11377558?",
"url": "https://api.github.com/users/lessarderic"
} | {
"id": 2386734,
"login": "codice",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2386734?",
"url": "https://api.github.com/orgs/codice"
} | 2018-12-18T00:00:29 | 8768808666 | {"actor":{"display_login":"lessarderic"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/pulls/comments/203300022","pull_request_review_id":138155646,"id":203300022,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzMwMDAyMg==","diff_hunk":"@@ -169,6 +171,14 @@ def build_new_order_xml_with_cc(operation, money, creditcard, options)\n end\n end\n \n+ def add_mit_cit_params(xml, options)\n+ xml.tag! :MITMsgType, options[:mit_cit_type] unless options[:mit_cit_type].nil?","path":"lib/orbital/ext/active_merchant/active_merchant.rb","position":38,"original_position":38,"commit_id":"b873a436b9347e5823000dd68621e4fbe913a485","original_commit_id":"b873a436b9347e5823000dd68621e4fbe913a485","user":{"login":"pierre","id":51940,"node_id":"MDQ6VXNlcjUxOTQw","avatar_url":"https://avatars2.githubusercontent.com/u/51940?v=4","gravatar_id":"","url":"https://api.github.com/users/pierre","html_url":"https://github.com/pierre","followers_url":"https://api.github.com/users/pierre/followers","following_url":"https://api.github.com/users/pierre/following{/other_user}","gists_url":"https://api.github.com/users/pierre/gists{/gist_id}","starred_url":"https://api.github.com/users/pierre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierre/subscriptions","organizations_url":"https://api.github.com/users/pierre/orgs","repos_url":"https://api.github.com/users/pierre/repos","events_url":"https://api.github.com/users/pierre/events{/privacy}","received_events_url":"https://api.github.com/users/pierre/received_events","type":"User","site_admin":false},"body":"Could you document in the `README` how `mit_cit_type` and `mit_ref_trx_id` should be populated?\r\n\r\nAlso, if this is for VISA only, is it the responsibility of the control plugin to filter on the card type?","created_at":"2018-07-18T08:53:51Z","updated_at":"2018-07-18T08:54:10Z","html_url":"https://github.com/killbill/killbill-orbital-plugin/pull/16#discussion_r203300022","pull_request_url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/pulls/16","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/killbill/killbill-orbital-plugin/pulls/comments/203300022"},"html":{"href":"https://github.com/killbill/killbill-orbital-plugin/pull/16#discussion_r203300022"},"pull_request":{"href":"https://api.github.com/repos/killbill/killbill-orbital-plugin/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/pulls/16","id":198122981,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MTIyOTgx","html_url":"https://github.com/killbill/killbill-orbital-plugin/pull/16","diff_url":"https://github.com/killbill/killbill-orbital-plugin/pull/16.diff","patch_url":"https://github.com/killbill/killbill-orbital-plugin/pull/16.patch","issue_url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/issues/16","number":16,"state":"open","locked":false,"title":"MIT CIT support for Orbital","user":{"login":"daliwei","id":5861585,"node_id":"MDQ6VXNlcjU4NjE1ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/5861585?v=4","gravatar_id":"","url":"https://api.github.com/users/daliwei","html_url":"https://github.com/daliwei","followers_url":"https://api.github.com/users/daliwei/followers","following_url":"https://api.github.com/users/daliwei/following{/other_user}","gists_url":"https://api.github.com/users/daliwei/gists{/gist_id}","starred_url":"https://api.github.com/users/daliwei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daliwei/subscriptions","organizations_url":"https://api.github.com/users/daliwei/orgs","repos_url":"https://api.github.com/users/daliwei/repos","events_url":"https://api.github.com/users/daliwei/events{/privacy}","received_events_url":"https://api.github.com/users/daliwei/received_events","type":"User","site_admin":false},"body":"@pierre Please review.","created_at":"2018-06-28T19:01:19Z","updated_at":"2018-07-18T08:54:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"02faf4c691198e98de8f2a88884421aed7659567","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/pulls/16/commits","review_comments_url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/pulls/16/comments","review_comment_url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/issues/16/comments","statuses_url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/statuses/b873a436b9347e5823000dd68621e4fbe913a485","head":{"label":"daliwei:dw/mit_cit","ref":"dw/mit_cit","sha":"b873a436b9347e5823000dd68621e4fbe913a485","user":{"login":"daliwei","id":5861585,"node_id":"MDQ6VXNlcjU4NjE1ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/5861585?v=4","gravatar_id":"","url":"https://api.github.com/users/daliwei","html_url":"https://github.com/daliwei","followers_url":"https://api.github.com/users/daliwei/followers","following_url":"https://api.github.com/users/daliwei/following{/other_user}","gists_url":"https://api.github.com/users/daliwei/gists{/gist_id}","starred_url":"https://api.github.com/users/daliwei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daliwei/subscriptions","organizations_url":"https://api.github.com/users/daliwei/orgs","repos_url":"https://api.github.com/users/daliwei/repos","events_url":"https://api.github.com/users/daliwei/events{/privacy}","received_events_url":"https://api.github.com/users/daliwei/received_events","type":"User","site_admin":false},"repo":{"id":61576259,"node_id":"MDEwOlJlcG9zaXRvcnk2MTU3NjI1OQ==","name":"killbill-orbital-plugin","full_name":"daliwei/killbill-orbital-plugin","owner":{"login":"daliwei","id":5861585,"node_id":"MDQ6VXNlcjU4NjE1ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/5861585?v=4","gravatar_id":"","url":"https://api.github.com/users/daliwei","html_url":"https://github.com/daliwei","followers_url":"https://api.github.com/users/daliwei/followers","following_url":"https://api.github.com/users/daliwei/following{/other_user}","gists_url":"https://api.github.com/users/daliwei/gists{/gist_id}","starred_url":"https://api.github.com/users/daliwei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daliwei/subscriptions","organizations_url":"https://api.github.com/users/daliwei/orgs","repos_url":"https://api.github.com/users/daliwei/repos","events_url":"https://api.github.com/users/daliwei/events{/privacy}","received_events_url":"https://api.github.com/users/daliwei/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/daliwei/killbill-orbital-plugin","description":"Plugin to use Orbital as a gateway","fork":true,"url":"https://api.github.com/repos/daliwei/killbill-orbital-plugin","forks_url":"https://api.github.com/repos/daliwei/killbill-orbital-plugin/forks","keys_url":"https://api.github.com/repos/daliwei/killbill-orbital-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/daliwei/killbill-orbital-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/daliwei/killbill-orbital-plugin/teams","hooks_url":"https://api.github.com/repos/daliwei/killbill-orbital-plugin/hooks","issue_events_url":"https://api.github.com/repos/daliwei/killbill-orbital-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/daliwei/killbill-orbital-plugin/events","assignees_url":"https://api.github.com/repos/daliwei/killbill-orbital-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/daliwei/killbill-orbital-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/daliwei/killbill-orbital-plugin/tags","blobs_url":"https://api.github.com/repos/daliwei/killbill-orbital-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/daliwei/killbill-orbital-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/daliwei/killbill-orbital-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/daliwei/killbill-orbital-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/daliwei/killbill-orbital-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/daliwei/killbill-orbital-plugin/languages","stargazers_url":"https://api.github.com/repos/daliwei/killbill-orbital-plugin/stargazers","contributors_url":"https://api.github.com/repos/daliwei/killbill-orbital-plugin/contributors","subscribers_url":"https://api.github.com/repos/daliwei/killbill-orbital-plugin/subscribers","subscription_url":"https://api.github.com/repos/daliwei/killbill-orbital-plugin/subscription","commits_url":"https://api.github.com/repos/daliwei/killbill-orbital-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/daliwei/killbill-orbital-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/daliwei/killbill-orbital-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/daliwei/killbill-orbital-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/daliwei/killbill-orbital-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/daliwei/killbill-orbital-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/daliwei/killbill-orbital-plugin/merges","archive_url":"https://api.github.com/repos/daliwei/killbill-orbital-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/daliwei/killbill-orbital-plugin/downloads","issues_url":"https://api.github.com/repos/daliwei/killbill-orbital-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/daliwei/killbill-orbital-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/daliwei/killbill-orbital-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/daliwei/killbill-orbital-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/daliwei/killbill-orbital-plugin/labels{/name}","releases_url":"https://api.github.com/repos/daliwei/killbill-orbital-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/daliwei/killbill-orbital-plugin/deployments","created_at":"2016-06-20T19:58:13Z","updated_at":"2018-03-26T18:04:42Z","pushed_at":"2018-07-10T22:25:33Z","git_url":"git://github.com/daliwei/killbill-orbital-plugin.git","ssh_url":"[email protected]:daliwei/killbill-orbital-plugin.git","clone_url":"https://github.com/daliwei/killbill-orbital-plugin.git","svn_url":"https://github.com/daliwei/killbill-orbital-plugin","homepage":null,"size":104,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"killbill:backport-0.18.x","ref":"backport-0.18.x","sha":"4228bc32eac4ac3b6456d4f8c66248e053b35a4a","user":{"login":"killbill","id":2446739,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NDY3Mzk=","avatar_url":"https://avatars2.githubusercontent.com/u/2446739?v=4","gravatar_id":"","url":"https://api.github.com/users/killbill","html_url":"https://github.com/killbill","followers_url":"https://api.github.com/users/killbill/followers","following_url":"https://api.github.com/users/killbill/following{/other_user}","gists_url":"https://api.github.com/users/killbill/gists{/gist_id}","starred_url":"https://api.github.com/users/killbill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/killbill/subscriptions","organizations_url":"https://api.github.com/users/killbill/orgs","repos_url":"https://api.github.com/users/killbill/repos","events_url":"https://api.github.com/users/killbill/events{/privacy}","received_events_url":"https://api.github.com/users/killbill/received_events","type":"Organization","site_admin":false},"repo":{"id":52034349,"node_id":"MDEwOlJlcG9zaXRvcnk1MjAzNDM0OQ==","name":"killbill-orbital-plugin","full_name":"killbill/killbill-orbital-plugin","owner":{"login":"killbill","id":2446739,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NDY3Mzk=","avatar_url":"https://avatars2.githubusercontent.com/u/2446739?v=4","gravatar_id":"","url":"https://api.github.com/users/killbill","html_url":"https://github.com/killbill","followers_url":"https://api.github.com/users/killbill/followers","following_url":"https://api.github.com/users/killbill/following{/other_user}","gists_url":"https://api.github.com/users/killbill/gists{/gist_id}","starred_url":"https://api.github.com/users/killbill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/killbill/subscriptions","organizations_url":"https://api.github.com/users/killbill/orgs","repos_url":"https://api.github.com/users/killbill/repos","events_url":"https://api.github.com/users/killbill/events{/privacy}","received_events_url":"https://api.github.com/users/killbill/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/killbill/killbill-orbital-plugin","description":"Plugin to use Orbital as a gateway","fork":false,"url":"https://api.github.com/repos/killbill/killbill-orbital-plugin","forks_url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/forks","keys_url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/teams","hooks_url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/hooks","issue_events_url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/events","assignees_url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/tags","blobs_url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/languages","stargazers_url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/stargazers","contributors_url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/contributors","subscribers_url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/subscribers","subscription_url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/subscription","commits_url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/merges","archive_url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/downloads","issues_url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/labels{/name}","releases_url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/killbill/killbill-orbital-plugin/deployments","created_at":"2016-02-18T19:53:41Z","updated_at":"2018-06-16T18:57:45Z","pushed_at":"2018-07-18T08:41:47Z","git_url":"git://github.com/killbill/killbill-orbital-plugin.git","ssh_url":"[email protected]:killbill/killbill-orbital-plugin.git","clone_url":"https://github.com/killbill/killbill-orbital-plugin.git","svn_url":"https://github.com/killbill/killbill-orbital-plugin","homepage":"http://killbill.io","size":97,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/killbill/killbill-orbital-plugin/pulls/16"},"html":{"href":"https://github.com/killbill/killbill-orbital-plugin/pull/16"},"issue":{"href":"https://api.github.com/repos/killbill/killbill-orbital-plugin/issues/16"},"comments":{"href":"https://api.github.com/repos/killbill/killbill-orbital-plugin/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/killbill/killbill-orbital-plugin/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/killbill/killbill-orbital-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/killbill/killbill-orbital-plugin/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/killbill/killbill-orbital-plugin/statuses/b873a436b9347e5823000dd68621e4fbe913a485"}},"author_association":"CONTRIBUTOR"}} | {
"id": 52034349,
"name": "killbill/killbill-orbital-plugin",
"url": "https://api.github.com/repos/killbill/killbill-orbital-plugin"
} | {
"id": 51940,
"login": "pierre",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/51940?",
"url": "https://api.github.com/users/pierre"
} | {
"id": 2446739,
"login": "killbill",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2446739?",
"url": "https://api.github.com/orgs/killbill"
} | 2018-07-18T08:53:51 | 7981550338 | {"actor":{"display_login":"pierre"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/nunit/nunit/pulls/comments/190192772","pull_request_review_id":122516837,"id":190192772,"diff_hunk":"@@ -69,31 +69,14 @@ public CollectionTallyResult Result\n /// <param name=\"c\">The expected collection to compare against.</param>\n public CollectionTally(NUnitEqualityComparer comparer, IEnumerable c)\n {\n- this.comparer = comparer;\n-\n- foreach (object o in c)\n- _missingItems.Add(o);\n- }\n-\n- private bool ItemsEqual(object expected, object actual)\n- {\n- Tolerance tolerance = Tolerance.Default;\n- return comparer.AreEqual(expected, actual, ref tolerance);\n+ _missingItems = new MissingItemCollection(comparer, c);\n }\n \n /// <summary>Try to remove an object from the tally.</summary>\n /// <param name=\"o\">The object to remove.</param>\n public void TryRemove(object o)\n {\n- for (int index = _missingItems.Count - 1; index >= 0; index--)\n- {\n- if (ItemsEqual(_missingItems[index], o))\n- {\n- _missingItems.RemoveAt(index);\n- return;\n- }\n- }\n-\n+ if (_missingItems.Remove(o)) return;","path":"src/NUnitFramework/framework/Constraints/CollectionTally.cs","position":57,"original_position":57,"commit_id":"d893d83bbd18dd19474511d9058561f6713123da","original_commit_id":"d893d83bbd18dd19474511d9058561f6713123da","user":{"login":"ggeurts","id":684925,"avatar_url":"https://avatars2.githubusercontent.com/u/684925?v=4","gravatar_id":"","url":"https://api.github.com/users/ggeurts","html_url":"https://github.com/ggeurts","followers_url":"https://api.github.com/users/ggeurts/followers","following_url":"https://api.github.com/users/ggeurts/following{/other_user}","gists_url":"https://api.github.com/users/ggeurts/gists{/gist_id}","starred_url":"https://api.github.com/users/ggeurts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggeurts/subscriptions","organizations_url":"https://api.github.com/users/ggeurts/orgs","repos_url":"https://api.github.com/users/ggeurts/repos","events_url":"https://api.github.com/users/ggeurts/events{/privacy}","received_events_url":"https://api.github.com/users/ggeurts/received_events","type":"User","site_admin":false},"body":"The current collection equality compare operations do not support non-transitive comparisons. If transitive collection comparisons were required, interval trees might be used to improve performance.","created_at":"2018-05-23T10:08:49Z","updated_at":"2018-05-23T10:08:49Z","html_url":"https://github.com/nunit/nunit/pull/2830#discussion_r190192772","pull_request_url":"https://api.github.com/repos/nunit/nunit/pulls/2830","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nunit/nunit/pulls/comments/190192772"},"html":{"href":"https://github.com/nunit/nunit/pull/2830#discussion_r190192772"},"pull_request":{"href":"https://api.github.com/repos/nunit/nunit/pulls/2830"}},"in_reply_to_id":190079653},"pull_request":{"url":"https://api.github.com/repos/nunit/nunit/pulls/2830","id":184485768,"html_url":"https://github.com/nunit/nunit/pull/2830","diff_url":"https://github.com/nunit/nunit/pull/2830.diff","patch_url":"https://github.com/nunit/nunit/pull/2830.patch","issue_url":"https://api.github.com/repos/nunit/nunit/issues/2830","number":2830,"state":"open","locked":false,"title":"Fix for #2799 and #2826: slow collection equivalence tests.","user":{"login":"ggeurts","id":684925,"avatar_url":"https://avatars2.githubusercontent.com/u/684925?v=4","gravatar_id":"","url":"https://api.github.com/users/ggeurts","html_url":"https://github.com/ggeurts","followers_url":"https://api.github.com/users/ggeurts/followers","following_url":"https://api.github.com/users/ggeurts/following{/other_user}","gists_url":"https://api.github.com/users/ggeurts/gists{/gist_id}","starred_url":"https://api.github.com/users/ggeurts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggeurts/subscriptions","organizations_url":"https://api.github.com/users/ggeurts/orgs","repos_url":"https://api.github.com/users/ggeurts/repos","events_url":"https://api.github.com/users/ggeurts/events{/privacy}","received_events_url":"https://api.github.com/users/ggeurts/received_events","type":"User","site_admin":false},"body":"Fixes #2799","created_at":"2018-04-26T23:01:25Z","updated_at":"2018-05-23T10:08:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5570a98a6d0e05db076496b432420dc94b4a8f8e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":805813973,"url":"https://api.github.com/repos/nunit/nunit/labels/awaiting:contributor","name":"awaiting:contributor","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nunit/nunit/pulls/2830/commits","review_comments_url":"https://api.github.com/repos/nunit/nunit/pulls/2830/comments","review_comment_url":"https://api.github.com/repos/nunit/nunit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nunit/nunit/issues/2830/comments","statuses_url":"https://api.github.com/repos/nunit/nunit/statuses/d893d83bbd18dd19474511d9058561f6713123da","head":{"label":"ggeurts:issue-2799","ref":"issue-2799","sha":"d893d83bbd18dd19474511d9058561f6713123da","user":{"login":"ggeurts","id":684925,"avatar_url":"https://avatars2.githubusercontent.com/u/684925?v=4","gravatar_id":"","url":"https://api.github.com/users/ggeurts","html_url":"https://github.com/ggeurts","followers_url":"https://api.github.com/users/ggeurts/followers","following_url":"https://api.github.com/users/ggeurts/following{/other_user}","gists_url":"https://api.github.com/users/ggeurts/gists{/gist_id}","starred_url":"https://api.github.com/users/ggeurts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggeurts/subscriptions","organizations_url":"https://api.github.com/users/ggeurts/orgs","repos_url":"https://api.github.com/users/ggeurts/repos","events_url":"https://api.github.com/users/ggeurts/events{/privacy}","received_events_url":"https://api.github.com/users/ggeurts/received_events","type":"User","site_admin":false},"repo":{"id":66562778,"name":"nunit","full_name":"ggeurts/nunit","owner":{"login":"ggeurts","id":684925,"avatar_url":"https://avatars2.githubusercontent.com/u/684925?v=4","gravatar_id":"","url":"https://api.github.com/users/ggeurts","html_url":"https://github.com/ggeurts","followers_url":"https://api.github.com/users/ggeurts/followers","following_url":"https://api.github.com/users/ggeurts/following{/other_user}","gists_url":"https://api.github.com/users/ggeurts/gists{/gist_id}","starred_url":"https://api.github.com/users/ggeurts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggeurts/subscriptions","organizations_url":"https://api.github.com/users/ggeurts/orgs","repos_url":"https://api.github.com/users/ggeurts/repos","events_url":"https://api.github.com/users/ggeurts/events{/privacy}","received_events_url":"https://api.github.com/users/ggeurts/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ggeurts/nunit","description":"NUnit 3.0 Framework","fork":true,"url":"https://api.github.com/repos/ggeurts/nunit","forks_url":"https://api.github.com/repos/ggeurts/nunit/forks","keys_url":"https://api.github.com/repos/ggeurts/nunit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ggeurts/nunit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ggeurts/nunit/teams","hooks_url":"https://api.github.com/repos/ggeurts/nunit/hooks","issue_events_url":"https://api.github.com/repos/ggeurts/nunit/issues/events{/number}","events_url":"https://api.github.com/repos/ggeurts/nunit/events","assignees_url":"https://api.github.com/repos/ggeurts/nunit/assignees{/user}","branches_url":"https://api.github.com/repos/ggeurts/nunit/branches{/branch}","tags_url":"https://api.github.com/repos/ggeurts/nunit/tags","blobs_url":"https://api.github.com/repos/ggeurts/nunit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ggeurts/nunit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ggeurts/nunit/git/refs{/sha}","trees_url":"https://api.github.com/repos/ggeurts/nunit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ggeurts/nunit/statuses/{sha}","languages_url":"https://api.github.com/repos/ggeurts/nunit/languages","stargazers_url":"https://api.github.com/repos/ggeurts/nunit/stargazers","contributors_url":"https://api.github.com/repos/ggeurts/nunit/contributors","subscribers_url":"https://api.github.com/repos/ggeurts/nunit/subscribers","subscription_url":"https://api.github.com/repos/ggeurts/nunit/subscription","commits_url":"https://api.github.com/repos/ggeurts/nunit/commits{/sha}","git_commits_url":"https://api.github.com/repos/ggeurts/nunit/git/commits{/sha}","comments_url":"https://api.github.com/repos/ggeurts/nunit/comments{/number}","issue_comment_url":"https://api.github.com/repos/ggeurts/nunit/issues/comments{/number}","contents_url":"https://api.github.com/repos/ggeurts/nunit/contents/{+path}","compare_url":"https://api.github.com/repos/ggeurts/nunit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ggeurts/nunit/merges","archive_url":"https://api.github.com/repos/ggeurts/nunit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ggeurts/nunit/downloads","issues_url":"https://api.github.com/repos/ggeurts/nunit/issues{/number}","pulls_url":"https://api.github.com/repos/ggeurts/nunit/pulls{/number}","milestones_url":"https://api.github.com/repos/ggeurts/nunit/milestones{/number}","notifications_url":"https://api.github.com/repos/ggeurts/nunit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ggeurts/nunit/labels{/name}","releases_url":"https://api.github.com/repos/ggeurts/nunit/releases{/id}","deployments_url":"https://api.github.com/repos/ggeurts/nunit/deployments","created_at":"2016-08-25T14:01:50Z","updated_at":"2018-04-26T10:12:37Z","pushed_at":"2018-05-04T11:34:26Z","git_url":"git://github.com/ggeurts/nunit.git","ssh_url":"[email protected]:ggeurts/nunit.git","clone_url":"https://github.com/ggeurts/nunit.git","svn_url":"https://github.com/ggeurts/nunit","homepage":"http://www.nunit.org/","size":34832,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nunit:master","ref":"master","sha":"662055f789a8528e851e63c6566822e9392a46d1","user":{"login":"nunit","id":2678858,"avatar_url":"https://avatars0.githubusercontent.com/u/2678858?v=4","gravatar_id":"","url":"https://api.github.com/users/nunit","html_url":"https://github.com/nunit","followers_url":"https://api.github.com/users/nunit/followers","following_url":"https://api.github.com/users/nunit/following{/other_user}","gists_url":"https://api.github.com/users/nunit/gists{/gist_id}","starred_url":"https://api.github.com/users/nunit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nunit/subscriptions","organizations_url":"https://api.github.com/users/nunit/orgs","repos_url":"https://api.github.com/users/nunit/repos","events_url":"https://api.github.com/users/nunit/events{/privacy}","received_events_url":"https://api.github.com/users/nunit/received_events","type":"Organization","site_admin":false},"repo":{"id":13692183,"name":"nunit","full_name":"nunit/nunit","owner":{"login":"nunit","id":2678858,"avatar_url":"https://avatars0.githubusercontent.com/u/2678858?v=4","gravatar_id":"","url":"https://api.github.com/users/nunit","html_url":"https://github.com/nunit","followers_url":"https://api.github.com/users/nunit/followers","following_url":"https://api.github.com/users/nunit/following{/other_user}","gists_url":"https://api.github.com/users/nunit/gists{/gist_id}","starred_url":"https://api.github.com/users/nunit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nunit/subscriptions","organizations_url":"https://api.github.com/users/nunit/orgs","repos_url":"https://api.github.com/users/nunit/repos","events_url":"https://api.github.com/users/nunit/events{/privacy}","received_events_url":"https://api.github.com/users/nunit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nunit/nunit","description":"NUnit 3.0 Framework","fork":false,"url":"https://api.github.com/repos/nunit/nunit","forks_url":"https://api.github.com/repos/nunit/nunit/forks","keys_url":"https://api.github.com/repos/nunit/nunit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nunit/nunit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nunit/nunit/teams","hooks_url":"https://api.github.com/repos/nunit/nunit/hooks","issue_events_url":"https://api.github.com/repos/nunit/nunit/issues/events{/number}","events_url":"https://api.github.com/repos/nunit/nunit/events","assignees_url":"https://api.github.com/repos/nunit/nunit/assignees{/user}","branches_url":"https://api.github.com/repos/nunit/nunit/branches{/branch}","tags_url":"https://api.github.com/repos/nunit/nunit/tags","blobs_url":"https://api.github.com/repos/nunit/nunit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nunit/nunit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nunit/nunit/git/refs{/sha}","trees_url":"https://api.github.com/repos/nunit/nunit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nunit/nunit/statuses/{sha}","languages_url":"https://api.github.com/repos/nunit/nunit/languages","stargazers_url":"https://api.github.com/repos/nunit/nunit/stargazers","contributors_url":"https://api.github.com/repos/nunit/nunit/contributors","subscribers_url":"https://api.github.com/repos/nunit/nunit/subscribers","subscription_url":"https://api.github.com/repos/nunit/nunit/subscription","commits_url":"https://api.github.com/repos/nunit/nunit/commits{/sha}","git_commits_url":"https://api.github.com/repos/nunit/nunit/git/commits{/sha}","comments_url":"https://api.github.com/repos/nunit/nunit/comments{/number}","issue_comment_url":"https://api.github.com/repos/nunit/nunit/issues/comments{/number}","contents_url":"https://api.github.com/repos/nunit/nunit/contents/{+path}","compare_url":"https://api.github.com/repos/nunit/nunit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nunit/nunit/merges","archive_url":"https://api.github.com/repos/nunit/nunit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nunit/nunit/downloads","issues_url":"https://api.github.com/repos/nunit/nunit/issues{/number}","pulls_url":"https://api.github.com/repos/nunit/nunit/pulls{/number}","milestones_url":"https://api.github.com/repos/nunit/nunit/milestones{/number}","notifications_url":"https://api.github.com/repos/nunit/nunit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nunit/nunit/labels{/name}","releases_url":"https://api.github.com/repos/nunit/nunit/releases{/id}","deployments_url":"https://api.github.com/repos/nunit/nunit/deployments","created_at":"2013-10-18T23:43:29Z","updated_at":"2018-05-22T03:29:07Z","pushed_at":"2018-05-23T05:02:46Z","git_url":"git://github.com/nunit/nunit.git","ssh_url":"[email protected]:nunit/nunit.git","clone_url":"https://github.com/nunit/nunit.git","svn_url":"https://github.com/nunit/nunit","homepage":"http://www.nunit.org/","size":34315,"stargazers_count":1312,"watchers_count":1312,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":479,"mirror_url":null,"archived":false,"open_issues_count":284,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":479,"open_issues":284,"watchers":1312,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nunit/nunit/pulls/2830"},"html":{"href":"https://github.com/nunit/nunit/pull/2830"},"issue":{"href":"https://api.github.com/repos/nunit/nunit/issues/2830"},"comments":{"href":"https://api.github.com/repos/nunit/nunit/issues/2830/comments"},"review_comments":{"href":"https://api.github.com/repos/nunit/nunit/pulls/2830/comments"},"review_comment":{"href":"https://api.github.com/repos/nunit/nunit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nunit/nunit/pulls/2830/commits"},"statuses":{"href":"https://api.github.com/repos/nunit/nunit/statuses/d893d83bbd18dd19474511d9058561f6713123da"}},"author_association":"MEMBER"}} | {
"id": 13692183,
"name": "nunit/nunit",
"url": "https://api.github.com/repos/nunit/nunit"
} | {
"id": 684925,
"login": "ggeurts",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/684925?",
"url": "https://api.github.com/users/ggeurts"
} | {
"id": 2678858,
"login": "nunit",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2678858?",
"url": "https://api.github.com/orgs/nunit"
} | 2018-05-23T10:08:49 | 7716268713 | {"actor":{"display_login":"ggeurts"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/lampepfl/dotty/pulls/comments/204748252","pull_request_review_id":139881029,"id":204748252,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDc0ODI1Mg==","diff_hunk":"@@ -0,0 +1,80 @@\n+// Constant(Symbol)","path":"compiler/test/dotc/pos-decompilation.blacklist","position":1,"original_position":1,"commit_id":"74df64090892dcdc424f262fc3f3a7d145335fce","original_commit_id":"74df64090892dcdc424f262fc3f3a7d145335fce","user":{"login":"allanrenucci","id":4996324,"node_id":"MDQ6VXNlcjQ5OTYzMjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4996324?v=4","gravatar_id":"","url":"https://api.github.com/users/allanrenucci","html_url":"https://github.com/allanrenucci","followers_url":"https://api.github.com/users/allanrenucci/followers","following_url":"https://api.github.com/users/allanrenucci/following{/other_user}","gists_url":"https://api.github.com/users/allanrenucci/gists{/gist_id}","starred_url":"https://api.github.com/users/allanrenucci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allanrenucci/subscriptions","organizations_url":"https://api.github.com/users/allanrenucci/orgs","repos_url":"https://api.github.com/users/allanrenucci/repos","events_url":"https://api.github.com/users/allanrenucci/events{/privacy}","received_events_url":"https://api.github.com/users/allanrenucci/received_events","type":"User","site_admin":false},"body":"Shouldn't a comment start with `#`?","created_at":"2018-07-24T13:10:23Z","updated_at":"2018-07-24T13:10:23Z","html_url":"https://github.com/lampepfl/dotty/pull/4645#discussion_r204748252","pull_request_url":"https://api.github.com/repos/lampepfl/dotty/pulls/4645","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/lampepfl/dotty/pulls/comments/204748252"},"html":{"href":"https://github.com/lampepfl/dotty/pull/4645#discussion_r204748252"},"pull_request":{"href":"https://api.github.com/repos/lampepfl/dotty/pulls/4645"}},"in_reply_to_id":204727419},"pull_request":{"url":"https://api.github.com/repos/lampepfl/dotty/pulls/4645","id":193886708,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzODg2NzA4","html_url":"https://github.com/lampepfl/dotty/pull/4645","diff_url":"https://github.com/lampepfl/dotty/pull/4645.diff","patch_url":"https://github.com/lampepfl/dotty/pull/4645.patch","issue_url":"https://api.github.com/repos/lampepfl/dotty/issues/4645","number":4645,"state":"open","locked":false,"title":"Add FromTastyDecompilation decompilation blacklist","user":{"login":"nicolasstucki","id":3648029,"node_id":"MDQ6VXNlcjM2NDgwMjk=","avatar_url":"https://avatars2.githubusercontent.com/u/3648029?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolasstucki","html_url":"https://github.com/nicolasstucki","followers_url":"https://api.github.com/users/nicolasstucki/followers","following_url":"https://api.github.com/users/nicolasstucki/following{/other_user}","gists_url":"https://api.github.com/users/nicolasstucki/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolasstucki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolasstucki/subscriptions","organizations_url":"https://api.github.com/users/nicolasstucki/orgs","repos_url":"https://api.github.com/users/nicolasstucki/repos","events_url":"https://api.github.com/users/nicolasstucki/events{/privacy}","received_events_url":"https://api.github.com/users/nicolasstucki/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-11T06:43:02Z","updated_at":"2018-07-24T13:10:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f15716727f06311a3eb0e9a4c7be89374a75f23b","assignee":{"login":"allanrenucci","id":4996324,"node_id":"MDQ6VXNlcjQ5OTYzMjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4996324?v=4","gravatar_id":"","url":"https://api.github.com/users/allanrenucci","html_url":"https://github.com/allanrenucci","followers_url":"https://api.github.com/users/allanrenucci/followers","following_url":"https://api.github.com/users/allanrenucci/following{/other_user}","gists_url":"https://api.github.com/users/allanrenucci/gists{/gist_id}","starred_url":"https://api.github.com/users/allanrenucci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allanrenucci/subscriptions","organizations_url":"https://api.github.com/users/allanrenucci/orgs","repos_url":"https://api.github.com/users/allanrenucci/repos","events_url":"https://api.github.com/users/allanrenucci/events{/privacy}","received_events_url":"https://api.github.com/users/allanrenucci/received_events","type":"User","site_admin":false},"assignees":[{"login":"allanrenucci","id":4996324,"node_id":"MDQ6VXNlcjQ5OTYzMjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4996324?v=4","gravatar_id":"","url":"https://api.github.com/users/allanrenucci","html_url":"https://github.com/allanrenucci","followers_url":"https://api.github.com/users/allanrenucci/followers","following_url":"https://api.github.com/users/allanrenucci/following{/other_user}","gists_url":"https://api.github.com/users/allanrenucci/gists{/gist_id}","starred_url":"https://api.github.com/users/allanrenucci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allanrenucci/subscriptions","organizations_url":"https://api.github.com/users/allanrenucci/orgs","repos_url":"https://api.github.com/users/allanrenucci/repos","events_url":"https://api.github.com/users/allanrenucci/events{/privacy}","received_events_url":"https://api.github.com/users/allanrenucci/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":386605863,"node_id":"MDU6TGFiZWwzODY2MDU4NjM=","url":"https://api.github.com/repos/lampepfl/dotty/labels/stat:needs%20review","name":"stat:needs review","color":"f9d0c4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/lampepfl/dotty/pulls/4645/commits","review_comments_url":"https://api.github.com/repos/lampepfl/dotty/pulls/4645/comments","review_comment_url":"https://api.github.com/repos/lampepfl/dotty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lampepfl/dotty/issues/4645/comments","statuses_url":"https://api.github.com/repos/lampepfl/dotty/statuses/74df64090892dcdc424f262fc3f3a7d145335fce","head":{"label":"dotty-staging:test-decompile-more-files","ref":"test-decompile-more-files","sha":"74df64090892dcdc424f262fc3f3a7d145335fce","user":{"login":"dotty-staging","id":6998674,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5OTg2NzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/6998674?v=4","gravatar_id":"","url":"https://api.github.com/users/dotty-staging","html_url":"https://github.com/dotty-staging","followers_url":"https://api.github.com/users/dotty-staging/followers","following_url":"https://api.github.com/users/dotty-staging/following{/other_user}","gists_url":"https://api.github.com/users/dotty-staging/gists{/gist_id}","starred_url":"https://api.github.com/users/dotty-staging/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotty-staging/subscriptions","organizations_url":"https://api.github.com/users/dotty-staging/orgs","repos_url":"https://api.github.com/users/dotty-staging/repos","events_url":"https://api.github.com/users/dotty-staging/events{/privacy}","received_events_url":"https://api.github.com/users/dotty-staging/received_events","type":"Organization","site_admin":false},"repo":{"id":17904384,"node_id":"MDEwOlJlcG9zaXRvcnkxNzkwNDM4NA==","name":"dotty","full_name":"dotty-staging/dotty","owner":{"login":"dotty-staging","id":6998674,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5OTg2NzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/6998674?v=4","gravatar_id":"","url":"https://api.github.com/users/dotty-staging","html_url":"https://github.com/dotty-staging","followers_url":"https://api.github.com/users/dotty-staging/followers","following_url":"https://api.github.com/users/dotty-staging/following{/other_user}","gists_url":"https://api.github.com/users/dotty-staging/gists{/gist_id}","starred_url":"https://api.github.com/users/dotty-staging/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotty-staging/subscriptions","organizations_url":"https://api.github.com/users/dotty-staging/orgs","repos_url":"https://api.github.com/users/dotty-staging/repos","events_url":"https://api.github.com/users/dotty-staging/events{/privacy}","received_events_url":"https://api.github.com/users/dotty-staging/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotty-staging/dotty","description":"Research platform for new language concepts and compiler technologies for Scala.","fork":true,"url":"https://api.github.com/repos/dotty-staging/dotty","forks_url":"https://api.github.com/repos/dotty-staging/dotty/forks","keys_url":"https://api.github.com/repos/dotty-staging/dotty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotty-staging/dotty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotty-staging/dotty/teams","hooks_url":"https://api.github.com/repos/dotty-staging/dotty/hooks","issue_events_url":"https://api.github.com/repos/dotty-staging/dotty/issues/events{/number}","events_url":"https://api.github.com/repos/dotty-staging/dotty/events","assignees_url":"https://api.github.com/repos/dotty-staging/dotty/assignees{/user}","branches_url":"https://api.github.com/repos/dotty-staging/dotty/branches{/branch}","tags_url":"https://api.github.com/repos/dotty-staging/dotty/tags","blobs_url":"https://api.github.com/repos/dotty-staging/dotty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotty-staging/dotty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotty-staging/dotty/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotty-staging/dotty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotty-staging/dotty/statuses/{sha}","languages_url":"https://api.github.com/repos/dotty-staging/dotty/languages","stargazers_url":"https://api.github.com/repos/dotty-staging/dotty/stargazers","contributors_url":"https://api.github.com/repos/dotty-staging/dotty/contributors","subscribers_url":"https://api.github.com/repos/dotty-staging/dotty/subscribers","subscription_url":"https://api.github.com/repos/dotty-staging/dotty/subscription","commits_url":"https://api.github.com/repos/dotty-staging/dotty/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotty-staging/dotty/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotty-staging/dotty/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotty-staging/dotty/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotty-staging/dotty/contents/{+path}","compare_url":"https://api.github.com/repos/dotty-staging/dotty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotty-staging/dotty/merges","archive_url":"https://api.github.com/repos/dotty-staging/dotty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotty-staging/dotty/downloads","issues_url":"https://api.github.com/repos/dotty-staging/dotty/issues{/number}","pulls_url":"https://api.github.com/repos/dotty-staging/dotty/pulls{/number}","milestones_url":"https://api.github.com/repos/dotty-staging/dotty/milestones{/number}","notifications_url":"https://api.github.com/repos/dotty-staging/dotty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotty-staging/dotty/labels{/name}","releases_url":"https://api.github.com/repos/dotty-staging/dotty/releases{/id}","deployments_url":"https://api.github.com/repos/dotty-staging/dotty/deployments","created_at":"2014-03-19T13:06:15Z","updated_at":"2018-07-24T09:13:54Z","pushed_at":"2018-07-24T13:01:49Z","git_url":"git://github.com/dotty-staging/dotty.git","ssh_url":"[email protected]:dotty-staging/dotty.git","clone_url":"https://github.com/dotty-staging/dotty.git","svn_url":"https://github.com/dotty-staging/dotty","homepage":"","size":52647,"stargazers_count":66,"watchers_count":66,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":9,"open_issues":0,"watchers":66,"default_branch":"master"}},"base":{"label":"lampepfl:master","ref":"master","sha":"fe8d050f63863587719f0b916e60b80ec1998c65","user":{"login":"lampepfl","id":2684793,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODQ3OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/2684793?v=4","gravatar_id":"","url":"https://api.github.com/users/lampepfl","html_url":"https://github.com/lampepfl","followers_url":"https://api.github.com/users/lampepfl/followers","following_url":"https://api.github.com/users/lampepfl/following{/other_user}","gists_url":"https://api.github.com/users/lampepfl/gists{/gist_id}","starred_url":"https://api.github.com/users/lampepfl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lampepfl/subscriptions","organizations_url":"https://api.github.com/users/lampepfl/orgs","repos_url":"https://api.github.com/users/lampepfl/repos","events_url":"https://api.github.com/users/lampepfl/events{/privacy}","received_events_url":"https://api.github.com/users/lampepfl/received_events","type":"Organization","site_admin":false},"repo":{"id":7035651,"node_id":"MDEwOlJlcG9zaXRvcnk3MDM1NjUx","name":"dotty","full_name":"lampepfl/dotty","owner":{"login":"lampepfl","id":2684793,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODQ3OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/2684793?v=4","gravatar_id":"","url":"https://api.github.com/users/lampepfl","html_url":"https://github.com/lampepfl","followers_url":"https://api.github.com/users/lampepfl/followers","following_url":"https://api.github.com/users/lampepfl/following{/other_user}","gists_url":"https://api.github.com/users/lampepfl/gists{/gist_id}","starred_url":"https://api.github.com/users/lampepfl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lampepfl/subscriptions","organizations_url":"https://api.github.com/users/lampepfl/orgs","repos_url":"https://api.github.com/users/lampepfl/repos","events_url":"https://api.github.com/users/lampepfl/events{/privacy}","received_events_url":"https://api.github.com/users/lampepfl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lampepfl/dotty","description":"Research compiler that will become Scala 3","fork":false,"url":"https://api.github.com/repos/lampepfl/dotty","forks_url":"https://api.github.com/repos/lampepfl/dotty/forks","keys_url":"https://api.github.com/repos/lampepfl/dotty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lampepfl/dotty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lampepfl/dotty/teams","hooks_url":"https://api.github.com/repos/lampepfl/dotty/hooks","issue_events_url":"https://api.github.com/repos/lampepfl/dotty/issues/events{/number}","events_url":"https://api.github.com/repos/lampepfl/dotty/events","assignees_url":"https://api.github.com/repos/lampepfl/dotty/assignees{/user}","branches_url":"https://api.github.com/repos/lampepfl/dotty/branches{/branch}","tags_url":"https://api.github.com/repos/lampepfl/dotty/tags","blobs_url":"https://api.github.com/repos/lampepfl/dotty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lampepfl/dotty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lampepfl/dotty/git/refs{/sha}","trees_url":"https://api.github.com/repos/lampepfl/dotty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lampepfl/dotty/statuses/{sha}","languages_url":"https://api.github.com/repos/lampepfl/dotty/languages","stargazers_url":"https://api.github.com/repos/lampepfl/dotty/stargazers","contributors_url":"https://api.github.com/repos/lampepfl/dotty/contributors","subscribers_url":"https://api.github.com/repos/lampepfl/dotty/subscribers","subscription_url":"https://api.github.com/repos/lampepfl/dotty/subscription","commits_url":"https://api.github.com/repos/lampepfl/dotty/commits{/sha}","git_commits_url":"https://api.github.com/repos/lampepfl/dotty/git/commits{/sha}","comments_url":"https://api.github.com/repos/lampepfl/dotty/comments{/number}","issue_comment_url":"https://api.github.com/repos/lampepfl/dotty/issues/comments{/number}","contents_url":"https://api.github.com/repos/lampepfl/dotty/contents/{+path}","compare_url":"https://api.github.com/repos/lampepfl/dotty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lampepfl/dotty/merges","archive_url":"https://api.github.com/repos/lampepfl/dotty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lampepfl/dotty/downloads","issues_url":"https://api.github.com/repos/lampepfl/dotty/issues{/number}","pulls_url":"https://api.github.com/repos/lampepfl/dotty/pulls{/number}","milestones_url":"https://api.github.com/repos/lampepfl/dotty/milestones{/number}","notifications_url":"https://api.github.com/repos/lampepfl/dotty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lampepfl/dotty/labels{/name}","releases_url":"https://api.github.com/repos/lampepfl/dotty/releases{/id}","deployments_url":"https://api.github.com/repos/lampepfl/dotty/deployments","created_at":"2012-12-06T12:57:33Z","updated_at":"2018-07-24T11:18:56Z","pushed_at":"2018-07-24T13:04:46Z","git_url":"git://github.com/lampepfl/dotty.git","ssh_url":"[email protected]:lampepfl/dotty.git","clone_url":"https://github.com/lampepfl/dotty.git","svn_url":"https://github.com/lampepfl/dotty","homepage":"http://dotty.epfl.ch","size":438249,"stargazers_count":2808,"watchers_count":2808,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":398,"mirror_url":null,"archived":false,"open_issues_count":424,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":398,"open_issues":424,"watchers":2808,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lampepfl/dotty/pulls/4645"},"html":{"href":"https://github.com/lampepfl/dotty/pull/4645"},"issue":{"href":"https://api.github.com/repos/lampepfl/dotty/issues/4645"},"comments":{"href":"https://api.github.com/repos/lampepfl/dotty/issues/4645/comments"},"review_comments":{"href":"https://api.github.com/repos/lampepfl/dotty/pulls/4645/comments"},"review_comment":{"href":"https://api.github.com/repos/lampepfl/dotty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lampepfl/dotty/pulls/4645/commits"},"statuses":{"href":"https://api.github.com/repos/lampepfl/dotty/statuses/74df64090892dcdc424f262fc3f3a7d145335fce"}},"author_association":"CONTRIBUTOR"}} | {
"id": 7035651,
"name": "lampepfl/dotty",
"url": "https://api.github.com/repos/lampepfl/dotty"
} | {
"id": 4996324,
"login": "allanrenucci",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4996324?",
"url": "https://api.github.com/users/allanrenucci"
} | {
"id": 2684793,
"login": "lampepfl",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2684793?",
"url": "https://api.github.com/orgs/lampepfl"
} | 2018-07-24T13:10:23 | 8010061944 | {"actor":{"display_login":"allanrenucci"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/LSSTDESC/Twinkles/pulls/comments/208747961","pull_request_review_id":144601173,"id":208747961,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODc0Nzk2MQ==","diff_hunk":"@@ -0,0 +1,67 @@\n+import os\n+import sys\n+import matplotlib as mpl\n+mpl.rcParams['text.usetex'] = False\n+import matplotlib.pyplot as plt\n+from desc.twinkles import validate_ic\n+\n+if __name__ == \"__main__\":\n+\n+ cat_folder = sys.argv[1]","path":"utils/run_validation.py","position":10,"original_position":10,"commit_id":"086817e723283000e807349ad19e265973058340","original_commit_id":"086817e723283000e807349ad19e265973058340","user":{"login":"danielsf","id":1682854,"node_id":"MDQ6VXNlcjE2ODI4NTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1682854?v=4","gravatar_id":"","url":"https://api.github.com/users/danielsf","html_url":"https://github.com/danielsf","followers_url":"https://api.github.com/users/danielsf/followers","following_url":"https://api.github.com/users/danielsf/following{/other_user}","gists_url":"https://api.github.com/users/danielsf/gists{/gist_id}","starred_url":"https://api.github.com/users/danielsf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielsf/subscriptions","organizations_url":"https://api.github.com/users/danielsf/orgs","repos_url":"https://api.github.com/users/danielsf/repos","events_url":"https://api.github.com/users/danielsf/events{/privacy}","received_events_url":"https://api.github.com/users/danielsf/received_events","type":"User","site_admin":false},"body":"How is this script meant to be run? If it is supposed to be run from the command line, can you use `argparse` to get the arguments so that `python utils/run_validation.py -h` gives some helpful information?","created_at":"2018-08-08T21:51:43Z","updated_at":"2018-08-08T21:54:04Z","html_url":"https://github.com/LSSTDESC/Twinkles/pull/473#discussion_r208747961","pull_request_url":"https://api.github.com/repos/LSSTDESC/Twinkles/pulls/473","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/LSSTDESC/Twinkles/pulls/comments/208747961"},"html":{"href":"https://github.com/LSSTDESC/Twinkles/pull/473#discussion_r208747961"},"pull_request":{"href":"https://api.github.com/repos/LSSTDESC/Twinkles/pulls/473"}}},"pull_request":{"url":"https://api.github.com/repos/LSSTDESC/Twinkles/pulls/473","id":198736282,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NzM2Mjgy","html_url":"https://github.com/LSSTDESC/Twinkles/pull/473","diff_url":"https://github.com/LSSTDESC/Twinkles/pull/473.diff","patch_url":"https://github.com/LSSTDESC/Twinkles/pull/473.patch","issue_url":"https://api.github.com/repos/LSSTDESC/Twinkles/issues/473","number":473,"state":"open","locked":false,"title":"Issue/467/ic validation","user":{"login":"jbkalmbach","id":4755090,"node_id":"MDQ6VXNlcjQ3NTUwOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/4755090?v=4","gravatar_id":"","url":"https://api.github.com/users/jbkalmbach","html_url":"https://github.com/jbkalmbach","followers_url":"https://api.github.com/users/jbkalmbach/followers","following_url":"https://api.github.com/users/jbkalmbach/following{/other_user}","gists_url":"https://api.github.com/users/jbkalmbach/gists{/gist_id}","starred_url":"https://api.github.com/users/jbkalmbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbkalmbach/subscriptions","organizations_url":"https://api.github.com/users/jbkalmbach/orgs","repos_url":"https://api.github.com/users/jbkalmbach/repos","events_url":"https://api.github.com/users/jbkalmbach/events{/privacy}","received_events_url":"https://api.github.com/users/jbkalmbach/received_events","type":"User","site_admin":false},"body":"Instance catalog validation tests. Not quite ready for full review but ready for discussion.","created_at":"2018-07-02T16:54:43Z","updated_at":"2018-08-08T21:54:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d960e314aa2db905b3e37d5a5e8e97ee929569a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jchiang87","id":1994473,"node_id":"MDQ6VXNlcjE5OTQ0NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1994473?v=4","gravatar_id":"","url":"https://api.github.com/users/jchiang87","html_url":"https://github.com/jchiang87","followers_url":"https://api.github.com/users/jchiang87/followers","following_url":"https://api.github.com/users/jchiang87/following{/other_user}","gists_url":"https://api.github.com/users/jchiang87/gists{/gist_id}","starred_url":"https://api.github.com/users/jchiang87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jchiang87/subscriptions","organizations_url":"https://api.github.com/users/jchiang87/orgs","repos_url":"https://api.github.com/users/jchiang87/repos","events_url":"https://api.github.com/users/jchiang87/events{/privacy}","received_events_url":"https://api.github.com/users/jchiang87/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/LSSTDESC/Twinkles/pulls/473/commits","review_comments_url":"https://api.github.com/repos/LSSTDESC/Twinkles/pulls/473/comments","review_comment_url":"https://api.github.com/repos/LSSTDESC/Twinkles/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LSSTDESC/Twinkles/issues/473/comments","statuses_url":"https://api.github.com/repos/LSSTDESC/Twinkles/statuses/086817e723283000e807349ad19e265973058340","head":{"label":"LSSTDESC:issue/467/ic_validation","ref":"issue/467/ic_validation","sha":"086817e723283000e807349ad19e265973058340","user":{"login":"LSSTDESC","id":2731443,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MzE0NDM=","avatar_url":"https://avatars1.githubusercontent.com/u/2731443?v=4","gravatar_id":"","url":"https://api.github.com/users/LSSTDESC","html_url":"https://github.com/LSSTDESC","followers_url":"https://api.github.com/users/LSSTDESC/followers","following_url":"https://api.github.com/users/LSSTDESC/following{/other_user}","gists_url":"https://api.github.com/users/LSSTDESC/gists{/gist_id}","starred_url":"https://api.github.com/users/LSSTDESC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LSSTDESC/subscriptions","organizations_url":"https://api.github.com/users/LSSTDESC/orgs","repos_url":"https://api.github.com/users/LSSTDESC/repos","events_url":"https://api.github.com/users/LSSTDESC/events{/privacy}","received_events_url":"https://api.github.com/users/LSSTDESC/received_events","type":"Organization","site_admin":false},"repo":{"id":25598726,"node_id":"MDEwOlJlcG9zaXRvcnkyNTU5ODcyNg==","name":"Twinkles","full_name":"LSSTDESC/Twinkles","owner":{"login":"LSSTDESC","id":2731443,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MzE0NDM=","avatar_url":"https://avatars1.githubusercontent.com/u/2731443?v=4","gravatar_id":"","url":"https://api.github.com/users/LSSTDESC","html_url":"https://github.com/LSSTDESC","followers_url":"https://api.github.com/users/LSSTDESC/followers","following_url":"https://api.github.com/users/LSSTDESC/following{/other_user}","gists_url":"https://api.github.com/users/LSSTDESC/gists{/gist_id}","starred_url":"https://api.github.com/users/LSSTDESC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LSSTDESC/subscriptions","organizations_url":"https://api.github.com/users/LSSTDESC/orgs","repos_url":"https://api.github.com/users/LSSTDESC/repos","events_url":"https://api.github.com/users/LSSTDESC/events{/privacy}","received_events_url":"https://api.github.com/users/LSSTDESC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LSSTDESC/Twinkles","description":"10 years. 6 filters. 1 tiny patch of sky. Thousands of time-variable cosmological distance probes.","fork":false,"url":"https://api.github.com/repos/LSSTDESC/Twinkles","forks_url":"https://api.github.com/repos/LSSTDESC/Twinkles/forks","keys_url":"https://api.github.com/repos/LSSTDESC/Twinkles/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LSSTDESC/Twinkles/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LSSTDESC/Twinkles/teams","hooks_url":"https://api.github.com/repos/LSSTDESC/Twinkles/hooks","issue_events_url":"https://api.github.com/repos/LSSTDESC/Twinkles/issues/events{/number}","events_url":"https://api.github.com/repos/LSSTDESC/Twinkles/events","assignees_url":"https://api.github.com/repos/LSSTDESC/Twinkles/assignees{/user}","branches_url":"https://api.github.com/repos/LSSTDESC/Twinkles/branches{/branch}","tags_url":"https://api.github.com/repos/LSSTDESC/Twinkles/tags","blobs_url":"https://api.github.com/repos/LSSTDESC/Twinkles/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LSSTDESC/Twinkles/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LSSTDESC/Twinkles/git/refs{/sha}","trees_url":"https://api.github.com/repos/LSSTDESC/Twinkles/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LSSTDESC/Twinkles/statuses/{sha}","languages_url":"https://api.github.com/repos/LSSTDESC/Twinkles/languages","stargazers_url":"https://api.github.com/repos/LSSTDESC/Twinkles/stargazers","contributors_url":"https://api.github.com/repos/LSSTDESC/Twinkles/contributors","subscribers_url":"https://api.github.com/repos/LSSTDESC/Twinkles/subscribers","subscription_url":"https://api.github.com/repos/LSSTDESC/Twinkles/subscription","commits_url":"https://api.github.com/repos/LSSTDESC/Twinkles/commits{/sha}","git_commits_url":"https://api.github.com/repos/LSSTDESC/Twinkles/git/commits{/sha}","comments_url":"https://api.github.com/repos/LSSTDESC/Twinkles/comments{/number}","issue_comment_url":"https://api.github.com/repos/LSSTDESC/Twinkles/issues/comments{/number}","contents_url":"https://api.github.com/repos/LSSTDESC/Twinkles/contents/{+path}","compare_url":"https://api.github.com/repos/LSSTDESC/Twinkles/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LSSTDESC/Twinkles/merges","archive_url":"https://api.github.com/repos/LSSTDESC/Twinkles/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LSSTDESC/Twinkles/downloads","issues_url":"https://api.github.com/repos/LSSTDESC/Twinkles/issues{/number}","pulls_url":"https://api.github.com/repos/LSSTDESC/Twinkles/pulls{/number}","milestones_url":"https://api.github.com/repos/LSSTDESC/Twinkles/milestones{/number}","notifications_url":"https://api.github.com/repos/LSSTDESC/Twinkles/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LSSTDESC/Twinkles/labels{/name}","releases_url":"https://api.github.com/repos/LSSTDESC/Twinkles/releases{/id}","deployments_url":"https://api.github.com/repos/LSSTDESC/Twinkles/deployments","created_at":"2014-10-22T18:58:04Z","updated_at":"2018-08-07T23:06:43Z","pushed_at":"2018-08-07T23:06:36Z","git_url":"git://github.com/LSSTDESC/Twinkles.git","ssh_url":"[email protected]:LSSTDESC/Twinkles.git","clone_url":"https://github.com/LSSTDESC/Twinkles.git","svn_url":"https://github.com/LSSTDESC/Twinkles","homepage":null,"size":167290,"stargazers_count":13,"watchers_count":13,"language":"OpenEdge ABL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":100,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11,"open_issues":100,"watchers":13,"default_branch":"master"}},"base":{"label":"LSSTDESC:master","ref":"master","sha":"90e2a472b7e1ffba1c88c80389fd802d4fd57b11","user":{"login":"LSSTDESC","id":2731443,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MzE0NDM=","avatar_url":"https://avatars1.githubusercontent.com/u/2731443?v=4","gravatar_id":"","url":"https://api.github.com/users/LSSTDESC","html_url":"https://github.com/LSSTDESC","followers_url":"https://api.github.com/users/LSSTDESC/followers","following_url":"https://api.github.com/users/LSSTDESC/following{/other_user}","gists_url":"https://api.github.com/users/LSSTDESC/gists{/gist_id}","starred_url":"https://api.github.com/users/LSSTDESC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LSSTDESC/subscriptions","organizations_url":"https://api.github.com/users/LSSTDESC/orgs","repos_url":"https://api.github.com/users/LSSTDESC/repos","events_url":"https://api.github.com/users/LSSTDESC/events{/privacy}","received_events_url":"https://api.github.com/users/LSSTDESC/received_events","type":"Organization","site_admin":false},"repo":{"id":25598726,"node_id":"MDEwOlJlcG9zaXRvcnkyNTU5ODcyNg==","name":"Twinkles","full_name":"LSSTDESC/Twinkles","owner":{"login":"LSSTDESC","id":2731443,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MzE0NDM=","avatar_url":"https://avatars1.githubusercontent.com/u/2731443?v=4","gravatar_id":"","url":"https://api.github.com/users/LSSTDESC","html_url":"https://github.com/LSSTDESC","followers_url":"https://api.github.com/users/LSSTDESC/followers","following_url":"https://api.github.com/users/LSSTDESC/following{/other_user}","gists_url":"https://api.github.com/users/LSSTDESC/gists{/gist_id}","starred_url":"https://api.github.com/users/LSSTDESC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LSSTDESC/subscriptions","organizations_url":"https://api.github.com/users/LSSTDESC/orgs","repos_url":"https://api.github.com/users/LSSTDESC/repos","events_url":"https://api.github.com/users/LSSTDESC/events{/privacy}","received_events_url":"https://api.github.com/users/LSSTDESC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LSSTDESC/Twinkles","description":"10 years. 6 filters. 1 tiny patch of sky. Thousands of time-variable cosmological distance probes.","fork":false,"url":"https://api.github.com/repos/LSSTDESC/Twinkles","forks_url":"https://api.github.com/repos/LSSTDESC/Twinkles/forks","keys_url":"https://api.github.com/repos/LSSTDESC/Twinkles/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LSSTDESC/Twinkles/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LSSTDESC/Twinkles/teams","hooks_url":"https://api.github.com/repos/LSSTDESC/Twinkles/hooks","issue_events_url":"https://api.github.com/repos/LSSTDESC/Twinkles/issues/events{/number}","events_url":"https://api.github.com/repos/LSSTDESC/Twinkles/events","assignees_url":"https://api.github.com/repos/LSSTDESC/Twinkles/assignees{/user}","branches_url":"https://api.github.com/repos/LSSTDESC/Twinkles/branches{/branch}","tags_url":"https://api.github.com/repos/LSSTDESC/Twinkles/tags","blobs_url":"https://api.github.com/repos/LSSTDESC/Twinkles/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LSSTDESC/Twinkles/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LSSTDESC/Twinkles/git/refs{/sha}","trees_url":"https://api.github.com/repos/LSSTDESC/Twinkles/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LSSTDESC/Twinkles/statuses/{sha}","languages_url":"https://api.github.com/repos/LSSTDESC/Twinkles/languages","stargazers_url":"https://api.github.com/repos/LSSTDESC/Twinkles/stargazers","contributors_url":"https://api.github.com/repos/LSSTDESC/Twinkles/contributors","subscribers_url":"https://api.github.com/repos/LSSTDESC/Twinkles/subscribers","subscription_url":"https://api.github.com/repos/LSSTDESC/Twinkles/subscription","commits_url":"https://api.github.com/repos/LSSTDESC/Twinkles/commits{/sha}","git_commits_url":"https://api.github.com/repos/LSSTDESC/Twinkles/git/commits{/sha}","comments_url":"https://api.github.com/repos/LSSTDESC/Twinkles/comments{/number}","issue_comment_url":"https://api.github.com/repos/LSSTDESC/Twinkles/issues/comments{/number}","contents_url":"https://api.github.com/repos/LSSTDESC/Twinkles/contents/{+path}","compare_url":"https://api.github.com/repos/LSSTDESC/Twinkles/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LSSTDESC/Twinkles/merges","archive_url":"https://api.github.com/repos/LSSTDESC/Twinkles/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LSSTDESC/Twinkles/downloads","issues_url":"https://api.github.com/repos/LSSTDESC/Twinkles/issues{/number}","pulls_url":"https://api.github.com/repos/LSSTDESC/Twinkles/pulls{/number}","milestones_url":"https://api.github.com/repos/LSSTDESC/Twinkles/milestones{/number}","notifications_url":"https://api.github.com/repos/LSSTDESC/Twinkles/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LSSTDESC/Twinkles/labels{/name}","releases_url":"https://api.github.com/repos/LSSTDESC/Twinkles/releases{/id}","deployments_url":"https://api.github.com/repos/LSSTDESC/Twinkles/deployments","created_at":"2014-10-22T18:58:04Z","updated_at":"2018-08-07T23:06:43Z","pushed_at":"2018-08-07T23:06:36Z","git_url":"git://github.com/LSSTDESC/Twinkles.git","ssh_url":"[email protected]:LSSTDESC/Twinkles.git","clone_url":"https://github.com/LSSTDESC/Twinkles.git","svn_url":"https://github.com/LSSTDESC/Twinkles","homepage":null,"size":167290,"stargazers_count":13,"watchers_count":13,"language":"OpenEdge ABL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":100,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11,"open_issues":100,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LSSTDESC/Twinkles/pulls/473"},"html":{"href":"https://github.com/LSSTDESC/Twinkles/pull/473"},"issue":{"href":"https://api.github.com/repos/LSSTDESC/Twinkles/issues/473"},"comments":{"href":"https://api.github.com/repos/LSSTDESC/Twinkles/issues/473/comments"},"review_comments":{"href":"https://api.github.com/repos/LSSTDESC/Twinkles/pulls/473/comments"},"review_comment":{"href":"https://api.github.com/repos/LSSTDESC/Twinkles/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LSSTDESC/Twinkles/pulls/473/commits"},"statuses":{"href":"https://api.github.com/repos/LSSTDESC/Twinkles/statuses/086817e723283000e807349ad19e265973058340"}},"author_association":"MEMBER"}} | {
"id": 25598726,
"name": "LSSTDESC/Twinkles",
"url": "https://api.github.com/repos/LSSTDESC/Twinkles"
} | {
"id": 1682854,
"login": "danielsf",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1682854?",
"url": "https://api.github.com/users/danielsf"
} | {
"id": 2731443,
"login": "LSSTDESC",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2731443?",
"url": "https://api.github.com/orgs/LSSTDESC"
} | 2018-08-08T21:51:43 | 8086737400 | {"actor":{"display_login":"danielsf"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/savoirfairelinux/project-addons/pulls/comments/238817501","pull_request_review_id":181447137,"id":238817501,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODgxNzUwMQ==","diff_hunk":"@@ -0,0 +1,81 @@\n+from datetime import datetime, timedelta\n+\n+from odoo import models, fields, api\n+from odoo.tools import DEFAULT_SERVER_DATE_FORMAT as DATE_FORMAT\n+\n+\n+class WeeklypReportWizard(models.TransientModel):\n+ _name = 'weekly.report.wizard'\n+\n+ date_start = fields.Date(string=\"Start Date\", required=True, default=fields.Date.today)\n+ date_end = fields.Date(string=\"End Date\", required=True, default=fields.Date.today)\n+ room_id = fields.Many2one(\n+ string='Room',\n+ comodel_name='resource.calendar.room',\n+ ondelete='set null',\n+ required=True,\n+ )\n+ recurrency = fields.Boolean(\n+ string='Recurrency',\n+ default=True,\n+ required=True,","path":"project_resource_calendar/wizard/weekly_report_wizard.py","position":21,"original_position":21,"commit_id":"cd4ea0246e1f74c329585305db23eb67ebc94701","original_commit_id":"cd4ea0246e1f74c329585305db23eb67ebc94701","user":{"login":"rimbendhaou","id":11257486,"node_id":"MDQ6VXNlcjExMjU3NDg2","avatar_url":"https://avatars2.githubusercontent.com/u/11257486?v=4","gravatar_id":"","url":"https://api.github.com/users/rimbendhaou","html_url":"https://github.com/rimbendhaou","followers_url":"https://api.github.com/users/rimbendhaou/followers","following_url":"https://api.github.com/users/rimbendhaou/following{/other_user}","gists_url":"https://api.github.com/users/rimbendhaou/gists{/gist_id}","starred_url":"https://api.github.com/users/rimbendhaou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rimbendhaou/subscriptions","organizations_url":"https://api.github.com/users/rimbendhaou/orgs","repos_url":"https://api.github.com/users/rimbendhaou/repos","events_url":"https://api.github.com/users/rimbendhaou/events{/privacy}","received_events_url":"https://api.github.com/users/rimbendhaou/received_events","type":"User","site_admin":false},"body":"why required: if it is not true so it is false","created_at":"2018-12-04T20:02:36Z","updated_at":"2018-12-04T20:33:38Z","html_url":"https://github.com/savoirfairelinux/project-addons/pull/233#discussion_r238817501","pull_request_url":"https://api.github.com/repos/savoirfairelinux/project-addons/pulls/233","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/savoirfairelinux/project-addons/pulls/comments/238817501"},"html":{"href":"https://github.com/savoirfairelinux/project-addons/pull/233#discussion_r238817501"},"pull_request":{"href":"https://api.github.com/repos/savoirfairelinux/project-addons/pulls/233"}}},"pull_request":{"url":"https://api.github.com/repos/savoirfairelinux/project-addons/pulls/233","id":235612408,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1NjEyNDA4","html_url":"https://github.com/savoirfairelinux/project-addons/pull/233","diff_url":"https://github.com/savoirfairelinux/project-addons/pull/233.diff","patch_url":"https://github.com/savoirfairelinux/project-addons/pull/233.patch","issue_url":"https://api.github.com/repos/savoirfairelinux/project-addons/issues/233","number":233,"state":"open","locked":false,"title":"[ADD] Weekly report by room","user":{"login":"eilst","id":12146356,"node_id":"MDQ6VXNlcjEyMTQ2MzU2","avatar_url":"https://avatars1.githubusercontent.com/u/12146356?v=4","gravatar_id":"","url":"https://api.github.com/users/eilst","html_url":"https://github.com/eilst","followers_url":"https://api.github.com/users/eilst/followers","following_url":"https://api.github.com/users/eilst/following{/other_user}","gists_url":"https://api.github.com/users/eilst/gists{/gist_id}","starred_url":"https://api.github.com/users/eilst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eilst/subscriptions","organizations_url":"https://api.github.com/users/eilst/orgs","repos_url":"https://api.github.com/users/eilst/repos","events_url":"https://api.github.com/users/eilst/events{/privacy}","received_events_url":"https://api.github.com/users/eilst/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-03T22:19:35Z","updated_at":"2018-12-04T20:33:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4140bc2af92edd0fba037878bd0b2f74a2e50afe","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jananjoy","id":4388740,"node_id":"MDQ6VXNlcjQzODg3NDA=","avatar_url":"https://avatars3.githubusercontent.com/u/4388740?v=4","gravatar_id":"","url":"https://api.github.com/users/jananjoy","html_url":"https://github.com/jananjoy","followers_url":"https://api.github.com/users/jananjoy/followers","following_url":"https://api.github.com/users/jananjoy/following{/other_user}","gists_url":"https://api.github.com/users/jananjoy/gists{/gist_id}","starred_url":"https://api.github.com/users/jananjoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jananjoy/subscriptions","organizations_url":"https://api.github.com/users/jananjoy/orgs","repos_url":"https://api.github.com/users/jananjoy/repos","events_url":"https://api.github.com/users/jananjoy/events{/privacy}","received_events_url":"https://api.github.com/users/jananjoy/received_events","type":"User","site_admin":false},{"login":"lgharib","id":43585585,"node_id":"MDQ6VXNlcjQzNTg1NTg1","avatar_url":"https://avatars0.githubusercontent.com/u/43585585?v=4","gravatar_id":"","url":"https://api.github.com/users/lgharib","html_url":"https://github.com/lgharib","followers_url":"https://api.github.com/users/lgharib/followers","following_url":"https://api.github.com/users/lgharib/following{/other_user}","gists_url":"https://api.github.com/users/lgharib/gists{/gist_id}","starred_url":"https://api.github.com/users/lgharib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgharib/subscriptions","organizations_url":"https://api.github.com/users/lgharib/orgs","repos_url":"https://api.github.com/users/lgharib/repos","events_url":"https://api.github.com/users/lgharib/events{/privacy}","received_events_url":"https://api.github.com/users/lgharib/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1130398846,"node_id":"MDU6TGFiZWwxMTMwMzk4ODQ2","url":"https://api.github.com/repos/savoirfairelinux/project-addons/labels/need%20review","name":"need review","color":"f99a1d","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/savoirfairelinux/project-addons/pulls/233/commits","review_comments_url":"https://api.github.com/repos/savoirfairelinux/project-addons/pulls/233/comments","review_comment_url":"https://api.github.com/repos/savoirfairelinux/project-addons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/savoirfairelinux/project-addons/issues/233/comments","statuses_url":"https://api.github.com/repos/savoirfairelinux/project-addons/statuses/cd4ea0246e1f74c329585305db23eb67ebc94701","head":{"label":"savoirfairelinux:lg_8_weekly_report","ref":"lg_8_weekly_report","sha":"cd4ea0246e1f74c329585305db23eb67ebc94701","user":{"login":"savoirfairelinux","id":2735545,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MzU1NDU=","avatar_url":"https://avatars3.githubusercontent.com/u/2735545?v=4","gravatar_id":"","url":"https://api.github.com/users/savoirfairelinux","html_url":"https://github.com/savoirfairelinux","followers_url":"https://api.github.com/users/savoirfairelinux/followers","following_url":"https://api.github.com/users/savoirfairelinux/following{/other_user}","gists_url":"https://api.github.com/users/savoirfairelinux/gists{/gist_id}","starred_url":"https://api.github.com/users/savoirfairelinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/savoirfairelinux/subscriptions","organizations_url":"https://api.github.com/users/savoirfairelinux/orgs","repos_url":"https://api.github.com/users/savoirfairelinux/repos","events_url":"https://api.github.com/users/savoirfairelinux/events{/privacy}","received_events_url":"https://api.github.com/users/savoirfairelinux/received_events","type":"Organization","site_admin":false},"repo":{"id":86372981,"node_id":"MDEwOlJlcG9zaXRvcnk4NjM3Mjk4MQ==","name":"project-addons","full_name":"savoirfairelinux/project-addons","private":false,"owner":{"login":"savoirfairelinux","id":2735545,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MzU1NDU=","avatar_url":"https://avatars3.githubusercontent.com/u/2735545?v=4","gravatar_id":"","url":"https://api.github.com/users/savoirfairelinux","html_url":"https://github.com/savoirfairelinux","followers_url":"https://api.github.com/users/savoirfairelinux/followers","following_url":"https://api.github.com/users/savoirfairelinux/following{/other_user}","gists_url":"https://api.github.com/users/savoirfairelinux/gists{/gist_id}","starred_url":"https://api.github.com/users/savoirfairelinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/savoirfairelinux/subscriptions","organizations_url":"https://api.github.com/users/savoirfairelinux/orgs","repos_url":"https://api.github.com/users/savoirfairelinux/repos","events_url":"https://api.github.com/users/savoirfairelinux/events{/privacy}","received_events_url":"https://api.github.com/users/savoirfairelinux/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/savoirfairelinux/project-addons","description":"Odoo project related addons","fork":false,"url":"https://api.github.com/repos/savoirfairelinux/project-addons","forks_url":"https://api.github.com/repos/savoirfairelinux/project-addons/forks","keys_url":"https://api.github.com/repos/savoirfairelinux/project-addons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/savoirfairelinux/project-addons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/savoirfairelinux/project-addons/teams","hooks_url":"https://api.github.com/repos/savoirfairelinux/project-addons/hooks","issue_events_url":"https://api.github.com/repos/savoirfairelinux/project-addons/issues/events{/number}","events_url":"https://api.github.com/repos/savoirfairelinux/project-addons/events","assignees_url":"https://api.github.com/repos/savoirfairelinux/project-addons/assignees{/user}","branches_url":"https://api.github.com/repos/savoirfairelinux/project-addons/branches{/branch}","tags_url":"https://api.github.com/repos/savoirfairelinux/project-addons/tags","blobs_url":"https://api.github.com/repos/savoirfairelinux/project-addons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/savoirfairelinux/project-addons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/savoirfairelinux/project-addons/git/refs{/sha}","trees_url":"https://api.github.com/repos/savoirfairelinux/project-addons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/savoirfairelinux/project-addons/statuses/{sha}","languages_url":"https://api.github.com/repos/savoirfairelinux/project-addons/languages","stargazers_url":"https://api.github.com/repos/savoirfairelinux/project-addons/stargazers","contributors_url":"https://api.github.com/repos/savoirfairelinux/project-addons/contributors","subscribers_url":"https://api.github.com/repos/savoirfairelinux/project-addons/subscribers","subscription_url":"https://api.github.com/repos/savoirfairelinux/project-addons/subscription","commits_url":"https://api.github.com/repos/savoirfairelinux/project-addons/commits{/sha}","git_commits_url":"https://api.github.com/repos/savoirfairelinux/project-addons/git/commits{/sha}","comments_url":"https://api.github.com/repos/savoirfairelinux/project-addons/comments{/number}","issue_comment_url":"https://api.github.com/repos/savoirfairelinux/project-addons/issues/comments{/number}","contents_url":"https://api.github.com/repos/savoirfairelinux/project-addons/contents/{+path}","compare_url":"https://api.github.com/repos/savoirfairelinux/project-addons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/savoirfairelinux/project-addons/merges","archive_url":"https://api.github.com/repos/savoirfairelinux/project-addons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/savoirfairelinux/project-addons/downloads","issues_url":"https://api.github.com/repos/savoirfairelinux/project-addons/issues{/number}","pulls_url":"https://api.github.com/repos/savoirfairelinux/project-addons/pulls{/number}","milestones_url":"https://api.github.com/repos/savoirfairelinux/project-addons/milestones{/number}","notifications_url":"https://api.github.com/repos/savoirfairelinux/project-addons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/savoirfairelinux/project-addons/labels{/name}","releases_url":"https://api.github.com/repos/savoirfairelinux/project-addons/releases{/id}","deployments_url":"https://api.github.com/repos/savoirfairelinux/project-addons/deployments","created_at":"2017-03-27T18:58:38Z","updated_at":"2018-12-04T19:44:50Z","pushed_at":"2018-12-04T20:32:32Z","git_url":"git://github.com/savoirfairelinux/project-addons.git","ssh_url":"[email protected]:savoirfairelinux/project-addons.git","clone_url":"https://github.com/savoirfairelinux/project-addons.git","svn_url":"https://github.com/savoirfairelinux/project-addons","homepage":null,"size":546,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":4,"open_issues":11,"watchers":5,"default_branch":"11.0"}},"base":{"label":"savoirfairelinux:11.0","ref":"11.0","sha":"6f3aaad42761baa6803cc7f9be3f21cc8fefa854","user":{"login":"savoirfairelinux","id":2735545,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MzU1NDU=","avatar_url":"https://avatars3.githubusercontent.com/u/2735545?v=4","gravatar_id":"","url":"https://api.github.com/users/savoirfairelinux","html_url":"https://github.com/savoirfairelinux","followers_url":"https://api.github.com/users/savoirfairelinux/followers","following_url":"https://api.github.com/users/savoirfairelinux/following{/other_user}","gists_url":"https://api.github.com/users/savoirfairelinux/gists{/gist_id}","starred_url":"https://api.github.com/users/savoirfairelinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/savoirfairelinux/subscriptions","organizations_url":"https://api.github.com/users/savoirfairelinux/orgs","repos_url":"https://api.github.com/users/savoirfairelinux/repos","events_url":"https://api.github.com/users/savoirfairelinux/events{/privacy}","received_events_url":"https://api.github.com/users/savoirfairelinux/received_events","type":"Organization","site_admin":false},"repo":{"id":86372981,"node_id":"MDEwOlJlcG9zaXRvcnk4NjM3Mjk4MQ==","name":"project-addons","full_name":"savoirfairelinux/project-addons","private":false,"owner":{"login":"savoirfairelinux","id":2735545,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MzU1NDU=","avatar_url":"https://avatars3.githubusercontent.com/u/2735545?v=4","gravatar_id":"","url":"https://api.github.com/users/savoirfairelinux","html_url":"https://github.com/savoirfairelinux","followers_url":"https://api.github.com/users/savoirfairelinux/followers","following_url":"https://api.github.com/users/savoirfairelinux/following{/other_user}","gists_url":"https://api.github.com/users/savoirfairelinux/gists{/gist_id}","starred_url":"https://api.github.com/users/savoirfairelinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/savoirfairelinux/subscriptions","organizations_url":"https://api.github.com/users/savoirfairelinux/orgs","repos_url":"https://api.github.com/users/savoirfairelinux/repos","events_url":"https://api.github.com/users/savoirfairelinux/events{/privacy}","received_events_url":"https://api.github.com/users/savoirfairelinux/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/savoirfairelinux/project-addons","description":"Odoo project related addons","fork":false,"url":"https://api.github.com/repos/savoirfairelinux/project-addons","forks_url":"https://api.github.com/repos/savoirfairelinux/project-addons/forks","keys_url":"https://api.github.com/repos/savoirfairelinux/project-addons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/savoirfairelinux/project-addons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/savoirfairelinux/project-addons/teams","hooks_url":"https://api.github.com/repos/savoirfairelinux/project-addons/hooks","issue_events_url":"https://api.github.com/repos/savoirfairelinux/project-addons/issues/events{/number}","events_url":"https://api.github.com/repos/savoirfairelinux/project-addons/events","assignees_url":"https://api.github.com/repos/savoirfairelinux/project-addons/assignees{/user}","branches_url":"https://api.github.com/repos/savoirfairelinux/project-addons/branches{/branch}","tags_url":"https://api.github.com/repos/savoirfairelinux/project-addons/tags","blobs_url":"https://api.github.com/repos/savoirfairelinux/project-addons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/savoirfairelinux/project-addons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/savoirfairelinux/project-addons/git/refs{/sha}","trees_url":"https://api.github.com/repos/savoirfairelinux/project-addons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/savoirfairelinux/project-addons/statuses/{sha}","languages_url":"https://api.github.com/repos/savoirfairelinux/project-addons/languages","stargazers_url":"https://api.github.com/repos/savoirfairelinux/project-addons/stargazers","contributors_url":"https://api.github.com/repos/savoirfairelinux/project-addons/contributors","subscribers_url":"https://api.github.com/repos/savoirfairelinux/project-addons/subscribers","subscription_url":"https://api.github.com/repos/savoirfairelinux/project-addons/subscription","commits_url":"https://api.github.com/repos/savoirfairelinux/project-addons/commits{/sha}","git_commits_url":"https://api.github.com/repos/savoirfairelinux/project-addons/git/commits{/sha}","comments_url":"https://api.github.com/repos/savoirfairelinux/project-addons/comments{/number}","issue_comment_url":"https://api.github.com/repos/savoirfairelinux/project-addons/issues/comments{/number}","contents_url":"https://api.github.com/repos/savoirfairelinux/project-addons/contents/{+path}","compare_url":"https://api.github.com/repos/savoirfairelinux/project-addons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/savoirfairelinux/project-addons/merges","archive_url":"https://api.github.com/repos/savoirfairelinux/project-addons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/savoirfairelinux/project-addons/downloads","issues_url":"https://api.github.com/repos/savoirfairelinux/project-addons/issues{/number}","pulls_url":"https://api.github.com/repos/savoirfairelinux/project-addons/pulls{/number}","milestones_url":"https://api.github.com/repos/savoirfairelinux/project-addons/milestones{/number}","notifications_url":"https://api.github.com/repos/savoirfairelinux/project-addons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/savoirfairelinux/project-addons/labels{/name}","releases_url":"https://api.github.com/repos/savoirfairelinux/project-addons/releases{/id}","deployments_url":"https://api.github.com/repos/savoirfairelinux/project-addons/deployments","created_at":"2017-03-27T18:58:38Z","updated_at":"2018-12-04T19:44:50Z","pushed_at":"2018-12-04T20:32:32Z","git_url":"git://github.com/savoirfairelinux/project-addons.git","ssh_url":"[email protected]:savoirfairelinux/project-addons.git","clone_url":"https://github.com/savoirfairelinux/project-addons.git","svn_url":"https://github.com/savoirfairelinux/project-addons","homepage":null,"size":546,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":4,"open_issues":11,"watchers":5,"default_branch":"11.0"}},"_links":{"self":{"href":"https://api.github.com/repos/savoirfairelinux/project-addons/pulls/233"},"html":{"href":"https://github.com/savoirfairelinux/project-addons/pull/233"},"issue":{"href":"https://api.github.com/repos/savoirfairelinux/project-addons/issues/233"},"comments":{"href":"https://api.github.com/repos/savoirfairelinux/project-addons/issues/233/comments"},"review_comments":{"href":"https://api.github.com/repos/savoirfairelinux/project-addons/pulls/233/comments"},"review_comment":{"href":"https://api.github.com/repos/savoirfairelinux/project-addons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/savoirfairelinux/project-addons/pulls/233/commits"},"statuses":{"href":"https://api.github.com/repos/savoirfairelinux/project-addons/statuses/cd4ea0246e1f74c329585305db23eb67ebc94701"}},"author_association":"MEMBER"}} | {
"id": 86372981,
"name": "savoirfairelinux/project-addons",
"url": "https://api.github.com/repos/savoirfairelinux/project-addons"
} | {
"id": 11257486,
"login": "rimbendhaou",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11257486?",
"url": "https://api.github.com/users/rimbendhaou"
} | {
"id": 2735545,
"login": "savoirfairelinux",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2735545?",
"url": "https://api.github.com/orgs/savoirfairelinux"
} | 2018-12-04T20:02:36 | 8697534736 | {"actor":{"display_login":"rimbendhaou"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/capriza/node-busmq/pulls/comments/234901094","pull_request_review_id":176640169,"id":234901094,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDkwMTA5NA==","diff_hunk":"@@ -409,7 +410,7 @@ Service.prototype._handleRequest = function(request, id) {\n this._touchRequester(request.replyTo);\n \n // sends the reply back to the requester\n- _reply = function(err, reply) {\n+ _reply = function(err, reply, intermediateReply) {","path":"lib/service.js","position":32,"original_position":32,"commit_id":"be9f770334fb8235c6d0530a7f83aba3aa0bb0d1","original_commit_id":"be9f770334fb8235c6d0530a7f83aba3aa0bb0d1","user":{"login":"fujifish","id":3403305,"node_id":"MDQ6VXNlcjM0MDMzMDU=","avatar_url":"https://avatars2.githubusercontent.com/u/3403305?v=4","gravatar_id":"","url":"https://api.github.com/users/fujifish","html_url":"https://github.com/fujifish","followers_url":"https://api.github.com/users/fujifish/followers","following_url":"https://api.github.com/users/fujifish/following{/other_user}","gists_url":"https://api.github.com/users/fujifish/gists{/gist_id}","starred_url":"https://api.github.com/users/fujifish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fujifish/subscriptions","organizations_url":"https://api.github.com/users/fujifish/orgs","repos_url":"https://api.github.com/users/fujifish/repos","events_url":"https://api.github.com/users/fujifish/events{/privacy}","received_events_url":"https://api.github.com/users/fujifish/received_events","type":"User","site_admin":false},"body":"I think it would also be good to add a \"createWriteStream\" method on the _reply function so that it would be possible to use stream piping and generally be more friendly. Something in the lines of:\r\n\r\n```javascript\r\n_reply.createWriteStream = function() {\r\n return new Writable({\r\n _write(chunk, encoding, cb) {\r\n requester.q.push({ err: err, reply: chunk, reqId: request.reqId, intermediateReply: true });\r\n cb && cb();\r\n },\r\n _final(cb) {\r\n requester.q.push({ err: err, reqId: request.reqId});\r\n cb && cb();\r\n }\r\n});\r\n};\r\n```\r\n\r\nAnd when using:\r\n\r\n```javascript\r\ns.on(\"request\", function(request, reply) {\r\n var stream = reply.createWriteStream();\r\n stream.write(chunk1);\r\n stream.write(chunk2);\r\n stream.end(chunk3);\r\n});\r\n```\r\n\r\nWDYT?\r\n","created_at":"2018-11-20T08:07:44Z","updated_at":"2018-11-20T08:07:45Z","html_url":"https://github.com/capriza/node-busmq/pull/60#discussion_r234901094","pull_request_url":"https://api.github.com/repos/capriza/node-busmq/pulls/60","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/capriza/node-busmq/pulls/comments/234901094"},"html":{"href":"https://github.com/capriza/node-busmq/pull/60#discussion_r234901094"},"pull_request":{"href":"https://api.github.com/repos/capriza/node-busmq/pulls/60"}}},"pull_request":{"url":"https://api.github.com/repos/capriza/node-busmq/pulls/60","id":231990376,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxOTkwMzc2","html_url":"https://github.com/capriza/node-busmq/pull/60","diff_url":"https://github.com/capriza/node-busmq/pull/60.diff","patch_url":"https://github.com/capriza/node-busmq/pull/60.patch","issue_url":"https://api.github.com/repos/capriza/node-busmq/issues/60","number":60,"state":"open","locked":false,"title":"Allow intermediate reply","user":{"login":"TD092854","id":5929390,"node_id":"MDQ6VXNlcjU5MjkzOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/5929390?v=4","gravatar_id":"","url":"https://api.github.com/users/TD092854","html_url":"https://github.com/TD092854","followers_url":"https://api.github.com/users/TD092854/followers","following_url":"https://api.github.com/users/TD092854/following{/other_user}","gists_url":"https://api.github.com/users/TD092854/gists{/gist_id}","starred_url":"https://api.github.com/users/TD092854/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TD092854/subscriptions","organizations_url":"https://api.github.com/users/TD092854/orgs","repos_url":"https://api.github.com/users/TD092854/repos","events_url":"https://api.github.com/users/TD092854/events{/privacy}","received_events_url":"https://api.github.com/users/TD092854/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nI've added functionality to the service to allow for intermediate replies to a request.\r\nThis can be used to indicate if the service is actually fulfilling the request or make a sort of streaming reply possible. \r\n\r\nIn our case we want to replace the inter service HTTP communication with a message bus to simplify configuration and deployment. We have a few HTTP endpoints that stream data and using intermediate replies on the bus we can keep this behavior.","created_at":"2018-11-19T14:22:15Z","updated_at":"2018-11-20T08:07:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc7b5eab5eca9ce6841849fbe176e047b0ad9f77","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/capriza/node-busmq/pulls/60/commits","review_comments_url":"https://api.github.com/repos/capriza/node-busmq/pulls/60/comments","review_comment_url":"https://api.github.com/repos/capriza/node-busmq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/capriza/node-busmq/issues/60/comments","statuses_url":"https://api.github.com/repos/capriza/node-busmq/statuses/be9f770334fb8235c6d0530a7f83aba3aa0bb0d1","head":{"label":"TD092854:master","ref":"master","sha":"be9f770334fb8235c6d0530a7f83aba3aa0bb0d1","user":{"login":"TD092854","id":5929390,"node_id":"MDQ6VXNlcjU5MjkzOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/5929390?v=4","gravatar_id":"","url":"https://api.github.com/users/TD092854","html_url":"https://github.com/TD092854","followers_url":"https://api.github.com/users/TD092854/followers","following_url":"https://api.github.com/users/TD092854/following{/other_user}","gists_url":"https://api.github.com/users/TD092854/gists{/gist_id}","starred_url":"https://api.github.com/users/TD092854/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TD092854/subscriptions","organizations_url":"https://api.github.com/users/TD092854/orgs","repos_url":"https://api.github.com/users/TD092854/repos","events_url":"https://api.github.com/users/TD092854/events{/privacy}","received_events_url":"https://api.github.com/users/TD092854/received_events","type":"User","site_admin":false},"repo":{"id":158229114,"node_id":"MDEwOlJlcG9zaXRvcnkxNTgyMjkxMTQ=","name":"node-busmq","full_name":"TD092854/node-busmq","private":false,"owner":{"login":"TD092854","id":5929390,"node_id":"MDQ6VXNlcjU5MjkzOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/5929390?v=4","gravatar_id":"","url":"https://api.github.com/users/TD092854","html_url":"https://github.com/TD092854","followers_url":"https://api.github.com/users/TD092854/followers","following_url":"https://api.github.com/users/TD092854/following{/other_user}","gists_url":"https://api.github.com/users/TD092854/gists{/gist_id}","starred_url":"https://api.github.com/users/TD092854/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TD092854/subscriptions","organizations_url":"https://api.github.com/users/TD092854/orgs","repos_url":"https://api.github.com/users/TD092854/repos","events_url":"https://api.github.com/users/TD092854/events{/privacy}","received_events_url":"https://api.github.com/users/TD092854/received_events","type":"User","site_admin":false},"html_url":"https://github.com/TD092854/node-busmq","description":"A high performance, highly-available and scalable, message bus and queueing system for node.js backed by Redis","fork":true,"url":"https://api.github.com/repos/TD092854/node-busmq","forks_url":"https://api.github.com/repos/TD092854/node-busmq/forks","keys_url":"https://api.github.com/repos/TD092854/node-busmq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TD092854/node-busmq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TD092854/node-busmq/teams","hooks_url":"https://api.github.com/repos/TD092854/node-busmq/hooks","issue_events_url":"https://api.github.com/repos/TD092854/node-busmq/issues/events{/number}","events_url":"https://api.github.com/repos/TD092854/node-busmq/events","assignees_url":"https://api.github.com/repos/TD092854/node-busmq/assignees{/user}","branches_url":"https://api.github.com/repos/TD092854/node-busmq/branches{/branch}","tags_url":"https://api.github.com/repos/TD092854/node-busmq/tags","blobs_url":"https://api.github.com/repos/TD092854/node-busmq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TD092854/node-busmq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TD092854/node-busmq/git/refs{/sha}","trees_url":"https://api.github.com/repos/TD092854/node-busmq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TD092854/node-busmq/statuses/{sha}","languages_url":"https://api.github.com/repos/TD092854/node-busmq/languages","stargazers_url":"https://api.github.com/repos/TD092854/node-busmq/stargazers","contributors_url":"https://api.github.com/repos/TD092854/node-busmq/contributors","subscribers_url":"https://api.github.com/repos/TD092854/node-busmq/subscribers","subscription_url":"https://api.github.com/repos/TD092854/node-busmq/subscription","commits_url":"https://api.github.com/repos/TD092854/node-busmq/commits{/sha}","git_commits_url":"https://api.github.com/repos/TD092854/node-busmq/git/commits{/sha}","comments_url":"https://api.github.com/repos/TD092854/node-busmq/comments{/number}","issue_comment_url":"https://api.github.com/repos/TD092854/node-busmq/issues/comments{/number}","contents_url":"https://api.github.com/repos/TD092854/node-busmq/contents/{+path}","compare_url":"https://api.github.com/repos/TD092854/node-busmq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TD092854/node-busmq/merges","archive_url":"https://api.github.com/repos/TD092854/node-busmq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TD092854/node-busmq/downloads","issues_url":"https://api.github.com/repos/TD092854/node-busmq/issues{/number}","pulls_url":"https://api.github.com/repos/TD092854/node-busmq/pulls{/number}","milestones_url":"https://api.github.com/repos/TD092854/node-busmq/milestones{/number}","notifications_url":"https://api.github.com/repos/TD092854/node-busmq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TD092854/node-busmq/labels{/name}","releases_url":"https://api.github.com/repos/TD092854/node-busmq/releases{/id}","deployments_url":"https://api.github.com/repos/TD092854/node-busmq/deployments","created_at":"2018-11-19T13:37:21Z","updated_at":"2018-11-19T14:12:44Z","pushed_at":"2018-11-19T14:12:42Z","git_url":"git://github.com/TD092854/node-busmq.git","ssh_url":"[email protected]:TD092854/node-busmq.git","clone_url":"https://github.com/TD092854/node-busmq.git","svn_url":"https://github.com/TD092854/node-busmq","homepage":"","size":4587,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"capriza:master","ref":"master","sha":"afeaeb3da9374006672a07d80e169176028d19e9","user":{"login":"capriza","id":2735864,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MzU4NjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2735864?v=4","gravatar_id":"","url":"https://api.github.com/users/capriza","html_url":"https://github.com/capriza","followers_url":"https://api.github.com/users/capriza/followers","following_url":"https://api.github.com/users/capriza/following{/other_user}","gists_url":"https://api.github.com/users/capriza/gists{/gist_id}","starred_url":"https://api.github.com/users/capriza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/capriza/subscriptions","organizations_url":"https://api.github.com/users/capriza/orgs","repos_url":"https://api.github.com/users/capriza/repos","events_url":"https://api.github.com/users/capriza/events{/privacy}","received_events_url":"https://api.github.com/users/capriza/received_events","type":"Organization","site_admin":false},"repo":{"id":24260061,"node_id":"MDEwOlJlcG9zaXRvcnkyNDI2MDA2MQ==","name":"node-busmq","full_name":"capriza/node-busmq","private":false,"owner":{"login":"capriza","id":2735864,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MzU4NjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2735864?v=4","gravatar_id":"","url":"https://api.github.com/users/capriza","html_url":"https://github.com/capriza","followers_url":"https://api.github.com/users/capriza/followers","following_url":"https://api.github.com/users/capriza/following{/other_user}","gists_url":"https://api.github.com/users/capriza/gists{/gist_id}","starred_url":"https://api.github.com/users/capriza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/capriza/subscriptions","organizations_url":"https://api.github.com/users/capriza/orgs","repos_url":"https://api.github.com/users/capriza/repos","events_url":"https://api.github.com/users/capriza/events{/privacy}","received_events_url":"https://api.github.com/users/capriza/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/capriza/node-busmq","description":"A high performance, highly-available and scalable, message bus and queueing system for node.js backed by Redis","fork":false,"url":"https://api.github.com/repos/capriza/node-busmq","forks_url":"https://api.github.com/repos/capriza/node-busmq/forks","keys_url":"https://api.github.com/repos/capriza/node-busmq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/capriza/node-busmq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/capriza/node-busmq/teams","hooks_url":"https://api.github.com/repos/capriza/node-busmq/hooks","issue_events_url":"https://api.github.com/repos/capriza/node-busmq/issues/events{/number}","events_url":"https://api.github.com/repos/capriza/node-busmq/events","assignees_url":"https://api.github.com/repos/capriza/node-busmq/assignees{/user}","branches_url":"https://api.github.com/repos/capriza/node-busmq/branches{/branch}","tags_url":"https://api.github.com/repos/capriza/node-busmq/tags","blobs_url":"https://api.github.com/repos/capriza/node-busmq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/capriza/node-busmq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/capriza/node-busmq/git/refs{/sha}","trees_url":"https://api.github.com/repos/capriza/node-busmq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/capriza/node-busmq/statuses/{sha}","languages_url":"https://api.github.com/repos/capriza/node-busmq/languages","stargazers_url":"https://api.github.com/repos/capriza/node-busmq/stargazers","contributors_url":"https://api.github.com/repos/capriza/node-busmq/contributors","subscribers_url":"https://api.github.com/repos/capriza/node-busmq/subscribers","subscription_url":"https://api.github.com/repos/capriza/node-busmq/subscription","commits_url":"https://api.github.com/repos/capriza/node-busmq/commits{/sha}","git_commits_url":"https://api.github.com/repos/capriza/node-busmq/git/commits{/sha}","comments_url":"https://api.github.com/repos/capriza/node-busmq/comments{/number}","issue_comment_url":"https://api.github.com/repos/capriza/node-busmq/issues/comments{/number}","contents_url":"https://api.github.com/repos/capriza/node-busmq/contents/{+path}","compare_url":"https://api.github.com/repos/capriza/node-busmq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/capriza/node-busmq/merges","archive_url":"https://api.github.com/repos/capriza/node-busmq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/capriza/node-busmq/downloads","issues_url":"https://api.github.com/repos/capriza/node-busmq/issues{/number}","pulls_url":"https://api.github.com/repos/capriza/node-busmq/pulls{/number}","milestones_url":"https://api.github.com/repos/capriza/node-busmq/milestones{/number}","notifications_url":"https://api.github.com/repos/capriza/node-busmq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/capriza/node-busmq/labels{/name}","releases_url":"https://api.github.com/repos/capriza/node-busmq/releases{/id}","deployments_url":"https://api.github.com/repos/capriza/node-busmq/deployments","created_at":"2014-09-20T10:27:45Z","updated_at":"2018-11-14T09:57:46Z","pushed_at":"2018-11-19T14:22:16Z","git_url":"git://github.com/capriza/node-busmq.git","ssh_url":"[email protected]:capriza/node-busmq.git","clone_url":"https://github.com/capriza/node-busmq.git","svn_url":"https://github.com/capriza/node-busmq","homepage":"","size":4583,"stargazers_count":192,"watchers_count":192,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":20,"open_issues":3,"watchers":192,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/capriza/node-busmq/pulls/60"},"html":{"href":"https://github.com/capriza/node-busmq/pull/60"},"issue":{"href":"https://api.github.com/repos/capriza/node-busmq/issues/60"},"comments":{"href":"https://api.github.com/repos/capriza/node-busmq/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/capriza/node-busmq/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/capriza/node-busmq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/capriza/node-busmq/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/capriza/node-busmq/statuses/be9f770334fb8235c6d0530a7f83aba3aa0bb0d1"}},"author_association":"NONE"}} | {
"id": 24260061,
"name": "capriza/node-busmq",
"url": "https://api.github.com/repos/capriza/node-busmq"
} | {
"id": 3403305,
"login": "fujifish",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3403305?",
"url": "https://api.github.com/users/fujifish"
} | {
"id": 2735864,
"login": "capriza",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2735864?",
"url": "https://api.github.com/orgs/capriza"
} | 2018-11-20T08:07:44 | 8618000492 | {"actor":{"display_login":"fujifish"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/spacetelescope/jwql/pulls/comments/240244795","pull_request_review_id":183228764,"id":240244795,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDI0NDc5NQ==","diff_hunk":"@@ -0,0 +1,311 @@\n+#! /usr/bin/env python\n+\n+\"\"\"This module monitors the status of JWQL monitors run via cron job via log files. Basic","path":"jwql/jwql_monitors/monitor_cron_jobs.py","position":3,"original_position":3,"commit_id":"426b03ee54f3fa80ffd7194007042fbd50544256","original_commit_id":"426b03ee54f3fa80ffd7194007042fbd50544256","user":{"login":"bhilbert4","id":11775426,"node_id":"MDQ6VXNlcjExNzc1NDI2","avatar_url":"https://avatars3.githubusercontent.com/u/11775426?v=4","gravatar_id":"","url":"https://api.github.com/users/bhilbert4","html_url":"https://github.com/bhilbert4","followers_url":"https://api.github.com/users/bhilbert4/followers","following_url":"https://api.github.com/users/bhilbert4/following{/other_user}","gists_url":"https://api.github.com/users/bhilbert4/gists{/gist_id}","starred_url":"https://api.github.com/users/bhilbert4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhilbert4/subscriptions","organizations_url":"https://api.github.com/users/bhilbert4/orgs","repos_url":"https://api.github.com/users/bhilbert4/repos","events_url":"https://api.github.com/users/bhilbert4/events{/privacy}","received_events_url":"https://api.github.com/users/bhilbert4/received_events","type":"User","site_admin":false},"body":"Rearranged.","created_at":"2018-12-10T15:03:30Z","updated_at":"2018-12-10T15:03:31Z","html_url":"https://github.com/spacetelescope/jwql/pull/202#discussion_r240244795","pull_request_url":"https://api.github.com/repos/spacetelescope/jwql/pulls/202","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/spacetelescope/jwql/pulls/comments/240244795"},"html":{"href":"https://github.com/spacetelescope/jwql/pull/202#discussion_r240244795"},"pull_request":{"href":"https://api.github.com/repos/spacetelescope/jwql/pulls/202"}},"in_reply_to_id":239630314},"pull_request":{"url":"https://api.github.com/repos/spacetelescope/jwql/pulls/202","id":234803417,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0ODAzNDE3","html_url":"https://github.com/spacetelescope/jwql/pull/202","diff_url":"https://github.com/spacetelescope/jwql/pull/202.diff","patch_url":"https://github.com/spacetelescope/jwql/pull/202.patch","issue_url":"https://api.github.com/repos/spacetelescope/jwql/issues/202","number":202,"state":"open","locked":false,"title":"Add cron job monitor table to web app","user":{"login":"bhilbert4","id":11775426,"node_id":"MDQ6VXNlcjExNzc1NDI2","avatar_url":"https://avatars3.githubusercontent.com/u/11775426?v=4","gravatar_id":"","url":"https://api.github.com/users/bhilbert4","html_url":"https://github.com/bhilbert4","followers_url":"https://api.github.com/users/bhilbert4/followers","following_url":"https://api.github.com/users/bhilbert4/following{/other_user}","gists_url":"https://api.github.com/users/bhilbert4/gists{/gist_id}","starred_url":"https://api.github.com/users/bhilbert4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhilbert4/subscriptions","organizations_url":"https://api.github.com/users/bhilbert4/orgs","repos_url":"https://api.github.com/users/bhilbert4/repos","events_url":"https://api.github.com/users/bhilbert4/events{/privacy}","received_events_url":"https://api.github.com/users/bhilbert4/received_events","type":"User","site_admin":false},"body":"This PR makes several updates to the `jwql` package:\r\n\r\n* Introduces code to add a cron job monitor to the `jwql` package and accompanying table to the web app. \r\n* Updates all references to Bokeh library in html files to version 1.0.1\r\n* Updates environment file and setup.py to use Bokeh 1.0.1\r\n* Updates environment file to correctly install the latest version of the `jwst` package and its dependencies. (`jwst` requires a yet-to-be released version of `astropy`)\r\n\r\nCurrently, the new functionality is contained in `monitor_cron_jobs.py`, which is called within the `get_dashboard_components` method in `data_containers.py`, and therefore is run each time the dashboard page of the website is loaded.\r\n","created_at":"2018-11-29T22:09:39Z","updated_at":"2018-12-10T15:03:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"bhilbert4","id":11775426,"node_id":"MDQ6VXNlcjExNzc1NDI2","avatar_url":"https://avatars3.githubusercontent.com/u/11775426?v=4","gravatar_id":"","url":"https://api.github.com/users/bhilbert4","html_url":"https://github.com/bhilbert4","followers_url":"https://api.github.com/users/bhilbert4/followers","following_url":"https://api.github.com/users/bhilbert4/following{/other_user}","gists_url":"https://api.github.com/users/bhilbert4/gists{/gist_id}","starred_url":"https://api.github.com/users/bhilbert4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhilbert4/subscriptions","organizations_url":"https://api.github.com/users/bhilbert4/orgs","repos_url":"https://api.github.com/users/bhilbert4/repos","events_url":"https://api.github.com/users/bhilbert4/events{/privacy}","received_events_url":"https://api.github.com/users/bhilbert4/received_events","type":"User","site_admin":false},"assignees":[{"login":"bhilbert4","id":11775426,"node_id":"MDQ6VXNlcjExNzc1NDI2","avatar_url":"https://avatars3.githubusercontent.com/u/11775426?v=4","gravatar_id":"","url":"https://api.github.com/users/bhilbert4","html_url":"https://github.com/bhilbert4","followers_url":"https://api.github.com/users/bhilbert4/followers","following_url":"https://api.github.com/users/bhilbert4/following{/other_user}","gists_url":"https://api.github.com/users/bhilbert4/gists{/gist_id}","starred_url":"https://api.github.com/users/bhilbert4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhilbert4/subscriptions","organizations_url":"https://api.github.com/users/bhilbert4/orgs","repos_url":"https://api.github.com/users/bhilbert4/repos","events_url":"https://api.github.com/users/bhilbert4/events{/privacy}","received_events_url":"https://api.github.com/users/bhilbert4/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":749115772,"node_id":"MDU6TGFiZWw3NDkxMTU3NzI=","url":"https://api.github.com/repos/spacetelescope/jwql/labels/Medium%20Priority","name":"Medium Priority","color":"0052cc","default":false},{"id":749114262,"node_id":"MDU6TGFiZWw3NDkxMTQyNjI=","url":"https://api.github.com/repos/spacetelescope/jwql/labels/Web%20Application","name":"Web Application","color":"1d76db","default":false},{"id":742310104,"node_id":"MDU6TGFiZWw3NDIzMTAxMDQ=","url":"https://api.github.com/repos/spacetelescope/jwql/labels/enhancement","name":"enhancement","color":"c2e0c6","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/spacetelescope/jwql/pulls/202/commits","review_comments_url":"https://api.github.com/repos/spacetelescope/jwql/pulls/202/comments","review_comment_url":"https://api.github.com/repos/spacetelescope/jwql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spacetelescope/jwql/issues/202/comments","statuses_url":"https://api.github.com/repos/spacetelescope/jwql/statuses/426b03ee54f3fa80ffd7194007042fbd50544256","head":{"label":"bhilbert4:add-cron-status","ref":"add-cron-status","sha":"426b03ee54f3fa80ffd7194007042fbd50544256","user":{"login":"bhilbert4","id":11775426,"node_id":"MDQ6VXNlcjExNzc1NDI2","avatar_url":"https://avatars3.githubusercontent.com/u/11775426?v=4","gravatar_id":"","url":"https://api.github.com/users/bhilbert4","html_url":"https://github.com/bhilbert4","followers_url":"https://api.github.com/users/bhilbert4/followers","following_url":"https://api.github.com/users/bhilbert4/following{/other_user}","gists_url":"https://api.github.com/users/bhilbert4/gists{/gist_id}","starred_url":"https://api.github.com/users/bhilbert4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhilbert4/subscriptions","organizations_url":"https://api.github.com/users/bhilbert4/orgs","repos_url":"https://api.github.com/users/bhilbert4/repos","events_url":"https://api.github.com/users/bhilbert4/events{/privacy}","received_events_url":"https://api.github.com/users/bhilbert4/received_events","type":"User","site_admin":false},"repo":{"id":146640861,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY2NDA4NjE=","name":"jwql","full_name":"bhilbert4/jwql","private":false,"owner":{"login":"bhilbert4","id":11775426,"node_id":"MDQ6VXNlcjExNzc1NDI2","avatar_url":"https://avatars3.githubusercontent.com/u/11775426?v=4","gravatar_id":"","url":"https://api.github.com/users/bhilbert4","html_url":"https://github.com/bhilbert4","followers_url":"https://api.github.com/users/bhilbert4/followers","following_url":"https://api.github.com/users/bhilbert4/following{/other_user}","gists_url":"https://api.github.com/users/bhilbert4/gists{/gist_id}","starred_url":"https://api.github.com/users/bhilbert4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhilbert4/subscriptions","organizations_url":"https://api.github.com/users/bhilbert4/orgs","repos_url":"https://api.github.com/users/bhilbert4/repos","events_url":"https://api.github.com/users/bhilbert4/events{/privacy}","received_events_url":"https://api.github.com/users/bhilbert4/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bhilbert4/jwql","description":"The James Webb Quicklook Application","fork":true,"url":"https://api.github.com/repos/bhilbert4/jwql","forks_url":"https://api.github.com/repos/bhilbert4/jwql/forks","keys_url":"https://api.github.com/repos/bhilbert4/jwql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bhilbert4/jwql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bhilbert4/jwql/teams","hooks_url":"https://api.github.com/repos/bhilbert4/jwql/hooks","issue_events_url":"https://api.github.com/repos/bhilbert4/jwql/issues/events{/number}","events_url":"https://api.github.com/repos/bhilbert4/jwql/events","assignees_url":"https://api.github.com/repos/bhilbert4/jwql/assignees{/user}","branches_url":"https://api.github.com/repos/bhilbert4/jwql/branches{/branch}","tags_url":"https://api.github.com/repos/bhilbert4/jwql/tags","blobs_url":"https://api.github.com/repos/bhilbert4/jwql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bhilbert4/jwql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bhilbert4/jwql/git/refs{/sha}","trees_url":"https://api.github.com/repos/bhilbert4/jwql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bhilbert4/jwql/statuses/{sha}","languages_url":"https://api.github.com/repos/bhilbert4/jwql/languages","stargazers_url":"https://api.github.com/repos/bhilbert4/jwql/stargazers","contributors_url":"https://api.github.com/repos/bhilbert4/jwql/contributors","subscribers_url":"https://api.github.com/repos/bhilbert4/jwql/subscribers","subscription_url":"https://api.github.com/repos/bhilbert4/jwql/subscription","commits_url":"https://api.github.com/repos/bhilbert4/jwql/commits{/sha}","git_commits_url":"https://api.github.com/repos/bhilbert4/jwql/git/commits{/sha}","comments_url":"https://api.github.com/repos/bhilbert4/jwql/comments{/number}","issue_comment_url":"https://api.github.com/repos/bhilbert4/jwql/issues/comments{/number}","contents_url":"https://api.github.com/repos/bhilbert4/jwql/contents/{+path}","compare_url":"https://api.github.com/repos/bhilbert4/jwql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bhilbert4/jwql/merges","archive_url":"https://api.github.com/repos/bhilbert4/jwql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bhilbert4/jwql/downloads","issues_url":"https://api.github.com/repos/bhilbert4/jwql/issues{/number}","pulls_url":"https://api.github.com/repos/bhilbert4/jwql/pulls{/number}","milestones_url":"https://api.github.com/repos/bhilbert4/jwql/milestones{/number}","notifications_url":"https://api.github.com/repos/bhilbert4/jwql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bhilbert4/jwql/labels{/name}","releases_url":"https://api.github.com/repos/bhilbert4/jwql/releases{/id}","deployments_url":"https://api.github.com/repos/bhilbert4/jwql/deployments","created_at":"2018-08-29T18:19:14Z","updated_at":"2018-11-08T15:23:25Z","pushed_at":"2018-12-05T20:53:38Z","git_url":"git://github.com/bhilbert4/jwql.git","ssh_url":"[email protected]:bhilbert4/jwql.git","clone_url":"https://github.com/bhilbert4/jwql.git","svn_url":"https://github.com/bhilbert4/jwql","homepage":"","size":72039,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spacetelescope:master","ref":"master","sha":"36b1c138d31c2b8039b3acc9862cab8da10606b3","user":{"login":"spacetelescope","id":2751928,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NTE5Mjg=","avatar_url":"https://avatars3.githubusercontent.com/u/2751928?v=4","gravatar_id":"","url":"https://api.github.com/users/spacetelescope","html_url":"https://github.com/spacetelescope","followers_url":"https://api.github.com/users/spacetelescope/followers","following_url":"https://api.github.com/users/spacetelescope/following{/other_user}","gists_url":"https://api.github.com/users/spacetelescope/gists{/gist_id}","starred_url":"https://api.github.com/users/spacetelescope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spacetelescope/subscriptions","organizations_url":"https://api.github.com/users/spacetelescope/orgs","repos_url":"https://api.github.com/users/spacetelescope/repos","events_url":"https://api.github.com/users/spacetelescope/events{/privacy}","received_events_url":"https://api.github.com/users/spacetelescope/received_events","type":"Organization","site_admin":false},"repo":{"id":109727729,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk3Mjc3Mjk=","name":"jwql","full_name":"spacetelescope/jwql","private":false,"owner":{"login":"spacetelescope","id":2751928,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NTE5Mjg=","avatar_url":"https://avatars3.githubusercontent.com/u/2751928?v=4","gravatar_id":"","url":"https://api.github.com/users/spacetelescope","html_url":"https://github.com/spacetelescope","followers_url":"https://api.github.com/users/spacetelescope/followers","following_url":"https://api.github.com/users/spacetelescope/following{/other_user}","gists_url":"https://api.github.com/users/spacetelescope/gists{/gist_id}","starred_url":"https://api.github.com/users/spacetelescope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spacetelescope/subscriptions","organizations_url":"https://api.github.com/users/spacetelescope/orgs","repos_url":"https://api.github.com/users/spacetelescope/repos","events_url":"https://api.github.com/users/spacetelescope/events{/privacy}","received_events_url":"https://api.github.com/users/spacetelescope/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spacetelescope/jwql","description":"The James Webb Quicklook Application","fork":false,"url":"https://api.github.com/repos/spacetelescope/jwql","forks_url":"https://api.github.com/repos/spacetelescope/jwql/forks","keys_url":"https://api.github.com/repos/spacetelescope/jwql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spacetelescope/jwql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spacetelescope/jwql/teams","hooks_url":"https://api.github.com/repos/spacetelescope/jwql/hooks","issue_events_url":"https://api.github.com/repos/spacetelescope/jwql/issues/events{/number}","events_url":"https://api.github.com/repos/spacetelescope/jwql/events","assignees_url":"https://api.github.com/repos/spacetelescope/jwql/assignees{/user}","branches_url":"https://api.github.com/repos/spacetelescope/jwql/branches{/branch}","tags_url":"https://api.github.com/repos/spacetelescope/jwql/tags","blobs_url":"https://api.github.com/repos/spacetelescope/jwql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spacetelescope/jwql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spacetelescope/jwql/git/refs{/sha}","trees_url":"https://api.github.com/repos/spacetelescope/jwql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spacetelescope/jwql/statuses/{sha}","languages_url":"https://api.github.com/repos/spacetelescope/jwql/languages","stargazers_url":"https://api.github.com/repos/spacetelescope/jwql/stargazers","contributors_url":"https://api.github.com/repos/spacetelescope/jwql/contributors","subscribers_url":"https://api.github.com/repos/spacetelescope/jwql/subscribers","subscription_url":"https://api.github.com/repos/spacetelescope/jwql/subscription","commits_url":"https://api.github.com/repos/spacetelescope/jwql/commits{/sha}","git_commits_url":"https://api.github.com/repos/spacetelescope/jwql/git/commits{/sha}","comments_url":"https://api.github.com/repos/spacetelescope/jwql/comments{/number}","issue_comment_url":"https://api.github.com/repos/spacetelescope/jwql/issues/comments{/number}","contents_url":"https://api.github.com/repos/spacetelescope/jwql/contents/{+path}","compare_url":"https://api.github.com/repos/spacetelescope/jwql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spacetelescope/jwql/merges","archive_url":"https://api.github.com/repos/spacetelescope/jwql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spacetelescope/jwql/downloads","issues_url":"https://api.github.com/repos/spacetelescope/jwql/issues{/number}","pulls_url":"https://api.github.com/repos/spacetelescope/jwql/pulls{/number}","milestones_url":"https://api.github.com/repos/spacetelescope/jwql/milestones{/number}","notifications_url":"https://api.github.com/repos/spacetelescope/jwql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spacetelescope/jwql/labels{/name}","releases_url":"https://api.github.com/repos/spacetelescope/jwql/releases{/id}","deployments_url":"https://api.github.com/repos/spacetelescope/jwql/deployments","created_at":"2017-11-06T17:31:59Z","updated_at":"2018-12-06T19:31:59Z","pushed_at":"2018-12-06T19:35:01Z","git_url":"git://github.com/spacetelescope/jwql.git","ssh_url":"[email protected]:spacetelescope/jwql.git","clone_url":"https://github.com/spacetelescope/jwql.git","svn_url":"https://github.com/spacetelescope/jwql","homepage":"","size":72089,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":10,"open_issues":40,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spacetelescope/jwql/pulls/202"},"html":{"href":"https://github.com/spacetelescope/jwql/pull/202"},"issue":{"href":"https://api.github.com/repos/spacetelescope/jwql/issues/202"},"comments":{"href":"https://api.github.com/repos/spacetelescope/jwql/issues/202/comments"},"review_comments":{"href":"https://api.github.com/repos/spacetelescope/jwql/pulls/202/comments"},"review_comment":{"href":"https://api.github.com/repos/spacetelescope/jwql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spacetelescope/jwql/pulls/202/commits"},"statuses":{"href":"https://api.github.com/repos/spacetelescope/jwql/statuses/426b03ee54f3fa80ffd7194007042fbd50544256"}},"author_association":"COLLABORATOR"}} | {
"id": 109727729,
"name": "spacetelescope/jwql",
"url": "https://api.github.com/repos/spacetelescope/jwql"
} | {
"id": 11775426,
"login": "bhilbert4",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11775426?",
"url": "https://api.github.com/users/bhilbert4"
} | {
"id": 2751928,
"login": "spacetelescope",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2751928?",
"url": "https://api.github.com/orgs/spacetelescope"
} | 2018-12-10T15:03:30 | 8727453070 | {"actor":{"display_login":"bhilbert4"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/CDAT/cdat.github.io/pulls/comments/230837176","pull_request_review_id":171664276,"id":230837176,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDgzNzE3Ng==","diff_hunk":"@@ -21,7 +21,7 @@ source activate [YOUR_CDAT_CONDA_ENV]\n \n Once you've loaded the environment, you should be able to run the examples. They should output a .png file that has the same image as the example.\n \n-We strongly recommend using Jupyter notebook for the tutotrials\n+We strongly recommend using Jupyter notebook for the tutotrials. When you type the command below it is best to have navigated to a folder that contains at least one jupyter notebook (file extention .ipynb).","path":"getting_started.md","position":5,"original_position":5,"commit_id":"b0ed1885b956d8323c7d5dd39e66432accfc6492","original_commit_id":"b0ed1885b956d8323c7d5dd39e66432accfc6492","user":{"login":"doutriaux1","id":2781425,"node_id":"MDQ6VXNlcjI3ODE0MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/2781425?v=4","gravatar_id":"","url":"https://api.github.com/users/doutriaux1","html_url":"https://github.com/doutriaux1","followers_url":"https://api.github.com/users/doutriaux1/followers","following_url":"https://api.github.com/users/doutriaux1/following{/other_user}","gists_url":"https://api.github.com/users/doutriaux1/gists{/gist_id}","starred_url":"https://api.github.com/users/doutriaux1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doutriaux1/subscriptions","organizations_url":"https://api.github.com/users/doutriaux1/orgs","repos_url":"https://api.github.com/users/doutriaux1/repos","events_url":"https://api.github.com/users/doutriaux1/events{/privacy}","received_events_url":"https://api.github.com/users/doutriaux1/received_events","type":"User","site_admin":false},"body":"typo on `tutorials` and actually in notebook you can't go up so it would say something like:\r\nWhen you type the command below it is best to have navigated to a folder containing the jupyter notebooks sub-folders.","created_at":"2018-11-05T17:18:53Z","updated_at":"2018-11-05T17:21:48Z","html_url":"https://github.com/CDAT/cdat.github.io/pull/170#discussion_r230837176","pull_request_url":"https://api.github.com/repos/CDAT/cdat.github.io/pulls/170","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/CDAT/cdat.github.io/pulls/comments/230837176"},"html":{"href":"https://github.com/CDAT/cdat.github.io/pull/170#discussion_r230837176"},"pull_request":{"href":"https://api.github.com/repos/CDAT/cdat.github.io/pulls/170"}}},"pull_request":{"url":"https://api.github.com/repos/CDAT/cdat.github.io/pulls/170","id":227771681,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NzcxNjgx","html_url":"https://github.com/CDAT/cdat.github.io/pull/170","diff_url":"https://github.com/CDAT/cdat.github.io/pull/170.diff","patch_url":"https://github.com/CDAT/cdat.github.io/pull/170.patch","issue_url":"https://api.github.com/repos/CDAT/cdat.github.io/issues/170","number":170,"state":"open","locked":false,"title":"DOC: Update VCS Principles Tutorial","user":{"login":"davis278","id":42980412,"node_id":"MDQ6VXNlcjQyOTgwNDEy","avatar_url":"https://avatars2.githubusercontent.com/u/42980412?v=4","gravatar_id":"","url":"https://api.github.com/users/davis278","html_url":"https://github.com/davis278","followers_url":"https://api.github.com/users/davis278/followers","following_url":"https://api.github.com/users/davis278/following{/other_user}","gists_url":"https://api.github.com/users/davis278/gists{/gist_id}","starred_url":"https://api.github.com/users/davis278/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davis278/subscriptions","organizations_url":"https://api.github.com/users/davis278/orgs","repos_url":"https://api.github.com/users/davis278/repos","events_url":"https://api.github.com/users/davis278/events{/privacy}","received_events_url":"https://api.github.com/users/davis278/received_events","type":"User","site_admin":false},"body":"Deleted inappropriate code at the top of the page; made other corrections to the text.","created_at":"2018-11-01T21:53:54Z","updated_at":"2018-11-05T17:21:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a24dea099a9db786ef425b4e808e5028c6e3985e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CDAT/cdat.github.io/pulls/170/commits","review_comments_url":"https://api.github.com/repos/CDAT/cdat.github.io/pulls/170/comments","review_comment_url":"https://api.github.com/repos/CDAT/cdat.github.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CDAT/cdat.github.io/issues/170/comments","statuses_url":"https://api.github.com/repos/CDAT/cdat.github.io/statuses/b0ed1885b956d8323c7d5dd39e66432accfc6492","head":{"label":"CDAT:doc-vcs-tutorial","ref":"doc-vcs-tutorial","sha":"b0ed1885b956d8323c7d5dd39e66432accfc6492","user":{"login":"CDAT","id":2781444,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3ODE0NDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2781444?v=4","gravatar_id":"","url":"https://api.github.com/users/CDAT","html_url":"https://github.com/CDAT","followers_url":"https://api.github.com/users/CDAT/followers","following_url":"https://api.github.com/users/CDAT/following{/other_user}","gists_url":"https://api.github.com/users/CDAT/gists{/gist_id}","starred_url":"https://api.github.com/users/CDAT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CDAT/subscriptions","organizations_url":"https://api.github.com/users/CDAT/orgs","repos_url":"https://api.github.com/users/CDAT/repos","events_url":"https://api.github.com/users/CDAT/events{/privacy}","received_events_url":"https://api.github.com/users/CDAT/received_events","type":"Organization","site_admin":false},"repo":{"id":11455826,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ1NTgyNg==","name":"cdat.github.io","full_name":"CDAT/cdat.github.io","private":false,"owner":{"login":"CDAT","id":2781444,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3ODE0NDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2781444?v=4","gravatar_id":"","url":"https://api.github.com/users/CDAT","html_url":"https://github.com/CDAT","followers_url":"https://api.github.com/users/CDAT/followers","following_url":"https://api.github.com/users/CDAT/following{/other_user}","gists_url":"https://api.github.com/users/CDAT/gists{/gist_id}","starred_url":"https://api.github.com/users/CDAT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CDAT/subscriptions","organizations_url":"https://api.github.com/users/CDAT/orgs","repos_url":"https://api.github.com/users/CDAT/repos","events_url":"https://api.github.com/users/CDAT/events{/privacy}","received_events_url":"https://api.github.com/users/CDAT/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CDAT/cdat.github.io","description":"cdat website","fork":false,"url":"https://api.github.com/repos/CDAT/cdat.github.io","forks_url":"https://api.github.com/repos/CDAT/cdat.github.io/forks","keys_url":"https://api.github.com/repos/CDAT/cdat.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CDAT/cdat.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CDAT/cdat.github.io/teams","hooks_url":"https://api.github.com/repos/CDAT/cdat.github.io/hooks","issue_events_url":"https://api.github.com/repos/CDAT/cdat.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/CDAT/cdat.github.io/events","assignees_url":"https://api.github.com/repos/CDAT/cdat.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/CDAT/cdat.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/CDAT/cdat.github.io/tags","blobs_url":"https://api.github.com/repos/CDAT/cdat.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CDAT/cdat.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CDAT/cdat.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/CDAT/cdat.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CDAT/cdat.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/CDAT/cdat.github.io/languages","stargazers_url":"https://api.github.com/repos/CDAT/cdat.github.io/stargazers","contributors_url":"https://api.github.com/repos/CDAT/cdat.github.io/contributors","subscribers_url":"https://api.github.com/repos/CDAT/cdat.github.io/subscribers","subscription_url":"https://api.github.com/repos/CDAT/cdat.github.io/subscription","commits_url":"https://api.github.com/repos/CDAT/cdat.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/CDAT/cdat.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/CDAT/cdat.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/CDAT/cdat.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/CDAT/cdat.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/CDAT/cdat.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CDAT/cdat.github.io/merges","archive_url":"https://api.github.com/repos/CDAT/cdat.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CDAT/cdat.github.io/downloads","issues_url":"https://api.github.com/repos/CDAT/cdat.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/CDAT/cdat.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/CDAT/cdat.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/CDAT/cdat.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CDAT/cdat.github.io/labels{/name}","releases_url":"https://api.github.com/repos/CDAT/cdat.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/CDAT/cdat.github.io/deployments","created_at":"2013-07-16T17:39:25Z","updated_at":"2018-08-08T21:07:57Z","pushed_at":"2018-11-01T21:53:54Z","git_url":"git://github.com/CDAT/cdat.github.io.git","ssh_url":"[email protected]:CDAT/cdat.github.io.git","clone_url":"https://github.com/CDAT/cdat.github.io.git","svn_url":"https://github.com/CDAT/cdat.github.io","homepage":"https://cdat.llnl.gov","size":424217,"stargazers_count":5,"watchers_count":5,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":16,"license":null,"forks":4,"open_issues":16,"watchers":5,"default_branch":"master"}},"base":{"label":"CDAT:master","ref":"master","sha":"bee2efe3418f7de9d804432856a419af404e1249","user":{"login":"CDAT","id":2781444,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3ODE0NDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2781444?v=4","gravatar_id":"","url":"https://api.github.com/users/CDAT","html_url":"https://github.com/CDAT","followers_url":"https://api.github.com/users/CDAT/followers","following_url":"https://api.github.com/users/CDAT/following{/other_user}","gists_url":"https://api.github.com/users/CDAT/gists{/gist_id}","starred_url":"https://api.github.com/users/CDAT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CDAT/subscriptions","organizations_url":"https://api.github.com/users/CDAT/orgs","repos_url":"https://api.github.com/users/CDAT/repos","events_url":"https://api.github.com/users/CDAT/events{/privacy}","received_events_url":"https://api.github.com/users/CDAT/received_events","type":"Organization","site_admin":false},"repo":{"id":11455826,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ1NTgyNg==","name":"cdat.github.io","full_name":"CDAT/cdat.github.io","private":false,"owner":{"login":"CDAT","id":2781444,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3ODE0NDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2781444?v=4","gravatar_id":"","url":"https://api.github.com/users/CDAT","html_url":"https://github.com/CDAT","followers_url":"https://api.github.com/users/CDAT/followers","following_url":"https://api.github.com/users/CDAT/following{/other_user}","gists_url":"https://api.github.com/users/CDAT/gists{/gist_id}","starred_url":"https://api.github.com/users/CDAT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CDAT/subscriptions","organizations_url":"https://api.github.com/users/CDAT/orgs","repos_url":"https://api.github.com/users/CDAT/repos","events_url":"https://api.github.com/users/CDAT/events{/privacy}","received_events_url":"https://api.github.com/users/CDAT/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CDAT/cdat.github.io","description":"cdat website","fork":false,"url":"https://api.github.com/repos/CDAT/cdat.github.io","forks_url":"https://api.github.com/repos/CDAT/cdat.github.io/forks","keys_url":"https://api.github.com/repos/CDAT/cdat.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CDAT/cdat.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CDAT/cdat.github.io/teams","hooks_url":"https://api.github.com/repos/CDAT/cdat.github.io/hooks","issue_events_url":"https://api.github.com/repos/CDAT/cdat.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/CDAT/cdat.github.io/events","assignees_url":"https://api.github.com/repos/CDAT/cdat.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/CDAT/cdat.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/CDAT/cdat.github.io/tags","blobs_url":"https://api.github.com/repos/CDAT/cdat.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CDAT/cdat.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CDAT/cdat.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/CDAT/cdat.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CDAT/cdat.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/CDAT/cdat.github.io/languages","stargazers_url":"https://api.github.com/repos/CDAT/cdat.github.io/stargazers","contributors_url":"https://api.github.com/repos/CDAT/cdat.github.io/contributors","subscribers_url":"https://api.github.com/repos/CDAT/cdat.github.io/subscribers","subscription_url":"https://api.github.com/repos/CDAT/cdat.github.io/subscription","commits_url":"https://api.github.com/repos/CDAT/cdat.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/CDAT/cdat.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/CDAT/cdat.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/CDAT/cdat.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/CDAT/cdat.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/CDAT/cdat.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CDAT/cdat.github.io/merges","archive_url":"https://api.github.com/repos/CDAT/cdat.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CDAT/cdat.github.io/downloads","issues_url":"https://api.github.com/repos/CDAT/cdat.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/CDAT/cdat.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/CDAT/cdat.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/CDAT/cdat.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CDAT/cdat.github.io/labels{/name}","releases_url":"https://api.github.com/repos/CDAT/cdat.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/CDAT/cdat.github.io/deployments","created_at":"2013-07-16T17:39:25Z","updated_at":"2018-08-08T21:07:57Z","pushed_at":"2018-11-01T21:53:54Z","git_url":"git://github.com/CDAT/cdat.github.io.git","ssh_url":"[email protected]:CDAT/cdat.github.io.git","clone_url":"https://github.com/CDAT/cdat.github.io.git","svn_url":"https://github.com/CDAT/cdat.github.io","homepage":"https://cdat.llnl.gov","size":424217,"stargazers_count":5,"watchers_count":5,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":16,"license":null,"forks":4,"open_issues":16,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CDAT/cdat.github.io/pulls/170"},"html":{"href":"https://github.com/CDAT/cdat.github.io/pull/170"},"issue":{"href":"https://api.github.com/repos/CDAT/cdat.github.io/issues/170"},"comments":{"href":"https://api.github.com/repos/CDAT/cdat.github.io/issues/170/comments"},"review_comments":{"href":"https://api.github.com/repos/CDAT/cdat.github.io/pulls/170/comments"},"review_comment":{"href":"https://api.github.com/repos/CDAT/cdat.github.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CDAT/cdat.github.io/pulls/170/commits"},"statuses":{"href":"https://api.github.com/repos/CDAT/cdat.github.io/statuses/b0ed1885b956d8323c7d5dd39e66432accfc6492"}},"author_association":"COLLABORATOR"}} | {
"id": 11455826,
"name": "CDAT/cdat.github.io",
"url": "https://api.github.com/repos/CDAT/cdat.github.io"
} | {
"id": 2781425,
"login": "doutriaux1",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2781425?",
"url": "https://api.github.com/users/doutriaux1"
} | {
"id": 2781444,
"login": "CDAT",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2781444?",
"url": "https://api.github.com/orgs/CDAT"
} | 2018-11-05T17:18:53 | 8537234506 | {"actor":{"display_login":"doutriaux1"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/comments/217202279","pull_request_review_id":154859917,"id":217202279,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzIwMjI3OQ==","diff_hunk":"@@ -0,0 +1,804 @@\n+package com.google.cloud.redis.v1;\n+\n+import static io.grpc.MethodDescriptor.generateFullMethodName;\n+import static io.grpc.stub.ClientCalls.asyncBidiStreamingCall;\n+import static io.grpc.stub.ClientCalls.asyncClientStreamingCall;\n+import static io.grpc.stub.ClientCalls.asyncServerStreamingCall;\n+import static io.grpc.stub.ClientCalls.asyncUnaryCall;\n+import static io.grpc.stub.ClientCalls.blockingServerStreamingCall;\n+import static io.grpc.stub.ClientCalls.blockingUnaryCall;\n+import static io.grpc.stub.ClientCalls.futureUnaryCall;\n+import static io.grpc.stub.ServerCalls.asyncBidiStreamingCall;\n+import static io.grpc.stub.ServerCalls.asyncClientStreamingCall;\n+import static io.grpc.stub.ServerCalls.asyncServerStreamingCall;\n+import static io.grpc.stub.ServerCalls.asyncUnaryCall;\n+import static io.grpc.stub.ServerCalls.asyncUnimplementedStreamingCall;\n+import static io.grpc.stub.ServerCalls.asyncUnimplementedUnaryCall;\n+\n+/**\n+ * <pre>\n+ * Configures and manages Cloud Memorystore for Redis instances\n+ * Google Cloud Memorystore for Redis v1\n+ * The `redis.googleapis.com` service implements the Google Cloud Memorystore\n+ * for Redis API and defines the following resource model for managing Redis\n+ * instances:\n+ * * The service works with a collection of cloud projects, named: `/projects/*`\n+ * * Each project has a collection of available locations, named: `/locations/*`\n+ * * Each location has a collection of Redis instances, named: `/instances/*`\n+ * * As such, Redis instances are resources of the form:\n+ * `/projects/{project_id}/locations/{location_id}/instances/{instance_id}`\n+ * Note that location_id must be refering to a GCP `region`; for example:\n+ * * `projects/redpepper-1290/locations/us-central1/instances/my-redis`\n+ * </pre>\n+ */\[email protected](\n+ value = \"by gRPC proto compiler (version 1.10.0)\",\n+ comments = \"Source: google/cloud/redis/v1/cloud_redis.proto\")\n+public final class CloudRedisGrpc {\n+\n+ private CloudRedisGrpc() {}\n+\n+ public static final String SERVICE_NAME = \"google.cloud.redis.v1.CloudRedis\";\n+\n+ // Static method descriptors that strictly reflect the proto.\n+ @io.grpc.ExperimentalApi(\"https://github.com/grpc/grpc-java/issues/1901\")\n+ @java.lang.Deprecated // Use {@link #getListInstancesMethod()} instead. \n+ public static final io.grpc.MethodDescriptor<com.google.cloud.redis.v1.ListInstancesRequest,\n+ com.google.cloud.redis.v1.ListInstancesResponse> METHOD_LIST_INSTANCES = getListInstancesMethodHelper();\n+\n+ private static volatile io.grpc.MethodDescriptor<com.google.cloud.redis.v1.ListInstancesRequest,\n+ com.google.cloud.redis.v1.ListInstancesResponse> getListInstancesMethod;\n+\n+ @io.grpc.ExperimentalApi(\"https://github.com/grpc/grpc-java/issues/1901\")\n+ public static io.grpc.MethodDescriptor<com.google.cloud.redis.v1.ListInstancesRequest,\n+ com.google.cloud.redis.v1.ListInstancesResponse> getListInstancesMethod() {\n+ return getListInstancesMethodHelper();\n+ }\n+\n+ private static io.grpc.MethodDescriptor<com.google.cloud.redis.v1.ListInstancesRequest,\n+ com.google.cloud.redis.v1.ListInstancesResponse> getListInstancesMethodHelper() {\n+ io.grpc.MethodDescriptor<com.google.cloud.redis.v1.ListInstancesRequest, com.google.cloud.redis.v1.ListInstancesResponse> getListInstancesMethod;\n+ if ((getListInstancesMethod = CloudRedisGrpc.getListInstancesMethod) == null) {\n+ synchronized (CloudRedisGrpc.class) {\n+ if ((getListInstancesMethod = CloudRedisGrpc.getListInstancesMethod) == null) {\n+ CloudRedisGrpc.getListInstancesMethod = getListInstancesMethod = \n+ io.grpc.MethodDescriptor.<com.google.cloud.redis.v1.ListInstancesRequest, com.google.cloud.redis.v1.ListInstancesResponse>newBuilder()\n+ .setType(io.grpc.MethodDescriptor.MethodType.UNARY)\n+ .setFullMethodName(generateFullMethodName(\n+ \"google.cloud.redis.v1.CloudRedis\", \"ListInstances\"))\n+ .setSampledToLocalTracing(true)\n+ .setRequestMarshaller(io.grpc.protobuf.ProtoUtils.marshaller(\n+ com.google.cloud.redis.v1.ListInstancesRequest.getDefaultInstance()))\n+ .setResponseMarshaller(io.grpc.protobuf.ProtoUtils.marshaller(\n+ com.google.cloud.redis.v1.ListInstancesResponse.getDefaultInstance()))\n+ .setSchemaDescriptor(new CloudRedisMethodDescriptorSupplier(\"ListInstances\"))\n+ .build();\n+ }\n+ }\n+ }\n+ return getListInstancesMethod;\n+ }\n+ @io.grpc.ExperimentalApi(\"https://github.com/grpc/grpc-java/issues/1901\")\n+ @java.lang.Deprecated // Use {@link #getGetInstanceMethod()} instead. \n+ public static final io.grpc.MethodDescriptor<com.google.cloud.redis.v1.GetInstanceRequest,\n+ com.google.cloud.redis.v1.Instance> METHOD_GET_INSTANCE = getGetInstanceMethodHelper();\n+\n+ private static volatile io.grpc.MethodDescriptor<com.google.cloud.redis.v1.GetInstanceRequest,\n+ com.google.cloud.redis.v1.Instance> getGetInstanceMethod;\n+\n+ @io.grpc.ExperimentalApi(\"https://github.com/grpc/grpc-java/issues/1901\")\n+ public static io.grpc.MethodDescriptor<com.google.cloud.redis.v1.GetInstanceRequest,\n+ com.google.cloud.redis.v1.Instance> getGetInstanceMethod() {\n+ return getGetInstanceMethodHelper();\n+ }\n+\n+ private static io.grpc.MethodDescriptor<com.google.cloud.redis.v1.GetInstanceRequest,\n+ com.google.cloud.redis.v1.Instance> getGetInstanceMethodHelper() {\n+ io.grpc.MethodDescriptor<com.google.cloud.redis.v1.GetInstanceRequest, com.google.cloud.redis.v1.Instance> getGetInstanceMethod;\n+ if ((getGetInstanceMethod = CloudRedisGrpc.getGetInstanceMethod) == null) {\n+ synchronized (CloudRedisGrpc.class) {\n+ if ((getGetInstanceMethod = CloudRedisGrpc.getGetInstanceMethod) == null) {\n+ CloudRedisGrpc.getGetInstanceMethod = getGetInstanceMethod = \n+ io.grpc.MethodDescriptor.<com.google.cloud.redis.v1.GetInstanceRequest, com.google.cloud.redis.v1.Instance>newBuilder()\n+ .setType(io.grpc.MethodDescriptor.MethodType.UNARY)\n+ .setFullMethodName(generateFullMethodName(\n+ \"google.cloud.redis.v1.CloudRedis\", \"GetInstance\"))\n+ .setSampledToLocalTracing(true)\n+ .setRequestMarshaller(io.grpc.protobuf.ProtoUtils.marshaller(\n+ com.google.cloud.redis.v1.GetInstanceRequest.getDefaultInstance()))\n+ .setResponseMarshaller(io.grpc.protobuf.ProtoUtils.marshaller(\n+ com.google.cloud.redis.v1.Instance.getDefaultInstance()))\n+ .setSchemaDescriptor(new CloudRedisMethodDescriptorSupplier(\"GetInstance\"))\n+ .build();\n+ }\n+ }\n+ }\n+ return getGetInstanceMethod;\n+ }\n+ @io.grpc.ExperimentalApi(\"https://github.com/grpc/grpc-java/issues/1901\")\n+ @java.lang.Deprecated // Use {@link #getCreateInstanceMethod()} instead. \n+ public static final io.grpc.MethodDescriptor<com.google.cloud.redis.v1.CreateInstanceRequest,\n+ com.google.longrunning.Operation> METHOD_CREATE_INSTANCE = getCreateInstanceMethodHelper();\n+\n+ private static volatile io.grpc.MethodDescriptor<com.google.cloud.redis.v1.CreateInstanceRequest,","path":"google-api-grpc/grpc-google-cloud-redis-v1/src/main/java/com/google/cloud/redis/v1/CloudRedisGrpc.java","position":123,"original_position":123,"commit_id":"c42dd3df38a339be808a1753aa14af14762cad87","original_commit_id":"c42dd3df38a339be808a1753aa14af14762cad87","user":{"login":"codacy-bot","id":19940114,"node_id":"MDQ6VXNlcjE5OTQwMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":" Issue found: [Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.](https://app.codacy.com/app/mziccard/google-cloud-java/pullRequest?prid=2183030)","created_at":"2018-09-12T21:54:08Z","updated_at":"2018-09-12T21:54:08Z","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/3669#discussion_r217202279","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/3669","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/comments/217202279"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/3669#discussion_r217202279"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/3669"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/3669","id":215104815,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MTA0ODE1","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/3669","diff_url":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/3669.diff","patch_url":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/3669.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/3669","number":3669,"state":"open","locked":false,"title":"Adding redis-v1 and video-intelligence-v1p2beta1","user":{"login":"garrettjonesgoogle","id":13341017,"node_id":"MDQ6VXNlcjEzMzQxMDE3","avatar_url":"https://avatars2.githubusercontent.com/u/13341017?v=4","gravatar_id":"","url":"https://api.github.com/users/garrettjonesgoogle","html_url":"https://github.com/garrettjonesgoogle","followers_url":"https://api.github.com/users/garrettjonesgoogle/followers","following_url":"https://api.github.com/users/garrettjonesgoogle/following{/other_user}","gists_url":"https://api.github.com/users/garrettjonesgoogle/gists{/gist_id}","starred_url":"https://api.github.com/users/garrettjonesgoogle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garrettjonesgoogle/subscriptions","organizations_url":"https://api.github.com/users/garrettjonesgoogle/orgs","repos_url":"https://api.github.com/users/garrettjonesgoogle/repos","events_url":"https://api.github.com/users/garrettjonesgoogle/events{/privacy}","received_events_url":"https://api.github.com/users/garrettjonesgoogle/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-12T21:42:52Z","updated_at":"2018-09-12T21:54:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bbe9769da09863fac872ecd91e14eb39d4e2b8aa","assignee":null,"assignees":[],"requested_reviewers":[{"login":"chingor13","id":32483,"node_id":"MDQ6VXNlcjMyNDgz","avatar_url":"https://avatars0.githubusercontent.com/u/32483?v=4","gravatar_id":"","url":"https://api.github.com/users/chingor13","html_url":"https://github.com/chingor13","followers_url":"https://api.github.com/users/chingor13/followers","following_url":"https://api.github.com/users/chingor13/following{/other_user}","gists_url":"https://api.github.com/users/chingor13/gists{/gist_id}","starred_url":"https://api.github.com/users/chingor13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chingor13/subscriptions","organizations_url":"https://api.github.com/users/chingor13/orgs","repos_url":"https://api.github.com/users/chingor13/repos","events_url":"https://api.github.com/users/chingor13/events{/privacy}","received_events_url":"https://api.github.com/users/chingor13/received_events","type":"User","site_admin":false},{"login":"pongad","id":1617025,"node_id":"MDQ6VXNlcjE2MTcwMjU=","avatar_url":"https://avatars1.githubusercontent.com/u/1617025?v=4","gravatar_id":"","url":"https://api.github.com/users/pongad","html_url":"https://github.com/pongad","followers_url":"https://api.github.com/users/pongad/followers","following_url":"https://api.github.com/users/pongad/following{/other_user}","gists_url":"https://api.github.com/users/pongad/gists{/gist_id}","starred_url":"https://api.github.com/users/pongad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pongad/subscriptions","organizations_url":"https://api.github.com/users/pongad/orgs","repos_url":"https://api.github.com/users/pongad/repos","events_url":"https://api.github.com/users/pongad/events{/privacy}","received_events_url":"https://api.github.com/users/pongad/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":175662188,"node_id":"MDU6TGFiZWwxNzU2NjIxODg=","url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/labels/cla:%20yes","name":"cla: yes","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/3669/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/3669/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/3669/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/statuses/c42dd3df38a339be808a1753aa14af14762cad87","head":{"label":"garrettjonesgoogle:master","ref":"master","sha":"c42dd3df38a339be808a1753aa14af14762cad87","user":{"login":"garrettjonesgoogle","id":13341017,"node_id":"MDQ6VXNlcjEzMzQxMDE3","avatar_url":"https://avatars2.githubusercontent.com/u/13341017?v=4","gravatar_id":"","url":"https://api.github.com/users/garrettjonesgoogle","html_url":"https://github.com/garrettjonesgoogle","followers_url":"https://api.github.com/users/garrettjonesgoogle/followers","following_url":"https://api.github.com/users/garrettjonesgoogle/following{/other_user}","gists_url":"https://api.github.com/users/garrettjonesgoogle/gists{/gist_id}","starred_url":"https://api.github.com/users/garrettjonesgoogle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garrettjonesgoogle/subscriptions","organizations_url":"https://api.github.com/users/garrettjonesgoogle/orgs","repos_url":"https://api.github.com/users/garrettjonesgoogle/repos","events_url":"https://api.github.com/users/garrettjonesgoogle/events{/privacy}","received_events_url":"https://api.github.com/users/garrettjonesgoogle/received_events","type":"User","site_admin":false},"repo":{"id":41181033,"node_id":"MDEwOlJlcG9zaXRvcnk0MTE4MTAzMw==","name":"gcloud-java","full_name":"garrettjonesgoogle/gcloud-java","owner":{"login":"garrettjonesgoogle","id":13341017,"node_id":"MDQ6VXNlcjEzMzQxMDE3","avatar_url":"https://avatars2.githubusercontent.com/u/13341017?v=4","gravatar_id":"","url":"https://api.github.com/users/garrettjonesgoogle","html_url":"https://github.com/garrettjonesgoogle","followers_url":"https://api.github.com/users/garrettjonesgoogle/followers","following_url":"https://api.github.com/users/garrettjonesgoogle/following{/other_user}","gists_url":"https://api.github.com/users/garrettjonesgoogle/gists{/gist_id}","starred_url":"https://api.github.com/users/garrettjonesgoogle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garrettjonesgoogle/subscriptions","organizations_url":"https://api.github.com/users/garrettjonesgoogle/orgs","repos_url":"https://api.github.com/users/garrettjonesgoogle/repos","events_url":"https://api.github.com/users/garrettjonesgoogle/events{/privacy}","received_events_url":"https://api.github.com/users/garrettjonesgoogle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/garrettjonesgoogle/gcloud-java","description":"Google Cloud Client Library for Java","fork":true,"url":"https://api.github.com/repos/garrettjonesgoogle/gcloud-java","forks_url":"https://api.github.com/repos/garrettjonesgoogle/gcloud-java/forks","keys_url":"https://api.github.com/repos/garrettjonesgoogle/gcloud-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/garrettjonesgoogle/gcloud-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/garrettjonesgoogle/gcloud-java/teams","hooks_url":"https://api.github.com/repos/garrettjonesgoogle/gcloud-java/hooks","issue_events_url":"https://api.github.com/repos/garrettjonesgoogle/gcloud-java/issues/events{/number}","events_url":"https://api.github.com/repos/garrettjonesgoogle/gcloud-java/events","assignees_url":"https://api.github.com/repos/garrettjonesgoogle/gcloud-java/assignees{/user}","branches_url":"https://api.github.com/repos/garrettjonesgoogle/gcloud-java/branches{/branch}","tags_url":"https://api.github.com/repos/garrettjonesgoogle/gcloud-java/tags","blobs_url":"https://api.github.com/repos/garrettjonesgoogle/gcloud-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/garrettjonesgoogle/gcloud-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/garrettjonesgoogle/gcloud-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/garrettjonesgoogle/gcloud-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/garrettjonesgoogle/gcloud-java/statuses/{sha}","languages_url":"https://api.github.com/repos/garrettjonesgoogle/gcloud-java/languages","stargazers_url":"https://api.github.com/repos/garrettjonesgoogle/gcloud-java/stargazers","contributors_url":"https://api.github.com/repos/garrettjonesgoogle/gcloud-java/contributors","subscribers_url":"https://api.github.com/repos/garrettjonesgoogle/gcloud-java/subscribers","subscription_url":"https://api.github.com/repos/garrettjonesgoogle/gcloud-java/subscription","commits_url":"https://api.github.com/repos/garrettjonesgoogle/gcloud-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/garrettjonesgoogle/gcloud-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/garrettjonesgoogle/gcloud-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/garrettjonesgoogle/gcloud-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/garrettjonesgoogle/gcloud-java/contents/{+path}","compare_url":"https://api.github.com/repos/garrettjonesgoogle/gcloud-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/garrettjonesgoogle/gcloud-java/merges","archive_url":"https://api.github.com/repos/garrettjonesgoogle/gcloud-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/garrettjonesgoogle/gcloud-java/downloads","issues_url":"https://api.github.com/repos/garrettjonesgoogle/gcloud-java/issues{/number}","pulls_url":"https://api.github.com/repos/garrettjonesgoogle/gcloud-java/pulls{/number}","milestones_url":"https://api.github.com/repos/garrettjonesgoogle/gcloud-java/milestones{/number}","notifications_url":"https://api.github.com/repos/garrettjonesgoogle/gcloud-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/garrettjonesgoogle/gcloud-java/labels{/name}","releases_url":"https://api.github.com/repos/garrettjonesgoogle/gcloud-java/releases{/id}","deployments_url":"https://api.github.com/repos/garrettjonesgoogle/gcloud-java/deployments","created_at":"2015-08-21T23:00:59Z","updated_at":"2018-09-12T21:42:36Z","pushed_at":"2018-09-12T21:43:26Z","git_url":"git://github.com/garrettjonesgoogle/gcloud-java.git","ssh_url":"[email protected]:garrettjonesgoogle/gcloud-java.git","clone_url":"https://github.com/garrettjonesgoogle/gcloud-java.git","svn_url":"https://github.com/garrettjonesgoogle/gcloud-java","homepage":"http://googlecloudplatform.github.io/gcloud-java/site/0.0.6/","size":44708,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"80c9675d4c5e7ebecc2ce3ea8cae4b656beb81a3","user":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":26181278,"node_id":"MDEwOlJlcG9zaXRvcnkyNjE4MTI3OA==","name":"google-cloud-java","full_name":"GoogleCloudPlatform/google-cloud-java","owner":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-java","description":"Google Cloud Client Library for Java","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/deployments","created_at":"2014-11-04T17:57:16Z","updated_at":"2018-09-12T21:50:05Z","pushed_at":"2018-09-12T21:49:59Z","git_url":"git://github.com/GoogleCloudPlatform/google-cloud-java.git","ssh_url":"[email protected]:GoogleCloudPlatform/google-cloud-java.git","clone_url":"https://github.com/GoogleCloudPlatform/google-cloud-java.git","svn_url":"https://github.com/GoogleCloudPlatform/google-cloud-java","homepage":"https://googlecloudplatform.github.io/google-cloud-java/","size":371081,"stargazers_count":782,"watchers_count":782,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":532,"mirror_url":null,"archived":false,"open_issues_count":184,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":532,"open_issues":184,"watchers":782,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/3669"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/3669"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/3669"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/3669/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/3669/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/3669/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/statuses/c42dd3df38a339be808a1753aa14af14762cad87"}},"author_association":"MEMBER"}} | {
"id": 26181278,
"name": "GoogleCloudPlatform/google-cloud-java",
"url": "https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java"
} | {
"id": 19940114,
"login": "codacy-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19940114?",
"url": "https://api.github.com/users/codacy-bot"
} | {
"id": 2810941,
"login": "GoogleCloudPlatform",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2810941?",
"url": "https://api.github.com/orgs/GoogleCloudPlatform"
} | 2018-09-12T21:54:08 | 8256184076 | {"actor":{"display_login":"codacy-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/pulls/comments/170041145","pull_request_review_id":98661568,"id":170041145,"diff_hunk":"@@ -24,49 +28,78 @@ function update_apt_get() {\n return 1\n }\n \n-update_apt_get\n-\n-# Only run the installation on workers; verify zookeeper on master(s)\n-if [[ $(/usr/share/google/get_metadata_value attributes/dataproc-role) == 'Master' ]]; then\n- service zookeeper-server status || \\\n- (echo 'Required zookeeper-server not running on master!' && exit 1)\n- # On master nodes, just install kafka libs but not kafka-server.\n- apt-get install -y kafka\n- exit 0\n-fi\n-\n-# Find zookeeper list first, before attempting any installation.\n-ZOOKEEPER_CLIENT_PORT=$(grep clientPort /etc/zookeeper/conf/zoo.cfg | cut -d '=' -f 2)\n-ZOOKEEPER_LIST=$(grep \"^server\\.\" /etc/zookeeper/conf/zoo.cfg | \\\n- cut -d '=' -f 2 | cut -d ':' -f 1 | sed \"s/$/:${ZOOKEEPER_CLIENT_PORT}/\" | \\\n- xargs echo | sed \"s/ /,/g\")\n-if [[ -z \"${ZOOKEEPER_LIST}\" ]]; then\n- # Didn't find zookeeper quorum in zoo.cfg, but possibly workers just didn't\n- # bother to populate it. Check if YARN HA is configured.\n- ZOOKEEPER_LIST=$(bdconfig get_property_value --configuration_file \\\n+function err() {\n+ echo \"[$(date +'%Y-%m-%dT%H:%M:%S%z')]: $@\" >&2\n+}\n+\n+function install_and_configure_kafka_server() {\n+ # Find zookeeper list first, before attempting any installation.\n+ local ZOOKEEPER_CLIENT_PORT\n+ local ZOOKEEPER_LIST\n+ readonly KAFKA_PROP_FILE='/etc/kafka/conf/server.properties'\n+\n+ ZOOKEEPER_CLIENT_PORT=$(grep 'clientPort' /etc/zookeeper/conf/zoo.cfg \\\n+ | cut -d '=' -f 2)\n+ ZOOKEEPER_LIST=$(grep '^server\\.' /etc/zookeeper/conf/zoo.cfg \\\n+ | cut -d '=' -f 2 \\\n+ | cut -d ':' -f 1 \\\n+ | sed \"s/$/:${ZOOKEEPER_CLIENT_PORT}/\" \\\n+ | xargs echo \\\n+ | sed \"s/ /,/g\")\n+\n+ if [[ -z \"${ZOOKEEPER_LIST}\" ]]; then\n+ # Didn't find zookeeper quorum in zoo.cfg, but possibly workers just didn't\n+ # bother to populate it. Check if YARN HA is configured.\n+ ZOOKEEPER_LIST=$(bdconfig get_property_value --configuration_file \\\n /etc/hadoop/conf/yarn-site.xml \\\n --name yarn.resourcemanager.zk-address 2>/dev/null)\n-fi\n-\n-# If all attempts failed, error out.\n-if [[ -z \"${ZOOKEEPER_LIST}\" ]]; then\n- echo 'Failed to find configured Zookeeper list; try --num-masters=3 for HA'\n- exit 1\n-fi\n-\n-# Install Kafka from Dataproc distro.\n-apt-get install -y kafka-server || dpkg -l kafka-server\n-\n-mkdir -p /var/lib/kafka-logs\n-chown kafka:kafka -R /var/lib/kafka-logs\n-\n-# Note: If modified to also run brokers on master nodes, this logic for\n-# generating BROKER_ID will need to be changed.\n-BROKER_ID=$(hostname | sed 's/.*-w-\\([0-9]\\)*.*/\\1/g')\n-sed -i 's|log.dirs=/tmp/kafka-logs|log.dirs=/var/lib/kafka-logs|' /etc/kafka/conf/server.properties\n-sed -i 's|^\\(zookeeper\\.connect=\\).*|\\1'${ZOOKEEPER_LIST}'|' /etc/kafka/conf/server.properties\n-sed -i 's,^\\(broker\\.id=\\).*,\\1'${BROKER_ID}',' /etc/kafka/conf/server.properties\n-echo 'delete.topic.enable = true' >> /etc/kafka/conf/server.properties\n-\n-# Start Kafka\n-service kafka-server restart\n+ fi\n+\n+ # If all attempts failed, error out.\n+ if [[ -z \"${ZOOKEEPER_LIST}\" ]]; then\n+ err 'Failed to find configured Zookeeper list; try --num-masters=3 for HA'\n+ exit 1\n+ fi\n+\n+ # Install Kafka from Dataproc distro.\n+ apt-get install -y kafka-server \\","path":"kafka/kafka.sh","position":95,"original_position":95,"commit_id":"c8e43dce993889f7bfa9748df7666ae6801651c3","original_commit_id":"c8e43dce993889f7bfa9748df7666ae6801651c3","user":{"login":"bsidhom","id":1359900,"avatar_url":"https://avatars3.githubusercontent.com/u/1359900?v=4","gravatar_id":"","url":"https://api.github.com/users/bsidhom","html_url":"https://github.com/bsidhom","followers_url":"https://api.github.com/users/bsidhom/followers","following_url":"https://api.github.com/users/bsidhom/following{/other_user}","gists_url":"https://api.github.com/users/bsidhom/gists{/gist_id}","starred_url":"https://api.github.com/users/bsidhom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsidhom/subscriptions","organizations_url":"https://api.github.com/users/bsidhom/orgs","repos_url":"https://api.github.com/users/bsidhom/repos","events_url":"https://api.github.com/users/bsidhom/events{/privacy}","received_events_url":"https://api.github.com/users/bsidhom/received_events","type":"User","site_admin":false},"body":"This is a change of behavior. `dpkg -l` appears to be checking if the package is already installed and allowing configuration to continue. Please keep the previous behavior or explain why this change is necessary.","created_at":"2018-02-22T17:52:46Z","updated_at":"2018-02-22T17:54:38Z","html_url":"https://github.com/GoogleCloudPlatform/dataproc-initialization-actions/pull/188#discussion_r170041145","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/pulls/188","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/pulls/comments/170041145"},"html":{"href":"https://github.com/GoogleCloudPlatform/dataproc-initialization-actions/pull/188#discussion_r170041145"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/pulls/188"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/pulls/188","id":170738387,"html_url":"https://github.com/GoogleCloudPlatform/dataproc-initialization-actions/pull/188","diff_url":"https://github.com/GoogleCloudPlatform/dataproc-initialization-actions/pull/188.diff","patch_url":"https://github.com/GoogleCloudPlatform/dataproc-initialization-actions/pull/188.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/issues/188","number":188,"state":"open","locked":false,"title":"Kafka script updated","user":{"login":"szewi","id":7081900,"avatar_url":"https://avatars1.githubusercontent.com/u/7081900?v=4","gravatar_id":"","url":"https://api.github.com/users/szewi","html_url":"https://github.com/szewi","followers_url":"https://api.github.com/users/szewi/followers","following_url":"https://api.github.com/users/szewi/following{/other_user}","gists_url":"https://api.github.com/users/szewi/gists{/gist_id}","starred_url":"https://api.github.com/users/szewi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szewi/subscriptions","organizations_url":"https://api.github.com/users/szewi/orgs","repos_url":"https://api.github.com/users/szewi/repos","events_url":"https://api.github.com/users/szewi/events{/privacy}","received_events_url":"https://api.github.com/users/szewi/received_events","type":"User","site_admin":false},"body":"…to follow https://google.github.io/styleguide/shell.xml. \r\n\r\nAs described in https://github.com/GoogleCloudPlatform/dataproc-initialization-actions/issues/187","created_at":"2018-02-22T12:36:23Z","updated_at":"2018-02-22T17:54:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ca595955e6dcaff868b26cdedadb6af6adf328e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":272081215,"url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/pulls/188/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/pulls/188/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/issues/188/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/statuses/c8e43dce993889f7bfa9748df7666ae6801651c3","head":{"label":"szewi:kafka-mods","ref":"kafka-mods","sha":"c8e43dce993889f7bfa9748df7666ae6801651c3","user":{"login":"szewi","id":7081900,"avatar_url":"https://avatars1.githubusercontent.com/u/7081900?v=4","gravatar_id":"","url":"https://api.github.com/users/szewi","html_url":"https://github.com/szewi","followers_url":"https://api.github.com/users/szewi/followers","following_url":"https://api.github.com/users/szewi/following{/other_user}","gists_url":"https://api.github.com/users/szewi/gists{/gist_id}","starred_url":"https://api.github.com/users/szewi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szewi/subscriptions","organizations_url":"https://api.github.com/users/szewi/orgs","repos_url":"https://api.github.com/users/szewi/repos","events_url":"https://api.github.com/users/szewi/events{/privacy}","received_events_url":"https://api.github.com/users/szewi/received_events","type":"User","site_admin":false},"repo":{"id":121387740,"name":"dataproc-initialization-actions","full_name":"szewi/dataproc-initialization-actions","owner":{"login":"szewi","id":7081900,"avatar_url":"https://avatars1.githubusercontent.com/u/7081900?v=4","gravatar_id":"","url":"https://api.github.com/users/szewi","html_url":"https://github.com/szewi","followers_url":"https://api.github.com/users/szewi/followers","following_url":"https://api.github.com/users/szewi/following{/other_user}","gists_url":"https://api.github.com/users/szewi/gists{/gist_id}","starred_url":"https://api.github.com/users/szewi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szewi/subscriptions","organizations_url":"https://api.github.com/users/szewi/orgs","repos_url":"https://api.github.com/users/szewi/repos","events_url":"https://api.github.com/users/szewi/events{/privacy}","received_events_url":"https://api.github.com/users/szewi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/szewi/dataproc-initialization-actions","description":"Run in all nodes of your cluster before the cluster starts - lets you customize your cluster","fork":true,"url":"https://api.github.com/repos/szewi/dataproc-initialization-actions","forks_url":"https://api.github.com/repos/szewi/dataproc-initialization-actions/forks","keys_url":"https://api.github.com/repos/szewi/dataproc-initialization-actions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/szewi/dataproc-initialization-actions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/szewi/dataproc-initialization-actions/teams","hooks_url":"https://api.github.com/repos/szewi/dataproc-initialization-actions/hooks","issue_events_url":"https://api.github.com/repos/szewi/dataproc-initialization-actions/issues/events{/number}","events_url":"https://api.github.com/repos/szewi/dataproc-initialization-actions/events","assignees_url":"https://api.github.com/repos/szewi/dataproc-initialization-actions/assignees{/user}","branches_url":"https://api.github.com/repos/szewi/dataproc-initialization-actions/branches{/branch}","tags_url":"https://api.github.com/repos/szewi/dataproc-initialization-actions/tags","blobs_url":"https://api.github.com/repos/szewi/dataproc-initialization-actions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/szewi/dataproc-initialization-actions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/szewi/dataproc-initialization-actions/git/refs{/sha}","trees_url":"https://api.github.com/repos/szewi/dataproc-initialization-actions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/szewi/dataproc-initialization-actions/statuses/{sha}","languages_url":"https://api.github.com/repos/szewi/dataproc-initialization-actions/languages","stargazers_url":"https://api.github.com/repos/szewi/dataproc-initialization-actions/stargazers","contributors_url":"https://api.github.com/repos/szewi/dataproc-initialization-actions/contributors","subscribers_url":"https://api.github.com/repos/szewi/dataproc-initialization-actions/subscribers","subscription_url":"https://api.github.com/repos/szewi/dataproc-initialization-actions/subscription","commits_url":"https://api.github.com/repos/szewi/dataproc-initialization-actions/commits{/sha}","git_commits_url":"https://api.github.com/repos/szewi/dataproc-initialization-actions/git/commits{/sha}","comments_url":"https://api.github.com/repos/szewi/dataproc-initialization-actions/comments{/number}","issue_comment_url":"https://api.github.com/repos/szewi/dataproc-initialization-actions/issues/comments{/number}","contents_url":"https://api.github.com/repos/szewi/dataproc-initialization-actions/contents/{+path}","compare_url":"https://api.github.com/repos/szewi/dataproc-initialization-actions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/szewi/dataproc-initialization-actions/merges","archive_url":"https://api.github.com/repos/szewi/dataproc-initialization-actions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/szewi/dataproc-initialization-actions/downloads","issues_url":"https://api.github.com/repos/szewi/dataproc-initialization-actions/issues{/number}","pulls_url":"https://api.github.com/repos/szewi/dataproc-initialization-actions/pulls{/number}","milestones_url":"https://api.github.com/repos/szewi/dataproc-initialization-actions/milestones{/number}","notifications_url":"https://api.github.com/repos/szewi/dataproc-initialization-actions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/szewi/dataproc-initialization-actions/labels{/name}","releases_url":"https://api.github.com/repos/szewi/dataproc-initialization-actions/releases{/id}","deployments_url":"https://api.github.com/repos/szewi/dataproc-initialization-actions/deployments","created_at":"2018-02-13T13:48:01Z","updated_at":"2018-02-13T13:48:03Z","pushed_at":"2018-02-22T11:48:12Z","git_url":"git://github.com/szewi/dataproc-initialization-actions.git","ssh_url":"[email protected]:szewi/dataproc-initialization-actions.git","clone_url":"https://github.com/szewi/dataproc-initialization-actions.git","svn_url":"https://github.com/szewi/dataproc-initialization-actions","homepage":"https://cloud.google.com/dataproc/init-actions","size":235,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"4eb6fba4dcd9d8f532ab6c1e96a17c40c19b2b2a","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":44124590,"name":"dataproc-initialization-actions","full_name":"GoogleCloudPlatform/dataproc-initialization-actions","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/dataproc-initialization-actions","description":"Run in all nodes of your cluster before the cluster starts - lets you customize your cluster","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/deployments","created_at":"2015-10-12T17:58:35Z","updated_at":"2018-02-22T07:20:33Z","pushed_at":"2018-02-22T16:40:40Z","git_url":"git://github.com/GoogleCloudPlatform/dataproc-initialization-actions.git","ssh_url":"[email protected]:GoogleCloudPlatform/dataproc-initialization-actions.git","clone_url":"https://github.com/GoogleCloudPlatform/dataproc-initialization-actions.git","svn_url":"https://github.com/GoogleCloudPlatform/dataproc-initialization-actions","homepage":"https://cloud.google.com/dataproc/init-actions","size":233,"stargazers_count":188,"watchers_count":188,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":173,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":173,"open_issues":18,"watchers":188,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/pulls/188"},"html":{"href":"https://github.com/GoogleCloudPlatform/dataproc-initialization-actions/pull/188"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/issues/188"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/issues/188/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/pulls/188/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/pulls/188/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions/statuses/c8e43dce993889f7bfa9748df7666ae6801651c3"}},"author_association":"NONE"}} | {
"id": 44124590,
"name": "GoogleCloudPlatform/dataproc-initialization-actions",
"url": "https://api.github.com/repos/GoogleCloudPlatform/dataproc-initialization-actions"
} | {
"id": 1359900,
"login": "bsidhom",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1359900?",
"url": "https://api.github.com/users/bsidhom"
} | {
"id": 2810941,
"login": "GoogleCloudPlatform",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2810941?",
"url": "https://api.github.com/orgs/GoogleCloudPlatform"
} | 2018-02-22T17:52:46 | 7283070564 | {"actor":{"display_login":"bsidhom"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/pulls/comments/168585837","pull_request_review_id":96979400,"id":168585837,"diff_hunk":"@@ -0,0 +1,34 @@\n+# removePublicGCS - Sample 5-minute Solution to prevent public objects in GCS via Cloud Functions\n+\n+This is a sample of deploying a *Cloud Function* that triggers off a target *GCS* bucket whenever an object's metadata or ACLs are updated. For each object that is updated, this function will explicitly remove the **'allAuthenticatedUsers'** and **'allUsers'** special ACL groups from the owners, readers, and writers groups. This function effectively reacts and removes public access if it is ever accidentally granted by a user or code. The object getting the public ACLs removed are not modified in any other way, the object data, metadata, and other ACLs will remain the same after the function triggers.\n+\n+## Steps\n+\n+Begin by activating a *Cloud Shell* within your [Cloud Console](https://console.cloud.google.com/).\n+\n+ ## Make a new directory as a staging area to deploy the cloud function\n+ $ mkdir removePublicAccessGCF\n+ $ cd removePublicAccessGCF\n+\n+\n+ ## Grab a copy of the sample Cloud Function code\n+ $ wget https://raw.githubusercontent.com/reechar-goog/professional-services/feature/removePublicGCS_CF/infrastructure/removePublicGCS/index.js","path":"infrastructure/removePublicGCS/README.md","position":15,"original_position":15,"commit_id":"13b3608ab9eac409fa44aabb1aeed1179c66f864","original_commit_id":"13b3608ab9eac409fa44aabb1aeed1179c66f864","user":{"login":"woogie-wolgemuth","id":30418896,"avatar_url":"https://avatars3.githubusercontent.com/u/30418896?v=4","gravatar_id":"","url":"https://api.github.com/users/woogie-wolgemuth","html_url":"https://github.com/woogie-wolgemuth","followers_url":"https://api.github.com/users/woogie-wolgemuth/followers","following_url":"https://api.github.com/users/woogie-wolgemuth/following{/other_user}","gists_url":"https://api.github.com/users/woogie-wolgemuth/gists{/gist_id}","starred_url":"https://api.github.com/users/woogie-wolgemuth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woogie-wolgemuth/subscriptions","organizations_url":"https://api.github.com/users/woogie-wolgemuth/orgs","repos_url":"https://api.github.com/users/woogie-wolgemuth/repos","events_url":"https://api.github.com/users/woogie-wolgemuth/events{/privacy}","received_events_url":"https://api.github.com/users/woogie-wolgemuth/received_events","type":"User","site_admin":false},"body":"Switch these instructions to point at the PSO GitHub; also, prefer using Git clone over wget raw files (we can assume git competency for visitors to GitHub).","created_at":"2018-02-15T19:39:17Z","updated_at":"2018-02-15T20:04:26Z","html_url":"https://github.com/GoogleCloudPlatform/professional-services/pull/32#discussion_r168585837","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/pulls/32","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/pulls/comments/168585837"},"html":{"href":"https://github.com/GoogleCloudPlatform/professional-services/pull/32#discussion_r168585837"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/pulls/32"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/pulls/32","id":169459616,"html_url":"https://github.com/GoogleCloudPlatform/professional-services/pull/32","diff_url":"https://github.com/GoogleCloudPlatform/professional-services/pull/32.diff","patch_url":"https://github.com/GoogleCloudPlatform/professional-services/pull/32.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/issues/32","number":32,"state":"open","locked":false,"title":"Feature/remove public gcs cf","user":{"login":"reechar-goog","id":30415822,"avatar_url":"https://avatars1.githubusercontent.com/u/30415822?v=4","gravatar_id":"","url":"https://api.github.com/users/reechar-goog","html_url":"https://github.com/reechar-goog","followers_url":"https://api.github.com/users/reechar-goog/followers","following_url":"https://api.github.com/users/reechar-goog/following{/other_user}","gists_url":"https://api.github.com/users/reechar-goog/gists{/gist_id}","starred_url":"https://api.github.com/users/reechar-goog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reechar-goog/subscriptions","organizations_url":"https://api.github.com/users/reechar-goog/orgs","repos_url":"https://api.github.com/users/reechar-goog/repos","events_url":"https://api.github.com/users/reechar-goog/events{/privacy}","received_events_url":"https://api.github.com/users/reechar-goog/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-15T19:12:42Z","updated_at":"2018-02-15T20:04:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b3a4ea6e0f0429fea23d5f242b64211542c04565","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/pulls/32/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/pulls/32/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/issues/32/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/statuses/13b3608ab9eac409fa44aabb1aeed1179c66f864","head":{"label":"reechar-goog:feature/removePublicGCS_CF","ref":"feature/removePublicGCS_CF","sha":"13b3608ab9eac409fa44aabb1aeed1179c66f864","user":{"login":"reechar-goog","id":30415822,"avatar_url":"https://avatars1.githubusercontent.com/u/30415822?v=4","gravatar_id":"","url":"https://api.github.com/users/reechar-goog","html_url":"https://github.com/reechar-goog","followers_url":"https://api.github.com/users/reechar-goog/followers","following_url":"https://api.github.com/users/reechar-goog/following{/other_user}","gists_url":"https://api.github.com/users/reechar-goog/gists{/gist_id}","starred_url":"https://api.github.com/users/reechar-goog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reechar-goog/subscriptions","organizations_url":"https://api.github.com/users/reechar-goog/orgs","repos_url":"https://api.github.com/users/reechar-goog/repos","events_url":"https://api.github.com/users/reechar-goog/events{/privacy}","received_events_url":"https://api.github.com/users/reechar-goog/received_events","type":"User","site_admin":false},"repo":{"id":121563229,"name":"professional-services","full_name":"reechar-goog/professional-services","owner":{"login":"reechar-goog","id":30415822,"avatar_url":"https://avatars1.githubusercontent.com/u/30415822?v=4","gravatar_id":"","url":"https://api.github.com/users/reechar-goog","html_url":"https://github.com/reechar-goog","followers_url":"https://api.github.com/users/reechar-goog/followers","following_url":"https://api.github.com/users/reechar-goog/following{/other_user}","gists_url":"https://api.github.com/users/reechar-goog/gists{/gist_id}","starred_url":"https://api.github.com/users/reechar-goog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reechar-goog/subscriptions","organizations_url":"https://api.github.com/users/reechar-goog/orgs","repos_url":"https://api.github.com/users/reechar-goog/repos","events_url":"https://api.github.com/users/reechar-goog/events{/privacy}","received_events_url":"https://api.github.com/users/reechar-goog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/reechar-goog/professional-services","description":null,"fork":true,"url":"https://api.github.com/repos/reechar-goog/professional-services","forks_url":"https://api.github.com/repos/reechar-goog/professional-services/forks","keys_url":"https://api.github.com/repos/reechar-goog/professional-services/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reechar-goog/professional-services/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reechar-goog/professional-services/teams","hooks_url":"https://api.github.com/repos/reechar-goog/professional-services/hooks","issue_events_url":"https://api.github.com/repos/reechar-goog/professional-services/issues/events{/number}","events_url":"https://api.github.com/repos/reechar-goog/professional-services/events","assignees_url":"https://api.github.com/repos/reechar-goog/professional-services/assignees{/user}","branches_url":"https://api.github.com/repos/reechar-goog/professional-services/branches{/branch}","tags_url":"https://api.github.com/repos/reechar-goog/professional-services/tags","blobs_url":"https://api.github.com/repos/reechar-goog/professional-services/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reechar-goog/professional-services/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reechar-goog/professional-services/git/refs{/sha}","trees_url":"https://api.github.com/repos/reechar-goog/professional-services/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reechar-goog/professional-services/statuses/{sha}","languages_url":"https://api.github.com/repos/reechar-goog/professional-services/languages","stargazers_url":"https://api.github.com/repos/reechar-goog/professional-services/stargazers","contributors_url":"https://api.github.com/repos/reechar-goog/professional-services/contributors","subscribers_url":"https://api.github.com/repos/reechar-goog/professional-services/subscribers","subscription_url":"https://api.github.com/repos/reechar-goog/professional-services/subscription","commits_url":"https://api.github.com/repos/reechar-goog/professional-services/commits{/sha}","git_commits_url":"https://api.github.com/repos/reechar-goog/professional-services/git/commits{/sha}","comments_url":"https://api.github.com/repos/reechar-goog/professional-services/comments{/number}","issue_comment_url":"https://api.github.com/repos/reechar-goog/professional-services/issues/comments{/number}","contents_url":"https://api.github.com/repos/reechar-goog/professional-services/contents/{+path}","compare_url":"https://api.github.com/repos/reechar-goog/professional-services/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reechar-goog/professional-services/merges","archive_url":"https://api.github.com/repos/reechar-goog/professional-services/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reechar-goog/professional-services/downloads","issues_url":"https://api.github.com/repos/reechar-goog/professional-services/issues{/number}","pulls_url":"https://api.github.com/repos/reechar-goog/professional-services/pulls{/number}","milestones_url":"https://api.github.com/repos/reechar-goog/professional-services/milestones{/number}","notifications_url":"https://api.github.com/repos/reechar-goog/professional-services/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reechar-goog/professional-services/labels{/name}","releases_url":"https://api.github.com/repos/reechar-goog/professional-services/releases{/id}","deployments_url":"https://api.github.com/repos/reechar-goog/professional-services/deployments","created_at":"2018-02-14T21:27:40Z","updated_at":"2018-02-14T21:27:43Z","pushed_at":"2018-02-15T17:38:39Z","git_url":"git://github.com/reechar-goog/professional-services.git","ssh_url":"[email protected]:reechar-goog/professional-services.git","clone_url":"https://github.com/reechar-goog/professional-services.git","svn_url":"https://github.com/reechar-goog/professional-services","homepage":null,"size":18632,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"6d07f76e9233fa0d2ce5e2cbcd8b3c6cd497110f","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":91730359,"name":"professional-services","full_name":"GoogleCloudPlatform/professional-services","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/professional-services","description":null,"fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/deployments","created_at":"2017-05-18T19:29:27Z","updated_at":"2018-02-06T19:11:11Z","pushed_at":"2018-02-15T19:12:43Z","git_url":"git://github.com/GoogleCloudPlatform/professional-services.git","ssh_url":"[email protected]:GoogleCloudPlatform/professional-services.git","clone_url":"https://github.com/GoogleCloudPlatform/professional-services.git","svn_url":"https://github.com/GoogleCloudPlatform/professional-services","homepage":null,"size":18625,"stargazers_count":25,"watchers_count":25,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":16,"open_issues":11,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/pulls/32"},"html":{"href":"https://github.com/GoogleCloudPlatform/professional-services/pull/32"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/issues/32"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/professional-services/statuses/13b3608ab9eac409fa44aabb1aeed1179c66f864"}},"author_association":"NONE"}} | {
"id": 91730359,
"name": "GoogleCloudPlatform/professional-services",
"url": "https://api.github.com/repos/GoogleCloudPlatform/professional-services"
} | {
"id": 30418896,
"login": "woogie-wolgemuth",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30418896?",
"url": "https://api.github.com/users/woogie-wolgemuth"
} | {
"id": 2810941,
"login": "GoogleCloudPlatform",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2810941?",
"url": "https://api.github.com/orgs/GoogleCloudPlatform"
} | 2018-02-15T19:39:17 | 7251641184 | {"actor":{"display_login":"woogie-wolgemuth"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/pulls/comments/216827253","pull_request_review_id":154402560,"id":216827253,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjgyNzI1Mw==","diff_hunk":"@@ -0,0 +1,37 @@\n+#\n+# Copyright 2017 Google LLC\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+# https://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitations under the License.\n+#\n+\n+apiVersion: \"sparkoperator.k8s.io/v1alpha1\"\n+kind: SparkApplication\n+metadata:\n+ name: spark-pi\n+ namespace: default\n+spec:\n+ type: Scala\n+ mode: cluster\n+ image: Default","path":"examples/spark-pi-default.yaml","position":25,"original_position":25,"commit_id":"fdfc8112bf27dfd14c70983fb3cd76d081dd4470","original_commit_id":"bab102c7b2ee2c2f9ebc8e63409b4c1a6b53bc34","user":{"login":"liyinan926","id":3709137,"node_id":"MDQ6VXNlcjM3MDkxMzc=","avatar_url":"https://avatars2.githubusercontent.com/u/3709137?v=4","gravatar_id":"","url":"https://api.github.com/users/liyinan926","html_url":"https://github.com/liyinan926","followers_url":"https://api.github.com/users/liyinan926/followers","following_url":"https://api.github.com/users/liyinan926/following{/other_user}","gists_url":"https://api.github.com/users/liyinan926/gists{/gist_id}","starred_url":"https://api.github.com/users/liyinan926/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liyinan926/subscriptions","organizations_url":"https://api.github.com/users/liyinan926/orgs","repos_url":"https://api.github.com/users/liyinan926/repos","events_url":"https://api.github.com/users/liyinan926/events{/privacy}","received_events_url":"https://api.github.com/users/liyinan926/received_events","type":"User","site_admin":false},"body":"What if we simply make `image` optional, and if it's not specified, use the default image, instead of using this `Default` value?","created_at":"2018-09-11T21:22:29Z","updated_at":"2018-09-11T21:33:50Z","html_url":"https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/pull/281#discussion_r216827253","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/pulls/281","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/pulls/comments/216827253"},"html":{"href":"https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/pull/281#discussion_r216827253"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/pulls/281"}},"in_reply_to_id":216384292},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/pulls/281","id":214369295,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MzY5Mjk1","html_url":"https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/pull/281","diff_url":"https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/pull/281.diff","patch_url":"https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/pull/281.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/issues/281","number":281,"state":"open","locked":false,"title":"Add support for specifying default spark image for applications in spark operator","user":{"login":"mrow4a","id":13368647,"node_id":"MDQ6VXNlcjEzMzY4NjQ3","avatar_url":"https://avatars2.githubusercontent.com/u/13368647?v=4","gravatar_id":"","url":"https://api.github.com/users/mrow4a","html_url":"https://github.com/mrow4a","followers_url":"https://api.github.com/users/mrow4a/followers","following_url":"https://api.github.com/users/mrow4a/following{/other_user}","gists_url":"https://api.github.com/users/mrow4a/gists{/gist_id}","starred_url":"https://api.github.com/users/mrow4a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrow4a/subscriptions","organizations_url":"https://api.github.com/users/mrow4a/orgs","repos_url":"https://api.github.com/users/mrow4a/repos","events_url":"https://api.github.com/users/mrow4a/events{/privacy}","received_events_url":"https://api.github.com/users/mrow4a/received_events","type":"User","site_admin":false},"body":"This PR adds support for specifying default spark container images in spark operator, which will be used in all spark applications submitted through that spark operator, unless custom image specified. \r\n\r\n","created_at":"2018-09-10T16:16:30Z","updated_at":"2018-09-11T21:33:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"98d9cd4cee926201830f4f8816f8c676d0088ab7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/pulls/281/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/pulls/281/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/issues/281/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/statuses/fdfc8112bf27dfd14c70983fb3cd76d081dd4470","head":{"label":"cerndb:default_spark_image","ref":"default_spark_image","sha":"fdfc8112bf27dfd14c70983fb3cd76d081dd4470","user":{"login":"cerndb","id":1798473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTg0NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1798473?v=4","gravatar_id":"","url":"https://api.github.com/users/cerndb","html_url":"https://github.com/cerndb","followers_url":"https://api.github.com/users/cerndb/followers","following_url":"https://api.github.com/users/cerndb/following{/other_user}","gists_url":"https://api.github.com/users/cerndb/gists{/gist_id}","starred_url":"https://api.github.com/users/cerndb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerndb/subscriptions","organizations_url":"https://api.github.com/users/cerndb/orgs","repos_url":"https://api.github.com/users/cerndb/repos","events_url":"https://api.github.com/users/cerndb/events{/privacy}","received_events_url":"https://api.github.com/users/cerndb/received_events","type":"Organization","site_admin":false},"repo":{"id":132584722,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI1ODQ3MjI=","name":"spark-on-k8s-operator","full_name":"cerndb/spark-on-k8s-operator","owner":{"login":"cerndb","id":1798473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTg0NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1798473?v=4","gravatar_id":"","url":"https://api.github.com/users/cerndb","html_url":"https://github.com/cerndb","followers_url":"https://api.github.com/users/cerndb/followers","following_url":"https://api.github.com/users/cerndb/following{/other_user}","gists_url":"https://api.github.com/users/cerndb/gists{/gist_id}","starred_url":"https://api.github.com/users/cerndb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerndb/subscriptions","organizations_url":"https://api.github.com/users/cerndb/orgs","repos_url":"https://api.github.com/users/cerndb/repos","events_url":"https://api.github.com/users/cerndb/events{/privacy}","received_events_url":"https://api.github.com/users/cerndb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cerndb/spark-on-k8s-operator","description":"Kubernetes CRD operator for specifying and running Apache Spark applications idiomatically on Kubernetes. ","fork":true,"url":"https://api.github.com/repos/cerndb/spark-on-k8s-operator","forks_url":"https://api.github.com/repos/cerndb/spark-on-k8s-operator/forks","keys_url":"https://api.github.com/repos/cerndb/spark-on-k8s-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cerndb/spark-on-k8s-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cerndb/spark-on-k8s-operator/teams","hooks_url":"https://api.github.com/repos/cerndb/spark-on-k8s-operator/hooks","issue_events_url":"https://api.github.com/repos/cerndb/spark-on-k8s-operator/issues/events{/number}","events_url":"https://api.github.com/repos/cerndb/spark-on-k8s-operator/events","assignees_url":"https://api.github.com/repos/cerndb/spark-on-k8s-operator/assignees{/user}","branches_url":"https://api.github.com/repos/cerndb/spark-on-k8s-operator/branches{/branch}","tags_url":"https://api.github.com/repos/cerndb/spark-on-k8s-operator/tags","blobs_url":"https://api.github.com/repos/cerndb/spark-on-k8s-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cerndb/spark-on-k8s-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cerndb/spark-on-k8s-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/cerndb/spark-on-k8s-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cerndb/spark-on-k8s-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/cerndb/spark-on-k8s-operator/languages","stargazers_url":"https://api.github.com/repos/cerndb/spark-on-k8s-operator/stargazers","contributors_url":"https://api.github.com/repos/cerndb/spark-on-k8s-operator/contributors","subscribers_url":"https://api.github.com/repos/cerndb/spark-on-k8s-operator/subscribers","subscription_url":"https://api.github.com/repos/cerndb/spark-on-k8s-operator/subscription","commits_url":"https://api.github.com/repos/cerndb/spark-on-k8s-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/cerndb/spark-on-k8s-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/cerndb/spark-on-k8s-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/cerndb/spark-on-k8s-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/cerndb/spark-on-k8s-operator/contents/{+path}","compare_url":"https://api.github.com/repos/cerndb/spark-on-k8s-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cerndb/spark-on-k8s-operator/merges","archive_url":"https://api.github.com/repos/cerndb/spark-on-k8s-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cerndb/spark-on-k8s-operator/downloads","issues_url":"https://api.github.com/repos/cerndb/spark-on-k8s-operator/issues{/number}","pulls_url":"https://api.github.com/repos/cerndb/spark-on-k8s-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/cerndb/spark-on-k8s-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/cerndb/spark-on-k8s-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cerndb/spark-on-k8s-operator/labels{/name}","releases_url":"https://api.github.com/repos/cerndb/spark-on-k8s-operator/releases{/id}","deployments_url":"https://api.github.com/repos/cerndb/spark-on-k8s-operator/deployments","created_at":"2018-05-08T09:18:27Z","updated_at":"2018-08-28T12:38:13Z","pushed_at":"2018-09-11T07:34:46Z","git_url":"git://github.com/cerndb/spark-on-k8s-operator.git","ssh_url":"[email protected]:cerndb/spark-on-k8s-operator.git","clone_url":"https://github.com/cerndb/spark-on-k8s-operator.git","svn_url":"https://github.com/cerndb/spark-on-k8s-operator","homepage":"","size":814,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"29a4329ea4d049e5e2292b564448e9f0466c6044","user":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":116165188,"node_id":"MDEwOlJlcG9zaXRvcnkxMTYxNjUxODg=","name":"spark-on-k8s-operator","full_name":"GoogleCloudPlatform/spark-on-k8s-operator","owner":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/spark-on-k8s-operator","description":"Kubernetes operator for specifying and managing the lifecycle of Apache Spark applications on Kubernetes. ","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/deployments","created_at":"2018-01-03T17:43:16Z","updated_at":"2018-09-11T16:32:47Z","pushed_at":"2018-09-11T20:29:21Z","git_url":"git://github.com/GoogleCloudPlatform/spark-on-k8s-operator.git","ssh_url":"[email protected]:GoogleCloudPlatform/spark-on-k8s-operator.git","clone_url":"https://github.com/GoogleCloudPlatform/spark-on-k8s-operator.git","svn_url":"https://github.com/GoogleCloudPlatform/spark-on-k8s-operator","homepage":"","size":810,"stargazers_count":179,"watchers_count":179,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":52,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":52,"open_issues":28,"watchers":179,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/pulls/281"},"html":{"href":"https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/pull/281"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/issues/281"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/issues/281/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/pulls/281/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/pulls/281/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/statuses/fdfc8112bf27dfd14c70983fb3cd76d081dd4470"}},"author_association":"CONTRIBUTOR"}} | {
"id": 116165188,
"name": "GoogleCloudPlatform/spark-on-k8s-operator",
"url": "https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator"
} | {
"id": 3709137,
"login": "liyinan926",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3709137?",
"url": "https://api.github.com/users/liyinan926"
} | {
"id": 2810941,
"login": "GoogleCloudPlatform",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2810941?",
"url": "https://api.github.com/orgs/GoogleCloudPlatform"
} | 2018-09-11T21:22:29 | 8249430232 | {"actor":{"display_login":"liyinan926"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/pulls/comments/207941909","pull_request_review_id":143654553,"id":207941909,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzk0MTkwOQ==","diff_hunk":"@@ -0,0 +1,40 @@\n+/**\n+ * Copyright 2018, Google, Inc.\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+'use strict';\n+\n+// [START full_sample]\n+const puppeteer = require('puppeteer');\n+\n+exports.screenshot = async (req, res) => {\n+ const url = req.query.url;\n+\n+ // [START start_browser]\n+ const browser = await puppeteer.launch({args: ['--no-sandbox']});\n+ // [END start_browser]\n+ const page = await browser.newPage();\n+\n+ if (!url) {\n+ return res.send('Please provide URL as GET parameter, for example: <a href=\"?url=https://example.com\">?url=https://example.com</a>');\n+ }\n+\n+ await page.goto(url);\n+ const imageBuffer = await page.screenshot();\n+ browser.close();","path":"functions/headless-chrome/index.js","position":35,"original_position":35,"commit_id":"8ae264309a94e24cb127acb061ee7f311bc55626","original_commit_id":"8ae264309a94e24cb127acb061ee7f311bc55626","user":{"login":"ebidel","id":238208,"node_id":"MDQ6VXNlcjIzODIwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/238208?v=4","gravatar_id":"","url":"https://api.github.com/users/ebidel","html_url":"https://github.com/ebidel","followers_url":"https://api.github.com/users/ebidel/followers","following_url":"https://api.github.com/users/ebidel/following{/other_user}","gists_url":"https://api.github.com/users/ebidel/gists{/gist_id}","starred_url":"https://api.github.com/users/ebidel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebidel/subscriptions","organizations_url":"https://api.github.com/users/ebidel/orgs","repos_url":"https://api.github.com/users/ebidel/repos","events_url":"https://api.github.com/users/ebidel/events{/privacy}","received_events_url":"https://api.github.com/users/ebidel/received_events","type":"User","site_admin":false},"body":"await browser.close()","created_at":"2018-08-06T15:52:05Z","updated_at":"2018-08-06T15:52:58Z","html_url":"https://github.com/GoogleCloudPlatform/nodejs-docs-samples/pull/705#discussion_r207941909","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/pulls/705","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/pulls/comments/207941909"},"html":{"href":"https://github.com/GoogleCloudPlatform/nodejs-docs-samples/pull/705#discussion_r207941909"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/pulls/705"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/pulls/705","id":206217521,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MjE3NTIx","html_url":"https://github.com/GoogleCloudPlatform/nodejs-docs-samples/pull/705","diff_url":"https://github.com/GoogleCloudPlatform/nodejs-docs-samples/pull/705.diff","patch_url":"https://github.com/GoogleCloudPlatform/nodejs-docs-samples/pull/705.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/issues/705","number":705,"state":"open","locked":false,"title":"GCF: Headless Chrome sample","user":{"login":"steren","id":360895,"node_id":"MDQ6VXNlcjM2MDg5NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/360895?v=4","gravatar_id":"","url":"https://api.github.com/users/steren","html_url":"https://github.com/steren","followers_url":"https://api.github.com/users/steren/followers","following_url":"https://api.github.com/users/steren/following{/other_user}","gists_url":"https://api.github.com/users/steren/gists{/gist_id}","starred_url":"https://api.github.com/users/steren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steren/subscriptions","organizations_url":"https://api.github.com/users/steren/orgs","repos_url":"https://api.github.com/users/steren/repos","events_url":"https://api.github.com/users/steren/events{/privacy}","received_events_url":"https://api.github.com/users/steren/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-05T01:38:53Z","updated_at":"2018-08-06T15:52:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea2889e7286b857a60fb7d6b89d8e317f68a5368","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":955669109,"node_id":"MDU6TGFiZWw5NTU2NjkxMDk=","url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/labels/cla:%20yes","name":"cla: yes","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/pulls/705/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/pulls/705/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/issues/705/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/statuses/8ae264309a94e24cb127acb061ee7f311bc55626","head":{"label":"steren:headless","ref":"headless","sha":"8ae264309a94e24cb127acb061ee7f311bc55626","user":{"login":"steren","id":360895,"node_id":"MDQ6VXNlcjM2MDg5NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/360895?v=4","gravatar_id":"","url":"https://api.github.com/users/steren","html_url":"https://github.com/steren","followers_url":"https://api.github.com/users/steren/followers","following_url":"https://api.github.com/users/steren/following{/other_user}","gists_url":"https://api.github.com/users/steren/gists{/gist_id}","starred_url":"https://api.github.com/users/steren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steren/subscriptions","organizations_url":"https://api.github.com/users/steren/orgs","repos_url":"https://api.github.com/users/steren/repos","events_url":"https://api.github.com/users/steren/events{/privacy}","received_events_url":"https://api.github.com/users/steren/received_events","type":"User","site_admin":false},"repo":{"id":134869574,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ4Njk1NzQ=","name":"nodejs-docs-samples","full_name":"steren/nodejs-docs-samples","owner":{"login":"steren","id":360895,"node_id":"MDQ6VXNlcjM2MDg5NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/360895?v=4","gravatar_id":"","url":"https://api.github.com/users/steren","html_url":"https://github.com/steren","followers_url":"https://api.github.com/users/steren/followers","following_url":"https://api.github.com/users/steren/following{/other_user}","gists_url":"https://api.github.com/users/steren/gists{/gist_id}","starred_url":"https://api.github.com/users/steren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steren/subscriptions","organizations_url":"https://api.github.com/users/steren/orgs","repos_url":"https://api.github.com/users/steren/repos","events_url":"https://api.github.com/users/steren/events{/privacy}","received_events_url":"https://api.github.com/users/steren/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/steren/nodejs-docs-samples","description":"Node.js samples for Google Cloud Platform products.","fork":true,"url":"https://api.github.com/repos/steren/nodejs-docs-samples","forks_url":"https://api.github.com/repos/steren/nodejs-docs-samples/forks","keys_url":"https://api.github.com/repos/steren/nodejs-docs-samples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/steren/nodejs-docs-samples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/steren/nodejs-docs-samples/teams","hooks_url":"https://api.github.com/repos/steren/nodejs-docs-samples/hooks","issue_events_url":"https://api.github.com/repos/steren/nodejs-docs-samples/issues/events{/number}","events_url":"https://api.github.com/repos/steren/nodejs-docs-samples/events","assignees_url":"https://api.github.com/repos/steren/nodejs-docs-samples/assignees{/user}","branches_url":"https://api.github.com/repos/steren/nodejs-docs-samples/branches{/branch}","tags_url":"https://api.github.com/repos/steren/nodejs-docs-samples/tags","blobs_url":"https://api.github.com/repos/steren/nodejs-docs-samples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/steren/nodejs-docs-samples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/steren/nodejs-docs-samples/git/refs{/sha}","trees_url":"https://api.github.com/repos/steren/nodejs-docs-samples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/steren/nodejs-docs-samples/statuses/{sha}","languages_url":"https://api.github.com/repos/steren/nodejs-docs-samples/languages","stargazers_url":"https://api.github.com/repos/steren/nodejs-docs-samples/stargazers","contributors_url":"https://api.github.com/repos/steren/nodejs-docs-samples/contributors","subscribers_url":"https://api.github.com/repos/steren/nodejs-docs-samples/subscribers","subscription_url":"https://api.github.com/repos/steren/nodejs-docs-samples/subscription","commits_url":"https://api.github.com/repos/steren/nodejs-docs-samples/commits{/sha}","git_commits_url":"https://api.github.com/repos/steren/nodejs-docs-samples/git/commits{/sha}","comments_url":"https://api.github.com/repos/steren/nodejs-docs-samples/comments{/number}","issue_comment_url":"https://api.github.com/repos/steren/nodejs-docs-samples/issues/comments{/number}","contents_url":"https://api.github.com/repos/steren/nodejs-docs-samples/contents/{+path}","compare_url":"https://api.github.com/repos/steren/nodejs-docs-samples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/steren/nodejs-docs-samples/merges","archive_url":"https://api.github.com/repos/steren/nodejs-docs-samples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/steren/nodejs-docs-samples/downloads","issues_url":"https://api.github.com/repos/steren/nodejs-docs-samples/issues{/number}","pulls_url":"https://api.github.com/repos/steren/nodejs-docs-samples/pulls{/number}","milestones_url":"https://api.github.com/repos/steren/nodejs-docs-samples/milestones{/number}","notifications_url":"https://api.github.com/repos/steren/nodejs-docs-samples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/steren/nodejs-docs-samples/labels{/name}","releases_url":"https://api.github.com/repos/steren/nodejs-docs-samples/releases{/id}","deployments_url":"https://api.github.com/repos/steren/nodejs-docs-samples/deployments","created_at":"2018-05-25T14:51:43Z","updated_at":"2018-08-05T01:39:54Z","pushed_at":"2018-08-05T01:47:14Z","git_url":"git://github.com/steren/nodejs-docs-samples.git","ssh_url":"[email protected]:steren/nodejs-docs-samples.git","clone_url":"https://github.com/steren/nodejs-docs-samples.git","svn_url":"https://github.com/steren/nodejs-docs-samples","homepage":"https://cloud.google.com/nodejs","size":13961,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"ccdd4002a6884ca7d88b6944778ff76e06ddb218","user":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":35065891,"node_id":"MDEwOlJlcG9zaXRvcnkzNTA2NTg5MQ==","name":"nodejs-docs-samples","full_name":"GoogleCloudPlatform/nodejs-docs-samples","owner":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/nodejs-docs-samples","description":"Node.js samples for Google Cloud Platform products.","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/deployments","created_at":"2015-05-04T23:26:38Z","updated_at":"2018-08-05T11:00:48Z","pushed_at":"2018-08-05T01:47:16Z","git_url":"git://github.com/GoogleCloudPlatform/nodejs-docs-samples.git","ssh_url":"[email protected]:GoogleCloudPlatform/nodejs-docs-samples.git","clone_url":"https://github.com/GoogleCloudPlatform/nodejs-docs-samples.git","svn_url":"https://github.com/GoogleCloudPlatform/nodejs-docs-samples","homepage":"https://cloud.google.com/nodejs","size":13789,"stargazers_count":1118,"watchers_count":1118,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":846,"mirror_url":null,"archived":false,"open_issues_count":68,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":846,"open_issues":68,"watchers":1118,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/pulls/705"},"html":{"href":"https://github.com/GoogleCloudPlatform/nodejs-docs-samples/pull/705"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/issues/705"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/issues/705/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/pulls/705/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/pulls/705/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples/statuses/8ae264309a94e24cb127acb061ee7f311bc55626"}},"author_association":"CONTRIBUTOR"}} | {
"id": 35065891,
"name": "GoogleCloudPlatform/nodejs-docs-samples",
"url": "https://api.github.com/repos/GoogleCloudPlatform/nodejs-docs-samples"
} | {
"id": 238208,
"login": "ebidel",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/238208?",
"url": "https://api.github.com/users/ebidel"
} | {
"id": 2810941,
"login": "GoogleCloudPlatform",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2810941?",
"url": "https://api.github.com/orgs/GoogleCloudPlatform"
} | 2018-08-06T15:52:05 | 8072413915 | {"actor":{"display_login":"ebidel"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/comments/204528912","pull_request_review_id":139623362,"id":204528912,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDUyODkxMg==","diff_hunk":"@@ -173,6 +173,20 @@ def delete_acl(self, entity):\n indexed.pop(entity)\n self.metadata['acl'] = indexed.values()\n \n+ def get_acl(self, entity):\n+ \"\"\"\n+ Get a single AccessControl entry from the Object revision.\n+\n+ :param entity:str the name of the entity.\n+ :return:dict with the contents of the ObjectAccessControl.\n+ \"\"\"\n+ entity = self.canonical_entity_name(entity)\n+ for acl in self.metadata.get('acl', []):\n+ if acl.get('entity', '') == entity:","path":"google/cloud/storage/tests/testbench.py","position":46,"original_position":13,"commit_id":"b29665a2ddaad74d9dfd524b4cbd245a273dafa3","original_commit_id":"d0d77b9a96ec3d361546f03f2351c9263a775102","user":{"login":"coryan","id":6241635,"node_id":"MDQ6VXNlcjYyNDE2MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/6241635?v=4","gravatar_id":"","url":"https://api.github.com/users/coryan","html_url":"https://github.com/coryan","followers_url":"https://api.github.com/users/coryan/followers","following_url":"https://api.github.com/users/coryan/following{/other_user}","gists_url":"https://api.github.com/users/coryan/gists{/gist_id}","starred_url":"https://api.github.com/users/coryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coryan/subscriptions","organizations_url":"https://api.github.com/users/coryan/orgs","repos_url":"https://api.github.com/users/coryan/repos","events_url":"https://api.github.com/users/coryan/events{/privacy}","received_events_url":"https://api.github.com/users/coryan/received_events","type":"User","site_admin":false},"body":"Good idea. What do you think of calling `lower()` in `canonical_entity_name()` instead? That way all the acl functions work like this.\r\n\r\n","created_at":"2018-07-23T19:37:52Z","updated_at":"2018-07-23T19:37:52Z","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-cpp/pull/906#discussion_r204528912","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/906","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/comments/204528912"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-cpp/pull/906#discussion_r204528912"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/906"}},"in_reply_to_id":204510826},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/906","id":202718641,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNzE4NjQx","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-cpp/pull/906","diff_url":"https://github.com/GoogleCloudPlatform/google-cloud-cpp/pull/906.diff","patch_url":"https://github.com/GoogleCloudPlatform/google-cloud-cpp/pull/906.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/issues/906","number":906,"state":"open","locked":false,"title":"Implement Client::GetObjectAcl.","user":{"login":"coryan","id":6241635,"node_id":"MDQ6VXNlcjYyNDE2MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/6241635?v=4","gravatar_id":"","url":"https://api.github.com/users/coryan","html_url":"https://github.com/coryan","followers_url":"https://api.github.com/users/coryan/followers","following_url":"https://api.github.com/users/coryan/following{/other_user}","gists_url":"https://api.github.com/users/coryan/gists{/gist_id}","starred_url":"https://api.github.com/users/coryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coryan/subscriptions","organizations_url":"https://api.github.com/users/coryan/orgs","repos_url":"https://api.github.com/users/coryan/repos","events_url":"https://api.github.com/users/coryan/events{/privacy}","received_events_url":"https://api.github.com/users/coryan/received_events","type":"User","site_admin":false},"body":"This fixes #840. It implements the API, the unit tests\r\nthe integration tests, and the sample snippet.","created_at":"2018-07-20T00:38:29Z","updated_at":"2018-07-23T19:37:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f08adf2fb5b5339c70f319dd953079158dd59a9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":760104389,"node_id":"MDU6TGFiZWw3NjAxMDQzODk=","url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false},{"id":921026962,"node_id":"MDU6TGFiZWw5MjEwMjY5NjI=","url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/labels/storage","name":"storage","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/906/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/906/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/issues/906/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/statuses/b29665a2ddaad74d9dfd524b4cbd245a273dafa3","head":{"label":"coryan:implement-get-object-acl","ref":"implement-get-object-acl","sha":"b29665a2ddaad74d9dfd524b4cbd245a273dafa3","user":{"login":"coryan","id":6241635,"node_id":"MDQ6VXNlcjYyNDE2MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/6241635?v=4","gravatar_id":"","url":"https://api.github.com/users/coryan","html_url":"https://github.com/coryan","followers_url":"https://api.github.com/users/coryan/followers","following_url":"https://api.github.com/users/coryan/following{/other_user}","gists_url":"https://api.github.com/users/coryan/gists{/gist_id}","starred_url":"https://api.github.com/users/coryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coryan/subscriptions","organizations_url":"https://api.github.com/users/coryan/orgs","repos_url":"https://api.github.com/users/coryan/repos","events_url":"https://api.github.com/users/coryan/events{/privacy}","received_events_url":"https://api.github.com/users/coryan/received_events","type":"User","site_admin":false},"repo":{"id":111937615,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE5Mzc2MTU=","name":"google-cloud-cpp","full_name":"coryan/google-cloud-cpp","owner":{"login":"coryan","id":6241635,"node_id":"MDQ6VXNlcjYyNDE2MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/6241635?v=4","gravatar_id":"","url":"https://api.github.com/users/coryan","html_url":"https://github.com/coryan","followers_url":"https://api.github.com/users/coryan/followers","following_url":"https://api.github.com/users/coryan/following{/other_user}","gists_url":"https://api.github.com/users/coryan/gists{/gist_id}","starred_url":"https://api.github.com/users/coryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coryan/subscriptions","organizations_url":"https://api.github.com/users/coryan/orgs","repos_url":"https://api.github.com/users/coryan/repos","events_url":"https://api.github.com/users/coryan/events{/privacy}","received_events_url":"https://api.github.com/users/coryan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/coryan/google-cloud-cpp","description":"Google Cloud Platform C++ client libraries","fork":true,"url":"https://api.github.com/repos/coryan/google-cloud-cpp","forks_url":"https://api.github.com/repos/coryan/google-cloud-cpp/forks","keys_url":"https://api.github.com/repos/coryan/google-cloud-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coryan/google-cloud-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coryan/google-cloud-cpp/teams","hooks_url":"https://api.github.com/repos/coryan/google-cloud-cpp/hooks","issue_events_url":"https://api.github.com/repos/coryan/google-cloud-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/coryan/google-cloud-cpp/events","assignees_url":"https://api.github.com/repos/coryan/google-cloud-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/coryan/google-cloud-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/coryan/google-cloud-cpp/tags","blobs_url":"https://api.github.com/repos/coryan/google-cloud-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coryan/google-cloud-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coryan/google-cloud-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/coryan/google-cloud-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coryan/google-cloud-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/coryan/google-cloud-cpp/languages","stargazers_url":"https://api.github.com/repos/coryan/google-cloud-cpp/stargazers","contributors_url":"https://api.github.com/repos/coryan/google-cloud-cpp/contributors","subscribers_url":"https://api.github.com/repos/coryan/google-cloud-cpp/subscribers","subscription_url":"https://api.github.com/repos/coryan/google-cloud-cpp/subscription","commits_url":"https://api.github.com/repos/coryan/google-cloud-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/coryan/google-cloud-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/coryan/google-cloud-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/coryan/google-cloud-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/coryan/google-cloud-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/coryan/google-cloud-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coryan/google-cloud-cpp/merges","archive_url":"https://api.github.com/repos/coryan/google-cloud-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coryan/google-cloud-cpp/downloads","issues_url":"https://api.github.com/repos/coryan/google-cloud-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/coryan/google-cloud-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/coryan/google-cloud-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/coryan/google-cloud-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coryan/google-cloud-cpp/labels{/name}","releases_url":"https://api.github.com/repos/coryan/google-cloud-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/coryan/google-cloud-cpp/deployments","created_at":"2017-11-24T16:28:07Z","updated_at":"2018-07-21T17:13:24Z","pushed_at":"2018-07-23T19:36:44Z","git_url":"git://github.com/coryan/google-cloud-cpp.git","ssh_url":"[email protected]:coryan/google-cloud-cpp.git","clone_url":"https://github.com/coryan/google-cloud-cpp.git","svn_url":"https://github.com/coryan/google-cloud-cpp","homepage":"https://cloud.google.com/","size":95109,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"0b5fc1b8433e3ad641caa119720b6d14c26a4ba1","user":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":111860063,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE4NjAwNjM=","name":"google-cloud-cpp","full_name":"GoogleCloudPlatform/google-cloud-cpp","owner":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-cpp","description":"Google Cloud Client Library for C++","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/deployments","created_at":"2017-11-24T00:19:31Z","updated_at":"2018-07-23T08:19:28Z","pushed_at":"2018-07-23T19:36:46Z","git_url":"git://github.com/GoogleCloudPlatform/google-cloud-cpp.git","ssh_url":"[email protected]:GoogleCloudPlatform/google-cloud-cpp.git","clone_url":"https://github.com/GoogleCloudPlatform/google-cloud-cpp.git","svn_url":"https://github.com/GoogleCloudPlatform/google-cloud-cpp","homepage":"https://cloud.google.com/","size":88073,"stargazers_count":35,"watchers_count":35,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":167,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":24,"open_issues":167,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/906"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-cpp/pull/906"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/issues/906"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/issues/906/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/906/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/906/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/statuses/b29665a2ddaad74d9dfd524b4cbd245a273dafa3"}},"author_association":"COLLABORATOR"}} | {
"id": 111860063,
"name": "GoogleCloudPlatform/google-cloud-cpp",
"url": "https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp"
} | {
"id": 6241635,
"login": "coryan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6241635?",
"url": "https://api.github.com/users/coryan"
} | {
"id": 2810941,
"login": "GoogleCloudPlatform",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2810941?",
"url": "https://api.github.com/orgs/GoogleCloudPlatform"
} | 2018-07-23T19:37:52 | 8005989453 | {"actor":{"display_login":"coryan"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments/242931322","pull_request_review_id":186564422,"id":242931322,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjkzMTMyMg==","diff_hunk":"@@ -61,7 +61,7 @@ public function deleteProductIdList(array $productIdList);\n * Duplicates the given product IDs.\n *\n * @param array $productListId The ID list of products to delete\n- * @param array $productIdList\n+ * @param array $productIdList The ID list of products to delete","path":"src/PrestaShopBundle/Service/DataUpdater/Admin/ProductInterface.php","position":12,"original_position":14,"commit_id":"83e374fe204b82e214950c83e53445b3a975385f","original_commit_id":"068427ef691f3a0f6f10dbbfe9f567949d4e99bb","user":{"login":"jolelievre","id":13801017,"node_id":"MDQ6VXNlcjEzODAxMDE3","avatar_url":"https://avatars1.githubusercontent.com/u/13801017?v=4","gravatar_id":"","url":"https://api.github.com/users/jolelievre","html_url":"https://github.com/jolelievre","followers_url":"https://api.github.com/users/jolelievre/followers","following_url":"https://api.github.com/users/jolelievre/following{/other_user}","gists_url":"https://api.github.com/users/jolelievre/gists{/gist_id}","starred_url":"https://api.github.com/users/jolelievre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jolelievre/subscriptions","organizations_url":"https://api.github.com/users/jolelievre/orgs","repos_url":"https://api.github.com/users/jolelievre/repos","events_url":"https://api.github.com/users/jolelievre/events{/privacy}","received_events_url":"https://api.github.com/users/jolelievre/received_events","type":"User","site_admin":false},"body":"remove the useless line","created_at":"2018-12-19T14:18:36Z","updated_at":"2018-12-19T14:18:55Z","html_url":"https://github.com/PrestaShop/PrestaShop/pull/11772#discussion_r242931322","pull_request_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/11772","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments/242931322"},"html":{"href":"https://github.com/PrestaShop/PrestaShop/pull/11772#discussion_r242931322"},"pull_request":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/11772"}}},"pull_request":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/11772","id":238470047,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NDcwMDQ3","html_url":"https://github.com/PrestaShop/PrestaShop/pull/11772","diff_url":"https://github.com/PrestaShop/PrestaShop/pull/11772.diff","patch_url":"https://github.com/PrestaShop/PrestaShop/pull/11772.patch","issue_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/11772","number":11772,"state":"open","locked":false,"title":"Add missing and improve PHP docs","user":{"login":"MathiasReker","id":26626066,"node_id":"MDQ6VXNlcjI2NjI2MDY2","avatar_url":"https://avatars3.githubusercontent.com/u/26626066?v=4","gravatar_id":"","url":"https://api.github.com/users/MathiasReker","html_url":"https://github.com/MathiasReker","followers_url":"https://api.github.com/users/MathiasReker/followers","following_url":"https://api.github.com/users/MathiasReker/following{/other_user}","gists_url":"https://api.github.com/users/MathiasReker/gists{/gist_id}","starred_url":"https://api.github.com/users/MathiasReker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MathiasReker/subscriptions","organizations_url":"https://api.github.com/users/MathiasReker/orgs","repos_url":"https://api.github.com/users/MathiasReker/repos","events_url":"https://api.github.com/users/MathiasReker/events{/privacy}","received_events_url":"https://api.github.com/users/MathiasReker/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for contributing to the PrestaShop project! \r\n\r\nPlease take the time to edit the \"Answers\" rows with the necessary information.\r\n\r\nCheck out our contribution guidelines to find out how to complete it:\r\nhttps://devdocs.prestashop.com/1.7/contribute/contribution-guidelines/#pull-requests\r\n -->\r\n\r\n| Questions | Answers\r\n| ------------- | -------------------------------------------------------\r\n| Branch? | develop\r\n| Description? | /\r\n| Type? | improvement\r\n| Category? | CO\r\n| BC breaks? | Does it break backward compatibility? no\r\n| Deprecations? | Does it deprecate an existing feature? no\r\n| Fixed ticket? | /\r\n| How to test? | /\r\n\r\n<!-- Click the form's \"Preview\" button to make sure the table is functional in GitHub. Thank you! -->\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/prestashop/prestashop/11772)\n<!-- Reviewable:end -->\n","created_at":"2018-12-13T17:22:15Z","updated_at":"2018-12-19T14:18:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ed5528d86890a716168edc406f0773731a5ad5d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":19737371,"node_id":"MDU6TGFiZWwxOTczNzM3MQ==","url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/Improvement","name":"Improvement","color":"d4c5f9","default":false},{"id":493336338,"node_id":"MDU6TGFiZWw0OTMzMzYzMzg=","url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/Needs%20port%20on%20StarterTheme","name":"Needs port on StarterTheme","color":"fbca04","default":false},{"id":904910825,"node_id":"MDU6TGFiZWw5MDQ5MTA4MjU=","url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/develop","name":"develop","color":"6270ea","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/11772/commits","review_comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/11772/comments","review_comment_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/11772/comments","statuses_url":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/83e374fe204b82e214950c83e53445b3a975385f","head":{"label":"MathiasReker:n5","ref":"n5","sha":"83e374fe204b82e214950c83e53445b3a975385f","user":{"login":"MathiasReker","id":26626066,"node_id":"MDQ6VXNlcjI2NjI2MDY2","avatar_url":"https://avatars3.githubusercontent.com/u/26626066?v=4","gravatar_id":"","url":"https://api.github.com/users/MathiasReker","html_url":"https://github.com/MathiasReker","followers_url":"https://api.github.com/users/MathiasReker/followers","following_url":"https://api.github.com/users/MathiasReker/following{/other_user}","gists_url":"https://api.github.com/users/MathiasReker/gists{/gist_id}","starred_url":"https://api.github.com/users/MathiasReker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MathiasReker/subscriptions","organizations_url":"https://api.github.com/users/MathiasReker/orgs","repos_url":"https://api.github.com/users/MathiasReker/repos","events_url":"https://api.github.com/users/MathiasReker/events{/privacy}","received_events_url":"https://api.github.com/users/MathiasReker/received_events","type":"User","site_admin":false},"repo":{"id":141559329,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE1NTkzMjk=","name":"PrestaShop-1","full_name":"MathiasReker/PrestaShop-1","private":false,"owner":{"login":"MathiasReker","id":26626066,"node_id":"MDQ6VXNlcjI2NjI2MDY2","avatar_url":"https://avatars3.githubusercontent.com/u/26626066?v=4","gravatar_id":"","url":"https://api.github.com/users/MathiasReker","html_url":"https://github.com/MathiasReker","followers_url":"https://api.github.com/users/MathiasReker/followers","following_url":"https://api.github.com/users/MathiasReker/following{/other_user}","gists_url":"https://api.github.com/users/MathiasReker/gists{/gist_id}","starred_url":"https://api.github.com/users/MathiasReker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MathiasReker/subscriptions","organizations_url":"https://api.github.com/users/MathiasReker/orgs","repos_url":"https://api.github.com/users/MathiasReker/repos","events_url":"https://api.github.com/users/MathiasReker/events{/privacy}","received_events_url":"https://api.github.com/users/MathiasReker/received_events","type":"User","site_admin":false},"html_url":"https://github.com/MathiasReker/PrestaShop-1","description":"PrestaShop offers a fully scalable open source ecommerce solution.","fork":true,"url":"https://api.github.com/repos/MathiasReker/PrestaShop-1","forks_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/forks","keys_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/teams","hooks_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/hooks","issue_events_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/issues/events{/number}","events_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/events","assignees_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/assignees{/user}","branches_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/branches{/branch}","tags_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/tags","blobs_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/statuses/{sha}","languages_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/languages","stargazers_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/stargazers","contributors_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/contributors","subscribers_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/subscribers","subscription_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/subscription","commits_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/contents/{+path}","compare_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/merges","archive_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/downloads","issues_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/issues{/number}","pulls_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/pulls{/number}","milestones_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/milestones{/number}","notifications_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/labels{/name}","releases_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/releases{/id}","deployments_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/deployments","created_at":"2018-07-19T09:50:59Z","updated_at":"2018-12-18T19:06:59Z","pushed_at":"2018-12-19T10:52:00Z","git_url":"git://github.com/MathiasReker/PrestaShop-1.git","ssh_url":"[email protected]:MathiasReker/PrestaShop-1.git","clone_url":"https://github.com/MathiasReker/PrestaShop-1.git","svn_url":"https://github.com/MathiasReker/PrestaShop-1","homepage":"http://www.prestashop.com/","size":365438,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"PrestaShop:develop","ref":"develop","sha":"ab0d56fdd5cd30bd7d4bd098af7a91fc5f27ca13","user":{"login":"PrestaShop","id":2815696,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTU2OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/2815696?v=4","gravatar_id":"","url":"https://api.github.com/users/PrestaShop","html_url":"https://github.com/PrestaShop","followers_url":"https://api.github.com/users/PrestaShop/followers","following_url":"https://api.github.com/users/PrestaShop/following{/other_user}","gists_url":"https://api.github.com/users/PrestaShop/gists{/gist_id}","starred_url":"https://api.github.com/users/PrestaShop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrestaShop/subscriptions","organizations_url":"https://api.github.com/users/PrestaShop/orgs","repos_url":"https://api.github.com/users/PrestaShop/repos","events_url":"https://api.github.com/users/PrestaShop/events{/privacy}","received_events_url":"https://api.github.com/users/PrestaShop/received_events","type":"Organization","site_admin":false},"repo":{"id":6763587,"node_id":"MDEwOlJlcG9zaXRvcnk2NzYzNTg3","name":"PrestaShop","full_name":"PrestaShop/PrestaShop","private":false,"owner":{"login":"PrestaShop","id":2815696,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTU2OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/2815696?v=4","gravatar_id":"","url":"https://api.github.com/users/PrestaShop","html_url":"https://github.com/PrestaShop","followers_url":"https://api.github.com/users/PrestaShop/followers","following_url":"https://api.github.com/users/PrestaShop/following{/other_user}","gists_url":"https://api.github.com/users/PrestaShop/gists{/gist_id}","starred_url":"https://api.github.com/users/PrestaShop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrestaShop/subscriptions","organizations_url":"https://api.github.com/users/PrestaShop/orgs","repos_url":"https://api.github.com/users/PrestaShop/repos","events_url":"https://api.github.com/users/PrestaShop/events{/privacy}","received_events_url":"https://api.github.com/users/PrestaShop/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PrestaShop/PrestaShop","description":"PrestaShop offers a fully scalable open source ecommerce solution.","fork":false,"url":"https://api.github.com/repos/PrestaShop/PrestaShop","forks_url":"https://api.github.com/repos/PrestaShop/PrestaShop/forks","keys_url":"https://api.github.com/repos/PrestaShop/PrestaShop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PrestaShop/PrestaShop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PrestaShop/PrestaShop/teams","hooks_url":"https://api.github.com/repos/PrestaShop/PrestaShop/hooks","issue_events_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/events{/number}","events_url":"https://api.github.com/repos/PrestaShop/PrestaShop/events","assignees_url":"https://api.github.com/repos/PrestaShop/PrestaShop/assignees{/user}","branches_url":"https://api.github.com/repos/PrestaShop/PrestaShop/branches{/branch}","tags_url":"https://api.github.com/repos/PrestaShop/PrestaShop/tags","blobs_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/refs{/sha}","trees_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/{sha}","languages_url":"https://api.github.com/repos/PrestaShop/PrestaShop/languages","stargazers_url":"https://api.github.com/repos/PrestaShop/PrestaShop/stargazers","contributors_url":"https://api.github.com/repos/PrestaShop/PrestaShop/contributors","subscribers_url":"https://api.github.com/repos/PrestaShop/PrestaShop/subscribers","subscription_url":"https://api.github.com/repos/PrestaShop/PrestaShop/subscription","commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/commits{/sha}","git_commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/commits{/sha}","comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/comments{/number}","issue_comment_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/comments{/number}","contents_url":"https://api.github.com/repos/PrestaShop/PrestaShop/contents/{+path}","compare_url":"https://api.github.com/repos/PrestaShop/PrestaShop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PrestaShop/PrestaShop/merges","archive_url":"https://api.github.com/repos/PrestaShop/PrestaShop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PrestaShop/PrestaShop/downloads","issues_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues{/number}","pulls_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls{/number}","milestones_url":"https://api.github.com/repos/PrestaShop/PrestaShop/milestones{/number}","notifications_url":"https://api.github.com/repos/PrestaShop/PrestaShop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels{/name}","releases_url":"https://api.github.com/repos/PrestaShop/PrestaShop/releases{/id}","deployments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/deployments","created_at":"2012-11-19T16:41:31Z","updated_at":"2018-12-19T13:32:08Z","pushed_at":"2018-12-19T13:31:30Z","git_url":"git://github.com/PrestaShop/PrestaShop.git","ssh_url":"[email protected]:PrestaShop/PrestaShop.git","clone_url":"https://github.com/PrestaShop/PrestaShop.git","svn_url":"https://github.com/PrestaShop/PrestaShop","homepage":"http://www.prestashop.com/","size":397223,"stargazers_count":3346,"watchers_count":3346,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3012,"mirror_url":null,"archived":false,"open_issues_count":1266,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3012,"open_issues":1266,"watchers":3346,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/11772"},"html":{"href":"https://github.com/PrestaShop/PrestaShop/pull/11772"},"issue":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/11772"},"comments":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/11772/comments"},"review_comments":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/11772/comments"},"review_comment":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/11772/commits"},"statuses":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/83e374fe204b82e214950c83e53445b3a975385f"}},"author_association":"CONTRIBUTOR"}} | {
"id": 6763587,
"name": "PrestaShop/PrestaShop",
"url": "https://api.github.com/repos/PrestaShop/PrestaShop"
} | {
"id": 13801017,
"login": "jolelievre",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13801017?",
"url": "https://api.github.com/users/jolelievre"
} | {
"id": 2815696,
"login": "PrestaShop",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2815696?",
"url": "https://api.github.com/orgs/PrestaShop"
} | 2018-12-19T14:18:36 | 8779241435 | {"actor":{"display_login":"jolelievre"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Kotti/Kotti/pulls/comments/169904822","pull_request_review_id":98504244,"id":169904822,"diff_hunk":"@@ -573,14 +622,15 @@ def adjust_for_engine(conn, branch):\n def patched_processed_result_value(self, value, dialect):\n if not value:\n return None\n- return self._upload_type.decode(unicode(value))\n+ return self._upload_type.decode(value)\n \n if conn.engine.dialect.name == 'sqlite': # pragma: no cover\n from depot.fields.sqlalchemy import UploadedFileField\n UploadedFileField.process_result_value = patched_processed_result_value\n \n ","path":"kotti/filedepot.py","position":336,"original_position":336,"commit_id":"5151b8293ed9f7aa33c77fce4233936c97640d66","original_commit_id":"5151b8293ed9f7aa33c77fce4233936c97640d66","user":{"login":"codacy-bot","id":19940114,"avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":" Issue found: [Exactly one space required around keyword argument assignment](https://app.codacy.com/app/disko/Kotti/pullRequest?prid=1245898)","created_at":"2018-02-22T09:57:38Z","updated_at":"2018-02-22T09:57:38Z","html_url":"https://github.com/Kotti/Kotti/pull/550#discussion_r169904822","pull_request_url":"https://api.github.com/repos/Kotti/Kotti/pulls/550","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Kotti/Kotti/pulls/comments/169904822"},"html":{"href":"https://github.com/Kotti/Kotti/pull/550#discussion_r169904822"},"pull_request":{"href":"https://api.github.com/repos/Kotti/Kotti/pulls/550"}}},"pull_request":{"url":"https://api.github.com/repos/Kotti/Kotti/pulls/550","id":163374299,"html_url":"https://github.com/Kotti/Kotti/pull/550","diff_url":"https://github.com/Kotti/Kotti/pull/550.diff","patch_url":"https://github.com/Kotti/Kotti/pull/550.patch","issue_url":"https://api.github.com/repos/Kotti/Kotti/issues/550","number":550,"state":"open","locked":false,"title":"PYTHON 3 SUPPORT","user":{"login":"disko","id":378908,"avatar_url":"https://avatars2.githubusercontent.com/u/378908?v=4","gravatar_id":"","url":"https://api.github.com/users/disko","html_url":"https://github.com/disko","followers_url":"https://api.github.com/users/disko/followers","following_url":"https://api.github.com/users/disko/following{/other_user}","gists_url":"https://api.github.com/users/disko/gists{/gist_id}","starred_url":"https://api.github.com/users/disko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/disko/subscriptions","organizations_url":"https://api.github.com/users/disko/orgs","repos_url":"https://api.github.com/users/disko/repos","events_url":"https://api.github.com/users/disko/events{/privacy}","received_events_url":"https://api.github.com/users/disko/received_events","type":"User","site_admin":false},"body":"Title says it all: this PR add Python 3.5 and 3.6 support and completely drops support for Python 2.\r\n\r\nThe changelog isn't updated yet, but there are very few minor API changes. Scaffolding was removed (see #549), everything else stays the same. Most existing applications should continue to work without any changes at all.\r\n\r\n**DO NOT MERGE**\r\n\r\nTODO:\r\n\r\n- [x] release 1.3.1\r\n- [x] check state of no longer included ``kotti-image``\r\n- [x] cleanup inline comments / leftovers\r\n- [ ] update docs\r\n- [ ] cleanup git history\r\n","created_at":"2018-01-17T08:09:00Z","updated_at":"2018-02-22T09:57:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"810d466eac24d76f4c10f75b4c24780b93b837ff","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Kotti/Kotti/pulls/550/commits","review_comments_url":"https://api.github.com/repos/Kotti/Kotti/pulls/550/comments","review_comment_url":"https://api.github.com/repos/Kotti/Kotti/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Kotti/Kotti/issues/550/comments","statuses_url":"https://api.github.com/repos/Kotti/Kotti/statuses/5151b8293ed9f7aa33c77fce4233936c97640d66","head":{"label":"disko:py3","ref":"py3","sha":"5151b8293ed9f7aa33c77fce4233936c97640d66","user":{"login":"disko","id":378908,"avatar_url":"https://avatars2.githubusercontent.com/u/378908?v=4","gravatar_id":"","url":"https://api.github.com/users/disko","html_url":"https://github.com/disko","followers_url":"https://api.github.com/users/disko/followers","following_url":"https://api.github.com/users/disko/following{/other_user}","gists_url":"https://api.github.com/users/disko/gists{/gist_id}","starred_url":"https://api.github.com/users/disko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/disko/subscriptions","organizations_url":"https://api.github.com/users/disko/orgs","repos_url":"https://api.github.com/users/disko/repos","events_url":"https://api.github.com/users/disko/events{/privacy}","received_events_url":"https://api.github.com/users/disko/received_events","type":"User","site_admin":false},"repo":{"id":3516356,"name":"Kotti","full_name":"disko/Kotti","owner":{"login":"disko","id":378908,"avatar_url":"https://avatars2.githubusercontent.com/u/378908?v=4","gravatar_id":"","url":"https://api.github.com/users/disko","html_url":"https://github.com/disko","followers_url":"https://api.github.com/users/disko/followers","following_url":"https://api.github.com/users/disko/following{/other_user}","gists_url":"https://api.github.com/users/disko/gists{/gist_id}","starred_url":"https://api.github.com/users/disko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/disko/subscriptions","organizations_url":"https://api.github.com/users/disko/orgs","repos_url":"https://api.github.com/users/disko/repos","events_url":"https://api.github.com/users/disko/events{/privacy}","received_events_url":"https://api.github.com/users/disko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/disko/Kotti","description":"A user-friendly, light-weight and extensible web content management system. Written in Python, based on Pyramid and SQLAlchemy.","fork":true,"url":"https://api.github.com/repos/disko/Kotti","forks_url":"https://api.github.com/repos/disko/Kotti/forks","keys_url":"https://api.github.com/repos/disko/Kotti/keys{/key_id}","collaborators_url":"https://api.github.com/repos/disko/Kotti/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/disko/Kotti/teams","hooks_url":"https://api.github.com/repos/disko/Kotti/hooks","issue_events_url":"https://api.github.com/repos/disko/Kotti/issues/events{/number}","events_url":"https://api.github.com/repos/disko/Kotti/events","assignees_url":"https://api.github.com/repos/disko/Kotti/assignees{/user}","branches_url":"https://api.github.com/repos/disko/Kotti/branches{/branch}","tags_url":"https://api.github.com/repos/disko/Kotti/tags","blobs_url":"https://api.github.com/repos/disko/Kotti/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/disko/Kotti/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/disko/Kotti/git/refs{/sha}","trees_url":"https://api.github.com/repos/disko/Kotti/git/trees{/sha}","statuses_url":"https://api.github.com/repos/disko/Kotti/statuses/{sha}","languages_url":"https://api.github.com/repos/disko/Kotti/languages","stargazers_url":"https://api.github.com/repos/disko/Kotti/stargazers","contributors_url":"https://api.github.com/repos/disko/Kotti/contributors","subscribers_url":"https://api.github.com/repos/disko/Kotti/subscribers","subscription_url":"https://api.github.com/repos/disko/Kotti/subscription","commits_url":"https://api.github.com/repos/disko/Kotti/commits{/sha}","git_commits_url":"https://api.github.com/repos/disko/Kotti/git/commits{/sha}","comments_url":"https://api.github.com/repos/disko/Kotti/comments{/number}","issue_comment_url":"https://api.github.com/repos/disko/Kotti/issues/comments{/number}","contents_url":"https://api.github.com/repos/disko/Kotti/contents/{+path}","compare_url":"https://api.github.com/repos/disko/Kotti/compare/{base}...{head}","merges_url":"https://api.github.com/repos/disko/Kotti/merges","archive_url":"https://api.github.com/repos/disko/Kotti/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/disko/Kotti/downloads","issues_url":"https://api.github.com/repos/disko/Kotti/issues{/number}","pulls_url":"https://api.github.com/repos/disko/Kotti/pulls{/number}","milestones_url":"https://api.github.com/repos/disko/Kotti/milestones{/number}","notifications_url":"https://api.github.com/repos/disko/Kotti/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/disko/Kotti/labels{/name}","releases_url":"https://api.github.com/repos/disko/Kotti/releases{/id}","deployments_url":"https://api.github.com/repos/disko/Kotti/deployments","created_at":"2012-02-22T16:24:57Z","updated_at":"2015-05-05T07:27:27Z","pushed_at":"2018-02-22T09:20:34Z","git_url":"git://github.com/disko/Kotti.git","ssh_url":"[email protected]:disko/Kotti.git","clone_url":"https://github.com/disko/Kotti.git","svn_url":"https://github.com/disko/Kotti","homepage":"","size":8303,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"Kotti:master","ref":"master","sha":"462d847879ab9f363d96fd976e21bce9dfd6ed64","user":{"login":"Kotti","id":2951509,"avatar_url":"https://avatars3.githubusercontent.com/u/2951509?v=4","gravatar_id":"","url":"https://api.github.com/users/Kotti","html_url":"https://github.com/Kotti","followers_url":"https://api.github.com/users/Kotti/followers","following_url":"https://api.github.com/users/Kotti/following{/other_user}","gists_url":"https://api.github.com/users/Kotti/gists{/gist_id}","starred_url":"https://api.github.com/users/Kotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kotti/subscriptions","organizations_url":"https://api.github.com/users/Kotti/orgs","repos_url":"https://api.github.com/users/Kotti/repos","events_url":"https://api.github.com/users/Kotti/events{/privacy}","received_events_url":"https://api.github.com/users/Kotti/received_events","type":"Organization","site_admin":false},"repo":{"id":1303218,"name":"Kotti","full_name":"Kotti/Kotti","owner":{"login":"Kotti","id":2951509,"avatar_url":"https://avatars3.githubusercontent.com/u/2951509?v=4","gravatar_id":"","url":"https://api.github.com/users/Kotti","html_url":"https://github.com/Kotti","followers_url":"https://api.github.com/users/Kotti/followers","following_url":"https://api.github.com/users/Kotti/following{/other_user}","gists_url":"https://api.github.com/users/Kotti/gists{/gist_id}","starred_url":"https://api.github.com/users/Kotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kotti/subscriptions","organizations_url":"https://api.github.com/users/Kotti/orgs","repos_url":"https://api.github.com/users/Kotti/repos","events_url":"https://api.github.com/users/Kotti/events{/privacy}","received_events_url":"https://api.github.com/users/Kotti/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Kotti/Kotti","description":"Kotti is a high-level, Pythonic web application framework based on Pyramid and SQLAlchemy. It includes an extensible Content Management System called the Kotti CMS.","fork":false,"url":"https://api.github.com/repos/Kotti/Kotti","forks_url":"https://api.github.com/repos/Kotti/Kotti/forks","keys_url":"https://api.github.com/repos/Kotti/Kotti/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kotti/Kotti/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kotti/Kotti/teams","hooks_url":"https://api.github.com/repos/Kotti/Kotti/hooks","issue_events_url":"https://api.github.com/repos/Kotti/Kotti/issues/events{/number}","events_url":"https://api.github.com/repos/Kotti/Kotti/events","assignees_url":"https://api.github.com/repos/Kotti/Kotti/assignees{/user}","branches_url":"https://api.github.com/repos/Kotti/Kotti/branches{/branch}","tags_url":"https://api.github.com/repos/Kotti/Kotti/tags","blobs_url":"https://api.github.com/repos/Kotti/Kotti/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kotti/Kotti/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kotti/Kotti/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kotti/Kotti/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kotti/Kotti/statuses/{sha}","languages_url":"https://api.github.com/repos/Kotti/Kotti/languages","stargazers_url":"https://api.github.com/repos/Kotti/Kotti/stargazers","contributors_url":"https://api.github.com/repos/Kotti/Kotti/contributors","subscribers_url":"https://api.github.com/repos/Kotti/Kotti/subscribers","subscription_url":"https://api.github.com/repos/Kotti/Kotti/subscription","commits_url":"https://api.github.com/repos/Kotti/Kotti/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kotti/Kotti/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kotti/Kotti/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kotti/Kotti/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kotti/Kotti/contents/{+path}","compare_url":"https://api.github.com/repos/Kotti/Kotti/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kotti/Kotti/merges","archive_url":"https://api.github.com/repos/Kotti/Kotti/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kotti/Kotti/downloads","issues_url":"https://api.github.com/repos/Kotti/Kotti/issues{/number}","pulls_url":"https://api.github.com/repos/Kotti/Kotti/pulls{/number}","milestones_url":"https://api.github.com/repos/Kotti/Kotti/milestones{/number}","notifications_url":"https://api.github.com/repos/Kotti/Kotti/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kotti/Kotti/labels{/name}","releases_url":"https://api.github.com/repos/Kotti/Kotti/releases{/id}","deployments_url":"https://api.github.com/repos/Kotti/Kotti/deployments","created_at":"2011-01-28T15:42:02Z","updated_at":"2018-02-15T16:19:42Z","pushed_at":"2018-02-22T09:20:36Z","git_url":"git://github.com/Kotti/Kotti.git","ssh_url":"[email protected]:Kotti/Kotti.git","clone_url":"https://github.com/Kotti/Kotti.git","svn_url":"https://github.com/Kotti/Kotti","homepage":"http://kotti.pylonsproject.org","size":7236,"stargazers_count":319,"watchers_count":319,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":102,"mirror_url":null,"archived":false,"open_issues_count":51,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":102,"open_issues":51,"watchers":319,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Kotti/Kotti/pulls/550"},"html":{"href":"https://github.com/Kotti/Kotti/pull/550"},"issue":{"href":"https://api.github.com/repos/Kotti/Kotti/issues/550"},"comments":{"href":"https://api.github.com/repos/Kotti/Kotti/issues/550/comments"},"review_comments":{"href":"https://api.github.com/repos/Kotti/Kotti/pulls/550/comments"},"review_comment":{"href":"https://api.github.com/repos/Kotti/Kotti/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Kotti/Kotti/pulls/550/commits"},"statuses":{"href":"https://api.github.com/repos/Kotti/Kotti/statuses/5151b8293ed9f7aa33c77fce4233936c97640d66"}},"author_association":"OWNER"}} | {
"id": 1303218,
"name": "Kotti/Kotti",
"url": "https://api.github.com/repos/Kotti/Kotti"
} | {
"id": 19940114,
"login": "codacy-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19940114?",
"url": "https://api.github.com/users/codacy-bot"
} | {
"id": 2951509,
"login": "Kotti",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2951509?",
"url": "https://api.github.com/orgs/Kotti"
} | 2018-02-22T09:57:38 | 7280548681 | {"actor":{"display_login":"codacy-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/INRIA/spoon/pulls/comments/194672133","pull_request_review_id":127885179,"id":194672133,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDY3MjEzMw==","diff_hunk":"@@ -407,6 +411,139 @@ private String extractVariable(String value) {\n \t\t\treturn value;\n \t\t}\n \n+\t\tprivate List<Version> getVersionsFromM2(String groupId, String artifactId) {\n+\t\t\tString groupIdPath = groupId.replace(\".\", \"/\");\n+\t\t\tFile[] fileVersion = Paths.get(m2RepositoryPath, groupIdPath, artifactId).toFile().listFiles(file -> {\n+\t\t\t\tif (!file.isDirectory()) {\n+\t\t\t\t\treturn false;\n+\t\t\t\t}\n+\t\t\t\tString version = file.getName();\n+\t\t\t\treturn Paths.get(m2RepositoryPath, groupIdPath, artifactId, version, artifactId + \"-\" + version + \".jar\").toFile().exists();\n+\t\t\t});\n+\t\t\tif (fileVersion == null) {\n+\t\t\t\treturn Collections.emptyList();\n+\t\t\t}\n+\t\t\tList<Version> versions = Arrays.stream(fileVersion).map(f -> new Version(f.getName())).collect(Collectors.toList());\n+\t\t\tversions.sort(Comparator.reverseOrder());\n+\t\t\treturn versions;\n+\t\t}\n+\n+\t\tclass Version implements Comparable<Version> {","path":"src/main/java/spoon/MavenLauncher.java","position":47,"original_position":47,"commit_id":"765cdec809303f56735ac32e0bc5afe6deb794fa","original_commit_id":"765cdec809303f56735ac32e0bc5afe6deb794fa","user":{"login":"surli","id":1478232,"node_id":"MDQ6VXNlcjE0NzgyMzI=","avatar_url":"https://avatars2.githubusercontent.com/u/1478232?v=4","gravatar_id":"","url":"https://api.github.com/users/surli","html_url":"https://github.com/surli","followers_url":"https://api.github.com/users/surli/followers","following_url":"https://api.github.com/users/surli/following{/other_user}","gists_url":"https://api.github.com/users/surli/gists{/gist_id}","starred_url":"https://api.github.com/users/surli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/surli/subscriptions","organizations_url":"https://api.github.com/users/surli/orgs","repos_url":"https://api.github.com/users/surli/repos","events_url":"https://api.github.com/users/surli/events{/privacy}","received_events_url":"https://api.github.com/users/surli/received_events","type":"User","site_admin":false},"body":"What about extracting the inner classes: the MavenLauncher seems now composed almost entirely of InheritanceModel. It seems easier to me to maintain if it's extracted. ","created_at":"2018-06-12T09:28:43Z","updated_at":"2018-06-12T09:28:43Z","html_url":"https://github.com/INRIA/spoon/pull/2057#discussion_r194672133","pull_request_url":"https://api.github.com/repos/INRIA/spoon/pulls/2057","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/INRIA/spoon/pulls/comments/194672133"},"html":{"href":"https://github.com/INRIA/spoon/pull/2057#discussion_r194672133"},"pull_request":{"href":"https://api.github.com/repos/INRIA/spoon/pulls/2057"}}},"pull_request":{"url":"https://api.github.com/repos/INRIA/spoon/pulls/2057","id":194215722,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MjE1NzIy","html_url":"https://github.com/INRIA/spoon/pull/2057","diff_url":"https://github.com/INRIA/spoon/pull/2057.diff","patch_url":"https://github.com/INRIA/spoon/pull/2057.patch","issue_url":"https://api.github.com/repos/INRIA/spoon/issues/2057","number":2057,"state":"open","locked":false,"title":"feat(launcher): handles range version in MavenLauncher","user":{"login":"tdurieux","id":5577568,"node_id":"MDQ6VXNlcjU1Nzc1Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/5577568?v=4","gravatar_id":"","url":"https://api.github.com/users/tdurieux","html_url":"https://github.com/tdurieux","followers_url":"https://api.github.com/users/tdurieux/followers","following_url":"https://api.github.com/users/tdurieux/following{/other_user}","gists_url":"https://api.github.com/users/tdurieux/gists{/gist_id}","starred_url":"https://api.github.com/users/tdurieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdurieux/subscriptions","organizations_url":"https://api.github.com/users/tdurieux/orgs","repos_url":"https://api.github.com/users/tdurieux/repos","events_url":"https://api.github.com/users/tdurieux/events{/privacy}","received_events_url":"https://api.github.com/users/tdurieux/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-12T09:17:56Z","updated_at":"2018-06-12T09:28:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14e20fa03385526e8122815c483b8e234014b5ca","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/INRIA/spoon/pulls/2057/commits","review_comments_url":"https://api.github.com/repos/INRIA/spoon/pulls/2057/comments","review_comment_url":"https://api.github.com/repos/INRIA/spoon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/INRIA/spoon/issues/2057/comments","statuses_url":"https://api.github.com/repos/INRIA/spoon/statuses/765cdec809303f56735ac32e0bc5afe6deb794fa","head":{"label":"tdurieux:feat_range_version","ref":"feat_range_version","sha":"765cdec809303f56735ac32e0bc5afe6deb794fa","user":{"login":"tdurieux","id":5577568,"node_id":"MDQ6VXNlcjU1Nzc1Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/5577568?v=4","gravatar_id":"","url":"https://api.github.com/users/tdurieux","html_url":"https://github.com/tdurieux","followers_url":"https://api.github.com/users/tdurieux/followers","following_url":"https://api.github.com/users/tdurieux/following{/other_user}","gists_url":"https://api.github.com/users/tdurieux/gists{/gist_id}","starred_url":"https://api.github.com/users/tdurieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdurieux/subscriptions","organizations_url":"https://api.github.com/users/tdurieux/orgs","repos_url":"https://api.github.com/users/tdurieux/repos","events_url":"https://api.github.com/users/tdurieux/events{/privacy}","received_events_url":"https://api.github.com/users/tdurieux/received_events","type":"User","site_admin":false},"repo":{"id":42295680,"node_id":"MDEwOlJlcG9zaXRvcnk0MjI5NTY4MA==","name":"spoon","full_name":"tdurieux/spoon","owner":{"login":"tdurieux","id":5577568,"node_id":"MDQ6VXNlcjU1Nzc1Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/5577568?v=4","gravatar_id":"","url":"https://api.github.com/users/tdurieux","html_url":"https://github.com/tdurieux","followers_url":"https://api.github.com/users/tdurieux/followers","following_url":"https://api.github.com/users/tdurieux/following{/other_user}","gists_url":"https://api.github.com/users/tdurieux/gists{/gist_id}","starred_url":"https://api.github.com/users/tdurieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdurieux/subscriptions","organizations_url":"https://api.github.com/users/tdurieux/orgs","repos_url":"https://api.github.com/users/tdurieux/repos","events_url":"https://api.github.com/users/tdurieux/events{/privacy}","received_events_url":"https://api.github.com/users/tdurieux/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tdurieux/spoon","description":"Spoon is a library for analyzing and transforming Java source code.","fork":true,"url":"https://api.github.com/repos/tdurieux/spoon","forks_url":"https://api.github.com/repos/tdurieux/spoon/forks","keys_url":"https://api.github.com/repos/tdurieux/spoon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tdurieux/spoon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tdurieux/spoon/teams","hooks_url":"https://api.github.com/repos/tdurieux/spoon/hooks","issue_events_url":"https://api.github.com/repos/tdurieux/spoon/issues/events{/number}","events_url":"https://api.github.com/repos/tdurieux/spoon/events","assignees_url":"https://api.github.com/repos/tdurieux/spoon/assignees{/user}","branches_url":"https://api.github.com/repos/tdurieux/spoon/branches{/branch}","tags_url":"https://api.github.com/repos/tdurieux/spoon/tags","blobs_url":"https://api.github.com/repos/tdurieux/spoon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tdurieux/spoon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tdurieux/spoon/git/refs{/sha}","trees_url":"https://api.github.com/repos/tdurieux/spoon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tdurieux/spoon/statuses/{sha}","languages_url":"https://api.github.com/repos/tdurieux/spoon/languages","stargazers_url":"https://api.github.com/repos/tdurieux/spoon/stargazers","contributors_url":"https://api.github.com/repos/tdurieux/spoon/contributors","subscribers_url":"https://api.github.com/repos/tdurieux/spoon/subscribers","subscription_url":"https://api.github.com/repos/tdurieux/spoon/subscription","commits_url":"https://api.github.com/repos/tdurieux/spoon/commits{/sha}","git_commits_url":"https://api.github.com/repos/tdurieux/spoon/git/commits{/sha}","comments_url":"https://api.github.com/repos/tdurieux/spoon/comments{/number}","issue_comment_url":"https://api.github.com/repos/tdurieux/spoon/issues/comments{/number}","contents_url":"https://api.github.com/repos/tdurieux/spoon/contents/{+path}","compare_url":"https://api.github.com/repos/tdurieux/spoon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tdurieux/spoon/merges","archive_url":"https://api.github.com/repos/tdurieux/spoon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tdurieux/spoon/downloads","issues_url":"https://api.github.com/repos/tdurieux/spoon/issues{/number}","pulls_url":"https://api.github.com/repos/tdurieux/spoon/pulls{/number}","milestones_url":"https://api.github.com/repos/tdurieux/spoon/milestones{/number}","notifications_url":"https://api.github.com/repos/tdurieux/spoon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tdurieux/spoon/labels{/name}","releases_url":"https://api.github.com/repos/tdurieux/spoon/releases{/id}","deployments_url":"https://api.github.com/repos/tdurieux/spoon/deployments","created_at":"2015-09-11T08:01:22Z","updated_at":"2018-05-02T10:04:06Z","pushed_at":"2018-06-12T09:17:25Z","git_url":"git://github.com/tdurieux/spoon.git","ssh_url":"[email protected]:tdurieux/spoon.git","clone_url":"https://github.com/tdurieux/spoon.git","svn_url":"https://github.com/tdurieux/spoon","homepage":"http://spoon.gforge.inria.fr/","size":21322,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"INRIA:master","ref":"master","sha":"ee1c2aeeab31beacb4b3e76703c9a492238b74fa","user":{"login":"INRIA","id":2951919,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NTE5MTk=","avatar_url":"https://avatars2.githubusercontent.com/u/2951919?v=4","gravatar_id":"","url":"https://api.github.com/users/INRIA","html_url":"https://github.com/INRIA","followers_url":"https://api.github.com/users/INRIA/followers","following_url":"https://api.github.com/users/INRIA/following{/other_user}","gists_url":"https://api.github.com/users/INRIA/gists{/gist_id}","starred_url":"https://api.github.com/users/INRIA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/INRIA/subscriptions","organizations_url":"https://api.github.com/users/INRIA/orgs","repos_url":"https://api.github.com/users/INRIA/repos","events_url":"https://api.github.com/users/INRIA/events{/privacy}","received_events_url":"https://api.github.com/users/INRIA/received_events","type":"Organization","site_admin":false},"repo":{"id":14176513,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE3NjUxMw==","name":"spoon","full_name":"INRIA/spoon","owner":{"login":"INRIA","id":2951919,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NTE5MTk=","avatar_url":"https://avatars2.githubusercontent.com/u/2951919?v=4","gravatar_id":"","url":"https://api.github.com/users/INRIA","html_url":"https://github.com/INRIA","followers_url":"https://api.github.com/users/INRIA/followers","following_url":"https://api.github.com/users/INRIA/following{/other_user}","gists_url":"https://api.github.com/users/INRIA/gists{/gist_id}","starred_url":"https://api.github.com/users/INRIA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/INRIA/subscriptions","organizations_url":"https://api.github.com/users/INRIA/orgs","repos_url":"https://api.github.com/users/INRIA/repos","events_url":"https://api.github.com/users/INRIA/events{/privacy}","received_events_url":"https://api.github.com/users/INRIA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/INRIA/spoon","description":"Spoon is a library to analyze, transform, rewrite, transpile Java source code (incl Java 9 modules). It parses source files to build a well-designed AST with powerful analysis and transformation API. Made at Inria with :heart:, :beers: and :sparkles:.","fork":false,"url":"https://api.github.com/repos/INRIA/spoon","forks_url":"https://api.github.com/repos/INRIA/spoon/forks","keys_url":"https://api.github.com/repos/INRIA/spoon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/INRIA/spoon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/INRIA/spoon/teams","hooks_url":"https://api.github.com/repos/INRIA/spoon/hooks","issue_events_url":"https://api.github.com/repos/INRIA/spoon/issues/events{/number}","events_url":"https://api.github.com/repos/INRIA/spoon/events","assignees_url":"https://api.github.com/repos/INRIA/spoon/assignees{/user}","branches_url":"https://api.github.com/repos/INRIA/spoon/branches{/branch}","tags_url":"https://api.github.com/repos/INRIA/spoon/tags","blobs_url":"https://api.github.com/repos/INRIA/spoon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/INRIA/spoon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/INRIA/spoon/git/refs{/sha}","trees_url":"https://api.github.com/repos/INRIA/spoon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/INRIA/spoon/statuses/{sha}","languages_url":"https://api.github.com/repos/INRIA/spoon/languages","stargazers_url":"https://api.github.com/repos/INRIA/spoon/stargazers","contributors_url":"https://api.github.com/repos/INRIA/spoon/contributors","subscribers_url":"https://api.github.com/repos/INRIA/spoon/subscribers","subscription_url":"https://api.github.com/repos/INRIA/spoon/subscription","commits_url":"https://api.github.com/repos/INRIA/spoon/commits{/sha}","git_commits_url":"https://api.github.com/repos/INRIA/spoon/git/commits{/sha}","comments_url":"https://api.github.com/repos/INRIA/spoon/comments{/number}","issue_comment_url":"https://api.github.com/repos/INRIA/spoon/issues/comments{/number}","contents_url":"https://api.github.com/repos/INRIA/spoon/contents/{+path}","compare_url":"https://api.github.com/repos/INRIA/spoon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/INRIA/spoon/merges","archive_url":"https://api.github.com/repos/INRIA/spoon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/INRIA/spoon/downloads","issues_url":"https://api.github.com/repos/INRIA/spoon/issues{/number}","pulls_url":"https://api.github.com/repos/INRIA/spoon/pulls{/number}","milestones_url":"https://api.github.com/repos/INRIA/spoon/milestones{/number}","notifications_url":"https://api.github.com/repos/INRIA/spoon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/INRIA/spoon/labels{/name}","releases_url":"https://api.github.com/repos/INRIA/spoon/releases{/id}","deployments_url":"https://api.github.com/repos/INRIA/spoon/deployments","created_at":"2013-11-06T15:29:59Z","updated_at":"2018-06-11T12:07:16Z","pushed_at":"2018-06-12T09:17:57Z","git_url":"git://github.com/INRIA/spoon.git","ssh_url":"[email protected]:INRIA/spoon.git","clone_url":"https://github.com/INRIA/spoon.git","svn_url":"https://github.com/INRIA/spoon","homepage":"http://spoon.gforge.inria.fr/","size":20937,"stargazers_count":521,"watchers_count":521,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":111,"mirror_url":null,"archived":false,"open_issues_count":53,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":111,"open_issues":53,"watchers":521,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/INRIA/spoon/pulls/2057"},"html":{"href":"https://github.com/INRIA/spoon/pull/2057"},"issue":{"href":"https://api.github.com/repos/INRIA/spoon/issues/2057"},"comments":{"href":"https://api.github.com/repos/INRIA/spoon/issues/2057/comments"},"review_comments":{"href":"https://api.github.com/repos/INRIA/spoon/pulls/2057/comments"},"review_comment":{"href":"https://api.github.com/repos/INRIA/spoon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/INRIA/spoon/pulls/2057/commits"},"statuses":{"href":"https://api.github.com/repos/INRIA/spoon/statuses/765cdec809303f56735ac32e0bc5afe6deb794fa"}},"author_association":"COLLABORATOR"}} | {
"id": 14176513,
"name": "INRIA/spoon",
"url": "https://api.github.com/repos/INRIA/spoon"
} | {
"id": 1478232,
"login": "surli",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1478232?",
"url": "https://api.github.com/users/surli"
} | {
"id": 2951919,
"login": "INRIA",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2951919?",
"url": "https://api.github.com/orgs/INRIA"
} | 2018-06-12T09:28:43 | 7811228527 | {"actor":{"display_login":"surli"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/CVC4/CVC4/pulls/comments/176931155","pull_request_review_id":106720747,"id":176931155,"diff_hunk":"@@ -138,34 +135,39 @@ Abc_Aig_t* AigBitblaster::currentAigM() {\n }\n \n AigBitblaster::AigBitblaster()\n- : TBitblaster<Abc_Obj_t*>()\n- , d_aigCache()\n- , d_bbAtoms()\n- , d_aigOutputNode(NULL)\n+ : TBitblaster<Abc_Obj_t*>(),\n+ d_nullContext(new context::Context()),\n+ d_aigCache(),\n+ d_bbAtoms(),\n+ d_aigOutputNode(NULL)\n {\n- d_nullContext = new context::Context();\n- switch(options::bvSatSolver()) {\n- case SAT_SOLVER_MINISAT: {\n- prop::BVSatSolverInterface* minisat = prop::SatSolverFactory::createMinisat(d_nullContext,\n- smtStatisticsRegistry(),\n- \"AigBitblaster\");\n- MinisatEmptyNotify* notify = new MinisatEmptyNotify();\n- minisat->setNotify(notify);\n- d_satSolver = minisat;\n- break;\n- }\n- case SAT_SOLVER_CRYPTOMINISAT:\n- d_satSolver = prop::SatSolverFactory::createCryptoMinisat(smtStatisticsRegistry(),\n- \"AigBitblaster\");\n- break;\n- default: CVC4_FATAL() << \"Unknown SAT solver type\";\n+ prop::SatSolver* solver = nullptr;\n+ switch (options::bvSatSolver())\n+ {\n+ case SAT_SOLVER_MINISAT:\n+ {\n+ prop::BVSatSolverInterface* minisat =\n+ prop::SatSolverFactory::createMinisat(\n+ d_nullContext.get(), smtStatisticsRegistry(), \"AigBitblaster\");\n+ MinisatEmptyNotify* notify = new MinisatEmptyNotify();\n+ minisat->setNotify(notify);\n+ solver = minisat;\n+ break;\n+ }\n+ case SAT_SOLVER_CADICAL:\n+ solver = prop::SatSolverFactory::createCadical(smtStatisticsRegistry(),\n+ \"AigBitblaster\");\n+ break;\n+ case SAT_SOLVER_CRYPTOMINISAT:\n+ solver = prop::SatSolverFactory::createCryptoMinisat(\n+ smtStatisticsRegistry(), \"AigBitblaster\");\n+ break;\n+ default: CVC4_FATAL() << \"Unknown SAT solver type\";\n }\n+ d_satSolver = std::unique_ptr<prop::SatSolver>(solver);\n }\n \n-AigBitblaster::~AigBitblaster() {\n- Assert (abcAigNetwork == NULL);","path":"src/theory/bv/bitblast/aig_bitblaster.cpp","position":133,"original_position":133,"commit_id":"5468f415af4d110a2c073a3b2277fef907c0cd73","original_commit_id":"5468f415af4d110a2c073a3b2277fef907c0cd73","user":{"login":"4tXJ7f","id":1926228,"avatar_url":"https://avatars3.githubusercontent.com/u/1926228?v=4","gravatar_id":"","url":"https://api.github.com/users/4tXJ7f","html_url":"https://github.com/4tXJ7f","followers_url":"https://api.github.com/users/4tXJ7f/followers","following_url":"https://api.github.com/users/4tXJ7f/following{/other_user}","gists_url":"https://api.github.com/users/4tXJ7f/gists{/gist_id}","starred_url":"https://api.github.com/users/4tXJ7f/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4tXJ7f/subscriptions","organizations_url":"https://api.github.com/users/4tXJ7f/orgs","repos_url":"https://api.github.com/users/4tXJ7f/repos","events_url":"https://api.github.com/users/4tXJ7f/events{/privacy}","received_events_url":"https://api.github.com/users/4tXJ7f/received_events","type":"User","site_admin":false},"body":"Why has this line been removed?","created_at":"2018-03-25T07:13:15Z","updated_at":"2018-03-25T07:24:50Z","html_url":"https://github.com/CVC4/CVC4/pull/1695#discussion_r176931155","pull_request_url":"https://api.github.com/repos/CVC4/CVC4/pulls/1695","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/CVC4/CVC4/pulls/comments/176931155"},"html":{"href":"https://github.com/CVC4/CVC4/pull/1695#discussion_r176931155"},"pull_request":{"href":"https://api.github.com/repos/CVC4/CVC4/pulls/1695"}}},"pull_request":{"url":"https://api.github.com/repos/CVC4/CVC4/pulls/1695","id":176910445,"html_url":"https://github.com/CVC4/CVC4/pull/1695","diff_url":"https://github.com/CVC4/CVC4/pull/1695.diff","patch_url":"https://github.com/CVC4/CVC4/pull/1695.patch","issue_url":"https://api.github.com/repos/CVC4/CVC4/issues/1695","number":1695,"state":"open","locked":false,"title":"Reorganize bitblaster code.","user":{"login":"mpreiner","id":4653598,"avatar_url":"https://avatars0.githubusercontent.com/u/4653598?v=4","gravatar_id":"","url":"https://api.github.com/users/mpreiner","html_url":"https://github.com/mpreiner","followers_url":"https://api.github.com/users/mpreiner/followers","following_url":"https://api.github.com/users/mpreiner/following{/other_user}","gists_url":"https://api.github.com/users/mpreiner/gists{/gist_id}","starred_url":"https://api.github.com/users/mpreiner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpreiner/subscriptions","organizations_url":"https://api.github.com/users/mpreiner/orgs","repos_url":"https://api.github.com/users/mpreiner/repos","events_url":"https://api.github.com/users/mpreiner/events{/privacy}","received_events_url":"https://api.github.com/users/mpreiner/received_events","type":"User","site_admin":false},"body":"This PR splits bitblaster_template.h into the separate header files {aig,eager,lazy}_bitblaster.h and bitblaster.h (the template class TBitblaster). All the bitblaster related code is moved into the sub-directory bitblast/.\r\n\r\nCode changes:\r\n - std::unique_ptr are used if applicable. This also fixes a resource leak in aig_bitblaster.cpp (d_satSolver).\r\n - static member AigBitblaster::abcAigNetwork is made thread_local and is renamed to s_abcAigNetwork\r\n\r\nReformats: \r\n - bitblaster.h\r\n - {aig,eager,lazy}_bitblaster.h (since moved to separate header file)\r\n\r\nReviewing:\r\n - Commit 1 moves code only (review not necessarily required)\r\n - Commit 2 and 3 make the code changes mentioned above (review required)\r\n - Commit 4 moves corresponding files into sub-directory bitblast/ (review required)\r\n - Commti 5 reformats bitblaster.h (no review required)\r\n","created_at":"2018-03-22T21:09:59Z","updated_at":"2018-03-25T07:24:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cecbbd76850c1757070ca6d02334977dfd014b6f","assignee":{"login":"4tXJ7f","id":1926228,"avatar_url":"https://avatars3.githubusercontent.com/u/1926228?v=4","gravatar_id":"","url":"https://api.github.com/users/4tXJ7f","html_url":"https://github.com/4tXJ7f","followers_url":"https://api.github.com/users/4tXJ7f/followers","following_url":"https://api.github.com/users/4tXJ7f/following{/other_user}","gists_url":"https://api.github.com/users/4tXJ7f/gists{/gist_id}","starred_url":"https://api.github.com/users/4tXJ7f/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4tXJ7f/subscriptions","organizations_url":"https://api.github.com/users/4tXJ7f/orgs","repos_url":"https://api.github.com/users/4tXJ7f/repos","events_url":"https://api.github.com/users/4tXJ7f/events{/privacy}","received_events_url":"https://api.github.com/users/4tXJ7f/received_events","type":"User","site_admin":false},"assignees":[{"login":"4tXJ7f","id":1926228,"avatar_url":"https://avatars3.githubusercontent.com/u/1926228?v=4","gravatar_id":"","url":"https://api.github.com/users/4tXJ7f","html_url":"https://github.com/4tXJ7f","followers_url":"https://api.github.com/users/4tXJ7f/followers","following_url":"https://api.github.com/users/4tXJ7f/following{/other_user}","gists_url":"https://api.github.com/users/4tXJ7f/gists{/gist_id}","starred_url":"https://api.github.com/users/4tXJ7f/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4tXJ7f/subscriptions","organizations_url":"https://api.github.com/users/4tXJ7f/orgs","repos_url":"https://api.github.com/users/4tXJ7f/repos","events_url":"https://api.github.com/users/4tXJ7f/events{/privacy}","received_events_url":"https://api.github.com/users/4tXJ7f/received_events","type":"User","site_admin":false},{"login":"aniemetz","id":29313325,"avatar_url":"https://avatars3.githubusercontent.com/u/29313325?v=4","gravatar_id":"","url":"https://api.github.com/users/aniemetz","html_url":"https://github.com/aniemetz","followers_url":"https://api.github.com/users/aniemetz/followers","following_url":"https://api.github.com/users/aniemetz/following{/other_user}","gists_url":"https://api.github.com/users/aniemetz/gists{/gist_id}","starred_url":"https://api.github.com/users/aniemetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aniemetz/subscriptions","organizations_url":"https://api.github.com/users/aniemetz/orgs","repos_url":"https://api.github.com/users/aniemetz/repos","events_url":"https://api.github.com/users/aniemetz/events{/privacy}","received_events_url":"https://api.github.com/users/aniemetz/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"aniemetz","id":29313325,"avatar_url":"https://avatars3.githubusercontent.com/u/29313325?v=4","gravatar_id":"","url":"https://api.github.com/users/aniemetz","html_url":"https://github.com/aniemetz","followers_url":"https://api.github.com/users/aniemetz/followers","following_url":"https://api.github.com/users/aniemetz/following{/other_user}","gists_url":"https://api.github.com/users/aniemetz/gists{/gist_id}","starred_url":"https://api.github.com/users/aniemetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aniemetz/subscriptions","organizations_url":"https://api.github.com/users/aniemetz/orgs","repos_url":"https://api.github.com/users/aniemetz/repos","events_url":"https://api.github.com/users/aniemetz/events{/privacy}","received_events_url":"https://api.github.com/users/aniemetz/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":717338434,"url":"https://api.github.com/repos/CVC4/CVC4/labels/moderate","name":"moderate","color":"88ccf5","default":false},{"id":671891100,"url":"https://api.github.com/repos/CVC4/CVC4/labels/normal","name":"normal","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/CVC4/CVC4/pulls/1695/commits","review_comments_url":"https://api.github.com/repos/CVC4/CVC4/pulls/1695/comments","review_comment_url":"https://api.github.com/repos/CVC4/CVC4/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CVC4/CVC4/issues/1695/comments","statuses_url":"https://api.github.com/repos/CVC4/CVC4/statuses/5468f415af4d110a2c073a3b2277fef907c0cd73","head":{"label":"mpreiner:reorganize-bitblaster","ref":"reorganize-bitblaster","sha":"5468f415af4d110a2c073a3b2277fef907c0cd73","user":{"login":"mpreiner","id":4653598,"avatar_url":"https://avatars0.githubusercontent.com/u/4653598?v=4","gravatar_id":"","url":"https://api.github.com/users/mpreiner","html_url":"https://github.com/mpreiner","followers_url":"https://api.github.com/users/mpreiner/followers","following_url":"https://api.github.com/users/mpreiner/following{/other_user}","gists_url":"https://api.github.com/users/mpreiner/gists{/gist_id}","starred_url":"https://api.github.com/users/mpreiner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpreiner/subscriptions","organizations_url":"https://api.github.com/users/mpreiner/orgs","repos_url":"https://api.github.com/users/mpreiner/repos","events_url":"https://api.github.com/users/mpreiner/events{/privacy}","received_events_url":"https://api.github.com/users/mpreiner/received_events","type":"User","site_admin":false},"repo":{"id":95035994,"name":"CVC4","full_name":"mpreiner/CVC4","owner":{"login":"mpreiner","id":4653598,"avatar_url":"https://avatars0.githubusercontent.com/u/4653598?v=4","gravatar_id":"","url":"https://api.github.com/users/mpreiner","html_url":"https://github.com/mpreiner","followers_url":"https://api.github.com/users/mpreiner/followers","following_url":"https://api.github.com/users/mpreiner/following{/other_user}","gists_url":"https://api.github.com/users/mpreiner/gists{/gist_id}","starred_url":"https://api.github.com/users/mpreiner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpreiner/subscriptions","organizations_url":"https://api.github.com/users/mpreiner/orgs","repos_url":"https://api.github.com/users/mpreiner/repos","events_url":"https://api.github.com/users/mpreiner/events{/privacy}","received_events_url":"https://api.github.com/users/mpreiner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mpreiner/CVC4","description":"CVC4 is an efficient open-source automatic theorem prover for satisfiability modulo theories (SMT) problems.","fork":true,"url":"https://api.github.com/repos/mpreiner/CVC4","forks_url":"https://api.github.com/repos/mpreiner/CVC4/forks","keys_url":"https://api.github.com/repos/mpreiner/CVC4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mpreiner/CVC4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mpreiner/CVC4/teams","hooks_url":"https://api.github.com/repos/mpreiner/CVC4/hooks","issue_events_url":"https://api.github.com/repos/mpreiner/CVC4/issues/events{/number}","events_url":"https://api.github.com/repos/mpreiner/CVC4/events","assignees_url":"https://api.github.com/repos/mpreiner/CVC4/assignees{/user}","branches_url":"https://api.github.com/repos/mpreiner/CVC4/branches{/branch}","tags_url":"https://api.github.com/repos/mpreiner/CVC4/tags","blobs_url":"https://api.github.com/repos/mpreiner/CVC4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mpreiner/CVC4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mpreiner/CVC4/git/refs{/sha}","trees_url":"https://api.github.com/repos/mpreiner/CVC4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mpreiner/CVC4/statuses/{sha}","languages_url":"https://api.github.com/repos/mpreiner/CVC4/languages","stargazers_url":"https://api.github.com/repos/mpreiner/CVC4/stargazers","contributors_url":"https://api.github.com/repos/mpreiner/CVC4/contributors","subscribers_url":"https://api.github.com/repos/mpreiner/CVC4/subscribers","subscription_url":"https://api.github.com/repos/mpreiner/CVC4/subscription","commits_url":"https://api.github.com/repos/mpreiner/CVC4/commits{/sha}","git_commits_url":"https://api.github.com/repos/mpreiner/CVC4/git/commits{/sha}","comments_url":"https://api.github.com/repos/mpreiner/CVC4/comments{/number}","issue_comment_url":"https://api.github.com/repos/mpreiner/CVC4/issues/comments{/number}","contents_url":"https://api.github.com/repos/mpreiner/CVC4/contents/{+path}","compare_url":"https://api.github.com/repos/mpreiner/CVC4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mpreiner/CVC4/merges","archive_url":"https://api.github.com/repos/mpreiner/CVC4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mpreiner/CVC4/downloads","issues_url":"https://api.github.com/repos/mpreiner/CVC4/issues{/number}","pulls_url":"https://api.github.com/repos/mpreiner/CVC4/pulls{/number}","milestones_url":"https://api.github.com/repos/mpreiner/CVC4/milestones{/number}","notifications_url":"https://api.github.com/repos/mpreiner/CVC4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mpreiner/CVC4/labels{/name}","releases_url":"https://api.github.com/repos/mpreiner/CVC4/releases{/id}","deployments_url":"https://api.github.com/repos/mpreiner/CVC4/deployments","created_at":"2017-06-21T18:51:05Z","updated_at":"2017-06-21T18:51:12Z","pushed_at":"2018-03-25T04:54:35Z","git_url":"git://github.com/mpreiner/CVC4.git","ssh_url":"[email protected]:mpreiner/CVC4.git","clone_url":"https://github.com/mpreiner/CVC4.git","svn_url":"https://github.com/mpreiner/CVC4","homepage":null,"size":42953,"stargazers_count":0,"watchers_count":0,"language":"SMT","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CVC4:master","ref":"master","sha":"d3528b6db31f9bdff56bc519bbf427b2533c43b8","user":{"login":"CVC4","id":2973223,"avatar_url":"https://avatars0.githubusercontent.com/u/2973223?v=4","gravatar_id":"","url":"https://api.github.com/users/CVC4","html_url":"https://github.com/CVC4","followers_url":"https://api.github.com/users/CVC4/followers","following_url":"https://api.github.com/users/CVC4/following{/other_user}","gists_url":"https://api.github.com/users/CVC4/gists{/gist_id}","starred_url":"https://api.github.com/users/CVC4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CVC4/subscriptions","organizations_url":"https://api.github.com/users/CVC4/orgs","repos_url":"https://api.github.com/users/CVC4/repos","events_url":"https://api.github.com/users/CVC4/events{/privacy}","received_events_url":"https://api.github.com/users/CVC4/received_events","type":"Organization","site_admin":false},"repo":{"id":7040894,"name":"CVC4","full_name":"CVC4/CVC4","owner":{"login":"CVC4","id":2973223,"avatar_url":"https://avatars0.githubusercontent.com/u/2973223?v=4","gravatar_id":"","url":"https://api.github.com/users/CVC4","html_url":"https://github.com/CVC4","followers_url":"https://api.github.com/users/CVC4/followers","following_url":"https://api.github.com/users/CVC4/following{/other_user}","gists_url":"https://api.github.com/users/CVC4/gists{/gist_id}","starred_url":"https://api.github.com/users/CVC4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CVC4/subscriptions","organizations_url":"https://api.github.com/users/CVC4/orgs","repos_url":"https://api.github.com/users/CVC4/repos","events_url":"https://api.github.com/users/CVC4/events{/privacy}","received_events_url":"https://api.github.com/users/CVC4/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CVC4/CVC4","description":"CVC4 is an efficient open-source automatic theorem prover for satisfiability modulo theories (SMT) problems.","fork":false,"url":"https://api.github.com/repos/CVC4/CVC4","forks_url":"https://api.github.com/repos/CVC4/CVC4/forks","keys_url":"https://api.github.com/repos/CVC4/CVC4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CVC4/CVC4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CVC4/CVC4/teams","hooks_url":"https://api.github.com/repos/CVC4/CVC4/hooks","issue_events_url":"https://api.github.com/repos/CVC4/CVC4/issues/events{/number}","events_url":"https://api.github.com/repos/CVC4/CVC4/events","assignees_url":"https://api.github.com/repos/CVC4/CVC4/assignees{/user}","branches_url":"https://api.github.com/repos/CVC4/CVC4/branches{/branch}","tags_url":"https://api.github.com/repos/CVC4/CVC4/tags","blobs_url":"https://api.github.com/repos/CVC4/CVC4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CVC4/CVC4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CVC4/CVC4/git/refs{/sha}","trees_url":"https://api.github.com/repos/CVC4/CVC4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CVC4/CVC4/statuses/{sha}","languages_url":"https://api.github.com/repos/CVC4/CVC4/languages","stargazers_url":"https://api.github.com/repos/CVC4/CVC4/stargazers","contributors_url":"https://api.github.com/repos/CVC4/CVC4/contributors","subscribers_url":"https://api.github.com/repos/CVC4/CVC4/subscribers","subscription_url":"https://api.github.com/repos/CVC4/CVC4/subscription","commits_url":"https://api.github.com/repos/CVC4/CVC4/commits{/sha}","git_commits_url":"https://api.github.com/repos/CVC4/CVC4/git/commits{/sha}","comments_url":"https://api.github.com/repos/CVC4/CVC4/comments{/number}","issue_comment_url":"https://api.github.com/repos/CVC4/CVC4/issues/comments{/number}","contents_url":"https://api.github.com/repos/CVC4/CVC4/contents/{+path}","compare_url":"https://api.github.com/repos/CVC4/CVC4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CVC4/CVC4/merges","archive_url":"https://api.github.com/repos/CVC4/CVC4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CVC4/CVC4/downloads","issues_url":"https://api.github.com/repos/CVC4/CVC4/issues{/number}","pulls_url":"https://api.github.com/repos/CVC4/CVC4/pulls{/number}","milestones_url":"https://api.github.com/repos/CVC4/CVC4/milestones{/number}","notifications_url":"https://api.github.com/repos/CVC4/CVC4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CVC4/CVC4/labels{/name}","releases_url":"https://api.github.com/repos/CVC4/CVC4/releases{/id}","deployments_url":"https://api.github.com/repos/CVC4/CVC4/deployments","created_at":"2012-12-06T18:45:04Z","updated_at":"2018-03-25T06:38:40Z","pushed_at":"2018-03-25T06:48:49Z","git_url":"git://github.com/CVC4/CVC4.git","ssh_url":"[email protected]:CVC4/CVC4.git","clone_url":"https://github.com/CVC4/CVC4.git","svn_url":"https://github.com/CVC4/CVC4","homepage":null,"size":42857,"stargazers_count":188,"watchers_count":188,"language":"SMT","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":79,"mirror_url":null,"archived":false,"open_issues_count":203,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":79,"open_issues":203,"watchers":188,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CVC4/CVC4/pulls/1695"},"html":{"href":"https://github.com/CVC4/CVC4/pull/1695"},"issue":{"href":"https://api.github.com/repos/CVC4/CVC4/issues/1695"},"comments":{"href":"https://api.github.com/repos/CVC4/CVC4/issues/1695/comments"},"review_comments":{"href":"https://api.github.com/repos/CVC4/CVC4/pulls/1695/comments"},"review_comment":{"href":"https://api.github.com/repos/CVC4/CVC4/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CVC4/CVC4/pulls/1695/commits"},"statuses":{"href":"https://api.github.com/repos/CVC4/CVC4/statuses/5468f415af4d110a2c073a3b2277fef907c0cd73"}},"author_association":"OWNER"}} | {
"id": 7040894,
"name": "CVC4/CVC4",
"url": "https://api.github.com/repos/CVC4/CVC4"
} | {
"id": 1926228,
"login": "4tXJ7f",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1926228?",
"url": "https://api.github.com/users/4tXJ7f"
} | {
"id": 2973223,
"login": "CVC4",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2973223?",
"url": "https://api.github.com/orgs/CVC4"
} | 2018-03-25T07:13:15 | 7430806329 | {"actor":{"display_login":"4tXJ7f"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/STJr/SRB2/pulls/comments/241953978","pull_request_review_id":185359607,"id":241953978,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTk1Mzk3OA==","diff_hunk":"@@ -473,23 +472,32 @@ static void R_RenderFloorSplat(floorsplat_t *pSplat, vertex_t *verts, UINT8 *pTe\n \t\tif (x2 >= vid.width)\n \t\t\tx2 = vid.width - 1;\n \n+\t\tangle = (currentplane->viewangle + currentplane->plangle)>>ANGLETOFINESHIFT;\n+\t\tplanecos = FINECOSINE(angle);\n+\t\tplanesin = FINESINE(angle);\n+\n \t\tif (planeheight != cachedheight[y])\n \t\t{\n \t\t\tcachedheight[y] = planeheight;\n \t\t\tdistance = cacheddistance[y] = FixedMul(planeheight, yslope[y]);\n \t\t\tds_xstep = cachedxstep[y] = FixedMul(distance,basexscale);\n \t\t\tds_ystep = cachedystep[y] = FixedMul(distance,baseyscale);\n+\n+\t\t\tif ((span = abs(centery-y)))\n+\t\t\t{\n+\t\t\t\tds_xstep = cachedxstep[y] = FixedMul(planesin, planeheight) / span;\n+\t\t\t\tds_ystep = cachedystep[y] = FixedMul(planecos, planeheight) / span;","path":"src/r_splats.c","position":30,"original_position":30,"commit_id":"9c04a066d96ab24530c383a0d43a84aaa4741986","original_commit_id":"9c04a066d96ab24530c383a0d43a84aaa4741986","user":{"login":"MonsterIestyn","id":2997824,"node_id":"MDQ6VXNlcjI5OTc4MjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2997824?v=4","gravatar_id":"","url":"https://api.github.com/users/MonsterIestyn","html_url":"https://github.com/MonsterIestyn","followers_url":"https://api.github.com/users/MonsterIestyn/followers","following_url":"https://api.github.com/users/MonsterIestyn/following{/other_user}","gists_url":"https://api.github.com/users/MonsterIestyn/gists{/gist_id}","starred_url":"https://api.github.com/users/MonsterIestyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MonsterIestyn/subscriptions","organizations_url":"https://api.github.com/users/MonsterIestyn/orgs","repos_url":"https://api.github.com/users/MonsterIestyn/repos","events_url":"https://api.github.com/users/MonsterIestyn/events{/privacy}","received_events_url":"https://api.github.com/users/MonsterIestyn/received_events","type":"User","site_admin":false},"body":"Ah okay, was just confused because it's usually cos for x, sin for y","created_at":"2018-12-15T16:21:01Z","updated_at":"2018-12-15T16:21:01Z","html_url":"https://github.com/STJr/SRB2/pull/373#discussion_r241953978","pull_request_url":"https://api.github.com/repos/STJr/SRB2/pulls/373","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/STJr/SRB2/pulls/comments/241953978"},"html":{"href":"https://github.com/STJr/SRB2/pull/373#discussion_r241953978"},"pull_request":{"href":"https://api.github.com/repos/STJr/SRB2/pulls/373"}},"in_reply_to_id":241869102},"pull_request":{"url":"https://api.github.com/repos/STJr/SRB2/pulls/373","id":238790373,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NzkwMzcz","html_url":"https://github.com/STJr/SRB2/pull/373","diff_url":"https://github.com/STJr/SRB2/pull/373.diff","patch_url":"https://github.com/STJr/SRB2/pull/373.patch","issue_url":"https://api.github.com/repos/STJr/SRB2/issues/373","number":373,"state":"open","locked":false,"title":"Software plane fixes","user":{"login":"monster-psychic-cat","id":16945067,"node_id":"MDQ6VXNlcjE2OTQ1MDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16945067?v=4","gravatar_id":"","url":"https://api.github.com/users/monster-psychic-cat","html_url":"https://github.com/monster-psychic-cat","followers_url":"https://api.github.com/users/monster-psychic-cat/followers","following_url":"https://api.github.com/users/monster-psychic-cat/following{/other_user}","gists_url":"https://api.github.com/users/monster-psychic-cat/gists{/gist_id}","starred_url":"https://api.github.com/users/monster-psychic-cat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monster-psychic-cat/subscriptions","organizations_url":"https://api.github.com/users/monster-psychic-cat/orgs","repos_url":"https://api.github.com/users/monster-psychic-cat/repos","events_url":"https://api.github.com/users/monster-psychic-cat/events{/privacy}","received_events_url":"https://api.github.com/users/monster-psychic-cat/received_events","type":"User","site_admin":false},"body":"This commit fixes:\r\n\r\n* [This](https://github.com/STJr/SRB2/pull/291) fix\r\n\r\n\r\n\r\n* Floor wobble on large resolutions such as 1920x1200.\r\n\r\n\r\n\r\n* Polyobjects causing slime trails on FOFs around them, sometimes\r\n\r\n\r\n\r\n* Polyobjects rendering the flat of the sector they are on twice, as if it were a shadow\r\n\r\n","created_at":"2018-12-14T17:25:18Z","updated_at":"2018-12-15T16:21:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97393a095037e12a420110f92d5c7368de1310af","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/STJr/SRB2/pulls/373/commits","review_comments_url":"https://api.github.com/repos/STJr/SRB2/pulls/373/comments","review_comment_url":"https://api.github.com/repos/STJr/SRB2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/STJr/SRB2/issues/373/comments","statuses_url":"https://api.github.com/repos/STJr/SRB2/statuses/9c04a066d96ab24530c383a0d43a84aaa4741986","head":{"label":"monster-psychic-cat:sw_planefixes","ref":"sw_planefixes","sha":"9c04a066d96ab24530c383a0d43a84aaa4741986","user":{"login":"monster-psychic-cat","id":16945067,"node_id":"MDQ6VXNlcjE2OTQ1MDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16945067?v=4","gravatar_id":"","url":"https://api.github.com/users/monster-psychic-cat","html_url":"https://github.com/monster-psychic-cat","followers_url":"https://api.github.com/users/monster-psychic-cat/followers","following_url":"https://api.github.com/users/monster-psychic-cat/following{/other_user}","gists_url":"https://api.github.com/users/monster-psychic-cat/gists{/gist_id}","starred_url":"https://api.github.com/users/monster-psychic-cat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monster-psychic-cat/subscriptions","organizations_url":"https://api.github.com/users/monster-psychic-cat/orgs","repos_url":"https://api.github.com/users/monster-psychic-cat/repos","events_url":"https://api.github.com/users/monster-psychic-cat/events{/privacy}","received_events_url":"https://api.github.com/users/monster-psychic-cat/received_events","type":"User","site_admin":false},"repo":{"id":143322713,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMzMjI3MTM=","name":"SRB2","full_name":"monster-psychic-cat/SRB2","private":false,"owner":{"login":"monster-psychic-cat","id":16945067,"node_id":"MDQ6VXNlcjE2OTQ1MDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16945067?v=4","gravatar_id":"","url":"https://api.github.com/users/monster-psychic-cat","html_url":"https://github.com/monster-psychic-cat","followers_url":"https://api.github.com/users/monster-psychic-cat/followers","following_url":"https://api.github.com/users/monster-psychic-cat/following{/other_user}","gists_url":"https://api.github.com/users/monster-psychic-cat/gists{/gist_id}","starred_url":"https://api.github.com/users/monster-psychic-cat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monster-psychic-cat/subscriptions","organizations_url":"https://api.github.com/users/monster-psychic-cat/orgs","repos_url":"https://api.github.com/users/monster-psychic-cat/repos","events_url":"https://api.github.com/users/monster-psychic-cat/events{/privacy}","received_events_url":"https://api.github.com/users/monster-psychic-cat/received_events","type":"User","site_admin":false},"html_url":"https://github.com/monster-psychic-cat/SRB2","description":"SRB2 2.1 Public","fork":true,"url":"https://api.github.com/repos/monster-psychic-cat/SRB2","forks_url":"https://api.github.com/repos/monster-psychic-cat/SRB2/forks","keys_url":"https://api.github.com/repos/monster-psychic-cat/SRB2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/monster-psychic-cat/SRB2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/monster-psychic-cat/SRB2/teams","hooks_url":"https://api.github.com/repos/monster-psychic-cat/SRB2/hooks","issue_events_url":"https://api.github.com/repos/monster-psychic-cat/SRB2/issues/events{/number}","events_url":"https://api.github.com/repos/monster-psychic-cat/SRB2/events","assignees_url":"https://api.github.com/repos/monster-psychic-cat/SRB2/assignees{/user}","branches_url":"https://api.github.com/repos/monster-psychic-cat/SRB2/branches{/branch}","tags_url":"https://api.github.com/repos/monster-psychic-cat/SRB2/tags","blobs_url":"https://api.github.com/repos/monster-psychic-cat/SRB2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/monster-psychic-cat/SRB2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/monster-psychic-cat/SRB2/git/refs{/sha}","trees_url":"https://api.github.com/repos/monster-psychic-cat/SRB2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/monster-psychic-cat/SRB2/statuses/{sha}","languages_url":"https://api.github.com/repos/monster-psychic-cat/SRB2/languages","stargazers_url":"https://api.github.com/repos/monster-psychic-cat/SRB2/stargazers","contributors_url":"https://api.github.com/repos/monster-psychic-cat/SRB2/contributors","subscribers_url":"https://api.github.com/repos/monster-psychic-cat/SRB2/subscribers","subscription_url":"https://api.github.com/repos/monster-psychic-cat/SRB2/subscription","commits_url":"https://api.github.com/repos/monster-psychic-cat/SRB2/commits{/sha}","git_commits_url":"https://api.github.com/repos/monster-psychic-cat/SRB2/git/commits{/sha}","comments_url":"https://api.github.com/repos/monster-psychic-cat/SRB2/comments{/number}","issue_comment_url":"https://api.github.com/repos/monster-psychic-cat/SRB2/issues/comments{/number}","contents_url":"https://api.github.com/repos/monster-psychic-cat/SRB2/contents/{+path}","compare_url":"https://api.github.com/repos/monster-psychic-cat/SRB2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/monster-psychic-cat/SRB2/merges","archive_url":"https://api.github.com/repos/monster-psychic-cat/SRB2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/monster-psychic-cat/SRB2/downloads","issues_url":"https://api.github.com/repos/monster-psychic-cat/SRB2/issues{/number}","pulls_url":"https://api.github.com/repos/monster-psychic-cat/SRB2/pulls{/number}","milestones_url":"https://api.github.com/repos/monster-psychic-cat/SRB2/milestones{/number}","notifications_url":"https://api.github.com/repos/monster-psychic-cat/SRB2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/monster-psychic-cat/SRB2/labels{/name}","releases_url":"https://api.github.com/repos/monster-psychic-cat/SRB2/releases{/id}","deployments_url":"https://api.github.com/repos/monster-psychic-cat/SRB2/deployments","created_at":"2018-08-02T16:59:19Z","updated_at":"2018-12-09T22:39:13Z","pushed_at":"2018-12-14T18:49:46Z","git_url":"git://github.com/monster-psychic-cat/SRB2.git","ssh_url":"[email protected]:monster-psychic-cat/SRB2.git","clone_url":"https://github.com/monster-psychic-cat/SRB2.git","svn_url":"https://github.com/monster-psychic-cat/SRB2","homepage":null,"size":60796,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"STJr:master","ref":"master","sha":"880c017f8fe25dc2dac2c42e249f9847064ae668","user":{"login":"STJr","id":2997763,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5OTc3NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/2997763?v=4","gravatar_id":"","url":"https://api.github.com/users/STJr","html_url":"https://github.com/STJr","followers_url":"https://api.github.com/users/STJr/followers","following_url":"https://api.github.com/users/STJr/following{/other_user}","gists_url":"https://api.github.com/users/STJr/gists{/gist_id}","starred_url":"https://api.github.com/users/STJr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/STJr/subscriptions","organizations_url":"https://api.github.com/users/STJr/orgs","repos_url":"https://api.github.com/users/STJr/repos","events_url":"https://api.github.com/users/STJr/events{/privacy}","received_events_url":"https://api.github.com/users/STJr/received_events","type":"Organization","site_admin":false},"repo":{"id":17780491,"node_id":"MDEwOlJlcG9zaXRvcnkxNzc4MDQ5MQ==","name":"SRB2","full_name":"STJr/SRB2","private":false,"owner":{"login":"STJr","id":2997763,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5OTc3NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/2997763?v=4","gravatar_id":"","url":"https://api.github.com/users/STJr","html_url":"https://github.com/STJr","followers_url":"https://api.github.com/users/STJr/followers","following_url":"https://api.github.com/users/STJr/following{/other_user}","gists_url":"https://api.github.com/users/STJr/gists{/gist_id}","starred_url":"https://api.github.com/users/STJr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/STJr/subscriptions","organizations_url":"https://api.github.com/users/STJr/orgs","repos_url":"https://api.github.com/users/STJr/repos","events_url":"https://api.github.com/users/STJr/events{/privacy}","received_events_url":"https://api.github.com/users/STJr/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/STJr/SRB2","description":"SRB2 2.1 Public","fork":false,"url":"https://api.github.com/repos/STJr/SRB2","forks_url":"https://api.github.com/repos/STJr/SRB2/forks","keys_url":"https://api.github.com/repos/STJr/SRB2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/STJr/SRB2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/STJr/SRB2/teams","hooks_url":"https://api.github.com/repos/STJr/SRB2/hooks","issue_events_url":"https://api.github.com/repos/STJr/SRB2/issues/events{/number}","events_url":"https://api.github.com/repos/STJr/SRB2/events","assignees_url":"https://api.github.com/repos/STJr/SRB2/assignees{/user}","branches_url":"https://api.github.com/repos/STJr/SRB2/branches{/branch}","tags_url":"https://api.github.com/repos/STJr/SRB2/tags","blobs_url":"https://api.github.com/repos/STJr/SRB2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/STJr/SRB2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/STJr/SRB2/git/refs{/sha}","trees_url":"https://api.github.com/repos/STJr/SRB2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/STJr/SRB2/statuses/{sha}","languages_url":"https://api.github.com/repos/STJr/SRB2/languages","stargazers_url":"https://api.github.com/repos/STJr/SRB2/stargazers","contributors_url":"https://api.github.com/repos/STJr/SRB2/contributors","subscribers_url":"https://api.github.com/repos/STJr/SRB2/subscribers","subscription_url":"https://api.github.com/repos/STJr/SRB2/subscription","commits_url":"https://api.github.com/repos/STJr/SRB2/commits{/sha}","git_commits_url":"https://api.github.com/repos/STJr/SRB2/git/commits{/sha}","comments_url":"https://api.github.com/repos/STJr/SRB2/comments{/number}","issue_comment_url":"https://api.github.com/repos/STJr/SRB2/issues/comments{/number}","contents_url":"https://api.github.com/repos/STJr/SRB2/contents/{+path}","compare_url":"https://api.github.com/repos/STJr/SRB2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/STJr/SRB2/merges","archive_url":"https://api.github.com/repos/STJr/SRB2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/STJr/SRB2/downloads","issues_url":"https://api.github.com/repos/STJr/SRB2/issues{/number}","pulls_url":"https://api.github.com/repos/STJr/SRB2/pulls{/number}","milestones_url":"https://api.github.com/repos/STJr/SRB2/milestones{/number}","notifications_url":"https://api.github.com/repos/STJr/SRB2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/STJr/SRB2/labels{/name}","releases_url":"https://api.github.com/repos/STJr/SRB2/releases{/id}","deployments_url":"https://api.github.com/repos/STJr/SRB2/deployments","created_at":"2014-03-15T17:01:34Z","updated_at":"2018-12-13T21:21:03Z","pushed_at":"2018-12-15T02:32:32Z","git_url":"git://github.com/STJr/SRB2.git","ssh_url":"[email protected]:STJr/SRB2.git","clone_url":"https://github.com/STJr/SRB2.git","svn_url":"https://github.com/STJr/SRB2","homepage":null,"size":68844,"stargazers_count":104,"watchers_count":104,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":45,"open_issues":13,"watchers":104,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/STJr/SRB2/pulls/373"},"html":{"href":"https://github.com/STJr/SRB2/pull/373"},"issue":{"href":"https://api.github.com/repos/STJr/SRB2/issues/373"},"comments":{"href":"https://api.github.com/repos/STJr/SRB2/issues/373/comments"},"review_comments":{"href":"https://api.github.com/repos/STJr/SRB2/pulls/373/comments"},"review_comment":{"href":"https://api.github.com/repos/STJr/SRB2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/STJr/SRB2/pulls/373/commits"},"statuses":{"href":"https://api.github.com/repos/STJr/SRB2/statuses/9c04a066d96ab24530c383a0d43a84aaa4741986"}},"author_association":"CONTRIBUTOR"}} | {
"id": 17780491,
"name": "STJr/SRB2",
"url": "https://api.github.com/repos/STJr/SRB2"
} | {
"id": 2997824,
"login": "MonsterIestyn",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2997824?",
"url": "https://api.github.com/users/MonsterIestyn"
} | {
"id": 2997763,
"login": "STJr",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2997763?",
"url": "https://api.github.com/orgs/STJr"
} | 2018-12-15T16:21:01 | 8759450452 | {"actor":{"display_login":"MonsterIestyn"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/pantsbuild/pants/pulls/comments/169491729","pull_request_review_id":98026491,"id":169491729,"diff_hunk":"@@ -0,0 +1,64 @@\n+# coding=utf-8\n+# Copyright 2018 Pants project contributors (see CONTRIBUTORS.md).\n+# Licensed under the Apache License, Version 2.0 (see LICENSE).\n+\n+from __future__ import (absolute_import, division, generators, nested_scopes, print_function,\n+ unicode_literals, with_statement)\n+\n+import os\n+\n+from pex.interpreter import PythonInterpreter\n+\n+from pants.util.memo import memoized_method\n+\n+\n+class SandboxedInterpreter(PythonInterpreter):\n+\n+ class ToolchainLocationError(Exception):\n+ def __init__(self, dir_path):\n+ msg = \"path '{}' does not exist or is not a directory\".format(dir_path)\n+ super(ToolchainLocationError, self).__init__(msg)\n+\n+ class BaseInterpreterError(Exception): pass\n+\n+ # using another PythonInterpreter to populate the superclass constructor args\n+ def __init__(self, llvm_base_dir, base_interp):\n+\n+ if not os.path.isdir(llvm_base_dir):\n+ raise ToolchainLocationError(llvm_base_dir)\n+ if not isinstance(base_interp, PythonInterpreter):\n+ raise BaseInterpreterError(\n+ \"invalid PythonInterpreter: '{}'\".format(repr(base_interp)))\n+\n+ self._llvm_base_dir = llvm_base_dir\n+\n+ # this feels a little hacky -- what if pex's PythonInterpreter later needs\n+ # another constructor arg that's not just a property of the class?\n+ super(SandboxedInterpreter, self).__init__(\n+ base_interp.binary, base_interp.identity, extras=base_interp.extras)\n+\n+ # made into an instance method here (unlike PythonInterpreter superclass) to\n+ # use instance property self._llvm_base_dir\n+ @memoized_method\n+ def sanitized_environment(self):\n+ sanitized_env = super(SandboxedInterpreter, self).sanitized_environment()\n+\n+ # use our compiler at the front of the path\n+ # TODO: when we provide ld and stdlib headers, don't add the original path\n+ sanitized_env['PATH'] = ':'.join([\n+ os.path.join(self._llvm_base_dir, 'bin'),\n+ os.environ.get('PATH'),\n+ ])\n+\n+ # TODO: figure out whether we actually should be compiling fat binaries.\n+ # this line tells distutils to only compile for 64-bit archs -- if not, it\n+ # will attempt to build a fat binary for 32- and 64-bit archs, which makes\n+ # clang invoke \"lipo\", an osx command which does not appear to be open\n+ # source. see Lib/distutils/sysconfig.py and Lib/_osx_support.py in CPython.\n+ sanitized_env['ARCHFLAGS'] = '-arch x86_64'","path":"src/python/pants/backend/python/sandboxed_interpreter.py","position":58,"original_position":58,"commit_id":"41a1a9a281f50ca30c0f6230d8e9dca3a3dbad9d","original_commit_id":"41a1a9a281f50ca30c0f6230d8e9dca3a3dbad9d","user":{"login":"cosmicexplorer","id":1305167,"avatar_url":"https://avatars1.githubusercontent.com/u/1305167?v=4","gravatar_id":"","url":"https://api.github.com/users/cosmicexplorer","html_url":"https://github.com/cosmicexplorer","followers_url":"https://api.github.com/users/cosmicexplorer/followers","following_url":"https://api.github.com/users/cosmicexplorer/following{/other_user}","gists_url":"https://api.github.com/users/cosmicexplorer/gists{/gist_id}","starred_url":"https://api.github.com/users/cosmicexplorer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosmicexplorer/subscriptions","organizations_url":"https://api.github.com/users/cosmicexplorer/orgs","repos_url":"https://api.github.com/users/cosmicexplorer/repos","events_url":"https://api.github.com/users/cosmicexplorer/events{/privacy}","received_events_url":"https://api.github.com/users/cosmicexplorer/received_events","type":"User","site_admin":false},"body":"I actually had the contents of `sandboxed_interpreter.py` as a private contextmanager method of `BuildLocalPythonDistributions` and I think I thought that decoupling the \"sandbox\" environment from the task that directly consumes it was a useful goal, but it's not clear to me how useful that is now. It's easy enough to move back and thinking about it again, I don't know if I really like the idea of overriding an `@classmethod` with an instance method at all (which is what's happening with `sanitized_environment()`). I think it's probably better to put it back in the `BuildLocalPythonDistributions` task.","created_at":"2018-02-20T23:15:21Z","updated_at":"2018-02-20T23:15:21Z","html_url":"https://github.com/pantsbuild/pants/pull/5490#discussion_r169491729","pull_request_url":"https://api.github.com/repos/pantsbuild/pants/pulls/5490","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/comments/169491729"},"html":{"href":"https://github.com/pantsbuild/pants/pull/5490#discussion_r169491729"},"pull_request":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/5490"}},"in_reply_to_id":169487698},"pull_request":{"url":"https://api.github.com/repos/pantsbuild/pants/pulls/5490","id":170329276,"html_url":"https://github.com/pantsbuild/pants/pull/5490","diff_url":"https://github.com/pantsbuild/pants/pull/5490.diff","patch_url":"https://github.com/pantsbuild/pants/pull/5490.patch","issue_url":"https://api.github.com/repos/pantsbuild/pants/issues/5490","number":5490,"state":"open","locked":false,"title":"use the LLVM subsystem to invoke a provided clang to compile native code in python_dist()","user":{"login":"cosmicexplorer","id":1305167,"avatar_url":"https://avatars1.githubusercontent.com/u/1305167?v=4","gravatar_id":"","url":"https://api.github.com/users/cosmicexplorer","html_url":"https://github.com/cosmicexplorer","followers_url":"https://api.github.com/users/cosmicexplorer/followers","following_url":"https://api.github.com/users/cosmicexplorer/following{/other_user}","gists_url":"https://api.github.com/users/cosmicexplorer/gists{/gist_id}","starred_url":"https://api.github.com/users/cosmicexplorer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosmicexplorer/subscriptions","organizations_url":"https://api.github.com/users/cosmicexplorer/orgs","repos_url":"https://api.github.com/users/cosmicexplorer/repos","events_url":"https://api.github.com/users/cosmicexplorer/events{/privacy}","received_events_url":"https://api.github.com/users/cosmicexplorer/received_events","type":"User","site_admin":false},"body":"### Problem\r\n\r\n`python_dist()` allows the use of native extension modules, but it currently uses whatever compiler, linker, libraries, *etc* that distutils can find first on the host to compile the native code. Providing these disparate elements of the native code compilation toolchain in Pants means users don't have to install it themselves, and Pants can ensure that the provided compiler supports whatever features we want to provide to developers of native extension modules with `python_dist()`.\r\n\r\n### Solution\r\n\r\nThis PR uses the LLVM subsystem defined in #5471 to compile native code in a setup.py-based project declared through a `python_dist()` target. The environment of the setup.py invocation was controlled by subclassing `pex.interpreter.PythonInterpreter` and overriding the `sanitized_environment()` method. This couples the compilation environment we create to the execution of the setup.py for a `python_dist()` target in (I think) a very natural way.\r\n\r\n### Result\r\n\r\nWhen a `python_dist()` target is built through the `BuildLocalPythonDistributions` task, it pulls in a bootstrapped LLVM toolchain **(currently just the clang compiler)** and prepends it to the `PATH` so that our provided compiler is preferred (in addition to scrubbing `CC` and `CXX`). True sandboxed execution is preferable, but for now this at least guarantees that the provided compiler is used, which satisfies the goals stated at the top.\r\n\r\nThe LLVM archive that Pants will attempt to unpack will be produced by a cross-platform script. The current version of this script that I am using for development is located [here](https://github.com/cosmicexplorer/binaries/blob/dmcclanahan/add-llvm-package-script/build-llvm-5.0.1.sh) -- it's very simple and works, but I don't know if that should be made available in S3 before this PR gets merged.","created_at":"2018-02-20T22:40:07Z","updated_at":"2018-02-20T23:15:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8ebcf54fd9fe12e7b7db747ae7b5020cb86b45c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kwlzn","id":1883523,"avatar_url":"https://avatars0.githubusercontent.com/u/1883523?v=4","gravatar_id":"","url":"https://api.github.com/users/kwlzn","html_url":"https://github.com/kwlzn","followers_url":"https://api.github.com/users/kwlzn/followers","following_url":"https://api.github.com/users/kwlzn/following{/other_user}","gists_url":"https://api.github.com/users/kwlzn/gists{/gist_id}","starred_url":"https://api.github.com/users/kwlzn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwlzn/subscriptions","organizations_url":"https://api.github.com/users/kwlzn/orgs","repos_url":"https://api.github.com/users/kwlzn/repos","events_url":"https://api.github.com/users/kwlzn/events{/privacy}","received_events_url":"https://api.github.com/users/kwlzn/received_events","type":"User","site_admin":false},{"login":"CMLivingston","id":12532471,"avatar_url":"https://avatars1.githubusercontent.com/u/12532471?v=4","gravatar_id":"","url":"https://api.github.com/users/CMLivingston","html_url":"https://github.com/CMLivingston","followers_url":"https://api.github.com/users/CMLivingston/followers","following_url":"https://api.github.com/users/CMLivingston/following{/other_user}","gists_url":"https://api.github.com/users/CMLivingston/gists{/gist_id}","starred_url":"https://api.github.com/users/CMLivingston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CMLivingston/subscriptions","organizations_url":"https://api.github.com/users/CMLivingston/orgs","repos_url":"https://api.github.com/users/CMLivingston/repos","events_url":"https://api.github.com/users/CMLivingston/events{/privacy}","received_events_url":"https://api.github.com/users/CMLivingston/received_events","type":"User","site_admin":false},{"login":"UnrememberMe","id":14335127,"avatar_url":"https://avatars0.githubusercontent.com/u/14335127?v=4","gravatar_id":"","url":"https://api.github.com/users/UnrememberMe","html_url":"https://github.com/UnrememberMe","followers_url":"https://api.github.com/users/UnrememberMe/followers","following_url":"https://api.github.com/users/UnrememberMe/following{/other_user}","gists_url":"https://api.github.com/users/UnrememberMe/gists{/gist_id}","starred_url":"https://api.github.com/users/UnrememberMe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UnrememberMe/subscriptions","organizations_url":"https://api.github.com/users/UnrememberMe/orgs","repos_url":"https://api.github.com/users/UnrememberMe/repos","events_url":"https://api.github.com/users/UnrememberMe/events{/privacy}","received_events_url":"https://api.github.com/users/UnrememberMe/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pantsbuild/pants/pulls/5490/commits","review_comments_url":"https://api.github.com/repos/pantsbuild/pants/pulls/5490/comments","review_comment_url":"https://api.github.com/repos/pantsbuild/pants/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pantsbuild/pants/issues/5490/comments","statuses_url":"https://api.github.com/repos/pantsbuild/pants/statuses/41a1a9a281f50ca30c0f6230d8e9dca3a3dbad9d","head":{"label":"cosmicexplorer:dmcclanahan/python-dist-c++-sources","ref":"dmcclanahan/python-dist-c++-sources","sha":"41a1a9a281f50ca30c0f6230d8e9dca3a3dbad9d","user":{"login":"cosmicexplorer","id":1305167,"avatar_url":"https://avatars1.githubusercontent.com/u/1305167?v=4","gravatar_id":"","url":"https://api.github.com/users/cosmicexplorer","html_url":"https://github.com/cosmicexplorer","followers_url":"https://api.github.com/users/cosmicexplorer/followers","following_url":"https://api.github.com/users/cosmicexplorer/following{/other_user}","gists_url":"https://api.github.com/users/cosmicexplorer/gists{/gist_id}","starred_url":"https://api.github.com/users/cosmicexplorer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosmicexplorer/subscriptions","organizations_url":"https://api.github.com/users/cosmicexplorer/orgs","repos_url":"https://api.github.com/users/cosmicexplorer/repos","events_url":"https://api.github.com/users/cosmicexplorer/events{/privacy}","received_events_url":"https://api.github.com/users/cosmicexplorer/received_events","type":"User","site_admin":false},"repo":{"id":59165183,"name":"pants","full_name":"cosmicexplorer/pants","owner":{"login":"cosmicexplorer","id":1305167,"avatar_url":"https://avatars1.githubusercontent.com/u/1305167?v=4","gravatar_id":"","url":"https://api.github.com/users/cosmicexplorer","html_url":"https://github.com/cosmicexplorer","followers_url":"https://api.github.com/users/cosmicexplorer/followers","following_url":"https://api.github.com/users/cosmicexplorer/following{/other_user}","gists_url":"https://api.github.com/users/cosmicexplorer/gists{/gist_id}","starred_url":"https://api.github.com/users/cosmicexplorer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosmicexplorer/subscriptions","organizations_url":"https://api.github.com/users/cosmicexplorer/orgs","repos_url":"https://api.github.com/users/cosmicexplorer/repos","events_url":"https://api.github.com/users/cosmicexplorer/events{/privacy}","received_events_url":"https://api.github.com/users/cosmicexplorer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cosmicexplorer/pants","description":"Pants Build System","fork":true,"url":"https://api.github.com/repos/cosmicexplorer/pants","forks_url":"https://api.github.com/repos/cosmicexplorer/pants/forks","keys_url":"https://api.github.com/repos/cosmicexplorer/pants/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cosmicexplorer/pants/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cosmicexplorer/pants/teams","hooks_url":"https://api.github.com/repos/cosmicexplorer/pants/hooks","issue_events_url":"https://api.github.com/repos/cosmicexplorer/pants/issues/events{/number}","events_url":"https://api.github.com/repos/cosmicexplorer/pants/events","assignees_url":"https://api.github.com/repos/cosmicexplorer/pants/assignees{/user}","branches_url":"https://api.github.com/repos/cosmicexplorer/pants/branches{/branch}","tags_url":"https://api.github.com/repos/cosmicexplorer/pants/tags","blobs_url":"https://api.github.com/repos/cosmicexplorer/pants/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cosmicexplorer/pants/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cosmicexplorer/pants/git/refs{/sha}","trees_url":"https://api.github.com/repos/cosmicexplorer/pants/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cosmicexplorer/pants/statuses/{sha}","languages_url":"https://api.github.com/repos/cosmicexplorer/pants/languages","stargazers_url":"https://api.github.com/repos/cosmicexplorer/pants/stargazers","contributors_url":"https://api.github.com/repos/cosmicexplorer/pants/contributors","subscribers_url":"https://api.github.com/repos/cosmicexplorer/pants/subscribers","subscription_url":"https://api.github.com/repos/cosmicexplorer/pants/subscription","commits_url":"https://api.github.com/repos/cosmicexplorer/pants/commits{/sha}","git_commits_url":"https://api.github.com/repos/cosmicexplorer/pants/git/commits{/sha}","comments_url":"https://api.github.com/repos/cosmicexplorer/pants/comments{/number}","issue_comment_url":"https://api.github.com/repos/cosmicexplorer/pants/issues/comments{/number}","contents_url":"https://api.github.com/repos/cosmicexplorer/pants/contents/{+path}","compare_url":"https://api.github.com/repos/cosmicexplorer/pants/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cosmicexplorer/pants/merges","archive_url":"https://api.github.com/repos/cosmicexplorer/pants/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cosmicexplorer/pants/downloads","issues_url":"https://api.github.com/repos/cosmicexplorer/pants/issues{/number}","pulls_url":"https://api.github.com/repos/cosmicexplorer/pants/pulls{/number}","milestones_url":"https://api.github.com/repos/cosmicexplorer/pants/milestones{/number}","notifications_url":"https://api.github.com/repos/cosmicexplorer/pants/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cosmicexplorer/pants/labels{/name}","releases_url":"https://api.github.com/repos/cosmicexplorer/pants/releases{/id}","deployments_url":"https://api.github.com/repos/cosmicexplorer/pants/deployments","created_at":"2016-05-19T01:53:21Z","updated_at":"2016-05-19T01:53:26Z","pushed_at":"2018-02-20T22:18:05Z","git_url":"git://github.com/cosmicexplorer/pants.git","ssh_url":"[email protected]:cosmicexplorer/pants.git","clone_url":"https://github.com/cosmicexplorer/pants.git","svn_url":"https://github.com/cosmicexplorer/pants","homepage":"http://pantsbuild.github.io/","size":82714,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pantsbuild:master","ref":"master","sha":"71a33d65d11458ccceb67126c9dc418682e479a5","user":{"login":"pantsbuild","id":3065172,"avatar_url":"https://avatars0.githubusercontent.com/u/3065172?v=4","gravatar_id":"","url":"https://api.github.com/users/pantsbuild","html_url":"https://github.com/pantsbuild","followers_url":"https://api.github.com/users/pantsbuild/followers","following_url":"https://api.github.com/users/pantsbuild/following{/other_user}","gists_url":"https://api.github.com/users/pantsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/pantsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pantsbuild/subscriptions","organizations_url":"https://api.github.com/users/pantsbuild/orgs","repos_url":"https://api.github.com/users/pantsbuild/repos","events_url":"https://api.github.com/users/pantsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/pantsbuild/received_events","type":"Organization","site_admin":false},"repo":{"id":7209075,"name":"pants","full_name":"pantsbuild/pants","owner":{"login":"pantsbuild","id":3065172,"avatar_url":"https://avatars0.githubusercontent.com/u/3065172?v=4","gravatar_id":"","url":"https://api.github.com/users/pantsbuild","html_url":"https://github.com/pantsbuild","followers_url":"https://api.github.com/users/pantsbuild/followers","following_url":"https://api.github.com/users/pantsbuild/following{/other_user}","gists_url":"https://api.github.com/users/pantsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/pantsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pantsbuild/subscriptions","organizations_url":"https://api.github.com/users/pantsbuild/orgs","repos_url":"https://api.github.com/users/pantsbuild/repos","events_url":"https://api.github.com/users/pantsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/pantsbuild/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pantsbuild/pants","description":"The Pants Build System","fork":false,"url":"https://api.github.com/repos/pantsbuild/pants","forks_url":"https://api.github.com/repos/pantsbuild/pants/forks","keys_url":"https://api.github.com/repos/pantsbuild/pants/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pantsbuild/pants/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pantsbuild/pants/teams","hooks_url":"https://api.github.com/repos/pantsbuild/pants/hooks","issue_events_url":"https://api.github.com/repos/pantsbuild/pants/issues/events{/number}","events_url":"https://api.github.com/repos/pantsbuild/pants/events","assignees_url":"https://api.github.com/repos/pantsbuild/pants/assignees{/user}","branches_url":"https://api.github.com/repos/pantsbuild/pants/branches{/branch}","tags_url":"https://api.github.com/repos/pantsbuild/pants/tags","blobs_url":"https://api.github.com/repos/pantsbuild/pants/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pantsbuild/pants/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pantsbuild/pants/git/refs{/sha}","trees_url":"https://api.github.com/repos/pantsbuild/pants/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pantsbuild/pants/statuses/{sha}","languages_url":"https://api.github.com/repos/pantsbuild/pants/languages","stargazers_url":"https://api.github.com/repos/pantsbuild/pants/stargazers","contributors_url":"https://api.github.com/repos/pantsbuild/pants/contributors","subscribers_url":"https://api.github.com/repos/pantsbuild/pants/subscribers","subscription_url":"https://api.github.com/repos/pantsbuild/pants/subscription","commits_url":"https://api.github.com/repos/pantsbuild/pants/commits{/sha}","git_commits_url":"https://api.github.com/repos/pantsbuild/pants/git/commits{/sha}","comments_url":"https://api.github.com/repos/pantsbuild/pants/comments{/number}","issue_comment_url":"https://api.github.com/repos/pantsbuild/pants/issues/comments{/number}","contents_url":"https://api.github.com/repos/pantsbuild/pants/contents/{+path}","compare_url":"https://api.github.com/repos/pantsbuild/pants/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pantsbuild/pants/merges","archive_url":"https://api.github.com/repos/pantsbuild/pants/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pantsbuild/pants/downloads","issues_url":"https://api.github.com/repos/pantsbuild/pants/issues{/number}","pulls_url":"https://api.github.com/repos/pantsbuild/pants/pulls{/number}","milestones_url":"https://api.github.com/repos/pantsbuild/pants/milestones{/number}","notifications_url":"https://api.github.com/repos/pantsbuild/pants/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pantsbuild/pants/labels{/name}","releases_url":"https://api.github.com/repos/pantsbuild/pants/releases{/id}","deployments_url":"https://api.github.com/repos/pantsbuild/pants/deployments","created_at":"2012-12-17T17:39:04Z","updated_at":"2018-02-20T12:19:45Z","pushed_at":"2018-02-20T22:40:08Z","git_url":"git://github.com/pantsbuild/pants.git","ssh_url":"[email protected]:pantsbuild/pants.git","clone_url":"https://github.com/pantsbuild/pants.git","svn_url":"https://github.com/pantsbuild/pants","homepage":"http://pantsbuild.org/","size":82545,"stargazers_count":918,"watchers_count":918,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":258,"mirror_url":null,"archived":false,"open_issues_count":594,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":258,"open_issues":594,"watchers":918,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/5490"},"html":{"href":"https://github.com/pantsbuild/pants/pull/5490"},"issue":{"href":"https://api.github.com/repos/pantsbuild/pants/issues/5490"},"comments":{"href":"https://api.github.com/repos/pantsbuild/pants/issues/5490/comments"},"review_comments":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/5490/comments"},"review_comment":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/5490/commits"},"statuses":{"href":"https://api.github.com/repos/pantsbuild/pants/statuses/41a1a9a281f50ca30c0f6230d8e9dca3a3dbad9d"}},"author_association":"CONTRIBUTOR"}} | {
"id": 7209075,
"name": "pantsbuild/pants",
"url": "https://api.github.com/repos/pantsbuild/pants"
} | {
"id": 1305167,
"login": "cosmicexplorer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1305167?",
"url": "https://api.github.com/users/cosmicexplorer"
} | {
"id": 3065172,
"login": "pantsbuild",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3065172?",
"url": "https://api.github.com/orgs/pantsbuild"
} | 2018-02-20T23:15:21 | 7272454965 | {"actor":{"display_login":"cosmicexplorer"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/marmelab/quarto-isomorphic/pulls/comments/200973271","pull_request_review_id":135382330,"id":200973271,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDk3MzI3MQ==","diff_hunk":"@@ -1,31 +1,22 @@\n import React from 'react';\n import Link from 'next/link';\n-import styled, { css } from 'react-emotion';\n+import { bodyStyle } from './styles/GlobalStyles';","path":"pages/index.js","position":4,"original_position":4,"commit_id":"0c424c56f170198dafdc3f48f3f40566f3f2b4c6","original_commit_id":"0c424c56f170198dafdc3f48f3f40566f3f2b4c6","user":{"login":"fzaninotto","id":99944,"node_id":"MDQ6VXNlcjk5OTQ0","avatar_url":"https://avatars3.githubusercontent.com/u/99944?v=4","gravatar_id":"","url":"https://api.github.com/users/fzaninotto","html_url":"https://github.com/fzaninotto","followers_url":"https://api.github.com/users/fzaninotto/followers","following_url":"https://api.github.com/users/fzaninotto/following{/other_user}","gists_url":"https://api.github.com/users/fzaninotto/gists{/gist_id}","starred_url":"https://api.github.com/users/fzaninotto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fzaninotto/subscriptions","organizations_url":"https://api.github.com/users/fzaninotto/orgs","repos_url":"https://api.github.com/users/fzaninotto/repos","events_url":"https://api.github.com/users/fzaninotto/events{/privacy}","received_events_url":"https://api.github.com/users/fzaninotto/received_events","type":"User","site_admin":false},"body":"Make it a styled component instead","created_at":"2018-07-09T11:49:03Z","updated_at":"2018-07-09T11:50:17Z","html_url":"https://github.com/marmelab/quarto-isomorphic/pull/1#discussion_r200973271","pull_request_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/pulls/1","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/marmelab/quarto-isomorphic/pulls/comments/200973271"},"html":{"href":"https://github.com/marmelab/quarto-isomorphic/pull/1#discussion_r200973271"},"pull_request":{"href":"https://api.github.com/repos/marmelab/quarto-isomorphic/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/marmelab/quarto-isomorphic/pulls/1","id":200049595,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMDQ5NTk1","html_url":"https://github.com/marmelab/quarto-isomorphic/pull/1","diff_url":"https://github.com/marmelab/quarto-isomorphic/pull/1.diff","patch_url":"https://github.com/marmelab/quarto-isomorphic/pull/1.patch","issue_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/issues/1","number":1,"state":"open","locked":false,"title":"[WIP] Basic home page rendering","user":{"login":"JulienMattiussi","id":39904906,"node_id":"MDQ6VXNlcjM5OTA0OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/39904906?v=4","gravatar_id":"","url":"https://api.github.com/users/JulienMattiussi","html_url":"https://github.com/JulienMattiussi","followers_url":"https://api.github.com/users/JulienMattiussi/followers","following_url":"https://api.github.com/users/JulienMattiussi/following{/other_user}","gists_url":"https://api.github.com/users/JulienMattiussi/gists{/gist_id}","starred_url":"https://api.github.com/users/JulienMattiussi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JulienMattiussi/subscriptions","organizations_url":"https://api.github.com/users/JulienMattiussi/orgs","repos_url":"https://api.github.com/users/JulienMattiussi/repos","events_url":"https://api.github.com/users/JulienMattiussi/events{/privacy}","received_events_url":"https://api.github.com/users/JulienMattiussi/received_events","type":"User","site_admin":false},"body":"\r\n\r\nSimple display of the home page\r\n\r\n- [x] Show the home page\r\n- [ ] Test button rendering","created_at":"2018-07-09T10:02:16Z","updated_at":"2018-07-09T11:50:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"374e036c93ea04d04bfafcb39f574e7e6c5849a7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/pulls/1/commits","review_comments_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/pulls/1/comments","review_comment_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/issues/1/comments","statuses_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/statuses/0c424c56f170198dafdc3f48f3f40566f3f2b4c6","head":{"label":"marmelab:homepage","ref":"homepage","sha":"0c424c56f170198dafdc3f48f3f40566f3f2b4c6","user":{"login":"marmelab","id":3116319,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMTYzMTk=","avatar_url":"https://avatars1.githubusercontent.com/u/3116319?v=4","gravatar_id":"","url":"https://api.github.com/users/marmelab","html_url":"https://github.com/marmelab","followers_url":"https://api.github.com/users/marmelab/followers","following_url":"https://api.github.com/users/marmelab/following{/other_user}","gists_url":"https://api.github.com/users/marmelab/gists{/gist_id}","starred_url":"https://api.github.com/users/marmelab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marmelab/subscriptions","organizations_url":"https://api.github.com/users/marmelab/orgs","repos_url":"https://api.github.com/users/marmelab/repos","events_url":"https://api.github.com/users/marmelab/events{/privacy}","received_events_url":"https://api.github.com/users/marmelab/received_events","type":"Organization","site_admin":false},"repo":{"id":140002517,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAwMDI1MTc=","name":"quarto-isomorphic","full_name":"marmelab/quarto-isomorphic","owner":{"login":"marmelab","id":3116319,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMTYzMTk=","avatar_url":"https://avatars1.githubusercontent.com/u/3116319?v=4","gravatar_id":"","url":"https://api.github.com/users/marmelab","html_url":"https://github.com/marmelab","followers_url":"https://api.github.com/users/marmelab/followers","following_url":"https://api.github.com/users/marmelab/following{/other_user}","gists_url":"https://api.github.com/users/marmelab/gists{/gist_id}","starred_url":"https://api.github.com/users/marmelab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marmelab/subscriptions","organizations_url":"https://api.github.com/users/marmelab/orgs","repos_url":"https://api.github.com/users/marmelab/repos","events_url":"https://api.github.com/users/marmelab/events{/privacy}","received_events_url":"https://api.github.com/users/marmelab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/marmelab/quarto-isomorphic","description":"Quarto game with react in SSR mode","fork":false,"url":"https://api.github.com/repos/marmelab/quarto-isomorphic","forks_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/forks","keys_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/teams","hooks_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/hooks","issue_events_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/issues/events{/number}","events_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/events","assignees_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/assignees{/user}","branches_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/branches{/branch}","tags_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/tags","blobs_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/git/refs{/sha}","trees_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/statuses/{sha}","languages_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/languages","stargazers_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/stargazers","contributors_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/contributors","subscribers_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/subscribers","subscription_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/subscription","commits_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/commits{/sha}","git_commits_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/git/commits{/sha}","comments_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/comments{/number}","issue_comment_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/issues/comments{/number}","contents_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/contents/{+path}","compare_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/merges","archive_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/downloads","issues_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/issues{/number}","pulls_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/pulls{/number}","milestones_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/milestones{/number}","notifications_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/labels{/name}","releases_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/releases{/id}","deployments_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/deployments","created_at":"2018-07-06T15:37:02Z","updated_at":"2018-07-09T09:16:48Z","pushed_at":"2018-07-09T10:02:17Z","git_url":"git://github.com/marmelab/quarto-isomorphic.git","ssh_url":"[email protected]:marmelab/quarto-isomorphic.git","clone_url":"https://github.com/marmelab/quarto-isomorphic.git","svn_url":"https://github.com/marmelab/quarto-isomorphic","homepage":null,"size":461,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"marmelab:master","ref":"master","sha":"984f9f0aa6aca0f51fe1fb47f289916adb3ac8e2","user":{"login":"marmelab","id":3116319,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMTYzMTk=","avatar_url":"https://avatars1.githubusercontent.com/u/3116319?v=4","gravatar_id":"","url":"https://api.github.com/users/marmelab","html_url":"https://github.com/marmelab","followers_url":"https://api.github.com/users/marmelab/followers","following_url":"https://api.github.com/users/marmelab/following{/other_user}","gists_url":"https://api.github.com/users/marmelab/gists{/gist_id}","starred_url":"https://api.github.com/users/marmelab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marmelab/subscriptions","organizations_url":"https://api.github.com/users/marmelab/orgs","repos_url":"https://api.github.com/users/marmelab/repos","events_url":"https://api.github.com/users/marmelab/events{/privacy}","received_events_url":"https://api.github.com/users/marmelab/received_events","type":"Organization","site_admin":false},"repo":{"id":140002517,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAwMDI1MTc=","name":"quarto-isomorphic","full_name":"marmelab/quarto-isomorphic","owner":{"login":"marmelab","id":3116319,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMTYzMTk=","avatar_url":"https://avatars1.githubusercontent.com/u/3116319?v=4","gravatar_id":"","url":"https://api.github.com/users/marmelab","html_url":"https://github.com/marmelab","followers_url":"https://api.github.com/users/marmelab/followers","following_url":"https://api.github.com/users/marmelab/following{/other_user}","gists_url":"https://api.github.com/users/marmelab/gists{/gist_id}","starred_url":"https://api.github.com/users/marmelab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marmelab/subscriptions","organizations_url":"https://api.github.com/users/marmelab/orgs","repos_url":"https://api.github.com/users/marmelab/repos","events_url":"https://api.github.com/users/marmelab/events{/privacy}","received_events_url":"https://api.github.com/users/marmelab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/marmelab/quarto-isomorphic","description":"Quarto game with react in SSR mode","fork":false,"url":"https://api.github.com/repos/marmelab/quarto-isomorphic","forks_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/forks","keys_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/teams","hooks_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/hooks","issue_events_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/issues/events{/number}","events_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/events","assignees_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/assignees{/user}","branches_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/branches{/branch}","tags_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/tags","blobs_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/git/refs{/sha}","trees_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/statuses/{sha}","languages_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/languages","stargazers_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/stargazers","contributors_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/contributors","subscribers_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/subscribers","subscription_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/subscription","commits_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/commits{/sha}","git_commits_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/git/commits{/sha}","comments_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/comments{/number}","issue_comment_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/issues/comments{/number}","contents_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/contents/{+path}","compare_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/merges","archive_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/downloads","issues_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/issues{/number}","pulls_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/pulls{/number}","milestones_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/milestones{/number}","notifications_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/labels{/name}","releases_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/releases{/id}","deployments_url":"https://api.github.com/repos/marmelab/quarto-isomorphic/deployments","created_at":"2018-07-06T15:37:02Z","updated_at":"2018-07-09T09:16:48Z","pushed_at":"2018-07-09T10:02:17Z","git_url":"git://github.com/marmelab/quarto-isomorphic.git","ssh_url":"[email protected]:marmelab/quarto-isomorphic.git","clone_url":"https://github.com/marmelab/quarto-isomorphic.git","svn_url":"https://github.com/marmelab/quarto-isomorphic","homepage":null,"size":461,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/marmelab/quarto-isomorphic/pulls/1"},"html":{"href":"https://github.com/marmelab/quarto-isomorphic/pull/1"},"issue":{"href":"https://api.github.com/repos/marmelab/quarto-isomorphic/issues/1"},"comments":{"href":"https://api.github.com/repos/marmelab/quarto-isomorphic/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/marmelab/quarto-isomorphic/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/marmelab/quarto-isomorphic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/marmelab/quarto-isomorphic/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/marmelab/quarto-isomorphic/statuses/0c424c56f170198dafdc3f48f3f40566f3f2b4c6"}},"author_association":"COLLABORATOR"}} | {
"id": 140002517,
"name": "marmelab/quarto-isomorphic",
"url": "https://api.github.com/repos/marmelab/quarto-isomorphic"
} | {
"id": 99944,
"login": "fzaninotto",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/99944?",
"url": "https://api.github.com/users/fzaninotto"
} | {
"id": 3116319,
"login": "marmelab",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3116319?",
"url": "https://api.github.com/orgs/marmelab"
} | 2018-07-09T11:49:03 | 7937125688 | {"actor":{"display_login":"fzaninotto"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/edx/paragon/pulls/comments/182515147","pull_request_review_id":113326158,"id":182515147,"diff_hunk":"@@ -0,0 +1,85 @@\n+\n+import React from 'react';\n+import PropTypes from 'prop-types';\n+import classNames from 'classnames';\n+import FontAwesomeStyles from 'font-awesome/css/font-awesome.min.css';\n+\n+import newId from '../utils/newId';\n+import styles from './ValidationMessage.scss';\n+\n+const inputProps = {\n+ dangerIconDescription: PropTypes.oneOfType([PropTypes.string, PropTypes.element]),\n+ className: PropTypes.arrayOf(PropTypes.string),\n+ errorId: PropTypes.string,\n+ isValid: PropTypes.bool,\n+ themes: PropTypes.arrayOf(PropTypes.string),\n+ validationMessage: PropTypes.oneOfType([PropTypes.string, PropTypes.element]),\n+};\n+\n+const defaultProps = {\n+ dangerIconDescription: '',\n+ className: [],\n+ errorId: undefined,\n+ isValid: true,\n+ themes: [],\n+ validationMessage: '',\n+};\n+\n+class ValidationMessage extends React.Component {\n+ constructor(props) {\n+ super(props);\n+\n+ const id = this.props.errorId ? this.props.errorId : `error-${newId('validationMessage')}`;\n+ this.state = {\n+ errorId: id,\n+ };\n+ }\n+\n+ hasDangerTheme() {\n+ return this.props.themes.indexOf('danger') >= 0;\n+ }\n+\n+ render() {\n+ return (\n+ <div\n+ className={classNames(\n+ styles['invalid-feedback'],\n+ { [styles['invalid-feedback-nodanger']]: !this.hasDangerTheme() },\n+ this.props.className,\n+ )}\n+ id={this.state.errorId}\n+ aria-live=\"polite\"\n+ >\n+ { this.props.isValid ? (\n+ <span />\n+ ) : [\n+ (this.hasDangerTheme() &&\n+ <span key=\"0\">\n+ <span\n+ className={classNames(\n+ FontAwesomeStyles.fa,\n+ FontAwesomeStyles['fa-exclamation-circle'],\n+ styles['fa-icon-spacing'],\n+ )}\n+ aria-hidden\n+ />\n+ <span\n+ className={classNames(styles['sr-only'])}\n+ >\n+ {this.props.dangerIconDescription}\n+ </span>\n+ </span>\n+ ),\n+ <span key=\"1\">","path":"src/ValidationMessage/index.jsx","position":73,"original_position":73,"commit_id":"9072866989bc4f2f67647d73f4bd30f09f5a3683","original_commit_id":"9072866989bc4f2f67647d73f4bd30f09f5a3683","user":{"login":"jaebradley","id":8136030,"avatar_url":"https://avatars0.githubusercontent.com/u/8136030?v=4","gravatar_id":"","url":"https://api.github.com/users/jaebradley","html_url":"https://github.com/jaebradley","followers_url":"https://api.github.com/users/jaebradley/followers","following_url":"https://api.github.com/users/jaebradley/following{/other_user}","gists_url":"https://api.github.com/users/jaebradley/gists{/gist_id}","starred_url":"https://api.github.com/users/jaebradley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaebradley/subscriptions","organizations_url":"https://api.github.com/users/jaebradley/orgs","repos_url":"https://api.github.com/users/jaebradley/repos","events_url":"https://api.github.com/users/jaebradley/events{/privacy}","received_events_url":"https://api.github.com/users/jaebradley/received_events","type":"User","site_admin":false},"body":"That will make this component incompatible with anything before `React` 16 right?\r\n\r\nIs this something we need to be concerned about? (Probably not)","created_at":"2018-04-18T17:53:12Z","updated_at":"2018-04-18T17:53:12Z","html_url":"https://github.com/edx/paragon/pull/215#discussion_r182515147","pull_request_url":"https://api.github.com/repos/edx/paragon/pulls/215","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/edx/paragon/pulls/comments/182515147"},"html":{"href":"https://github.com/edx/paragon/pull/215#discussion_r182515147"},"pull_request":{"href":"https://api.github.com/repos/edx/paragon/pulls/215"}},"in_reply_to_id":182232906},"pull_request":{"url":"https://api.github.com/repos/edx/paragon/pulls/215","id":182275644,"html_url":"https://github.com/edx/paragon/pull/215","diff_url":"https://github.com/edx/paragon/pull/215.diff","patch_url":"https://github.com/edx/paragon/pull/215.patch","issue_url":"https://api.github.com/repos/edx/paragon/issues/215","number":215,"state":"open","locked":false,"title":"feat(fieldset): add Fieldset and ValidationMessage","user":{"login":"thallada","id":1505923,"avatar_url":"https://avatars3.githubusercontent.com/u/1505923?v=4","gravatar_id":"","url":"https://api.github.com/users/thallada","html_url":"https://github.com/thallada","followers_url":"https://api.github.com/users/thallada/followers","following_url":"https://api.github.com/users/thallada/following{/other_user}","gists_url":"https://api.github.com/users/thallada/gists{/gist_id}","starred_url":"https://api.github.com/users/thallada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thallada/subscriptions","organizations_url":"https://api.github.com/users/thallada/orgs","repos_url":"https://api.github.com/users/thallada/repos","events_url":"https://api.github.com/users/thallada/events{/privacy}","received_events_url":"https://api.github.com/users/thallada/received_events","type":"User","site_admin":false},"body":"Also, refactors the invalid-feedback div out of asInput into its own component.","created_at":"2018-04-17T19:51:07Z","updated_at":"2018-04-18T17:53:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43dd706ad97d2d54b136671eb380a5f1064549bb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/edx/paragon/pulls/215/commits","review_comments_url":"https://api.github.com/repos/edx/paragon/pulls/215/comments","review_comment_url":"https://api.github.com/repos/edx/paragon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/paragon/issues/215/comments","statuses_url":"https://api.github.com/repos/edx/paragon/statuses/9072866989bc4f2f67647d73f4bd30f09f5a3683","head":{"label":"edx:thallada/fieldset","ref":"thallada/fieldset","sha":"9072866989bc4f2f67647d73f4bd30f09f5a3683","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":89630641,"name":"paragon","full_name":"edx/paragon","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/paragon","description":"💎 Accessible components done right.","fork":false,"url":"https://api.github.com/repos/edx/paragon","forks_url":"https://api.github.com/repos/edx/paragon/forks","keys_url":"https://api.github.com/repos/edx/paragon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/paragon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/paragon/teams","hooks_url":"https://api.github.com/repos/edx/paragon/hooks","issue_events_url":"https://api.github.com/repos/edx/paragon/issues/events{/number}","events_url":"https://api.github.com/repos/edx/paragon/events","assignees_url":"https://api.github.com/repos/edx/paragon/assignees{/user}","branches_url":"https://api.github.com/repos/edx/paragon/branches{/branch}","tags_url":"https://api.github.com/repos/edx/paragon/tags","blobs_url":"https://api.github.com/repos/edx/paragon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/paragon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/paragon/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/paragon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/paragon/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/paragon/languages","stargazers_url":"https://api.github.com/repos/edx/paragon/stargazers","contributors_url":"https://api.github.com/repos/edx/paragon/contributors","subscribers_url":"https://api.github.com/repos/edx/paragon/subscribers","subscription_url":"https://api.github.com/repos/edx/paragon/subscription","commits_url":"https://api.github.com/repos/edx/paragon/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/paragon/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/paragon/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/paragon/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/paragon/contents/{+path}","compare_url":"https://api.github.com/repos/edx/paragon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/paragon/merges","archive_url":"https://api.github.com/repos/edx/paragon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/paragon/downloads","issues_url":"https://api.github.com/repos/edx/paragon/issues{/number}","pulls_url":"https://api.github.com/repos/edx/paragon/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/paragon/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/paragon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/paragon/labels{/name}","releases_url":"https://api.github.com/repos/edx/paragon/releases{/id}","deployments_url":"https://api.github.com/repos/edx/paragon/deployments","created_at":"2017-04-27T18:57:22Z","updated_at":"2018-04-12T20:17:54Z","pushed_at":"2018-04-18T17:42:54Z","git_url":"git://github.com/edx/paragon.git","ssh_url":"[email protected]:edx/paragon.git","clone_url":"https://github.com/edx/paragon.git","svn_url":"https://github.com/edx/paragon","homepage":"https://edx.github.io/paragon","size":3317,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2,"open_issues":30,"watchers":14,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"13d45638aea83ae0bb23f16c852d81adbb8557ab","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":89630641,"name":"paragon","full_name":"edx/paragon","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/paragon","description":"💎 Accessible components done right.","fork":false,"url":"https://api.github.com/repos/edx/paragon","forks_url":"https://api.github.com/repos/edx/paragon/forks","keys_url":"https://api.github.com/repos/edx/paragon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/paragon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/paragon/teams","hooks_url":"https://api.github.com/repos/edx/paragon/hooks","issue_events_url":"https://api.github.com/repos/edx/paragon/issues/events{/number}","events_url":"https://api.github.com/repos/edx/paragon/events","assignees_url":"https://api.github.com/repos/edx/paragon/assignees{/user}","branches_url":"https://api.github.com/repos/edx/paragon/branches{/branch}","tags_url":"https://api.github.com/repos/edx/paragon/tags","blobs_url":"https://api.github.com/repos/edx/paragon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/paragon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/paragon/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/paragon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/paragon/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/paragon/languages","stargazers_url":"https://api.github.com/repos/edx/paragon/stargazers","contributors_url":"https://api.github.com/repos/edx/paragon/contributors","subscribers_url":"https://api.github.com/repos/edx/paragon/subscribers","subscription_url":"https://api.github.com/repos/edx/paragon/subscription","commits_url":"https://api.github.com/repos/edx/paragon/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/paragon/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/paragon/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/paragon/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/paragon/contents/{+path}","compare_url":"https://api.github.com/repos/edx/paragon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/paragon/merges","archive_url":"https://api.github.com/repos/edx/paragon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/paragon/downloads","issues_url":"https://api.github.com/repos/edx/paragon/issues{/number}","pulls_url":"https://api.github.com/repos/edx/paragon/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/paragon/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/paragon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/paragon/labels{/name}","releases_url":"https://api.github.com/repos/edx/paragon/releases{/id}","deployments_url":"https://api.github.com/repos/edx/paragon/deployments","created_at":"2017-04-27T18:57:22Z","updated_at":"2018-04-12T20:17:54Z","pushed_at":"2018-04-18T17:42:54Z","git_url":"git://github.com/edx/paragon.git","ssh_url":"[email protected]:edx/paragon.git","clone_url":"https://github.com/edx/paragon.git","svn_url":"https://github.com/edx/paragon","homepage":"https://edx.github.io/paragon","size":3317,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2,"open_issues":30,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/paragon/pulls/215"},"html":{"href":"https://github.com/edx/paragon/pull/215"},"issue":{"href":"https://api.github.com/repos/edx/paragon/issues/215"},"comments":{"href":"https://api.github.com/repos/edx/paragon/issues/215/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/paragon/pulls/215/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/paragon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/paragon/pulls/215/commits"},"statuses":{"href":"https://api.github.com/repos/edx/paragon/statuses/9072866989bc4f2f67647d73f4bd30f09f5a3683"}},"author_association":"CONTRIBUTOR"}} | {
"id": 89630641,
"name": "edx/paragon",
"url": "https://api.github.com/repos/edx/paragon"
} | {
"id": 8136030,
"login": "jaebradley",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8136030?",
"url": "https://api.github.com/users/jaebradley"
} | {
"id": 3179841,
"login": "edx",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3179841?",
"url": "https://api.github.com/orgs/edx"
} | 2018-04-18T17:53:12 | 7550746450 | {"actor":{"display_login":"jaebradley"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/openssl/openssl/pulls/comments/242872581","pull_request_review_id":186488662,"id":242872581,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0Mjg3MjU4MQ==","diff_hunk":"@@ -785,6 +786,24 @@ int X509_check_issued(X509 *issuer, X509 *subject)\n return ret;\n }\n \n+ {\n+ /*\n+ * Check if the subject signature algorithm matches the issue PUBKEY","path":"crypto/x509v3/v3_purp.c","position":16,"original_position":16,"commit_id":"0ef2fadec91b47a15018509f2dc5c4e606346c0d","original_commit_id":"0ef2fadec91b47a15018509f2dc5c4e606346c0d","user":{"login":"levitte","id":698918,"node_id":"MDQ6VXNlcjY5ODkxOA==","avatar_url":"https://avatars1.githubusercontent.com/u/698918?v=4","gravatar_id":"","url":"https://api.github.com/users/levitte","html_url":"https://github.com/levitte","followers_url":"https://api.github.com/users/levitte/followers","following_url":"https://api.github.com/users/levitte/following{/other_user}","gists_url":"https://api.github.com/users/levitte/gists{/gist_id}","starred_url":"https://api.github.com/users/levitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levitte/subscriptions","organizations_url":"https://api.github.com/users/levitte/orgs","repos_url":"https://api.github.com/users/levitte/repos","events_url":"https://api.github.com/users/levitte/events{/privacy}","received_events_url":"https://api.github.com/users/levitte/received_events","type":"User","site_admin":false},"body":"Will fix","created_at":"2018-12-19T10:53:17Z","updated_at":"2018-12-19T10:53:17Z","html_url":"https://github.com/openssl/openssl/pull/7919#discussion_r242872581","pull_request_url":"https://api.github.com/repos/openssl/openssl/pulls/7919","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments/242872581"},"html":{"href":"https://github.com/openssl/openssl/pull/7919#discussion_r242872581"},"pull_request":{"href":"https://api.github.com/repos/openssl/openssl/pulls/7919"}},"in_reply_to_id":242839634},"pull_request":{"url":"https://api.github.com/repos/openssl/openssl/pulls/7919","id":239399291,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5Mzk5Mjkx","html_url":"https://github.com/openssl/openssl/pull/7919","diff_url":"https://github.com/openssl/openssl/pull/7919.diff","patch_url":"https://github.com/openssl/openssl/pull/7919.patch","issue_url":"https://api.github.com/repos/openssl/openssl/issues/7919","number":7919,"state":"open","locked":false,"title":"X509_check_issued: check that signature algo matches signing key algo","user":{"login":"levitte","id":698918,"node_id":"MDQ6VXNlcjY5ODkxOA==","avatar_url":"https://avatars1.githubusercontent.com/u/698918?v=4","gravatar_id":"","url":"https://api.github.com/users/levitte","html_url":"https://github.com/levitte","followers_url":"https://api.github.com/users/levitte/followers","following_url":"https://api.github.com/users/levitte/following{/other_user}","gists_url":"https://api.github.com/users/levitte/gists{/gist_id}","starred_url":"https://api.github.com/users/levitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levitte/subscriptions","organizations_url":"https://api.github.com/users/levitte/orgs","repos_url":"https://api.github.com/users/levitte/repos","events_url":"https://api.github.com/users/levitte/events{/privacy}","received_events_url":"https://api.github.com/users/levitte/received_events","type":"User","site_admin":false},"body":"This implements 3.5.18 \"Consistent Public Key and Signature Algorithms\"\r\nfrom RFC 4158 \"Internet X.509 Public Key Infrastructure: Certification\r\nPath Building\"\r\n\r\nRef: https://tools.ietf.org/html/rfc4158#section-3.5.18\r\n\r\nFixes #7899\r\n","created_at":"2018-12-18T08:18:53Z","updated_at":"2018-12-19T10:53:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1de993ee71daa470d02327d4a83f90816921bc7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":344283545,"node_id":"MDU6TGFiZWwzNDQyODM1NDU=","url":"https://api.github.com/repos/openssl/openssl/labels/feature","name":"feature","color":"0052cc","default":false},{"id":441165144,"node_id":"MDU6TGFiZWw0NDExNjUxNDQ=","url":"https://api.github.com/repos/openssl/openssl/labels/master","name":"master","color":"bfdadc","default":false},{"id":613575196,"node_id":"MDU6TGFiZWw2MTM1NzUxOTY=","url":"https://api.github.com/repos/openssl/openssl/labels/pending%202nd%20review","name":"pending 2nd review","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openssl/openssl/pulls/7919/commits","review_comments_url":"https://api.github.com/repos/openssl/openssl/pulls/7919/comments","review_comment_url":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openssl/openssl/issues/7919/comments","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/0ef2fadec91b47a15018509f2dc5c4e606346c0d","head":{"label":"levitte:fix-7899","ref":"fix-7899","sha":"0ef2fadec91b47a15018509f2dc5c4e606346c0d","user":{"login":"levitte","id":698918,"node_id":"MDQ6VXNlcjY5ODkxOA==","avatar_url":"https://avatars1.githubusercontent.com/u/698918?v=4","gravatar_id":"","url":"https://api.github.com/users/levitte","html_url":"https://github.com/levitte","followers_url":"https://api.github.com/users/levitte/followers","following_url":"https://api.github.com/users/levitte/following{/other_user}","gists_url":"https://api.github.com/users/levitte/gists{/gist_id}","starred_url":"https://api.github.com/users/levitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levitte/subscriptions","organizations_url":"https://api.github.com/users/levitte/orgs","repos_url":"https://api.github.com/users/levitte/repos","events_url":"https://api.github.com/users/levitte/events{/privacy}","received_events_url":"https://api.github.com/users/levitte/received_events","type":"User","site_admin":false},"repo":{"id":22960861,"node_id":"MDEwOlJlcG9zaXRvcnkyMjk2MDg2MQ==","name":"openssl","full_name":"levitte/openssl","private":false,"owner":{"login":"levitte","id":698918,"node_id":"MDQ6VXNlcjY5ODkxOA==","avatar_url":"https://avatars1.githubusercontent.com/u/698918?v=4","gravatar_id":"","url":"https://api.github.com/users/levitte","html_url":"https://github.com/levitte","followers_url":"https://api.github.com/users/levitte/followers","following_url":"https://api.github.com/users/levitte/following{/other_user}","gists_url":"https://api.github.com/users/levitte/gists{/gist_id}","starred_url":"https://api.github.com/users/levitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levitte/subscriptions","organizations_url":"https://api.github.com/users/levitte/orgs","repos_url":"https://api.github.com/users/levitte/repos","events_url":"https://api.github.com/users/levitte/events{/privacy}","received_events_url":"https://api.github.com/users/levitte/received_events","type":"User","site_admin":false},"html_url":"https://github.com/levitte/openssl","description":null,"fork":true,"url":"https://api.github.com/repos/levitte/openssl","forks_url":"https://api.github.com/repos/levitte/openssl/forks","keys_url":"https://api.github.com/repos/levitte/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/levitte/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/levitte/openssl/teams","hooks_url":"https://api.github.com/repos/levitte/openssl/hooks","issue_events_url":"https://api.github.com/repos/levitte/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/levitte/openssl/events","assignees_url":"https://api.github.com/repos/levitte/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/levitte/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/levitte/openssl/tags","blobs_url":"https://api.github.com/repos/levitte/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/levitte/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/levitte/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/levitte/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/levitte/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/levitte/openssl/languages","stargazers_url":"https://api.github.com/repos/levitte/openssl/stargazers","contributors_url":"https://api.github.com/repos/levitte/openssl/contributors","subscribers_url":"https://api.github.com/repos/levitte/openssl/subscribers","subscription_url":"https://api.github.com/repos/levitte/openssl/subscription","commits_url":"https://api.github.com/repos/levitte/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/levitte/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/levitte/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/levitte/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/levitte/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/levitte/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/levitte/openssl/merges","archive_url":"https://api.github.com/repos/levitte/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/levitte/openssl/downloads","issues_url":"https://api.github.com/repos/levitte/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/levitte/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/levitte/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/levitte/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/levitte/openssl/labels{/name}","releases_url":"https://api.github.com/repos/levitte/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/levitte/openssl/deployments","created_at":"2014-08-14T16:32:56Z","updated_at":"2018-12-15T11:26:06Z","pushed_at":"2018-12-19T05:15:03Z","git_url":"git://github.com/levitte/openssl.git","ssh_url":"[email protected]:levitte/openssl.git","clone_url":"https://github.com/levitte/openssl.git","svn_url":"https://github.com/levitte/openssl","homepage":"","size":170245,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openssl:master","ref":"master","sha":"5aa2a7ea41d7137640cb0914807fd1202b920543","user":{"login":"openssl","id":3279138,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzkxMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/3279138?v=4","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"repo":{"id":7634677,"node_id":"MDEwOlJlcG9zaXRvcnk3NjM0Njc3","name":"openssl","full_name":"openssl/openssl","private":false,"owner":{"login":"openssl","id":3279138,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzkxMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/3279138?v=4","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openssl/openssl","description":"TLS/SSL and crypto library","fork":false,"url":"https://api.github.com/repos/openssl/openssl","forks_url":"https://api.github.com/repos/openssl/openssl/forks","keys_url":"https://api.github.com/repos/openssl/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openssl/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openssl/openssl/teams","hooks_url":"https://api.github.com/repos/openssl/openssl/hooks","issue_events_url":"https://api.github.com/repos/openssl/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/openssl/openssl/events","assignees_url":"https://api.github.com/repos/openssl/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/openssl/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/openssl/openssl/tags","blobs_url":"https://api.github.com/repos/openssl/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openssl/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openssl/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/openssl/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/openssl/openssl/languages","stargazers_url":"https://api.github.com/repos/openssl/openssl/stargazers","contributors_url":"https://api.github.com/repos/openssl/openssl/contributors","subscribers_url":"https://api.github.com/repos/openssl/openssl/subscribers","subscription_url":"https://api.github.com/repos/openssl/openssl/subscription","commits_url":"https://api.github.com/repos/openssl/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/openssl/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/openssl/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/openssl/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/openssl/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/openssl/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openssl/openssl/merges","archive_url":"https://api.github.com/repos/openssl/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openssl/openssl/downloads","issues_url":"https://api.github.com/repos/openssl/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/openssl/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/openssl/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/openssl/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openssl/openssl/labels{/name}","releases_url":"https://api.github.com/repos/openssl/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/openssl/openssl/deployments","created_at":"2013-01-15T22:34:48Z","updated_at":"2018-12-19T09:35:25Z","pushed_at":"2018-12-19T05:15:10Z","git_url":"git://github.com/openssl/openssl.git","ssh_url":"[email protected]:openssl/openssl.git","clone_url":"https://github.com/openssl/openssl.git","svn_url":"https://github.com/openssl/openssl","homepage":"https://www.openssl.org","size":163547,"stargazers_count":8960,"watchers_count":8960,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4086,"mirror_url":null,"archived":false,"open_issues_count":619,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4086,"open_issues":619,"watchers":8960,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/7919"},"html":{"href":"https://github.com/openssl/openssl/pull/7919"},"issue":{"href":"https://api.github.com/repos/openssl/openssl/issues/7919"},"comments":{"href":"https://api.github.com/repos/openssl/openssl/issues/7919/comments"},"review_comments":{"href":"https://api.github.com/repos/openssl/openssl/pulls/7919/comments"},"review_comment":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openssl/openssl/pulls/7919/commits"},"statuses":{"href":"https://api.github.com/repos/openssl/openssl/statuses/0ef2fadec91b47a15018509f2dc5c4e606346c0d"}},"author_association":"MEMBER"}} | {
"id": 7634677,
"name": "openssl/openssl",
"url": "https://api.github.com/repos/openssl/openssl"
} | {
"id": 698918,
"login": "levitte",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/698918?",
"url": "https://api.github.com/users/levitte"
} | {
"id": 3279138,
"login": "openssl",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3279138?",
"url": "https://api.github.com/orgs/openssl"
} | 2018-12-19T10:53:17 | 8778104254 | {"actor":{"display_login":"levitte"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/openssl/openssl/pulls/comments/225579507","pull_request_review_id":164764416,"id":225579507,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTU3OTUwNw==","diff_hunk":"@@ -865,15 +848,12 @@ int DTLSv1_listen(SSL *s, BIO_ADDR *client)\n if (BIO_dgram_get_peer(rbio, client) <= 0)\n BIO_ADDR_clear(client);\n \n+ if (!dtls_buffer_listen_record(s, reclen, seq, align))","path":"ssl/d1_lib.c","position":159,"original_position":159,"commit_id":"e7f09488cbfe8b2f4d1313515be39dd35f55b9cb","original_commit_id":"e7f09488cbfe8b2f4d1313515be39dd35f55b9cb","user":{"login":"kaduk","id":1894506,"node_id":"MDQ6VXNlcjE4OTQ1MDY=","avatar_url":"https://avatars1.githubusercontent.com/u/1894506?v=4","gravatar_id":"","url":"https://api.github.com/users/kaduk","html_url":"https://github.com/kaduk","followers_url":"https://api.github.com/users/kaduk/followers","following_url":"https://api.github.com/users/kaduk/following{/other_user}","gists_url":"https://api.github.com/users/kaduk/gists{/gist_id}","starred_url":"https://api.github.com/users/kaduk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaduk/subscriptions","organizations_url":"https://api.github.com/users/kaduk/orgs","repos_url":"https://api.github.com/users/kaduk/repos","events_url":"https://api.github.com/users/kaduk/events{/privacy}","received_events_url":"https://api.github.com/users/kaduk/received_events","type":"User","site_admin":false},"body":"I understand that this is an internal API and we can change it later if we need to, but it might be worth thinking about pulling up the processed_rcds reference to this call, to be clear that we're adding to the \"already-processed\" queue.","created_at":"2018-10-16T15:01:10Z","updated_at":"2018-10-16T15:04:54Z","html_url":"https://github.com/openssl/openssl/pull/7375#discussion_r225579507","pull_request_url":"https://api.github.com/repos/openssl/openssl/pulls/7375","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments/225579507"},"html":{"href":"https://github.com/openssl/openssl/pull/7375#discussion_r225579507"},"pull_request":{"href":"https://api.github.com/repos/openssl/openssl/pulls/7375"}}},"pull_request":{"url":"https://api.github.com/repos/openssl/openssl/pulls/7375","id":221440743,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNDQwNzQz","html_url":"https://github.com/openssl/openssl/pull/7375","diff_url":"https://github.com/openssl/openssl/pull/7375.diff","patch_url":"https://github.com/openssl/openssl/pull/7375.patch","issue_url":"https://api.github.com/repos/openssl/openssl/issues/7375","number":7375,"state":"open","locked":false,"title":" Buffer a ClientHello with a cookie received via DTLSv1_listen","user":{"login":"mattcaswell","id":7422273,"node_id":"MDQ6VXNlcjc0MjIyNzM=","avatar_url":"https://avatars0.githubusercontent.com/u/7422273?v=4","gravatar_id":"","url":"https://api.github.com/users/mattcaswell","html_url":"https://github.com/mattcaswell","followers_url":"https://api.github.com/users/mattcaswell/followers","following_url":"https://api.github.com/users/mattcaswell/following{/other_user}","gists_url":"https://api.github.com/users/mattcaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/mattcaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattcaswell/subscriptions","organizations_url":"https://api.github.com/users/mattcaswell/orgs","repos_url":"https://api.github.com/users/mattcaswell/repos","events_url":"https://api.github.com/users/mattcaswell/events{/privacy}","received_events_url":"https://api.github.com/users/mattcaswell/received_events","type":"User","site_admin":false},"body":"Previously when a ClientHello arrives with a valid cookie using `DTLSv1_listen()` we only \"peeked\" at the message and left it on the underlying fd. This works fine for single threaded applications but for multi-threaded apps this does not work since the fd is typically reused for the server thread, while a new fd is created and connected for the client. By \"peeking\" we leave the message on the server fd, and consequently we think we've received another valid ClientHello and so we create yet another\r\nfd for the client, and so on until we run out of fds.\r\n\r\nIn this new approach we remove the ClientHello and buffer it in the SSL object.\r\n\r\nThe buffering approach requires the record data to be in the read SSL3_BUFFER object. Previously we were using the `init_buf`. It makes more sense for it to be in the SSL3_BUFFER anyway, so we swap to using these buffers instead.\r\n\r\nFixes #6934","created_at":"2018-10-09T13:32:17Z","updated_at":"2018-10-16T15:04:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"abef31b13b64d423404d5eeacd39009bebc2c3e1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":872237503,"node_id":"MDU6TGFiZWw4NzIyMzc1MDM=","url":"https://api.github.com/repos/openssl/openssl/labels/1.1.1","name":"1.1.1","color":"bfdadc","default":false},{"id":441165144,"node_id":"MDU6TGFiZWw0NDExNjUxNDQ=","url":"https://api.github.com/repos/openssl/openssl/labels/master","name":"master","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openssl/openssl/pulls/7375/commits","review_comments_url":"https://api.github.com/repos/openssl/openssl/pulls/7375/comments","review_comment_url":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openssl/openssl/issues/7375/comments","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/e7f09488cbfe8b2f4d1313515be39dd35f55b9cb","head":{"label":"mattcaswell:fix-dtlsv1-listen","ref":"fix-dtlsv1-listen","sha":"e7f09488cbfe8b2f4d1313515be39dd35f55b9cb","user":{"login":"mattcaswell","id":7422273,"node_id":"MDQ6VXNlcjc0MjIyNzM=","avatar_url":"https://avatars0.githubusercontent.com/u/7422273?v=4","gravatar_id":"","url":"https://api.github.com/users/mattcaswell","html_url":"https://github.com/mattcaswell","followers_url":"https://api.github.com/users/mattcaswell/followers","following_url":"https://api.github.com/users/mattcaswell/following{/other_user}","gists_url":"https://api.github.com/users/mattcaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/mattcaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattcaswell/subscriptions","organizations_url":"https://api.github.com/users/mattcaswell/orgs","repos_url":"https://api.github.com/users/mattcaswell/repos","events_url":"https://api.github.com/users/mattcaswell/events{/privacy}","received_events_url":"https://api.github.com/users/mattcaswell/received_events","type":"User","site_admin":false},"repo":{"id":26978010,"node_id":"MDEwOlJlcG9zaXRvcnkyNjk3ODAxMA==","name":"openssl","full_name":"mattcaswell/openssl","private":false,"owner":{"login":"mattcaswell","id":7422273,"node_id":"MDQ6VXNlcjc0MjIyNzM=","avatar_url":"https://avatars0.githubusercontent.com/u/7422273?v=4","gravatar_id":"","url":"https://api.github.com/users/mattcaswell","html_url":"https://github.com/mattcaswell","followers_url":"https://api.github.com/users/mattcaswell/followers","following_url":"https://api.github.com/users/mattcaswell/following{/other_user}","gists_url":"https://api.github.com/users/mattcaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/mattcaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattcaswell/subscriptions","organizations_url":"https://api.github.com/users/mattcaswell/orgs","repos_url":"https://api.github.com/users/mattcaswell/repos","events_url":"https://api.github.com/users/mattcaswell/events{/privacy}","received_events_url":"https://api.github.com/users/mattcaswell/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mattcaswell/openssl","description":null,"fork":true,"url":"https://api.github.com/repos/mattcaswell/openssl","forks_url":"https://api.github.com/repos/mattcaswell/openssl/forks","keys_url":"https://api.github.com/repos/mattcaswell/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattcaswell/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattcaswell/openssl/teams","hooks_url":"https://api.github.com/repos/mattcaswell/openssl/hooks","issue_events_url":"https://api.github.com/repos/mattcaswell/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/mattcaswell/openssl/events","assignees_url":"https://api.github.com/repos/mattcaswell/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/mattcaswell/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/mattcaswell/openssl/tags","blobs_url":"https://api.github.com/repos/mattcaswell/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattcaswell/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattcaswell/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattcaswell/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattcaswell/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/mattcaswell/openssl/languages","stargazers_url":"https://api.github.com/repos/mattcaswell/openssl/stargazers","contributors_url":"https://api.github.com/repos/mattcaswell/openssl/contributors","subscribers_url":"https://api.github.com/repos/mattcaswell/openssl/subscribers","subscription_url":"https://api.github.com/repos/mattcaswell/openssl/subscription","commits_url":"https://api.github.com/repos/mattcaswell/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattcaswell/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattcaswell/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattcaswell/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattcaswell/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/mattcaswell/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattcaswell/openssl/merges","archive_url":"https://api.github.com/repos/mattcaswell/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattcaswell/openssl/downloads","issues_url":"https://api.github.com/repos/mattcaswell/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/mattcaswell/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/mattcaswell/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/mattcaswell/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattcaswell/openssl/labels{/name}","releases_url":"https://api.github.com/repos/mattcaswell/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/mattcaswell/openssl/deployments","created_at":"2014-11-21T21:09:59Z","updated_at":"2017-02-22T10:52:04Z","pushed_at":"2018-10-16T11:47:36Z","git_url":"git://github.com/mattcaswell/openssl.git","ssh_url":"[email protected]:mattcaswell/openssl.git","clone_url":"https://github.com/mattcaswell/openssl.git","svn_url":"https://github.com/mattcaswell/openssl","homepage":null,"size":159140,"stargazers_count":4,"watchers_count":4,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"openssl:master","ref":"master","sha":"5c1bd555d3c81cbd46d5032e84c29d16bb4a8f06","user":{"login":"openssl","id":3279138,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzkxMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/3279138?v=4","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"repo":{"id":7634677,"node_id":"MDEwOlJlcG9zaXRvcnk3NjM0Njc3","name":"openssl","full_name":"openssl/openssl","private":false,"owner":{"login":"openssl","id":3279138,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzkxMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/3279138?v=4","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openssl/openssl","description":"TLS/SSL and crypto library","fork":false,"url":"https://api.github.com/repos/openssl/openssl","forks_url":"https://api.github.com/repos/openssl/openssl/forks","keys_url":"https://api.github.com/repos/openssl/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openssl/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openssl/openssl/teams","hooks_url":"https://api.github.com/repos/openssl/openssl/hooks","issue_events_url":"https://api.github.com/repos/openssl/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/openssl/openssl/events","assignees_url":"https://api.github.com/repos/openssl/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/openssl/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/openssl/openssl/tags","blobs_url":"https://api.github.com/repos/openssl/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openssl/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openssl/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/openssl/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/openssl/openssl/languages","stargazers_url":"https://api.github.com/repos/openssl/openssl/stargazers","contributors_url":"https://api.github.com/repos/openssl/openssl/contributors","subscribers_url":"https://api.github.com/repos/openssl/openssl/subscribers","subscription_url":"https://api.github.com/repos/openssl/openssl/subscription","commits_url":"https://api.github.com/repos/openssl/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/openssl/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/openssl/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/openssl/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/openssl/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/openssl/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openssl/openssl/merges","archive_url":"https://api.github.com/repos/openssl/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openssl/openssl/downloads","issues_url":"https://api.github.com/repos/openssl/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/openssl/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/openssl/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/openssl/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openssl/openssl/labels{/name}","releases_url":"https://api.github.com/repos/openssl/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/openssl/openssl/deployments","created_at":"2013-01-15T22:34:48Z","updated_at":"2018-10-16T14:54:57Z","pushed_at":"2018-10-16T14:43:37Z","git_url":"git://github.com/openssl/openssl.git","ssh_url":"[email protected]:openssl/openssl.git","clone_url":"https://github.com/openssl/openssl.git","svn_url":"https://github.com/openssl/openssl","homepage":"https://www.openssl.org","size":158116,"stargazers_count":8461,"watchers_count":8461,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3883,"mirror_url":null,"archived":false,"open_issues_count":543,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3883,"open_issues":543,"watchers":8461,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/7375"},"html":{"href":"https://github.com/openssl/openssl/pull/7375"},"issue":{"href":"https://api.github.com/repos/openssl/openssl/issues/7375"},"comments":{"href":"https://api.github.com/repos/openssl/openssl/issues/7375/comments"},"review_comments":{"href":"https://api.github.com/repos/openssl/openssl/pulls/7375/comments"},"review_comment":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openssl/openssl/pulls/7375/commits"},"statuses":{"href":"https://api.github.com/repos/openssl/openssl/statuses/e7f09488cbfe8b2f4d1313515be39dd35f55b9cb"}},"author_association":"MEMBER"}} | {
"id": 7634677,
"name": "openssl/openssl",
"url": "https://api.github.com/repos/openssl/openssl"
} | {
"id": 1894506,
"login": "kaduk",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1894506?",
"url": "https://api.github.com/users/kaduk"
} | {
"id": 3279138,
"login": "openssl",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3279138?",
"url": "https://api.github.com/orgs/openssl"
} | 2018-10-16T15:01:10 | 8429212581 | {"actor":{"display_login":"kaduk"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/openssl/openssl/pulls/comments/228315377","pull_request_review_id":168562479,"id":228315377,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODMxNTM3Nw==","diff_hunk":"@@ -0,0 +1,235 @@\n+=pod\n+\n+=head1 NAME\n+\n+EVP_MAC, EVP_MAC_CTX, EVP_MAC_CTX_new, EVP_MAC_CTX_new_id, EVP_MAC_CTX_free,\n+EVP_MAC_CTX_copy, EVP_MAC_CTX_mac, EVP_MAC_reset, EVP_MAC_size, EVP_MAC_init,\n+EVP_MAC_update, EVP_MAC_final, EVP_MAC_ctrl, EVP_MAC_ctrl_str, EVP_MAC_str2ctrl,\n+EVP_MAC_hex2ctrl, EVP_MAC_nid, EVP_MAC_name, EVP_add_mac, EVP_get_macbyname,\n+EVP_get_macbynid, EVP_get_macbyobj - EVP MAC routines\n+\n+=head1 SYNOPSIS\n+\n+ #include <openssl/evp.h>\n+\n+ typedef struct evp_mac_st EVP_MAC;\n+ typedef struct evp_mac_ctx_st EVP_MAC_CTX;\n+\n+ EVP_MAC_CTX *EVP_MAC_CTX_new(const EVP_MAC *mac);\n+ EVP_MAC_CTX *EVP_MAC_CTX_new_id(int nid);\n+ void EVP_MAC_CTX_free(EVP_MAC_CTX *ctx);\n+ int EVP_MAC_CTX_copy(EVP_MAC_CTX *dest, EVP_MAC_CTX *src);\n+ const EVP_MAC *EVP_MAC_CTX_mac(EVP_MAC_CTX *ctx);\n+ int EVP_MAC_reset(EVP_MAC_CTX *ctx);\n+ size_t EVP_MAC_size(EVP_MAC_CTX *ctx);\n+ int EVP_MAC_init(EVP_MAC_CTX *ctx);\n+ int EVP_MAC_update(EVP_MAC_CTX *ctx, const unsigned char *data, size_t datalen);\n+ int EVP_MAC_final(EVP_MAC_CTX *ctx, unsigned char *out, size_t *poutlen);\n+ int EVP_MAC_ctrl(EVP_MAC_CTX *ctx, int cmd, ...);\n+ int EVP_MAC_ctrl_str(EVP_MAC_CTX *ctx, const char *type, const char *value);\n+ int EVP_MAC_str2ctrl(EVP_MAC_CTX *ctx, int cmd, const char *value);\n+ int EVP_MAC_hex2ctrl(EVP_MAC_CTX *ctx, int cmd, const char *value);\n+ int EVP_MAC_nid(const EVP_MAC *mac);\n+ const char *EVP_MAC_name(const EVP_MAC *mac);\n+ int EVP_add_mac(const EVP_MAC *mac);\n+ const EVP_MAC *EVP_get_macbyname(const char *name);\n+ const EVP_MAC *EVP_get_macbynid(int nid);\n+ const EVP_MAC *EVP_get_macbyobj(const ASN1_OBJECT *o);\n+\n+=head1 DESCRIPTION\n+\n+These types and functions help the application to calculate MACs of\n+different types and with different underlying algorithms if there are\n+any.\n+\n+=head2 Types\n+\n+B<EVP_MAC> is a type that holds the implementation of a MAC.\n+\n+B<EVP_MAC_CTX> is a context type that holds internal information used\n+to compute MACs from the input.\n+\n+=head2 Context manipulation functions\n+\n+EVP_MAC_CTX_new() creates a new context for the MAC type C<mac>.\n+EVP_MAC_CTX_new_id() creates a new context for the numerical MAC\n+identity <nid>. The created context can then be used with most other\n+functions described here.\n+\n+EVP_MAC_CTX_free() frees the contents of the context as well as the\n+context itself. B<NULL> is a valid parameter, for which this function\n+is a no-op.\n+\n+EVP_MAC_CTX_copy() makes a deep copy of the C<src> context to the\n+C<dest> context. The C<dest> context I<must> have been created before\n+calling this function.","path":"doc/man3/EVP_MAC.pod","position":77,"original_position":65,"commit_id":"ae33379efbf34b1e9b15f1c226acd45cf85077a6","original_commit_id":"9a9fb003bef2b8e44231af6c782cfc7ebf2995fc","user":{"login":"kroeckx","id":1616242,"node_id":"MDQ6VXNlcjE2MTYyNDI=","avatar_url":"https://avatars3.githubusercontent.com/u/1616242?v=4","gravatar_id":"","url":"https://api.github.com/users/kroeckx","html_url":"https://github.com/kroeckx","followers_url":"https://api.github.com/users/kroeckx/followers","following_url":"https://api.github.com/users/kroeckx/following{/other_user}","gists_url":"https://api.github.com/users/kroeckx/gists{/gist_id}","starred_url":"https://api.github.com/users/kroeckx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kroeckx/subscriptions","organizations_url":"https://api.github.com/users/kroeckx/orgs","repos_url":"https://api.github.com/users/kroeckx/repos","events_url":"https://api.github.com/users/kroeckx/events{/privacy}","received_events_url":"https://api.github.com/users/kroeckx/received_events","type":"User","site_admin":false},"body":"I really dislike the copy pattern. I'm sure most of those copy functions have various bugs in them and are very hard to get correct, and probably none of them are correct. This is part of the reusing pattern that I want to get rid of.","created_at":"2018-10-25T20:03:25Z","updated_at":"2018-10-25T20:03:25Z","html_url":"https://github.com/openssl/openssl/pull/7393#discussion_r228315377","pull_request_url":"https://api.github.com/repos/openssl/openssl/pulls/7393","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments/228315377"},"html":{"href":"https://github.com/openssl/openssl/pull/7393#discussion_r228315377"},"pull_request":{"href":"https://api.github.com/repos/openssl/openssl/pulls/7393"}},"in_reply_to_id":228213338},"pull_request":{"url":"https://api.github.com/repos/openssl/openssl/pulls/7393","id":222578028,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNTc4MDI4","html_url":"https://github.com/openssl/openssl/pull/7393","diff_url":"https://github.com/openssl/openssl/pull/7393.diff","patch_url":"https://github.com/openssl/openssl/pull/7393.patch","issue_url":"https://api.github.com/repos/openssl/openssl/issues/7393","number":7393,"state":"open","locked":false,"title":"Add EVP_MAC API","user":{"login":"levitte","id":698918,"node_id":"MDQ6VXNlcjY5ODkxOA==","avatar_url":"https://avatars1.githubusercontent.com/u/698918?v=4","gravatar_id":"","url":"https://api.github.com/users/levitte","html_url":"https://github.com/levitte","followers_url":"https://api.github.com/users/levitte/followers","following_url":"https://api.github.com/users/levitte/following{/other_user}","gists_url":"https://api.github.com/users/levitte/gists{/gist_id}","starred_url":"https://api.github.com/users/levitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levitte/subscriptions","organizations_url":"https://api.github.com/users/levitte/orgs","repos_url":"https://api.github.com/users/levitte/repos","events_url":"https://api.github.com/users/levitte/events{/privacy}","received_events_url":"https://api.github.com/users/levitte/received_events","type":"User","site_admin":false},"body":"We currently implement EVP MAC methods as EVP_PKEY methods. This\r\nchange creates a separate EVP API for MACs, to replace the current\r\nEVP_PKEY ones.\r\n\r\nA note about this EVP API and how it interfaces with underlying MAC\r\nimplementations:\r\n\r\nOther EVP APIs pass the EVP API context down to implementations, and\r\nit can be observed that the implementations use the pointer to their\r\nown private data almost exclusively. The EVP_MAC API deviates from\r\nthat pattern by passing the pointer to the implementation's private\r\ndata directly, and thereby deny the implementations access to the\r\nEVP_MAC context structure. This change is made to provide a clearer\r\nseparation between the EVP library itself and the implementations of\r\nits supported algorithm classes.\r\n\r\n<!--\r\nThank you for your pull request. Please review these requirements:\r\n\r\nContributors guide: https://github.com/openssl/openssl/blob/master/CONTRIBUTING\r\n\r\nOther than that, provide a description above this comment if there isn't one already\r\n\r\nIf this fixes a github issue, make sure to have a line saying 'Fixes #XXXX' (without quotes) in the commit message.\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n- [ ] documentation is added or updated\r\n- [ ] tests are added or updated\r\n","created_at":"2018-10-12T20:29:23Z","updated_at":"2018-10-25T20:03:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cae2c570f81c6daec4caa0d20f8e4e9aa0e23f30","assignee":null,"assignees":[],"requested_reviewers":[{"login":"InfoHunter","id":799430,"node_id":"MDQ6VXNlcjc5OTQzMA==","avatar_url":"https://avatars3.githubusercontent.com/u/799430?v=4","gravatar_id":"","url":"https://api.github.com/users/InfoHunter","html_url":"https://github.com/InfoHunter","followers_url":"https://api.github.com/users/InfoHunter/followers","following_url":"https://api.github.com/users/InfoHunter/following{/other_user}","gists_url":"https://api.github.com/users/InfoHunter/gists{/gist_id}","starred_url":"https://api.github.com/users/InfoHunter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/InfoHunter/subscriptions","organizations_url":"https://api.github.com/users/InfoHunter/orgs","repos_url":"https://api.github.com/users/InfoHunter/repos","events_url":"https://api.github.com/users/InfoHunter/events{/privacy}","received_events_url":"https://api.github.com/users/InfoHunter/received_events","type":"User","site_admin":false},{"login":"t-j-h","id":7409473,"node_id":"MDQ6VXNlcjc0MDk0NzM=","avatar_url":"https://avatars2.githubusercontent.com/u/7409473?v=4","gravatar_id":"","url":"https://api.github.com/users/t-j-h","html_url":"https://github.com/t-j-h","followers_url":"https://api.github.com/users/t-j-h/followers","following_url":"https://api.github.com/users/t-j-h/following{/other_user}","gists_url":"https://api.github.com/users/t-j-h/gists{/gist_id}","starred_url":"https://api.github.com/users/t-j-h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t-j-h/subscriptions","organizations_url":"https://api.github.com/users/t-j-h/orgs","repos_url":"https://api.github.com/users/t-j-h/repos","events_url":"https://api.github.com/users/t-j-h/events{/privacy}","received_events_url":"https://api.github.com/users/t-j-h/received_events","type":"User","site_admin":false},{"login":"mattcaswell","id":7422273,"node_id":"MDQ6VXNlcjc0MjIyNzM=","avatar_url":"https://avatars0.githubusercontent.com/u/7422273?v=4","gravatar_id":"","url":"https://api.github.com/users/mattcaswell","html_url":"https://github.com/mattcaswell","followers_url":"https://api.github.com/users/mattcaswell/followers","following_url":"https://api.github.com/users/mattcaswell/following{/other_user}","gists_url":"https://api.github.com/users/mattcaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/mattcaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattcaswell/subscriptions","organizations_url":"https://api.github.com/users/mattcaswell/orgs","repos_url":"https://api.github.com/users/mattcaswell/repos","events_url":"https://api.github.com/users/mattcaswell/events{/privacy}","received_events_url":"https://api.github.com/users/mattcaswell/received_events","type":"User","site_admin":false},{"login":"mspncp","id":11467854,"node_id":"MDQ6VXNlcjExNDY3ODU0","avatar_url":"https://avatars2.githubusercontent.com/u/11467854?v=4","gravatar_id":"","url":"https://api.github.com/users/mspncp","html_url":"https://github.com/mspncp","followers_url":"https://api.github.com/users/mspncp/followers","following_url":"https://api.github.com/users/mspncp/following{/other_user}","gists_url":"https://api.github.com/users/mspncp/gists{/gist_id}","starred_url":"https://api.github.com/users/mspncp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mspncp/subscriptions","organizations_url":"https://api.github.com/users/mspncp/orgs","repos_url":"https://api.github.com/users/mspncp/repos","events_url":"https://api.github.com/users/mspncp/events{/privacy}","received_events_url":"https://api.github.com/users/mspncp/received_events","type":"User","site_admin":false},{"login":"paulidale","id":17916609,"node_id":"MDQ6VXNlcjE3OTE2NjA5","avatar_url":"https://avatars1.githubusercontent.com/u/17916609?v=4","gravatar_id":"","url":"https://api.github.com/users/paulidale","html_url":"https://github.com/paulidale","followers_url":"https://api.github.com/users/paulidale/followers","following_url":"https://api.github.com/users/paulidale/following{/other_user}","gists_url":"https://api.github.com/users/paulidale/gists{/gist_id}","starred_url":"https://api.github.com/users/paulidale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulidale/subscriptions","organizations_url":"https://api.github.com/users/paulidale/orgs","repos_url":"https://api.github.com/users/paulidale/repos","events_url":"https://api.github.com/users/paulidale/events{/privacy}","received_events_url":"https://api.github.com/users/paulidale/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":441165144,"node_id":"MDU6TGFiZWw0NDExNjUxNDQ=","url":"https://api.github.com/repos/openssl/openssl/labels/master","name":"master","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openssl/openssl/pulls/7393/commits","review_comments_url":"https://api.github.com/repos/openssl/openssl/pulls/7393/comments","review_comment_url":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openssl/openssl/issues/7393/comments","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/ae33379efbf34b1e9b15f1c226acd45cf85077a6","head":{"label":"levitte:evp-mac","ref":"evp-mac","sha":"ae33379efbf34b1e9b15f1c226acd45cf85077a6","user":{"login":"levitte","id":698918,"node_id":"MDQ6VXNlcjY5ODkxOA==","avatar_url":"https://avatars1.githubusercontent.com/u/698918?v=4","gravatar_id":"","url":"https://api.github.com/users/levitte","html_url":"https://github.com/levitte","followers_url":"https://api.github.com/users/levitte/followers","following_url":"https://api.github.com/users/levitte/following{/other_user}","gists_url":"https://api.github.com/users/levitte/gists{/gist_id}","starred_url":"https://api.github.com/users/levitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levitte/subscriptions","organizations_url":"https://api.github.com/users/levitte/orgs","repos_url":"https://api.github.com/users/levitte/repos","events_url":"https://api.github.com/users/levitte/events{/privacy}","received_events_url":"https://api.github.com/users/levitte/received_events","type":"User","site_admin":false},"repo":{"id":22960861,"node_id":"MDEwOlJlcG9zaXRvcnkyMjk2MDg2MQ==","name":"openssl","full_name":"levitte/openssl","private":false,"owner":{"login":"levitte","id":698918,"node_id":"MDQ6VXNlcjY5ODkxOA==","avatar_url":"https://avatars1.githubusercontent.com/u/698918?v=4","gravatar_id":"","url":"https://api.github.com/users/levitte","html_url":"https://github.com/levitte","followers_url":"https://api.github.com/users/levitte/followers","following_url":"https://api.github.com/users/levitte/following{/other_user}","gists_url":"https://api.github.com/users/levitte/gists{/gist_id}","starred_url":"https://api.github.com/users/levitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levitte/subscriptions","organizations_url":"https://api.github.com/users/levitte/orgs","repos_url":"https://api.github.com/users/levitte/repos","events_url":"https://api.github.com/users/levitte/events{/privacy}","received_events_url":"https://api.github.com/users/levitte/received_events","type":"User","site_admin":false},"html_url":"https://github.com/levitte/openssl","description":null,"fork":true,"url":"https://api.github.com/repos/levitte/openssl","forks_url":"https://api.github.com/repos/levitte/openssl/forks","keys_url":"https://api.github.com/repos/levitte/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/levitte/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/levitte/openssl/teams","hooks_url":"https://api.github.com/repos/levitte/openssl/hooks","issue_events_url":"https://api.github.com/repos/levitte/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/levitte/openssl/events","assignees_url":"https://api.github.com/repos/levitte/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/levitte/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/levitte/openssl/tags","blobs_url":"https://api.github.com/repos/levitte/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/levitte/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/levitte/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/levitte/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/levitte/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/levitte/openssl/languages","stargazers_url":"https://api.github.com/repos/levitte/openssl/stargazers","contributors_url":"https://api.github.com/repos/levitte/openssl/contributors","subscribers_url":"https://api.github.com/repos/levitte/openssl/subscribers","subscription_url":"https://api.github.com/repos/levitte/openssl/subscription","commits_url":"https://api.github.com/repos/levitte/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/levitte/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/levitte/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/levitte/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/levitte/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/levitte/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/levitte/openssl/merges","archive_url":"https://api.github.com/repos/levitte/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/levitte/openssl/downloads","issues_url":"https://api.github.com/repos/levitte/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/levitte/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/levitte/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/levitte/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/levitte/openssl/labels{/name}","releases_url":"https://api.github.com/repos/levitte/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/levitte/openssl/deployments","created_at":"2014-08-14T16:32:56Z","updated_at":"2018-09-27T14:48:10Z","pushed_at":"2018-10-25T19:59:11Z","git_url":"git://github.com/levitte/openssl.git","ssh_url":"[email protected]:levitte/openssl.git","clone_url":"https://github.com/levitte/openssl.git","svn_url":"https://github.com/levitte/openssl","homepage":"","size":160433,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openssl:master","ref":"master","sha":"f81b043ad856d8b9af5239a4978f8bd4b965dab9","user":{"login":"openssl","id":3279138,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzkxMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/3279138?v=4","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"repo":{"id":7634677,"node_id":"MDEwOlJlcG9zaXRvcnk3NjM0Njc3","name":"openssl","full_name":"openssl/openssl","private":false,"owner":{"login":"openssl","id":3279138,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzkxMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/3279138?v=4","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openssl/openssl","description":"TLS/SSL and crypto library","fork":false,"url":"https://api.github.com/repos/openssl/openssl","forks_url":"https://api.github.com/repos/openssl/openssl/forks","keys_url":"https://api.github.com/repos/openssl/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openssl/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openssl/openssl/teams","hooks_url":"https://api.github.com/repos/openssl/openssl/hooks","issue_events_url":"https://api.github.com/repos/openssl/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/openssl/openssl/events","assignees_url":"https://api.github.com/repos/openssl/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/openssl/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/openssl/openssl/tags","blobs_url":"https://api.github.com/repos/openssl/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openssl/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openssl/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/openssl/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/openssl/openssl/languages","stargazers_url":"https://api.github.com/repos/openssl/openssl/stargazers","contributors_url":"https://api.github.com/repos/openssl/openssl/contributors","subscribers_url":"https://api.github.com/repos/openssl/openssl/subscribers","subscription_url":"https://api.github.com/repos/openssl/openssl/subscription","commits_url":"https://api.github.com/repos/openssl/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/openssl/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/openssl/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/openssl/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/openssl/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/openssl/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openssl/openssl/merges","archive_url":"https://api.github.com/repos/openssl/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openssl/openssl/downloads","issues_url":"https://api.github.com/repos/openssl/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/openssl/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/openssl/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/openssl/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openssl/openssl/labels{/name}","releases_url":"https://api.github.com/repos/openssl/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/openssl/openssl/deployments","created_at":"2013-01-15T22:34:48Z","updated_at":"2018-10-25T14:22:31Z","pushed_at":"2018-10-25T19:59:13Z","git_url":"git://github.com/openssl/openssl.git","ssh_url":"[email protected]:openssl/openssl.git","clone_url":"https://github.com/openssl/openssl.git","svn_url":"https://github.com/openssl/openssl","homepage":"https://www.openssl.org","size":159398,"stargazers_count":8518,"watchers_count":8518,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3912,"mirror_url":null,"archived":false,"open_issues_count":582,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3912,"open_issues":582,"watchers":8518,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/7393"},"html":{"href":"https://github.com/openssl/openssl/pull/7393"},"issue":{"href":"https://api.github.com/repos/openssl/openssl/issues/7393"},"comments":{"href":"https://api.github.com/repos/openssl/openssl/issues/7393/comments"},"review_comments":{"href":"https://api.github.com/repos/openssl/openssl/pulls/7393/comments"},"review_comment":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openssl/openssl/pulls/7393/commits"},"statuses":{"href":"https://api.github.com/repos/openssl/openssl/statuses/ae33379efbf34b1e9b15f1c226acd45cf85077a6"}},"author_association":"MEMBER"}} | {
"id": 7634677,
"name": "openssl/openssl",
"url": "https://api.github.com/repos/openssl/openssl"
} | {
"id": 1616242,
"login": "kroeckx",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1616242?",
"url": "https://api.github.com/users/kroeckx"
} | {
"id": 3279138,
"login": "openssl",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3279138?",
"url": "https://api.github.com/orgs/openssl"
} | 2018-10-25T20:03:25 | 8482944766 | {"actor":{"display_login":"kroeckx"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/awslabs/aws-cdk/pulls/comments/243196279","pull_request_review_id":186899505,"id":243196279,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzE5NjI3OQ==","diff_hunk":"@@ -0,0 +1,247 @@\n+#!/usr/bin/env node\n+\n+/**\n+ * automatically creates a module for any CloudFormation namespaces that do not\n+ * have an AWS construct library.\n+ */\n+\n+import child_process = require('child_process');\n+import fs = require('fs');\n+import path = require('path');\n+import { promisify } from 'util';\n+import cfnspec = require('../lib');\n+\n+const exist = promisify(fs.exists);","path":"packages/@aws-cdk/cfnspec/build-tools/create-missing-libraries.ts","position":14,"original_position":14,"commit_id":"2dca7b080adf1d397c7a5d28d01da5e9670f4b1b","original_commit_id":"2dca7b080adf1d397c7a5d28d01da5e9670f4b1b","user":{"login":"eladb","id":598796,"node_id":"MDQ6VXNlcjU5ODc5Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/598796?v=4","gravatar_id":"","url":"https://api.github.com/users/eladb","html_url":"https://github.com/eladb","followers_url":"https://api.github.com/users/eladb/followers","following_url":"https://api.github.com/users/eladb/following{/other_user}","gists_url":"https://api.github.com/users/eladb/gists{/gist_id}","starred_url":"https://api.github.com/users/eladb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eladb/subscriptions","organizations_url":"https://api.github.com/users/eladb/orgs","repos_url":"https://api.github.com/users/eladb/repos","events_url":"https://api.github.com/users/eladb/events{/privacy}","received_events_url":"https://api.github.com/users/eladb/received_events","type":"User","site_admin":false},"body":"Done, you are right.","created_at":"2018-12-20T09:02:42Z","updated_at":"2018-12-20T09:02:42Z","html_url":"https://github.com/awslabs/aws-cdk/pull/1407#discussion_r243196279","pull_request_url":"https://api.github.com/repos/awslabs/aws-cdk/pulls/1407","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/awslabs/aws-cdk/pulls/comments/243196279"},"html":{"href":"https://github.com/awslabs/aws-cdk/pull/1407#discussion_r243196279"},"pull_request":{"href":"https://api.github.com/repos/awslabs/aws-cdk/pulls/1407"}},"in_reply_to_id":243182853},"pull_request":{"url":"https://api.github.com/repos/awslabs/aws-cdk/pulls/1407","id":240004458,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwMDA0NDU4","html_url":"https://github.com/awslabs/aws-cdk/pull/1407","diff_url":"https://github.com/awslabs/aws-cdk/pull/1407.diff","patch_url":"https://github.com/awslabs/aws-cdk/pull/1407.patch","issue_url":"https://api.github.com/repos/awslabs/aws-cdk/issues/1407","number":1407,"state":"open","locked":false,"title":"feat: update CloudFormation resources v2.18.0","user":{"login":"eladb","id":598796,"node_id":"MDQ6VXNlcjU5ODc5Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/598796?v=4","gravatar_id":"","url":"https://api.github.com/users/eladb","html_url":"https://github.com/eladb","followers_url":"https://api.github.com/users/eladb/followers","following_url":"https://api.github.com/users/eladb/following{/other_user}","gists_url":"https://api.github.com/users/eladb/gists{/gist_id}","starred_url":"https://api.github.com/users/eladb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eladb/subscriptions","organizations_url":"https://api.github.com/users/eladb/orgs","repos_url":"https://api.github.com/users/eladb/repos","events_url":"https://api.github.com/users/eladb/events{/privacy}","received_events_url":"https://api.github.com/users/eladb/received_events","type":"User","site_admin":false},"body":"Rewrite the create-missing-libraries script in typescript\r\nso it's a bit more robust and mangles names nicely.\r\n\r\nNew resource types:\r\n\r\n* AWS::AmazonMQ::ConfigurationAssociation\r\n* AWS::IoTAnalytics::Channel\r\n* AWS::IoTAnalytics::Dataset\r\n* AWS::IoTAnalytics::Datastore\r\n* AWS::IoTAnalytics::Pipeline\r\n\r\n\r\n----\r\n\r\n### Pull Request Checklist\r\n\r\nPlease check all boxes, including N/A items:\r\n\r\n#### Testing\r\n\r\n- [x] Unit test and/or integration test added\r\n- [x] __Toolkit change?:__ [integration tests](https://github.com/awslabs/aws-cdk/blob/master/packages/aws-cdk/integ-tests/test.sh) manually executed (paste output to the PR description)\r\n- [x] __Init template change?:__ coordinated update of integration tests (currently maintained in a private repo).\r\n\r\n#### Documentation\r\n\r\n- [x] __README__: README and/or documentation topic updated\r\n- [ ] __jsdocs__: All public APIs documented\r\n\r\n### Title and description\r\n\r\n- [x] __Change type__: Title is prefixed with change type:\r\n * `fix(module): <title>` bug fix (_patch_)\r\n * `feat(module): <title>` feature/capability (_minor_)\r\n * `chore(module): <title> ` won't appear in changelog\r\n * `build(module): <title>` won't appear in changelog\r\n- [x] __Title format__: Title uses lower case and doesn't end with a period\r\n- [x] __Breaking change?__: Last paragraph of description is: `BREAKING CHANGE: <describe exactly what changed and how to achieve similar behavior + link to documentation/gist/issue if more details are required>`\r\n- [x] __References__: Indicate issues fixed via: `Fixes #xxx` or `Closes #xxx`\r\n\r\n----\r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.\r\n","created_at":"2018-12-19T23:16:59Z","updated_at":"2018-12-20T09:02:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b07dbd37cc2fea661c87cdafad63f9740229d14","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/awslabs/aws-cdk/pulls/1407/commits","review_comments_url":"https://api.github.com/repos/awslabs/aws-cdk/pulls/1407/comments","review_comment_url":"https://api.github.com/repos/awslabs/aws-cdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/awslabs/aws-cdk/issues/1407/comments","statuses_url":"https://api.github.com/repos/awslabs/aws-cdk/statuses/2dca7b080adf1d397c7a5d28d01da5e9670f4b1b","head":{"label":"awslabs:benisrae/cfn-update","ref":"benisrae/cfn-update","sha":"2dca7b080adf1d397c7a5d28d01da5e9670f4b1b","user":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":105808767,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU4MDg3Njc=","name":"aws-cdk","full_name":"awslabs/aws-cdk","private":false,"owner":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/awslabs/aws-cdk","description":"The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code","fork":false,"url":"https://api.github.com/repos/awslabs/aws-cdk","forks_url":"https://api.github.com/repos/awslabs/aws-cdk/forks","keys_url":"https://api.github.com/repos/awslabs/aws-cdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awslabs/aws-cdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awslabs/aws-cdk/teams","hooks_url":"https://api.github.com/repos/awslabs/aws-cdk/hooks","issue_events_url":"https://api.github.com/repos/awslabs/aws-cdk/issues/events{/number}","events_url":"https://api.github.com/repos/awslabs/aws-cdk/events","assignees_url":"https://api.github.com/repos/awslabs/aws-cdk/assignees{/user}","branches_url":"https://api.github.com/repos/awslabs/aws-cdk/branches{/branch}","tags_url":"https://api.github.com/repos/awslabs/aws-cdk/tags","blobs_url":"https://api.github.com/repos/awslabs/aws-cdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awslabs/aws-cdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awslabs/aws-cdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/awslabs/aws-cdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awslabs/aws-cdk/statuses/{sha}","languages_url":"https://api.github.com/repos/awslabs/aws-cdk/languages","stargazers_url":"https://api.github.com/repos/awslabs/aws-cdk/stargazers","contributors_url":"https://api.github.com/repos/awslabs/aws-cdk/contributors","subscribers_url":"https://api.github.com/repos/awslabs/aws-cdk/subscribers","subscription_url":"https://api.github.com/repos/awslabs/aws-cdk/subscription","commits_url":"https://api.github.com/repos/awslabs/aws-cdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/awslabs/aws-cdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/awslabs/aws-cdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/awslabs/aws-cdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/awslabs/aws-cdk/contents/{+path}","compare_url":"https://api.github.com/repos/awslabs/aws-cdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awslabs/aws-cdk/merges","archive_url":"https://api.github.com/repos/awslabs/aws-cdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awslabs/aws-cdk/downloads","issues_url":"https://api.github.com/repos/awslabs/aws-cdk/issues{/number}","pulls_url":"https://api.github.com/repos/awslabs/aws-cdk/pulls{/number}","milestones_url":"https://api.github.com/repos/awslabs/aws-cdk/milestones{/number}","notifications_url":"https://api.github.com/repos/awslabs/aws-cdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awslabs/aws-cdk/labels{/name}","releases_url":"https://api.github.com/repos/awslabs/aws-cdk/releases{/id}","deployments_url":"https://api.github.com/repos/awslabs/aws-cdk/deployments","created_at":"2017-10-04T19:22:36Z","updated_at":"2018-12-20T08:13:28Z","pushed_at":"2018-12-20T08:13:23Z","git_url":"git://github.com/awslabs/aws-cdk.git","ssh_url":"[email protected]:awslabs/aws-cdk.git","clone_url":"https://github.com/awslabs/aws-cdk.git","svn_url":"https://github.com/awslabs/aws-cdk","homepage":"https://awslabs.github.io/aws-cdk","size":157481,"stargazers_count":1363,"watchers_count":1363,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":132,"mirror_url":null,"archived":false,"open_issues_count":339,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":132,"open_issues":339,"watchers":1363,"default_branch":"master"}},"base":{"label":"awslabs:master","ref":"master","sha":"d5cae6103d07838b911d123e8078d0b2ff5c6bed","user":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":105808767,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU4MDg3Njc=","name":"aws-cdk","full_name":"awslabs/aws-cdk","private":false,"owner":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/awslabs/aws-cdk","description":"The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code","fork":false,"url":"https://api.github.com/repos/awslabs/aws-cdk","forks_url":"https://api.github.com/repos/awslabs/aws-cdk/forks","keys_url":"https://api.github.com/repos/awslabs/aws-cdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awslabs/aws-cdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awslabs/aws-cdk/teams","hooks_url":"https://api.github.com/repos/awslabs/aws-cdk/hooks","issue_events_url":"https://api.github.com/repos/awslabs/aws-cdk/issues/events{/number}","events_url":"https://api.github.com/repos/awslabs/aws-cdk/events","assignees_url":"https://api.github.com/repos/awslabs/aws-cdk/assignees{/user}","branches_url":"https://api.github.com/repos/awslabs/aws-cdk/branches{/branch}","tags_url":"https://api.github.com/repos/awslabs/aws-cdk/tags","blobs_url":"https://api.github.com/repos/awslabs/aws-cdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awslabs/aws-cdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awslabs/aws-cdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/awslabs/aws-cdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awslabs/aws-cdk/statuses/{sha}","languages_url":"https://api.github.com/repos/awslabs/aws-cdk/languages","stargazers_url":"https://api.github.com/repos/awslabs/aws-cdk/stargazers","contributors_url":"https://api.github.com/repos/awslabs/aws-cdk/contributors","subscribers_url":"https://api.github.com/repos/awslabs/aws-cdk/subscribers","subscription_url":"https://api.github.com/repos/awslabs/aws-cdk/subscription","commits_url":"https://api.github.com/repos/awslabs/aws-cdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/awslabs/aws-cdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/awslabs/aws-cdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/awslabs/aws-cdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/awslabs/aws-cdk/contents/{+path}","compare_url":"https://api.github.com/repos/awslabs/aws-cdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awslabs/aws-cdk/merges","archive_url":"https://api.github.com/repos/awslabs/aws-cdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awslabs/aws-cdk/downloads","issues_url":"https://api.github.com/repos/awslabs/aws-cdk/issues{/number}","pulls_url":"https://api.github.com/repos/awslabs/aws-cdk/pulls{/number}","milestones_url":"https://api.github.com/repos/awslabs/aws-cdk/milestones{/number}","notifications_url":"https://api.github.com/repos/awslabs/aws-cdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awslabs/aws-cdk/labels{/name}","releases_url":"https://api.github.com/repos/awslabs/aws-cdk/releases{/id}","deployments_url":"https://api.github.com/repos/awslabs/aws-cdk/deployments","created_at":"2017-10-04T19:22:36Z","updated_at":"2018-12-20T08:13:28Z","pushed_at":"2018-12-20T08:13:23Z","git_url":"git://github.com/awslabs/aws-cdk.git","ssh_url":"[email protected]:awslabs/aws-cdk.git","clone_url":"https://github.com/awslabs/aws-cdk.git","svn_url":"https://github.com/awslabs/aws-cdk","homepage":"https://awslabs.github.io/aws-cdk","size":157481,"stargazers_count":1363,"watchers_count":1363,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":132,"mirror_url":null,"archived":false,"open_issues_count":339,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":132,"open_issues":339,"watchers":1363,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/awslabs/aws-cdk/pulls/1407"},"html":{"href":"https://github.com/awslabs/aws-cdk/pull/1407"},"issue":{"href":"https://api.github.com/repos/awslabs/aws-cdk/issues/1407"},"comments":{"href":"https://api.github.com/repos/awslabs/aws-cdk/issues/1407/comments"},"review_comments":{"href":"https://api.github.com/repos/awslabs/aws-cdk/pulls/1407/comments"},"review_comment":{"href":"https://api.github.com/repos/awslabs/aws-cdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/awslabs/aws-cdk/pulls/1407/commits"},"statuses":{"href":"https://api.github.com/repos/awslabs/aws-cdk/statuses/2dca7b080adf1d397c7a5d28d01da5e9670f4b1b"}},"author_association":"CONTRIBUTOR"}} | {
"id": 105808767,
"name": "awslabs/aws-cdk",
"url": "https://api.github.com/repos/awslabs/aws-cdk"
} | {
"id": 598796,
"login": "eladb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/598796?",
"url": "https://api.github.com/users/eladb"
} | {
"id": 3299148,
"login": "awslabs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3299148?",
"url": "https://api.github.com/orgs/awslabs"
} | 2018-12-20T09:02:42 | 8784166594 | {"actor":{"display_login":"eladb"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/comments/215803231","pull_request_review_id":153152553,"id":215803231,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTgwMzIzMQ==","diff_hunk":"@@ -7,53 +7,180 @@\n # on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either\n # express or implied. See the License for the specific language governing\n # permissions and limitations under the License.\n+\n \"\"\"\n-Download and extract the model archivefiles\n+Model loader.\n \"\"\"\n-import os\n+import inspect\n import json\n+import os\n+import sys\n+import importlib\n+from abc import ABCMeta, abstractmethod\n \n-from mms.log import get_logger\n-\n-logger = get_logger()\n+from mms.service import Service\n+from mms.model_service.mxnet_model_service import SingleNodeService\n+from mms.log import log_error\n \n MANIFEST_FILENAME = 'MANIFEST.json'\n \n+class ModelLoaderFactory(object):\n+ \"\"\"\n+ ModelLoaderFactory\n+ \"\"\"\n+\n+ @staticmethod\n+ def get_model_loader(service_type):\n+ if service_type == \"mms\":\n+ return MmsModelLoader()\n+ elif service_type == \"legacy_mms\":\n+ return LegacyModelLoader()\n+ else:\n+ raise ValueError(\"Unknown model loader type: {}\".format(service_type))\n+\n \n class ModelLoader(object):\n \"\"\"\n- Model Loader\n+ Base Model Loader class.\n \"\"\"\n+ __metaclass__ = ABCMeta\n+\n+ @abstractmethod\n+ def load(self, model_name, model_dir, handler, gpu_id, batch_size):\n+ \"\"\"\n+ Load model from file.\n+\n+ :param model_name:\n+ :param model_dir:\n+ :param handler:\n+ :param gpu_id:\n+ :param batch_size:\n+ :return: Model\n+ \"\"\"\n+ pass\n+\n @staticmethod\n- def load(model_dir, handler):\n+ def list_model_services(module, parent_class=None):\n+ \"\"\"\n+ Parse user defined module to get all model service classes in it.\n+\n+ :param module:\n+ :param parent_class:\n+ :return: List of model service class definitions\n \"\"\"\n- Load models\n \n- Parameters\n- ----------\n- model_dir : str\n- Model path\n- handler : str\n- Model entry point service handler file name\n+ # Parsing the module to get all defined classes\n+ classes = [cls[1] for cls in inspect.getmembers(module, lambda member: inspect.isclass(member) and\n+ member.__module__ == module.__name__)]\n+ print(classes)\n+ # filter classes that is subclass of parent_class\n+ if parent_class is not None:\n+ return [c for c in classes if issubclass(c, parent_class)]\n+ else:\n+ return classes\n \n- Returns\n- ----------\n- map\n- Model manifest\n+\n+class MmsModelLoader(ModelLoader):\n+ \"\"\"\n+ MMS 1.0 Model Loader\n+ \"\"\"\n+\n+ def load(self, model_name, model_dir, handler, gpu_id, batch_size):\n \"\"\"\n- manifest_file = os.path.join(model_dir, \"MANIFEST.legacy\")\n- if os.path.isfile(manifest_file):\n- manifest = json.load(open(manifest_file))\n+ Load MMS 1.0 model from file.\n+\n+ :param model_name:\n+ :param model_dir:\n+ :param handler:\n+ :param gpu_id:\n+ :param batch_size:\n+ :return:\n+ \"\"\"\n+ manifest_file = os.path.join(model_dir, MANIFEST_FILENAME)\n+ manifest = None\n+ if os.path.exists(manifest_file):\n+ with open(manifest_file) as f:\n+ manifest = json.load(f)\n+\n+ temp = handler.split(':', 1)\n+ module_name = temp[0]\n+ function_name = None\n+ if len(temp) == 2:\n+ function_name = temp[1]\n+ module = None\n+ module = importlib.import_module(module_name)\n+ if module is None:\n+ raise Exception(\"Unable to load module {}, make sure it is added to python path\".format(module_name))\n+ if function_name is None:\n+ function_name = \"handle\"\n+ print(function_name)\n+ if hasattr(module, function_name):\n+ entry_point = getattr(module, function_name)\n+ service = Service(model_name, model_dir, manifest, entry_point, gpu_id, batch_size)\n else:\n- manifest_file = os.path.join(model_dir, MANIFEST_FILENAME)\n- manifest = json.load(open(manifest_file))\n+ model_class_definitions = ModelLoader.list_model_services(module)\n+ if len(model_class_definitions) != 1:\n+ raise Exception(\"Expected only one class in custom service code or a function entry point\")\n+ model_class = model_class_definitions[0]\n+ model_service = model_class()\n+ handle = getattr(model_service, \"handle\")\n+ if handle is None:\n+ raise Exception(\"Expect handle method in class {}\".format(str(model_class)))\n+ service = Service(model_name, model_dir, manifest, model_service.handle, gpu_id, batch_size)\n+ initialize = getattr(model_service, \"initialize\")\n+ if initialize is not None:\n+ # noinspection PyBroadException\n+ try:\n+ model_service.initialize()\n+ # pylint: disable=broad-except\n+ except Exception as e:\n+ log_error(\"Error during initialize in custom service class {}\".format(str(e)))\n \n- if handler is None:\n- raise Exception('No handler is provided.')\n+ return service\n \n- handler_file = os.path.join(model_dir, handler)\n- if not os.path.isfile(handler_file):\n- # TODO: search PYTHONPATH and MODELPATH for handler file\n- raise Exception(\"handler file not not found: {}.\".format(handler_file))\n \n- return manifest, handler_file\n+class LegacyModelLoader(ModelLoader):\n+ \"\"\"\n+ MMS 0.4 Model Loader\n+ \"\"\"\n+\n+ def load(self, model_name, model_dir, handler, gpu_id, batch_size):\n+ \"\"\"\n+ Load MMS 1.0 model from file.\n+\n+ :param model_name:\n+ :param model_dir:\n+ :param handler:\n+ :param gpu_id:\n+ :param batch_size:\n+ :return:\n+ \"\"\"\n+ manifest_file = os.path.join(model_dir, 'MANIFEST.legacy')\n+ print(\"loading manifest\")\n+ with open(manifest_file) as f:\n+ manifest = json.load(f)\n+ print(\"done manifest\")\n+ if not handler.endswith(\".py\"):\n+ handler = handler + \".py\"\n+\n+ service_file = os.path.join(model_dir, handler)\n+ name = os.path.splitext(os.path.basename(service_file))[0]\n+ module = None\n+ print(\"loading module\")\n+ print(name, service_file)\n+ if sys.version_info[0] > 2:\n+ spec = importlib.util.spec_from_file_location(name, service_file)\n+ module = importlib.util.module_from_spec(spec)\n+ spec.loader.exec_module(module)\n+\n+ else:\n+ import imp\n+ module = imp.load_source(name, service_file)\n+ if module is None:\n+ raise Exception(\"Unable to load module {}\".format(service_file))","path":"mms/model_loader.py","position":210,"original_position":210,"commit_id":"28bc15fc762cfc4b49fdb5f26dbf80e5f8812a4a","original_commit_id":"28bc15fc762cfc4b49fdb5f26dbf80e5f8812a4a","user":{"login":"piyushghai","id":7931019,"node_id":"MDQ6VXNlcjc5MzEwMTk=","avatar_url":"https://avatars1.githubusercontent.com/u/7931019?v=4","gravatar_id":"","url":"https://api.github.com/users/piyushghai","html_url":"https://github.com/piyushghai","followers_url":"https://api.github.com/users/piyushghai/followers","following_url":"https://api.github.com/users/piyushghai/following{/other_user}","gists_url":"https://api.github.com/users/piyushghai/gists{/gist_id}","starred_url":"https://api.github.com/users/piyushghai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piyushghai/subscriptions","organizations_url":"https://api.github.com/users/piyushghai/orgs","repos_url":"https://api.github.com/users/piyushghai/repos","events_url":"https://api.github.com/users/piyushghai/events{/privacy}","received_events_url":"https://api.github.com/users/piyushghai/received_events","type":"User","site_admin":false},"body":"MMS Exception","created_at":"2018-09-06T23:00:53Z","updated_at":"2018-09-06T23:03:11Z","html_url":"https://github.com/awslabs/mxnet-model-server/pull/507#discussion_r215803231","pull_request_url":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/507","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/comments/215803231"},"html":{"href":"https://github.com/awslabs/mxnet-model-server/pull/507#discussion_r215803231"},"pull_request":{"href":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/507"}}},"pull_request":{"url":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/507","id":212872779,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyODcyNzc5","html_url":"https://github.com/awslabs/mxnet-model-server/pull/507","diff_url":"https://github.com/awslabs/mxnet-model-server/pull/507.diff","patch_url":"https://github.com/awslabs/mxnet-model-server/pull/507.patch","issue_url":"https://api.github.com/repos/awslabs/mxnet-model-server/issues/507","number":507,"state":"open","locked":false,"title":"Added Support for v1.0 model archive spec entry points","user":{"login":"vrakesh","id":13260794,"node_id":"MDQ6VXNlcjEzMjYwNzk0","avatar_url":"https://avatars3.githubusercontent.com/u/13260794?v=4","gravatar_id":"","url":"https://api.github.com/users/vrakesh","html_url":"https://github.com/vrakesh","followers_url":"https://api.github.com/users/vrakesh/followers","following_url":"https://api.github.com/users/vrakesh/following{/other_user}","gists_url":"https://api.github.com/users/vrakesh/gists{/gist_id}","starred_url":"https://api.github.com/users/vrakesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrakesh/subscriptions","organizations_url":"https://api.github.com/users/vrakesh/orgs","repos_url":"https://api.github.com/users/vrakesh/repos","events_url":"https://api.github.com/users/vrakesh/events{/privacy}","received_events_url":"https://api.github.com/users/vrakesh/received_events","type":"User","site_admin":false},"body":"1.Support for custom class with handler method.\r\n2.Support for custom function entry point\r\n\r\n*Issue #, if available:*\r\n\r\n*Description of changes:*\r\n\r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.\r\n","created_at":"2018-09-04T06:57:32Z","updated_at":"2018-09-06T23:03:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"03460dba45fadf1c52760c5d9874c113f8865e22","assignee":null,"assignees":[],"requested_reviewers":[{"login":"zachgk","id":1329299,"node_id":"MDQ6VXNlcjEzMjkyOTk=","avatar_url":"https://avatars1.githubusercontent.com/u/1329299?v=4","gravatar_id":"","url":"https://api.github.com/users/zachgk","html_url":"https://github.com/zachgk","followers_url":"https://api.github.com/users/zachgk/followers","following_url":"https://api.github.com/users/zachgk/following{/other_user}","gists_url":"https://api.github.com/users/zachgk/gists{/gist_id}","starred_url":"https://api.github.com/users/zachgk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zachgk/subscriptions","organizations_url":"https://api.github.com/users/zachgk/orgs","repos_url":"https://api.github.com/users/zachgk/repos","events_url":"https://api.github.com/users/zachgk/events{/privacy}","received_events_url":"https://api.github.com/users/zachgk/received_events","type":"User","site_admin":false},{"login":"vdantu","id":36211508,"node_id":"MDQ6VXNlcjM2MjExNTA4","avatar_url":"https://avatars1.githubusercontent.com/u/36211508?v=4","gravatar_id":"","url":"https://api.github.com/users/vdantu","html_url":"https://github.com/vdantu","followers_url":"https://api.github.com/users/vdantu/followers","following_url":"https://api.github.com/users/vdantu/following{/other_user}","gists_url":"https://api.github.com/users/vdantu/gists{/gist_id}","starred_url":"https://api.github.com/users/vdantu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdantu/subscriptions","organizations_url":"https://api.github.com/users/vdantu/orgs","repos_url":"https://api.github.com/users/vdantu/repos","events_url":"https://api.github.com/users/vdantu/events{/privacy}","received_events_url":"https://api.github.com/users/vdantu/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/507/commits","review_comments_url":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/507/comments","review_comment_url":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/awslabs/mxnet-model-server/issues/507/comments","statuses_url":"https://api.github.com/repos/awslabs/mxnet-model-server/statuses/28bc15fc762cfc4b49fdb5f26dbf80e5f8812a4a","head":{"label":"vrakesh:entry_point_update","ref":"entry_point_update","sha":"28bc15fc762cfc4b49fdb5f26dbf80e5f8812a4a","user":{"login":"vrakesh","id":13260794,"node_id":"MDQ6VXNlcjEzMjYwNzk0","avatar_url":"https://avatars3.githubusercontent.com/u/13260794?v=4","gravatar_id":"","url":"https://api.github.com/users/vrakesh","html_url":"https://github.com/vrakesh","followers_url":"https://api.github.com/users/vrakesh/followers","following_url":"https://api.github.com/users/vrakesh/following{/other_user}","gists_url":"https://api.github.com/users/vrakesh/gists{/gist_id}","starred_url":"https://api.github.com/users/vrakesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrakesh/subscriptions","organizations_url":"https://api.github.com/users/vrakesh/orgs","repos_url":"https://api.github.com/users/vrakesh/repos","events_url":"https://api.github.com/users/vrakesh/events{/privacy}","received_events_url":"https://api.github.com/users/vrakesh/received_events","type":"User","site_admin":false},"repo":{"id":127979033,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc5NzkwMzM=","name":"mxnet-model-server","full_name":"vrakesh/mxnet-model-server","owner":{"login":"vrakesh","id":13260794,"node_id":"MDQ6VXNlcjEzMjYwNzk0","avatar_url":"https://avatars3.githubusercontent.com/u/13260794?v=4","gravatar_id":"","url":"https://api.github.com/users/vrakesh","html_url":"https://github.com/vrakesh","followers_url":"https://api.github.com/users/vrakesh/followers","following_url":"https://api.github.com/users/vrakesh/following{/other_user}","gists_url":"https://api.github.com/users/vrakesh/gists{/gist_id}","starred_url":"https://api.github.com/users/vrakesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrakesh/subscriptions","organizations_url":"https://api.github.com/users/vrakesh/orgs","repos_url":"https://api.github.com/users/vrakesh/repos","events_url":"https://api.github.com/users/vrakesh/events{/privacy}","received_events_url":"https://api.github.com/users/vrakesh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vrakesh/mxnet-model-server","description":"Model Server for Apache MXNet is a tool for serving neural net models for inference","fork":true,"url":"https://api.github.com/repos/vrakesh/mxnet-model-server","forks_url":"https://api.github.com/repos/vrakesh/mxnet-model-server/forks","keys_url":"https://api.github.com/repos/vrakesh/mxnet-model-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vrakesh/mxnet-model-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vrakesh/mxnet-model-server/teams","hooks_url":"https://api.github.com/repos/vrakesh/mxnet-model-server/hooks","issue_events_url":"https://api.github.com/repos/vrakesh/mxnet-model-server/issues/events{/number}","events_url":"https://api.github.com/repos/vrakesh/mxnet-model-server/events","assignees_url":"https://api.github.com/repos/vrakesh/mxnet-model-server/assignees{/user}","branches_url":"https://api.github.com/repos/vrakesh/mxnet-model-server/branches{/branch}","tags_url":"https://api.github.com/repos/vrakesh/mxnet-model-server/tags","blobs_url":"https://api.github.com/repos/vrakesh/mxnet-model-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vrakesh/mxnet-model-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vrakesh/mxnet-model-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/vrakesh/mxnet-model-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vrakesh/mxnet-model-server/statuses/{sha}","languages_url":"https://api.github.com/repos/vrakesh/mxnet-model-server/languages","stargazers_url":"https://api.github.com/repos/vrakesh/mxnet-model-server/stargazers","contributors_url":"https://api.github.com/repos/vrakesh/mxnet-model-server/contributors","subscribers_url":"https://api.github.com/repos/vrakesh/mxnet-model-server/subscribers","subscription_url":"https://api.github.com/repos/vrakesh/mxnet-model-server/subscription","commits_url":"https://api.github.com/repos/vrakesh/mxnet-model-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/vrakesh/mxnet-model-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/vrakesh/mxnet-model-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/vrakesh/mxnet-model-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/vrakesh/mxnet-model-server/contents/{+path}","compare_url":"https://api.github.com/repos/vrakesh/mxnet-model-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vrakesh/mxnet-model-server/merges","archive_url":"https://api.github.com/repos/vrakesh/mxnet-model-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vrakesh/mxnet-model-server/downloads","issues_url":"https://api.github.com/repos/vrakesh/mxnet-model-server/issues{/number}","pulls_url":"https://api.github.com/repos/vrakesh/mxnet-model-server/pulls{/number}","milestones_url":"https://api.github.com/repos/vrakesh/mxnet-model-server/milestones{/number}","notifications_url":"https://api.github.com/repos/vrakesh/mxnet-model-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vrakesh/mxnet-model-server/labels{/name}","releases_url":"https://api.github.com/repos/vrakesh/mxnet-model-server/releases{/id}","deployments_url":"https://api.github.com/repos/vrakesh/mxnet-model-server/deployments","created_at":"2018-04-03T23:09:44Z","updated_at":"2018-06-20T18:13:11Z","pushed_at":"2018-09-06T21:46:32Z","git_url":"git://github.com/vrakesh/mxnet-model-server.git","ssh_url":"[email protected]:vrakesh/mxnet-model-server.git","clone_url":"https://github.com/vrakesh/mxnet-model-server.git","svn_url":"https://github.com/vrakesh/mxnet-model-server","homepage":"","size":36365,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"awslabs:netty","ref":"netty","sha":"df44fb179a462417f576dc2314ec124a87f93cc2","user":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":105830539,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU4MzA1Mzk=","name":"mxnet-model-server","full_name":"awslabs/mxnet-model-server","owner":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/awslabs/mxnet-model-server","description":"Model Server for Apache MXNet is a tool for serving neural net models for inference","fork":false,"url":"https://api.github.com/repos/awslabs/mxnet-model-server","forks_url":"https://api.github.com/repos/awslabs/mxnet-model-server/forks","keys_url":"https://api.github.com/repos/awslabs/mxnet-model-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awslabs/mxnet-model-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awslabs/mxnet-model-server/teams","hooks_url":"https://api.github.com/repos/awslabs/mxnet-model-server/hooks","issue_events_url":"https://api.github.com/repos/awslabs/mxnet-model-server/issues/events{/number}","events_url":"https://api.github.com/repos/awslabs/mxnet-model-server/events","assignees_url":"https://api.github.com/repos/awslabs/mxnet-model-server/assignees{/user}","branches_url":"https://api.github.com/repos/awslabs/mxnet-model-server/branches{/branch}","tags_url":"https://api.github.com/repos/awslabs/mxnet-model-server/tags","blobs_url":"https://api.github.com/repos/awslabs/mxnet-model-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awslabs/mxnet-model-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awslabs/mxnet-model-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/awslabs/mxnet-model-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awslabs/mxnet-model-server/statuses/{sha}","languages_url":"https://api.github.com/repos/awslabs/mxnet-model-server/languages","stargazers_url":"https://api.github.com/repos/awslabs/mxnet-model-server/stargazers","contributors_url":"https://api.github.com/repos/awslabs/mxnet-model-server/contributors","subscribers_url":"https://api.github.com/repos/awslabs/mxnet-model-server/subscribers","subscription_url":"https://api.github.com/repos/awslabs/mxnet-model-server/subscription","commits_url":"https://api.github.com/repos/awslabs/mxnet-model-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/awslabs/mxnet-model-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/awslabs/mxnet-model-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/awslabs/mxnet-model-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/awslabs/mxnet-model-server/contents/{+path}","compare_url":"https://api.github.com/repos/awslabs/mxnet-model-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awslabs/mxnet-model-server/merges","archive_url":"https://api.github.com/repos/awslabs/mxnet-model-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awslabs/mxnet-model-server/downloads","issues_url":"https://api.github.com/repos/awslabs/mxnet-model-server/issues{/number}","pulls_url":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls{/number}","milestones_url":"https://api.github.com/repos/awslabs/mxnet-model-server/milestones{/number}","notifications_url":"https://api.github.com/repos/awslabs/mxnet-model-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awslabs/mxnet-model-server/labels{/name}","releases_url":"https://api.github.com/repos/awslabs/mxnet-model-server/releases{/id}","deployments_url":"https://api.github.com/repos/awslabs/mxnet-model-server/deployments","created_at":"2017-10-04T23:41:07Z","updated_at":"2018-09-06T19:57:23Z","pushed_at":"2018-09-06T22:49:49Z","git_url":"git://github.com/awslabs/mxnet-model-server.git","ssh_url":"[email protected]:awslabs/mxnet-model-server.git","clone_url":"https://github.com/awslabs/mxnet-model-server.git","svn_url":"https://github.com/awslabs/mxnet-model-server","homepage":"","size":36317,"stargazers_count":306,"watchers_count":306,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":63,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":63,"open_issues":48,"watchers":306,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/507"},"html":{"href":"https://github.com/awslabs/mxnet-model-server/pull/507"},"issue":{"href":"https://api.github.com/repos/awslabs/mxnet-model-server/issues/507"},"comments":{"href":"https://api.github.com/repos/awslabs/mxnet-model-server/issues/507/comments"},"review_comments":{"href":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/507/comments"},"review_comment":{"href":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/507/commits"},"statuses":{"href":"https://api.github.com/repos/awslabs/mxnet-model-server/statuses/28bc15fc762cfc4b49fdb5f26dbf80e5f8812a4a"}},"author_association":"CONTRIBUTOR"}} | {
"id": 105830539,
"name": "awslabs/mxnet-model-server",
"url": "https://api.github.com/repos/awslabs/mxnet-model-server"
} | {
"id": 7931019,
"login": "piyushghai",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7931019?",
"url": "https://api.github.com/users/piyushghai"
} | {
"id": 3299148,
"login": "awslabs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3299148?",
"url": "https://api.github.com/orgs/awslabs"
} | 2018-09-06T23:00:53 | 8227432896 | {"actor":{"display_login":"piyushghai"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/comments/184512418","pull_request_review_id":115726023,"id":184512418,"diff_hunk":"@@ -20,6 +21,7 @@ def send_users_email(send_type):\n :param send_type\n :return:\n \"\"\"\n+ # Send emails to users, excluding reviews moderators","path":"website/notifications/tasks.py","position":18,"original_position":18,"commit_id":"3f9d432126896092f14077c92fc64eed686fa2cd","original_commit_id":"3f9d432126896092f14077c92fc64eed686fa2cd","user":{"login":"adlius","id":1566880,"avatar_url":"https://avatars0.githubusercontent.com/u/1566880?v=4","gravatar_id":"","url":"https://api.github.com/users/adlius","html_url":"https://github.com/adlius","followers_url":"https://api.github.com/users/adlius/followers","following_url":"https://api.github.com/users/adlius/following{/other_user}","gists_url":"https://api.github.com/users/adlius/gists{/gist_id}","starred_url":"https://api.github.com/users/adlius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adlius/subscriptions","organizations_url":"https://api.github.com/users/adlius/orgs","repos_url":"https://api.github.com/users/adlius/repos","events_url":"https://api.github.com/users/adlius/events{/privacy}","received_events_url":"https://api.github.com/users/adlius/received_events","type":"User","site_admin":false},"body":"That was actually an incorrect comment. Now it does send emails to moderators.","created_at":"2018-04-26T19:57:12Z","updated_at":"2018-04-26T19:57:12Z","html_url":"https://github.com/CenterForOpenScience/osf.io/pull/8326#discussion_r184512418","pull_request_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/8326","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/comments/184512418"},"html":{"href":"https://github.com/CenterForOpenScience/osf.io/pull/8326#discussion_r184512418"},"pull_request":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/8326"}},"in_reply_to_id":184506967},"pull_request":{"url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/8326","id":184426316,"html_url":"https://github.com/CenterForOpenScience/osf.io/pull/8326","diff_url":"https://github.com/CenterForOpenScience/osf.io/pull/8326.diff","patch_url":"https://github.com/CenterForOpenScience/osf.io/pull/8326.patch","issue_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/8326","number":8326,"state":"open","locked":false,"title":"[IN-229][OSF] Add email hooks and templates for reviews notifications.","user":{"login":"adlius","id":1566880,"avatar_url":"https://avatars0.githubusercontent.com/u/1566880?v=4","gravatar_id":"","url":"https://api.github.com/users/adlius","html_url":"https://github.com/adlius","followers_url":"https://api.github.com/users/adlius/followers","following_url":"https://api.github.com/users/adlius/following{/other_user}","gists_url":"https://api.github.com/users/adlius/gists{/gist_id}","starred_url":"https://api.github.com/users/adlius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adlius/subscriptions","organizations_url":"https://api.github.com/users/adlius/orgs","repos_url":"https://api.github.com/users/adlius/repos","events_url":"https://api.github.com/users/adlius/events{/privacy}","received_events_url":"https://api.github.com/users/adlius/received_events","type":"User","site_admin":false},"body":"## Purpose\r\n\r\nCurrently, no emails are sent to moderators/admins of a moderated preprint service upon preprint submission. This PR adds the functionality to automatically send emails to notify moderators/admins depending on their notification settings.\r\n\r\n## Changes\r\n\r\nSome background about the digest email workflow is needed for better understanding:\r\nThere are three settings for an `OSFUser`'s notification: instant, daily and none. `Instant` means the user would receive notification in digest form every five minutes, while `daily` means the user would be notified everyday at noon (also in digest form) if there are new activities. \r\nTwo cron tasks, `5-minute-emails` and `daily-emails` (see `website/settings/defaults.py`), are scheduled so that celery would periodically run `send_users_email('email_transactional')` and `send_users_email('email_digest')`, repesctively.\r\nWhen the celery task runs, it would try to fetch messages previously stored to be sent as digest by calling `get_user_emails()`, which would return an interable containing information derived from existing `NotificationDigest` instances, which were created and saved by calling `store_emails()`. These instances will be deleted at the end of the task by calling `remove_notifications()`.\r\n\r\nIn short, the workflow looks like this:\r\n`Action triggers a notification -> NotificationDigest instance is stored -> celery task periodically runs and retrieves information from existing NotificationDigest instances -> Digest email is compiled and sent -> NotificationDigest instances are deleted`\r\n\r\nTherefore, the following changes are made, in the order of the workflow described above.\r\n1. In `website/reviews/listeners.py`, a signal is added to invoke `store_emails()` when new preprint is submitted.\r\n - In `osf/utils/machines.py`, the signal is sent in `notify_submit()`\r\n - `store_emails()` has a new param `provider` so that it can store provider relationship with the newly added `provider` field of the `NotificationDigest` model.\r\n2. In `website/notifications/tasks.py`, `send_users_email()` are modified so that it fetches all reviews-related email by calling `get_moderator_emails()` and send them.\r\n - `get_moderator_emails()` is added to return moderator related emails.\r\n - Query string of `get_user_emails()` is modified so that it excludes moderator related emails for better decoupling.\r\n3. New email templates are added. Existing templates are modified to show correct footer.\r\n\r\n## QA Notes\r\n\r\nSince this modifies `store_email()`, check and see if other digest notifications are still working.\r\nMake sure that emails are sent to moderators at the right time (at five-minute intervals and everyday at noon).\r\n\r\n## Side Effects\r\n\r\nNone\r\n\r\n## Ticket\r\n\r\nhttps://openscience.atlassian.net/browse/IN-229\r\n","created_at":"2018-04-26T18:29:10Z","updated_at":"2018-04-26T19:57:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9aa788f7ccce774067885820f5247b7108ee14fa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/8326/commits","review_comments_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/8326/comments","review_comment_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/8326/comments","statuses_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/statuses/3f9d432126896092f14077c92fc64eed686fa2cd","head":{"label":"adlius:IN-229_Add_email_for_reviews_notifications","ref":"IN-229_Add_email_for_reviews_notifications","sha":"3f9d432126896092f14077c92fc64eed686fa2cd","user":{"login":"adlius","id":1566880,"avatar_url":"https://avatars0.githubusercontent.com/u/1566880?v=4","gravatar_id":"","url":"https://api.github.com/users/adlius","html_url":"https://github.com/adlius","followers_url":"https://api.github.com/users/adlius/followers","following_url":"https://api.github.com/users/adlius/following{/other_user}","gists_url":"https://api.github.com/users/adlius/gists{/gist_id}","starred_url":"https://api.github.com/users/adlius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adlius/subscriptions","organizations_url":"https://api.github.com/users/adlius/orgs","repos_url":"https://api.github.com/users/adlius/repos","events_url":"https://api.github.com/users/adlius/events{/privacy}","received_events_url":"https://api.github.com/users/adlius/received_events","type":"User","site_admin":false},"repo":{"id":98200364,"name":"osf.io","full_name":"adlius/osf.io","owner":{"login":"adlius","id":1566880,"avatar_url":"https://avatars0.githubusercontent.com/u/1566880?v=4","gravatar_id":"","url":"https://api.github.com/users/adlius","html_url":"https://github.com/adlius","followers_url":"https://api.github.com/users/adlius/followers","following_url":"https://api.github.com/users/adlius/following{/other_user}","gists_url":"https://api.github.com/users/adlius/gists{/gist_id}","starred_url":"https://api.github.com/users/adlius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adlius/subscriptions","organizations_url":"https://api.github.com/users/adlius/orgs","repos_url":"https://api.github.com/users/adlius/repos","events_url":"https://api.github.com/users/adlius/events{/privacy}","received_events_url":"https://api.github.com/users/adlius/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adlius/osf.io","description":"Facilitating Open Science","fork":true,"url":"https://api.github.com/repos/adlius/osf.io","forks_url":"https://api.github.com/repos/adlius/osf.io/forks","keys_url":"https://api.github.com/repos/adlius/osf.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adlius/osf.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adlius/osf.io/teams","hooks_url":"https://api.github.com/repos/adlius/osf.io/hooks","issue_events_url":"https://api.github.com/repos/adlius/osf.io/issues/events{/number}","events_url":"https://api.github.com/repos/adlius/osf.io/events","assignees_url":"https://api.github.com/repos/adlius/osf.io/assignees{/user}","branches_url":"https://api.github.com/repos/adlius/osf.io/branches{/branch}","tags_url":"https://api.github.com/repos/adlius/osf.io/tags","blobs_url":"https://api.github.com/repos/adlius/osf.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adlius/osf.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adlius/osf.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/adlius/osf.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adlius/osf.io/statuses/{sha}","languages_url":"https://api.github.com/repos/adlius/osf.io/languages","stargazers_url":"https://api.github.com/repos/adlius/osf.io/stargazers","contributors_url":"https://api.github.com/repos/adlius/osf.io/contributors","subscribers_url":"https://api.github.com/repos/adlius/osf.io/subscribers","subscription_url":"https://api.github.com/repos/adlius/osf.io/subscription","commits_url":"https://api.github.com/repos/adlius/osf.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/adlius/osf.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/adlius/osf.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/adlius/osf.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/adlius/osf.io/contents/{+path}","compare_url":"https://api.github.com/repos/adlius/osf.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adlius/osf.io/merges","archive_url":"https://api.github.com/repos/adlius/osf.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adlius/osf.io/downloads","issues_url":"https://api.github.com/repos/adlius/osf.io/issues{/number}","pulls_url":"https://api.github.com/repos/adlius/osf.io/pulls{/number}","milestones_url":"https://api.github.com/repos/adlius/osf.io/milestones{/number}","notifications_url":"https://api.github.com/repos/adlius/osf.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adlius/osf.io/labels{/name}","releases_url":"https://api.github.com/repos/adlius/osf.io/releases{/id}","deployments_url":"https://api.github.com/repos/adlius/osf.io/deployments","created_at":"2017-07-24T14:32:59Z","updated_at":"2017-07-24T14:33:20Z","pushed_at":"2018-04-26T17:16:57Z","git_url":"git://github.com/adlius/osf.io.git","ssh_url":"[email protected]:adlius/osf.io.git","clone_url":"https://github.com/adlius/osf.io.git","svn_url":"https://github.com/adlius/osf.io","homepage":"https://osf.io","size":169405,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"CenterForOpenScience:develop","ref":"develop","sha":"f2a3f06c0e9196af9b4040509e1fccedc33812c1","user":{"login":"CenterForOpenScience","id":3344584,"avatar_url":"https://avatars1.githubusercontent.com/u/3344584?v=4","gravatar_id":"","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"repo":{"id":10199599,"name":"osf.io","full_name":"CenterForOpenScience/osf.io","owner":{"login":"CenterForOpenScience","id":3344584,"avatar_url":"https://avatars1.githubusercontent.com/u/3344584?v=4","gravatar_id":"","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CenterForOpenScience/osf.io","description":"Facilitating Open Science","fork":false,"url":"https://api.github.com/repos/CenterForOpenScience/osf.io","forks_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/forks","keys_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/teams","hooks_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/hooks","issue_events_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/events{/number}","events_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/events","assignees_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/assignees{/user}","branches_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/branches{/branch}","tags_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/tags","blobs_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/statuses/{sha}","languages_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/languages","stargazers_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/stargazers","contributors_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/contributors","subscribers_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/subscribers","subscription_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/subscription","commits_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/contents/{+path}","compare_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/merges","archive_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/downloads","issues_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues{/number}","pulls_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls{/number}","milestones_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/milestones{/number}","notifications_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/labels{/name}","releases_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/releases{/id}","deployments_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/deployments","created_at":"2013-05-21T15:53:37Z","updated_at":"2018-04-26T18:26:46Z","pushed_at":"2018-04-26T19:20:01Z","git_url":"git://github.com/CenterForOpenScience/osf.io.git","ssh_url":"[email protected]:CenterForOpenScience/osf.io.git","clone_url":"https://github.com/CenterForOpenScience/osf.io.git","svn_url":"https://github.com/CenterForOpenScience/osf.io","homepage":"https://osf.io","size":170182,"stargazers_count":436,"watchers_count":436,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":244,"mirror_url":null,"archived":false,"open_issues_count":228,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":244,"open_issues":228,"watchers":436,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/8326"},"html":{"href":"https://github.com/CenterForOpenScience/osf.io/pull/8326"},"issue":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/8326"},"comments":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/8326/comments"},"review_comments":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/8326/comments"},"review_comment":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/8326/commits"},"statuses":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/statuses/3f9d432126896092f14077c92fc64eed686fa2cd"}},"author_association":"CONTRIBUTOR"}} | {
"id": 10199599,
"name": "CenterForOpenScience/osf.io",
"url": "https://api.github.com/repos/CenterForOpenScience/osf.io"
} | {
"id": 1566880,
"login": "adlius",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1566880?",
"url": "https://api.github.com/users/adlius"
} | {
"id": 3344584,
"login": "CenterForOpenScience",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3344584?",
"url": "https://api.github.com/orgs/CenterForOpenScience"
} | 2018-04-26T19:57:12 | 7593626349 | {"actor":{"display_login":"adlius"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/LCOGT/banzai/pulls/comments/245016272","pull_request_review_id":189032335,"id":245016272,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTAxNjI3Mg==","diff_hunk":"@@ -337,10 +337,9 @@ def get_instrument(header, db_address=_DEFAULT_DB):\n \n def get_bpm_filename(instrument_id, ccdsum, db_address=_DEFAULT_DB):\n db_session = get_session(db_address=db_address)\n- bpm_query = db_session.query(CalibrationImage).filter(\n- CalibrationImage.type == 'BPM',\n- CalibrationImage.instrument_id == instrument_id,\n- cast(CalibrationImage.attributes['ccdsum'], String) == type_coerce(ccdsum, JSON))\n+ bpm_query = db_session.query(CalibrationImage).filter(CalibrationImage.type == 'BPM',\n+ CalibrationImage.instrument_id == instrument_id,\n+ CalibrationImage.attributes['ccdsum'] == type_coerce(ccdsum, JSON))","path":"banzai/dbs.py","position":22,"original_position":22,"commit_id":"42cc799e9d75dde653ed87c6b8b7ad2f2e4cba66","original_commit_id":"42cc799e9d75dde653ed87c6b8b7ad2f2e4cba66","user":{"login":"turnerm","id":6585693,"node_id":"MDQ6VXNlcjY1ODU2OTM=","avatar_url":"https://avatars2.githubusercontent.com/u/6585693?v=4","gravatar_id":"","url":"https://api.github.com/users/turnerm","html_url":"https://github.com/turnerm","followers_url":"https://api.github.com/users/turnerm/followers","following_url":"https://api.github.com/users/turnerm/following{/other_user}","gists_url":"https://api.github.com/users/turnerm/gists{/gist_id}","starred_url":"https://api.github.com/users/turnerm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turnerm/subscriptions","organizations_url":"https://api.github.com/users/turnerm/orgs","repos_url":"https://api.github.com/users/turnerm/repos","events_url":"https://api.github.com/users/turnerm/events{/privacy}","received_events_url":"https://api.github.com/users/turnerm/received_events","type":"User","site_admin":false},"body":"Are you sure you want to take remove `cast`? From [here](https://docs.sqlalchemy.org/en/latest/core/type_basics.html?highlight=json#sqlalchemy.types.JSON):\r\n>Index operations return an expression object whose type defaults to JSON by default, so that further JSON-oriented instructions may be called upon the result type. Note that there are backend-specific idiosyncracies here, including that the PostgreSQL database does not generally compare a “json” to a “json” structure without type casts. These idiosyncracies can be accommodated in a backend-neutral way by making explicit use of the cast() and type_coerce() constructs. Comparison of specific index elements of a JSON object to other objects works best if the left hand side is CAST to a string and the right hand side is rendered as a JSON string","created_at":"2019-01-03T14:32:12Z","updated_at":"2019-01-03T14:32:13Z","html_url":"https://github.com/LCOGT/banzai/pull/169#discussion_r245016272","pull_request_url":"https://api.github.com/repos/LCOGT/banzai/pulls/169","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/LCOGT/banzai/pulls/comments/245016272"},"html":{"href":"https://github.com/LCOGT/banzai/pull/169#discussion_r245016272"},"pull_request":{"href":"https://api.github.com/repos/LCOGT/banzai/pulls/169"}}},"pull_request":{"url":"https://api.github.com/repos/LCOGT/banzai/pulls/169","id":240598627,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNTk4NjI3","html_url":"https://github.com/LCOGT/banzai/pull/169","diff_url":"https://github.com/LCOGT/banzai/pull/169.diff","patch_url":"https://github.com/LCOGT/banzai/pull/169.patch","issue_url":"https://api.github.com/repos/LCOGT/banzai/issues/169","number":169,"state":"open","locked":false,"title":"Reafactor for BANZAI NRES","user":{"login":"cmccully","id":5331996,"node_id":"MDQ6VXNlcjUzMzE5OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/5331996?v=4","gravatar_id":"","url":"https://api.github.com/users/cmccully","html_url":"https://github.com/cmccully","followers_url":"https://api.github.com/users/cmccully/followers","following_url":"https://api.github.com/users/cmccully/following{/other_user}","gists_url":"https://api.github.com/users/cmccully/gists{/gist_id}","starred_url":"https://api.github.com/users/cmccully/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmccully/subscriptions","organizations_url":"https://api.github.com/users/cmccully/orgs","repos_url":"https://api.github.com/users/cmccully/repos","events_url":"https://api.github.com/users/cmccully/events{/privacy}","received_events_url":"https://api.github.com/users/cmccully/received_events","type":"User","site_admin":false},"body":"The master calibrations are now imported using the settings.FRAME_CLASS instead of being hard coded to images.Image. This required significant refactoring of the tests. The attributes in the db are now passed around as strings. Settings.py has been refactored to make it easier to override. ","created_at":"2018-12-21T23:26:36Z","updated_at":"2019-01-03T14:32:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"338fcd503453d7468206b1fc677bcd5c205d828c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/LCOGT/banzai/pulls/169/commits","review_comments_url":"https://api.github.com/repos/LCOGT/banzai/pulls/169/comments","review_comment_url":"https://api.github.com/repos/LCOGT/banzai/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LCOGT/banzai/issues/169/comments","statuses_url":"https://api.github.com/repos/LCOGT/banzai/statuses/42cc799e9d75dde653ed87c6b8b7ad2f2e4cba66","head":{"label":"LCOGT:feature/nres_settings_dbs","ref":"feature/nres_settings_dbs","sha":"42cc799e9d75dde653ed87c6b8b7ad2f2e4cba66","user":{"login":"LCOGT","id":3358238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNTgyMzg=","avatar_url":"https://avatars1.githubusercontent.com/u/3358238?v=4","gravatar_id":"","url":"https://api.github.com/users/LCOGT","html_url":"https://github.com/LCOGT","followers_url":"https://api.github.com/users/LCOGT/followers","following_url":"https://api.github.com/users/LCOGT/following{/other_user}","gists_url":"https://api.github.com/users/LCOGT/gists{/gist_id}","starred_url":"https://api.github.com/users/LCOGT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LCOGT/subscriptions","organizations_url":"https://api.github.com/users/LCOGT/orgs","repos_url":"https://api.github.com/users/LCOGT/repos","events_url":"https://api.github.com/users/LCOGT/events{/privacy}","received_events_url":"https://api.github.com/users/LCOGT/received_events","type":"Organization","site_admin":false},"repo":{"id":26836413,"node_id":"MDEwOlJlcG9zaXRvcnkyNjgzNjQxMw==","name":"banzai","full_name":"LCOGT/banzai","private":false,"owner":{"login":"LCOGT","id":3358238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNTgyMzg=","avatar_url":"https://avatars1.githubusercontent.com/u/3358238?v=4","gravatar_id":"","url":"https://api.github.com/users/LCOGT","html_url":"https://github.com/LCOGT","followers_url":"https://api.github.com/users/LCOGT/followers","following_url":"https://api.github.com/users/LCOGT/following{/other_user}","gists_url":"https://api.github.com/users/LCOGT/gists{/gist_id}","starred_url":"https://api.github.com/users/LCOGT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LCOGT/subscriptions","organizations_url":"https://api.github.com/users/LCOGT/orgs","repos_url":"https://api.github.com/users/LCOGT/repos","events_url":"https://api.github.com/users/LCOGT/events{/privacy}","received_events_url":"https://api.github.com/users/LCOGT/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/LCOGT/banzai","description":"Beautiful Algorithms to Normalize Zillions of Astronomical Images","fork":false,"url":"https://api.github.com/repos/LCOGT/banzai","forks_url":"https://api.github.com/repos/LCOGT/banzai/forks","keys_url":"https://api.github.com/repos/LCOGT/banzai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LCOGT/banzai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LCOGT/banzai/teams","hooks_url":"https://api.github.com/repos/LCOGT/banzai/hooks","issue_events_url":"https://api.github.com/repos/LCOGT/banzai/issues/events{/number}","events_url":"https://api.github.com/repos/LCOGT/banzai/events","assignees_url":"https://api.github.com/repos/LCOGT/banzai/assignees{/user}","branches_url":"https://api.github.com/repos/LCOGT/banzai/branches{/branch}","tags_url":"https://api.github.com/repos/LCOGT/banzai/tags","blobs_url":"https://api.github.com/repos/LCOGT/banzai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LCOGT/banzai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LCOGT/banzai/git/refs{/sha}","trees_url":"https://api.github.com/repos/LCOGT/banzai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LCOGT/banzai/statuses/{sha}","languages_url":"https://api.github.com/repos/LCOGT/banzai/languages","stargazers_url":"https://api.github.com/repos/LCOGT/banzai/stargazers","contributors_url":"https://api.github.com/repos/LCOGT/banzai/contributors","subscribers_url":"https://api.github.com/repos/LCOGT/banzai/subscribers","subscription_url":"https://api.github.com/repos/LCOGT/banzai/subscription","commits_url":"https://api.github.com/repos/LCOGT/banzai/commits{/sha}","git_commits_url":"https://api.github.com/repos/LCOGT/banzai/git/commits{/sha}","comments_url":"https://api.github.com/repos/LCOGT/banzai/comments{/number}","issue_comment_url":"https://api.github.com/repos/LCOGT/banzai/issues/comments{/number}","contents_url":"https://api.github.com/repos/LCOGT/banzai/contents/{+path}","compare_url":"https://api.github.com/repos/LCOGT/banzai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LCOGT/banzai/merges","archive_url":"https://api.github.com/repos/LCOGT/banzai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LCOGT/banzai/downloads","issues_url":"https://api.github.com/repos/LCOGT/banzai/issues{/number}","pulls_url":"https://api.github.com/repos/LCOGT/banzai/pulls{/number}","milestones_url":"https://api.github.com/repos/LCOGT/banzai/milestones{/number}","notifications_url":"https://api.github.com/repos/LCOGT/banzai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LCOGT/banzai/labels{/name}","releases_url":"https://api.github.com/repos/LCOGT/banzai/releases{/id}","deployments_url":"https://api.github.com/repos/LCOGT/banzai/deployments","created_at":"2014-11-19T00:11:47Z","updated_at":"2018-12-05T21:58:28Z","pushed_at":"2019-01-03T01:44:13Z","git_url":"git://github.com/LCOGT/banzai.git","ssh_url":"[email protected]:LCOGT/banzai.git","clone_url":"https://github.com/LCOGT/banzai.git","svn_url":"https://github.com/LCOGT/banzai","homepage":"","size":14840,"stargazers_count":12,"watchers_count":12,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":14,"open_issues":6,"watchers":12,"default_branch":"master"}},"base":{"label":"LCOGT:feature/refactor_dbs","ref":"feature/refactor_dbs","sha":"eb8bc531ae63aaab9c3af8187903f132b107f7ac","user":{"login":"LCOGT","id":3358238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNTgyMzg=","avatar_url":"https://avatars1.githubusercontent.com/u/3358238?v=4","gravatar_id":"","url":"https://api.github.com/users/LCOGT","html_url":"https://github.com/LCOGT","followers_url":"https://api.github.com/users/LCOGT/followers","following_url":"https://api.github.com/users/LCOGT/following{/other_user}","gists_url":"https://api.github.com/users/LCOGT/gists{/gist_id}","starred_url":"https://api.github.com/users/LCOGT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LCOGT/subscriptions","organizations_url":"https://api.github.com/users/LCOGT/orgs","repos_url":"https://api.github.com/users/LCOGT/repos","events_url":"https://api.github.com/users/LCOGT/events{/privacy}","received_events_url":"https://api.github.com/users/LCOGT/received_events","type":"Organization","site_admin":false},"repo":{"id":26836413,"node_id":"MDEwOlJlcG9zaXRvcnkyNjgzNjQxMw==","name":"banzai","full_name":"LCOGT/banzai","private":false,"owner":{"login":"LCOGT","id":3358238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNTgyMzg=","avatar_url":"https://avatars1.githubusercontent.com/u/3358238?v=4","gravatar_id":"","url":"https://api.github.com/users/LCOGT","html_url":"https://github.com/LCOGT","followers_url":"https://api.github.com/users/LCOGT/followers","following_url":"https://api.github.com/users/LCOGT/following{/other_user}","gists_url":"https://api.github.com/users/LCOGT/gists{/gist_id}","starred_url":"https://api.github.com/users/LCOGT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LCOGT/subscriptions","organizations_url":"https://api.github.com/users/LCOGT/orgs","repos_url":"https://api.github.com/users/LCOGT/repos","events_url":"https://api.github.com/users/LCOGT/events{/privacy}","received_events_url":"https://api.github.com/users/LCOGT/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/LCOGT/banzai","description":"Beautiful Algorithms to Normalize Zillions of Astronomical Images","fork":false,"url":"https://api.github.com/repos/LCOGT/banzai","forks_url":"https://api.github.com/repos/LCOGT/banzai/forks","keys_url":"https://api.github.com/repos/LCOGT/banzai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LCOGT/banzai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LCOGT/banzai/teams","hooks_url":"https://api.github.com/repos/LCOGT/banzai/hooks","issue_events_url":"https://api.github.com/repos/LCOGT/banzai/issues/events{/number}","events_url":"https://api.github.com/repos/LCOGT/banzai/events","assignees_url":"https://api.github.com/repos/LCOGT/banzai/assignees{/user}","branches_url":"https://api.github.com/repos/LCOGT/banzai/branches{/branch}","tags_url":"https://api.github.com/repos/LCOGT/banzai/tags","blobs_url":"https://api.github.com/repos/LCOGT/banzai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LCOGT/banzai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LCOGT/banzai/git/refs{/sha}","trees_url":"https://api.github.com/repos/LCOGT/banzai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LCOGT/banzai/statuses/{sha}","languages_url":"https://api.github.com/repos/LCOGT/banzai/languages","stargazers_url":"https://api.github.com/repos/LCOGT/banzai/stargazers","contributors_url":"https://api.github.com/repos/LCOGT/banzai/contributors","subscribers_url":"https://api.github.com/repos/LCOGT/banzai/subscribers","subscription_url":"https://api.github.com/repos/LCOGT/banzai/subscription","commits_url":"https://api.github.com/repos/LCOGT/banzai/commits{/sha}","git_commits_url":"https://api.github.com/repos/LCOGT/banzai/git/commits{/sha}","comments_url":"https://api.github.com/repos/LCOGT/banzai/comments{/number}","issue_comment_url":"https://api.github.com/repos/LCOGT/banzai/issues/comments{/number}","contents_url":"https://api.github.com/repos/LCOGT/banzai/contents/{+path}","compare_url":"https://api.github.com/repos/LCOGT/banzai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LCOGT/banzai/merges","archive_url":"https://api.github.com/repos/LCOGT/banzai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LCOGT/banzai/downloads","issues_url":"https://api.github.com/repos/LCOGT/banzai/issues{/number}","pulls_url":"https://api.github.com/repos/LCOGT/banzai/pulls{/number}","milestones_url":"https://api.github.com/repos/LCOGT/banzai/milestones{/number}","notifications_url":"https://api.github.com/repos/LCOGT/banzai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LCOGT/banzai/labels{/name}","releases_url":"https://api.github.com/repos/LCOGT/banzai/releases{/id}","deployments_url":"https://api.github.com/repos/LCOGT/banzai/deployments","created_at":"2014-11-19T00:11:47Z","updated_at":"2018-12-05T21:58:28Z","pushed_at":"2019-01-03T01:44:13Z","git_url":"git://github.com/LCOGT/banzai.git","ssh_url":"[email protected]:LCOGT/banzai.git","clone_url":"https://github.com/LCOGT/banzai.git","svn_url":"https://github.com/LCOGT/banzai","homepage":"","size":14840,"stargazers_count":12,"watchers_count":12,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":14,"open_issues":6,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LCOGT/banzai/pulls/169"},"html":{"href":"https://github.com/LCOGT/banzai/pull/169"},"issue":{"href":"https://api.github.com/repos/LCOGT/banzai/issues/169"},"comments":{"href":"https://api.github.com/repos/LCOGT/banzai/issues/169/comments"},"review_comments":{"href":"https://api.github.com/repos/LCOGT/banzai/pulls/169/comments"},"review_comment":{"href":"https://api.github.com/repos/LCOGT/banzai/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LCOGT/banzai/pulls/169/commits"},"statuses":{"href":"https://api.github.com/repos/LCOGT/banzai/statuses/42cc799e9d75dde653ed87c6b8b7ad2f2e4cba66"}},"author_association":"COLLABORATOR"}} | {
"id": 26836413,
"name": "LCOGT/banzai",
"url": "https://api.github.com/repos/LCOGT/banzai"
} | {
"id": 6585693,
"login": "turnerm",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6585693?",
"url": "https://api.github.com/users/turnerm"
} | {
"id": 3358238,
"login": "LCOGT",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3358238?",
"url": "https://api.github.com/orgs/LCOGT"
} | 2019-01-03T14:32:12 | 8828951745 | {"actor":{"display_login":"turnerm"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/LLK/scratch-paint/pulls/comments/217190728","pull_request_review_id":154845980,"id":217190728,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzE5MDcyOA==","diff_hunk":"@@ -97,7 +98,13 @@ class MoveTool {\n this.setSelectedItems();\n }\n onMouseDrag (event) {\n- const dragVector = event.point.subtract(event.downPoint);\n+ const point = event.point;\n+ if (event.point.x > ART_BOARD_WIDTH || event.point.y > ART_BOARD_HEIGHT ||\n+ event.point.x < 0 || event.point.y < 0) {\n+ point.x = Math.max(0, Math.min(point.x, ART_BOARD_WIDTH));","path":"src/helper/selection-tools/move-tool.js","position":16,"original_position":16,"commit_id":"5e3114856bce282fe8042f7f296386ba12cf010f","original_commit_id":"5e3114856bce282fe8042f7f296386ba12cf010f","user":{"login":"kchadha","id":1786240,"node_id":"MDQ6VXNlcjE3ODYyNDA=","avatar_url":"https://avatars2.githubusercontent.com/u/1786240?v=4","gravatar_id":"","url":"https://api.github.com/users/kchadha","html_url":"https://github.com/kchadha","followers_url":"https://api.github.com/users/kchadha/followers","following_url":"https://api.github.com/users/kchadha/following{/other_user}","gists_url":"https://api.github.com/users/kchadha/gists{/gist_id}","starred_url":"https://api.github.com/users/kchadha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kchadha/subscriptions","organizations_url":"https://api.github.com/users/kchadha/orgs","repos_url":"https://api.github.com/users/kchadha/repos","events_url":"https://api.github.com/users/kchadha/events{/privacy}","received_events_url":"https://api.github.com/users/kchadha/received_events","type":"User","site_admin":false},"body":"Do you need the big if statement given that you're doing `Math.max` and `Math.min`?","created_at":"2018-09-12T21:11:28Z","updated_at":"2018-09-12T21:11:28Z","html_url":"https://github.com/LLK/scratch-paint/pull/671#discussion_r217190728","pull_request_url":"https://api.github.com/repos/LLK/scratch-paint/pulls/671","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/LLK/scratch-paint/pulls/comments/217190728"},"html":{"href":"https://github.com/LLK/scratch-paint/pull/671#discussion_r217190728"},"pull_request":{"href":"https://api.github.com/repos/LLK/scratch-paint/pulls/671"}}},"pull_request":{"url":"https://api.github.com/repos/LLK/scratch-paint/pulls/671","id":214777324,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0Nzc3MzI0","html_url":"https://github.com/LLK/scratch-paint/pull/671","diff_url":"https://github.com/LLK/scratch-paint/pull/671.diff","patch_url":"https://github.com/LLK/scratch-paint/pull/671.patch","issue_url":"https://api.github.com/repos/LLK/scratch-paint/issues/671","number":671,"state":"open","locked":false,"title":"Fence tools to make it less easy to lose work off the sides","user":{"login":"fsih","id":2855464,"node_id":"MDQ6VXNlcjI4NTU0NjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2855464?v=4","gravatar_id":"","url":"https://api.github.com/users/fsih","html_url":"https://github.com/fsih","followers_url":"https://api.github.com/users/fsih/followers","following_url":"https://api.github.com/users/fsih/following{/other_user}","gists_url":"https://api.github.com/users/fsih/gists{/gist_id}","starred_url":"https://api.github.com/users/fsih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsih/subscriptions","organizations_url":"https://api.github.com/users/fsih/orgs","repos_url":"https://api.github.com/users/fsih/repos","events_url":"https://api.github.com/users/fsih/events{/privacy}","received_events_url":"https://api.github.com/users/fsih/received_events","type":"User","site_admin":false},"body":"### Resolves\r\nFixes https://github.com/LLK/scratch-paint/issues/166\r\n\r\n### Proposed Changes\r\nFence the move, move point (reshape), nudge, and scale tools to the canvas area.\r\nThis also adds super-nudge\r\n\r\n### Reason for Changes\r\nCurrently, it's easy to move shapes off the edges of the paint editor, which then become inaccessible but are still visible in the thumbnail and on stage, which can be confusing. These changes don't completely prevent moving items off the edges, but make it a more difficult state for beginners to get into.\r\n\r\n### Testing\r\nTry moving shapes off the paint editor bounds in the various tools in which you can move things, such as select, reshape, and shape tools, in bitmap and vector. Super-nudge is shift+arrow keys.","created_at":"2018-09-11T21:50:36Z","updated_at":"2018-09-12T21:11:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d124c30ff9dfafcfba47eca23bc5260ebee3941","assignee":{"login":"kchadha","id":1786240,"node_id":"MDQ6VXNlcjE3ODYyNDA=","avatar_url":"https://avatars2.githubusercontent.com/u/1786240?v=4","gravatar_id":"","url":"https://api.github.com/users/kchadha","html_url":"https://github.com/kchadha","followers_url":"https://api.github.com/users/kchadha/followers","following_url":"https://api.github.com/users/kchadha/following{/other_user}","gists_url":"https://api.github.com/users/kchadha/gists{/gist_id}","starred_url":"https://api.github.com/users/kchadha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kchadha/subscriptions","organizations_url":"https://api.github.com/users/kchadha/orgs","repos_url":"https://api.github.com/users/kchadha/repos","events_url":"https://api.github.com/users/kchadha/events{/privacy}","received_events_url":"https://api.github.com/users/kchadha/received_events","type":"User","site_admin":false},"assignees":[{"login":"kchadha","id":1786240,"node_id":"MDQ6VXNlcjE3ODYyNDA=","avatar_url":"https://avatars2.githubusercontent.com/u/1786240?v=4","gravatar_id":"","url":"https://api.github.com/users/kchadha","html_url":"https://github.com/kchadha","followers_url":"https://api.github.com/users/kchadha/followers","following_url":"https://api.github.com/users/kchadha/following{/other_user}","gists_url":"https://api.github.com/users/kchadha/gists{/gist_id}","starred_url":"https://api.github.com/users/kchadha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kchadha/subscriptions","organizations_url":"https://api.github.com/users/kchadha/orgs","repos_url":"https://api.github.com/users/kchadha/repos","events_url":"https://api.github.com/users/kchadha/events{/privacy}","received_events_url":"https://api.github.com/users/kchadha/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":649717852,"node_id":"MDU6TGFiZWw2NDk3MTc4NTI=","url":"https://api.github.com/repos/LLK/scratch-paint/labels/pr%20-%20needs%20review","name":"pr - needs review","color":"fbca04","default":false}],"milestone":{"url":"https://api.github.com/repos/LLK/scratch-paint/milestones/18","html_url":"https://github.com/LLK/scratch-paint/milestone/18","labels_url":"https://api.github.com/repos/LLK/scratch-paint/milestones/18/labels","id":3284469,"node_id":"MDk6TWlsZXN0b25lMzI4NDQ2OQ==","number":18,"title":"September 2018","description":"","creator":{"login":"thisandagain","id":747641,"node_id":"MDQ6VXNlcjc0NzY0MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/747641?v=4","gravatar_id":"","url":"https://api.github.com/users/thisandagain","html_url":"https://github.com/thisandagain","followers_url":"https://api.github.com/users/thisandagain/followers","following_url":"https://api.github.com/users/thisandagain/following{/other_user}","gists_url":"https://api.github.com/users/thisandagain/gists{/gist_id}","starred_url":"https://api.github.com/users/thisandagain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thisandagain/subscriptions","organizations_url":"https://api.github.com/users/thisandagain/orgs","repos_url":"https://api.github.com/users/thisandagain/repos","events_url":"https://api.github.com/users/thisandagain/events{/privacy}","received_events_url":"https://api.github.com/users/thisandagain/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":17,"state":"open","created_at":"2018-04-20T14:00:14Z","updated_at":"2018-09-12T19:39:12Z","due_on":"2018-09-30T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/LLK/scratch-paint/pulls/671/commits","review_comments_url":"https://api.github.com/repos/LLK/scratch-paint/pulls/671/comments","review_comment_url":"https://api.github.com/repos/LLK/scratch-paint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LLK/scratch-paint/issues/671/comments","statuses_url":"https://api.github.com/repos/LLK/scratch-paint/statuses/5e3114856bce282fe8042f7f296386ba12cf010f","head":{"label":"fsih:fencing","ref":"fencing","sha":"5e3114856bce282fe8042f7f296386ba12cf010f","user":{"login":"fsih","id":2855464,"node_id":"MDQ6VXNlcjI4NTU0NjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2855464?v=4","gravatar_id":"","url":"https://api.github.com/users/fsih","html_url":"https://github.com/fsih","followers_url":"https://api.github.com/users/fsih/followers","following_url":"https://api.github.com/users/fsih/following{/other_user}","gists_url":"https://api.github.com/users/fsih/gists{/gist_id}","starred_url":"https://api.github.com/users/fsih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsih/subscriptions","organizations_url":"https://api.github.com/users/fsih/orgs","repos_url":"https://api.github.com/users/fsih/repos","events_url":"https://api.github.com/users/fsih/events{/privacy}","received_events_url":"https://api.github.com/users/fsih/received_events","type":"User","site_admin":false},"repo":{"id":106751723,"node_id":"MDEwOlJlcG9zaXRvcnkxMDY3NTE3MjM=","name":"scratch-paint","full_name":"fsih/scratch-paint","owner":{"login":"fsih","id":2855464,"node_id":"MDQ6VXNlcjI4NTU0NjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2855464?v=4","gravatar_id":"","url":"https://api.github.com/users/fsih","html_url":"https://github.com/fsih","followers_url":"https://api.github.com/users/fsih/followers","following_url":"https://api.github.com/users/fsih/following{/other_user}","gists_url":"https://api.github.com/users/fsih/gists{/gist_id}","starred_url":"https://api.github.com/users/fsih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsih/subscriptions","organizations_url":"https://api.github.com/users/fsih/orgs","repos_url":"https://api.github.com/users/fsih/repos","events_url":"https://api.github.com/users/fsih/events{/privacy}","received_events_url":"https://api.github.com/users/fsih/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fsih/scratch-paint","description":null,"fork":true,"url":"https://api.github.com/repos/fsih/scratch-paint","forks_url":"https://api.github.com/repos/fsih/scratch-paint/forks","keys_url":"https://api.github.com/repos/fsih/scratch-paint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fsih/scratch-paint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fsih/scratch-paint/teams","hooks_url":"https://api.github.com/repos/fsih/scratch-paint/hooks","issue_events_url":"https://api.github.com/repos/fsih/scratch-paint/issues/events{/number}","events_url":"https://api.github.com/repos/fsih/scratch-paint/events","assignees_url":"https://api.github.com/repos/fsih/scratch-paint/assignees{/user}","branches_url":"https://api.github.com/repos/fsih/scratch-paint/branches{/branch}","tags_url":"https://api.github.com/repos/fsih/scratch-paint/tags","blobs_url":"https://api.github.com/repos/fsih/scratch-paint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fsih/scratch-paint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fsih/scratch-paint/git/refs{/sha}","trees_url":"https://api.github.com/repos/fsih/scratch-paint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fsih/scratch-paint/statuses/{sha}","languages_url":"https://api.github.com/repos/fsih/scratch-paint/languages","stargazers_url":"https://api.github.com/repos/fsih/scratch-paint/stargazers","contributors_url":"https://api.github.com/repos/fsih/scratch-paint/contributors","subscribers_url":"https://api.github.com/repos/fsih/scratch-paint/subscribers","subscription_url":"https://api.github.com/repos/fsih/scratch-paint/subscription","commits_url":"https://api.github.com/repos/fsih/scratch-paint/commits{/sha}","git_commits_url":"https://api.github.com/repos/fsih/scratch-paint/git/commits{/sha}","comments_url":"https://api.github.com/repos/fsih/scratch-paint/comments{/number}","issue_comment_url":"https://api.github.com/repos/fsih/scratch-paint/issues/comments{/number}","contents_url":"https://api.github.com/repos/fsih/scratch-paint/contents/{+path}","compare_url":"https://api.github.com/repos/fsih/scratch-paint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fsih/scratch-paint/merges","archive_url":"https://api.github.com/repos/fsih/scratch-paint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fsih/scratch-paint/downloads","issues_url":"https://api.github.com/repos/fsih/scratch-paint/issues{/number}","pulls_url":"https://api.github.com/repos/fsih/scratch-paint/pulls{/number}","milestones_url":"https://api.github.com/repos/fsih/scratch-paint/milestones{/number}","notifications_url":"https://api.github.com/repos/fsih/scratch-paint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fsih/scratch-paint/labels{/name}","releases_url":"https://api.github.com/repos/fsih/scratch-paint/releases{/id}","deployments_url":"https://api.github.com/repos/fsih/scratch-paint/deployments","created_at":"2017-10-12T22:27:50Z","updated_at":"2017-10-27T03:46:56Z","pushed_at":"2018-09-12T21:05:12Z","git_url":"git://github.com/fsih/scratch-paint.git","ssh_url":"[email protected]:fsih/scratch-paint.git","clone_url":"https://github.com/fsih/scratch-paint.git","svn_url":"https://github.com/fsih/scratch-paint","homepage":null,"size":3989,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"LLK:develop","ref":"develop","sha":"45018e4f645c9a936bae1c392790b620be97215c","user":{"login":"LLK","id":3420800,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MjA4MDA=","avatar_url":"https://avatars1.githubusercontent.com/u/3420800?v=4","gravatar_id":"","url":"https://api.github.com/users/LLK","html_url":"https://github.com/LLK","followers_url":"https://api.github.com/users/LLK/followers","following_url":"https://api.github.com/users/LLK/following{/other_user}","gists_url":"https://api.github.com/users/LLK/gists{/gist_id}","starred_url":"https://api.github.com/users/LLK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLK/subscriptions","organizations_url":"https://api.github.com/users/LLK/orgs","repos_url":"https://api.github.com/users/LLK/repos","events_url":"https://api.github.com/users/LLK/events{/privacy}","received_events_url":"https://api.github.com/users/LLK/received_events","type":"Organization","site_admin":false},"repo":{"id":97151235,"node_id":"MDEwOlJlcG9zaXRvcnk5NzE1MTIzNQ==","name":"scratch-paint","full_name":"LLK/scratch-paint","owner":{"login":"LLK","id":3420800,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MjA4MDA=","avatar_url":"https://avatars1.githubusercontent.com/u/3420800?v=4","gravatar_id":"","url":"https://api.github.com/users/LLK","html_url":"https://github.com/LLK","followers_url":"https://api.github.com/users/LLK/followers","following_url":"https://api.github.com/users/LLK/following{/other_user}","gists_url":"https://api.github.com/users/LLK/gists{/gist_id}","starred_url":"https://api.github.com/users/LLK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLK/subscriptions","organizations_url":"https://api.github.com/users/LLK/orgs","repos_url":"https://api.github.com/users/LLK/repos","events_url":"https://api.github.com/users/LLK/events{/privacy}","received_events_url":"https://api.github.com/users/LLK/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LLK/scratch-paint","description":"Vector paint editor for Scratch 3.0","fork":false,"url":"https://api.github.com/repos/LLK/scratch-paint","forks_url":"https://api.github.com/repos/LLK/scratch-paint/forks","keys_url":"https://api.github.com/repos/LLK/scratch-paint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LLK/scratch-paint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LLK/scratch-paint/teams","hooks_url":"https://api.github.com/repos/LLK/scratch-paint/hooks","issue_events_url":"https://api.github.com/repos/LLK/scratch-paint/issues/events{/number}","events_url":"https://api.github.com/repos/LLK/scratch-paint/events","assignees_url":"https://api.github.com/repos/LLK/scratch-paint/assignees{/user}","branches_url":"https://api.github.com/repos/LLK/scratch-paint/branches{/branch}","tags_url":"https://api.github.com/repos/LLK/scratch-paint/tags","blobs_url":"https://api.github.com/repos/LLK/scratch-paint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LLK/scratch-paint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LLK/scratch-paint/git/refs{/sha}","trees_url":"https://api.github.com/repos/LLK/scratch-paint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LLK/scratch-paint/statuses/{sha}","languages_url":"https://api.github.com/repos/LLK/scratch-paint/languages","stargazers_url":"https://api.github.com/repos/LLK/scratch-paint/stargazers","contributors_url":"https://api.github.com/repos/LLK/scratch-paint/contributors","subscribers_url":"https://api.github.com/repos/LLK/scratch-paint/subscribers","subscription_url":"https://api.github.com/repos/LLK/scratch-paint/subscription","commits_url":"https://api.github.com/repos/LLK/scratch-paint/commits{/sha}","git_commits_url":"https://api.github.com/repos/LLK/scratch-paint/git/commits{/sha}","comments_url":"https://api.github.com/repos/LLK/scratch-paint/comments{/number}","issue_comment_url":"https://api.github.com/repos/LLK/scratch-paint/issues/comments{/number}","contents_url":"https://api.github.com/repos/LLK/scratch-paint/contents/{+path}","compare_url":"https://api.github.com/repos/LLK/scratch-paint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LLK/scratch-paint/merges","archive_url":"https://api.github.com/repos/LLK/scratch-paint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LLK/scratch-paint/downloads","issues_url":"https://api.github.com/repos/LLK/scratch-paint/issues{/number}","pulls_url":"https://api.github.com/repos/LLK/scratch-paint/pulls{/number}","milestones_url":"https://api.github.com/repos/LLK/scratch-paint/milestones{/number}","notifications_url":"https://api.github.com/repos/LLK/scratch-paint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LLK/scratch-paint/labels{/name}","releases_url":"https://api.github.com/repos/LLK/scratch-paint/releases{/id}","deployments_url":"https://api.github.com/repos/LLK/scratch-paint/deployments","created_at":"2017-07-13T18:00:02Z","updated_at":"2018-09-12T17:21:58Z","pushed_at":"2018-09-12T20:49:37Z","git_url":"git://github.com/LLK/scratch-paint.git","ssh_url":"[email protected]:LLK/scratch-paint.git","clone_url":"https://github.com/LLK/scratch-paint.git","svn_url":"https://github.com/LLK/scratch-paint","homepage":"https://llk.github.io/scratch-paint/","size":50326,"stargazers_count":36,"watchers_count":36,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":35,"mirror_url":null,"archived":false,"open_issues_count":171,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":35,"open_issues":171,"watchers":36,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/LLK/scratch-paint/pulls/671"},"html":{"href":"https://github.com/LLK/scratch-paint/pull/671"},"issue":{"href":"https://api.github.com/repos/LLK/scratch-paint/issues/671"},"comments":{"href":"https://api.github.com/repos/LLK/scratch-paint/issues/671/comments"},"review_comments":{"href":"https://api.github.com/repos/LLK/scratch-paint/pulls/671/comments"},"review_comment":{"href":"https://api.github.com/repos/LLK/scratch-paint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LLK/scratch-paint/pulls/671/commits"},"statuses":{"href":"https://api.github.com/repos/LLK/scratch-paint/statuses/5e3114856bce282fe8042f7f296386ba12cf010f"}},"author_association":"MEMBER"}} | {
"id": 97151235,
"name": "LLK/scratch-paint",
"url": "https://api.github.com/repos/LLK/scratch-paint"
} | {
"id": 1786240,
"login": "kchadha",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1786240?",
"url": "https://api.github.com/users/kchadha"
} | {
"id": 3420800,
"login": "LLK",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3420800?",
"url": "https://api.github.com/orgs/LLK"
} | 2018-09-12T21:11:28 | 8255989132 | {"actor":{"display_login":"kchadha"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/mesosphere/marathon/pulls/comments/218884781","pull_request_review_id":156923893,"id":218884781,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODg4NDc4MQ==","diff_hunk":"@@ -0,0 +1,91 @@\n+#!/usr/bin/env amm\n+\n+import ammonite.ops._\n+import ammonite.ops.ImplicitWd._\n+\n+import scala.io.Source\n+import scala.util.Try\n+\n+import $file.utils\n+import utils.SemVer\n+\n+// output directory for all packages going to S3\n+val PACKAGE_DIR: Path = pwd / 'target / 'universal\n+// dcos catalog template directory\n+val TEMPLATE_DIR: Path = pwd / 'dcos\n+// versioned dcos catalog directory\n+val UNIVERSE_DIR: Path = pwd / 'target / 'dcos\n+\n+@main\n+def localBuild(version: String) {","path":"ci/dcos.sc","position":20,"original_position":20,"commit_id":"b255e9e0cb1afc20997068f9c1119449e96ab677","original_commit_id":"b255e9e0cb1afc20997068f9c1119449e96ab677","user":{"login":"timcharper","id":183,"node_id":"MDQ6VXNlcjE4Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/183?v=4","gravatar_id":"","url":"https://api.github.com/users/timcharper","html_url":"https://github.com/timcharper","followers_url":"https://api.github.com/users/timcharper/followers","following_url":"https://api.github.com/users/timcharper/following{/other_user}","gists_url":"https://api.github.com/users/timcharper/gists{/gist_id}","starred_url":"https://api.github.com/users/timcharper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timcharper/subscriptions","organizations_url":"https://api.github.com/users/timcharper/orgs","repos_url":"https://api.github.com/users/timcharper/repos","events_url":"https://api.github.com/users/timcharper/events{/privacy}","received_events_url":"https://api.github.com/users/timcharper/received_events","type":"User","site_admin":false},"body":"currently in `ci/pipeline`\r\n\r\n```\r\nimplicit val SemVerRead: scopt.Read[SemVer] =\r\n scopt.Read.reads(SemVer(_))\r\n```\r\n\r\nLet's move to `utils` so it can be shared?","created_at":"2018-09-19T17:00:14Z","updated_at":"2018-09-19T17:00:14Z","html_url":"https://github.com/mesosphere/marathon/pull/6538#discussion_r218884781","pull_request_url":"https://api.github.com/repos/mesosphere/marathon/pulls/6538","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/comments/218884781"},"html":{"href":"https://github.com/mesosphere/marathon/pull/6538#discussion_r218884781"},"pull_request":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/6538"}},"in_reply_to_id":218757403},"pull_request":{"url":"https://api.github.com/repos/mesosphere/marathon/pulls/6538","id":216455357,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NDU1MzU3","html_url":"https://github.com/mesosphere/marathon/pull/6538","diff_url":"https://github.com/mesosphere/marathon/pull/6538.diff","patch_url":"https://github.com/mesosphere/marathon/pull/6538.patch","issue_url":"https://api.github.com/repos/mesosphere/marathon/issues/6538","number":6538,"state":"open","locked":false,"title":"Build MoM to Soak without release to public universe","user":{"login":"kensipe","id":27497,"node_id":"MDQ6VXNlcjI3NDk3","avatar_url":"https://avatars2.githubusercontent.com/u/27497?v=4","gravatar_id":"","url":"https://api.github.com/users/kensipe","html_url":"https://github.com/kensipe","followers_url":"https://api.github.com/users/kensipe/followers","following_url":"https://api.github.com/users/kensipe/following{/other_user}","gists_url":"https://api.github.com/users/kensipe/gists{/gist_id}","starred_url":"https://api.github.com/users/kensipe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kensipe/subscriptions","organizations_url":"https://api.github.com/users/kensipe/orgs","repos_url":"https://api.github.com/users/kensipe/repos","events_url":"https://api.github.com/users/kensipe/events{/privacy}","received_events_url":"https://api.github.com/users/kensipe/received_events","type":"User","site_admin":false},"body":"Summary:\r\nBuild MoM to Soak without release to public universe\r\n\r\nJIRA issues: MARATHON-8363\r\n","created_at":"2018-09-18T21:52:30Z","updated_at":"2018-09-19T17:00:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f071a4ab106f570f51e42cb234b7f9f3d458806","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mesosphere/marathon/pulls/6538/commits","review_comments_url":"https://api.github.com/repos/mesosphere/marathon/pulls/6538/comments","review_comment_url":"https://api.github.com/repos/mesosphere/marathon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mesosphere/marathon/issues/6538/comments","statuses_url":"https://api.github.com/repos/mesosphere/marathon/statuses/b255e9e0cb1afc20997068f9c1119449e96ab677","head":{"label":"mesosphere:ken/dcos-packages","ref":"ken/dcos-packages","sha":"b255e9e0cb1afc20997068f9c1119449e96ab677","user":{"login":"mesosphere","id":3458585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTg1ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":10941409,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk0MTQwOQ==","name":"marathon","full_name":"mesosphere/marathon","private":false,"owner":{"login":"mesosphere","id":3458585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTg1ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mesosphere/marathon","description":"Deploy and manage containers (including Docker) on top of Apache Mesos at scale.","fork":false,"url":"https://api.github.com/repos/mesosphere/marathon","forks_url":"https://api.github.com/repos/mesosphere/marathon/forks","keys_url":"https://api.github.com/repos/mesosphere/marathon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/marathon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/marathon/teams","hooks_url":"https://api.github.com/repos/mesosphere/marathon/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/marathon/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/marathon/events","assignees_url":"https://api.github.com/repos/mesosphere/marathon/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/marathon/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/marathon/tags","blobs_url":"https://api.github.com/repos/mesosphere/marathon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/marathon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/marathon/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/marathon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/marathon/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/marathon/languages","stargazers_url":"https://api.github.com/repos/mesosphere/marathon/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/marathon/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/marathon/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/marathon/subscription","commits_url":"https://api.github.com/repos/mesosphere/marathon/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/marathon/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/marathon/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/marathon/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/marathon/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/marathon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/marathon/merges","archive_url":"https://api.github.com/repos/mesosphere/marathon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/marathon/downloads","issues_url":"https://api.github.com/repos/mesosphere/marathon/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/marathon/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/marathon/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/marathon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/marathon/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/marathon/releases{/id}","deployments_url":"https://api.github.com/repos/mesosphere/marathon/deployments","created_at":"2013-06-25T14:56:34Z","updated_at":"2018-09-19T14:56:47Z","pushed_at":"2018-09-19T16:38:41Z","git_url":"git://github.com/mesosphere/marathon.git","ssh_url":"[email protected]:mesosphere/marathon.git","clone_url":"https://github.com/mesosphere/marathon.git","svn_url":"https://github.com/mesosphere/marathon","homepage":"https://mesosphere.github.io/marathon/","size":38250,"stargazers_count":3725,"watchers_count":3725,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":853,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":853,"open_issues":12,"watchers":3725,"default_branch":"master"}},"base":{"label":"mesosphere:master","ref":"master","sha":"c18694c82968f7bf4d4dc899323f65aa42b5e85d","user":{"login":"mesosphere","id":3458585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTg1ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":10941409,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk0MTQwOQ==","name":"marathon","full_name":"mesosphere/marathon","private":false,"owner":{"login":"mesosphere","id":3458585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTg1ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mesosphere/marathon","description":"Deploy and manage containers (including Docker) on top of Apache Mesos at scale.","fork":false,"url":"https://api.github.com/repos/mesosphere/marathon","forks_url":"https://api.github.com/repos/mesosphere/marathon/forks","keys_url":"https://api.github.com/repos/mesosphere/marathon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/marathon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/marathon/teams","hooks_url":"https://api.github.com/repos/mesosphere/marathon/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/marathon/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/marathon/events","assignees_url":"https://api.github.com/repos/mesosphere/marathon/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/marathon/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/marathon/tags","blobs_url":"https://api.github.com/repos/mesosphere/marathon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/marathon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/marathon/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/marathon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/marathon/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/marathon/languages","stargazers_url":"https://api.github.com/repos/mesosphere/marathon/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/marathon/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/marathon/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/marathon/subscription","commits_url":"https://api.github.com/repos/mesosphere/marathon/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/marathon/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/marathon/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/marathon/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/marathon/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/marathon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/marathon/merges","archive_url":"https://api.github.com/repos/mesosphere/marathon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/marathon/downloads","issues_url":"https://api.github.com/repos/mesosphere/marathon/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/marathon/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/marathon/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/marathon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/marathon/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/marathon/releases{/id}","deployments_url":"https://api.github.com/repos/mesosphere/marathon/deployments","created_at":"2013-06-25T14:56:34Z","updated_at":"2018-09-19T14:56:47Z","pushed_at":"2018-09-19T16:38:41Z","git_url":"git://github.com/mesosphere/marathon.git","ssh_url":"[email protected]:mesosphere/marathon.git","clone_url":"https://github.com/mesosphere/marathon.git","svn_url":"https://github.com/mesosphere/marathon","homepage":"https://mesosphere.github.io/marathon/","size":38250,"stargazers_count":3725,"watchers_count":3725,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":853,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":853,"open_issues":12,"watchers":3725,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/6538"},"html":{"href":"https://github.com/mesosphere/marathon/pull/6538"},"issue":{"href":"https://api.github.com/repos/mesosphere/marathon/issues/6538"},"comments":{"href":"https://api.github.com/repos/mesosphere/marathon/issues/6538/comments"},"review_comments":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/6538/comments"},"review_comment":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/6538/commits"},"statuses":{"href":"https://api.github.com/repos/mesosphere/marathon/statuses/b255e9e0cb1afc20997068f9c1119449e96ab677"}},"author_association":"CONTRIBUTOR"}} | {
"id": 10941409,
"name": "mesosphere/marathon",
"url": "https://api.github.com/repos/mesosphere/marathon"
} | {
"id": 183,
"login": "timcharper",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/183?",
"url": "https://api.github.com/users/timcharper"
} | {
"id": 3458585,
"login": "mesosphere",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3458585?",
"url": "https://api.github.com/orgs/mesosphere"
} | 2018-09-19T17:00:14 | 8290320678 | {"actor":{"display_login":"timcharper"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/comments/166697793","pull_request_review_id":94802829,"id":166697793,"diff_hunk":"@@ -58,10 +101,13 @@ public EvaluationOutcome evaluate(MesosResourcePool mesosResourcePool, PodInfoBu\n // add it to the ExecutorInfo.\n podInfoBuilder.setExecutorVolume(volumeSpec);\n \n+ String sourceRoot = null;\n+\n Resource volume = PodInfoBuilder.getExistingExecutorVolume(\n volumeSpec,\n- resourceId.get(),\n- persistenceId.get(),\n+ resourceId,\n+ persistenceId,\n+ Optional.ofNullable(sourceRoot),","path":"sdk/scheduler/src/main/java/com/mesosphere/sdk/offer/evaluate/VolumeEvaluationStage.java","position":75,"original_position":75,"commit_id":"3cecd81f611628f052644597f077c14b9fd444ac","original_commit_id":"3cecd81f611628f052644597f077c14b9fd444ac","user":{"login":"nickbp","id":35933,"avatar_url":"https://avatars2.githubusercontent.com/u/35933?v=4","gravatar_id":"","url":"https://api.github.com/users/nickbp","html_url":"https://github.com/nickbp","followers_url":"https://api.github.com/users/nickbp/followers","following_url":"https://api.github.com/users/nickbp/following{/other_user}","gists_url":"https://api.github.com/users/nickbp/gists{/gist_id}","starred_url":"https://api.github.com/users/nickbp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickbp/subscriptions","organizations_url":"https://api.github.com/users/nickbp/orgs","repos_url":"https://api.github.com/users/nickbp/repos","events_url":"https://api.github.com/users/nickbp/events{/privacy}","received_events_url":"https://api.github.com/users/nickbp/received_events","type":"User","site_admin":false},"body":"Always null?","created_at":"2018-02-07T17:43:32Z","updated_at":"2018-02-07T17:49:34Z","html_url":"https://github.com/mesosphere/dcos-commons/pull/2207#discussion_r166697793","pull_request_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/2207","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/comments/166697793"},"html":{"href":"https://github.com/mesosphere/dcos-commons/pull/2207#discussion_r166697793"},"pull_request":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/2207"}}},"pull_request":{"url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/2207","id":167529638,"html_url":"https://github.com/mesosphere/dcos-commons/pull/2207","diff_url":"https://github.com/mesosphere/dcos-commons/pull/2207.diff","patch_url":"https://github.com/mesosphere/dcos-commons/pull/2207.patch","issue_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/2207","number":2207,"state":"open","locked":false,"title":"Fix sidecar refinement","user":{"login":"gabrielhartmann","id":567111,"avatar_url":"https://avatars1.githubusercontent.com/u/567111?v=4","gravatar_id":"","url":"https://api.github.com/users/gabrielhartmann","html_url":"https://github.com/gabrielhartmann","followers_url":"https://api.github.com/users/gabrielhartmann/followers","following_url":"https://api.github.com/users/gabrielhartmann/following{/other_user}","gists_url":"https://api.github.com/users/gabrielhartmann/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrielhartmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrielhartmann/subscriptions","organizations_url":"https://api.github.com/users/gabrielhartmann/orgs","repos_url":"https://api.github.com/users/gabrielhartmann/repos","events_url":"https://api.github.com/users/gabrielhartmann/events{/privacy}","received_events_url":"https://api.github.com/users/gabrielhartmann/received_events","type":"User","site_admin":false},"body":"### Problem\r\nYou need to do 3 things to encounter the bug fixed here.\r\n1. Have a volume at the pod level\r\n1. Have a sidecar task on that pod\r\n1. Consume pre-reserved resources for that pod\r\n\r\n`edge-lb` does all three of those things and so can't use `0.40.X` versions of the SDK. This should fix that. I'll confirm with them before release of `0.40.2`.\r\n\r\n### Fix\r\nThis change can be a little bit hard to follow. There were a couple things that needed to happen.\r\n1. Use the `ResourceBuilder` class to build executor volumes so you get the reservation refinement stuff.\r\n1. Pass around the `sourceRoot` field so we can build `MOUNT` volumes for Executor reuse.\r\n\r\n### Note\r\nThe custom executor is only supported on 1.9 and previous. 1.9 and previous clusters do not support reservation refinement. That's why the custom executor code path remains unmodified.","created_at":"2018-02-06T21:08:44Z","updated_at":"2018-02-07T17:49:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"242911d262564ca978bfa1a7e99117377cfc1eb3","assignee":{"login":"gabrielhartmann","id":567111,"avatar_url":"https://avatars1.githubusercontent.com/u/567111?v=4","gravatar_id":"","url":"https://api.github.com/users/gabrielhartmann","html_url":"https://github.com/gabrielhartmann","followers_url":"https://api.github.com/users/gabrielhartmann/followers","following_url":"https://api.github.com/users/gabrielhartmann/following{/other_user}","gists_url":"https://api.github.com/users/gabrielhartmann/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrielhartmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrielhartmann/subscriptions","organizations_url":"https://api.github.com/users/gabrielhartmann/orgs","repos_url":"https://api.github.com/users/gabrielhartmann/repos","events_url":"https://api.github.com/users/gabrielhartmann/events{/privacy}","received_events_url":"https://api.github.com/users/gabrielhartmann/received_events","type":"User","site_admin":false},"assignees":[{"login":"gabrielhartmann","id":567111,"avatar_url":"https://avatars1.githubusercontent.com/u/567111?v=4","gravatar_id":"","url":"https://api.github.com/users/gabrielhartmann","html_url":"https://github.com/gabrielhartmann","followers_url":"https://api.github.com/users/gabrielhartmann/followers","following_url":"https://api.github.com/users/gabrielhartmann/following{/other_user}","gists_url":"https://api.github.com/users/gabrielhartmann/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrielhartmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrielhartmann/subscriptions","organizations_url":"https://api.github.com/users/gabrielhartmann/orgs","repos_url":"https://api.github.com/users/gabrielhartmann/repos","events_url":"https://api.github.com/users/gabrielhartmann/events{/privacy}","received_events_url":"https://api.github.com/users/gabrielhartmann/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/2207/commits","review_comments_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/2207/comments","review_comment_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/2207/comments","statuses_url":"https://api.github.com/repos/mesosphere/dcos-commons/statuses/3cecd81f611628f052644597f077c14b9fd444ac","head":{"label":"mesosphere:fix_sidecar_refinement","ref":"fix_sidecar_refinement","sha":"3cecd81f611628f052644597f077c14b9fd444ac","user":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":60286497,"name":"dcos-commons","full_name":"mesosphere/dcos-commons","owner":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/dcos-commons","description":"Simplifying stateful services","fork":false,"url":"https://api.github.com/repos/mesosphere/dcos-commons","forks_url":"https://api.github.com/repos/mesosphere/dcos-commons/forks","keys_url":"https://api.github.com/repos/mesosphere/dcos-commons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/dcos-commons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/dcos-commons/teams","hooks_url":"https://api.github.com/repos/mesosphere/dcos-commons/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/dcos-commons/events","assignees_url":"https://api.github.com/repos/mesosphere/dcos-commons/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/dcos-commons/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/dcos-commons/tags","blobs_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/dcos-commons/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/dcos-commons/languages","stargazers_url":"https://api.github.com/repos/mesosphere/dcos-commons/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/dcos-commons/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/dcos-commons/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/dcos-commons/subscription","commits_url":"https://api.github.com/repos/mesosphere/dcos-commons/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/dcos-commons/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/dcos-commons/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/dcos-commons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/dcos-commons/merges","archive_url":"https://api.github.com/repos/mesosphere/dcos-commons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/dcos-commons/downloads","issues_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/dcos-commons/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/dcos-commons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/dcos-commons/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/dcos-commons/releases{/id}","deployments_url":"https://api.github.com/repos/mesosphere/dcos-commons/deployments","created_at":"2016-06-02T18:09:08Z","updated_at":"2018-01-27T09:16:17Z","pushed_at":"2018-02-07T17:38:36Z","git_url":"git://github.com/mesosphere/dcos-commons.git","ssh_url":"[email protected]:mesosphere/dcos-commons.git","clone_url":"https://github.com/mesosphere/dcos-commons.git","svn_url":"https://github.com/mesosphere/dcos-commons","homepage":"https://mesosphere.github.io/dcos-commons/","size":59050,"stargazers_count":118,"watchers_count":118,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":121,"mirror_url":null,"archived":false,"open_issues_count":60,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":121,"open_issues":60,"watchers":118,"default_branch":"master"}},"base":{"label":"mesosphere:master","ref":"master","sha":"5dbdd75459f6293e01c96552b34e5e566a4d283a","user":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":60286497,"name":"dcos-commons","full_name":"mesosphere/dcos-commons","owner":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/dcos-commons","description":"Simplifying stateful services","fork":false,"url":"https://api.github.com/repos/mesosphere/dcos-commons","forks_url":"https://api.github.com/repos/mesosphere/dcos-commons/forks","keys_url":"https://api.github.com/repos/mesosphere/dcos-commons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/dcos-commons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/dcos-commons/teams","hooks_url":"https://api.github.com/repos/mesosphere/dcos-commons/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/dcos-commons/events","assignees_url":"https://api.github.com/repos/mesosphere/dcos-commons/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/dcos-commons/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/dcos-commons/tags","blobs_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/dcos-commons/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/dcos-commons/languages","stargazers_url":"https://api.github.com/repos/mesosphere/dcos-commons/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/dcos-commons/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/dcos-commons/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/dcos-commons/subscription","commits_url":"https://api.github.com/repos/mesosphere/dcos-commons/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/dcos-commons/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/dcos-commons/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/dcos-commons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/dcos-commons/merges","archive_url":"https://api.github.com/repos/mesosphere/dcos-commons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/dcos-commons/downloads","issues_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/dcos-commons/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/dcos-commons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/dcos-commons/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/dcos-commons/releases{/id}","deployments_url":"https://api.github.com/repos/mesosphere/dcos-commons/deployments","created_at":"2016-06-02T18:09:08Z","updated_at":"2018-01-27T09:16:17Z","pushed_at":"2018-02-07T17:38:36Z","git_url":"git://github.com/mesosphere/dcos-commons.git","ssh_url":"[email protected]:mesosphere/dcos-commons.git","clone_url":"https://github.com/mesosphere/dcos-commons.git","svn_url":"https://github.com/mesosphere/dcos-commons","homepage":"https://mesosphere.github.io/dcos-commons/","size":59050,"stargazers_count":118,"watchers_count":118,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":121,"mirror_url":null,"archived":false,"open_issues_count":60,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":121,"open_issues":60,"watchers":118,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/2207"},"html":{"href":"https://github.com/mesosphere/dcos-commons/pull/2207"},"issue":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/issues/2207"},"comments":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/issues/2207/comments"},"review_comments":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/2207/comments"},"review_comment":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/2207/commits"},"statuses":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/statuses/3cecd81f611628f052644597f077c14b9fd444ac"}},"author_association":"CONTRIBUTOR"}} | {
"id": 60286497,
"name": "mesosphere/dcos-commons",
"url": "https://api.github.com/repos/mesosphere/dcos-commons"
} | {
"id": 35933,
"login": "nickbp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/35933?",
"url": "https://api.github.com/users/nickbp"
} | {
"id": 3458585,
"login": "mesosphere",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3458585?",
"url": "https://api.github.com/orgs/mesosphere"
} | 2018-02-07T17:43:32 | 7212292343 | {"actor":{"display_login":"nickbp"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/hyrise/hyrise/pulls/comments/208172184","pull_request_review_id":143926023,"id":208172184,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODE3MjE4NA==","diff_hunk":"@@ -108,12 +108,6 @@ node {\n Utils.markStageSkippedForConditional(\"clangDebugAddrUBSanitizers\")\n }\n }\n- }, gccDebug: {","path":"Jenkinsfile","position":18,"original_position":18,"commit_id":"cf33e8b0342ac60b7637bad4a3e8f3275ce68df0","original_commit_id":"cf33e8b0342ac60b7637bad4a3e8f3275ce68df0","user":{"login":"Bensk1","id":1655756,"node_id":"MDQ6VXNlcjE2NTU3NTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1655756?v=4","gravatar_id":"","url":"https://api.github.com/users/Bensk1","html_url":"https://github.com/Bensk1","followers_url":"https://api.github.com/users/Bensk1/followers","following_url":"https://api.github.com/users/Bensk1/following{/other_user}","gists_url":"https://api.github.com/users/Bensk1/gists{/gist_id}","starred_url":"https://api.github.com/users/Bensk1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bensk1/subscriptions","organizations_url":"https://api.github.com/users/Bensk1/orgs","repos_url":"https://api.github.com/users/Bensk1/repos","events_url":"https://api.github.com/users/Bensk1/events{/privacy}","received_events_url":"https://api.github.com/users/Bensk1/received_events","type":"User","site_admin":false},"body":"Der `sh \"./gcc-debug/hyriseTest gcc-debug\"` wurde jetzt entfernt?","created_at":"2018-08-07T10:06:35Z","updated_at":"2018-08-07T10:06:35Z","html_url":"https://github.com/hyrise/hyrise/pull/1038#discussion_r208172184","pull_request_url":"https://api.github.com/repos/hyrise/hyrise/pulls/1038","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/hyrise/hyrise/pulls/comments/208172184"},"html":{"href":"https://github.com/hyrise/hyrise/pull/1038#discussion_r208172184"},"pull_request":{"href":"https://api.github.com/repos/hyrise/hyrise/pulls/1038"}}},"pull_request":{"url":"https://api.github.com/repos/hyrise/hyrise/pulls/1038","id":206643651,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NjQzNjUx","html_url":"https://github.com/hyrise/hyrise/pull/1038","diff_url":"https://github.com/hyrise/hyrise/pull/1038.diff","patch_url":"https://github.com/hyrise/hyrise/pull/1038.patch","issue_url":"https://api.github.com/repos/hyrise/hyrise/issues/1038","number":1038,"state":"open","locked":false,"title":"Fix test isolation on Jenkins","user":{"login":"mrks","id":575106,"node_id":"MDQ6VXNlcjU3NTEwNg==","avatar_url":"https://avatars2.githubusercontent.com/u/575106?v=4","gravatar_id":"","url":"https://api.github.com/users/mrks","html_url":"https://github.com/mrks","followers_url":"https://api.github.com/users/mrks/followers","following_url":"https://api.github.com/users/mrks/following{/other_user}","gists_url":"https://api.github.com/users/mrks/gists{/gist_id}","starred_url":"https://api.github.com/users/mrks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrks/subscriptions","organizations_url":"https://api.github.com/users/mrks/orgs","repos_url":"https://api.github.com/users/mrks/repos","events_url":"https://api.github.com/users/mrks/events{/privacy}","received_events_url":"https://api.github.com/users/mrks/received_events","type":"User","site_admin":false},"body":"This should fix the current matser fail","created_at":"2018-08-07T10:00:12Z","updated_at":"2018-08-07T10:06:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ee3364a68ba6ba3762ee6a7dbe1a28efd709e554","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hyrise/hyrise/pulls/1038/commits","review_comments_url":"https://api.github.com/repos/hyrise/hyrise/pulls/1038/comments","review_comment_url":"https://api.github.com/repos/hyrise/hyrise/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyrise/hyrise/issues/1038/comments","statuses_url":"https://api.github.com/repos/hyrise/hyrise/statuses/cf33e8b0342ac60b7637bad4a3e8f3275ce68df0","head":{"label":"hyrise:mrks/fixisolations","ref":"mrks/fixisolations","sha":"cf33e8b0342ac60b7637bad4a3e8f3275ce68df0","user":{"login":"hyrise","id":3465095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NjUwOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/3465095?v=4","gravatar_id":"","url":"https://api.github.com/users/hyrise","html_url":"https://github.com/hyrise","followers_url":"https://api.github.com/users/hyrise/followers","following_url":"https://api.github.com/users/hyrise/following{/other_user}","gists_url":"https://api.github.com/users/hyrise/gists{/gist_id}","starred_url":"https://api.github.com/users/hyrise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyrise/subscriptions","organizations_url":"https://api.github.com/users/hyrise/orgs","repos_url":"https://api.github.com/users/hyrise/repos","events_url":"https://api.github.com/users/hyrise/events{/privacy}","received_events_url":"https://api.github.com/users/hyrise/received_events","type":"Organization","site_admin":false},"repo":{"id":87414843,"node_id":"MDEwOlJlcG9zaXRvcnk4NzQxNDg0Mw==","name":"hyrise","full_name":"hyrise/hyrise","owner":{"login":"hyrise","id":3465095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NjUwOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/3465095?v=4","gravatar_id":"","url":"https://api.github.com/users/hyrise","html_url":"https://github.com/hyrise","followers_url":"https://api.github.com/users/hyrise/followers","following_url":"https://api.github.com/users/hyrise/following{/other_user}","gists_url":"https://api.github.com/users/hyrise/gists{/gist_id}","starred_url":"https://api.github.com/users/hyrise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyrise/subscriptions","organizations_url":"https://api.github.com/users/hyrise/orgs","repos_url":"https://api.github.com/users/hyrise/repos","events_url":"https://api.github.com/users/hyrise/events{/privacy}","received_events_url":"https://api.github.com/users/hyrise/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyrise/hyrise","description":"A research in-memory database.","fork":false,"url":"https://api.github.com/repos/hyrise/hyrise","forks_url":"https://api.github.com/repos/hyrise/hyrise/forks","keys_url":"https://api.github.com/repos/hyrise/hyrise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyrise/hyrise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyrise/hyrise/teams","hooks_url":"https://api.github.com/repos/hyrise/hyrise/hooks","issue_events_url":"https://api.github.com/repos/hyrise/hyrise/issues/events{/number}","events_url":"https://api.github.com/repos/hyrise/hyrise/events","assignees_url":"https://api.github.com/repos/hyrise/hyrise/assignees{/user}","branches_url":"https://api.github.com/repos/hyrise/hyrise/branches{/branch}","tags_url":"https://api.github.com/repos/hyrise/hyrise/tags","blobs_url":"https://api.github.com/repos/hyrise/hyrise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyrise/hyrise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyrise/hyrise/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyrise/hyrise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyrise/hyrise/statuses/{sha}","languages_url":"https://api.github.com/repos/hyrise/hyrise/languages","stargazers_url":"https://api.github.com/repos/hyrise/hyrise/stargazers","contributors_url":"https://api.github.com/repos/hyrise/hyrise/contributors","subscribers_url":"https://api.github.com/repos/hyrise/hyrise/subscribers","subscription_url":"https://api.github.com/repos/hyrise/hyrise/subscription","commits_url":"https://api.github.com/repos/hyrise/hyrise/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyrise/hyrise/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyrise/hyrise/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyrise/hyrise/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyrise/hyrise/contents/{+path}","compare_url":"https://api.github.com/repos/hyrise/hyrise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyrise/hyrise/merges","archive_url":"https://api.github.com/repos/hyrise/hyrise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyrise/hyrise/downloads","issues_url":"https://api.github.com/repos/hyrise/hyrise/issues{/number}","pulls_url":"https://api.github.com/repos/hyrise/hyrise/pulls{/number}","milestones_url":"https://api.github.com/repos/hyrise/hyrise/milestones{/number}","notifications_url":"https://api.github.com/repos/hyrise/hyrise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyrise/hyrise/labels{/name}","releases_url":"https://api.github.com/repos/hyrise/hyrise/releases{/id}","deployments_url":"https://api.github.com/repos/hyrise/hyrise/deployments","created_at":"2017-04-06T10:03:31Z","updated_at":"2018-08-07T09:09:03Z","pushed_at":"2018-08-07T10:00:41Z","git_url":"git://github.com/hyrise/hyrise.git","ssh_url":"[email protected]:hyrise/hyrise.git","clone_url":"https://github.com/hyrise/hyrise.git","svn_url":"https://github.com/hyrise/hyrise","homepage":"https://hpi.de/plattner/projects/hyrise.html","size":27844,"stargazers_count":97,"watchers_count":97,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":69,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":25,"open_issues":69,"watchers":97,"default_branch":"master"}},"base":{"label":"hyrise:master","ref":"master","sha":"7c3f2eef88235bd23b2eb2ba307f54c189ce8d38","user":{"login":"hyrise","id":3465095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NjUwOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/3465095?v=4","gravatar_id":"","url":"https://api.github.com/users/hyrise","html_url":"https://github.com/hyrise","followers_url":"https://api.github.com/users/hyrise/followers","following_url":"https://api.github.com/users/hyrise/following{/other_user}","gists_url":"https://api.github.com/users/hyrise/gists{/gist_id}","starred_url":"https://api.github.com/users/hyrise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyrise/subscriptions","organizations_url":"https://api.github.com/users/hyrise/orgs","repos_url":"https://api.github.com/users/hyrise/repos","events_url":"https://api.github.com/users/hyrise/events{/privacy}","received_events_url":"https://api.github.com/users/hyrise/received_events","type":"Organization","site_admin":false},"repo":{"id":87414843,"node_id":"MDEwOlJlcG9zaXRvcnk4NzQxNDg0Mw==","name":"hyrise","full_name":"hyrise/hyrise","owner":{"login":"hyrise","id":3465095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NjUwOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/3465095?v=4","gravatar_id":"","url":"https://api.github.com/users/hyrise","html_url":"https://github.com/hyrise","followers_url":"https://api.github.com/users/hyrise/followers","following_url":"https://api.github.com/users/hyrise/following{/other_user}","gists_url":"https://api.github.com/users/hyrise/gists{/gist_id}","starred_url":"https://api.github.com/users/hyrise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyrise/subscriptions","organizations_url":"https://api.github.com/users/hyrise/orgs","repos_url":"https://api.github.com/users/hyrise/repos","events_url":"https://api.github.com/users/hyrise/events{/privacy}","received_events_url":"https://api.github.com/users/hyrise/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyrise/hyrise","description":"A research in-memory database.","fork":false,"url":"https://api.github.com/repos/hyrise/hyrise","forks_url":"https://api.github.com/repos/hyrise/hyrise/forks","keys_url":"https://api.github.com/repos/hyrise/hyrise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyrise/hyrise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyrise/hyrise/teams","hooks_url":"https://api.github.com/repos/hyrise/hyrise/hooks","issue_events_url":"https://api.github.com/repos/hyrise/hyrise/issues/events{/number}","events_url":"https://api.github.com/repos/hyrise/hyrise/events","assignees_url":"https://api.github.com/repos/hyrise/hyrise/assignees{/user}","branches_url":"https://api.github.com/repos/hyrise/hyrise/branches{/branch}","tags_url":"https://api.github.com/repos/hyrise/hyrise/tags","blobs_url":"https://api.github.com/repos/hyrise/hyrise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyrise/hyrise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyrise/hyrise/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyrise/hyrise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyrise/hyrise/statuses/{sha}","languages_url":"https://api.github.com/repos/hyrise/hyrise/languages","stargazers_url":"https://api.github.com/repos/hyrise/hyrise/stargazers","contributors_url":"https://api.github.com/repos/hyrise/hyrise/contributors","subscribers_url":"https://api.github.com/repos/hyrise/hyrise/subscribers","subscription_url":"https://api.github.com/repos/hyrise/hyrise/subscription","commits_url":"https://api.github.com/repos/hyrise/hyrise/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyrise/hyrise/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyrise/hyrise/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyrise/hyrise/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyrise/hyrise/contents/{+path}","compare_url":"https://api.github.com/repos/hyrise/hyrise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyrise/hyrise/merges","archive_url":"https://api.github.com/repos/hyrise/hyrise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyrise/hyrise/downloads","issues_url":"https://api.github.com/repos/hyrise/hyrise/issues{/number}","pulls_url":"https://api.github.com/repos/hyrise/hyrise/pulls{/number}","milestones_url":"https://api.github.com/repos/hyrise/hyrise/milestones{/number}","notifications_url":"https://api.github.com/repos/hyrise/hyrise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyrise/hyrise/labels{/name}","releases_url":"https://api.github.com/repos/hyrise/hyrise/releases{/id}","deployments_url":"https://api.github.com/repos/hyrise/hyrise/deployments","created_at":"2017-04-06T10:03:31Z","updated_at":"2018-08-07T09:09:03Z","pushed_at":"2018-08-07T10:00:41Z","git_url":"git://github.com/hyrise/hyrise.git","ssh_url":"[email protected]:hyrise/hyrise.git","clone_url":"https://github.com/hyrise/hyrise.git","svn_url":"https://github.com/hyrise/hyrise","homepage":"https://hpi.de/plattner/projects/hyrise.html","size":27844,"stargazers_count":97,"watchers_count":97,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":69,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":25,"open_issues":69,"watchers":97,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyrise/hyrise/pulls/1038"},"html":{"href":"https://github.com/hyrise/hyrise/pull/1038"},"issue":{"href":"https://api.github.com/repos/hyrise/hyrise/issues/1038"},"comments":{"href":"https://api.github.com/repos/hyrise/hyrise/issues/1038/comments"},"review_comments":{"href":"https://api.github.com/repos/hyrise/hyrise/pulls/1038/comments"},"review_comment":{"href":"https://api.github.com/repos/hyrise/hyrise/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyrise/hyrise/pulls/1038/commits"},"statuses":{"href":"https://api.github.com/repos/hyrise/hyrise/statuses/cf33e8b0342ac60b7637bad4a3e8f3275ce68df0"}},"author_association":"MEMBER"}} | {
"id": 87414843,
"name": "hyrise/hyrise",
"url": "https://api.github.com/repos/hyrise/hyrise"
} | {
"id": 1655756,
"login": "Bensk1",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1655756?",
"url": "https://api.github.com/users/Bensk1"
} | {
"id": 3465095,
"login": "hyrise",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3465095?",
"url": "https://api.github.com/orgs/hyrise"
} | 2018-08-07T10:06:35 | 8076654060 | {"actor":{"display_login":"Bensk1"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/hyrise/hyrise/pulls/comments/241679850","pull_request_review_id":185012413,"id":241679850,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTY3OTg1MA==","diff_hunk":"@@ -215,16 +216,12 @@ class Sort::SortImpl : public AbstractReadOnlyOperatorImpl {\n \n auto base_segment = chunk->get_segment(_column_id);\n \n- resolve_segment_type<SortColumnType>(*base_segment, [&](auto& typed_segment) {\n- auto iterable = create_iterable_from_segment<SortColumnType>(typed_segment);\n-\n- iterable.for_each([&](const auto& value) {\n- if (value.is_null()) {\n- null_value_rows.emplace_back(RowID{chunk_id, value.chunk_offset()}, SortColumnType{});\n- } else {\n- row_id_value_vector.emplace_back(RowID{chunk_id, value.chunk_offset()}, value.value());\n- }\n- });\n+ segment_for_each<SortColumnType>(*base_segment, [&](const auto& value) {\n+ if (value.is_null()) {\n+ null_value_rows.emplace_back(RowID{chunk_id, value.chunk_offset()}, SortColumnType{});\n+ } else {\n+ row_id_value_vector.emplace_back(RowID{chunk_id, value.chunk_offset()}, value.value());","path":"src/lib/operators/sort.cpp","position":26,"original_position":26,"commit_id":"303e6d90688a4270cfe57f51467d8408af0a04f6","original_commit_id":"e561f9438ca8a4b549aaecb1df4d2f2d733b9c6f","user":{"login":"mrzzzrm","id":2679018,"node_id":"MDQ6VXNlcjI2NzkwMTg=","avatar_url":"https://avatars3.githubusercontent.com/u/2679018?v=4","gravatar_id":"","url":"https://api.github.com/users/mrzzzrm","html_url":"https://github.com/mrzzzrm","followers_url":"https://api.github.com/users/mrzzzrm/followers","following_url":"https://api.github.com/users/mrzzzrm/following{/other_user}","gists_url":"https://api.github.com/users/mrzzzrm/gists{/gist_id}","starred_url":"https://api.github.com/users/mrzzzrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrzzzrm/subscriptions","organizations_url":"https://api.github.com/users/mrzzzrm/orgs","repos_url":"https://api.github.com/users/mrzzzrm/repos","events_url":"https://api.github.com/users/mrzzzrm/events{/privacy}","received_events_url":"https://api.github.com/users/mrzzzrm/received_events","type":"User","site_admin":false},"body":"Decided I like `SegmentPosition` even better.","created_at":"2018-12-14T08:48:58Z","updated_at":"2018-12-14T08:48:58Z","html_url":"https://github.com/hyrise/hyrise/pull/1337#discussion_r241679850","pull_request_url":"https://api.github.com/repos/hyrise/hyrise/pulls/1337","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hyrise/hyrise/pulls/comments/241679850"},"html":{"href":"https://github.com/hyrise/hyrise/pull/1337#discussion_r241679850"},"pull_request":{"href":"https://api.github.com/repos/hyrise/hyrise/pulls/1337"}},"in_reply_to_id":238109286},"pull_request":{"url":"https://api.github.com/repos/hyrise/hyrise/pulls/1337","id":235252499,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MjUyNDk5","html_url":"https://github.com/hyrise/hyrise/pull/1337","diff_url":"https://github.com/hyrise/hyrise/pull/1337.diff","patch_url":"https://github.com/hyrise/hyrise/pull/1337.patch","issue_url":"https://api.github.com/repos/hyrise/hyrise/issues/1337","number":1337,"state":"open","locked":false,"title":"More type erasure for AnySegmentIterable to reduce compile times in Debug build","user":{"login":"mrzzzrm","id":2679018,"node_id":"MDQ6VXNlcjI2NzkwMTg=","avatar_url":"https://avatars3.githubusercontent.com/u/2679018?v=4","gravatar_id":"","url":"https://api.github.com/users/mrzzzrm","html_url":"https://github.com/mrzzzrm","followers_url":"https://api.github.com/users/mrzzzrm/followers","following_url":"https://api.github.com/users/mrzzzrm/following{/other_user}","gists_url":"https://api.github.com/users/mrzzzrm/gists{/gist_id}","starred_url":"https://api.github.com/users/mrzzzrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrzzzrm/subscriptions","organizations_url":"https://api.github.com/users/mrzzzrm/orgs","repos_url":"https://api.github.com/users/mrzzzrm/repos","events_url":"https://api.github.com/users/mrzzzrm/events{/privacy}","received_events_url":"https://api.github.com/users/mrzzzrm/received_events","type":"User","site_admin":false},"body":"Fix #1145\r\n\r\nThis introduces `segment_iterate()` and `segment_with_iterators()` as your new way to go to iterate over a segment's data. They compile way faster in debug builds than anything we had previously, as the passed functor is only instantiated once per `DataType`. In release builds, everything remains roughly the same.\r\n\r\nI changed the JoinNestedLoop, which took ~15 Minutes to compile in release` to retrieve the outer value via a virtual function call, which greatly reduces its compile time.\r\n\r\n\r\nClangDebug libhyrise objects (accumulated):\r\n\r\n```\r\nObjectCount 258 -> 260\r\nBuildTime 632.07s -> 545.41s (-86.66s -13.71%)\r\nFileSize 937.2MiB -> 645.2MiB (-292.0MiB -31.16%)\r\n```\r\n\r\nClangRelease libhyrise objects (accumulated):\r\n\r\n```\r\nObjectCount 258 -> 260\r\nBuildTime 2505.70s -> 1579.45s (-926.25s -36.97%)\r\nFileSize 106.7MiB -> 88.2MiB (-18.5MiB -17.35%)\r\n```","created_at":"2018-12-02T11:13:30Z","updated_at":"2018-12-14T08:48:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df705123066f8cae325f3b652814adf5cc7b1707","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":978421305,"node_id":"MDU6TGFiZWw5Nzg0MjEzMDU=","url":"https://api.github.com/repos/hyrise/hyrise/labels/FullCI","name":"FullCI","color":"02ef0e","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/hyrise/hyrise/pulls/1337/commits","review_comments_url":"https://api.github.com/repos/hyrise/hyrise/pulls/1337/comments","review_comment_url":"https://api.github.com/repos/hyrise/hyrise/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyrise/hyrise/issues/1337/comments","statuses_url":"https://api.github.com/repos/hyrise/hyrise/statuses/303e6d90688a4270cfe57f51467d8408af0a04f6","head":{"label":"hyrise:any_segment_iterable_unleashed","ref":"any_segment_iterable_unleashed","sha":"303e6d90688a4270cfe57f51467d8408af0a04f6","user":{"login":"hyrise","id":3465095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NjUwOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/3465095?v=4","gravatar_id":"","url":"https://api.github.com/users/hyrise","html_url":"https://github.com/hyrise","followers_url":"https://api.github.com/users/hyrise/followers","following_url":"https://api.github.com/users/hyrise/following{/other_user}","gists_url":"https://api.github.com/users/hyrise/gists{/gist_id}","starred_url":"https://api.github.com/users/hyrise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyrise/subscriptions","organizations_url":"https://api.github.com/users/hyrise/orgs","repos_url":"https://api.github.com/users/hyrise/repos","events_url":"https://api.github.com/users/hyrise/events{/privacy}","received_events_url":"https://api.github.com/users/hyrise/received_events","type":"Organization","site_admin":false},"repo":{"id":87414843,"node_id":"MDEwOlJlcG9zaXRvcnk4NzQxNDg0Mw==","name":"hyrise","full_name":"hyrise/hyrise","private":false,"owner":{"login":"hyrise","id":3465095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NjUwOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/3465095?v=4","gravatar_id":"","url":"https://api.github.com/users/hyrise","html_url":"https://github.com/hyrise","followers_url":"https://api.github.com/users/hyrise/followers","following_url":"https://api.github.com/users/hyrise/following{/other_user}","gists_url":"https://api.github.com/users/hyrise/gists{/gist_id}","starred_url":"https://api.github.com/users/hyrise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyrise/subscriptions","organizations_url":"https://api.github.com/users/hyrise/orgs","repos_url":"https://api.github.com/users/hyrise/repos","events_url":"https://api.github.com/users/hyrise/events{/privacy}","received_events_url":"https://api.github.com/users/hyrise/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hyrise/hyrise","description":"Hyrise is a research in-memory database.","fork":false,"url":"https://api.github.com/repos/hyrise/hyrise","forks_url":"https://api.github.com/repos/hyrise/hyrise/forks","keys_url":"https://api.github.com/repos/hyrise/hyrise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyrise/hyrise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyrise/hyrise/teams","hooks_url":"https://api.github.com/repos/hyrise/hyrise/hooks","issue_events_url":"https://api.github.com/repos/hyrise/hyrise/issues/events{/number}","events_url":"https://api.github.com/repos/hyrise/hyrise/events","assignees_url":"https://api.github.com/repos/hyrise/hyrise/assignees{/user}","branches_url":"https://api.github.com/repos/hyrise/hyrise/branches{/branch}","tags_url":"https://api.github.com/repos/hyrise/hyrise/tags","blobs_url":"https://api.github.com/repos/hyrise/hyrise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyrise/hyrise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyrise/hyrise/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyrise/hyrise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyrise/hyrise/statuses/{sha}","languages_url":"https://api.github.com/repos/hyrise/hyrise/languages","stargazers_url":"https://api.github.com/repos/hyrise/hyrise/stargazers","contributors_url":"https://api.github.com/repos/hyrise/hyrise/contributors","subscribers_url":"https://api.github.com/repos/hyrise/hyrise/subscribers","subscription_url":"https://api.github.com/repos/hyrise/hyrise/subscription","commits_url":"https://api.github.com/repos/hyrise/hyrise/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyrise/hyrise/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyrise/hyrise/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyrise/hyrise/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyrise/hyrise/contents/{+path}","compare_url":"https://api.github.com/repos/hyrise/hyrise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyrise/hyrise/merges","archive_url":"https://api.github.com/repos/hyrise/hyrise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyrise/hyrise/downloads","issues_url":"https://api.github.com/repos/hyrise/hyrise/issues{/number}","pulls_url":"https://api.github.com/repos/hyrise/hyrise/pulls{/number}","milestones_url":"https://api.github.com/repos/hyrise/hyrise/milestones{/number}","notifications_url":"https://api.github.com/repos/hyrise/hyrise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyrise/hyrise/labels{/name}","releases_url":"https://api.github.com/repos/hyrise/hyrise/releases{/id}","deployments_url":"https://api.github.com/repos/hyrise/hyrise/deployments","created_at":"2017-04-06T10:03:31Z","updated_at":"2018-12-13T21:06:41Z","pushed_at":"2018-12-14T08:32:41Z","git_url":"git://github.com/hyrise/hyrise.git","ssh_url":"[email protected]:hyrise/hyrise.git","clone_url":"https://github.com/hyrise/hyrise.git","svn_url":"https://github.com/hyrise/hyrise","homepage":"https://hpi.de/plattner/projects/hyrise.html","size":20101,"stargazers_count":144,"watchers_count":144,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":82,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":40,"open_issues":82,"watchers":144,"default_branch":"master"}},"base":{"label":"hyrise:master","ref":"master","sha":"f3ec2460d88b854c634e30711ae66d0b347f679c","user":{"login":"hyrise","id":3465095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NjUwOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/3465095?v=4","gravatar_id":"","url":"https://api.github.com/users/hyrise","html_url":"https://github.com/hyrise","followers_url":"https://api.github.com/users/hyrise/followers","following_url":"https://api.github.com/users/hyrise/following{/other_user}","gists_url":"https://api.github.com/users/hyrise/gists{/gist_id}","starred_url":"https://api.github.com/users/hyrise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyrise/subscriptions","organizations_url":"https://api.github.com/users/hyrise/orgs","repos_url":"https://api.github.com/users/hyrise/repos","events_url":"https://api.github.com/users/hyrise/events{/privacy}","received_events_url":"https://api.github.com/users/hyrise/received_events","type":"Organization","site_admin":false},"repo":{"id":87414843,"node_id":"MDEwOlJlcG9zaXRvcnk4NzQxNDg0Mw==","name":"hyrise","full_name":"hyrise/hyrise","private":false,"owner":{"login":"hyrise","id":3465095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NjUwOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/3465095?v=4","gravatar_id":"","url":"https://api.github.com/users/hyrise","html_url":"https://github.com/hyrise","followers_url":"https://api.github.com/users/hyrise/followers","following_url":"https://api.github.com/users/hyrise/following{/other_user}","gists_url":"https://api.github.com/users/hyrise/gists{/gist_id}","starred_url":"https://api.github.com/users/hyrise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyrise/subscriptions","organizations_url":"https://api.github.com/users/hyrise/orgs","repos_url":"https://api.github.com/users/hyrise/repos","events_url":"https://api.github.com/users/hyrise/events{/privacy}","received_events_url":"https://api.github.com/users/hyrise/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hyrise/hyrise","description":"Hyrise is a research in-memory database.","fork":false,"url":"https://api.github.com/repos/hyrise/hyrise","forks_url":"https://api.github.com/repos/hyrise/hyrise/forks","keys_url":"https://api.github.com/repos/hyrise/hyrise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyrise/hyrise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyrise/hyrise/teams","hooks_url":"https://api.github.com/repos/hyrise/hyrise/hooks","issue_events_url":"https://api.github.com/repos/hyrise/hyrise/issues/events{/number}","events_url":"https://api.github.com/repos/hyrise/hyrise/events","assignees_url":"https://api.github.com/repos/hyrise/hyrise/assignees{/user}","branches_url":"https://api.github.com/repos/hyrise/hyrise/branches{/branch}","tags_url":"https://api.github.com/repos/hyrise/hyrise/tags","blobs_url":"https://api.github.com/repos/hyrise/hyrise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyrise/hyrise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyrise/hyrise/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyrise/hyrise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyrise/hyrise/statuses/{sha}","languages_url":"https://api.github.com/repos/hyrise/hyrise/languages","stargazers_url":"https://api.github.com/repos/hyrise/hyrise/stargazers","contributors_url":"https://api.github.com/repos/hyrise/hyrise/contributors","subscribers_url":"https://api.github.com/repos/hyrise/hyrise/subscribers","subscription_url":"https://api.github.com/repos/hyrise/hyrise/subscription","commits_url":"https://api.github.com/repos/hyrise/hyrise/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyrise/hyrise/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyrise/hyrise/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyrise/hyrise/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyrise/hyrise/contents/{+path}","compare_url":"https://api.github.com/repos/hyrise/hyrise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyrise/hyrise/merges","archive_url":"https://api.github.com/repos/hyrise/hyrise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyrise/hyrise/downloads","issues_url":"https://api.github.com/repos/hyrise/hyrise/issues{/number}","pulls_url":"https://api.github.com/repos/hyrise/hyrise/pulls{/number}","milestones_url":"https://api.github.com/repos/hyrise/hyrise/milestones{/number}","notifications_url":"https://api.github.com/repos/hyrise/hyrise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyrise/hyrise/labels{/name}","releases_url":"https://api.github.com/repos/hyrise/hyrise/releases{/id}","deployments_url":"https://api.github.com/repos/hyrise/hyrise/deployments","created_at":"2017-04-06T10:03:31Z","updated_at":"2018-12-13T21:06:41Z","pushed_at":"2018-12-14T08:32:41Z","git_url":"git://github.com/hyrise/hyrise.git","ssh_url":"[email protected]:hyrise/hyrise.git","clone_url":"https://github.com/hyrise/hyrise.git","svn_url":"https://github.com/hyrise/hyrise","homepage":"https://hpi.de/plattner/projects/hyrise.html","size":20101,"stargazers_count":144,"watchers_count":144,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":82,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":40,"open_issues":82,"watchers":144,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyrise/hyrise/pulls/1337"},"html":{"href":"https://github.com/hyrise/hyrise/pull/1337"},"issue":{"href":"https://api.github.com/repos/hyrise/hyrise/issues/1337"},"comments":{"href":"https://api.github.com/repos/hyrise/hyrise/issues/1337/comments"},"review_comments":{"href":"https://api.github.com/repos/hyrise/hyrise/pulls/1337/comments"},"review_comment":{"href":"https://api.github.com/repos/hyrise/hyrise/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyrise/hyrise/pulls/1337/commits"},"statuses":{"href":"https://api.github.com/repos/hyrise/hyrise/statuses/303e6d90688a4270cfe57f51467d8408af0a04f6"}},"author_association":"CONTRIBUTOR"}} | {
"id": 87414843,
"name": "hyrise/hyrise",
"url": "https://api.github.com/repos/hyrise/hyrise"
} | {
"id": 2679018,
"login": "mrzzzrm",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2679018?",
"url": "https://api.github.com/users/mrzzzrm"
} | {
"id": 3465095,
"login": "hyrise",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3465095?",
"url": "https://api.github.com/orgs/hyrise"
} | 2018-12-14T08:48:58 | 8753542853 | {"actor":{"display_login":"mrzzzrm"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/makersacademy/chitter-challenge/pulls/comments/175303491","pull_request_review_id":104811043,"id":175303491,"diff_hunk":"@@ -0,0 +1,42 @@\n+require 'bcrypt'\n+\n+class User\n+ attr_reader :id, :email, :password, :username, :name\n+\n+ def initialize(id, name, username, email, password)\n+ @id = id\n+ @email = email\n+ @password = password\n+ @username = username\n+ @name = name\n+ end\n+\n+ def self.all\n+ result = DatabaseConnection.query(\"SELECT * FROM users\")\n+ result.map { |user| User.new(user['id'], name['name'], user['username'], user['email'], user['password']) }\n+ end\n+\n+ def self.create(options)\n+ password = BCrypt::Password.create(options[:password])\n+ result = DatabaseConnection.query(\"INSERT INTO users (name, username, email, password) VALUES('#{options[:name]}', '#{options[:username]}', '#{options[:email]}', '#{password}') RETURNING id, name, username, email, password;\")\n+ User.new(result[0]['id'], result[0]['name'], result[0]['username'], result[0]['email'], result[0]['password'])\n+ end\n+\n+ def self.find(id)\n+ result = DatabaseConnection.query(\"SELECT * FROM users WHERE id = '#{id}';\")\n+ User.new(result[0]['id'], result[0]['name'], result[0]['username'], result[0]['email'], result[0]['password'])\n+ end\n+\n+ def self.authenticate(email, password)","path":"lib/user.rb","position":30,"original_position":30,"commit_id":"8f892aafa12fe5aa3e3023c9de6a46cab9ab8c4e","original_commit_id":"8f892aafa12fe5aa3e3023c9de6a46cab9ab8c4e","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Assignment Branch Condition size for authenticate is too high. [17.15/15]","created_at":"2018-03-18T20:56:59Z","updated_at":"2018-03-18T20:57:00Z","html_url":"https://github.com/makersacademy/chitter-challenge/pull/877#discussion_r175303491","pull_request_url":"https://api.github.com/repos/makersacademy/chitter-challenge/pulls/877","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/makersacademy/chitter-challenge/pulls/comments/175303491"},"html":{"href":"https://github.com/makersacademy/chitter-challenge/pull/877#discussion_r175303491"},"pull_request":{"href":"https://api.github.com/repos/makersacademy/chitter-challenge/pulls/877"}}},"pull_request":{"url":"https://api.github.com/repos/makersacademy/chitter-challenge/pulls/877","id":175772823,"html_url":"https://github.com/makersacademy/chitter-challenge/pull/877","diff_url":"https://github.com/makersacademy/chitter-challenge/pull/877.diff","patch_url":"https://github.com/makersacademy/chitter-challenge/pull/877.patch","issue_url":"https://api.github.com/repos/makersacademy/chitter-challenge/issues/877","number":877,"state":"open","locked":false,"title":"Weekend","user":{"login":"CharSV5","id":32747446,"avatar_url":"https://avatars0.githubusercontent.com/u/32747446?v=4","gravatar_id":"","url":"https://api.github.com/users/CharSV5","html_url":"https://github.com/CharSV5","followers_url":"https://api.github.com/users/CharSV5/followers","following_url":"https://api.github.com/users/CharSV5/following{/other_user}","gists_url":"https://api.github.com/users/CharSV5/gists{/gist_id}","starred_url":"https://api.github.com/users/CharSV5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CharSV5/subscriptions","organizations_url":"https://api.github.com/users/CharSV5/orgs","repos_url":"https://api.github.com/users/CharSV5/repos","events_url":"https://api.github.com/users/CharSV5/events{/privacy}","received_events_url":"https://api.github.com/users/CharSV5/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-18T20:56:43Z","updated_at":"2018-03-18T20:57:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bada4ddeb28b19d64d6c6ca68b580a99fd9dc7d0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/makersacademy/chitter-challenge/pulls/877/commits","review_comments_url":"https://api.github.com/repos/makersacademy/chitter-challenge/pulls/877/comments","review_comment_url":"https://api.github.com/repos/makersacademy/chitter-challenge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/makersacademy/chitter-challenge/issues/877/comments","statuses_url":"https://api.github.com/repos/makersacademy/chitter-challenge/statuses/8f892aafa12fe5aa3e3023c9de6a46cab9ab8c4e","head":{"label":"CharSV5:master","ref":"master","sha":"8f892aafa12fe5aa3e3023c9de6a46cab9ab8c4e","user":{"login":"CharSV5","id":32747446,"avatar_url":"https://avatars0.githubusercontent.com/u/32747446?v=4","gravatar_id":"","url":"https://api.github.com/users/CharSV5","html_url":"https://github.com/CharSV5","followers_url":"https://api.github.com/users/CharSV5/followers","following_url":"https://api.github.com/users/CharSV5/following{/other_user}","gists_url":"https://api.github.com/users/CharSV5/gists{/gist_id}","starred_url":"https://api.github.com/users/CharSV5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CharSV5/subscriptions","organizations_url":"https://api.github.com/users/CharSV5/orgs","repos_url":"https://api.github.com/users/CharSV5/repos","events_url":"https://api.github.com/users/CharSV5/events{/privacy}","received_events_url":"https://api.github.com/users/CharSV5/received_events","type":"User","site_admin":false},"repo":{"id":125651370,"name":"chitter-challenge","full_name":"CharSV5/chitter-challenge","owner":{"login":"CharSV5","id":32747446,"avatar_url":"https://avatars0.githubusercontent.com/u/32747446?v=4","gravatar_id":"","url":"https://api.github.com/users/CharSV5","html_url":"https://github.com/CharSV5","followers_url":"https://api.github.com/users/CharSV5/followers","following_url":"https://api.github.com/users/CharSV5/following{/other_user}","gists_url":"https://api.github.com/users/CharSV5/gists{/gist_id}","starred_url":"https://api.github.com/users/CharSV5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CharSV5/subscriptions","organizations_url":"https://api.github.com/users/CharSV5/orgs","repos_url":"https://api.github.com/users/CharSV5/repos","events_url":"https://api.github.com/users/CharSV5/events{/privacy}","received_events_url":"https://api.github.com/users/CharSV5/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CharSV5/chitter-challenge","description":"Build a Twitter Clone!","fork":true,"url":"https://api.github.com/repos/CharSV5/chitter-challenge","forks_url":"https://api.github.com/repos/CharSV5/chitter-challenge/forks","keys_url":"https://api.github.com/repos/CharSV5/chitter-challenge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CharSV5/chitter-challenge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CharSV5/chitter-challenge/teams","hooks_url":"https://api.github.com/repos/CharSV5/chitter-challenge/hooks","issue_events_url":"https://api.github.com/repos/CharSV5/chitter-challenge/issues/events{/number}","events_url":"https://api.github.com/repos/CharSV5/chitter-challenge/events","assignees_url":"https://api.github.com/repos/CharSV5/chitter-challenge/assignees{/user}","branches_url":"https://api.github.com/repos/CharSV5/chitter-challenge/branches{/branch}","tags_url":"https://api.github.com/repos/CharSV5/chitter-challenge/tags","blobs_url":"https://api.github.com/repos/CharSV5/chitter-challenge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CharSV5/chitter-challenge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CharSV5/chitter-challenge/git/refs{/sha}","trees_url":"https://api.github.com/repos/CharSV5/chitter-challenge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CharSV5/chitter-challenge/statuses/{sha}","languages_url":"https://api.github.com/repos/CharSV5/chitter-challenge/languages","stargazers_url":"https://api.github.com/repos/CharSV5/chitter-challenge/stargazers","contributors_url":"https://api.github.com/repos/CharSV5/chitter-challenge/contributors","subscribers_url":"https://api.github.com/repos/CharSV5/chitter-challenge/subscribers","subscription_url":"https://api.github.com/repos/CharSV5/chitter-challenge/subscription","commits_url":"https://api.github.com/repos/CharSV5/chitter-challenge/commits{/sha}","git_commits_url":"https://api.github.com/repos/CharSV5/chitter-challenge/git/commits{/sha}","comments_url":"https://api.github.com/repos/CharSV5/chitter-challenge/comments{/number}","issue_comment_url":"https://api.github.com/repos/CharSV5/chitter-challenge/issues/comments{/number}","contents_url":"https://api.github.com/repos/CharSV5/chitter-challenge/contents/{+path}","compare_url":"https://api.github.com/repos/CharSV5/chitter-challenge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CharSV5/chitter-challenge/merges","archive_url":"https://api.github.com/repos/CharSV5/chitter-challenge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CharSV5/chitter-challenge/downloads","issues_url":"https://api.github.com/repos/CharSV5/chitter-challenge/issues{/number}","pulls_url":"https://api.github.com/repos/CharSV5/chitter-challenge/pulls{/number}","milestones_url":"https://api.github.com/repos/CharSV5/chitter-challenge/milestones{/number}","notifications_url":"https://api.github.com/repos/CharSV5/chitter-challenge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CharSV5/chitter-challenge/labels{/name}","releases_url":"https://api.github.com/repos/CharSV5/chitter-challenge/releases{/id}","deployments_url":"https://api.github.com/repos/CharSV5/chitter-challenge/deployments","created_at":"2018-03-17T17:04:56Z","updated_at":"2018-03-18T20:54:21Z","pushed_at":"2018-03-18T20:54:19Z","git_url":"git://github.com/CharSV5/chitter-challenge.git","ssh_url":"[email protected]:CharSV5/chitter-challenge.git","clone_url":"https://github.com/CharSV5/chitter-challenge.git","svn_url":"https://github.com/CharSV5/chitter-challenge","homepage":null,"size":392,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"makersacademy:master","ref":"master","sha":"6b620101240bd73392b359e0da6273ba56054969","user":{"login":"makersacademy","id":3636186,"avatar_url":"https://avatars2.githubusercontent.com/u/3636186?v=4","gravatar_id":"","url":"https://api.github.com/users/makersacademy","html_url":"https://github.com/makersacademy","followers_url":"https://api.github.com/users/makersacademy/followers","following_url":"https://api.github.com/users/makersacademy/following{/other_user}","gists_url":"https://api.github.com/users/makersacademy/gists{/gist_id}","starred_url":"https://api.github.com/users/makersacademy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makersacademy/subscriptions","organizations_url":"https://api.github.com/users/makersacademy/orgs","repos_url":"https://api.github.com/users/makersacademy/repos","events_url":"https://api.github.com/users/makersacademy/events{/privacy}","received_events_url":"https://api.github.com/users/makersacademy/received_events","type":"Organization","site_admin":false},"repo":{"id":26954706,"name":"chitter-challenge","full_name":"makersacademy/chitter-challenge","owner":{"login":"makersacademy","id":3636186,"avatar_url":"https://avatars2.githubusercontent.com/u/3636186?v=4","gravatar_id":"","url":"https://api.github.com/users/makersacademy","html_url":"https://github.com/makersacademy","followers_url":"https://api.github.com/users/makersacademy/followers","following_url":"https://api.github.com/users/makersacademy/following{/other_user}","gists_url":"https://api.github.com/users/makersacademy/gists{/gist_id}","starred_url":"https://api.github.com/users/makersacademy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makersacademy/subscriptions","organizations_url":"https://api.github.com/users/makersacademy/orgs","repos_url":"https://api.github.com/users/makersacademy/repos","events_url":"https://api.github.com/users/makersacademy/events{/privacy}","received_events_url":"https://api.github.com/users/makersacademy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/makersacademy/chitter-challenge","description":"Build a Twitter Clone!","fork":false,"url":"https://api.github.com/repos/makersacademy/chitter-challenge","forks_url":"https://api.github.com/repos/makersacademy/chitter-challenge/forks","keys_url":"https://api.github.com/repos/makersacademy/chitter-challenge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/makersacademy/chitter-challenge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/makersacademy/chitter-challenge/teams","hooks_url":"https://api.github.com/repos/makersacademy/chitter-challenge/hooks","issue_events_url":"https://api.github.com/repos/makersacademy/chitter-challenge/issues/events{/number}","events_url":"https://api.github.com/repos/makersacademy/chitter-challenge/events","assignees_url":"https://api.github.com/repos/makersacademy/chitter-challenge/assignees{/user}","branches_url":"https://api.github.com/repos/makersacademy/chitter-challenge/branches{/branch}","tags_url":"https://api.github.com/repos/makersacademy/chitter-challenge/tags","blobs_url":"https://api.github.com/repos/makersacademy/chitter-challenge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/makersacademy/chitter-challenge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/makersacademy/chitter-challenge/git/refs{/sha}","trees_url":"https://api.github.com/repos/makersacademy/chitter-challenge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/makersacademy/chitter-challenge/statuses/{sha}","languages_url":"https://api.github.com/repos/makersacademy/chitter-challenge/languages","stargazers_url":"https://api.github.com/repos/makersacademy/chitter-challenge/stargazers","contributors_url":"https://api.github.com/repos/makersacademy/chitter-challenge/contributors","subscribers_url":"https://api.github.com/repos/makersacademy/chitter-challenge/subscribers","subscription_url":"https://api.github.com/repos/makersacademy/chitter-challenge/subscription","commits_url":"https://api.github.com/repos/makersacademy/chitter-challenge/commits{/sha}","git_commits_url":"https://api.github.com/repos/makersacademy/chitter-challenge/git/commits{/sha}","comments_url":"https://api.github.com/repos/makersacademy/chitter-challenge/comments{/number}","issue_comment_url":"https://api.github.com/repos/makersacademy/chitter-challenge/issues/comments{/number}","contents_url":"https://api.github.com/repos/makersacademy/chitter-challenge/contents/{+path}","compare_url":"https://api.github.com/repos/makersacademy/chitter-challenge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/makersacademy/chitter-challenge/merges","archive_url":"https://api.github.com/repos/makersacademy/chitter-challenge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/makersacademy/chitter-challenge/downloads","issues_url":"https://api.github.com/repos/makersacademy/chitter-challenge/issues{/number}","pulls_url":"https://api.github.com/repos/makersacademy/chitter-challenge/pulls{/number}","milestones_url":"https://api.github.com/repos/makersacademy/chitter-challenge/milestones{/number}","notifications_url":"https://api.github.com/repos/makersacademy/chitter-challenge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/makersacademy/chitter-challenge/labels{/name}","releases_url":"https://api.github.com/repos/makersacademy/chitter-challenge/releases{/id}","deployments_url":"https://api.github.com/repos/makersacademy/chitter-challenge/deployments","created_at":"2014-11-21T09:53:31Z","updated_at":"2018-02-20T20:03:18Z","pushed_at":"2018-03-18T20:56:43Z","git_url":"git://github.com/makersacademy/chitter-challenge.git","ssh_url":"[email protected]:makersacademy/chitter-challenge.git","clone_url":"https://github.com/makersacademy/chitter-challenge.git","svn_url":"https://github.com/makersacademy/chitter-challenge","homepage":null,"size":392,"stargazers_count":6,"watchers_count":6,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":870,"mirror_url":null,"archived":false,"open_issues_count":24,"license":null,"forks":870,"open_issues":24,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/makersacademy/chitter-challenge/pulls/877"},"html":{"href":"https://github.com/makersacademy/chitter-challenge/pull/877"},"issue":{"href":"https://api.github.com/repos/makersacademy/chitter-challenge/issues/877"},"comments":{"href":"https://api.github.com/repos/makersacademy/chitter-challenge/issues/877/comments"},"review_comments":{"href":"https://api.github.com/repos/makersacademy/chitter-challenge/pulls/877/comments"},"review_comment":{"href":"https://api.github.com/repos/makersacademy/chitter-challenge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/makersacademy/chitter-challenge/pulls/877/commits"},"statuses":{"href":"https://api.github.com/repos/makersacademy/chitter-challenge/statuses/8f892aafa12fe5aa3e3023c9de6a46cab9ab8c4e"}},"author_association":"NONE"}} | {
"id": 26954706,
"name": "makersacademy/chitter-challenge",
"url": "https://api.github.com/repos/makersacademy/chitter-challenge"
} | {
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
} | {
"id": 3636186,
"login": "makersacademy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3636186?",
"url": "https://api.github.com/orgs/makersacademy"
} | 2018-03-18T20:56:59 | 7397311268 | {"actor":{"display_login":"houndci-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/219794947","pull_request_review_id":158050080,"id":219794947,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTc5NDk0Nw==","diff_hunk":"@@ -166,12 +166,12 @@ export default interface Eth {\n ): Promise<EncodedTransaction>;\n sendSignedTransaction(\n data: string,\n- cb?: Callback<string>\n- ): PromiEvent<TransactionReceipt>;\n+ cb?: Callback<TransactionReceipt | string | { confNumber: number, receipt: TransactionReceipt }>\n+ ): PromiEvent<TransactionReceipt | string | { confNumber: number, receipt: TransactionReceipt }>;","path":"types/web3/eth/index.d.ts","position":7,"original_position":7,"commit_id":"8c5482e2a84cbdbd03fe4623ecd7177e752bd3fa","original_commit_id":"8c5482e2a84cbdbd03fe4623ecd7177e752bd3fa","user":{"login":"Levino","id":1150767,"node_id":"MDQ6VXNlcjExNTA3Njc=","avatar_url":"https://avatars1.githubusercontent.com/u/1150767?v=4","gravatar_id":"","url":"https://api.github.com/users/Levino","html_url":"https://github.com/Levino","followers_url":"https://api.github.com/users/Levino/followers","following_url":"https://api.github.com/users/Levino/following{/other_user}","gists_url":"https://api.github.com/users/Levino/gists{/gist_id}","starred_url":"https://api.github.com/users/Levino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Levino/subscriptions","organizations_url":"https://api.github.com/users/Levino/orgs","repos_url":"https://api.github.com/users/Levino/repos","events_url":"https://api.github.com/users/Levino/events{/privacy}","received_events_url":"https://api.github.com/users/Levino/received_events","type":"User","site_admin":false},"body":"I am not sure how the PromiEvent is exactly typed, but the promise part of this will only resolve with the \"hash\" if I understand correctly. There are also some events on it that send the `receipt` and the `confirmationNumber` but these are not passed to the resolve function of the promise. (This kind of \"rx js\" behaviour of this promise is overcomplex I find, but what can we do here?)","created_at":"2018-09-24T10:49:38Z","updated_at":"2018-09-24T10:50:22Z","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/29091#discussion_r219794947","pull_request_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/29091","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/219794947"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/29091#discussion_r219794947"},"pull_request":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/29091"}}},"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/29091","id":217299721,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3Mjk5NzIx","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/29091","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/29091.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/29091.patch","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/29091","number":29091,"state":"open","locked":false,"title":"[web3]: improve sendTransaction callback","user":{"login":"dkent600","id":1821666,"node_id":"MDQ6VXNlcjE4MjE2NjY=","avatar_url":"https://avatars0.githubusercontent.com/u/1821666?v=4","gravatar_id":"","url":"https://api.github.com/users/dkent600","html_url":"https://github.com/dkent600","followers_url":"https://api.github.com/users/dkent600/followers","following_url":"https://api.github.com/users/dkent600/following{/other_user}","gists_url":"https://api.github.com/users/dkent600/gists{/gist_id}","starred_url":"https://api.github.com/users/dkent600/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkent600/subscriptions","organizations_url":"https://api.github.com/users/dkent600/orgs","repos_url":"https://api.github.com/users/dkent600/repos","events_url":"https://api.github.com/users/dkent600/events{/privacy}","received_events_url":"https://api.github.com/users/dkent600/received_events","type":"User","site_admin":false},"body":"This PR modifies the callback definition on `sendTransaction` and `sendSignedTransaction` to respect the different types that may be returned by the callback.","created_at":"2018-09-21T14:20:05Z","updated_at":"2018-09-24T10:50:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5d480bc626a9f16f661f147c4375920c0f7dfd0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":395679059,"node_id":"MDU6TGFiZWwzOTU2NzkwNTk=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Revision%20needed","name":"Revision needed","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/29091/commits","review_comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/29091/comments","review_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/29091/comments","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/8c5482e2a84cbdbd03fe4623ecd7177e752bd3fa","head":{"label":"dkent600:improveSendTransaction","ref":"improveSendTransaction","sha":"8c5482e2a84cbdbd03fe4623ecd7177e752bd3fa","user":{"login":"dkent600","id":1821666,"node_id":"MDQ6VXNlcjE4MjE2NjY=","avatar_url":"https://avatars0.githubusercontent.com/u/1821666?v=4","gravatar_id":"","url":"https://api.github.com/users/dkent600","html_url":"https://github.com/dkent600","followers_url":"https://api.github.com/users/dkent600/followers","following_url":"https://api.github.com/users/dkent600/following{/other_user}","gists_url":"https://api.github.com/users/dkent600/gists{/gist_id}","starred_url":"https://api.github.com/users/dkent600/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkent600/subscriptions","organizations_url":"https://api.github.com/users/dkent600/orgs","repos_url":"https://api.github.com/users/dkent600/repos","events_url":"https://api.github.com/users/dkent600/events{/privacy}","received_events_url":"https://api.github.com/users/dkent600/received_events","type":"User","site_admin":false},"repo":{"id":149521865,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk1MjE4NjU=","name":"DefinitelyTyped","full_name":"dkent600/DefinitelyTyped","private":false,"owner":{"login":"dkent600","id":1821666,"node_id":"MDQ6VXNlcjE4MjE2NjY=","avatar_url":"https://avatars0.githubusercontent.com/u/1821666?v=4","gravatar_id":"","url":"https://api.github.com/users/dkent600","html_url":"https://github.com/dkent600","followers_url":"https://api.github.com/users/dkent600/followers","following_url":"https://api.github.com/users/dkent600/following{/other_user}","gists_url":"https://api.github.com/users/dkent600/gists{/gist_id}","starred_url":"https://api.github.com/users/dkent600/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkent600/subscriptions","organizations_url":"https://api.github.com/users/dkent600/orgs","repos_url":"https://api.github.com/users/dkent600/repos","events_url":"https://api.github.com/users/dkent600/events{/privacy}","received_events_url":"https://api.github.com/users/dkent600/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dkent600/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/dkent600/DefinitelyTyped","forks_url":"https://api.github.com/repos/dkent600/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/dkent600/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dkent600/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dkent600/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/dkent600/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/dkent600/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/dkent600/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/dkent600/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/dkent600/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/dkent600/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/dkent600/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dkent600/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dkent600/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/dkent600/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dkent600/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/dkent600/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/dkent600/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/dkent600/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/dkent600/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/dkent600/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/dkent600/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/dkent600/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/dkent600/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/dkent600/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/dkent600/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/dkent600/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dkent600/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/dkent600/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dkent600/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/dkent600/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/dkent600/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/dkent600/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/dkent600/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dkent600/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/dkent600/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/dkent600/DefinitelyTyped/deployments","created_at":"2018-09-19T23:01:41Z","updated_at":"2018-09-21T15:34:38Z","pushed_at":"2018-09-21T21:39:28Z","git_url":"git://github.com/dkent600/DefinitelyTyped.git","ssh_url":"[email protected]:dkent600/DefinitelyTyped.git","clone_url":"https://github.com/dkent600/DefinitelyTyped.git","svn_url":"https://github.com/dkent600/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":357344,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DefinitelyTyped:master","ref":"master","sha":"fdb583ed26aac613aad220d788101cc4c3855d35","user":{"login":"DefinitelyTyped","id":3637556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2Mzc1NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"repo":{"id":6093316,"node_id":"MDEwOlJlcG9zaXRvcnk2MDkzMzE2","name":"DefinitelyTyped","full_name":"DefinitelyTyped/DefinitelyTyped","private":false,"owner":{"login":"DefinitelyTyped","id":3637556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2Mzc1NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":false,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","forks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/deployments","created_at":"2012-10-05T16:39:45Z","updated_at":"2018-09-24T07:29:07Z","pushed_at":"2018-09-24T10:46:49Z","git_url":"git://github.com/DefinitelyTyped/DefinitelyTyped.git","ssh_url":"[email protected]:DefinitelyTyped/DefinitelyTyped.git","clone_url":"https://github.com/DefinitelyTyped/DefinitelyTyped.git","svn_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":358414,"stargazers_count":17564,"watchers_count":17564,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14642,"mirror_url":null,"archived":false,"open_issues_count":2400,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":14642,"open_issues":2400,"watchers":17564,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/29091"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/29091"},"issue":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/29091"},"comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/29091/comments"},"review_comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/29091/comments"},"review_comment":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/29091/commits"},"statuses":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/8c5482e2a84cbdbd03fe4623ecd7177e752bd3fa"}},"author_association":"NONE"}} | {
"id": 6093316,
"name": "DefinitelyTyped/DefinitelyTyped",
"url": "https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped"
} | {
"id": 1150767,
"login": "Levino",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1150767?",
"url": "https://api.github.com/users/Levino"
} | {
"id": 3637556,
"login": "DefinitelyTyped",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3637556?",
"url": "https://api.github.com/orgs/DefinitelyTyped"
} | 2018-09-24T10:49:38 | 8310463859 | {"actor":{"display_login":"Levino"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/idaholab/raven/pulls/comments/233899410","pull_request_review_id":175419981,"id":233899410,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzg5OTQxMA==","diff_hunk":"@@ -382,37 +383,38 @@ def submit(self, myInput, samplerType, jobHandler, **kwargs):\n ## works, we are unable to pass a member function as a job because the\n ## pp library loses track of what self is, so instead we call it from the\n ## class and pass self in as the first parameter\n- jobHandler.addJob((self, myInput, samplerType, kwargs), self.__class__.evaluateSample, prefix, metadata=metadata, modulesToImport=self.mods, uniqueHandler=uniqueHandler)\n+ jobHandler.addJob((self, myInput, samplerType, kwargs), self.__class__.evaluateSample, prefix, metadata=metadata, modulesToImport=self.mods, uniqueHandler=uniqueHandler, forceUseThreads=forceThreads)\n \n- def submitAsClient(self, myInput, samplerType, jobHandler, **kwargs):\n- \"\"\"\n- This will submit an individual sample to be evaluated by this model to a\n- specified jobHandler as a client job. Note, some parameters are needed\n- by createNewInput and thus descriptions are copied from there.\n- @ In, myInput, list, the inputs (list) to start from to generate the new\n- one\n- @ In, samplerType, string, is the type of sampler that is calling to\n- generate a new input\n- @ In, jobHandler, JobHandler instance, the global job handler instance\n- @ In, **kwargs, dict, is a dictionary that contains the information\n- coming from the sampler, a mandatory key is the sampledVars' that\n- contains a dictionary {'name variable':value}\n- @ Out, None\n- \"\"\"\n- prefix = kwargs['prefix'] if 'prefix' in kwargs else None\n- uniqueHandler = kwargs['uniqueHandler'] if 'uniqueHandler' in kwargs.keys() else 'any'\n+ #def submitAsClient(self, myInput, samplerType, jobHandler, **kwargs):\n+ #\"\"\"\n+ #This will submit an individual sample to be evaluated by this model to a\n+ #specified jobHandler as a client job. Note, some parameters are needed\n+ #by createNewInput and thus descriptions are copied from there.\n+ #@ In, myInput, list, the inputs (list) to start from to generate the new\n+ #one\n+ #@ In, samplerType, string, is the type of sampler that is calling to\n+ #generate a new input\n+ #@ In, jobHandler, JobHandler instance, the global job handler instance\n+ #@ In, **kwargs, dict, is a dictionary that contains the information\n+ #coming from the sampler, a mandatory key is the sampledVars' that\n+ #contains a dictionary {'name variable':value}\n+ #@ Out, None\n+ #\"\"\"\n+ #prefix = kwargs.get(\"prefix\") \n+ #uniqueHandler = kwargs.get(\"uniqueHandler\",'any')\n+ #forceThreads = kwargs.get(\"forceThreads\",False)","path":"framework/Models/Model.py","position":53,"original_position":53,"commit_id":"5ffb6cadc8cfb6596ae92fde0ec599db7c5190bf","original_commit_id":"5ffb6cadc8cfb6596ae92fde0ec599db7c5190bf","user":{"login":"PaulTalbot-INL","id":2044370,"node_id":"MDQ6VXNlcjIwNDQzNzA=","avatar_url":"https://avatars1.githubusercontent.com/u/2044370?v=4","gravatar_id":"","url":"https://api.github.com/users/PaulTalbot-INL","html_url":"https://github.com/PaulTalbot-INL","followers_url":"https://api.github.com/users/PaulTalbot-INL/followers","following_url":"https://api.github.com/users/PaulTalbot-INL/following{/other_user}","gists_url":"https://api.github.com/users/PaulTalbot-INL/gists{/gist_id}","starred_url":"https://api.github.com/users/PaulTalbot-INL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaulTalbot-INL/subscriptions","organizations_url":"https://api.github.com/users/PaulTalbot-INL/orgs","repos_url":"https://api.github.com/users/PaulTalbot-INL/repos","events_url":"https://api.github.com/users/PaulTalbot-INL/events{/privacy}","received_events_url":"https://api.github.com/users/PaulTalbot-INL/received_events","type":"User","site_admin":false},"body":"Can we add a comment explaining why we are saving this material, and on what conditions it can be removed?","created_at":"2018-11-15T15:52:24Z","updated_at":"2018-11-15T15:53:46Z","html_url":"https://github.com/idaholab/raven/pull/844#discussion_r233899410","pull_request_url":"https://api.github.com/repos/idaholab/raven/pulls/844","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/idaholab/raven/pulls/comments/233899410"},"html":{"href":"https://github.com/idaholab/raven/pull/844#discussion_r233899410"},"pull_request":{"href":"https://api.github.com/repos/idaholab/raven/pulls/844"}}},"pull_request":{"url":"https://api.github.com/repos/idaholab/raven/pulls/844","id":230589782,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNTg5Nzgy","html_url":"https://github.com/idaholab/raven/pull/844","diff_url":"https://github.com/idaholab/raven/pull/844.diff","patch_url":"https://github.com/idaholab/raven/pull/844.patch","issue_url":"https://api.github.com/repos/idaholab/raven/issues/844","number":844,"state":"open","locked":false,"title":"Alfoa/generic codeinterface fix","user":{"login":"alfoa","id":9202671,"node_id":"MDQ6VXNlcjkyMDI2NzE=","avatar_url":"https://avatars0.githubusercontent.com/u/9202671?v=4","gravatar_id":"","url":"https://api.github.com/users/alfoa","html_url":"https://github.com/alfoa","followers_url":"https://api.github.com/users/alfoa/followers","following_url":"https://api.github.com/users/alfoa/following{/other_user}","gists_url":"https://api.github.com/users/alfoa/gists{/gist_id}","starred_url":"https://api.github.com/users/alfoa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfoa/subscriptions","organizations_url":"https://api.github.com/users/alfoa/orgs","repos_url":"https://api.github.com/users/alfoa/repos","events_url":"https://api.github.com/users/alfoa/events{/privacy}","received_events_url":"https://api.github.com/users/alfoa/received_events","type":"User","site_admin":false},"body":"--------\r\nPull Request Description\r\n--------\r\n##### What issue does this change request address? (Use \"#\" before the issue to link it, i.e., #42.)\r\n\r\nCloses #843\r\n\r\n##### What are the significant changes in functionality due to this change request?\r\n\r\n\r\n----------------\r\nFor Change Control Board: Change Request Review\r\n----------------\r\nThe following review must be completed by an authorized member of the Change Control Board.\r\n- [ ] 1. Review all computer code.\r\n- [ ] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).\r\n- [ ] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the [wiki](https://github.com/idaholab/raven/wiki/RAVEN-Code-Standards#python) for details.\r\n- [ ] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.\r\n- [ ] 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in <RunInfo> XML block, the node ```<internalParallel>``` to True.\r\n- [ ] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.\r\n- [ ] 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.\r\n- [ ] 8. If an analytic test is changed/added is the the analytic documentation updated/added?\r\n","created_at":"2018-11-13T19:02:44Z","updated_at":"2018-11-15T15:53:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d3664c72c7e2ff6505c367653505e0ddeafd3a31","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":581880378,"node_id":"MDU6TGFiZWw1ODE4ODAzNzg=","url":"https://api.github.com/repos/idaholab/raven/labels/defect","name":"defect","color":"b60205","default":false},{"id":570314579,"node_id":"MDU6TGFiZWw1NzAzMTQ1Nzk=","url":"https://api.github.com/repos/idaholab/raven/labels/priority_critical","name":"priority_critical","color":"d93f0b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/idaholab/raven/pulls/844/commits","review_comments_url":"https://api.github.com/repos/idaholab/raven/pulls/844/comments","review_comment_url":"https://api.github.com/repos/idaholab/raven/pulls/comments{/number}","comments_url":"https://api.github.com/repos/idaholab/raven/issues/844/comments","statuses_url":"https://api.github.com/repos/idaholab/raven/statuses/5ffb6cadc8cfb6596ae92fde0ec599db7c5190bf","head":{"label":"idaholab:alfoa/genericCodeinterfaceFix","ref":"alfoa/genericCodeinterfaceFix","sha":"5ffb6cadc8cfb6596ae92fde0ec599db7c5190bf","user":{"login":"idaholab","id":3855370,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NTUzNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/3855370?v=4","gravatar_id":"","url":"https://api.github.com/users/idaholab","html_url":"https://github.com/idaholab","followers_url":"https://api.github.com/users/idaholab/followers","following_url":"https://api.github.com/users/idaholab/following{/other_user}","gists_url":"https://api.github.com/users/idaholab/gists{/gist_id}","starred_url":"https://api.github.com/users/idaholab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idaholab/subscriptions","organizations_url":"https://api.github.com/users/idaholab/orgs","repos_url":"https://api.github.com/users/idaholab/repos","events_url":"https://api.github.com/users/idaholab/events{/privacy}","received_events_url":"https://api.github.com/users/idaholab/received_events","type":"Organization","site_admin":false},"repo":{"id":85989537,"node_id":"MDEwOlJlcG9zaXRvcnk4NTk4OTUzNw==","name":"raven","full_name":"idaholab/raven","private":false,"owner":{"login":"idaholab","id":3855370,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NTUzNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/3855370?v=4","gravatar_id":"","url":"https://api.github.com/users/idaholab","html_url":"https://github.com/idaholab","followers_url":"https://api.github.com/users/idaholab/followers","following_url":"https://api.github.com/users/idaholab/following{/other_user}","gists_url":"https://api.github.com/users/idaholab/gists{/gist_id}","starred_url":"https://api.github.com/users/idaholab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idaholab/subscriptions","organizations_url":"https://api.github.com/users/idaholab/orgs","repos_url":"https://api.github.com/users/idaholab/repos","events_url":"https://api.github.com/users/idaholab/events{/privacy}","received_events_url":"https://api.github.com/users/idaholab/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/idaholab/raven","description":"RAVEN is a flexible and multi-purpose probabilistic risk analysis, uncertainty quantification, parameter optimization and data knowledge-discovering framework.","fork":false,"url":"https://api.github.com/repos/idaholab/raven","forks_url":"https://api.github.com/repos/idaholab/raven/forks","keys_url":"https://api.github.com/repos/idaholab/raven/keys{/key_id}","collaborators_url":"https://api.github.com/repos/idaholab/raven/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/idaholab/raven/teams","hooks_url":"https://api.github.com/repos/idaholab/raven/hooks","issue_events_url":"https://api.github.com/repos/idaholab/raven/issues/events{/number}","events_url":"https://api.github.com/repos/idaholab/raven/events","assignees_url":"https://api.github.com/repos/idaholab/raven/assignees{/user}","branches_url":"https://api.github.com/repos/idaholab/raven/branches{/branch}","tags_url":"https://api.github.com/repos/idaholab/raven/tags","blobs_url":"https://api.github.com/repos/idaholab/raven/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/idaholab/raven/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/idaholab/raven/git/refs{/sha}","trees_url":"https://api.github.com/repos/idaholab/raven/git/trees{/sha}","statuses_url":"https://api.github.com/repos/idaholab/raven/statuses/{sha}","languages_url":"https://api.github.com/repos/idaholab/raven/languages","stargazers_url":"https://api.github.com/repos/idaholab/raven/stargazers","contributors_url":"https://api.github.com/repos/idaholab/raven/contributors","subscribers_url":"https://api.github.com/repos/idaholab/raven/subscribers","subscription_url":"https://api.github.com/repos/idaholab/raven/subscription","commits_url":"https://api.github.com/repos/idaholab/raven/commits{/sha}","git_commits_url":"https://api.github.com/repos/idaholab/raven/git/commits{/sha}","comments_url":"https://api.github.com/repos/idaholab/raven/comments{/number}","issue_comment_url":"https://api.github.com/repos/idaholab/raven/issues/comments{/number}","contents_url":"https://api.github.com/repos/idaholab/raven/contents/{+path}","compare_url":"https://api.github.com/repos/idaholab/raven/compare/{base}...{head}","merges_url":"https://api.github.com/repos/idaholab/raven/merges","archive_url":"https://api.github.com/repos/idaholab/raven/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/idaholab/raven/downloads","issues_url":"https://api.github.com/repos/idaholab/raven/issues{/number}","pulls_url":"https://api.github.com/repos/idaholab/raven/pulls{/number}","milestones_url":"https://api.github.com/repos/idaholab/raven/milestones{/number}","notifications_url":"https://api.github.com/repos/idaholab/raven/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/idaholab/raven/labels{/name}","releases_url":"https://api.github.com/repos/idaholab/raven/releases{/id}","deployments_url":"https://api.github.com/repos/idaholab/raven/deployments","created_at":"2017-03-23T19:29:27Z","updated_at":"2018-11-15T15:48:25Z","pushed_at":"2018-11-15T15:51:51Z","git_url":"git://github.com/idaholab/raven.git","ssh_url":"[email protected]:idaholab/raven.git","clone_url":"https://github.com/idaholab/raven.git","svn_url":"https://github.com/idaholab/raven","homepage":"https://raven.inl.gov/","size":559451,"stargazers_count":42,"watchers_count":42,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":231,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":34,"open_issues":231,"watchers":42,"default_branch":"devel"}},"base":{"label":"idaholab:devel","ref":"devel","sha":"a87baededaaf4ceb73ec05876f610a3aa8a06dfc","user":{"login":"idaholab","id":3855370,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NTUzNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/3855370?v=4","gravatar_id":"","url":"https://api.github.com/users/idaholab","html_url":"https://github.com/idaholab","followers_url":"https://api.github.com/users/idaholab/followers","following_url":"https://api.github.com/users/idaholab/following{/other_user}","gists_url":"https://api.github.com/users/idaholab/gists{/gist_id}","starred_url":"https://api.github.com/users/idaholab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idaholab/subscriptions","organizations_url":"https://api.github.com/users/idaholab/orgs","repos_url":"https://api.github.com/users/idaholab/repos","events_url":"https://api.github.com/users/idaholab/events{/privacy}","received_events_url":"https://api.github.com/users/idaholab/received_events","type":"Organization","site_admin":false},"repo":{"id":85989537,"node_id":"MDEwOlJlcG9zaXRvcnk4NTk4OTUzNw==","name":"raven","full_name":"idaholab/raven","private":false,"owner":{"login":"idaholab","id":3855370,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NTUzNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/3855370?v=4","gravatar_id":"","url":"https://api.github.com/users/idaholab","html_url":"https://github.com/idaholab","followers_url":"https://api.github.com/users/idaholab/followers","following_url":"https://api.github.com/users/idaholab/following{/other_user}","gists_url":"https://api.github.com/users/idaholab/gists{/gist_id}","starred_url":"https://api.github.com/users/idaholab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idaholab/subscriptions","organizations_url":"https://api.github.com/users/idaholab/orgs","repos_url":"https://api.github.com/users/idaholab/repos","events_url":"https://api.github.com/users/idaholab/events{/privacy}","received_events_url":"https://api.github.com/users/idaholab/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/idaholab/raven","description":"RAVEN is a flexible and multi-purpose probabilistic risk analysis, uncertainty quantification, parameter optimization and data knowledge-discovering framework.","fork":false,"url":"https://api.github.com/repos/idaholab/raven","forks_url":"https://api.github.com/repos/idaholab/raven/forks","keys_url":"https://api.github.com/repos/idaholab/raven/keys{/key_id}","collaborators_url":"https://api.github.com/repos/idaholab/raven/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/idaholab/raven/teams","hooks_url":"https://api.github.com/repos/idaholab/raven/hooks","issue_events_url":"https://api.github.com/repos/idaholab/raven/issues/events{/number}","events_url":"https://api.github.com/repos/idaholab/raven/events","assignees_url":"https://api.github.com/repos/idaholab/raven/assignees{/user}","branches_url":"https://api.github.com/repos/idaholab/raven/branches{/branch}","tags_url":"https://api.github.com/repos/idaholab/raven/tags","blobs_url":"https://api.github.com/repos/idaholab/raven/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/idaholab/raven/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/idaholab/raven/git/refs{/sha}","trees_url":"https://api.github.com/repos/idaholab/raven/git/trees{/sha}","statuses_url":"https://api.github.com/repos/idaholab/raven/statuses/{sha}","languages_url":"https://api.github.com/repos/idaholab/raven/languages","stargazers_url":"https://api.github.com/repos/idaholab/raven/stargazers","contributors_url":"https://api.github.com/repos/idaholab/raven/contributors","subscribers_url":"https://api.github.com/repos/idaholab/raven/subscribers","subscription_url":"https://api.github.com/repos/idaholab/raven/subscription","commits_url":"https://api.github.com/repos/idaholab/raven/commits{/sha}","git_commits_url":"https://api.github.com/repos/idaholab/raven/git/commits{/sha}","comments_url":"https://api.github.com/repos/idaholab/raven/comments{/number}","issue_comment_url":"https://api.github.com/repos/idaholab/raven/issues/comments{/number}","contents_url":"https://api.github.com/repos/idaholab/raven/contents/{+path}","compare_url":"https://api.github.com/repos/idaholab/raven/compare/{base}...{head}","merges_url":"https://api.github.com/repos/idaholab/raven/merges","archive_url":"https://api.github.com/repos/idaholab/raven/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/idaholab/raven/downloads","issues_url":"https://api.github.com/repos/idaholab/raven/issues{/number}","pulls_url":"https://api.github.com/repos/idaholab/raven/pulls{/number}","milestones_url":"https://api.github.com/repos/idaholab/raven/milestones{/number}","notifications_url":"https://api.github.com/repos/idaholab/raven/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/idaholab/raven/labels{/name}","releases_url":"https://api.github.com/repos/idaholab/raven/releases{/id}","deployments_url":"https://api.github.com/repos/idaholab/raven/deployments","created_at":"2017-03-23T19:29:27Z","updated_at":"2018-11-15T15:48:25Z","pushed_at":"2018-11-15T15:51:51Z","git_url":"git://github.com/idaholab/raven.git","ssh_url":"[email protected]:idaholab/raven.git","clone_url":"https://github.com/idaholab/raven.git","svn_url":"https://github.com/idaholab/raven","homepage":"https://raven.inl.gov/","size":559451,"stargazers_count":42,"watchers_count":42,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":231,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":34,"open_issues":231,"watchers":42,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/idaholab/raven/pulls/844"},"html":{"href":"https://github.com/idaholab/raven/pull/844"},"issue":{"href":"https://api.github.com/repos/idaholab/raven/issues/844"},"comments":{"href":"https://api.github.com/repos/idaholab/raven/issues/844/comments"},"review_comments":{"href":"https://api.github.com/repos/idaholab/raven/pulls/844/comments"},"review_comment":{"href":"https://api.github.com/repos/idaholab/raven/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/idaholab/raven/pulls/844/commits"},"statuses":{"href":"https://api.github.com/repos/idaholab/raven/statuses/5ffb6cadc8cfb6596ae92fde0ec599db7c5190bf"}},"author_association":"COLLABORATOR"}} | {
"id": 85989537,
"name": "idaholab/raven",
"url": "https://api.github.com/repos/idaholab/raven"
} | {
"id": 2044370,
"login": "PaulTalbot-INL",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2044370?",
"url": "https://api.github.com/users/PaulTalbot-INL"
} | {
"id": 3855370,
"login": "idaholab",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3855370?",
"url": "https://api.github.com/orgs/idaholab"
} | 2018-11-15T15:52:24 | 8596396486 | {"actor":{"display_login":"PaulTalbot-INL"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/idaholab/moose/pulls/comments/170934667","pull_request_review_id":99697392,"id":170934667,"diff_hunk":"@@ -17,7 +19,16 @@\n namespace hit\n {\n \n-const std::string indentString = \" \";\n+// returns the type of quoting used on string s (i.e. \" or ') or an empty string otherwise.\n+std::string","path":"framework/contrib/hit/parse.cc","position":15,"original_position":15,"commit_id":"fa2e38db5f2dd9f3f75b64f2fa053c9324bede0d","original_commit_id":"fa2e38db5f2dd9f3f75b64f2fa053c9324bede0d","user":{"login":"permcody","id":3036960,"avatar_url":"https://avatars2.githubusercontent.com/u/3036960?v=4","gravatar_id":"","url":"https://api.github.com/users/permcody","html_url":"https://github.com/permcody","followers_url":"https://api.github.com/users/permcody/followers","following_url":"https://api.github.com/users/permcody/following{/other_user}","gists_url":"https://api.github.com/users/permcody/gists{/gist_id}","starred_url":"https://api.github.com/users/permcody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/permcody/subscriptions","organizations_url":"https://api.github.com/users/permcody/orgs","repos_url":"https://api.github.com/users/permcody/repos","events_url":"https://api.github.com/users/permcody/events{/privacy}","received_events_url":"https://api.github.com/users/permcody/received_events","type":"User","site_admin":false},"body":"Consider a return type of `char`.","created_at":"2018-02-27T14:15:45Z","updated_at":"2018-02-27T14:19:23Z","html_url":"https://github.com/idaholab/moose/pull/10893#discussion_r170934667","pull_request_url":"https://api.github.com/repos/idaholab/moose/pulls/10893","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/idaholab/moose/pulls/comments/170934667"},"html":{"href":"https://github.com/idaholab/moose/pull/10893#discussion_r170934667"},"pull_request":{"href":"https://api.github.com/repos/idaholab/moose/pulls/10893"}}},"pull_request":{"url":"https://api.github.com/repos/idaholab/moose/pulls/10893","id":171121961,"html_url":"https://github.com/idaholab/moose/pull/10893","diff_url":"https://github.com/idaholab/moose/pull/10893.diff","patch_url":"https://github.com/idaholab/moose/pull/10893.patch","issue_url":"https://api.github.com/repos/idaholab/moose/issues/10893","number":10893,"state":"open","locked":false,"title":"hit: add support for reflowing long strings","user":{"login":"rwcarlsen","id":1351242,"avatar_url":"https://avatars2.githubusercontent.com/u/1351242?v=4","gravatar_id":"","url":"https://api.github.com/users/rwcarlsen","html_url":"https://github.com/rwcarlsen","followers_url":"https://api.github.com/users/rwcarlsen/followers","following_url":"https://api.github.com/users/rwcarlsen/following{/other_user}","gists_url":"https://api.github.com/users/rwcarlsen/gists{/gist_id}","starred_url":"https://api.github.com/users/rwcarlsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwcarlsen/subscriptions","organizations_url":"https://api.github.com/users/rwcarlsen/orgs","repos_url":"https://api.github.com/users/rwcarlsen/repos","events_url":"https://api.github.com/users/rwcarlsen/events{/privacy}","received_events_url":"https://api.github.com/users/rwcarlsen/received_events","type":"User","site_admin":false},"body":"This does not add any formal auto-formatting support, but is helping to lay the groundwork for a canonical moose input file style enforceable with auto-formatting.\r\n\r\nAlso fix handling of blank lines and inline comments. PR #10883 broke blank line and comment handling. The new consecutive string literal syntax was causing blank line tokens after the last string literal to be \"eaten\" as part of the string field node by the parser. This adds tests that should prevent such regressions in addition to fixing the issue. Fixes #10889","created_at":"2018-02-23T21:36:11Z","updated_at":"2018-02-27T14:19:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"70c0e9da540d9d0bdedddfa9abf81f629249531f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/idaholab/moose/pulls/10893/commits","review_comments_url":"https://api.github.com/repos/idaholab/moose/pulls/10893/comments","review_comment_url":"https://api.github.com/repos/idaholab/moose/pulls/comments{/number}","comments_url":"https://api.github.com/repos/idaholab/moose/issues/10893/comments","statuses_url":"https://api.github.com/repos/idaholab/moose/statuses/fa2e38db5f2dd9f3f75b64f2fa053c9324bede0d","head":{"label":"rwcarlsen:hit-reflow","ref":"hit-reflow","sha":"fa2e38db5f2dd9f3f75b64f2fa053c9324bede0d","user":{"login":"rwcarlsen","id":1351242,"avatar_url":"https://avatars2.githubusercontent.com/u/1351242?v=4","gravatar_id":"","url":"https://api.github.com/users/rwcarlsen","html_url":"https://github.com/rwcarlsen","followers_url":"https://api.github.com/users/rwcarlsen/followers","following_url":"https://api.github.com/users/rwcarlsen/following{/other_user}","gists_url":"https://api.github.com/users/rwcarlsen/gists{/gist_id}","starred_url":"https://api.github.com/users/rwcarlsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwcarlsen/subscriptions","organizations_url":"https://api.github.com/users/rwcarlsen/orgs","repos_url":"https://api.github.com/users/rwcarlsen/repos","events_url":"https://api.github.com/users/rwcarlsen/events{/privacy}","received_events_url":"https://api.github.com/users/rwcarlsen/received_events","type":"User","site_admin":false},"repo":{"id":68224891,"name":"moose","full_name":"rwcarlsen/moose","owner":{"login":"rwcarlsen","id":1351242,"avatar_url":"https://avatars2.githubusercontent.com/u/1351242?v=4","gravatar_id":"","url":"https://api.github.com/users/rwcarlsen","html_url":"https://github.com/rwcarlsen","followers_url":"https://api.github.com/users/rwcarlsen/followers","following_url":"https://api.github.com/users/rwcarlsen/following{/other_user}","gists_url":"https://api.github.com/users/rwcarlsen/gists{/gist_id}","starred_url":"https://api.github.com/users/rwcarlsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwcarlsen/subscriptions","organizations_url":"https://api.github.com/users/rwcarlsen/orgs","repos_url":"https://api.github.com/users/rwcarlsen/repos","events_url":"https://api.github.com/users/rwcarlsen/events{/privacy}","received_events_url":"https://api.github.com/users/rwcarlsen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rwcarlsen/moose","description":"Multiphysics Object Oriented Simulation Environment","fork":true,"url":"https://api.github.com/repos/rwcarlsen/moose","forks_url":"https://api.github.com/repos/rwcarlsen/moose/forks","keys_url":"https://api.github.com/repos/rwcarlsen/moose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rwcarlsen/moose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rwcarlsen/moose/teams","hooks_url":"https://api.github.com/repos/rwcarlsen/moose/hooks","issue_events_url":"https://api.github.com/repos/rwcarlsen/moose/issues/events{/number}","events_url":"https://api.github.com/repos/rwcarlsen/moose/events","assignees_url":"https://api.github.com/repos/rwcarlsen/moose/assignees{/user}","branches_url":"https://api.github.com/repos/rwcarlsen/moose/branches{/branch}","tags_url":"https://api.github.com/repos/rwcarlsen/moose/tags","blobs_url":"https://api.github.com/repos/rwcarlsen/moose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rwcarlsen/moose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rwcarlsen/moose/git/refs{/sha}","trees_url":"https://api.github.com/repos/rwcarlsen/moose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rwcarlsen/moose/statuses/{sha}","languages_url":"https://api.github.com/repos/rwcarlsen/moose/languages","stargazers_url":"https://api.github.com/repos/rwcarlsen/moose/stargazers","contributors_url":"https://api.github.com/repos/rwcarlsen/moose/contributors","subscribers_url":"https://api.github.com/repos/rwcarlsen/moose/subscribers","subscription_url":"https://api.github.com/repos/rwcarlsen/moose/subscription","commits_url":"https://api.github.com/repos/rwcarlsen/moose/commits{/sha}","git_commits_url":"https://api.github.com/repos/rwcarlsen/moose/git/commits{/sha}","comments_url":"https://api.github.com/repos/rwcarlsen/moose/comments{/number}","issue_comment_url":"https://api.github.com/repos/rwcarlsen/moose/issues/comments{/number}","contents_url":"https://api.github.com/repos/rwcarlsen/moose/contents/{+path}","compare_url":"https://api.github.com/repos/rwcarlsen/moose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rwcarlsen/moose/merges","archive_url":"https://api.github.com/repos/rwcarlsen/moose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rwcarlsen/moose/downloads","issues_url":"https://api.github.com/repos/rwcarlsen/moose/issues{/number}","pulls_url":"https://api.github.com/repos/rwcarlsen/moose/pulls{/number}","milestones_url":"https://api.github.com/repos/rwcarlsen/moose/milestones{/number}","notifications_url":"https://api.github.com/repos/rwcarlsen/moose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rwcarlsen/moose/labels{/name}","releases_url":"https://api.github.com/repos/rwcarlsen/moose/releases{/id}","deployments_url":"https://api.github.com/repos/rwcarlsen/moose/deployments","created_at":"2016-09-14T16:48:53Z","updated_at":"2016-09-14T16:49:08Z","pushed_at":"2018-02-27T00:33:02Z","git_url":"git://github.com/rwcarlsen/moose.git","ssh_url":"[email protected]:rwcarlsen/moose.git","clone_url":"https://github.com/rwcarlsen/moose.git","svn_url":"https://github.com/rwcarlsen/moose","homepage":"http://www.mooseframework.org","size":233975,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"idaholab:devel","ref":"devel","sha":"1633d7521930ed90584d4a37a9b4613d5bf62e01","user":{"login":"idaholab","id":3855370,"avatar_url":"https://avatars0.githubusercontent.com/u/3855370?v=4","gravatar_id":"","url":"https://api.github.com/users/idaholab","html_url":"https://github.com/idaholab","followers_url":"https://api.github.com/users/idaholab/followers","following_url":"https://api.github.com/users/idaholab/following{/other_user}","gists_url":"https://api.github.com/users/idaholab/gists{/gist_id}","starred_url":"https://api.github.com/users/idaholab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idaholab/subscriptions","organizations_url":"https://api.github.com/users/idaholab/orgs","repos_url":"https://api.github.com/users/idaholab/repos","events_url":"https://api.github.com/users/idaholab/events{/privacy}","received_events_url":"https://api.github.com/users/idaholab/received_events","type":"Organization","site_admin":false},"repo":{"id":16851223,"name":"moose","full_name":"idaholab/moose","owner":{"login":"idaholab","id":3855370,"avatar_url":"https://avatars0.githubusercontent.com/u/3855370?v=4","gravatar_id":"","url":"https://api.github.com/users/idaholab","html_url":"https://github.com/idaholab","followers_url":"https://api.github.com/users/idaholab/followers","following_url":"https://api.github.com/users/idaholab/following{/other_user}","gists_url":"https://api.github.com/users/idaholab/gists{/gist_id}","starred_url":"https://api.github.com/users/idaholab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idaholab/subscriptions","organizations_url":"https://api.github.com/users/idaholab/orgs","repos_url":"https://api.github.com/users/idaholab/repos","events_url":"https://api.github.com/users/idaholab/events{/privacy}","received_events_url":"https://api.github.com/users/idaholab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/idaholab/moose","description":"Multiphysics Object Oriented Simulation Environment","fork":false,"url":"https://api.github.com/repos/idaholab/moose","forks_url":"https://api.github.com/repos/idaholab/moose/forks","keys_url":"https://api.github.com/repos/idaholab/moose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/idaholab/moose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/idaholab/moose/teams","hooks_url":"https://api.github.com/repos/idaholab/moose/hooks","issue_events_url":"https://api.github.com/repos/idaholab/moose/issues/events{/number}","events_url":"https://api.github.com/repos/idaholab/moose/events","assignees_url":"https://api.github.com/repos/idaholab/moose/assignees{/user}","branches_url":"https://api.github.com/repos/idaholab/moose/branches{/branch}","tags_url":"https://api.github.com/repos/idaholab/moose/tags","blobs_url":"https://api.github.com/repos/idaholab/moose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/idaholab/moose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/idaholab/moose/git/refs{/sha}","trees_url":"https://api.github.com/repos/idaholab/moose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/idaholab/moose/statuses/{sha}","languages_url":"https://api.github.com/repos/idaholab/moose/languages","stargazers_url":"https://api.github.com/repos/idaholab/moose/stargazers","contributors_url":"https://api.github.com/repos/idaholab/moose/contributors","subscribers_url":"https://api.github.com/repos/idaholab/moose/subscribers","subscription_url":"https://api.github.com/repos/idaholab/moose/subscription","commits_url":"https://api.github.com/repos/idaholab/moose/commits{/sha}","git_commits_url":"https://api.github.com/repos/idaholab/moose/git/commits{/sha}","comments_url":"https://api.github.com/repos/idaholab/moose/comments{/number}","issue_comment_url":"https://api.github.com/repos/idaholab/moose/issues/comments{/number}","contents_url":"https://api.github.com/repos/idaholab/moose/contents/{+path}","compare_url":"https://api.github.com/repos/idaholab/moose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/idaholab/moose/merges","archive_url":"https://api.github.com/repos/idaholab/moose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/idaholab/moose/downloads","issues_url":"https://api.github.com/repos/idaholab/moose/issues{/number}","pulls_url":"https://api.github.com/repos/idaholab/moose/pulls{/number}","milestones_url":"https://api.github.com/repos/idaholab/moose/milestones{/number}","notifications_url":"https://api.github.com/repos/idaholab/moose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/idaholab/moose/labels{/name}","releases_url":"https://api.github.com/repos/idaholab/moose/releases{/id}","deployments_url":"https://api.github.com/repos/idaholab/moose/deployments","created_at":"2014-02-14T22:26:15Z","updated_at":"2018-02-26T18:37:32Z","pushed_at":"2018-02-27T14:11:34Z","git_url":"git://github.com/idaholab/moose.git","ssh_url":"[email protected]:idaholab/moose.git","clone_url":"https://github.com/idaholab/moose.git","svn_url":"https://github.com/idaholab/moose","homepage":"http://www.mooseframework.org","size":233741,"stargazers_count":274,"watchers_count":274,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":412,"mirror_url":null,"archived":false,"open_issues_count":690,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":412,"open_issues":690,"watchers":274,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/idaholab/moose/pulls/10893"},"html":{"href":"https://github.com/idaholab/moose/pull/10893"},"issue":{"href":"https://api.github.com/repos/idaholab/moose/issues/10893"},"comments":{"href":"https://api.github.com/repos/idaholab/moose/issues/10893/comments"},"review_comments":{"href":"https://api.github.com/repos/idaholab/moose/pulls/10893/comments"},"review_comment":{"href":"https://api.github.com/repos/idaholab/moose/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/idaholab/moose/pulls/10893/commits"},"statuses":{"href":"https://api.github.com/repos/idaholab/moose/statuses/fa2e38db5f2dd9f3f75b64f2fa053c9324bede0d"}},"author_association":"CONTRIBUTOR"}} | {
"id": 16851223,
"name": "idaholab/moose",
"url": "https://api.github.com/repos/idaholab/moose"
} | {
"id": 3036960,
"login": "permcody",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3036960?",
"url": "https://api.github.com/users/permcody"
} | {
"id": 3855370,
"login": "idaholab",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3855370?",
"url": "https://api.github.com/orgs/idaholab"
} | 2018-02-27T14:15:45 | 7303827020 | {"actor":{"display_login":"permcody"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/infinitered/gluegun/pulls/comments/243750333","pull_request_review_id":187606894,"id":243750333,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0Mzc1MDMzMw==","diff_hunk":"@@ -0,0 +1,31 @@\n+const { readdirSync, statSync, rmdir, unlink, existsSync } = require('fs')","path":"buildHelpers/cleanDir.js","position":null,"original_position":1,"commit_id":"ae67394646878bf81c2cf6639c7d8844d0e216bf","original_commit_id":"f6a5a3dc7f3d110b5794227bab918db7fc82d4bf","user":{"login":"RichiCoder1","id":2391878,"node_id":"MDQ6VXNlcjIzOTE4Nzg=","avatar_url":"https://avatars2.githubusercontent.com/u/2391878?v=4","gravatar_id":"","url":"https://api.github.com/users/RichiCoder1","html_url":"https://github.com/RichiCoder1","followers_url":"https://api.github.com/users/RichiCoder1/followers","following_url":"https://api.github.com/users/RichiCoder1/following{/other_user}","gists_url":"https://api.github.com/users/RichiCoder1/gists{/gist_id}","starred_url":"https://api.github.com/users/RichiCoder1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RichiCoder1/subscriptions","organizations_url":"https://api.github.com/users/RichiCoder1/orgs","repos_url":"https://api.github.com/users/RichiCoder1/repos","events_url":"https://api.github.com/users/RichiCoder1/events{/privacy}","received_events_url":"https://api.github.com/users/RichiCoder1/received_events","type":"User","site_admin":false},"body":"Moved and prettier'd!","created_at":"2018-12-23T01:46:53Z","updated_at":"2018-12-23T01:46:53Z","html_url":"https://github.com/infinitered/gluegun/pull/419#discussion_r243750333","pull_request_url":"https://api.github.com/repos/infinitered/gluegun/pulls/419","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/infinitered/gluegun/pulls/comments/243750333"},"html":{"href":"https://github.com/infinitered/gluegun/pull/419#discussion_r243750333"},"pull_request":{"href":"https://api.github.com/repos/infinitered/gluegun/pulls/419"}},"in_reply_to_id":243749946},"pull_request":{"url":"https://api.github.com/repos/infinitered/gluegun/pulls/419","id":240576516,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNTc2NTE2","html_url":"https://github.com/infinitered/gluegun/pull/419","diff_url":"https://github.com/infinitered/gluegun/pull/419.diff","patch_url":"https://github.com/infinitered/gluegun/pull/419.patch","issue_url":"https://api.github.com/repos/infinitered/gluegun/issues/419","number":419,"state":"open","locked":false,"title":"Adds types to extensible toolbox and fixes build and test on Windows","user":{"login":"RichiCoder1","id":2391878,"node_id":"MDQ6VXNlcjIzOTE4Nzg=","avatar_url":"https://avatars2.githubusercontent.com/u/2391878?v=4","gravatar_id":"","url":"https://api.github.com/users/RichiCoder1","html_url":"https://github.com/RichiCoder1","followers_url":"https://api.github.com/users/RichiCoder1/followers","following_url":"https://api.github.com/users/RichiCoder1/following{/other_user}","gists_url":"https://api.github.com/users/RichiCoder1/gists{/gist_id}","starred_url":"https://api.github.com/users/RichiCoder1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RichiCoder1/subscriptions","organizations_url":"https://api.github.com/users/RichiCoder1/orgs","repos_url":"https://api.github.com/users/RichiCoder1/repos","events_url":"https://api.github.com/users/RichiCoder1/events{/privacy}","received_events_url":"https://api.github.com/users/RichiCoder1/received_events","type":"User","site_admin":false},"body":"This, uh, blew up a little.\r\n\r\nOriginally it was just about correcting the types for `Toolbox` (which is does) but I ran into a bunch of issues building and running tests on Windows and so I ended up fixing most of those issues\r\n\r\nPartially resolves #418","created_at":"2018-12-21T21:00:24Z","updated_at":"2018-12-23T01:46:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"98a68819ce23a7d6f8dd9fe2fcee302dc1cc2498","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/infinitered/gluegun/pulls/419/commits","review_comments_url":"https://api.github.com/repos/infinitered/gluegun/pulls/419/comments","review_comment_url":"https://api.github.com/repos/infinitered/gluegun/pulls/comments{/number}","comments_url":"https://api.github.com/repos/infinitered/gluegun/issues/419/comments","statuses_url":"https://api.github.com/repos/infinitered/gluegun/statuses/ae67394646878bf81c2cf6639c7d8844d0e216bf","head":{"label":"RichiCoder1:typescript_fixes_and_windows_build","ref":"typescript_fixes_and_windows_build","sha":"ae67394646878bf81c2cf6639c7d8844d0e216bf","user":{"login":"RichiCoder1","id":2391878,"node_id":"MDQ6VXNlcjIzOTE4Nzg=","avatar_url":"https://avatars2.githubusercontent.com/u/2391878?v=4","gravatar_id":"","url":"https://api.github.com/users/RichiCoder1","html_url":"https://github.com/RichiCoder1","followers_url":"https://api.github.com/users/RichiCoder1/followers","following_url":"https://api.github.com/users/RichiCoder1/following{/other_user}","gists_url":"https://api.github.com/users/RichiCoder1/gists{/gist_id}","starred_url":"https://api.github.com/users/RichiCoder1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RichiCoder1/subscriptions","organizations_url":"https://api.github.com/users/RichiCoder1/orgs","repos_url":"https://api.github.com/users/RichiCoder1/repos","events_url":"https://api.github.com/users/RichiCoder1/events{/privacy}","received_events_url":"https://api.github.com/users/RichiCoder1/received_events","type":"User","site_admin":false},"repo":{"id":162751161,"node_id":"MDEwOlJlcG9zaXRvcnkxNjI3NTExNjE=","name":"gluegun","full_name":"RichiCoder1/gluegun","private":false,"owner":{"login":"RichiCoder1","id":2391878,"node_id":"MDQ6VXNlcjIzOTE4Nzg=","avatar_url":"https://avatars2.githubusercontent.com/u/2391878?v=4","gravatar_id":"","url":"https://api.github.com/users/RichiCoder1","html_url":"https://github.com/RichiCoder1","followers_url":"https://api.github.com/users/RichiCoder1/followers","following_url":"https://api.github.com/users/RichiCoder1/following{/other_user}","gists_url":"https://api.github.com/users/RichiCoder1/gists{/gist_id}","starred_url":"https://api.github.com/users/RichiCoder1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RichiCoder1/subscriptions","organizations_url":"https://api.github.com/users/RichiCoder1/orgs","repos_url":"https://api.github.com/users/RichiCoder1/repos","events_url":"https://api.github.com/users/RichiCoder1/events{/privacy}","received_events_url":"https://api.github.com/users/RichiCoder1/received_events","type":"User","site_admin":false},"html_url":"https://github.com/RichiCoder1/gluegun","description":"A delightful toolkit for building Node-powered CLIs.","fork":true,"url":"https://api.github.com/repos/RichiCoder1/gluegun","forks_url":"https://api.github.com/repos/RichiCoder1/gluegun/forks","keys_url":"https://api.github.com/repos/RichiCoder1/gluegun/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RichiCoder1/gluegun/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RichiCoder1/gluegun/teams","hooks_url":"https://api.github.com/repos/RichiCoder1/gluegun/hooks","issue_events_url":"https://api.github.com/repos/RichiCoder1/gluegun/issues/events{/number}","events_url":"https://api.github.com/repos/RichiCoder1/gluegun/events","assignees_url":"https://api.github.com/repos/RichiCoder1/gluegun/assignees{/user}","branches_url":"https://api.github.com/repos/RichiCoder1/gluegun/branches{/branch}","tags_url":"https://api.github.com/repos/RichiCoder1/gluegun/tags","blobs_url":"https://api.github.com/repos/RichiCoder1/gluegun/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RichiCoder1/gluegun/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RichiCoder1/gluegun/git/refs{/sha}","trees_url":"https://api.github.com/repos/RichiCoder1/gluegun/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RichiCoder1/gluegun/statuses/{sha}","languages_url":"https://api.github.com/repos/RichiCoder1/gluegun/languages","stargazers_url":"https://api.github.com/repos/RichiCoder1/gluegun/stargazers","contributors_url":"https://api.github.com/repos/RichiCoder1/gluegun/contributors","subscribers_url":"https://api.github.com/repos/RichiCoder1/gluegun/subscribers","subscription_url":"https://api.github.com/repos/RichiCoder1/gluegun/subscription","commits_url":"https://api.github.com/repos/RichiCoder1/gluegun/commits{/sha}","git_commits_url":"https://api.github.com/repos/RichiCoder1/gluegun/git/commits{/sha}","comments_url":"https://api.github.com/repos/RichiCoder1/gluegun/comments{/number}","issue_comment_url":"https://api.github.com/repos/RichiCoder1/gluegun/issues/comments{/number}","contents_url":"https://api.github.com/repos/RichiCoder1/gluegun/contents/{+path}","compare_url":"https://api.github.com/repos/RichiCoder1/gluegun/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RichiCoder1/gluegun/merges","archive_url":"https://api.github.com/repos/RichiCoder1/gluegun/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RichiCoder1/gluegun/downloads","issues_url":"https://api.github.com/repos/RichiCoder1/gluegun/issues{/number}","pulls_url":"https://api.github.com/repos/RichiCoder1/gluegun/pulls{/number}","milestones_url":"https://api.github.com/repos/RichiCoder1/gluegun/milestones{/number}","notifications_url":"https://api.github.com/repos/RichiCoder1/gluegun/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RichiCoder1/gluegun/labels{/name}","releases_url":"https://api.github.com/repos/RichiCoder1/gluegun/releases{/id}","deployments_url":"https://api.github.com/repos/RichiCoder1/gluegun/deployments","created_at":"2018-12-21T19:33:52Z","updated_at":"2018-12-21T19:33:54Z","pushed_at":"2018-12-23T01:46:42Z","git_url":"git://github.com/RichiCoder1/gluegun.git","ssh_url":"[email protected]:RichiCoder1/gluegun.git","clone_url":"https://github.com/RichiCoder1/gluegun.git","svn_url":"https://github.com/RichiCoder1/gluegun","homepage":"https://infinitered.github.io/gluegun","size":1463,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"infinitered:master","ref":"master","sha":"2850fa183151b0c52d97a3262c734837aa63cb07","user":{"login":"infinitered","id":3902527,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MDI1Mjc=","avatar_url":"https://avatars1.githubusercontent.com/u/3902527?v=4","gravatar_id":"","url":"https://api.github.com/users/infinitered","html_url":"https://github.com/infinitered","followers_url":"https://api.github.com/users/infinitered/followers","following_url":"https://api.github.com/users/infinitered/following{/other_user}","gists_url":"https://api.github.com/users/infinitered/gists{/gist_id}","starred_url":"https://api.github.com/users/infinitered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinitered/subscriptions","organizations_url":"https://api.github.com/users/infinitered/orgs","repos_url":"https://api.github.com/users/infinitered/repos","events_url":"https://api.github.com/users/infinitered/events{/privacy}","received_events_url":"https://api.github.com/users/infinitered/received_events","type":"Organization","site_admin":false},"repo":{"id":75027176,"node_id":"MDEwOlJlcG9zaXRvcnk3NTAyNzE3Ng==","name":"gluegun","full_name":"infinitered/gluegun","private":false,"owner":{"login":"infinitered","id":3902527,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MDI1Mjc=","avatar_url":"https://avatars1.githubusercontent.com/u/3902527?v=4","gravatar_id":"","url":"https://api.github.com/users/infinitered","html_url":"https://github.com/infinitered","followers_url":"https://api.github.com/users/infinitered/followers","following_url":"https://api.github.com/users/infinitered/following{/other_user}","gists_url":"https://api.github.com/users/infinitered/gists{/gist_id}","starred_url":"https://api.github.com/users/infinitered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinitered/subscriptions","organizations_url":"https://api.github.com/users/infinitered/orgs","repos_url":"https://api.github.com/users/infinitered/repos","events_url":"https://api.github.com/users/infinitered/events{/privacy}","received_events_url":"https://api.github.com/users/infinitered/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/infinitered/gluegun","description":"A delightful toolkit for building Node-powered CLIs.","fork":false,"url":"https://api.github.com/repos/infinitered/gluegun","forks_url":"https://api.github.com/repos/infinitered/gluegun/forks","keys_url":"https://api.github.com/repos/infinitered/gluegun/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infinitered/gluegun/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infinitered/gluegun/teams","hooks_url":"https://api.github.com/repos/infinitered/gluegun/hooks","issue_events_url":"https://api.github.com/repos/infinitered/gluegun/issues/events{/number}","events_url":"https://api.github.com/repos/infinitered/gluegun/events","assignees_url":"https://api.github.com/repos/infinitered/gluegun/assignees{/user}","branches_url":"https://api.github.com/repos/infinitered/gluegun/branches{/branch}","tags_url":"https://api.github.com/repos/infinitered/gluegun/tags","blobs_url":"https://api.github.com/repos/infinitered/gluegun/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infinitered/gluegun/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infinitered/gluegun/git/refs{/sha}","trees_url":"https://api.github.com/repos/infinitered/gluegun/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infinitered/gluegun/statuses/{sha}","languages_url":"https://api.github.com/repos/infinitered/gluegun/languages","stargazers_url":"https://api.github.com/repos/infinitered/gluegun/stargazers","contributors_url":"https://api.github.com/repos/infinitered/gluegun/contributors","subscribers_url":"https://api.github.com/repos/infinitered/gluegun/subscribers","subscription_url":"https://api.github.com/repos/infinitered/gluegun/subscription","commits_url":"https://api.github.com/repos/infinitered/gluegun/commits{/sha}","git_commits_url":"https://api.github.com/repos/infinitered/gluegun/git/commits{/sha}","comments_url":"https://api.github.com/repos/infinitered/gluegun/comments{/number}","issue_comment_url":"https://api.github.com/repos/infinitered/gluegun/issues/comments{/number}","contents_url":"https://api.github.com/repos/infinitered/gluegun/contents/{+path}","compare_url":"https://api.github.com/repos/infinitered/gluegun/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infinitered/gluegun/merges","archive_url":"https://api.github.com/repos/infinitered/gluegun/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infinitered/gluegun/downloads","issues_url":"https://api.github.com/repos/infinitered/gluegun/issues{/number}","pulls_url":"https://api.github.com/repos/infinitered/gluegun/pulls{/number}","milestones_url":"https://api.github.com/repos/infinitered/gluegun/milestones{/number}","notifications_url":"https://api.github.com/repos/infinitered/gluegun/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infinitered/gluegun/labels{/name}","releases_url":"https://api.github.com/repos/infinitered/gluegun/releases{/id}","deployments_url":"https://api.github.com/repos/infinitered/gluegun/deployments","created_at":"2016-11-29T00:37:41Z","updated_at":"2018-12-23T01:06:58Z","pushed_at":"2018-12-23T01:46:43Z","git_url":"git://github.com/infinitered/gluegun.git","ssh_url":"[email protected]:infinitered/gluegun.git","clone_url":"https://github.com/infinitered/gluegun.git","svn_url":"https://github.com/infinitered/gluegun","homepage":"https://infinitered.github.io/gluegun","size":1470,"stargazers_count":448,"watchers_count":448,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":28,"open_issues":28,"watchers":448,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/infinitered/gluegun/pulls/419"},"html":{"href":"https://github.com/infinitered/gluegun/pull/419"},"issue":{"href":"https://api.github.com/repos/infinitered/gluegun/issues/419"},"comments":{"href":"https://api.github.com/repos/infinitered/gluegun/issues/419/comments"},"review_comments":{"href":"https://api.github.com/repos/infinitered/gluegun/pulls/419/comments"},"review_comment":{"href":"https://api.github.com/repos/infinitered/gluegun/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/infinitered/gluegun/pulls/419/commits"},"statuses":{"href":"https://api.github.com/repos/infinitered/gluegun/statuses/ae67394646878bf81c2cf6639c7d8844d0e216bf"}},"author_association":"NONE"}} | {
"id": 75027176,
"name": "infinitered/gluegun",
"url": "https://api.github.com/repos/infinitered/gluegun"
} | {
"id": 2391878,
"login": "RichiCoder1",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2391878?",
"url": "https://api.github.com/users/RichiCoder1"
} | {
"id": 3902527,
"login": "infinitered",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3902527?",
"url": "https://api.github.com/orgs/infinitered"
} | 2018-12-23T01:46:53 | 8796156748 | {"actor":{"display_login":"RichiCoder1"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/comments/204176525","pull_request_review_id":139219892,"id":204176525,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDE3NjUyNQ==","diff_hunk":"@@ -0,0 +1,162 @@\n+module Parsers\n+\n+open System\n+open NonStructuralComparison // needed for parser performance, non boxing of struct equality\n+open OptimizedClosures // needed to apply multi-curry args at once with adapt (invoke method)\n+\n+type Range =\n+ struct\n+ val Start : int\n+ val Finish : int\n+ new(s,f)={Start=s;Finish=f}\n+ end\n+\n+type ValueOption<'T> =\n+ struct\n+ val HasValue : bool\n+ val Value: 'T\n+ new(a,b) = {HasValue = a; Value = b}\n+ end\n+let inline VSome v = ValueOption<_>(true,v)\n+let inline VNone () = ValueOption<'T>(false,Unchecked.defaultof<'T>)\n+\n+\n+type Parser = FSharpFunc<string, int, int, ValueOption<obj>>\n+\n+let inline private between x l u = (x - l) * (u - x) >= LanguagePrimitives.GenericZero\n+\n+let inline private rtrn (o : 'T) = ValueOption<'T>(true, o)\n+let inline private failure () = ValueOption<'T>(false,Unchecked.defaultof<'T>)\n+\n+/// Private Range Parsers that quickly try parse over matched range (all r.Finish checked before running in preceeding functions)\n+\n+let stringParse (path : string,r:Range) = path.Substring(r.Start, r.Finish - r.Start + 1) |> rtrn\n+\n+let charParse (path : string,r:Range) = path.[r.Start] |> rtrn // this is not ideal method (but uncommonly used)\n+let boolParse (path : string,r:Range) =\n+ match path.Substring(r.Start, r.Finish - r.Start) with\n+ | \"true\" | \"True\" | \"TRUE\" -> true |> rtrn\n+ | \"false\" | \"False\" | \"FALSE\" -> false |> rtrn","path":"frameworks/FSharp/Zebra/src/App/Parsers.fs","position":39,"original_position":39,"commit_id":"b6d27e5da1d3e428d948634d6303816e040ed286","original_commit_id":"deb6860da5bda21fb0d0755e9441bb4c8c21e64a","user":{"login":"gerardtoconnor","id":5388991,"node_id":"MDQ6VXNlcjUzODg5OTE=","avatar_url":"https://avatars0.githubusercontent.com/u/5388991?v=4","gravatar_id":"","url":"https://api.github.com/users/gerardtoconnor","html_url":"https://github.com/gerardtoconnor","followers_url":"https://api.github.com/users/gerardtoconnor/followers","following_url":"https://api.github.com/users/gerardtoconnor/following{/other_user}","gists_url":"https://api.github.com/users/gerardtoconnor/gists{/gist_id}","starred_url":"https://api.github.com/users/gerardtoconnor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gerardtoconnor/subscriptions","organizations_url":"https://api.github.com/users/gerardtoconnor/orgs","repos_url":"https://api.github.com/users/gerardtoconnor/repos","events_url":"https://api.github.com/users/gerardtoconnor/events{/privacy}","received_events_url":"https://api.github.com/users/gerardtoconnor/received_events","type":"User","site_admin":false},"body":"Thank you, provided it performs well, beats F# Giraffe, I can do PR when Framework is fully released.","created_at":"2018-07-20T21:43:45Z","updated_at":"2018-07-20T21:43:46Z","html_url":"https://github.com/TechEmpower/FrameworkBenchmarks/pull/3936#discussion_r204176525","pull_request_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/3936","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/comments/204176525"},"html":{"href":"https://github.com/TechEmpower/FrameworkBenchmarks/pull/3936#discussion_r204176525"},"pull_request":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/3936"}},"in_reply_to_id":204173799},"pull_request":{"url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/3936","id":201860446,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxODYwNDQ2","html_url":"https://github.com/TechEmpower/FrameworkBenchmarks/pull/3936","diff_url":"https://github.com/TechEmpower/FrameworkBenchmarks/pull/3936.diff","patch_url":"https://github.com/TechEmpower/FrameworkBenchmarks/pull/3936.patch","issue_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/issues/3936","number":3936,"state":"open","locked":false,"title":"Zebra - F# / Aspnetcore web framework ","user":{"login":"gerardtoconnor","id":5388991,"node_id":"MDQ6VXNlcjUzODg5OTE=","avatar_url":"https://avatars0.githubusercontent.com/u/5388991?v=4","gravatar_id":"","url":"https://api.github.com/users/gerardtoconnor","html_url":"https://github.com/gerardtoconnor","followers_url":"https://api.github.com/users/gerardtoconnor/followers","following_url":"https://api.github.com/users/gerardtoconnor/following{/other_user}","gists_url":"https://api.github.com/users/gerardtoconnor/gists{/gist_id}","starred_url":"https://api.github.com/users/gerardtoconnor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gerardtoconnor/subscriptions","organizations_url":"https://api.github.com/users/gerardtoconnor/orgs","repos_url":"https://api.github.com/users/gerardtoconnor/repos","events_url":"https://api.github.com/users/gerardtoconnor/events{/privacy}","received_events_url":"https://api.github.com/users/gerardtoconnor/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for submitting to the TechEmpower Framework Benchmarks!\r\n\r\nIf you are submitting a new framework, please make sure that you add the appropriate line in the `.travis.yml` file for proper integration testing. Also please make sure that an appropriate `README.md` is added in your framework directory with information about the framework and a link to its homepage and documentation.\r\n\r\nIf you are editing an existing test, please update the `README.md` for that test where appropriate.\r\n-->\r\n\r\nThis is my new web framework based on the following blog post:\r\n\r\nhttps://medium.com/@gerardtoconnor/racing-the-zebra-benchmark-performance-architecture-for-f-web-server-58dd922f5cfe\r\n\r\nWe would like to get more F# frameworks in the mix and Zebra *should* hopefully perform a little better thanks to reduced captures & allocations as well as a shared async state-machine.\r\n\r\n@benaadams @forki @NinoFloris","created_at":"2018-07-17T08:24:16Z","updated_at":"2018-07-20T21:43:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96d2f873339859902fe98e73ca88f207b0de65b3","assignee":{"login":"michaelhixson","id":297150,"node_id":"MDQ6VXNlcjI5NzE1MA==","avatar_url":"https://avatars3.githubusercontent.com/u/297150?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelhixson","html_url":"https://github.com/michaelhixson","followers_url":"https://api.github.com/users/michaelhixson/followers","following_url":"https://api.github.com/users/michaelhixson/following{/other_user}","gists_url":"https://api.github.com/users/michaelhixson/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelhixson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelhixson/subscriptions","organizations_url":"https://api.github.com/users/michaelhixson/orgs","repos_url":"https://api.github.com/users/michaelhixson/repos","events_url":"https://api.github.com/users/michaelhixson/events{/privacy}","received_events_url":"https://api.github.com/users/michaelhixson/received_events","type":"User","site_admin":false},"assignees":[{"login":"michaelhixson","id":297150,"node_id":"MDQ6VXNlcjI5NzE1MA==","avatar_url":"https://avatars3.githubusercontent.com/u/297150?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelhixson","html_url":"https://github.com/michaelhixson","followers_url":"https://api.github.com/users/michaelhixson/followers","following_url":"https://api.github.com/users/michaelhixson/following{/other_user}","gists_url":"https://api.github.com/users/michaelhixson/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelhixson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelhixson/subscriptions","organizations_url":"https://api.github.com/users/michaelhixson/orgs","repos_url":"https://api.github.com/users/michaelhixson/repos","events_url":"https://api.github.com/users/michaelhixson/events{/privacy}","received_events_url":"https://api.github.com/users/michaelhixson/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/3936/commits","review_comments_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/3936/comments","review_comment_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/issues/3936/comments","statuses_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/statuses/b6d27e5da1d3e428d948634d6303816e040ed286","head":{"label":"gerardtoconnor:master","ref":"master","sha":"b6d27e5da1d3e428d948634d6303816e040ed286","user":{"login":"gerardtoconnor","id":5388991,"node_id":"MDQ6VXNlcjUzODg5OTE=","avatar_url":"https://avatars0.githubusercontent.com/u/5388991?v=4","gravatar_id":"","url":"https://api.github.com/users/gerardtoconnor","html_url":"https://github.com/gerardtoconnor","followers_url":"https://api.github.com/users/gerardtoconnor/followers","following_url":"https://api.github.com/users/gerardtoconnor/following{/other_user}","gists_url":"https://api.github.com/users/gerardtoconnor/gists{/gist_id}","starred_url":"https://api.github.com/users/gerardtoconnor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gerardtoconnor/subscriptions","organizations_url":"https://api.github.com/users/gerardtoconnor/orgs","repos_url":"https://api.github.com/users/gerardtoconnor/repos","events_url":"https://api.github.com/users/gerardtoconnor/events{/privacy}","received_events_url":"https://api.github.com/users/gerardtoconnor/received_events","type":"User","site_admin":false},"repo":{"id":137586552,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc1ODY1NTI=","name":"FrameworkBenchmarks","full_name":"gerardtoconnor/FrameworkBenchmarks","owner":{"login":"gerardtoconnor","id":5388991,"node_id":"MDQ6VXNlcjUzODg5OTE=","avatar_url":"https://avatars0.githubusercontent.com/u/5388991?v=4","gravatar_id":"","url":"https://api.github.com/users/gerardtoconnor","html_url":"https://github.com/gerardtoconnor","followers_url":"https://api.github.com/users/gerardtoconnor/followers","following_url":"https://api.github.com/users/gerardtoconnor/following{/other_user}","gists_url":"https://api.github.com/users/gerardtoconnor/gists{/gist_id}","starred_url":"https://api.github.com/users/gerardtoconnor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gerardtoconnor/subscriptions","organizations_url":"https://api.github.com/users/gerardtoconnor/orgs","repos_url":"https://api.github.com/users/gerardtoconnor/repos","events_url":"https://api.github.com/users/gerardtoconnor/events{/privacy}","received_events_url":"https://api.github.com/users/gerardtoconnor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gerardtoconnor/FrameworkBenchmarks","description":"Source for the TechEmpower Framework Benchmarks project","fork":true,"url":"https://api.github.com/repos/gerardtoconnor/FrameworkBenchmarks","forks_url":"https://api.github.com/repos/gerardtoconnor/FrameworkBenchmarks/forks","keys_url":"https://api.github.com/repos/gerardtoconnor/FrameworkBenchmarks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gerardtoconnor/FrameworkBenchmarks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gerardtoconnor/FrameworkBenchmarks/teams","hooks_url":"https://api.github.com/repos/gerardtoconnor/FrameworkBenchmarks/hooks","issue_events_url":"https://api.github.com/repos/gerardtoconnor/FrameworkBenchmarks/issues/events{/number}","events_url":"https://api.github.com/repos/gerardtoconnor/FrameworkBenchmarks/events","assignees_url":"https://api.github.com/repos/gerardtoconnor/FrameworkBenchmarks/assignees{/user}","branches_url":"https://api.github.com/repos/gerardtoconnor/FrameworkBenchmarks/branches{/branch}","tags_url":"https://api.github.com/repos/gerardtoconnor/FrameworkBenchmarks/tags","blobs_url":"https://api.github.com/repos/gerardtoconnor/FrameworkBenchmarks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gerardtoconnor/FrameworkBenchmarks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gerardtoconnor/FrameworkBenchmarks/git/refs{/sha}","trees_url":"https://api.github.com/repos/gerardtoconnor/FrameworkBenchmarks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gerardtoconnor/FrameworkBenchmarks/statuses/{sha}","languages_url":"https://api.github.com/repos/gerardtoconnor/FrameworkBenchmarks/languages","stargazers_url":"https://api.github.com/repos/gerardtoconnor/FrameworkBenchmarks/stargazers","contributors_url":"https://api.github.com/repos/gerardtoconnor/FrameworkBenchmarks/contributors","subscribers_url":"https://api.github.com/repos/gerardtoconnor/FrameworkBenchmarks/subscribers","subscription_url":"https://api.github.com/repos/gerardtoconnor/FrameworkBenchmarks/subscription","commits_url":"https://api.github.com/repos/gerardtoconnor/FrameworkBenchmarks/commits{/sha}","git_commits_url":"https://api.github.com/repos/gerardtoconnor/FrameworkBenchmarks/git/commits{/sha}","comments_url":"https://api.github.com/repos/gerardtoconnor/FrameworkBenchmarks/comments{/number}","issue_comment_url":"https://api.github.com/repos/gerardtoconnor/FrameworkBenchmarks/issues/comments{/number}","contents_url":"https://api.github.com/repos/gerardtoconnor/FrameworkBenchmarks/contents/{+path}","compare_url":"https://api.github.com/repos/gerardtoconnor/FrameworkBenchmarks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gerardtoconnor/FrameworkBenchmarks/merges","archive_url":"https://api.github.com/repos/gerardtoconnor/FrameworkBenchmarks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gerardtoconnor/FrameworkBenchmarks/downloads","issues_url":"https://api.github.com/repos/gerardtoconnor/FrameworkBenchmarks/issues{/number}","pulls_url":"https://api.github.com/repos/gerardtoconnor/FrameworkBenchmarks/pulls{/number}","milestones_url":"https://api.github.com/repos/gerardtoconnor/FrameworkBenchmarks/milestones{/number}","notifications_url":"https://api.github.com/repos/gerardtoconnor/FrameworkBenchmarks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gerardtoconnor/FrameworkBenchmarks/labels{/name}","releases_url":"https://api.github.com/repos/gerardtoconnor/FrameworkBenchmarks/releases{/id}","deployments_url":"https://api.github.com/repos/gerardtoconnor/FrameworkBenchmarks/deployments","created_at":"2018-06-16T14:29:28Z","updated_at":"2018-07-20T21:25:58Z","pushed_at":"2018-07-20T21:25:52Z","git_url":"git://github.com/gerardtoconnor/FrameworkBenchmarks.git","ssh_url":"[email protected]:gerardtoconnor/FrameworkBenchmarks.git","clone_url":"https://github.com/gerardtoconnor/FrameworkBenchmarks.git","svn_url":"https://github.com/gerardtoconnor/FrameworkBenchmarks","homepage":"https://www.techempower.com/benchmarks/","size":272329,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TechEmpower:master","ref":"master","sha":"5b2efcb06cbb0f04fbc3666c9a8d5f7d12948054","user":{"login":"TechEmpower","id":3910062,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTAwNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/3910062?v=4","gravatar_id":"","url":"https://api.github.com/users/TechEmpower","html_url":"https://github.com/TechEmpower","followers_url":"https://api.github.com/users/TechEmpower/followers","following_url":"https://api.github.com/users/TechEmpower/following{/other_user}","gists_url":"https://api.github.com/users/TechEmpower/gists{/gist_id}","starred_url":"https://api.github.com/users/TechEmpower/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TechEmpower/subscriptions","organizations_url":"https://api.github.com/users/TechEmpower/orgs","repos_url":"https://api.github.com/users/TechEmpower/repos","events_url":"https://api.github.com/users/TechEmpower/events{/privacy}","received_events_url":"https://api.github.com/users/TechEmpower/received_events","type":"Organization","site_admin":false},"repo":{"id":8957264,"node_id":"MDEwOlJlcG9zaXRvcnk4OTU3MjY0","name":"FrameworkBenchmarks","full_name":"TechEmpower/FrameworkBenchmarks","owner":{"login":"TechEmpower","id":3910062,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTAwNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/3910062?v=4","gravatar_id":"","url":"https://api.github.com/users/TechEmpower","html_url":"https://github.com/TechEmpower","followers_url":"https://api.github.com/users/TechEmpower/followers","following_url":"https://api.github.com/users/TechEmpower/following{/other_user}","gists_url":"https://api.github.com/users/TechEmpower/gists{/gist_id}","starred_url":"https://api.github.com/users/TechEmpower/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TechEmpower/subscriptions","organizations_url":"https://api.github.com/users/TechEmpower/orgs","repos_url":"https://api.github.com/users/TechEmpower/repos","events_url":"https://api.github.com/users/TechEmpower/events{/privacy}","received_events_url":"https://api.github.com/users/TechEmpower/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TechEmpower/FrameworkBenchmarks","description":"Source for the TechEmpower Framework Benchmarks project","fork":false,"url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks","forks_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/forks","keys_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/teams","hooks_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/hooks","issue_events_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/issues/events{/number}","events_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/events","assignees_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/assignees{/user}","branches_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/branches{/branch}","tags_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/tags","blobs_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/git/refs{/sha}","trees_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/statuses/{sha}","languages_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/languages","stargazers_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/stargazers","contributors_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/contributors","subscribers_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/subscribers","subscription_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/subscription","commits_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/commits{/sha}","git_commits_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/git/commits{/sha}","comments_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/comments{/number}","issue_comment_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/issues/comments{/number}","contents_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/contents/{+path}","compare_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/merges","archive_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/downloads","issues_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/issues{/number}","pulls_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls{/number}","milestones_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/milestones{/number}","notifications_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/labels{/name}","releases_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/releases{/id}","deployments_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/deployments","created_at":"2013-03-22T17:33:54Z","updated_at":"2018-07-20T21:11:00Z","pushed_at":"2018-07-20T21:25:54Z","git_url":"git://github.com/TechEmpower/FrameworkBenchmarks.git","ssh_url":"[email protected]:TechEmpower/FrameworkBenchmarks.git","clone_url":"https://github.com/TechEmpower/FrameworkBenchmarks.git","svn_url":"https://github.com/TechEmpower/FrameworkBenchmarks","homepage":"https://www.techempower.com/benchmarks/","size":272536,"stargazers_count":3420,"watchers_count":3420,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1091,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":1091,"open_issues":38,"watchers":3420,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/3936"},"html":{"href":"https://github.com/TechEmpower/FrameworkBenchmarks/pull/3936"},"issue":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/issues/3936"},"comments":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/issues/3936/comments"},"review_comments":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/3936/comments"},"review_comment":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/3936/commits"},"statuses":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/statuses/b6d27e5da1d3e428d948634d6303816e040ed286"}},"author_association":"NONE"}} | {
"id": 8957264,
"name": "TechEmpower/FrameworkBenchmarks",
"url": "https://api.github.com/repos/TechEmpower/FrameworkBenchmarks"
} | {
"id": 5388991,
"login": "gerardtoconnor",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5388991?",
"url": "https://api.github.com/users/gerardtoconnor"
} | {
"id": 3910062,
"login": "TechEmpower",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3910062?",
"url": "https://api.github.com/orgs/TechEmpower"
} | 2018-07-20T21:43:45 | 7997333097 | {"actor":{"display_login":"gerardtoconnor"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ImageEngine/cortex/pulls/comments/224595807","pull_request_review_id":164004224,"id":224595807,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDU5NTgwNw==","diff_hunk":"@@ -0,0 +1,370 @@\n+//////////////////////////////////////////////////////////////////////////\n+//\n+// Copyright (c) 2018, Image Engine Design Inc. All rights reserved.\n+//\n+// Redistribution and use in source and binary forms, with or without\n+// modification, are permitted provided that the following conditions are\n+// met:\n+//\n+// * Redistributions of source code must retain the above copyright\n+// notice, this list of conditions and the following disclaimer.\n+//\n+// * Redistributions in binary form must reproduce the above copyright\n+// notice, this list of conditions and the following disclaimer in the\n+// documentation and/or other materials provided with the distribution.\n+//\n+// * Neither the name of Image Engine Design nor the names of any\n+// other contributors to this software may be used to endorse or\n+// promote products derived from this software without specific prior\n+// written permission.\n+//\n+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS \"AS\n+// IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,\n+// THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR\n+// PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR\n+// CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,\n+// EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,\n+// PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR\n+// PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF\n+// LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING\n+// NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS\n+// SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n+//\n+//////////////////////////////////////////////////////////////////////////\n+\n+#include \"IECoreScene/MeshAlgo.h\"\n+\n+#include \"IECore/DataAlgo.h\"\n+#include \"IECore/DespatchTypedData.h\"\n+#include \"IECore/TriangleAlgo.h\"\n+\n+#include \"tbb/parallel_for.h\"\n+#include \"tbb/blocked_range.h\"\n+\n+using namespace Imath;\n+using namespace IECore;\n+using namespace IECoreScene;\n+\n+namespace\n+{\n+\n+/// A functor for use with despatchTypedData, which copies elements from another vector, as specified by an array of indices into that data\n+struct TriangleDataRemap\n+{\n+\ttypedef void ReturnType;\n+\n+\tTriangleDataRemap( const std::vector<int> &indices ) : m_other( nullptr ), m_indices( indices )\n+\t{\n+\t}\n+\n+\tconst Data *m_other;\n+\tconst std::vector<int> &m_indices;\n+\n+\ttemplate<typename T>\n+\tvoid operator()( T *data )\n+\t{\n+\t\tassert( data );\n+\t\ttypename T::ValueType &dataWritable = data->writable();\n+\n+\t\tconst T *otherData = runTimeCast<const T, const Data>( m_other );\n+\t\tassert( otherData );\n+\t\tconst typename T::ValueType &otherDataReadable = otherData->readable();\n+\n+\t\tdataWritable.clear();\n+\t\tdataWritable.resize( m_indices.size() );\n+\n+\t\ttbb::task_group_context taskGroupContext( tbb::task_group_context::isolated );\n+\n+\t\ttbb::parallel_for(\n+\t\t\ttbb::blocked_range<size_t>( 0, m_indices.size() ), [&dataWritable, &otherDataReadable, this]( const tbb::blocked_range<size_t> &r )\n+\t\t\t{\n+\t\t\t\tfor( size_t i = r.begin(); i != r.end(); ++i )\n+\t\t\t\t{\n+\t\t\t\t\tdataWritable[i] = otherDataReadable[m_indices[i]];\n+\t\t\t\t}\n+\t\t\t}, taskGroupContext\n+\t\t);\n+\n+\t\tassert( dataWritable.size() == m_indices.size() );\n+\t}\n+};\n+\n+/// A simple class to allow TriangulateOp to operate on either V3fVectorData or V3dVectorData using\n+/// despatchTypedData\n+struct TriangulateFn\n+{\n+\ttypedef void ReturnType;\n+\n+\tMeshPrimitive *m_mesh;\n+\tfloat m_tolerance;\n+\tbool m_throwExceptions;\n+\n+\tTriangulateFn( MeshPrimitive *mesh, float tolerance, bool throwExceptions ) : m_mesh( mesh ), m_tolerance( tolerance ), m_throwExceptions( throwExceptions )\n+\t{\n+\t}\n+\n+\ttemplate<typename T>\n+\tReturnType operator()( T *p )\n+\t{\n+\t\ttypedef typename T::ValueType::value_type Vec;\n+\n+\t\tconst typename T::ValueType &pReadable = p->readable();\n+\n+\t\tMeshPrimitivePtr meshCopy = m_mesh->copy();\n+\n+\t\tConstIntVectorDataPtr verticesPerFace = m_mesh->verticesPerFace();\n+\t\tconst std::vector<int> &verticesPerFaceReadable = verticesPerFace->readable();\n+\t\tConstIntVectorDataPtr vertexIds = m_mesh->vertexIds();\n+\t\tconst std::vector<int> &vertexIdsReadable = vertexIds->readable();\n+\n+\t\tIntVectorDataPtr newVertexIds = new IntVectorData();\n+\t\tstd::vector<int> &newVertexIdsWritable = newVertexIds->writable();\n+\t\tnewVertexIdsWritable.reserve( vertexIdsReadable.size() );\n+\n+\t\tIntVectorDataPtr newVerticesPerFace = new IntVectorData();\n+\t\tstd::vector<int> &newVerticesPerFaceWritable = newVerticesPerFace->writable();\n+\t\tnewVerticesPerFaceWritable.reserve( verticesPerFaceReadable.size() );\n+\n+\t\tstd::vector<int> faceVaryingIndices;\n+\t\tstd::vector<int> uniformIndices;\n+\t\tint faceVertexIdStart = 0;\n+\t\tint faceIdx = 0;\n+\t\tfor( IntVectorData::ValueType::const_iterator it = verticesPerFaceReadable.begin(); it != verticesPerFaceReadable.end(); ++it, ++faceIdx )\n+\t\t{\n+\t\t\tint numFaceVerts = *it;\n+\n+\t\t\tif( numFaceVerts > 3 )\n+\t\t\t{\n+\t\t\t\t/// For the time being, just do a simple triangle fan.\n+\n+\t\t\t\tconst int i0 = faceVertexIdStart + 0;\n+\t\t\t\tconst int v0 = vertexIdsReadable[i0];\n+\n+\t\t\t\tint i1 = faceVertexIdStart + 1;\n+\t\t\t\tint i2 = faceVertexIdStart + 2;\n+\t\t\t\tint v1 = vertexIdsReadable[i1];\n+\t\t\t\tint v2 = vertexIdsReadable[i2];\n+\n+\t\t\t\tconst Vec firstTriangleNormal = triangleNormal( pReadable[v0], pReadable[v1], pReadable[v2] );\n+\n+\t\t\t\tif( m_throwExceptions )\n+\t\t\t\t{\n+\t\t\t\t\t/// Convexivity test - for each edge, all other vertices must be on the same \"side\" of it\n+\t\t\t\t\tfor( int i = 0; i < numFaceVerts - 1; i++ )\n+\t\t\t\t\t{\n+\t\t\t\t\t\tconst int edgeStartIndex = faceVertexIdStart + i + 0;\n+\t\t\t\t\t\tconst int edgeStart = vertexIdsReadable[edgeStartIndex];\n+\n+\t\t\t\t\t\tconst int edgeEndIndex = faceVertexIdStart + i + 1;\n+\t\t\t\t\t\tconst int edgeEnd = vertexIdsReadable[edgeEndIndex];\n+\n+\t\t\t\t\t\tconst Vec edge = pReadable[edgeEnd] - pReadable[edgeStart];\n+\t\t\t\t\t\tconst float edgeLength = edge.length();\n+\n+\t\t\t\t\t\tif( edgeLength > m_tolerance )\n+\t\t\t\t\t\t{\n+\t\t\t\t\t\t\tconst Vec edgeDirection = edge / edgeLength;\n+\n+\t\t\t\t\t\t\t/// Construct a plane whose normal is perpendicular to both the edge and the polygon's normal\n+\t\t\t\t\t\t\tconst Vec planeNormal = edgeDirection.cross( firstTriangleNormal );\n+\t\t\t\t\t\t\tconst float planeConstant = planeNormal.dot( pReadable[edgeStart] );\n+\n+\t\t\t\t\t\t\tint sign = 0;\n+\t\t\t\t\t\t\tbool first = true;\n+\t\t\t\t\t\t\tfor( int j = 0; j < numFaceVerts; j++ )\n+\t\t\t\t\t\t\t{\n+\t\t\t\t\t\t\t\tconst int testVertexIndex = faceVertexIdStart + j;\n+\t\t\t\t\t\t\t\tconst int testVertex = vertexIdsReadable[testVertexIndex];\n+\n+\t\t\t\t\t\t\t\tif( testVertex != edgeStart && testVertex != edgeEnd )\n+\t\t\t\t\t\t\t\t{\n+\t\t\t\t\t\t\t\t\tfloat signedDistance = planeNormal.dot( pReadable[testVertex] ) - planeConstant;\n+\n+\t\t\t\t\t\t\t\t\tif( fabs( signedDistance ) > m_tolerance )\n+\t\t\t\t\t\t\t\t\t{\n+\t\t\t\t\t\t\t\t\t\tint thisSign = 1;\n+\t\t\t\t\t\t\t\t\t\tif( signedDistance < 0.0 )\n+\t\t\t\t\t\t\t\t\t\t{\n+\t\t\t\t\t\t\t\t\t\t\tthisSign = -1;\n+\t\t\t\t\t\t\t\t\t\t}\n+\t\t\t\t\t\t\t\t\t\tif( first )\n+\t\t\t\t\t\t\t\t\t\t{\n+\t\t\t\t\t\t\t\t\t\t\tsign = thisSign;\n+\t\t\t\t\t\t\t\t\t\t\tfirst = false;\n+\t\t\t\t\t\t\t\t\t\t}\n+\t\t\t\t\t\t\t\t\t\telse if( thisSign != sign )\n+\t\t\t\t\t\t\t\t\t\t{\n+\t\t\t\t\t\t\t\t\t\t\tassert( sign != 0 );\n+\t\t\t\t\t\t\t\t\t\t\tthrow InvalidArgumentException( \"TriangulateOp cannot deal with concave polygons\" );\n+\t\t\t\t\t\t\t\t\t\t}\n+\t\t\t\t\t\t\t\t\t}\n+\t\t\t\t\t\t\t\t}\n+\t\t\t\t\t\t\t}\n+\t\t\t\t\t\t}\n+\t\t\t\t\t}\n+\t\t\t\t}\n+\n+\t\t\t\tfor( int i = 1; i < numFaceVerts - 1; i++ )\n+\t\t\t\t{\n+\t\t\t\t\ti1 = faceVertexIdStart + ( ( i + 0 ) % numFaceVerts );\n+\t\t\t\t\ti2 = faceVertexIdStart + ( ( i + 1 ) % numFaceVerts );\n+\t\t\t\t\tv1 = vertexIdsReadable[i1];\n+\t\t\t\t\tv2 = vertexIdsReadable[i2];\n+\n+\t\t\t\t\tif( m_throwExceptions &&\n+\t\t\t\t\t\tfabs( triangleNormal( pReadable[v0], pReadable[v1], pReadable[v2] ).dot( firstTriangleNormal ) - 1.0 ) > m_tolerance )\n+\t\t\t\t\t{\n+\t\t\t\t\t\tthrow InvalidArgumentException( \"TriangulateOp cannot deal with non-planar polygons\" );\n+\t\t\t\t\t}\n+\n+\t\t\t\t\t/// Create a new triangle\n+\t\t\t\t\tnewVerticesPerFaceWritable.push_back( 3 );\n+\n+\t\t\t\t\t/// Triangulate the vertices\n+\t\t\t\t\tnewVertexIdsWritable.push_back( v0 );\n+\t\t\t\t\tnewVertexIdsWritable.push_back( v1 );\n+\t\t\t\t\tnewVertexIdsWritable.push_back( v2 );\n+\n+\t\t\t\t\t/// Store the indices required to rebuild the facevarying primvars\n+\t\t\t\t\tfaceVaryingIndices.push_back( i0 );\n+\t\t\t\t\tfaceVaryingIndices.push_back( i1 );\n+\t\t\t\t\tfaceVaryingIndices.push_back( i2 );\n+\n+\t\t\t\t\tuniformIndices.push_back( faceIdx );\n+\t\t\t\t}\n+\t\t\t}\n+\t\t\telse\n+\t\t\t{\n+\t\t\t\tassert( numFaceVerts == 3 );\n+\n+\t\t\t\tint i0 = faceVertexIdStart + 0;\n+\t\t\t\tint i1 = faceVertexIdStart + 1;\n+\t\t\t\tint i2 = faceVertexIdStart + 2;\n+\n+\t\t\t\tnewVerticesPerFaceWritable.push_back( 3 );\n+\n+\t\t\t\t/// Copy across the vertexId data\n+\t\t\t\tnewVertexIdsWritable.push_back( vertexIdsReadable[i0] );\n+\t\t\t\tnewVertexIdsWritable.push_back( vertexIdsReadable[i1] );\n+\t\t\t\tnewVertexIdsWritable.push_back( vertexIdsReadable[i2] );\n+\n+\t\t\t\t/// Store the indices required to rebuild the facevarying primvars\n+\t\t\t\tfaceVaryingIndices.push_back( i0 );\n+\t\t\t\tfaceVaryingIndices.push_back( i1 );\n+\t\t\t\tfaceVaryingIndices.push_back( i2 );\n+\n+\t\t\t\tuniformIndices.push_back( faceIdx );\n+\t\t\t}\n+\n+\t\t\tfaceVertexIdStart += numFaceVerts;\n+\t\t}\n+\n+\t\tm_mesh->setTopology( newVerticesPerFace, newVertexIds, m_mesh->interpolation() );\n+\n+\t\t/// Rebuild all the facevarying primvars, using the list of indices into the old data we created above.\n+\t\tassert( faceVaryingIndices.size() == newVertexIds->readable().size() );\n+\t\tTriangleDataRemap varyingRemap( faceVaryingIndices );\n+\t\tTriangleDataRemap uniformRemap( uniformIndices );\n+\t\tfor( PrimitiveVariableMap::iterator it = m_mesh->variables.begin(); it != m_mesh->variables.end(); ++it )\n+\t\t{\n+\t\t\tTriangleDataRemap *remap = nullptr;\n+\t\t\tif( it->second.interpolation == PrimitiveVariable::FaceVarying )\n+\t\t\t{\n+\t\t\t\tremap = &varyingRemap;\n+\t\t\t}\n+\t\t\telse if( it->second.interpolation == PrimitiveVariable::Uniform )\n+\t\t\t{\n+\t\t\t\tremap = &uniformRemap;\n+\t\t\t}\n+\t\t\telse\n+\t\t\t{\n+\t\t\t\tcontinue;\n+\t\t\t}\n+\n+\t\t\tconst Data *inputData = it->second.indices ? it->second.indices.get() : it->second.data.get();\n+\t\t\tDataPtr result = inputData->copy();\n+\t\t\tremap->m_other = inputData;\n+\n+\t\t\tdespatchTypedData<TriangleDataRemap, TypeTraits::IsVectorTypedData>( result.get(), *remap );\n+\n+\t\t\tif( it->second.indices )\n+\t\t\t{\n+\t\t\t\tit->second.indices = runTimeCast<IntVectorData>( result );\n+\t\t\t}\n+\t\t\telse\n+\t\t\t{\n+\t\t\t\tit->second.data = result;\n+\t\t\t}\n+\t\t}\n+\n+\t\tassert( m_mesh->arePrimitiveVariablesValid() );\n+\t}\n+\n+\tstruct ErrorHandler\n+\t{\n+\t\ttemplate<typename T, typename F>\n+\t\tvoid operator()( const T *data, const F &functor )\n+\t\t{\n+\t\t\tassert( data );\n+\n+\t\t\tthrow InvalidArgumentException(\n+\t\t\t\t(\n+\t\t\t\t\tboost::format( \"TriangulateOp: Invalid data type \\\"%s\\\" for primitive variable \\\"P\\\".\" ) %\n+\t\t\t\t\t\tObject::typeNameFromTypeId( data->typeId() )\n+\t\t\t\t).str()\n+\t\t\t);\n+\t\t}\n+\t};\n+};\n+\n+void reportError( const std::string &context, const std::string &message, bool throwExceptions )\n+{\n+\tif ( throwExceptions )\n+\t{\n+\t\tthrow InvalidArgumentException( boost::str ( boost::format(\"%s : %s\") % context % message ) );\n+\t}\n+\telse\n+\t{\n+\t\tmsg( MessageHandler::Level::Error, context, message );\n+\t}\n+}\n+\n+} // namespace\n+\n+MeshPrimitivePtr MeshAlgo::triangulate(\n+\tconst MeshPrimitive *mesh, float tolerance, bool throwExceptions\n+)\n+{\n+\tMeshPrimitivePtr meshCopy = mesh->copy();\n+\n+\tif ( !mesh->arePrimitiveVariablesValid() )\n+\t{\n+\t\treportError( \"TriangulateOp\", \"Mesh with invalid primitive variables \", throwExceptions );","path":"src/IECoreScene/MeshAlgoTriangulate.cpp","position":342,"original_position":342,"commit_id":"34a608c3e82df7feb85d6d138cee778fe8d132a6","original_commit_id":"6ea2fda044c5a61441f4c7a6172979648fd7db9a","user":{"login":"andrewkaufman","id":3979682,"node_id":"MDQ6VXNlcjM5Nzk2ODI=","avatar_url":"https://avatars1.githubusercontent.com/u/3979682?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewkaufman","html_url":"https://github.com/andrewkaufman","followers_url":"https://api.github.com/users/andrewkaufman/followers","following_url":"https://api.github.com/users/andrewkaufman/following{/other_user}","gists_url":"https://api.github.com/users/andrewkaufman/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewkaufman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewkaufman/subscriptions","organizations_url":"https://api.github.com/users/andrewkaufman/orgs","repos_url":"https://api.github.com/users/andrewkaufman/repos","events_url":"https://api.github.com/users/andrewkaufman/events{/privacy}","received_events_url":"https://api.github.com/users/andrewkaufman/received_events","type":"User","site_admin":false},"body":"MeshAlgo::triangulate","created_at":"2018-10-11T20:36:56Z","updated_at":"2018-10-11T20:41:45Z","html_url":"https://github.com/ImageEngine/cortex/pull/853#discussion_r224595807","pull_request_url":"https://api.github.com/repos/ImageEngine/cortex/pulls/853","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ImageEngine/cortex/pulls/comments/224595807"},"html":{"href":"https://github.com/ImageEngine/cortex/pull/853#discussion_r224595807"},"pull_request":{"href":"https://api.github.com/repos/ImageEngine/cortex/pulls/853"}}},"pull_request":{"url":"https://api.github.com/repos/ImageEngine/cortex/pulls/853","id":219032623,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MDMyNjIz","html_url":"https://github.com/ImageEngine/cortex/pull/853","diff_url":"https://github.com/ImageEngine/cortex/pull/853.diff","patch_url":"https://github.com/ImageEngine/cortex/pull/853.patch","issue_url":"https://api.github.com/repos/ImageEngine/cortex/issues/853","number":853,"state":"open","locked":false,"title":"Parallel set topology & Triangulate","user":{"login":"donboie","id":25311256,"node_id":"MDQ6VXNlcjI1MzExMjU2","avatar_url":"https://avatars1.githubusercontent.com/u/25311256?v=4","gravatar_id":"","url":"https://api.github.com/users/donboie","html_url":"https://github.com/donboie","followers_url":"https://api.github.com/users/donboie/followers","following_url":"https://api.github.com/users/donboie/following{/other_user}","gists_url":"https://api.github.com/users/donboie/gists{/gist_id}","starred_url":"https://api.github.com/users/donboie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donboie/subscriptions","organizations_url":"https://api.github.com/users/donboie/orgs","repos_url":"https://api.github.com/users/donboie/repos","events_url":"https://api.github.com/users/donboie/events{/privacy}","received_events_url":"https://api.github.com/users/donboie/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-28T17:15:04Z","updated_at":"2018-10-11T20:41:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54260854c680d44a1c3ec3140b86e747882283fb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mattigruener","id":19398650,"node_id":"MDQ6VXNlcjE5Mzk4NjUw","avatar_url":"https://avatars2.githubusercontent.com/u/19398650?v=4","gravatar_id":"","url":"https://api.github.com/users/mattigruener","html_url":"https://github.com/mattigruener","followers_url":"https://api.github.com/users/mattigruener/followers","following_url":"https://api.github.com/users/mattigruener/following{/other_user}","gists_url":"https://api.github.com/users/mattigruener/gists{/gist_id}","starred_url":"https://api.github.com/users/mattigruener/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattigruener/subscriptions","organizations_url":"https://api.github.com/users/mattigruener/orgs","repos_url":"https://api.github.com/users/mattigruener/repos","events_url":"https://api.github.com/users/mattigruener/events{/privacy}","received_events_url":"https://api.github.com/users/mattigruener/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ImageEngine/cortex/pulls/853/commits","review_comments_url":"https://api.github.com/repos/ImageEngine/cortex/pulls/853/comments","review_comment_url":"https://api.github.com/repos/ImageEngine/cortex/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ImageEngine/cortex/issues/853/comments","statuses_url":"https://api.github.com/repos/ImageEngine/cortex/statuses/34a608c3e82df7feb85d6d138cee778fe8d132a6","head":{"label":"donboie:parallelSetTopology","ref":"parallelSetTopology","sha":"34a608c3e82df7feb85d6d138cee778fe8d132a6","user":{"login":"donboie","id":25311256,"node_id":"MDQ6VXNlcjI1MzExMjU2","avatar_url":"https://avatars1.githubusercontent.com/u/25311256?v=4","gravatar_id":"","url":"https://api.github.com/users/donboie","html_url":"https://github.com/donboie","followers_url":"https://api.github.com/users/donboie/followers","following_url":"https://api.github.com/users/donboie/following{/other_user}","gists_url":"https://api.github.com/users/donboie/gists{/gist_id}","starred_url":"https://api.github.com/users/donboie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donboie/subscriptions","organizations_url":"https://api.github.com/users/donboie/orgs","repos_url":"https://api.github.com/users/donboie/repos","events_url":"https://api.github.com/users/donboie/events{/privacy}","received_events_url":"https://api.github.com/users/donboie/received_events","type":"User","site_admin":false},"repo":{"id":80573606,"node_id":"MDEwOlJlcG9zaXRvcnk4MDU3MzYwNg==","name":"cortex","full_name":"donboie/cortex","private":false,"owner":{"login":"donboie","id":25311256,"node_id":"MDQ6VXNlcjI1MzExMjU2","avatar_url":"https://avatars1.githubusercontent.com/u/25311256?v=4","gravatar_id":"","url":"https://api.github.com/users/donboie","html_url":"https://github.com/donboie","followers_url":"https://api.github.com/users/donboie/followers","following_url":"https://api.github.com/users/donboie/following{/other_user}","gists_url":"https://api.github.com/users/donboie/gists{/gist_id}","starred_url":"https://api.github.com/users/donboie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donboie/subscriptions","organizations_url":"https://api.github.com/users/donboie/orgs","repos_url":"https://api.github.com/users/donboie/repos","events_url":"https://api.github.com/users/donboie/events{/privacy}","received_events_url":"https://api.github.com/users/donboie/received_events","type":"User","site_admin":false},"html_url":"https://github.com/donboie/cortex","description":"Libraries for visual effects software development","fork":true,"url":"https://api.github.com/repos/donboie/cortex","forks_url":"https://api.github.com/repos/donboie/cortex/forks","keys_url":"https://api.github.com/repos/donboie/cortex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/donboie/cortex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/donboie/cortex/teams","hooks_url":"https://api.github.com/repos/donboie/cortex/hooks","issue_events_url":"https://api.github.com/repos/donboie/cortex/issues/events{/number}","events_url":"https://api.github.com/repos/donboie/cortex/events","assignees_url":"https://api.github.com/repos/donboie/cortex/assignees{/user}","branches_url":"https://api.github.com/repos/donboie/cortex/branches{/branch}","tags_url":"https://api.github.com/repos/donboie/cortex/tags","blobs_url":"https://api.github.com/repos/donboie/cortex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/donboie/cortex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/donboie/cortex/git/refs{/sha}","trees_url":"https://api.github.com/repos/donboie/cortex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/donboie/cortex/statuses/{sha}","languages_url":"https://api.github.com/repos/donboie/cortex/languages","stargazers_url":"https://api.github.com/repos/donboie/cortex/stargazers","contributors_url":"https://api.github.com/repos/donboie/cortex/contributors","subscribers_url":"https://api.github.com/repos/donboie/cortex/subscribers","subscription_url":"https://api.github.com/repos/donboie/cortex/subscription","commits_url":"https://api.github.com/repos/donboie/cortex/commits{/sha}","git_commits_url":"https://api.github.com/repos/donboie/cortex/git/commits{/sha}","comments_url":"https://api.github.com/repos/donboie/cortex/comments{/number}","issue_comment_url":"https://api.github.com/repos/donboie/cortex/issues/comments{/number}","contents_url":"https://api.github.com/repos/donboie/cortex/contents/{+path}","compare_url":"https://api.github.com/repos/donboie/cortex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/donboie/cortex/merges","archive_url":"https://api.github.com/repos/donboie/cortex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/donboie/cortex/downloads","issues_url":"https://api.github.com/repos/donboie/cortex/issues{/number}","pulls_url":"https://api.github.com/repos/donboie/cortex/pulls{/number}","milestones_url":"https://api.github.com/repos/donboie/cortex/milestones{/number}","notifications_url":"https://api.github.com/repos/donboie/cortex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/donboie/cortex/labels{/name}","releases_url":"https://api.github.com/repos/donboie/cortex/releases{/id}","deployments_url":"https://api.github.com/repos/donboie/cortex/deployments","created_at":"2017-01-31T23:39:09Z","updated_at":"2018-04-20T03:14:07Z","pushed_at":"2018-10-11T19:33:24Z","git_url":"git://github.com/donboie/cortex.git","ssh_url":"[email protected]:donboie/cortex.git","clone_url":"https://github.com/donboie/cortex.git","svn_url":"https://github.com/donboie/cortex","homepage":null,"size":105669,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"ImageEngine:master","ref":"master","sha":"c9a515b9d8f1e9cee8dadb2220f9efb7c5d0e322","user":{"login":"ImageEngine","id":3976662,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzY2NjI=","avatar_url":"https://avatars1.githubusercontent.com/u/3976662?v=4","gravatar_id":"","url":"https://api.github.com/users/ImageEngine","html_url":"https://github.com/ImageEngine","followers_url":"https://api.github.com/users/ImageEngine/followers","following_url":"https://api.github.com/users/ImageEngine/following{/other_user}","gists_url":"https://api.github.com/users/ImageEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/ImageEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ImageEngine/subscriptions","organizations_url":"https://api.github.com/users/ImageEngine/orgs","repos_url":"https://api.github.com/users/ImageEngine/repos","events_url":"https://api.github.com/users/ImageEngine/events{/privacy}","received_events_url":"https://api.github.com/users/ImageEngine/received_events","type":"Organization","site_admin":false},"repo":{"id":10654465,"node_id":"MDEwOlJlcG9zaXRvcnkxMDY1NDQ2NQ==","name":"cortex","full_name":"ImageEngine/cortex","private":false,"owner":{"login":"ImageEngine","id":3976662,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzY2NjI=","avatar_url":"https://avatars1.githubusercontent.com/u/3976662?v=4","gravatar_id":"","url":"https://api.github.com/users/ImageEngine","html_url":"https://github.com/ImageEngine","followers_url":"https://api.github.com/users/ImageEngine/followers","following_url":"https://api.github.com/users/ImageEngine/following{/other_user}","gists_url":"https://api.github.com/users/ImageEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/ImageEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ImageEngine/subscriptions","organizations_url":"https://api.github.com/users/ImageEngine/orgs","repos_url":"https://api.github.com/users/ImageEngine/repos","events_url":"https://api.github.com/users/ImageEngine/events{/privacy}","received_events_url":"https://api.github.com/users/ImageEngine/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ImageEngine/cortex","description":"Libraries for visual effects software development","fork":false,"url":"https://api.github.com/repos/ImageEngine/cortex","forks_url":"https://api.github.com/repos/ImageEngine/cortex/forks","keys_url":"https://api.github.com/repos/ImageEngine/cortex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ImageEngine/cortex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ImageEngine/cortex/teams","hooks_url":"https://api.github.com/repos/ImageEngine/cortex/hooks","issue_events_url":"https://api.github.com/repos/ImageEngine/cortex/issues/events{/number}","events_url":"https://api.github.com/repos/ImageEngine/cortex/events","assignees_url":"https://api.github.com/repos/ImageEngine/cortex/assignees{/user}","branches_url":"https://api.github.com/repos/ImageEngine/cortex/branches{/branch}","tags_url":"https://api.github.com/repos/ImageEngine/cortex/tags","blobs_url":"https://api.github.com/repos/ImageEngine/cortex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ImageEngine/cortex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ImageEngine/cortex/git/refs{/sha}","trees_url":"https://api.github.com/repos/ImageEngine/cortex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ImageEngine/cortex/statuses/{sha}","languages_url":"https://api.github.com/repos/ImageEngine/cortex/languages","stargazers_url":"https://api.github.com/repos/ImageEngine/cortex/stargazers","contributors_url":"https://api.github.com/repos/ImageEngine/cortex/contributors","subscribers_url":"https://api.github.com/repos/ImageEngine/cortex/subscribers","subscription_url":"https://api.github.com/repos/ImageEngine/cortex/subscription","commits_url":"https://api.github.com/repos/ImageEngine/cortex/commits{/sha}","git_commits_url":"https://api.github.com/repos/ImageEngine/cortex/git/commits{/sha}","comments_url":"https://api.github.com/repos/ImageEngine/cortex/comments{/number}","issue_comment_url":"https://api.github.com/repos/ImageEngine/cortex/issues/comments{/number}","contents_url":"https://api.github.com/repos/ImageEngine/cortex/contents/{+path}","compare_url":"https://api.github.com/repos/ImageEngine/cortex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ImageEngine/cortex/merges","archive_url":"https://api.github.com/repos/ImageEngine/cortex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ImageEngine/cortex/downloads","issues_url":"https://api.github.com/repos/ImageEngine/cortex/issues{/number}","pulls_url":"https://api.github.com/repos/ImageEngine/cortex/pulls{/number}","milestones_url":"https://api.github.com/repos/ImageEngine/cortex/milestones{/number}","notifications_url":"https://api.github.com/repos/ImageEngine/cortex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ImageEngine/cortex/labels{/name}","releases_url":"https://api.github.com/repos/ImageEngine/cortex/releases{/id}","deployments_url":"https://api.github.com/repos/ImageEngine/cortex/deployments","created_at":"2013-06-12T23:12:28Z","updated_at":"2018-10-09T17:56:03Z","pushed_at":"2018-10-11T19:33:26Z","git_url":"git://github.com/ImageEngine/cortex.git","ssh_url":"[email protected]:ImageEngine/cortex.git","clone_url":"https://github.com/ImageEngine/cortex.git","svn_url":"https://github.com/ImageEngine/cortex","homepage":null,"size":105490,"stargazers_count":280,"watchers_count":280,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":83,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":83,"open_issues":37,"watchers":280,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ImageEngine/cortex/pulls/853"},"html":{"href":"https://github.com/ImageEngine/cortex/pull/853"},"issue":{"href":"https://api.github.com/repos/ImageEngine/cortex/issues/853"},"comments":{"href":"https://api.github.com/repos/ImageEngine/cortex/issues/853/comments"},"review_comments":{"href":"https://api.github.com/repos/ImageEngine/cortex/pulls/853/comments"},"review_comment":{"href":"https://api.github.com/repos/ImageEngine/cortex/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ImageEngine/cortex/pulls/853/commits"},"statuses":{"href":"https://api.github.com/repos/ImageEngine/cortex/statuses/34a608c3e82df7feb85d6d138cee778fe8d132a6"}},"author_association":"CONTRIBUTOR"}} | {
"id": 10654465,
"name": "ImageEngine/cortex",
"url": "https://api.github.com/repos/ImageEngine/cortex"
} | {
"id": 3979682,
"login": "andrewkaufman",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3979682?",
"url": "https://api.github.com/users/andrewkaufman"
} | {
"id": 3976662,
"login": "ImageEngine",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3976662?",
"url": "https://api.github.com/orgs/ImageEngine"
} | 2018-10-11T20:36:56 | 8407355886 | {"actor":{"display_login":"andrewkaufman"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/crate/crate/pulls/comments/186112276","pull_request_review_id":117636406,"id":186112276,"diff_hunk":"@@ -115,6 +116,29 @@ public void testCopyFromParameter() throws Exception {\n assertThat(BytesRefs.toString(value), is(path));\n }\n \n+ @Test\n+ public void testCopyFromWithInputFormatJson() {","path":"sql/src/test/java/io/crate/analyze/CopyAnalyzerTest.java","position":29,"original_position":29,"commit_id":"1ca6a7f4bd552545d1ddc79aed19c982db75f97e","original_commit_id":"1ca6a7f4bd552545d1ddc79aed19c982db75f97e","user":{"login":"mfussenegger","id":38700,"avatar_url":"https://avatars0.githubusercontent.com/u/38700?v=4","gravatar_id":"","url":"https://api.github.com/users/mfussenegger","html_url":"https://github.com/mfussenegger","followers_url":"https://api.github.com/users/mfussenegger/followers","following_url":"https://api.github.com/users/mfussenegger/following{/other_user}","gists_url":"https://api.github.com/users/mfussenegger/gists{/gist_id}","starred_url":"https://api.github.com/users/mfussenegger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfussenegger/subscriptions","organizations_url":"https://api.github.com/users/mfussenegger/orgs","repos_url":"https://api.github.com/users/mfussenegger/repos","events_url":"https://api.github.com/users/mfussenegger/events{/privacy}","received_events_url":"https://api.github.com/users/mfussenegger/received_events","type":"User","site_admin":false},"body":"It would be nice to either state more explicitly in the method name what aspect a test is testing or reduce the assertions to the relevant parts.\r\n\r\nThe tests below all assert the `table` and `uri` but I suspect that this is not relevant - but only the format handling.\r\n\r\nIf it is not clear what aspect a test is testing it is incredible hard to judge later on if they're still required after a refactoring.","created_at":"2018-05-04T15:06:53Z","updated_at":"2018-05-04T15:10:34Z","html_url":"https://github.com/crate/crate/pull/6830#discussion_r186112276","pull_request_url":"https://api.github.com/repos/crate/crate/pulls/6830","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/crate/crate/pulls/comments/186112276"},"html":{"href":"https://github.com/crate/crate/pull/6830#discussion_r186112276"},"pull_request":{"href":"https://api.github.com/repos/crate/crate/pulls/6830"}}},"pull_request":{"url":"https://api.github.com/repos/crate/crate/pulls/6830","id":166593142,"html_url":"https://github.com/crate/crate/pull/6830","diff_url":"https://github.com/crate/crate/pull/6830.diff","patch_url":"https://github.com/crate/crate/pull/6830.patch","issue_url":"https://api.github.com/repos/crate/crate/issues/6830","number":6830,"state":"open","locked":false,"title":"COPY FROM with CSV input","user":{"login":"emilywoods","id":20131679,"avatar_url":"https://avatars1.githubusercontent.com/u/20131679?v=4","gravatar_id":"","url":"https://api.github.com/users/emilywoods","html_url":"https://github.com/emilywoods","followers_url":"https://api.github.com/users/emilywoods/followers","following_url":"https://api.github.com/users/emilywoods/following{/other_user}","gists_url":"https://api.github.com/users/emilywoods/gists{/gist_id}","starred_url":"https://api.github.com/users/emilywoods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilywoods/subscriptions","organizations_url":"https://api.github.com/users/emilywoods/orgs","repos_url":"https://api.github.com/users/emilywoods/repos","events_url":"https://api.github.com/users/emilywoods/events{/privacy}","received_events_url":"https://api.github.com/users/emilywoods/received_events","type":"User","site_admin":false},"body":"PR for allowing CSV input format when importing data via `COPY FROM` .\r\nThis can be done using either:\r\n- file extension e.g. `COPY table_ident FROM file.csv`\r\n- `WITH` option e.g. `COPY table_ident FROM file.ext WITH (format='csv')`\r\n\r\nIncludes updates to `COPY FROM` docs","created_at":"2018-02-01T16:52:50Z","updated_at":"2018-05-04T15:10:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce82eaaeb6edaa0dc8751e79f11d2554548abea2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/crate/crate/pulls/6830/commits","review_comments_url":"https://api.github.com/repos/crate/crate/pulls/6830/comments","review_comment_url":"https://api.github.com/repos/crate/crate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crate/crate/issues/6830/comments","statuses_url":"https://api.github.com/repos/crate/crate/statuses/1ca6a7f4bd552545d1ddc79aed19c982db75f97e","head":{"label":"crate:ew/crate-csv","ref":"ew/crate-csv","sha":"1ca6a7f4bd552545d1ddc79aed19c982db75f97e","user":{"login":"crate","id":4048232,"avatar_url":"https://avatars3.githubusercontent.com/u/4048232?v=4","gravatar_id":"","url":"https://api.github.com/users/crate","html_url":"https://github.com/crate","followers_url":"https://api.github.com/users/crate/followers","following_url":"https://api.github.com/users/crate/following{/other_user}","gists_url":"https://api.github.com/users/crate/gists{/gist_id}","starred_url":"https://api.github.com/users/crate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crate/subscriptions","organizations_url":"https://api.github.com/users/crate/orgs","repos_url":"https://api.github.com/users/crate/repos","events_url":"https://api.github.com/users/crate/events{/privacy}","received_events_url":"https://api.github.com/users/crate/received_events","type":"Organization","site_admin":false},"repo":{"id":9342529,"name":"crate","full_name":"crate/crate","owner":{"login":"crate","id":4048232,"avatar_url":"https://avatars3.githubusercontent.com/u/4048232?v=4","gravatar_id":"","url":"https://api.github.com/users/crate","html_url":"https://github.com/crate","followers_url":"https://api.github.com/users/crate/followers","following_url":"https://api.github.com/users/crate/following{/other_user}","gists_url":"https://api.github.com/users/crate/gists{/gist_id}","starred_url":"https://api.github.com/users/crate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crate/subscriptions","organizations_url":"https://api.github.com/users/crate/orgs","repos_url":"https://api.github.com/users/crate/repos","events_url":"https://api.github.com/users/crate/events{/privacy}","received_events_url":"https://api.github.com/users/crate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crate/crate","description":"CrateDB is a distributed SQL database that makes it simple to store and analyze massive amounts of machine data in real-time.","fork":false,"url":"https://api.github.com/repos/crate/crate","forks_url":"https://api.github.com/repos/crate/crate/forks","keys_url":"https://api.github.com/repos/crate/crate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crate/crate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crate/crate/teams","hooks_url":"https://api.github.com/repos/crate/crate/hooks","issue_events_url":"https://api.github.com/repos/crate/crate/issues/events{/number}","events_url":"https://api.github.com/repos/crate/crate/events","assignees_url":"https://api.github.com/repos/crate/crate/assignees{/user}","branches_url":"https://api.github.com/repos/crate/crate/branches{/branch}","tags_url":"https://api.github.com/repos/crate/crate/tags","blobs_url":"https://api.github.com/repos/crate/crate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crate/crate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crate/crate/git/refs{/sha}","trees_url":"https://api.github.com/repos/crate/crate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crate/crate/statuses/{sha}","languages_url":"https://api.github.com/repos/crate/crate/languages","stargazers_url":"https://api.github.com/repos/crate/crate/stargazers","contributors_url":"https://api.github.com/repos/crate/crate/contributors","subscribers_url":"https://api.github.com/repos/crate/crate/subscribers","subscription_url":"https://api.github.com/repos/crate/crate/subscription","commits_url":"https://api.github.com/repos/crate/crate/commits{/sha}","git_commits_url":"https://api.github.com/repos/crate/crate/git/commits{/sha}","comments_url":"https://api.github.com/repos/crate/crate/comments{/number}","issue_comment_url":"https://api.github.com/repos/crate/crate/issues/comments{/number}","contents_url":"https://api.github.com/repos/crate/crate/contents/{+path}","compare_url":"https://api.github.com/repos/crate/crate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crate/crate/merges","archive_url":"https://api.github.com/repos/crate/crate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crate/crate/downloads","issues_url":"https://api.github.com/repos/crate/crate/issues{/number}","pulls_url":"https://api.github.com/repos/crate/crate/pulls{/number}","milestones_url":"https://api.github.com/repos/crate/crate/milestones{/number}","notifications_url":"https://api.github.com/repos/crate/crate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crate/crate/labels{/name}","releases_url":"https://api.github.com/repos/crate/crate/releases{/id}","deployments_url":"https://api.github.com/repos/crate/crate/deployments","created_at":"2013-04-10T09:17:16Z","updated_at":"2018-05-04T14:30:49Z","pushed_at":"2018-05-04T14:58:45Z","git_url":"git://github.com/crate/crate.git","ssh_url":"[email protected]:crate/crate.git","clone_url":"https://github.com/crate/crate.git","svn_url":"https://github.com/crate/crate","homepage":"https://crate.io","size":85130,"stargazers_count":1997,"watchers_count":1997,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":262,"mirror_url":null,"archived":false,"open_issues_count":85,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":262,"open_issues":85,"watchers":1997,"default_branch":"master"}},"base":{"label":"crate:master","ref":"master","sha":"7d0ad7dc5935aae07de55cc13d18b40a5b8ee9ca","user":{"login":"crate","id":4048232,"avatar_url":"https://avatars3.githubusercontent.com/u/4048232?v=4","gravatar_id":"","url":"https://api.github.com/users/crate","html_url":"https://github.com/crate","followers_url":"https://api.github.com/users/crate/followers","following_url":"https://api.github.com/users/crate/following{/other_user}","gists_url":"https://api.github.com/users/crate/gists{/gist_id}","starred_url":"https://api.github.com/users/crate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crate/subscriptions","organizations_url":"https://api.github.com/users/crate/orgs","repos_url":"https://api.github.com/users/crate/repos","events_url":"https://api.github.com/users/crate/events{/privacy}","received_events_url":"https://api.github.com/users/crate/received_events","type":"Organization","site_admin":false},"repo":{"id":9342529,"name":"crate","full_name":"crate/crate","owner":{"login":"crate","id":4048232,"avatar_url":"https://avatars3.githubusercontent.com/u/4048232?v=4","gravatar_id":"","url":"https://api.github.com/users/crate","html_url":"https://github.com/crate","followers_url":"https://api.github.com/users/crate/followers","following_url":"https://api.github.com/users/crate/following{/other_user}","gists_url":"https://api.github.com/users/crate/gists{/gist_id}","starred_url":"https://api.github.com/users/crate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crate/subscriptions","organizations_url":"https://api.github.com/users/crate/orgs","repos_url":"https://api.github.com/users/crate/repos","events_url":"https://api.github.com/users/crate/events{/privacy}","received_events_url":"https://api.github.com/users/crate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crate/crate","description":"CrateDB is a distributed SQL database that makes it simple to store and analyze massive amounts of machine data in real-time.","fork":false,"url":"https://api.github.com/repos/crate/crate","forks_url":"https://api.github.com/repos/crate/crate/forks","keys_url":"https://api.github.com/repos/crate/crate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crate/crate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crate/crate/teams","hooks_url":"https://api.github.com/repos/crate/crate/hooks","issue_events_url":"https://api.github.com/repos/crate/crate/issues/events{/number}","events_url":"https://api.github.com/repos/crate/crate/events","assignees_url":"https://api.github.com/repos/crate/crate/assignees{/user}","branches_url":"https://api.github.com/repos/crate/crate/branches{/branch}","tags_url":"https://api.github.com/repos/crate/crate/tags","blobs_url":"https://api.github.com/repos/crate/crate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crate/crate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crate/crate/git/refs{/sha}","trees_url":"https://api.github.com/repos/crate/crate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crate/crate/statuses/{sha}","languages_url":"https://api.github.com/repos/crate/crate/languages","stargazers_url":"https://api.github.com/repos/crate/crate/stargazers","contributors_url":"https://api.github.com/repos/crate/crate/contributors","subscribers_url":"https://api.github.com/repos/crate/crate/subscribers","subscription_url":"https://api.github.com/repos/crate/crate/subscription","commits_url":"https://api.github.com/repos/crate/crate/commits{/sha}","git_commits_url":"https://api.github.com/repos/crate/crate/git/commits{/sha}","comments_url":"https://api.github.com/repos/crate/crate/comments{/number}","issue_comment_url":"https://api.github.com/repos/crate/crate/issues/comments{/number}","contents_url":"https://api.github.com/repos/crate/crate/contents/{+path}","compare_url":"https://api.github.com/repos/crate/crate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crate/crate/merges","archive_url":"https://api.github.com/repos/crate/crate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crate/crate/downloads","issues_url":"https://api.github.com/repos/crate/crate/issues{/number}","pulls_url":"https://api.github.com/repos/crate/crate/pulls{/number}","milestones_url":"https://api.github.com/repos/crate/crate/milestones{/number}","notifications_url":"https://api.github.com/repos/crate/crate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crate/crate/labels{/name}","releases_url":"https://api.github.com/repos/crate/crate/releases{/id}","deployments_url":"https://api.github.com/repos/crate/crate/deployments","created_at":"2013-04-10T09:17:16Z","updated_at":"2018-05-04T14:30:49Z","pushed_at":"2018-05-04T14:58:45Z","git_url":"git://github.com/crate/crate.git","ssh_url":"[email protected]:crate/crate.git","clone_url":"https://github.com/crate/crate.git","svn_url":"https://github.com/crate/crate","homepage":"https://crate.io","size":85130,"stargazers_count":1997,"watchers_count":1997,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":262,"mirror_url":null,"archived":false,"open_issues_count":85,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":262,"open_issues":85,"watchers":1997,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crate/crate/pulls/6830"},"html":{"href":"https://github.com/crate/crate/pull/6830"},"issue":{"href":"https://api.github.com/repos/crate/crate/issues/6830"},"comments":{"href":"https://api.github.com/repos/crate/crate/issues/6830/comments"},"review_comments":{"href":"https://api.github.com/repos/crate/crate/pulls/6830/comments"},"review_comment":{"href":"https://api.github.com/repos/crate/crate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crate/crate/pulls/6830/commits"},"statuses":{"href":"https://api.github.com/repos/crate/crate/statuses/1ca6a7f4bd552545d1ddc79aed19c982db75f97e"}},"author_association":"CONTRIBUTOR"}} | {
"id": 9342529,
"name": "crate/crate",
"url": "https://api.github.com/repos/crate/crate"
} | {
"id": 38700,
"login": "mfussenegger",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/38700?",
"url": "https://api.github.com/users/mfussenegger"
} | {
"id": 4048232,
"login": "crate",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4048232?",
"url": "https://api.github.com/orgs/crate"
} | 2018-05-04T15:06:53 | 7629152938 | {"actor":{"display_login":"mfussenegger"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/pulls/comments/227896767","pull_request_review_id":168041283,"id":227896767,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzg5Njc2Nw==","diff_hunk":"@@ -34,15 +35,645 @@\n \n .alert-reg-success {\n color: $color-green;\n+@import url('https://fonts.googleapis.com/css?family=Raleway');\n+\n+*, html, body {\n+ font-family: 'Raleway', sans-serif;\n+}\n+\n+.navbar-fixed{\n+ box-shadow: 0px 0.5px rgb(224, 223, 223);\n+}\n+.nav-wrapper .brand-logo{\n+ font-family: Athelas,'Times New Roman';\n+}\n+.btn {\n+ text-transform: none;\n+ border-radius: 4px;\n+ box-shadow: none;\n+ border: 1px solid #aaa;\n+}\n+\n+.btn:hover {\n+ text-transform: none;\n+ border-radius: 4px;\n+ box-shadow: none;\n+ border: 1px solid teal;\n+ background-color: teal!important;\n+ color: #fff!important;\n+\n+}\n+.nav-wrapper i{\n+ padding: 2px 10px 0px 10px ;\n+}\n+i:hover{\n+ cursor: pointer;\n+ color: #000;\n+}\n+.small-profile{\n+ border-radius: 100%;\n+ width: 30px;\n+ margin: 20px 10px ;\n+}\n+.profile-header{\n+ padding-top: 1.5%;\n+}\n+.profile-header h4{\n+ font-weight: bold;\n+}\n+.profile-header button{\n+ margin-top: 25px;\n+}\n+.profile-header .row{\n+ margin-bottom: 0%;\n+ padding: 0px 15px;\n+}\n+button{\n+ border: 1px solid teal;\n+}\n+button:hover{\n+ border: 0px solid grey;\n+}\n+\n+.profile-header p.bio{\n+ margin:-2px;\n+ font-size: 16px;\n+ font-family: 'Lucida Sans', 'Lucida Sans Regular', 'Lucida Grande', 'Lucida Sans Unicode', Geneva, Verdana, sans-serif;\n+}\n+.followers-link li{\n+ display: inline;\n+}\n+.followers-link li :hover{\n+ text-decoration: underline;\n+}\n+.profile-header .container.underline{\n+ border: 0.5px solid rgb(218, 218, 218);\n+ width: 44%;\n+ padding: 0%;\n+ margin-top: 1%;\n+}\n+h6{\n+ font-weight: bold;\n+}\n+.profile-articles{\n+ font-family: Athelas,'Times New Roman';\n+ font-size: 1.3rem\n+}\n+.article-title{\n+ font-family: Lato;\n+ font-weight: bolder;\n+}\n+.profile-articles .row .card-action ul{\n+ padding:0px;\n+ margin: 0px;\n+}\n+\n+.profile-articles .row .card-action ul li{\n+ display: inline;\n+ font-family:Lato;\n+ font-size: 0.8em;\n+ padding:0px 10px;\n+}\n+.article-small-profile{\n+ border-radius: 50%;\n+ width: 50px;\n+}\n+\n+.user-info {\n+ display: flex;\n+ flex-direction: column;\n+}\n+\n+.avatar {\n+ height: 120px;\n+ width: 120px;\n+ border-radius: 50%;\n+}\n+\n+.profile {\n+ display: flex;\n+ justify-content: space-between;\n+ margin-top: 40px;\n+ flex-wrap: wrap;\n+}\n+\n+.user-detail {\n+ display: flex;\n+ align-items: center;\n+}\n+\n+.user-detail > button {\n+ margin-left: 30px;\n+}\n+\n+.username{\n+ margin: 0;\n+ padding: 0;\n+}\n+\n+.p-r-30 {\n+ padding-right: 20px!important;\n+}\n+\n+.article-time {\n+ display: flex;\n+ margin-left: 20px;\n+ flex-direction: column;\n+}\n+.article-time a{\n+ color: #000000;;\n+}\n+\n+.author-info {\n+ display: flex;\n+ margin-bottom: 20px;\n+}\n+\n+.avatar-small {\n+ height:50px;\n+ width:50px;\n+ border-radius: 50%;\n+}\n+\n+.article-time--details {\n+ display: flex;\n+ color: #aaa;\n+ font-size: 14px;\n+}\n+\n+.r-l-spacer {\n+ padding-right: 10px;;\n+ padding-left: 10px;;\n+}\n+\n+.avatar-name{\n+ display: flex;\n+ justify-content: space-between;\n+ align-items: center;\n }\n \n+.overlay {\n+ width: 100%;\n+ height: 100%;\n+ background-color: rgba(0, 0, 0, 0.6);\n+ z-index: -1;\n+}\n+\n+.edit-name {\n+ display: flex;\n+ justify-content: space-between;\n+ align-items: center;\n+}\n+\n+.modal-footer {\n+ display: flex;\n+ justify-content: space-around;\n+}\n+\n+.underline {\n+ text-decoration: underline;\n+}\n .modal.custom-modal {\n background-color: $color-pale-green;\n outline: none;\n text-align: center;\n width: 50%;\n }\n \n+ .navbar-fixed {\n+ box-shadow: 0 0.5px rgb(224, 223, 223);\n+ }\n+\n+ .nav-wrapper .brand-logo {\n+ font-family: Athelas, 'Times New Roman';\n+ }\n+\n+ .btn {\n+ text-transform: none;\n+ border-radius: 4px;\n+ box-shadow: none;\n+ border: 1px solid #aaa;\n+ }\n+\n+ .btn:hover {\n+ text-transform: none;\n+ border-radius: 4px;\n+ box-shadow: none;\n+ border: 1px solid teal;\n+ background-color: teal !important;\n+ color: #fff !important;\n+\n+ }\n+\n+ .nav-wrapper i {\n+ padding: 2px 10px 0 10px;\n+ }\n+ i:hover {\n+ cursor: pointer;\n+ color: #000;\n+ }\n+\n+ .small-profile {\n+ border-radius: 100%;\n+ width: 30px;\n+ margin: 20px 10px;\n+ }\n+\n+ .profile-header {\n+ padding-top: 1.5%;\n+ }\n+\n+ .profile-header h4 {\n+ font-weight: bold;\n+ }\n+\n+ .profile-header button {\n+ margin-top: 25px;\n+ }\n+\n+ .profile-header .row {\n+ margin-bottom: 0;\n+ padding: 0 15px;\n+ }\n+\n+ button {\n+ border: 1px solid teal;\n+ }\n+.character-counter {\n+ display: none;\n+}\n+ @import url('https://fonts.googleapis.com/css?family=Raleway');\n+}\n+\n+*, html, body {\n+ font-family: 'Raleway', sans-serif;\n+}\n+\n+.navbar-fixed {\n+ box-shadow: 0 0.5px rgb(224, 223, 223);\n+}\n+\n+.nav-wrapper .brand-logo {\n+ font-family: Athelas, 'Times New Roman';\n+}\n+\n+.btn {\n+ text-transform: none !important;\n+ border-radius: 4px !important;\n+ box-shadow: none;\n+ border: 1px solid #aaa;\n+}\n+\n+.btn:hover {\n+ text-transform: none;\n+ border-radius: 4px;\n+ box-shadow: none;\n+ border: 1px solid teal;\n+ background-color: teal !important;\n+ color: #fff !important;\n+}\n+\n+.nav-wrapper i {\n+ padding: 2px 10px 0 10px;\n+}\n+\n+i:hover {\n+ cursor: pointer;\n+ color: #000;\n+}\n+\n+.small-profile {\n+ border-radius: 100%;\n+ width: 30px;\n+ margin: 20px 10px;\n+}\n+\n+.profile-header {\n+ padding-top: 1.5%;\n+}\n+\n+.profile-header h4 {\n+ font-weight: bold;\n+}\n+\n+.profile-header button {\n+ margin-top: 25px;\n+}\n+\n+.profile-header .row {\n+ margin-bottom: 0;\n+ padding: 0 15px;\n+}\n+\n+button {\n+ border: 1px solid teal;\n+}\n+\n+button:hover {\n+ border: 0 solid grey;\n+}\n+\n+.profile-header p.bio {\n+ margin: -2px;\n+ font-size: 16px;\n+ font-family: 'Lucida Sans', 'Lucida Sans Regular', 'Lucida Grande', 'Lucida Sans Unicode', Geneva, Verdana, sans-serif;\n+}\n+\n+.followers-link li {\n+ display: inline;\n+}\n+\n+.followers-link li :hover {\n+ text-decoration: underline;\n+}\n+\n+.profile-header .container.underline {\n+ border: 0.5px solid rgb(218, 218, 218);\n+ width: 44%;\n+ padding: 0;\n+ margin-top: 1%;\n+}\n+\n+h6 {\n+ font-weight: bold;\n+}\n+\n+.profile-articles {\n+ font-family: Athelas, 'Times New Roman';\n+ font-size: 1.3rem\n+}\n+\n+.article-title {\n+ font-family: Lato;\n+ font-weight: bolder;\n+}\n+\n+.profile-articles .row .card-action ul {\n+ padding: 0;\n+ margin: 0;\n+}\n+\n+.profile-articles .row .card-action ul li {\n+ display: inline;\n+ font-family: Lato;\n+ font-size: 0.8em;\n+ padding: 0 10px;\n+}\n+\n+.article-small-profile {\n+ border-radius: 50%;\n+ width: 50px;\n+}\n+\n+.user-info {\n+ display: flex;\n+ flex-direction: column;\n+}\n+\n+.avatar {\n+ height: 120px;\n+ width: 120px;\n+ border-radius: 50%;\n+}\n+\n+.profile {\n+ display: flex;\n+ justify-content: space-between;\n+ margin-top: 40px;\n+ flex-wrap: wrap;\n+}\n+\n+.user-detail {\n+ align-items: center;\n+ display: flex;\n+}\n+\n+.username {\n+ margin: 0;\n+ padding: 0;\n+}\n+\n+.p-r-30 {\n+ padding-right: 20px !important;\n+}\n+\n+.article-time {\n+ display: flex;\n+ flex-direction: column;\n+ margin-left: 20px;\n+\n+}\n+\n+.article-time a {\n+ color: #000000;;\n+}\n+\n+.author-info {\n+ display: flex;\n+ margin-bottom: 20px;\n+}\n+\n+.avatar-small {\n+ height: 50px;\n+ width: 50px;\n+ border-radius: 50%;\n+}\n+\n+.article-time--details {\n+ display: flex;\n+ color: #aaa;\n+ font-size: 14px;\n+}\n+\n+.r-l-spacer {\n+ padding-right: 10px;;\n+ padding-left: 10px;;\n+}\n+\n+.avatar-name {\n+ display: flex;\n+ justify-content: space-between;\n+ align-items: center;\n+}\n+\n+.overlay {\n+ width: 100%;\n+ height: 100%;\n+ background-color: rgba(0, 0, 0, 0.6);\n+ z-index: -1;\n+}\n+\n+.edit-name {\n+ display: flex;\n+ justify-content: space-between;\n+ align-items: center;\n+}\n+\n+.modal-footer {\n+ display: flex;\n+ justify-content: space-around;\n+}\n+\n+.underline {\n+ text-decoration: underline;\n+}\n+\n+ button:hover {\n+ border: 0 solid grey;\n+ }\n+\n+ .profile-header p.bio {\n+ margin: -2px;\n+ font-size: 16px;\n+ font-family: 'Lucida Sans', 'Lucida Sans Regular', 'Lucida Grande', 'Lucida Sans Unicode', Geneva, Verdana, sans-serif;\n+ }\n+\n+ .followers-link li {\n+ display: inline;\n+ }\n+\n+ .followers-link li :hover {\n+ text-decoration: underline;\n+ }\n+\n+ .profile-header .container.underline {\n+ border: 0.5px solid rgb(218, 218, 218);\n+ width: 44%;\n+ padding: 0;\n+ margin-top: 1%;\n+ }\n+\n+ h6 {\n+ font-weight: bold;\n+ }\n+\n+ .profile-articles {\n+ font-family: Athelas, 'Times New Roman';\n+ font-size: 1.3rem\n+ }\n+\n+ .article-title {\n+ font-family: Lato;\n+ font-weight: bolder;\n+ }\n+\n+ .profile-articles .row .card-action ul {\n+ padding: 0;\n+ margin: 0;\n+ }\n+\n+ .profile-articles .row .card-action ul li {\n+ display: inline;\n+ font-family: Lato;\n+ font-size: 0.8em;\n+ padding: 0 10px;\n+ }\n+\n+ .article-small-profile {\n+ border-radius: 50%;\n+ width: 50px;\n+ }\n+\n+ .user-info {\n+ display: flex;\n+ flex-direction: column;\n+ }\n+\n+ .avatar {\n+ height: 120px;\n+ width: 120px;\n+ border-radius: 50%;\n+ }\n+\n+ .profile {\n+ display: flex;\n+ justify-content: space-between;\n+ margin-top: 40px;\n+ flex-wrap: wrap;\n+ }\n+\n+ .user-detail {\n+ align-items: center;\n+ display: flex;\n+ }\n+\n+ .username {\n+ margin: 0;\n+ padding: 0;\n+ }\n+\n+ .p-r-30 {\n+ padding-right: 20px !important;\n+ }\n+\n+ .article-time {\n+ display: flex;\n+ flex-direction: column;\n+ margin-left: 20px;\n+\n+ }\n+\n+ .article-time a {\n+ color: #000000;;\n+ }\n+\n+ .author-info {\n+ display: flex;\n+ margin-bottom: 20px;\n+ }\n+\n+ .avatar-small {\n+ height: 50px;\n+ width: 50px;\n+ border-radius: 50%;\n+ }\n+\n+ .article-time--details {\n+ display: flex;\n+ color: #aaa;\n+ font-size: 14px;\n+ }\n+\n+ .r-l-spacer {\n+ padding-right: 10px;;\n+ padding-left: 10px;;\n+ }\n+\n+ .avatar-name {","path":"src/styles/styles.scss","position":626,"original_position":626,"commit_id":"cb14976e7d3491ea46ac9492142d795ded5bfdd1","original_commit_id":"cb14976e7d3491ea46ac9492142d795ded5bfdd1","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Line should be indented 0 spaces, but was indented 2 spaces<br>Merge rule `.avatar-name` with rule on line 493","created_at":"2018-10-24T17:56:46Z","updated_at":"2018-10-24T17:56:47Z","html_url":"https://github.com/andela/ah-leagueOfLegends-frontend/pull/27#discussion_r227896767","pull_request_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/pulls/27","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/pulls/comments/227896767"},"html":{"href":"https://github.com/andela/ah-leagueOfLegends-frontend/pull/27#discussion_r227896767"},"pull_request":{"href":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/pulls/27","id":225490774,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NDkwNzc0","html_url":"https://github.com/andela/ah-leagueOfLegends-frontend/pull/27","diff_url":"https://github.com/andela/ah-leagueOfLegends-frontend/pull/27.diff","patch_url":"https://github.com/andela/ah-leagueOfLegends-frontend/pull/27.patch","issue_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/issues/27","number":27,"state":"open","locked":false,"title":"Dummy branch fix hound","user":{"login":"Quantum-35","id":39088834,"node_id":"MDQ6VXNlcjM5MDg4ODM0","avatar_url":"https://avatars1.githubusercontent.com/u/39088834?v=4","gravatar_id":"","url":"https://api.github.com/users/Quantum-35","html_url":"https://github.com/Quantum-35","followers_url":"https://api.github.com/users/Quantum-35/followers","following_url":"https://api.github.com/users/Quantum-35/following{/other_user}","gists_url":"https://api.github.com/users/Quantum-35/gists{/gist_id}","starred_url":"https://api.github.com/users/Quantum-35/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quantum-35/subscriptions","organizations_url":"https://api.github.com/users/Quantum-35/orgs","repos_url":"https://api.github.com/users/Quantum-35/repos","events_url":"https://api.github.com/users/Quantum-35/events{/privacy}","received_events_url":"https://api.github.com/users/Quantum-35/received_events","type":"User","site_admin":false},"body":"This is a PR for checking hound violations in veiw-editt-profile branch","created_at":"2018-10-24T17:38:50Z","updated_at":"2018-10-24T17:56:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2764ad1bf3e49422ee119abbbd2f40737549921e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/pulls/27/commits","review_comments_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/pulls/27/comments","review_comment_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/issues/27/comments","statuses_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/statuses/cb14976e7d3491ea46ac9492142d795ded5bfdd1","head":{"label":"andela:dummy-branch-fix-hound","ref":"dummy-branch-fix-hound","sha":"cb14976e7d3491ea46ac9492142d795ded5bfdd1","user":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":151223608,"node_id":"MDEwOlJlcG9zaXRvcnkxNTEyMjM2MDg=","name":"ah-leagueOfLegends-frontend","full_name":"andela/ah-leagueOfLegends-frontend","private":false,"owner":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/andela/ah-leagueOfLegends-frontend","description":null,"fork":false,"url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend","forks_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/forks","keys_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/teams","hooks_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/hooks","issue_events_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/events","assignees_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/tags","blobs_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/languages","stargazers_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/stargazers","contributors_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/contributors","subscribers_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/subscribers","subscription_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/subscription","commits_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/merges","archive_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/downloads","issues_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/labels{/name}","releases_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/deployments","created_at":"2018-10-02T08:28:58Z","updated_at":"2018-10-24T13:08:26Z","pushed_at":"2018-10-24T17:54:22Z","git_url":"git://github.com/andela/ah-leagueOfLegends-frontend.git","ssh_url":"[email protected]:andela/ah-leagueOfLegends-frontend.git","clone_url":"https://github.com/andela/ah-leagueOfLegends-frontend.git","svn_url":"https://github.com/andela/ah-leagueOfLegends-frontend","homepage":null,"size":925,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"develop"}},"base":{"label":"andela:develop","ref":"develop","sha":"019d14f6a153e09c9d5bd3ccd45125fca507ac2b","user":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":151223608,"node_id":"MDEwOlJlcG9zaXRvcnkxNTEyMjM2MDg=","name":"ah-leagueOfLegends-frontend","full_name":"andela/ah-leagueOfLegends-frontend","private":false,"owner":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/andela/ah-leagueOfLegends-frontend","description":null,"fork":false,"url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend","forks_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/forks","keys_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/teams","hooks_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/hooks","issue_events_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/events","assignees_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/tags","blobs_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/languages","stargazers_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/stargazers","contributors_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/contributors","subscribers_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/subscribers","subscription_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/subscription","commits_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/merges","archive_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/downloads","issues_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/labels{/name}","releases_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/deployments","created_at":"2018-10-02T08:28:58Z","updated_at":"2018-10-24T13:08:26Z","pushed_at":"2018-10-24T17:54:22Z","git_url":"git://github.com/andela/ah-leagueOfLegends-frontend.git","ssh_url":"[email protected]:andela/ah-leagueOfLegends-frontend.git","clone_url":"https://github.com/andela/ah-leagueOfLegends-frontend.git","svn_url":"https://github.com/andela/ah-leagueOfLegends-frontend","homepage":null,"size":925,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/pulls/27"},"html":{"href":"https://github.com/andela/ah-leagueOfLegends-frontend/pull/27"},"issue":{"href":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/issues/27"},"comments":{"href":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/andela/ah-leagueOfLegends-frontend/statuses/cb14976e7d3491ea46ac9492142d795ded5bfdd1"}},"author_association":"COLLABORATOR"}} | {
"id": 151223608,
"name": "andela/ah-leagueOfLegends-frontend",
"url": "https://api.github.com/repos/andela/ah-leagueOfLegends-frontend"
} | {
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
} | {
"id": 4100206,
"login": "andela",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4100206?",
"url": "https://api.github.com/orgs/andela"
} | 2018-10-24T17:56:46 | 8475088436 | {"actor":{"display_login":"houndci-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/andela/activo-web/pulls/comments/191806435","pull_request_review_id":124452195,"id":191806435,"diff_hunk":"@@ -0,0 +1,52 @@\n+import * as React from 'react';\n+import './AssetCategoryCard.scss';\n+\n+class AssetCategoryCard extends React.Component<{}> {\n+ render() {\n+ return (\n+ <React.Fragment>\n+ <div className=\"container-element\">\n+ <h2 className=\"asset-tag\">ASSET CATEGORIES</h2>","path":"src/components/AssetCategoryCard/index.tsx","position":9,"original_position":9,"commit_id":"b9585a1c0eb28b6ba806d45c67c42e459d04440f","original_commit_id":"b9585a1c0eb28b6ba806d45c67c42e459d04440f","user":{"login":"Billmike","id":24798364,"avatar_url":"https://avatars2.githubusercontent.com/u/24798364?v=4","gravatar_id":"","url":"https://api.github.com/users/Billmike","html_url":"https://github.com/Billmike","followers_url":"https://api.github.com/users/Billmike/followers","following_url":"https://api.github.com/users/Billmike/following{/other_user}","gists_url":"https://api.github.com/users/Billmike/gists{/gist_id}","starred_url":"https://api.github.com/users/Billmike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Billmike/subscriptions","organizations_url":"https://api.github.com/users/Billmike/orgs","repos_url":"https://api.github.com/users/Billmike/repos","events_url":"https://api.github.com/users/Billmike/events{/privacy}","received_events_url":"https://api.github.com/users/Billmike/received_events","type":"User","site_admin":false},"body":"Fixed.","created_at":"2018-05-30T15:08:41Z","updated_at":"2018-05-30T15:08:42Z","html_url":"https://github.com/andela/activo-web/pull/13#discussion_r191806435","pull_request_url":"https://api.github.com/repos/andela/activo-web/pulls/13","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/andela/activo-web/pulls/comments/191806435"},"html":{"href":"https://github.com/andela/activo-web/pull/13#discussion_r191806435"},"pull_request":{"href":"https://api.github.com/repos/andela/activo-web/pulls/13"}},"in_reply_to_id":191790266},"pull_request":{"url":"https://api.github.com/repos/andela/activo-web/pulls/13","id":190948689,"html_url":"https://github.com/andela/activo-web/pull/13","diff_url":"https://github.com/andela/activo-web/pull/13.diff","patch_url":"https://github.com/andela/activo-web/pull/13.patch","issue_url":"https://api.github.com/repos/andela/activo-web/issues/13","number":13,"state":"open","locked":false,"title":"#157469427 Design asset category cards","user":{"login":"Billmike","id":24798364,"avatar_url":"https://avatars2.githubusercontent.com/u/24798364?v=4","gravatar_id":"","url":"https://api.github.com/users/Billmike","html_url":"https://github.com/Billmike","followers_url":"https://api.github.com/users/Billmike/followers","following_url":"https://api.github.com/users/Billmike/following{/other_user}","gists_url":"https://api.github.com/users/Billmike/gists{/gist_id}","starred_url":"https://api.github.com/users/Billmike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Billmike/subscriptions","organizations_url":"https://api.github.com/users/Billmike/orgs","repos_url":"https://api.github.com/users/Billmike/repos","events_url":"https://api.github.com/users/Billmike/events{/privacy}","received_events_url":"https://api.github.com/users/Billmike/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\nSetup the component for the display of asset category cards\r\n\r\n### Description of task to be completed?\r\n- create dashboard component\r\n- create globals, mixins and variables scss files\r\n- import DinPro font file\r\n- write test for Assest category cards\r\n\r\n#### How should this be manually tested?\r\n- After cloning the repo, run `yarn install` to install the necessary packages\r\n- Run `yarn start:dev` to start the webpack dev-server on `port 3000`.\r\n- Open web browser to `localhost:3000` to see the dashboard component\r\n\r\n#### Any background context you want to provide?\r\nN/A\r\n\r\n#### What are the relevant pivotal tracker stories?\r\n[#157469427](https://www.pivotaltracker.com/story/show/157469427)\r\n\r\n#### Screenshots\r\n<img width=\"1280\" alt=\"screen shot 2018-05-28 at 3 47 48 pm\" src=\"https://user-images.githubusercontent.com/24798364/40619844-8612e290-628e-11e8-870b-7e5ffb718afd.png\">\r\n","created_at":"2018-05-28T14:48:57Z","updated_at":"2018-05-30T15:08:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05870a8b5218ef79e6bddfb3476fccd58da53e7a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/andela/activo-web/pulls/13/commits","review_comments_url":"https://api.github.com/repos/andela/activo-web/pulls/13/comments","review_comment_url":"https://api.github.com/repos/andela/activo-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/andela/activo-web/issues/13/comments","statuses_url":"https://api.github.com/repos/andela/activo-web/statuses/b9585a1c0eb28b6ba806d45c67c42e459d04440f","head":{"label":"andela:ft-Design-asset-category-cards-157469427","ref":"ft-Design-asset-category-cards-157469427","sha":"b9585a1c0eb28b6ba806d45c67c42e459d04440f","user":{"login":"andela","id":4100206,"avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":132578458,"name":"activo-web","full_name":"andela/activo-web","owner":{"login":"andela","id":4100206,"avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/andela/activo-web","description":null,"fork":false,"url":"https://api.github.com/repos/andela/activo-web","forks_url":"https://api.github.com/repos/andela/activo-web/forks","keys_url":"https://api.github.com/repos/andela/activo-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/activo-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/activo-web/teams","hooks_url":"https://api.github.com/repos/andela/activo-web/hooks","issue_events_url":"https://api.github.com/repos/andela/activo-web/issues/events{/number}","events_url":"https://api.github.com/repos/andela/activo-web/events","assignees_url":"https://api.github.com/repos/andela/activo-web/assignees{/user}","branches_url":"https://api.github.com/repos/andela/activo-web/branches{/branch}","tags_url":"https://api.github.com/repos/andela/activo-web/tags","blobs_url":"https://api.github.com/repos/andela/activo-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/activo-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/activo-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/activo-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/activo-web/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/activo-web/languages","stargazers_url":"https://api.github.com/repos/andela/activo-web/stargazers","contributors_url":"https://api.github.com/repos/andela/activo-web/contributors","subscribers_url":"https://api.github.com/repos/andela/activo-web/subscribers","subscription_url":"https://api.github.com/repos/andela/activo-web/subscription","commits_url":"https://api.github.com/repos/andela/activo-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/activo-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/activo-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/activo-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/activo-web/contents/{+path}","compare_url":"https://api.github.com/repos/andela/activo-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/activo-web/merges","archive_url":"https://api.github.com/repos/andela/activo-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/activo-web/downloads","issues_url":"https://api.github.com/repos/andela/activo-web/issues{/number}","pulls_url":"https://api.github.com/repos/andela/activo-web/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/activo-web/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/activo-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/activo-web/labels{/name}","releases_url":"https://api.github.com/repos/andela/activo-web/releases{/id}","deployments_url":"https://api.github.com/repos/andela/activo-web/deployments","created_at":"2018-05-08T08:28:37Z","updated_at":"2018-05-25T16:05:09Z","pushed_at":"2018-05-30T14:05:51Z","git_url":"git://github.com/andela/activo-web.git","ssh_url":"[email protected]:andela/activo-web.git","clone_url":"https://github.com/andela/activo-web.git","svn_url":"https://github.com/andela/activo-web","homepage":null,"size":2619,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":1,"open_issues":4,"watchers":0,"default_branch":"develop"}},"base":{"label":"andela:develop","ref":"develop","sha":"f116599a9a0d2ebc6698188c4df9fe4030500c0a","user":{"login":"andela","id":4100206,"avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":132578458,"name":"activo-web","full_name":"andela/activo-web","owner":{"login":"andela","id":4100206,"avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/andela/activo-web","description":null,"fork":false,"url":"https://api.github.com/repos/andela/activo-web","forks_url":"https://api.github.com/repos/andela/activo-web/forks","keys_url":"https://api.github.com/repos/andela/activo-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/activo-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/activo-web/teams","hooks_url":"https://api.github.com/repos/andela/activo-web/hooks","issue_events_url":"https://api.github.com/repos/andela/activo-web/issues/events{/number}","events_url":"https://api.github.com/repos/andela/activo-web/events","assignees_url":"https://api.github.com/repos/andela/activo-web/assignees{/user}","branches_url":"https://api.github.com/repos/andela/activo-web/branches{/branch}","tags_url":"https://api.github.com/repos/andela/activo-web/tags","blobs_url":"https://api.github.com/repos/andela/activo-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/activo-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/activo-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/activo-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/activo-web/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/activo-web/languages","stargazers_url":"https://api.github.com/repos/andela/activo-web/stargazers","contributors_url":"https://api.github.com/repos/andela/activo-web/contributors","subscribers_url":"https://api.github.com/repos/andela/activo-web/subscribers","subscription_url":"https://api.github.com/repos/andela/activo-web/subscription","commits_url":"https://api.github.com/repos/andela/activo-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/activo-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/activo-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/activo-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/activo-web/contents/{+path}","compare_url":"https://api.github.com/repos/andela/activo-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/activo-web/merges","archive_url":"https://api.github.com/repos/andela/activo-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/activo-web/downloads","issues_url":"https://api.github.com/repos/andela/activo-web/issues{/number}","pulls_url":"https://api.github.com/repos/andela/activo-web/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/activo-web/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/activo-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/activo-web/labels{/name}","releases_url":"https://api.github.com/repos/andela/activo-web/releases{/id}","deployments_url":"https://api.github.com/repos/andela/activo-web/deployments","created_at":"2018-05-08T08:28:37Z","updated_at":"2018-05-25T16:05:09Z","pushed_at":"2018-05-30T14:05:51Z","git_url":"git://github.com/andela/activo-web.git","ssh_url":"[email protected]:andela/activo-web.git","clone_url":"https://github.com/andela/activo-web.git","svn_url":"https://github.com/andela/activo-web","homepage":null,"size":2619,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":1,"open_issues":4,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/andela/activo-web/pulls/13"},"html":{"href":"https://github.com/andela/activo-web/pull/13"},"issue":{"href":"https://api.github.com/repos/andela/activo-web/issues/13"},"comments":{"href":"https://api.github.com/repos/andela/activo-web/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/andela/activo-web/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/andela/activo-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/andela/activo-web/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/andela/activo-web/statuses/b9585a1c0eb28b6ba806d45c67c42e459d04440f"}},"author_association":"CONTRIBUTOR"}} | {
"id": 132578458,
"name": "andela/activo-web",
"url": "https://api.github.com/repos/andela/activo-web"
} | {
"id": 24798364,
"login": "Billmike",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24798364?",
"url": "https://api.github.com/users/Billmike"
} | {
"id": 4100206,
"login": "andela",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4100206?",
"url": "https://api.github.com/orgs/andela"
} | 2018-05-30T15:08:41 | 7750759848 | {"actor":{"display_login":"Billmike"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/andela/balder-ah-backend/pulls/comments/237930452","pull_request_review_id":180357688,"id":237930452,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzkzMDQ1Mg==","diff_hunk":"@@ -0,0 +1,44 @@\n+export default (sequelize, DataTypes) => {\n+ const Article = sequelize.define('Article', {\n+ id: {\n+ allowNull: false,\n+ autoIncrement: true,\n+ primaryKey: true,\n+ type: DataTypes.INTEGER\n+ },\n+ slug: {\n+ allowNull: false,\n+ type: DataTypes.STRING\n+ },\n+ title: {\n+ allowNull: false,\n+ unique: false,\n+ type: DataTypes.STRING\n+ },\n+ description: {\n+ allowNull: false,\n+ type: DataTypes.STRING\n+ },\n+ body: {\n+ allowNull: false,\n+ unique: false,\n+ type: DataTypes.TEXT\n+ },\n+ imgUrl: {\n+ allowNull: true,\n+ unique: false,\n+ type: DataTypes.TEXT\n+ },\n+ userId: {\n+ allowNull: false,\n+ type: DataTypes.INTEGER\n+ }\n+ });\n+ Article.associate = models => {","path":"src/db/models/article.js","position":37,"original_position":37,"commit_id":"0563af04129d992fc9e0b04e3231c02026edb699","original_commit_id":"0563af04129d992fc9e0b04e3231c02026edb699","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Expected parentheses around arrow function argument having a body with curly braces arrow-parens","created_at":"2018-11-30T17:00:06Z","updated_at":"2018-11-30T17:00:06Z","html_url":"https://github.com/andela/balder-ah-backend/pull/12#discussion_r237930452","pull_request_url":"https://api.github.com/repos/andela/balder-ah-backend/pulls/12","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/andela/balder-ah-backend/pulls/comments/237930452"},"html":{"href":"https://github.com/andela/balder-ah-backend/pull/12#discussion_r237930452"},"pull_request":{"href":"https://api.github.com/repos/andela/balder-ah-backend/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/andela/balder-ah-backend/pulls/12","id":235053403,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MDUzNDAz","html_url":"https://github.com/andela/balder-ah-backend/pull/12","diff_url":"https://github.com/andela/balder-ah-backend/pull/12.diff","patch_url":"https://github.com/andela/balder-ah-backend/pull/12.patch","issue_url":"https://api.github.com/repos/andela/balder-ah-backend/issues/12","number":12,"state":"open","locked":false,"title":"Ft user article 162170713","user":{"login":"frostyblok","id":40468678,"node_id":"MDQ6VXNlcjQwNDY4Njc4","avatar_url":"https://avatars1.githubusercontent.com/u/40468678?v=4","gravatar_id":"","url":"https://api.github.com/users/frostyblok","html_url":"https://github.com/frostyblok","followers_url":"https://api.github.com/users/frostyblok/followers","following_url":"https://api.github.com/users/frostyblok/following{/other_user}","gists_url":"https://api.github.com/users/frostyblok/gists{/gist_id}","starred_url":"https://api.github.com/users/frostyblok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frostyblok/subscriptions","organizations_url":"https://api.github.com/users/frostyblok/orgs","repos_url":"https://api.github.com/users/frostyblok/repos","events_url":"https://api.github.com/users/frostyblok/events{/privacy}","received_events_url":"https://api.github.com/users/frostyblok/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\nPerform CRUD operations for Articles \r\n#### Description of Task to be completed?\r\nHave the following endpoints working\r\n- GET /api/articles\r\n- GET /api/articles/:slug\r\n- POST /api/articles\r\n- PUT /api/articles/:slug\r\n- DELETE /api/articles/:slug\r\n#### How should this be manually tested?\r\nAfter clonning the repo,\r\n- Run `npm install` to install the node modules and install all the dependency\r\n- Run `npm run start:dev to start the server\r\n- Use postman to test all the endpoints\r\n#### Any background context you want to provide?\r\nN/A\r\n#### What are the relevant pivotal tracker stories?\r\n#162170713\r\n#### Screenshots (if appropriate)\r\n<img width=\"1440\" alt=\"screen shot 2018-11-30 at 5 27 04 pm\" src=\"https://user-images.githubusercontent.com/40468678/49302939-a85b6a80-f4c8-11e8-8a52-829bb74bf209.png\">\r\n","created_at":"2018-11-30T16:59:24Z","updated_at":"2018-11-30T17:00:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"078462846e13101a6cf330bc45be70bdadc29caf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1145954757,"node_id":"MDU6TGFiZWwxMTQ1OTU0NzU3","url":"https://api.github.com/repos/andela/balder-ah-backend/labels/WIP","name":"WIP","color":"e0c708","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/andela/balder-ah-backend/pulls/12/commits","review_comments_url":"https://api.github.com/repos/andela/balder-ah-backend/pulls/12/comments","review_comment_url":"https://api.github.com/repos/andela/balder-ah-backend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/andela/balder-ah-backend/issues/12/comments","statuses_url":"https://api.github.com/repos/andela/balder-ah-backend/statuses/0563af04129d992fc9e0b04e3231c02026edb699","head":{"label":"andela:ft-user-article-162170713","ref":"ft-user-article-162170713","sha":"0563af04129d992fc9e0b04e3231c02026edb699","user":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":156544885,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY1NDQ4ODU=","name":"balder-ah-backend","full_name":"andela/balder-ah-backend","private":false,"owner":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/andela/balder-ah-backend","description":null,"fork":false,"url":"https://api.github.com/repos/andela/balder-ah-backend","forks_url":"https://api.github.com/repos/andela/balder-ah-backend/forks","keys_url":"https://api.github.com/repos/andela/balder-ah-backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/balder-ah-backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/balder-ah-backend/teams","hooks_url":"https://api.github.com/repos/andela/balder-ah-backend/hooks","issue_events_url":"https://api.github.com/repos/andela/balder-ah-backend/issues/events{/number}","events_url":"https://api.github.com/repos/andela/balder-ah-backend/events","assignees_url":"https://api.github.com/repos/andela/balder-ah-backend/assignees{/user}","branches_url":"https://api.github.com/repos/andela/balder-ah-backend/branches{/branch}","tags_url":"https://api.github.com/repos/andela/balder-ah-backend/tags","blobs_url":"https://api.github.com/repos/andela/balder-ah-backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/balder-ah-backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/balder-ah-backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/balder-ah-backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/balder-ah-backend/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/balder-ah-backend/languages","stargazers_url":"https://api.github.com/repos/andela/balder-ah-backend/stargazers","contributors_url":"https://api.github.com/repos/andela/balder-ah-backend/contributors","subscribers_url":"https://api.github.com/repos/andela/balder-ah-backend/subscribers","subscription_url":"https://api.github.com/repos/andela/balder-ah-backend/subscription","commits_url":"https://api.github.com/repos/andela/balder-ah-backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/balder-ah-backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/balder-ah-backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/balder-ah-backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/balder-ah-backend/contents/{+path}","compare_url":"https://api.github.com/repos/andela/balder-ah-backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/balder-ah-backend/merges","archive_url":"https://api.github.com/repos/andela/balder-ah-backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/balder-ah-backend/downloads","issues_url":"https://api.github.com/repos/andela/balder-ah-backend/issues{/number}","pulls_url":"https://api.github.com/repos/andela/balder-ah-backend/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/balder-ah-backend/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/balder-ah-backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/balder-ah-backend/labels{/name}","releases_url":"https://api.github.com/repos/andela/balder-ah-backend/releases{/id}","deployments_url":"https://api.github.com/repos/andela/balder-ah-backend/deployments","created_at":"2018-11-07T12:42:41Z","updated_at":"2018-11-30T06:19:06Z","pushed_at":"2018-11-30T16:59:25Z","git_url":"git://github.com/andela/balder-ah-backend.git","ssh_url":"[email protected]:andela/balder-ah-backend.git","clone_url":"https://github.com/andela/balder-ah-backend.git","svn_url":"https://github.com/andela/balder-ah-backend","homepage":null,"size":265,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"staging"}},"base":{"label":"andela:staging","ref":"staging","sha":"da66fd294b3b2a51a3668c091f2436b6ed47d3cf","user":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":156544885,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY1NDQ4ODU=","name":"balder-ah-backend","full_name":"andela/balder-ah-backend","private":false,"owner":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/andela/balder-ah-backend","description":null,"fork":false,"url":"https://api.github.com/repos/andela/balder-ah-backend","forks_url":"https://api.github.com/repos/andela/balder-ah-backend/forks","keys_url":"https://api.github.com/repos/andela/balder-ah-backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/balder-ah-backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/balder-ah-backend/teams","hooks_url":"https://api.github.com/repos/andela/balder-ah-backend/hooks","issue_events_url":"https://api.github.com/repos/andela/balder-ah-backend/issues/events{/number}","events_url":"https://api.github.com/repos/andela/balder-ah-backend/events","assignees_url":"https://api.github.com/repos/andela/balder-ah-backend/assignees{/user}","branches_url":"https://api.github.com/repos/andela/balder-ah-backend/branches{/branch}","tags_url":"https://api.github.com/repos/andela/balder-ah-backend/tags","blobs_url":"https://api.github.com/repos/andela/balder-ah-backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/balder-ah-backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/balder-ah-backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/balder-ah-backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/balder-ah-backend/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/balder-ah-backend/languages","stargazers_url":"https://api.github.com/repos/andela/balder-ah-backend/stargazers","contributors_url":"https://api.github.com/repos/andela/balder-ah-backend/contributors","subscribers_url":"https://api.github.com/repos/andela/balder-ah-backend/subscribers","subscription_url":"https://api.github.com/repos/andela/balder-ah-backend/subscription","commits_url":"https://api.github.com/repos/andela/balder-ah-backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/balder-ah-backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/balder-ah-backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/balder-ah-backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/balder-ah-backend/contents/{+path}","compare_url":"https://api.github.com/repos/andela/balder-ah-backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/balder-ah-backend/merges","archive_url":"https://api.github.com/repos/andela/balder-ah-backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/balder-ah-backend/downloads","issues_url":"https://api.github.com/repos/andela/balder-ah-backend/issues{/number}","pulls_url":"https://api.github.com/repos/andela/balder-ah-backend/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/balder-ah-backend/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/balder-ah-backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/balder-ah-backend/labels{/name}","releases_url":"https://api.github.com/repos/andela/balder-ah-backend/releases{/id}","deployments_url":"https://api.github.com/repos/andela/balder-ah-backend/deployments","created_at":"2018-11-07T12:42:41Z","updated_at":"2018-11-30T06:19:06Z","pushed_at":"2018-11-30T16:59:25Z","git_url":"git://github.com/andela/balder-ah-backend.git","ssh_url":"[email protected]:andela/balder-ah-backend.git","clone_url":"https://github.com/andela/balder-ah-backend.git","svn_url":"https://github.com/andela/balder-ah-backend","homepage":null,"size":265,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/andela/balder-ah-backend/pulls/12"},"html":{"href":"https://github.com/andela/balder-ah-backend/pull/12"},"issue":{"href":"https://api.github.com/repos/andela/balder-ah-backend/issues/12"},"comments":{"href":"https://api.github.com/repos/andela/balder-ah-backend/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/andela/balder-ah-backend/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/andela/balder-ah-backend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/andela/balder-ah-backend/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/andela/balder-ah-backend/statuses/0563af04129d992fc9e0b04e3231c02026edb699"}},"author_association":"COLLABORATOR"}} | {
"id": 156544885,
"name": "andela/balder-ah-backend",
"url": "https://api.github.com/repos/andela/balder-ah-backend"
} | {
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
} | {
"id": 4100206,
"login": "andela",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4100206?",
"url": "https://api.github.com/orgs/andela"
} | 2018-11-30T17:00:06 | 8677518391 | {"actor":{"display_login":"houndci-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/andela/heimdal-ah-backend/pulls/comments/241938130","pull_request_review_id":185342405,"id":241938130,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTkzODEzMA==","diff_hunk":"@@ -5,7 +5,7 @@\n \"main\": \"index.js\",\n \"scripts\": {\n \"pretest\": \"npm run db:undo:migrate:test && npm run db:migrate:test && npm run db:seed:test\",\n- \"test\": \"cross-env NODE_ENV=test nyc mocha ./test --require @babel/register --exit --timeout 250000\",\n+ \"test\": \"cross-env NODE_ENV=test nyc mocha ./test/index --require @babel/register --exit --timeout 250000\",","path":"package.json","position":5,"original_position":5,"commit_id":"a45d0d0ccbfc1a39cedfec015b0320736b75f0e2","original_commit_id":"a45d0d0ccbfc1a39cedfec015b0320736b75f0e2","user":{"login":"henperi","id":36136977,"node_id":"MDQ6VXNlcjM2MTM2OTc3","avatar_url":"https://avatars0.githubusercontent.com/u/36136977?v=4","gravatar_id":"","url":"https://api.github.com/users/henperi","html_url":"https://github.com/henperi","followers_url":"https://api.github.com/users/henperi/followers","following_url":"https://api.github.com/users/henperi/following{/other_user}","gists_url":"https://api.github.com/users/henperi/gists{/gist_id}","starred_url":"https://api.github.com/users/henperi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henperi/subscriptions","organizations_url":"https://api.github.com/users/henperi/orgs","repos_url":"https://api.github.com/users/henperi/repos","events_url":"https://api.github.com/users/henperi/events{/privacy}","received_events_url":"https://api.github.com/users/henperi/received_events","type":"User","site_admin":false},"body":"Well, using the index file we can actually control the tests in the order in which we want all of it to occur. I imported all the tests in a way that it should run sequentially. For example, a user must be created before he can create an article. And an article must be created before it can be commented on. I feel like if we connect these units together and refactor our tests a little bit to depend on each other, we can then really have an integration test.","created_at":"2018-12-15T04:34:28Z","updated_at":"2018-12-15T04:34:28Z","html_url":"https://github.com/andela/heimdal-ah-backend/pull/37#discussion_r241938130","pull_request_url":"https://api.github.com/repos/andela/heimdal-ah-backend/pulls/37","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/andela/heimdal-ah-backend/pulls/comments/241938130"},"html":{"href":"https://github.com/andela/heimdal-ah-backend/pull/37#discussion_r241938130"},"pull_request":{"href":"https://api.github.com/repos/andela/heimdal-ah-backend/pulls/37"}},"in_reply_to_id":241888079},"pull_request":{"url":"https://api.github.com/repos/andela/heimdal-ah-backend/pulls/37","id":238641930,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NjQxOTMw","html_url":"https://github.com/andela/heimdal-ah-backend/pull/37","diff_url":"https://github.com/andela/heimdal-ah-backend/pull/37.diff","patch_url":"https://github.com/andela/heimdal-ah-backend/pull/37.patch","issue_url":"https://api.github.com/repos/andela/heimdal-ah-backend/issues/37","number":37,"state":"open","locked":false,"title":"#162171028 Implement article tagging functionality","user":{"login":"henperi","id":36136977,"node_id":"MDQ6VXNlcjM2MTM2OTc3","avatar_url":"https://avatars0.githubusercontent.com/u/36136977?v=4","gravatar_id":"","url":"https://api.github.com/users/henperi","html_url":"https://github.com/henperi","followers_url":"https://api.github.com/users/henperi/followers","following_url":"https://api.github.com/users/henperi/following{/other_user}","gists_url":"https://api.github.com/users/henperi/gists{/gist_id}","starred_url":"https://api.github.com/users/henperi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henperi/subscriptions","organizations_url":"https://api.github.com/users/henperi/orgs","repos_url":"https://api.github.com/users/henperi/repos","events_url":"https://api.github.com/users/henperi/events{/privacy}","received_events_url":"https://api.github.com/users/henperi/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\n- This PR adds article tagging functionality to the app\r\n\r\n#### Description of Task to be completed?\r\n- Users should be able to add tags to their articles upon article creation\r\n- Article tags should be fetched along with articles when an article is being queried\r\n- Multiple articles can have the same tag and multiples tags can be associated many articles\r\n\r\n#### How should this be manually tested?\r\n- Clone this Repository\r\n- Run ```npm install```\r\n- Signup a new user via postman through POST 'localhost:4000/api/v1/auth/signup'\r\n- Get the returned token\r\n- Add the token to the headers (access-token) and use postman to create an article via POST 'localhost:4000/api/v1/article, remember to add an array of tags.\r\n- Watch the article being returned with a list of tags\r\n\r\n#### What are the relevant pivotal tracker stories?\r\n#162171028\r\n\r\n#### Any background context you want to add?\r\nNil\r\n\r\n#### Screenshots","created_at":"2018-12-14T08:16:23Z","updated_at":"2018-12-15T04:34:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86764d3dbe8768f398e4ea9d885838b1b3b68e92","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/andela/heimdal-ah-backend/pulls/37/commits","review_comments_url":"https://api.github.com/repos/andela/heimdal-ah-backend/pulls/37/comments","review_comment_url":"https://api.github.com/repos/andela/heimdal-ah-backend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/andela/heimdal-ah-backend/issues/37/comments","statuses_url":"https://api.github.com/repos/andela/heimdal-ah-backend/statuses/a45d0d0ccbfc1a39cedfec015b0320736b75f0e2","head":{"label":"andela:ft-implement-tagging-articles-162171028","ref":"ft-implement-tagging-articles-162171028","sha":"a45d0d0ccbfc1a39cedfec015b0320736b75f0e2","user":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":156545133,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY1NDUxMzM=","name":"heimdal-ah-backend","full_name":"andela/heimdal-ah-backend","private":false,"owner":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/andela/heimdal-ah-backend","description":null,"fork":false,"url":"https://api.github.com/repos/andela/heimdal-ah-backend","forks_url":"https://api.github.com/repos/andela/heimdal-ah-backend/forks","keys_url":"https://api.github.com/repos/andela/heimdal-ah-backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/heimdal-ah-backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/heimdal-ah-backend/teams","hooks_url":"https://api.github.com/repos/andela/heimdal-ah-backend/hooks","issue_events_url":"https://api.github.com/repos/andela/heimdal-ah-backend/issues/events{/number}","events_url":"https://api.github.com/repos/andela/heimdal-ah-backend/events","assignees_url":"https://api.github.com/repos/andela/heimdal-ah-backend/assignees{/user}","branches_url":"https://api.github.com/repos/andela/heimdal-ah-backend/branches{/branch}","tags_url":"https://api.github.com/repos/andela/heimdal-ah-backend/tags","blobs_url":"https://api.github.com/repos/andela/heimdal-ah-backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/heimdal-ah-backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/heimdal-ah-backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/heimdal-ah-backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/heimdal-ah-backend/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/heimdal-ah-backend/languages","stargazers_url":"https://api.github.com/repos/andela/heimdal-ah-backend/stargazers","contributors_url":"https://api.github.com/repos/andela/heimdal-ah-backend/contributors","subscribers_url":"https://api.github.com/repos/andela/heimdal-ah-backend/subscribers","subscription_url":"https://api.github.com/repos/andela/heimdal-ah-backend/subscription","commits_url":"https://api.github.com/repos/andela/heimdal-ah-backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/heimdal-ah-backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/heimdal-ah-backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/heimdal-ah-backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/heimdal-ah-backend/contents/{+path}","compare_url":"https://api.github.com/repos/andela/heimdal-ah-backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/heimdal-ah-backend/merges","archive_url":"https://api.github.com/repos/andela/heimdal-ah-backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/heimdal-ah-backend/downloads","issues_url":"https://api.github.com/repos/andela/heimdal-ah-backend/issues{/number}","pulls_url":"https://api.github.com/repos/andela/heimdal-ah-backend/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/heimdal-ah-backend/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/heimdal-ah-backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/heimdal-ah-backend/labels{/name}","releases_url":"https://api.github.com/repos/andela/heimdal-ah-backend/releases{/id}","deployments_url":"https://api.github.com/repos/andela/heimdal-ah-backend/deployments","created_at":"2018-11-07T12:44:53Z","updated_at":"2018-12-14T17:07:15Z","pushed_at":"2018-12-14T17:50:31Z","git_url":"git://github.com/andela/heimdal-ah-backend.git","ssh_url":"[email protected]:andela/heimdal-ah-backend.git","clone_url":"https://github.com/andela/heimdal-ah-backend.git","svn_url":"https://github.com/andela/heimdal-ah-backend","homepage":"https://heimdal-ah-staging.herokuapp.com/","size":836,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":1,"open_issues":2,"watchers":0,"default_branch":"develop"}},"base":{"label":"andela:develop","ref":"develop","sha":"fcce689677fe5c203bc56763ba5b732d9752c3b8","user":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":156545133,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY1NDUxMzM=","name":"heimdal-ah-backend","full_name":"andela/heimdal-ah-backend","private":false,"owner":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/andela/heimdal-ah-backend","description":null,"fork":false,"url":"https://api.github.com/repos/andela/heimdal-ah-backend","forks_url":"https://api.github.com/repos/andela/heimdal-ah-backend/forks","keys_url":"https://api.github.com/repos/andela/heimdal-ah-backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/heimdal-ah-backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/heimdal-ah-backend/teams","hooks_url":"https://api.github.com/repos/andela/heimdal-ah-backend/hooks","issue_events_url":"https://api.github.com/repos/andela/heimdal-ah-backend/issues/events{/number}","events_url":"https://api.github.com/repos/andela/heimdal-ah-backend/events","assignees_url":"https://api.github.com/repos/andela/heimdal-ah-backend/assignees{/user}","branches_url":"https://api.github.com/repos/andela/heimdal-ah-backend/branches{/branch}","tags_url":"https://api.github.com/repos/andela/heimdal-ah-backend/tags","blobs_url":"https://api.github.com/repos/andela/heimdal-ah-backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/heimdal-ah-backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/heimdal-ah-backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/heimdal-ah-backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/heimdal-ah-backend/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/heimdal-ah-backend/languages","stargazers_url":"https://api.github.com/repos/andela/heimdal-ah-backend/stargazers","contributors_url":"https://api.github.com/repos/andela/heimdal-ah-backend/contributors","subscribers_url":"https://api.github.com/repos/andela/heimdal-ah-backend/subscribers","subscription_url":"https://api.github.com/repos/andela/heimdal-ah-backend/subscription","commits_url":"https://api.github.com/repos/andela/heimdal-ah-backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/heimdal-ah-backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/heimdal-ah-backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/heimdal-ah-backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/heimdal-ah-backend/contents/{+path}","compare_url":"https://api.github.com/repos/andela/heimdal-ah-backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/heimdal-ah-backend/merges","archive_url":"https://api.github.com/repos/andela/heimdal-ah-backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/heimdal-ah-backend/downloads","issues_url":"https://api.github.com/repos/andela/heimdal-ah-backend/issues{/number}","pulls_url":"https://api.github.com/repos/andela/heimdal-ah-backend/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/heimdal-ah-backend/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/heimdal-ah-backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/heimdal-ah-backend/labels{/name}","releases_url":"https://api.github.com/repos/andela/heimdal-ah-backend/releases{/id}","deployments_url":"https://api.github.com/repos/andela/heimdal-ah-backend/deployments","created_at":"2018-11-07T12:44:53Z","updated_at":"2018-12-14T17:07:15Z","pushed_at":"2018-12-14T17:50:31Z","git_url":"git://github.com/andela/heimdal-ah-backend.git","ssh_url":"[email protected]:andela/heimdal-ah-backend.git","clone_url":"https://github.com/andela/heimdal-ah-backend.git","svn_url":"https://github.com/andela/heimdal-ah-backend","homepage":"https://heimdal-ah-staging.herokuapp.com/","size":836,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":1,"open_issues":2,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/andela/heimdal-ah-backend/pulls/37"},"html":{"href":"https://github.com/andela/heimdal-ah-backend/pull/37"},"issue":{"href":"https://api.github.com/repos/andela/heimdal-ah-backend/issues/37"},"comments":{"href":"https://api.github.com/repos/andela/heimdal-ah-backend/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/andela/heimdal-ah-backend/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/andela/heimdal-ah-backend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/andela/heimdal-ah-backend/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/andela/heimdal-ah-backend/statuses/a45d0d0ccbfc1a39cedfec015b0320736b75f0e2"}},"author_association":"COLLABORATOR"}} | {
"id": 156545133,
"name": "andela/heimdal-ah-backend",
"url": "https://api.github.com/repos/andela/heimdal-ah-backend"
} | {
"id": 36136977,
"login": "henperi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/36136977?",
"url": "https://api.github.com/users/henperi"
} | {
"id": 4100206,
"login": "andela",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4100206?",
"url": "https://api.github.com/orgs/andela"
} | 2018-12-15T04:34:28 | 8758486335 | {"actor":{"display_login":"henperi"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/andela/casablanca-cfh/pulls/comments/180739522","pull_request_review_id":111211125,"id":180739522,"diff_hunk":"@@ -274,54 +287,54 @@ Game.prototype.dealAnswers = function(maxAnswers) {\n }\n };\n \n-Game.prototype._findPlayerIndexBySocket = function(thisPlayer) {\n- var playerIndex = -1;\n- _.each(this.players, function(player, index) {\n+Game.prototype._findPlayerIndexBySocket = function (thisPlayer) {\n+ let playerIndex = -1;\n+ _.each(this.players, (player, index) => {\n if (player.socket.id === thisPlayer) {\n playerIndex = index;\n }\n });\n return playerIndex;\n };\n \n-Game.prototype.pickCards = function(thisCardArray, thisPlayer) {\n+Game.prototype.pickCards = function (thisCardArray, thisPlayer) {\n // Only accept cards when we expect players to pick a card\n- if (this.state === \"waiting for players to pick\") {\n+ if (this.state === 'waiting for players to pick') {\n // Find the player's position in the players array\n- var playerIndex = this._findPlayerIndexBySocket(thisPlayer);\n- console.log('player is at index',playerIndex);\n+ const playerIndex = this._findPlayerIndexBySocket(thisPlayer);\n+ console.log('player is at index', playerIndex);\n if (playerIndex !== -1) {\n // Verify that the player hasn't previously picked a card\n- var previouslySubmitted = false;\n- _.each(this.table, function(pickedSet, index) {\n+ let previouslySubmitted = false;\n+ _.each(this.table, (pickedSet, index) => {\n if (pickedSet.player === thisPlayer) {\n previouslySubmitted = true;\n }\n });\n if (!previouslySubmitted) {\n // Find the indices of the cards in the player's hand (given the card ids)\n- var tableCard = [];\n- for (var i = 0; i < thisCardArray.length; i++ ) {\n- var cardIndex = null;\n- for (var j = 0; j < this.players[playerIndex].hand.length; j++) {\n+ const tableCard = [];\n+ for (let i = 0; i < thisCardArray.length; i++) {\n+ let cardIndex = null;\n+ for (let j = 0; j < this.players[playerIndex].hand.length; j++) {\n if (this.players[playerIndex].hand[j].id === thisCardArray[i]) {\n cardIndex = j;\n }\n }\n- console.log('card',i,'is at index',cardIndex);\n+ console.log('card', i, 'is at index', cardIndex);","path":"config/socket/game.js","position":368,"original_position":368,"commit_id":"54180a0f0f33d226fa136d816072cb9d122247b7","original_commit_id":"54180a0f0f33d226fa136d816072cb9d122247b7","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Unexpected console statement no-console","created_at":"2018-04-11T12:42:40Z","updated_at":"2018-04-11T12:42:40Z","html_url":"https://github.com/andela/casablanca-cfh/pull/24#discussion_r180739522","pull_request_url":"https://api.github.com/repos/andela/casablanca-cfh/pulls/24","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/andela/casablanca-cfh/pulls/comments/180739522"},"html":{"href":"https://github.com/andela/casablanca-cfh/pull/24#discussion_r180739522"},"pull_request":{"href":"https://api.github.com/repos/andela/casablanca-cfh/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/andela/casablanca-cfh/pulls/24","id":180681925,"html_url":"https://github.com/andela/casablanca-cfh/pull/24","diff_url":"https://github.com/andela/casablanca-cfh/pull/24.diff","patch_url":"https://github.com/andela/casablanca-cfh/pull/24.patch","issue_url":"https://api.github.com/repos/andela/casablanca-cfh/issues/24","number":24,"state":"open","locked":false,"title":"#156096163 Ft gaming screen ui 156096163","user":{"login":"Abudu-Samuel","id":32877552,"avatar_url":"https://avatars1.githubusercontent.com/u/32877552?v=4","gravatar_id":"","url":"https://api.github.com/users/Abudu-Samuel","html_url":"https://github.com/Abudu-Samuel","followers_url":"https://api.github.com/users/Abudu-Samuel/followers","following_url":"https://api.github.com/users/Abudu-Samuel/following{/other_user}","gists_url":"https://api.github.com/users/Abudu-Samuel/gists{/gist_id}","starred_url":"https://api.github.com/users/Abudu-Samuel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Abudu-Samuel/subscriptions","organizations_url":"https://api.github.com/users/Abudu-Samuel/orgs","repos_url":"https://api.github.com/users/Abudu-Samuel/repos","events_url":"https://api.github.com/users/Abudu-Samuel/events{/privacy}","received_events_url":"https://api.github.com/users/Abudu-Samuel/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\n It redesigns the game screen page\r\n\r\n#### Description of Task to be completed?\r\nRe-Design UI for game screen\r\n\r\n#### How should this be manually tested?\r\n- clone the repo and change into the project directory\r\n- run `npm install` to install required packages\r\n- create a `.env` file and add all the required environment variables as specified in `.env.example`\r\n- use `npm run start:dev` to start up the server\r\n- visit `http://localhost:3000/#!/app` to see and test the game page\r\n\r\n#### Any background context you want to provide?\r\nN/A\r\n\r\n### Screenshots\r\n<img width=\"1280\" alt=\"screen shot 2018-04-10 at 6 46 24 pm\" src=\"https://user-images.githubusercontent.com/32877552/38574059-c0c73090-3cef-11e8-8039-739e561af748.png\">\r\n<img width=\"1280\" alt=\"screen shot 2018-04-10 at 6 46 46 pm\" src=\"https://user-images.githubusercontent.com/32877552/38574061-c176da2c-3cef-11e8-87bb-efb6068c7a8f.png\">\r\n<img width=\"1280\" alt=\"screen shot 2018-04-10 at 6 47 07 pm\" src=\"https://user-images.githubusercontent.com/32877552/38574065-c21f3172-3cef-11e8-8927-5a85e884c6db.png\">\r\n<img width=\"1280\" alt=\"screen shot 2018-04-10 at 6 47 14 pm\" src=\"https://user-images.githubusercontent.com/32877552/38574066-c248a868-3cef-11e8-9f98-d869b0996d20.png\">\r\n\r\n#### What are the relevant pivotal tracker stories?(if applicable)\r\n#156096163","created_at":"2018-04-10T17:57:44Z","updated_at":"2018-04-11T12:42:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef143c2c7ee7a85440ce1aa805ccac1f93e44473","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/andela/casablanca-cfh/pulls/24/commits","review_comments_url":"https://api.github.com/repos/andela/casablanca-cfh/pulls/24/comments","review_comment_url":"https://api.github.com/repos/andela/casablanca-cfh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/andela/casablanca-cfh/issues/24/comments","statuses_url":"https://api.github.com/repos/andela/casablanca-cfh/statuses/54180a0f0f33d226fa136d816072cb9d122247b7","head":{"label":"andela:ft-gaming-screen-ui-156096163","ref":"ft-gaming-screen-ui-156096163","sha":"54180a0f0f33d226fa136d816072cb9d122247b7","user":{"login":"andela","id":4100206,"avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":125843476,"name":"casablanca-cfh","full_name":"andela/casablanca-cfh","owner":{"login":"andela","id":4100206,"avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/andela/casablanca-cfh","description":null,"fork":false,"url":"https://api.github.com/repos/andela/casablanca-cfh","forks_url":"https://api.github.com/repos/andela/casablanca-cfh/forks","keys_url":"https://api.github.com/repos/andela/casablanca-cfh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/casablanca-cfh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/casablanca-cfh/teams","hooks_url":"https://api.github.com/repos/andela/casablanca-cfh/hooks","issue_events_url":"https://api.github.com/repos/andela/casablanca-cfh/issues/events{/number}","events_url":"https://api.github.com/repos/andela/casablanca-cfh/events","assignees_url":"https://api.github.com/repos/andela/casablanca-cfh/assignees{/user}","branches_url":"https://api.github.com/repos/andela/casablanca-cfh/branches{/branch}","tags_url":"https://api.github.com/repos/andela/casablanca-cfh/tags","blobs_url":"https://api.github.com/repos/andela/casablanca-cfh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/casablanca-cfh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/casablanca-cfh/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/casablanca-cfh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/casablanca-cfh/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/casablanca-cfh/languages","stargazers_url":"https://api.github.com/repos/andela/casablanca-cfh/stargazers","contributors_url":"https://api.github.com/repos/andela/casablanca-cfh/contributors","subscribers_url":"https://api.github.com/repos/andela/casablanca-cfh/subscribers","subscription_url":"https://api.github.com/repos/andela/casablanca-cfh/subscription","commits_url":"https://api.github.com/repos/andela/casablanca-cfh/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/casablanca-cfh/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/casablanca-cfh/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/casablanca-cfh/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/casablanca-cfh/contents/{+path}","compare_url":"https://api.github.com/repos/andela/casablanca-cfh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/casablanca-cfh/merges","archive_url":"https://api.github.com/repos/andela/casablanca-cfh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/casablanca-cfh/downloads","issues_url":"https://api.github.com/repos/andela/casablanca-cfh/issues{/number}","pulls_url":"https://api.github.com/repos/andela/casablanca-cfh/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/casablanca-cfh/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/casablanca-cfh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/casablanca-cfh/labels{/name}","releases_url":"https://api.github.com/repos/andela/casablanca-cfh/releases{/id}","deployments_url":"https://api.github.com/repos/andela/casablanca-cfh/deployments","created_at":"2018-03-19T10:52:34Z","updated_at":"2018-04-09T00:02:02Z","pushed_at":"2018-04-11T12:42:22Z","git_url":"git://github.com/andela/casablanca-cfh.git","ssh_url":"[email protected]:andela/casablanca-cfh.git","clone_url":"https://github.com/andela/casablanca-cfh.git","svn_url":"https://github.com/andela/casablanca-cfh","homepage":null,"size":22475,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"andela:develop","ref":"develop","sha":"4806a9da594ee3d078c3b3d86369e76db59715b0","user":{"login":"andela","id":4100206,"avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":125843476,"name":"casablanca-cfh","full_name":"andela/casablanca-cfh","owner":{"login":"andela","id":4100206,"avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/andela/casablanca-cfh","description":null,"fork":false,"url":"https://api.github.com/repos/andela/casablanca-cfh","forks_url":"https://api.github.com/repos/andela/casablanca-cfh/forks","keys_url":"https://api.github.com/repos/andela/casablanca-cfh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/casablanca-cfh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/casablanca-cfh/teams","hooks_url":"https://api.github.com/repos/andela/casablanca-cfh/hooks","issue_events_url":"https://api.github.com/repos/andela/casablanca-cfh/issues/events{/number}","events_url":"https://api.github.com/repos/andela/casablanca-cfh/events","assignees_url":"https://api.github.com/repos/andela/casablanca-cfh/assignees{/user}","branches_url":"https://api.github.com/repos/andela/casablanca-cfh/branches{/branch}","tags_url":"https://api.github.com/repos/andela/casablanca-cfh/tags","blobs_url":"https://api.github.com/repos/andela/casablanca-cfh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/casablanca-cfh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/casablanca-cfh/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/casablanca-cfh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/casablanca-cfh/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/casablanca-cfh/languages","stargazers_url":"https://api.github.com/repos/andela/casablanca-cfh/stargazers","contributors_url":"https://api.github.com/repos/andela/casablanca-cfh/contributors","subscribers_url":"https://api.github.com/repos/andela/casablanca-cfh/subscribers","subscription_url":"https://api.github.com/repos/andela/casablanca-cfh/subscription","commits_url":"https://api.github.com/repos/andela/casablanca-cfh/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/casablanca-cfh/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/casablanca-cfh/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/casablanca-cfh/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/casablanca-cfh/contents/{+path}","compare_url":"https://api.github.com/repos/andela/casablanca-cfh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/casablanca-cfh/merges","archive_url":"https://api.github.com/repos/andela/casablanca-cfh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/casablanca-cfh/downloads","issues_url":"https://api.github.com/repos/andela/casablanca-cfh/issues{/number}","pulls_url":"https://api.github.com/repos/andela/casablanca-cfh/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/casablanca-cfh/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/casablanca-cfh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/casablanca-cfh/labels{/name}","releases_url":"https://api.github.com/repos/andela/casablanca-cfh/releases{/id}","deployments_url":"https://api.github.com/repos/andela/casablanca-cfh/deployments","created_at":"2018-03-19T10:52:34Z","updated_at":"2018-04-09T00:02:02Z","pushed_at":"2018-04-11T12:42:22Z","git_url":"git://github.com/andela/casablanca-cfh.git","ssh_url":"[email protected]:andela/casablanca-cfh.git","clone_url":"https://github.com/andela/casablanca-cfh.git","svn_url":"https://github.com/andela/casablanca-cfh","homepage":null,"size":22475,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/andela/casablanca-cfh/pulls/24"},"html":{"href":"https://github.com/andela/casablanca-cfh/pull/24"},"issue":{"href":"https://api.github.com/repos/andela/casablanca-cfh/issues/24"},"comments":{"href":"https://api.github.com/repos/andela/casablanca-cfh/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/andela/casablanca-cfh/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/andela/casablanca-cfh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/andela/casablanca-cfh/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/andela/casablanca-cfh/statuses/54180a0f0f33d226fa136d816072cb9d122247b7"}},"author_association":"COLLABORATOR"}} | {
"id": 125843476,
"name": "andela/casablanca-cfh",
"url": "https://api.github.com/repos/andela/casablanca-cfh"
} | {
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
} | {
"id": 4100206,
"login": "andela",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4100206?",
"url": "https://api.github.com/orgs/andela"
} | 2018-04-11T12:42:40 | 7513259136 | {"actor":{"display_login":"houndci-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/andela/gondor-cfh/pulls/comments/199015340","pull_request_review_id":133054601,"id":199015340,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTAxNTM0MA==","diff_hunk":"@@ -0,0 +1,166 @@\n+import should from 'should';\n+import io from 'socket.io-client';\n+\n+const socketURL = 'http://localhost:3000';\n+\n+const options = {\n+ transports: ['websocket'],\n+ 'force new connection': true\n+};\n+\n+const cfhPlayer1 = { name: 'Tom' };\n+const cfhPlayer2 = { name: 'Sally' };\n+const cfhPlayer3 = { name: 'Dana' };\n+\n+describe('Game Server', () => {\n+ it('Should accept requests to joinGame', (done) => {\n+ const client1 = io.connect(socketURL, options);\n+ const disconnect = function () {\n+ client1.disconnect();\n+ done();\n+ };\n+ client1.on('connect', (data) => {\n+ client1.emit('joinGame', { userID: 'unauthenticated', room: '', createPrivate: false });\n+ setTimeout(disconnect, 200);\n+ });\n+ });\n+\n+ it('Should send a game update upon receiving request to joinGame', (done) => {\n+ const client1 = io.connect(socketURL, options);\n+ const disconnect = function () {\n+ client1.disconnect();\n+ done();\n+ };\n+ client1.on('connect', (data) => {\n+ client1.emit('joinGame', { userID: 'unauthenticated', room: '', createPrivate: false });\n+ client1.on('gameUpdate', (data) => {\n+ data.gameID.should.match(/\\d+/);\n+ });\n+ setTimeout(disconnect, 200);\n+ });\n+ });\n+\n+ it('Should announce new user to all users', (done) => {\n+ const client1 = io.connect(socketURL, options);\n+ let client2;\n+ const disconnect = function () {\n+ client1.disconnect();\n+ client2.disconnect();\n+ done();\n+ };\n+ client1.on('connect', (data) => {\n+ client1.emit('joinGame', { userID: 'unauthenticated', room: '', createPrivate: false });\n+ client2 = io.connect(socketURL, options);\n+ client2.on('connect', (data) => {\n+ client2.emit('joinGame', { userID: 'unauthenticated', room: '', createPrivate: false });\n+ client1.on('notification', (data) => {\n+ data.notification.should.match(/ has joined the game\\!/);\n+ });\n+ });\n+ setTimeout(disconnect, 200);\n+ });\n+ });\n+\n+ it('Should start game when startGame event is sent with 3 players', (done) => {\n+ let client1, client2, client3;\n+ client1 = io.connect(socketURL, options);\n+ const disconnect = function () {\n+ client1.disconnect();\n+ client2.disconnect();\n+ client3.disconnect();\n+ done();\n+ };\n+ const expectStartGame = function () {\n+ client1.emit('startGame');\n+ client1.on('gameUpdate', (data) => {\n+ data.state.should.equal('waiting for players to pick');\n+ });\n+ client2.on('gameUpdate', (data) => {\n+ data.state.should.equal('waiting for players to pick');\n+ });\n+ client3.on('gameUpdate', (data) => {\n+ data.state.should.equal('waiting for players to pick');\n+ });\n+ setTimeout(disconnect, 200);\n+ };\n+ client1.on('connect', (data) => {\n+ client1.emit('joinGame', { userID: 'unauthenticated', room: '', createPrivate: false });\n+ client2 = io.connect(socketURL, options);\n+ client2.on('connect', (data) => {\n+ client2.emit('joinGame', { userID: 'unauthenticated', room: '', createPrivate: false });\n+ client3 = io.connect(socketURL, options);\n+ client3.on('connect', (data) => {\n+ client3.emit('joinGame', { userID: 'unauthenticated', room: '', createPrivate: false });\n+ setTimeout(expectStartGame, 100);\n+ });\n+ });\n+ });\n+ });\n+\n+ it('Should automatically start game when 6 players are in a game', (done) => {\n+ let client1, client2, client3, client4, client5, client6;\n+ client1 = io.connect(socketURL, options);\n+ const disconnect = function () {\n+ client1.disconnect();\n+ client2.disconnect();\n+ client3.disconnect();\n+ client4.disconnect();\n+ client5.disconnect();\n+ client6.disconnect();\n+ done();\n+ };\n+ const expectStartGame = function () {\n+ client1.emit('startGame');\n+ client1.on('gameUpdate', (data) => {\n+ data.state.should.equal('waiting for players to pick');\n+ });\n+ client2.on('gameUpdate', (data) => {\n+ data.state.should.equal('waiting for players to pick');\n+ });\n+ client3.on('gameUpdate', (data) => {\n+ data.state.should.equal('waiting for players to pick');\n+ });\n+ client4.on('gameUpdate', (data) => {\n+ data.state.should.equal('waiting for players to pick');\n+ });\n+ client5.on('gameUpdate', (data) => {\n+ data.state.should.equal('waiting for players to pick');\n+ });\n+ client6.on('gameUpdate', (data) => {\n+ data.state.should.equal('waiting for players to pick');\n+ });\n+ setTimeout(disconnect, 200);\n+ };\n+ client1.on('connect', (data) => {\n+ client1.emit('joinGame', { userID: 'unauthenticated', room: '', createPrivate: true });\n+ let connectOthers = true;\n+ client1.on('gameUpdate', (data) => {\n+ const gameID = data.gameID;\n+ if (connectOthers) {\n+ client2 = io.connect(socketURL, options);\n+ connectOthers = false;\n+ client2.on('connect', (data) => {\n+ client2.emit('joinGame', { userID: 'unauthenticated', room: gameID, createPrivate: false });\n+ client3 = io.connect(socketURL, options);\n+ client3.on('connect', (data) => {\n+ client3.emit('joinGame', { userID: 'unauthenticated', room: gameID, createPrivate: false });\n+ client4 = io.connect(socketURL, options);\n+ client4.on('connect', (data) => {","path":"server/test/game/game.js","position":148,"original_position":148,"commit_id":"c7a9543a010f6e886fd208b096b952094f0731ff","original_commit_id":"c7a9543a010f6e886fd208b096b952094f0731ff","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"'data' is defined but never used no-unused-vars<br>'data' is already declared in the upper scope no-shadow","created_at":"2018-06-28T23:18:27Z","updated_at":"2018-06-28T23:18:28Z","html_url":"https://github.com/andela/gondor-cfh/pull/10#discussion_r199015340","pull_request_url":"https://api.github.com/repos/andela/gondor-cfh/pulls/10","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/andela/gondor-cfh/pulls/comments/199015340"},"html":{"href":"https://github.com/andela/gondor-cfh/pull/10#discussion_r199015340"},"pull_request":{"href":"https://api.github.com/repos/andela/gondor-cfh/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/andela/gondor-cfh/pulls/10","id":198143103,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MTQzMTAz","html_url":"https://github.com/andela/gondor-cfh/pull/10","diff_url":"https://github.com/andela/gondor-cfh/pull/10.diff","patch_url":"https://github.com/andela/gondor-cfh/pull/10.patch","issue_url":"https://api.github.com/repos/andela/gondor-cfh/issues/10","number":10,"state":"open","locked":false,"title":"#158687936 Codebase restructure","user":{"login":"otseobande","id":17123317,"node_id":"MDQ6VXNlcjE3MTIzMzE3","avatar_url":"https://avatars3.githubusercontent.com/u/17123317?v=4","gravatar_id":"","url":"https://api.github.com/users/otseobande","html_url":"https://github.com/otseobande","followers_url":"https://api.github.com/users/otseobande/followers","following_url":"https://api.github.com/users/otseobande/following{/other_user}","gists_url":"https://api.github.com/users/otseobande/gists{/gist_id}","starred_url":"https://api.github.com/users/otseobande/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otseobande/subscriptions","organizations_url":"https://api.github.com/users/otseobande/orgs","repos_url":"https://api.github.com/users/otseobande/repos","events_url":"https://api.github.com/users/otseobande/events{/privacy}","received_events_url":"https://api.github.com/users/otseobande/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\n - Reorganises the codebase and refactors major parts of the app to es6+\r\n - Adds new gulp tasks to speed up development\r\n - Keeps the app in the same logical state.\r\n\r\n#### Description of Task to be completed?\r\n- N/A\r\n\r\n#### How should this be manually tested?\r\n\r\n- ```npm run test```\r\n#### Any background context you want to provide?\r\n- N/A\r\n\r\n#### What are the relevant pivotal tracker stories?\r\n- #158687936\r\n\r\n#### Screenshots (if appropriate)\r\n- N/A\r\n\r\n#### Questions:\r\n- N/A","created_at":"2018-06-28T20:25:01Z","updated_at":"2018-06-28T23:18:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0a5354f0989ef81093a14805b7939b587a90516","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/andela/gondor-cfh/pulls/10/commits","review_comments_url":"https://api.github.com/repos/andela/gondor-cfh/pulls/10/comments","review_comment_url":"https://api.github.com/repos/andela/gondor-cfh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/andela/gondor-cfh/issues/10/comments","statuses_url":"https://api.github.com/repos/andela/gondor-cfh/statuses/c7a9543a010f6e886fd208b096b952094f0731ff","head":{"label":"andela:chore/158687936/codebase-restructure","ref":"chore/158687936/codebase-restructure","sha":"c7a9543a010f6e886fd208b096b952094f0731ff","user":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":137855156,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc4NTUxNTY=","name":"gondor-cfh","full_name":"andela/gondor-cfh","owner":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/andela/gondor-cfh","description":null,"fork":false,"url":"https://api.github.com/repos/andela/gondor-cfh","forks_url":"https://api.github.com/repos/andela/gondor-cfh/forks","keys_url":"https://api.github.com/repos/andela/gondor-cfh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/gondor-cfh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/gondor-cfh/teams","hooks_url":"https://api.github.com/repos/andela/gondor-cfh/hooks","issue_events_url":"https://api.github.com/repos/andela/gondor-cfh/issues/events{/number}","events_url":"https://api.github.com/repos/andela/gondor-cfh/events","assignees_url":"https://api.github.com/repos/andela/gondor-cfh/assignees{/user}","branches_url":"https://api.github.com/repos/andela/gondor-cfh/branches{/branch}","tags_url":"https://api.github.com/repos/andela/gondor-cfh/tags","blobs_url":"https://api.github.com/repos/andela/gondor-cfh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/gondor-cfh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/gondor-cfh/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/gondor-cfh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/gondor-cfh/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/gondor-cfh/languages","stargazers_url":"https://api.github.com/repos/andela/gondor-cfh/stargazers","contributors_url":"https://api.github.com/repos/andela/gondor-cfh/contributors","subscribers_url":"https://api.github.com/repos/andela/gondor-cfh/subscribers","subscription_url":"https://api.github.com/repos/andela/gondor-cfh/subscription","commits_url":"https://api.github.com/repos/andela/gondor-cfh/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/gondor-cfh/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/gondor-cfh/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/gondor-cfh/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/gondor-cfh/contents/{+path}","compare_url":"https://api.github.com/repos/andela/gondor-cfh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/gondor-cfh/merges","archive_url":"https://api.github.com/repos/andela/gondor-cfh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/gondor-cfh/downloads","issues_url":"https://api.github.com/repos/andela/gondor-cfh/issues{/number}","pulls_url":"https://api.github.com/repos/andela/gondor-cfh/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/gondor-cfh/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/gondor-cfh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/gondor-cfh/labels{/name}","releases_url":"https://api.github.com/repos/andela/gondor-cfh/releases{/id}","deployments_url":"https://api.github.com/repos/andela/gondor-cfh/deployments","created_at":"2018-06-19T07:23:24Z","updated_at":"2018-06-28T12:26:41Z","pushed_at":"2018-06-28T23:17:54Z","git_url":"git://github.com/andela/gondor-cfh.git","ssh_url":"[email protected]:andela/gondor-cfh.git","clone_url":"https://github.com/andela/gondor-cfh.git","svn_url":"https://github.com/andela/gondor-cfh","homepage":"https://cfhtdd.herokuapp.com/#!/","size":9888,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":2,"watchers":0,"default_branch":"staging"}},"base":{"label":"andela:staging","ref":"staging","sha":"3ee971bd2d56cf7cbeec9b4d510be29fd0445d8e","user":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":137855156,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc4NTUxNTY=","name":"gondor-cfh","full_name":"andela/gondor-cfh","owner":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/andela/gondor-cfh","description":null,"fork":false,"url":"https://api.github.com/repos/andela/gondor-cfh","forks_url":"https://api.github.com/repos/andela/gondor-cfh/forks","keys_url":"https://api.github.com/repos/andela/gondor-cfh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/gondor-cfh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/gondor-cfh/teams","hooks_url":"https://api.github.com/repos/andela/gondor-cfh/hooks","issue_events_url":"https://api.github.com/repos/andela/gondor-cfh/issues/events{/number}","events_url":"https://api.github.com/repos/andela/gondor-cfh/events","assignees_url":"https://api.github.com/repos/andela/gondor-cfh/assignees{/user}","branches_url":"https://api.github.com/repos/andela/gondor-cfh/branches{/branch}","tags_url":"https://api.github.com/repos/andela/gondor-cfh/tags","blobs_url":"https://api.github.com/repos/andela/gondor-cfh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/gondor-cfh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/gondor-cfh/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/gondor-cfh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/gondor-cfh/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/gondor-cfh/languages","stargazers_url":"https://api.github.com/repos/andela/gondor-cfh/stargazers","contributors_url":"https://api.github.com/repos/andela/gondor-cfh/contributors","subscribers_url":"https://api.github.com/repos/andela/gondor-cfh/subscribers","subscription_url":"https://api.github.com/repos/andela/gondor-cfh/subscription","commits_url":"https://api.github.com/repos/andela/gondor-cfh/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/gondor-cfh/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/gondor-cfh/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/gondor-cfh/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/gondor-cfh/contents/{+path}","compare_url":"https://api.github.com/repos/andela/gondor-cfh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/gondor-cfh/merges","archive_url":"https://api.github.com/repos/andela/gondor-cfh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/gondor-cfh/downloads","issues_url":"https://api.github.com/repos/andela/gondor-cfh/issues{/number}","pulls_url":"https://api.github.com/repos/andela/gondor-cfh/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/gondor-cfh/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/gondor-cfh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/gondor-cfh/labels{/name}","releases_url":"https://api.github.com/repos/andela/gondor-cfh/releases{/id}","deployments_url":"https://api.github.com/repos/andela/gondor-cfh/deployments","created_at":"2018-06-19T07:23:24Z","updated_at":"2018-06-28T12:26:41Z","pushed_at":"2018-06-28T23:17:54Z","git_url":"git://github.com/andela/gondor-cfh.git","ssh_url":"[email protected]:andela/gondor-cfh.git","clone_url":"https://github.com/andela/gondor-cfh.git","svn_url":"https://github.com/andela/gondor-cfh","homepage":"https://cfhtdd.herokuapp.com/#!/","size":9888,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":2,"watchers":0,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/andela/gondor-cfh/pulls/10"},"html":{"href":"https://github.com/andela/gondor-cfh/pull/10"},"issue":{"href":"https://api.github.com/repos/andela/gondor-cfh/issues/10"},"comments":{"href":"https://api.github.com/repos/andela/gondor-cfh/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/andela/gondor-cfh/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/andela/gondor-cfh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/andela/gondor-cfh/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/andela/gondor-cfh/statuses/c7a9543a010f6e886fd208b096b952094f0731ff"}},"author_association":"COLLABORATOR"}} | {
"id": 137855156,
"name": "andela/gondor-cfh",
"url": "https://api.github.com/repos/andela/gondor-cfh"
} | {
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
} | {
"id": 4100206,
"login": "andela",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4100206?",
"url": "https://api.github.com/orgs/andela"
} | 2018-06-28T23:18:27 | 7894827612 | {"actor":{"display_login":"houndci-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/andela/ah-orcas-frontend/pulls/comments/243507029","pull_request_review_id":187295495,"id":243507029,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzUwNzAyOQ==","diff_hunk":"@@ -4,26 +4,35 @@ import 'bootstrap/dist/css/bootstrap.min.css';\n import 'bootstrap';\n import Swal from 'sweetalert2';\n import propTypes from 'prop-types';\n-\n+import ArticleCard from '../HomePage/containers';\n import { getProfileAction, userArticlesAction, updateUserProfileAction } from '../../actions/profile.action';\n \n class Profile extends Component {\n constructor(props) {\n super(props);\n this.state = {\n profile: {},\n- profileArticlesData: {},\n+ profileArticlesData: [],\n usernameUpdate: '',\n bioUpdate: '',\n+ usernameLocal: '',\n };\n \n this.handleEditClick = this.handleEditClick.bind(this);\n this.onSuccess = this.onSuccess.bind(this);\n \n+ try{\n+ this.setState({usernameLocal: JSON.parse(localStorage.getItem('user')).username});\n+ } catch(error) {\n+ \n+ }\n+","path":"src/components/ProfilePage/Profile.jsx","position":28,"original_position":28,"commit_id":"2d4d9385bc90d7a3727c7c2a94b0130aba06782a","original_commit_id":"2d4d9385bc90d7a3727c7c2a94b0130aba06782a","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"More than 2 blank lines not allowed no-multiple-empty-lines","created_at":"2018-12-21T07:35:44Z","updated_at":"2018-12-21T07:35:46Z","html_url":"https://github.com/andela/ah-orcas-frontend/pull/33#discussion_r243507029","pull_request_url":"https://api.github.com/repos/andela/ah-orcas-frontend/pulls/33","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/andela/ah-orcas-frontend/pulls/comments/243507029"},"html":{"href":"https://github.com/andela/ah-orcas-frontend/pull/33#discussion_r243507029"},"pull_request":{"href":"https://api.github.com/repos/andela/ah-orcas-frontend/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/andela/ah-orcas-frontend/pulls/33","id":240394298,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwMzk0Mjk4","html_url":"https://github.com/andela/ah-orcas-frontend/pull/33","diff_url":"https://github.com/andela/ah-orcas-frontend/pull/33.diff","patch_url":"https://github.com/andela/ah-orcas-frontend/pull/33.patch","issue_url":"https://api.github.com/repos/andela/ah-orcas-frontend/issues/33","number":33,"state":"open","locked":false,"title":"#162751889 redesign list articles ui","user":{"login":"abadojack","id":8406752,"node_id":"MDQ6VXNlcjg0MDY3NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/8406752?v=4","gravatar_id":"","url":"https://api.github.com/users/abadojack","html_url":"https://github.com/abadojack","followers_url":"https://api.github.com/users/abadojack/followers","following_url":"https://api.github.com/users/abadojack/following{/other_user}","gists_url":"https://api.github.com/users/abadojack/gists{/gist_id}","starred_url":"https://api.github.com/users/abadojack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abadojack/subscriptions","organizations_url":"https://api.github.com/users/abadojack/orgs","repos_url":"https://api.github.com/users/abadojack/repos","events_url":"https://api.github.com/users/abadojack/events{/privacy}","received_events_url":"https://api.github.com/users/abadojack/received_events","type":"User","site_admin":false},"body":"\r\n#### What does this PR do?\r\n```redesign view articles page ```\r\n#### Description of Task to be completed?\r\n```redesign article listing to make it look more pleasing ```\r\n#### How should this be manually tested?\r\n- git clone this repo\r\n```\r\n$ git clone https://github.com/andela/ah-orcas-frontend.git\r\n```\r\n- Navigate to this branch\r\n```\r\ngit checkout ft-redesign-list-articles-162751889\r\n```\r\n- Install the node modules\r\n```\r\n$ npm install\r\n```\r\n- Start the server\r\n```\r\n$ npm start\r\n```\r\n- It should open your browser and navigate to http://localhost:3000\r\n- Marvel at the awesomeness\r\n\r\n#### What are the relevant pivotal tracker stories?\r\n[#162751889](https://www.pivotaltracker.com/story/show/162751889)\r\n\r\n#### Screenshots (if appropriate)\r\n<img width=\"1440\" alt=\"screenshot 2018-12-21 at 10 33 58\" src=\"https://user-images.githubusercontent.com/8406752/50330365-fa157480-050b-11e9-9938-0fb2f730846a.png\">\r\n\r\n#### Checklist:\r\n\r\n- [X] My code follows the style guidelines of this project\r\n- [ ] At least 2 people have reviewed my PR\r\n- [X] I have commented my code, particularly in hard-to-understand areas\r\n- [X] I have made corresponding changes to the documentation\r\n- [ ] My changes generate no new warnings\r\n- [ ] I have added tests that prove my fix is effective or that my feature works\r\n- [X] New and existing unit tests pass locally with my changes\r\n- [X] My PR has one commit.","created_at":"2018-12-21T07:35:29Z","updated_at":"2018-12-21T07:35:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f203e146127a341b162d4d1dad9fa47d754048ae","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/andela/ah-orcas-frontend/pulls/33/commits","review_comments_url":"https://api.github.com/repos/andela/ah-orcas-frontend/pulls/33/comments","review_comment_url":"https://api.github.com/repos/andela/ah-orcas-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/andela/ah-orcas-frontend/issues/33/comments","statuses_url":"https://api.github.com/repos/andela/ah-orcas-frontend/statuses/2d4d9385bc90d7a3727c7c2a94b0130aba06782a","head":{"label":"andela:ft-redesign-list-articles-162751889","ref":"ft-redesign-list-articles-162751889","sha":"2d4d9385bc90d7a3727c7c2a94b0130aba06782a","user":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":153309690,"node_id":"MDEwOlJlcG9zaXRvcnkxNTMzMDk2OTA=","name":"ah-orcas-frontend","full_name":"andela/ah-orcas-frontend","private":false,"owner":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/andela/ah-orcas-frontend","description":null,"fork":false,"url":"https://api.github.com/repos/andela/ah-orcas-frontend","forks_url":"https://api.github.com/repos/andela/ah-orcas-frontend/forks","keys_url":"https://api.github.com/repos/andela/ah-orcas-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/ah-orcas-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/ah-orcas-frontend/teams","hooks_url":"https://api.github.com/repos/andela/ah-orcas-frontend/hooks","issue_events_url":"https://api.github.com/repos/andela/ah-orcas-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/andela/ah-orcas-frontend/events","assignees_url":"https://api.github.com/repos/andela/ah-orcas-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/andela/ah-orcas-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/andela/ah-orcas-frontend/tags","blobs_url":"https://api.github.com/repos/andela/ah-orcas-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/ah-orcas-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/ah-orcas-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/ah-orcas-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/ah-orcas-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/ah-orcas-frontend/languages","stargazers_url":"https://api.github.com/repos/andela/ah-orcas-frontend/stargazers","contributors_url":"https://api.github.com/repos/andela/ah-orcas-frontend/contributors","subscribers_url":"https://api.github.com/repos/andela/ah-orcas-frontend/subscribers","subscription_url":"https://api.github.com/repos/andela/ah-orcas-frontend/subscription","commits_url":"https://api.github.com/repos/andela/ah-orcas-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/ah-orcas-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/ah-orcas-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/ah-orcas-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/ah-orcas-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/andela/ah-orcas-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/ah-orcas-frontend/merges","archive_url":"https://api.github.com/repos/andela/ah-orcas-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/ah-orcas-frontend/downloads","issues_url":"https://api.github.com/repos/andela/ah-orcas-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/andela/ah-orcas-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/ah-orcas-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/ah-orcas-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/ah-orcas-frontend/labels{/name}","releases_url":"https://api.github.com/repos/andela/ah-orcas-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/andela/ah-orcas-frontend/deployments","created_at":"2018-10-16T15:31:07Z","updated_at":"2018-12-20T21:01:41Z","pushed_at":"2018-12-21T07:35:29Z","git_url":"git://github.com/andela/ah-orcas-frontend.git","ssh_url":"[email protected]:andela/ah-orcas-frontend.git","clone_url":"https://github.com/andela/ah-orcas-frontend.git","svn_url":"https://github.com/andela/ah-orcas-frontend","homepage":null,"size":884,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":1,"open_issues":3,"watchers":0,"default_branch":"develop"}},"base":{"label":"andela:develop","ref":"develop","sha":"c194048a0d212e88b0e1fcf5f3dbcd90c2d3ab7d","user":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":153309690,"node_id":"MDEwOlJlcG9zaXRvcnkxNTMzMDk2OTA=","name":"ah-orcas-frontend","full_name":"andela/ah-orcas-frontend","private":false,"owner":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/andela/ah-orcas-frontend","description":null,"fork":false,"url":"https://api.github.com/repos/andela/ah-orcas-frontend","forks_url":"https://api.github.com/repos/andela/ah-orcas-frontend/forks","keys_url":"https://api.github.com/repos/andela/ah-orcas-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/ah-orcas-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/ah-orcas-frontend/teams","hooks_url":"https://api.github.com/repos/andela/ah-orcas-frontend/hooks","issue_events_url":"https://api.github.com/repos/andela/ah-orcas-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/andela/ah-orcas-frontend/events","assignees_url":"https://api.github.com/repos/andela/ah-orcas-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/andela/ah-orcas-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/andela/ah-orcas-frontend/tags","blobs_url":"https://api.github.com/repos/andela/ah-orcas-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/ah-orcas-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/ah-orcas-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/ah-orcas-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/ah-orcas-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/ah-orcas-frontend/languages","stargazers_url":"https://api.github.com/repos/andela/ah-orcas-frontend/stargazers","contributors_url":"https://api.github.com/repos/andela/ah-orcas-frontend/contributors","subscribers_url":"https://api.github.com/repos/andela/ah-orcas-frontend/subscribers","subscription_url":"https://api.github.com/repos/andela/ah-orcas-frontend/subscription","commits_url":"https://api.github.com/repos/andela/ah-orcas-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/ah-orcas-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/ah-orcas-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/ah-orcas-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/ah-orcas-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/andela/ah-orcas-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/ah-orcas-frontend/merges","archive_url":"https://api.github.com/repos/andela/ah-orcas-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/ah-orcas-frontend/downloads","issues_url":"https://api.github.com/repos/andela/ah-orcas-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/andela/ah-orcas-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/ah-orcas-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/ah-orcas-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/ah-orcas-frontend/labels{/name}","releases_url":"https://api.github.com/repos/andela/ah-orcas-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/andela/ah-orcas-frontend/deployments","created_at":"2018-10-16T15:31:07Z","updated_at":"2018-12-20T21:01:41Z","pushed_at":"2018-12-21T07:35:29Z","git_url":"git://github.com/andela/ah-orcas-frontend.git","ssh_url":"[email protected]:andela/ah-orcas-frontend.git","clone_url":"https://github.com/andela/ah-orcas-frontend.git","svn_url":"https://github.com/andela/ah-orcas-frontend","homepage":null,"size":884,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":1,"open_issues":3,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/andela/ah-orcas-frontend/pulls/33"},"html":{"href":"https://github.com/andela/ah-orcas-frontend/pull/33"},"issue":{"href":"https://api.github.com/repos/andela/ah-orcas-frontend/issues/33"},"comments":{"href":"https://api.github.com/repos/andela/ah-orcas-frontend/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/andela/ah-orcas-frontend/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/andela/ah-orcas-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/andela/ah-orcas-frontend/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/andela/ah-orcas-frontend/statuses/2d4d9385bc90d7a3727c7c2a94b0130aba06782a"}},"author_association":"COLLABORATOR"}} | {
"id": 153309690,
"name": "andela/ah-orcas-frontend",
"url": "https://api.github.com/repos/andela/ah-orcas-frontend"
} | {
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
} | {
"id": 4100206,
"login": "andela",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4100206?",
"url": "https://api.github.com/orgs/andela"
} | 2018-12-21T07:35:44 | 8790087982 | {"actor":{"display_login":"houndci-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/pulls/comments/195672303","pull_request_review_id":129088374,"id":195672303,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTY3MjMwMw==","diff_hunk":"@@ -0,0 +1,28 @@\n+package com.ericsson.ei.frontend;\n+\n+import org.junit.*;\n+\n+import static org.junit.Assert.*;\n+import com.ericsson.ei.frontend.pageobjects.IndexPage;\n+import com.ericsson.ei.frontend.pageobjects.TestRulesPage;\n+\n+public class TemplateTestCase extends SeleniumBaseClass{\n+\n+ @Test\n+ public void testTemplateTestCase() throws Exception {\n+\n+ //Open indexpage and verify that it is opened\n+ IndexPage indexPageObject = new IndexPage(mockedHttpClient, driver, baseUrl);\n+ indexPageObject.loadPage();\n+ assertEquals(\"Eiffel Intelligence\", indexPageObject.getTitle());\n+\n+ //The line below contains selenium interaction with mocking\n+ String response = \"[{\\\"aggregationtype\\\":\\\"eiffel-intelligence\\\",\\\"created\\\":1524037895385,\\\"notificationMeta\\\":\\\"http://eiffel-jenkins1:8080/job/ei-artifact-triggered-job/build\\\",\\\"notificationType\\\":\\\"REST_POST\\\",\\\"restPostBodyMediaType\\\":\\\"application/x-www-form-urlencoded\\\",\\\"notificationMessageKeyValues\\\":[{\\\"formkey\\\":\\\"json\\\",\\\"formvalue\\\":\\\"{parameter: [{ name: 'jsonparams', value : to_string(@) }]}\\\"}],\\\"repeat\\\":false,\\\"requirements\\\":[{\\\"conditions\\\":[{\\\"jmespath\\\":\\\"gav.groupId=='com.othercompany.library'\\\"}]}],\\\"subscriptionName\\\":\\\"Subscription1\\\",\\\"_id\\\":{\\\"$oid\\\":\\\"5ad6f907c242af3f1469751d\\\"}},{\\\"aggregationtype\\\":\\\"eiffel-intelligence\\\",\\\"created\\\":1524037895415,\\\"notificationMeta\\\":\\\"http://eiffel-jenkins1:8080/job/ei-artifact-triggered-job/build\\\",\\\"notificationType\\\":\\\"REST_POST\\\",\\\"restPostBodyMediaType\\\":\\\"application/x-www-form-urlencoded\\\",\\\"notificationMessageKeyValues\\\":[{\\\"formkey\\\":\\\"json\\\",\\\"formvalue\\\":\\\"{parameter: [{ name: 'jsonparams', value : to_string(@) }]}\\\"}],\\\"repeat\\\":false,\\\"requirements\\\":[{\\\"conditions\\\":[{\\\"jmespath\\\":\\\"gav.groupId=='com.othercompany.library'\\\"}]}],\\\"subscriptionName\\\":\\\"Subscription2\\\",\\\"_id\\\":{\\\"$oid\\\":\\\"5ad6f907c242af3f1469751e\\\"}},{\\\"aggregationtype\\\":\\\"eiffel-intelligence\\\",\\\"created\\\":1524223397628,\\\"notificationMeta\\\":\\\"http://<MyHost:port>/api/doit\\\",\\\"notificationType\\\":\\\"REST_POST\\\",\\\"restPostBodyMediaType\\\":\\\"application/json\\\",\\\"notificationMessageKeyValues\\\":[{\\\"formkey\\\":\\\"\\\",\\\"formvalue\\\":\\\"{mydata: [{ fullaggregation : to_string(@) }]}\\\"}],\\\"repeat\\\":false,\\\"requirements\\\":[{\\\"conditions\\\":[{\\\"jmespath\\\":\\\"submission.sourceChanges[?submitter.group == 'Team Gophers' && svnIdentifier==null]\\\"}]}],\\\"subscriptionName\\\":\\\"Subscription_Template_Rest_Post_Raw_Body_Json_Trigger\\\",\\\"_id\\\":{\\\"$oid\\\":\\\"5ad9cda5b715d336247e4980\\\"}}]\";","path":"src/functionaltest/java/com/ericsson/ei/frontend/TemplateTestCase.java","position":20,"original_position":20,"commit_id":"7a8d9087db9d2affd3fb11e4e38a1221cd1de42f","original_commit_id":"7a8d9087db9d2affd3fb11e4e38a1221cd1de42f","user":{"login":"e-edling-ericsson","id":38752030,"node_id":"MDQ6VXNlcjM4NzUyMDMw","avatar_url":"https://avatars0.githubusercontent.com/u/38752030?v=4","gravatar_id":"","url":"https://api.github.com/users/e-edling-ericsson","html_url":"https://github.com/e-edling-ericsson","followers_url":"https://api.github.com/users/e-edling-ericsson/followers","following_url":"https://api.github.com/users/e-edling-ericsson/following{/other_user}","gists_url":"https://api.github.com/users/e-edling-ericsson/gists{/gist_id}","starred_url":"https://api.github.com/users/e-edling-ericsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/e-edling-ericsson/subscriptions","organizations_url":"https://api.github.com/users/e-edling-ericsson/orgs","repos_url":"https://api.github.com/users/e-edling-ericsson/repos","events_url":"https://api.github.com/users/e-edling-ericsson/events{/privacy}","received_events_url":"https://api.github.com/users/e-edling-ericsson/received_events","type":"User","site_admin":false},"body":"Absolutely, i guess its easier with these big responses. I´ll fix that!","created_at":"2018-06-15T08:59:19Z","updated_at":"2018-06-15T08:59:20Z","html_url":"https://github.com/Ericsson/eiffel-intelligence-frontend/pull/36#discussion_r195672303","pull_request_url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/pulls/36","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/pulls/comments/195672303"},"html":{"href":"https://github.com/Ericsson/eiffel-intelligence-frontend/pull/36#discussion_r195672303"},"pull_request":{"href":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/pulls/36"}},"in_reply_to_id":195665893},"pull_request":{"url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/pulls/36","id":193289446,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMjg5NDQ2","html_url":"https://github.com/Ericsson/eiffel-intelligence-frontend/pull/36","diff_url":"https://github.com/Ericsson/eiffel-intelligence-frontend/pull/36.diff","patch_url":"https://github.com/Ericsson/eiffel-intelligence-frontend/pull/36.patch","issue_url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/issues/36","number":36,"state":"open","locked":false,"title":"Create EI Frontend Test Framework","user":{"login":"eroohen","id":24456185,"node_id":"MDQ6VXNlcjI0NDU2MTg1","avatar_url":"https://avatars2.githubusercontent.com/u/24456185?v=4","gravatar_id":"","url":"https://api.github.com/users/eroohen","html_url":"https://github.com/eroohen","followers_url":"https://api.github.com/users/eroohen/followers","following_url":"https://api.github.com/users/eroohen/following{/other_user}","gists_url":"https://api.github.com/users/eroohen/gists{/gist_id}","starred_url":"https://api.github.com/users/eroohen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eroohen/subscriptions","organizations_url":"https://api.github.com/users/eroohen/orgs","repos_url":"https://api.github.com/users/eroohen/repos","events_url":"https://api.github.com/users/eroohen/events{/privacy}","received_events_url":"https://api.github.com/users/eroohen/received_events","type":"User","site_admin":false},"body":" * Create EI Frontend Test Framework with Selenium test framework (using Firefox driver).\r\n * This test framework will be used for EI Frontend Functional Tests.\r\n * Support for Travis-CI\r\n * Sample test case","created_at":"2018-06-07T11:29:37Z","updated_at":"2018-06-15T08:59:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"014b2b907984196a88e40c5b420f1080acfdf582","assignee":null,"assignees":[],"requested_reviewers":[{"login":"evasiba-ericsson","id":21218366,"node_id":"MDQ6VXNlcjIxMjE4MzY2","avatar_url":"https://avatars0.githubusercontent.com/u/21218366?v=4","gravatar_id":"","url":"https://api.github.com/users/evasiba-ericsson","html_url":"https://github.com/evasiba-ericsson","followers_url":"https://api.github.com/users/evasiba-ericsson/followers","following_url":"https://api.github.com/users/evasiba-ericsson/following{/other_user}","gists_url":"https://api.github.com/users/evasiba-ericsson/gists{/gist_id}","starred_url":"https://api.github.com/users/evasiba-ericsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evasiba-ericsson/subscriptions","organizations_url":"https://api.github.com/users/evasiba-ericsson/orgs","repos_url":"https://api.github.com/users/evasiba-ericsson/repos","events_url":"https://api.github.com/users/evasiba-ericsson/events{/privacy}","received_events_url":"https://api.github.com/users/evasiba-ericsson/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/pulls/36/commits","review_comments_url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/pulls/36/comments","review_comment_url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/issues/36/comments","statuses_url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/statuses/7a8d9087db9d2affd3fb11e4e38a1221cd1de42f","head":{"label":"eroohen:selenium","ref":"selenium","sha":"7a8d9087db9d2affd3fb11e4e38a1221cd1de42f","user":{"login":"eroohen","id":24456185,"node_id":"MDQ6VXNlcjI0NDU2MTg1","avatar_url":"https://avatars2.githubusercontent.com/u/24456185?v=4","gravatar_id":"","url":"https://api.github.com/users/eroohen","html_url":"https://github.com/eroohen","followers_url":"https://api.github.com/users/eroohen/followers","following_url":"https://api.github.com/users/eroohen/following{/other_user}","gists_url":"https://api.github.com/users/eroohen/gists{/gist_id}","starred_url":"https://api.github.com/users/eroohen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eroohen/subscriptions","organizations_url":"https://api.github.com/users/eroohen/orgs","repos_url":"https://api.github.com/users/eroohen/repos","events_url":"https://api.github.com/users/eroohen/events{/privacy}","received_events_url":"https://api.github.com/users/eroohen/received_events","type":"User","site_admin":false},"repo":{"id":135124873,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUxMjQ4NzM=","name":"eiffel-intelligence-frontend","full_name":"eroohen/eiffel-intelligence-frontend","owner":{"login":"eroohen","id":24456185,"node_id":"MDQ6VXNlcjI0NDU2MTg1","avatar_url":"https://avatars2.githubusercontent.com/u/24456185?v=4","gravatar_id":"","url":"https://api.github.com/users/eroohen","html_url":"https://github.com/eroohen","followers_url":"https://api.github.com/users/eroohen/followers","following_url":"https://api.github.com/users/eroohen/following{/other_user}","gists_url":"https://api.github.com/users/eroohen/gists{/gist_id}","starred_url":"https://api.github.com/users/eroohen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eroohen/subscriptions","organizations_url":"https://api.github.com/users/eroohen/orgs","repos_url":"https://api.github.com/users/eroohen/repos","events_url":"https://api.github.com/users/eroohen/events{/privacy}","received_events_url":"https://api.github.com/users/eroohen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eroohen/eiffel-intelligence-frontend","description":null,"fork":true,"url":"https://api.github.com/repos/eroohen/eiffel-intelligence-frontend","forks_url":"https://api.github.com/repos/eroohen/eiffel-intelligence-frontend/forks","keys_url":"https://api.github.com/repos/eroohen/eiffel-intelligence-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eroohen/eiffel-intelligence-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eroohen/eiffel-intelligence-frontend/teams","hooks_url":"https://api.github.com/repos/eroohen/eiffel-intelligence-frontend/hooks","issue_events_url":"https://api.github.com/repos/eroohen/eiffel-intelligence-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/eroohen/eiffel-intelligence-frontend/events","assignees_url":"https://api.github.com/repos/eroohen/eiffel-intelligence-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/eroohen/eiffel-intelligence-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/eroohen/eiffel-intelligence-frontend/tags","blobs_url":"https://api.github.com/repos/eroohen/eiffel-intelligence-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eroohen/eiffel-intelligence-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eroohen/eiffel-intelligence-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/eroohen/eiffel-intelligence-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eroohen/eiffel-intelligence-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/eroohen/eiffel-intelligence-frontend/languages","stargazers_url":"https://api.github.com/repos/eroohen/eiffel-intelligence-frontend/stargazers","contributors_url":"https://api.github.com/repos/eroohen/eiffel-intelligence-frontend/contributors","subscribers_url":"https://api.github.com/repos/eroohen/eiffel-intelligence-frontend/subscribers","subscription_url":"https://api.github.com/repos/eroohen/eiffel-intelligence-frontend/subscription","commits_url":"https://api.github.com/repos/eroohen/eiffel-intelligence-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/eroohen/eiffel-intelligence-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/eroohen/eiffel-intelligence-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/eroohen/eiffel-intelligence-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/eroohen/eiffel-intelligence-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/eroohen/eiffel-intelligence-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eroohen/eiffel-intelligence-frontend/merges","archive_url":"https://api.github.com/repos/eroohen/eiffel-intelligence-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eroohen/eiffel-intelligence-frontend/downloads","issues_url":"https://api.github.com/repos/eroohen/eiffel-intelligence-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/eroohen/eiffel-intelligence-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/eroohen/eiffel-intelligence-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/eroohen/eiffel-intelligence-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eroohen/eiffel-intelligence-frontend/labels{/name}","releases_url":"https://api.github.com/repos/eroohen/eiffel-intelligence-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/eroohen/eiffel-intelligence-frontend/deployments","created_at":"2018-05-28T07:24:57Z","updated_at":"2018-06-04T13:01:47Z","pushed_at":"2018-06-14T13:36:07Z","git_url":"git://github.com/eroohen/eiffel-intelligence-frontend.git","ssh_url":"[email protected]:eroohen/eiffel-intelligence-frontend.git","clone_url":"https://github.com/eroohen/eiffel-intelligence-frontend.git","svn_url":"https://github.com/eroohen/eiffel-intelligence-frontend","homepage":null,"size":8449,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Ericsson:master","ref":"master","sha":"d29d2f17d3e763729b84c070b57d866e339ea32d","user":{"login":"Ericsson","id":4161311,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxNjEzMTE=","avatar_url":"https://avatars3.githubusercontent.com/u/4161311?v=4","gravatar_id":"","url":"https://api.github.com/users/Ericsson","html_url":"https://github.com/Ericsson","followers_url":"https://api.github.com/users/Ericsson/followers","following_url":"https://api.github.com/users/Ericsson/following{/other_user}","gists_url":"https://api.github.com/users/Ericsson/gists{/gist_id}","starred_url":"https://api.github.com/users/Ericsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ericsson/subscriptions","organizations_url":"https://api.github.com/users/Ericsson/orgs","repos_url":"https://api.github.com/users/Ericsson/repos","events_url":"https://api.github.com/users/Ericsson/events{/privacy}","received_events_url":"https://api.github.com/users/Ericsson/received_events","type":"Organization","site_admin":false},"repo":{"id":108382337,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgzODIzMzc=","name":"eiffel-intelligence-frontend","full_name":"Ericsson/eiffel-intelligence-frontend","owner":{"login":"Ericsson","id":4161311,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxNjEzMTE=","avatar_url":"https://avatars3.githubusercontent.com/u/4161311?v=4","gravatar_id":"","url":"https://api.github.com/users/Ericsson","html_url":"https://github.com/Ericsson","followers_url":"https://api.github.com/users/Ericsson/followers","following_url":"https://api.github.com/users/Ericsson/following{/other_user}","gists_url":"https://api.github.com/users/Ericsson/gists{/gist_id}","starred_url":"https://api.github.com/users/Ericsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ericsson/subscriptions","organizations_url":"https://api.github.com/users/Ericsson/orgs","repos_url":"https://api.github.com/users/Ericsson/repos","events_url":"https://api.github.com/users/Ericsson/events{/privacy}","received_events_url":"https://api.github.com/users/Ericsson/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Ericsson/eiffel-intelligence-frontend","description":null,"fork":false,"url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend","forks_url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/forks","keys_url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/teams","hooks_url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/hooks","issue_events_url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/events","assignees_url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/tags","blobs_url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/languages","stargazers_url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/stargazers","contributors_url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/contributors","subscribers_url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/subscribers","subscription_url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/subscription","commits_url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/merges","archive_url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/downloads","issues_url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/labels{/name}","releases_url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/deployments","created_at":"2017-10-26T08:20:39Z","updated_at":"2018-06-14T11:02:53Z","pushed_at":"2018-06-14T14:17:37Z","git_url":"git://github.com/Ericsson/eiffel-intelligence-frontend.git","ssh_url":"[email protected]:Ericsson/eiffel-intelligence-frontend.git","clone_url":"https://github.com/Ericsson/eiffel-intelligence-frontend.git","svn_url":"https://github.com/Ericsson/eiffel-intelligence-frontend","homepage":null,"size":2782,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":11,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/pulls/36"},"html":{"href":"https://github.com/Ericsson/eiffel-intelligence-frontend/pull/36"},"issue":{"href":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/issues/36"},"comments":{"href":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend/statuses/7a8d9087db9d2affd3fb11e4e38a1221cd1de42f"}},"author_association":"NONE"}} | {
"id": 108382337,
"name": "Ericsson/eiffel-intelligence-frontend",
"url": "https://api.github.com/repos/Ericsson/eiffel-intelligence-frontend"
} | {
"id": 38752030,
"login": "e-edling-ericsson",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/38752030?",
"url": "https://api.github.com/users/e-edling-ericsson"
} | {
"id": 4161311,
"login": "Ericsson",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4161311?",
"url": "https://api.github.com/orgs/Ericsson"
} | 2018-06-15T08:59:19 | 7829732814 | {"actor":{"display_login":"e-edling-ericsson"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Ericsson/codechecker/pulls/comments/194334411","pull_request_review_id":127483955,"id":194334411,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDMzNDQxMQ==","diff_hunk":"@@ -0,0 +1,304 @@\n+import argparse\n+import json\n+import operator\n+import os\n+import re\n+import shutil\n+import stat\n+import subprocess\n+import sys\n+import tempfile\n+\n+\n+def check_files_existence(report_dir):\n+ '''\n+ This function checks the existence of some files which are required for the\n+ reduction process.\n+ '''\n+ def check(path, isfile):\n+ if not (os.path.isfile(path) if isfile else os.path.isdir(path)):\n+ print('Error: ' + path + \" doesn't exist.\")\n+ sys.exit(1)\n+\n+ check(report_dir, False)\n+ check(os.path.join(report_dir, 'metadata.json'), True)\n+ check(os.path.join(report_dir, 'compiler_includes.json'), True)\n+ check(os.path.join(report_dir, 'compiler_target.json'), True)\n+ check(os.path.join(report_dir, 'compile_cmd.json'), True)\n+\n+\n+def check_commands_existence():\n+ '''\n+ This function checks the existence of some commands which are required for\n+ the reduction process. A dictionary is returned where the key is the\n+ command name and the value is its absolute path.\n+ '''\n+ def get_path(cmd):\n+ proc = subprocess.Popen(['which', cmd], stdout=subprocess.PIPE)\n+ return proc.communicate()[0]\n+\n+ commands = ['CodeChecker', 'creduce', 'clang', 'clang-tidy']\n+\n+ result = dict()\n+\n+ for command in commands:\n+ path = get_path(command).strip()\n+\n+ if not path:\n+ print('Error: ' + command + ' command not found.')\n+ sys.exit(1)\n+\n+ result[command] = path\n+\n+ return result\n+\n+\n+def checker_categories():\n+ '''\n+ This function returns a set of main checker categories i.e. the first part\n+ of each checker name.\n+ '''\n+ checkers_proc = subprocess.Popen(['CodeChecker', 'checkers'],\n+ stdout=subprocess.PIPE)\n+\n+ checkers, _ = checkers_proc.communicate()\n+ return set(checker[:checker.replace('.', '-').find('-')]\n+ for checker in checkers.split())\n+\n+\n+def get_prepared_analyze_command(report_dir,\n+ workspace_dir,\n+ codechecker,\n+ specific_checker=None):\n+ '''\n+ This function returns a CodeChecker analyze command based on the original\n+ one which is stored in the metadata.json file in the report directory.\n+\n+ report_dir -- The report directory path which is used for the original\n+ analysis.\n+ workspace_dir -- The workspace directory which contains the new report\n+ directory which is used for reduction. The new report directory should\n+ be a temporary location because its content is rewritten between the\n+ reduction steps.\n+ codechecker -- Full path of CodeChecker.\n+ specific_checker -- For fastening reduction only this checker will be\n+ enabled and all others will be disabled\n+ '''\n+ def remove_flag(cmd, flag):\n+ try:\n+ idx = cmd.index(flag)\n+ del cmd[idx] # Remove the flag.\n+ del cmd[idx] # Remove its parameter.\n+ return True\n+ except ValueError:\n+ return False\n+\n+ # --- Get analyzer command from metadata.json --- #\n+\n+ metadata = os.path.join(report_dir, 'metadata.json')\n+ compiler_includes = os.path.join(report_dir, 'compiler_includes.json')\n+ compiler_targets = os.path.join(report_dir, 'compiler_target.json')\n+ compilation_database = os.path.join(workspace_dir, 'compile_cmd.json')\n+ output_dir = os.path.join(workspace_dir, 'reports')\n+\n+ with open(metadata) as f:\n+ metadata = json.load(f)\n+\n+ analyzer_cmd = metadata['command']\n+ analyzer_cmd[0] = codechecker\n+\n+ # --- Change compilation database --- #\n+\n+ parser = argparse.ArgumentParser()\n+ parser.add_argument('compilation_database')\n+\n+ # 2 is for skipping \"CodeChecker analyze\".\n+ known, _ = parser.parse_known_args(analyzer_cmd[2:])\n+\n+ analyzer_cmd.remove(known.compilation_database)\n+ analyzer_cmd.append(compilation_database)\n+\n+ # --- Change output dir to a temporary directory --- #\n+\n+ remove_flag(analyzer_cmd, '-o')\n+ remove_flag(analyzer_cmd, '--output')\n+\n+ analyzer_cmd.extend(['-o', output_dir])\n+\n+ # --- Change compiler includes and targets file --- #\n+\n+ remove_flag(analyzer_cmd, '--compiler-includes-file')\n+ remove_flag(analyzer_cmd, '--compiler-target-file')\n+\n+ analyzer_cmd.extend(['--compiler-includes-file', compiler_includes])\n+ analyzer_cmd.extend(['--compiler-target-file', compiler_targets])\n+\n+ # --- Always do a clean analysis --- #\n+\n+ analyzer_cmd.append('--clean')\n+\n+ # --- Disable all checkers but the required one if needed --- #\n+\n+ if specific_checker is not None:\n+ while remove_flag(analyzer_cmd, '-e'):\n+ pass\n+ while remove_flag(analyzer_cmd, '--enable'):\n+ pass\n+ while remove_flag(analyzer_cmd, '-d'):\n+ pass\n+ while remove_flag(analyzer_cmd, '--disable'):\n+ pass\n+\n+ for category in checker_categories():\n+ analyzer_cmd.extend(['-d', category])\n+\n+ analyzer_cmd.extend(['-e', specific_checker])\n+\n+ return analyzer_cmd\n+\n+\n+def get_build_command_for_file(compilation_database, filename):\n+ '''\n+ This function finds the first build action in the compilation database\n+ which compiles the given source file.\n+ '''\n+ with open(compilation_database) as f:\n+ build_actions = json.load(f)\n+\n+ collection = map(\n+ operator.itemgetter('command'),\n+ filter(lambda ba: ba['file'].endswith(filename), build_actions))\n+\n+ return None if len(collection) == 0 else collection[0]\n+\n+\n+def dump_preprocessed_build_action(build_command, output):\n+ '''\n+ This function dumps the preprocessed source code to the given output file.\n+ '''\n+\n+ if not isinstance(build_command, list):\n+ build_command = build_command.split()\n+\n+ build_command.append('-E')\n+\n+ try:\n+ build_command[build_command.index('-o') + 1] = output\n+ except ValueError:\n+ build_command.extend(['-o', output])\n+\n+ print(build_command)\n+ subprocess.Popen(build_command).communicate()\n+\n+\n+def write_creduce_test_file(analyze_cmd, report_dir, parse_content, output_file):\n+ '''\n+ This function assembles and writes the test file which describes the\n+ condition of recuding the source file with CReduce.\n+ '''\n+ content = '''\n+#!/usr/bin/env bash\n+{0}\n+sed -i 's/, \"working_directory\": \"[^\"]*\"//' {1}/metadata.json\n+CodeChecker parse --print-steps {1} | grep '{2}'\n+'''.format(analyze_cmd, report_dir, parse_content)\n+\n+ with open(output_file, 'w') as f:\n+ f.write(content)\n+\n+ os.chmod(output_file, stat.S_IXUSR | stat.S_IRUSR)\n+\n+\n+def get_prepared_build_action(workdir, build_action, reduce_file):\n+ source_file = os.path.join(workdir, reduce_file)\n+ return {\n+ 'directory': build_action['directory'],\n+ 'command': re.sub('[\\w\\/\\.]*' + reduce_file,\n+ source_file,\n+ build_action['command']),\n+ 'file': source_file}\n+\n+\n+# --- Command line arguments --- #\n+\n+parser = argparse.ArgumentParser(description='''\n+Reduce for a specific bug.\n+\n+Given the following arguments this script attempts to create a minimal example\n+which still produces a specific CodeChecker finding. Reduction steps are\n+accomplished as long as the bug is still observable based on the output of\n+CodeChecker parse command.''')\n+parser.add_argument('--report_dir', required=True, help='Report directory.')\n+parser.add_argument('--reduce_file', required=True, help='The file to reduce.')\n+parser.add_argument('--parse_content', required=True,\n+ help='Reduce the source as long as it still produces a '\n+ '\"CodeChecker parse\" command output which contains this '\n+ 'string.')\n+parser.add_argument('--specific_checker', required=False, default=None,\n+ help='Only this checker will be enabled during the '\n+ 'reduction.')\n+args = parser.parse_args()\n+\n+check_files_existence(args.report_dir)\n+commands = check_commands_existence()\n+\n+try:\n+ # --- Defining some necessary variables --- #\n+\n+ temp_workdir = tempfile.mkdtemp()\n+ old_report_dir = os.path.abspath(args.report_dir)\n+ new_report_dir = os.path.join(temp_workdir, 'reports')\n+ old_compilation_database = os.path.join(old_report_dir, 'compile_cmd.json')\n+ new_compilation_database = os.path.join(temp_workdir, 'compile_cmd.json')","path":"scripts/debug_tools/reduce.py","position":252,"original_position":252,"commit_id":"d4717cd16b00baf801669743800995fbc8d45f07","original_commit_id":"d4717cd16b00baf801669743800995fbc8d45f07","user":{"login":"codacy-bot","id":19940114,"node_id":"MDQ6VXNlcjE5OTQwMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":" Issue found: [Constant name \"new_compilation_database\" doesn't conform to '(([A-Z_][A-Z0-9_]*)|(__.*__))$' pattern](https://app.codacy.com/app/gyorb/codechecker/pullRequest?prid=1761804)","created_at":"2018-06-11T09:00:35Z","updated_at":"2018-06-11T09:00:35Z","html_url":"https://github.com/Ericsson/codechecker/pull/1639#discussion_r194334411","pull_request_url":"https://api.github.com/repos/Ericsson/codechecker/pulls/1639","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Ericsson/codechecker/pulls/comments/194334411"},"html":{"href":"https://github.com/Ericsson/codechecker/pull/1639#discussion_r194334411"},"pull_request":{"href":"https://api.github.com/repos/Ericsson/codechecker/pulls/1639"}}},"pull_request":{"url":"https://api.github.com/repos/Ericsson/codechecker/pulls/1639","id":193910396,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzOTEwMzk2","html_url":"https://github.com/Ericsson/codechecker/pull/1639","diff_url":"https://github.com/Ericsson/codechecker/pull/1639.diff","patch_url":"https://github.com/Ericsson/codechecker/pull/1639.patch","issue_url":"https://api.github.com/repos/Ericsson/codechecker/issues/1639","number":1639,"state":"open","locked":false,"title":"Reducer script for non-ctu findings.","user":{"login":"bruntib","id":12861163,"node_id":"MDQ6VXNlcjEyODYxMTYz","avatar_url":"https://avatars3.githubusercontent.com/u/12861163?v=4","gravatar_id":"","url":"https://api.github.com/users/bruntib","html_url":"https://github.com/bruntib","followers_url":"https://api.github.com/users/bruntib/followers","following_url":"https://api.github.com/users/bruntib/following{/other_user}","gists_url":"https://api.github.com/users/bruntib/gists{/gist_id}","starred_url":"https://api.github.com/users/bruntib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bruntib/subscriptions","organizations_url":"https://api.github.com/users/bruntib/orgs","repos_url":"https://api.github.com/users/bruntib/repos","events_url":"https://api.github.com/users/bruntib/events{/privacy}","received_events_url":"https://api.github.com/users/bruntib/received_events","type":"User","site_admin":false},"body":"This script attempts to reduce a source code which still produces the\r\ngiven CodeChecker finding. The documentation can be found on the --help\r\npage of the script.","created_at":"2018-06-11T08:41:51Z","updated_at":"2018-06-11T09:00:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0377b13e5234d50757fd5418b980f6495ecdb60","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Ericsson/codechecker/pulls/1639/commits","review_comments_url":"https://api.github.com/repos/Ericsson/codechecker/pulls/1639/comments","review_comment_url":"https://api.github.com/repos/Ericsson/codechecker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Ericsson/codechecker/issues/1639/comments","statuses_url":"https://api.github.com/repos/Ericsson/codechecker/statuses/d4717cd16b00baf801669743800995fbc8d45f07","head":{"label":"bruntib:reducer_non_ctu","ref":"reducer_non_ctu","sha":"d4717cd16b00baf801669743800995fbc8d45f07","user":{"login":"bruntib","id":12861163,"node_id":"MDQ6VXNlcjEyODYxMTYz","avatar_url":"https://avatars3.githubusercontent.com/u/12861163?v=4","gravatar_id":"","url":"https://api.github.com/users/bruntib","html_url":"https://github.com/bruntib","followers_url":"https://api.github.com/users/bruntib/followers","following_url":"https://api.github.com/users/bruntib/following{/other_user}","gists_url":"https://api.github.com/users/bruntib/gists{/gist_id}","starred_url":"https://api.github.com/users/bruntib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bruntib/subscriptions","organizations_url":"https://api.github.com/users/bruntib/orgs","repos_url":"https://api.github.com/users/bruntib/repos","events_url":"https://api.github.com/users/bruntib/events{/privacy}","received_events_url":"https://api.github.com/users/bruntib/received_events","type":"User","site_admin":false},"repo":{"id":49504445,"node_id":"MDEwOlJlcG9zaXRvcnk0OTUwNDQ0NQ==","name":"codechecker","full_name":"bruntib/codechecker","owner":{"login":"bruntib","id":12861163,"node_id":"MDQ6VXNlcjEyODYxMTYz","avatar_url":"https://avatars3.githubusercontent.com/u/12861163?v=4","gravatar_id":"","url":"https://api.github.com/users/bruntib","html_url":"https://github.com/bruntib","followers_url":"https://api.github.com/users/bruntib/followers","following_url":"https://api.github.com/users/bruntib/following{/other_user}","gists_url":"https://api.github.com/users/bruntib/gists{/gist_id}","starred_url":"https://api.github.com/users/bruntib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bruntib/subscriptions","organizations_url":"https://api.github.com/users/bruntib/orgs","repos_url":"https://api.github.com/users/bruntib/repos","events_url":"https://api.github.com/users/bruntib/events{/privacy}","received_events_url":"https://api.github.com/users/bruntib/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bruntib/codechecker","description":"CodeChecker is a defect database and viewer extension for Clang Static Analyzer","fork":true,"url":"https://api.github.com/repos/bruntib/codechecker","forks_url":"https://api.github.com/repos/bruntib/codechecker/forks","keys_url":"https://api.github.com/repos/bruntib/codechecker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bruntib/codechecker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bruntib/codechecker/teams","hooks_url":"https://api.github.com/repos/bruntib/codechecker/hooks","issue_events_url":"https://api.github.com/repos/bruntib/codechecker/issues/events{/number}","events_url":"https://api.github.com/repos/bruntib/codechecker/events","assignees_url":"https://api.github.com/repos/bruntib/codechecker/assignees{/user}","branches_url":"https://api.github.com/repos/bruntib/codechecker/branches{/branch}","tags_url":"https://api.github.com/repos/bruntib/codechecker/tags","blobs_url":"https://api.github.com/repos/bruntib/codechecker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bruntib/codechecker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bruntib/codechecker/git/refs{/sha}","trees_url":"https://api.github.com/repos/bruntib/codechecker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bruntib/codechecker/statuses/{sha}","languages_url":"https://api.github.com/repos/bruntib/codechecker/languages","stargazers_url":"https://api.github.com/repos/bruntib/codechecker/stargazers","contributors_url":"https://api.github.com/repos/bruntib/codechecker/contributors","subscribers_url":"https://api.github.com/repos/bruntib/codechecker/subscribers","subscription_url":"https://api.github.com/repos/bruntib/codechecker/subscription","commits_url":"https://api.github.com/repos/bruntib/codechecker/commits{/sha}","git_commits_url":"https://api.github.com/repos/bruntib/codechecker/git/commits{/sha}","comments_url":"https://api.github.com/repos/bruntib/codechecker/comments{/number}","issue_comment_url":"https://api.github.com/repos/bruntib/codechecker/issues/comments{/number}","contents_url":"https://api.github.com/repos/bruntib/codechecker/contents/{+path}","compare_url":"https://api.github.com/repos/bruntib/codechecker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bruntib/codechecker/merges","archive_url":"https://api.github.com/repos/bruntib/codechecker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bruntib/codechecker/downloads","issues_url":"https://api.github.com/repos/bruntib/codechecker/issues{/number}","pulls_url":"https://api.github.com/repos/bruntib/codechecker/pulls{/number}","milestones_url":"https://api.github.com/repos/bruntib/codechecker/milestones{/number}","notifications_url":"https://api.github.com/repos/bruntib/codechecker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bruntib/codechecker/labels{/name}","releases_url":"https://api.github.com/repos/bruntib/codechecker/releases{/id}","deployments_url":"https://api.github.com/repos/bruntib/codechecker/deployments","created_at":"2016-01-12T14:16:36Z","updated_at":"2018-03-16T20:15:17Z","pushed_at":"2018-06-11T08:41:01Z","git_url":"git://github.com/bruntib/codechecker.git","ssh_url":"[email protected]:bruntib/codechecker.git","clone_url":"https://github.com/bruntib/codechecker.git","svn_url":"https://github.com/bruntib/codechecker","homepage":null,"size":9514,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Ericsson:master","ref":"master","sha":"7a28027bf19ad2348eba25455522f3021cd017ff","user":{"login":"Ericsson","id":4161311,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxNjEzMTE=","avatar_url":"https://avatars3.githubusercontent.com/u/4161311?v=4","gravatar_id":"","url":"https://api.github.com/users/Ericsson","html_url":"https://github.com/Ericsson","followers_url":"https://api.github.com/users/Ericsson/followers","following_url":"https://api.github.com/users/Ericsson/following{/other_user}","gists_url":"https://api.github.com/users/Ericsson/gists{/gist_id}","starred_url":"https://api.github.com/users/Ericsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ericsson/subscriptions","organizations_url":"https://api.github.com/users/Ericsson/orgs","repos_url":"https://api.github.com/users/Ericsson/repos","events_url":"https://api.github.com/users/Ericsson/events{/privacy}","received_events_url":"https://api.github.com/users/Ericsson/received_events","type":"Organization","site_admin":false},"repo":{"id":37459110,"node_id":"MDEwOlJlcG9zaXRvcnkzNzQ1OTExMA==","name":"codechecker","full_name":"Ericsson/codechecker","owner":{"login":"Ericsson","id":4161311,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxNjEzMTE=","avatar_url":"https://avatars3.githubusercontent.com/u/4161311?v=4","gravatar_id":"","url":"https://api.github.com/users/Ericsson","html_url":"https://github.com/Ericsson","followers_url":"https://api.github.com/users/Ericsson/followers","following_url":"https://api.github.com/users/Ericsson/following{/other_user}","gists_url":"https://api.github.com/users/Ericsson/gists{/gist_id}","starred_url":"https://api.github.com/users/Ericsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ericsson/subscriptions","organizations_url":"https://api.github.com/users/Ericsson/orgs","repos_url":"https://api.github.com/users/Ericsson/repos","events_url":"https://api.github.com/users/Ericsson/events{/privacy}","received_events_url":"https://api.github.com/users/Ericsson/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Ericsson/codechecker","description":"CodeChecker is an analyzer tooling, defect database and viewer extension for the Clang Static Analyzer and Clang Tidy","fork":false,"url":"https://api.github.com/repos/Ericsson/codechecker","forks_url":"https://api.github.com/repos/Ericsson/codechecker/forks","keys_url":"https://api.github.com/repos/Ericsson/codechecker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ericsson/codechecker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ericsson/codechecker/teams","hooks_url":"https://api.github.com/repos/Ericsson/codechecker/hooks","issue_events_url":"https://api.github.com/repos/Ericsson/codechecker/issues/events{/number}","events_url":"https://api.github.com/repos/Ericsson/codechecker/events","assignees_url":"https://api.github.com/repos/Ericsson/codechecker/assignees{/user}","branches_url":"https://api.github.com/repos/Ericsson/codechecker/branches{/branch}","tags_url":"https://api.github.com/repos/Ericsson/codechecker/tags","blobs_url":"https://api.github.com/repos/Ericsson/codechecker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ericsson/codechecker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ericsson/codechecker/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ericsson/codechecker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ericsson/codechecker/statuses/{sha}","languages_url":"https://api.github.com/repos/Ericsson/codechecker/languages","stargazers_url":"https://api.github.com/repos/Ericsson/codechecker/stargazers","contributors_url":"https://api.github.com/repos/Ericsson/codechecker/contributors","subscribers_url":"https://api.github.com/repos/Ericsson/codechecker/subscribers","subscription_url":"https://api.github.com/repos/Ericsson/codechecker/subscription","commits_url":"https://api.github.com/repos/Ericsson/codechecker/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ericsson/codechecker/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ericsson/codechecker/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ericsson/codechecker/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ericsson/codechecker/contents/{+path}","compare_url":"https://api.github.com/repos/Ericsson/codechecker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ericsson/codechecker/merges","archive_url":"https://api.github.com/repos/Ericsson/codechecker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ericsson/codechecker/downloads","issues_url":"https://api.github.com/repos/Ericsson/codechecker/issues{/number}","pulls_url":"https://api.github.com/repos/Ericsson/codechecker/pulls{/number}","milestones_url":"https://api.github.com/repos/Ericsson/codechecker/milestones{/number}","notifications_url":"https://api.github.com/repos/Ericsson/codechecker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ericsson/codechecker/labels{/name}","releases_url":"https://api.github.com/repos/Ericsson/codechecker/releases{/id}","deployments_url":"https://api.github.com/repos/Ericsson/codechecker/deployments","created_at":"2015-06-15T10:38:51Z","updated_at":"2018-06-11T07:53:14Z","pushed_at":"2018-06-11T08:41:51Z","git_url":"git://github.com/Ericsson/codechecker.git","ssh_url":"[email protected]:Ericsson/codechecker.git","clone_url":"https://github.com/Ericsson/codechecker.git","svn_url":"https://github.com/Ericsson/codechecker","homepage":"","size":13933,"stargazers_count":449,"watchers_count":449,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"archived":false,"open_issues_count":143,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":51,"open_issues":143,"watchers":449,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Ericsson/codechecker/pulls/1639"},"html":{"href":"https://github.com/Ericsson/codechecker/pull/1639"},"issue":{"href":"https://api.github.com/repos/Ericsson/codechecker/issues/1639"},"comments":{"href":"https://api.github.com/repos/Ericsson/codechecker/issues/1639/comments"},"review_comments":{"href":"https://api.github.com/repos/Ericsson/codechecker/pulls/1639/comments"},"review_comment":{"href":"https://api.github.com/repos/Ericsson/codechecker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Ericsson/codechecker/pulls/1639/commits"},"statuses":{"href":"https://api.github.com/repos/Ericsson/codechecker/statuses/d4717cd16b00baf801669743800995fbc8d45f07"}},"author_association":"CONTRIBUTOR"}} | {
"id": 37459110,
"name": "Ericsson/codechecker",
"url": "https://api.github.com/repos/Ericsson/codechecker"
} | {
"id": 19940114,
"login": "codacy-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19940114?",
"url": "https://api.github.com/users/codacy-bot"
} | {
"id": 4161311,
"login": "Ericsson",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4161311?",
"url": "https://api.github.com/orgs/Ericsson"
} | 2018-06-11T09:00:35 | 7804879408 | {"actor":{"display_login":"codacy-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/DevExpress/devextreme-reactive/pulls/comments/169045629","pull_request_review_id":97507946,"id":169045629,"diff_hunk":"@@ -50,27 +58,34 @@ const filterHierarchicalRows = (rows, predicate, getRowLevelKey, isGroupRow) =>\n \n export const filteredRows = (\n rows,\n- filters,\n+ filterExpr,\n getCellValue,\n getColumnPredicate,\n isGroupRow,\n getRowLevelKey,\n ) => {\n- if (!filters.length || !rows.length) return rows;\n-\n- const predicate = filters.reduce(\n- (prevPredicate, filter) => {\n- const { columnName, ...filterConfig } = filter;\n- const customPredicate = getColumnPredicate && getColumnPredicate(columnName);\n- const columnPredicate = customPredicate || defaultPredicate;\n-\n- return (row) => {\n- const result = columnPredicate(getCellValue(row, columnName), filterConfig, row);\n- return result && prevPredicate(row);\n- };\n- },\n- () => true,\n- );\n+ if (!filterExpr || !Object.keys(filterExpr).length || !rows.length) return rows;\n+\n+ const getPredicateFromFilter = (filter) => {\n+ const { columnName, ...filterConfig } = filter;\n+ const customPredicate = getColumnPredicate && getColumnPredicate(columnName);\n+ const columnPredicate = customPredicate || defaultPredicate;\n+\n+ return row => columnPredicate(getCellValue(row, columnName), filterConfig, row);\n+ };\n+\n+ const predicateGenerator = (filterExpression) => {","path":"packages/dx-grid-core/src/plugins/integrated-filtering/computeds.js","position":50,"original_position":50,"commit_id":"67b41fa23d476f9ff1c1440228dbdfe539f202f6","original_commit_id":"67b41fa23d476f9ff1c1440228dbdfe539f202f6","user":{"login":"gsobolev","id":4580098,"avatar_url":"https://avatars0.githubusercontent.com/u/4580098?v=4","gravatar_id":"","url":"https://api.github.com/users/gsobolev","html_url":"https://github.com/gsobolev","followers_url":"https://api.github.com/users/gsobolev/followers","following_url":"https://api.github.com/users/gsobolev/following{/other_user}","gists_url":"https://api.github.com/users/gsobolev/gists{/gist_id}","starred_url":"https://api.github.com/users/gsobolev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsobolev/subscriptions","organizations_url":"https://api.github.com/users/gsobolev/orgs","repos_url":"https://api.github.com/users/gsobolev/repos","events_url":"https://api.github.com/users/gsobolev/events{/privacy}","received_events_url":"https://api.github.com/users/gsobolev/received_events","type":"User","site_admin":false},"body":"Maybe call this function `getPredicateFromExpression` to keep names consistent? This could also make it more transparent what this thing does.","created_at":"2018-02-19T11:10:26Z","updated_at":"2018-02-19T11:10:26Z","html_url":"https://github.com/DevExpress/devextreme-reactive/pull/726#discussion_r169045629","pull_request_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/pulls/726","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DevExpress/devextreme-reactive/pulls/comments/169045629"},"html":{"href":"https://github.com/DevExpress/devextreme-reactive/pull/726#discussion_r169045629"},"pull_request":{"href":"https://api.github.com/repos/DevExpress/devextreme-reactive/pulls/726"}}},"pull_request":{"url":"https://api.github.com/repos/DevExpress/devextreme-reactive/pulls/726","id":167136161,"html_url":"https://github.com/DevExpress/devextreme-reactive/pull/726","diff_url":"https://github.com/DevExpress/devextreme-reactive/pull/726.diff","patch_url":"https://github.com/DevExpress/devextreme-reactive/pull/726.patch","issue_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/issues/726","number":726,"state":"open","locked":false,"title":"feat(react-grid): add search panel plugin","user":{"login":"alexey-semikozov","id":7069422,"avatar_url":"https://avatars1.githubusercontent.com/u/7069422?v=4","gravatar_id":"","url":"https://api.github.com/users/alexey-semikozov","html_url":"https://github.com/alexey-semikozov","followers_url":"https://api.github.com/users/alexey-semikozov/followers","following_url":"https://api.github.com/users/alexey-semikozov/following{/other_user}","gists_url":"https://api.github.com/users/alexey-semikozov/gists{/gist_id}","starred_url":"https://api.github.com/users/alexey-semikozov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexey-semikozov/subscriptions","organizations_url":"https://api.github.com/users/alexey-semikozov/orgs","repos_url":"https://api.github.com/users/alexey-semikozov/repos","events_url":"https://api.github.com/users/alexey-semikozov/events{/privacy}","received_events_url":"https://api.github.com/users/alexey-semikozov/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-05T12:52:07Z","updated_at":"2018-02-19T11:10:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d28dc9bb6fc9f31bee164456d551b3ae57e35e4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/pulls/726/commits","review_comments_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/pulls/726/comments","review_comment_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/issues/726/comments","statuses_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/statuses/67b41fa23d476f9ff1c1440228dbdfe539f202f6","head":{"label":"alexey-semikozov:search-box","ref":"search-box","sha":"67b41fa23d476f9ff1c1440228dbdfe539f202f6","user":{"login":"alexey-semikozov","id":7069422,"avatar_url":"https://avatars1.githubusercontent.com/u/7069422?v=4","gravatar_id":"","url":"https://api.github.com/users/alexey-semikozov","html_url":"https://github.com/alexey-semikozov","followers_url":"https://api.github.com/users/alexey-semikozov/followers","following_url":"https://api.github.com/users/alexey-semikozov/following{/other_user}","gists_url":"https://api.github.com/users/alexey-semikozov/gists{/gist_id}","starred_url":"https://api.github.com/users/alexey-semikozov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexey-semikozov/subscriptions","organizations_url":"https://api.github.com/users/alexey-semikozov/orgs","repos_url":"https://api.github.com/users/alexey-semikozov/repos","events_url":"https://api.github.com/users/alexey-semikozov/events{/privacy}","received_events_url":"https://api.github.com/users/alexey-semikozov/received_events","type":"User","site_admin":false},"repo":{"id":119976509,"name":"devextreme-reactive","full_name":"alexey-semikozov/devextreme-reactive","owner":{"login":"alexey-semikozov","id":7069422,"avatar_url":"https://avatars1.githubusercontent.com/u/7069422?v=4","gravatar_id":"","url":"https://api.github.com/users/alexey-semikozov","html_url":"https://github.com/alexey-semikozov","followers_url":"https://api.github.com/users/alexey-semikozov/followers","following_url":"https://api.github.com/users/alexey-semikozov/following{/other_user}","gists_url":"https://api.github.com/users/alexey-semikozov/gists{/gist_id}","starred_url":"https://api.github.com/users/alexey-semikozov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexey-semikozov/subscriptions","organizations_url":"https://api.github.com/users/alexey-semikozov/orgs","repos_url":"https://api.github.com/users/alexey-semikozov/repos","events_url":"https://api.github.com/users/alexey-semikozov/events{/privacy}","received_events_url":"https://api.github.com/users/alexey-semikozov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexey-semikozov/devextreme-reactive","description":"DevExtreme Reactive Components","fork":true,"url":"https://api.github.com/repos/alexey-semikozov/devextreme-reactive","forks_url":"https://api.github.com/repos/alexey-semikozov/devextreme-reactive/forks","keys_url":"https://api.github.com/repos/alexey-semikozov/devextreme-reactive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexey-semikozov/devextreme-reactive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexey-semikozov/devextreme-reactive/teams","hooks_url":"https://api.github.com/repos/alexey-semikozov/devextreme-reactive/hooks","issue_events_url":"https://api.github.com/repos/alexey-semikozov/devextreme-reactive/issues/events{/number}","events_url":"https://api.github.com/repos/alexey-semikozov/devextreme-reactive/events","assignees_url":"https://api.github.com/repos/alexey-semikozov/devextreme-reactive/assignees{/user}","branches_url":"https://api.github.com/repos/alexey-semikozov/devextreme-reactive/branches{/branch}","tags_url":"https://api.github.com/repos/alexey-semikozov/devextreme-reactive/tags","blobs_url":"https://api.github.com/repos/alexey-semikozov/devextreme-reactive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexey-semikozov/devextreme-reactive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexey-semikozov/devextreme-reactive/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexey-semikozov/devextreme-reactive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexey-semikozov/devextreme-reactive/statuses/{sha}","languages_url":"https://api.github.com/repos/alexey-semikozov/devextreme-reactive/languages","stargazers_url":"https://api.github.com/repos/alexey-semikozov/devextreme-reactive/stargazers","contributors_url":"https://api.github.com/repos/alexey-semikozov/devextreme-reactive/contributors","subscribers_url":"https://api.github.com/repos/alexey-semikozov/devextreme-reactive/subscribers","subscription_url":"https://api.github.com/repos/alexey-semikozov/devextreme-reactive/subscription","commits_url":"https://api.github.com/repos/alexey-semikozov/devextreme-reactive/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexey-semikozov/devextreme-reactive/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexey-semikozov/devextreme-reactive/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexey-semikozov/devextreme-reactive/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexey-semikozov/devextreme-reactive/contents/{+path}","compare_url":"https://api.github.com/repos/alexey-semikozov/devextreme-reactive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexey-semikozov/devextreme-reactive/merges","archive_url":"https://api.github.com/repos/alexey-semikozov/devextreme-reactive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexey-semikozov/devextreme-reactive/downloads","issues_url":"https://api.github.com/repos/alexey-semikozov/devextreme-reactive/issues{/number}","pulls_url":"https://api.github.com/repos/alexey-semikozov/devextreme-reactive/pulls{/number}","milestones_url":"https://api.github.com/repos/alexey-semikozov/devextreme-reactive/milestones{/number}","notifications_url":"https://api.github.com/repos/alexey-semikozov/devextreme-reactive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexey-semikozov/devextreme-reactive/labels{/name}","releases_url":"https://api.github.com/repos/alexey-semikozov/devextreme-reactive/releases{/id}","deployments_url":"https://api.github.com/repos/alexey-semikozov/devextreme-reactive/deployments","created_at":"2018-02-02T12:00:11Z","updated_at":"2018-02-02T12:00:14Z","pushed_at":"2018-02-14T13:28:00Z","git_url":"git://github.com/alexey-semikozov/devextreme-reactive.git","ssh_url":"[email protected]:alexey-semikozov/devextreme-reactive.git","clone_url":"https://github.com/alexey-semikozov/devextreme-reactive.git","svn_url":"https://github.com/alexey-semikozov/devextreme-reactive","homepage":"https://devexpress.github.io/devextreme-reactive/","size":17900,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DevExpress:master","ref":"master","sha":"5b8de2db75f0befbbb779adb911bd0bac5899dfc","user":{"login":"DevExpress","id":4243232,"avatar_url":"https://avatars0.githubusercontent.com/u/4243232?v=4","gravatar_id":"","url":"https://api.github.com/users/DevExpress","html_url":"https://github.com/DevExpress","followers_url":"https://api.github.com/users/DevExpress/followers","following_url":"https://api.github.com/users/DevExpress/following{/other_user}","gists_url":"https://api.github.com/users/DevExpress/gists{/gist_id}","starred_url":"https://api.github.com/users/DevExpress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevExpress/subscriptions","organizations_url":"https://api.github.com/users/DevExpress/orgs","repos_url":"https://api.github.com/users/DevExpress/repos","events_url":"https://api.github.com/users/DevExpress/events{/privacy}","received_events_url":"https://api.github.com/users/DevExpress/received_events","type":"Organization","site_admin":false},"repo":{"id":85281744,"name":"devextreme-reactive","full_name":"DevExpress/devextreme-reactive","owner":{"login":"DevExpress","id":4243232,"avatar_url":"https://avatars0.githubusercontent.com/u/4243232?v=4","gravatar_id":"","url":"https://api.github.com/users/DevExpress","html_url":"https://github.com/DevExpress","followers_url":"https://api.github.com/users/DevExpress/followers","following_url":"https://api.github.com/users/DevExpress/following{/other_user}","gists_url":"https://api.github.com/users/DevExpress/gists{/gist_id}","starred_url":"https://api.github.com/users/DevExpress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevExpress/subscriptions","organizations_url":"https://api.github.com/users/DevExpress/orgs","repos_url":"https://api.github.com/users/DevExpress/repos","events_url":"https://api.github.com/users/DevExpress/events{/privacy}","received_events_url":"https://api.github.com/users/DevExpress/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DevExpress/devextreme-reactive","description":"DevExtreme Reactive Components","fork":false,"url":"https://api.github.com/repos/DevExpress/devextreme-reactive","forks_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/forks","keys_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/teams","hooks_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/hooks","issue_events_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/issues/events{/number}","events_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/events","assignees_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/assignees{/user}","branches_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/branches{/branch}","tags_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/tags","blobs_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/git/refs{/sha}","trees_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/statuses/{sha}","languages_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/languages","stargazers_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/stargazers","contributors_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/contributors","subscribers_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/subscribers","subscription_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/subscription","commits_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/commits{/sha}","git_commits_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/git/commits{/sha}","comments_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/comments{/number}","issue_comment_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/issues/comments{/number}","contents_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/contents/{+path}","compare_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/merges","archive_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/downloads","issues_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/issues{/number}","pulls_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/pulls{/number}","milestones_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/milestones{/number}","notifications_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/labels{/name}","releases_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/releases{/id}","deployments_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/deployments","created_at":"2017-03-17T07:10:12Z","updated_at":"2018-02-19T08:40:15Z","pushed_at":"2018-02-19T10:44:01Z","git_url":"git://github.com/DevExpress/devextreme-reactive.git","ssh_url":"[email protected]:DevExpress/devextreme-reactive.git","clone_url":"https://github.com/DevExpress/devextreme-reactive.git","svn_url":"https://github.com/DevExpress/devextreme-reactive","homepage":"https://devexpress.github.io/devextreme-reactive/","size":18419,"stargazers_count":371,"watchers_count":371,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":49,"mirror_url":null,"archived":false,"open_issues_count":52,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":49,"open_issues":52,"watchers":371,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DevExpress/devextreme-reactive/pulls/726"},"html":{"href":"https://github.com/DevExpress/devextreme-reactive/pull/726"},"issue":{"href":"https://api.github.com/repos/DevExpress/devextreme-reactive/issues/726"},"comments":{"href":"https://api.github.com/repos/DevExpress/devextreme-reactive/issues/726/comments"},"review_comments":{"href":"https://api.github.com/repos/DevExpress/devextreme-reactive/pulls/726/comments"},"review_comment":{"href":"https://api.github.com/repos/DevExpress/devextreme-reactive/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DevExpress/devextreme-reactive/pulls/726/commits"},"statuses":{"href":"https://api.github.com/repos/DevExpress/devextreme-reactive/statuses/67b41fa23d476f9ff1c1440228dbdfe539f202f6"}},"author_association":"NONE"}} | {
"id": 85281744,
"name": "DevExpress/devextreme-reactive",
"url": "https://api.github.com/repos/DevExpress/devextreme-reactive"
} | {
"id": 4580098,
"login": "gsobolev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4580098?",
"url": "https://api.github.com/users/gsobolev"
} | {
"id": 4243232,
"login": "DevExpress",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4243232?",
"url": "https://api.github.com/orgs/DevExpress"
} | 2018-02-19T11:10:26 | 7263522595 | {"actor":{"display_login":"gsobolev"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/DevExpress/DevExtreme/pulls/comments/184694402","pull_request_review_id":115944032,"id":184694402,"diff_hunk":"@@ -149,9 +150,19 @@ function isEqualRange(range) {\n const businessRange = that.getBusinessRange();\n const canvasOptions = getCanvasBounds(businessRange);\n const correctionPrecision = getEqualityCorrection(businessRange) / 100;\n+ const comparingRange = range && new rangeModule.Range(range);","path":"js/viz/translators/translator2d.js","position":12,"original_position":12,"commit_id":"ebb488f13ecca4ef96d0b20715ab737c6cfc9794","original_commit_id":"ebb488f13ecca4ef96d0b20715ab737c6cfc9794","user":{"login":"alexanderPolosatov","id":23187083,"avatar_url":"https://avatars0.githubusercontent.com/u/23187083?v=4","gravatar_id":"","url":"https://api.github.com/users/alexanderPolosatov","html_url":"https://github.com/alexanderPolosatov","followers_url":"https://api.github.com/users/alexanderPolosatov/followers","following_url":"https://api.github.com/users/alexanderPolosatov/following{/other_user}","gists_url":"https://api.github.com/users/alexanderPolosatov/gists{/gist_id}","starred_url":"https://api.github.com/users/alexanderPolosatov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexanderPolosatov/subscriptions","organizations_url":"https://api.github.com/users/alexanderPolosatov/orgs","repos_url":"https://api.github.com/users/alexanderPolosatov/repos","events_url":"https://api.github.com/users/alexanderPolosatov/events{/privacy}","received_events_url":"https://api.github.com/users/alexanderPolosatov/received_events","type":"User","site_admin":false},"body":"and in 'if(comparingRange' use 'range' instead for this checking","created_at":"2018-04-27T13:56:28Z","updated_at":"2018-04-27T13:57:06Z","html_url":"https://github.com/DevExpress/DevExtreme/pull/3868#discussion_r184694402","pull_request_url":"https://api.github.com/repos/DevExpress/DevExtreme/pulls/3868","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DevExpress/DevExtreme/pulls/comments/184694402"},"html":{"href":"https://github.com/DevExpress/DevExtreme/pull/3868#discussion_r184694402"},"pull_request":{"href":"https://api.github.com/repos/DevExpress/DevExtreme/pulls/3868"}},"in_reply_to_id":184692558},"pull_request":{"url":"https://api.github.com/repos/DevExpress/DevExtreme/pulls/3868","id":184625332,"html_url":"https://github.com/DevExpress/DevExtreme/pull/3868","diff_url":"https://github.com/DevExpress/DevExtreme/pull/3868.diff","patch_url":"https://github.com/DevExpress/DevExtreme/pull/3868.patch","issue_url":"https://api.github.com/repos/DevExpress/DevExtreme/issues/3868","number":3868,"state":"open","locked":false,"title":"dxChart: Fix calculation of initial value axis range (T629067)","user":{"login":"dxBeardedBear","id":28751590,"avatar_url":"https://avatars1.githubusercontent.com/u/28751590?v=4","gravatar_id":"","url":"https://api.github.com/users/dxBeardedBear","html_url":"https://github.com/dxBeardedBear","followers_url":"https://api.github.com/users/dxBeardedBear/followers","following_url":"https://api.github.com/users/dxBeardedBear/following{/other_user}","gists_url":"https://api.github.com/users/dxBeardedBear/gists{/gist_id}","starred_url":"https://api.github.com/users/dxBeardedBear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dxBeardedBear/subscriptions","organizations_url":"https://api.github.com/users/dxBeardedBear/orgs","repos_url":"https://api.github.com/users/dxBeardedBear/repos","events_url":"https://api.github.com/users/dxBeardedBear/events{/privacy}","received_events_url":"https://api.github.com/users/dxBeardedBear/received_events","type":"User","site_admin":false},"body":"\r\n","created_at":"2018-04-27T13:40:20Z","updated_at":"2018-04-27T13:57:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2912315cf24e28d92caf1ef607247477980a3902","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":800639823,"url":"https://api.github.com/repos/DevExpress/DevExtreme/labels/18_1","name":"18_1","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DevExpress/DevExtreme/pulls/3868/commits","review_comments_url":"https://api.github.com/repos/DevExpress/DevExtreme/pulls/3868/comments","review_comment_url":"https://api.github.com/repos/DevExpress/DevExtreme/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DevExpress/DevExtreme/issues/3868/comments","statuses_url":"https://api.github.com/repos/DevExpress/DevExtreme/statuses/ebb488f13ecca4ef96d0b20715ab737c6cfc9794","head":{"label":"dxBeardedBear:FixInitialRange_181","ref":"FixInitialRange_181","sha":"ebb488f13ecca4ef96d0b20715ab737c6cfc9794","user":{"login":"dxBeardedBear","id":28751590,"avatar_url":"https://avatars1.githubusercontent.com/u/28751590?v=4","gravatar_id":"","url":"https://api.github.com/users/dxBeardedBear","html_url":"https://github.com/dxBeardedBear","followers_url":"https://api.github.com/users/dxBeardedBear/followers","following_url":"https://api.github.com/users/dxBeardedBear/following{/other_user}","gists_url":"https://api.github.com/users/dxBeardedBear/gists{/gist_id}","starred_url":"https://api.github.com/users/dxBeardedBear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dxBeardedBear/subscriptions","organizations_url":"https://api.github.com/users/dxBeardedBear/orgs","repos_url":"https://api.github.com/users/dxBeardedBear/repos","events_url":"https://api.github.com/users/dxBeardedBear/events{/privacy}","received_events_url":"https://api.github.com/users/dxBeardedBear/received_events","type":"User","site_admin":false},"repo":{"id":105625024,"name":"DevExtreme","full_name":"dxBeardedBear/DevExtreme","owner":{"login":"dxBeardedBear","id":28751590,"avatar_url":"https://avatars1.githubusercontent.com/u/28751590?v=4","gravatar_id":"","url":"https://api.github.com/users/dxBeardedBear","html_url":"https://github.com/dxBeardedBear","followers_url":"https://api.github.com/users/dxBeardedBear/followers","following_url":"https://api.github.com/users/dxBeardedBear/following{/other_user}","gists_url":"https://api.github.com/users/dxBeardedBear/gists{/gist_id}","starred_url":"https://api.github.com/users/dxBeardedBear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dxBeardedBear/subscriptions","organizations_url":"https://api.github.com/users/dxBeardedBear/orgs","repos_url":"https://api.github.com/users/dxBeardedBear/repos","events_url":"https://api.github.com/users/dxBeardedBear/events{/privacy}","received_events_url":"https://api.github.com/users/dxBeardedBear/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dxBeardedBear/DevExtreme","description":"HTML5 JavaScript Component Suite for Responsive Web Development","fork":true,"url":"https://api.github.com/repos/dxBeardedBear/DevExtreme","forks_url":"https://api.github.com/repos/dxBeardedBear/DevExtreme/forks","keys_url":"https://api.github.com/repos/dxBeardedBear/DevExtreme/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dxBeardedBear/DevExtreme/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dxBeardedBear/DevExtreme/teams","hooks_url":"https://api.github.com/repos/dxBeardedBear/DevExtreme/hooks","issue_events_url":"https://api.github.com/repos/dxBeardedBear/DevExtreme/issues/events{/number}","events_url":"https://api.github.com/repos/dxBeardedBear/DevExtreme/events","assignees_url":"https://api.github.com/repos/dxBeardedBear/DevExtreme/assignees{/user}","branches_url":"https://api.github.com/repos/dxBeardedBear/DevExtreme/branches{/branch}","tags_url":"https://api.github.com/repos/dxBeardedBear/DevExtreme/tags","blobs_url":"https://api.github.com/repos/dxBeardedBear/DevExtreme/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dxBeardedBear/DevExtreme/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dxBeardedBear/DevExtreme/git/refs{/sha}","trees_url":"https://api.github.com/repos/dxBeardedBear/DevExtreme/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dxBeardedBear/DevExtreme/statuses/{sha}","languages_url":"https://api.github.com/repos/dxBeardedBear/DevExtreme/languages","stargazers_url":"https://api.github.com/repos/dxBeardedBear/DevExtreme/stargazers","contributors_url":"https://api.github.com/repos/dxBeardedBear/DevExtreme/contributors","subscribers_url":"https://api.github.com/repos/dxBeardedBear/DevExtreme/subscribers","subscription_url":"https://api.github.com/repos/dxBeardedBear/DevExtreme/subscription","commits_url":"https://api.github.com/repos/dxBeardedBear/DevExtreme/commits{/sha}","git_commits_url":"https://api.github.com/repos/dxBeardedBear/DevExtreme/git/commits{/sha}","comments_url":"https://api.github.com/repos/dxBeardedBear/DevExtreme/comments{/number}","issue_comment_url":"https://api.github.com/repos/dxBeardedBear/DevExtreme/issues/comments{/number}","contents_url":"https://api.github.com/repos/dxBeardedBear/DevExtreme/contents/{+path}","compare_url":"https://api.github.com/repos/dxBeardedBear/DevExtreme/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dxBeardedBear/DevExtreme/merges","archive_url":"https://api.github.com/repos/dxBeardedBear/DevExtreme/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dxBeardedBear/DevExtreme/downloads","issues_url":"https://api.github.com/repos/dxBeardedBear/DevExtreme/issues{/number}","pulls_url":"https://api.github.com/repos/dxBeardedBear/DevExtreme/pulls{/number}","milestones_url":"https://api.github.com/repos/dxBeardedBear/DevExtreme/milestones{/number}","notifications_url":"https://api.github.com/repos/dxBeardedBear/DevExtreme/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dxBeardedBear/DevExtreme/labels{/name}","releases_url":"https://api.github.com/repos/dxBeardedBear/DevExtreme/releases{/id}","deployments_url":"https://api.github.com/repos/dxBeardedBear/DevExtreme/deployments","created_at":"2017-10-03T07:26:44Z","updated_at":"2017-10-03T07:26:52Z","pushed_at":"2018-04-27T13:37:15Z","git_url":"git://github.com/dxBeardedBear/DevExtreme.git","ssh_url":"[email protected]:dxBeardedBear/DevExtreme.git","clone_url":"https://github.com/dxBeardedBear/DevExtreme.git","svn_url":"https://github.com/dxBeardedBear/DevExtreme","homepage":"https://js.devexpress.com/","size":21723,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"17_2"}},"base":{"label":"DevExpress:18_1","ref":"18_1","sha":"160f45ed850b574cf9970bc4d559380e96d534cb","user":{"login":"DevExpress","id":4243232,"avatar_url":"https://avatars0.githubusercontent.com/u/4243232?v=4","gravatar_id":"","url":"https://api.github.com/users/DevExpress","html_url":"https://github.com/DevExpress","followers_url":"https://api.github.com/users/DevExpress/followers","following_url":"https://api.github.com/users/DevExpress/following{/other_user}","gists_url":"https://api.github.com/users/DevExpress/gists{/gist_id}","starred_url":"https://api.github.com/users/DevExpress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevExpress/subscriptions","organizations_url":"https://api.github.com/users/DevExpress/orgs","repos_url":"https://api.github.com/users/DevExpress/repos","events_url":"https://api.github.com/users/DevExpress/events{/privacy}","received_events_url":"https://api.github.com/users/DevExpress/received_events","type":"Organization","site_admin":false},"repo":{"id":88523356,"name":"DevExtreme","full_name":"DevExpress/DevExtreme","owner":{"login":"DevExpress","id":4243232,"avatar_url":"https://avatars0.githubusercontent.com/u/4243232?v=4","gravatar_id":"","url":"https://api.github.com/users/DevExpress","html_url":"https://github.com/DevExpress","followers_url":"https://api.github.com/users/DevExpress/followers","following_url":"https://api.github.com/users/DevExpress/following{/other_user}","gists_url":"https://api.github.com/users/DevExpress/gists{/gist_id}","starred_url":"https://api.github.com/users/DevExpress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevExpress/subscriptions","organizations_url":"https://api.github.com/users/DevExpress/orgs","repos_url":"https://api.github.com/users/DevExpress/repos","events_url":"https://api.github.com/users/DevExpress/events{/privacy}","received_events_url":"https://api.github.com/users/DevExpress/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DevExpress/DevExtreme","description":"HTML5 JavaScript Component Suite for Responsive Web Development","fork":false,"url":"https://api.github.com/repos/DevExpress/DevExtreme","forks_url":"https://api.github.com/repos/DevExpress/DevExtreme/forks","keys_url":"https://api.github.com/repos/DevExpress/DevExtreme/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DevExpress/DevExtreme/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DevExpress/DevExtreme/teams","hooks_url":"https://api.github.com/repos/DevExpress/DevExtreme/hooks","issue_events_url":"https://api.github.com/repos/DevExpress/DevExtreme/issues/events{/number}","events_url":"https://api.github.com/repos/DevExpress/DevExtreme/events","assignees_url":"https://api.github.com/repos/DevExpress/DevExtreme/assignees{/user}","branches_url":"https://api.github.com/repos/DevExpress/DevExtreme/branches{/branch}","tags_url":"https://api.github.com/repos/DevExpress/DevExtreme/tags","blobs_url":"https://api.github.com/repos/DevExpress/DevExtreme/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DevExpress/DevExtreme/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DevExpress/DevExtreme/git/refs{/sha}","trees_url":"https://api.github.com/repos/DevExpress/DevExtreme/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DevExpress/DevExtreme/statuses/{sha}","languages_url":"https://api.github.com/repos/DevExpress/DevExtreme/languages","stargazers_url":"https://api.github.com/repos/DevExpress/DevExtreme/stargazers","contributors_url":"https://api.github.com/repos/DevExpress/DevExtreme/contributors","subscribers_url":"https://api.github.com/repos/DevExpress/DevExtreme/subscribers","subscription_url":"https://api.github.com/repos/DevExpress/DevExtreme/subscription","commits_url":"https://api.github.com/repos/DevExpress/DevExtreme/commits{/sha}","git_commits_url":"https://api.github.com/repos/DevExpress/DevExtreme/git/commits{/sha}","comments_url":"https://api.github.com/repos/DevExpress/DevExtreme/comments{/number}","issue_comment_url":"https://api.github.com/repos/DevExpress/DevExtreme/issues/comments{/number}","contents_url":"https://api.github.com/repos/DevExpress/DevExtreme/contents/{+path}","compare_url":"https://api.github.com/repos/DevExpress/DevExtreme/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DevExpress/DevExtreme/merges","archive_url":"https://api.github.com/repos/DevExpress/DevExtreme/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DevExpress/DevExtreme/downloads","issues_url":"https://api.github.com/repos/DevExpress/DevExtreme/issues{/number}","pulls_url":"https://api.github.com/repos/DevExpress/DevExtreme/pulls{/number}","milestones_url":"https://api.github.com/repos/DevExpress/DevExtreme/milestones{/number}","notifications_url":"https://api.github.com/repos/DevExpress/DevExtreme/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DevExpress/DevExtreme/labels{/name}","releases_url":"https://api.github.com/repos/DevExpress/DevExtreme/releases{/id}","deployments_url":"https://api.github.com/repos/DevExpress/DevExtreme/deployments","created_at":"2017-04-17T15:43:34Z","updated_at":"2018-04-27T12:21:42Z","pushed_at":"2018-04-27T13:40:20Z","git_url":"git://github.com/DevExpress/DevExtreme.git","ssh_url":"[email protected]:DevExpress/DevExtreme.git","clone_url":"https://github.com/DevExpress/DevExtreme.git","svn_url":"https://github.com/DevExpress/DevExtreme","homepage":"https://js.devexpress.com/","size":25260,"stargazers_count":819,"watchers_count":819,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":156,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":156,"open_issues":31,"watchers":819,"default_branch":"18_1"}},"_links":{"self":{"href":"https://api.github.com/repos/DevExpress/DevExtreme/pulls/3868"},"html":{"href":"https://github.com/DevExpress/DevExtreme/pull/3868"},"issue":{"href":"https://api.github.com/repos/DevExpress/DevExtreme/issues/3868"},"comments":{"href":"https://api.github.com/repos/DevExpress/DevExtreme/issues/3868/comments"},"review_comments":{"href":"https://api.github.com/repos/DevExpress/DevExtreme/pulls/3868/comments"},"review_comment":{"href":"https://api.github.com/repos/DevExpress/DevExtreme/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DevExpress/DevExtreme/pulls/3868/commits"},"statuses":{"href":"https://api.github.com/repos/DevExpress/DevExtreme/statuses/ebb488f13ecca4ef96d0b20715ab737c6cfc9794"}},"author_association":"CONTRIBUTOR"}} | {
"id": 88523356,
"name": "DevExpress/DevExtreme",
"url": "https://api.github.com/repos/DevExpress/DevExtreme"
} | {
"id": 23187083,
"login": "alexanderPolosatov",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23187083?",
"url": "https://api.github.com/users/alexanderPolosatov"
} | {
"id": 4243232,
"login": "DevExpress",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4243232?",
"url": "https://api.github.com/orgs/DevExpress"
} | 2018-04-27T13:56:28 | 7597616059 | {"actor":{"display_login":"alexanderPolosatov"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/DevExpress/testcafe/pulls/comments/239731398","pull_request_review_id":182595708,"id":239731398,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTczMTM5OA==","diff_hunk":"@@ -0,0 +1,204 @@\n+---\n+layout: docs\n+title: Integrating TestCafe with Azure DevOps\n+permalink: /documentation/recipes/integrating-testcafe-with-ci-systems/azure-devops.html\n+---\n+# Integrating TestCafe with Azure DevOps\n+\n+This topic describes how to integrate TestCafe tests into an [Azure DevOps Server](https://azure.microsoft.com/en-us/services/devops/server/) and [Azure Pipelines](https://azure.microsoft.com/en-us/services/devops/pipelines/) project's build process.\n+\n+## Step 1 - Add TestCafe Dependency to the Project\n+\n+Open the repository's root directory and execute the following command:\n+\n+```sh\n+npm --save-dev testcafe\n+```\n+\n+This command installs the latest TestCafe version locally and adds it to the `devDependencies` section in the `package.json` file.\n+\n+```json\n+{\n+ \"devDependencies\": {\n+ \"testcafe\": \"*\"\n+ }\n+}\n+```\n+\n+## Step 2 - Provide a Command to Run Tests\n+\n+Since TestCafe is installed locally, a test run command that launches TestCafe should be also added to `package.json` to the `scripts` section.\n+\n+```json\n+{\n+ \"scripts\": {\n+ \"test\": \"testcafe chrome:headless tests/**/*\"\n+ },\n+\n+ \"devDependencies\": {\n+ \"testcafe\": \"*\"\n+ }\n+}\n+```\n+\n+This allows you to run tests using `npm test`.\n+\n+## Step 3 - Configure a Build Task\n+\n+Now you are ready to create a build task.\n+\n+### Configure Build Task on Azure Pipelines\n+\n+Open `azure-pipelines.yml` or create it in the repository root and add the following [job](https://docs.microsoft.com/en-us/azure/devops/pipelines/process/phases?view=vsts&tabs=yaml).\n+\n+```yaml\n+jobs:\n+- job: e2e_tests\n+ pool:\n+ vmImage: 'Ubuntu 16.04'\n+ steps:\n+ - task: NodeTool@0\n+ inputs:\n+ # Replace '10.14' with the latest Node.js LTS version\n+ versionSpec: '10.14'\n+ displayName: 'Install Node.js'\n+ - script: npm install\n+ displayName: 'Install TestCafe'\n+ - script: npm test\n+ displayName: 'Run TestCafe Tests'\n+```\n+\n+* `jobs` - the list of [jobs](https://docs.microsoft.com/en-us/azure/devops/pipelines/process/phases?view=vsts&tabs=yaml).\n+* `job` - the job name. You can choose any name you wish.\n+* `pool` - the [agent pool](https://docs.microsoft.com/en-us/azure/devops/pipelines/agents/pools-queues?view=vsts) that executes this build job.\n+* `vmImage` - the [agent's](https://docs.microsoft.com/en-us/azure/devops/pipelines/agents/agents?view=vsts) virtual machine image name. This tutorial uses a [Microsoft-hosted agent](https://docs.microsoft.com/en-us/azure/devops/pipelines/agents/hosted?view=vsts&tabs=yaml) that runs on an Ubuntu 16.04 machine. You can find the list of software installed on this machine in the [Azure Pipelines GitHub repository](https://github.com/Microsoft/azure-pipelines-image-generation/blob/master/images/linux/Ubuntu1604-README.md).\n+* `steps` - the list of steps performed when executing a job.\n+* `task` - adds a [Node.js installer task](https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/tool/node-js?view=vsts) to the job. This task installs Node.js and adds it to the `PATH` variable.\n+* `inputs` - specifies input variables for the task.\n+* `versionSpec` - the Node.js version to install. You can find the latest LTS version number on the [Node.js website](https://nodejs.org/en/).\n+* `displayName` - a step name displayed in build results.\n+* `script` - a console command executed at this step.\n+\n+The first step in this task installs TestCafe with `npm install` and the second step runs TestCafe tests using `npm test`.\n+\n+Commit your changes and push them to the repository.\n+\n+### Configure Build Task on Azure DevOps Server\n+\n+Hover over the **Pipelines** section and click **Builds** in the popup menu.\n+\n+\n+\n+Click the **New** button and select **New build pipeline**.\n+\n+\n+\n+Azure DevOps Server asks you to select the repository that contains your code. Enter the repository details and click **Continue**.\n+\n+\n+\n+The next screen prompts you to select a build template. Choose to start with an empty job.\n+\n+\n+\n+On the next screen, select an [agent pool](https://docs.microsoft.com/en-us/azure/devops/pipelines/agents/pools-queues?view=vsts) to run the job.\n+\n+> Important! The agent should run on a machine with all the necessary browsers installed.\n+\n+\n+\n+Now you can add tasks to the job. Click the **+** button to create a new task.\n+\n+\n+\n+Select **Node Tool Installer** from the task list. This task installs Node.js and adds it to the `PATH` variable.\n+\n+\n+\n+The task is now added to the pipeline. Click its name in the pipeline to enter the task settings.\n+\n+On the settings screen, specify the Node.js version to install. Use the latest LTS version - you can find its number on the [Node.js website](https://nodejs.org/en/).\n+\n+\n+\n+Now add another task that runs a shell command. Click the **+** button again and select **Command Line** from the task list.\n+\n+\n+\n+Configure this command to install TestCafe. Open its settings, specify a meaningful name and enter the following command:\n+\n+```cmd\n+npm install\n+```\n+\n+\n+\n+In the same manner, add another **Command Line** task that runs TestCafe tests.\n+\n+```cmd\n+npm test\n+```\n+\n+\n+\n+Save the changes and run this task using the **Save & queue** button.\n+\n+\n+\n+This opens the **Save build pipeline and queue** window. Specify an optional comment that describes the changes you have made. Select an agent pool that runs this task, the repository branch and the commit that contains code to build. You can leave the **Commit** field blank to use the latest commit. Click **Save & queue**.\n+\n+\n+\n+## Step 4 - Run Test Task and View Results\n+\n+### Option 1 - Enable Continuous Integration\n+\n+You can set Azure DevOps to run the pipeline every time your code changes. To do this, you need to enable continuous integration.","path":"docs/articles/documentation/recipes/integrating-testcafe-with-ci-systems/azure-devops.md","position":156,"original_position":156,"commit_id":"2ee049c5624a36706afa72b71df5fde27c0258de","original_commit_id":"2ee049c5624a36706afa72b71df5fde27c0258de","user":{"login":"dirk-pieterse","id":26871970,"node_id":"MDQ6VXNlcjI2ODcxOTcw","avatar_url":"https://avatars0.githubusercontent.com/u/26871970?v=4","gravatar_id":"","url":"https://api.github.com/users/dirk-pieterse","html_url":"https://github.com/dirk-pieterse","followers_url":"https://api.github.com/users/dirk-pieterse/followers","following_url":"https://api.github.com/users/dirk-pieterse/following{/other_user}","gists_url":"https://api.github.com/users/dirk-pieterse/gists{/gist_id}","starred_url":"https://api.github.com/users/dirk-pieterse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirk-pieterse/subscriptions","organizations_url":"https://api.github.com/users/dirk-pieterse/orgs","repos_url":"https://api.github.com/users/dirk-pieterse/repos","events_url":"https://api.github.com/users/dirk-pieterse/events{/privacy}","received_events_url":"https://api.github.com/users/dirk-pieterse/received_events","type":"User","site_admin":false},"body":"You can enable continuous integration in Azure DevOpst to specify that the pipeline is run every time your code changes?","created_at":"2018-12-07T08:47:38Z","updated_at":"2018-12-07T08:47:38Z","html_url":"https://github.com/DevExpress/testcafe/pull/3158#discussion_r239731398","pull_request_url":"https://api.github.com/repos/DevExpress/testcafe/pulls/3158","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/DevExpress/testcafe/pulls/comments/239731398"},"html":{"href":"https://github.com/DevExpress/testcafe/pull/3158#discussion_r239731398"},"pull_request":{"href":"https://api.github.com/repos/DevExpress/testcafe/pulls/3158"}}},"pull_request":{"url":"https://api.github.com/repos/DevExpress/testcafe/pulls/3158","id":234217416,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MjE3NDE2","html_url":"https://github.com/DevExpress/testcafe/pull/3158","diff_url":"https://github.com/DevExpress/testcafe/pull/3158.diff","patch_url":"https://github.com/DevExpress/testcafe/pull/3158.patch","issue_url":"https://api.github.com/repos/DevExpress/testcafe/issues/3158","number":3158,"state":"open","locked":false,"title":"[docs] Add a recipe describing integration with Azure DevOps","user":{"login":"VasilyStrelyaev","id":11459924,"node_id":"MDQ6VXNlcjExNDU5OTI0","avatar_url":"https://avatars1.githubusercontent.com/u/11459924?v=4","gravatar_id":"","url":"https://api.github.com/users/VasilyStrelyaev","html_url":"https://github.com/VasilyStrelyaev","followers_url":"https://api.github.com/users/VasilyStrelyaev/followers","following_url":"https://api.github.com/users/VasilyStrelyaev/following{/other_user}","gists_url":"https://api.github.com/users/VasilyStrelyaev/gists{/gist_id}","starred_url":"https://api.github.com/users/VasilyStrelyaev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VasilyStrelyaev/subscriptions","organizations_url":"https://api.github.com/users/VasilyStrelyaev/orgs","repos_url":"https://api.github.com/users/VasilyStrelyaev/repos","events_url":"https://api.github.com/users/VasilyStrelyaev/events{/privacy}","received_events_url":"https://api.github.com/users/VasilyStrelyaev/received_events","type":"User","site_admin":false},"body":"\\cc @DevExpress/testcafe-docs ","created_at":"2018-11-28T10:11:33Z","updated_at":"2018-12-07T08:47:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4741b738f550a2536927a9fea52abdd32fc3fcdb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DevExpress/testcafe/pulls/3158/commits","review_comments_url":"https://api.github.com/repos/DevExpress/testcafe/pulls/3158/comments","review_comment_url":"https://api.github.com/repos/DevExpress/testcafe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DevExpress/testcafe/issues/3158/comments","statuses_url":"https://api.github.com/repos/DevExpress/testcafe/statuses/2ee049c5624a36706afa72b71df5fde27c0258de","head":{"label":"VasilyStrelyaev:tfs-recipe","ref":"tfs-recipe","sha":"2ee049c5624a36706afa72b71df5fde27c0258de","user":{"login":"VasilyStrelyaev","id":11459924,"node_id":"MDQ6VXNlcjExNDU5OTI0","avatar_url":"https://avatars1.githubusercontent.com/u/11459924?v=4","gravatar_id":"","url":"https://api.github.com/users/VasilyStrelyaev","html_url":"https://github.com/VasilyStrelyaev","followers_url":"https://api.github.com/users/VasilyStrelyaev/followers","following_url":"https://api.github.com/users/VasilyStrelyaev/following{/other_user}","gists_url":"https://api.github.com/users/VasilyStrelyaev/gists{/gist_id}","starred_url":"https://api.github.com/users/VasilyStrelyaev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VasilyStrelyaev/subscriptions","organizations_url":"https://api.github.com/users/VasilyStrelyaev/orgs","repos_url":"https://api.github.com/users/VasilyStrelyaev/repos","events_url":"https://api.github.com/users/VasilyStrelyaev/events{/privacy}","received_events_url":"https://api.github.com/users/VasilyStrelyaev/received_events","type":"User","site_admin":false},"repo":{"id":45828606,"node_id":"MDEwOlJlcG9zaXRvcnk0NTgyODYwNg==","name":"testcafe","full_name":"VasilyStrelyaev/testcafe","private":false,"owner":{"login":"VasilyStrelyaev","id":11459924,"node_id":"MDQ6VXNlcjExNDU5OTI0","avatar_url":"https://avatars1.githubusercontent.com/u/11459924?v=4","gravatar_id":"","url":"https://api.github.com/users/VasilyStrelyaev","html_url":"https://github.com/VasilyStrelyaev","followers_url":"https://api.github.com/users/VasilyStrelyaev/followers","following_url":"https://api.github.com/users/VasilyStrelyaev/following{/other_user}","gists_url":"https://api.github.com/users/VasilyStrelyaev/gists{/gist_id}","starred_url":"https://api.github.com/users/VasilyStrelyaev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VasilyStrelyaev/subscriptions","organizations_url":"https://api.github.com/users/VasilyStrelyaev/orgs","repos_url":"https://api.github.com/users/VasilyStrelyaev/repos","events_url":"https://api.github.com/users/VasilyStrelyaev/events{/privacy}","received_events_url":"https://api.github.com/users/VasilyStrelyaev/received_events","type":"User","site_admin":false},"html_url":"https://github.com/VasilyStrelyaev/testcafe","description":null,"fork":true,"url":"https://api.github.com/repos/VasilyStrelyaev/testcafe","forks_url":"https://api.github.com/repos/VasilyStrelyaev/testcafe/forks","keys_url":"https://api.github.com/repos/VasilyStrelyaev/testcafe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VasilyStrelyaev/testcafe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VasilyStrelyaev/testcafe/teams","hooks_url":"https://api.github.com/repos/VasilyStrelyaev/testcafe/hooks","issue_events_url":"https://api.github.com/repos/VasilyStrelyaev/testcafe/issues/events{/number}","events_url":"https://api.github.com/repos/VasilyStrelyaev/testcafe/events","assignees_url":"https://api.github.com/repos/VasilyStrelyaev/testcafe/assignees{/user}","branches_url":"https://api.github.com/repos/VasilyStrelyaev/testcafe/branches{/branch}","tags_url":"https://api.github.com/repos/VasilyStrelyaev/testcafe/tags","blobs_url":"https://api.github.com/repos/VasilyStrelyaev/testcafe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VasilyStrelyaev/testcafe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VasilyStrelyaev/testcafe/git/refs{/sha}","trees_url":"https://api.github.com/repos/VasilyStrelyaev/testcafe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VasilyStrelyaev/testcafe/statuses/{sha}","languages_url":"https://api.github.com/repos/VasilyStrelyaev/testcafe/languages","stargazers_url":"https://api.github.com/repos/VasilyStrelyaev/testcafe/stargazers","contributors_url":"https://api.github.com/repos/VasilyStrelyaev/testcafe/contributors","subscribers_url":"https://api.github.com/repos/VasilyStrelyaev/testcafe/subscribers","subscription_url":"https://api.github.com/repos/VasilyStrelyaev/testcafe/subscription","commits_url":"https://api.github.com/repos/VasilyStrelyaev/testcafe/commits{/sha}","git_commits_url":"https://api.github.com/repos/VasilyStrelyaev/testcafe/git/commits{/sha}","comments_url":"https://api.github.com/repos/VasilyStrelyaev/testcafe/comments{/number}","issue_comment_url":"https://api.github.com/repos/VasilyStrelyaev/testcafe/issues/comments{/number}","contents_url":"https://api.github.com/repos/VasilyStrelyaev/testcafe/contents/{+path}","compare_url":"https://api.github.com/repos/VasilyStrelyaev/testcafe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VasilyStrelyaev/testcafe/merges","archive_url":"https://api.github.com/repos/VasilyStrelyaev/testcafe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VasilyStrelyaev/testcafe/downloads","issues_url":"https://api.github.com/repos/VasilyStrelyaev/testcafe/issues{/number}","pulls_url":"https://api.github.com/repos/VasilyStrelyaev/testcafe/pulls{/number}","milestones_url":"https://api.github.com/repos/VasilyStrelyaev/testcafe/milestones{/number}","notifications_url":"https://api.github.com/repos/VasilyStrelyaev/testcafe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VasilyStrelyaev/testcafe/labels{/name}","releases_url":"https://api.github.com/repos/VasilyStrelyaev/testcafe/releases{/id}","deployments_url":"https://api.github.com/repos/VasilyStrelyaev/testcafe/deployments","created_at":"2015-11-09T09:38:53Z","updated_at":"2018-12-04T14:36:45Z","pushed_at":"2018-12-06T11:09:20Z","git_url":"git://github.com/VasilyStrelyaev/testcafe.git","ssh_url":"[email protected]:VasilyStrelyaev/testcafe.git","clone_url":"https://github.com/VasilyStrelyaev/testcafe.git","svn_url":"https://github.com/VasilyStrelyaev/testcafe","homepage":null,"size":48722,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DevExpress:master","ref":"master","sha":"17e40f19adca335953e8acb2c66116d3b8a79a3b","user":{"login":"DevExpress","id":4243232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNDMyMzI=","avatar_url":"https://avatars0.githubusercontent.com/u/4243232?v=4","gravatar_id":"","url":"https://api.github.com/users/DevExpress","html_url":"https://github.com/DevExpress","followers_url":"https://api.github.com/users/DevExpress/followers","following_url":"https://api.github.com/users/DevExpress/following{/other_user}","gists_url":"https://api.github.com/users/DevExpress/gists{/gist_id}","starred_url":"https://api.github.com/users/DevExpress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevExpress/subscriptions","organizations_url":"https://api.github.com/users/DevExpress/orgs","repos_url":"https://api.github.com/users/DevExpress/repos","events_url":"https://api.github.com/users/DevExpress/events{/privacy}","received_events_url":"https://api.github.com/users/DevExpress/received_events","type":"Organization","site_admin":false},"repo":{"id":34262857,"node_id":"MDEwOlJlcG9zaXRvcnkzNDI2Mjg1Nw==","name":"testcafe","full_name":"DevExpress/testcafe","private":false,"owner":{"login":"DevExpress","id":4243232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNDMyMzI=","avatar_url":"https://avatars0.githubusercontent.com/u/4243232?v=4","gravatar_id":"","url":"https://api.github.com/users/DevExpress","html_url":"https://github.com/DevExpress","followers_url":"https://api.github.com/users/DevExpress/followers","following_url":"https://api.github.com/users/DevExpress/following{/other_user}","gists_url":"https://api.github.com/users/DevExpress/gists{/gist_id}","starred_url":"https://api.github.com/users/DevExpress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevExpress/subscriptions","organizations_url":"https://api.github.com/users/DevExpress/orgs","repos_url":"https://api.github.com/users/DevExpress/repos","events_url":"https://api.github.com/users/DevExpress/events{/privacy}","received_events_url":"https://api.github.com/users/DevExpress/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DevExpress/testcafe","description":"A Node.js tool to automate end-to-end web testing.","fork":false,"url":"https://api.github.com/repos/DevExpress/testcafe","forks_url":"https://api.github.com/repos/DevExpress/testcafe/forks","keys_url":"https://api.github.com/repos/DevExpress/testcafe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DevExpress/testcafe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DevExpress/testcafe/teams","hooks_url":"https://api.github.com/repos/DevExpress/testcafe/hooks","issue_events_url":"https://api.github.com/repos/DevExpress/testcafe/issues/events{/number}","events_url":"https://api.github.com/repos/DevExpress/testcafe/events","assignees_url":"https://api.github.com/repos/DevExpress/testcafe/assignees{/user}","branches_url":"https://api.github.com/repos/DevExpress/testcafe/branches{/branch}","tags_url":"https://api.github.com/repos/DevExpress/testcafe/tags","blobs_url":"https://api.github.com/repos/DevExpress/testcafe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DevExpress/testcafe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DevExpress/testcafe/git/refs{/sha}","trees_url":"https://api.github.com/repos/DevExpress/testcafe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DevExpress/testcafe/statuses/{sha}","languages_url":"https://api.github.com/repos/DevExpress/testcafe/languages","stargazers_url":"https://api.github.com/repos/DevExpress/testcafe/stargazers","contributors_url":"https://api.github.com/repos/DevExpress/testcafe/contributors","subscribers_url":"https://api.github.com/repos/DevExpress/testcafe/subscribers","subscription_url":"https://api.github.com/repos/DevExpress/testcafe/subscription","commits_url":"https://api.github.com/repos/DevExpress/testcafe/commits{/sha}","git_commits_url":"https://api.github.com/repos/DevExpress/testcafe/git/commits{/sha}","comments_url":"https://api.github.com/repos/DevExpress/testcafe/comments{/number}","issue_comment_url":"https://api.github.com/repos/DevExpress/testcafe/issues/comments{/number}","contents_url":"https://api.github.com/repos/DevExpress/testcafe/contents/{+path}","compare_url":"https://api.github.com/repos/DevExpress/testcafe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DevExpress/testcafe/merges","archive_url":"https://api.github.com/repos/DevExpress/testcafe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DevExpress/testcafe/downloads","issues_url":"https://api.github.com/repos/DevExpress/testcafe/issues{/number}","pulls_url":"https://api.github.com/repos/DevExpress/testcafe/pulls{/number}","milestones_url":"https://api.github.com/repos/DevExpress/testcafe/milestones{/number}","notifications_url":"https://api.github.com/repos/DevExpress/testcafe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DevExpress/testcafe/labels{/name}","releases_url":"https://api.github.com/repos/DevExpress/testcafe/releases{/id}","deployments_url":"https://api.github.com/repos/DevExpress/testcafe/deployments","created_at":"2015-04-20T13:43:28Z","updated_at":"2018-12-07T08:15:07Z","pushed_at":"2018-12-07T08:36:58Z","git_url":"git://github.com/DevExpress/testcafe.git","ssh_url":"[email protected]:DevExpress/testcafe.git","clone_url":"https://github.com/DevExpress/testcafe.git","svn_url":"https://github.com/DevExpress/testcafe","homepage":"https://devexpress.github.io/testcafe/","size":47824,"stargazers_count":5801,"watchers_count":5801,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":311,"mirror_url":null,"archived":false,"open_issues_count":292,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":311,"open_issues":292,"watchers":5801,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DevExpress/testcafe/pulls/3158"},"html":{"href":"https://github.com/DevExpress/testcafe/pull/3158"},"issue":{"href":"https://api.github.com/repos/DevExpress/testcafe/issues/3158"},"comments":{"href":"https://api.github.com/repos/DevExpress/testcafe/issues/3158/comments"},"review_comments":{"href":"https://api.github.com/repos/DevExpress/testcafe/pulls/3158/comments"},"review_comment":{"href":"https://api.github.com/repos/DevExpress/testcafe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DevExpress/testcafe/pulls/3158/commits"},"statuses":{"href":"https://api.github.com/repos/DevExpress/testcafe/statuses/2ee049c5624a36706afa72b71df5fde27c0258de"}},"author_association":"COLLABORATOR"}} | {
"id": 34262857,
"name": "DevExpress/testcafe",
"url": "https://api.github.com/repos/DevExpress/testcafe"
} | {
"id": 26871970,
"login": "dirk-pieterse",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26871970?",
"url": "https://api.github.com/users/dirk-pieterse"
} | {
"id": 4243232,
"login": "DevExpress",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4243232?",
"url": "https://api.github.com/orgs/DevExpress"
} | 2018-12-07T08:47:38 | 8714667846 | {"actor":{"display_login":"dirk-pieterse"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/comments/187486546","pull_request_review_id":119278051,"id":187486546,"diff_hunk":"@@ -162,12 +192,16 @@ TRCFileAdapter::extendRead(const std::string& fileName) const {\n \n // Columns 2 till the end are data.\n TimeSeriesTableVec3::RowVector \n- row_vector{static_cast<int>(num_markers_expected)};\n+ row_vector{static_cast<int>(num_markers_expected), \n+ SimTK::Vec3(SimTK::NaN)};\n int ind{0};\n- for(std::size_t c = 2; c < column_labels.size() * 3 + 2; c += 3)\n- row_vector[ind++] = SimTK::Vec3{std::stod(row.at(c)),","path":"OpenSim/Common/TRCFileAdapter.cpp","position":91,"original_position":91,"commit_id":"6ca70beb6e3326ab4fc2b004698e2600fb953786","original_commit_id":"8c986299b4e5441365f2de6233478c6f79e0b3af","user":{"login":"chrisdembia","id":846001,"avatar_url":"https://avatars0.githubusercontent.com/u/846001?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisdembia","html_url":"https://github.com/chrisdembia","followers_url":"https://api.github.com/users/chrisdembia/followers","following_url":"https://api.github.com/users/chrisdembia/following{/other_user}","gists_url":"https://api.github.com/users/chrisdembia/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisdembia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisdembia/subscriptions","organizations_url":"https://api.github.com/users/chrisdembia/orgs","repos_url":"https://api.github.com/users/chrisdembia/repos","events_url":"https://api.github.com/users/chrisdembia/events{/privacy}","received_events_url":"https://api.github.com/users/chrisdembia/received_events","type":"User","site_admin":false},"body":"What if `row.at(c+1)` or `row.at(c+2)` is empty?","created_at":"2018-05-10T23:22:47Z","updated_at":"2018-05-10T23:40:54Z","html_url":"https://github.com/opensim-org/opensim-core/pull/2187#discussion_r187486546","pull_request_url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/2187","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/opensim-org/opensim-core/pulls/comments/187486546"},"html":{"href":"https://github.com/opensim-org/opensim-core/pull/2187#discussion_r187486546"},"pull_request":{"href":"https://api.github.com/repos/opensim-org/opensim-core/pulls/2187"}}},"pull_request":{"url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/2187","id":187319649,"html_url":"https://github.com/opensim-org/opensim-core/pull/2187","diff_url":"https://github.com/opensim-org/opensim-core/pull/2187.diff","patch_url":"https://github.com/opensim-org/opensim-core/pull/2187.patch","issue_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/2187","number":2187,"state":"open","locked":false,"title":"[WIP] TRCFileAdapter now reads blanks as NaN and does not use space as delimiter","user":{"login":"aseth1","id":6494122,"avatar_url":"https://avatars0.githubusercontent.com/u/6494122?v=4","gravatar_id":"","url":"https://api.github.com/users/aseth1","html_url":"https://github.com/aseth1","followers_url":"https://api.github.com/users/aseth1/followers","following_url":"https://api.github.com/users/aseth1/following{/other_user}","gists_url":"https://api.github.com/users/aseth1/gists{/gist_id}","starred_url":"https://api.github.com/users/aseth1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aseth1/subscriptions","organizations_url":"https://api.github.com/users/aseth1/orgs","repos_url":"https://api.github.com/users/aseth1/repos","events_url":"https://api.github.com/users/aseth1/events{/privacy}","received_events_url":"https://api.github.com/users/aseth1/received_events","type":"User","site_admin":false},"body":"Fixes issue #2148, #1974 \r\n\r\nRan into this is in trying to test our C3D reader by comparing markers outputted as a TRC file with Mokka export of C3D data as TRC. Mokka outputs blank delimited by tabs to denote obstructed or out of view marker.\r\n\r\n### Brief summary of changes\r\n- revised `FileAdapter::tokenize()` to read consecutive tabs as empty strings\r\n- removed space as a delimiter\r\n- empty strings automatically convert to NaN\r\n- add test case using Mokka generated TRC\r\n- renamed data files for testing based on the conditions they are testing\r\n\r\n### Testing I've completed\r\n- tests pass locally\r\n- added typical file with blank entries (from Mokka) \r\n\r\n### Looking for feedback on...\r\n\r\n### CHANGELOG.md (choose one)\r\n- no need to update because this is a bug fix\r\n\r\nThe Doxygen for this PR can be viewed at http://myosin.sourceforge.net/?C=N;O=D; click the folder whose name is this PR's number.\r\n","created_at":"2018-05-10T22:03:30Z","updated_at":"2018-05-10T23:40:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54c1a93051e6893fe0616023cb421e4ff78771e4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/2187/commits","review_comments_url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/2187/comments","review_comment_url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/2187/comments","statuses_url":"https://api.github.com/repos/opensim-org/opensim-core/statuses/6ca70beb6e3326ab4fc2b004698e2600fb953786","head":{"label":"opensim-org:trc_adapter_reads_blanks_as_nan","ref":"trc_adapter_reads_blanks_as_nan","sha":"6ca70beb6e3326ab4fc2b004698e2600fb953786","user":{"login":"opensim-org","id":4370782,"avatar_url":"https://avatars0.githubusercontent.com/u/4370782?v=4","gravatar_id":"","url":"https://api.github.com/users/opensim-org","html_url":"https://github.com/opensim-org","followers_url":"https://api.github.com/users/opensim-org/followers","following_url":"https://api.github.com/users/opensim-org/following{/other_user}","gists_url":"https://api.github.com/users/opensim-org/gists{/gist_id}","starred_url":"https://api.github.com/users/opensim-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opensim-org/subscriptions","organizations_url":"https://api.github.com/users/opensim-org/orgs","repos_url":"https://api.github.com/users/opensim-org/repos","events_url":"https://api.github.com/users/opensim-org/events{/privacy}","received_events_url":"https://api.github.com/users/opensim-org/received_events","type":"Organization","site_admin":false},"repo":{"id":20775600,"name":"opensim-core","full_name":"opensim-org/opensim-core","owner":{"login":"opensim-org","id":4370782,"avatar_url":"https://avatars0.githubusercontent.com/u/4370782?v=4","gravatar_id":"","url":"https://api.github.com/users/opensim-org","html_url":"https://github.com/opensim-org","followers_url":"https://api.github.com/users/opensim-org/followers","following_url":"https://api.github.com/users/opensim-org/following{/other_user}","gists_url":"https://api.github.com/users/opensim-org/gists{/gist_id}","starred_url":"https://api.github.com/users/opensim-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opensim-org/subscriptions","organizations_url":"https://api.github.com/users/opensim-org/orgs","repos_url":"https://api.github.com/users/opensim-org/repos","events_url":"https://api.github.com/users/opensim-org/events{/privacy}","received_events_url":"https://api.github.com/users/opensim-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opensim-org/opensim-core","description":"SimTK OpenSim 4.0 C++ libraries and command-line applications, and Java/Python wrapping.","fork":false,"url":"https://api.github.com/repos/opensim-org/opensim-core","forks_url":"https://api.github.com/repos/opensim-org/opensim-core/forks","keys_url":"https://api.github.com/repos/opensim-org/opensim-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opensim-org/opensim-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opensim-org/opensim-core/teams","hooks_url":"https://api.github.com/repos/opensim-org/opensim-core/hooks","issue_events_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/events{/number}","events_url":"https://api.github.com/repos/opensim-org/opensim-core/events","assignees_url":"https://api.github.com/repos/opensim-org/opensim-core/assignees{/user}","branches_url":"https://api.github.com/repos/opensim-org/opensim-core/branches{/branch}","tags_url":"https://api.github.com/repos/opensim-org/opensim-core/tags","blobs_url":"https://api.github.com/repos/opensim-org/opensim-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opensim-org/opensim-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opensim-org/opensim-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/opensim-org/opensim-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opensim-org/opensim-core/statuses/{sha}","languages_url":"https://api.github.com/repos/opensim-org/opensim-core/languages","stargazers_url":"https://api.github.com/repos/opensim-org/opensim-core/stargazers","contributors_url":"https://api.github.com/repos/opensim-org/opensim-core/contributors","subscribers_url":"https://api.github.com/repos/opensim-org/opensim-core/subscribers","subscription_url":"https://api.github.com/repos/opensim-org/opensim-core/subscription","commits_url":"https://api.github.com/repos/opensim-org/opensim-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/opensim-org/opensim-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/opensim-org/opensim-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/opensim-org/opensim-core/contents/{+path}","compare_url":"https://api.github.com/repos/opensim-org/opensim-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opensim-org/opensim-core/merges","archive_url":"https://api.github.com/repos/opensim-org/opensim-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opensim-org/opensim-core/downloads","issues_url":"https://api.github.com/repos/opensim-org/opensim-core/issues{/number}","pulls_url":"https://api.github.com/repos/opensim-org/opensim-core/pulls{/number}","milestones_url":"https://api.github.com/repos/opensim-org/opensim-core/milestones{/number}","notifications_url":"https://api.github.com/repos/opensim-org/opensim-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opensim-org/opensim-core/labels{/name}","releases_url":"https://api.github.com/repos/opensim-org/opensim-core/releases{/id}","deployments_url":"https://api.github.com/repos/opensim-org/opensim-core/deployments","created_at":"2014-06-12T16:57:56Z","updated_at":"2018-05-10T10:32:36Z","pushed_at":"2018-05-10T23:22:55Z","git_url":"git://github.com/opensim-org/opensim-core.git","ssh_url":"[email protected]:opensim-org/opensim-core.git","clone_url":"https://github.com/opensim-org/opensim-core.git","svn_url":"https://github.com/opensim-org/opensim-core","homepage":"https://opensim.stanford.edu","size":141958,"stargazers_count":134,"watchers_count":134,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":94,"mirror_url":null,"archived":false,"open_issues_count":480,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":94,"open_issues":480,"watchers":134,"default_branch":"master"}},"base":{"label":"opensim-org:master","ref":"master","sha":"671076b4764d0d9d9ffc0ddc1d73cbe81da41df5","user":{"login":"opensim-org","id":4370782,"avatar_url":"https://avatars0.githubusercontent.com/u/4370782?v=4","gravatar_id":"","url":"https://api.github.com/users/opensim-org","html_url":"https://github.com/opensim-org","followers_url":"https://api.github.com/users/opensim-org/followers","following_url":"https://api.github.com/users/opensim-org/following{/other_user}","gists_url":"https://api.github.com/users/opensim-org/gists{/gist_id}","starred_url":"https://api.github.com/users/opensim-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opensim-org/subscriptions","organizations_url":"https://api.github.com/users/opensim-org/orgs","repos_url":"https://api.github.com/users/opensim-org/repos","events_url":"https://api.github.com/users/opensim-org/events{/privacy}","received_events_url":"https://api.github.com/users/opensim-org/received_events","type":"Organization","site_admin":false},"repo":{"id":20775600,"name":"opensim-core","full_name":"opensim-org/opensim-core","owner":{"login":"opensim-org","id":4370782,"avatar_url":"https://avatars0.githubusercontent.com/u/4370782?v=4","gravatar_id":"","url":"https://api.github.com/users/opensim-org","html_url":"https://github.com/opensim-org","followers_url":"https://api.github.com/users/opensim-org/followers","following_url":"https://api.github.com/users/opensim-org/following{/other_user}","gists_url":"https://api.github.com/users/opensim-org/gists{/gist_id}","starred_url":"https://api.github.com/users/opensim-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opensim-org/subscriptions","organizations_url":"https://api.github.com/users/opensim-org/orgs","repos_url":"https://api.github.com/users/opensim-org/repos","events_url":"https://api.github.com/users/opensim-org/events{/privacy}","received_events_url":"https://api.github.com/users/opensim-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opensim-org/opensim-core","description":"SimTK OpenSim 4.0 C++ libraries and command-line applications, and Java/Python wrapping.","fork":false,"url":"https://api.github.com/repos/opensim-org/opensim-core","forks_url":"https://api.github.com/repos/opensim-org/opensim-core/forks","keys_url":"https://api.github.com/repos/opensim-org/opensim-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opensim-org/opensim-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opensim-org/opensim-core/teams","hooks_url":"https://api.github.com/repos/opensim-org/opensim-core/hooks","issue_events_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/events{/number}","events_url":"https://api.github.com/repos/opensim-org/opensim-core/events","assignees_url":"https://api.github.com/repos/opensim-org/opensim-core/assignees{/user}","branches_url":"https://api.github.com/repos/opensim-org/opensim-core/branches{/branch}","tags_url":"https://api.github.com/repos/opensim-org/opensim-core/tags","blobs_url":"https://api.github.com/repos/opensim-org/opensim-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opensim-org/opensim-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opensim-org/opensim-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/opensim-org/opensim-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opensim-org/opensim-core/statuses/{sha}","languages_url":"https://api.github.com/repos/opensim-org/opensim-core/languages","stargazers_url":"https://api.github.com/repos/opensim-org/opensim-core/stargazers","contributors_url":"https://api.github.com/repos/opensim-org/opensim-core/contributors","subscribers_url":"https://api.github.com/repos/opensim-org/opensim-core/subscribers","subscription_url":"https://api.github.com/repos/opensim-org/opensim-core/subscription","commits_url":"https://api.github.com/repos/opensim-org/opensim-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/opensim-org/opensim-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/opensim-org/opensim-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/opensim-org/opensim-core/contents/{+path}","compare_url":"https://api.github.com/repos/opensim-org/opensim-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opensim-org/opensim-core/merges","archive_url":"https://api.github.com/repos/opensim-org/opensim-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opensim-org/opensim-core/downloads","issues_url":"https://api.github.com/repos/opensim-org/opensim-core/issues{/number}","pulls_url":"https://api.github.com/repos/opensim-org/opensim-core/pulls{/number}","milestones_url":"https://api.github.com/repos/opensim-org/opensim-core/milestones{/number}","notifications_url":"https://api.github.com/repos/opensim-org/opensim-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opensim-org/opensim-core/labels{/name}","releases_url":"https://api.github.com/repos/opensim-org/opensim-core/releases{/id}","deployments_url":"https://api.github.com/repos/opensim-org/opensim-core/deployments","created_at":"2014-06-12T16:57:56Z","updated_at":"2018-05-10T10:32:36Z","pushed_at":"2018-05-10T23:22:55Z","git_url":"git://github.com/opensim-org/opensim-core.git","ssh_url":"[email protected]:opensim-org/opensim-core.git","clone_url":"https://github.com/opensim-org/opensim-core.git","svn_url":"https://github.com/opensim-org/opensim-core","homepage":"https://opensim.stanford.edu","size":141958,"stargazers_count":134,"watchers_count":134,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":94,"mirror_url":null,"archived":false,"open_issues_count":480,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":94,"open_issues":480,"watchers":134,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opensim-org/opensim-core/pulls/2187"},"html":{"href":"https://github.com/opensim-org/opensim-core/pull/2187"},"issue":{"href":"https://api.github.com/repos/opensim-org/opensim-core/issues/2187"},"comments":{"href":"https://api.github.com/repos/opensim-org/opensim-core/issues/2187/comments"},"review_comments":{"href":"https://api.github.com/repos/opensim-org/opensim-core/pulls/2187/comments"},"review_comment":{"href":"https://api.github.com/repos/opensim-org/opensim-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opensim-org/opensim-core/pulls/2187/commits"},"statuses":{"href":"https://api.github.com/repos/opensim-org/opensim-core/statuses/6ca70beb6e3326ab4fc2b004698e2600fb953786"}},"author_association":"OWNER"}} | {
"id": 20775600,
"name": "opensim-org/opensim-core",
"url": "https://api.github.com/repos/opensim-org/opensim-core"
} | {
"id": 846001,
"login": "chrisdembia",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/846001?",
"url": "https://api.github.com/users/chrisdembia"
} | {
"id": 4370782,
"login": "opensim-org",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4370782?",
"url": "https://api.github.com/orgs/opensim-org"
} | 2018-05-10T23:22:47 | 7658412910 | {"actor":{"display_login":"chrisdembia"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/juju/juju/pulls/comments/234827146","pull_request_review_id":176553030,"id":234827146,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDgyNzE0Ng==","diff_hunk":"@@ -272,6 +272,11 @@ func newModelStateWorker(\n func (w *modelStateWorker) loop() error {\n \tst, err := w.pool.Get(w.modelUUID)\n \tif err != nil {\n+\t\tif errors.IsNotFound(err) {","path":"worker/state/manifold.go","position":4,"original_position":4,"commit_id":"14c404acca799e9ce37ad38a3ce5d8774a0fe893","original_commit_id":"1af5e03fa56d06f189d95b597e2b9533972f1d75","user":{"login":"ycliuhw","id":6562925,"node_id":"MDQ6VXNlcjY1NjI5MjU=","avatar_url":"https://avatars3.githubusercontent.com/u/6562925?v=4","gravatar_id":"","url":"https://api.github.com/users/ycliuhw","html_url":"https://github.com/ycliuhw","followers_url":"https://api.github.com/users/ycliuhw/followers","following_url":"https://api.github.com/users/ycliuhw/following{/other_user}","gists_url":"https://api.github.com/users/ycliuhw/gists{/gist_id}","starred_url":"https://api.github.com/users/ycliuhw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ycliuhw/subscriptions","organizations_url":"https://api.github.com/users/ycliuhw/orgs","repos_url":"https://api.github.com/users/ycliuhw/repos","events_url":"https://api.github.com/users/ycliuhw/events{/privacy}","received_events_url":"https://api.github.com/users/ycliuhw/received_events","type":"User","site_admin":false},"body":"the change here is to ignore notfound error. ","created_at":"2018-11-20T00:01:55Z","updated_at":"2018-11-20T00:42:49Z","html_url":"https://github.com/juju/juju/pull/9480#discussion_r234827146","pull_request_url":"https://api.github.com/repos/juju/juju/pulls/9480","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/comments/234827146"},"html":{"href":"https://github.com/juju/juju/pull/9480#discussion_r234827146"},"pull_request":{"href":"https://api.github.com/repos/juju/juju/pulls/9480"}},"in_reply_to_id":234825324},"pull_request":{"url":"https://api.github.com/repos/juju/juju/pulls/9480","id":231904841,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxOTA0ODQx","html_url":"https://github.com/juju/juju/pull/9480","diff_url":"https://github.com/juju/juju/pull/9480.diff","patch_url":"https://github.com/juju/juju/pull/9480.patch","issue_url":"https://api.github.com/repos/juju/juju/issues/9480","number":9480,"state":"open","locked":false,"title":"fixed unreleased pooledState when getting model failed","user":{"login":"ycliuhw","id":6562925,"node_id":"MDQ6VXNlcjY1NjI5MjU=","avatar_url":"https://avatars3.githubusercontent.com/u/6562925?v=4","gravatar_id":"","url":"https://api.github.com/users/ycliuhw","html_url":"https://github.com/ycliuhw","followers_url":"https://api.github.com/users/ycliuhw/followers","following_url":"https://api.github.com/users/ycliuhw/following{/other_user}","gists_url":"https://api.github.com/users/ycliuhw/gists{/gist_id}","starred_url":"https://api.github.com/users/ycliuhw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ycliuhw/subscriptions","organizations_url":"https://api.github.com/users/ycliuhw/orgs","repos_url":"https://api.github.com/users/ycliuhw/repos","events_url":"https://api.github.com/users/ycliuhw/events{/privacy}","received_events_url":"https://api.github.com/users/ycliuhw/received_events","type":"User","site_admin":false},"body":"## Description of change\r\n\r\nfixed `unreleased` pooledState when getting model failed which is causing uncleared cached state in statepool even the model has been destroyed.\r\n\r\n## QA steps\r\n\r\n1. prepare a model and deploy some workload;\r\n2. run `juju destroy-model <model-name> --debug --release-storage`;\r\n3. jump into the controller: `juju ssh -m <controller-name>:controller 0`;\r\n4. run `juju_statepool_report` to see if the removed model still have been removed from the state pool and does not have any goroutine refererence.\r\n\r\n* Before this fix: \r\n```\r\nubuntu@juju-bc7b54-0:~$ juju_statepool_report\r\nQuerying @jujud-machine-0 introspection socket: /statepool\r\nState Pool Report:\r\n\r\nModel count: 1 models\r\nMarked for removal: 1 models\r\n\r\n\r\nModel: 2187cbe4-73c4-48d7-8836-f3012f41e288\r\n Marked for removal: true\r\n Reference count: 1\r\n [1]\r\ngoroutine 10098 [running]:\r\nruntime/debug.Stack(0x2eb40a0, 0xc0005ff980, 0xc002927656)\r\n\t/snap/go/3039/src/runtime/debug/stack.go:24 +0xa7\r\ngithub.com/juju/juju/state.(*StatePool).Get(0xc0005ff9b0, 0xc002927656, 0x24, 0x0, 0x0, 0x0)\r\n\t/home/kelvinliu/Code/Golang/src/github.com/juju/juju/state/pool.go:212 +0x12f\r\ngithub.com/juju/juju/apiserver/common.modelManagerStateShim.GetBackend(0xc00041c210, 0xc003570000, 0xc0005ff9b0, 0xc002927656, 0x24, 0xc00041c210, 0xc003570000, 0xc0005ff9b0, 0xc00050b086, 0x24)\r\n\t/home/kelvinliu/Code/Golang/src/github.com/juju/juju/apiserver/common/modelmanagerinterface.go:148 +0x49\r\ngithub.com/juju/juju/apiserver/common.(*ModelStatusAPI).modelStatus(0xc0019c3440, 0xc002927650, 0x2a, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)\r\n\t/home/kelvinliu/Code/Golang/src/github.com/juju/juju/apiserver/common/modelstatus.go:54 +0xab5\r\ngithub.com/juju/juju/apiserver/common.(*ModelStatusAPI).ModelStatus(0xc0019c3440, 0xc001f842c0, 0x1, 0x4, 0x0, 0x0, 0x0, 0x0, 0x0)\r\n\t/home/kelvinliu/Code/Golang/src/github.com/juju/juju/apiserver/common/modelstatus.go:36 +0xfb\r\nreflect.Value.call(0x347b160, 0xc00323f400, 0x2613, 0x35c46a5, 0x4, 0xc00399c680, 0x1, 0x1, 0x9f80e1, 0x2df67e0, ...)\r\n\t/snap/go/3039/src/reflect/value.go:447 +0x449\r\nreflect.Value.Call(0x347b160, 0xc00323f400, 0x2613, 0xc00399c680, 0x1, 0x1, 0x1, 0x1, 0xc000496000)\r\n\t/snap/go/3039/src/reflect/value.go:308 +0xa4\r\ngithub.com/juju/juju/rpc/rpcreflect.newMethod.func8(0x3b54d20, 0xc003c9d580, 0x347b160, 0xc00323f400, 0x16, 0x300dfc0, 0xc003c72500, 0x199, 0x42d7e2, 0xc000000000, ...)\r\n\t/home/kelvinliu/Code/Golang/src/github.com/juju/juju/rpc/rpcreflect/type.go:344 +0x109\r\ngithub.com/juju/juju/apiserver.(*srvCaller).Call(0xc001f84280, 0x3b54d20, 0xc003c9d580, 0x0, 0x0, 0x300dfc0, 0xc003c72500, 0x199, 0xc003c724e0, 0x1a332f9f, ...)\r\n\t/home/kelvinliu/Code/Golang/src/github.com/juju/juju/apiserver/root.go:158 +0xd6\r\ngithub.com/juju/juju/rpc.(*Conn).runRequest(0xc00323ed20, 0x3b416a0, 0xc001f84280, 0x3719c90, 0x1e, 0xc003ffe940, 0xc, 0x5, 0x0, 0x0, ...)\r\n\t/home/kelvinliu/Code/Golang/src/github.com/juju/juju/rpc/server.go:560 +0x1ab\r\ncreated by github.com/juju/juju/rpc.(*Conn).handleRequest\r\n\t/home/kelvinliu/Code/Golang/src/github.com/juju/juju/rpc/server.go:467 +0x8f9\r\n```\r\n\r\n* Now:\r\n```\r\nubuntu@juju-bc7b54-0:~$ juju_statepool_report\r\nQuerying @jujud-machine-0 introspection socket: /statepool\r\nState Pool Report:\r\n\r\nModel count: 0 models\r\nMarked for removal: 0 models\r\n```\r\n\r\n## Documentation changes\r\n\r\nBug fix, no document change is required.\r\n","created_at":"2018-11-19T09:32:59Z","updated_at":"2018-11-20T00:42:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e7fd4e37f954c1c445d1289b2d49a104d80713c8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju/pulls/9480/commits","review_comments_url":"https://api.github.com/repos/juju/juju/pulls/9480/comments","review_comment_url":"https://api.github.com/repos/juju/juju/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juju/juju/issues/9480/comments","statuses_url":"https://api.github.com/repos/juju/juju/statuses/14c404acca799e9ce37ad38a3ce5d8774a0fe893","head":{"label":"ycliuhw:fix/destroy-model-not-release-state-ref","ref":"fix/destroy-model-not-release-state-ref","sha":"14c404acca799e9ce37ad38a3ce5d8774a0fe893","user":{"login":"ycliuhw","id":6562925,"node_id":"MDQ6VXNlcjY1NjI5MjU=","avatar_url":"https://avatars3.githubusercontent.com/u/6562925?v=4","gravatar_id":"","url":"https://api.github.com/users/ycliuhw","html_url":"https://github.com/ycliuhw","followers_url":"https://api.github.com/users/ycliuhw/followers","following_url":"https://api.github.com/users/ycliuhw/following{/other_user}","gists_url":"https://api.github.com/users/ycliuhw/gists{/gist_id}","starred_url":"https://api.github.com/users/ycliuhw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ycliuhw/subscriptions","organizations_url":"https://api.github.com/users/ycliuhw/orgs","repos_url":"https://api.github.com/users/ycliuhw/repos","events_url":"https://api.github.com/users/ycliuhw/events{/privacy}","received_events_url":"https://api.github.com/users/ycliuhw/received_events","type":"User","site_admin":false},"repo":{"id":129208625,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkyMDg2MjU=","name":"juju","full_name":"ycliuhw/juju","private":false,"owner":{"login":"ycliuhw","id":6562925,"node_id":"MDQ6VXNlcjY1NjI5MjU=","avatar_url":"https://avatars3.githubusercontent.com/u/6562925?v=4","gravatar_id":"","url":"https://api.github.com/users/ycliuhw","html_url":"https://github.com/ycliuhw","followers_url":"https://api.github.com/users/ycliuhw/followers","following_url":"https://api.github.com/users/ycliuhw/following{/other_user}","gists_url":"https://api.github.com/users/ycliuhw/gists{/gist_id}","starred_url":"https://api.github.com/users/ycliuhw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ycliuhw/subscriptions","organizations_url":"https://api.github.com/users/ycliuhw/orgs","repos_url":"https://api.github.com/users/ycliuhw/repos","events_url":"https://api.github.com/users/ycliuhw/events{/privacy}","received_events_url":"https://api.github.com/users/ycliuhw/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ycliuhw/juju","description":"juju is devops distilled","fork":true,"url":"https://api.github.com/repos/ycliuhw/juju","forks_url":"https://api.github.com/repos/ycliuhw/juju/forks","keys_url":"https://api.github.com/repos/ycliuhw/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ycliuhw/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ycliuhw/juju/teams","hooks_url":"https://api.github.com/repos/ycliuhw/juju/hooks","issue_events_url":"https://api.github.com/repos/ycliuhw/juju/issues/events{/number}","events_url":"https://api.github.com/repos/ycliuhw/juju/events","assignees_url":"https://api.github.com/repos/ycliuhw/juju/assignees{/user}","branches_url":"https://api.github.com/repos/ycliuhw/juju/branches{/branch}","tags_url":"https://api.github.com/repos/ycliuhw/juju/tags","blobs_url":"https://api.github.com/repos/ycliuhw/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ycliuhw/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ycliuhw/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/ycliuhw/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ycliuhw/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/ycliuhw/juju/languages","stargazers_url":"https://api.github.com/repos/ycliuhw/juju/stargazers","contributors_url":"https://api.github.com/repos/ycliuhw/juju/contributors","subscribers_url":"https://api.github.com/repos/ycliuhw/juju/subscribers","subscription_url":"https://api.github.com/repos/ycliuhw/juju/subscription","commits_url":"https://api.github.com/repos/ycliuhw/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/ycliuhw/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/ycliuhw/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/ycliuhw/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/ycliuhw/juju/contents/{+path}","compare_url":"https://api.github.com/repos/ycliuhw/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ycliuhw/juju/merges","archive_url":"https://api.github.com/repos/ycliuhw/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ycliuhw/juju/downloads","issues_url":"https://api.github.com/repos/ycliuhw/juju/issues{/number}","pulls_url":"https://api.github.com/repos/ycliuhw/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/ycliuhw/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/ycliuhw/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ycliuhw/juju/labels{/name}","releases_url":"https://api.github.com/repos/ycliuhw/juju/releases{/id}","deployments_url":"https://api.github.com/repos/ycliuhw/juju/deployments","created_at":"2018-04-12T07:09:20Z","updated_at":"2018-11-15T23:17:46Z","pushed_at":"2018-11-20T00:37:23Z","git_url":"git://github.com/ycliuhw/juju.git","ssh_url":"[email protected]:ycliuhw/juju.git","clone_url":"https://github.com/ycliuhw/juju.git","svn_url":"https://github.com/ycliuhw/juju","homepage":"juju.ubuntu.com","size":231939,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"juju:develop","ref":"develop","sha":"30db4a02820d257f4bd08880cb88178fc7cda991","user":{"login":"juju","id":4604548,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MDQ1NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/4604548?v=4","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20445947,"node_id":"MDEwOlJlcG9zaXRvcnkyMDQ0NTk0Nw==","name":"juju","full_name":"juju/juju","private":false,"owner":{"login":"juju","id":4604548,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MDQ1NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/4604548?v=4","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/juju/juju","description":"juju is devops distilled","fork":false,"url":"https://api.github.com/repos/juju/juju","forks_url":"https://api.github.com/repos/juju/juju/forks","keys_url":"https://api.github.com/repos/juju/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju/teams","hooks_url":"https://api.github.com/repos/juju/juju/hooks","issue_events_url":"https://api.github.com/repos/juju/juju/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju/events","assignees_url":"https://api.github.com/repos/juju/juju/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju/tags","blobs_url":"https://api.github.com/repos/juju/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju/languages","stargazers_url":"https://api.github.com/repos/juju/juju/stargazers","contributors_url":"https://api.github.com/repos/juju/juju/contributors","subscribers_url":"https://api.github.com/repos/juju/juju/subscribers","subscription_url":"https://api.github.com/repos/juju/juju/subscription","commits_url":"https://api.github.com/repos/juju/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju/juju/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju/merges","archive_url":"https://api.github.com/repos/juju/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju/downloads","issues_url":"https://api.github.com/repos/juju/juju/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju/releases{/id}","deployments_url":"https://api.github.com/repos/juju/juju/deployments","created_at":"2014-06-03T14:28:10Z","updated_at":"2018-11-19T04:57:12Z","pushed_at":"2018-11-20T00:37:24Z","git_url":"git://github.com/juju/juju.git","ssh_url":"[email protected]:juju/juju.git","clone_url":"https://github.com/juju/juju.git","svn_url":"https://github.com/juju/juju","homepage":"juju.ubuntu.com","size":231772,"stargazers_count":1271,"watchers_count":1271,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":294,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":294,"open_issues":12,"watchers":1271,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/9480"},"html":{"href":"https://github.com/juju/juju/pull/9480"},"issue":{"href":"https://api.github.com/repos/juju/juju/issues/9480"},"comments":{"href":"https://api.github.com/repos/juju/juju/issues/9480/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju/pulls/9480/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juju/juju/pulls/9480/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju/statuses/14c404acca799e9ce37ad38a3ce5d8774a0fe893"}},"author_association":"MEMBER"}} | {
"id": 20445947,
"name": "juju/juju",
"url": "https://api.github.com/repos/juju/juju"
} | {
"id": 6562925,
"login": "ycliuhw",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6562925?",
"url": "https://api.github.com/users/ycliuhw"
} | {
"id": 4604548,
"login": "juju",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4604548?",
"url": "https://api.github.com/orgs/juju"
} | 2018-11-20T00:01:55 | 8616541520 | {"actor":{"display_login":"ycliuhw"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/pulls/comments/187717066","pull_request_review_id":119560323,"id":187717066,"diff_hunk":"@@ -72,6 +72,7 @@ public CacheManagerBusinessReflectionImpl(KitAwareClassLoaderDelegator kitAwareC\n private void pound(Object cache, Integer intensity) {\n IntStream.range(0, intensity).forEach(value -> {\n put(cache, ThreadLocalRandom.current().nextLong(0, intensity * 1000), longString(intensity));\n+ remove(cache, ThreadLocalRandom.current().nextLong(0, intensity * 1000));","path":"src/main/java/org/terracotta/tinypounder/CacheManagerBusinessReflectionImpl.java","position":4,"original_position":4,"commit_id":"70b0a778e8da544876777f298b1866b05c3e21e0","original_commit_id":"70b0a778e8da544876777f298b1866b05c3e21e0","user":{"login":"anthonydahanne","id":60938,"avatar_url":"https://avatars0.githubusercontent.com/u/60938?v=4","gravatar_id":"","url":"https://api.github.com/users/anthonydahanne","html_url":"https://github.com/anthonydahanne","followers_url":"https://api.github.com/users/anthonydahanne/followers","following_url":"https://api.github.com/users/anthonydahanne/following{/other_user}","gists_url":"https://api.github.com/users/anthonydahanne/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonydahanne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonydahanne/subscriptions","organizations_url":"https://api.github.com/users/anthonydahanne/orgs","repos_url":"https://api.github.com/users/anthonydahanne/repos","events_url":"https://api.github.com/users/anthonydahanne/events{/privacy}","received_events_url":"https://api.github.com/users/anthonydahanne/received_events","type":"User","site_admin":false},"body":"well, that's not pounding anymore if you start removing entries ...","created_at":"2018-05-11T19:53:01Z","updated_at":"2018-05-11T19:53:02Z","html_url":"https://github.com/Terracotta-OSS/tinypounder/pull/37#discussion_r187717066","pull_request_url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/pulls/37","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Terracotta-OSS/tinypounder/pulls/comments/187717066"},"html":{"href":"https://github.com/Terracotta-OSS/tinypounder/pull/37#discussion_r187717066"},"pull_request":{"href":"https://api.github.com/repos/Terracotta-OSS/tinypounder/pulls/37"}}},"pull_request":{"url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/pulls/37","id":187554227,"html_url":"https://github.com/Terracotta-OSS/tinypounder/pull/37","diff_url":"https://github.com/Terracotta-OSS/tinypounder/pull/37.diff","patch_url":"https://github.com/Terracotta-OSS/tinypounder/pull/37.patch","issue_url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/issues/37","number":37,"state":"open","locked":false,"title":"Add remove operation to Ehcache","user":{"login":"boyusun-SAG","id":35749518,"avatar_url":"https://avatars3.githubusercontent.com/u/35749518?v=4","gravatar_id":"","url":"https://api.github.com/users/boyusun-SAG","html_url":"https://github.com/boyusun-SAG","followers_url":"https://api.github.com/users/boyusun-SAG/followers","following_url":"https://api.github.com/users/boyusun-SAG/following{/other_user}","gists_url":"https://api.github.com/users/boyusun-SAG/gists{/gist_id}","starred_url":"https://api.github.com/users/boyusun-SAG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boyusun-SAG/subscriptions","organizations_url":"https://api.github.com/users/boyusun-SAG/orgs","repos_url":"https://api.github.com/users/boyusun-SAG/repos","events_url":"https://api.github.com/users/boyusun-SAG/events{/privacy}","received_events_url":"https://api.github.com/users/boyusun-SAG/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-11T19:49:17Z","updated_at":"2018-05-11T19:53:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75117f4ba76232c4c2447d137fb69e7084b6a524","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/pulls/37/commits","review_comments_url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/pulls/37/comments","review_comment_url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/issues/37/comments","statuses_url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/statuses/70b0a778e8da544876777f298b1866b05c3e21e0","head":{"label":"boyusun-SAG:AddRemoveToEhcache","ref":"AddRemoveToEhcache","sha":"70b0a778e8da544876777f298b1866b05c3e21e0","user":{"login":"boyusun-SAG","id":35749518,"avatar_url":"https://avatars3.githubusercontent.com/u/35749518?v=4","gravatar_id":"","url":"https://api.github.com/users/boyusun-SAG","html_url":"https://github.com/boyusun-SAG","followers_url":"https://api.github.com/users/boyusun-SAG/followers","following_url":"https://api.github.com/users/boyusun-SAG/following{/other_user}","gists_url":"https://api.github.com/users/boyusun-SAG/gists{/gist_id}","starred_url":"https://api.github.com/users/boyusun-SAG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boyusun-SAG/subscriptions","organizations_url":"https://api.github.com/users/boyusun-SAG/orgs","repos_url":"https://api.github.com/users/boyusun-SAG/repos","events_url":"https://api.github.com/users/boyusun-SAG/events{/privacy}","received_events_url":"https://api.github.com/users/boyusun-SAG/received_events","type":"User","site_admin":false},"repo":{"id":118689393,"name":"tinypounder","full_name":"boyusun-SAG/tinypounder","owner":{"login":"boyusun-SAG","id":35749518,"avatar_url":"https://avatars3.githubusercontent.com/u/35749518?v=4","gravatar_id":"","url":"https://api.github.com/users/boyusun-SAG","html_url":"https://github.com/boyusun-SAG","followers_url":"https://api.github.com/users/boyusun-SAG/followers","following_url":"https://api.github.com/users/boyusun-SAG/following{/other_user}","gists_url":"https://api.github.com/users/boyusun-SAG/gists{/gist_id}","starred_url":"https://api.github.com/users/boyusun-SAG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boyusun-SAG/subscriptions","organizations_url":"https://api.github.com/users/boyusun-SAG/orgs","repos_url":"https://api.github.com/users/boyusun-SAG/repos","events_url":"https://api.github.com/users/boyusun-SAG/events{/privacy}","received_events_url":"https://api.github.com/users/boyusun-SAG/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/boyusun-SAG/tinypounder","description":"The TinyPounder is a GUI tool to test creation / removal / destroyal of Ehcache3 cache managers or caches AS WELL as TC Store datasets !","fork":true,"url":"https://api.github.com/repos/boyusun-SAG/tinypounder","forks_url":"https://api.github.com/repos/boyusun-SAG/tinypounder/forks","keys_url":"https://api.github.com/repos/boyusun-SAG/tinypounder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boyusun-SAG/tinypounder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boyusun-SAG/tinypounder/teams","hooks_url":"https://api.github.com/repos/boyusun-SAG/tinypounder/hooks","issue_events_url":"https://api.github.com/repos/boyusun-SAG/tinypounder/issues/events{/number}","events_url":"https://api.github.com/repos/boyusun-SAG/tinypounder/events","assignees_url":"https://api.github.com/repos/boyusun-SAG/tinypounder/assignees{/user}","branches_url":"https://api.github.com/repos/boyusun-SAG/tinypounder/branches{/branch}","tags_url":"https://api.github.com/repos/boyusun-SAG/tinypounder/tags","blobs_url":"https://api.github.com/repos/boyusun-SAG/tinypounder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boyusun-SAG/tinypounder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boyusun-SAG/tinypounder/git/refs{/sha}","trees_url":"https://api.github.com/repos/boyusun-SAG/tinypounder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boyusun-SAG/tinypounder/statuses/{sha}","languages_url":"https://api.github.com/repos/boyusun-SAG/tinypounder/languages","stargazers_url":"https://api.github.com/repos/boyusun-SAG/tinypounder/stargazers","contributors_url":"https://api.github.com/repos/boyusun-SAG/tinypounder/contributors","subscribers_url":"https://api.github.com/repos/boyusun-SAG/tinypounder/subscribers","subscription_url":"https://api.github.com/repos/boyusun-SAG/tinypounder/subscription","commits_url":"https://api.github.com/repos/boyusun-SAG/tinypounder/commits{/sha}","git_commits_url":"https://api.github.com/repos/boyusun-SAG/tinypounder/git/commits{/sha}","comments_url":"https://api.github.com/repos/boyusun-SAG/tinypounder/comments{/number}","issue_comment_url":"https://api.github.com/repos/boyusun-SAG/tinypounder/issues/comments{/number}","contents_url":"https://api.github.com/repos/boyusun-SAG/tinypounder/contents/{+path}","compare_url":"https://api.github.com/repos/boyusun-SAG/tinypounder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boyusun-SAG/tinypounder/merges","archive_url":"https://api.github.com/repos/boyusun-SAG/tinypounder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boyusun-SAG/tinypounder/downloads","issues_url":"https://api.github.com/repos/boyusun-SAG/tinypounder/issues{/number}","pulls_url":"https://api.github.com/repos/boyusun-SAG/tinypounder/pulls{/number}","milestones_url":"https://api.github.com/repos/boyusun-SAG/tinypounder/milestones{/number}","notifications_url":"https://api.github.com/repos/boyusun-SAG/tinypounder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boyusun-SAG/tinypounder/labels{/name}","releases_url":"https://api.github.com/repos/boyusun-SAG/tinypounder/releases{/id}","deployments_url":"https://api.github.com/repos/boyusun-SAG/tinypounder/deployments","created_at":"2018-01-24T00:35:59Z","updated_at":"2018-03-14T18:51:27Z","pushed_at":"2018-05-11T19:48:45Z","git_url":"git://github.com/boyusun-SAG/tinypounder.git","ssh_url":"[email protected]:boyusun-SAG/tinypounder.git","clone_url":"https://github.com/boyusun-SAG/tinypounder.git","svn_url":"https://github.com/boyusun-SAG/tinypounder","homepage":"http://www.terracotta.org","size":243,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Terracotta-OSS:master","ref":"master","sha":"6c5119dcefb20060b197c966eb99dccf199fdfef","user":{"login":"Terracotta-OSS","id":4680389,"avatar_url":"https://avatars3.githubusercontent.com/u/4680389?v=4","gravatar_id":"","url":"https://api.github.com/users/Terracotta-OSS","html_url":"https://github.com/Terracotta-OSS","followers_url":"https://api.github.com/users/Terracotta-OSS/followers","following_url":"https://api.github.com/users/Terracotta-OSS/following{/other_user}","gists_url":"https://api.github.com/users/Terracotta-OSS/gists{/gist_id}","starred_url":"https://api.github.com/users/Terracotta-OSS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Terracotta-OSS/subscriptions","organizations_url":"https://api.github.com/users/Terracotta-OSS/orgs","repos_url":"https://api.github.com/users/Terracotta-OSS/repos","events_url":"https://api.github.com/users/Terracotta-OSS/events{/privacy}","received_events_url":"https://api.github.com/users/Terracotta-OSS/received_events","type":"Organization","site_admin":false},"repo":{"id":94243498,"name":"tinypounder","full_name":"Terracotta-OSS/tinypounder","owner":{"login":"Terracotta-OSS","id":4680389,"avatar_url":"https://avatars3.githubusercontent.com/u/4680389?v=4","gravatar_id":"","url":"https://api.github.com/users/Terracotta-OSS","html_url":"https://github.com/Terracotta-OSS","followers_url":"https://api.github.com/users/Terracotta-OSS/followers","following_url":"https://api.github.com/users/Terracotta-OSS/following{/other_user}","gists_url":"https://api.github.com/users/Terracotta-OSS/gists{/gist_id}","starred_url":"https://api.github.com/users/Terracotta-OSS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Terracotta-OSS/subscriptions","organizations_url":"https://api.github.com/users/Terracotta-OSS/orgs","repos_url":"https://api.github.com/users/Terracotta-OSS/repos","events_url":"https://api.github.com/users/Terracotta-OSS/events{/privacy}","received_events_url":"https://api.github.com/users/Terracotta-OSS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Terracotta-OSS/tinypounder","description":"The TinyPounder is a GUI tool to test creation / removal / destroyal of Ehcache3 cache managers or caches AS WELL as TC Store datasets !","fork":false,"url":"https://api.github.com/repos/Terracotta-OSS/tinypounder","forks_url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/forks","keys_url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/teams","hooks_url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/hooks","issue_events_url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/issues/events{/number}","events_url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/events","assignees_url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/assignees{/user}","branches_url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/branches{/branch}","tags_url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/tags","blobs_url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/git/refs{/sha}","trees_url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/statuses/{sha}","languages_url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/languages","stargazers_url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/stargazers","contributors_url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/contributors","subscribers_url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/subscribers","subscription_url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/subscription","commits_url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/commits{/sha}","git_commits_url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/git/commits{/sha}","comments_url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/comments{/number}","issue_comment_url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/issues/comments{/number}","contents_url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/contents/{+path}","compare_url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/merges","archive_url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/downloads","issues_url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/issues{/number}","pulls_url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/pulls{/number}","milestones_url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/milestones{/number}","notifications_url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/labels{/name}","releases_url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/releases{/id}","deployments_url":"https://api.github.com/repos/Terracotta-OSS/tinypounder/deployments","created_at":"2017-06-13T18:14:55Z","updated_at":"2018-03-14T18:50:55Z","pushed_at":"2018-05-11T19:49:17Z","git_url":"git://github.com/Terracotta-OSS/tinypounder.git","ssh_url":"[email protected]:Terracotta-OSS/tinypounder.git","clone_url":"https://github.com/Terracotta-OSS/tinypounder.git","svn_url":"https://github.com/Terracotta-OSS/tinypounder","homepage":"http://www.terracotta.org","size":243,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":5,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Terracotta-OSS/tinypounder/pulls/37"},"html":{"href":"https://github.com/Terracotta-OSS/tinypounder/pull/37"},"issue":{"href":"https://api.github.com/repos/Terracotta-OSS/tinypounder/issues/37"},"comments":{"href":"https://api.github.com/repos/Terracotta-OSS/tinypounder/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/Terracotta-OSS/tinypounder/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/Terracotta-OSS/tinypounder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Terracotta-OSS/tinypounder/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/Terracotta-OSS/tinypounder/statuses/70b0a778e8da544876777f298b1866b05c3e21e0"}},"author_association":"CONTRIBUTOR"}} | {
"id": 94243498,
"name": "Terracotta-OSS/tinypounder",
"url": "https://api.github.com/repos/Terracotta-OSS/tinypounder"
} | {
"id": 60938,
"login": "anthonydahanne",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/60938?",
"url": "https://api.github.com/users/anthonydahanne"
} | {
"id": 4680389,
"login": "Terracotta-OSS",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4680389?",
"url": "https://api.github.com/orgs/Terracotta-OSS"
} | 2018-05-11T19:53:01 | 7663076965 | {"actor":{"display_login":"anthonydahanne"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/saltstack-formulas/packages-formula/pulls/comments/174238466","pull_request_review_id":103558099,"id":174238466,"diff_hunk":"@@ -21,3 +21,12 @@ packages:\n required:\n states: []\n pkgs: []\n+ snaps:\n+ package: snapd\n+ collides: ['snap',]","path":"packages/defaults.yaml","position":null,"original_position":6,"commit_id":"7092c456cffb1405b6f7097f29e72bc4b33d2018","original_commit_id":"4816786311e4a23893e60ff627a912dbbc45796e","user":{"login":"noelmcloughlin","id":13322818,"avatar_url":"https://avatars1.githubusercontent.com/u/13322818?v=4","gravatar_id":"","url":"https://api.github.com/users/noelmcloughlin","html_url":"https://github.com/noelmcloughlin","followers_url":"https://api.github.com/users/noelmcloughlin/followers","following_url":"https://api.github.com/users/noelmcloughlin/following{/other_user}","gists_url":"https://api.github.com/users/noelmcloughlin/gists{/gist_id}","starred_url":"https://api.github.com/users/noelmcloughlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noelmcloughlin/subscriptions","organizations_url":"https://api.github.com/users/noelmcloughlin/orgs","repos_url":"https://api.github.com/users/noelmcloughlin/repos","events_url":"https://api.github.com/users/noelmcloughlin/events{/privacy}","received_events_url":"https://api.github.com/users/noelmcloughlin/received_events","type":"User","site_admin":false},"body":"I tested on Ubuntu and no collision. Snap is not in OpenSUSE repo. snapd is not available for Centos yet.\r\n\r\nLooks like Fedora only issue. I have updated the commit accordingly.","created_at":"2018-03-13T18:26:28Z","updated_at":"2018-03-13T18:26:29Z","html_url":"https://github.com/saltstack-formulas/packages-formula/pull/13#discussion_r174238466","pull_request_url":"https://api.github.com/repos/saltstack-formulas/packages-formula/pulls/13","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/saltstack-formulas/packages-formula/pulls/comments/174238466"},"html":{"href":"https://github.com/saltstack-formulas/packages-formula/pull/13#discussion_r174238466"},"pull_request":{"href":"https://api.github.com/repos/saltstack-formulas/packages-formula/pulls/13"}},"in_reply_to_id":174201819},"pull_request":{"url":"https://api.github.com/repos/saltstack-formulas/packages-formula/pulls/13","id":174681073,"html_url":"https://github.com/saltstack-formulas/packages-formula/pull/13","diff_url":"https://github.com/saltstack-formulas/packages-formula/pull/13.diff","patch_url":"https://github.com/saltstack-formulas/packages-formula/pull/13.patch","issue_url":"https://api.github.com/repos/saltstack-formulas/packages-formula/issues/13","number":13,"state":"open","locked":false,"title":"Add support for snapd package manager","user":{"login":"noelmcloughlin","id":13322818,"avatar_url":"https://avatars1.githubusercontent.com/u/13322818?v=4","gravatar_id":"","url":"https://api.github.com/users/noelmcloughlin","html_url":"https://github.com/noelmcloughlin","followers_url":"https://api.github.com/users/noelmcloughlin/followers","following_url":"https://api.github.com/users/noelmcloughlin/following{/other_user}","gists_url":"https://api.github.com/users/noelmcloughlin/gists{/gist_id}","starred_url":"https://api.github.com/users/noelmcloughlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noelmcloughlin/subscriptions","organizations_url":"https://api.github.com/users/noelmcloughlin/orgs","repos_url":"https://api.github.com/users/noelmcloughlin/repos","events_url":"https://api.github.com/users/noelmcloughlin/events{/privacy}","received_events_url":"https://api.github.com/users/noelmcloughlin/received_events","type":"User","site_admin":false},"body":"This PR adds formula support for [snapd package manager](https://docs.snapcraft.io/core/snapd). \r\n\r\nVerified on Fedora:\r\n```\r\n$ sudo salt-call state.highstate --local\r\n[ERROR ] Command '['dnf', 'versionlock', 'list']' failed with return code: 1\r\n[ERROR ] output: No such command: versionlock. Please use /usr/bin/dnf --help\r\nIt could be a DNF plugin command, try: \"dnf install 'dnf-command(versionlock)'\"\r\n[ERROR ] Command '['dnf', 'versionlock', 'list']' failed with return code: 1\r\n[ERROR ] output: No such command: versionlock. Please use /usr/bin/dnf --help\r\nIt could be a DNF plugin command, try: \"dnf install 'dnf-command(versionlock)'\"\r\nlocal:\r\n----------\r\n ID: pkg_req_pkgs\r\n Function: pkg.installed\r\n Result: True\r\n Comment: The following packages were installed/updated: snapd\r\n Started: 10:15:09.328165\r\n Duration: 81800.251 ms\r\n Changes: \r\n ----------\r\n snap-confine:\r\n ----------\r\n new:\r\n 2.30-1.fc27\r\n old:\r\n snapd:\r\n ----------\r\n new:\r\n 2.30-1.fc27\r\n old:\r\n snapd-selinux:\r\n ----------\r\n new:\r\n 2.30-1.fc27\r\n old:\r\n squashfs-tools:\r\n ----------\r\n new:\r\n 4.3-15.fc27\r\n old:\r\n----------\r\n ID: wanted_pkgs\r\n Function: pkg.installed\r\n Result: True\r\n Comment: All specified packages are already installed.\r\n Package iptables is not being held..\r\n Package vim-minimal is not being held..\r\n Package lxde-common is not being held..\r\n Package redhat-lsb-core is not being held..\r\n Package python2-pip is not being held..\r\n Package ca-certificates is not being held.\r\n Started: 10:16:31.145721\r\n Duration: 326.031 ms\r\n Changes: \r\n----------\r\n ID: unwanted_pkgs\r\n Function: pkg.removed\r\n Result: True\r\n Comment: All specified packages are already absent\r\n Started: 10:16:31.472044\r\n Duration: 0.887 ms\r\n Changes: \r\n----------\r\n ID: pip_req_pkgs\r\n Function: pkg.installed\r\n Result: True\r\n Comment: All specified packages are already installed\r\n Started: 10:16:31.473074\r\n Duration: 0.696 ms\r\n Changes: \r\n----------\r\n ID: gem_req_pkgs\r\n Function: pkg.installed\r\n Result: True\r\n Comment: All specified packages are already installed\r\n Started: 10:16:31.473930\r\n Duration: 0.583 ms\r\n Changes: \r\n----------\r\n ID: packages-snapd.service-service\r\n Function: service.running\r\n Name: snapd.service\r\n Result: True\r\n Comment: Service snapd.service has been enabled, and is running\r\n Started: 10:16:31.980996\r\n Duration: 332.52 ms\r\n Changes: \r\n ----------\r\n snapd.service:\r\n True\r\n----------\r\n ID: packages-snapd.socket-service\r\n Function: service.running\r\n Name: snapd.socket\r\n Result: True\r\n Comment: The service snapd.socket is already running\r\n Started: 10:16:32.314073\r\n Duration: 40.829 ms\r\n Changes: \r\n----------\r\n ID: packages-snapd-hello-world-wanted\r\n Function: cmd.run\r\n Name: snap install hello-world\r\n Result: True\r\n Comment: Command \"snap install hello-world\" run\r\n Started: 10:16:32.356819\r\n Duration: 15161.719 ms\r\n Changes: \r\n ----------\r\n pid:\r\n 58238\r\n retcode:\r\n 0\r\n stderr:\r\n stdout:\r\n \r\n E?[7mnsure prerequisites for \"hello-world\" are availa?[0mble \r\n En?[7msure prerequisites for \"hello-world\" are availab?[0mle \r\n Fetc?[7mh and check assertions for snap \"core\" (4206) ?[0m \r\n Fetch?[7m and check assertions for snap \"core\" (4206) ?[0m \r\n Fetch a?[7mnd check assertions for snap \"core\" (4206) ?[0m \r\n Fetch an?[7md check assertions for snap \"core\" (4206) ?[0m \r\n Fetch and?[7m check assertions for snap \"core\" (4206) ?[0m \r\n Fetch and c?[7mheck assertions for snap \"core\" (4206) ?[0m \r\n Fetch and ch?[7meck assertions for snap \"core\" (4206) ?[0m \r\n Mount snap \"co?[7mre\" (4206) ?[0m \r\n Mount snap \"cor?[7me\" (4206) ?[0m \r\n Mount snap \"core\"?[7m (4206) ?[0m \r\n Mount snap \"core\" ?[7m(4206) ?[0m \r\n Setup snap \"core\" (?[7m4206) security profiles ?[0m \r\n Setup snap \"core\" (42?[7m06) security profiles (phase 2) ?[0m \r\n Setup snap \"core\" (420?[7m6) security profiles (phase 2) ?[0m \r\n ?[0m?[K2018-03-13T10:16:38-06:00 INFO Waiting for restart...\r\n \r\n Setup snap \"core\" (4206)?[7m security profiles (phase 2) ?[0m \r\n Setup snap \"core\" (4206) ?[7msecurity profiles (phase 2) ?[0m \r\n Setup snap \"core\" (4206) s?[7mecurity profiles (phase 2) ?[0m \r\n Setup snap \"core\" (4206) sec?[7murity profiles (phase 2) ?[0m \r\n Setup snap \"core\" (4206) secu?[7mrity profiles (phase 2) ?[0m \r\n Setup snap \"core\" (4206) securi?[7mty profiles (phase 2) ?[0m \r\n Setup snap \"core\" (4206) securit?[7my profiles (phase 2) ?[0m \r\n Setup snap \"core\" (4206) security ?[7mprofiles (phase 2) ?[0m \r\n Setup snap \"core\" (4206) security p?[7mrofiles (phase 2) ?[0m \r\n Setup snap \"core\" (4206) security pr?[7mofiles (phase 2) ?[0m \r\n Setup snap \"core\" (4206) security prof?[7miles (phase 2) ?[0m \r\n Setup snap \"core\" (4206) security profi?[7mles (phase 2) ?[0m \r\n Setup snap \"core\" (4206) security profile?[7ms (phase 2) ?[0m \r\n Setup snap \"core\" (4206) security profiles?[7m (phase 2) ?[0m \r\n Setup snap \"core\" (4206) security profiles (?[7mphase 2) ?[0m \r\n Setup snap \"core\" (4206) security profiles (p?[7mhase 2) ?[0m \r\n Setup snap \"core\" (4206) security profiles (ph?[7mase 2) ?[0m \r\n Setup snap \"core\" (4206) security profiles (phas?[7me 2) ?[0m \r\n Setup snap \"core\" (4206) security profiles (phase?[7m 2) ?[0m \r\n Setup snap \"core\" (4206) security profiles (phase 2?[7m) ?[0m \r\n Setup snap \"core\" (4206) security profiles (phase 2)?[7m ?[0m \r\n Setup snap \"core\" (4206) security profiles (phase 2) ?[7m ?[0m \r\n Setup snap \"core\" (4206) security profiles (phase 2) ?[7m ?[0m \r\n Setup snap \"core\" (4206) security profiles (phase 2) ?[7m ?[0m \r\n Setup snap \"core\" (4206) security profiles (phase 2) ?[7m ?[0m \r\n Setup snap \"core\" (4206) security profiles (phase 2) ?[7m ?[0m \r\n Setup snap \"core\" (4206) security profiles (phase 2) ?[7m ?[0m \r\n Setup snap \"core\" (4206) security profiles (phase 2) ?[7m ?[0m \r\n Setup snap \"core\" (4206) security profiles (phase 2) ?[7m ?[0m \r\n Setup snap \"core\" (4206) security profiles (phase 2) ?[7m ?[0m \r\n Setup snap \"core\" (4206) security profiles (phase 2) ?[7m ?[0m \r\n Setup snap \"core\" (4206) security profiles (phase 2) ?[7m ?[0m \r\n Setup snap \"core\" (4206) security profiles (phase 2) ?[7m ?[0m \r\n Setup snap \"core\" (4206) security profiles (phase 2) ?[7m ?[0m \r\n Setup snap \"core\" (4206) security profiles (phase 2) ?[7m ?[0m \r\n Setup snap \"core\" (4206) security profiles (phase 2) ?[7m ?[0m \r\n Setup snap \"core\" (4206) security profiles (phase 2) ?[7m ?[0m \r\n Setup snap \"core\" (4206) security profiles (phase 2) ?[7m ?[0m \r\n Setup snap \"core\" (4206) security profiles (phase 2) ?[7m ?[0m \r\n Setup snap \"core\" (4206) security profiles (phase 2) ?[7m ?[0m \r\n Setup snap \"core\" (4206) security profiles (phase 2) ?[7m ?[0m \r\n Setup snap \"core\" (4206) security profiles (phase 2) ?[7m ?[0m \r\n Setup snap \"core\" (4206) security profiles (phase 2) ?[7m ?[0m \r\n Setup snap \"core\" (4206) security profiles (phase 2) ?[7m ?[0m \r\n Setup snap \"core\" (4206) security profiles (phase 2) ?[7m ?[0m \r\n Setup snap \"core\" (4206) security profiles (phase 2) ?[7m ?[0m \r\n Setup snap \"core\" (4206) security profiles (phase 2) ?[7m ?[0m \r\n Setup snap \"core\" (4206) security profiles (phase 2) ?[7m ?[0m \r\n Setup snap \"core\" (4206) security profiles (phase 2) ?[7m ?[0m \r\n Setup snap \"core\" (4206) security profiles (phase 2) ?[7m ?[0m \r\n Setup snap \"core\" (4206) security profiles (phase 2) ?[7m ?[0m \r\n Setup snap \"core\" (4206) security profiles (phase 2) ?[7m ?[0m \r\n Setup snap \"core\" (4206) security profiles (phase 2) ?[7m ?[0m \r\n Set automatic aliases for snap \"core\" ?[7m ?[0m \r\n Fetch and check assertions for snap \"hello-world\" (27) ?[7m ?[0m \r\n Fetch and check assertions for snap \"hello-world\" (27) ?[7m ?[0m \r\n Fetch and check assertions for snap \"hello-world\" (27) ?[7m ?[0m \r\n Fetch and check assertions for snap \"hello-world\" (27) ?[7m ?[0m \r\n Fetch and check assertions for snap \"hello-world\" (27) ?[7m ?[0m \r\n Fetch and check assertions for snap \"hello-world\" (27) ?[7m ?[0m \r\n Fetch and check assertions for snap \"hello-world\" (27) ?[7m ?[0m \r\n Fetch and check assertions for snap \"hello-world\" (27) ?[7m ?[0m \r\n Fetch and check assertions for snap \"hello-world\" (27) ?[7m ?[0m \r\n Mount snap \"hello-world\" (27) ?[7m ?[0m \r\n Mount snap \"hello-world\" (27) ?[7m ?[0m \r\n Mount snap \"hello-world\" (27) ?[7m ?[0m \r\n Setup snap \"hello-world\" (27) security profiles ?[7m ?[0m \r\n Setup snap \"hello-world\" (27) security profiles ?[7m ?[0m \r\n Setup snap \"hello-world\" (27) security profiles ?[7m ?[0m \r\n Setup snap \"hello-world\" (27) security profiles ?[7m ?[0m \r\n Set automatic aliases for snap \"hello-world\" ?[7m ?[0m \r\n ?[0m?[?12;25h?[Khello-world 6.3 from 'canonical' installed\r\n----------\r\n ID: packages-snapd-goodbye-world-unwanted\r\n Function: cmd.run\r\n Name: snap remove goodbye-world\r\n Result: True\r\n Comment: onlyif execution failed\r\n Started: 10:16:47.519558\r\n Duration: 38.403 ms\r\n Changes: \r\n\r\nSummary for local\r\n------------\r\nSucceeded: 9 (changed=3)\r\nFailed: 0\r\n------------\r\nTotal states run: 9\r\nTotal run time: 97.702 s\r\n```","created_at":"2018-03-13T14:40:12Z","updated_at":"2018-03-13T18:26:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"24581e3b22d972627b851a9dec92b167d61c5f9b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":838206073,"url":"https://api.github.com/repos/saltstack-formulas/packages-formula/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/saltstack-formulas/packages-formula/pulls/13/commits","review_comments_url":"https://api.github.com/repos/saltstack-formulas/packages-formula/pulls/13/comments","review_comment_url":"https://api.github.com/repos/saltstack-formulas/packages-formula/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack-formulas/packages-formula/issues/13/comments","statuses_url":"https://api.github.com/repos/saltstack-formulas/packages-formula/statuses/7092c456cffb1405b6f7097f29e72bc4b33d2018","head":{"label":"noelmcloughlin:snapd_support","ref":"snapd_support","sha":"7092c456cffb1405b6f7097f29e72bc4b33d2018","user":{"login":"noelmcloughlin","id":13322818,"avatar_url":"https://avatars1.githubusercontent.com/u/13322818?v=4","gravatar_id":"","url":"https://api.github.com/users/noelmcloughlin","html_url":"https://github.com/noelmcloughlin","followers_url":"https://api.github.com/users/noelmcloughlin/followers","following_url":"https://api.github.com/users/noelmcloughlin/following{/other_user}","gists_url":"https://api.github.com/users/noelmcloughlin/gists{/gist_id}","starred_url":"https://api.github.com/users/noelmcloughlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noelmcloughlin/subscriptions","organizations_url":"https://api.github.com/users/noelmcloughlin/orgs","repos_url":"https://api.github.com/users/noelmcloughlin/repos","events_url":"https://api.github.com/users/noelmcloughlin/events{/privacy}","received_events_url":"https://api.github.com/users/noelmcloughlin/received_events","type":"User","site_admin":false},"repo":{"id":121660390,"name":"packages-formula","full_name":"noelmcloughlin/packages-formula","owner":{"login":"noelmcloughlin","id":13322818,"avatar_url":"https://avatars1.githubusercontent.com/u/13322818?v=4","gravatar_id":"","url":"https://api.github.com/users/noelmcloughlin","html_url":"https://github.com/noelmcloughlin","followers_url":"https://api.github.com/users/noelmcloughlin/followers","following_url":"https://api.github.com/users/noelmcloughlin/following{/other_user}","gists_url":"https://api.github.com/users/noelmcloughlin/gists{/gist_id}","starred_url":"https://api.github.com/users/noelmcloughlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noelmcloughlin/subscriptions","organizations_url":"https://api.github.com/users/noelmcloughlin/orgs","repos_url":"https://api.github.com/users/noelmcloughlin/repos","events_url":"https://api.github.com/users/noelmcloughlin/events{/privacy}","received_events_url":"https://api.github.com/users/noelmcloughlin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/noelmcloughlin/packages-formula","description":"A simple 'packages manager' formula, to install/remove packages without further ado.","fork":true,"url":"https://api.github.com/repos/noelmcloughlin/packages-formula","forks_url":"https://api.github.com/repos/noelmcloughlin/packages-formula/forks","keys_url":"https://api.github.com/repos/noelmcloughlin/packages-formula/keys{/key_id}","collaborators_url":"https://api.github.com/repos/noelmcloughlin/packages-formula/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/noelmcloughlin/packages-formula/teams","hooks_url":"https://api.github.com/repos/noelmcloughlin/packages-formula/hooks","issue_events_url":"https://api.github.com/repos/noelmcloughlin/packages-formula/issues/events{/number}","events_url":"https://api.github.com/repos/noelmcloughlin/packages-formula/events","assignees_url":"https://api.github.com/repos/noelmcloughlin/packages-formula/assignees{/user}","branches_url":"https://api.github.com/repos/noelmcloughlin/packages-formula/branches{/branch}","tags_url":"https://api.github.com/repos/noelmcloughlin/packages-formula/tags","blobs_url":"https://api.github.com/repos/noelmcloughlin/packages-formula/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/noelmcloughlin/packages-formula/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/noelmcloughlin/packages-formula/git/refs{/sha}","trees_url":"https://api.github.com/repos/noelmcloughlin/packages-formula/git/trees{/sha}","statuses_url":"https://api.github.com/repos/noelmcloughlin/packages-formula/statuses/{sha}","languages_url":"https://api.github.com/repos/noelmcloughlin/packages-formula/languages","stargazers_url":"https://api.github.com/repos/noelmcloughlin/packages-formula/stargazers","contributors_url":"https://api.github.com/repos/noelmcloughlin/packages-formula/contributors","subscribers_url":"https://api.github.com/repos/noelmcloughlin/packages-formula/subscribers","subscription_url":"https://api.github.com/repos/noelmcloughlin/packages-formula/subscription","commits_url":"https://api.github.com/repos/noelmcloughlin/packages-formula/commits{/sha}","git_commits_url":"https://api.github.com/repos/noelmcloughlin/packages-formula/git/commits{/sha}","comments_url":"https://api.github.com/repos/noelmcloughlin/packages-formula/comments{/number}","issue_comment_url":"https://api.github.com/repos/noelmcloughlin/packages-formula/issues/comments{/number}","contents_url":"https://api.github.com/repos/noelmcloughlin/packages-formula/contents/{+path}","compare_url":"https://api.github.com/repos/noelmcloughlin/packages-formula/compare/{base}...{head}","merges_url":"https://api.github.com/repos/noelmcloughlin/packages-formula/merges","archive_url":"https://api.github.com/repos/noelmcloughlin/packages-formula/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/noelmcloughlin/packages-formula/downloads","issues_url":"https://api.github.com/repos/noelmcloughlin/packages-formula/issues{/number}","pulls_url":"https://api.github.com/repos/noelmcloughlin/packages-formula/pulls{/number}","milestones_url":"https://api.github.com/repos/noelmcloughlin/packages-formula/milestones{/number}","notifications_url":"https://api.github.com/repos/noelmcloughlin/packages-formula/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/noelmcloughlin/packages-formula/labels{/name}","releases_url":"https://api.github.com/repos/noelmcloughlin/packages-formula/releases{/id}","deployments_url":"https://api.github.com/repos/noelmcloughlin/packages-formula/deployments","created_at":"2018-02-15T17:42:13Z","updated_at":"2018-02-15T17:42:15Z","pushed_at":"2018-03-13T18:24:39Z","git_url":"git://github.com/noelmcloughlin/packages-formula.git","ssh_url":"[email protected]:noelmcloughlin/packages-formula.git","clone_url":"https://github.com/noelmcloughlin/packages-formula.git","svn_url":"https://github.com/noelmcloughlin/packages-formula","homepage":null,"size":27,"stargazers_count":0,"watchers_count":0,"language":"SaltStack","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"saltstack-formulas:master","ref":"master","sha":"4a404cb6e88c1f7a5788e4106ecba05086bbc9c6","user":{"login":"saltstack-formulas","id":4683350,"avatar_url":"https://avatars3.githubusercontent.com/u/4683350?v=4","gravatar_id":"","url":"https://api.github.com/users/saltstack-formulas","html_url":"https://github.com/saltstack-formulas","followers_url":"https://api.github.com/users/saltstack-formulas/followers","following_url":"https://api.github.com/users/saltstack-formulas/following{/other_user}","gists_url":"https://api.github.com/users/saltstack-formulas/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack-formulas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack-formulas/subscriptions","organizations_url":"https://api.github.com/users/saltstack-formulas/orgs","repos_url":"https://api.github.com/users/saltstack-formulas/repos","events_url":"https://api.github.com/users/saltstack-formulas/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack-formulas/received_events","type":"Organization","site_admin":false},"repo":{"id":121636410,"name":"packages-formula","full_name":"saltstack-formulas/packages-formula","owner":{"login":"saltstack-formulas","id":4683350,"avatar_url":"https://avatars3.githubusercontent.com/u/4683350?v=4","gravatar_id":"","url":"https://api.github.com/users/saltstack-formulas","html_url":"https://github.com/saltstack-formulas","followers_url":"https://api.github.com/users/saltstack-formulas/followers","following_url":"https://api.github.com/users/saltstack-formulas/following{/other_user}","gists_url":"https://api.github.com/users/saltstack-formulas/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack-formulas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack-formulas/subscriptions","organizations_url":"https://api.github.com/users/saltstack-formulas/orgs","repos_url":"https://api.github.com/users/saltstack-formulas/repos","events_url":"https://api.github.com/users/saltstack-formulas/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack-formulas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack-formulas/packages-formula","description":"A simple 'packages manager' formula, to install/remove packages without further ado.","fork":false,"url":"https://api.github.com/repos/saltstack-formulas/packages-formula","forks_url":"https://api.github.com/repos/saltstack-formulas/packages-formula/forks","keys_url":"https://api.github.com/repos/saltstack-formulas/packages-formula/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack-formulas/packages-formula/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack-formulas/packages-formula/teams","hooks_url":"https://api.github.com/repos/saltstack-formulas/packages-formula/hooks","issue_events_url":"https://api.github.com/repos/saltstack-formulas/packages-formula/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack-formulas/packages-formula/events","assignees_url":"https://api.github.com/repos/saltstack-formulas/packages-formula/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack-formulas/packages-formula/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack-formulas/packages-formula/tags","blobs_url":"https://api.github.com/repos/saltstack-formulas/packages-formula/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack-formulas/packages-formula/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack-formulas/packages-formula/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack-formulas/packages-formula/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack-formulas/packages-formula/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack-formulas/packages-formula/languages","stargazers_url":"https://api.github.com/repos/saltstack-formulas/packages-formula/stargazers","contributors_url":"https://api.github.com/repos/saltstack-formulas/packages-formula/contributors","subscribers_url":"https://api.github.com/repos/saltstack-formulas/packages-formula/subscribers","subscription_url":"https://api.github.com/repos/saltstack-formulas/packages-formula/subscription","commits_url":"https://api.github.com/repos/saltstack-formulas/packages-formula/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack-formulas/packages-formula/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack-formulas/packages-formula/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack-formulas/packages-formula/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack-formulas/packages-formula/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack-formulas/packages-formula/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack-formulas/packages-formula/merges","archive_url":"https://api.github.com/repos/saltstack-formulas/packages-formula/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack-formulas/packages-formula/downloads","issues_url":"https://api.github.com/repos/saltstack-formulas/packages-formula/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack-formulas/packages-formula/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack-formulas/packages-formula/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack-formulas/packages-formula/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack-formulas/packages-formula/labels{/name}","releases_url":"https://api.github.com/repos/saltstack-formulas/packages-formula/releases{/id}","deployments_url":"https://api.github.com/repos/saltstack-formulas/packages-formula/deployments","created_at":"2018-02-15T14:03:21Z","updated_at":"2018-02-15T14:52:16Z","pushed_at":"2018-03-13T18:24:41Z","git_url":"git://github.com/saltstack-formulas/packages-formula.git","ssh_url":"[email protected]:saltstack-formulas/packages-formula.git","clone_url":"https://github.com/saltstack-formulas/packages-formula.git","svn_url":"https://github.com/saltstack-formulas/packages-formula","homepage":null,"size":28,"stargazers_count":0,"watchers_count":0,"language":"SaltStack","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":4,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack-formulas/packages-formula/pulls/13"},"html":{"href":"https://github.com/saltstack-formulas/packages-formula/pull/13"},"issue":{"href":"https://api.github.com/repos/saltstack-formulas/packages-formula/issues/13"},"comments":{"href":"https://api.github.com/repos/saltstack-formulas/packages-formula/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack-formulas/packages-formula/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack-formulas/packages-formula/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack-formulas/packages-formula/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack-formulas/packages-formula/statuses/7092c456cffb1405b6f7097f29e72bc4b33d2018"}},"author_association":"MEMBER"}} | {
"id": 121636410,
"name": "saltstack-formulas/packages-formula",
"url": "https://api.github.com/repos/saltstack-formulas/packages-formula"
} | {
"id": 13322818,
"login": "noelmcloughlin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13322818?",
"url": "https://api.github.com/users/noelmcloughlin"
} | {
"id": 4683350,
"login": "saltstack-formulas",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4683350?",
"url": "https://api.github.com/orgs/saltstack-formulas"
} | 2018-03-13T18:26:28 | 7373844973 | {"actor":{"display_login":"noelmcloughlin"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/comments/198681117","pull_request_review_id":132655738,"id":198681117,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODY4MTExNw==","diff_hunk":"@@ -681,10 +681,9 @@ public function category() {\n \n \t\t$terms = get_the_category();\n \n-\t\tif ( ! is_wp_error( $terms ) && ( is_array( $terms ) && $terms !== array() ) ) {\n+\t\tif ( ! is_wp_error( $terms ) && is_array( $terms ) && ! empty( $terms ) ) {\n \t\t\t// We can only show one section here, so we take the first one.\n-\t\t\t$this->og_tag( 'article:section', $terms[0]->name );\n-\n+\t\t\t$this->og_tag( 'article:section', reset( $terms )->name );","path":"frontend/class-opengraph.php","position":null,"original_position":9,"commit_id":"4448f53d3d37ec609d415ac7b1437cbac2347930","original_commit_id":"6dfee441892d363159a04b9c6b831b6fc66d51d7","user":{"login":"mikeschinkel","id":153285,"node_id":"MDQ6VXNlcjE1MzI4NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/153285?v=4","gravatar_id":"","url":"https://api.github.com/users/mikeschinkel","html_url":"https://github.com/mikeschinkel","followers_url":"https://api.github.com/users/mikeschinkel/followers","following_url":"https://api.github.com/users/mikeschinkel/following{/other_user}","gists_url":"https://api.github.com/users/mikeschinkel/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeschinkel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeschinkel/subscriptions","organizations_url":"https://api.github.com/users/mikeschinkel/orgs","repos_url":"https://api.github.com/users/mikeschinkel/repos","events_url":"https://api.github.com/users/mikeschinkel/events{/privacy}","received_events_url":"https://api.github.com/users/mikeschinkel/received_events","type":"User","site_admin":false},"body":"Done.\r\n","created_at":"2018-06-28T00:44:13Z","updated_at":"2018-06-28T00:44:13Z","html_url":"https://github.com/Yoast/wordpress-seo/pull/10122#discussion_r198681117","pull_request_url":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/10122","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/comments/198681117"},"html":{"href":"https://github.com/Yoast/wordpress-seo/pull/10122#discussion_r198681117"},"pull_request":{"href":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/10122"}},"in_reply_to_id":198458395},"pull_request":{"url":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/10122","id":196921646,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2OTIxNjQ2","html_url":"https://github.com/Yoast/wordpress-seo/pull/10122","diff_url":"https://github.com/Yoast/wordpress-seo/pull/10122.diff","patch_url":"https://github.com/Yoast/wordpress-seo/pull/10122.patch","issue_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/10122","number":10122,"state":"open","locked":false,"title":"Fix error when $terms[0] does not exist in open-graph","user":{"login":"mikeschinkel","id":153285,"node_id":"MDQ6VXNlcjE1MzI4NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/153285?v=4","gravatar_id":"","url":"https://api.github.com/users/mikeschinkel","html_url":"https://github.com/mikeschinkel","followers_url":"https://api.github.com/users/mikeschinkel/followers","following_url":"https://api.github.com/users/mikeschinkel/following{/other_user}","gists_url":"https://api.github.com/users/mikeschinkel/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeschinkel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeschinkel/subscriptions","organizations_url":"https://api.github.com/users/mikeschinkel/orgs","repos_url":"https://api.github.com/users/mikeschinkel/repos","events_url":"https://api.github.com/users/mikeschinkel/events{/privacy}","received_events_url":"https://api.github.com/users/mikeschinkel/received_events","type":"User","site_admin":false},"body":"## Summary\r\n\r\nThis PR can be summarized in the following changelog entry:\r\n\r\n* Fix error when $terms[0] does not exist (such as when there is only $terms[1].)\r\n\r\n## Relevant technical choices:\r\n\r\n* Use `reset($terms)->name` instead of `$terms[0]->name` because the first element may be `$terms[1]`.\r\n* Use `!empty($terms)` instead of `$terms !== array()` because it is clearer.\r\n\r\n## Test instructions\r\n\r\nThis PR can be tested by following these steps:\r\n\r\n* Select more than more category. \r\n* Do NOT set a Primary category\r\n* Add `'get_the_categories'` filter that unsets `$term[0]` _(as a commercial theme a client was using does. It removes parent categories if child categories are selected.)_\r\n\r\n## Quality assurance\r\n\r\n* [X] I have tested this code to the best of my abilities\r\n* [ ] I have added unittests to verify the code works as intended\r\n\r\nFixes #\r\n","created_at":"2018-06-23T21:37:53Z","updated_at":"2018-06-28T00:44:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"19f72ea0cae981b0fdb426e73a36eb25f4670404","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":267593824,"node_id":"MDU6TGFiZWwyNjc1OTM4MjQ=","url":"https://api.github.com/repos/Yoast/wordpress-seo/labels/community-patch","name":"community-patch","color":"78BDF2","default":false},{"id":665788661,"node_id":"MDU6TGFiZWw2NjU3ODg2NjE=","url":"https://api.github.com/repos/Yoast/wordpress-seo/labels/needs-changes","name":"needs-changes","color":"78BDF2","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/10122/commits","review_comments_url":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/10122/comments","review_comment_url":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/10122/comments","statuses_url":"https://api.github.com/repos/Yoast/wordpress-seo/statuses/4448f53d3d37ec609d415ac7b1437cbac2347930","head":{"label":"newclarity:newclarity-patch-1","ref":"newclarity-patch-1","sha":"4448f53d3d37ec609d415ac7b1437cbac2347930","user":{"login":"newclarity","id":1221428,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMjE0Mjg=","avatar_url":"https://avatars3.githubusercontent.com/u/1221428?v=4","gravatar_id":"","url":"https://api.github.com/users/newclarity","html_url":"https://github.com/newclarity","followers_url":"https://api.github.com/users/newclarity/followers","following_url":"https://api.github.com/users/newclarity/following{/other_user}","gists_url":"https://api.github.com/users/newclarity/gists{/gist_id}","starred_url":"https://api.github.com/users/newclarity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newclarity/subscriptions","organizations_url":"https://api.github.com/users/newclarity/orgs","repos_url":"https://api.github.com/users/newclarity/repos","events_url":"https://api.github.com/users/newclarity/events{/privacy}","received_events_url":"https://api.github.com/users/newclarity/received_events","type":"Organization","site_admin":false},"repo":{"id":138431449,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg0MzE0NDk=","name":"wordpress-seo","full_name":"newclarity/wordpress-seo","owner":{"login":"newclarity","id":1221428,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMjE0Mjg=","avatar_url":"https://avatars3.githubusercontent.com/u/1221428?v=4","gravatar_id":"","url":"https://api.github.com/users/newclarity","html_url":"https://github.com/newclarity","followers_url":"https://api.github.com/users/newclarity/followers","following_url":"https://api.github.com/users/newclarity/following{/other_user}","gists_url":"https://api.github.com/users/newclarity/gists{/gist_id}","starred_url":"https://api.github.com/users/newclarity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newclarity/subscriptions","organizations_url":"https://api.github.com/users/newclarity/orgs","repos_url":"https://api.github.com/users/newclarity/repos","events_url":"https://api.github.com/users/newclarity/events{/privacy}","received_events_url":"https://api.github.com/users/newclarity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/newclarity/wordpress-seo","description":"Yoast SEO for WordPress","fork":true,"url":"https://api.github.com/repos/newclarity/wordpress-seo","forks_url":"https://api.github.com/repos/newclarity/wordpress-seo/forks","keys_url":"https://api.github.com/repos/newclarity/wordpress-seo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/newclarity/wordpress-seo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/newclarity/wordpress-seo/teams","hooks_url":"https://api.github.com/repos/newclarity/wordpress-seo/hooks","issue_events_url":"https://api.github.com/repos/newclarity/wordpress-seo/issues/events{/number}","events_url":"https://api.github.com/repos/newclarity/wordpress-seo/events","assignees_url":"https://api.github.com/repos/newclarity/wordpress-seo/assignees{/user}","branches_url":"https://api.github.com/repos/newclarity/wordpress-seo/branches{/branch}","tags_url":"https://api.github.com/repos/newclarity/wordpress-seo/tags","blobs_url":"https://api.github.com/repos/newclarity/wordpress-seo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/newclarity/wordpress-seo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/newclarity/wordpress-seo/git/refs{/sha}","trees_url":"https://api.github.com/repos/newclarity/wordpress-seo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/newclarity/wordpress-seo/statuses/{sha}","languages_url":"https://api.github.com/repos/newclarity/wordpress-seo/languages","stargazers_url":"https://api.github.com/repos/newclarity/wordpress-seo/stargazers","contributors_url":"https://api.github.com/repos/newclarity/wordpress-seo/contributors","subscribers_url":"https://api.github.com/repos/newclarity/wordpress-seo/subscribers","subscription_url":"https://api.github.com/repos/newclarity/wordpress-seo/subscription","commits_url":"https://api.github.com/repos/newclarity/wordpress-seo/commits{/sha}","git_commits_url":"https://api.github.com/repos/newclarity/wordpress-seo/git/commits{/sha}","comments_url":"https://api.github.com/repos/newclarity/wordpress-seo/comments{/number}","issue_comment_url":"https://api.github.com/repos/newclarity/wordpress-seo/issues/comments{/number}","contents_url":"https://api.github.com/repos/newclarity/wordpress-seo/contents/{+path}","compare_url":"https://api.github.com/repos/newclarity/wordpress-seo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/newclarity/wordpress-seo/merges","archive_url":"https://api.github.com/repos/newclarity/wordpress-seo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/newclarity/wordpress-seo/downloads","issues_url":"https://api.github.com/repos/newclarity/wordpress-seo/issues{/number}","pulls_url":"https://api.github.com/repos/newclarity/wordpress-seo/pulls{/number}","milestones_url":"https://api.github.com/repos/newclarity/wordpress-seo/milestones{/number}","notifications_url":"https://api.github.com/repos/newclarity/wordpress-seo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/newclarity/wordpress-seo/labels{/name}","releases_url":"https://api.github.com/repos/newclarity/wordpress-seo/releases{/id}","deployments_url":"https://api.github.com/repos/newclarity/wordpress-seo/deployments","created_at":"2018-06-23T20:29:18Z","updated_at":"2018-06-23T20:29:22Z","pushed_at":"2018-06-28T00:43:48Z","git_url":"git://github.com/newclarity/wordpress-seo.git","ssh_url":"[email protected]:newclarity/wordpress-seo.git","clone_url":"https://github.com/newclarity/wordpress-seo.git","svn_url":"https://github.com/newclarity/wordpress-seo","homepage":"http://yoast.com/wordpress/seo/","size":279307,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"Yoast:master","ref":"master","sha":"c02527a491407c689c3af50a3b26b16a0a753e09","user":{"login":"Yoast","id":4690436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2OTA0MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/4690436?v=4","gravatar_id":"","url":"https://api.github.com/users/Yoast","html_url":"https://github.com/Yoast","followers_url":"https://api.github.com/users/Yoast/followers","following_url":"https://api.github.com/users/Yoast/following{/other_user}","gists_url":"https://api.github.com/users/Yoast/gists{/gist_id}","starred_url":"https://api.github.com/users/Yoast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yoast/subscriptions","organizations_url":"https://api.github.com/users/Yoast/orgs","repos_url":"https://api.github.com/users/Yoast/repos","events_url":"https://api.github.com/users/Yoast/events{/privacy}","received_events_url":"https://api.github.com/users/Yoast/received_events","type":"Organization","site_admin":false},"repo":{"id":6723399,"node_id":"MDEwOlJlcG9zaXRvcnk2NzIzMzk5","name":"wordpress-seo","full_name":"Yoast/wordpress-seo","owner":{"login":"Yoast","id":4690436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2OTA0MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/4690436?v=4","gravatar_id":"","url":"https://api.github.com/users/Yoast","html_url":"https://github.com/Yoast","followers_url":"https://api.github.com/users/Yoast/followers","following_url":"https://api.github.com/users/Yoast/following{/other_user}","gists_url":"https://api.github.com/users/Yoast/gists{/gist_id}","starred_url":"https://api.github.com/users/Yoast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yoast/subscriptions","organizations_url":"https://api.github.com/users/Yoast/orgs","repos_url":"https://api.github.com/users/Yoast/repos","events_url":"https://api.github.com/users/Yoast/events{/privacy}","received_events_url":"https://api.github.com/users/Yoast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yoast/wordpress-seo","description":"Yoast SEO for WordPress","fork":false,"url":"https://api.github.com/repos/Yoast/wordpress-seo","forks_url":"https://api.github.com/repos/Yoast/wordpress-seo/forks","keys_url":"https://api.github.com/repos/Yoast/wordpress-seo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yoast/wordpress-seo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yoast/wordpress-seo/teams","hooks_url":"https://api.github.com/repos/Yoast/wordpress-seo/hooks","issue_events_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/events{/number}","events_url":"https://api.github.com/repos/Yoast/wordpress-seo/events","assignees_url":"https://api.github.com/repos/Yoast/wordpress-seo/assignees{/user}","branches_url":"https://api.github.com/repos/Yoast/wordpress-seo/branches{/branch}","tags_url":"https://api.github.com/repos/Yoast/wordpress-seo/tags","blobs_url":"https://api.github.com/repos/Yoast/wordpress-seo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yoast/wordpress-seo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yoast/wordpress-seo/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yoast/wordpress-seo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yoast/wordpress-seo/statuses/{sha}","languages_url":"https://api.github.com/repos/Yoast/wordpress-seo/languages","stargazers_url":"https://api.github.com/repos/Yoast/wordpress-seo/stargazers","contributors_url":"https://api.github.com/repos/Yoast/wordpress-seo/contributors","subscribers_url":"https://api.github.com/repos/Yoast/wordpress-seo/subscribers","subscription_url":"https://api.github.com/repos/Yoast/wordpress-seo/subscription","commits_url":"https://api.github.com/repos/Yoast/wordpress-seo/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yoast/wordpress-seo/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yoast/wordpress-seo/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yoast/wordpress-seo/contents/{+path}","compare_url":"https://api.github.com/repos/Yoast/wordpress-seo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yoast/wordpress-seo/merges","archive_url":"https://api.github.com/repos/Yoast/wordpress-seo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yoast/wordpress-seo/downloads","issues_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues{/number}","pulls_url":"https://api.github.com/repos/Yoast/wordpress-seo/pulls{/number}","milestones_url":"https://api.github.com/repos/Yoast/wordpress-seo/milestones{/number}","notifications_url":"https://api.github.com/repos/Yoast/wordpress-seo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yoast/wordpress-seo/labels{/name}","releases_url":"https://api.github.com/repos/Yoast/wordpress-seo/releases{/id}","deployments_url":"https://api.github.com/repos/Yoast/wordpress-seo/deployments","created_at":"2012-11-16T15:16:29Z","updated_at":"2018-06-27T13:34:54Z","pushed_at":"2018-06-28T00:43:52Z","git_url":"git://github.com/Yoast/wordpress-seo.git","ssh_url":"[email protected]:Yoast/wordpress-seo.git","clone_url":"https://github.com/Yoast/wordpress-seo.git","svn_url":"https://github.com/Yoast/wordpress-seo","homepage":"http://yoast.com/wordpress/seo/","size":290977,"stargazers_count":908,"watchers_count":908,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":531,"mirror_url":null,"archived":false,"open_issues_count":1079,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":531,"open_issues":1079,"watchers":908,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/10122"},"html":{"href":"https://github.com/Yoast/wordpress-seo/pull/10122"},"issue":{"href":"https://api.github.com/repos/Yoast/wordpress-seo/issues/10122"},"comments":{"href":"https://api.github.com/repos/Yoast/wordpress-seo/issues/10122/comments"},"review_comments":{"href":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/10122/comments"},"review_comment":{"href":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/10122/commits"},"statuses":{"href":"https://api.github.com/repos/Yoast/wordpress-seo/statuses/4448f53d3d37ec609d415ac7b1437cbac2347930"}},"author_association":"NONE"}} | {
"id": 6723399,
"name": "Yoast/wordpress-seo",
"url": "https://api.github.com/repos/Yoast/wordpress-seo"
} | {
"id": 153285,
"login": "mikeschinkel",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/153285?",
"url": "https://api.github.com/users/mikeschinkel"
} | {
"id": 4690436,
"login": "Yoast",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4690436?",
"url": "https://api.github.com/orgs/Yoast"
} | 2018-06-28T00:44:13 | 7888918571 | {"actor":{"display_login":"mikeschinkel"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/zulip/zulip-electron/pulls/comments/204738425","pull_request_review_id":139869152,"id":204738425,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDczODQyNQ==","diff_hunk":"@@ -0,0 +1,185 @@\n+{\n+ \"name\": \"zulip\",\n+ \"productName\": \"ZulipTest\",\n+ \"version\": \"2.3.3\",\n+ \"main\": \"../app/main\",\n+ \"description\": \"Zulip Desktop App\",","path":"tests/package.json","position":6,"original_position":6,"commit_id":"3e4a8c6c8b4d3904fd92542a03ef8e817416b679","original_commit_id":"3e4a8c6c8b4d3904fd92542a03ef8e817416b679","user":{"login":"priyankp10","id":23620441,"node_id":"MDQ6VXNlcjIzNjIwNDQx","avatar_url":"https://avatars2.githubusercontent.com/u/23620441?v=4","gravatar_id":"","url":"https://api.github.com/users/priyankp10","html_url":"https://github.com/priyankp10","followers_url":"https://api.github.com/users/priyankp10/followers","following_url":"https://api.github.com/users/priyankp10/following{/other_user}","gists_url":"https://api.github.com/users/priyankp10/gists{/gist_id}","starred_url":"https://api.github.com/users/priyankp10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/priyankp10/subscriptions","organizations_url":"https://api.github.com/users/priyankp10/orgs","repos_url":"https://api.github.com/users/priyankp10/repos","events_url":"https://api.github.com/users/priyankp10/events{/privacy}","received_events_url":"https://api.github.com/users/priyankp10/received_events","type":"User","site_admin":false},"body":"For making the electron app use the `ZulipTest` app temp directory and the `../app/main` entry point only `productName`, `name` and `version` are required, you can remove other stuff.","created_at":"2018-07-24T12:40:20Z","updated_at":"2018-07-24T12:40:52Z","html_url":"https://github.com/zulip/zulip-electron/pull/526#discussion_r204738425","pull_request_url":"https://api.github.com/repos/zulip/zulip-electron/pulls/526","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/zulip/zulip-electron/pulls/comments/204738425"},"html":{"href":"https://github.com/zulip/zulip-electron/pull/526#discussion_r204738425"},"pull_request":{"href":"https://api.github.com/repos/zulip/zulip-electron/pulls/526"}}},"pull_request":{"url":"https://api.github.com/repos/zulip/zulip-electron/pulls/526","id":203436344,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNDM2MzQ0","html_url":"https://github.com/zulip/zulip-electron/pull/526","diff_url":"https://github.com/zulip/zulip-electron/pull/526.diff","patch_url":"https://github.com/zulip/zulip-electron/pull/526.patch","issue_url":"https://api.github.com/repos/zulip/zulip-electron/issues/526","number":526,"state":"open","locked":false,"title":"[WIP] Setup karma unit tests","user":{"login":"abhigyank","id":20434085,"node_id":"MDQ6VXNlcjIwNDM0MDg1","avatar_url":"https://avatars3.githubusercontent.com/u/20434085?v=4","gravatar_id":"","url":"https://api.github.com/users/abhigyank","html_url":"https://github.com/abhigyank","followers_url":"https://api.github.com/users/abhigyank/followers","following_url":"https://api.github.com/users/abhigyank/following{/other_user}","gists_url":"https://api.github.com/users/abhigyank/gists{/gist_id}","starred_url":"https://api.github.com/users/abhigyank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhigyank/subscriptions","organizations_url":"https://api.github.com/users/abhigyank/orgs","repos_url":"https://api.github.com/users/abhigyank/repos","events_url":"https://api.github.com/users/abhigyank/events{/privacy}","received_events_url":"https://api.github.com/users/abhigyank/received_events","type":"User","site_admin":false},"body":"This PR sets up karma for executing renderer process tests in electron and adds one test file for testing spellchecker, refactors tests dir into tests/e2e & tests/unit. \r\nIt picks up parts of #350 and improves upon them.\r\n\r\nAddress #82","created_at":"2018-07-24T07:40:45Z","updated_at":"2018-07-24T12:40:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"def32caf4e6e821ac6bda6c8fb358e6b66324711","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":805493159,"node_id":"MDU6TGFiZWw4MDU0OTMxNTk=","url":"https://api.github.com/repos/zulip/zulip-electron/labels/size:%20XL","name":"size: XL","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/zulip/zulip-electron/pulls/526/commits","review_comments_url":"https://api.github.com/repos/zulip/zulip-electron/pulls/526/comments","review_comment_url":"https://api.github.com/repos/zulip/zulip-electron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zulip/zulip-electron/issues/526/comments","statuses_url":"https://api.github.com/repos/zulip/zulip-electron/statuses/3e4a8c6c8b4d3904fd92542a03ef8e817416b679","head":{"label":"abhigyank:karma","ref":"karma","sha":"3e4a8c6c8b4d3904fd92542a03ef8e817416b679","user":{"login":"abhigyank","id":20434085,"node_id":"MDQ6VXNlcjIwNDM0MDg1","avatar_url":"https://avatars3.githubusercontent.com/u/20434085?v=4","gravatar_id":"","url":"https://api.github.com/users/abhigyank","html_url":"https://github.com/abhigyank","followers_url":"https://api.github.com/users/abhigyank/followers","following_url":"https://api.github.com/users/abhigyank/following{/other_user}","gists_url":"https://api.github.com/users/abhigyank/gists{/gist_id}","starred_url":"https://api.github.com/users/abhigyank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhigyank/subscriptions","organizations_url":"https://api.github.com/users/abhigyank/orgs","repos_url":"https://api.github.com/users/abhigyank/repos","events_url":"https://api.github.com/users/abhigyank/events{/privacy}","received_events_url":"https://api.github.com/users/abhigyank/received_events","type":"User","site_admin":false},"repo":{"id":117662227,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc2NjIyMjc=","name":"zulip-electron","full_name":"abhigyank/zulip-electron","owner":{"login":"abhigyank","id":20434085,"node_id":"MDQ6VXNlcjIwNDM0MDg1","avatar_url":"https://avatars3.githubusercontent.com/u/20434085?v=4","gravatar_id":"","url":"https://api.github.com/users/abhigyank","html_url":"https://github.com/abhigyank","followers_url":"https://api.github.com/users/abhigyank/followers","following_url":"https://api.github.com/users/abhigyank/following{/other_user}","gists_url":"https://api.github.com/users/abhigyank/gists{/gist_id}","starred_url":"https://api.github.com/users/abhigyank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhigyank/subscriptions","organizations_url":"https://api.github.com/users/abhigyank/orgs","repos_url":"https://api.github.com/users/abhigyank/repos","events_url":"https://api.github.com/users/abhigyank/events{/privacy}","received_events_url":"https://api.github.com/users/abhigyank/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abhigyank/zulip-electron","description":"Zulip Desktop Client","fork":true,"url":"https://api.github.com/repos/abhigyank/zulip-electron","forks_url":"https://api.github.com/repos/abhigyank/zulip-electron/forks","keys_url":"https://api.github.com/repos/abhigyank/zulip-electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abhigyank/zulip-electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abhigyank/zulip-electron/teams","hooks_url":"https://api.github.com/repos/abhigyank/zulip-electron/hooks","issue_events_url":"https://api.github.com/repos/abhigyank/zulip-electron/issues/events{/number}","events_url":"https://api.github.com/repos/abhigyank/zulip-electron/events","assignees_url":"https://api.github.com/repos/abhigyank/zulip-electron/assignees{/user}","branches_url":"https://api.github.com/repos/abhigyank/zulip-electron/branches{/branch}","tags_url":"https://api.github.com/repos/abhigyank/zulip-electron/tags","blobs_url":"https://api.github.com/repos/abhigyank/zulip-electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abhigyank/zulip-electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abhigyank/zulip-electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/abhigyank/zulip-electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abhigyank/zulip-electron/statuses/{sha}","languages_url":"https://api.github.com/repos/abhigyank/zulip-electron/languages","stargazers_url":"https://api.github.com/repos/abhigyank/zulip-electron/stargazers","contributors_url":"https://api.github.com/repos/abhigyank/zulip-electron/contributors","subscribers_url":"https://api.github.com/repos/abhigyank/zulip-electron/subscribers","subscription_url":"https://api.github.com/repos/abhigyank/zulip-electron/subscription","commits_url":"https://api.github.com/repos/abhigyank/zulip-electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/abhigyank/zulip-electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/abhigyank/zulip-electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/abhigyank/zulip-electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/abhigyank/zulip-electron/contents/{+path}","compare_url":"https://api.github.com/repos/abhigyank/zulip-electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abhigyank/zulip-electron/merges","archive_url":"https://api.github.com/repos/abhigyank/zulip-electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abhigyank/zulip-electron/downloads","issues_url":"https://api.github.com/repos/abhigyank/zulip-electron/issues{/number}","pulls_url":"https://api.github.com/repos/abhigyank/zulip-electron/pulls{/number}","milestones_url":"https://api.github.com/repos/abhigyank/zulip-electron/milestones{/number}","notifications_url":"https://api.github.com/repos/abhigyank/zulip-electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abhigyank/zulip-electron/labels{/name}","releases_url":"https://api.github.com/repos/abhigyank/zulip-electron/releases{/id}","deployments_url":"https://api.github.com/repos/abhigyank/zulip-electron/deployments","created_at":"2018-01-16T09:24:44Z","updated_at":"2018-07-05T16:43:33Z","pushed_at":"2018-07-24T08:26:07Z","git_url":"git://github.com/abhigyank/zulip-electron.git","ssh_url":"[email protected]:abhigyank/zulip-electron.git","clone_url":"https://github.com/abhigyank/zulip-electron.git","svn_url":"https://github.com/abhigyank/zulip-electron","homepage":"https://zulipchat.com/apps","size":2205,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zulip:master","ref":"master","sha":"82199dd1c3ddfeb1fba91b4bb2780a1e831a4be0","user":{"login":"zulip","id":4921959,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5MjE5NTk=","avatar_url":"https://avatars2.githubusercontent.com/u/4921959?v=4","gravatar_id":"","url":"https://api.github.com/users/zulip","html_url":"https://github.com/zulip","followers_url":"https://api.github.com/users/zulip/followers","following_url":"https://api.github.com/users/zulip/following{/other_user}","gists_url":"https://api.github.com/users/zulip/gists{/gist_id}","starred_url":"https://api.github.com/users/zulip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zulip/subscriptions","organizations_url":"https://api.github.com/users/zulip/orgs","repos_url":"https://api.github.com/users/zulip/repos","events_url":"https://api.github.com/users/zulip/events{/privacy}","received_events_url":"https://api.github.com/users/zulip/received_events","type":"Organization","site_admin":false},"repo":{"id":60656871,"node_id":"MDEwOlJlcG9zaXRvcnk2MDY1Njg3MQ==","name":"zulip-electron","full_name":"zulip/zulip-electron","owner":{"login":"zulip","id":4921959,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5MjE5NTk=","avatar_url":"https://avatars2.githubusercontent.com/u/4921959?v=4","gravatar_id":"","url":"https://api.github.com/users/zulip","html_url":"https://github.com/zulip","followers_url":"https://api.github.com/users/zulip/followers","following_url":"https://api.github.com/users/zulip/following{/other_user}","gists_url":"https://api.github.com/users/zulip/gists{/gist_id}","starred_url":"https://api.github.com/users/zulip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zulip/subscriptions","organizations_url":"https://api.github.com/users/zulip/orgs","repos_url":"https://api.github.com/users/zulip/repos","events_url":"https://api.github.com/users/zulip/events{/privacy}","received_events_url":"https://api.github.com/users/zulip/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zulip/zulip-electron","description":"Zulip Desktop Client","fork":false,"url":"https://api.github.com/repos/zulip/zulip-electron","forks_url":"https://api.github.com/repos/zulip/zulip-electron/forks","keys_url":"https://api.github.com/repos/zulip/zulip-electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zulip/zulip-electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zulip/zulip-electron/teams","hooks_url":"https://api.github.com/repos/zulip/zulip-electron/hooks","issue_events_url":"https://api.github.com/repos/zulip/zulip-electron/issues/events{/number}","events_url":"https://api.github.com/repos/zulip/zulip-electron/events","assignees_url":"https://api.github.com/repos/zulip/zulip-electron/assignees{/user}","branches_url":"https://api.github.com/repos/zulip/zulip-electron/branches{/branch}","tags_url":"https://api.github.com/repos/zulip/zulip-electron/tags","blobs_url":"https://api.github.com/repos/zulip/zulip-electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zulip/zulip-electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zulip/zulip-electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/zulip/zulip-electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zulip/zulip-electron/statuses/{sha}","languages_url":"https://api.github.com/repos/zulip/zulip-electron/languages","stargazers_url":"https://api.github.com/repos/zulip/zulip-electron/stargazers","contributors_url":"https://api.github.com/repos/zulip/zulip-electron/contributors","subscribers_url":"https://api.github.com/repos/zulip/zulip-electron/subscribers","subscription_url":"https://api.github.com/repos/zulip/zulip-electron/subscription","commits_url":"https://api.github.com/repos/zulip/zulip-electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/zulip/zulip-electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/zulip/zulip-electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/zulip/zulip-electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/zulip/zulip-electron/contents/{+path}","compare_url":"https://api.github.com/repos/zulip/zulip-electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zulip/zulip-electron/merges","archive_url":"https://api.github.com/repos/zulip/zulip-electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zulip/zulip-electron/downloads","issues_url":"https://api.github.com/repos/zulip/zulip-electron/issues{/number}","pulls_url":"https://api.github.com/repos/zulip/zulip-electron/pulls{/number}","milestones_url":"https://api.github.com/repos/zulip/zulip-electron/milestones{/number}","notifications_url":"https://api.github.com/repos/zulip/zulip-electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zulip/zulip-electron/labels{/name}","releases_url":"https://api.github.com/repos/zulip/zulip-electron/releases{/id}","deployments_url":"https://api.github.com/repos/zulip/zulip-electron/deployments","created_at":"2016-06-08T00:48:28Z","updated_at":"2018-07-23T17:47:14Z","pushed_at":"2018-07-24T08:26:09Z","git_url":"git://github.com/zulip/zulip-electron.git","ssh_url":"[email protected]:zulip/zulip-electron.git","clone_url":"https://github.com/zulip/zulip-electron.git","svn_url":"https://github.com/zulip/zulip-electron","homepage":"https://zulipchat.com/apps","size":2218,"stargazers_count":273,"watchers_count":273,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":118,"mirror_url":null,"archived":false,"open_issues_count":52,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":118,"open_issues":52,"watchers":273,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zulip/zulip-electron/pulls/526"},"html":{"href":"https://github.com/zulip/zulip-electron/pull/526"},"issue":{"href":"https://api.github.com/repos/zulip/zulip-electron/issues/526"},"comments":{"href":"https://api.github.com/repos/zulip/zulip-electron/issues/526/comments"},"review_comments":{"href":"https://api.github.com/repos/zulip/zulip-electron/pulls/526/comments"},"review_comment":{"href":"https://api.github.com/repos/zulip/zulip-electron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zulip/zulip-electron/pulls/526/commits"},"statuses":{"href":"https://api.github.com/repos/zulip/zulip-electron/statuses/3e4a8c6c8b4d3904fd92542a03ef8e817416b679"}},"author_association":"COLLABORATOR"}} | {
"id": 60656871,
"name": "zulip/zulip-electron",
"url": "https://api.github.com/repos/zulip/zulip-electron"
} | {
"id": 23620441,
"login": "priyankp10",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23620441?",
"url": "https://api.github.com/users/priyankp10"
} | {
"id": 4921959,
"login": "zulip",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4921959?",
"url": "https://api.github.com/orgs/zulip"
} | 2018-07-24T12:40:20 | 8009895494 | {"actor":{"display_login":"priyankp10"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/pulls/comments/178110576","pull_request_review_id":108115952,"id":178110576,"diff_hunk":"@@ -24,31 +24,35 @@ const opts = {\n };\n \n module.exports = (passport) => {\n- passport.use(new JwtStrategy(opts, (jwtPayload, done) => {\n+ const jwtStrategy = new JwtStrategy(opts, (jwtPayload, done) => {\n User.findOne({ where: { username: jwtPayload.username } })\n .then(user => done(null, user))\n .catch(err => done(err, false));\n- }));\n+ });\n+\n+ const fbStrategy = new FacebookStrategy({","path":"config/passport.js","position":12,"original_position":12,"commit_id":"abdb34e4fa8f48ebf1de060020241fc004bac92a","original_commit_id":"abdb34e4fa8f48ebf1de060020241fc004bac92a","user":{"login":"sirctseb","id":51333,"avatar_url":"https://avatars0.githubusercontent.com/u/51333?v=4","gravatar_id":"","url":"https://api.github.com/users/sirctseb","html_url":"https://github.com/sirctseb","followers_url":"https://api.github.com/users/sirctseb/followers","following_url":"https://api.github.com/users/sirctseb/following{/other_user}","gists_url":"https://api.github.com/users/sirctseb/gists{/gist_id}","starred_url":"https://api.github.com/users/sirctseb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sirctseb/subscriptions","organizations_url":"https://api.github.com/users/sirctseb/orgs","repos_url":"https://api.github.com/users/sirctseb/repos","events_url":"https://api.github.com/users/sirctseb/events{/privacy}","received_events_url":"https://api.github.com/users/sirctseb/received_events","type":"User","site_admin":false},"body":"The FacebookStrategy constructor fails if the environment variables are not set, preventing the service from starting. If facebook config is optional, we should move the constructor back into the `if`","created_at":"2018-03-29T16:24:59Z","updated_at":"2018-03-29T16:24:59Z","html_url":"https://github.com/amida-tech/amida-auth-microservice/pull/38#discussion_r178110576","pull_request_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/pulls/38","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/amida-tech/amida-auth-microservice/pulls/comments/178110576"},"html":{"href":"https://github.com/amida-tech/amida-auth-microservice/pull/38#discussion_r178110576"},"pull_request":{"href":"https://api.github.com/repos/amida-tech/amida-auth-microservice/pulls/38"}}},"pull_request":{"url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/pulls/38","id":176590885,"html_url":"https://github.com/amida-tech/amida-auth-microservice/pull/38","diff_url":"https://github.com/amida-tech/amida-auth-microservice/pull/38.diff","patch_url":"https://github.com/amida-tech/amida-auth-microservice/pull/38.patch","issue_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/issues/38","number":38,"state":"open","locked":false,"title":"add refresh token functionality","user":{"login":"jsachs","id":954072,"avatar_url":"https://avatars0.githubusercontent.com/u/954072?v=4","gravatar_id":"","url":"https://api.github.com/users/jsachs","html_url":"https://github.com/jsachs","followers_url":"https://api.github.com/users/jsachs/followers","following_url":"https://api.github.com/users/jsachs/following{/other_user}","gists_url":"https://api.github.com/users/jsachs/gists{/gist_id}","starred_url":"https://api.github.com/users/jsachs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsachs/subscriptions","organizations_url":"https://api.github.com/users/jsachs/orgs","repos_url":"https://api.github.com/users/jsachs/repos","events_url":"https://api.github.com/users/jsachs/events{/privacy}","received_events_url":"https://api.github.com/users/jsachs/received_events","type":"User","site_admin":false},"body":"#### What's this PR do?\r\nAdd refresh token endpoints and behavior.\r\n\r\n#### Related JIRA tickets:\r\n[SER-186](https://jira.amida-tech.com/browse/SER-186)\r\n\r\n#### How should this be manually tested?\r\nFirst, make sure the test harness runs.\r\n\r\nThen, you will want to mimic the client workflow. Log in normally. You should set the normal auth token to have a short expiration time. When the token expires, confirm that you can use the reset token endpoint `POST /token` to get a new, valid JWT.\r\n\r\nThis behavior will be handled by clients. If they receive a 401 based on an expired token, they should call the `/token` endpoint then resubmit the 401. @mhiner can confirm that this is the correct design or correct me if I am wrong.\r\n\r\nThere is also an endpoint `POST /token/reject` that will expire your current refresh token. The JWT token will still be valid, but the only way to get a new refresh token is to log in again. This can be used by a client as part of a logout process if they wish.\r\n\r\n#### Any background context you want to provide?\r\nhttps://solidgeargroup.com/refresh-token-with-jwt-authentication-node-js","created_at":"2018-03-21T19:49:24Z","updated_at":"2018-03-29T16:24:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96ce19475d4240965682438e8fe84f96535de12e","assignee":{"login":"jsachs","id":954072,"avatar_url":"https://avatars0.githubusercontent.com/u/954072?v=4","gravatar_id":"","url":"https://api.github.com/users/jsachs","html_url":"https://github.com/jsachs","followers_url":"https://api.github.com/users/jsachs/followers","following_url":"https://api.github.com/users/jsachs/following{/other_user}","gists_url":"https://api.github.com/users/jsachs/gists{/gist_id}","starred_url":"https://api.github.com/users/jsachs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsachs/subscriptions","organizations_url":"https://api.github.com/users/jsachs/orgs","repos_url":"https://api.github.com/users/jsachs/repos","events_url":"https://api.github.com/users/jsachs/events{/privacy}","received_events_url":"https://api.github.com/users/jsachs/received_events","type":"User","site_admin":false},"assignees":[{"login":"jsachs","id":954072,"avatar_url":"https://avatars0.githubusercontent.com/u/954072?v=4","gravatar_id":"","url":"https://api.github.com/users/jsachs","html_url":"https://github.com/jsachs","followers_url":"https://api.github.com/users/jsachs/followers","following_url":"https://api.github.com/users/jsachs/following{/other_user}","gists_url":"https://api.github.com/users/jsachs/gists{/gist_id}","starred_url":"https://api.github.com/users/jsachs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsachs/subscriptions","organizations_url":"https://api.github.com/users/jsachs/orgs","repos_url":"https://api.github.com/users/jsachs/repos","events_url":"https://api.github.com/users/jsachs/events{/privacy}","received_events_url":"https://api.github.com/users/jsachs/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"mhiner","id":1047430,"avatar_url":"https://avatars3.githubusercontent.com/u/1047430?v=4","gravatar_id":"","url":"https://api.github.com/users/mhiner","html_url":"https://github.com/mhiner","followers_url":"https://api.github.com/users/mhiner/followers","following_url":"https://api.github.com/users/mhiner/following{/other_user}","gists_url":"https://api.github.com/users/mhiner/gists{/gist_id}","starred_url":"https://api.github.com/users/mhiner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhiner/subscriptions","organizations_url":"https://api.github.com/users/mhiner/orgs","repos_url":"https://api.github.com/users/mhiner/repos","events_url":"https://api.github.com/users/mhiner/events{/privacy}","received_events_url":"https://api.github.com/users/mhiner/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/pulls/38/commits","review_comments_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/pulls/38/comments","review_comment_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/pulls/comments{/number}","comments_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/issues/38/comments","statuses_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/statuses/abdb34e4fa8f48ebf1de060020241fc004bac92a","head":{"label":"amida-tech:feature/js-refresh-tokens","ref":"feature/js-refresh-tokens","sha":"abdb34e4fa8f48ebf1de060020241fc004bac92a","user":{"login":"amida-tech","id":4925200,"avatar_url":"https://avatars0.githubusercontent.com/u/4925200?v=4","gravatar_id":"","url":"https://api.github.com/users/amida-tech","html_url":"https://github.com/amida-tech","followers_url":"https://api.github.com/users/amida-tech/followers","following_url":"https://api.github.com/users/amida-tech/following{/other_user}","gists_url":"https://api.github.com/users/amida-tech/gists{/gist_id}","starred_url":"https://api.github.com/users/amida-tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amida-tech/subscriptions","organizations_url":"https://api.github.com/users/amida-tech/orgs","repos_url":"https://api.github.com/users/amida-tech/repos","events_url":"https://api.github.com/users/amida-tech/events{/privacy}","received_events_url":"https://api.github.com/users/amida-tech/received_events","type":"Organization","site_admin":false},"repo":{"id":101319144,"name":"amida-auth-microservice","full_name":"amida-tech/amida-auth-microservice","owner":{"login":"amida-tech","id":4925200,"avatar_url":"https://avatars0.githubusercontent.com/u/4925200?v=4","gravatar_id":"","url":"https://api.github.com/users/amida-tech","html_url":"https://github.com/amida-tech","followers_url":"https://api.github.com/users/amida-tech/followers","following_url":"https://api.github.com/users/amida-tech/following{/other_user}","gists_url":"https://api.github.com/users/amida-tech/gists{/gist_id}","starred_url":"https://api.github.com/users/amida-tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amida-tech/subscriptions","organizations_url":"https://api.github.com/users/amida-tech/orgs","repos_url":"https://api.github.com/users/amida-tech/repos","events_url":"https://api.github.com/users/amida-tech/events{/privacy}","received_events_url":"https://api.github.com/users/amida-tech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/amida-tech/amida-auth-microservice","description":null,"fork":false,"url":"https://api.github.com/repos/amida-tech/amida-auth-microservice","forks_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/forks","keys_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/teams","hooks_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/hooks","issue_events_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/issues/events{/number}","events_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/events","assignees_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/assignees{/user}","branches_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/branches{/branch}","tags_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/tags","blobs_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/git/refs{/sha}","trees_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/statuses/{sha}","languages_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/languages","stargazers_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/stargazers","contributors_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/contributors","subscribers_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/subscribers","subscription_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/subscription","commits_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/commits{/sha}","git_commits_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/git/commits{/sha}","comments_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/comments{/number}","issue_comment_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/issues/comments{/number}","contents_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/contents/{+path}","compare_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/merges","archive_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/downloads","issues_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/issues{/number}","pulls_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/pulls{/number}","milestones_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/milestones{/number}","notifications_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/labels{/name}","releases_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/releases{/id}","deployments_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/deployments","created_at":"2017-08-24T17:07:56Z","updated_at":"2017-08-24T17:17:13Z","pushed_at":"2018-03-22T10:51:39Z","git_url":"git://github.com/amida-tech/amida-auth-microservice.git","ssh_url":"[email protected]:amida-tech/amida-auth-microservice.git","clone_url":"https://github.com/amida-tech/amida-auth-microservice.git","svn_url":"https://github.com/amida-tech/amida-auth-microservice","homepage":null,"size":689,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":3,"watchers":0,"default_branch":"develop"}},"base":{"label":"amida-tech:develop","ref":"develop","sha":"e30f59d3bf719bc853c815e1ad62f0b24987f0c6","user":{"login":"amida-tech","id":4925200,"avatar_url":"https://avatars0.githubusercontent.com/u/4925200?v=4","gravatar_id":"","url":"https://api.github.com/users/amida-tech","html_url":"https://github.com/amida-tech","followers_url":"https://api.github.com/users/amida-tech/followers","following_url":"https://api.github.com/users/amida-tech/following{/other_user}","gists_url":"https://api.github.com/users/amida-tech/gists{/gist_id}","starred_url":"https://api.github.com/users/amida-tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amida-tech/subscriptions","organizations_url":"https://api.github.com/users/amida-tech/orgs","repos_url":"https://api.github.com/users/amida-tech/repos","events_url":"https://api.github.com/users/amida-tech/events{/privacy}","received_events_url":"https://api.github.com/users/amida-tech/received_events","type":"Organization","site_admin":false},"repo":{"id":101319144,"name":"amida-auth-microservice","full_name":"amida-tech/amida-auth-microservice","owner":{"login":"amida-tech","id":4925200,"avatar_url":"https://avatars0.githubusercontent.com/u/4925200?v=4","gravatar_id":"","url":"https://api.github.com/users/amida-tech","html_url":"https://github.com/amida-tech","followers_url":"https://api.github.com/users/amida-tech/followers","following_url":"https://api.github.com/users/amida-tech/following{/other_user}","gists_url":"https://api.github.com/users/amida-tech/gists{/gist_id}","starred_url":"https://api.github.com/users/amida-tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amida-tech/subscriptions","organizations_url":"https://api.github.com/users/amida-tech/orgs","repos_url":"https://api.github.com/users/amida-tech/repos","events_url":"https://api.github.com/users/amida-tech/events{/privacy}","received_events_url":"https://api.github.com/users/amida-tech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/amida-tech/amida-auth-microservice","description":null,"fork":false,"url":"https://api.github.com/repos/amida-tech/amida-auth-microservice","forks_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/forks","keys_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/teams","hooks_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/hooks","issue_events_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/issues/events{/number}","events_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/events","assignees_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/assignees{/user}","branches_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/branches{/branch}","tags_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/tags","blobs_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/git/refs{/sha}","trees_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/statuses/{sha}","languages_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/languages","stargazers_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/stargazers","contributors_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/contributors","subscribers_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/subscribers","subscription_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/subscription","commits_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/commits{/sha}","git_commits_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/git/commits{/sha}","comments_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/comments{/number}","issue_comment_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/issues/comments{/number}","contents_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/contents/{+path}","compare_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/merges","archive_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/downloads","issues_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/issues{/number}","pulls_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/pulls{/number}","milestones_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/milestones{/number}","notifications_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/labels{/name}","releases_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/releases{/id}","deployments_url":"https://api.github.com/repos/amida-tech/amida-auth-microservice/deployments","created_at":"2017-08-24T17:07:56Z","updated_at":"2017-08-24T17:17:13Z","pushed_at":"2018-03-22T10:51:39Z","git_url":"git://github.com/amida-tech/amida-auth-microservice.git","ssh_url":"[email protected]:amida-tech/amida-auth-microservice.git","clone_url":"https://github.com/amida-tech/amida-auth-microservice.git","svn_url":"https://github.com/amida-tech/amida-auth-microservice","homepage":null,"size":689,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":3,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/amida-tech/amida-auth-microservice/pulls/38"},"html":{"href":"https://github.com/amida-tech/amida-auth-microservice/pull/38"},"issue":{"href":"https://api.github.com/repos/amida-tech/amida-auth-microservice/issues/38"},"comments":{"href":"https://api.github.com/repos/amida-tech/amida-auth-microservice/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/amida-tech/amida-auth-microservice/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/amida-tech/amida-auth-microservice/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/amida-tech/amida-auth-microservice/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/amida-tech/amida-auth-microservice/statuses/abdb34e4fa8f48ebf1de060020241fc004bac92a"}},"author_association":"OWNER"}} | {
"id": 101319144,
"name": "amida-tech/amida-auth-microservice",
"url": "https://api.github.com/repos/amida-tech/amida-auth-microservice"
} | {
"id": 51333,
"login": "sirctseb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/51333?",
"url": "https://api.github.com/users/sirctseb"
} | {
"id": 4925200,
"login": "amida-tech",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4925200?",
"url": "https://api.github.com/orgs/amida-tech"
} | 2018-03-29T16:24:59 | 7454923611 | {"actor":{"display_login":"sirctseb"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/pybee/voc/pulls/comments/217881248","pull_request_review_id":155709621,"id":217881248,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzg4MTI0OA==","diff_hunk":"@@ -2,7 +2,7 @@\n from os import path\n sys.path.append(path.dirname(path.dirname(path.abspath(__file__))))\n \n-from utils import *\n+from .utils import *\n \n def test_small_integers(test_case):","path":"tests/microbenchmarks.py","position":7,"original_position":7,"commit_id":"ae8716701b3c72fa060628ba4c0bf839b81fdaaa","original_commit_id":"ae8716701b3c72fa060628ba4c0bf839b81fdaaa","user":{"login":"brutusthebee","id":20432436,"node_id":"MDQ6VXNlcjIwNDMyNDM2","avatar_url":"https://avatars0.githubusercontent.com/u/20432436?v=4","gravatar_id":"","url":"https://api.github.com/users/brutusthebee","html_url":"https://github.com/brutusthebee","followers_url":"https://api.github.com/users/brutusthebee/followers","following_url":"https://api.github.com/users/brutusthebee/following{/other_user}","gists_url":"https://api.github.com/users/brutusthebee/gists{/gist_id}","starred_url":"https://api.github.com/users/brutusthebee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brutusthebee/subscriptions","organizations_url":"https://api.github.com/users/brutusthebee/orgs","repos_url":"https://api.github.com/users/brutusthebee/repos","events_url":"https://api.github.com/users/brutusthebee/events{/privacy}","received_events_url":"https://api.github.com/users/brutusthebee/received_events","type":"User","site_admin":false},"body":"At column 1: (E302) expected 2 blank lines, found 1","created_at":"2018-09-15T09:56:01Z","updated_at":"2018-09-15T09:56:01Z","html_url":"https://github.com/pybee/voc/pull/922#discussion_r217881248","pull_request_url":"https://api.github.com/repos/pybee/voc/pulls/922","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/pybee/voc/pulls/comments/217881248"},"html":{"href":"https://github.com/pybee/voc/pull/922#discussion_r217881248"},"pull_request":{"href":"https://api.github.com/repos/pybee/voc/pulls/922"}}},"pull_request":{"url":"https://api.github.com/repos/pybee/voc/pulls/922","id":215761412,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NzYxNDEy","html_url":"https://github.com/pybee/voc/pull/922","diff_url":"https://github.com/pybee/voc/pull/922.diff","patch_url":"https://github.com/pybee/voc/pull/922.patch","issue_url":"https://api.github.com/repos/pybee/voc/issues/922","number":922,"state":"open","locked":false,"title":"Implement bytes.splitlines()","user":{"login":"wkeeling","id":1295116,"node_id":"MDQ6VXNlcjEyOTUxMTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1295116?v=4","gravatar_id":"","url":"https://api.github.com/users/wkeeling","html_url":"https://github.com/wkeeling","followers_url":"https://api.github.com/users/wkeeling/followers","following_url":"https://api.github.com/users/wkeeling/following{/other_user}","gists_url":"https://api.github.com/users/wkeeling/gists{/gist_id}","starred_url":"https://api.github.com/users/wkeeling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkeeling/subscriptions","organizations_url":"https://api.github.com/users/wkeeling/orgs","repos_url":"https://api.github.com/users/wkeeling/repos","events_url":"https://api.github.com/users/wkeeling/events{/privacy}","received_events_url":"https://api.github.com/users/wkeeling/received_events","type":"User","site_admin":false},"body":"Refs: #38 \r\n\r\nImplementation of `bytes.splitlines()` with tests.\r\n\r\nAlso fixes a couple of syntax problems discovered in `microbenchmarks,py`","created_at":"2018-09-15T09:55:19Z","updated_at":"2018-09-15T09:56:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"007cb903cfe5baa322c2ea11fa2ac25c7d77608b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pybee/voc/pulls/922/commits","review_comments_url":"https://api.github.com/repos/pybee/voc/pulls/922/comments","review_comment_url":"https://api.github.com/repos/pybee/voc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pybee/voc/issues/922/comments","statuses_url":"https://api.github.com/repos/pybee/voc/statuses/ae8716701b3c72fa060628ba4c0bf839b81fdaaa","head":{"label":"wkeeling:bytes_splitlines","ref":"bytes_splitlines","sha":"ae8716701b3c72fa060628ba4c0bf839b81fdaaa","user":{"login":"wkeeling","id":1295116,"node_id":"MDQ6VXNlcjEyOTUxMTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1295116?v=4","gravatar_id":"","url":"https://api.github.com/users/wkeeling","html_url":"https://github.com/wkeeling","followers_url":"https://api.github.com/users/wkeeling/followers","following_url":"https://api.github.com/users/wkeeling/following{/other_user}","gists_url":"https://api.github.com/users/wkeeling/gists{/gist_id}","starred_url":"https://api.github.com/users/wkeeling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkeeling/subscriptions","organizations_url":"https://api.github.com/users/wkeeling/orgs","repos_url":"https://api.github.com/users/wkeeling/repos","events_url":"https://api.github.com/users/wkeeling/events{/privacy}","received_events_url":"https://api.github.com/users/wkeeling/received_events","type":"User","site_admin":false},"repo":{"id":147968546,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc5Njg1NDY=","name":"voc","full_name":"wkeeling/voc","owner":{"login":"wkeeling","id":1295116,"node_id":"MDQ6VXNlcjEyOTUxMTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1295116?v=4","gravatar_id":"","url":"https://api.github.com/users/wkeeling","html_url":"https://github.com/wkeeling","followers_url":"https://api.github.com/users/wkeeling/followers","following_url":"https://api.github.com/users/wkeeling/following{/other_user}","gists_url":"https://api.github.com/users/wkeeling/gists{/gist_id}","starred_url":"https://api.github.com/users/wkeeling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkeeling/subscriptions","organizations_url":"https://api.github.com/users/wkeeling/orgs","repos_url":"https://api.github.com/users/wkeeling/repos","events_url":"https://api.github.com/users/wkeeling/events{/privacy}","received_events_url":"https://api.github.com/users/wkeeling/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wkeeling/voc","description":" A transpiler that converts Python code into Java bytecode","fork":true,"url":"https://api.github.com/repos/wkeeling/voc","forks_url":"https://api.github.com/repos/wkeeling/voc/forks","keys_url":"https://api.github.com/repos/wkeeling/voc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wkeeling/voc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wkeeling/voc/teams","hooks_url":"https://api.github.com/repos/wkeeling/voc/hooks","issue_events_url":"https://api.github.com/repos/wkeeling/voc/issues/events{/number}","events_url":"https://api.github.com/repos/wkeeling/voc/events","assignees_url":"https://api.github.com/repos/wkeeling/voc/assignees{/user}","branches_url":"https://api.github.com/repos/wkeeling/voc/branches{/branch}","tags_url":"https://api.github.com/repos/wkeeling/voc/tags","blobs_url":"https://api.github.com/repos/wkeeling/voc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wkeeling/voc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wkeeling/voc/git/refs{/sha}","trees_url":"https://api.github.com/repos/wkeeling/voc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wkeeling/voc/statuses/{sha}","languages_url":"https://api.github.com/repos/wkeeling/voc/languages","stargazers_url":"https://api.github.com/repos/wkeeling/voc/stargazers","contributors_url":"https://api.github.com/repos/wkeeling/voc/contributors","subscribers_url":"https://api.github.com/repos/wkeeling/voc/subscribers","subscription_url":"https://api.github.com/repos/wkeeling/voc/subscription","commits_url":"https://api.github.com/repos/wkeeling/voc/commits{/sha}","git_commits_url":"https://api.github.com/repos/wkeeling/voc/git/commits{/sha}","comments_url":"https://api.github.com/repos/wkeeling/voc/comments{/number}","issue_comment_url":"https://api.github.com/repos/wkeeling/voc/issues/comments{/number}","contents_url":"https://api.github.com/repos/wkeeling/voc/contents/{+path}","compare_url":"https://api.github.com/repos/wkeeling/voc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wkeeling/voc/merges","archive_url":"https://api.github.com/repos/wkeeling/voc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wkeeling/voc/downloads","issues_url":"https://api.github.com/repos/wkeeling/voc/issues{/number}","pulls_url":"https://api.github.com/repos/wkeeling/voc/pulls{/number}","milestones_url":"https://api.github.com/repos/wkeeling/voc/milestones{/number}","notifications_url":"https://api.github.com/repos/wkeeling/voc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wkeeling/voc/labels{/name}","releases_url":"https://api.github.com/repos/wkeeling/voc/releases{/id}","deployments_url":"https://api.github.com/repos/wkeeling/voc/deployments","created_at":"2018-09-08T20:44:10Z","updated_at":"2018-09-14T08:04:35Z","pushed_at":"2018-09-15T09:06:08Z","git_url":"git://github.com/wkeeling/voc.git","ssh_url":"[email protected]:wkeeling/voc.git","clone_url":"https://github.com/wkeeling/voc.git","svn_url":"https://github.com/wkeeling/voc","homepage":"http://pybee.org/voc","size":14660,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pybee:master","ref":"master","sha":"5a2edb60334eecc037e2fcb6b514297dd12da4b1","user":{"login":"pybee","id":5001767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMDE3Njc=","avatar_url":"https://avatars0.githubusercontent.com/u/5001767?v=4","gravatar_id":"","url":"https://api.github.com/users/pybee","html_url":"https://github.com/pybee","followers_url":"https://api.github.com/users/pybee/followers","following_url":"https://api.github.com/users/pybee/following{/other_user}","gists_url":"https://api.github.com/users/pybee/gists{/gist_id}","starred_url":"https://api.github.com/users/pybee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pybee/subscriptions","organizations_url":"https://api.github.com/users/pybee/orgs","repos_url":"https://api.github.com/users/pybee/repos","events_url":"https://api.github.com/users/pybee/events{/privacy}","received_events_url":"https://api.github.com/users/pybee/received_events","type":"Organization","site_admin":false},"repo":{"id":40796389,"node_id":"MDEwOlJlcG9zaXRvcnk0MDc5NjM4OQ==","name":"voc","full_name":"pybee/voc","owner":{"login":"pybee","id":5001767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMDE3Njc=","avatar_url":"https://avatars0.githubusercontent.com/u/5001767?v=4","gravatar_id":"","url":"https://api.github.com/users/pybee","html_url":"https://github.com/pybee","followers_url":"https://api.github.com/users/pybee/followers","following_url":"https://api.github.com/users/pybee/following{/other_user}","gists_url":"https://api.github.com/users/pybee/gists{/gist_id}","starred_url":"https://api.github.com/users/pybee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pybee/subscriptions","organizations_url":"https://api.github.com/users/pybee/orgs","repos_url":"https://api.github.com/users/pybee/repos","events_url":"https://api.github.com/users/pybee/events{/privacy}","received_events_url":"https://api.github.com/users/pybee/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pybee/voc","description":" A transpiler that converts Python code into Java bytecode","fork":false,"url":"https://api.github.com/repos/pybee/voc","forks_url":"https://api.github.com/repos/pybee/voc/forks","keys_url":"https://api.github.com/repos/pybee/voc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pybee/voc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pybee/voc/teams","hooks_url":"https://api.github.com/repos/pybee/voc/hooks","issue_events_url":"https://api.github.com/repos/pybee/voc/issues/events{/number}","events_url":"https://api.github.com/repos/pybee/voc/events","assignees_url":"https://api.github.com/repos/pybee/voc/assignees{/user}","branches_url":"https://api.github.com/repos/pybee/voc/branches{/branch}","tags_url":"https://api.github.com/repos/pybee/voc/tags","blobs_url":"https://api.github.com/repos/pybee/voc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pybee/voc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pybee/voc/git/refs{/sha}","trees_url":"https://api.github.com/repos/pybee/voc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pybee/voc/statuses/{sha}","languages_url":"https://api.github.com/repos/pybee/voc/languages","stargazers_url":"https://api.github.com/repos/pybee/voc/stargazers","contributors_url":"https://api.github.com/repos/pybee/voc/contributors","subscribers_url":"https://api.github.com/repos/pybee/voc/subscribers","subscription_url":"https://api.github.com/repos/pybee/voc/subscription","commits_url":"https://api.github.com/repos/pybee/voc/commits{/sha}","git_commits_url":"https://api.github.com/repos/pybee/voc/git/commits{/sha}","comments_url":"https://api.github.com/repos/pybee/voc/comments{/number}","issue_comment_url":"https://api.github.com/repos/pybee/voc/issues/comments{/number}","contents_url":"https://api.github.com/repos/pybee/voc/contents/{+path}","compare_url":"https://api.github.com/repos/pybee/voc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pybee/voc/merges","archive_url":"https://api.github.com/repos/pybee/voc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pybee/voc/downloads","issues_url":"https://api.github.com/repos/pybee/voc/issues{/number}","pulls_url":"https://api.github.com/repos/pybee/voc/pulls{/number}","milestones_url":"https://api.github.com/repos/pybee/voc/milestones{/number}","notifications_url":"https://api.github.com/repos/pybee/voc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pybee/voc/labels{/name}","releases_url":"https://api.github.com/repos/pybee/voc/releases{/id}","deployments_url":"https://api.github.com/repos/pybee/voc/deployments","created_at":"2015-08-16T02:36:42Z","updated_at":"2018-09-11T18:46:54Z","pushed_at":"2018-09-15T09:55:20Z","git_url":"git://github.com/pybee/voc.git","ssh_url":"[email protected]:pybee/voc.git","clone_url":"https://github.com/pybee/voc.git","svn_url":"https://github.com/pybee/voc","homepage":"http://pybee.org/voc","size":14689,"stargazers_count":693,"watchers_count":693,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":483,"mirror_url":null,"archived":false,"open_issues_count":107,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":483,"open_issues":107,"watchers":693,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pybee/voc/pulls/922"},"html":{"href":"https://github.com/pybee/voc/pull/922"},"issue":{"href":"https://api.github.com/repos/pybee/voc/issues/922"},"comments":{"href":"https://api.github.com/repos/pybee/voc/issues/922/comments"},"review_comments":{"href":"https://api.github.com/repos/pybee/voc/pulls/922/comments"},"review_comment":{"href":"https://api.github.com/repos/pybee/voc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pybee/voc/pulls/922/commits"},"statuses":{"href":"https://api.github.com/repos/pybee/voc/statuses/ae8716701b3c72fa060628ba4c0bf839b81fdaaa"}},"author_association":"NONE"}} | {
"id": 40796389,
"name": "pybee/voc",
"url": "https://api.github.com/repos/pybee/voc"
} | {
"id": 20432436,
"login": "brutusthebee",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20432436?",
"url": "https://api.github.com/users/brutusthebee"
} | {
"id": 5001767,
"login": "pybee",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5001767?",
"url": "https://api.github.com/orgs/pybee"
} | 2018-09-15T09:56:01 | 8269734088 | {"actor":{"display_login":"brutusthebee"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Particular/ServiceControl/pulls/comments/202517087","pull_request_review_id":137240227,"id":202517087,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjUxNzA4Nw==","diff_hunk":"@@ -1,595 +1,88 @@\n-<?xml version=\"1.0\" encoding=\"utf-8\"?>\n-<Project ToolsVersion=\"12.0\" DefaultTargets=\"Build\" xmlns=\"http://schemas.microsoft.com/developer/msbuild/2003\">\n- <Import Project=\"$(MSBuildExtensionsPath)\\$(MSBuildToolsVersion)\\Microsoft.Common.props\" Condition=\"Exists('$(MSBuildExtensionsPath)\\$(MSBuildToolsVersion)\\Microsoft.Common.props')\" />\n+<Project Sdk=\"MSBuild.Sdk.Extras/1.6.37-preview\">\n+\n <PropertyGroup>\n- <AllowedReferenceRelatedFileExtensions>.pdb</AllowedReferenceRelatedFileExtensions>\n- </PropertyGroup>\n- <PropertyGroup>\n- <Configuration Condition=\" '$(Configuration)' == '' \">Debug</Configuration>\n- <Platform Condition=\" '$(Platform)' == '' \">AnyCPU</Platform>\n- <ProjectGuid>{C0EEF6D1-5DF7-4A26-9964-6376F465B085}</ProjectGuid>\n+ <TargetFramework>net452</TargetFramework>\n <OutputType>WinExe</OutputType>\n- <AppDesignerFolder>Properties</AppDesignerFolder>\n- <RootNamespace>ServiceControl.Config</RootNamespace>\n <AssemblyName>ServiceControlConfig</AssemblyName>\n- <TargetFrameworkVersion>v4.5.2</TargetFrameworkVersion>\n- <FileAlignment>512</FileAlignment>\n- <ProjectTypeGuids>{60dc8134-eba5-43b8-bcc9-bb4bc16c2548};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}</ProjectTypeGuids>\n- <WarningLevel>4</WarningLevel>\n- <NuGetPackageImportStamp>\n- </NuGetPackageImportStamp>\n- <TargetFrameworkProfile />\n- </PropertyGroup>\n- <PropertyGroup Condition=\" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' \">\n- <PlatformTarget>AnyCPU</PlatformTarget>\n- <DebugSymbols>true</DebugSymbols>\n- <DebugType>full</DebugType>\n- <Optimize>false</Optimize>\n- <OutputPath>bin\\Debug\\</OutputPath>\n- <DefineConstants>DEBUG;TRACE</DefineConstants>\n- <ErrorReport>prompt</ErrorReport>\n- <WarningLevel>4</WarningLevel>\n- <LangVersion>6</LangVersion>\n- <UseVSHostingProcess>false</UseVSHostingProcess>\n- <Prefer32Bit>false</Prefer32Bit>\n- </PropertyGroup>\n- <PropertyGroup Condition=\" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' \">\n- <PlatformTarget>AnyCPU</PlatformTarget>\n- <DebugType>pdbonly</DebugType>\n- <Optimize>true</Optimize>\n- <OutputPath>bin\\Release\\</OutputPath>\n- <DefineConstants>TRACE</DefineConstants>\n- <ErrorReport>prompt</ErrorReport>\n- <WarningLevel>4</WarningLevel>\n- <LangVersion>6</LangVersion>\n- <UseVSHostingProcess>false</UseVSHostingProcess>\n- <Prefer32Bit>false</Prefer32Bit>\n- </PropertyGroup>\n- <PropertyGroup>\n- <ApplicationManifest>app.manifest</ApplicationManifest>\n- </PropertyGroup>\n- <PropertyGroup>\n <ApplicationIcon>App.ico</ApplicationIcon>\n+ <ExtrasEnableWpfProjectSetup>true</ExtrasEnableWpfProjectSetup>","path":"src/ServiceControl.Config/ServiceControl.Config.csproj","position":56,"original_position":56,"commit_id":"687814e87fd9c386383470291777835bff6c273f","original_commit_id":"687814e87fd9c386383470291777835bff6c273f","user":{"login":"bording","id":753669,"node_id":"MDQ6VXNlcjc1MzY2OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/753669?v=4","gravatar_id":"","url":"https://api.github.com/users/bording","html_url":"https://github.com/bording","followers_url":"https://api.github.com/users/bording/followers","following_url":"https://api.github.com/users/bording/following{/other_user}","gists_url":"https://api.github.com/users/bording/gists{/gist_id}","starred_url":"https://api.github.com/users/bording/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bording/subscriptions","organizations_url":"https://api.github.com/users/bording/orgs","repos_url":"https://api.github.com/users/bording/repos","events_url":"https://api.github.com/users/bording/events{/privacy}","received_events_url":"https://api.github.com/users/bording/received_events","type":"User","site_admin":false},"body":"Yeah, it's part of https://github.com/onovotny/MSBuildSdkExtras, which is used by the setting the custom SDK line: `<Project Sdk=\"MSBuild.Sdk.Extras/1.6.37-preview\">`.\r\n\r\nIt adds all the stuff to the project system that is required for a WPF app to work. Once Microsoft adds actual support, this could be removed. \r\n\r\n","created_at":"2018-07-14T14:56:12Z","updated_at":"2018-07-14T14:56:12Z","html_url":"https://github.com/Particular/ServiceControl/pull/1222#discussion_r202517087","pull_request_url":"https://api.github.com/repos/Particular/ServiceControl/pulls/1222","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Particular/ServiceControl/pulls/comments/202517087"},"html":{"href":"https://github.com/Particular/ServiceControl/pull/1222#discussion_r202517087"},"pull_request":{"href":"https://api.github.com/repos/Particular/ServiceControl/pulls/1222"}},"in_reply_to_id":202507541},"pull_request":{"url":"https://api.github.com/repos/Particular/ServiceControl/pulls/1222","id":200074282,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMDc0Mjgy","html_url":"https://github.com/Particular/ServiceControl/pull/1222","diff_url":"https://github.com/Particular/ServiceControl/pull/1222.diff","patch_url":"https://github.com/Particular/ServiceControl/pull/1222.patch","issue_url":"https://api.github.com/repos/Particular/ServiceControl/issues/1222","number":1222,"state":"closed","locked":false,"title":"Upgrade SC projects to SDK-style project format","user":{"login":"danielmarbach","id":174258,"node_id":"MDQ6VXNlcjE3NDI1OA==","avatar_url":"https://avatars1.githubusercontent.com/u/174258?v=4","gravatar_id":"","url":"https://api.github.com/users/danielmarbach","html_url":"https://github.com/danielmarbach","followers_url":"https://api.github.com/users/danielmarbach/followers","following_url":"https://api.github.com/users/danielmarbach/following{/other_user}","gists_url":"https://api.github.com/users/danielmarbach/gists{/gist_id}","starred_url":"https://api.github.com/users/danielmarbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielmarbach/subscriptions","organizations_url":"https://api.github.com/users/danielmarbach/orgs","repos_url":"https://api.github.com/users/danielmarbach/repos","events_url":"https://api.github.com/users/danielmarbach/events{/privacy}","received_events_url":"https://api.github.com/users/danielmarbach/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-09T11:47:30Z","updated_at":"2018-07-14T14:56:12Z","closed_at":"2018-07-14T12:17:35Z","merged_at":"2018-07-14T12:17:35Z","merge_commit_sha":"b2cc4a40361306c7097dbca97c13c6fa53642113","assignee":{"login":"bording","id":753669,"node_id":"MDQ6VXNlcjc1MzY2OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/753669?v=4","gravatar_id":"","url":"https://api.github.com/users/bording","html_url":"https://github.com/bording","followers_url":"https://api.github.com/users/bording/followers","following_url":"https://api.github.com/users/bording/following{/other_user}","gists_url":"https://api.github.com/users/bording/gists{/gist_id}","starred_url":"https://api.github.com/users/bording/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bording/subscriptions","organizations_url":"https://api.github.com/users/bording/orgs","repos_url":"https://api.github.com/users/bording/repos","events_url":"https://api.github.com/users/bording/events{/privacy}","received_events_url":"https://api.github.com/users/bording/received_events","type":"User","site_admin":false},"assignees":[{"login":"bording","id":753669,"node_id":"MDQ6VXNlcjc1MzY2OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/753669?v=4","gravatar_id":"","url":"https://api.github.com/users/bording","html_url":"https://github.com/bording","followers_url":"https://api.github.com/users/bording/followers","following_url":"https://api.github.com/users/bording/following{/other_user}","gists_url":"https://api.github.com/users/bording/gists{/gist_id}","starred_url":"https://api.github.com/users/bording/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bording/subscriptions","organizations_url":"https://api.github.com/users/bording/orgs","repos_url":"https://api.github.com/users/bording/repos","events_url":"https://api.github.com/users/bording/events{/privacy}","received_events_url":"https://api.github.com/users/bording/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"WilliamBZA","id":1060960,"node_id":"MDQ6VXNlcjEwNjA5NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/1060960?v=4","gravatar_id":"","url":"https://api.github.com/users/WilliamBZA","html_url":"https://github.com/WilliamBZA","followers_url":"https://api.github.com/users/WilliamBZA/followers","following_url":"https://api.github.com/users/WilliamBZA/following{/other_user}","gists_url":"https://api.github.com/users/WilliamBZA/gists{/gist_id}","starred_url":"https://api.github.com/users/WilliamBZA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WilliamBZA/subscriptions","organizations_url":"https://api.github.com/users/WilliamBZA/orgs","repos_url":"https://api.github.com/users/WilliamBZA/repos","events_url":"https://api.github.com/users/WilliamBZA/events{/privacy}","received_events_url":"https://api.github.com/users/WilliamBZA/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Particular/ServiceControl/pulls/1222/commits","review_comments_url":"https://api.github.com/repos/Particular/ServiceControl/pulls/1222/comments","review_comment_url":"https://api.github.com/repos/Particular/ServiceControl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Particular/ServiceControl/issues/1222/comments","statuses_url":"https://api.github.com/repos/Particular/ServiceControl/statuses/687814e87fd9c386383470291777835bff6c273f","head":{"label":"Particular:csproj","ref":"csproj","sha":"687814e87fd9c386383470291777835bff6c273f","user":{"login":"Particular","id":5038441,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMzg0NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/5038441?v=4","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":7913469,"node_id":"MDEwOlJlcG9zaXRvcnk3OTEzNDY5","name":"ServiceControl","full_name":"Particular/ServiceControl","owner":{"login":"Particular","id":5038441,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMzg0NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/5038441?v=4","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Particular/ServiceControl","description":"Backend for ServiceInsight and ServicePulse","fork":false,"url":"https://api.github.com/repos/Particular/ServiceControl","forks_url":"https://api.github.com/repos/Particular/ServiceControl/forks","keys_url":"https://api.github.com/repos/Particular/ServiceControl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/ServiceControl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/ServiceControl/teams","hooks_url":"https://api.github.com/repos/Particular/ServiceControl/hooks","issue_events_url":"https://api.github.com/repos/Particular/ServiceControl/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/ServiceControl/events","assignees_url":"https://api.github.com/repos/Particular/ServiceControl/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/ServiceControl/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/ServiceControl/tags","blobs_url":"https://api.github.com/repos/Particular/ServiceControl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/ServiceControl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/ServiceControl/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/ServiceControl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/ServiceControl/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/ServiceControl/languages","stargazers_url":"https://api.github.com/repos/Particular/ServiceControl/stargazers","contributors_url":"https://api.github.com/repos/Particular/ServiceControl/contributors","subscribers_url":"https://api.github.com/repos/Particular/ServiceControl/subscribers","subscription_url":"https://api.github.com/repos/Particular/ServiceControl/subscription","commits_url":"https://api.github.com/repos/Particular/ServiceControl/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/ServiceControl/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/ServiceControl/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/ServiceControl/issues/comments{/number}","contents_url":"https://api.github.com/repos/Particular/ServiceControl/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/ServiceControl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/ServiceControl/merges","archive_url":"https://api.github.com/repos/Particular/ServiceControl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/ServiceControl/downloads","issues_url":"https://api.github.com/repos/Particular/ServiceControl/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/ServiceControl/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/ServiceControl/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/ServiceControl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/ServiceControl/labels{/name}","releases_url":"https://api.github.com/repos/Particular/ServiceControl/releases{/id}","deployments_url":"https://api.github.com/repos/Particular/ServiceControl/deployments","created_at":"2013-01-30T11:42:44Z","updated_at":"2018-07-05T12:16:15Z","pushed_at":"2018-07-14T12:40:55Z","git_url":"git://github.com/Particular/ServiceControl.git","ssh_url":"[email protected]:Particular/ServiceControl.git","clone_url":"https://github.com/Particular/ServiceControl.git","svn_url":"https://github.com/Particular/ServiceControl","homepage":"https://docs.particular.net/servicecontrol/","size":48507,"stargazers_count":17,"watchers_count":17,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":29,"mirror_url":null,"archived":false,"open_issues_count":95,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":29,"open_issues":95,"watchers":17,"default_branch":"master"}},"base":{"label":"Particular:develop","ref":"develop","sha":"995f02598e2550fddb707beae76980024ae2f51c","user":{"login":"Particular","id":5038441,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMzg0NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/5038441?v=4","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":7913469,"node_id":"MDEwOlJlcG9zaXRvcnk3OTEzNDY5","name":"ServiceControl","full_name":"Particular/ServiceControl","owner":{"login":"Particular","id":5038441,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMzg0NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/5038441?v=4","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Particular/ServiceControl","description":"Backend for ServiceInsight and ServicePulse","fork":false,"url":"https://api.github.com/repos/Particular/ServiceControl","forks_url":"https://api.github.com/repos/Particular/ServiceControl/forks","keys_url":"https://api.github.com/repos/Particular/ServiceControl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/ServiceControl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/ServiceControl/teams","hooks_url":"https://api.github.com/repos/Particular/ServiceControl/hooks","issue_events_url":"https://api.github.com/repos/Particular/ServiceControl/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/ServiceControl/events","assignees_url":"https://api.github.com/repos/Particular/ServiceControl/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/ServiceControl/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/ServiceControl/tags","blobs_url":"https://api.github.com/repos/Particular/ServiceControl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/ServiceControl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/ServiceControl/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/ServiceControl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/ServiceControl/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/ServiceControl/languages","stargazers_url":"https://api.github.com/repos/Particular/ServiceControl/stargazers","contributors_url":"https://api.github.com/repos/Particular/ServiceControl/contributors","subscribers_url":"https://api.github.com/repos/Particular/ServiceControl/subscribers","subscription_url":"https://api.github.com/repos/Particular/ServiceControl/subscription","commits_url":"https://api.github.com/repos/Particular/ServiceControl/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/ServiceControl/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/ServiceControl/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/ServiceControl/issues/comments{/number}","contents_url":"https://api.github.com/repos/Particular/ServiceControl/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/ServiceControl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/ServiceControl/merges","archive_url":"https://api.github.com/repos/Particular/ServiceControl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/ServiceControl/downloads","issues_url":"https://api.github.com/repos/Particular/ServiceControl/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/ServiceControl/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/ServiceControl/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/ServiceControl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/ServiceControl/labels{/name}","releases_url":"https://api.github.com/repos/Particular/ServiceControl/releases{/id}","deployments_url":"https://api.github.com/repos/Particular/ServiceControl/deployments","created_at":"2013-01-30T11:42:44Z","updated_at":"2018-07-05T12:16:15Z","pushed_at":"2018-07-14T12:40:55Z","git_url":"git://github.com/Particular/ServiceControl.git","ssh_url":"[email protected]:Particular/ServiceControl.git","clone_url":"https://github.com/Particular/ServiceControl.git","svn_url":"https://github.com/Particular/ServiceControl","homepage":"https://docs.particular.net/servicecontrol/","size":48507,"stargazers_count":17,"watchers_count":17,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":29,"mirror_url":null,"archived":false,"open_issues_count":95,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":29,"open_issues":95,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Particular/ServiceControl/pulls/1222"},"html":{"href":"https://github.com/Particular/ServiceControl/pull/1222"},"issue":{"href":"https://api.github.com/repos/Particular/ServiceControl/issues/1222"},"comments":{"href":"https://api.github.com/repos/Particular/ServiceControl/issues/1222/comments"},"review_comments":{"href":"https://api.github.com/repos/Particular/ServiceControl/pulls/1222/comments"},"review_comment":{"href":"https://api.github.com/repos/Particular/ServiceControl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Particular/ServiceControl/pulls/1222/commits"},"statuses":{"href":"https://api.github.com/repos/Particular/ServiceControl/statuses/687814e87fd9c386383470291777835bff6c273f"}},"author_association":"MEMBER"}} | {
"id": 7913469,
"name": "Particular/ServiceControl",
"url": "https://api.github.com/repos/Particular/ServiceControl"
} | {
"id": 753669,
"login": "bording",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/753669?",
"url": "https://api.github.com/users/bording"
} | {
"id": 5038441,
"login": "Particular",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5038441?",
"url": "https://api.github.com/orgs/Particular"
} | 2018-07-14T14:56:12 | 7965897180 | {"actor":{"display_login":"bording"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Particular/docs.particular.net/pulls/comments/225279955","pull_request_review_id":164849220,"id":225279955,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTI3OTk1NQ==","diff_hunk":"@@ -1,5 +1,5 @@\n \n-### Promotion\n+## Promotion\n \n As stated above, scripts are created in the target project output directory. Generally this directory will be excluded from source control. To add created scripts to source control they can be \"promoted\".","path":"persistence/sql/controlling-script-generation_promote_sqlpersistence_[2,).partial.md","position":5,"original_position":5,"commit_id":"ae0a04736e0cd6dfd8c2e9b4bfdd6ea0ed440c1b","original_commit_id":"ae0a04736e0cd6dfd8c2e9b4bfdd6ea0ed440c1b","user":{"login":"bording","id":753669,"node_id":"MDQ6VXNlcjc1MzY2OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/753669?v=4","gravatar_id":"","url":"https://api.github.com/users/bording","html_url":"https://github.com/bording","followers_url":"https://api.github.com/users/bording/followers","following_url":"https://api.github.com/users/bording/following{/other_user}","gists_url":"https://api.github.com/users/bording/gists{/gist_id}","starred_url":"https://api.github.com/users/bording/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bording/subscriptions","organizations_url":"https://api.github.com/users/bording/orgs","repos_url":"https://api.github.com/users/bording/repos","events_url":"https://api.github.com/users/bording/events{/privacy}","received_events_url":"https://api.github.com/users/bording/received_events","type":"User","site_admin":false},"body":"\"promoted\" why?","created_at":"2018-10-15T18:58:12Z","updated_at":"2018-10-15T18:58:59Z","html_url":"https://github.com/Particular/docs.particular.net/pull/4067#discussion_r225279955","pull_request_url":"https://api.github.com/repos/Particular/docs.particular.net/pulls/4067","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Particular/docs.particular.net/pulls/comments/225279955"},"html":{"href":"https://github.com/Particular/docs.particular.net/pull/4067#discussion_r225279955"},"pull_request":{"href":"https://api.github.com/repos/Particular/docs.particular.net/pulls/4067"}}},"pull_request":{"url":"https://api.github.com/repos/Particular/docs.particular.net/pulls/4067","id":223002594,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMDAyNTk0","html_url":"https://github.com/Particular/docs.particular.net/pull/4067","diff_url":"https://github.com/Particular/docs.particular.net/pull/4067.diff","patch_url":"https://github.com/Particular/docs.particular.net/pull/4067.patch","issue_url":"https://api.github.com/repos/Particular/docs.particular.net/issues/4067","number":4067,"state":"open","locked":false,"title":"[WIP] SqlP 4.3 doco","user":{"login":"DavidBoike","id":427110,"node_id":"MDQ6VXNlcjQyNzExMA==","avatar_url":"https://avatars3.githubusercontent.com/u/427110?v=4","gravatar_id":"","url":"https://api.github.com/users/DavidBoike","html_url":"https://github.com/DavidBoike","followers_url":"https://api.github.com/users/DavidBoike/followers","following_url":"https://api.github.com/users/DavidBoike/following{/other_user}","gists_url":"https://api.github.com/users/DavidBoike/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidBoike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidBoike/subscriptions","organizations_url":"https://api.github.com/users/DavidBoike/orgs","repos_url":"https://api.github.com/users/DavidBoike/repos","events_url":"https://api.github.com/users/DavidBoike/events{/privacy}","received_events_url":"https://api.github.com/users/DavidBoike/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-15T18:36:50Z","updated_at":"2018-10-15T18:58:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4ab1f6dbad112a8909a764471c71fe10b763e9a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Particular/docs.particular.net/pulls/4067/commits","review_comments_url":"https://api.github.com/repos/Particular/docs.particular.net/pulls/4067/comments","review_comment_url":"https://api.github.com/repos/Particular/docs.particular.net/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Particular/docs.particular.net/issues/4067/comments","statuses_url":"https://api.github.com/repos/Particular/docs.particular.net/statuses/ae0a04736e0cd6dfd8c2e9b4bfdd6ea0ed440c1b","head":{"label":"Particular:sqlp-4.3","ref":"sqlp-4.3","sha":"ae0a04736e0cd6dfd8c2e9b4bfdd6ea0ed440c1b","user":{"login":"Particular","id":5038441,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMzg0NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/5038441?v=4","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":11727301,"node_id":"MDEwOlJlcG9zaXRvcnkxMTcyNzMwMQ==","name":"docs.particular.net","full_name":"Particular/docs.particular.net","private":false,"owner":{"login":"Particular","id":5038441,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMzg0NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/5038441?v=4","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Particular/docs.particular.net","description":"All content for The Particular Docs Site","fork":false,"url":"https://api.github.com/repos/Particular/docs.particular.net","forks_url":"https://api.github.com/repos/Particular/docs.particular.net/forks","keys_url":"https://api.github.com/repos/Particular/docs.particular.net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/docs.particular.net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/docs.particular.net/teams","hooks_url":"https://api.github.com/repos/Particular/docs.particular.net/hooks","issue_events_url":"https://api.github.com/repos/Particular/docs.particular.net/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/docs.particular.net/events","assignees_url":"https://api.github.com/repos/Particular/docs.particular.net/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/docs.particular.net/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/docs.particular.net/tags","blobs_url":"https://api.github.com/repos/Particular/docs.particular.net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/docs.particular.net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/docs.particular.net/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/docs.particular.net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/docs.particular.net/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/docs.particular.net/languages","stargazers_url":"https://api.github.com/repos/Particular/docs.particular.net/stargazers","contributors_url":"https://api.github.com/repos/Particular/docs.particular.net/contributors","subscribers_url":"https://api.github.com/repos/Particular/docs.particular.net/subscribers","subscription_url":"https://api.github.com/repos/Particular/docs.particular.net/subscription","commits_url":"https://api.github.com/repos/Particular/docs.particular.net/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/docs.particular.net/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/docs.particular.net/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/docs.particular.net/issues/comments{/number}","contents_url":"https://api.github.com/repos/Particular/docs.particular.net/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/docs.particular.net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/docs.particular.net/merges","archive_url":"https://api.github.com/repos/Particular/docs.particular.net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/docs.particular.net/downloads","issues_url":"https://api.github.com/repos/Particular/docs.particular.net/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/docs.particular.net/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/docs.particular.net/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/docs.particular.net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/docs.particular.net/labels{/name}","releases_url":"https://api.github.com/repos/Particular/docs.particular.net/releases{/id}","deployments_url":"https://api.github.com/repos/Particular/docs.particular.net/deployments","created_at":"2013-07-28T23:18:15Z","updated_at":"2018-10-15T17:16:17Z","pushed_at":"2018-10-15T18:54:49Z","git_url":"git://github.com/Particular/docs.particular.net.git","ssh_url":"[email protected]:Particular/docs.particular.net.git","clone_url":"https://github.com/Particular/docs.particular.net.git","svn_url":"https://github.com/Particular/docs.particular.net","homepage":"https://docs.particular.net","size":86534,"stargazers_count":54,"watchers_count":54,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":225,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":225,"open_issues":40,"watchers":54,"default_branch":"master"}},"base":{"label":"Particular:master","ref":"master","sha":"71b64d03185d64adbf730f307a28eadf1fadd74c","user":{"login":"Particular","id":5038441,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMzg0NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/5038441?v=4","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":11727301,"node_id":"MDEwOlJlcG9zaXRvcnkxMTcyNzMwMQ==","name":"docs.particular.net","full_name":"Particular/docs.particular.net","private":false,"owner":{"login":"Particular","id":5038441,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMzg0NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/5038441?v=4","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Particular/docs.particular.net","description":"All content for The Particular Docs Site","fork":false,"url":"https://api.github.com/repos/Particular/docs.particular.net","forks_url":"https://api.github.com/repos/Particular/docs.particular.net/forks","keys_url":"https://api.github.com/repos/Particular/docs.particular.net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/docs.particular.net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/docs.particular.net/teams","hooks_url":"https://api.github.com/repos/Particular/docs.particular.net/hooks","issue_events_url":"https://api.github.com/repos/Particular/docs.particular.net/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/docs.particular.net/events","assignees_url":"https://api.github.com/repos/Particular/docs.particular.net/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/docs.particular.net/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/docs.particular.net/tags","blobs_url":"https://api.github.com/repos/Particular/docs.particular.net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/docs.particular.net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/docs.particular.net/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/docs.particular.net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/docs.particular.net/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/docs.particular.net/languages","stargazers_url":"https://api.github.com/repos/Particular/docs.particular.net/stargazers","contributors_url":"https://api.github.com/repos/Particular/docs.particular.net/contributors","subscribers_url":"https://api.github.com/repos/Particular/docs.particular.net/subscribers","subscription_url":"https://api.github.com/repos/Particular/docs.particular.net/subscription","commits_url":"https://api.github.com/repos/Particular/docs.particular.net/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/docs.particular.net/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/docs.particular.net/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/docs.particular.net/issues/comments{/number}","contents_url":"https://api.github.com/repos/Particular/docs.particular.net/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/docs.particular.net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/docs.particular.net/merges","archive_url":"https://api.github.com/repos/Particular/docs.particular.net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/docs.particular.net/downloads","issues_url":"https://api.github.com/repos/Particular/docs.particular.net/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/docs.particular.net/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/docs.particular.net/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/docs.particular.net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/docs.particular.net/labels{/name}","releases_url":"https://api.github.com/repos/Particular/docs.particular.net/releases{/id}","deployments_url":"https://api.github.com/repos/Particular/docs.particular.net/deployments","created_at":"2013-07-28T23:18:15Z","updated_at":"2018-10-15T17:16:17Z","pushed_at":"2018-10-15T18:54:49Z","git_url":"git://github.com/Particular/docs.particular.net.git","ssh_url":"[email protected]:Particular/docs.particular.net.git","clone_url":"https://github.com/Particular/docs.particular.net.git","svn_url":"https://github.com/Particular/docs.particular.net","homepage":"https://docs.particular.net","size":86534,"stargazers_count":54,"watchers_count":54,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":225,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":225,"open_issues":40,"watchers":54,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Particular/docs.particular.net/pulls/4067"},"html":{"href":"https://github.com/Particular/docs.particular.net/pull/4067"},"issue":{"href":"https://api.github.com/repos/Particular/docs.particular.net/issues/4067"},"comments":{"href":"https://api.github.com/repos/Particular/docs.particular.net/issues/4067/comments"},"review_comments":{"href":"https://api.github.com/repos/Particular/docs.particular.net/pulls/4067/comments"},"review_comment":{"href":"https://api.github.com/repos/Particular/docs.particular.net/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Particular/docs.particular.net/pulls/4067/commits"},"statuses":{"href":"https://api.github.com/repos/Particular/docs.particular.net/statuses/ae0a04736e0cd6dfd8c2e9b4bfdd6ea0ed440c1b"}},"author_association":"MEMBER"}} | {
"id": 11727301,
"name": "Particular/docs.particular.net",
"url": "https://api.github.com/repos/Particular/docs.particular.net"
} | {
"id": 753669,
"login": "bording",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/753669?",
"url": "https://api.github.com/users/bording"
} | {
"id": 5038441,
"login": "Particular",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5038441?",
"url": "https://api.github.com/orgs/Particular"
} | 2018-10-15T18:58:12 | 8423626346 | {"actor":{"display_login":"bording"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/212789445","pull_request_review_id":149501256,"id":212789445,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjc4OTQ0NQ==","diff_hunk":"@@ -559,13 +583,46 @@ unsigned int NetPlayServer::OnData(sf::Packet& packet, Client& player)\n packet >> pad.button >> pad.analogA >> pad.analogB >> pad.stickX >> pad.stickY >>\n pad.substickX >> pad.substickY >> pad.triggerLeft >> pad.triggerRight >> pad.isConnected;\n \n- // Add to packet for relay to clients\n+ if (m_host_input_authority)\n+ {\n+ m_last_pad_status[map] = pad;\n+\n+ if (!m_first_pad_status_received[map])\n+ {\n+ m_first_pad_status_received[map] = true;\n+ SendFirstReceivedToHost(map, true);\n+ }\n+ }\n+ else\n+ {\n+ spac << map << pad.button << pad.analogA << pad.analogB << pad.stickX << pad.stickY\n+ << pad.substickX << pad.substickY << pad.triggerLeft << pad.triggerRight\n+ << pad.isConnected;\n+ }\n+ }\n+\n+ if (!m_host_input_authority)\n+ SendToClients(spac, player.pid);\n+ }\n+ break;\n+\n+ case NP_MSG_PAD_HOST_POLL:\n+ {\n+ sf::Packet spac;\n+ spac << static_cast<MessageId>(NP_MSG_PAD_DATA);\n+\n+ for (PadMapping map = 0; map < 4; map++)\n+ {\n+ if (m_pad_map.at(map) == -1)","path":"Source/Core/Core/NetPlayServer.cpp","position":110,"original_position":110,"commit_id":"f47122c6b08713e12fc23b953750e22f9dcbd974","original_commit_id":"f47122c6b08713e12fc23b953750e22f9dcbd974","user":{"login":"Techjar","id":532821,"node_id":"MDQ6VXNlcjUzMjgyMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/532821?v=4","gravatar_id":"","url":"https://api.github.com/users/Techjar","html_url":"https://github.com/Techjar","followers_url":"https://api.github.com/users/Techjar/followers","following_url":"https://api.github.com/users/Techjar/following{/other_user}","gists_url":"https://api.github.com/users/Techjar/gists{/gist_id}","starred_url":"https://api.github.com/users/Techjar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Techjar/subscriptions","organizations_url":"https://api.github.com/users/Techjar/orgs","repos_url":"https://api.github.com/users/Techjar/repos","events_url":"https://api.github.com/users/Techjar/events{/privacy}","received_events_url":"https://api.github.com/users/Techjar/received_events","type":"User","site_admin":false},"body":"Yeah I guess `at()` is only needed when we can't trust the value being passed.","created_at":"2018-08-25T05:35:41Z","updated_at":"2018-08-25T05:35:41Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/7360#discussion_r212789445","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/7360","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/212789445"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/7360#discussion_r212789445"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/7360"}},"in_reply_to_id":212788549},"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/7360","id":210874486,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwODc0NDg2","html_url":"https://github.com/dolphin-emu/dolphin/pull/7360","diff_url":"https://github.com/dolphin-emu/dolphin/pull/7360.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/7360.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/7360","number":7360,"state":"open","locked":false,"title":"[WIP] NetPlay host input authority mode","user":{"login":"Techjar","id":532821,"node_id":"MDQ6VXNlcjUzMjgyMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/532821?v=4","gravatar_id":"","url":"https://api.github.com/users/Techjar","html_url":"https://github.com/Techjar","followers_url":"https://api.github.com/users/Techjar/followers","following_url":"https://api.github.com/users/Techjar/following{/other_user}","gists_url":"https://api.github.com/users/Techjar/gists{/gist_id}","starred_url":"https://api.github.com/users/Techjar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Techjar/subscriptions","organizations_url":"https://api.github.com/users/Techjar/orgs","repos_url":"https://api.github.com/users/Techjar/repos","events_url":"https://api.github.com/users/Techjar/events{/privacy}","received_events_url":"https://api.github.com/users/Techjar/received_events","type":"User","site_admin":false},"body":"Currently, each player buffers their own inputs and sends them to the host. The host then relays those inputs to everyone else. Every player waits on inputs from all players to be buffered before continuing. What this means is all clients run in lockstep, and the total latency of inputs cannot be lower than the sum of the 2 highest client ping times in the game (in 3+ player sessions with people across the world, the latency can be very high).\r\n\r\nHost input authority mode changes it so players no longer buffer their own inputs, and only send them to the host. The host stores only the most recent input received from a player. The host then sends inputs for all pads at the SI poll interval, similar to the existing code. If a player sends inputs to slowly, their last received input is simply sent again. If they send too quickly, inputs are dropped. This means that the host has full control over what inputs are actually read by the game, hence the name of the mode. Also, because the rate at which inputs are received by SI is decoupled from the rate at which players are sending inputs, clients are no longer dependent on each other. They only care what the host is doing. This means that they can set their buffer individually based on their latency to the host, rather than the highest latency between any 2 players, allowing someone with lower ping to the host to have less latency than someone else.\r\n\r\nThis is a catch to this: as a necessity of how the host's input sending works, the host has 0 latency. They can work around this, however, by running a second instance of Dolphin and setting the host one as a spectator (assuming their hardware can handle it). Having differing latency between players would be considered unfair for competitive play, but for casual play we don't really care. For this reason though, combined with the potential for a few inputs to be dropped on a bad connection, the old mode will remain and this new mode is entirely optional.","created_at":"2018-08-25T00:18:32Z","updated_at":"2018-08-25T05:35:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e6bed7914b0022495c1cec9f1b5abe3fe1488c0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/7360/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/7360/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/7360/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/f47122c6b08713e12fc23b953750e22f9dcbd974","head":{"label":"Techjar:netplay-host-input-authority","ref":"netplay-host-input-authority","sha":"f47122c6b08713e12fc23b953750e22f9dcbd974","user":{"login":"Techjar","id":532821,"node_id":"MDQ6VXNlcjUzMjgyMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/532821?v=4","gravatar_id":"","url":"https://api.github.com/users/Techjar","html_url":"https://github.com/Techjar","followers_url":"https://api.github.com/users/Techjar/followers","following_url":"https://api.github.com/users/Techjar/following{/other_user}","gists_url":"https://api.github.com/users/Techjar/gists{/gist_id}","starred_url":"https://api.github.com/users/Techjar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Techjar/subscriptions","organizations_url":"https://api.github.com/users/Techjar/orgs","repos_url":"https://api.github.com/users/Techjar/repos","events_url":"https://api.github.com/users/Techjar/events{/privacy}","received_events_url":"https://api.github.com/users/Techjar/received_events","type":"User","site_admin":false},"repo":{"id":77421300,"node_id":"MDEwOlJlcG9zaXRvcnk3NzQyMTMwMA==","name":"dolphin","full_name":"Techjar/dolphin","owner":{"login":"Techjar","id":532821,"node_id":"MDQ6VXNlcjUzMjgyMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/532821?v=4","gravatar_id":"","url":"https://api.github.com/users/Techjar","html_url":"https://github.com/Techjar","followers_url":"https://api.github.com/users/Techjar/followers","following_url":"https://api.github.com/users/Techjar/following{/other_user}","gists_url":"https://api.github.com/users/Techjar/gists{/gist_id}","starred_url":"https://api.github.com/users/Techjar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Techjar/subscriptions","organizations_url":"https://api.github.com/users/Techjar/orgs","repos_url":"https://api.github.com/users/Techjar/repos","events_url":"https://api.github.com/users/Techjar/events{/privacy}","received_events_url":"https://api.github.com/users/Techjar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Techjar/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":true,"url":"https://api.github.com/repos/Techjar/dolphin","forks_url":"https://api.github.com/repos/Techjar/dolphin/forks","keys_url":"https://api.github.com/repos/Techjar/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Techjar/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Techjar/dolphin/teams","hooks_url":"https://api.github.com/repos/Techjar/dolphin/hooks","issue_events_url":"https://api.github.com/repos/Techjar/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/Techjar/dolphin/events","assignees_url":"https://api.github.com/repos/Techjar/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/Techjar/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/Techjar/dolphin/tags","blobs_url":"https://api.github.com/repos/Techjar/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Techjar/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Techjar/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/Techjar/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Techjar/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/Techjar/dolphin/languages","stargazers_url":"https://api.github.com/repos/Techjar/dolphin/stargazers","contributors_url":"https://api.github.com/repos/Techjar/dolphin/contributors","subscribers_url":"https://api.github.com/repos/Techjar/dolphin/subscribers","subscription_url":"https://api.github.com/repos/Techjar/dolphin/subscription","commits_url":"https://api.github.com/repos/Techjar/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/Techjar/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/Techjar/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/Techjar/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/Techjar/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/Techjar/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Techjar/dolphin/merges","archive_url":"https://api.github.com/repos/Techjar/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Techjar/dolphin/downloads","issues_url":"https://api.github.com/repos/Techjar/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/Techjar/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/Techjar/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/Techjar/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Techjar/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/Techjar/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/Techjar/dolphin/deployments","created_at":"2016-12-27T03:00:03Z","updated_at":"2016-12-27T03:00:29Z","pushed_at":"2018-08-25T01:51:19Z","git_url":"git://github.com/Techjar/dolphin.git","ssh_url":"[email protected]:Techjar/dolphin.git","clone_url":"https://github.com/Techjar/dolphin.git","svn_url":"https://github.com/Techjar/dolphin","homepage":"https://dolphin-emu.org/","size":329586,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"476037d1f232779f30e40d63dc5c7a0d352b2d2c","user":{"login":"dolphin-emu","id":5050316,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwNTAzMTY=","avatar_url":"https://avatars2.githubusercontent.com/u/5050316?v=4","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU3NzMwNA==","name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwNTAzMTY=","avatar_url":"https://avatars2.githubusercontent.com/u/5050316?v=4","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/dolphin-emu/dolphin/deployments","created_at":"2013-07-22T09:07:57Z","updated_at":"2018-08-25T04:51:10Z","pushed_at":"2018-08-25T01:51:21Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"[email protected]:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":"https://dolphin-emu.org/","size":366824,"stargazers_count":4622,"watchers_count":4622,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1103,"mirror_url":null,"archived":false,"open_issues_count":112,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1103,"open_issues":112,"watchers":4622,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/7360"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/7360"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/7360"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/7360/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/7360/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/7360/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/f47122c6b08713e12fc23b953750e22f9dcbd974"}},"author_association":"CONTRIBUTOR"}} | {
"id": 11577304,
"name": "dolphin-emu/dolphin",
"url": "https://api.github.com/repos/dolphin-emu/dolphin"
} | {
"id": 532821,
"login": "Techjar",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/532821?",
"url": "https://api.github.com/users/Techjar"
} | {
"id": 5050316,
"login": "dolphin-emu",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5050316?",
"url": "https://api.github.com/orgs/dolphin-emu"
} | 2018-08-25T05:35:41 | 8166188195 | {"actor":{"display_login":"Techjar"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/245477449","pull_request_review_id":189596471,"id":245477449,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTQ3NzQ0OQ==","diff_hunk":"@@ -208,6 +209,55 @@ void CodeViewWidget::ReplaceAddress(u32 address, ReplaceWith replace)\n Update();\n }\n \n+bool CodeViewWidget::IsInstructionLoadStore(std::string instruction)\n+{\n+ // Could add check for context address being near PC, because we need gprs to be correct for the\n+ // load/store.\n+ if ((instruction.compare(0, 2, \"st\") != 0 && instruction.compare(0, 1, \"l\") != 0 &&\n+ instruction.compare(0, 5, \"psq_l\") != 0 && instruction.compare(0, 5, \"psq_s\") != 0) ||\n+ instruction.compare(0, 2, \"li\") == 0)\n+ return false;\n+ else\n+ return true;\n+}\n+\n+void CodeViewWidget::OnCopyTargetAddress()\n+{\n+ const std::string codeline = PowerPC::debug_interface.Disassemble(GetContextAddress());\n+\n+ if (!IsInstructionLoadStore(codeline))\n+ return;\n+\n+ const u32 addr = PowerPC::debug_interface.GetMemoryAddressFromInstruction(codeline);","path":"Source/Core/DolphinQt/Debugger/CodeViewWidget.cpp","position":31,"original_position":31,"commit_id":"3ceb748dad4c9e26ed20210578643c98627f0fe9","original_commit_id":"3ceb748dad4c9e26ed20210578643c98627f0fe9","user":{"login":"TryTwo","id":10532806,"node_id":"MDQ6VXNlcjEwNTMyODA2","avatar_url":"https://avatars0.githubusercontent.com/u/10532806?v=4","gravatar_id":"","url":"https://api.github.com/users/TryTwo","html_url":"https://github.com/TryTwo","followers_url":"https://api.github.com/users/TryTwo/followers","following_url":"https://api.github.com/users/TryTwo/following{/other_user}","gists_url":"https://api.github.com/users/TryTwo/gists{/gist_id}","starred_url":"https://api.github.com/users/TryTwo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TryTwo/subscriptions","organizations_url":"https://api.github.com/users/TryTwo/orgs","repos_url":"https://api.github.com/users/TryTwo/repos","events_url":"https://api.github.com/users/TryTwo/events{/privacy}","received_events_url":"https://api.github.com/users/TryTwo/received_events","type":"User","site_admin":false},"body":"I don't mind making it longer, but all the other functions use addr instead of address, so I probably should leave it for consistency?","created_at":"2019-01-05T13:06:59Z","updated_at":"2019-01-05T13:06:59Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/7675#discussion_r245477449","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/7675","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/245477449"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/7675#discussion_r245477449"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/7675"}},"in_reply_to_id":245399217},"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/7675","id":242345840,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyMzQ1ODQw","html_url":"https://github.com/dolphin-emu/dolphin/pull/7675","diff_url":"https://github.com/dolphin-emu/dolphin/pull/7675.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/7675.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/7675","number":7675,"state":"open","locked":false,"title":"Debugger code features","user":{"login":"TryTwo","id":10532806,"node_id":"MDQ6VXNlcjEwNTMyODA2","avatar_url":"https://avatars0.githubusercontent.com/u/10532806?v=4","gravatar_id":"","url":"https://api.github.com/users/TryTwo","html_url":"https://github.com/TryTwo","followers_url":"https://api.github.com/users/TryTwo/followers","following_url":"https://api.github.com/users/TryTwo/following{/other_user}","gists_url":"https://api.github.com/users/TryTwo/gists{/gist_id}","starred_url":"https://api.github.com/users/TryTwo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TryTwo/subscriptions","organizations_url":"https://api.github.com/users/TryTwo/orgs","repos_url":"https://api.github.com/users/TryTwo/repos","events_url":"https://api.github.com/users/TryTwo/events{/privacy}","received_events_url":"https://api.github.com/users/TryTwo/received_events","type":"User","site_admin":false},"body":"Backend:\r\nUpdates disassembler instructions. Mostly spaces and commas. PS load/store uses 0x notation. Required for new features.\r\nAdds function to PPCDebugInterface to calculate target memory address for load/store instructions.\r\n\r\nCode widget new features:\r\n-Tracing instructions step-by-step between two points. Follow specific registers/values through the trace or backtrace.\r\n-Function recording then differencing to find specific functions based on when they run.\r\n-Context menu for copying or breakpointing the memory target in load/store instructions. Only works if the PC is near the instruction (register consistency).","created_at":"2019-01-04T19:04:30Z","updated_at":"2019-01-05T13:06:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ffaed8ac489b4f65fd2af004b6175b4ae3d2ad49","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/7675/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/7675/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/7675/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/3ceb748dad4c9e26ed20210578643c98627f0fe9","head":{"label":"TryTwo:Debugger_Code_Features","ref":"Debugger_Code_Features","sha":"3ceb748dad4c9e26ed20210578643c98627f0fe9","user":{"login":"TryTwo","id":10532806,"node_id":"MDQ6VXNlcjEwNTMyODA2","avatar_url":"https://avatars0.githubusercontent.com/u/10532806?v=4","gravatar_id":"","url":"https://api.github.com/users/TryTwo","html_url":"https://github.com/TryTwo","followers_url":"https://api.github.com/users/TryTwo/followers","following_url":"https://api.github.com/users/TryTwo/following{/other_user}","gists_url":"https://api.github.com/users/TryTwo/gists{/gist_id}","starred_url":"https://api.github.com/users/TryTwo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TryTwo/subscriptions","organizations_url":"https://api.github.com/users/TryTwo/orgs","repos_url":"https://api.github.com/users/TryTwo/repos","events_url":"https://api.github.com/users/TryTwo/events{/privacy}","received_events_url":"https://api.github.com/users/TryTwo/received_events","type":"User","site_admin":false},"repo":{"id":154287647,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQyODc2NDc=","name":"dolphin","full_name":"TryTwo/dolphin","private":false,"owner":{"login":"TryTwo","id":10532806,"node_id":"MDQ6VXNlcjEwNTMyODA2","avatar_url":"https://avatars0.githubusercontent.com/u/10532806?v=4","gravatar_id":"","url":"https://api.github.com/users/TryTwo","html_url":"https://github.com/TryTwo","followers_url":"https://api.github.com/users/TryTwo/followers","following_url":"https://api.github.com/users/TryTwo/following{/other_user}","gists_url":"https://api.github.com/users/TryTwo/gists{/gist_id}","starred_url":"https://api.github.com/users/TryTwo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TryTwo/subscriptions","organizations_url":"https://api.github.com/users/TryTwo/orgs","repos_url":"https://api.github.com/users/TryTwo/repos","events_url":"https://api.github.com/users/TryTwo/events{/privacy}","received_events_url":"https://api.github.com/users/TryTwo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/TryTwo/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":true,"url":"https://api.github.com/repos/TryTwo/dolphin","forks_url":"https://api.github.com/repos/TryTwo/dolphin/forks","keys_url":"https://api.github.com/repos/TryTwo/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TryTwo/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TryTwo/dolphin/teams","hooks_url":"https://api.github.com/repos/TryTwo/dolphin/hooks","issue_events_url":"https://api.github.com/repos/TryTwo/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/TryTwo/dolphin/events","assignees_url":"https://api.github.com/repos/TryTwo/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/TryTwo/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/TryTwo/dolphin/tags","blobs_url":"https://api.github.com/repos/TryTwo/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TryTwo/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TryTwo/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/TryTwo/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TryTwo/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/TryTwo/dolphin/languages","stargazers_url":"https://api.github.com/repos/TryTwo/dolphin/stargazers","contributors_url":"https://api.github.com/repos/TryTwo/dolphin/contributors","subscribers_url":"https://api.github.com/repos/TryTwo/dolphin/subscribers","subscription_url":"https://api.github.com/repos/TryTwo/dolphin/subscription","commits_url":"https://api.github.com/repos/TryTwo/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/TryTwo/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/TryTwo/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/TryTwo/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/TryTwo/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/TryTwo/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TryTwo/dolphin/merges","archive_url":"https://api.github.com/repos/TryTwo/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TryTwo/dolphin/downloads","issues_url":"https://api.github.com/repos/TryTwo/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/TryTwo/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/TryTwo/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/TryTwo/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TryTwo/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/TryTwo/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/TryTwo/dolphin/deployments","created_at":"2018-10-23T08:04:11Z","updated_at":"2018-10-30T06:22:24Z","pushed_at":"2019-01-05T11:09:11Z","git_url":"git://github.com/TryTwo/dolphin.git","ssh_url":"[email protected]:TryTwo/dolphin.git","clone_url":"https://github.com/TryTwo/dolphin.git","svn_url":"https://github.com/TryTwo/dolphin","homepage":"https://dolphin-emu.org/","size":335638,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"931af76da322129da54b4361bc18ba772610c5fd","user":{"login":"dolphin-emu","id":5050316,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwNTAzMTY=","avatar_url":"https://avatars2.githubusercontent.com/u/5050316?v=4","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU3NzMwNA==","name":"dolphin","full_name":"dolphin-emu/dolphin","private":false,"owner":{"login":"dolphin-emu","id":5050316,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwNTAzMTY=","avatar_url":"https://avatars2.githubusercontent.com/u/5050316?v=4","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/dolphin-emu/dolphin/deployments","created_at":"2013-07-22T09:07:57Z","updated_at":"2019-01-05T10:57:59Z","pushed_at":"2019-01-05T11:10:43Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"[email protected]:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":"https://dolphin-emu.org/","size":372890,"stargazers_count":4936,"watchers_count":4936,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1159,"mirror_url":null,"archived":false,"open_issues_count":132,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1159,"open_issues":132,"watchers":4936,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/7675"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/7675"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/7675"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/7675/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/7675/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/7675/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/3ceb748dad4c9e26ed20210578643c98627f0fe9"}},"author_association":"CONTRIBUTOR"}} | {
"id": 11577304,
"name": "dolphin-emu/dolphin",
"url": "https://api.github.com/repos/dolphin-emu/dolphin"
} | {
"id": 10532806,
"login": "TryTwo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10532806?",
"url": "https://api.github.com/users/TryTwo"
} | {
"id": 5050316,
"login": "dolphin-emu",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5050316?",
"url": "https://api.github.com/orgs/dolphin-emu"
} | 2019-01-05T13:06:59 | 8838056749 | {"actor":{"display_login":"TryTwo"}} |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.