File size: 8,922 Bytes
eb67da4 |
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 |
import pytest
from starkware.starknet.testing.starknet import Starknet
from signers import MockSigner
from utils import (
assert_revert,
assert_revert_entry_point,
assert_event_emitted,
get_contract_class,
cached_contract
)
# random value
VALUE_1 = 123
VALUE_2 = 987
signer = MockSigner(123456789987654321)
@pytest.fixture(scope='module')
def contract_classes():
account_cls = get_contract_class('openzeppelin/account/Account.cairo')
v1_cls = get_contract_class('tests/mocks/upgrades_v1_mock.cairo')
v2_cls = get_contract_class('tests/mocks/upgrades_v2_mock.cairo')
proxy_cls = get_contract_class('openzeppelin/upgrades/Proxy.cairo')
return account_cls, v1_cls, v2_cls, proxy_cls
@pytest.fixture(scope='module')
async def proxy_init(contract_classes):
account_cls, v1_cls, v2_cls, proxy_cls = contract_classes
starknet = await Starknet.empty()
account1 = await starknet.deploy(
contract_class=account_cls,
constructor_calldata=[signer.public_key]
)
account2 = await starknet.deploy(
contract_class=account_cls,
constructor_calldata=[signer.public_key]
)
v1_decl = await starknet.declare(
contract_class=v1_cls,
)
v2_decl = await starknet.declare(
contract_class=v2_cls,
)
proxy = await starknet.deploy(
contract_class=proxy_cls,
constructor_calldata=[v1_decl.class_hash]
)
return (
starknet.state,
account1,
account2,
v1_decl,
v2_decl,
proxy
)
@pytest.fixture
def proxy_factory(contract_classes, proxy_init):
account_cls, _, _, proxy_cls = contract_classes
state, account1, account2, v1_decl, v2_decl, proxy = proxy_init
_state = state.copy()
account1 = cached_contract(_state, account_cls, account1)
account2 = cached_contract(_state, account_cls, account2)
proxy = cached_contract(_state, proxy_cls, proxy)
return account1, account2, proxy, v1_decl, v2_decl
@pytest.fixture
async def after_upgrade(proxy_factory):
admin, other, proxy, v1_decl, v2_decl = proxy_factory
# initialize, set value, and upgrade to v2
await signer.send_transactions(
admin,
[
(proxy.contract_address, 'initializer', [admin.contract_address]),
(proxy.contract_address, 'setValue1', [VALUE_1]),
(proxy.contract_address, 'upgrade', [v2_decl.class_hash])
]
)
return admin, other, proxy, v1_decl, v2_decl
@pytest.mark.asyncio
async def test_initializer(proxy_factory):
admin, _, proxy, *_ = proxy_factory
await signer.send_transaction(
admin, proxy.contract_address, 'initializer', [
admin.contract_address
]
)
@pytest.mark.asyncio
async def test_initializer_already_initialized(proxy_factory):
admin, _, proxy, *_ = proxy_factory
await signer.send_transaction(
admin, proxy.contract_address, 'initializer', [
admin.contract_address
]
)
await assert_revert(
signer.send_transaction(
admin, proxy.contract_address, 'initializer', [
admin.contract_address
]
),
reverted_with='Proxy: contract already initialized'
)
@pytest.mark.asyncio
async def test_upgrade(proxy_factory):
admin, _, proxy, _, v2_decl = proxy_factory
# initialize and set value
await signer.send_transactions(
admin,
[
(proxy.contract_address, 'initializer', [admin.contract_address]),
(proxy.contract_address, 'setValue1', [VALUE_1]),
]
)
# check value
execution_info = await signer.send_transaction(
admin, proxy.contract_address, 'getValue1', []
)
assert execution_info.result.response == [VALUE_1]
# upgrade
await signer.send_transaction(
admin, proxy.contract_address, 'upgrade', [
v2_decl.class_hash
]
)
# check value
execution_info = await signer.send_transaction(
admin, proxy.contract_address, 'getValue1', []
)
assert execution_info.result.response == [VALUE_1]
@pytest.mark.asyncio
async def test_upgrade_event(proxy_factory):
admin, _, proxy, _, v2_decl = proxy_factory
# initialize implementation
await signer.send_transaction(
admin, proxy.contract_address, 'initializer', [
admin.contract_address
]
)
# upgrade
tx_exec_info = await signer.send_transaction(
admin, proxy.contract_address, 'upgrade', [
v2_decl.class_hash
]
)
# check event
assert_event_emitted(
tx_exec_info,
from_address=proxy.contract_address,
name='Upgraded',
data=[
v2_decl.class_hash # new class hash
]
)
@pytest.mark.asyncio
async def test_upgrade_from_non_admin(proxy_factory):
admin, non_admin, proxy, _, v2_decl = proxy_factory
# initialize implementation
await signer.send_transaction(
admin, proxy.contract_address, 'initializer', [
admin.contract_address
]
)
# upgrade should revert
await assert_revert(
signer.send_transaction(
non_admin, proxy.contract_address, 'upgrade', [
v2_decl.class_hash
]
),
reverted_with="Proxy: caller is not admin"
)
@pytest.mark.asyncio
async def test_implementation_v2(after_upgrade):
admin, _, proxy, _, v2_decl = after_upgrade
execution_info = await signer.send_transactions(
admin,
[
(proxy.contract_address, 'getImplementationHash', []),
(proxy.contract_address, 'getAdmin', []),
(proxy.contract_address, 'getValue1', [])
]
)
expected = [
v2_decl.class_hash, # getImplementationHash
admin.contract_address, # getAdmin
VALUE_1 # getValue1
]
assert execution_info.result.response == expected
#
# v2 functions
#
@pytest.mark.asyncio
async def test_set_admin(after_upgrade):
admin, new_admin, proxy, *_ = after_upgrade
# change admin
await signer.send_transaction(
admin, proxy.contract_address, 'setAdmin', [
new_admin.contract_address
]
)
# check admin
execution_info = await signer.send_transaction(
admin, proxy.contract_address, 'getAdmin', []
)
assert execution_info.result.response == [new_admin.contract_address]
@pytest.mark.asyncio
async def test_set_admin_from_non_admin(after_upgrade):
_, non_admin, proxy, *_ = after_upgrade
# should revert
await assert_revert(signer.send_transaction(
non_admin, proxy.contract_address, 'setAdmin', [non_admin.contract_address]),
reverted_with="Proxy: caller is not admin"
)
@pytest.mark.asyncio
async def test_v2_functions_pre_and_post_upgrade(proxy_factory):
admin, new_admin, proxy, _, v2_decl = proxy_factory
# initialize
await signer.send_transaction(
admin, proxy.contract_address, 'initializer', [
admin.contract_address
]
)
# check getValue2 doesn't exist
await assert_revert_entry_point(
signer.send_transaction(
admin, proxy.contract_address, 'getValue2', []
),
invalid_selector='getValue2'
)
# check setValue2 doesn't exist in v1
await assert_revert_entry_point(
signer.send_transaction(
admin, proxy.contract_address, 'setValue2', [VALUE_2]
),
invalid_selector='setValue2'
)
# check getAdmin doesn't exist in v1
await assert_revert_entry_point(
signer.send_transaction(
admin, proxy.contract_address, 'getAdmin', []
),
invalid_selector='getAdmin'
)
# check setAdmin doesn't exist in v1
await assert_revert_entry_point(
signer.send_transaction(
admin, proxy.contract_address, 'setAdmin', [new_admin.contract_address]
),
invalid_selector='setAdmin'
)
# upgrade
await signer.send_transaction(
admin, proxy.contract_address, 'upgrade', [
v2_decl.class_hash
]
)
# set value 2 and admin
await signer.send_transactions(
admin,
[
(proxy.contract_address, 'setValue2', [VALUE_2]),
(proxy.contract_address, 'setAdmin', [new_admin.contract_address])
]
)
# check value 2 and admin
execution_info = await signer.send_transactions(
admin,
[
(proxy.contract_address, 'getValue2', []),
(proxy.contract_address, 'getAdmin', [])
]
)
expected = [
VALUE_2, # getValue2
new_admin.contract_address # getAdmin
]
assert execution_info.result.response == expected
|