File size: 9,280 Bytes
b98ffbb |
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 |
use dora_core::{
config::NodeId,
daemon_messages::{DaemonReply, DaemonRequest, DropToken, NodeEvent, Timestamped},
message::uhlc::{self, Timestamp},
};
use eyre::{eyre, Context};
use flume::RecvTimeoutError;
use std::{
sync::Arc,
time::{Duration, Instant},
};
use crate::daemon_connection::DaemonChannel;
pub fn init(
node_id: NodeId,
tx: flume::Sender<EventItem>,
channel: DaemonChannel,
clock: Arc<uhlc::HLC>,
) -> eyre::Result<EventStreamThreadHandle> {
let node_id_cloned = node_id.clone();
let join_handle = std::thread::spawn(|| event_stream_loop(node_id_cloned, tx, channel, clock));
Ok(EventStreamThreadHandle::new(node_id, join_handle))
}
#[derive(Debug)]
pub enum EventItem {
NodeEvent {
event: NodeEvent,
ack_channel: flume::Sender<()>,
},
FatalError(eyre::Report),
TimeoutError(eyre::Report),
}
pub struct EventStreamThreadHandle {
node_id: NodeId,
handle: flume::Receiver<std::thread::Result<()>>,
}
impl EventStreamThreadHandle {
fn new(node_id: NodeId, join_handle: std::thread::JoinHandle<()>) -> Self {
let (tx, rx) = flume::bounded(1);
std::thread::spawn(move || {
let _ = tx.send(join_handle.join());
});
Self {
node_id,
handle: rx,
}
}
}
impl Drop for EventStreamThreadHandle {
#[tracing::instrument(skip(self), fields(node_id = %self.node_id))]
fn drop(&mut self) {
if self.handle.is_empty() {
tracing::trace!("waiting for event stream thread");
}
match self.handle.recv_timeout(Duration::from_secs(20)) {
Ok(Ok(())) => {
tracing::trace!("event stream thread finished");
}
Ok(Err(_)) => {
tracing::error!("event stream thread panicked");
}
Err(RecvTimeoutError::Timeout) => {
tracing::warn!("timeout while waiting for event stream thread");
}
Err(RecvTimeoutError::Disconnected) => {
tracing::warn!("event stream thread result channel closed unexpectedly");
}
}
}
}
#[tracing::instrument(skip(tx, channel, clock))]
fn event_stream_loop(
node_id: NodeId,
tx: flume::Sender<EventItem>,
mut channel: DaemonChannel,
clock: Arc<uhlc::HLC>,
) {
let mut tx = Some(tx);
let mut pending_drop_tokens: Vec<(DropToken, flume::Receiver<()>, Instant, u64)> = Vec::new();
let mut drop_tokens = Vec::new();
let result = 'outer: loop {
if let Err(err) = handle_pending_drop_tokens(&mut pending_drop_tokens, &mut drop_tokens) {
break 'outer Err(err);
}
let daemon_request = Timestamped {
inner: DaemonRequest::NextEvent {
drop_tokens: std::mem::take(&mut drop_tokens),
},
timestamp: clock.new_timestamp(),
};
let events = match channel.request(&daemon_request) {
Ok(DaemonReply::NextEvents(events)) => {
if events.is_empty() {
tracing::trace!("event stream closed for node `{node_id}`");
break Ok(());
} else {
events
}
}
Ok(other) => {
let err = eyre!("unexpected control reply: {other:?}");
tracing::warn!("{err:?}");
continue;
}
Err(err) => {
let err = eyre!(err).wrap_err("failed to receive incoming event");
tracing::warn!("{err:?}");
continue;
}
};
for Timestamped { inner, timestamp } in events {
if let Err(err) = clock.update_with_timestamp(×tamp) {
tracing::warn!("failed to update HLC: {err}");
}
let drop_token = match &inner {
NodeEvent::Input {
data: Some(data), ..
} => data.drop_token(),
NodeEvent::AllInputsClosed => {
// close the event stream
tx = None;
// skip this internal event
continue;
}
_ => None,
};
if let Some(tx) = tx.as_ref() {
let (drop_tx, drop_rx) = flume::bounded(0);
match tx.send(EventItem::NodeEvent {
event: inner,
ack_channel: drop_tx,
}) {
Ok(()) => {}
Err(send_error) => {
let event = send_error.into_inner();
tracing::trace!(
"event channel was closed already, could not forward `{event:?}`"
);
break 'outer Ok(());
}
}
if let Some(token) = drop_token {
pending_drop_tokens.push((token, drop_rx, Instant::now(), 1));
}
} else {
tracing::warn!("dropping event because event `tx` was already closed: `{inner:?}`");
}
}
};
if let Err(err) = result {
if let Some(tx) = tx.as_ref() {
if let Err(flume::SendError(item)) = tx.send(EventItem::FatalError(err)) {
let err = match item {
EventItem::FatalError(err) => err,
_ => unreachable!(),
};
tracing::error!("failed to report fatal EventStream error: {err:?}");
}
} else {
tracing::error!("received error event after `tx` was closed: {err:?}");
}
}
if let Err(err) = report_remaining_drop_tokens(
channel,
drop_tokens,
pending_drop_tokens,
clock.new_timestamp(),
)
.context("failed to report remaining drop tokens")
{
tracing::warn!("{err:?}");
}
}
fn handle_pending_drop_tokens(
pending_drop_tokens: &mut Vec<(DropToken, flume::Receiver<()>, Instant, u64)>,
drop_tokens: &mut Vec<DropToken>,
) -> eyre::Result<()> {
let mut still_pending = Vec::new();
for (token, rx, since, warn) in pending_drop_tokens.drain(..) {
match rx.try_recv() {
Ok(()) => return Err(eyre!("Node API should not send anything on ACK channel")),
Err(flume::TryRecvError::Disconnected) => {
// the event was dropped -> add the drop token to the list
drop_tokens.push(token);
}
Err(flume::TryRecvError::Empty) => {
let duration = Duration::from_secs(30 * warn);
if since.elapsed() > duration {
tracing::warn!("timeout: token {token:?} was not dropped after {duration:?}");
}
still_pending.push((token, rx, since, warn + 1));
}
}
}
*pending_drop_tokens = still_pending;
Ok(())
}
fn report_remaining_drop_tokens(
mut channel: DaemonChannel,
mut drop_tokens: Vec<DropToken>,
mut pending_drop_tokens: Vec<(DropToken, flume::Receiver<()>, Instant, u64)>,
timestamp: Timestamp,
) -> eyre::Result<()> {
while !(pending_drop_tokens.is_empty() && drop_tokens.is_empty()) {
report_drop_tokens(&mut drop_tokens, &mut channel, timestamp)?;
let mut still_pending = Vec::new();
for (token, rx, since, _) in pending_drop_tokens.drain(..) {
match rx.recv_timeout(Duration::from_millis(100)) {
Ok(()) => return Err(eyre!("Node API should not send anything on ACK channel")),
Err(flume::RecvTimeoutError::Disconnected) => {
// the event was dropped -> add the drop token to the list
drop_tokens.push(token);
}
Err(flume::RecvTimeoutError::Timeout) => {
let duration = Duration::from_secs(30);
if since.elapsed() > duration {
tracing::warn!(
"timeout: node finished, but token {token:?} was still not \
dropped after {duration:?} -> ignoring it"
);
} else {
still_pending.push((token, rx, since, 0));
}
}
}
}
pending_drop_tokens = still_pending;
if !pending_drop_tokens.is_empty() {
tracing::trace!("waiting for drop for {} events", pending_drop_tokens.len());
}
}
Ok(())
}
fn report_drop_tokens(
drop_tokens: &mut Vec<DropToken>,
channel: &mut DaemonChannel,
timestamp: Timestamp,
) -> Result<(), eyre::ErrReport> {
if drop_tokens.is_empty() {
return Ok(());
}
let daemon_request = Timestamped {
inner: DaemonRequest::ReportDropTokens {
drop_tokens: std::mem::take(drop_tokens),
},
timestamp,
};
match channel.request(&daemon_request)? {
dora_core::daemon_messages::DaemonReply::Empty => Ok(()),
other => Err(eyre!("unexpected ReportDropTokens reply: {other:?}")),
}
}
|