Update app.py

app.py

@@ -81,10 +81,17 @@ def estimate_trajectory(ball_positions, frames, detection_frames):
     pitch_point = ball_positions[0]
     pitch_frame = detection_frames[0]
 
+    # Prioritize sudden y-change for impact detection
     impact_idx = None
     impact_frame = None
     for i in range(1, len(y_coords)):
-        if y_coords[i] > frame_height * IMPACT_ZONE_Y or abs(y_coords[i] - y_coords[i-1]) > IMPACT_DELTA_Y:
+        delta_y = abs(y_coords[i] - y_coords[i-1])
+        if delta_y > IMPACT_DELTA_Y:
+            impact_idx = i
+            impact_frame = detection_frames[i]
+            break
+        elif y_coords[i] > frame_height * IMPACT_ZONE_Y:
+            # Fallback to y-position if no significant y-change
             impact_idx = i
             impact_frame = detection_frames[i]
             break
@@ -109,7 +116,13 @@ def estimate_trajectory(ball_positions, frames, detection_frames):
     pitch_point_3d = pixel_to_3d(pitch_point[0], pitch_point[1], frame_height, frame_width)
     impact_point_3d = pixel_to_3d(impact_point[0], impact_point[1], frame_height, frame_width)
 
-    debug_log = f"Trajectory estimated successfully\nPitch point at frame {pitch_frame + 1}: ({pitch_point[0]:.1f}, {pitch_point[1]:.1f})\nImpact point at frame {impact_frame + 1}: ({impact_point[0]:.1f}, {impact_point[1]:.1f})"
+    debug_log = (
+        f"Trajectory estimated successfully\n"
+        f"Pitch point at frame {pitch_frame + 1}: ({pitch_point[0]:.1f}, {pitch_point[1]:.1f})\n"
+        f"Impact point at frame {impact_frame + 1}: ({impact_point[0]:.1f}, {impact_point[1]:.1f})\n"
+        f"Detections in frames: {detection_frames}\n"
+        f"Y-coordinate changes: {[abs(y_coords[i] - y_coords[i-1]) for i in range(1, len(y_coords))]}"
+    )
     return trajectory_2d, pitch_point, impact_point, pitch_frame, impact_frame, detections_3d, trajectory_3d, pitch_point_3d, impact_point_3d, debug_log
 
 def lbw_decision(ball_positions, trajectory, frames, pitch_point, impact_point):
@@ -193,7 +206,7 @@ def create_3d_plot(detections_3d, trajectory_3d, pitch_point_3d, impact_point_3d
         impact_scatter = go.Scatter3d(
             x=[impact_point_3d[0]] if impact_point_3d else [], 
             y=[impact_point_3d[1]] if impact_point_3d else [], 
-            z=[impact_point_3d[2]] if impact_point_3d else [],
+            z=[impact_point_3d[2]] if pitch_point_3d else [],
             mode='markers', marker=dict(size=8, color='yellow'), name='Impact Point'
         )
         data = [trajectory_line, pitch_scatter, impact_scatter] + stump_traces + bail_traces