Update app.py

app.py

@@ -76,7 +76,7 @@ def process_video(video_path):
 
         if not ball_detected:
             prediction = kalman.predict()
-            x, y = prediction[0].item(), prediction[1].item()  # Extract scalar values
+            x, y = prediction[0].item(), prediction[1].item()
             if 0 <= x < frame_width and 0 <= y < frame_height:
                 ball_positions.append((frame_idx, x, y, 0.0))
                 logger.debug(f"Frame {frame_idx}: Predicted ball at ({x:.2f}, {y:.2f})")
@@ -165,40 +165,87 @@ def process_video(video_path):
 
     output_video.release()
 
-    # Generate Plotly trajectory plot
+    # Generate Plotly trajectory plots
     if confident_positions:
         frames_range, x_coords, y_coords = zip(*confident_positions)
-        fig = go.Figure()
-        fig.add_trace(go.Scatter(
+        # Plot 1: X, Y vs Frame Index
+        fig1 = go.Figure()
+        fig1.add_trace(go.Scatter(
             x=frames_range, y=x_coords, mode='lines+markers', name='X Coordinate',
             line=dict(color='blue'), marker=dict(size=8)
         ))
-        fig.add_trace(go.Scatter(
+        fig1.add_trace(go.Scatter(
             x=frames_range, y=y_coords, mode='lines+markers', name='Y Coordinate',
             line=dict(color='red'), marker=dict(size=8)
         ))
         if release_frame:
-            fig.add_trace(go.Scatter(
+            fig1.add_trace(go.Scatter(
                 x=[release_frame], y=[release_y], mode='markers', name='Release Point',
                 marker=dict(size=12, color='blue', symbol='star')
             ))
-        ifpitch_frame:
-            fig.add_trace(go.Scatter(
+        if pitch_frame:
+            fig1.add_trace(go.Scatter(
                 x=[pitch_frame], y=[pitch_y], mode='markers', name='Pitch Point',
                 marker=dict(size=12, color='yellow', symbol='star')
             ))
         if impact_frame:
-            fig.add_trace(go.Scatter(
+            fig1.add_trace(go.Scatter(
                 x=[impact_frame], y=[impact_y], mode='markers', name='Impact Point',
                 marker=dict(size=12, color='green', symbol='star')
             ))
-        fig.update_layout(
+        fig1.update_layout(
             title="Ball Trajectory (X, Y vs Frame Index)",
             xaxis_title="Frame Index",
             yaxis_title="Pixel Coordinate",
             template="plotly_dark",
             showlegend=True
         )
+
+        # Plot 2: X vs Y (Spatial Trajectory)
+        fig2 = go.Figure()
+        fig2.add_trace(go.Scatter(
+            x=x_coords, y=y_coords, mode='lines+markers', name='Ball Trajectory',
+            line=dict(color='red'), marker=dict(size=8)
+        ))
+        if release_frame:
+            fig2.add_trace(go.Scatter(
+                x=[release_x], y=[release_y], mode='markers', name='Release Point',
+                marker=dict(size=12, color='blue', symbol='star')
+            ))
+        if pitch_frame:
+            fig2.add_trace(go.Scatter(
+                x=[pitch_x], y=[pitch_y], mode='markers', name='Pitch Point',
+                marker=dict(size=12, color='yellow', symbol='star')
+            ))
+        if impact_frame:
+            fig2.add_trace(go.Scatter(
+                x=[impact_x], y=[impact_y], mode='markers', name='Impact Point',
+                marker=dict(size=12, color='green', symbol='star')
+            ))
+        fig2.update_layout(
+            title="Ball Trajectory (X vs Y, Spatial View)",
+            xaxis_title="X Coordinate (pixels)",
+            yaxis_title="Y Coordinate (pixels)",
+            template="plotly_dark",
+            showlegend=True,
+            xaxis=dict(range=[0, frame_width]),
+            yaxis=dict(range=[frame_height, 0])  # Invert y-axis to match video orientation
+        )
+
+        # Combine plots
+        fig = go.Figure()
+        fig.add_traces(fig1.data + fig2.data)
+        fig.update_layout(
+            title="Ball Trajectory Analysis",
+            grid=dict(rows=2, columns=1),
+            subplot_titles=["X, Y vs Frame Index", "X vs Y (Spatial View)"],
+            template="plotly_dark",
+            showlegend=True
+        )
+        fig.layout['xaxis'].update(title="Frame Index", range=[min(frames_range), max(frames_range)])
+        fig.layout['yaxis'].update(title="Pixel Coordinate")
+        fig.layout['xaxis2'].update(title="X Coordinate (pixels)", range=[0, frame_width])
+        fig.layout['yaxis2'].update(title="Y Coordinate (pixels)", range=[frame_height, 0])
     else:
         fig = go.Figure()
         fig.add_annotation(text="No confident detections for trajectory plot", showarrow=False)
@@ -214,10 +261,10 @@ iface = gr.Interface(
     outputs=[
         gr.Video(label="Replay Video"),
         gr.Textbox(label="Decision"),
-        gr.Plot(label="Trajectory Plot")
+        gr.Plot(label="Trajectory Plots (Temporal and Spatial)")
     ],
     title="Cricket DRS System",
-    description="Upload a cricket video to get a DRS analysis with smooth ball trajectory, Out/Not Out decision, and trajectory plot."
+    description="Upload a cricket video to get a DRS analysis with smooth ball trajectory, Out/Not Out decision, and trajectory plots."
 )
 
 if __name__ == "__main__":