def generate_correct_grammatical_spelling_errors(model, max_tokens, sys_content, eng_level, paragraph):

app.py

@@ -767,10 +767,48 @@ def generate_paragraph_evaluate(model, max_tokens, sys_content, paragraph):
         error_msg = handle_evaluation_error(e)
         raise gr.Error(error_msg)
 
-def generate_correct_grammatical_spelling_errors(model, sys_content, eng_level, paragraph, user_correct_grammatical_spelling_errors_prompt):
+def generate_correct_grammatical_spelling_errors(model, max_tokens, sys_content, eng_level, paragraph):
     """
     根據用戶輸入的段落，生成文法和拼字錯誤修正建議。
     """
+    user_correct_grammatical_spelling_errors_prompt = """
+        I'm aiming to improve my writing. 
+        Please assist me by "Correcting Grammatical and Spelling Errors" in the provided paragraph. 
+        For every correction you make, I'd like an "Explanation" to understand the reasoning behind it. 
+        
+        Rules:
+        - Paragraph for Correction: [paragraph split by punctuation mark]    
+        - The sentence to remain unchanged: [sentence_to_remain_unchanged]
+        - When explaining, use Traditional Chinese (Taiwan, 繁體中文) for clarity. 
+        - But others(original, Correction, revised_paragraph) in English.
+        - Make sure any revised vocabulary aligns with the eng_level. 
+        - Prepositions Followed by Gerunds: After a preposition, a gerund (the -ing form of a verb) should be used. For example: "interested in reading."
+        - Two Main Verbs in a Sentence: When a sentence has two main verbs, it is necessary to use conjunctions, infinitives, clauses, or participles to correctly organize and connect the verbs, avoiding confusion in the sentence structure.
+        
+        Guidelines for Length and Complexity: 
+        - Please keep explanations concise and straightforward
+        - if there are no grammatical or spelling errors, don't need to revise either no more suggestions to show in the revised paragraph.
+        
+        Restrictions:
+        - avoiding overly technical language.
+        - don't give any suggestions about the sentence to remain unchanged.
+        - don't give suggestions about the Period, Comma etc.
+        - Do not change the original text's case.
+        - if no mistakes, don't need to revise.
+
+        The response should strictly be in the below JSON format and nothing else:
+
+        EXAMPLE:
+        {{ 
+            "Corrections and Explanations": [ 
+                {{ "original": "# original_sentence1", "correction": "#correction_1", "explanation": "#explanation_1(in_traditional_chinese ZH-TW)" }}, 
+                {{ "original": "# original_sentence2", "correction": "#correction_2", "explanation": "#explanation_2(in_traditional_chinese ZH-TW)" }}, 
+                ... 
+            ], 
+            "Revised Paragraph": "#revised_paragraph" 
+        }}
+    """
+
     try:
         user_content = f"""
             level is: {eng_level}
@@ -798,7 +836,7 @@ def generate_correct_grammatical_spelling_errors(model, sys_content, eng_level,
             prompt=f"{sys_content}\n{user_content}" if "gemini" in model.lower() else None,
             messages=messages,
             model=model,
-            max_tokens=4000,
+            max_tokens=max_tokens,
             response_format={"type": "json_object"}
         )
 
@@ -2947,47 +2985,7 @@ with gr.Blocks(theme=THEME, css=CSS) as demo:
 
                     # 修訂文法與拼字錯誤
                     with gr.Row():
-                        with gr.Column():
-                            with gr.Row() as paragraph_correct_grammatical_spelling_errors_params:
-                                default_user_correct_grammatical_spelling_errors_prompt = """
-                                    I'm aiming to improve my writing. 
-                                    Please assist me by "Correcting Grammatical and Spelling Errors" in the provided paragraph. 
-                                    For every correction you make, I'd like an "Explanation" to understand the reasoning behind it. 
-                                    
-                                    Rules:
-                                    - Paragraph for Correction: [paragraph split by punctuation mark]    
-                                    - The sentence to remain unchanged: [sentence_to_remain_unchanged]
-                                    - When explaining, use Traditional Chinese (Taiwan, 繁體中文) for clarity. 
-                                    - But others(original, Correction, revised_paragraph) in English.
-                                    - Make sure any revised vocabulary aligns with the eng_level. 
-                                    - Prepositions Followed by Gerunds: After a preposition, a gerund (the -ing form of a verb) should be used. For example: "interested in reading."
-                                    - Two Main Verbs in a Sentence: When a sentence has two main verbs, it is necessary to use conjunctions, infinitives, clauses, or participles to correctly organize and connect the verbs, avoiding confusion in the sentence structure.
-                                    
-                                    Guidelines for Length and Complexity: 
-                                    - Please keep explanations concise and straightforward
-                                    - if there are no grammatical or spelling errors, don't need to revise either no more suggestions to show in the revised paragraph.
-                                    
-                                    Restrictions:
-                                    - avoiding overly technical language.
-                                    - don't give any suggestions about the sentence to remain unchanged.
-                                    - don't give suggestions about the Period, Comma etc.
-                                    - Do not change the original text's case.
-                                    - if no mistakes, don't need to revise.
-
-                                    The response should strictly be in the below JSON format and nothing else:
-
-                                    EXAMPLE:
-                                    {{ 
-                                        "Corrections and Explanations": [ 
-                                            {{ "original": "# original_sentence1", "correction": "#correction_1", "explanation": "#explanation_1(in_traditional_chinese ZH-TW)" }}, 
-                                            {{ "original": "# original_sentence2", "correction": "#correction_2", "explanation": "#explanation_2(in_traditional_chinese ZH-TW)" }}, 
-                                            ... 
-                                        ], 
-                                        "Revised Paragraph": "#revised_paragraph" 
-                                    }}
-                                """
-                                user_correct_grammatical_spelling_errors_prompt = gr.Textbox(label="Correct Grammatical and Spelling Errors Prompt", value=default_user_correct_grammatical_spelling_errors_prompt, visible=False)
-                            
+                        with gr.Column():                            
                             with gr.Row() as paragraph_correct_grammatical_spelling_errors_html:
                                 gr.Markdown("# Step 7. 修訂文法與拼字錯誤")
                                 with gr.Accordion("📝 參考指引：AI 的混淆狀況？", open=False):
@@ -3085,10 +3083,10 @@ with gr.Blocks(theme=THEME, css=CSS) as demo:
                         fn=generate_correct_grammatical_spelling_errors,
                         inputs=[
                             model,
+                            max_tokens,
                             sys_content_input,
                             eng_level_input,
                             paragraph_output,
-                            user_correct_grammatical_spelling_errors_prompt,
                         ],
                         outputs=[
                             correct_grammatical_spelling_errors_output_table, 
@@ -3326,7 +3324,13 @@ with gr.Blocks(theme=THEME, css=CSS) as demo:
                     
                     generate_full_paragraph_correct_grammatical_spelling_errors_button.click(
                         fn=generate_correct_grammatical_spelling_errors,
-                        inputs=[model, sys_content_input, eng_level_input, full_paragraph_correct_grammatical_spelling_errors_input, user_correct_grammatical_spelling_errors_prompt],
+                        inputs=[
+                            model,
+                            max_tokens,
+                            sys_content_input, 
+                            eng_level_input, 
+                            full_paragraph_correct_grammatical_spelling_errors_input, 
+                        ],
                         outputs=[full_paragraph_correct_grammatical_spelling_errors_output_table, revised_full_paragraph_output]
                     ).then(
                         fn=highlight_diff_texts,
@@ -3445,9 +3449,6 @@ with gr.Blocks(theme=THEME, css=CSS) as demo:
                                 with gr.Column():
                                     past_exam_correct_grammatical_spelling_errors_input = gr.TextArea(label="這是你的原始寫作內容，參考 JUTOR 的建議，你可以選擇是否修改：",lines= 10, show_copy_button=True)
                                 with gr.Column():
-                                    with gr.Row():
-                                        with gr.Accordion("prompt 提供微調測試", open=False, elem_classes=['accordion-prompts'], visible=False):
-                                            past_exam_correct_grammatical_spelling_errors_prompt = gr.Textbox(label="Correct Grammatical and Spelling Errors Prompt", value=default_user_correct_grammatical_spelling_errors_prompt, lines= 20)
                                     with gr.Row():
                                         past_exam_generate_correct_grammatical_spelling_errors_button = gr.Button("修訂文法與拼字錯誤", variant="primary")
                                     with gr.Row():
@@ -3576,7 +3577,13 @@ with gr.Blocks(theme=THEME, css=CSS) as demo:
 
                                 past_exam_generate_correct_grammatical_spelling_errors_button.click(
                                     fn=generate_correct_grammatical_spelling_errors,
-                                    inputs=[model, past_exam_evaluation_sys_content_prompt, eng_level_input, past_exam_correct_grammatical_spelling_errors_input, past_exam_correct_grammatical_spelling_errors_prompt],
+                                    inputs=[
+                                        model,
+                                        max_tokens,
+                                        past_exam_evaluation_sys_content_prompt, 
+                                        eng_level_input, 
+                                        past_exam_correct_grammatical_spelling_errors_input, 
+                                    ],
                                     outputs=[past_exam_correct_grammatical_spelling_errors_output_table, past_exam_revised_output]
                                 ).then(
                                     fn=highlight_diff_texts,