feedback_with_ai

app.py

@@ -2100,55 +2100,26 @@ def get_instructions(content_subject, content_grade, key_moments, socratic_mode=
     """
     return instructions
 
-def chat_with_ai(ai_name, password, video_id, user_data, trascript_state, key_moments, user_message, chat_history, content_subject, content_grade, questions_answers_json, send_btn, socratic_mode=False):
+def chat_with_ai(ai_name, password, video_id, user_data, trascript_state, key_moments, user_message, chat_history, content_subject, content_grade, questions_answers_json, socratic_mode=False):
     verify_password(password)
 
     print("=====user_data=====")
     print(f"user_data: {user_data}")
 
-    questions_answers_json = json.loads(questions_answers_json)
-    for qa in questions_answers_json:
-        question = qa["question"]
-        answer = qa["answer"]
-        if user_message == question and answer != "":
-            print("=== in questions_answers_json==")
-            print(f"question: {question}")
-            print(f"answer: {answer}")
-            # 更新聊天历史
-            new_chat_history = (user_message, answer)
-            if chat_history is None:
-                chat_history = [new_chat_history]
-            else:
-                chat_history.append(new_chat_history)
-
-            # 等待 3 秒
-            time.sleep(3)
-            send_count = len(chat_history)-1
-            if len(chat_history) > CHAT_LIMIT:
-                send_btn_value = f"對話已達上限 ({send_count}/{CHAT_LIMIT})"
-                send_btn = gr.update(value=send_btn_value, interactive=False)
-            else:
-                send_btn_value = f"發送 ({send_count}/{CHAT_LIMIT})"
-                send_btn = gr.update(value=send_btn_value, interactive=True)
+    verify_message_length(user_message, max_length=1500)
 
-            return "", chat_history, send_btn
+    is_questions_answers_exists, question_message, answer_message = check_questions_answers(user_message, questions_answers_json)
+    if is_questions_answers_exists:
+        chat_history = update_chat_history(question_message, answer_message, chat_history)
+        send_btn_update, send_feedback_btn_update = update_send_and_feedback_buttons(chat_history, CHAT_LIMIT)
+        time.sleep(3)
+        return "", chat_history, send_btn_update, send_feedback_btn_update
 
-    if chat_history is not None and len(chat_history) > CHAT_LIMIT:
-        error_msg = "此次對話超過上限（對話一輪10次）"
-        raise gr.Error(error_msg)
+    verify_chat_limit(chat_history, CHAT_LIMIT)
 
     if not ai_name in ["foxcat", "lili", "maimai"]:
         ai_name = "foxcat"
 
-    # if ai_name == "jutor":
-    #     ai_client = ""
-    # elif ai_name == "claude3":
-    #     ai_client = BEDROCK_CLIENT
-    # elif ai_name == "groq":
-    #     ai_client = GROQ_CLIENT
-    # else:
-    #     ai_client = ""
-        
     ai_name_clients_model = {
         "foxcat": {
             "ai_name": "foxcat",
@@ -2160,11 +2131,6 @@ def chat_with_ai(ai_name, password, video_id, user_data, trascript_state, key_mo
             "ai_client": BEDROCK_CLIENT,
             "ai_model_name": "claude3",
         },
-        # "maimai": {
-        #     "ai_name": "maimai",
-        #     "ai_client": OPEN_AI_CLIENT,
-        #     "ai_model_name": "openai",
-        # }
         "maimai": {
             "ai_name": "maimai",
             "ai_client": GROQ_CLIENT,
@@ -2213,28 +2179,75 @@ def chat_with_ai(ai_name, password, video_id, user_data, trascript_state, key_mo
 
     try:
         # 更新聊天历史
-        new_chat_history = (user_message, response_completion)
-        if chat_history is None:
-            chat_history = [new_chat_history]
-        else:
-            chat_history.append(new_chat_history)
-
-        send_count = len(chat_history)-1
-        if len(chat_history) > CHAT_LIMIT:
-            send_btn_value = f"對話已達上限 ({send_count}/{CHAT_LIMIT})"
-            send_btn = gr.update(value=send_btn_value, interactive=False)
-        else:
-            send_btn_value = f"發送 ({send_count}/{CHAT_LIMIT})"
-            send_btn = gr.update(value=send_btn_value, interactive=True)
+        chat_history = update_chat_history(user_message, response_completion, chat_history)
+        send_btn_update, send_feedback_btn_update = update_send_and_feedback_buttons(chat_history, CHAT_LIMIT)
 
         # 返回聊天历史和空字符串清空输入框
-        return "", chat_history, send_btn
+        return "", chat_history, send_btn_update, send_feedback_btn_update
     except Exception as e:
         # 处理错误情况
         print(f"Error: {e}")
         return "请求失败，请稍后再试！", chat_history
 
-def chat_with_opan_ai_assistant(password, youtube_id, user_data, thread_id, trascript_state, key_moments, user_message, chat_history, content_subject, content_grade, questions_answers_json, send_btn, send_feedback_btn, socratic_mode=False):
+def feedback_with_ai(chat_history):
+    # prompt: 請依據以上的對話(chat_history)，總結我的「提問力」，並給予我是否有「問對問題」的回饋和建議
+    system_content = """
+        你是一個擅長引導問答素養的老師，user 為學生的提問跟回答，請精讀對話過程，針對 user 給予回饋就好，根據以下 Rule:
+        - 請使用繁體中文 zh-TW 總結 user 的提問力，並給予是否有問對問題的回饋和建議
+        - 不採計【預設提問】的問題，如果 user 的提問都來自【預設提問】，表達用戶善於使用系統，請給予回饋並鼓勵 user 親自提問更具體的問題
+        - 如果用戶提問都相當簡短，甚至就是一個字或都是一個數字（像是 user: 1, user:2），請給予回饋並建議 user 提問更具體的問題
+        - 如果用戶提問內容只有符號或是亂碼，像是？,！, ..., 3bhwbqhfw2vve2 等，請給予回饋並建議 user 提問更具體的問題
+        - 如果用戶提問內容有色情、暴力、仇恨、不當言論等，請給予嚴厲的回饋並建議 user 提問更具體的問題
+        - 並用第二人稱「你」來代表 user
+        - 請禮貌，並給予鼓勵
+    """
+    chat_history_conversation = ""
+    # 標註 user and assistant as string
+    # chat_history 第一組不採計
+    for chat in chat_history[1:]:
+        user_message = chat[0]
+        assistant_message = chat[1]
+        chat_history_conversation += f"User: {user_message}\nAssistant: {assistant_message}\n"
+    
+    feedback_request_message = "請依據以上的對話，總結我的「提問力」，並給予我是否有「問對問題」的回饋和建議"
+    user_content = f"""conversation: {chat_history_conversation}
+        {feedback_request_message}
+        最後根據提問力表現，給予提問建議、提問表現，並用 emoji 來表示評分：
+        🟢：（表現很好的回饋，給予正向肯定）
+        🟡：（還可以加油的的回饋，給予明確的建議）
+        🔴：（非常不懂提問的回饋，給予鼓勵並給出明確示範）
+
+        example:
+        另一方面，你表達「我不想學了」這個情感，其實也是一種重要的反饋。這顯示你可能感到挫折或疲倦。在這種情況下，表達出你的感受是好的，但如果能具體說明是什麼讓你感到這樣，或是有什麼具體的學習障礙，會更有助於找到解決方案。
+        給予你的建議是，嘗試在提問時更明確一些，這樣不僅能幫助你獲得更好的學習支持，也能提高你的問題解決技巧。
+        ......
+        提問建議：在提問時，試著具體並清晰地表達你的需求和疑惑，這樣能更有效地得到幫助。
+        提問表現：【🟡】加油，持續練習，你的提問力會越來越好！
+    """
+
+
+    client = OPEN_AI_CLIENT
+    model_name = "gpt-4-turbo"
+    response_text = handle_conversation_by_open_ai_chat_completions(client, model_name, user_content, system_content)
+    chat_history = update_chat_history(feedback_request_message, response_text, chat_history)
+    feedback_btn_update = gr.update(value="已回饋", interactive=False, variant="secondary")
+
+    return chat_history, feedback_btn_update
+
+def handle_conversation_by_open_ai_chat_completions(client, model_name, user_content, system_content):
+    response = client.chat.completions.create(
+        model=model_name,
+        messages=[
+            {"role": "system", "content": system_content},
+            {"role": "user", "content": user_content}
+        ],
+        max_tokens=4000,
+    )
+    response_text = response.choices[0].message.content.strip()
+    return response_text
+
+# open ai assistant
+def chat_with_opan_ai_assistant(password, youtube_id, user_data, thread_id, trascript_state, key_moments, user_message, chat_history, content_subject, content_grade, questions_answers_json, socratic_mode=False):
     verify_password(password)
 
     print("=====user_data=====")
@@ -2979,7 +2992,8 @@ with gr.Blocks(theme=gr.themes.Base(primary_hue=gr.themes.colors.orange, seconda
                     ai_chatbot_audio_input = gr.Audio(sources=["microphone"], type="filepath", max_length=60, label="語音輸入")
                 with gr.Row():
                     ai_msg = gr.Textbox(label="訊息輸入",scale=3)
-                    ai_send_button = gr.Button("送出", variant="primary",scale=1)              
+                    ai_send_button = gr.Button("送出", variant="primary",scale=1)
+                    ai_send_feedback_btn = gr.Button("提問力回饋", variant="primary", scale=1, visible=False)          
     with gr.Tab("文章模式"):
         with gr.Row():
             reading_passage = gr.Markdown(show_label=False, latex_delimiters = [{"left": "$", "right": "$", "display": False}])
@@ -3221,7 +3235,7 @@ with gr.Blocks(theme=gr.themes.Base(primary_hue=gr.themes.colors.orange, seconda
     # OPENAI ASSISTANT CHATBOT 模式
     send_button.click(
         chat_with_opan_ai_assistant,
-        inputs=[password, video_id, user_data, thread_id, trascript_state, key_moments, msg, chatbot, content_subject, content_grade, questions_answers_json, send_button, send_feedback_btn, socratic_mode_btn],
+        inputs=[password, video_id, user_data, thread_id, trascript_state, key_moments, msg, chatbot, content_subject, content_grade, questions_answers_json, socratic_mode_btn],
         outputs=[msg, chatbot, thread_id, send_button, send_feedback_btn],
         scroll_to_output=True
     )
@@ -3246,7 +3260,7 @@ with gr.Blocks(theme=gr.themes.Base(primary_hue=gr.themes.colors.orange, seconda
     )
     question_buttons = [btn_1, btn_2, btn_3]
     for question_btn in question_buttons:
-        inputs_list = [password, video_id, user_data, thread_id, trascript_state, key_moments, question_btn, chatbot, content_subject, content_grade, questions_answers_json, send_button, send_feedback_btn, socratic_mode_btn]
+        inputs_list = [password, video_id, user_data, thread_id, trascript_state, key_moments, question_btn, chatbot, content_subject, content_grade, questions_answers_json, socratic_mode_btn]
         outputs_list = [msg, chatbot, thread_id, send_button, send_feedback_btn]
         setup_question_button_click(question_btn, inputs_list, outputs_list, chat_with_opan_ai_assistant)
 
@@ -3260,15 +3274,21 @@ with gr.Blocks(theme=gr.themes.Base(primary_hue=gr.themes.colors.orange, seconda
     # 其他精靈 ai_chatbot 模式
     ai_send_button.click(
         chat_with_ai,
-        inputs=[ai_name, password, video_id, user_data, trascript_state, key_moments, ai_msg, ai_chatbot, content_subject, content_grade, questions_answers_json, ai_send_button, ai_chatbot_socratic_mode_btn],
-        outputs=[ai_msg, ai_chatbot, ai_send_button],
+        inputs=[ai_name, password, video_id, user_data, trascript_state, key_moments, ai_msg, ai_chatbot, content_subject, content_grade, questions_answers_json, ai_chatbot_socratic_mode_btn],
+        outputs=[ai_msg, ai_chatbot, ai_send_button, ai_send_feedback_btn],
+        scroll_to_output=True
+    )
+    ai_send_feedback_btn.click(
+        feedback_with_ai,
+        inputs=[ai_chatbot],
+        outputs=[ai_chatbot, ai_send_feedback_btn],
         scroll_to_output=True
     )
     # 其他精靈 ai_chatbot 连接 QA 按钮点击事件
     ai_chatbot_question_buttons = [ai_chatbot_question_1, ai_chatbot_question_2, ai_chatbot_question_3]
     for question_btn in ai_chatbot_question_buttons:
-        inputs_list = [ai_name, password, video_id, user_data, trascript_state, key_moments, question_btn, ai_chatbot, content_subject, content_grade, questions_answers_json, ai_send_button, ai_chatbot_socratic_mode_btn]
-        outputs_list = [ai_msg, ai_chatbot, ai_send_button]
+        inputs_list = [ai_name, password, video_id, user_data, trascript_state, key_moments, question_btn, ai_chatbot, content_subject, content_grade, questions_answers_json, ai_chatbot_socratic_mode_btn]
+        outputs_list = [ai_msg, ai_chatbot, ai_send_button, ai_send_feedback_btn]
         setup_question_button_click(question_btn, inputs_list, outputs_list, chat_with_ai)
 
     ai_chatbot_audio_input.change(