James McCool
commited on
Commit
·
7d83d23
1
Parent(s):
e253b51
Refactor name replacement logic in find_name_mismatches function
Browse files- Removed unnecessary checks for contest_name in ownership_raw and fpts_raw during name replacement, streamlining the code and improving readability.
- Enhanced the efficiency of the name matching process by consolidating replacement logic, ensuring accurate updates to player names across all relevant data structures.
global_func/find_name_mismatches.py
CHANGED
@@ -79,11 +79,7 @@ def find_name_mismatches(contest_df, projections_df, ownership_df, fpts_df):
|
|
79 |
for projection_name, contest_name in auto_matches.items():
|
80 |
for col in name_columns:
|
81 |
contest_raw[col] = contest_raw[col].replace(contest_name, projection_name)
|
82 |
-
|
83 |
-
if contest_name in ownership_raw:
|
84 |
ownership_raw['Player'] = ownership_raw['Player'].replace(contest_name, projection_name)
|
85 |
-
|
86 |
-
if contest_name in fpts_raw:
|
87 |
fpts_raw['Player'] = fpts_raw['Player'].replace(contest_name, projection_name)
|
88 |
|
89 |
# Process manual selections
|
@@ -92,10 +88,7 @@ def find_name_mismatches(contest_df, projections_df, ownership_df, fpts_df):
|
|
92 |
selected_name = selection.split(" (")[0]
|
93 |
for col in name_columns:
|
94 |
contest_raw[col] = contest_raw[col].replace(selected_name, projection_name)
|
95 |
-
|
96 |
-
if contest_name in ownership_raw:
|
97 |
ownership_raw['Player'] = ownership_raw['Player'].replace(contest_name, projection_name)
|
98 |
-
if contest_name in fpts_raw:
|
99 |
fpts_raw['Player'] = fpts_raw['Player'].replace(contest_name, projection_name)
|
100 |
|
101 |
st.success(f"Replaced '{selected_name}' with '{projection_name}'")
|
|
|
79 |
for projection_name, contest_name in auto_matches.items():
|
80 |
for col in name_columns:
|
81 |
contest_raw[col] = contest_raw[col].replace(contest_name, projection_name)
|
|
|
|
|
82 |
ownership_raw['Player'] = ownership_raw['Player'].replace(contest_name, projection_name)
|
|
|
|
|
83 |
fpts_raw['Player'] = fpts_raw['Player'].replace(contest_name, projection_name)
|
84 |
|
85 |
# Process manual selections
|
|
|
88 |
selected_name = selection.split(" (")[0]
|
89 |
for col in name_columns:
|
90 |
contest_raw[col] = contest_raw[col].replace(selected_name, projection_name)
|
|
|
|
|
91 |
ownership_raw['Player'] = ownership_raw['Player'].replace(contest_name, projection_name)
|
|
|
92 |
fpts_raw['Player'] = fpts_raw['Player'].replace(contest_name, projection_name)
|
93 |
|
94 |
st.success(f"Replaced '{selected_name}' with '{projection_name}'")
|