James McCool commited on
Commit
f0a2361
·
1 Parent(s): 8e02398

Improve player frame filtering in app.py by dropping rows without position data

Browse files

- Added logic to drop rows from the player frame where the 'Pos' column is NaN, ensuring only relevant player data is displayed.
- This enhancement refines the filtering process based on user-selected positions, further improving data clarity and user experience.

Files changed (1) hide show
  1. app.py +4 -0
app.py CHANGED
@@ -219,10 +219,12 @@ with tab2:
219
  pos_select = None
220
 
221
  if entry_parse_var == 'All':
 
222
  st.session_state['player_frame'] = create_player_exposures(working_df, player_columns)
223
  hold_frame = st.session_state['player_frame'].copy()
224
  hold_frame['Pos'] = hold_frame['Player'].map(map_dict['pos_map'])
225
  st.session_state['player_frame'].insert(1, 'Pos', hold_frame['Pos'])
 
226
  if pos_select:
227
  position_mask = st.session_state['player_frame']['Pos'].apply(lambda x: any(pos in x for pos in pos_select))
228
  st.session_state['player_frame'] = st.session_state['player_frame'][position_mask]
@@ -232,10 +234,12 @@ with tab2:
232
  format(formatter='{:.2%}', subset=st.session_state['player_frame'].iloc[:, 2:].select_dtypes(include=['number']).columns),
233
  hide_index=True)
234
  else:
 
235
  st.session_state['player_frame'] = create_player_exposures(working_df, player_columns, entry_names)
236
  hold_frame = st.session_state['player_frame'].copy()
237
  hold_frame['Pos'] = hold_frame['Player'].map(map_dict['pos_map'])
238
  st.session_state['player_frame'].insert(1, 'Pos', hold_frame['Pos'])
 
239
  if pos_select:
240
  position_mask = st.session_state['player_frame']['Pos'].apply(lambda x: any(pos in x for pos in pos_select))
241
  st.session_state['player_frame'] = st.session_state['player_frame'][position_mask]
 
219
  pos_select = None
220
 
221
  if entry_parse_var == 'All':
222
+
223
  st.session_state['player_frame'] = create_player_exposures(working_df, player_columns)
224
  hold_frame = st.session_state['player_frame'].copy()
225
  hold_frame['Pos'] = hold_frame['Player'].map(map_dict['pos_map'])
226
  st.session_state['player_frame'].insert(1, 'Pos', hold_frame['Pos'])
227
+ st.session_state['player_frame'] = st.session_state['player_frame'].dropna(subset=['Pos'])
228
  if pos_select:
229
  position_mask = st.session_state['player_frame']['Pos'].apply(lambda x: any(pos in x for pos in pos_select))
230
  st.session_state['player_frame'] = st.session_state['player_frame'][position_mask]
 
234
  format(formatter='{:.2%}', subset=st.session_state['player_frame'].iloc[:, 2:].select_dtypes(include=['number']).columns),
235
  hide_index=True)
236
  else:
237
+
238
  st.session_state['player_frame'] = create_player_exposures(working_df, player_columns, entry_names)
239
  hold_frame = st.session_state['player_frame'].copy()
240
  hold_frame['Pos'] = hold_frame['Player'].map(map_dict['pos_map'])
241
  st.session_state['player_frame'].insert(1, 'Pos', hold_frame['Pos'])
242
+ st.session_state['player_frame'] = st.session_state['player_frame'].dropna(subset=['Pos'])
243
  if pos_select:
244
  position_mask = st.session_state['player_frame']['Pos'].apply(lambda x: any(pos in x for pos in pos_select))
245
  st.session_state['player_frame'] = st.session_state['player_frame'][position_mask]