James McCool commited on
Commit
ba8ea34
·
1 Parent(s): c7d3c05

Refactor large_field_preset function to improve sorting logic: change the final return statement to sort by 'Finish_percentile' instead of 'Own', ensuring more accurate lineup targeting based on performance metrics.

Browse files
Files changed (1) hide show
  1. global_func/large_field_preset.py +3 -3
global_func/large_field_preset.py CHANGED
@@ -5,7 +5,7 @@ def large_field_preset(portfolio: pd.DataFrame, lineup_target: int):
5
  for slack_var in range(1, 10):
6
  rows_to_drop = []
7
 
8
- working_portfolio = portfolio.sort_values(by='Finish_percentile', ascending = True).reset_index(drop=True)
9
  working_portfolio = working_portfolio[working_portfolio['Lineup Edge'] > 0]
10
  working_portfolio = working_portfolio.reset_index(drop=True)
11
  curr_own_type_max = working_portfolio.loc[0, 'Own'] + (slack_var / 10 * working_portfolio.loc[0, 'Own'])
@@ -18,6 +18,6 @@ def large_field_preset(portfolio: pd.DataFrame, lineup_target: int):
18
 
19
  working_portfolio = working_portfolio.drop(rows_to_drop).reset_index(drop=True)
20
  if len(working_portfolio) >= lineup_target:
21
- return working_portfolio.sort_values(by='Own', ascending=False).head(lineup_target)
22
 
23
- return working_portfolio.sort_values(by='Own', ascending=False)
 
5
  for slack_var in range(1, 10):
6
  rows_to_drop = []
7
 
8
+ working_portfolio = portfolio.sort_values(by='Finish_percentile', ascending = True)
9
  working_portfolio = working_portfolio[working_portfolio['Lineup Edge'] > 0]
10
  working_portfolio = working_portfolio.reset_index(drop=True)
11
  curr_own_type_max = working_portfolio.loc[0, 'Own'] + (slack_var / 10 * working_portfolio.loc[0, 'Own'])
 
18
 
19
  working_portfolio = working_portfolio.drop(rows_to_drop).reset_index(drop=True)
20
  if len(working_portfolio) >= lineup_target:
21
+ return working_portfolio.sort_values(by='Finish_percentile', ascending=True).head(lineup_target)
22
 
23
+ return working_portfolio.sort_values(by='Finish_percentile', ascending=True)