Refactor variable names in VORP roster assignment within Streamlit app for improved clarity and consistency, updating halfPPR and custom lookup variables and ensuring accurate calculations of VORP values.

src/streamlit_app.py

@@ -396,14 +396,14 @@ def assign_vorp_roster(frame: pd.DataFrame, halfPpr_rv: dict, custom_rv: dict, p
         pos_frame = pos_frame[pos_frame['Rank'] != 0]
         pos_frame = pos_frame.sort_values(by='Rank', ascending=True).reset_index(drop=True)
         pos_frame['ranker_rank'] = pos_frame['Rank'].rank(method='first', ascending=True).astype(int)
-        pos_frame['pos_rank_initial'] = pos_frame['Pos'] + pos_frame['ranker_rank'].astype(str)
-        pos_frame['halfPpr_lookup'] = pos_frame['pos_rank_initial'].map(half_ppr_match_dict)
-        pos_frame['custom_lookup'] = pos_frame['pos_rank_initial'].map(custom_match_dict)
+        pos_frame['pos_rank_init'] = pos_frame['Pos'] + pos_frame['ranker_rank'].astype(str)
+        pos_frame['halfPpr_lu'] = pos_frame['pos_rank_init'].map(half_ppr_match_dict)
+        pos_frame['custom_lu'] = pos_frame['pos_rank_init'].map(custom_match_dict)
         
         pos_frame['halfPpr_rv'] = halfPpr_rv[positions]
         pos_frame['custom_rv'] = custom_rv[positions]
-        pos_frame['halfPpr_VORP'] = pos_frame['halfPpr_lookup'] - pos_frame['halfPpr_rv']
-        pos_frame['custom_VORP'] = pos_frame['custom_lookup'] - pos_frame['custom_rv']
+        pos_frame['halfPpr_VORP'] = pos_frame['halfPpr_lu'] - pos_frame['halfPpr_rv']
+        pos_frame['custom_VORP'] = pos_frame['custom_lu'] - pos_frame['custom_rv']
         
         vorp_frame = pd.concat([vorp_frame, pos_frame]).reset_index(drop=True)
 
@@ -414,7 +414,7 @@ def assign_vorp_roster(frame: pd.DataFrame, halfPpr_rv: dict, custom_rv: dict, p
         vorp_frame.loc[vorp_frame['Pos'] == positions, 'Rank_Adjust'] = (vorp_frame['Rank'] - (vorp_frame['vorp_diff'] * pos_vorp_limiters[positions])).astype(float)
     vorp_frame['custom_rank'] = vorp_frame['Rank_Adjust'].rank(method='first', ascending=True).astype(int)
     vorp_frame['pos_rank'] = vorp_frame.groupby('Pos')['custom_rank'].rank(method='first', ascending=True).astype(int)
-    vorp_frame['pos_designation'] = vorp_frame['Pos'] + vorp_frame['pos_rank'].astype(str)
+    vorp_frame['pos_des'] = vorp_frame['Pos'] + vorp_frame['pos_rank'].astype(str)
 
     return vorp_frame.sort_values(by='custom_rank', ascending=True)
 
@@ -445,7 +445,7 @@ def main():
     final_df = assign_vorp_roster(position_df, halfPpr_rv, custom_roster_rv, user_pos_vorp_limiters, half_ppr_match_dict, custom_match_dict)
     final_df = final_df.drop(columns=['SR_ID'], axis=1)
     final_df['Name_Lookup'] = final_df['Name'].map(orig_rank_dict)
-    final_df['Scoring_Lookup'] = final_df['pos_designation'].map(pos_des_dict)
+    final_df['Scoring_Lookup'] = final_df['pos_des'].map(pos_des_dict)
     
     # Display results
     st.header("Player Rankings")