Update app.py

app.py

@@ -2,6 +2,7 @@ import os
 import subprocess
 import uuid
 import glob
+import shutil
 import gradio as gr
 
 # Set default acceleration and extra encoding options.
@@ -33,17 +34,13 @@ def convert_video(use_youtube, youtube_url, video_file, downscale, faster, use_m
         output_filename = f"{uuid.uuid4()}.mp4"
     output_path = os.path.join(CONVERTED_FOLDER, output_filename)
     
-    files_to_delete = []  # For temporary file cleanup.
-    
     if use_youtube:
         if not youtube_url:
             return "Error: YouTube URL is required.", None
 
-        # Determine quality based on whether downscale is ticked.
-        if downscale:
-            quality = 'worstaudio' if audio_only else 'worstvideo+worstaudio'
-        else:
-            quality = 'b'  # Use "-f b" for best quality if downscale is not ticked.
+        # Determine quality: if downscale is ticked use low quality; otherwise, use "-f b" for best quality.
+        quality = 'worstaudio' if audio_only and downscale else (
+                  'worstvideo+worstaudio' if downscale else 'b')
         
         yt_uuid = str(uuid.uuid4())
         yt_input_filename = yt_uuid + ".%(ext)s"
@@ -59,49 +56,44 @@ def convert_video(use_youtube, youtube_url, video_file, downscale, faster, use_m
         downloaded_files = glob.glob(pattern)
         if not downloaded_files:
             return "Failed to download YouTube video.", None
-        yt_input_file = downloaded_files[0]
-        files_to_delete.append(yt_input_file)
-        
-        # Build FFmpeg command using the downloaded file.
-        ffmpeg_cmd = ['ffmpeg', '-hwaccel', accel, '-y', '-i', yt_input_file] + extra.split()
+        input_path = downloaded_files[0]
     else:
         # File upload branch.
         if not video_file:
             return "Error: No video file provided.", None
-        # Gradio passes the file path as a string.
-        ext = os.path.splitext(video_file)[1]
-        input_filename = f"{uuid.uuid4()}{ext}"
-        input_path = os.path.join(UPLOAD_FOLDER, input_filename)
-        # Move the uploaded file to our upload folder.
-        os.rename(video_file, input_path)
-        files_to_delete.append(input_path)
-        ffmpeg_cmd = ['ffmpeg', '-hwaccel', accel, '-y', '-i', input_path] + extra.split()
+        # Check if the provided file path exists.
+        if os.path.exists(video_file):
+            ext = os.path.splitext(video_file)[1]
+            input_filename = f"{uuid.uuid4()}{ext}"
+            input_path = os.path.join(UPLOAD_FOLDER, input_filename)
+            # Copy the file to our uploads folder.
+            shutil.copy2(video_file, input_path)
+        else:
+            # If the file doesn't exist (perhaps already in a persistent location), reuse it.
+            input_path = video_file
+
+    # Build the FFmpeg command.
+    ffmpeg_cmd = ['ffmpeg', '-hwaccel', accel, '-y', '-i', input_path] + extra.split()
     
-    # Apply downscale if requested.
     if downscale:
         ffmpeg_cmd.extend(['-vf', 'scale=144:-2'])
-    # Apply faster conversion if selected.
     if faster:
         ffmpeg_cmd.extend(['-preset', 'ultrafast'])
     
-    # Configure audio encoding.
     if audio_only:
         ffmpeg_cmd.extend(['-vn'])
         configure_audio(ffmpeg_cmd, use_mp3)
     else:
         configure_audio(ffmpeg_cmd, use_mp3)
     
-    # Append output file path.
     ffmpeg_cmd.append(output_path)
     
-    # Run FFmpeg.
     try:
         subprocess.run(ffmpeg_cmd, check=True)
     except subprocess.CalledProcessError as e:
         return f"An error occurred during conversion: {e}", None
 
-    # (Optional: cleanup temporary files here if desired.)
-    # Return output file path for preview and download.
+    # Return the same output for preview and download.
     return output_path, output_path
 
 # Create the Gradio interface.
@@ -110,7 +102,7 @@ with gr.Blocks() as demo:
     gr.Markdown("Upload a video or use a YouTube URL and adjust the options below.")
     
     with gr.Row():
-        use_youtube = gr.Checkbox(label="Use YouTube URL (almost never works)", value=False)
+        use_youtube = gr.Checkbox(label="Use YouTube URL", value=False)
         youtube_url = gr.Textbox(label="YouTube URL", placeholder="Enter YouTube URL here")
     video_file = gr.File(label="Upload Video")