Update app.py

app.py

@@ -1,56 +1,52 @@
 import gradio as gr
 import os
 import json
+import traceback
 from data_service import DataAssessmentService
 from sheets_integration import SheetsLogger
 from datetime import datetime
 
-# Initialize services
-service = DataAssessmentService(api_key=os.environ.get("OPENAI_API_KEY"))
-sheets_logger = SheetsLogger()
+# Initialize services with error handling
+try:
+    print("Initializing services...")
+    service = DataAssessmentService(api_key=os.environ.get("OPENAI_API_KEY"))
+    sheets_logger = SheetsLogger()
+    print("Services initialized successfully")
+except Exception as e:
+    print(f"Error initializing services: {str(e)}")
+    print(traceback.format_exc())
+    raise
 
-# Department mapping from abbreviations to full names
+# Constants
 DEPARTMENTS = {
-    "Executive Management": "บริหาร ผอ รอง ผู้ช่วย",
-    "Education Support": "สนับสนุนการศึกษา",
-    "Medicine": "MED",
-    "Cardiology": "Cardio",
-    "Gastroenterology": "GI",
-    "Medical Oncology": "Onco MED",
+    "Executive Management": "Executive Administration",
+    "Education Support": "Education Support",
+    "Medicine": "Medicine",
+    "Cardiology": "Cardiology",
+    "Gastroenterology": "Gastroenterology",
+    "Medical Oncology": "Medical Oncology",
     "Hematology": "Hematology",
-    "Operating Room": "OR",
-    "Surgery": "Sx",
-    "Orthopedics": "Ortho",
-    "Obstetrics and Gynecology": "OBgyne",
-    "Ophthalmology": "Oph",
+    "Operating Room": "Operating Room",
+    "Surgery": "Surgery",
+    "Orthopedics": "Orthopedics",
+    "Obstetrics and Gynecology": "Obstetrics and Gynecology",
+    "Ophthalmology": "Ophthalmology",
     "Ear, Nose, and Throat": "ENT",
-    "Anesthesiology": "Anes",
-    "Emergency Medicine & EMS": "ER and EMS",
-    "Pediatrics": "PED",
-    "Family Medicine & Preventive Medicine": "GP Fammed preventive med",
-    "Psychiatry": "Psych",
-    "Physical Medicine & Rehabilitation": "PM&R Physiotherapy",
-    "Pathology": "Patho",
-    "Radiology": "Xray",
-    "Radiation Oncology": "Onco radiology",
-    "Cyclotron": "Cyclotron",
-    "Inpatient Department": "IPD",
-    "Outpatient Department": "OPD",
-    "Pharmacy": "Pharmacy",
-    "Dentistry": "dentistry",
-    "Nutrition": "Nutrition",
-    "Medical Records": "เวชระเบียน",
-    "Finance": "การเงิน",
+    "Anesthesiology": "Anesthesiology",
+    "Emergency Medicine & EMS": "Emergency Medicine",
+    "Pediatrics": "Pediatrics",
+    "Family Medicine & Preventive Medicine": "Family Medicine",
+    "Psychiatry": "Psychiatry",
+    "Physical Medicine & Rehabilitation": "PM&R",
+    "Pathology": "Pathology",
+    "Radiology": "Radiology",
     "Other": "Other"
 }
 
-# Frequency options
 FREQUENCIES = ["One-time request", "Weekly", "Monthly"]
-
-# Urgency options
 URGENCY = ["Within a week", "Within a month", "Within a year"]
 
-# Example requests
+# Example requests for reference
 EXAMPLE_REQUESTS = """
 ### Example 1: Clinical Data Request
 I need OPD patient statistics for the Cardiology department from January to June 2024, including daily patient volume, types of cardiac conditions (ICD-10 codes), average waiting times, and number of follow-up vs. new cases. This data will be used for department capacity planning and resource allocation.
@@ -74,44 +70,9 @@ Need Emergency Department performance data for March 2024:
 Purpose: Monthly performance review and staff allocation planning.
 """
 
-def format_user_summary(analysis_result):
-    """Format analysis result into user-friendly summary"""
-    available = analysis_result.get("data_availability", {}).get("available_reports", [])
-    data_lake = analysis_result.get("data_lake_requirements", {}).get("reports_needed", [])
-    unavailable = analysis_result.get("unavailable_data", [])
-    
-    interpretation = analysis_result.get("request_analysis", {}).get("interpretation", "")
-    
-    summary = [
-        "### Summary of Your Request",
-        f"**What you need**: {interpretation}\n",
-        "\n**Data Availability Status:**\n"
-    ]
-    
-    if available:
-        summary.append("✅ **Available in Web Data System:**")
-        for report in available:
-            summary.append(f"- {report['name']}")
-        summary.append(f"\nEstimated processing time: 3 working days\n")
-    
-    if data_lake:
-        summary.append("🔄 **Requires Additional Database Query:**")
-        for report in data_lake:
-            summary.append(f"- {report['report_type']}")
-        summary.append(f"\nEstimated processing time: 2 weeks\n")
-    
-    if unavailable:
-        summary.append("❌ **Data Not Currently Available:**")
-        for item in unavailable:
-            summary.append(f"- {item['report_type']}")
-        summary.append("\nRecommendation: Schedule a meeting to discuss alternative data sources or solutions\n")
-    
-    return "\n".join(summary)
-
 def process_request(name, employee_id, email, department, other_dept, request_details, frequency, urgency):
     """Process the data request and return both user and technical responses"""
-    # Debug prints
-    print(f"Received inputs:")
+    print("\nProcessing new request:")
     print(f"Name: {name}")
     print(f"Employee ID: {employee_id}")
     print(f"Email: {email}")
@@ -126,27 +87,58 @@ def process_request(name, employee_id, email, department, other_dept, request_de
         print("Validation failed - missing required fields")
         return "Please fill in all required fields.", None
         
-    # Combine department info
-    final_department = other_dept if department == "Other" else department
-    print(f"Final department: {final_department}")
-    
     try:
         # Process the request through GPT
         print("Calling GPT service...")
         result = service.assess_request(request_details)
-        print(f"GPT response: {result}")
+        print(f"GPT service response received: {result}")
+
+        if "error" in result:
+            return f"Error analyzing request: {result['error']}", None
         
         # Create user-friendly summary
-        user_summary = format_user_summary(result)
-        print(f"Generated summary: {user_summary}")
+        user_summary = f"""
+### Data Request Summary
+**From:** {name} ({department})
+**Request Type:** {frequency} | Urgency: {urgency}
+
+**Analysis:**
+{result.get('request_analysis', {}).get('interpretation', 'No interpretation available')}
+
+**Data Availability:**
+"""
         
-        # Prepare data for logging
+        # Add available reports
+        available = result.get('data_availability', {}).get('available_reports', [])
+        if available:
+            user_summary += "\n✅ **Available in Web Data:**\n"
+            for report in available:
+                user_summary += f"- {report['name']}\n"
+            user_summary += "\nEstimated processing time: 3 working days\n"
+
+        # Add data lake requirements
+        data_lake = result.get('data_lake_requirements', {}).get('reports_needed', [])
+        if data_lake:
+            user_summary += "\n🔄 **Requires Additional Database Query:**\n"
+            for report in data_lake:
+                user_summary += f"- {report['report_type']}\n"
+            user_summary += "\nEstimated processing time: 2 weeks\n"
+
+        # Add unavailable data
+        unavailable = result.get('unavailable_data', [])
+        if unavailable:
+            user_summary += "\n❌ **Data Not Currently Available:**\n"
+            for item in unavailable:
+                user_summary += f"- {item['report_type']}\n"
+            user_summary += "\nRecommendation: Schedule a meeting to discuss alternatives\n"
+
+        # Log to sheets
+        print("Logging to Google Sheets...")
         sheet_data = {
-            "timestamp": datetime.now().strftime("%Y-%m-%d %H:%M:%S"),
             "name": name,
             "employee_id": employee_id,
             "email": email,
-            "department": final_department,
+            "department": other_dept if department == "Other" else department,
             "request_details": request_details,
             "frequency": frequency,
             "urgency": urgency,
@@ -154,33 +146,28 @@ def process_request(name, employee_id, email, department, other_dept, request_de
             "system_analysis": json.dumps(result, ensure_ascii=False)
         }
         
-        # Log to Google Sheets
-        print("Logging to sheets...")
-        success = sheets_logger.log_request(sheet_data)
-        print(f"Sheet logging result: {success}")
+        sheets_logger.log_request(sheet_data)
+        print("Request logged successfully")
         
         return user_summary, result
         
     except Exception as e:
-        error_message = f"Error processing request: {str(e)}"
-        print(f"Error occurred: {error_message}")
-        print(f"Full exception: {traceback.format_exc()}")
-        return error_message, None
+        error_msg = f"Error processing request: {str(e)}"
+        print(error_msg)
+        print(traceback.format_exc())
+        return error_msg, None
 
 # Create Gradio interface
 with gr.Blocks() as demo:
     gr.Markdown("# Hospital Data Request System")
     gr.Markdown("Please fill in the following information to request data access.")
     
-    # Debug output for monitoring
-    debug_output = gr.Markdown(visible=False)
-    
     with gr.Row():
         with gr.Column():
             name = gr.Textbox(
                 label="Full Name*",
                 placeholder="Enter your full name",
-                value=""  # Ensure empty initial value
+                value=""
             )
             employee_id = gr.Textbox(
                 label="Employee ID*",
@@ -199,7 +186,7 @@ with gr.Blocks() as demo:
                 choices=list(DEPARTMENTS.keys()),
                 label="Department*",
                 info="Select your department",
-                value=list(DEPARTMENTS.keys())[0]  # Set default value
+                value=list(DEPARTMENTS.keys())[0]
             )
             other_dept = gr.Textbox(
                 label="Other Department",
@@ -209,11 +196,8 @@ with gr.Blocks() as demo:
             )
     
     # Handle department change
-    def update_other_dept_visibility(dept):
-        return gr.update(visible=(dept == "Other"))
-    
     department.change(
-        fn=update_other_dept_visibility,
+        fn=lambda x: gr.update(visible=(x == "Other")),
         inputs=department,
         outputs=other_dept
     )
@@ -235,80 +219,24 @@ with gr.Blocks() as demo:
             frequency = gr.Dropdown(
                 choices=FREQUENCIES,
                 label="Request Frequency*",
-                value=FREQUENCIES[0]  # Set default value
+                value=FREQUENCIES[0]
             )
             urgency = gr.Dropdown(
                 choices=URGENCY,
                 label="Urgency Level*",
-                value=URGENCY[0]  # Set default value
+                value=URGENCY[0]
             )
     
-    # Submit button and processing
-    submit_btn = gr.Button("Submit Request", variant="primary")
+    # Submit button
+    submit_btn = gr.Button("Submit Request")
     
     # Output sections
     with gr.Row():
-        user_output = gr.Markdown(
-            label="Request Summary",
-            value=""
-        )
+        user_output = gr.Markdown(label="Request Summary")
     
     with gr.Accordion("Technical Analysis (For Data Team)", open=False):
         tech_output = gr.JSON()
     
-    def process_request(name, employee_id, email, department, other_dept, request_details, frequency, urgency):
-        print(f"Processing request with inputs:")
-        print(f"Name: {name}")
-        print(f"Employee ID: {employee_id}")
-        print(f"Email: {email}")
-        print(f"Department: {department}")
-        print(f"Other Dept: {other_dept}")
-        print(f"Request Details: {request_details}")
-        print(f"Frequency: {frequency}")
-        print(f"Urgency: {urgency}")
-
-        # Validate inputs
-        if not all([name, employee_id, email, request_details, department, frequency, urgency]):
-            print("Validation failed - missing required fields")
-            return "Please fill in all required fields.", None
-            
-        # Combine department info
-        final_department = other_dept if department == "Other" else department
-        
-        try:
-            # Process the request through GPT
-            print("Calling GPT service...")
-            result = service.assess_request(request_details)
-            print(f"GPT response received: {result}")
-            
-            # Create user-friendly summary
-            user_summary = format_user_summary(result)
-            
-            # Prepare data for logging
-            sheet_data = {
-                "timestamp": datetime.now().strftime("%Y-%m-%d %H:%M:%S"),
-                "name": name,
-                "employee_id": employee_id,
-                "email": email,
-                "department": final_department,
-                "request_details": request_details,
-                "frequency": frequency,
-                "urgency": urgency,
-                "user_summary": user_summary,
-                "system_analysis": json.dumps(result, ensure_ascii=False)
-            }
-            
-            # Log to Google Sheets
-            print("Logging to sheets...")
-            sheets_logger.log_request(sheet_data)
-            
-            return user_summary, result
-            
-        except Exception as e:
-            error_msg = f"Error processing request: {str(e)}"
-            print(error_msg)
-            return error_msg, None
-    
     # Connect the submit button to the process function
     submit_btn.click(
         fn=process_request,