Update app.py

app.py

@@ -38,46 +38,109 @@ def generate_questions_with_retry(knowledge_material, question_type, cognitive_l
     # Adjust number of questions based on type
     if question_type == "Multiple Choice":
         num_questions = 3
+        format_instructions = f"""
+        For each multiple choice question:
+        1. Present the question clearly
+        2. Provide {num_choices} choices labeled with A, B, C{', D' if num_choices > 3 else ''}{', E' if num_choices > 4 else ''}
+        3. After all questions, provide an ANSWER KEY section with:
+           - The correct answer letter for each question
+           - A brief explanation of why this is the correct answer
+           - Why other options are incorrect
+        """
     elif question_type == "Fill in the Blank":
         num_questions = 10
+        format_instructions = """
+        For each fill-in-the-blank question:
+        1. Present the question with a clear blank space indicated by _____
+        2. After all questions, provide an ANSWER KEY section with:
+           - The correct answer for each blank
+           - A brief explanation of why this answer is correct
+           - Any alternative acceptable answers if applicable
+        """
     elif question_type == "True/False":
         num_questions = 5
+        format_instructions = """
+        For each true/false question:
+        1. Present the statement clearly
+        2. After all questions, provide an ANSWER KEY section with:
+           - Whether the statement is True or False
+           - A detailed explanation of why the statement is true or false
+           - The specific part of the source material that supports this answer
+        """
     else:  # Open-ended
         num_questions = 3
+        format_instructions = """
+        For each open-ended question:
+        1. Present the question clearly
+        2. After all questions, provide an ANSWER KEY section with:
+           - A structured scoring checklist of key points (minimum 3-5 points per question)
+           - Each key point should be worth a specific number of marks
+           - Total marks available for each question
+           - Sample answer that would receive full marks
+           - Common points that students might miss
+        """
 
     # Base prompt
-    prompt = f"Generate {num_questions} {question_type.lower()} exam questions based on {cognitive_level.lower()} level from the following material: {knowledge_material}. {extra_instructions}"
+    prompt = f"""Generate {num_questions} {question_type.lower()} exam questions based on {cognitive_level.lower()} level from the following material:
+
+{knowledge_material}
+
+{format_instructions}
+
+{extra_instructions}
+
+Please format the output clearly with:
+1. Questions section (numbered 1, 2, 3, etc.)
+2. Answer Key section (clearly separated from questions)
+3. Each answer should include explanation for better understanding
+
+Make sure all questions and answers are directly related to the provided material."""
 
     # Modify prompt for case-based medical situations
     if case_based:
-        prompt = f"Generate {num_questions} {question_type.lower()} exam questions based on {cognitive_level.lower()} level from the following medical material: {knowledge_material}. The questions should be based on case-based medical situations, such as patient scenarios. {extra_instructions}"
-        if question_type != "Fill in the Blank":
-            prompt += " Provide answers with short explanations."
+        prompt = f"""Generate {num_questions} {question_type.lower()} case-based medical exam questions based on {cognitive_level.lower()} level.
+
+Use this material as the medical knowledge base:
+{knowledge_material}
+
+Each question should:
+1. Start with a medical case scenario/patient presentation
+2. Include relevant clinical details
+3. Ask about diagnosis, treatment, or management
+4. Be at {cognitive_level.lower()} cognitive level
+
+{format_instructions}
 
-    # Add specific handling for Multiple Choice and True/False
-    if question_type == "Multiple Choice" and num_choices:
-        prompt += f" Each multiple choice question should have {num_choices} choices."
+{extra_instructions}
 
-    if question_type == "True/False":
-        prompt += " Provide short explanations for each question based on the given material, without stating True or False explicitly."
+Please format the output with:
+1. Cases and Questions (numbered 1, 2, 3, etc.)
+2. Detailed Answer Key section including:
+   - Correct answers
+   - Clinical reasoning
+   - Key diagnostic or treatment considerations
+   - Common pitfalls to avoid"""
 
     retries = 0
     while retries < max_retries:
         try:
             response = client.chat.completions.create(
-                model="gpt-4o-mini",  # or your preferred model
+                model="gpt-4o-mini",
                 messages=[
-                    {"role": "system", "content": "You are a helpful assistant for generating exam questions."},
+                    {"role": "system", "content": "You are an expert exam question generator with deep knowledge in medical education. Create clear, well-structured questions with detailed answer keys and explanations."},
                     {"role": "user", "content": prompt}
-                ]
+                ],
+                temperature=0.7,
+                max_tokens=3000  # Increased to accommodate answers and explanations
             )
             return response.choices[0].message.content
         except Exception as e:
             retries += 1
+            st.warning(f"Attempt {retries} failed. Retrying... Error: {str(e)}")
             if retries == max_retries:
                 st.error(f"Failed to generate questions after {max_retries} attempts. Error: {str(e)}")
                 return None
-            time.sleep(2)  # Wait before retrying
+            time.sleep(2)
 
 # ระบบ login
 if 'username' not in st.session_state: