Update app.py

app.py

@@ -141,47 +141,88 @@ def generate_story_continuation(user_input: str, level: str) -> str:
     """Generate AI story continuation using ChatGPT with level-appropriate content."""
     level_context = {
         'Beginner': """
-        Guidelines for Beginner level (Thai students grade 1-3):
-        - Use only Present Simple Tense
-        - Keep sentences very short and simple
-        - Use basic everyday vocabulary
-        - Focus on simple daily life topics
-        - Avoid complex words or phrases
+        Role: You are a teaching assistant for Thai students in grades 1-3.
+        Rules:
+        - Use only 1-2 VERY simple sentences
+        - Use Present Simple Tense only
+        - Use basic vocabulary (family, school, daily activities)
+        - Each sentence should be 5-7 words maximum
+        - Focus on clear, basic responses
+        Example responses:
+        - "The cat sits under the tree."
+        - "The boy plays with his toy car."
+        - "They walk to school together."
         """,
         'Intermediate': """
-        Guidelines for Intermediate level (Thai students grade 4-6):
-        - Use Present and Past Tense
-        - Sentences can be slightly complex
-        - Use more varied vocabulary
-        - Include some descriptive words
-        - Stories can have more development
+        Role: You are a teaching assistant for Thai students in grades 4-6.
+        Rules:
+        - Use exactly 2 sentences maximum
+        - Can use Present or Past Tense
+        - Keep each sentence under 12 words
+        - Use grade-appropriate vocabulary
+        - Add simple descriptions but stay concise
+        Example responses:
+        - "The brown cat jumped over the tall wooden fence. It landed softly in the garden."
+        - "Tom carefully opened his mysterious new book. The colorful pages showed amazing magical creatures."
         """,
         'Advanced': """
-        Guidelines for Advanced level (Thai students grade 7-9):
-        - Use various tenses appropriately
-        - Complex sentences are acceptable
-        - Advanced vocabulary can be used
-        - Creative and detailed storytelling
-        - More sophisticated plot development
+        Role: You are a teaching assistant for Thai students in grades 7-9.
+        Rules:
+        - Use 2-3 sentences maximum (no more!)
+        - Various tenses are allowed
+        - No strict word limit per sentence, but keep overall response concise
+        - Use more sophisticated vocabulary and sentence structures
+        - Create engaging responses that encourage creative continuation
+        - Focus on quality and natural flow rather than sentence length
+        Example responses:
+        - "Sarah discovered an ancient-looking letter hidden beneath the creaky floorboards. The yellowed paper contained a mysterious message."
+        - "As the storm clouds gathered overhead, James remembered the old legend about the mountain. Lightning illuminated the winding path that led to the cave entrance."
         """
     }
     
     try:
-        story_context = '\n'.join([entry['content'] for entry in st.session_state.story])
+        story_context = '\n'.join([entry['content'] for entry in st.session_state.story[-3:]])  # Only use last 3 entries
         
         response = client.chat.completions.create(
             model="gpt-4o-mini",
             messages=[
-                {"role": "system", "content": f"""You are a creative storytelling assistant for {level} level Thai students.
+                {"role": "system", "content": f"""You are a storytelling assistant for Thai students.
                 {level_context[level]}
-                Keep the language appropriate for the level while being engaging.
-                Respond with only 1-2 short sentences to continue the story."""},
-                {"role": "user", "content": f"Story so far:\n{story_context}\nUser's addition:\n{user_input}\nContinue the story with 1-2 short sentences:"}
+                CRUCIAL GUIDELINES:
+                - NEVER exceed the maximum number of sentences for the level
+                - Create openings for student's creativity
+                - Do not resolve plot points or conclude the story
+                - Avoid using 'suddenly' or 'then'
+                - Make each sentence meaningful but incomplete
+                - Leave room for the student to develop the story
+                
+                Remember: This is interactive storytelling - let the student drive the story forward."""},
+                {"role": "user", "content": f"Story context (recent):\n{story_context}\nStudent's input:\n{user_input}\nProvide a brief continuation:"}
             ],
-            max_tokens=50,
-            temperature=0.7
+            max_tokens={
+                'Beginner': 30,
+                'Intermediate': 40,
+                'Advanced': 50
+            }[level],
+            temperature=0.7,
+            presence_penalty=0.6,  # Discourage repetitive responses
+            frequency_penalty=0.6   # Encourage diversity in responses
         )
-        return response.choices[0].message.content
+        
+        # Additional length check and cleanup
+        response_text = response.choices[0].message.content.strip()
+        sentences = [s.strip() for s in response_text.split('.') if s.strip()]
+        
+        # Limit sentences based on level
+        max_sentences = {'Beginner': 2, 'Intermediate': 2, 'Advanced': 3}
+        if len(sentences) > max_sentences[level]:
+            sentences = sentences[:max_sentences[level]]
+        
+        # Reconstruct response with proper punctuation
+        response_text = '. '.join(sentences) + '.'
+            
+        return response_text
+        
     except Exception as e:
         st.error(f"Error generating story continuation: {str(e)}")
         return "I'm having trouble continuing the story. Please try again."