Update app.py

app.py

@@ -5,7 +5,7 @@ from openai import OpenAI
 from typing import Dict, List, Set
 
 # Initialize OpenAI client
-client = OpenAI()  # Make sure OPENAI_API_KEY is set in your environment variables
+client = OpenAI()
 
 # Set up Streamlit page configuration
 st.set_page_config(
@@ -19,8 +19,8 @@ st.set_page_config(
 def init_session_state():
     if 'story' not in st.session_state:
         st.session_state.story = []
-    if 'achievements' not in st.session_state:
-        st.session_state.achievements = []
+    if 'feedback' not in st.session_state:
+        st.session_state.feedback = None
     if 'level' not in st.session_state:
         st.session_state.level = 'Beginner'
     if 'unique_words' not in st.session_state:
@@ -42,10 +42,12 @@ def generate_story_continuation(user_input: str, level: str) -> str:
         response = client.chat.completions.create(
             model="gpt-4o-mini",
             messages=[
-                {"role": "system", "content": f"You are a creative storytelling assistant for {level} English learners. Keep the language simple and engaging, avoid complex vocabulary, and maintain story coherence."},
-                {"role": "user", "content": f"Story so far:\n{story_context}\nUser's addition:\n{user_input}\nContinue the story in an engaging way:"}
+                {"role": "system", "content": f"""You are a creative storytelling assistant for {level} English learners. 
+                Keep the language simple and engaging. Respond with only 1-2 short sentences to continue the story.
+                Avoid long descriptions and let the user contribute to the story development."""},
+                {"role": "user", "content": f"Story so far:\n{story_context}\nUser's addition:\n{user_input}\nContinue the story with 1-2 short sentences:"}
             ],
-            max_tokens=150,
+            max_tokens=50,
             temperature=0.7
         )
         return response.choices[0].message.content
@@ -77,7 +79,7 @@ def get_creative_prompt() -> str:
             model="gpt-4o-mini",
             messages=[
                 {"role": "system", "content": "Generate an inspiring question to help continue the story."},
-                {"role": "user", "content": "Create an open-ended question to inspire the next part of the story."}
+                {"role": "user", "content": "Create a short, open-ended question to inspire the next part of the story."}
             ],
             max_tokens=50,
             temperature=0.7
@@ -93,7 +95,7 @@ def provide_feedback(text: str, level: str) -> str:
         response = client.chat.completions.create(
             model="gpt-4o-mini",
             messages=[
-                {"role": "system", "content": f"You are an encouraging English teacher for {level} students. Provide one brief, positive piece of feedback."},
+                {"role": "system", "content": f"You are an encouraging English teacher for {level} students. Provide one brief, positive piece of feedback and one gentle correction if needed."},
                 {"role": "user", "content": f"Provide encouraging feedback on: {text}"}
             ],
             max_tokens=50,
@@ -110,7 +112,6 @@ def update_achievements(text: str):
     st.session_state.unique_words.update(words)
     st.session_state.total_words += len(words)
     
-    # Check for achievements
     achievements = {
         '50 Words': len(st.session_state.unique_words) >= 50,
         '100 Words': len(st.session_state.unique_words) >= 100,
@@ -125,7 +126,7 @@ def update_achievements(text: str):
 def reset_story():
     """Reset the story and related state variables."""
     st.session_state.story = []
-    st.session_state.achievements = []
+    st.session_state.feedback = None
     st.session_state.unique_words = set()
     st.session_state.total_words = 0
     st.session_state.badges = []
@@ -164,7 +165,10 @@ with col1:
             st.info("Start your adventure by writing the first sentence!")
         else:
             for entry in st.session_state.story:
-                st.write(f"{entry['role']}: {entry['content']}")
+                if entry['role'] == 'You':
+                    st.write("👤 You:", entry['content'])
+                elif entry['role'] == 'AI':
+                    st.write("🤖 AI:", entry['content'])
     
     # User Input Box
     st.header("Your Turn")
@@ -178,20 +182,23 @@ with col1:
             # Update achievements
             update_achievements(user_input)
             
-            # Get feedback
-            feedback = provide_feedback(user_input, st.session_state.level)
-            st.session_state.story.append({"role": "Feedback", "content": feedback})
+            # Generate feedback (stored separately)
+            st.session_state.feedback = provide_feedback(user_input, st.session_state.level)
             
             # Generate AI continuation
             ai_response = generate_story_continuation(user_input, st.session_state.level)
             st.session_state.story.append({"role": "AI", "content": ai_response})
             
-            # Clear the input and rerun
             st.rerun()
         else:
             st.warning("Please write something to continue the story.")
 
 with col2:
+    # Feedback Display (separate from story)
+    if st.session_state.feedback:
+        st.markdown("### 📝 Writing Feedback")
+        st.markdown(f"*{st.session_state.feedback}*")
+    
     # Help and Suggestions Box
     st.header("Writing Help")
     if st.button("Get Vocabulary Ideas"):
@@ -202,7 +209,7 @@ with col2:
     
     if st.button("Get a Creative Prompt"):
         creative_prompt = get_creative_prompt()
-        st.write(creative_prompt)
+        st.write("💭", creative_prompt)
     
     # Achievements Box
     st.header("Your Achievements")