Update sounds.py

sounds.py

@@ -28,60 +28,40 @@ class AudioManager:
 
     def get_audio_html(self) -> str:
         """Generate HTML for all audio elements"""
-        audio_elements = []
-        
-        # Background music (with loop)
-        if 'bgm' in self._audio_cache:
-            audio_elements.append(f"""
-                <audio id="bgm" loop>
-                    <source src="data:audio/mp3;base64,{self._audio_cache['bgm']}" type="audio/mp3">
-                </audio>
-            """)
-        
-        # Sound effects (without loop)
-        for name, base64_data in self._audio_cache.items():
-            if name != 'bgm':
-                audio_elements.append(f"""
-                    <audio id="sound_{name}">
-                        <source src="data:audio/mp3;base64,{base64_data}" type="audio/mp3">
-                    </audio>
-                """)
-        
-        # Add JavaScript controls
-        audio_elements.append("""
-            <script>
-            // Play specific sound
-            function playSound(id) {
-                const sound = document.getElementById(id);
-                if (sound) {
-                    sound.currentTime = 0;
-                    sound.play();
-                }
-            }
+        try:
+            audio_elements = []
             
-            // Toggle background music
-            function toggleBGM(play) {
-                const bgm = document.getElementById('bgm');
-                if (bgm) {
-                    if (play) {
-                        bgm.play();
-                    } else {
-                        bgm.pause();
-                    }
-                }
-            }
+            # Background music (with loop)
+            if 'bgm' in self._audio_cache:
+                audio_elements.append(
+                    f'<audio id="bgm" loop preload="auto" style="display:none;">'
+                    f'<source src="data:audio/mp3;base64,{self._audio_cache["bgm"]}" type="audio/mp3">'
+                    f'</audio>'
+                )
             
-            // Set volume for all audio
-            function setVolume(vol) {
-                const audios = document.getElementsByTagName('audio');
-                for (let audio of audios) {
-                    audio.volume = vol;
-                }
-            }
-            </script>
-        """)
-        
-        return "\n".join(audio_elements)
+            # Sound effects (without loop)
+            for name, base64_data in self._audio_cache.items():
+                if name != 'bgm':
+                    audio_elements.append(
+                        f'<audio id="sound_{name}" preload="auto" style="display:none;">'
+                        f'<source src="data:audio/mp3;base64,{base64_data}" type="audio/mp3">'
+                        f'</audio>'
+                    )
+            
+            # Add JavaScript controls in a more concise way
+            audio_elements.append("""
+                <script>
+                const playSound=e=>{const t=document.getElementById(e);t&&(t.currentTime=0,t.play())},
+                toggleBGM=e=>{const t=document.getElementById("bgm");t&&(e?t.play():t.pause())},
+                setVolume=e=>{document.getElementsByTagName("audio").forEach(t=>t.volume=e)};
+                </script>
+            """.strip())
+            
+            return "\n".join(audio_elements)
+            
+        except Exception as e:
+            logging.error(f"Error generating audio HTML: {str(e)}")
+            return ""
 
 def get_sound_commands() -> Dict[str, str]:
     """Get JavaScript commands for playing sounds"""