Update app.py

app.py

@@ -100,51 +100,70 @@ if 'vocabulary_used' not in st.session_state:
 
 def get_ai_story_continuation(story_context, level):
     """Get story continuation from OpenAI API"""
-    # Define level-specific parameters
-    level_params = {
-        'beginner': {
-            'complexity': "Use simple present tense and basic vocabulary. Keep sentences short (8-12 words).",
-            'examples': "Example: 'The dog runs to the park.' or 'She likes to read books.'"
-        },
-        'intermediate': {
-            'complexity': "Use present and past tense, compound sentences, and intermediate vocabulary.",
-            'examples': "Example: 'The excited dog rushed to the park, where his friends were waiting.'"
-        },
-        'advanced': {
-            'complexity': "Use varied tenses, complex sentences, and advanced vocabulary appropriately.",
-            'examples': "Example: 'Having spotted his friends at the park, the enthusiastic dog bounded over with unbridled joy.'"
-        }
-    }
-
     try:
         response = openai.ChatCompletion.create(
-            model="gpt-4o-mini",  # หรือ model ที่ถูกต้องตามที่คุณใช้
+            model="gpt-4o-mini",
             messages=[
                 {"role": "system", "content": f"""You are helping a {level} level English student write a story. 
-                {level_params[level]['complexity']}
-                {level_params[level]['examples']}
+                Follow these rules strictly:
+                1. Read the story context carefully
+                2. Continue the story logically from the last sentence
+                3. Never repeat the exact same sentence
+                4. Make sure each continuation adds new information
+                5. Suggest vocabulary that fits the current story context
                 
                 Provide a JSON response with:
-                1. continuation: A single sentence continuing the story (matching the specified level)
-                2. creative_prompt: A short question (3-8 words) to guide the student's next sentence
-                3. vocabulary_suggestions: 3 relevant words they might use next (appropriate for {level} level)
-                4. translation: Thai translation of the continuation sentence
-                
-                Ensure the story stays coherent with the context."""},
-                {"role": "user", "content": f"Story context: {story_context}\n\nProvide the next part of the story and a guiding question."}
+                1. continuation: A new sentence that continues the story logically
+                2. creative_prompt: A specific question about possible next events
+                3. vocabulary_suggestions: 3 relevant words that could be used next
+                4. translation: Thai translation of your continuation sentence"""},
+                {"role": "user", "content": f"""Current story context: {story_context}
+                Continue the story and ensure it connects with what happened before."""}
             ],
             temperature=0.7
         )
-        return json.loads(response.choices[0].message.content)
+        
+        # Validate the response
+        result = json.loads(response.choices[0].message.content)
+        
+        # Check if continuation is not too similar to previous content
+        if story_context and result['continuation'].lower() in story_context.lower():
+            # Try to get a new response
+            return get_ai_story_continuation(story_context, level)
+            
+        return result
+        
     except Exception as e:
         st.error(f"Error with AI response: {e}")
         return {
-            "continuation": "The story continues...",
-            "creative_prompt": "What happens next?",
-            "vocabulary_suggestions": ["word1", "word2", "word3"],
-            "translation": "เรื่องราวดำเนินต่อไป..."
+            "continuation": "Suddenly, something unexpected happened...",
+            "creative_prompt": "What did our character discover?",
+            "vocabulary_suggestions": ["discover", "surprise", "mystery"],
+            "translation": "ทันใดนั้น บางสิ่งที่ไม่คาดคิดก็เกิดขึ้น..."
         }
 
+def validate_story_quality(story_context, new_continuation):
+    """Validate that the story maintains quality and coherence"""
+    try:
+        validation = openai.ChatCompletion.create(
+            model="gpt-4o-mini",
+            messages=[
+                {"role": "system", "content": """Validate story coherence and quality.
+                Return JSON with:
+                1. is_coherent: boolean
+                2. reason: string explanation if not coherent"""},
+                {"role": "user", "content": f"""Previous: {story_context}
+                New continuation: {new_continuation}
+                Is this a logical and non-repetitive continuation?"""}
+            ]
+        )
+        
+        result = json.loads(validation.choices[0].message.content)
+        return result['is_coherent'], result.get('reason', '')
+        
+    except Exception:
+        return True, ""  # Default to accepting if validation fails
+
 def start_story(level):
     """Get the first sentence from AI"""
     # Define level-specific starting prompts
@@ -318,6 +337,13 @@ def process_player_input(user_input):
             story_context + "\n" + user_input,
             st.session_state.current_level
         )
+
+        # Validate the continuation
+        is_coherent, reason = validate_story_quality(story_context, ai_response['continuation'])
+        
+        if not is_coherent:
+            # Try getting a new response
+            ai_response = get_ai_story_continuation(story_context + "\n" + user_input, st.session_state.current_level)
         
         # Add AI's response to story
         st.session_state.story.append({