Update app.py

app.py

@@ -752,9 +752,9 @@ def generate_story_continuation(user_input: str, level: str) -> str:
     }
 
     try:
-        # Get recent story context
+        # Get recent story context (last 5 entries for more coherence)
         story_context = '\n'.join([
-            entry['content'] for entry in st.session_state.story[-3:]
+            entry['content'] for entry in st.session_state.story[-5:]
         ]) if st.session_state.story else "Story just started"
         
         # Create prompt
@@ -817,6 +817,7 @@ def generate_story_continuation(user_input: str, level: str) -> str:
         logging.error(f"Error generating story continuation: {str(e)}")
         return "I'm having trouble continuing the story. Please try again."
 
+
 def generate_dynamic_story_starter(theme_id: str, level: str) -> Dict[str, str]:
     """
     Dynamically generate a story starter based on theme and level.
@@ -1646,7 +1647,8 @@ def handle_ending_mode(text: str):
             ai_response = generate_ending_continuation(
                 text,
                 ending_type=st.session_state.ending_type,
-                remaining_sentences=remaining
+                remaining_sentences=remaining,
+                level=st.session_state.level
             )
             
             # Add AI response
@@ -1664,7 +1666,8 @@ def handle_ending_mode(text: str):
             # Generate final ending
             final_response = generate_final_ending(
                 st.session_state.story,
-                st.session_state.ending_type
+                st.session_state.ending_type,
+                level=st.session_state.level
             )
             
             # Add final AI response
@@ -1681,13 +1684,14 @@ def handle_ending_mode(text: str):
         # Clear input and rerun
         st.session_state.text_input = ""
         st.session_state.clear_input = True
-        st.rerun()  # Using st.rerun() instead of st.experimental_rerun()
+        st.rerun()
         
     except Exception as e:
         logging.error(f"Error in ending mode: {str(e)}")
         st.error("เกิดข้อผิดพลาดในโหมดจบเรื่อง กรุณาลองใหม่อีกครั้ง")
 
-def generate_final_ending(story: List[dict], ending_type: str) -> str:
+
+def generate_final_ending(story: List[dict], ending_type: str, level: str) -> str:
     """Generate the final ending sentence based on the story and chosen ending type"""
     try:
         # Create a comprehensive prompt for the final ending
@@ -1699,39 +1703,78 @@ def generate_final_ending(story: List[dict], ending_type: str) -> str:
                 - Brings joy and satisfaction
                 - Resolves the main story elements
                 - Ends on a positive note
-                Maximum 2 sentences.
-            """,
+                """,
             "Mysterious Ending": """
                 Create a final mysterious ending sentence that:
                 - Leaves an intriguing question
                 - Creates a sense of wonder
                 - Maintains some mystery
-                Maximum 2 sentences.
-            """,
+                """,
             "Lesson Learned": """
                 Create a final sentence that:
                 - Shows what was learned
                 - Provides a moral lesson
                 - Connects to the story's events
-                Maximum 2 sentences.
-            """,
+                """,
             "Surprise Ending": """
                 Create a final twist ending that:
                 - Provides an unexpected but logical conclusion
                 - Connects to previous story elements
                 - Creates a satisfying surprise
-                Maximum 2 sentences.
-            """
+                """
         }
 
+        level_context = {
+            'Beginner': {
+                'instructions': """
+                Additional Guidelines:
+                - Use only 1-2 VERY simple sentences
+                - Use Present Simple Tense only
+                - Basic vocabulary
+                - 5-7 words per sentence maximum
+                - Focus on clear, basic responses
+                """,
+                'max_tokens': 30,
+                'temperature': 0.6
+            },
+            'Intermediate': {
+                'instructions': """
+                Additional Guidelines:
+                - Use exactly 2 sentences maximum
+                - Can use Present or Past Tense
+                - Keep each sentence under 12 words
+                - Grade-appropriate vocabulary
+                - Add simple descriptions but stay concise
+                """,
+                'max_tokens': 40,
+                'temperature': 0.7
+            },
+            'Advanced': {
+                'instructions': """
+                Additional Guidelines:
+                - Use 2-3 sentences maximum
+                - Various tenses allowed
+                - Natural sentence length but keep overall response concise
+                - More sophisticated vocabulary and structures
+                - Create engaging responses that encourage creative continuation
+                """,
+                'max_tokens': 50,
+                'temperature': 0.8
+            }
+        }
+
+        level_settings = level_context[level]
+
         response = client.chat.completions.create(
-            model="gpt-4",
+            model="gpt-4o-mini",
             messages=[
                 {
                     "role": "system",
                     "content": f"""
-                    You are a master storyteller creating the final ending.
                     {ending_prompts[ending_type]}
+                    
+                    {level_settings['instructions']}
+                    
                     This must be the absolute final sentence(s) of the story.
                     Make it conclusive and satisfying.
                     """
@@ -1741,8 +1784,8 @@ def generate_final_ending(story: List[dict], ending_type: str) -> str:
                     "content": f"Story context:\n{story_summary}\n\nCreate the final ending:"
                 }
             ],
-            max_tokens=100,
-            temperature=0.7
+            max_tokens=level_settings['max_tokens'],
+            temperature=level_settings['temperature']
         )
         
         return response.choices[0].message.content.strip()
@@ -1751,7 +1794,8 @@ def generate_final_ending(story: List[dict], ending_type: str) -> str:
         logging.error(f"Error generating final ending: {str(e)}")
         return "And so, the story came to an end."
 
-def generate_ending_continuation(text: str, ending_type: str, remaining_sentences: int) -> str:
+
+def generate_ending_continuation(text: str, ending_type: str, remaining_sentences: int, level: str) -> str:
     """Generate AI continuation focusing on story conclusion"""
     try:
         ending_prompts = {
@@ -1789,6 +1833,52 @@ def generate_ending_continuation(text: str, ending_type: str, remaining_sentence
             """
         }
 
+        level_context = {
+            'Beginner': {
+                'instructions': """
+                Additional Guidelines:
+                - Use only 1-2 VERY simple sentences
+                - Use Present Simple Tense only
+                - Basic vocabulary
+                - 5-7 words per sentence maximum
+                - Focus on clear, basic responses
+                """,
+                'max_tokens': 30,
+                'temperature': 0.6
+            },
+            'Intermediate': {
+                'instructions': """
+                Additional Guidelines:
+                - Use exactly 2 sentences maximum
+                - Can use Present or Past Tense
+                - Keep each sentence under 12 words
+                - Grade-appropriate vocabulary
+                - Add simple descriptions but stay concise
+                """,
+                'max_tokens': 40,
+                'temperature': 0.7
+            },
+            'Advanced': {
+                'instructions': """
+                Additional Guidelines:
+                - Use 2-3 sentences maximum
+                - Various tenses allowed
+                - Natural sentence length but keep overall response concise
+                - More sophisticated vocabulary and structures
+                - Create engaging responses that encourage creative continuation
+                """,
+                'max_tokens': 50,
+                'temperature': 0.8
+            }
+        }
+
+        # Get recent story context
+        story_context = '\n'.join([
+            entry['content'] for entry in st.session_state.story[-5:]
+        ]) if st.session_state.story else "Story just started"
+
+        level_settings = level_context[level]
+
         response = client.chat.completions.create(
             model="gpt-4o-mini",
             messages=[
@@ -1797,21 +1887,22 @@ def generate_ending_continuation(text: str, ending_type: str, remaining_sentence
                     "content": f"""
                     {ending_prompts[ending_type]}
                     
+                    {level_settings['instructions']}
+                    
                     Additional Rules:
                     - You have {remaining_sentences} sentences left to conclude the story.
                     - Each response should be maximum 2 sentences.
                     - Build towards the finale naturally.
                     - Ensure coherence with previous story events.
-                    - Indicate awareness of the remaining sentences.
                     """
                 },
                 {
                     "role": "user",
-                    "content": f"Continue and work towards ending this story: {text}"
+                    "content": f"Story context:\n{story_context}\nStudent's input:\n{text}\nContinue and work towards ending this story:"
                 }
             ],
-            max_tokens=100,
-            temperature=0.7
+            max_tokens=level_settings['max_tokens'],
+            temperature=level_settings['temperature']
         )
 
         return response.choices[0].message.content.strip()
@@ -1820,7 +1911,6 @@ def generate_ending_continuation(text: str, ending_type: str, remaining_sentence
         logging.error(f"Error generating ending continuation: {str(e)}")
         return "The story moved towards its conclusion..."
 
-
 def complete_story():
     """Handle story completion and celebration"""
     st.balloons()  # แสดงเอฟเฟคฉลอง