Update app.py

app.py

@@ -967,7 +967,7 @@ def update_achievements():
         return False
 
 def provide_feedback(text: str, level: str) -> Dict[str, str]:
-    """Provide feedback on the user's writing with appropriate level"""
+    """Provide more detailed feedback on the user's writing with appropriate level"""
     
     level_prompts = {
         'Beginner': """
@@ -977,6 +977,7 @@ def provide_feedback(text: str, level: str) -> Dict[str, str]:
         - Basic vocabulary
         - Capitalization and periods
         Provide very simple, encouraging feedback in Thai.
+        Explain any mistakes and how to correct them.
         """,
         'Intermediate': """
         Focus on:
@@ -986,6 +987,7 @@ def provide_feedback(text: str, level: str) -> Dict[str, str]:
         - Basic punctuation
         - Simple conjunctions
         Provide moderately detailed feedback in Thai.
+        Explain any mistakes and suggest improvements.
         """,
         'Advanced': """
         Focus on:
@@ -995,6 +997,7 @@ def provide_feedback(text: str, level: str) -> Dict[str, str]:
         - All punctuation
         - Style and flow
         Provide comprehensive feedback in Thai.
+        Explain any mistakes and provide examples for improvement.
         """
     }
 
@@ -1025,8 +1028,8 @@ def provide_feedback(text: str, level: str) -> Dict[str, str]:
                             "content": f"Review this sentence: {text}"
                         }
                     ],
-                    max_tokens=200,
-                    temperature=0.3
+                    max_tokens=300,  # Increased from 200
+                    temperature=0.5  # Adjusted for balanced variety
                 )
                 
                 # Parse response
@@ -1057,6 +1060,7 @@ def provide_feedback(text: str, level: str) -> Dict[str, str]:
             "difficulty_score": 5
         }
 
+
 def get_vocabulary_suggestions(context: str = "", level: str = DEFAULT_LEVEL) -> List[str]:
     """Get contextual vocabulary suggestions with Thai translations"""
     try:
@@ -1628,24 +1632,40 @@ def handle_ending_mode(text: str):
         # Get current remaining sentences
         remaining = st.session_state.sentences_to_end
 
+        # Get feedback
+        feedback_data = provide_feedback(text, st.session_state.level)
+        st.session_state.feedback = feedback_data
+        is_correct = not feedback_data.get('has_errors', False)
+        
         # Add user's sentence
         st.session_state.story.append({
             "role": "You",
             "content": text,
             "is_corrected": False,
-            "is_correct": True,
+            "is_correct": is_correct,
             "timestamp": datetime.now().isoformat(),
             "remaining_sentences": remaining
         })
         
+        # Update vocabulary
+        words = set(text.lower().split())
+        st.session_state.stats['vocabulary_used'].update(words)
+        
+        # Update points and achievements
+        update_points(is_correct)
+        update_achievements()
+        
         # Decrease remaining count for user's sentence
         st.session_state.sentences_to_end -= 1
         remaining = st.session_state.sentences_to_end
         
         if remaining > 0:
+            # Use corrected text if there are errors
+            text_for_continuation = feedback_data['corrected'] if feedback_data.get('has_errors') else text
+            
             # Generate AI's ending continuation
             ai_response = generate_ending_continuation(
-                text,
+                text_for_continuation,
                 ending_type=st.session_state.ending_type,
                 remaining_sentences=remaining,
                 level=st.session_state.level
@@ -1691,36 +1711,41 @@ def handle_ending_mode(text: str):
         st.error("เกิดข้อผิดพลาดในโหมดจบเรื่อง กรุณาลองใหม่อีกครั้ง")
 
 
+
 def generate_final_ending(story: List[dict], ending_type: str, level: str) -> str:
-    """Generate the final ending sentence based on the story and chosen ending type"""
+    """Generate the final ending sentences based on the story and chosen ending type"""
     try:
         # Create a comprehensive prompt for the final ending
         story_summary = " ".join([entry['content'] for entry in story[-5:]])  # Last 5 sentences
         
         ending_prompts = {
             "Happy Ending": """
-                Create a final happy ending sentence that:
+                Create a final happy ending that:
                 - Brings joy and satisfaction
                 - Resolves the main story elements
                 - Ends on a positive note
+                - Use 2-3 sentences
                 """,
             "Mysterious Ending": """
-                Create a final mysterious ending sentence that:
+                Create a final mysterious ending that:
                 - Leaves an intriguing question
                 - Creates a sense of wonder
                 - Maintains some mystery
+                - Use 2-3 sentences
                 """,
             "Lesson Learned": """
-                Create a final sentence that:
+                Create a final ending that:
                 - Shows what was learned
                 - Provides a moral lesson
                 - Connects to the story's events
+                - Use 2-3 sentences
                 """,
             "Surprise Ending": """
                 Create a final twist ending that:
                 - Provides an unexpected but logical conclusion
                 - Connects to previous story elements
                 - Creates a satisfying surprise
+                - Use 2-3 sentences
                 """
         }
 
@@ -1728,37 +1753,34 @@ def generate_final_ending(story: List[dict], ending_type: str, level: str) -> st
             'Beginner': {
                 'instructions': """
                 Additional Guidelines:
-                - Use only 1-2 VERY simple sentences
-                - Use Present Simple Tense only
+                - Use simple sentences
+                - Use Present Simple Tense
                 - Basic vocabulary
-                - 5-7 words per sentence maximum
-                - Focus on clear, basic responses
+                - 7-10 words per sentence maximum
                 """,
-                'max_tokens': 30,
+                'max_tokens': 100,  # Increased to allow for longer endings
                 'temperature': 0.6
             },
             'Intermediate': {
                 'instructions': """
                 Additional Guidelines:
-                - Use exactly 2 sentences maximum
+                - Use 2-3 sentences
                 - Can use Present or Past Tense
-                - Keep each sentence under 12 words
+                - Keep each sentence under 15 words
                 - Grade-appropriate vocabulary
-                - Add simple descriptions but stay concise
                 """,
-                'max_tokens': 40,
+                'max_tokens': 120,  # Increased
                 'temperature': 0.7
             },
             'Advanced': {
                 'instructions': """
                 Additional Guidelines:
-                - Use 2-3 sentences maximum
+                - Use 2-3 sentences
                 - Various tenses allowed
                 - Natural sentence length but keep overall response concise
                 - More sophisticated vocabulary and structures
-                - Create engaging responses that encourage creative continuation
                 """,
-                'max_tokens': 50,
+                'max_tokens': 150,  # Increased
                 'temperature': 0.8
             }
         }
@@ -1775,7 +1797,7 @@ def generate_final_ending(story: List[dict], ending_type: str, level: str) -> st
                     
                     {level_settings['instructions']}
                     
-                    This must be the absolute final sentence(s) of the story.
+                    This must be the absolute final sentences of the story.
                     Make it conclusive and satisfying.
                     """
                 },
@@ -1795,6 +1817,7 @@ def generate_final_ending(story: List[dict], ending_type: str, level: str) -> st
         return "And so, the story came to an end."
 
 
+
 def generate_ending_continuation(text: str, ending_type: str, remaining_sentences: int, level: str) -> str:
     """Generate AI continuation focusing on story conclusion"""
     try: