Merge pull request #15 from andreamalhera/10-feature-selection-visualisation-of-genel-target-diff

.github/workflows/test_gedi.yml

@@ -71,11 +71,11 @@ jobs:
 
     - name: Compare output 3
       run: 
-        diff data/validation/genELexperiment3_04.json output/features/grid_feat/2_enself_rt20v/genELexperiment3_04_nan.json
+        diff data/validation/genELexperiment3_04_nan.json output/features/grid_feat/2_enself_rt20v/genELexperiment3_04_nan.json
 
     - name: Compare output 4
       run: 
-        diff data/validation/genELexperiment4_02.json output/features/grid_feat/2_enself_rt20v/genELexperiment4_nan_02.json
+        diff data/validation/genELexperiment4_nan_02.json output/features/grid_feat/2_enself_rt20v/genELexperiment4_nan_02.json
 
   test_benchmark:
     runs-on: ubuntu-latest

data/validation/genELexperiment1_04_02.json

@@ -1 +1 @@
-{"ratio_top_20_variants": 0.20017714791851196, "epa_normalized_sequence_entropy_linear_forgetting": 0.052097205658647734, "log": "experiment1"}
+{"ratio_top_20_variants": 0.20017714791851196, "epa_normalized_sequence_entropy_linear_forgetting": 0.052097205658647734, "log": "genELexperiment1_04_02"}

data/validation/genELexperiment2_07_04.json

@@ -1 +1 @@
-{"ratio_top_20_variants": 0.38863337713534823, "epa_normalized_sequence_entropy_linear_forgetting": 0.052097205658647734, "log": "experiment2"}
+{"ratio_top_20_variants": 0.38863337713534823, "epa_normalized_sequence_entropy_linear_forgetting": 0.052097205658647734, "log": "genELexperiment2_07_04"}

data/validation/{genELexperiment3_04.json → genELexperiment3_04_nan.json}

@@ -1 +1 @@
-{"epa_normalized_sequence_entropy_linear_forgetting": 0.052097205658647734, "log": "experiment3"}
+{"epa_normalized_sequence_entropy_linear_forgetting": 0.052097205658647734, "log": "genELexperiment3_04_nan"}

data/validation/genELexperiment4_02.json

@@ -1 +0,0 @@
-{"ratio_top_20_variants": 0.2, "log": "experiment4"}

data/validation/genELexperiment4_nan_02.json

@@ -0,0 +1 @@
+{"ratio_top_20_variants": 0.2, "log": "genELexperiment4_nan_02"}

gedi/generator.py

@@ -220,8 +220,9 @@ class GenerateEventLogs():
         #TODO: Replace hotfix
         if features_to_dump.get('ratio_unique_traces_per_trace'):#HOTFIX
             features_to_dump['ratio_variants_per_number_of_traces']=features_to_dump.pop('ratio_unique_traces_per_trace')
-        features_to_dump['log'] = identifier.replace('genEL', '')
+        features_to_dump['log']= os.path.split(save_path)[1].split(".")[0]
         dump_features_json(features_to_dump, save_path)
+
         return log_config
 
     def generate_optimized_log(self, config):