prevent double entry

App/Messages/MessagesRoute.py

@@ -18,17 +18,19 @@ message_router = APIRouter(tags=["Messages"], prefix="/messages")
 
 
 @message_router.post("/sms_received", response_model=MessageResponse)
-async def receive_message(request: Request):
+async def receive_message(message_data: MessageCreate):
+    message = Message.get_or_none(message_id=message_data.id)
 
-    message_raw = await request.json()
-    message_data = MessageCreate(**message_raw)
     try:
         # Extract data from the message content using regex
         text = message_data.payload.message
         parsed_data = parse_message_content(text)
-        # Process Mpesa Payments
-        if parsed_data:
+
+        # Process Mpesa Payments and prevent double entry from the sms gateway app (message_id must be unique)
+        if parsed_data and not message:
             user: User = User.get_or_none(phoneNumber=parsed_data.phone_number)
+
+            # if the user sent an exact amount
             data_plan: Plan = Plan.get_or_none(
                 amount=Decimal(parsed_data.amount_received)
             )
@@ -40,23 +42,26 @@ async def receive_message(request: Request):
                 transaction_id=parsed_data.transaction_id,
             )
 
-        payment: Payment = await create_payment(payment_details)
-        # Create a new message record with parsed_data
-        new_message = await Message.create(
-            device_id=message_data.deviceId,
-            event=message_data.event,
-            message_id=message_data.id,
-            webhook_id=message_data.webhookId,
-            message_content=text,
-            phone_number=message_data.payload.phoneNumber,
-            received_at=message_data.payload.receivedAt,
-            sim_number=message_data.payload.simNumber,
-            parsed_data=parsed_data,
-        )
-
-        data = MessageResponse.from_orm(new_message)
-
-        await payment.create_subscription_or_balance()
+            payment: Payment = await create_payment(payment_details)
+            await payment.create_subscription_or_balance()
+
+        # prevent double entries
+        if not message:
+            # Create a new message record with parsed_data
+            message = await Message.create(
+                device_id=message_data.deviceId,
+                event=message_data.event,
+                message_id=message_data.id,
+                webhook_id=message_data.webhookId,
+                message_content=text,
+                phone_number=message_data.payload.phoneNumber,
+                received_at=message_data.payload.receivedAt,
+                sim_number=message_data.payload.simNumber,
+                parsed_data=parsed_data,
+            )
+
+        data = MessageResponse.from_orm(message)
+
         return data
     except Exception as e:
         raise HTTPException(status_code=400, detail=str(e))