Update app.py

app.py

@@ -221,8 +221,9 @@ def _convert_gr_history_to_api_messages(system_prompt, gr_history, current_user_
     return messages
 
 def _generate_ui_outputs_from_cache(owner, space_name):
-    # This function only reads the global variable, does not need 'global' declaration
-    global parsed_code_blocks_state_cache # Added global here just in case, although technically not needed for reads only.
+    # This function only reads the global variable, does not need 'global' declaration to read.
+    # Added global for consistency, but technically reads don't require it.
+    global parsed_code_blocks_state_cache
     preview_md_val = "*No files in cache to display.*"
     formatted_md_val = f"# Space: {owner}/{space_name}\n## File Structure\n{bbb}\n📁 Root\n{bbb}\n\n*No files in cache.*" if owner or space_name else "*Load or define a Space to see its Markdown structure.*"
     download_file = None
@@ -254,6 +255,8 @@ def _generate_ui_outputs_from_cache(owner, space_name):
     return formatted_md_val, preview_md_val, gr.update(value=download_file, interactive=download_file is not None)
 
 def handle_chat_submit(user_message, chat_history, api_key_input, provider_select, model_select, system_prompt, hf_owner_name, hf_repo_name, _current_formatted_markdown):
+    # This global declaration is needed because the function ASSIGNS to parsed_code_blocks_state_cache later.
+    # It must be at the very top of the function before any use or assignment.
     global parsed_code_blocks_state_cache
     _chat_msg_in = ""
     _chat_hist = list(chat_history)
@@ -264,8 +267,7 @@ def handle_chat_submit(user_message, chat_history, api_key_input, provider_selec
         try:
             parsed_from_md = build_logic_parse_markdown(_current_formatted_markdown)
             new_cache_state = []
-            # This loop accesses parsed_code_blocks_state_cache, but the global declaration
-            # is correctly placed *before* this use in this function.
+            # This line USES parsed_code_blocks_state_cache. It must come AFTER the global declaration.
             existing_structure_block = next((b for b in parsed_code_blocks_state_cache if b.get("is_structure_block")), None)
             if existing_structure_block:
                  new_cache_state.append(existing_structure_block.copy())
@@ -294,9 +296,7 @@ def handle_chat_submit(user_message, chat_history, api_key_input, provider_selec
                                  "is_structure_block": False
                             })
             new_cache_state.sort(key=lambda b: (0, b["filename"]) if b.get("is_structure_block") else (1, b["filename"]))
-            # This is an assignment to parsed_code_blocks_state_cache.
-            # The 'global' declaration needs to be before the first assignment *or* use.
-            # It is correctly placed at the start of the function.
+            # This line ASSIGNS to parsed_code_blocks_state_cache. This is why the global declaration is needed.
             parsed_code_blocks_state_cache = new_cache_state
 
         except Exception as e:
@@ -312,7 +312,7 @@ def handle_chat_submit(user_message, chat_history, api_key_input, provider_selec
     current_sys_prompt = system_prompt.strip() or DEFAULT_SYSTEM_PROMPT
 
     current_files_context = ""
-    # This block accesses parsed_code_blocks_state_cache, after the global declaration.
+    # This block USES parsed_code_blocks_state_cache. It must come AFTER the global declaration.
     if parsed_code_blocks_state_cache:
         current_files_context = "\n\n## Current Files in Space\n"
         for block in parsed_code_blocks_state_cache:
@@ -355,15 +355,16 @@ def handle_chat_submit(user_message, chat_history, api_key_input, provider_selec
         elif full_bot_response_content and not full_bot_response_content.startswith("Error: "):
             _status = f"Streaming complete. Processing files from {model_select} response..."
 
-            # This block accesses and assigns to parsed_code_blocks_state_cache,
-            # after the global declaration at the top of the function.
+            # This line USES parsed_code_blocks_state_cache.
             parsing_res = _parse_chat_stream_logic(full_bot_response_content, existing_files_state=parsed_code_blocks_state_cache)
 
             if parsing_res["error_message"]:
                 _status = f"Parsing Error: {parsing_res['error_message']}"
                 _detected_files_update = gr.Markdown(f"## Parsing Error\n`{escape_html_for_markdown(parsing_res['error_message'])}`")
             else:
-                global parsed_code_blocks_state_cache # Redundant global, but harmless. The one at the top is effective.
+                # REMOVE THE REDUNDANT GLOBAL DECLARATION HERE.
+                # global parsed_code_blocks_state_cache # Redundant global, but harmless. The one at the top is effective.
+                # This line ASSIGNS to parsed_code_blocks_state_cache.
                 parsed_code_blocks_state_cache = parsing_res["parsed_code_blocks"]
 
                 _formatted_output_update, _detected_files_update, _download_btn_update = _generate_ui_outputs_from_cache(hf_owner_name, hf_repo_name)
@@ -399,6 +400,7 @@ def update_models_dropdown(provider_select):
     return gr.update(choices=models, value=selected_value)
 
 def handle_load_existing_space(hf_api_key_ui, ui_owner_name, ui_space_name):
+    # This global declaration is needed because the function ASSIGNS to parsed_code_blocks_state_cache later.
     global parsed_code_blocks_state_cache
     _formatted_md_val, _detected_preview_val, _status_val = "*Loading files...*", "*Loading files...*", f"Loading Space: {ui_owner_name}/{ui_space_name}..."
     _file_browser_update, _iframe_html_update, _download_btn_update = gr.update(visible=False, choices=[], value=None), gr.update(value=None, visible=False), gr.update(interactive=False, value=None)
@@ -429,6 +431,7 @@ def handle_load_existing_space(hf_api_key_ui, ui_owner_name, ui_space_name):
 
     if error_occurred:
          yield (f"*Error: {_status_val}*", f"*Error: {_status_val}*", _status_val, _file_browser_update, updated_owner_name_val, ui_space_name, _iframe_html_update, _download_btn_update, _build_status_clear, _edit_status_clear, _runtime_status_clear, _chat_history_clear)
+         # This line ASSIGNS to parsed_code_blocks_state_cache.
          parsed_code_blocks_state_cache = []
          return
 
@@ -441,6 +444,7 @@ def handle_load_existing_space(hf_api_key_ui, ui_owner_name, ui_space_name):
 
     if err_list_files and not file_list:
         _status_val = f"File List Error: {err_list_files}"
+        # This line ASSIGNS to parsed_code_blocks_state_cache.
         parsed_code_blocks_state_cache = []
         _formatted_md_val, _detected_preview_val, _download_btn_update = _generate_ui_outputs_from_cache(owner_to_use, ui_space_name)
         _file_browser_update = gr.update(visible=True, choices=[], value="Error loading files")
@@ -449,6 +453,7 @@ def handle_load_existing_space(hf_api_key_ui, ui_owner_name, ui_space_name):
 
     if not file_list:
         _status_val = f"Loaded Space: {owner_to_use}/{ui_space_name}. No files found ({err_list_files or 'Repository is empty'})."
+        # This line ASSIGNS to parsed_code_blocks_state_cache.
         parsed_code_blocks_state_cache = []
         _formatted_md_val, _detected_preview_val, _download_btn_update = _generate_ui_outputs_from_cache(owner_to_use, ui_space_name)
         _file_browser_update = gr.update(visible=True, choices=[], value="No files found")
@@ -483,6 +488,7 @@ def handle_load_existing_space(hf_api_key_ui, ui_owner_name, ui_space_name):
             print(f"Unexpected error loading {file_path}: {content_ex}")
             continue
 
+    # This line ASSIGNS to parsed_code_blocks_state_cache.
     parsed_code_blocks_state_cache = loaded_files_for_cache
     _formatted_md_val, _detected_preview_val, _download_btn_update = _generate_ui_outputs_from_cache(owner_to_use, ui_space_name)
     _status_val = f"Successfully loaded Space: {owner_to_use}/{ui_space_name}. Markdown ready. {len(file_list)} files listed."
@@ -491,6 +497,7 @@ def handle_load_existing_space(hf_api_key_ui, ui_owner_name, ui_space_name):
     yield (_formatted_md_val, _detected_preview_val, _status_val, _file_browser_update, updated_owner_name_val, ui_space_name, _iframe_html_update, _download_btn_update, _build_status_clear, _edit_status_clear, _runtime_status_clear, _chat_history_clear)
 
 def handle_build_space_button(hf_api_key_ui, ui_space_name_part, ui_owner_name_part, space_sdk_ui, formatted_markdown_content):
+    # This global declaration is needed because the function ASSIGNS to parsed_code_blocks_state_cache later.
     global parsed_code_blocks_state_cache
     _build_status, _iframe_html, _file_browser_update = "Starting space build process...", gr.update(value=None, visible=False), gr.update(visible=False, choices=[], value=None)
     yield _build_status, _iframe_html, _file_browser_update, gr.update(value=ui_owner_name_part), gr.update(value=ui_space_name_part)
@@ -511,7 +518,8 @@ def handle_build_space_button(hf_api_key_ui, ui_space_name_part, ui_owner_name_p
 
     try:
         parsed_from_md_for_build = build_logic_parse_markdown(formatted_markdown_content)
-        parsed_code_blocks_state_cache = [] # Assignment to global variable
+        # This line ASSIGNS to parsed_code_blocks_state_cache.
+        parsed_code_blocks_state_cache = []
         if parsed_from_md_for_build.get("owner_md"):
              ui_owner_name_part = parsed_from_md_for_build["owner_md"]
         if parsed_from_md_for_build.get("repo_name_md"):
@@ -519,7 +527,8 @@ def handle_build_space_button(hf_api_key_ui, ui_space_name_part, ui_owner_name_p
 
         structure_block_md = next((f for f in parsed_from_md_for_build.get("files", []) if f.get("path") == "File Structure (original)"), None)
         if structure_block_md:
-             parsed_code_blocks_state_cache.append({ # Modifies global list
+             # This line modifies the global list.
+             parsed_code_blocks_state_cache.append({
                  "filename": structure_block_md["path"],
                  "code": structure_block_md["content"],
                  "language": "plaintext",
@@ -530,14 +539,16 @@ def handle_build_space_button(hf_api_key_ui, ui_space_name_part, ui_owner_name_p
         for f_info in parsed_from_md_for_build.get("files", []):
              if f_info.get("path") and f_info["path"] != "File Structure (original)":
                   is_binary_repr = isinstance(f_info.get("content"), str) and (f_info["content"].startswith("[Binary file") or f_info["content"].startswith("[Error loading content:") or f_info["content"].startswith("[Binary or Skipped file]"))
-                  parsed_code_blocks_state_cache.append({ # Modifies global list
+                  # This line modifies the global list.
+                  parsed_code_blocks_state_cache.append({
                        "filename": f_info["path"],
                        "code": f_info.get("content", ""),
                        "language": "binary" if is_binary_repr else _infer_lang_from_filename(f_info["path"]),
                        "is_binary": is_binary_repr,
                        "is_structure_block": False
                   })
-        parsed_code_blocks_state_cache.sort(key=lambda b: (0, b["filename"]) if b.get("is_structure_block") else (1, b["filename"])) # Modifies global list
+        # This line modifies the global list.
+        parsed_code_blocks_state_cache.sort(key=lambda b: (0, b["filename"]) if b.get("is_structure_block") else (1, b["filename"]))
 
     except Exception as e:
          _build_status = f"Build Error: Failed to parse Markdown structure before building: {e}";
@@ -563,7 +574,9 @@ def handle_build_space_button(hf_api_key_ui, ui_space_name_part, ui_owner_name_p
     yield _build_status, _iframe_html, _file_browser_update, owner_name_output, space_name_output
 
 def handle_load_file_for_editing(hf_api_key_ui, ui_space_name_part, ui_owner_name_part, selected_file_path):
-    global parsed_code_blocks_state_cache # This function only reads, does not strictly need global.
+    # This function only reads the global variable, does not strictly need global.
+    # Added global for consistency, but technically reads don't require it.
+    global parsed_code_blocks_state_cache
     _file_content_val, _edit_status_val, _commit_msg_val, _lang_update = "", "Error: No file selected.", gr.update(value=""), gr.update(language="python")
     if not selected_file_path or selected_file_path in ["No files found", "Error loading files", "Error refreshing files"]:
          yield _file_content_val, "Select a file from the dropdown.", _commit_msg_val, _lang_update
@@ -603,6 +616,7 @@ def handle_load_file_for_editing(hf_api_key_ui, ui_space_name_part, ui_owner_nam
     yield _file_content_val, _edit_status_val, _commit_msg_val, _lang_update
 
 def handle_commit_file_changes(hf_api_key_ui, ui_space_name_part, ui_owner_name_part, file_to_edit_path, edited_content, commit_message):
+    # This global declaration is needed because the function ASSIGNS to parsed_code_blocks_state_cache later.
     global parsed_code_blocks_state_cache
     _edit_status_val = "Processing commit..."
     _file_browser_update_val = gr.update()
@@ -634,8 +648,7 @@ def handle_commit_file_changes(hf_api_key_ui, ui_space_name_part, ui_owner_name_
 
     if "Successfully updated" in status_msg:
         found_in_cache = False
-        # Modifies item within the global list. No need for global declaration here if the list itself isn't reassigned.
-        # But if the file was new, it might be added later, which requires global.
+        # This loop modifies items within the global list.
         for block in parsed_code_blocks_state_cache:
             if block["filename"] == file_to_edit_path:
                 block["code"] = edited_content
@@ -645,8 +658,9 @@ def handle_commit_file_changes(hf_api_key_ui, ui_space_name_part, ui_owner_name_
                 found_in_cache = True
                 break
         if not found_in_cache:
-             # Assignment to global variable
+             # This line ASSIGNS to parsed_code_blocks_state_cache.
              parsed_code_blocks_state_cache = [b for b in parsed_code_blocks_state_cache if b["filename"] != file_to_edit_path]
+             # This line modifies the global list.
              parsed_code_blocks_state_cache.append({
                  "filename": file_to_edit_path,
                  "code": edited_content,
@@ -654,6 +668,7 @@ def handle_commit_file_changes(hf_api_key_ui, ui_space_name_part, ui_owner_name_
                  "is_binary": False,
                  "is_structure_block": False
              })
+             # This line modifies the global list.
              parsed_code_blocks_state_cache.sort(key=lambda b: (0, b["filename"]) if b.get("is_structure_block") else (1, b["filename"]))
 
         _formatted_md_out, _detected_preview_out, _download_btn_out = _generate_ui_outputs_from_cache(owner_to_use, ui_space_name_part)
@@ -668,6 +683,7 @@ def handle_commit_file_changes(hf_api_key_ui, ui_space_name_part, ui_owner_name_
     yield _edit_status_val, _file_browser_update_val, _formatted_md_out, _detected_preview_out, _download_btn_out
 
 def handle_delete_file(hf_api_key_ui, ui_space_name_part, ui_owner_name_part, file_to_delete_path):
+    # This global declaration is needed because the function ASSIGNS to parsed_code_blocks_state_cache later.
     global parsed_code_blocks_state_cache
     _edit_status_val = "Processing deletion..."
     _file_browser_choices_update = gr.update()
@@ -704,7 +720,7 @@ def handle_delete_file(hf_api_key_ui, ui_space_name_part, ui_owner_name_part, fi
     new_file_list, err_list = list_space_files_for_browsing(hf_api_key_ui, ui_space_name_part, owner_to_use)
 
     if "Successfully deleted" in deletion_status_msg:
-        # Assignment to global variable
+        # This line ASSIGNS to parsed_code_blocks_state_cache.
         parsed_code_blocks_state_cache = [b for b in parsed_code_blocks_state_cache if b["filename"] != file_to_delete_path]
         _formatted_md_out, _detected_preview_out, _download_btn_out = _generate_ui_outputs_from_cache(owner_to_use, ui_space_name_part)