Redo format_response to be more serial

app.py

@@ -133,59 +133,59 @@ def execute_request(ids: list[str]) -> list[Work]:
     return [response[id_] for id_ in ids]
 
 
+def collapse_newlines(x: str) -> str:
+    return x.replace("\r\n", " ").replace("\n", " ").replace("\r", " ")
+
+
 def format_response(neighbors: list[Work], distances: list[float]) -> str:
-    result_string = ''
+    result_string = ""
     for work, distance in zip(neighbors, distances):
-        # edge cases: no title
-        abstract = work.abstract if work.abstract is not None else "No abstract"
-
-        # title: knock out escape sequences
-        if work.title is not None:
-            title = work.title.replace('\n', '\\n').replace('\r', '\\r')
-        else:  # edge case: no title
-            title = "No title"
-        
-        # abstract: knock out escape sequences, then truncate to 2000 chars
-        if work.abstract:
-            abstract = work.abstract.replace('\n', '\\n').replace('\r', '\\r')
-            if len(abstract) > 2000:
-                abstract = abstract[:2000] + '...'
-        else:  # edge case: no abstract
-            abstract = "No abstract"
-        
-        # authors: truncate to 3 authors if necessary
-        if len(work.authors) >= 3:
-            authors_str = ', '.join(work.authors[:3]) + ', ...'
-        elif work.authors:
-            authors_str = ', '.join(work.authors)
-        else:  # edge case: no authors
-            authors_str = "No author"
+        entry_string = "## "
+
+        if work.title and work.doi:
+            entry_string += f"[{collapse_newlines(work.title)}]({work.doi})"
+        elif work.title:
+            entry_string += f"{collapse_newlines(work.title)}"
+        elif work.doi:
+            entry_string += f"[No title]({work.doi})"
+        else:
+            entry_string += "No title"
 
-        entry_string = ''
+        entry_string += "\n\n**"
 
-        if work.doi:  # edge case: for now, no doi -> no link
-            entry_string += f'## [{title}]({work.doi})\n\n'
+        if len(work.authors) >= 3:  # truncate to 3 if necessary
+            entry_string += ', '.join(work.authors[:3]) + ', ...'
+        elif work.authors:
+            entry_string += ', '.join(work.authors)
         else:
-            entry_string += f'## {title}\n\n'
-        
+            entry_string += "No author"
+
+        entry_string += f", {work.year}"
+
         if work.journal_name:
-            entry_string += f'**{authors_str} - {work.journal_name}, {work.year}**\n\n'
+            entry_string += " - " + work.journal_name
+
+        entry_string += "**\n\n"
+
+        if work.abstract:
+            abstract = collapse_newlines(work.abstract)
+            if len(abstract) > 2000:
+                abstract = abstract[:2000] + '...'
+            entry_string += abstract
         else:
-            entry_string += f'**{authors_str}, {work.year}**\n\n'
-        
-        entry_string += f'{abstract}\n\n'
-        
-        # edge case: we shouldn't tack "Cited-by count: 0" onto someone's paper
-        if work.citations:
-            entry_string += f'*Cited-by count: {work.citations}*'
-            entry_string += '    '
-        
-        if work.doi:  # list the doi if it exists
-            entry_string += f'*DOI: {work.doi.replace("https://doi.org/", "")}*'
-            entry_string += '    '
-        
-        entry_string += f'*Similarity: {distance:.2f}*'
-        entry_string += '    \n'
+            entry_string += "No abstract"
+
+        entry_string += "\n\n*"
+
+        meta: list[tuple[str, str]] = []
+        if work.citations:  # don't tack "Cited-by count: 0" on someones's work
+            meta.append(("Cited-by count", str(work.citations)))
+        if work.doi:
+            meta.append(("DOI", work.doi.replace("https://doi.org/", "")))
+        meta.append(("Similarity", f"{distance:.2f}"))
+        entry_string += (" " * 4).join(": ".join(tup) for tup in meta)
+
+        entry_string += "*\n"
 
         result_string += entry_string