fix case of "all Questions" when selected first

app.py

@@ -62,7 +62,7 @@ def update_sources_list(question_option, source_finder_id, run_id: str, baseline
 
 # Main function to handle UI interactions
 async def update_sources_list_async(question_option, source_finder_name, run_id, baseline_ranker_name: str):
-    global available_run_id_dict
+    global available_run_id_dict, previous_run_id
     if not question_option:
         return gr.skip(), gr.skip(), gr.skip(), "No question selected", ""
     logger.info("processing update")
@@ -78,21 +78,28 @@ async def update_sources_list_async(question_option, source_finder_name, run_id,
             finder_id_int = None
 
         if question_option == "All questions":
-            if finder_id_int and type(run_id) == str:
+            if finder_id_int:
+                if run_id is None:
+                    available_run_id_dict = await get_run_ids(conn, finder_id_int)
+                    run_id = list(available_run_id_dict.keys())[0]
+                    previous_run_id = run_id
                 run_id_int = available_run_id_dict.get(run_id)
                 all_stats = await calculate_cumulative_statistics_for_all_questions(conn, run_id_int, baseline_ranker_id_int)
+
             else:
+                run_id_options = list(available_run_id_dict.keys())
                 all_stats = None
-            return None, all_stats, gr.skip(), "Select Run Id and source finder to see results", ""
+            run_id_options = list(available_run_id_dict.keys())
+            return None, all_stats, gr.Dropdown(choices=run_id_options, value=run_id), "Select Run Id and source finder to see results", ""
 
         # Extract question ID from selection
         question_id = questions_dict.get(question_option)
 
-        available_run_id_dict = await get_run_ids(conn, question_id, finder_id_int)
+        available_run_id_dict = await get_run_ids(conn, finder_id_int, question_id)
         run_id_options = list(available_run_id_dict.keys())
         if run_id not in run_id_options:
             run_id = run_id_options[0]
-
+        previous_run_id = run_id
         run_id_int = available_run_id_dict.get(run_id)
 
 

data_access.py

@@ -52,16 +52,23 @@ async def get_source_finders(conn: asyncpg.Connection):
 
 
 # Get distinct run IDs for a question
-async def get_run_ids(conn: asyncpg.Connection, question_id: int, source_finder_id: int):
+async def get_run_ids(conn: asyncpg.Connection, source_finder_id: int, question_id: int = None):
     query = """
     select distinct sfr.description, srs.source_finder_run_id as run_id
-        from talmudexplore.source_run_results srs
-        join talmudexplore.source_finder_runs sfr on srs.source_finder_run_id = sfr.id
-        join talmudexplore.source_finders sf on sfr.source_finder_id = sf.id
-        where sfr.source_finder_id = $1
-        and srs.question_id = $2
+        from source_run_results srs
+        join source_finder_runs sfr on srs.source_finder_run_id = sfr.id
+        join source_finders sf on sfr.source_finder_id = sf.id
+        where sfr.source_finder_id = $1        
     """
-    run_ids = await conn.fetch(query, source_finder_id, question_id)
+
+    if question_id is not None:
+        query += " and srs.question_id = $2"
+        params = (source_finder_id, question_id)
+    else:
+        params = (source_finder_id,)
+    query += " order by run_id DESC;"
+
+    run_ids = await conn.fetch(query, *params)
     return {r["description"]:r["run_id"] for r in run_ids}
 
 
@@ -132,7 +139,7 @@ async def calculate_cumulative_statistics_for_all_questions(conn: asyncpg.Connec
     for question_id in question_ids:
         try:
             # Get unified sources for this question
-            sources, stats = await get_unified_sources(conn, question_id, ranker_id, source_finder_run_id)
+            sources, stats = await get_unified_sources(conn, question_id, source_finder_run_id, ranker_id)
 
             if sources and len(sources) > 0:
                 valid_questions += 1

tests/test_db_layer.py

@@ -97,7 +97,7 @@ async def test_get_run_ids():
 
     # Call the function to test
     async with get_async_connection() as conn:
-        result = await get_run_ids(conn, question_id, source_finder_id)
+        result = await get_run_ids(conn, source_finder_id, question_id)
 
         # Verify the result is a dictionary
         assert isinstance(result, dict), "Result should be a dictionary"
@@ -107,6 +107,22 @@ async def test_get_run_ids():
 
         # Test with a non-existent question_id
         non_existent_question_id = 9999
-        empty_result = await get_run_ids(conn, non_existent_question_id, source_finder_id)
-    assert isinstance(empty_result, dict), "Should return an empty dictionary for non-existent question"
-    assert len(empty_result) == 0, "Should return empty dictionary for non-existent question"
+        empty_result = await get_run_ids(conn, source_finder_id, non_existent_question_id)
+        assert isinstance(empty_result, dict), "Should return an empty dictionary for non-existent question"
+        assert len(empty_result) == 0, "Should return empty dictionary for non-existent question"
+
+@pytest.mark.asyncio
+async def test_get_run_ids_no_question_id():
+    source_finder_id = 2  # Using a source finder ID that exists in the test database
+
+    # Call the function to test
+    async with get_async_connection() as conn:
+        result = await get_run_ids(conn, source_finder_id)
+
+        # Verify the result is a dictionary
+        assert isinstance(result, dict), "Result should be a dictionary"
+
+        # Check that the dictionary is not empty (assuming there are run IDs for this question/source finder)
+        assert len(result) > 0, "Should return at least one run ID"
+
+