Update app.py

app.py

@@ -71,24 +71,21 @@ def resolve_template_expressions(template):
 
 # Function to estimate the cost of resources
 def estimate_cost(resources):
-    # This is a simplified cost estimation. In a real scenario, you'd need to
-    # integrate with Azure's pricing API or use a more comprehensive pricing model.
     cost_estimates = {
-        "Microsoft.Storage/storageAccounts": 10,  # $10 per month
-        "Microsoft.Compute/virtualMachines": 50,  # $50 per month
-        "Microsoft.Web/sites": 30,  # $30 per month
-        "Microsoft.Sql/servers": 40,  # $40 per month
-        # Add more resource types and their estimated costs
+        "Microsoft.Storage/storageAccounts": 10,
+        "Microsoft.Compute/virtualMachines": 50,
+        "Microsoft.Web/sites": 30,
+        "Microsoft.Sql/servers": 40,
     }
-    
+
     total_cost = 0
     for resource in resources:
         resource_type = resource.get('type')
         if resource_type in cost_estimates:
             total_cost += cost_estimates[resource_type]
         else:
-            total_cost += 5  # Default cost for unknown resource types
-    
+            total_cost += 5
+
     return total_cost
 
 # Function to create a dependency graph of resources
@@ -108,8 +105,6 @@ def plot_dependency_graph(G):
     pos = nx.spring_layout(G)
     nx.draw(G, pos, with_labels=True, node_color='lightblue', 
             node_size=3000, font_size=8, font_weight='bold')
-    edge_labels = nx.get_edge_attributes(G, 'weight')
-    nx.draw_networkx_edge_labels(G, pos, edge_labels=edge_labels)
     plt.title("Resource Dependency Graph")
     return plt
 
@@ -117,41 +112,29 @@ def plot_dependency_graph(G):
 def lint_template(template):
     lint_results = []
     
-    # Check 1: Ensure all resources have tags
     for resource in template.get('resources', []):
         if 'tags' not in resource:
             lint_results.append(f"Warning: Resource '{resource.get('name')}' does not have any tags.")
-    
-    # Check 2: Ensure parameters have descriptions
+
     for param_name, param_value in template.get('parameters', {}).items():
         if 'metadata' not in param_value or 'description' not in param_value['metadata']:
             lint_results.append(f"Warning: Parameter '{param_name}' does not have a description.")
-    
-    # Check 3: Warn about hardcoded values in resource properties
-    for resource in template.get('resources', []):
-        for prop, value in resource.get('properties', {}).items():
-            if isinstance(value, (str, int, float)) and not isinstance(value, bool):
-                lint_results.append(f"Info: Consider using a parameter for the hardcoded value in resource '{resource.get('name')}', property '{prop}'.")
-    
+
     return lint_results
 
 # Function to generate a system diagram
 def generate_system_diagram(resources):
-    # Create a new Graphviz graph
     dot = graphviz.Digraph()
-    dot.attr(rankdir='TB')  # Top to bottom layout
+    dot.attr(rankdir='TB')
 
-    # Create nodes for each resource
     for i, resource in enumerate(resources):
         resource_type = resource['type'].split('/')[-1]
         node_id = f"R{i}"
         dot.node(node_id, f"{resource_type}\n{resource['name']}")
 
-    # Create connections based on dependencies
     for resource in resources:
         if 'dependsOn' in resource:
             for dependency in resource['dependsOn']:
-                # Find the node id for the dependency
                 dep_id = next((f"R{j}" for j, r in enumerate(resources) if r['name'] == dependency), None)
                 if dep_id:
                     dot.edge(dep_id, f"R{resources.index(resource)}")
@@ -163,12 +146,10 @@ def simulate_deployment(arm_template):
     try:
         template = json.loads(arm_template)
         
-        # Validate template
         is_valid, validation_message = validate_template(template)
         if not is_valid:
             return [], [], [], [], 0, None, [], None, validation_message
 
-        # Resolve expressions
         resolved_template = resolve_template_expressions(template)
 
         resources_to_create = []
@@ -205,16 +186,12 @@ def simulate_deployment(arm_template):
             if resource_name not in [r.get('name') for r in resolved_template.get('resources', [])]:
                 resources_to_delete.append(resource_name)
 
-        # Estimate cost
         estimated_cost = estimate_cost(resource_details)
 
-        # Create dependency graph
         dependency_graph = create_dependency_graph(resolved_template.get('resources', []))
 
-        # Lint template
         lint_results = lint_template(template)
 
-        # Generate system diagram
         system_diagram = generate_system_diagram(resource_details)
 
         return resources_to_create, resources_to_update, resources_to_delete, resource_details, estimated_cost, dependency_graph, lint_results, system_diagram, "Simulation completed successfully."
@@ -225,64 +202,44 @@ def simulate_deployment(arm_template):
 st.title("Comprehensive ARM Template Simulator")
 st.subheader("Upload your ARM template or paste it below to simulate its deployment.")
 
-# File uploader
 uploaded_file = st.file_uploader("Choose an ARM template file", type=["json"])
 
-# Input box for ARM template
 template_input = st.text_area("Or paste ARM Template JSON here:", height=300)
 
-# Function to read file contents
 def read_file_contents(file):
     return file.getvalue().decode("utf-8")
 
-# Button to simulate the evaluation
 if st.button("Simulate Template"):
-    # Check if a file was uploaded
     if uploaded_file is not None:
-        # Read the contents of the uploaded file
         file_contents = read_file_contents(uploaded_file)
-        # Use the file contents for simulation
         template_to_simulate = file_contents
     elif template_input:
-        # Use the pasted input for simulation
         template_to_simulate = template_input
     else:
         st.error("Please either upload a file or paste an ARM template to simulate.")
         st.stop()
 
-    # Proceed with simulation
     resources_to_create, resources_to_update, resources_to_delete, resource_details, estimated_cost, dependency_graph, lint_results, system_diagram, message = simulate_deployment(template_to_simulate)
-    
+
     st.subheader("Simulation Results:")
     st.write(message)
 
     if resources_to_create or resources_to_update or resources_to_delete:
         st.write("### Resources to be Created:")
-        if resources_to_create:
-            st.write(resources_to_create)
-        else:
-            st.write("No new resources will be created.")
+        st.write(resources_to_create or "No new resources will be created.")
 
         st.write("### Resources to be Updated:")
-        if resources_to_update:
-            st.write(resources_to_update)
-        else:
-            st.write("No resources will be updated.")
+        st.write(resources_to_update or "No resources will be updated.")
 
         st.write("### Resources to be Deleted:")
-        if resources_to_delete:
-            st.write(resources_to_delete)
-        else:
-            st.write("No resources will be deleted.")
+        st.write(resources_to_delete or "No resources will be deleted.")
 
         st.write("### Detailed Resource Information:")
         for resource in resource_details:
             st.write(f"**Name:** {resource['name']}")
             st.write(f"**Type:** {resource['type']}")
             st.write(f"**Location:** {resource['location']}")
-            st.write("**Properties:**")
             st.json(resource['properties'])
-            st.write("---")
 
         st.write(f"### Estimated Monthly Cost: ${estimated_cost}")
 
@@ -290,20 +247,13 @@ if st.button("Simulate Template"):
         if dependency_graph:
             fig = plot_dependency_graph(dependency_graph)
             st.pyplot(fig)
-        else:
-            st.write("No dependencies found between resources.")
 
         st.write("### System Diagram:")
         if system_diagram:
             st.graphviz_chart(system_diagram)
-        else:
-            st.write("Unable to generate system diagram.")
 
         st.write("### Template Lint Results:")
-        if lint_results:
-            for result in lint_results:
-                st.write(result)
-        else:
-            st.write("No linting issues found.")
+        for result in lint_results:
+            st.write(result)
     else:
-        st.write("No changes detected in the simulation.")
+        st.write("No changes detected in the simulation.")