feat: Enhance get_completion and update functions with error handling and command display for FFMPEG execution

app.py

@@ -96,7 +96,7 @@ def get_files_infos(files):
     return results
 
 
-def get_completion(prompt, files_info, top_p, temperature, model_choice):
+def get_completion(prompt, files_info, top_p, temperature, model_choice, previous_error=None, previous_command=None):
     # Create table header
     files_info_string = "| Type | Name | Dimensions | Duration | Audio Channels |\n"
     files_info_string += "|------|------|------------|-----------|--------|\n"
@@ -115,6 +115,35 @@ def get_completion(prompt, files_info, top_p, temperature, model_choice):
 
         files_info_string += f"| {file_info['type']} | {file_info['name']} | {dimensions} | {duration} | {audio} |\n"
 
+    # Build the user message with optional error feedback
+    user_content = f"""Always output the media as video/mp4 and output file with "output.mp4".
+The current assets and objective follow.
+
+AVAILABLE ASSETS LIST:
+
+{files_info_string}
+
+OBJECTIVE: {prompt} and output at "output.mp4"
+
+First, think step-by-step about what I'm asking for and reformulate it into a clear technical specification.
+Then provide the FFMPEG command that will accomplish this task."""
+
+    # Add error feedback if this is a retry
+    if previous_error and previous_command:
+        user_content += f"""
+
+IMPORTANT: This is a retry attempt. The previous command failed with the following error:
+
+PREVIOUS COMMAND (FAILED):
+{previous_command}
+
+ERROR MESSAGE:
+{previous_error}
+
+Please analyze the error and generate a corrected command that addresses the specific issue."""
+
+    user_content += "\n\nYOUR RESPONSE:"
+
     messages = [
         {
             "role": "system",
@@ -145,20 +174,7 @@ Remember: Simpler is better. Only use advanced ffmpeg features if absolutely nec
         },
         {
             "role": "user",
-            "content": f"""Always output the media as video/mp4 and output file with "output.mp4".
-The current assets and objective follow.
-
-AVAILABLE ASSETS LIST:
-
-{files_info_string}
-
-OBJECTIVE: {prompt} and output at "output.mp4"
-
-First, think step-by-step about what I'm asking for and reformulate it into a clear technical specification.
-Then provide the FFMPEG command that will accomplish this task.
-
-YOUR RESPONSE:
-         """,
+            "content": user_content,
         },
     ]
     try:
@@ -286,14 +302,18 @@ def update(
             raise gr.Error("Please make sure all files are less than 100MB in size.")
 
     attempts = 0
+    command_attempts = []
+    previous_error = None
+    previous_command = None
+    
     while attempts < 2:
-        print("ATTEMPT", attempts)
+        print("ATTEMPT", attempts + 1)
         try:
             command_string = get_completion(
-                prompt, files_info, top_p, temperature, model_choice
+                prompt, files_info, top_p, temperature, model_choice, previous_error, previous_command
             )
             print(
-                f"""///PROMTP {prompt} \n\n/// START OF COMMAND ///:\n\n{command_string}\n\n/// END OF COMMAND ///\n\n"""
+                f"""///PROMPT {prompt} \n\n/// START OF COMMAND ///:\n\n{command_string}\n\n/// END OF COMMAND ///\n\n"""
             )
 
             # split command string into list of arguments
@@ -308,35 +328,77 @@ def update(
                 shutil.copy(file_path, Path(temp_dir) / sanitized_name)
 
             # test if ffmpeg command is valid dry run
-            ffmpg_dry_run = subprocess.run(
+            ffmpeg_dry_run = subprocess.run(
                 args + ["-f", "null", "-"],
                 stderr=subprocess.PIPE,
                 text=True,
                 cwd=temp_dir,
             )
-            if ffmpg_dry_run.returncode == 0:
+            
+            # Extract command for display
+            command_for_display = f"ffmpeg {' '.join(args[1:])} -y output.mp4"
+            
+            if ffmpeg_dry_run.returncode == 0:
                 print("Command is valid.")
+                # Add successful command to attempts
+                command_attempts.append({
+                    "command": command_for_display,
+                    "status": "✅ Valid",
+                    "attempt": attempts + 1
+                })
             else:
                 print("Command is not valid. Error output:")
-                print(ffmpg_dry_run.stderr)
-                raise Exception(
-                    "FFMPEG generated command is not valid. Please try something else."
-                )
+                print(ffmpeg_dry_run.stderr)
+                
+                # Add failed command to attempts with error
+                command_attempts.append({
+                    "command": command_for_display,
+                    "status": "❌ Invalid",
+                    "error": ffmpeg_dry_run.stderr,
+                    "attempt": attempts + 1
+                })
+                
+                # Store error details for next retry
+                previous_error = ffmpeg_dry_run.stderr
+                previous_command = command_for_display
+                
+                raise Exception(f"FFMPEG command validation failed: {ffmpeg_dry_run.stderr}")
 
             output_file_name = f"output_{uuid.uuid4()}.mp4"
             output_file_path = str((Path(temp_dir) / output_file_name).resolve())
             execute_ffmpeg_command(args, temp_dir, output_file_path)
-            # Extract just the command for display
-            command_for_display = f"ffmpeg {' '.join(args[1:])} -y output.mp4"
-            generated_command = (
-                f"### Generated Command\n```bash\n{command_for_display}\n```"
-            )
-            return output_file_path, gr.update(value=generated_command)
+            
+            # Generate command display with all attempts
+            command_display = generate_command_display(command_attempts)
+            return output_file_path, gr.update(value=command_display)
+            
         except Exception as e:
             attempts += 1
             if attempts >= 2:
                 print("FROM UPDATE", e)
-                raise gr.Error(e)
+                # Show all attempted commands even on final failure
+                command_display = generate_command_display(command_attempts)
+                command_display += f"\n\n### Final Error\n❌ All attempts failed. Last error: {str(e)}"
+                return None, gr.update(value=command_display)
+
+
+def generate_command_display(command_attempts):
+    """Generate a markdown display of all command attempts"""
+    if not command_attempts:
+        return "### No commands generated"
+    
+    display = "### Generated Commands\n\n"
+    
+    for attempt in command_attempts:
+        display += f"**Attempt {attempt['attempt']}** {attempt['status']}\n"
+        display += f"```bash\n{attempt['command']}\n```\n"
+        
+        if attempt['status'] == "❌ Invalid" and 'error' in attempt:
+            display += f"<details>\n<summary>🔍 Error Details</summary>\n\n```\n{attempt['error']}\n```\n</details>\n\n"
+        else:
+            display += "\n"
+    
+    return display
 
 
 # Create MCP-compatible interface