feat: Enhance slideshow error guidance and increase command attempts for multiple images

app.py

@@ -96,7 +96,15 @@ def get_files_infos(files):
     return results
 
 
-def get_completion(prompt, files_info, top_p, temperature, model_choice, previous_error=None, previous_command=None):
+def get_completion(
+    prompt,
+    files_info,
+    top_p,
+    temperature,
+    model_choice,
+    previous_error=None,
+    previous_command=None,
+):
     # Create table header
     files_info_string = "| Type | Name | Dimensions | Duration | Audio Channels |\n"
     files_info_string += "|------|------|------------|-----------|--------|\n"
@@ -140,7 +148,13 @@ PREVIOUS COMMAND (FAILED):
 ERROR MESSAGE:
 {previous_error}
 
-Please analyze the error and generate a corrected command that addresses the specific issue."""
+Please analyze the error and generate a corrected command that addresses the specific issue.
+
+COMMON SLIDESHOW ERROR FIXES:
+- If you see "do not match the corresponding output link" → Images have different dimensions, use scale+pad approach
+- If you see "Padded dimensions cannot be smaller than input dimensions" → Fix pad calculation or use 1920x1080 standard
+- If you see "Failed to configure input pad" → Check scale and pad syntax, ensure proper filter chain
+- If you see "Invalid argument" in filters → Simplify filter_complex syntax and check parentheses"""
 
     user_content += "\n\nYOUR RESPONSE:"
 
@@ -169,6 +183,39 @@ Key requirements:
     - For image sequences: Use -framerate and pattern matching (like 'img%d.jpg') when possible, falling back to individual image processing with -loop 1 and appropriate filters only when necessary.
     - When showing file operations or commands, always use explicit paths and filenames without wildcards - avoid using asterisk (*) or glob patterns. Instead, use specific numbered sequences (like %d), explicit file lists, or show the full filename.
 
+CRITICAL SLIDESHOW GUIDANCE:
+When creating slideshows from multiple images with different dimensions, ALWAYS follow this proven pattern:
+
+1. CHOOSE A STANDARD RESOLUTION: Pick 1920x1080 (1080p) as the target resolution for all slideshows
+2. USE SIMPLE SCALE+PAD APPROACH: For each image, scale to fit within 1920x1080 maintaining aspect ratio, then pad with black bars
+3. PROVEN SLIDESHOW PATTERN:
+   ```
+   ffmpeg -loop 1 -t 3 -i image1.jpg -loop 1 -t 3 -i image2.jpg -filter_complex "[0]scale=1920:1080:force_original_aspect_ratio=decrease,pad=1920:1080:(ow-iw)/2:(oh-ih)/2,setsar=1[v0];[1]scale=1920:1080:force_original_aspect_ratio=decrease,pad=1920:1080:(ow-iw)/2:(oh-ih)/2,setsar=1[v1];[v0][v1]concat=n=2:v=1:a=0" -c:v libx264 -pix_fmt yuv420p -movflags +faststart output.mp4
+   ```
+
+4. SLIDESHOW RULES:
+   - Always use 1920x1080 as target resolution for consistency
+   - Always use scale=1920:1080:force_original_aspect_ratio=decrease
+   - Always use pad=1920:1080:(ow-iw)/2:(oh-ih)/2 for centering
+   - Always add setsar=1 after padding to fix aspect ratio issues
+   - Use 3-second duration per image by default (-t 3)
+   - For 3+ images, extend the pattern: [v0][v1][v2]concat=n=3:v=1:a=0
+
+5. DIMENSION MISMATCH FIXES:
+   - Never try to concat images with different dimensions directly
+   - Always normalize dimensions first with scale+pad
+   - Black padding is preferable to stretching/distorting images
+
+6. SLIDESHOW TRANSITIONS:
+   - For fade transitions, add fade=t=in:st=0:d=0.5,fade=t=out:st=2.5:d=0.5 after setsar=1
+   - Keep transitions simple - complex transitions often fail
+   - Only add transitions if specifically requested
+
+7. SLIDESHOW TIMING:
+   - Default to 3 seconds per image
+   - Adjust timing based on user request (e.g., "5 seconds per image")
+   - Total duration = (number of images × seconds per image)
+
 Remember: Simpler is better. Only use advanced ffmpeg features if absolutely necessary for the requested output.
 """,
         },
@@ -305,12 +352,18 @@ def update(
     command_attempts = []
     previous_error = None
     previous_command = None
-    
+
     while attempts < 2:
         print("ATTEMPT", attempts + 1)
         try:
             command_string = get_completion(
-                prompt, files_info, top_p, temperature, model_choice, previous_error, previous_command
+                prompt,
+                files_info,
+                top_p,
+                temperature,
+                model_choice,
+                previous_error,
+                previous_command,
             )
             print(
                 f"""///PROMPT {prompt} \n\n/// START OF COMMAND ///:\n\n{command_string}\n\n/// END OF COMMAND ///\n\n"""
@@ -334,51 +387,59 @@ def update(
                 text=True,
                 cwd=temp_dir,
             )
-            
+
             # Extract command for display
             command_for_display = f"ffmpeg {' '.join(args[1:])} -y output.mp4"
-            
+
             if ffmpeg_dry_run.returncode == 0:
                 print("Command is valid.")
                 # Add successful command to attempts
-                command_attempts.append({
-                    "command": command_for_display,
-                    "status": "✅ Valid",
-                    "attempt": attempts + 1
-                })
+                command_attempts.append(
+                    {
+                        "command": command_for_display,
+                        "status": "✅ Valid",
+                        "attempt": attempts + 1,
+                    }
+                )
             else:
                 print("Command is not valid. Error output:")
                 print(ffmpeg_dry_run.stderr)
-                
+
                 # Add failed command to attempts with error
-                command_attempts.append({
-                    "command": command_for_display,
-                    "status": "❌ Invalid",
-                    "error": ffmpeg_dry_run.stderr,
-                    "attempt": attempts + 1
-                })
-                
+                command_attempts.append(
+                    {
+                        "command": command_for_display,
+                        "status": "❌ Invalid",
+                        "error": ffmpeg_dry_run.stderr,
+                        "attempt": attempts + 1,
+                    }
+                )
+
                 # Store error details for next retry
                 previous_error = ffmpeg_dry_run.stderr
                 previous_command = command_for_display
-                
-                raise Exception(f"FFMPEG command validation failed: {ffmpeg_dry_run.stderr}")
+
+                raise Exception(
+                    f"FFMPEG command validation failed: {ffmpeg_dry_run.stderr}"
+                )
 
             output_file_name = f"output_{uuid.uuid4()}.mp4"
             output_file_path = str((Path(temp_dir) / output_file_name).resolve())
             execute_ffmpeg_command(args, temp_dir, output_file_path)
-            
+
             # Generate command display with all attempts
             command_display = generate_command_display(command_attempts)
             return output_file_path, gr.update(value=command_display)
-            
+
         except Exception as e:
             attempts += 1
             if attempts >= 2:
                 print("FROM UPDATE", e)
                 # Show all attempted commands even on final failure
                 command_display = generate_command_display(command_attempts)
-                command_display += f"\n\n### Final Error\n❌ All attempts failed. Last error: {str(e)}"
+                command_display += (
+                    f"\n\n### Final Error\n❌ All attempts failed. Last error: {str(e)}"
+                )
                 return None, gr.update(value=command_display)
 
 
@@ -386,18 +447,18 @@ def generate_command_display(command_attempts):
     """Generate a markdown display of all command attempts"""
     if not command_attempts:
         return "### No commands generated"
-    
+
     display = "### Generated Commands\n\n"
-    
+
     for attempt in command_attempts:
         display += f"**Attempt {attempt['attempt']}** {attempt['status']}\n"
         display += f"```bash\n{attempt['command']}\n```\n"
-        
-        if attempt['status'] == "❌ Invalid" and 'error' in attempt:
+
+        if attempt["status"] == "❌ Invalid" and "error" in attempt:
             display += f"<details>\n<summary>🔍 Error Details</summary>\n\n```\n{attempt['error']}\n```\n</details>\n\n"
         else:
             display += "\n"
-    
+
     return display