trying to improve performance

src/core/getAppPosts.mts

@@ -1,14 +1,30 @@
 import { postDirFilePath } from "../config.mts"
 import { Post, PostVisibility } from "../types.mts"
+import { getValidNumber } from "../utils/getValidNumber.mts"
+import { shuffleArray } from "../utils/shuffleArray.mts"
 
 import { readPostFiles } from "./readPostFiles.mts"
 
-export const getAppPosts = async (appId: string, visibility?: PostVisibility): Promise<Post[]> => {
+export const getAppPosts = async ({
+  appId,
+  limit,
+  visibility,
+  shuffle
+}: {
+  appId: string
+  limit?: number
+  visibility?: PostVisibility
+  shuffle?: boolean
+}): Promise<Post[]> => {
   const posts = await readPostFiles(postDirFilePath, appId)
 
-  if (visibility) {
-    return posts.filter(post => post.visibility === visibility)
-  } else {
-    return posts
-  }
+  const visiblePosts = visibility
+    ? posts.filter(post => post.visibility === visibility)
+    : posts
+
+  const sortedPosts = shuffle
+    ? shuffleArray(visiblePosts)
+    : visiblePosts.sort((a, b) => Date.parse(b.createdAt) - Date.parse(a.createdAt))
+  
+  return sortedPosts.slice(0, getValidNumber(limit, 1, 80, 20))
 }

src/core/readPostFiles.mts

@@ -6,7 +6,7 @@ import { readPostFile } from "./readPostFile.mts"
 
 const cache = {} as { [directory: string]: { timestamp: number, files: Post[] } };
 
-export const readPostFiles = async (postDirFilePath: string, appId?: string): Promise<Post[]> => {
+export const readPostFiles = async (postDirFilePath: string, appId?: string, limit?: number): Promise<Post[]> => {
 
   const now = Date.now()
   
@@ -29,8 +29,15 @@ export const readPostFiles = async (postDirFilePath: string, appId?: string): Pr
   }
 
   const posts: Post[] = []
+  
+  // TODO implement filtering at this level, using the date
+
+  // until then let's implement a hard limit
+  const postFilesToRead = postFiles.slice(0, 300)
+
+
+  for (const postFileName of postFilesToRead) {
 
-  for (const  postFileName of postFiles) {
     // console.log("postFileName:", postFileName)
     const postFilePath = path.join(postDirFilePath, postFileName)
     try {
@@ -49,6 +56,6 @@ export const readPostFiles = async (postDirFilePath: string, appId?: string): Pr
 
   // store results in cache with current timestamp
   cache[postDirFilePath] = { timestamp: now, files: posts }
-  
+
   return posts
 }

src/index.mts

@@ -10,6 +10,7 @@ import { savePost } from "./core/savePost.mts"
 import { getAppPosts } from "./core/getAppPosts.mts"
 import { deletePost } from "./core/deletePost.mts"
 import { getPost } from "./core/getPost.mts"
+import { getValidBoolean } from "./utils/getValidBoolean.mts"
 
 initFolders()
 
@@ -119,7 +120,7 @@ app.post("/posts/:appId", async (req, res) => {
   res.end()
 })
 
-app.get("/posts/:appId/:param", async (req, res) => {
+app.get("/posts/:appId/firehose/:visibility/:maxNbItems/:shuffle", async (req, res) => {
 
   const appId = `${req.params.appId}`
 
@@ -131,16 +132,19 @@ app.get("/posts/:appId/:param", async (req, res) => {
     return
   }
 
-  const param = `${req.params.param}`
-  const isVisibility = !uuidValidate(param)
+  const visibility = `${req.params.visibility}`
+
+  const shuffle = getValidBoolean(`${req.params.shuffle}`, false)
+
+  const limit = getValidNumber(`${req.params.maxNbItems}`, 1, 80, 20)
 
-  if (isVisibility) {
-    const visibility = param
     try {
-      const posts = await getAppPosts(
+      const posts = await getAppPosts({
         appId,
-        visibility === "all" ? undefined : visibility as PostVisibility
-      )
+        visibility: visibility === "all" ? undefined : visibility as PostVisibility,
+        shuffle,
+        limit
+      })
       res.status(200)
       console.log(`returning ${posts.length} community posts for app ${appId} (visibility: ${visibility})`)
       res.write(JSON.stringify({ posts } as GetAppPostsResponse))
@@ -155,8 +159,31 @@ app.get("/posts/:appId/:param", async (req, res) => {
       res.end()
       return
     }
-  } else {
-    const postId = param
+})
+
+
+app.get("/posts/:appId/:postId", async (req, res) => {
+
+  const appId = `${req.params.appId}`
+
+  if (!uuidValidate(appId)) {
+    console.error("invalid appId")
+    res.status(400)
+    res.write(JSON.stringify({ error: `invalid appId` }))
+    res.end()
+    return
+  }
+
+  const postId = `${req.params.postId}`
+
+  if (!uuidValidate(postId)) {
+    console.error("invalid postId")
+    res.status(400)
+    res.write(JSON.stringify({ error: `invalid postId` }))
+    res.end()
+    return
+  }
+
     try {
       const post = await getPost(appId, postId)
       res.status(200)
@@ -172,7 +199,6 @@ app.get("/posts/:appId/:param", async (req, res) => {
       res.end()
       return
     }
-  }
 })
 
 // delete a post

src/utils/shuffleArray.mts

@@ -0,0 +1,10 @@
+export function shuffleArray<T>(items: T[]): T[] {
+  for (let i = items.length - 1; i > 0; i--) {
+    const j = Math.floor(Math.random() * (i + 1));
+    const temp = items[i];
+    items[i] = items[j];
+    items[j] = temp;
+  }
+
+  return items
+}