Update app.py

app.py

@@ -126,6 +126,56 @@ def save_to_temp_file(content, filename):
         logger.error(f"Error saving temporary file: {str(e)}")
         raise
 
+def get_problem_type_addition(question_type):
+    """Return specific requirements based on problem type"""
+    problem_type_additions = {
+        "application": """
+The application question MUST:
+- Present a real-world scenario or practical problem
+- Require modeling the situation mathematically
+- Connect abstract mathematical concepts to concrete situations
+- Include realistic context and data
+- Require students to:
+    1. Identify relevant mathematical concepts
+    2. Translate the practical problem into mathematical terms
+    3. Solve using appropriate mathematical techniques
+    4. Interpret the results in the context of the original problem
+
+Example contexts might include:
+- Physics applications (motion, forces, work)
+- Engineering scenarios (optimization, rates of change)
+- Economics problems (cost optimization, growth models)
+- Biological systems (population growth, reaction rates)
+- Business applications (profit maximization, inventory management)
+- Social science applications (demographic models, social network analysis)
+- Data science applications (regression, statistical analysis)
+""",
+        "proof": """
+The proof question MUST:
+- Require a formal mathematical proof
+- Focus on demonstrating logical reasoning
+- Require justification for each step
+- Emphasize theoretical understanding
+
+The proof question MAY NOT:
+- Include Real-world applications or scenarios
+- Include Pure computation problems
+- Ask only for numerical answers
+""",
+        "computation": """
+The computation question MUST:
+- Require specific numerical or algebraic calculations
+- Focus on mathematical techniques
+- Have concrete answers in the form of numbers or algebraic expressions
+- Test procedural knowledge
+
+The computation question MAY NOT:
+- Include extended real-world applications or scenarios
+- Ask for a proof
+"""
+    }
+    return problem_type_additions.get(question_type, "")
+
 def generate_question(subject, difficulty, question_type):
     """Generate a single math question"""
     try:
@@ -161,87 +211,10 @@ def generate_question(subject, difficulty, question_type):
         logger.debug(f"Selected topic: {selected_topic}")
         
         difficulty_params = get_difficulty_parameters(difficulty)
+        problem_type_addition = get_problem_type_addition(question_type)
 
-        if question_type == "application":
-            application_addition = """
-The application question MUST:
-- Present a real-world scenario or practical problem
-- Require modeling the situation mathematically
-- Connect abstract mathematical concepts to concrete situations
-- Include realistic context and data
-- Require students to:
-    1. Identify relevant mathematical concepts
-    2. Translate the practical problem into mathematical terms
-    3. Solve using appropriate mathematical techniques
-    4. Interpret the results in the context of the original problem
-
-Example contexts might include:
-- Physics applications (motion, forces, work)
-- Engineering scenarios (optimization, rates of change)
-- Economics problems (cost optimization, growth models)
-- Biological systems (population growth, reaction rates)
-- Business applications (profit maximization, inventory management)
-- Social science applications (demographic models, social network analysis)
-- Data science applications (regression, statistical analysis)
-"""
-            if difficulty == 5:
-                system_prompt = f"""You are an expert mathematics professor creating a graduate-level exam question.
-STRICT REQUIREMENTS:
-1. Write exactly 1 graduate-level application question on {subject} covering {selected_topic}.
-2. Advanced Difficulty Requirements:
-   This question must be suitable for PhD qualifying exams or advanced competitions.
-   MUST include:
-   - Novel applications of theoretical concepts to complex real-world scenarios
-   - Graduate-level mathematical reasoning in practical contexts
-   - Sophisticated modeling of real situations
-   - Creative problem-solving approaches
-   - Multiple stages of mathematical modeling and analysis
-   
-   Follow these specific constraints:
-   {chr(10).join(f'   - {c}' for c in difficulty_params['constraints'])}
-   {application_addition}
-3. Style Reference:
-   Question should be {difficulty_params['example_style']}
-4. The question MUST:
-   - Bridge multiple mathematical domains
-   - Require deep theoretical understanding
-   - Test mastery of advanced concepts
-   - Demand innovative solution approaches
-5. For LaTeX formatting:
-   - Use $ for inline math
-   - Use $$ on separate lines for equations and solutions
-   - Put each solution step on its own line in $$ $$
-   - DO NOT use \\begin{{aligned}} or similar environments
-6. Include a detailed solution with thorough explanations of:
-   - How to model the situation
-   - Why specific mathematical techniques were chosen
-   - How to interpret the results
-7. Maintain clear, precise formatting"""
-            else:
-                system_prompt = f"""You are an expert mathematics professor creating a {difficulty_params['description']} exam question.
-STRICT REQUIREMENTS:
-1. Write exactly 1 application question on {subject} covering {selected_topic}.
-2. Difficulty Level Guidelines:
-   {difficulty_params['description'].upper()}
-   Follow these specific constraints:
-   {chr(10).join(f'   - {c}' for c in difficulty_params['constraints'])}
-   {application_addition}
-3. Style Reference:
-   Question should be {difficulty_params['example_style']}
-4. For LaTeX formatting:
-   - Use $ for inline math
-   - Use $$ on separate lines for equations and solutions
-   - Put each solution step on its own line in $$ $$
-   - DO NOT use \\begin{{aligned}} or similar environments
-5. Include a detailed solution that explains:
-   - How to model the situation
-   - Why specific mathematical techniques were chosen
-   - How to interpret the results
-6. Maintain clear formatting"""
-        else:
-            # Standard prompts for computation and proof questions
-            if difficulty == 5:
-                system_prompt = f"""You are an expert mathematics professor creating a graduate-level exam question.
+        if difficulty == 5:
+            system_prompt = f"""You are an expert mathematics professor creating a graduate-level exam question.
 STRICT REQUIREMENTS:
 1. Write exactly 1 graduate-level {question_type} question on {subject} covering {selected_topic}.
 2. Advanced Difficulty Requirements:
@@ -255,6 +228,9 @@ STRICT REQUIREMENTS:
    
    Follow these specific constraints:
    {chr(10).join(f'   - {c}' for c in difficulty_params['constraints'])}
+   
+   {problem_type_addition}
+
 3. Style Reference:
    Question should be {difficulty_params['example_style']}
 4. The question MUST:
@@ -269,14 +245,17 @@ STRICT REQUIREMENTS:
    - DO NOT use \\begin{{aligned}} or similar environments
 6. Include a detailed solution with thorough explanations of advanced concepts used
 7. Maintain clear, precise formatting"""
-            else:
-                system_prompt = f"""You are an expert mathematics professor creating a {difficulty_params['description']} exam question.
+        else:
+            system_prompt = f"""You are an expert mathematics professor creating a {difficulty_params['description']} exam question.
 STRICT REQUIREMENTS:
 1. Write exactly 1 {question_type} question on {subject} covering {selected_topic}.
 2. Difficulty Level Guidelines:
    {difficulty_params['description'].upper()}
    Follow these specific constraints:
    {chr(10).join(f'   - {c}' for c in difficulty_params['constraints'])}
+   
+   {problem_type_addition}
+
 3. Style Reference:
    Question should be {difficulty_params['example_style']}
 4. For LaTeX formatting: