Refactor luck calc to return intermediate df

src/analyze_yahoo.py

@@ -1,8 +1,6 @@
 import pandas as pd
 from typing import Optional
 
-from yahoo_client import LeagueSettings
-
 
 def calculate_luck(df: pd.DataFrame, as_of_week: Optional[int] = None) -> pd.DataFrame:
     if as_of_week:
@@ -27,6 +25,10 @@ def calculate_luck(df: pd.DataFrame, as_of_week: Optional[int] = None) -> pd.Dat
             df_list.append(df_week)
 
     df_luck = pd.concat(df_list)
+    return df_luck
+
+
+def get_grouped_luck(df_luck_all_weeks: pd.DataFrame) -> pd.DataFrame:
     summ_cols = [
         "team_name",
         "team_points",
@@ -37,7 +39,7 @@ def calculate_luck(df: pd.DataFrame, as_of_week: Optional[int] = None) -> pd.Dat
         "luck_wins",
     ]
     sort_by = "luck_wins"
-    return df_luck[summ_cols].groupby("team_name").sum().sort_values(sort_by, ascending=False)
+    return df_luck_all_weeks[summ_cols].groupby("team_name").sum().sort_values(sort_by, ascending=False)
 
 
 def summarize_remaining_wins_from_matches_map(matches_map):
@@ -65,8 +67,3 @@ def summarize_remaining_wins_from_matches_map(matches_map):
                 team_remaining_map[n_wins] = prob_list
         remaining_map[team_name] = team_remaining_map
     return remaining_map
-
-
-def analyze_league(df_scores: pd.DataFrame, league_settings: LeagueSettings) -> pd.DataFrame:
-    luck = calculate_luck(df_scores, as_of_week=league_settings.current_week - 1)
-    return luck