update: update crud service

src/lib/services/crud.service.ts

@@ -11,14 +11,26 @@ export const CrudService = <ModelDoc extends Document>(
       return this.model.create(data);
     }
 
-    async update(
+    async updateOne(
       filter: FilterQuery<ModelDoc>,
       data: AnyKeys<ModelDoc>
     ): Promise<ModelDoc> {
-      return this.model.findOneAndUpdate(filter, data, { new: true });
+      await this.existsOrThrow(filter);
+      await this.model.updateOne(filter, data);
+      return this.findOneOrFail(filter);
     }
 
-    async delete(filter: FilterQuery<ModelDoc>): Promise<ModelDoc> {
+    async updateMany(
+      filter: FilterQuery<ModelDoc>,
+      data: AnyKeys<ModelDoc>
+    ): Promise<ModelDoc[]> {
+      await this.existsOrThrow(filter);
+      await this.model.updateMany(filter, data);
+      return this.model.find(filter);
+    }
+
+    async deleteOne(filter: FilterQuery<ModelDoc>): Promise<ModelDoc> {
+      await this.existsOrThrow(filter);
       return this.model.findOneAndDelete(filter);
     }
 
@@ -59,10 +71,16 @@ export const CrudService = <ModelDoc extends Document>(
     }
 
     async findOneOrFail(filter: FilterQuery<ModelDoc>): Promise<ModelDoc> {
+      await this.existsOrThrow(filter);
       const document = await this.findOne(filter);
-      if (!document) throw new HttpError(404, "No Matching Result Found.");
 
       return document;
     }
+
+    private async existsOrThrow(filter: FilterQuery<ModelDoc>) {
+      if (!(await this.model.exists(filter))) {
+        throw new HttpError(404, "No Matching Result Found.");
+      }
+    }
   };
 };

src/modules/console/modules/admins/controllers/admins.controller.ts

@@ -81,7 +81,7 @@ export class AdminsController extends BaseController {
   };
 
   update = async (req: Request, res: Response): Promise<Response> => {
-    const admin = await this.adminsService.update(
+    const admin = await this.adminsService.updateOne(
       {
         _id: req.params.id,
       },
@@ -97,7 +97,7 @@ export class AdminsController extends BaseController {
   };
 
   delete = async (req: Request, res: Response): Promise<Response> => {
-    const admin = await this.adminsService.delete({
+    const admin = await this.adminsService.deleteOne({
       _id: req.params.id,
     });
 

src/modules/console/modules/workouts/controllers/workouts.controller.ts

@@ -78,7 +78,7 @@ export class WorkoutController extends BaseController {
     };
 
     update = async (req: Request, res: Response) => {
-        const data = await this.workoutsService.update(
+        const data = await this.workoutsService.updateOne(
             { _id: req.params.id },
             req.body
         );
@@ -91,7 +91,7 @@ export class WorkoutController extends BaseController {
     };
 
     delete = async (req: Request, res: Response) => {
-        const data = await this.workoutsService.delete({ _id: req.params.id });
+        const data = await this.workoutsService.deleteOne({ _id: req.params.id });
         return JsonResponse.success(
             {
                 data: serialize(data.toJSON(), WorkoutSerialization),