update: refactor guards

src/lib/guards/gen-guard.ts

@@ -0,0 +1,49 @@
+import { IJwtLoginPayload } from "@common/interfaces/jwt-payload.interface";
+import { JwtPayload, verify } from "jsonwebtoken";
+import { HttpError } from "@lib/error-handling/http-error";
+import { NextFunction, Request, Response } from "express";
+import { config } from "@configs/config";
+
+type OptionalIfUndefined<T> = [T] extends [undefined]
+  ? (args?: T) => void
+  : (args: T) => void;
+
+export const genGuard =
+  <T = undefined>(
+    validationMethod?: (
+      validationArgs: T,
+      payload: IJwtLoginPayload,
+      req: Request,
+      res: Response
+    ) => boolean | Promise<boolean>
+  ): OptionalIfUndefined<T> =>
+  (args: T) =>
+  async (req: Request, res: Response, next: NextFunction) => {
+    // get token from cookie
+    const token = req.headers.authorization?.split(" ")[1];
+    let payload: IJwtLoginPayload;
+
+    // validate token
+    if (!token) {
+      throw new HttpError(401, "Unauthorized");
+    }
+
+    try {
+      payload = verify(token, config.jwt.secret);
+    } catch (err) {
+      throw new HttpError(401, "Unauthorized");
+    }
+
+    if (
+      validationMethod &&
+      !(await validationMethod(args, payload, req, res))
+    ) {
+      throw new HttpError(401, "Unauthorized");
+    }
+
+    // inject payload in request
+    (req as unknown as { jwtPayload: JwtPayload }).jwtPayload = payload;
+
+    // go on
+    next();
+  };

src/modules/console/common/guards/admins.guard.ts

@@ -1,45 +1,23 @@
-import { JwtPayload, verify } from "jsonwebtoken";
-import { Request } from "express";
 import { Role } from "@common/enums/role.enum";
-import { HttpError } from "@lib/error-handling/http-error";
-import { config } from "@configs/config";
 import { IJwtLoginPayload } from "@common/interfaces/jwt-payload.interface";
+import { genGuard } from "@lib/guards/gen-guard";
 
 type AdminGuardMiddlewareProps = {
   roles?: Role[];
 };
 
-export const AdminGuardMiddleware =
-  (props?: AdminGuardMiddlewareProps) => (req: Request, res, next) => {
-    // get token from cookie
-    const token = req.headers.authorization?.split(" ")[1];
-    let payload: IJwtLoginPayload;
-
-    // validate token
-    if (!token) {
-      throw new HttpError(401, "Unauthorized");
-    }
-
-    try {
-      payload = verify(token, config.jwt.secret);
-    } catch (err) {
-      throw new HttpError(401, "Unauthorized");
-    }
-
+export const AdminGuardMiddleware = genGuard(
+  async (args: AdminGuardMiddlewareProps, payload: IJwtLoginPayload) => {
     if (payload.type !== "admin") {
-      throw new HttpError(401, "Unauthorized");
+      return false;
     }
 
-    // check roles
-    if (props?.roles && props?.roles.length > 0) {
-      if (!props.roles.includes(payload.role)) {
-        throw new HttpError(401, "Unauthorized");
+    if (args?.roles && args?.roles.length > 0) {
+      if (!args.roles.includes(payload.role)) {
+        return false;
       }
     }
 
-    // inject payload in request
-    (req as unknown as { jwtPayload: JwtPayload }).jwtPayload = payload;
-
-    // go on
-    next();
-  };
+    return true;
+  }
+);

src/modules/users/common/guards/users.guard.ts

@@ -1,34 +1,6 @@
-import { JwtPayload, verify } from "jsonwebtoken";
-import { Request } from "express";
-import { HttpError } from "@lib/error-handling/http-error";
-import { config } from "@configs/config";
 import { IJwtLoginPayload } from "@common/interfaces/jwt-payload.interface";
+import { genGuard } from "@lib/guards/gen-guard";
 
-export const UsersGuardMiddleware =
-  () => (req: Request, res, next) => {
-    // get token from cookie
-    const token = req.headers.authorization?.split(" ")[1];
-    let payload: IJwtLoginPayload;
-
-    // validate token
-    if (!token) {
-      throw new HttpError(401, "Unauthorized");
-    }
-
-    try {
-      payload = verify(token, config.jwt.secret);
-    } catch (err) {
-      throw new HttpError(401, "Unauthorized");
-    }
-
-    if (payload.type !== "user") {
-      throw new HttpError(401, "Unauthorized");
-    }
-
-
-    // inject payload in request
-    (req as unknown as { jwtPayload: JwtPayload }).jwtPayload = payload;
-
-    // go on
-    next();
-  };
+export const UsersGuardMiddleware = genGuard(
+  async (args, payload: IJwtLoginPayload) => payload.type === "user"
+);