fixed save logs

app.py

@@ -126,7 +126,8 @@ def submit_feedback(feedback, logs_data):
             logger.error("No logs data available for feedback")
             return gr.update(visible=False), gr.update(visible=True)
             
-        save_logs(scheduler, JSON_DATASET_PATH, logs_data, feedback)
+        # save_logs(scheduler, JSON_DATASET_PATH, logs_data, feedback)
+        save_logs(JSON_DATASET_PATH, logs_data, feedback)
         return gr.update(visible=False), gr.update(visible=True)
     except Exception as e:
         logger.error(f"Error saving feedback: {e}")
@@ -324,7 +325,8 @@ async def chat(query, history, sources, reports, subtype, year, client_ip=None,
 
     try:
         # Save log after streaming is complete
-        save_logs(scheduler, JSON_DATASET_PATH, logs_data)
+        # save_logs(scheduler, JSON_DATASET_PATH, logs_data)
+        save_logs(JSON_DATASET_PATH, logs_data)
     except Exception as e:
         logging.error(e)
 

auditqa/utils.py

@@ -12,18 +12,32 @@ from uuid import uuid4
 
 
 
-def save_logs(scheduler, JSON_DATASET_PATH, logs, feedback=None) -> None:
+# def save_logs(scheduler, JSON_DATASET_PATH, logs, feedback=None) -> None:
+#     """ Every interaction with app saves the log of question and answer, 
+#         this is to get the usage statistics of app and evaluate model performances.
+#         Also saves user feedback (when provided).
+#     """
+#     if feedback:
+#         logs["feedback"] = feedback #optional
+        
+#     with scheduler.lock:
+#         with open(JSON_DATASET_PATH, 'a') as f:
+#             json.dump(logs, f)
+#             f.write("\n")
+#     print("logging done")
+
+
+def save_logs(JSON_DATASET_PATH: str, logs: dict, feedback: str = None) -> None:
     """ Every interaction with app saves the log of question and answer, 
         this is to get the usage statistics of app and evaluate model performances.
         Also saves user feedback (when provided).
     """
     if feedback:
-        logs["feedback"] = feedback #optional
+        logs["feedback"] = feedback
         
-    with scheduler.lock:
-        with open(JSON_DATASET_PATH, 'a') as f:
-            json.dump(logs, f)
-            f.write("\n")
+    with open(JSON_DATASET_PATH, 'a') as f:
+        json.dump(logs, f)
+        f.write("\n")
     print("logging done")
 
 def get_message_template(type, SYSTEM_PROMPT, USER_PROMPT):