Update index.js

index.js

@@ -384,22 +384,17 @@ app.post("/api/v1/key/api-key-ban", authenticateApiKey, apiLimiter, async (req,
         const userIdString = req.query.user_id;
         const userIdNumber = Number(userIdString);
 
-        if (isNaN(userIdNumber)) {
-            return res.status(400).json({ error: "Invalid or missing user_id" });
-        }
-
-        if (userIdNumber === 0) {
+        if (isNaN(userIdNumber) || userIdNumber === 0) {
             return res.status(400).json({ error: "Invalid user_id" });
         }
 
         if (userIdNumber === 6477856957) {
-            return res.status(400).json({ error: "sorry only developer" });
+            return res.status(400).json({ error: "Sorry, only the developer can perform this action." });
         }
-
-        const existingUserTwo  = await ApiKey.findOne({ owner: userIdNumber });
         const existingUser = await collection.findOne({ owner: userIdNumber });
+        const existingUserTwo = await ApiKey.findOne({ owner: userIdNumber });
 
-        if (!existingUser || !existingUserTwo) {
+        if (!existingUser && !existingUserTwo) {
             const userDocument = {
               key: "banned",
               createdAt: new Date(),
@@ -408,6 +403,7 @@ app.post("/api/v1/key/api-key-ban", authenticateApiKey, apiLimiter, async (req,
               is_banned: true,
               username: null,
             };
+
             const userDocumentTwo = new ApiKey({
               key: "banned",
               createdAt: new Date(),
@@ -415,39 +411,41 @@ app.post("/api/v1/key/api-key-ban", authenticateApiKey, apiLimiter, async (req,
               owner: userIdNumber,
               type: "premium",
               is_banned: true,
-              email: null
+              email: null,
             });
-            await userDocumentTwo.save();
+
             await collection.insertOne(userDocument);
+            await userDocumentTwo.save();
+
             return res.status(200).json({
               message: "API key successfully banned",
               owner: userIdNumber
             });
         }
 
-        if (existingUser.is_banned === true || existingUserTwo.is_banned === true) {
+        if ((existingUser && existingUser.is_banned) || (existingUserTwo && existingUserTwo.is_banned)) {
             return res.status(200).json({ message: "API key is already banned" });
         }
 
-        const resultTwo = await ApiKey.updateOne(
-          { owner: userIdNumber },
-          { $set: { is_banned: true } },
-          { upsert: false }
-        );
-
         const result = await collection.updateOne(
             { owner: userIdNumber },
             { $set: { is_banned: true } },
             { upsert: false }
         );
 
-        if (result.matchedCount > 0 && resultTwo.matchedCount > 0) {
-            res.json({
+        const resultTwo = await ApiKey.updateOne(
+          { owner: userIdNumber },
+          { $set: { is_banned: true } },
+          { upsert: false }
+        );
+
+        if (result.matchedCount > 0 || resultTwo.matchedCount > 0) {
+            return res.status(200).json({
               message: "API key successfully banned",
               owner: userIdNumber
             });
         } else {
-            res.status(500).json({ error: "Failed to ban API key" });
+            return res.status(500).json({ error: "Failed to ban API key" });
         }
 
     } catch (err) {