Update plugins/federations.js

plugins/federations.js

@@ -68,39 +68,48 @@ FedsRoutes.post('/api/v2/federation/unban', authenticateApiKey, async (req, res)
             return res.status(404).json({ error: "Federation not found." });
         }
 
-        federation.banned_users = federation.banned_users.filter(id => id !== user_id);
+        federation.banned_users = federation.banned_users.filter(id => Number(id) !== Number(user_id));
         await federation.save();
 
-        res.json({ success: true, message: `User ${user_id} unbanned from federation ${name}.` });
+        await Federation.updateMany(
+            { uuid: { $in: federation.sub_federations } },
+            { $pull: { banned_users: Number(user_id) } }
+        );
+
+        res.json({ success: true, message: `User ${user_id} unbanned from ${name} and its sub-federations.` });
     } catch (error) {
         res.status(500).json({ error: `Failed to unban user: ${error.message}` });
     }
 });
 
+
 FedsRoutes.post("/api/v2/federation/ban", authenticateApiKey, apiLimiter, async (req, res) => {
-  try {
-    const { federation_uuid, user_id } = req.body;
+    try {
+        const { federation_uuid, user_id } = req.body;
 
-    const federation = await Federation.findOne({ uuid: federation_uuid });
-    if (!federation) return res.status(404).json({ error: "Federation not found" });
+        if (!federation_uuid || !user_id || isNaN(user_id)) {
+            return res.status(400).json({ error: "Federation UUID and valid user ID required" });
+        }
 
-    if (!federation.banned_users.includes(user_id)) {
-      federation.banned_users.push(user_id);
-      await federation.save();
-    }
+        const federation = await Federation.findOne({ uuid: federation_uuid });
 
-    const subFeds = await Federation.find({ uuid: { $in: federation.sub_federations } });
-    for (const subFed of subFeds) {
-      if (!subFed.banned_users.includes(user_id)) {
-        subFed.banned_users.push(user_id);
-        await subFed.save();
-      }
-    }
+        if (!federation) return res.status(404).json({ error: "Federation not found" });
 
-    res.json({ message: `User ${user_id} banned in ${federation.name} and all its sub-federations` });
-  } catch (err) {
-    res.status(500).json({ error: err.message });
-  }
+        if (!federation.banned_users.includes(Number(user_id))) {
+            federation.banned_users.push(Number(user_id));
+            await federation.save();
+        }
+  
+        await Federation.updateMany(
+            { uuid: { $in: federation.sub_federations } },
+            { $addToSet: { banned_users: Number(user_id) } }
+        );
+
+        res.json({ message: `User ${user_id} banned in ${federation.name} and all its sub-federations.` });
+    } catch (err) {
+        res.status(500).json({ error: err.message });
+    }
 });
 
+
 export { FedsRoutes };