Spaces:
Build error
Build error
File size: 16,914 Bytes
84d2a97 |
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 |
use std::path::{Path, PathBuf};
use common::tempfile_ext::MaybeTempPath;
use object_store::aws::AmazonS3Builder;
use serde::Deserialize;
use tempfile::TempPath;
use tokio::io::AsyncWriteExt;
use super::snapshot_stream::{SnapShotStreamLocalFS, SnapshotStream};
use crate::common::file_utils::move_file;
use crate::common::sha_256::hash_file;
use crate::operations::snapshot_ops::{
get_checksum_path, get_snapshot_description, SnapshotDescription,
};
use crate::operations::snapshot_storage_ops::{self};
use crate::operations::types::{CollectionError, CollectionResult};
#[derive(Clone, Deserialize, Debug, Default)]
pub struct SnapShotsConfig {
pub snapshots_storage: SnapshotsStorageConfig,
pub s3_config: Option<S3Config>,
}
#[derive(Clone, Debug, Default, Deserialize)]
pub enum SnapshotsStorageConfig {
#[default]
Local,
S3,
}
#[derive(Clone, Deserialize, Debug, Default)]
pub struct S3Config {
pub bucket: String,
pub region: Option<String>,
pub access_key: Option<String>,
pub secret_key: Option<String>,
pub endpoint_url: Option<String>,
}
pub struct SnapshotStorageCloud {
client: Box<dyn object_store::ObjectStore>,
}
pub struct SnapshotStorageLocalFS;
pub enum SnapshotStorageManager {
LocalFS(SnapshotStorageLocalFS),
// Assuming that we can have common operations for all cloud storages
S3(SnapshotStorageCloud),
// <TODO> : Implement other cloud storage
// GCS(SnapshotStorageCloud),
// AZURE(SnapshotStorageCloud),
}
impl SnapshotStorageManager {
pub fn new(snapshots_config: &SnapShotsConfig) -> CollectionResult<Self> {
match snapshots_config.snapshots_storage {
SnapshotsStorageConfig::Local => {
Ok(SnapshotStorageManager::LocalFS(SnapshotStorageLocalFS))
}
SnapshotsStorageConfig::S3 => {
let mut builder = AmazonS3Builder::new();
if let Some(s3_config) = &snapshots_config.s3_config {
builder = builder.with_bucket_name(&s3_config.bucket);
if let Some(access_key) = &s3_config.access_key {
builder = builder.with_access_key_id(access_key);
}
if let Some(secret_key) = &s3_config.secret_key {
builder = builder.with_secret_access_key(secret_key);
}
if let Some(region) = &s3_config.region {
builder = builder.with_region(region);
}
if let Some(endpoint_url) = &s3_config.endpoint_url {
builder = builder.with_endpoint(endpoint_url);
if endpoint_url.starts_with("http://") {
builder = builder.with_allow_http(true);
}
}
}
let client: Box<dyn object_store::ObjectStore> =
Box::new(builder.build().map_err(|e| {
CollectionError::service_error(format!("Failed to create S3 client: {e}"))
})?);
Ok(SnapshotStorageManager::S3(SnapshotStorageCloud { client }))
}
}
}
pub async fn delete_snapshot(&self, snapshot_name: &Path) -> CollectionResult<bool> {
match self {
SnapshotStorageManager::LocalFS(storage_impl) => {
storage_impl.delete_snapshot(snapshot_name).await
}
SnapshotStorageManager::S3(storage_impl) => {
storage_impl.delete_snapshot(snapshot_name).await
}
}
}
pub async fn list_snapshots(
&self,
directory: &Path,
) -> CollectionResult<Vec<SnapshotDescription>> {
match self {
SnapshotStorageManager::LocalFS(storage_impl) => {
storage_impl.list_snapshots(directory).await
}
SnapshotStorageManager::S3(storage_impl) => {
storage_impl.list_snapshots(directory).await
}
}
}
/// Store file in the snapshot storage.
/// On success, the `source_path` is deleted.
pub async fn store_file(
&self,
source_path: &Path,
target_path: &Path,
) -> CollectionResult<SnapshotDescription> {
debug_assert_ne!(
source_path, target_path,
"Source and target paths must be different"
);
match self {
SnapshotStorageManager::LocalFS(storage_impl) => {
storage_impl.store_file(source_path, target_path).await
}
SnapshotStorageManager::S3(storage_impl) => {
storage_impl.store_file(source_path, target_path).await
}
}
}
pub async fn get_stored_file(
&self,
storage_path: &Path,
local_path: &Path,
) -> CollectionResult<()> {
match self {
SnapshotStorageManager::LocalFS(storage_impl) => {
storage_impl.get_stored_file(storage_path, local_path).await
}
SnapshotStorageManager::S3(storage_impl) => {
storage_impl.get_stored_file(storage_path, local_path).await
}
}
}
pub fn get_snapshot_path(
&self,
snapshots_path: &Path,
snapshot_name: &str,
) -> CollectionResult<PathBuf> {
match self {
SnapshotStorageManager::LocalFS(_storage_impl) => {
SnapshotStorageLocalFS::get_snapshot_path(snapshots_path, snapshot_name)
}
SnapshotStorageManager::S3(_storage_impl) => Ok(
SnapshotStorageCloud::get_snapshot_path(snapshots_path, snapshot_name),
),
}
}
pub fn get_full_snapshot_path(
&self,
snapshots_path: &str,
snapshot_name: &str,
) -> CollectionResult<PathBuf> {
match self {
SnapshotStorageManager::LocalFS(_storage_impl) => {
SnapshotStorageLocalFS::get_full_snapshot_path(snapshots_path, snapshot_name)
}
SnapshotStorageManager::S3(_storage_impl) => Ok(
SnapshotStorageCloud::get_full_snapshot_path(snapshots_path, snapshot_name),
),
}
}
pub async fn get_snapshot_file(
&self,
snapshot_path: &Path,
temp_dir: &Path,
) -> CollectionResult<MaybeTempPath> {
match self {
SnapshotStorageManager::LocalFS(_storage_impl) => {
SnapshotStorageLocalFS::get_snapshot_file(snapshot_path, temp_dir)
}
SnapshotStorageManager::S3(storage_impl) => {
storage_impl
.get_snapshot_file(snapshot_path, temp_dir)
.await
}
}
}
pub async fn get_snapshot_stream(
&self,
snapshot_path: &Path,
) -> CollectionResult<SnapshotStream> {
match self {
SnapshotStorageManager::LocalFS(_storage_impl) => {
Ok(SnapshotStorageLocalFS::get_snapshot_stream(snapshot_path))
}
SnapshotStorageManager::S3(storage_impl) => {
storage_impl.get_snapshot_stream(snapshot_path).await
}
}
}
}
impl SnapshotStorageLocalFS {
async fn delete_snapshot(&self, snapshot_path: &Path) -> CollectionResult<bool> {
let checksum_path = get_checksum_path(snapshot_path);
let (delete_snapshot, delete_checksum) = tokio::join!(
tokio::fs::remove_file(snapshot_path),
tokio::fs::remove_file(checksum_path),
);
delete_snapshot.map_err(|e| match e.kind() {
std::io::ErrorKind::NotFound => {
CollectionError::not_found(format!("Snapshot {snapshot_path:?}"))
}
_ => e.into(),
})?;
// We might not have a checksum file for the snapshot, ignore deletion errors in that case
if let Err(err) = delete_checksum {
log::warn!("Failed to delete checksum file for snapshot, ignoring: {err}");
}
Ok(true)
}
async fn list_snapshots(&self, directory: &Path) -> CollectionResult<Vec<SnapshotDescription>> {
let mut entries = match tokio::fs::read_dir(directory).await {
Ok(entries) => entries,
Err(e) if e.kind() == std::io::ErrorKind::NotFound => return Ok(Vec::new()),
Err(e) => return Err(e.into()),
};
let mut snapshots = Vec::new();
while let Some(entry) = entries.next_entry().await? {
let path = entry.path();
if !path.is_dir() && path.extension().map_or(false, |ext| ext == "snapshot") {
snapshots.push(get_snapshot_description(&path).await?);
}
}
Ok(snapshots)
}
async fn store_file(
&self,
source_path: &Path,
target_path: &Path,
) -> CollectionResult<SnapshotDescription> {
// Steps:
//
// 1. Make sure that the target directory exists.
// 2. Compute the checksum of the source file.
// 3. Generate temporary file name, which should be used on the same file system as the target directory.
// 4. Move or copy the source file to the temporary file. (move might not be possible if the source and target are on different file systems)
// 5. Move the temporary file to the target file. (move is atomic, copy is not)
if let Some(target_dir) = target_path.parent() {
std::fs::create_dir_all(target_dir)?;
}
// Move snapshot to permanent location.
// We can't move right away, because snapshot folder can be on another mounting point.
// We can't copy to the target location directly, because copy is not atomic.
// So we copy to the final location with a temporary name and then rename atomically.
let target_path_tmp = TempPath::from_path(target_path.with_extension("tmp"));
// compute and store the file's checksum before the final snapshot file is saved
// to avoid making snapshot available without checksum
let checksum_path = get_checksum_path(target_path);
let checksum = hash_file(source_path).await?;
let checksum_file = TempPath::from_path(&checksum_path);
let mut file = tokio::fs::File::create(checksum_path.as_path()).await?;
file.write_all(checksum.as_bytes()).await?;
move_file(&source_path, &target_path_tmp).await?;
target_path_tmp.persist(target_path).map_err(|e| e.error)?;
checksum_file.keep()?;
get_snapshot_description(target_path).await
}
async fn get_stored_file(
&self,
storage_path: &Path,
local_path: &Path,
) -> CollectionResult<()> {
if let Some(target_dir) = local_path.parent() {
if !target_dir.exists() {
std::fs::create_dir_all(target_dir)?;
}
}
if storage_path != local_path {
move_file(&storage_path, &local_path).await?;
}
Ok(())
}
/// Get absolute file path for a full snapshot by name
///
/// This enforces the file to be inside the snapshots directory
fn get_full_snapshot_path(
snapshots_path: &str,
snapshot_name: &str,
) -> CollectionResult<PathBuf> {
let absolute_snapshot_dir = Path::new(snapshots_path).canonicalize().map_err(|_| {
CollectionError::not_found(format!("Snapshot directory: {snapshots_path}"))
})?;
let absolute_snapshot_path = absolute_snapshot_dir
.join(snapshot_name)
.canonicalize()
.map_err(|_| CollectionError::not_found(format!("Snapshot {snapshot_name}")))?;
if !absolute_snapshot_path.starts_with(absolute_snapshot_dir) {
return Err(CollectionError::not_found(format!(
"Snapshot {snapshot_name}"
)));
}
if !absolute_snapshot_path.is_file() {
return Err(CollectionError::not_found(format!(
"Snapshot {snapshot_name}"
)));
}
Ok(absolute_snapshot_path)
}
/// Get absolute file path for a collection snapshot by name
///
/// This enforces the file to be inside the snapshots directory
fn get_snapshot_path(snapshots_path: &Path, snapshot_name: &str) -> CollectionResult<PathBuf> {
let absolute_snapshot_dir = snapshots_path.canonicalize().map_err(|_| {
CollectionError::not_found(format!("Snapshot directory: {}", snapshots_path.display()))
})?;
let absolute_snapshot_path = absolute_snapshot_dir
.join(snapshot_name)
.canonicalize()
.map_err(|_| CollectionError::not_found(format!("Snapshot {snapshot_name}")))?;
if !absolute_snapshot_path.starts_with(absolute_snapshot_dir) {
return Err(CollectionError::not_found(format!(
"Snapshot {snapshot_name}"
)));
}
if !absolute_snapshot_path.is_file() {
return Err(CollectionError::not_found(format!(
"Snapshot {snapshot_name}"
)));
}
Ok(absolute_snapshot_path)
}
fn get_snapshot_file(
snapshot_path: &Path,
_temp_dir: &Path,
) -> CollectionResult<MaybeTempPath> {
if !snapshot_path.exists() {
return Err(CollectionError::not_found(format!(
"Snapshot {snapshot_path:?}"
)));
}
Ok(MaybeTempPath::Persistent(snapshot_path.to_path_buf()))
}
fn get_snapshot_stream(snapshot_path: &Path) -> SnapshotStream {
SnapshotStream::LocalFS(SnapShotStreamLocalFS {
snapshot_path: snapshot_path.to_path_buf(),
})
}
}
impl SnapshotStorageCloud {
async fn delete_snapshot(&self, snapshot_path: &Path) -> CollectionResult<bool> {
snapshot_storage_ops::delete_snapshot(&self.client, snapshot_path).await
}
async fn list_snapshots(&self, directory: &Path) -> CollectionResult<Vec<SnapshotDescription>> {
snapshot_storage_ops::list_snapshot_descriptions(&self.client, directory).await
}
async fn store_file(
&self,
source_path: &Path,
target_path: &Path,
) -> CollectionResult<SnapshotDescription> {
snapshot_storage_ops::multipart_upload(&self.client, source_path, target_path).await?;
tokio::fs::remove_file(source_path).await?;
snapshot_storage_ops::get_snapshot_description(&self.client, target_path).await
}
async fn get_stored_file(
&self,
storage_path: &Path,
local_path: &Path,
) -> CollectionResult<()> {
if let Some(target_dir) = local_path.parent() {
if !target_dir.exists() {
std::fs::create_dir_all(target_dir)?;
}
}
if storage_path != local_path {
// download snapshot from cloud storage to local path
snapshot_storage_ops::download_snapshot(&self.client, storage_path, local_path).await?;
}
Ok(())
}
fn get_snapshot_path(snapshots_path: &Path, snapshot_name: &str) -> PathBuf {
let absolute_snapshot_dir = snapshots_path;
absolute_snapshot_dir.join(snapshot_name)
}
fn get_full_snapshot_path(snapshots_path: &str, snapshot_name: &str) -> PathBuf {
let absolute_snapshot_dir = PathBuf::from(snapshots_path);
absolute_snapshot_dir.join(snapshot_name)
}
async fn get_snapshot_file(
&self,
snapshot_path: &Path,
temp_dir: &Path,
) -> CollectionResult<MaybeTempPath> {
let temp_path = tempfile::Builder::new()
.prefix(
snapshot_path
.file_stem()
.ok_or_else(|| CollectionError::bad_request("Invalid snapshot path"))?,
)
.suffix(".snapshot")
.tempfile_in(temp_dir)?
.into_temp_path();
snapshot_storage_ops::download_snapshot(&self.client, snapshot_path, &temp_path).await?;
Ok(MaybeTempPath::Temporary(temp_path))
}
pub async fn get_snapshot_stream(
&self,
snapshot_path: &Path,
) -> CollectionResult<SnapshotStream> {
let snapshot_path = snapshot_storage_ops::trim_dot_slash(snapshot_path)?;
let download = self.client.get(&snapshot_path).await.map_err(|e| match e {
object_store::Error::NotFound { path, source } => {
CollectionError::not_found(format!("Snapshot {path} does not exist: {source}"))
}
_ => CollectionError::service_error(format!("Failed to get {snapshot_path}: {e}")),
})?;
Ok(SnapshotStream::new_stream(download.into_stream(), None))
}
}
|