Spaces:
Build error
Build error
File size: 23,209 Bytes
84d2a97 |
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 |
use std::collections::{HashMap, HashSet};
use std::fmt;
use std::ops::Deref as _;
use std::sync::Arc;
use segment::types::{Condition, CustomIdCheckerCondition as _, Filter, ShardKey};
use super::ShardHolder;
use crate::hash_ring::{self, HashRingRouter};
use crate::operations::cluster_ops::ReshardingDirection;
use crate::operations::types::{CollectionError, CollectionResult, UpdateResult};
use crate::operations::{point_ops, CollectionUpdateOperations};
use crate::shards::replica_set::{ReplicaState, ShardReplicaSet};
use crate::shards::resharding::{ReshardKey, ReshardStage, ReshardState};
use crate::shards::shard::ShardId;
impl ShardHolder {
pub fn resharding_state(&self) -> Option<ReshardState> {
self.resharding_state.read().clone()
}
pub fn check_start_resharding(&mut self, resharding_key: &ReshardKey) -> CollectionResult<()> {
let ReshardKey {
direction,
peer_id: _,
shard_id,
shard_key,
} = resharding_key;
let ring = get_ring(&mut self.rings, shard_key)?;
{
let state = self.resharding_state.read();
assert_resharding_state_consistency(&state, ring, shard_key);
if let Some(state) = state.deref() {
if state.matches(resharding_key) {
return Err(CollectionError::bad_request(format!(
"resharding {resharding_key} is already in progress:\n{state:#?}"
)));
} else {
return Err(CollectionError::bad_request(format!(
"another resharding is in progress:\n{state:#?}"
)));
}
}
}
// Don't remove the last shard if resharding down
if matches!(direction, ReshardingDirection::Down) {
let shard_count = match shard_key {
Some(shard_key) => self
.get_shard_key_to_ids_mapping()
.get(shard_key)
.map_or(0, |shards| shards.len()),
None => self.shards.len(),
};
if shard_count <= 1 {
return Err(CollectionError::bad_request(format!(
"cannot remove shard {shard_id} by resharding down, it is the last shard",
)));
}
}
let has_shard = self.shards.contains_key(shard_id);
match resharding_key.direction {
ReshardingDirection::Up => {
if has_shard {
return Err(CollectionError::bad_request(format!(
"shard holder already contains shard {shard_id} replica set",
)));
}
}
ReshardingDirection::Down => {
if !has_shard {
return Err(CollectionError::bad_request(format!(
"shard holder does not contain shard {shard_id} replica set",
)));
}
}
}
// TODO(resharding): Check that peer exists!?
Ok(())
}
// TODO: do not leave broken intermediate state if this fails midway?
pub fn start_resharding_unchecked(
&mut self,
resharding_key: ReshardKey,
new_shard: Option<ShardReplicaSet>,
) -> CollectionResult<()> {
let ReshardKey {
direction,
peer_id,
shard_id,
shard_key,
} = resharding_key;
// TODO(resharding): Delete shard on error!?
let ring = get_ring(&mut self.rings, &shard_key)?;
ring.start_resharding(shard_id, direction);
// Add new shard if resharding up
if let Some(new_shard) = new_shard {
debug_assert_eq!(direction, ReshardingDirection::Up);
self.add_shard(shard_id, new_shard, shard_key.clone())?;
}
self.resharding_state.write(|state| {
debug_assert!(
state.is_none(),
"resharding is already in progress:\n{state:#?}",
);
*state = Some(ReshardState::new(direction, peer_id, shard_id, shard_key));
})?;
Ok(())
}
pub fn commit_read_hashring(&mut self, resharding_key: &ReshardKey) -> CollectionResult<()> {
self.check_resharding(resharding_key, check_stage(ReshardStage::MigratingPoints))?;
self.resharding_state.write(|state| {
let Some(state) = state else {
unreachable!();
};
state.stage = ReshardStage::ReadHashRingCommitted;
})?;
Ok(())
}
pub fn commit_write_hashring(&mut self, resharding_key: &ReshardKey) -> CollectionResult<()> {
self.check_resharding(
resharding_key,
check_stage(ReshardStage::ReadHashRingCommitted),
)?;
let ring = get_ring(&mut self.rings, &resharding_key.shard_key)?;
ring.commit_resharding();
self.resharding_state.write(|state| {
let Some(state) = state else {
unreachable!();
};
state.stage = ReshardStage::WriteHashRingCommitted;
})?;
Ok(())
}
pub fn check_finish_resharding(&mut self, resharding_key: &ReshardKey) -> CollectionResult<()> {
self.check_resharding(
resharding_key,
check_stage(ReshardStage::WriteHashRingCommitted),
)?;
Ok(())
}
pub fn finish_resharding_unchecked(&mut self, _: &ReshardKey) -> CollectionResult<()> {
self.resharding_state.write(|state| {
debug_assert!(state.is_some(), "resharding is not in progress");
*state = None;
})?;
Ok(())
}
fn check_resharding(
&mut self,
resharding_key: &ReshardKey,
check_state: impl Fn(&ReshardState) -> CollectionResult<()>,
) -> CollectionResult<()> {
let ReshardKey {
shard_id,
shard_key,
..
} = resharding_key;
let ring = get_ring(&mut self.rings, shard_key)?;
let state = self.resharding_state.read();
assert_resharding_state_consistency(&state, ring, &resharding_key.shard_key);
match state.deref() {
Some(state) if state.matches(resharding_key) => {
check_state(state)?;
}
Some(state) => {
return Err(CollectionError::bad_request(format!(
"another resharding is in progress:\n{state:#?}"
)));
}
None => {
return Err(CollectionError::bad_request(
"resharding is not in progress",
));
}
}
debug_assert!(
self.shards.contains_key(shard_id),
"shard holder does not contain shard {shard_id} replica set"
);
// TODO(resharding): Assert that peer exists!?
Ok(())
}
pub fn check_abort_resharding(&mut self, resharding_key: &ReshardKey) -> CollectionResult<()> {
let state = self.resharding_state.read();
// - do not abort if no resharding operation is ongoing
let Some(state) = state.deref() else {
return Err(CollectionError::bad_request(format!(
"can't abort resharding {resharding_key}, no resharding operation in progress",
)));
};
// - do not abort if there is no active reshardinog operation with that key
if !state.matches(resharding_key) {
return Err(CollectionError::bad_request(format!(
"can't abort resharding {resharding_key}, \
resharding operation in progress has key {}",
state.key(),
)));
}
// - it's safe to run, if write hash ring was not committed yet
if state.stage < ReshardStage::ReadHashRingCommitted {
return Ok(());
}
// - but resharding can't be aborted, after read hash ring has been committed
Err(CollectionError::bad_request(format!(
"can't abort resharding {resharding_key}, \
because read hash ring has been committed already, \
resharding must be completed",
)))
}
pub async fn abort_resharding(
&mut self,
resharding_key: ReshardKey,
force: bool,
) -> CollectionResult<()> {
let ReshardKey {
direction,
peer_id,
shard_id,
ref shard_key,
} = resharding_key;
let is_in_progress = match self.resharding_state.read().deref() {
Some(state) if state.matches(&resharding_key) => {
if !force && state.stage >= ReshardStage::ReadHashRingCommitted {
return Err(CollectionError::bad_request(format!(
"can't abort resharding {resharding_key}, \
because read hash ring has been committed already, \
resharding must be completed",
)));
}
true
}
Some(state) => {
log::warn!(
"aborting resharding {resharding_key}, \
but another resharding is in progress:\n\
{state:#?}"
);
false
}
None => {
log::warn!(
"aborting resharding {resharding_key}, \
but resharding is not in progress"
);
false
}
};
// Cleanup existing shards if resharding down
if is_in_progress && direction == ReshardingDirection::Down {
for (&id, shard) in self.shards.iter() {
// Skip shards that does not belong to resharding shard key
if self.shard_id_to_key_mapping.get(&id) != shard_key.as_ref() {
continue;
}
// Skip target shard
if id == shard_id {
continue;
}
// Revert replicas in `Resharding` state back into `Active` state
for (peer, state) in shard.peers() {
if state == ReplicaState::Resharding {
shard.set_replica_state(peer, ReplicaState::Active)?;
}
}
// We only cleanup local shards
if !shard.is_local().await {
continue;
}
// Remove any points that might have been transferred from target shard
let filter = self.hash_ring_filter(id).expect("hash ring filter");
let filter = Filter::new_must_not(Condition::CustomIdChecker(Arc::new(filter)));
shard.delete_local_points(filter).await?;
}
}
if let Some(ring) = self.rings.get_mut(shard_key) {
log::debug!("reverting resharding hashring for shard {shard_id}");
ring.abort_resharding(shard_id, direction);
} else {
log::warn!(
"aborting resharding {resharding_key}, \
but {shard_key:?} hashring does not exist"
);
}
// Remove new shard if resharding up
if direction == ReshardingDirection::Up {
if let Some(shard) = self.get_shard(shard_id) {
match shard.peer_state(peer_id) {
Some(ReplicaState::Resharding) => {
log::debug!("removing peer {peer_id} from {shard_id} replica set");
shard.remove_peer(peer_id).await?;
}
Some(ReplicaState::Dead) if is_in_progress => {
log::debug!("removing dead peer {peer_id} from {shard_id} replica set");
shard.remove_peer(peer_id).await?;
}
Some(state) => {
return Err(CollectionError::bad_request(format!(
"peer {peer_id} is in {state:?} state"
)));
}
None => {
log::warn!(
"aborting resharding {resharding_key}, \
but peer {peer_id} does not exist in {shard_id} replica set"
);
}
}
if shard.peers().is_empty() {
log::debug!("removing {shard_id} replica set, because replica set is empty");
if let Some(shard_key) = shard_key {
self.key_mapping.write_optional(|key_mapping| {
if !key_mapping.contains_key(shard_key) {
return None;
}
let mut key_mapping = key_mapping.clone();
key_mapping.get_mut(shard_key).unwrap().remove(&shard_id);
Some(key_mapping)
})?;
}
self.drop_and_remove_shard(shard_id).await?;
self.shard_id_to_key_mapping.remove(&shard_id);
}
} else {
log::warn!(
"aborting resharding {resharding_key}, \
but shard holder does not contain {shard_id} replica set",
);
}
}
if is_in_progress {
self.resharding_state.write(|state| {
debug_assert!(
state
.as_ref()
.map_or(false, |state| state.matches(&resharding_key)),
"resharding {resharding_key} is not in progress:\n{state:#?}"
);
state.take();
})?;
}
Ok(())
}
/// Split collection update operation by "update mode":
/// - update all:
/// - "regular" operation
/// - `upsert` inserts new points and updates existing ones
/// - other update operations return error, if a point does not exist in collection
/// - update existing:
/// - `upsert` does *not* insert new points, only updates existing ones
/// - other update operations ignore points that do not exist in collection
///
/// Depends on the current resharding state. If resharding is not active operations are not split.
pub fn split_by_mode(
&self,
shard_id: ShardId,
operation: CollectionUpdateOperations,
) -> OperationsByMode {
let Some(state) = self.resharding_state() else {
return OperationsByMode::from(operation);
};
// Resharding *UP*
// ββββββββββββββ ββββββββββββ
// β β β β
// β Shard 1 β β Shard 2 β
// β Non-Target ββββΊβ Target β
// β Sender β β Receiver β
// β β β β
// ββββββββββββββ ββββββββββββ
//
// Resharding *DOWN*
// ββββββββββββββ ββββββββββββ
// β β β β
// β Shard 1 β β Shard 2 β
// β Non-Target βββββ€ Target β
// β Receiver β β Sender β
// β β β β
// ββββββββββββββ ββββββββββββ
// Target shard of the resharding operation. This is the shard that:
//
// - *created* during resharding *up*
// - *deleted* during resharding *down*
let is_target_shard = shard_id == state.shard_id;
// Shard that will be *receiving* migrated points during resharding:
//
// - *target* shard during resharding *up*
// - *non* target shards during resharding *down*
let is_receiver_shard = match state.direction {
ReshardingDirection::Up => is_target_shard,
ReshardingDirection::Down => !is_target_shard,
};
// Shard that will be *sending* migrated points during resharding:
//
// - *non* target shards during resharding *up*
// - *target* shard during resharding *down*
let is_sender_shard = !is_receiver_shard;
// We split update operations:
//
// - on *receiver* shards during `MigratingPoints` stage (for all operations except `upsert`)
// - and on *sender* shards during `ReadHashRingCommitted` stage when resharding *up*
let should_split_receiver = is_receiver_shard
&& state.stage == ReshardStage::MigratingPoints
&& !operation.is_upsert_points();
let should_split_sender = is_sender_shard
&& state.stage >= ReshardStage::ReadHashRingCommitted
&& state.direction == ReshardingDirection::Up;
if !should_split_receiver && !should_split_sender {
return OperationsByMode::from(operation);
}
// There's no point splitting delete operations
if operation.is_delete_points() {
return OperationsByMode::from(operation);
}
let Some(filter) = self.resharding_filter() else {
return OperationsByMode::from(operation);
};
let point_ids = operation.point_ids();
if point_ids.is_empty() {
return OperationsByMode::from(operation);
}
let target_point_ids: HashSet<_> = point_ids
.iter()
.copied()
.filter(|&point_id| filter.check(point_id))
.collect();
if target_point_ids.is_empty() {
OperationsByMode::from(operation)
} else if target_point_ids.len() == point_ids.len() {
OperationsByMode::default().with_update_only_existing(operation)
} else {
let mut update_all = operation.clone();
update_all.retain_point_ids(|point_id| !target_point_ids.contains(point_id));
let mut update_only_existing = operation;
update_only_existing.retain_point_ids(|point_id| target_point_ids.contains(point_id));
OperationsByMode::from(update_all).with_update_only_existing(update_only_existing)
}
}
pub async fn cleanup_local_shard(&self, shard_id: ShardId) -> CollectionResult<UpdateResult> {
let shard = self.get_shard(shard_id).ok_or_else(|| {
CollectionError::not_found(format!("shard {shard_id} does not exist"))
})?;
if !shard.is_local().await {
return Err(CollectionError::bad_shard_selection(format!(
"shard {shard_id} is not a local shard"
)))?;
}
let filter = self.hash_ring_filter(shard_id).expect("hash ring filter");
let filter = Filter::new_must_not(Condition::CustomIdChecker(Arc::new(filter)));
shard.delete_local_points(filter).await
}
pub fn resharding_filter(&self) -> Option<hash_ring::HashRingFilter> {
let shard_id = self.resharding_state.read().as_ref()?.shard_id;
self.hash_ring_filter(shard_id)
}
pub fn hash_ring_filter(&self, shard_id: ShardId) -> Option<hash_ring::HashRingFilter> {
if !self.contains_shard(shard_id) {
return None;
}
let shard_key = self.shard_id_to_key_mapping.get(&shard_id).cloned();
let router = self.rings.get(&shard_key).expect("hashring exists");
let ring = match router {
HashRingRouter::Single(ring) => ring,
HashRingRouter::Resharding { old, new } => {
if new.len() > old.len() {
new
} else {
old
}
}
};
Some(hash_ring::HashRingFilter::new(ring.clone(), shard_id))
}
}
#[derive(Clone, Debug, Default)]
pub struct OperationsByMode {
pub update_all: Vec<CollectionUpdateOperations>,
pub update_only_existing: Vec<CollectionUpdateOperations>,
}
impl OperationsByMode {
pub fn with_update_only_existing(mut self, operation: CollectionUpdateOperations) -> Self {
match operation {
CollectionUpdateOperations::PointOperation(
point_ops::PointOperations::UpsertPoints(operation),
) => {
self.update_only_existing = operation.into_update_only();
}
operation => {
self.update_only_existing = vec![operation];
}
}
self
}
}
impl From<CollectionUpdateOperations> for OperationsByMode {
fn from(operation: CollectionUpdateOperations) -> Self {
Self {
update_all: vec![operation],
update_only_existing: Vec::new(),
}
}
}
fn get_ring<'a>(
rings: &'a mut HashMap<Option<ShardKey>, HashRingRouter>,
shard_key: &'_ Option<ShardKey>,
) -> CollectionResult<&'a mut HashRingRouter> {
rings.get_mut(shard_key).ok_or_else(|| {
CollectionError::bad_request(format!(
"{} hashring does not exist",
shard_key_fmt(shard_key)
))
})
}
fn assert_resharding_state_consistency(
state: &Option<ReshardState>,
ring: &HashRingRouter,
shard_key: &Option<ShardKey>,
) {
match state.as_ref().map(|state| state.stage) {
Some(ReshardStage::MigratingPoints | ReshardStage::ReadHashRingCommitted) => {
debug_assert!(
ring.is_resharding(),
"resharding is in progress, \
but {shard_key:?} hashring is not a resharding hashring:\n\
{state:#?}"
);
}
Some(ReshardStage::WriteHashRingCommitted) => {
debug_assert!(
!ring.is_resharding(),
"resharding is in progress, \
and write hashring has already been committed, \
but {shard_key:?} hashring is a resharding hashring:\n\
{state:#?}"
);
}
None => {
debug_assert!(
!ring.is_resharding(),
"resharding is not in progress, \
but {shard_key:?} hashring is a resharding hashring"
);
}
}
}
fn check_stage(stage: ReshardStage) -> impl Fn(&ReshardState) -> CollectionResult<()> {
move |state| {
if state.stage == stage {
Ok(())
} else {
Err(CollectionError::bad_request(format!(
"expected resharding stage {stage:?}, but resharding is at stage {:?}",
state.stage,
)))
}
}
}
fn shard_key_fmt(key: &Option<ShardKey>) -> &dyn fmt::Display {
match key {
Some(key) => key,
None => &"default",
}
}
|