Spaces:
Build error
Build error
File size: 34,670 Bytes
84d2a97 |
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 |
use std::cmp::min;
use std::collections::HashSet;
use std::path::{Path, PathBuf};
use std::sync::atomic::{AtomicBool, AtomicU64, AtomicUsize, Ordering};
use std::sync::Arc;
use common::cpu::CpuBudget;
use common::panic;
use itertools::Itertools;
use log::{debug, error, info, trace, warn};
use parking_lot::Mutex;
use segment::common::operation_error::OperationResult;
use segment::index::hnsw_index::num_rayon_threads;
use segment::types::SeqNumberType;
use tokio::runtime::Handle;
use tokio::sync::mpsc::{self, Receiver, Sender};
use tokio::sync::{oneshot, Mutex as TokioMutex};
use tokio::task::{self, JoinHandle};
use tokio::time::error::Elapsed;
use tokio::time::{timeout, Duration};
use crate::collection::payload_index_schema::PayloadIndexSchema;
use crate::collection_manager::collection_updater::CollectionUpdater;
use crate::collection_manager::holders::segment_holder::LockedSegmentHolder;
use crate::collection_manager::optimizers::segment_optimizer::{
OptimizerThresholds, SegmentOptimizer,
};
use crate::collection_manager::optimizers::{Tracker, TrackerLog, TrackerStatus};
use crate::common::stoppable_task::{spawn_stoppable, StoppableTaskHandle};
use crate::config::CollectionParams;
use crate::operations::shared_storage_config::SharedStorageConfig;
use crate::operations::types::{CollectionError, CollectionResult};
use crate::operations::CollectionUpdateOperations;
use crate::save_on_disk::SaveOnDisk;
use crate::shards::local_shard::LocalShardClocks;
use crate::wal::WalError;
use crate::wal_delta::LockedWal;
/// Interval at which the optimizer worker cleans up old optimization handles
///
/// The longer the duration, the longer it takes for panicked tasks to be reported.
const OPTIMIZER_CLEANUP_INTERVAL: Duration = Duration::from_secs(5);
pub type Optimizer = dyn SegmentOptimizer + Sync + Send;
/// Information, required to perform operation and notify regarding the result
#[derive(Debug)]
pub struct OperationData {
/// Sequential number of the operation
pub op_num: SeqNumberType,
/// Operation
pub operation: CollectionUpdateOperations,
/// If operation was requested to wait for result
pub wait: bool,
/// Callback notification channel
pub sender: Option<oneshot::Sender<CollectionResult<usize>>>,
}
/// Signal, used to inform Updater process
#[derive(Debug)]
pub enum UpdateSignal {
/// Requested operation to perform
Operation(OperationData),
/// Stop all optimizers and listening
Stop,
/// Empty signal used to trigger optimizers
Nop,
/// Ensures that previous updates are applied
Plunger(oneshot::Sender<()>),
}
/// Signal, used to inform Optimization process
#[derive(PartialEq, Eq, Clone, Copy)]
pub enum OptimizerSignal {
/// Sequential number of the operation
Operation(SeqNumberType),
/// Stop all optimizers and listening
Stop,
/// Empty signal used to trigger optimizers
Nop,
}
/// Structure, which holds object, required for processing updates of the collection
pub struct UpdateHandler {
shared_storage_config: Arc<SharedStorageConfig>,
payload_index_schema: Arc<SaveOnDisk<PayloadIndexSchema>>,
/// List of used optimizers
pub optimizers: Arc<Vec<Arc<Optimizer>>>,
/// Log of optimizer statuses
optimizers_log: Arc<Mutex<TrackerLog>>,
/// Total number of optimized points since last start
total_optimized_points: Arc<AtomicUsize>,
/// Global CPU budget in number of cores for all optimization tasks.
/// Assigns CPU permits to tasks to limit overall resource utilization.
optimizer_cpu_budget: CpuBudget,
/// How frequent can we flush data
/// This parameter depends on the optimizer config and should be updated accordingly.
pub flush_interval_sec: u64,
segments: LockedSegmentHolder,
/// Process, that listens updates signals and perform updates
update_worker: Option<JoinHandle<()>>,
/// Process, that listens for post-update signals and performs optimization
optimizer_worker: Option<JoinHandle<()>>,
/// Process that periodically flushes segments and tries to truncate wal
flush_worker: Option<JoinHandle<()>>,
/// Sender to stop flush worker
flush_stop: Option<oneshot::Sender<()>>,
runtime_handle: Handle,
/// WAL, required for operations
wal: LockedWal,
/// Always keep this WAL version and later and prevent acknowledging/truncating from the WAL.
/// This is used when other bits of code still depend on information in the WAL, such as the
/// queue proxy shard.
/// Defaults to `u64::MAX` to allow acknowledging all confirmed versions.
pub(super) wal_keep_from: Arc<AtomicU64>,
optimization_handles: Arc<TokioMutex<Vec<StoppableTaskHandle<bool>>>>,
/// Maximum number of concurrent optimization jobs in this update handler.
/// This parameter depends on the optimizer config and should be updated accordingly.
pub max_optimization_threads: Option<usize>,
/// Highest and cutoff clocks for the shard WAL.
clocks: LocalShardClocks,
shard_path: PathBuf,
/// Whether we have ever triggered optimizers since starting.
has_triggered_optimizers: Arc<AtomicBool>,
}
impl UpdateHandler {
#[allow(clippy::too_many_arguments)]
pub fn new(
shared_storage_config: Arc<SharedStorageConfig>,
payload_index_schema: Arc<SaveOnDisk<PayloadIndexSchema>>,
optimizers: Arc<Vec<Arc<Optimizer>>>,
optimizers_log: Arc<Mutex<TrackerLog>>,
total_optimized_points: Arc<AtomicUsize>,
optimizer_cpu_budget: CpuBudget,
runtime_handle: Handle,
segments: LockedSegmentHolder,
wal: LockedWal,
flush_interval_sec: u64,
max_optimization_threads: Option<usize>,
clocks: LocalShardClocks,
shard_path: PathBuf,
) -> UpdateHandler {
UpdateHandler {
shared_storage_config,
payload_index_schema,
optimizers,
segments,
update_worker: None,
optimizer_worker: None,
optimizers_log,
total_optimized_points,
optimizer_cpu_budget,
flush_worker: None,
flush_stop: None,
runtime_handle,
wal,
wal_keep_from: Arc::new(u64::MAX.into()),
flush_interval_sec,
optimization_handles: Arc::new(TokioMutex::new(vec![])),
max_optimization_threads,
clocks,
shard_path,
has_triggered_optimizers: Default::default(),
}
}
pub fn run_workers(&mut self, update_receiver: Receiver<UpdateSignal>) {
let (tx, rx) = mpsc::channel(self.shared_storage_config.update_queue_size);
self.optimizer_worker = Some(self.runtime_handle.spawn(Self::optimization_worker_fn(
self.optimizers.clone(),
tx.clone(),
rx,
self.segments.clone(),
self.wal.clone(),
self.optimization_handles.clone(),
self.optimizers_log.clone(),
self.total_optimized_points.clone(),
self.optimizer_cpu_budget.clone(),
self.max_optimization_threads,
self.has_triggered_optimizers.clone(),
self.payload_index_schema.clone(),
)));
self.update_worker = Some(self.runtime_handle.spawn(Self::update_worker_fn(
update_receiver,
tx,
self.wal.clone(),
self.segments.clone(),
)));
let (flush_tx, flush_rx) = oneshot::channel();
self.flush_worker = Some(self.runtime_handle.spawn(Self::flush_worker(
self.segments.clone(),
self.wal.clone(),
self.wal_keep_from.clone(),
self.flush_interval_sec,
flush_rx,
self.clocks.clone(),
self.shard_path.clone(),
)));
self.flush_stop = Some(flush_tx);
}
pub fn stop_flush_worker(&mut self) {
if let Some(flush_stop) = self.flush_stop.take() {
if let Err(()) = flush_stop.send(()) {
warn!("Failed to stop flush worker as it is already stopped.");
}
}
}
/// Gracefully wait before all optimizations stop
/// If some optimization is in progress - it will be finished before shutdown.
pub async fn wait_workers_stops(&mut self) -> CollectionResult<()> {
let maybe_handle = self.update_worker.take();
if let Some(handle) = maybe_handle {
handle.await?;
}
let maybe_handle = self.optimizer_worker.take();
if let Some(handle) = maybe_handle {
handle.await?;
}
let maybe_handle = self.flush_worker.take();
if let Some(handle) = maybe_handle {
handle.await?;
}
let mut opt_handles_guard = self.optimization_handles.lock().await;
let opt_handles = std::mem::take(&mut *opt_handles_guard);
let stopping_handles = opt_handles
.into_iter()
.filter_map(|h| h.stop())
.collect_vec();
for res in stopping_handles {
res.await?;
}
Ok(())
}
/// Checks if there are any failed operations.
/// If so - attempts to re-apply all failed operations.
fn try_recover(segments: LockedSegmentHolder, wal: LockedWal) -> CollectionResult<usize> {
// Try to re-apply everything starting from the first failed operation
let first_failed_operation_option = segments.read().failed_operation.iter().cloned().min();
match first_failed_operation_option {
None => {}
Some(first_failed_op) => {
let wal_lock = wal.lock();
for (op_num, operation) in wal_lock.read(first_failed_op) {
CollectionUpdater::update(&segments, op_num, operation.operation)?;
}
}
};
Ok(0)
}
/// Checks conditions for all optimizers until there is no suggested segment
/// Starts a task for each optimization
/// Returns handles for started tasks
pub(crate) fn launch_optimization<F>(
optimizers: Arc<Vec<Arc<Optimizer>>>,
optimizers_log: Arc<Mutex<TrackerLog>>,
total_optimized_points: Arc<AtomicUsize>,
optimizer_cpu_budget: &CpuBudget,
segments: LockedSegmentHolder,
callback: F,
limit: Option<usize>,
) -> Vec<StoppableTaskHandle<bool>>
where
F: FnOnce(bool) + Send + Clone + 'static,
{
let mut scheduled_segment_ids = HashSet::<_>::default();
let mut handles = vec![];
'outer: for optimizer in optimizers.iter() {
loop {
// Return early if we reached the optimization job limit
if limit.map(|extra| handles.len() >= extra).unwrap_or(false) {
log::trace!("Reached optimization job limit, postponing other optimizations");
break 'outer;
}
let nonoptimal_segment_ids =
optimizer.check_condition(segments.clone(), &scheduled_segment_ids);
if nonoptimal_segment_ids.is_empty() {
break;
}
debug!("Optimizing segments: {:?}", &nonoptimal_segment_ids);
// Determine how many CPUs we prefer for optimization task, acquire permit for it
let max_indexing_threads = optimizer.hnsw_config().max_indexing_threads;
let desired_cpus = num_rayon_threads(max_indexing_threads);
let Some(permit) = optimizer_cpu_budget.try_acquire(desired_cpus) else {
// If there is no CPU budget, break outer loop and return early
// If we have no handles (no optimizations) trigger callback so that we wake up
// our optimization worker to try again later, otherwise it could get stuck
log::trace!(
"No available CPU permit for {} optimizer, postponing",
optimizer.name(),
);
if handles.is_empty() {
callback(false);
}
break 'outer;
};
log::trace!(
"Acquired {} CPU permit for {} optimizer",
permit.num_cpus,
optimizer.name(),
);
let optimizer = optimizer.clone();
let optimizers_log = optimizers_log.clone();
let total_optimized_points = total_optimized_points.clone();
let segments = segments.clone();
let nsi = nonoptimal_segment_ids.clone();
scheduled_segment_ids.extend(&nsi);
let callback = callback.clone();
let handle = spawn_stoppable(
// Stoppable task
{
let segments = segments.clone();
move |stopped| {
// Track optimizer status
let tracker = Tracker::start(optimizer.as_ref().name(), nsi.clone());
let tracker_handle = tracker.handle();
optimizers_log.lock().register(tracker);
// Optimize and handle result
match optimizer.as_ref().optimize(
segments.clone(),
nsi,
permit,
stopped,
) {
// Perform some actions when optimization if finished
Ok(optimized_points) => {
let is_optimized = optimized_points > 0;
total_optimized_points
.fetch_add(optimized_points, Ordering::Relaxed);
tracker_handle.update(TrackerStatus::Done);
callback(is_optimized);
is_optimized
}
// Handle and report errors
Err(error) => match error {
CollectionError::Cancelled { description } => {
debug!("Optimization cancelled - {description}");
tracker_handle
.update(TrackerStatus::Cancelled(description));
false
}
_ => {
segments.write().report_optimizer_error(error.clone());
// Error of the optimization can not be handled by API user
// It is only possible to fix after full restart,
// so the best available action here is to stop whole
// optimization thread and log the error
log::error!("Optimization error: {error}");
tracker_handle
.update(TrackerStatus::Error(error.to_string()));
panic!("Optimization error: {error}");
}
},
}
}
},
// Panic handler
Some(Box::new(move |panic_payload| {
let message = panic::downcast_str(&panic_payload).unwrap_or("");
let separator = if !message.is_empty() { ": " } else { "" };
warn!(
"Optimization task panicked, collection may be in unstable state\
{separator}{message}"
);
segments
.write()
.report_optimizer_error(CollectionError::service_error(format!(
"Optimization task panicked{separator}{message}"
)));
})),
);
handles.push(handle);
}
}
handles
}
/// Ensure there is at least one appendable segment with enough capacity
///
/// If there is no appendable segment, or all are at or over capacity, a new empty one is
/// created.
///
/// Capacity is determined based on `optimizers.max_segment_size_kb`.
pub(super) fn ensure_appendable_segment_with_capacity(
segments: &LockedSegmentHolder,
segments_path: &Path,
collection_params: &CollectionParams,
thresholds_config: &OptimizerThresholds,
payload_index_schema: &PayloadIndexSchema,
) -> OperationResult<()> {
let no_segment_with_capacity = {
let segments_read = segments.read();
segments_read
.appendable_segments_ids()
.into_iter()
.filter_map(|segment_id| segments_read.get(segment_id))
.all(|segment| {
let max_vector_size_bytes = segment
.get()
.read()
.max_available_vectors_size_in_bytes()
.unwrap_or_default();
let max_segment_size_bytes = thresholds_config
.max_segment_size_kb
.saturating_mul(segment::common::BYTES_IN_KB);
max_vector_size_bytes >= max_segment_size_bytes
})
};
if no_segment_with_capacity {
log::debug!("Creating new appendable segment, all existing segments are over capacity");
segments.write().create_appendable_segment(
segments_path,
collection_params,
payload_index_schema,
)?;
}
Ok(())
}
/// Checks the optimizer conditions.
///
/// This function returns a tuple of two booleans:
/// - The first indicates if any optimizers have been triggered since startup.
/// - The second indicates if there are any pending/suboptimal optimizers.
pub(crate) fn check_optimizer_conditions(&self) -> (bool, bool) {
// Check if Qdrant triggered any optimizations since starting at all
let has_triggered_any_optimizers = self.has_triggered_optimizers.load(Ordering::Relaxed);
let excluded_ids = HashSet::<_>::default();
let has_suboptimal_optimizers = self.optimizers.iter().any(|optimizer| {
let nonoptimal_segment_ids =
optimizer.check_condition(self.segments.clone(), &excluded_ids);
!nonoptimal_segment_ids.is_empty()
});
(has_triggered_any_optimizers, has_suboptimal_optimizers)
}
#[allow(clippy::too_many_arguments)]
pub(crate) async fn process_optimization(
optimizers: Arc<Vec<Arc<Optimizer>>>,
segments: LockedSegmentHolder,
optimization_handles: Arc<TokioMutex<Vec<StoppableTaskHandle<bool>>>>,
optimizers_log: Arc<Mutex<TrackerLog>>,
total_optimized_points: Arc<AtomicUsize>,
optimizer_cpu_budget: &CpuBudget,
sender: Sender<OptimizerSignal>,
limit: usize,
) {
let mut new_handles = Self::launch_optimization(
optimizers.clone(),
optimizers_log,
total_optimized_points,
optimizer_cpu_budget,
segments.clone(),
move |_optimization_result| {
// After optimization is finished, we still need to check if there are
// some further optimizations possible.
// If receiver is already dead - we do not care.
// If channel is full - optimization will be triggered by some other signal
let _ = sender.try_send(OptimizerSignal::Nop);
},
Some(limit),
);
let mut handles = optimization_handles.lock().await;
handles.append(&mut new_handles);
}
/// Cleanup finalized optimization task handles
///
/// This finds and removes completed tasks from our list of optimization handles.
/// It also propagates any panics (and unknown errors) so we properly handle them if desired.
///
/// It is essential to call this every once in a while for handling panics in time.
///
/// Returns true if any optimization handle was finished, joined and removed.
async fn cleanup_optimization_handles(
optimization_handles: Arc<TokioMutex<Vec<StoppableTaskHandle<bool>>>>,
) -> bool {
// Remove finished handles
let finished_handles: Vec<_> = {
let mut handles = optimization_handles.lock().await;
(0..handles.len())
.filter(|i| handles[*i].is_finished())
.collect::<Vec<_>>()
.into_iter()
.rev()
.map(|i| handles.swap_remove(i))
.collect()
};
let finished_any = !finished_handles.is_empty();
// Finalize all finished handles to propagate panics
for handle in finished_handles {
handle.join_and_handle_panic().await;
}
finished_any
}
#[allow(clippy::too_many_arguments)]
async fn optimization_worker_fn(
optimizers: Arc<Vec<Arc<Optimizer>>>,
sender: Sender<OptimizerSignal>,
mut receiver: Receiver<OptimizerSignal>,
segments: LockedSegmentHolder,
wal: LockedWal,
optimization_handles: Arc<TokioMutex<Vec<StoppableTaskHandle<bool>>>>,
optimizers_log: Arc<Mutex<TrackerLog>>,
total_optimized_points: Arc<AtomicUsize>,
optimizer_cpu_budget: CpuBudget,
max_handles: Option<usize>,
has_triggered_optimizers: Arc<AtomicBool>,
payload_index_schema: Arc<SaveOnDisk<PayloadIndexSchema>>,
) {
let max_handles = max_handles.unwrap_or(usize::MAX);
let max_indexing_threads = optimizers
.first()
.map(|optimizer| optimizer.hnsw_config().max_indexing_threads)
.unwrap_or_default();
// Asynchronous task to trigger optimizers once CPU budget is available again
let mut cpu_available_trigger: Option<JoinHandle<()>> = None;
loop {
let result = timeout(OPTIMIZER_CLEANUP_INTERVAL, receiver.recv()).await;
let cleaned_any =
Self::cleanup_optimization_handles(optimization_handles.clone()).await;
// Either continue below here with the worker, or reloop/break
// Decision logic doing one of three things:
// 1. run optimizers
// 2. reloop and wait for next signal
// 3. break here and stop the optimization worker
let ignore_max_handles = match result {
// Regular optimizer signal: run optimizers: do 1
Ok(Some(OptimizerSignal::Operation(_))) => false,
// Optimizer signal ignoring max handles: do 1
Ok(Some(OptimizerSignal::Nop)) => true,
// Hit optimizer cleanup interval, did clean up a task: do 1
Err(Elapsed { .. }) if cleaned_any => {
// This branch prevents a race condition where optimizers would get stuck
// If the optimizer cleanup interval was triggered and we did clean any task we
// must run optimizers now. If we don't there may not be any other ongoing
// tasks that'll trigger this for us. If we don't run optimizers here we might
// get stuck into yellow state until a new update operation is received.
// See: <https://github.com/qdrant/qdrant/pull/5111>
log::warn!("Cleaned a optimization handle after timeout, explicitly triggering optimizers");
true
}
// Hit optimizer cleanup interval, did not clean up a task: do 2
Err(Elapsed { .. }) => continue,
// Channel closed or received stop signal: do 3
Ok(None | Some(OptimizerSignal::Stop)) => break,
};
has_triggered_optimizers.store(true, Ordering::Relaxed);
// Ensure we have at least one appendable segment with enough capacity
// Source required parameters from first optimizer
if let Some(optimizer) = optimizers.first() {
let result = Self::ensure_appendable_segment_with_capacity(
&segments,
optimizer.segments_path(),
&optimizer.collection_params(),
optimizer.threshold_config(),
&payload_index_schema.read(),
);
if let Err(err) = result {
log::error!(
"Failed to ensure there are appendable segments with capacity: {err}"
);
panic!("Failed to ensure there are appendable segments with capacity: {err}");
}
}
// If not forcing, wait on next signal if we have too many handles
if !ignore_max_handles && optimization_handles.lock().await.len() >= max_handles {
continue;
}
if Self::try_recover(segments.clone(), wal.clone()).is_err() {
continue;
}
// Continue if we have enough CPU budget available to start an optimization
// Otherwise skip now and start a task to trigger the optimizer again once CPU
// budget becomes available
let desired_cpus = num_rayon_threads(max_indexing_threads);
if !optimizer_cpu_budget.has_budget(desired_cpus) {
let trigger_active = cpu_available_trigger
.as_ref()
.map_or(false, |t| !t.is_finished());
if !trigger_active {
cpu_available_trigger.replace(trigger_optimizers_on_cpu_budget(
optimizer_cpu_budget.clone(),
desired_cpus,
sender.clone(),
));
}
continue;
}
// Determine optimization handle limit based on max handles we allow
// Not related to the CPU budget, but a different limit for the maximum number
// of concurrent concrete optimizations per shard as configured by the user in
// the Qdrant configuration.
// Skip if we reached limit, an ongoing optimization that finishes will trigger this loop again
let limit = max_handles.saturating_sub(optimization_handles.lock().await.len());
if limit == 0 {
log::trace!("Skipping optimization check, we reached optimization thread limit");
continue;
}
Self::process_optimization(
optimizers.clone(),
segments.clone(),
optimization_handles.clone(),
optimizers_log.clone(),
total_optimized_points.clone(),
&optimizer_cpu_budget,
sender.clone(),
limit,
)
.await;
}
}
async fn update_worker_fn(
mut receiver: Receiver<UpdateSignal>,
optimize_sender: Sender<OptimizerSignal>,
wal: LockedWal,
segments: LockedSegmentHolder,
) {
while let Some(signal) = receiver.recv().await {
match signal {
UpdateSignal::Operation(OperationData {
op_num,
operation,
sender,
wait,
}) => {
let flush_res = if wait {
wal.lock().flush().map_err(|err| {
CollectionError::service_error(format!(
"Can't flush WAL before operation {op_num} - {err}"
))
})
} else {
Ok(())
};
let operation_result = flush_res
.and_then(|_| CollectionUpdater::update(&segments, op_num, operation));
let res = match operation_result {
Ok(update_res) => optimize_sender
.send(OptimizerSignal::Operation(op_num))
.await
.and(Ok(update_res))
.map_err(|send_err| send_err.into()),
Err(err) => Err(err),
};
if let Some(feedback) = sender {
feedback.send(res).unwrap_or_else(|_| {
debug!("Can't report operation {op_num} result. Assume already not required");
});
};
}
UpdateSignal::Stop => {
optimize_sender
.send(OptimizerSignal::Stop)
.await
.unwrap_or_else(|_| debug!("Optimizer already stopped"));
break;
}
UpdateSignal::Nop => optimize_sender
.send(OptimizerSignal::Nop)
.await
.unwrap_or_else(|_| {
info!(
"Can't notify optimizers, assume process is dead. Restart is required"
);
}),
UpdateSignal::Plunger(callback_sender) => {
callback_sender.send(()).unwrap_or_else(|_| {
debug!("Can't notify sender, assume nobody is waiting anymore");
});
}
}
}
// Transmitter was destroyed
optimize_sender
.send(OptimizerSignal::Stop)
.await
.unwrap_or_else(|_| debug!("Optimizer already stopped"));
}
async fn flush_worker(
segments: LockedSegmentHolder,
wal: LockedWal,
wal_keep_from: Arc<AtomicU64>,
flush_interval_sec: u64,
mut stop_receiver: oneshot::Receiver<()>,
clocks: LocalShardClocks,
shard_path: PathBuf,
) {
loop {
// Stop flush worker on signal or if sender was dropped
// Even if timer did not finish
tokio::select! {
_ = tokio::time::sleep(Duration::from_secs(flush_interval_sec)) => {},
_ = &mut stop_receiver => {
debug!("Stopping flush worker.");
return;
}
}
trace!("Attempting flushing");
let wal_flash_job = wal.lock().flush_async();
if let Err(err) = wal_flash_job.join() {
error!("Failed to flush wal: {:?}", err);
segments
.write()
.report_optimizer_error(WalError::WriteWalError(format!(
"WAL flush error: {err:?}"
)));
continue;
}
let confirmed_version = Self::flush_segments(segments.clone());
let confirmed_version = match confirmed_version {
Ok(version) => version,
Err(err) => {
error!("Failed to flush: {err}");
segments.write().report_optimizer_error(err);
continue;
}
};
// Acknowledge confirmed version in WAL, but don't acknowledge the specified
// `keep_from` index or higher.
// This is to prevent truncating WAL entries that other bits of code still depend on
// such as the queue proxy shard.
// Default keep_from is `u64::MAX` to allow acknowledging all confirmed.
let keep_from = wal_keep_from.load(std::sync::atomic::Ordering::Relaxed);
// If we should keep the first message, do not acknowledge at all
if keep_from == 0 {
continue;
}
let ack = confirmed_version.min(keep_from.saturating_sub(1));
if let Err(err) = clocks.store_if_changed(&shard_path).await {
log::warn!("Failed to store clock maps to disk: {err}");
segments.write().report_optimizer_error(err);
}
if let Err(err) = wal.lock().ack(ack) {
log::warn!("Failed to acknowledge WAL version: {err}");
segments.write().report_optimizer_error(err);
}
}
}
/// Returns confirmed version after flush of all segments
///
/// # Errors
/// Returns an error on flush failure
fn flush_segments(segments: LockedSegmentHolder) -> OperationResult<SeqNumberType> {
let read_segments = segments.read();
let flushed_version = read_segments.flush_all(false, false)?;
Ok(match read_segments.failed_operation.iter().cloned().min() {
None => flushed_version,
Some(failed_operation) => min(failed_operation, flushed_version),
})
}
}
/// Trigger optimizers when CPU budget is available
fn trigger_optimizers_on_cpu_budget(
optimizer_cpu_budget: CpuBudget,
desired_cpus: usize,
sender: Sender<OptimizerSignal>,
) -> JoinHandle<()> {
task::spawn(async move {
log::trace!("Skipping optimization checks, waiting for CPU budget to be available");
optimizer_cpu_budget
.notify_on_budget_available(desired_cpus)
.await;
log::trace!("Continue optimization checks, new CPU budget available");
// Trigger optimizers with Nop operation
sender.send(OptimizerSignal::Nop).await.unwrap_or_else(|_| {
log::info!("Can't notify optimizers, assume process is dead. Restart is required")
});
})
}
|