iterate instead of sum

triplet_margin_loss.py

@@ -88,9 +88,9 @@ class TripletMarginLoss(evaluate.EvaluationModule):
             inputs_description=_KWARGS_DESCRIPTION,
             features=datasets.Features(
                 {
-                    "anchor": datasets.Value("float"),
-                    "positive": datasets.Value("float"),
-                    "negative": datasets.Value("float"),
+                    "anchor": datasets.Sequence(datasets.Value("float", id="references")),
+                    "positive": datasets.Sequence(datasets.Value("float"), id="sequence"),
+                    "negative": datasets.Sequence(datasets.Value("float"), id="sequence"),
                     "margin": datasets.Value("float")
                 }
             ),
@@ -98,10 +98,13 @@ class TripletMarginLoss(evaluate.EvaluationModule):
         )
 
     def _compute(self, anchor, positive, negative, margin=1.0):
-        d_a_p = np.sqrt(sum((anchor - positive)**2))
-        d_a_n = np.sqrt(sum((anchor - negative)**2))
+        d_a_p_sum = 0.0
+        d_a_n_sum = 0.0
+        for a, p, n in zip(anchor, positive, negative):
+            d_a_p_sum += (a - p)**2
+            d_a_n_sum += (a - n)**2
         return {
             "accuracy": float(
-                max(d_a_p - d_a_n + margin, 0)
+                max(np.sqrt(d_a_p_sum) - np.sqrt(d_a_n_sum) + margin, 0)
             )
         }