Update app.py

app.py

@@ -101,7 +101,7 @@ def update_index_file(new_metadata_path):
         if os.path.exists(temp_dir):
             shutil.rmtree(temp_dir)
 
-def generate_subtitles(video_path):
+def create_subtitles(video_path):  # Renamed from generate_subtitles
     with tempfile.NamedTemporaryFile(suffix='.mp3', delete=False) as temp_audio:
         # Convert video to mono 128kbps MP3
         audio = AudioSegment.from_file(video_path)
@@ -129,9 +129,10 @@ def generate_subtitles(video_path):
         
         vtt_content += f"{start_time_vtt} --> {end_time_vtt}\n{text}\n\n"
     
+    os.unlink(temp_audio.name)  # Clean up temp file
     return vtt_content
 
-def upload_video_to_hf(video_file, original_video_name, title, description, uploader, generate_subs=False, custom_thumbnail=None):
+def upload_video_to_hf(video_file, original_video_name, title, description, uploader, should_generate_subs=False, custom_thumbnail=None):  # Renamed parameter
     temp_dir = "temp"
     if not os.path.exists(temp_dir):
         os.makedirs(temp_dir)
@@ -163,21 +164,24 @@ def upload_video_to_hf(video_file, original_video_name, title, description, uplo
         
         # Generate and upload subtitles if requested and video is not too long
         subtitle_location = ""
-        if generate_subs and video_length <= 3600:  # 1 hour in seconds
-            vtt_content = generate_subtitles(video_path)
-            subtitle_name = f"{base_name}.vtt"
-            subtitle_path = os.path.join(temp_dir, subtitle_name)
-            
-            with open(subtitle_path, 'w') as f:
-                f.write(vtt_content)
-            
-            subtitle_location = f"subtitles/{subtitle_name}"
-            hf_api.upload_file(
-                path_or_fileobj=subtitle_path,
-                path_in_repo=subtitle_location,
-                repo_id="vericudebuget/ok4231",
-                repo_type="space",
-            )
+        if should_generate_subs and video_length <= 3600:  # 1 hour in seconds
+            try:
+                vtt_content = create_subtitles(video_path)  # Using renamed function
+                subtitle_name = f"{base_name}.vtt"
+                subtitle_path = os.path.join(temp_dir, subtitle_name)
+                
+                with open(subtitle_path, 'w') as f:
+                    f.write(vtt_content)
+                
+                subtitle_location = f"subtitles/{subtitle_name}"
+                hf_api.upload_file(
+                    path_or_fileobj=subtitle_path,
+                    path_in_repo=subtitle_location,
+                    repo_id="vericudebuget/ok4231",
+                    repo_type="space",
+                )
+            except Exception as e:
+                st.warning(f"Failed to generate subtitles: {str(e)}")
 
         # Upload video and thumbnail
         video_location = f"videos/{video_name}"
@@ -237,8 +241,8 @@ if uploaded_video:
         os.unlink(temp_video.name)  # Clean up temp file
         
         # Subtitle generation toggle, disabled if video is longer than 1 hour
-        generate_subtitles = st.toggle("Generate Subtitles", disabled=video_duration > 3600)
-        if video_duration > 3600 and generate_subtitles:
+        should_generate_subs = st.toggle("Generate Subtitles", disabled=video_duration > 3600, value=True)  # Renamed variable
+        if video_duration > 3600 and should_generate_subs:
             st.warning("Subtitle generation is disabled for videos longer than 1 hour.")
         
         custom_thumbnail = st.file_uploader("Upload custom thumbnail (optional)", type=["jpg", "jpeg", "png"])
@@ -256,7 +260,7 @@ if uploaded_video:
                         title, 
                         description, 
                         uploader,
-                        generate_subtitles,
+                        should_generate_subs,  # Using renamed variable
                         custom_thumbnail
                     )
                     if metadata: