Update app.py

app.py

@@ -39,9 +39,9 @@ def add_subtitle(video):
         video_path = video if isinstance(video, str) else None
         if not video_path:
             return "No video provided!"
-        
-        video = mp.VideoFileClip(video_path)
-        audio = video.audio
+
+        video_clip = mp.VideoFileClip(video_path)
+        audio = video_clip.audio
 
         # Use a temporary file for audio extraction
         with tempfile.NamedTemporaryFile(delete=True, suffix='.wav') as tmp_audio_file:
@@ -51,7 +51,11 @@ def add_subtitle(video):
             # Transcribe in chunks (parallel)
             chunk_duration = 15  # seconds
             chunk_size = sr * chunk_duration
-            chunks = [waveform[i:i + chunk_size] for i in range(0, len(waveform), chunk_size) if len(waveform[i:i + chunk_size]) > 0]
+            chunks = [
+                waveform[i:i + chunk_size]
+                for i in range(0, len(waveform), chunk_size)
+                if len(waveform[i:i + chunk_size]) > 0
+            ]
 
             with ThreadPoolExecutor() as executor:
                 transcriptions = list(executor.map(transcribe_audio, chunks))
@@ -59,7 +63,7 @@ def add_subtitle(video):
             full_transcription = " ".join(transcriptions)
             subtitle_storage["original"] = full_transcription  # Store the original subtitle
             subtitle_storage["video_path"] = video_path  # Store the video path
-            
+
         return f"Subtitle added: {full_transcription[:100]}..."  # Display first 100 characters
 
     except Exception as e:
@@ -71,18 +75,18 @@ def translate_subtitle(video, language):
         original_subtitle = subtitle_storage.get("original")
         if not original_subtitle:
             return "No subtitle to translate!"
-        
+
         # Translate using the selected language
         translated_subtitle = translator(
-            original_subtitle, 
+            original_subtitle,
             src_lang="en",  # Source language (assuming the subtitle is in English)
             tgt_lang=languages[language]  # Get the language code from the dropdown selection
         )[0]["translation_text"]
 
         subtitle_storage["translated"] = translated_subtitle  # Store the translated subtitle
-        
+
         return f"Subtitle translated to {language} successfully!"
-    
+
     except Exception as e:
         return f"Error in translating subtitle: {e}"
 
@@ -92,25 +96,26 @@ def download_word():
         translated_subtitle = subtitle_storage.get("translated")
         if not translated_subtitle:
             return "No translated subtitle to save!"
-        
+
         # Prepare the document
         doc = docx.Document()
         doc.add_heading('Translated Subtitles', 0)
-        
+
         # Create timestamps and subtitles
-        for i in range(0, len(translated_subtitle), 50):
-            start_time = (i // 50) * 5  # Each subtitle lasts for 5 seconds
-            subtitle_text = translated_subtitle[i:i + 50]  # Get the next 50 characters
-            
+        for i in range(0, len(translated_subtitle), 40):  # Adjusted chunk size
+            start_time = (i // 40) * 2.5  # Each subtitle lasts for 2.5 seconds
+            subtitle_text = translated_subtitle[i:i + 40].strip()  # Get the next 40 characters
+
             # Add a formatted string with timestamp and subtitle to the document
-            doc.add_paragraph(f"{start_time}s - {subtitle_text}")
-        
+            if subtitle_text:
+                doc.add_paragraph(f"{start_time:.3f}s - {subtitle_text}")
+
         file_path = "translated_subtitles.docx"
         doc.save(file_path)
 
         # Return the file for download
-        return file_path  # Return the file path to allow Gradio to serve it as a downloadable file
-    
+        return file_path  # Gradio will handle this as a downloadable file
+
     except Exception as e:
         return f"Error in saving subtitles as Word: {e}"
 
@@ -132,12 +137,15 @@ def download_video():
         # Generate subtitles (each subtitle will last for 2.5 seconds with millisecond precision)
         subs = []
         subtitle_length = 2.5  # seconds each subtitle will be displayed
-        for i in range(0, len(translated_subtitle), 40):  # Reduce chunk size to improve reliability
-            start_time = (i // 40) * subtitle_length  # Get start time with more precision
-            subtitle_text = translated_subtitle[i:i + 40]  # Get the next 40 characters
-            subs.append((start_time, subtitle_text))  # Create a tuple for start time and text
+        for i in range(0, len(translated_subtitle), 40):  # Reduced chunk size for better handling
+            start_time = (i // 40) * subtitle_length
+            end_time = start_time + subtitle_length
+            subtitle_text = translated_subtitle[i:i + 40].strip()  # Get the next 40 characters
+
+            if subtitle_text:
+                subs.append((start_time, end_time, subtitle_text))  # Create a tuple for start time, end time, and text
 
-        # Debugging log
+        # Debugging: Print the generated subtitles
         print("Generated subtitles:", subs)
 
         # Create subtitle clips
@@ -150,8 +158,8 @@ def download_video():
         subtitled_video.write_videofile(output_video_path, codec='libx264')  # Use libx264 for better compatibility
 
         # Return the file path for download
-        return output_video_path
-    
+        return output_video_path  # Gradio will handle this as a downloadable file
+
     except Exception as e:
         return f"Error in generating subtitled video: {e}"
 
@@ -159,42 +167,42 @@ def download_video():
 with gr.Blocks() as demo:
     # Title
     gr.Markdown("<h1 style='text-align: center;'>Video Subtitle Translator</h1>")
-    
+
     # Video Upload
     with gr.Row():
         video_input = gr.Video(label="Upload Video")
         upload_button = gr.Button("Upload Video")
         upload_status = gr.Textbox(label="Upload Status")
-    
+
     upload_button.click(add_subtitle, inputs=video_input, outputs=upload_status)
-    
+
     # Add Subtitle
     with gr.Row():
         add_subtitle_button = gr.Button("Add Subtitle")
         subtitle_status = gr.Textbox(label="Subtitle Status")
-    
+
     add_subtitle_button.click(add_subtitle, inputs=video_input, outputs=subtitle_status)
-    
+
     # Translate Subtitle
     with gr.Row():
         language_dropdown = gr.Dropdown(choices=list(languages.keys()), label="Choose Target Language", value="Persian")
         translate_button = gr.Button("Translate Subtitle")
         translate_status = gr.Textbox(label="Translation Status")
-    
+
     translate_button.click(translate_subtitle, inputs=[video_input, language_dropdown], outputs=translate_status)
-    
+
     # Download as Word
     with gr.Row():
         download_button = gr.Button("Download as Word")
         download_status = gr.File(label="Download Translated Word File")  # File output for Word download
-    
+
     download_button.click(download_word, inputs=None, outputs=download_status)
-    
+
     # Download Subtitled Video
     with gr.Row():
         download_video_button = gr.Button("Download Subtitled Video")
         download_video_status = gr.File(label="Download Subtitled Video")  # File output for Video download
-    
+
     download_video_button.click(download_video, inputs=None, outputs=download_video_status)
 
 # Launch the Gradio app