Datasets:
DanCip
/
github-issues-negatives

Dataset card Data Studio Files Community
issue_owner_repo
listlengths
2
2
issue_body
stringlengths
0
261k
⌀
issue_title
stringlengths
1
925
issue_comments_url
stringlengths
56
81
issue_comments_count
int64
0
2.5k
issue_created_at
stringlengths
20
20
issue_updated_at
stringlengths
20
20
issue_html_url
stringlengths
37
62
issue_github_id
int64
387k
2.46B
issue_number
int64
1
127k
[ "Piwigo", "Piwigo" ]
With: - #567 icon on button - font-icons for checkboxes - #554 tab on all admin pages - #528 less borders
modernize menubar manager
https://api.github.com/repos/Piwigo/Piwigo/issues/587/comments
0
2016-12-22T10:08:19Z
2016-12-22T10:11:37Z
https://github.com/Piwigo/Piwigo/issues/587
197,138,393
587
[ "Piwigo", "Piwigo" ]
Hello, I cannot login on a fresh installation and on an older one I have a lot of problems regarding this error. With other application (like wordpress or others) there are no errors. So the problem must be in the piwigo. I am not a php-crack therefore I ask here to get help. Error: Warning: session_start(): Failed to read session data: user (path: ) in ..... include\common.inc.php on line 149 The same is with a fresh piwigo 2.9b installation on line 156 - and there I cannot login. kind regards mcinternet
Piwigo 2.8.3 session_start() - error with PHP 7.1 on Windows Server 2016 (IIS10)
https://api.github.com/repos/Piwigo/Piwigo/issues/586/comments
8
2016-12-21T15:00:13Z
2017-03-30T13:34:39Z
https://github.com/Piwigo/Piwigo/issues/586
196,953,306
586
[ "Piwigo", "Piwigo" ]
Too much contrast on this box. ![dark-theme-watermark-position-box](https://cloud.githubusercontent.com/assets/9326959/21390854/3a43bb9c-c789-11e6-818c-ab2cb6828e9e.png)
admin dark theme, watermark position box too clear
https://api.github.com/repos/Piwigo/Piwigo/issues/585/comments
0
2016-12-21T13:24:51Z
2016-12-21T13:25:51Z
https://github.com/Piwigo/Piwigo/issues/585
196,932,011
585
[ "Piwigo", "Piwigo" ]
on admin.php?page=photo-1234 if photo 1234 does not exists, you get: ``` Piwigo encountered an unrecoverable error. [mysql error 1064] You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 3 SELECT username AS username FROM piwigo_users WHERE id = ; #1 my_error include/dblayer/functions_mysqli.inc.php(147) #2 pwg_query admin/picture_modify.php(282) #3 include admin/photo.php(74) #4 include admin.php(302) ```
editing missing photo leads to unexpected error
https://api.github.com/repos/Piwigo/Piwigo/issues/584/comments
0
2016-12-21T13:01:30Z
2016-12-21T13:02:40Z
https://github.com/Piwigo/Piwigo/issues/584
196,927,447
584
[ "Piwigo", "Piwigo" ]
I've just lived a very bad experience with upgrade of another web application (let's call it webApp), but it could have happened to Piwigo too! I'm using PHP 5.4 on this environement. The requirement for WebApp 2.16.5 was PHP version 5.3 and WebApp proposed me to upgrade to version 2.17. I agreed and the upgrade started. Unfortunately, WebApp 2.17 now requires PHP 5.5. My installation of WebApp is frozen. We should implement a "pre-upgrade" check. On PHP and MySQL versions at least.
check requirement before upgrade Piwigo
https://api.github.com/repos/Piwigo/Piwigo/issues/583/comments
0
2016-12-20T12:48:27Z
2020-11-04T16:43:23Z
https://github.com/Piwigo/Piwigo/issues/583
196,664,651
583
[ "Piwigo", "Piwigo" ]
Hello how Can I reset my admin password ? I have tried with md5 translation go to mysite/admin.php I am redirected to identification.php but my credentials don't work. Help please
impossible to log on as admin
https://api.github.com/repos/Piwigo/Piwigo/issues/580/comments
4
2016-12-19T12:34:33Z
2019-01-14T11:41:20Z
https://github.com/Piwigo/Piwigo/issues/580
196,403,547
580
[ "Piwigo", "Piwigo" ]
Hi, First of all, sorry for my english. I tag all my pictures with the name of people. I often have pictures with a group of people so I can't see them on the batch manager without zooming because batch manager only displays thumbnails. It will be very very helpful for me if I can choose in batch manager the size of the pictures to display, just like we can already do when visiting an album. Thanks to consider my request.
Choose picture size in Batch Manager
https://api.github.com/repos/Piwigo/Piwigo/issues/579/comments
10
2016-12-19T10:40:28Z
2024-07-19T15:31:33Z
https://github.com/Piwigo/Piwigo/issues/579
196,381,727
579
[ "Piwigo", "Piwigo" ]
In Piwigo/install.php: 120: $filename = PHPWG_ROOT_PATH . $conf['data_location'] . 'pwg_' . $_GET['dl']; 127: unlink($filename); As you can see, unlink() is being used to with a usercontrolled parameter dl, one can use path manipulation techniques like /../ and refer to files and get them removed by unlink(). this isn't as critical as the install.php file gets removed after install, it is when it isn't. Thanks,
File Manipulation
https://api.github.com/repos/Piwigo/Piwigo/issues/578/comments
3
2016-12-18T23:48:51Z
2016-12-20T13:55:18Z
https://github.com/Piwigo/Piwigo/issues/578
196,307,930
578
[ "Piwigo", "Piwigo" ]
In Piwigo/admin/theme.php: ``` 44: $filename = PHPWG_THEMES_PATH . $_GET['theme'] . '/admin/admin.inc.php'; 47: include_once ($filename); ``` As you can see, a user-controlled variable theme is being used in an include call. this could be used for Remote Code Execution in older PHP versions where attacker can specify %00 (nullbytes) to make php ignore the following part (/admin/admin.inc.php) Thanks
File Inclusion #3
https://api.github.com/repos/Piwigo/Piwigo/issues/577/comments
2
2016-12-18T23:44:33Z
2016-12-19T14:24:33Z
https://github.com/Piwigo/Piwigo/issues/577
196,307,673
577
[ "Piwigo", "Piwigo" ]
In Piwigo/admin/site_update.php ``` 46: $site_id = $_GET['site']; 55: die ('site ' . $site_id . ' does not exist'); ``` Unsanitized GET paramenter site is being sent to die() without no santization Fix: use htmlentities(); Thanks,
Cross Site Scirpting #2
https://api.github.com/repos/Piwigo/Piwigo/issues/576/comments
3
2016-12-18T23:42:44Z
2016-12-20T14:25:11Z
https://github.com/Piwigo/Piwigo/issues/576
196,307,554
576
[ "Piwigo", "Piwigo" ]
In Piwigo/admin/plugin.php ``` 32: $sections = explode('/', $_GET['section']); 59: $filename = PHPWG_PLUGINS_PATH . implode('/', $sections); 66: die ('Missing file ' . $filename); ``` As you can see a user-controlled input $_GET['section'] ($filename) is being sent to die() - printing out without no sanitization, this could result in cross-site scripting because die() prints out content just like echo() before exit. Fix: do htmlentities($filename);
Cross Site Scripting
https://api.github.com/repos/Piwigo/Piwigo/issues/575/comments
3
2016-12-18T23:40:33Z
2018-01-15T10:46:39Z
https://github.com/Piwigo/Piwigo/issues/575
196,307,456
575
[ "Piwigo", "Piwigo" ]
In Piwigo/admin/plugin.php ``` 32: $sections = explode('/', $_GET['section']); 59: $filename = PHPWG_PLUGINS_PATH . implode('/', $sections); 60: if(is_file($filename)) 62: include_once ($filename); ``` As you can see, a user-controlled variable is being sent stright to include_once(). a person who managed to upload a .jpg file or any other content with PHP paylaod will just need to refer to that location and include_once() will execute it, making a code execution possible.
File Inclusion with Possible RCE
https://api.github.com/repos/Piwigo/Piwigo/issues/574/comments
5
2016-12-18T23:38:12Z
2018-01-15T10:46:53Z
https://github.com/Piwigo/Piwigo/issues/574
196,307,361
574
[ "Piwigo", "Piwigo" ]
There is a File Inclusion attack in the file Piwigo/admin/languages.php ``` 34: $page['tab'] = $_GET['tab']; // 46: include (PHPWG_ROOT_PATH . 'admin/languages_' . $page['tab'] . '.php'); // languages_installed.php ``` A user controlled variable is being sent straight to include(), this should have checks for allowed strings before that. Thanks,
File Inclusion Attack #2
https://api.github.com/repos/Piwigo/Piwigo/issues/573/comments
1
2016-12-18T23:32:41Z
2018-01-15T10:47:02Z
https://github.com/Piwigo/Piwigo/issues/573
196,307,061
573
[ "Piwigo", "Piwigo" ]
Hello, There is a File Inclusion attack in the file Piwigo/admin/batch_manager.php It does: ``` 600: $page['tab'] = 'global'; // if(isset($_GET)) else , 596: $page['tab'] = $_GET['mode']; 768: include (PHPWG_ROOT_PATH . 'admin/batch_manager_' . $page['tab'] . '.php'); // batch_manager_global.php ``` The user controlled variable $page['tab'] is being sent to an include() without no checks. this will create file inclusion attacks possible. in older php versions, using a nullbyte attack, a code execution is also possible. Fix: put an array of allowed strings. Thanks,
File Inclusion Attack
https://api.github.com/repos/Piwigo/Piwigo/issues/572/comments
2
2016-12-18T23:29:28Z
2018-01-15T10:47:14Z
https://github.com/Piwigo/Piwigo/issues/572
196,306,879
572
[ "Piwigo", "Piwigo" ]
on version 2.9.0beta1 When you have an album with all photos also associated to other albums. ![piwigo-29b1-delete-album-irrelevant-option](https://cloud.githubusercontent.com/assets/9326959/21286495/e9c87814-c455-11e6-9857-c8430e0abf10.png)
irrelevant option for album deletion
https://api.github.com/repos/Piwigo/Piwigo/issues/571/comments
0
2016-12-17T11:40:06Z
2017-03-30T13:49:55Z
https://github.com/Piwigo/Piwigo/issues/571
196,217,762
571
[ "Piwigo", "Piwigo" ]
With white background fields, more padding, thicker border but clearer.
admin theme clear, modernize text fields
https://api.github.com/repos/Piwigo/Piwigo/issues/569/comments
0
2016-12-15T11:34:24Z
2016-12-16T14:40:49Z
https://github.com/Piwigo/Piwigo/issues/569
195,783,180
569
[ "Piwigo", "Piwigo" ]
Give a try to new fieldset/legend
admin theme clear, modernize Batch Manager
https://api.github.com/repos/Piwigo/Piwigo/issues/568/comments
0
2016-12-15T11:30:39Z
2016-12-15T11:32:29Z
https://github.com/Piwigo/Piwigo/issues/568
195,782,448
568
[ "Piwigo", "Piwigo" ]
Make them square, with more padding, with icon if relevant.
admin theme clear, modernize buttons
https://api.github.com/repos/Piwigo/Piwigo/issues/567/comments
0
2016-12-15T11:06:08Z
2016-12-16T14:40:49Z
https://github.com/Piwigo/Piwigo/issues/567
195,777,294
567
[ "Piwigo", "Piwigo" ]
Mainly 2 things: 1. make them "full pink" on hover, instead of turning them gray (which is quite a non sense for me) 2. make them more "square" than "rectangle" by reducing the left/right padding
modernize submit buttons on dark admin theme
https://api.github.com/repos/Piwigo/Piwigo/issues/566/comments
0
2016-12-12T15:27:43Z
2016-12-12T15:29:40Z
https://github.com/Piwigo/Piwigo/issues/566
195,002,598
566
[ "Piwigo", "Piwigo" ]
Instead of the browser standard checkboxes, which are not customizable and especially ugly on dark admin theme.
[batch manager] use font-icons for photo checkboxes
https://api.github.com/repos/Piwigo/Piwigo/issues/565/comments
0
2016-12-12T14:30:16Z
2016-12-12T14:54:32Z
https://github.com/Piwigo/Piwigo/issues/565
194,988,150
565
[ "Piwigo", "Piwigo" ]
hello the netinstaller is not setting the File and directory right on the installation prozess. so first Piwigo is only halfway working till you got this problem have a nice day vinc
Netinstaller not setting correct file directory right
https://api.github.com/repos/Piwigo/Piwigo/issues/564/comments
0
2016-12-07T16:56:37Z
2016-12-07T16:56:37Z
https://github.com/Piwigo/Piwigo/issues/564
194,105,224
564
[ "Piwigo", "Piwigo" ]
On Batch Manager, search filter, after some user reports of unexpected results, I made a few tests: ``` filesize:<0.150m => 1024*filesize <1149999 filesize:0.15m..0.8m => 1024*filesize >=150000 AND 1024*filesize <=1799999 filesize:>0.8m => 1024*filesize >800000 filesize:<150k => 1024*filesize <150999 filesize:150k..800k => 1024*filesize >=150000 AND 1024*filesize <=800999 filesize:>800k => 1024*filesize >800000 ``` The range lower limit seems fine in every case. The upper limit on the other side is quite "unexpected" :-/ Converting 0.8m to 1799999 (nearly 1.8MB) is a bit too much :-) As far as I imagine, the "k" or "m" notation can only apply to the filesize. The filesize is stored in kB in the data base, so why should we multiply the images.filesize by 1024 and add 999 if it's in kB or 999999 if it's in mB? If we simply remove the `if ($i) $val += 999;` (or `if ($i) $val += 999999;` if in mB), then we get : ``` filesize:<0.150m => 1024*filesize <150000 filesize:0.15m..0.8m => 1024*filesize >=150000 AND 1024*filesize <=800000 filesize:>0.8m => 1024*filesize >800000 filesize:<150k => 1024*filesize <150000 filesize:150k..800k => 1024*filesize >=150000 AND 1024*filesize <=800000 filesize:>800k => 1024*filesize >800000 ``` which sounds more accurate to me.
search filter, wrong limits on upper range limit
https://api.github.com/repos/Piwigo/Piwigo/issues/563/comments
5
2016-12-07T13:45:36Z
2016-12-09T21:02:32Z
https://github.com/Piwigo/Piwigo/issues/563
194,053,213
563
[ "Piwigo", "Piwigo" ]
Just like we can use <label class="font-checkbox"> for checkbox, that display a vector icon instead of the "widget" displayed by each web browser, we need on that works with radio buttons as well. Current (Piwigo 2.8) code in admin/themes/default/js/common.js was designed to work with radio, but I haven't been able to make it work.
radio button font-icons
https://api.github.com/repos/Piwigo/Piwigo/issues/561/comments
0
2016-12-02T13:40:10Z
2016-12-02T13:42:35Z
https://github.com/Piwigo/Piwigo/issues/561
193,118,437
561
[ "Piwigo", "Piwigo" ]
when a theme cannot be activated due to its missing parent theme, a tooltip should be displayed but a typo type bug prevent its display
No tooltip for activating themes without parent
https://api.github.com/repos/Piwigo/Piwigo/issues/560/comments
0
2016-12-02T10:44:55Z
2016-12-02T10:46:13Z
https://github.com/Piwigo/Piwigo/issues/560
193,085,985
560
[ "Piwigo", "Piwigo" ]
We need to sanitize search criteria used in quick search before displaying on search_rules.php page. Reported by @BlueTower
[security] quick search and criteria display
https://api.github.com/repos/Piwigo/Piwigo/issues/559/comments
6
2016-11-29T13:38:51Z
2018-02-21T16:01:25Z
https://github.com/Piwigo/Piwigo/issues/559
192,284,010
559
[ "Piwigo", "Piwigo" ]
avoid having the "show info" icon and the checkbox at the same time. I feel it confusing.
[tag manager] selection mode
https://api.github.com/repos/Piwigo/Piwigo/issues/558/comments
0
2016-11-29T12:25:51Z
2016-11-29T12:38:35Z
https://github.com/Piwigo/Piwigo/issues/558
192,268,215
558
[ "Piwigo", "Piwigo" ]
just like we do for users/groups/albums
[tag manager] show tag creation form only on demand
https://api.github.com/repos/Piwigo/Piwigo/issues/557/comments
0
2016-11-29T10:01:54Z
2016-11-29T12:38:35Z
https://github.com/Piwigo/Piwigo/issues/557
192,237,198
557
[ "Piwigo", "Piwigo" ]
... and only if at least one tag is selected. Just like we do for user manager, group manager or photo batch manager.
[tag manager] display actions in a list
https://api.github.com/repos/Piwigo/Piwigo/issues/556/comments
0
2016-11-28T12:40:34Z
2016-11-29T12:38:35Z
https://github.com/Piwigo/Piwigo/issues/556
191,996,281
556
[ "Piwigo", "Piwigo" ]
In the warning box, we should add an icon on the "delete orphan tags" action link.
[tag manager] add icon to delete orphan tags action link
https://api.github.com/repos/Piwigo/Piwigo/issues/555/comments
0
2016-11-28T12:25:18Z
2016-11-28T12:25:55Z
https://github.com/Piwigo/Piwigo/issues/555
191,993,245
555
[ "Piwigo", "Piwigo" ]
Some admin pages, like [Administration > Tools > Maintenance] have no tabs. For a matter of graphical consistency, we should have tabs on all admin pages, even with a single tab.
all admin pages should have tabs
https://api.github.com/repos/Piwigo/Piwigo/issues/554/comments
1
2016-11-28T12:22:19Z
2022-07-30T08:56:26Z
https://github.com/Piwigo/Piwigo/issues/554
191,992,679
554
[ "Piwigo", "Piwigo" ]
Thanks to #509 and history summary optimization, the column history.summarized is no longer used. We didn't remove it on Piwigo 2.9 to avoid impacting millions of lines on a full history table. Now that #370 was implemented and ran on 2.9, the history table should be much smaller and removing the useless column will be faster.
[history] remove column history.summarized
https://api.github.com/repos/Piwigo/Piwigo/issues/553/comments
1
2016-11-25T17:44:51Z
2020-10-28T17:09:46Z
https://github.com/Piwigo/Piwigo/issues/553
191,747,122
553
[ "Piwigo", "Piwigo" ]
Currently (Piwigo 2.8) the history only logs the visits on gallery side. Considering Piwigo is more and more used by teams, it would be highly useful to extend the history to actions: - add/edit/delete/login/logout user - add/edit/delete album - add/edit/delete photo - add/edit/delete tag - add/edit/delete group - add/edit/delete user comment
[history] log admin actions, logins, logouts...
https://api.github.com/repos/Piwigo/Piwigo/issues/552/comments
1
2016-11-25T12:48:43Z
2019-05-31T10:13:38Z
https://github.com/Piwigo/Piwigo/issues/552
191,695,857
552
[ "Piwigo", "Piwigo" ]
Hi all ! I'm using batch manager to remove bad pictures in my new albums. So I display all pictures. If I change the right access for the selected pictures, the `&display=all` parameter is maintained while if I delete the selected pictures it is not the case. It would be better if the display parameter is maintained after delete action. Léo
Deleting pictures in batch manager erases the display number parameter
https://api.github.com/repos/Piwigo/Piwigo/issues/551/comments
0
2016-11-20T17:15:06Z
2016-11-20T17:15:06Z
https://github.com/Piwigo/Piwigo/issues/551
190,570,304
551
[ "Piwigo", "Piwigo" ]
Have you ever thought about using mod_rewrite or a PHP routing class to get rid of the .php extension in the URLs? This change could also be used to make URLs for GET requests more presentable.
getting rid of .php in URLs
https://api.github.com/repos/Piwigo/Piwigo/issues/550/comments
4
2016-11-19T03:49:22Z
2016-12-03T16:15:49Z
https://github.com/Piwigo/Piwigo/issues/550
190,474,461
550
[ "Piwigo", "Piwigo" ]
I've just downloaded Piwigo 2.8.2 to run it in a Docker environment. However, I get mysql errors that look like this: Warning: [mysql error 3065] Expression #1 of ORDER BY clause is not in SELECT list, references column 'picsdb.piwigo_images.date_available' which is not in SELECT list; this is incompatible with DISTINCT SELECT DISTINCT(image_id) FROM piwigo_image_category INNER JOIN piwigo_images ON id = image_id WHERE category_id = 11 ORDER BY date_available DESC, file ASC, id ASC ; in /scripts/pics.binfalse.de/include/dblayer/functions_mysqli.inc.php on line 832 Fatal error: Uncaught Error: Call to a member function fetch_assoc() on boolean in /scripts/pics.binfalse.de/include/dblayer/functions_mysqli.inc.php:893 Stack trace: #0 /scripts/pics.binfalse.de/include/section_init.inc.php(318): query2array('\nSELECT DISTINC...', NULL, 'image_id') #1 /scripts/pics.binfalse.de/index.php(27): include('/scripts/pics.b...') #2 {main} thrown in /scripts/pics.binfalse.de/include/dblayer/functions_mysqli.inc.php on line 893 The docker environment consists of * an nginx:latest container that mounts the Piwigo sources to `/usr/share/nginx/html` (ro) * a mysql:latest container, that is linked to the nginx container * a php:fpm container that also knows about the piwigo sources and has `mysqli` installed We're talking about this PHP * PHP Version => 7.0.11 * Configure Command => './configure' '--with-config-file-path=/usr/local/etc/php' '--with-config-file-scan-dir=/usr/local/etc/php/conf.d' '--disable-cgi' '--enable-ftp' '--enable-mbstring' '--enable-mysqlnd' '--with-curl' '--with-libedit' '--with-openssl' '--with-zlib' '--enable-fpm' '--with-fpm-user=www-data' '--with-fpm-group=www-data' * PHP API => 20151012 * PHP Extension => 20151012 * Zend Extension => 320151012 * Zend Extension Build => API320151012,NTS * PHP Extension Build => API20151012,NTS * Client API library version => mysqlnd 5.0.12-dev - 20150407 - $Id: 241ae00989d1995ffcbbf63d579943635faf9972 $ * Version => mysqlnd 5.0.12-dev - 20150407 - $Id: 241ae00989d1995ffcbbf63d579943635faf9972 $ I've been able to fix the issues by adding the `ORDER BY` elements to the `SELECT` list in `piwigo/include/section_init.inc.php`: 309c309 < SELECT DISTINCT(image_id), date_available, file, id --- > SELECT DISTINCT(image_id) 446c446 < SELECT DISTINCT(id), date_available --- > SELECT DISTINCT(id) 485c485 < SELECT DISTINCT(id), hit --- > SELECT DISTINCT(id) However, I'm not sure if that's the proper way to go..!? Do you have any comments? Maybe you want to include the changes to your code base?
mysql error 3065: ORDER BY -vs- SELECT list
https://api.github.com/repos/Piwigo/Piwigo/issues/549/comments
1
2016-11-19T00:42:59Z
2016-11-19T10:29:03Z
https://github.com/Piwigo/Piwigo/issues/549
190,454,930
549
[ "Piwigo", "Piwigo" ]
Sanitize quick search expression before sending it to HTML comment on frontend
quick search and HTML comment
https://api.github.com/repos/Piwigo/Piwigo/issues/548/comments
1
2016-11-17T13:10:10Z
2018-01-15T12:08:46Z
https://github.com/Piwigo/Piwigo/issues/548
190,042,761
548
[ "Piwigo", "Piwigo" ]
Basic filter_var($url, FILTER_VALIDATE_URL, FILTER_FLAG_SCHEME_REQUIRED | FILTER_FLAG_HOST_REQUIRED) is not very strong. We need something stronger.
increase checks on url format
https://api.github.com/repos/Piwigo/Piwigo/issues/547/comments
1
2016-11-17T12:37:46Z
2018-01-15T12:09:01Z
https://github.com/Piwigo/Piwigo/issues/547
190,035,524
547
[ "Piwigo", "Piwigo" ]
http://fr.piwigo.org/forum/viewtopic.php?pid=219448#p219448 when $conf['gallery_url'] is set, the add_url_params(get_gallery_home_url(), $add_url_params) doesn't work it's probably get_root_url() instead
Bug on reset password email
https://api.github.com/repos/Piwigo/Piwigo/issues/546/comments
0
2016-11-10T13:49:09Z
2018-01-15T12:09:21Z
https://github.com/Piwigo/Piwigo/issues/546
188,512,765
546
[ "Piwigo", "Piwigo" ]
in order to simplify selection when dealing with duplicates.
[batch manager] add dimensions/filesize on thumbnail tooltip
https://api.github.com/repos/Piwigo/Piwigo/issues/545/comments
0
2016-11-10T10:50:36Z
2016-11-10T10:51:41Z
https://github.com/Piwigo/Piwigo/issues/545
188,476,423
545
[ "Piwigo", "Piwigo" ]
Hello, I thought I'd let you know of a problem I just encountered. While my suggestion is a long shot, I had the following set of errors while attempting to do a "Database synchronisation with files: ./galleries/" Warnings from the program. ``` [./galleries/all_low/29_Tel_Beit_She'an_(Decapolis)] PWG-UPDATE-1 (wrong filename) [./galleries/all_low/51_Hezekiah's_Tunnel] PWG-UPDATE-1 (wrong filename) [./galleries/all_low/73_Pre-Dinner_stop_(Al_Hasa,_Jordan)] PWG-UPDATE-1 (wrong filename) [./galleries/all_low/Items_From_31_Qasr_El_Yahud_(Jordan_Baptism_Site)] PWG-UPDATE-1 (wrong filename) [./galleries/all_low/Items_From_31_Qasr_El_Yahud_(Jordan_Baptism_Site)/31_Qasr_El_Yahud_(Jordan_Baptism_Site)] PWG-UPDATE-1 (wrong filename) ``` The actual SQL Error: `Warning: [mysql error 1064] You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'an_(Decapolis)/2016_09_18_-_Day_06/2016-09-18_20160918_055416.jpg',NULL,'286','1' at line 1084` ``` INSERT INTO piwigo_images (id,file,name,date_available,path,representative_ext,storage_category_id,added_by) VALUES('713','2016-09-13_0K3A0165.jpg','2016-09-13 0K3A0165','2016-10-28 15:12:51','./galleries/all_low/00_Transit/2016_09_13_-_Day_01/2016-09-13_0K3A0165.jpg',NULL,'331','1') , ('714','2016-09-13_0K3A0167.jpg','2016-09-13 0K3A0167','2016-10-28 15:12:51','./galleries/all_low/00_Transit/2016_09_13_-_Day_01/2016-09-13_0K3A0167.jpg',NULL,'331','1') , ('715','2016-09-13_20160913_145837.jpg','2016-09-13 20160913 145837','2016-10-28 15:12:51','./galleries/all_low/00_Transit/2016_09_13_-_Day_01/2016-09-13_20160913_145837.jpg',NULL,'331','1') , ('716','2016-09-13_20160913_153852_HDR.jpg','2016-09-13 20160913 153852 HDR','2016-10-28 15:12:51','./galleri in /var/www/html/a_server.com/public_html/israel/gallery/include/dblayer/functions_mysqli.inc.php on line 832 ``` While the DB entry didn't go through because the file had an ' in it as did another prior also, it seems that this isn't being detected early enough, and it still tried to push in through the DB, yet failed. So it seems the query failed, because it there was an error in the structure of the query. My guess is it shouldn't have even got the filename to the query in the first place, or it should have at least been escaped. Just my thoughts. Using Piwigo 2.8.2.
SQL Injection 'may' be possible through filenames
https://api.github.com/repos/Piwigo/Piwigo/issues/544/comments
3
2016-10-28T04:27:33Z
2022-09-12T12:43:56Z
https://github.com/Piwigo/Piwigo/issues/544
185,836,256
544
[ "Piwigo", "Piwigo" ]
I mean the small "x" on the left of each filter. We should make it more obvious. Like switching to fontello icon-cancel and, on hover, using icon-cancel-circled in red.
[Batch Manager] visual improvement on filter removal
https://api.github.com/repos/Piwigo/Piwigo/issues/543/comments
0
2016-10-24T13:25:49Z
2017-03-08T10:31:57Z
https://github.com/Piwigo/Piwigo/issues/543
184,839,740
543
[ "Piwigo", "Piwigo" ]
If $conf['browser_language'] = false, then we should use guest's language.
New user should not always use browser language
https://api.github.com/repos/Piwigo/Piwigo/issues/542/comments
0
2016-10-20T08:00:00Z
2018-01-15T12:09:31Z
https://github.com/Piwigo/Piwigo/issues/542
184,159,635
542
[ "Piwigo", "Piwigo" ]
In the effort the "modernize" the administration, on clear theme, dark colors, like for header/footer would fit well on menubar
admin theme clear, darken menubar
https://api.github.com/repos/Piwigo/Piwigo/issues/541/comments
1
2016-10-17T08:33:37Z
2016-10-17T08:37:10Z
https://github.com/Piwigo/Piwigo/issues/541
183,355,555
541
[ "Piwigo", "Piwigo" ]
Hi, isn't there an ongoing effort or discussion to switch from MyISAM engine to InnoDB? MyISAM is not really supported (considered "still experimental": https://mariadb.com/kb/en/mariadb/galera-cluster-system-variables/#wsrep_replicate_myisam) with Galera clustering, and since I've deployed Piwigo into MariaDB cluster, I had to mysqldump the initial DB, "fix" all create table statements from MyISAM to InnoDB and re-import the DB. It seems to work now, but I'm sure some more testing will be needed. Thank you in advance. Martin
Consider using InnoDB instead of MyISAM?
https://api.github.com/repos/Piwigo/Piwigo/issues/539/comments
2
2016-10-14T22:22:30Z
2016-11-04T15:14:24Z
https://github.com/Piwigo/Piwigo/issues/539
183,163,037
539
[ "Piwigo", "Piwigo" ]
If you create a new tag, you immediately get a warning saying it is an orphan tag. Of course there is no photo associated to this tag, this is "obvious". We should not warn the user for this. We could add a tags.created_on column and wait for at least1 day before warning the user.
do not mark tag as orphan if new
https://api.github.com/repos/Piwigo/Piwigo/issues/537/comments
2
2016-10-14T12:21:43Z
2016-11-25T17:34:08Z
https://github.com/Piwigo/Piwigo/issues/537
183,036,369
537
[ "Piwigo", "Piwigo" ]
I'm talking about this tiny ugly things. I'm pretty sure nobody use them. ![piwigo-resizable-widget](https://cloud.githubusercontent.com/assets/9326959/19383346/21df9b76-9204-11e6-81a9-005da7cce190.png)
Remove resizable widget on double select
https://api.github.com/repos/Piwigo/Piwigo/issues/536/comments
0
2016-10-14T09:48:35Z
2016-10-14T10:03:54Z
https://github.com/Piwigo/Piwigo/issues/536
183,007,994
536
[ "Piwigo", "Piwigo" ]
- On "clear" theme, switch to dark background color (only for header/footer, no #content) - Remove "|" separators - Limit the display of the gallery title in length - Remove label on narrow screens - shorten the label for the "color changer"
modernize header/footer in administration
https://api.github.com/repos/Piwigo/Piwigo/issues/535/comments
0
2016-10-11T17:50:59Z
2016-10-17T08:31:23Z
https://github.com/Piwigo/Piwigo/issues/535
182,329,916
535
[ "Piwigo", "Piwigo" ]
Make it more sexy! Related to #532
modernize administration homepage
https://api.github.com/repos/Piwigo/Piwigo/issues/534/comments
2
2016-10-06T13:48:53Z
2016-10-13T09:55:33Z
https://github.com/Piwigo/Piwigo/issues/534
181,419,964
534
[ "Piwigo", "Piwigo" ]
In addition to infos/errors/warnings, let's add a "messages" box. Actually it would be better to rename "infos" into "success" and call "messages" "infos", but it would have quite a huge impact, so I prefer to call it "messages". ![piwigo-2 9-messages](https://cloud.githubusercontent.com/assets/9326959/19145730/a7467e7e-8bb0-11e6-802f-139da84c3b9e.png)
add a "messages" box in admin
https://api.github.com/repos/Piwigo/Piwigo/issues/533/comments
0
2016-10-06T08:36:04Z
2016-10-06T09:47:37Z
https://github.com/Piwigo/Piwigo/issues/533
181,354,219
533
[ "Piwigo", "Piwigo" ]
This is a highly technical piece of information, totally useless on administration homepage. Will fit better on [Admin > Tools > Maintenance].
move environment info from admin home to maintenance
https://api.github.com/repos/Piwigo/Piwigo/issues/532/comments
0
2016-10-05T12:39:28Z
2016-10-06T10:24:09Z
https://github.com/Piwigo/Piwigo/issues/532
181,141,449
532
[ "Piwigo", "Piwigo" ]
In case of an album with several distinct authors, it could be useful (actually, we received such a request on Piwigo.com support) to be able to sort by author. In my opinion, this is not relevant for a "default sort order setting", but it's definitely interesting for the session sort order.
sort photos by author
https://api.github.com/repos/Piwigo/Piwigo/issues/530/comments
0
2016-09-28T09:29:59Z
2016-09-28T09:29:59Z
https://github.com/Piwigo/Piwigo/issues/530
179,723,419
530
[ "Piwigo", "Piwigo" ]
Batch manager can be attacked by CSRF https://en.wikipedia.org/wiki/Cross-site_request_forgery : let's add a pwg_token to protect it! Reported by Akhil Koul
[security] prevent CSRF on batch manager
https://api.github.com/repos/Piwigo/Piwigo/issues/529/comments
0
2016-09-27T12:20:37Z
2016-09-27T12:25:43Z
https://github.com/Piwigo/Piwigo/issues/529
179,477,526
529
[ "Piwigo", "Piwigo" ]
There are too many "boxes in boxes" on Piwigo administration panel. @mistic100 had already done a nice simplification on [Administration > Configuration > Options] pages. Let's walk another step!
admin panel, reduce the "boxes in boxes" effect
https://api.github.com/repos/Piwigo/Piwigo/issues/528/comments
0
2016-09-26T13:16:58Z
2016-10-13T09:55:47Z
https://github.com/Piwigo/Piwigo/issues/528
179,225,739
528
[ "Piwigo", "Piwigo" ]
Dans admin/picture_modify.php je propose l'ajout d'un trigger `trigger_notify('picture_modify_delete_elements', null);` Il permet d'intervenir avant la suppression d'une image.
Ajouter trigger suppression photo
https://api.github.com/repos/Piwigo/Piwigo/issues/527/comments
1
2016-09-26T12:12:37Z
2016-09-26T12:25:43Z
https://github.com/Piwigo/Piwigo/issues/527
179,211,652
527
[ "Piwigo", "Piwigo" ]
replace the background image by an SVG icon, bigger margins, left border with same color as text inside the box
make admin info/error/warning cleaner and modern
https://api.github.com/repos/Piwigo/Piwigo/issues/526/comments
0
2016-09-26T10:44:12Z
2016-09-26T10:46:44Z
https://github.com/Piwigo/Piwigo/issues/526
179,195,074
526
[ "Piwigo", "Piwigo" ]
Bonjour, Dans la fonction add_uploaded_file du fichier admin/include/functions_upload.inc.php il pourrait être intéressant d'ajouter un trigger afin de pouvoir intervenir après l'upload et l'ajout dans la base de données et non avant comme le fait le trigger upload_file. Je propose : trigger_change('after_add_upload_file', null, $insert) pour le cas d'un nouveau fichier. trigger_change('after_add_upload_file', null, $update) pour le cas d'une mise à jour.
Add trigger at the end of upload
https://api.github.com/repos/Piwigo/Piwigo/issues/525/comments
0
2016-09-23T09:46:04Z
2020-10-26T15:26:48Z
https://github.com/Piwigo/Piwigo/issues/525
178,832,186
525
[ "Piwigo", "Piwigo" ]
Hello, First of all, thank you very much for this powerful application (and plugins), I just chose it to migrate my old Menalto Gallery3 albums. The choice was made based on the features that you offer, which are higher than other photo albums. One missing feature is the rights for non-admin. I mean to manager their albums (adding, removing, ordering ... etc) or their inscription for notifications ... With the "community" plugin, I managed to give them the right on their albums but only for adding, they cannot order the photos or change the album's properties. Is there any extension/plugin that can add these features or anything in the roadmap to include it in the main project? Thank you again
Manage his own album (for non admin)
https://api.github.com/repos/Piwigo/Piwigo/issues/524/comments
15
2016-09-15T09:58:59Z
2023-10-23T11:34:32Z
https://github.com/Piwigo/Piwigo/issues/524
177,135,945
524
[ "Piwigo", "Piwigo" ]
Hello, I wanted to give ability for others user to modify and edit a galery (and photos inside) i just created. Today, the only way to do something similar is to give "admin" access to other users, it's seems to me "too much right". It's not the same goal as "community" plugin, i don't want a personal gallery for visitors, i want a new user statut of "contributor" that can modify only the content of some album he is able to see. The main idea is that i add some photos and some contributor can add informations on the photos like tag, description, title, etc... Like in galery/photos admin page.
Ability to edit some specific galery for non admin user
https://api.github.com/repos/Piwigo/Piwigo/issues/523/comments
0
2016-09-10T13:02:31Z
2016-09-10T13:05:47Z
https://github.com/Piwigo/Piwigo/issues/523
176,178,590
523
[ "Piwigo", "Piwigo" ]
link for error https://pic.ilp.moe/picture.php?/4004/category/2&slideshow=+period-1+play-false&mobile=true
piwigo template error on slideshow when loading on mobile
https://api.github.com/repos/Piwigo/Piwigo/issues/522/comments
1
2016-09-06T04:40:53Z
2016-09-06T06:33:48Z
https://github.com/Piwigo/Piwigo/issues/522
175,158,917
522
[ "Piwigo", "Piwigo" ]
Somewhere relevant in the database.
[user manager] make number of users per page persistent
https://api.github.com/repos/Piwigo/Piwigo/issues/521/comments
1
2016-09-04T19:48:01Z
2016-09-05T06:31:18Z
https://github.com/Piwigo/Piwigo/issues/521
174,966,184
521
[ "Piwigo", "Piwigo" ]
Hi, This issue was first opened on the piwigo-openstreetmap github page : [https://github.com/xbgmsharp/piwigo-openstreetmap/issues/109#](url) It was confirmed by **xbgmsharp** unfortunately no solution was found. Some of my photos EXIF GPS data are not read on my Piwigo installation (**Ubuntu 16.04 server with latest PWG package**). I have attached 2 photos as an example : [photo.zip](https://github.com/Piwigo/Piwigo/files/441210/photo.zip) For both the photos : - the EXIF GPS data were set using Geosetter software - the EXIF GPS data are correctly retrieved by various software (like Picasa or FastStone Image Viewer) But on my PWG server, only EXIF GPS data of photo2.jpg are retrieved correctly :-(
EXIF GPS data not read (piwigo-openstreetmap)
https://api.github.com/repos/Piwigo/Piwigo/issues/520/comments
2
2016-08-28T15:50:45Z
2016-09-05T19:22:24Z
https://github.com/Piwigo/Piwigo/issues/520
173,653,131
520
[ "Piwigo", "Piwigo" ]
Noticed these on my production site: ``` Warning: [mysql error 1191] Can't find FULLTEXT index matching the column list SELECT * FROM tags WHERE (MATCH(name) AGAINST( 'help helps' IN BOOLEAN MODE)) in /**/include/dblayer/functions_mysqli.inc.php on line 832 Fatal error: Call to a member function fetch_assoc() on a non-object in /**/include/dblayer/functions_mysqli.inc.php on line 213 ``` Then after fixing the above: ``` Warning: [mysql error 1191] Can't find FULLTEXT index matching the column list SELECT id from images i WHERE (CONVERT(file, CHAR) LIKE '%help%' OR MATCH(name, comment) AGAINST( 'help helps' IN BOOLEAN MODE)) in /**/include/dblayer/functions_mysqli.inc.php on line 832 Fatal error: Call to a member function fetch_assoc() on a non-object in /**/include/dblayer/functions_mysqli.inc.php on line 893 ``` Fixed with: ``` ALTER TABLE `tags` ADD FULLTEXT INDEX `name_ft` (`name` ASC); ALTER TABLE `images` ADD FULLTEXT INDEX `name_comment_ft` (`name` ASC, `comment` ASC); ```
Using full-text search without indexes
https://api.github.com/repos/Piwigo/Piwigo/issues/519/comments
1
2016-08-28T12:03:25Z
2016-11-04T15:14:59Z
https://github.com/Piwigo/Piwigo/issues/519
173,643,203
519
[ "Piwigo", "Piwigo" ]
Hi, I tried to configure apache based authentication. System: Ubuntu 16.04, Apache 2.4.18, php 5.6.24-1, piwigo 2.8.2 Tracking down I realized that the user id shown in the PHP_AUTH_USER server variable, and both the REMOTE_USER and the REDIRECT_REMOTE_USER isn't exists. After I changed the line 50 in the ./include/user.inc.php from foreach (array('REMOTE_USER', 'REDIRECT_REMOTE_USER') as $server_key) to foreach (array('PHP_AUTH_USER', 'REMOTE_USER', 'REDIRECT_REMOTE_USER') as $server_key) It started to work. Can you please correct it in the code? Thank you, Zoltan
apache_authentication failed
https://api.github.com/repos/Piwigo/Piwigo/issues/517/comments
3
2016-08-11T10:24:46Z
2019-11-13T07:34:23Z
https://github.com/Piwigo/Piwigo/issues/517
170,613,887
517
[ "Piwigo", "Piwigo" ]
I noticed in the e-mail notification that there is an issue with the translation at least to Norwegian. The trouble is that the phrase "New photos were added on the <date>" is split into a translation of "New photos were added" and "on". "on" can be translated differently depending on context, so it needs to be split for the phrase to sound right (e.g. on/off switch is different word in Norwegian than "on date"). You can see the following diff which hopefully shows what I am trying to explain. I do not know how you correctly add information text to the translation strings. ``` diff diff --git a/language/nb_NO/admin.lang.php b/language/nb_NO/admin.lang.php index 4acf3b3..781c4ef 100644 --- a/language/nb_NO/admin.lang.php +++ b/language/nb_NO/admin.lang.php @@ -229,6 +229,7 @@ $lang['Go to'] = 'G<C3><A5> til'; $lang['Hello'] = 'Hallo'; $lang['New photos were added'] = 'Nye elementer har blitt lagt til'; $lang['on'] = 'p<C3><A5>'; +$lang['on <date>'] = 'den'; $lang['between'] = 'mellom'; $lang['and'] = 'og'; $lang['The webmaster has subscribed you to receiving notifications by mail.'] = 'Webmaster har satt deg opp for beskjeder via e-mail.'; diff --git a/themes/default/template/mail/text/html/notification_by_mail.tpl b/themes/default/template/mail/text/html/notification_by_mail.tpl index df3e431..ea2eb3a 100644 --- a/themes/default/template/mail/text/html/notification_by_mail.tpl +++ b/themes/default/template/mail/text/html/notification_by_mail.tpl @@ -15,7 +15,7 @@ <p>{'You have unsubscribed from receiving notifications by mail.'|@translate}</p> {/if} {if isset($content_new_elements_single)} -<p>{'New photos were added'|@translate} {'on'|@translate} {$content_new_elements_single.DATE_SINGLE}.</p> +<p>{'New photos were added'|@translate} {'on <date>'|@translate} {$content_new_elements_single.DATE_SINGLE}.</p> {/if} {if isset($content_new_elements_between)} <p>{'New photos were added'|@translate} {'between'|@translate} {$content_new_elements_between.DATE_BETWEEN_1} {'and'|@translate} {$content_new_elements_between.DATE_BETWEEN_2}.</p> ```
(minor) noticed a spelling issue in e-mail notification
https://api.github.com/repos/Piwigo/Piwigo/issues/516/comments
0
2016-08-08T12:35:19Z
2016-08-08T12:35:19Z
https://github.com/Piwigo/Piwigo/issues/516
169,912,235
516
[ "Piwigo", "Piwigo" ]
It seems that piwigo is making use of mysql_\* functions a lot. However, this has been deprecated in php7, and instead mysqli_\* is supposed to be used. This prevents installation with php7, as it obviously fails to connect to the mysql database because the function mysql_connect() isn't defined.
Check mysql extension on install (for PHP7)
https://api.github.com/repos/Piwigo/Piwigo/issues/515/comments
3
2016-08-07T14:13:51Z
2016-11-07T13:45:23Z
https://github.com/Piwigo/Piwigo/issues/515
169,798,233
515
[ "Piwigo", "Piwigo" ]
When deleting themes via API [1] on a fresh 2.8.2 install, I get an fatal error: ``` Fatal error: Uncaught Error: Call to undefined function deltree() in .../piwigo/admin/include/themes.class.php:246 Stack trace: #0 .../piwigo/include/ws_functions/pwg.extensions.php(118): themes-&gt;perform_action('delete', 'clear') #1 .../piwigo/include/ws_core.inc.php(608): ws_themes_performAction(Array, Object(PwgServer)) #2 .../piwigo/include/ws_protocols/rest_handler.php(56): PwgServer-&gt;invoke('pwg.themes.perf...', Array) #3 .../piwigo/include/ws_core.inc.php(296): PwgRestRequestHandler-&gt;handleRequest(Object(PwgServer)) #4 .../piwigo/ws.php(94): PwgServer-&gt;run() #5 {main} thrown in .../piwigo/admin/include/themes.class.php on line 246 ``` Deleting the theme via Admin UI works. 1): `http://PIWIGO/ws.php?format=json&method=pwg.themes.performAction&action=delete&theme=Sylvia&pwg_token=TOKEN`
Uncaught error when deleting themes via API
https://api.github.com/repos/Piwigo/Piwigo/issues/513/comments
0
2016-08-03T12:49:57Z
2016-11-29T14:08:59Z
https://github.com/Piwigo/Piwigo/issues/513
169,123,520
513
[ "Piwigo", "Piwigo" ]
As title says, sessions just keep growing in the database. It has to be deleted manually, or GC has to be triggered by logging in and out. ``` MariaDB [db]> select expiration from xx_sessions limit 10; +---------------------+ | expiration | +---------------------+ | 2016-07-17 02:06:19 | | 2016-07-17 02:28:21 | | 2016-07-17 01:23:06 | | 2016-07-17 02:05:04 | | 2016-07-17 02:02:04 | | 2016-07-17 01:47:05 | | 2016-07-17 01:53:04 | | 2016-07-17 02:20:05 | | 2016-07-17 02:14:06 | | 2016-07-17 01:41:11 | +---------------------+ 10 rows in set (0.00 sec) MariaDB [db]> select count(*) as t from xx_sessions; +-------+ | t | +-------+ | 21915 | +-------+ 1 row in set (0.00 sec) ``` include/functions_sessions.inc.php handles GC: ``` php function pwg_session_gc() { global $conf; $query = ' DELETE FROM '.SESSIONS_TABLE.' WHERE '.pwg_db_date_to_ts('NOW()').' - '.pwg_db_date_to_ts('expiration').' > ' .$conf['session_length'].' ;'; pwg_query($query); return true; } ``` There is no local override of `$conf['session_length'] = 3600;` GC is called from `pwg_login` when actually logging in. So if a single user stays logged in forever, there is no expiration. In practical terms, this means that a small and rarely visited gallery will have a sessions table of 50 MB within two weeks. For more active galleries, this will wreak havoc where resources are limited, for example in shared environments. This is new behavior for Piwigo, it was not like this before. GC should be done periodically by route of some common user interaction.
Sessions do not get deleted after expiration
https://api.github.com/repos/Piwigo/Piwigo/issues/512/comments
3
2016-07-31T05:35:53Z
2016-12-03T19:08:39Z
https://github.com/Piwigo/Piwigo/issues/512
168,502,955
512
[ "Piwigo", "Piwigo" ]
Hi, when I hit the user admin screen I receive this message: DataTables warning (table id = 'userList'): DataTables warning: JSON data from server could not be parsed. This is casued by a JSON formatting error. Looking at the ajax call I see that user_list_backend.php is displaying some PHP notices that break the JSON: <br /> <b>Notice</b>: Undefined index: sSearch in <b>/srv/troyvit.com/pics/admin/user_list_backend.php</b> on line <b>102</b><br /> <br /> <b>Notice</b>: Undefined variable: sOrder in <b>/srv/troyvit.com/pics/admin/user_list_backend.php</b> on line <b>142</b><br /> <br /> <b>Notice</b>: Undefined index: sEcho in <b>/srv/troyvit.com/pics/admin/user_list_backend.php</b> on line <b>164</b><br /> I think I can suppress the PHP notices, but I wanted to let you know that out of the box this happens. This is after a recent upgrade to 2.8.2 Best, Troy Vitullo <img width="1280" alt="piwigo" src="https://cloud.githubusercontent.com/assets/2042893/17181929/0f950978-53df-11e6-8870-f6a230c5cd2a.png">
Json formatting error due to extra PHP notices
https://api.github.com/repos/Piwigo/Piwigo/issues/511/comments
9
2016-07-27T15:47:24Z
2023-02-24T08:32:25Z
https://github.com/Piwigo/Piwigo/issues/511
167,888,051
511
[ "Piwigo", "Piwigo" ]
Currently, the history is summarized only when you go on page [Administration > Tools > History]. It is logical, because history_summary is useful only on this page, but if you don't go there often, the summary calculation might be very long and you have to wait for many seconds, which is not acceptable on user side. We should summarize more often. Computing summary on a few history lines will be fast.
summarize history more often
https://api.github.com/repos/Piwigo/Piwigo/issues/509/comments
0
2016-07-20T14:17:53Z
2016-11-25T17:49:51Z
https://github.com/Piwigo/Piwigo/issues/509
166,592,696
509
[ "Piwigo", "Piwigo" ]
Not so much an issue, I'm just curious where "get_sql_condition_FandF" is defined? I am trying to look into how to exclude albums from the 'random' set and this function seems to be responsible for the query conditions.. But I can't seem to figure out where the heck it is defined at! Thanks!
get_sql_condition_FandF?
https://api.github.com/repos/Piwigo/Piwigo/issues/508/comments
1
2016-07-08T22:20:53Z
2016-07-09T13:39:35Z
https://github.com/Piwigo/Piwigo/issues/508
164,627,099
508
[ "Piwigo", "Piwigo" ]
If $conf['guest_access'] = false, you get redirected to identification.php with an error message "You are not authorized to access the requested page". This is not user friendly. We should avoid this error message in this specific case.
avoid error message on log in page when no guest access
https://api.github.com/repos/Piwigo/Piwigo/issues/507/comments
1
2016-07-08T08:43:42Z
2019-01-14T10:18:19Z
https://github.com/Piwigo/Piwigo/issues/507
164,484,957
507
[ "Piwigo", "Piwigo" ]
piwigo-videojs automatically generated obsolete.list files was containing errors (due to PEM). The result was some core files deleted by mistake. See http://piwigo.org/forum/viewtopic.php?id=26669
plugin update may delete core files
https://api.github.com/repos/Piwigo/Piwigo/issues/506/comments
0
2016-06-27T12:52:11Z
2017-03-31T12:46:58Z
https://github.com/Piwigo/Piwigo/issues/506
162,444,600
506
[ "Piwigo", "Piwigo" ]
Hello, In Google Search Guidelines https://support.google.com/webmasters/answer/139066?hl=en we can read : "Avoid errors: use absolute paths rather than relative paths with the rel="canonical" link element. Use this structure: https://www.example.com/dresses/green/greendresss.html Not this structure: /dresses/green/greendress.html)." I don't see "absolute URL" generated in Piwigo Gallery by the the header template : `{if isset($U_CANONICAL) }<link rel="canonical" href="{$U_CANONICAL}">{/if}` I realized that there were plenty of variants addresses the same page referenced in Google Search Example : URL generated by RV Thumb Scroller plugin with _start-_ content (pagination) probably because the canonical url haven't be crawled correctly ?
No absolute canonical URL generated (for SEO)
https://api.github.com/repos/Piwigo/Piwigo/issues/505/comments
0
2016-06-16T15:48:58Z
2016-06-16T15:59:44Z
https://github.com/Piwigo/Piwigo/issues/505
160,695,510
505
[ "Piwigo", "Piwigo" ]
This is probably an extremely rare scenario, yet is causes some issues with the Lightroom plugin... Step 1 - upload a photo with keyword tags. Works OK Step 2 - replace the photo AND remove all tags - the photo is replaced, however all previously assigned tags remain. This is caused by the following code in **ws_images_add**: ``` if (isset($params['tag_ids']) and !empty($params['tag_ids'])) { set_tags( explode(',', $params['tag_ids']), $image_id ); } ``` Note, tags will set only when the tag_ids parameter is not empty. But when I want to clear all tags, the value is an empty string! When pwg.images.add is invoked with the **image_id** parameter, it must respect **single_value_mode** and **multiple_value_mode** (just the way it works in **ws_images_setInfo**), otherwise replacing the photo and updating its properties works incorrectly.
Replacing an existing image via pwg.images.add and tag removal
https://api.github.com/repos/Piwigo/Piwigo/issues/504/comments
0
2016-06-12T23:46:18Z
2016-12-08T17:27:02Z
https://github.com/Piwigo/Piwigo/issues/504
159,854,836
504
[ "Piwigo", "Piwigo" ]
I wrote functions to use stronger bcrypt hashes instead of the default ones. This worked like a charm on all pages but the Configurations->Options page. There only a blank page was shown but no error or warning anywhere, but in the browser, nor in the apache error_log. After digging in the code I found out that a redeclaration of my hashing functions was the cause. Unfortunatly this simple error was completely hidden by the usage of @include in https://github.com/Piwigo/Piwigo/blob/4d75cf/admin/configuration.php#L326 As this will happen for every error in the local config (and users will tend to make mistakes there) I suggest to change the above mentioned line to something like ` if(is_readable(PHPWG_ROOT_PATH. 'local/config/config.inc.php') { include(PHPWG_ROOT_PATH. 'local/config/config.inc.php'); ` BTW: Can't https://github.com/Piwigo/Piwigo/blob/4d75cf/admin/configuration.php#L326-L330 be simplified to just use PHPWG_ROOT_PATH.PWG_LOCAL_DIR. 'config/config.inc.php'? What's the preferred way of avoiding function redeclaration errors? Use of function_exists around functions in local conf or to make sure the local conf is only included once programmatically, for example by using include_once? If you go for the first, this should be documented somewhere (I did not find it in the wiki nor in the default local conf nor in the forum). The second might have side effects I'm not aware of. Thanks e-dschungel
Error handling for local conf
https://api.github.com/repos/Piwigo/Piwigo/issues/503/comments
2
2016-06-12T07:46:08Z
2016-07-19T08:57:48Z
https://github.com/Piwigo/Piwigo/issues/503
159,813,671
503
[ "Piwigo", "Piwigo" ]
After filling in the (supposedly) correct details for the SQL server and piwigo account, I am presented with a blank screen. Neither php5-fpm, mySQL or [Caddy](https://caddyserver.com/) logs allude to anything out of the ordinary occurring. PHP 5.6.4-4 mySQL 14.14 Piwigo 4d75cf3 Not really sure where to do from here, any help is appreciated.
Blank Page after Start Installation
https://api.github.com/repos/Piwigo/Piwigo/issues/502/comments
1
2016-06-10T05:48:33Z
2016-06-10T10:03:36Z
https://github.com/Piwigo/Piwigo/issues/502
159,563,398
502
[ "Piwigo", "Piwigo" ]
Dear Contributors I would like to have a config options where I could define a **max row per page** instead of **max pictures per page**. IMHO that would like much nicer, i.e. with the Modus theme. Cheers Roman
Feature request: Max rows instead max photos
https://api.github.com/repos/Piwigo/Piwigo/issues/499/comments
2
2016-06-07T12:53:43Z
2016-06-07T19:28:00Z
https://github.com/Piwigo/Piwigo/issues/499
158,915,447
499
[ "Piwigo", "Piwigo" ]
Hi, first of all thanks for providing Piwigo! I attempted the manual installation by following the outlined steps [here](http://piwigo.org/basics/installation_manual). However, there is no mentioning of what files or folders need to be writable. So whenever I want to conclude the installation all I receive is an _empty_ response. Only difference was that I downloaded release 2.8.1 here from Github. Could you give some pointers, as it's normally considered bad practice to make just everything writable.
Manual Installation page missing crucial information
https://api.github.com/repos/Piwigo/Piwigo/issues/498/comments
4
2016-06-07T11:54:02Z
2016-06-12T19:03:15Z
https://github.com/Piwigo/Piwigo/issues/498
158,904,349
498
[ "Piwigo", "Piwigo" ]
Rating is actually an advanced feature. Most of the time, this feature is not used at all. I would like it to be provided as a plugin, but it requires quite a lot of work. As a first step it would be good to deactivate rating by default (during installation I mean)
deactivate rating by default
https://api.github.com/repos/Piwigo/Piwigo/issues/496/comments
2
2016-06-06T14:29:54Z
2016-06-23T15:43:29Z
https://github.com/Piwigo/Piwigo/issues/496
158,691,902
496
[ "Piwigo", "Piwigo" ]
which contains bug fixes and official compatibility with PHP 7
update phpmailer to version 5.2.15
https://api.github.com/repos/Piwigo/Piwigo/issues/491/comments
1
2016-05-31T10:07:37Z
2017-01-28T14:52:55Z
https://github.com/Piwigo/Piwigo/issues/491
157,635,517
491
[ "Piwigo", "Piwigo" ]
The "tags by letter" display is nice BUT is hard to read with Elegant. ![screen shot 2016-05-30 at 17 16 03](https://cloud.githubusercontent.com/assets/9326959/15653001/6b494144-268a-11e6-881a-cfad8aa0fadb.png) With a few changes like: FIELDSET.tagLetter, LEGEND.tagLetterLegend, TR.tagLine { border-color: #333; } FIELDSET.tagLetter { width:250px; } TABLE.tagLetterContent { font-size:inherit; } TD.nbEntries { white-space: nowrap; } We can get: ![screen shot 2016-05-30 at 17 16 51](https://cloud.githubusercontent.com/assets/9326959/15653013/7f419142-268a-11e6-950a-9272f2675490.png)
[theme Elegant] less visible borders for tags by letter
https://api.github.com/repos/Piwigo/Piwigo/issues/490/comments
0
2016-05-30T15:18:34Z
2016-07-13T17:30:08Z
https://github.com/Piwigo/Piwigo/issues/490
157,521,524
490
[ "Piwigo", "Piwigo" ]
Piwigo let you upload a watermark named "Pierrick's watermark.png", but the result is that no derivative can be generated, we get an ImageMagick Error. We should automatically rename the watermark with a safe file name to avoid any problem.
quote in watermark file name breaks multiple size
https://api.github.com/repos/Piwigo/Piwigo/issues/488/comments
0
2016-05-30T10:19:13Z
2016-06-02T09:17:59Z
https://github.com/Piwigo/Piwigo/issues/488
157,474,203
488
[ "Piwigo", "Piwigo" ]
You get the same message when your username is invalid. We should have a more generic message like "invalid credentials".
"invalid password" is not always accurate
https://api.github.com/repos/Piwigo/Piwigo/issues/487/comments
0
2016-05-27T10:22:53Z
2016-05-30T12:36:25Z
https://github.com/Piwigo/Piwigo/issues/487
157,175,792
487
[ "Piwigo", "Piwigo" ]
In 0511ed2236b1fab9bc9c23b6c3bbee82ee4efdb5 we implemented a clean list for authors, but only in search. It would be good to have a real list, no more "free text" for this photo property. It would mean an admin page to manage the author list. On the other side, Piwigo could already manage this with tags "author:john" "author:lisa", but an independant list of authors would be nice too.
authors as a list, not free text
https://api.github.com/repos/Piwigo/Piwigo/issues/486/comments
0
2016-05-25T15:07:19Z
2016-05-25T15:07:19Z
https://github.com/Piwigo/Piwigo/issues/486
156,774,894
486
[ "Piwigo", "Piwigo" ]
When going to flat mode, Piwigo doesn't follow the expected sort orders. Let's imagine you have defined this manual order (for albums and for photos inside the 3 albums) ``` * album A ** album A2 *** photo A2c *** photo A2d *** photo A2b *** photo A2a ** album A1 *** photo A1b *** photo A1a *** photo A1c ** album A3 *** photo A3a *** photo A3b *** photo A3c ``` If "album A" is configured to sort on manual order, then a flat "album A" should display: ``` * album A *** photo A2c *** photo A2d *** photo A2b *** photo A2a *** photo A1b *** photo A1a *** photo A1c *** photo A3a *** photo A3b *** photo A3c ```
flat mode and manual sort
https://api.github.com/repos/Piwigo/Piwigo/issues/485/comments
6
2016-05-23T12:15:20Z
2016-05-23T13:06:53Z
https://github.com/Piwigo/Piwigo/issues/485
156,266,594
485
[ "Piwigo", "Piwigo" ]
When we successfully log in with quick connect while being in identification.php Piwigo ask again the login and the password.
incoherent log in with quick connect on identification.php
https://api.github.com/repos/Piwigo/Piwigo/issues/484/comments
1
2016-05-23T09:19:20Z
2016-05-23T09:37:36Z
https://github.com/Piwigo/Piwigo/issues/484
156,235,151
484
[ "Piwigo", "Piwigo" ]
<img width="1144" alt="screen shot 2016-05-21 at 21 08 44" src="https://cloud.githubusercontent.com/assets/11272416/15448569/4ca55dc0-1f98-11e6-8da3-6e5b60ce6a9d.png"> All my albums are upload via FTP, while only the last album cannot display its thumbnail cover. Is this a bug? I don't whether it is a problem with my server, I exclude the possible reasons of file size(this chosen cover image is larger than 3M ) or file name (with a _ at the beginning) problem by comparing with other albums or renaming this cover image. I tried to read the source code of `i.php`. However, it seems too difficult for me to figure out the problem. Any one can help?
Failed to load thumbnail of album uploaded via FTP
https://api.github.com/repos/Piwigo/Piwigo/issues/481/comments
0
2016-05-21T13:17:52Z
2016-05-21T13:17:52Z
https://github.com/Piwigo/Piwigo/issues/481
156,101,603
481
[ "Piwigo", "Piwigo" ]
Is it possible to show the *-character (photos posted during the last x days) in the Category Menu of the Smart Pocket (Mobile) - Theme?
"Photos posted during the last days" in a Mobile-Theme?
https://api.github.com/repos/Piwigo/Piwigo/issues/480/comments
1
2016-05-14T07:11:16Z
2018-06-13T15:49:28Z
https://github.com/Piwigo/Piwigo/issues/480
154,838,941
480
[ "Piwigo", "Piwigo" ]
"There is no suitable CSPRNG" is the error you get when random_compat, introduced in f51ee90c66527fd7ff634f3e8d414cb670da068d for #470 , does not find any "secure enough" random number generator.
There is no suitable CSPRNG
https://api.github.com/repos/Piwigo/Piwigo/issues/479/comments
0
2016-05-13T08:24:41Z
2018-01-15T12:18:04Z
https://github.com/Piwigo/Piwigo/issues/479
154,658,558
479
[ "Piwigo", "Piwigo" ]
In the edit user popin, we show the last visit date and time. This date is taken from the history table, which leads to 2 problems: 1) if the table gets big (which is often a problem, as long as we have not implemented #370 ) the SQL query to get the last visit can take very long (several seconds) 2) if the history is disabled, we show an incorrect information To avoid these problems, we can simply register the date and time in a new column users.last_visit
[user] save the last visit datetime
https://api.github.com/repos/Piwigo/Piwigo/issues/478/comments
0
2016-05-10T09:53:37Z
2016-11-25T17:49:25Z
https://github.com/Piwigo/Piwigo/issues/478
153,967,047
478
[ "Piwigo", "Piwigo" ]
If $conf['guest_access'] is false, we'd better perform an http redirect and not an html redirect.
http redirect for forbidden guest access
https://api.github.com/repos/Piwigo/Piwigo/issues/476/comments
4
2016-05-04T21:20:30Z
2018-01-15T12:18:25Z
https://github.com/Piwigo/Piwigo/issues/476
153,117,551
476
[ "Piwigo", "Piwigo" ]
I'm using piwigo 2.8.0 with a photo directory containing 10000+ photos. To generate the thumbnails directory I'm using a (self written) bash script which use convert from imagemagick. For example to create medium images : > convert -quality 90 -auto-orient -thumbnail "792x594" DSCF2478.JPG DSCF2478-me.JPG The size of the generated image is : > $ exiftool DSCF2478-me.JPG | grep 'Image Size' > Image Size : 445x594 The image size is correct, since the orientation of the original photo is : > exiftool DSCF2478.JPG | grep Orientation > Orientation : Rotate 90 CW However, when using piwigo and browsing to this photo, it is distorted (except if I view the original photo). When looking at the page source code, I'm seeing this : > <img src="_data/i/galleries/path/to/DSCF2478-me.JPG" width="792" height="594" alt="DSCF2478.JPG" I don't know from where the width="792" comes from (maybe the database ?), but if I re-synchonize the files metadata from the admin pages, the result is always the same. Obviously this does not happen with only one photo, but with many (but not all) «rotated» photos. Any help ? Thanks.
distorted medium photos
https://api.github.com/repos/Piwigo/Piwigo/issues/475/comments
0
2016-05-04T11:23:55Z
2016-05-04T11:23:55Z
https://github.com/Piwigo/Piwigo/issues/475
152,988,559
475
[ "Piwigo", "Piwigo" ]
So I'm sure it would be a relatively easy task to implement google authentication codes that can be used with authy and various other alternatives for Google Authenticator as well as Google Authenticator itself. This would help us keep accounts secure. https://en.wikipedia.org/wiki/Two-factor_authentication
Add Two Factor Authentication Software tokens.
https://api.github.com/repos/Piwigo/Piwigo/issues/472/comments
0
2016-05-01T05:04:24Z
2016-05-01T05:04:24Z
https://github.com/Piwigo/Piwigo/issues/472
152,103,353
472
[ "Piwigo", "Piwigo" ]
Piwigo knows how to check for new versions of Piwigo or themes/plugins/languages (= extensions) are available. Piwigo knows how to notify any of its users by email. Let's go to the next step by checking (from time to time, to define) automatically and notify if anything new available.
notify webmaster by mail for new versions of Piwigo or extensions
https://api.github.com/repos/Piwigo/Piwigo/issues/471/comments
1
2016-04-28T07:55:40Z
2017-03-29T13:48:56Z
https://github.com/Piwigo/Piwigo/issues/471
151,572,346
471
[ "Piwigo", "Piwigo" ]
Current functions used to generate random strings are not "that much random" (depending on the PHP version and operating system).
increase randomness on generate_key
https://api.github.com/repos/Piwigo/Piwigo/issues/470/comments
0
2016-04-26T09:03:40Z
2018-01-15T12:20:36Z
https://github.com/Piwigo/Piwigo/issues/470
151,080,998
470
[ "Piwigo", "Piwigo" ]
If you have disabled the download link on the page of the photo (ie picture.php), it's complicated, even for an admin, to download the photo. A simple "download" link on the edition page would make things far simpler.
add download link on photo edition page
https://api.github.com/repos/Piwigo/Piwigo/issues/469/comments
2
2016-04-25T14:29:33Z
2016-07-19T08:45:06Z
https://github.com/Piwigo/Piwigo/issues/469
150,880,278
469
[ "Piwigo", "Piwigo" ]
This bug has been reproduced on Centos 6.7 with PHP 7.0.4 and Ubuntu with php 7.0.5, both with GD library. For example, generation of XXS thumbnails produce black images with default configuration. The problem lies in admin/includes/image.class.php in the get_sharpen_matrix function. Precisely, the normalized matrix will output bad images with the GD imageconvolution function, without throwing errors. Changing the normalizing code from <pre lang="javascript"><code> for ($i=0; $i<3; $i++) { $line = & $matrix[$i]; for ($j=0; $j<3; $j++) { $line[$j] /= $norm; } } </code></pre> To <pre lang="javascript"><code> for ($i=0; $i<3; $i++) { for ($j=0; $j<3; $j++) { $matrix[$i][$j] /= $norm; } } </code></pre> resolve the problem.
Image sharpening produce black images with PHP 7.0 and GD
https://api.github.com/repos/Piwigo/Piwigo/issues/467/comments
1
2016-04-22T21:40:22Z
2016-12-11T20:06:20Z
https://github.com/Piwigo/Piwigo/issues/467
150,477,011
467
[ "Piwigo", "Piwigo" ]
In the Batch Manager, if you move photos to an album and create this new album, the new album is created BUT not added/selected in the list of destination albums. Another album is selected and your photos are moved to the wrong album.
[Batch Manager] new album not listed when moving photos
https://api.github.com/repos/Piwigo/Piwigo/issues/466/comments
0
2016-04-22T07:45:23Z
2018-01-15T12:20:49Z
https://github.com/Piwigo/Piwigo/issues/466
150,296,126
466
[ "Piwigo", "Piwigo" ]
http://i.imgur.com/JRBGS3u.png This issue happens when using hhvm's fastcgi with nginx The proposed temp fix from hhvm is to replace all instances that try to retrieve upload_max_file_size with ini_get('hhvm.server.upload.upload_max_file_size');
HHVM bug causes issues with piwigo
https://api.github.com/repos/Piwigo/Piwigo/issues/465/comments
16
2016-04-18T14:08:04Z
2016-04-26T13:00:51Z
https://github.com/Piwigo/Piwigo/issues/465
149,161,359
465
[ "Piwigo", "Piwigo" ]
Please force https on all Piwigo domains. http is insecure and can be compromised: Links to download site could be manipulated, user data can be manipulated or stolen, logins can be hijacked... You may be interested in CSP upgrade-insecure-requests for a quick and smooth migration.
Use https on piwigo.org
https://api.github.com/repos/Piwigo/Piwigo/issues/464/comments
6
2016-04-15T19:05:51Z
2016-04-23T09:50:06Z
https://github.com/Piwigo/Piwigo/issues/464
148,743,091
464