Datasets:

---

DanielPFlorian

/

Transformers-Github-Issues

like 0

[]

[]

[ "Either my calculator and me are wrong or the max pos embedding is not matching the axial pos shape\n\n", "> Either my calculator and me are wrong or the max pos embedding is not matching the axial pos shape\r\n> \r\n> \r\n\r\nDefinitely your calculator looks like in learning phase! :)\r\n\r\nI am wondering if I load the models;\r\n\r\nmodel = ReformerForSequenceClassification.from_pretrained(\"./cnp\", num_labels = 2, output_attentions = False, output_hidden_states = False,)\r\nI assume the config will not be overridden, I mean it will complain about the config not being default.\r\n\r\nNot sure but, I am trying;\r\nmodel = ReformerForSequenceClassification(ReformerConfig())\r\nmodel.load_state_dict(torch.load(\"./cnp\"))\r\n\r\nwhich will load the custom model.\r\n\r\n", "Could you upload the trained model ?\r\nThen it's easier to reproduce the error and play around with the code", "> Could you upload the trained model ?\r\n> Then it's easier to reproduce the error and play around with the code\r\n\r\nThe model is trained on a very few samples (~100) and in the office network, which unfortunately does not allow to upload to outside world.\r\n\r\nI will try to upload one model after training it on collab.", "\r\nconfig = ReformerConfig()\r\nconfig.max_position_embeddings = 8192\r\nconfig.axial_pos_shape=[64, 128]\r\n\r\nmodel = ReformerForSequenceClassification(config)\r\nmodel.load_state_dict(torch.load(\"./cnp/pytorch_model.bin\"))\r\n\r\nThis is how I am trying to load the config, I tried an other approach but that did not work as well.\r\n", "@as-stevens are you training a Reformer Model from scratch?", "Regarding your code:\r\n\r\n```python\r\nconfig = ReformerConfig()\r\nconfig.max_position_embeddings = 8192\r\nconfig.axial_pos_shape=[64, 128]\r\n\r\nmodel = ReformerForSequenceClassification(config)\r\nmodel.load_state_dict(torch.load(\"./cnp/pytorch_model.bin\"))\r\n```\r\n\r\nplease note that it is not recommended instantiating a config and then later changing already set attributes. It's better to do the following:\r\n```\r\nconfig = ReformerConfig(max_position_embeddings=8192, axial_pos_shape=[64,128])\r\n```\r\n\r\nThis code for example works:\r\n```python \r\nfrom transformers import ReformerModel, ReformerConfig\r\nconfig = ReformerConfig(max_position_embeddings=8192, axial_pos_shape=[64, 128])\r\nmodel = ReformerModel(config)\r\nmodel.eval()\r\n\r\ninput_ids = torch.tensor([10 * [2, 4]])\r\nmodel(input_ids)\r\n```", "If you load a model from your checkpoint: \"./cnp/pytorch_model.bin\" the axial position embedding weights have to have the same dimensions in order for this to work", "Closing this for now. Feel free to re-open if you encounter other problems. Also make sure to have read the corresponding documentation of Reformer: https://huggingface.co/transformers/model_doc/reformer.html#axial-positional-encodings .", "@patrickvonplaten Thank you! Let me try your suggestion and run the classifier. Update you with the findings." ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5319?src=pr&el=h1) Report\n> Merging [#5319](https://codecov.io/gh/huggingface/transformers/pull/5319?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/bf0d12c220cfd19025736c488bdabda9efd20b9e&el=desc) will **increase** coverage by `1.33%`.\n> The diff coverage is `0.00%`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/5319?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #5319 +/- ##\n==========================================\n+ Coverage 77.91% 79.24% +1.33% \n==========================================\n Files 138 138 \n Lines 24284 24290 +6 \n==========================================\n+ Hits 18920 19249 +329 \n+ Misses 5364 5041 -323 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/5319?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/pipelines.py](https://codecov.io/gh/huggingface/transformers/pull/5319/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9waXBlbGluZXMucHk=) | `75.45% <0.00%> (-0.97%)` | :arrow_down: |\n| [src/transformers/modeling\\_auto.py](https://codecov.io/gh/huggingface/transformers/pull/5319/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19hdXRvLnB5) | `70.93% <0.00%> (-3.49%)` | :arrow_down: |\n| [src/transformers/trainer.py](https://codecov.io/gh/huggingface/transformers/pull/5319/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90cmFpbmVyLnB5) | `38.44% <0.00%> (-0.95%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5319/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl91dGlscy5weQ==) | `87.03% <0.00%> (-0.59%)` | :arrow_down: |\n| [src/transformers/tokenization\\_utils\\_base.py](https://codecov.io/gh/huggingface/transformers/pull/5319/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHNfYmFzZS5weQ==) | `93.68% <0.00%> (-0.03%)` | :arrow_down: |\n| [src/transformers/modeling\\_bart.py](https://codecov.io/gh/huggingface/transformers/pull/5319/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19iYXJ0LnB5) | `96.33% <0.00%> (ø)` | |\n| [src/transformers/configuration\\_bart.py](https://codecov.io/gh/huggingface/transformers/pull/5319/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9jb25maWd1cmF0aW9uX2JhcnQucHk=) | `93.75% <0.00%> (ø)` | |\n| [src/transformers/data/processors/glue.py](https://codecov.io/gh/huggingface/transformers/pull/5319/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9kYXRhL3Byb2Nlc3NvcnMvZ2x1ZS5weQ==) | `49.44% <0.00%> (ø)` | |\n| [src/transformers/data/processors/squad.py](https://codecov.io/gh/huggingface/transformers/pull/5319/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9kYXRhL3Byb2Nlc3NvcnMvc3F1YWQucHk=) | `28.66% <0.00%> (ø)` | |\n| ... and [6 more](https://codecov.io/gh/huggingface/transformers/pull/5319/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/5319?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5319?src=pr&el=footer). Last update [bf0d12c...d3d5d50](https://codecov.io/gh/huggingface/transformers/pull/5319?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "Warnings might scare the user that something went wrong, especially as there is no way to remove that behavior in the current API. Maybe documenting it properly is enough?\r\n\r\nMerging in the meantime because I need this to write model cards for XLNet." ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5318?src=pr&el=h1) Report\n> Merging [#5318](https://codecov.io/gh/huggingface/transformers/pull/5318?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/c4d4e8bdbd25d9463d41de6398940329c89b7fb6&el=desc) will **increase** coverage by `1.17%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/5318?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #5318 +/- ##\n==========================================\n+ Coverage 77.90% 79.07% +1.17% \n==========================================\n Files 140 138 -2 \n Lines 24334 24078 -256 \n==========================================\n+ Hits 18957 19040 +83 \n+ Misses 5377 5038 -339 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/5318?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/tokenization\\_bart.py](https://codecov.io/gh/huggingface/transformers/pull/5318/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYmFydC5weQ==) | `87.50% <0.00%> (-6.38%)` | :arrow_down: |\n| [src/transformers/modeling\\_auto.py](https://codecov.io/gh/huggingface/transformers/pull/5318/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19hdXRvLnB5) | `70.93% <0.00%> (-3.49%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_xlm.py](https://codecov.io/gh/huggingface/transformers/pull/5318/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl94bG0ucHk=) | `77.90% <0.00%> (-3.08%)` | :arrow_down: |\n| [src/transformers/file\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5318/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9maWxlX3V0aWxzLnB5) | `76.42% <0.00%> (-2.84%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5318/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl91dGlscy5weQ==) | `87.62% <0.00%> (-1.49%)` | :arrow_down: |\n| [src/transformers/modeling\\_reformer.py](https://codecov.io/gh/huggingface/transformers/pull/5318/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19yZWZvcm1lci5weQ==) | `88.21% <0.00%> (-1.02%)` | :arrow_down: |\n| [src/transformers/tokenization\\_reformer.py](https://codecov.io/gh/huggingface/transformers/pull/5318/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fcmVmb3JtZXIucHk=) | `40.67% <0.00%> (-0.99%)` | :arrow_down: |\n| [src/transformers/tokenization\\_utils\\_base.py](https://codecov.io/gh/huggingface/transformers/pull/5318/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHNfYmFzZS5weQ==) | `93.16% <0.00%> (-0.56%)` | :arrow_down: |\n| [src/transformers/modeling\\_electra.py](https://codecov.io/gh/huggingface/transformers/pull/5318/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19lbGVjdHJhLnB5) | `80.19% <0.00%> (-0.44%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_albert.py](https://codecov.io/gh/huggingface/transformers/pull/5318/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9hbGJlcnQucHk=) | `75.63% <0.00%> (-0.36%)` | :arrow_down: |\n| ... and [45 more](https://codecov.io/gh/huggingface/transformers/pull/5318/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/5318?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5318?src=pr&el=footer). Last update [c4d4e8b...54a74d9](https://codecov.io/gh/huggingface/transformers/pull/5318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "looks neat", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5316?src=pr&el=h1) Report\n> Merging [#5316](https://codecov.io/gh/huggingface/transformers/pull/5316?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/79a82cc06aaa68088639bf9bb000752cfd33a8c6&el=desc) will **increase** coverage by `0.00%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/5316?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #5316 +/- ##\n=======================================\n Coverage 79.29% 79.30% \n=======================================\n Files 138 138 \n Lines 24282 24282 \n=======================================\n+ Hits 19254 19256 +2 \n+ Misses 5028 5026 -2 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/5316?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/modeling\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5316/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ191dGlscy5weQ==) | `91.14% <0.00%> (-0.13%)` | :arrow_down: |\n| [src/transformers/file\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5316/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9maWxlX3V0aWxzLnB5) | `79.59% <0.00%> (+0.33%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_pytorch\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5316/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9weXRvcmNoX3V0aWxzLnB5) | `89.30% <0.00%> (+1.25%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/5316?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5316?src=pr&el=footer). Last update [79a82cc...ee4cc93](https://codecov.io/gh/huggingface/transformers/pull/5316?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5315?src=pr&el=h1) Report\n> Merging [#5315](https://codecov.io/gh/huggingface/transformers/pull/5315?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/9022ef021a56db975d25c7108cbd19d0dd399174&el=desc) will **increase** coverage by `0.88%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/5315?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #5315 +/- ##\n==========================================\n+ Coverage 77.08% 77.97% +0.88% \n==========================================\n Files 138 138 \n Lines 23841 23841 \n==========================================\n+ Hits 18379 18590 +211 \n+ Misses 5462 5251 -211 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/5315?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/configuration\\_bart.py](https://codecov.io/gh/huggingface/transformers/pull/5315/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9jb25maWd1cmF0aW9uX2JhcnQucHk=) | `93.75% <ø> (ø)` | |\n| [src/transformers/modeling\\_bart.py](https://codecov.io/gh/huggingface/transformers/pull/5315/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19iYXJ0LnB5) | `96.24% <ø> (ø)` | |\n| [src/transformers/file\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5315/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9maWxlX3V0aWxzLnB5) | `76.42% <0.00%> (-0.39%)` | :arrow_down: |\n| [src/transformers/trainer.py](https://codecov.io/gh/huggingface/transformers/pull/5315/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90cmFpbmVyLnB5) | `39.38% <0.00%> (-0.24%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5315/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl91dGlscy5weQ==) | `86.00% <0.00%> (+0.29%)` | :arrow_up: |\n| [src/transformers/modeling\\_openai.py](https://codecov.io/gh/huggingface/transformers/pull/5315/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19vcGVuYWkucHk=) | `80.90% <0.00%> (+1.38%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_openai.py](https://codecov.io/gh/huggingface/transformers/pull/5315/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9vcGVuYWkucHk=) | `94.92% <0.00%> (+75.00%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/5315?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5315?src=pr&el=footer). Last update [9022ef0...b9cc4aa](https://codecov.io/gh/huggingface/transformers/pull/5315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n", "I have the same kind of problem with transformers 3.3.1 and a BertModel, but the error is now an inplace operation on torch.cuda.LongTensor problem, something related to EmbeddingBackward.", "Could you please open a new issue with the full stacktrace + the information related to your environment?", "Done as issue #7848." ]

[ { "id": 1838412367, "node_id": "MDU6TGFiZWwxODM4NDEyMzY3", "url": "https://api.github.com/repos/huggingface/transformers/labels/model%20card", "name": "model card", "color": "92d5f4", "default": false, "description": "Related to pretrained model cards" } ]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5313?src=pr&el=h1) Report\n> Merging [#5313](https://codecov.io/gh/huggingface/transformers/pull/5313?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/08c9607c3d025f9f1a0c40e6d124d5d5d446208e&el=desc) will **increase** coverage by `1.88%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/5313?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #5313 +/- ##\n==========================================\n+ Coverage 77.41% 79.29% +1.88% \n==========================================\n Files 138 138 \n Lines 24282 24282 \n==========================================\n+ Hits 18798 19255 +457 \n+ Misses 5484 5027 -457 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/5313?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/modeling\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5313/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ191dGlscy5weQ==) | `91.14% <0.00%> (+0.36%)` | :arrow_up: |\n| [src/transformers/trainer.py](https://codecov.io/gh/huggingface/transformers/pull/5313/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90cmFpbmVyLnB5) | `39.62% <0.00%> (+1.41%)` | :arrow_up: |\n| [src/transformers/configuration\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5313/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9jb25maWd1cmF0aW9uX3V0aWxzLnB5) | `96.37% <0.00%> (+1.44%)` | :arrow_up: |\n| [src/transformers/modeling\\_distilbert.py](https://codecov.io/gh/huggingface/transformers/pull/5313/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19kaXN0aWxiZXJ0LnB5) | `97.74% <0.00%> (+1.69%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5313/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl91dGlscy5weQ==) | `87.62% <0.00%> (+2.20%)` | :arrow_up: |\n| [src/transformers/modeling\\_xlnet.py](https://codecov.io/gh/huggingface/transformers/pull/5313/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ194bG5ldC5weQ==) | `78.86% <0.00%> (+2.27%)` | :arrow_up: |\n| [src/transformers/modeling\\_ctrl.py](https://codecov.io/gh/huggingface/transformers/pull/5313/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19jdHJsLnB5) | `99.15% <0.00%> (+2.53%)` | :arrow_up: |\n| [src/transformers/modeling\\_auto.py](https://codecov.io/gh/huggingface/transformers/pull/5313/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19hdXRvLnB5) | `70.93% <0.00%> (+6.97%)` | :arrow_up: |\n| [src/transformers/pipelines.py](https://codecov.io/gh/huggingface/transformers/pull/5313/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9waXBlbGluZXMucHk=) | `76.41% <0.00%> (+9.68%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_t5.py](https://codecov.io/gh/huggingface/transformers/pull/5313/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl90NS5weQ==) | `91.43% <0.00%> (+42.03%)` | :arrow_up: |\n| ... and [1 more](https://codecov.io/gh/huggingface/transformers/pull/5313/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/5313?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5313?src=pr&el=footer). Last update [08c9607...f17b437](https://codecov.io/gh/huggingface/transformers/pull/5313?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5312?src=pr&el=h1) Report\n> Merging [#5312](https://codecov.io/gh/huggingface/transformers/pull/5312?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/135791e8ef12802ceb21a4abbb3a93f7da1bf390&el=desc) will **not change** coverage.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/5312?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #5312 +/- ##\n=======================================\n Coverage 79.30% 79.30% \n=======================================\n Files 138 138 \n Lines 24283 24283 \n=======================================\n Hits 19258 19258 \n Misses 5025 5025 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/5312?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/modeling\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5312/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl91dGlscy5weQ==) | `87.62% <0.00%> (-0.15%)` | :arrow_down: |\n| [src/transformers/modeling\\_transfo\\_xl.py](https://codecov.io/gh/huggingface/transformers/pull/5312/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190cmFuc2ZvX3hsLnB5) | `78.93% <0.00%> (+0.19%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/5312?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5312?src=pr&el=footer). Last update [135791e...487fa69](https://codecov.io/gh/huggingface/transformers/pull/5312?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null }, { "id": 1843244711, "node_id": "MDU6TGFiZWwxODQzMjQ0NzEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/New%20model", "name": "New model", "color": "fbca04", "default": false, "description": "" } ]

[]

[ "Wonderful if we can use embeddings of scientific documents in transformers.", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n", "SPECTER is a great work. Is there any plan to have the Huggingface version of SPECTER?", "This should be addressed now: https://huggingface.co/allenai/specter\r\nHow to use: https://github.com/allenai/specter" ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5310?src=pr&el=h1) Report\n> Merging [#5310](https://codecov.io/gh/huggingface/transformers/pull/5310?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/79a82cc06aaa68088639bf9bb000752cfd33a8c6&el=desc) will **increase** coverage by `0.00%`.\n> The diff coverage is `0.00%`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/5310?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #5310 +/- ##\n=======================================\n Coverage 79.29% 79.30% \n=======================================\n Files 138 138 \n Lines 24282 24282 \n=======================================\n+ Hits 19254 19256 +2 \n+ Misses 5028 5026 -2 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/5310?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/data/processors/squad.py](https://codecov.io/gh/huggingface/transformers/pull/5310/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9kYXRhL3Byb2Nlc3NvcnMvc3F1YWQucHk=) | `28.66% <0.00%> (ø)` | |\n| [src/transformers/modeling\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5310/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ191dGlscy5weQ==) | `91.14% <0.00%> (-0.13%)` | :arrow_down: |\n| [src/transformers/file\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5310/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9maWxlX3V0aWxzLnB5) | `79.59% <0.00%> (+0.33%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_pytorch\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5310/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9weXRvcmNoX3V0aWxzLnB5) | `89.30% <0.00%> (+1.25%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/5310?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5310?src=pr&el=footer). Last update [79a82cc...5583df5](https://codecov.io/gh/huggingface/transformers/pull/5310?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "Yes, it's in #5308 :-)" ]

[]

[]

[]

[ { "id": 1838412367, "node_id": "MDU6TGFiZWwxODM4NDEyMzY3", "url": "https://api.github.com/repos/huggingface/transformers/labels/model%20card", "name": "model card", "color": "92d5f4", "default": false, "description": "Related to pretrained model cards" } ]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5308?src=pr&el=h1) Report\n> Merging [#5308](https://codecov.io/gh/huggingface/transformers/pull/5308?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/135791e8ef12802ceb21a4abbb3a93f7da1bf390&el=desc) will **decrease** coverage by `2.10%`.\n> The diff coverage is `58.82%`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/5308?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #5308 +/- ##\n==========================================\n- Coverage 79.30% 77.20% -2.11% \n==========================================\n Files 138 138 \n Lines 24283 24285 +2 \n==========================================\n- Hits 19258 18749 -509 \n- Misses 5025 5536 +511 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/5308?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/data/processors/squad.py](https://codecov.io/gh/huggingface/transformers/pull/5308/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9kYXRhL3Byb2Nlc3NvcnMvc3F1YWQucHk=) | `28.66% <0.00%> (ø)` | |\n| [src/transformers/file\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5308/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9maWxlX3V0aWxzLnB5) | `79.59% <ø> (ø)` | |\n| [src/transformers/modeling\\_albert.py](https://codecov.io/gh/huggingface/transformers/pull/5308/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19hbGJlcnQucHk=) | `80.73% <ø> (ø)` | |\n| [src/transformers/modeling\\_bert.py](https://codecov.io/gh/huggingface/transformers/pull/5308/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19iZXJ0LnB5) | `87.65% <ø> (ø)` | |\n| [src/transformers/modeling\\_ctrl.py](https://codecov.io/gh/huggingface/transformers/pull/5308/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19jdHJsLnB5) | `96.62% <ø> (-2.54%)` | :arrow_down: |\n| [src/transformers/modeling\\_distilbert.py](https://codecov.io/gh/huggingface/transformers/pull/5308/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19kaXN0aWxiZXJ0LnB5) | `96.04% <ø> (-1.70%)` | :arrow_down: |\n| [src/transformers/modeling\\_electra.py](https://codecov.io/gh/huggingface/transformers/pull/5308/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19lbGVjdHJhLnB5) | `80.62% <ø> (ø)` | |\n| [src/transformers/modeling\\_flaubert.py](https://codecov.io/gh/huggingface/transformers/pull/5308/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19mbGF1YmVydC5weQ==) | `84.37% <ø> (ø)` | |\n| [src/transformers/modeling\\_gpt2.py](https://codecov.io/gh/huggingface/transformers/pull/5308/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19ncHQyLnB5) | `85.94% <ø> (ø)` | |\n| [src/transformers/modeling\\_longformer.py](https://codecov.io/gh/huggingface/transformers/pull/5308/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19sb25nZm9ybWVyLnB5) | `93.11% <ø> (ø)` | |\n| ... and [47 more](https://codecov.io/gh/huggingface/transformers/pull/5308/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/5308?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5308?src=pr&el=footer). Last update [135791e...5b1fbb2](https://codecov.io/gh/huggingface/transformers/pull/5308?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "@sshleifer @patrickvonplaten and @yjernite I updated your examples (seq2seq and eli5). Maybe you want to check it.", "> @sshleifer @patrickvonplaten and @yjernite I updated your examples (seq2seq and eli5). Maybe you want to check it.\r\n\r\nlgtm!" ]

[ { "id": 1838412367, "node_id": "MDU6TGFiZWwxODM4NDEyMzY3", "url": "https://api.github.com/repos/huggingface/transformers/labels/model%20card", "name": "model card", "color": "92d5f4", "default": false, "description": "Related to pretrained model cards" } ]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5307?src=pr&el=h1) Report\n> Merging [#5307](https://codecov.io/gh/huggingface/transformers/pull/5307?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/88d7f96e33c3f3e541bcdd913f2ff1e50aa18c1b&el=desc) will **increase** coverage by `0.00%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/5307?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #5307 +/- ##\n=======================================\n Coverage 79.30% 79.30% \n=======================================\n Files 138 138 \n Lines 24283 24283 \n=======================================\n+ Hits 19257 19258 +1 \n+ Misses 5026 5025 -1 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/5307?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/file\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5307/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9maWxlX3V0aWxzLnB5) | `79.59% <0.00%> (+0.33%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/5307?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5307?src=pr&el=footer). Last update [88d7f96...0bf35c5](https://codecov.io/gh/huggingface/transformers/pull/5307?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "Looks great!\r\n", "That's awesome, thanks!" ]

[]

[]

[ "Pinging @sshleifer, @sgugger and @LysandreJik for notification.", "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5306?src=pr&el=h1) Report\n> Merging [#5306](https://codecov.io/gh/huggingface/transformers/pull/5306?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/135791e8ef12802ceb21a4abbb3a93f7da1bf390&el=desc) will **decrease** coverage by `0.84%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/5306?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #5306 +/- ##\n==========================================\n- Coverage 79.30% 78.45% -0.85% \n==========================================\n Files 138 138 \n Lines 24283 24283 \n==========================================\n- Hits 19258 19052 -206 \n- Misses 5025 5231 +206 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/5306?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/modeling\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5306/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl91dGlscy5weQ==) | `87.77% <ø> (ø)` | |\n| [src/transformers/modeling\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5306/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ191dGlscy5weQ==) | `91.26% <ø> (+0.12%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_openai.py](https://codecov.io/gh/huggingface/transformers/pull/5306/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9vcGVuYWkucHk=) | `20.78% <0.00%> (-74.20%)` | :arrow_down: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/5306?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5306?src=pr&el=footer). Last update [135791e...d4e9c3f](https://codecov.io/gh/huggingface/transformers/pull/5306?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "BERT is a fine-tuning based model. As far as I'm aware, there are no 'embedding files' as such. You could generate embedding relevant to your case, by providing the model with words (see documentation) and generate outputs.", "> BERT is a fine-tuning based model. As far as I'm aware, there are no 'embedding files' as such. You could generate embedding relevant to your case, by providing the model with words (see documentation) and generate outputs.\r\n\r\nMany thanks!", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[]

[]

[ "This can be resolved by not using the remi/bertabs-finetuned-cnndm-extractive-abstractive-summarization model but the https://huggingface.co/remi/bertabs-finetuned-extractive-abstractive-summarization. With cnndm prefix I would expect it as a gpu version, but the opposite is the case.\r\nChanging the model fixes the error" ]

[ { "id": 1990944155, "node_id": "MDU6TGFiZWwxOTkwOTQ0MTU1", "url": "https://api.github.com/repos/huggingface/transformers/labels/bertabs", "name": "bertabs", "color": "9ab22e", "default": false, "description": "" } ]

[]

[ "Changing line 15 in run_summarization.py from \r\n`from .utils_summarization import (` to `from utils_summarization import (`\r\nfixed that error", "@sshleifer - can you take a look here maybe? ", "I do have a similar error, when I changed from .utils_summarization import ( to from utils_summarization import ( I got another error which is: \r\n/content/transformers/examples/seq2seq/bertabs\r\nTraceback (most recent call last):\r\n File \"run_summarization.py\", line 12, in <module>\r\n from modeling_bertabs import BertAbs, build_predictor\r\n File \"/content/transformers/examples/seq2seq/bertabs/modeling_bertabs.py\", line 30, in <module>\r\n from configuration_bertabs import BertAbsConfig\r\n File \"/content/transformers/examples/seq2seq/bertabs/configuration_bertabs.py\", line 19, in <module>\r\n from transformers import PretrainedConfig\r\nModuleNotFoundError: No module named 'transformers'\r\n\r\nCan you help me please?", "@Hildweig did you install the dependencies with \r\n`pip install -r requirements.txt` ?", "Also to make the example run I had to change the used model in run_summarization.py to \r\nremi/bertabs-finetuned-extractive-abstractive-summarization", "I did install the requirements, thank you! changing the model in run_summarization.py fixed the issue! However the output is very bad and makes no sense, this is what I got for a good text:\r\n\r\nthe u.s. is on the way to meet with the u.s.. the u.s. has pledged to help ease ease ease the situation. the u.n. is the most most most likely to provide provide provide a detailed detailed detailed detail. the u..s. is due to the u.s. , and and the u.s. will provide provide some areas to help\r\n------------------------------------------------\r\nDid you get a good summary?", "Why are you guys using bertabs? \r\nIt seems to not work very well, according to #3647 .\r\n\r\n@MichaelJanz would you be willing to contribute a PR with your changes?", "@sshleifer what do you suggest using for abstractive summarization? ", "@Hildweig Depends what your goal is?\r\n\r\nFor getting good scores on the cnndm dataset, I'd recommend `sshleifer/distilbart-cnn-12-6` and the finetuning in `examples/seq2seq/finetune.py`.\r\n\r\nFor your own data, start with a cnn checkpoint if you want 3 sentence summaries and an xsum checkpoint if you want 1 sentence summaries.\r\n\r\nFor running experiments to see how summarization finetuning works, you can start from `bart-large`, but these experiments are slow.\r\n\r\nTo make a useful open source contribution, you could try modifying/changing hyperparameters in `./train_distilbart_cnn.sh` to try to get a high score. Bonus points if you use `--logger wandb_shared`.\r\n\r\nAlso I recently update the setup instructions and script. It's now on master [here](https://github.com/huggingface/transformers/blob/master/examples/seq2seq/README.md). There are some tips in there that try to cover common cases.\r\n\r\nSpeed/Rouge tradeoffs detailed of different bart variants: [here](https://docs.google.com/spreadsheets/d/1EkhDMwVO02m8jCD1cG3RoFPLicpcL1GQHTQjfvDYgIM/edit#gid=0&range=B2:G12)\r\n[tweet](https://twitter.com/sam_shleifer/status/1276160367853547522?s=20) describing the distilbart project from a high level.\r\n\r\n\r\n", "@Hildweig I tested different input data and it performed (qualitatively considered) well for a random book review: https://bookpage.com/reviews/25272-deb-caletti-girl-unframed-ya#.Xvmf-CgzaUm\r\n\r\nThe result was: \r\n\r\n_sydney has to spend the summer with her mother , the once - famous movie star , lila shore , at her sumptuous mansion in san francisco 's exclusive sea cliff neighborhood. sydney has a lot of freedom to explore the city on her own , \r\nwhich is how she meets nicco and begins a relationship that will unexpectedly change all of their lives forever. in the book , sydney 's story appears to suggest that \r\nthe book itself is her testimony about the lead - up to a terrible crime. as a woman in the world , it often means being looked at but not seen by it , she says_\r\n\r\nHowever, using larger texts like a Sherlock Holmes novel did not work well, without any metrics considered.\r\n\r\n@sshleifer \r\nSure, I can create a PR.\r\nAlso thank you for the hint, I am thankful for any advices I can get for my master thesis. \r\n\r\nMay I ask you about your advice on my goal?\r\nI want to build a system, that is capable of creating summaries of book reviews for instagram posts in the german language. I am thinking of using the german bert (or similar) and fine tune it on a dataset I still have to get. Do you have any advice for me, you would like to share?", "However, the generated text does not look like abstractive, rather extractive", "Pr created in [#5355](https://github.com/huggingface/transformers/pull/5355)", "@sshleifer thank you! My goal is to fine-tune it on duc dataset.\r\n@MichaelJanz for me I have to summarize huge documents (17 page or so).", "Hi @sshleifer and @MichaelJanz,\r\n\r\nThis seems to be a problem of python package structure. I am getting a similar error but with the token_classification/run_ner.py file. \r\n\r\nFile \"examples/token-classification/run_ner.py\", line 42, in <module>\r\n from modeling_auto import AutoModelForTokenClassification\r\n File \"transformers/src/transformers/modeling_auto.py\", line 22, in <module>\r\n from .configuration_auto import (\r\nImportError: attempted relative import with no known parent package\r\n\r\nI have not installed transformers library using pip because I want to use the local codes (cloned from transformers library). After reading various stackoverflow suggestions (https://stackoverflow.com/questions/16981921/relative-imports-in-python-3 and https://napuzba.com/a/import-error-relative-no-parent), I believe that when I am importing the transformer package locally from my own directory, then it is not able read+load transformer as a package.\r\n\r\nI am using python3.7 \r\n\r\nCan you please suggest how to read transformer as a package from local codes. \r\n\r\nThanks..." ]

[]

[]

[ "Test fail due to the test in `test_tokenization_fast`, but I have not touched that file.\r\nFor me, the problem is in [test_tokenization_fast.py line 45](../tree/master/tests/test_tokenization_fast.py#L45). It works for me if I replace the path `tests/fixtures/...` with `./fixtures/...`\r\n\r\nShould I fix this?", "Hey! I'm interested in this as I have noticed the same phenomenon. Some of those files were moved recently; could you rebase from master to check whether that fixes the pathing issue?", "That's already looking better! If the tests still fail, it might be because the current expected outputs of the tests are incorrect. If your results are better than the expected outputs, that should be clear quickly.", "Is this fine if there are 229 files which have changed? If I do a compare from my repo with the master branch, it's only the 2 as before...", "For me, the reason for failure is still the same as mentioned above: `test_tokenization_fast.py:45: FileNotFoundError`\r\n```\r\n> with open(\"tests/fixtures/sample_text.txt\", encoding=\"utf-8\") as f_data:\r\nE FileNotFoundError: [Errno 2] No such file or directory: 'tests/fixtures/sample_text.txt'\r\n```", "That's weird, I'm seeing\r\n\r\n`AssertionError: Sequences differ: [100,[42 chars]832, 6193, 43, 24, 24, 24, 24, 24, 24, 29289, [4136 chars]1, 3] != [100,[42 chars]832, 24, 24, 29289, 476, 35, 24, 19, 5387, 812[3333 chars], 24]`\r\n\r\nin both CI tests, at `tests/test_tokenization_fast.py:62`", "Hmm strange... Maybe it's because I executed the tests in PyCharm.\r\n**Edit**: In PyCharm the root path for the tests was configured to be `.../tests/`, so that was the problem for me earlier.\r\n\r\nOk if I run it in the console I see the same result as you above!", "@TevenLeScao \r\n> If the tests still fail, it might be because the current expected outputs of the tests are incorrect.\r\n\r\nHow can I fix this?", "The issue seems to be that the Rust and Python tokenizers don't agree as the issue is also present in the Rust tokenizers. @n1t0 @Pierrci maybe could you take a look at this?", "I have no idea what changed unfortunately, but yes the rust tokenizers and the python one should have the same output for the tests to pass.", "Does it make sense if the `TransfoXLTokenizerFast` would also use the tokenizer from `sacremoses`?", "Not really. The fast tokenizers are implemented in Rust, not Python, so it's not possible to use sacremoses. Also, the fast tokenizers keep track of the offsets/alignment information, and I guess this is not something that sacremoses provides, does it? I'm really not familiar with it so I have no idea if it would be easy to re-implement otherwise.", "What exactly do you mean with offsets/alignment information? I'm not familiar with Rust nor the fast tokenizers in general. ", "Hi again, is there any update on the issue with the fast tokenizers?\r\n\r\nShould I maybe open a new PR which is up to date with the master branch so that we get rid of the messy commit history and lots of \"changes\"?", "Hi @RafaelWO , sorry for the delay.\r\n\r\n - A PR without the extra commits would definitely help\r\n - In the end we couldn't really decide on a solution: I think the consensus with @n1t0 and @thomwolf was that deleting the Rust TransfoXL tokenizer was the best but it's pretty harsh in terms of BC-breaking. I think the best would be to give it a deprecation warning for a bit and remove the Rust = Python tokenizer equality test for TransfoXL in the meantime.", "- I will reopen one\r\n- Sounds good, I will post my changes in a new PR and then we can discuss the deletion of the Rust tokenizer", "Reopened in PR #6322 " ]

[]

[]

[ "We are currently working on it as far as I know :-) @sshleifer ", "Duplicate of #4918 , but yes it is WIP!" ]

[]

[]

[ "See #4586." ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "I also cannot figure out how to use this model.", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[]

[]

[ "The position is based on the tokens. So this means that if you have a context: \r\n\r\n\"The dog runs in the park.\" and a question \"Who runs in the park?\" and the corresponding tokens (=`tokenizer(\"Who runs in the park?\", \"The dog runs in the park.\",).input_ids`) are \r\n\r\n`[101, 2040, 3216, 1999, 1996, 2380, 1029, 102, 1996, 3899, 3216, 1999, 1996, 2380, 1012, 102]`, then the model will tell you at what start and end position **of the input_ids** the answer to the question will be located. To better understand how to correctly use QA you might want to take a look at the example under this model in the docs: https://huggingface.co/transformers/master/model_doc/bert.html#bertforquestionanswering" ]

[ { "id": 1834056635, "node_id": "MDU6TGFiZWwxODM0MDU2NjM1", "url": "https://api.github.com/repos/huggingface/transformers/labels/Core:%20Tokenization", "name": "Core: Tokenization", "color": "FF4446", "default": false, "description": "Internals of the library; Tokenization." } ]

[]

[ "I just found out about the `return_offsets_mapping` functionality in the `PreTrainedTokenizerFast` tokenizers. I think I can use that functionality to solve my problem. ", "@brian8128 could you share a code example of how you do that?", "Hey Avijit - I didn't test this because it's sort of copied from various places in my codebase but here's the general idea. There may be multiple different char level labels within one token so here I take the most common one using the scipy.stats.mode function. \r\n\r\n```\r\nfrom scipy.stats import mode\r\nfrom transformers import BertTokenizerFast\r\n\r\ntexts = ... # list of strings\r\nchar_level_labels = ... # list of 1-d numpy arrays corresponding in length to texts\r\n\r\ntokenizer = BertTokenizerFast.from_pretrained('bert-base-uncased')\r\nbatch = tokenizer.batch_encode_plus(texts, return_offsets_mapping=True)\r\n\r\noffset_mappings = batch['offset_mapping']\r\n\r\ntoken_level_labels = []\r\nfor offset_mapping, char_level_label in zip(offset_mappings, char_level_labels):\r\n token_level_label = []\r\n for so, eo in offset_mapping:\r\n # Huggingface adds a start and end token that don't correspond to any\r\n # chars, we'll label these tokens with -1\r\n label = mode(char_level_label[so:eo]).mode[0] if eo - so > 0 else -1\r\n token_level_label.append(label)\r\n\r\n token_level_labels.append(np.array(token_level_labels))\r\n```" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5296?src=pr&el=h1) Report\n> Merging [#5296](https://codecov.io/gh/huggingface/transformers/pull/5296?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/7cc15bdd9675d1cec9186a8963c1f59be899ee68&el=desc) will **decrease** coverage by `0.00%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/5296?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #5296 +/- ##\n==========================================\n- Coverage 79.29% 79.28% -0.01% \n==========================================\n Files 138 138 \n Lines 24280 24280 \n==========================================\n- Hits 19252 19251 -1 \n- Misses 5028 5029 +1 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/5296?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/modeling\\_transfo\\_xl.py](https://codecov.io/gh/huggingface/transformers/pull/5296/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190cmFuc2ZvX3hsLnB5) | `78.74% <0.00%> (-0.20%)` | :arrow_down: |\n| [src/transformers/file\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5296/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9maWxlX3V0aWxzLnB5) | `79.59% <0.00%> (ø)` | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/5296?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5296?src=pr&el=footer). Last update [7cc15bd...65cabe0](https://codecov.io/gh/huggingface/transformers/pull/5296?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "Could someone review this PR?", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[]

[]

[ "Yes, it's intended. The attention mask has values of 0 where its attending to the tokens, and has a value of `-10000` for tokens it's not attending. By summing this attention mask, it zeros out the attentions that should not be kept. See [here](https://github.com/huggingface/transformers/blob/2ffef0d0c7a6cfa5a59c4b883849321f66c79d62/src/transformers/modeling_utils.py#L228) for the implementation.", "@LysandreJik I found that `attention_mask` is simply computed by `encoded_inputs[\"attention_mask\"] = [1] * len(encoded_inputs[\"input_ids\"])` in [tokenization_utils_base.py](https://github.com/huggingface/transformers/blob/2ffef0d0c7a6cfa5a59c4b883849321f66c79d62/src/transformers/tokenization_utils_base.py#L1944). Should `attention_mask` be synchronized with `encoded_inputs[\"input_ids\"]` when a [MASK] appears in the input? For example,\r\n\r\nInput: This is [MASK] pen.\r\n\r\nShould the `attention_mask` be `1 1 0 1` rather than `1 1 1 1`?", "The attention mask is computed according to the padding tokens, not masking tokens. See [here](https://github.com/huggingface/transformers/blob/2ffef0d0c7a6cfa5a59c4b883849321f66c79d62/src/transformers/tokenization_utils_base.py#L1932) for a sequence that requires padding." ]

[ { "id": 1108649053, "node_id": "MDU6TGFiZWwxMTA4NjQ5MDUz", "url": "https://api.github.com/repos/huggingface/transformers/labels/Help%20wanted", "name": "Help wanted", "color": "008672", "default": false, "description": "Extra attention is needed, help appreciated" } ]

[ { "login": "sshleifer", "id": 6045025, "node_id": "MDQ6VXNlcjYwNDUwMjU=", "avatar_url": "https://avatars.githubusercontent.com/u/6045025?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sshleifer", "html_url": "https://github.com/sshleifer", "followers_url": "https://api.github.com/users/sshleifer/followers", "following_url": "https://api.github.com/users/sshleifer/following{/other_user}", "gists_url": "https://api.github.com/users/sshleifer/gists{/gist_id}", "starred_url": "https://api.github.com/users/sshleifer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sshleifer/subscriptions", "organizations_url": "https://api.github.com/users/sshleifer/orgs", "repos_url": "https://api.github.com/users/sshleifer/repos", "events_url": "https://api.github.com/users/sshleifer/events{/privacy}", "received_events_url": "https://api.github.com/users/sshleifer/received_events", "type": "User", "site_admin": false } ]

[ "ok cool", "I will work on this.\r\n\r\n@sshleifer, is it supposed to be w/o a tokenizer?\r\n\r\n```\r\nfrom transformers import AutoTokenizer\r\n\r\ntokenizer = AutoTokenizer.from_pretrained(\"sshleifer/student_xsum_12_3\")\r\n```\r\n\r\n```\r\nOSError: Model name 'sshleifer/student_xsum_12_3' was not found in tokenizers model name list (facebook/bart-base, facebook/bart-large, facebook/bart-large-mnli, facebook/bart-large-cnn, facebook/bart-large-xsum, yjernite/bart_eli5). We assumed 'sshleifer/student_xsum_12_3' was a path, a model identifier, or url to a directory containing vocabulary files named ['vocab.json', 'merges.txt'] but couldn't find such vocabulary files at this path or url.\r\n```\r\nIt's broken online too (Compute button):\r\nhttps://huggingface.co/sshleifer/student_xsum_12_3?text=My+name+is+Thomas+and+my+main", "### Tokenizer issue\r\n@stas00 No that's just me being lazy, fixed that model, let me know if you need others.\r\n\r\nseparately: Can you write to S3?\r\nI just ran \r\n```bash\r\ncp_bart_tok () {\r\n\texport ss=s3://models.huggingface.co/bert/sshleifer\r\n\taw3 cp $ss/distilbart-xsum-1-1/merges.txt $1\r\n\taw3 cp $ss/distilbart-xsum-1-1/tokenizer_config.json $1\r\n\taw3 cp $ss/distilbart-xsum-1-1/vocab.json $1\r\n}\r\ncp_bart_tok $ss/student_xsum_12_1/\r\n```\r\nso easy for me to copy the bart tokenizer to other places.\r\n\r\n\r\n### Status of this issue\r\nthis issue is moved forward for **translation** with `examples/seq2seq/test_bash_script.py`\r\nIt's run by `.github/self-scheduled.yml`.\r\n\r\n\r\nThere are many possible axes for improvement: \r\n- testing summarization\r\n- may not need to set `do_predict=False` [here]:\r\n(https://github.com/huggingface/transformers/blob/c69ea5efc4eac65b183e8d07b1bf91d20bbe0c8c/examples/seq2seq/test_bash_script.py#L77). I made a PL issue where do_predict was breaking in fp16, but then I turned off fp16 here.\r\n- we could use a larger model like `sshleifer/student_mbart_en_ro_1_1/` and actually learn something (and wait longer).\r\n- we could run add a new github workflow against torch 1.6 (add a new `.github/next_torch_version.yml`)\r\n- understand current [failures](https://github.com/huggingface/transformers/runs/910644181?check_suite_focus=true)\r\n\r\nThanks so much for your help and let me know where/how I can support!\r\n", "> @stas00 No that's just me being lazy, fixed that model, let me know if you need others.\r\n\r\nThe problem is still there - you can quickly test [here](https://huggingface.co/sshleifer/student_xsum_12_3?text=My+name+is+Thomas+and+my+main)\r\n\r\n> separately: Can you write to S3?\r\n\r\nI don't think I can - at least nobody gave me permissions to do so.\r\n", "> ### Status of this issue\r\n> this issue is moved forward for translation with examples/seq2seq/test_bash_script.py\r\n> [...]\r\n> Thanks so much for your help and let me know where/how I can support!\r\n\r\nLet me study it first and I will ask follow up questions once I did so.\r\n\r\nI'm learning this library and while I have spare resources I'd be happy to help fixing problems - feel free to delegate some issue to me, so I won't need to dig through past issues looking for what I could work on.\r\n\r\nI am not sure github issue comments is the most efficient way to collaborate - perhaps you're on skype/email/some IM? My email is [email protected].", "Closing this. Will make new issues that are not started." ]

[ { "id": 1834056635, "node_id": "MDU6TGFiZWwxODM0MDU2NjM1", "url": "https://api.github.com/repos/huggingface/transformers/labels/Core:%20Tokenization", "name": "Core: Tokenization", "color": "FF4446", "default": false, "description": "Internals of the library; Tokenization." } ]

[]

[ "Hi! Do you mind pasting the command you use to run the script?", "I'm facing the same error while training Electra and MiniLM on Squad:\r\nValueError: Input [] is not valid. Should be a string, a list/tuple of strings or a list/tuple of integers.\r\n\r\nThis error is thrown up after reading of about 2% of the examples.\r\nMy env is the same as above. The command I use is:\r\n\r\npython examples/question-answering/run_squad.py \\\r\n --model_type bert \\\r\n --model_name_or_path microsoft/MiniLM-L12-H384-uncased \\\r\n --do_train \\\r\n --do_eval \\\r\n --do_lower_case \\\r\n --train_file \"/content/transformers/dev-v1.1.json\" \\\r\n --predict_file \"/content/transformers/dev-v1.1.json\" \\\r\n --per_gpu_train_batch_size 12 \\\r\n --learning_rate 3e-5 \\\r\n --num_train_epochs 2.0 \\\r\n --max_seq_length 384 \\\r\n --doc_stride 128 \\\r\n --output_dir \"/content/drive/My Drive/bert/newdir5\"\r\n\r\n", "Thanks, looking into it.", "I works now!", "Yes, it should be fixed in v3.0.0!" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "I met save issue before. Based on my experience, it is more related to PyTorch. \r\nSee https://pytorch.org/tutorials/beginner/saving_loading_models.html, you should use state_dict to save and load model.", "But @FacingBugs, this is an issue with the tokenizers and not the models ", "For tokenizer, using Transformer package provided API: \r\n```\r\ntokenizer.save_pretrained(your_output_model_dir)\r\n```", "@FacingBugs actually I have raised this bug because it was causing an issue in another library which uses this package\r\nhttps://github.com/flairNLP/flair/issues/1712\r\nAnd since `torch.save` is mostly used to persist the models and dependencies for pytorch based learning, I believe the fix should be implemented in the transformers library itself rather than other dependent libraries which may add on top of transformers to provide their custom pytorch models in which case `torch.save` would mostly be used to save the models.", "I think according to the PyTorch documentation, ```torch.save()``` is not recommended. \r\n\r\nI cite this from the documentation:\r\n\"However in this case, the serialized data is bound to the specific classes and the exact directory structure used, so it can break in various ways when used in other projects, or after some serious refactors.\"\r\n\r\n\r\nFor my personal experience with the Transformer package, the ```xx.save_pretrained()``` works for most of the cases (models, tokenizers, configs). For the tokenizer, I think the package actually saved several other files besides the vocab file. I think using the save_pretrained method should be the best practice. \r\n\r\nHope this can help you.", "Wouldn’t this make persisting other models on top of transformers difficult because now we have to save and track multiple files instead of a single file?", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5291?src=pr&el=h1) Report\n> Merging [#5291](https://codecov.io/gh/huggingface/transformers/pull/5291?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/79a82cc06aaa68088639bf9bb000752cfd33a8c6&el=desc) will **decrease** coverage by `1.39%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/5291?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #5291 +/- ##\n==========================================\n- Coverage 79.29% 77.90% -1.40% \n==========================================\n Files 138 138 \n Lines 24282 24282 \n==========================================\n- Hits 19254 18916 -338 \n- Misses 5028 5366 +338 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/5291?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/modeling\\_tf\\_openai.py](https://codecov.io/gh/huggingface/transformers/pull/5291/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9vcGVuYWkucHk=) | `20.78% <0.00%> (-74.20%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_distilbert.py](https://codecov.io/gh/huggingface/transformers/pull/5291/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9kaXN0aWxiZXJ0LnB5) | `66.25% <0.00%> (-32.52%)` | :arrow_down: |\n| [src/transformers/trainer.py](https://codecov.io/gh/huggingface/transformers/pull/5291/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90cmFpbmVyLnB5) | `39.38% <0.00%> (-0.24%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5291/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl91dGlscy5weQ==) | `87.48% <0.00%> (-0.15%)` | :arrow_down: |\n| [src/transformers/file\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5291/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9maWxlX3V0aWxzLnB5) | `79.59% <0.00%> (+0.33%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_pytorch\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5291/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9weXRvcmNoX3V0aWxzLnB5) | `89.30% <0.00%> (+1.25%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/5291?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5291?src=pr&el=footer). Last update [79a82cc...73e5da8](https://codecov.io/gh/huggingface/transformers/pull/5291?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "I wonder how it looks when it fails. Is it the same output you would usually see? If that's the case, I'm all for that change!", "Yes the tracebacks are completely unchanged. You just only see a `.` if the tests passes. And you don't have to scroll through `logger.info` (if you don't want to, it's still in the default circleci page).", "Merging. Tag me if any issues." ]

[]

[]

[ "@tqdo There is extensive info and a spreadsheet [here](https://huggingface.co/transformers/benchmarks.html?highlight=benchmark).", "Thanks a lot" ]

[ { "id": 1771187924, "node_id": "MDU6TGFiZWwxNzcxMTg3OTI0", "url": "https://api.github.com/repos/huggingface/transformers/labels/Core:%20Pipeline", "name": "Core: Pipeline", "color": "FF7066", "default": false, "description": "Internals of the library; Pipeline." } ]

[]

[ "CI Failure is spurious.", "Could you please tell me in **distilbart-cnn-12-6** what does **12 & 6** stands for?", "12 Encoder layers and 6 decoder layers I would suggest", "Thank you Sir, @patrickvonplaten " ]

[ { "id": 1843244711, "node_id": "MDU6TGFiZWwxODQzMjQ0NzEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/New%20model", "name": "New model", "color": "fbca04", "default": false, "description": "" } ]

[]

[ "It is [there](https://github.com/huggingface/transformers/blob/24f46ea3f3e5006ca38735306753a846a0823174/src/transformers/modeling_longformer.py#L796). \r\n\r\nYou may need to use a source install, I'm not sure it was already there in the last release.", "Thanks. It was in the release but it just wasnt in the documentation." ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5287?src=pr&el=h1) Report\n> Merging [#5287](https://codecov.io/gh/huggingface/transformers/pull/5287?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/24f46ea3f3e5006ca38735306753a846a0823174&el=desc) will **increase** coverage by `0.00%`.\n> The diff coverage is `97.14%`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/5287?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #5287 +/- ##\n=======================================\n Coverage 79.08% 79.08% \n=======================================\n Files 138 138 \n Lines 24078 24093 +15 \n=======================================\n+ Hits 19041 19054 +13 \n- Misses 5037 5039 +2 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/5287?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/tokenization\\_utils\\_base.py](https://codecov.io/gh/huggingface/transformers/pull/5287/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHNfYmFzZS5weQ==) | `93.15% <94.44%> (-0.01%)` | :arrow_down: |\n| [src/transformers/tokenization\\_gpt2.py](https://codecov.io/gh/huggingface/transformers/pull/5287/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fZ3B0Mi5weQ==) | `97.18% <100.00%> (+0.06%)` | :arrow_up: |\n| [src/transformers/tokenization\\_roberta.py](https://codecov.io/gh/huggingface/transformers/pull/5287/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fcm9iZXJ0YS5weQ==) | `94.52% <100.00%> (ø)` | |\n| [src/transformers/tokenization\\_utils\\_fast.py](https://codecov.io/gh/huggingface/transformers/pull/5287/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHNfZmFzdC5weQ==) | `94.20% <100.00%> (-0.09%)` | :arrow_down: |\n| [src/transformers/tokenization\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5287/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHMucHk=) | `91.16% <0.00%> (-0.32%)` | :arrow_down: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/5287?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5287?src=pr&el=footer). Last update [24f46ea...209dcc7](https://codecov.io/gh/huggingface/transformers/pull/5287?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[ { "id": 1834056635, "node_id": "MDU6TGFiZWwxODM0MDU2NjM1", "url": "https://api.github.com/repos/huggingface/transformers/labels/Core:%20Tokenization", "name": "Core: Tokenization", "color": "FF4446", "default": false, "description": "Internals of the library; Tokenization." } ]

[ { "login": "sshleifer", "id": 6045025, "node_id": "MDQ6VXNlcjYwNDUwMjU=", "avatar_url": "https://avatars.githubusercontent.com/u/6045025?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sshleifer", "html_url": "https://github.com/sshleifer", "followers_url": "https://api.github.com/users/sshleifer/followers", "following_url": "https://api.github.com/users/sshleifer/following{/other_user}", "gists_url": "https://api.github.com/users/sshleifer/gists{/gist_id}", "starred_url": "https://api.github.com/users/sshleifer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sshleifer/subscriptions", "organizations_url": "https://api.github.com/users/sshleifer/orgs", "repos_url": "https://api.github.com/users/sshleifer/repos", "events_url": "https://api.github.com/users/sshleifer/events{/privacy}", "received_events_url": "https://api.github.com/users/sshleifer/received_events", "type": "User", "site_admin": false } ]

[ "Would it be possible to run \r\n```\r\npip install transformers --upgrade\r\n``` \r\nand try again? We have fixed a lot of bugs since 2.8.0\r\n\r\nPasted tracebacks are much easier to read than screenshots.\r\n", "I belive that i was runing it. Let me try one more time.\n\nчт, 25 июня 2020 г., 21:50 Sam Shleifer <[email protected]>:\n\n> Would it be possible to run\n>\n> pip install transformers --upgrade\n>\n> and try again? We have fixed a lot of bugs since 2.8.0\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/huggingface/transformers/issues/5286#issuecomment-649756239>,\n> or unsubscribe\n> <https://github.com/notifications/unsubscribe-auth/AJWNBQJVBSPKL52ZGPRPJ4LRYOL6XANCNFSM4OIUNXTQ>\n> .\n>\n", "Just checked it twice. Looks like I've run it in another conda env. Here is an another error message(with transformers==2.11.0). \r\n\r\n", "Would you like me to create another issue?", "I can reproduce now, thanks. Will fix.", "Issue is that code on master saves `special_tokens_map.json` as \r\n```\r\n{\"bos_token\": \"<s>\", \"eos_token\": \"</s>\", \"unk_token\": \"<unk>\", \"sep_token\": \"</s>\", \"pad_token\": \"<pad>\", \"cls_token\": \"<s>\", \"mask_token\": {\"content\": \"<mask>\", \"single_word\": false, \"lstrip\": true, \"rstrip\": false, \"normalized\": true}}\r\n```\r\n\r\nand `v2.11` cannot load this format (where `mask_token` is a dict).\r\n\r\n\r\nI deleted `special_tokens_mask.json`, which seems to fix things. (the original `facebook/bart-large-cnn/` doesn't have a `special_tokens_mask.json`).\r\n\r\ncc @thomwolf", "I'm able to create tokenizer only for 'distilbart-xsum-12-1' and 'distilbart-xsum-9-6' (I still see 'special token mask_token... error for all other distilbart tokenizers')\r\nThe model can be uploaded only with these tokenizers. Then on the summarization step, I'm getting the following error:\r\n\r\nReproducible with both PyTorch versions: 1.5.1 and https://download.pytorch.org/whl/cpu/torch-1.0.1.post2-cp37-cp37m-linux_x86_64.whl", "Could I see the command you ran + more traceback/like what the ids were?\r\nOr could you try to reproduce the issue in google colab?\r\n", "1. **When I'm trying to create a tokenizer with the following command:**\r\ntokenizer = AutoTokenizer.from_pretrained(\"sshleifer/distilbart-cnn-12-6\") it fails with:\r\n\r\n\"special token {} has to be either str or AddedTokenFast but got: {}\".format(key, type(value))\r\nTypeError: special token mask_token has to be either str or AddedTokenFast but got: <class 'dict'>\r\n\r\n-----------------------------------------\r\n\r\n\r\n2. **And here is the code snippet for another error message:**\r\ntokenizer = AutoTokenizer.from_pretrained(\"sshleifer/distilbart-xsum-9-6\")\r\nmodel = AutoModelWithLMHead.from_pretrained(\"sshleifer/distilbart-xsum-9-6\")\r\nself.summarizer = pipeline(\"summarization\", model=model, tokenizer=tokenizer)\r\nself.summarizer(text) # It fails here. \r\n\r\nThe \"text\" variable contains the following(It was working with the simple text part from Wikipedia but fails with the following one): \r\n\r\nJune 29, 2020 | Primary Care Collaborative\r\nJuly 22, 2020 | National Hispanic Medical Association\r\nJuly 29, 2020 | Business Health Coalition\r\nJune 23, 2020 | The Hill\r\nJune 25, 2020\r\nJune 24, 2020 | Primary Care Collaborative\r\nNews Room\r\nTopic\r\nJune 25, 2020\r\nPrimary care practices are projected to lose more than $65,000 in revenue per full-time physician in 2020, following drastic declines in office visits and fees for services from March to May during the COVID-19 pandemic, according to a...\r\nJune 24, 2020 | Primary Care Collaborative\r\nIn the wake of police brutality and pervasive racial injustice, which has spurred numerous, ongoing demonstrations across the country, the Primary Care Collaborative (PCC) reaffirms its commitment to racial equality.\r\nPCC underscores this...\r\nJune 24, 2020 | Primary Care Collaborative\r\nOn June 18, PCC joined many other leading organizations in the primary care community in an hour-long chat on Twitter about the current and future state of primary care during the coronavirus pandemic.\r\nIf you missed the conversation, you...\r\nJune 23, 2020 | The Hill\r\nAnthony Fauci, the nation's top infectious disease expert, said Tuesday that he thinks institutional racism has played a role in the disproportionate impact the coronavirus outbreak has had on the Black community in the U.S.\r\n\"...\r\nJune 20, 2020\r\nWASHINGTON  —  Even as hospitals and physicians’ offices nationwide struggle to stay afloat amid the downturn caused by coronavirus, a small group of clinics is thriving, sustained by a model of care that many experts hope could reshape...\r\nJune 18, 2020 | Primary Care Collaborative\r\nCheck back weekly for the latest survey results and updates.\r\nFor last week's data, see Week 13 Results.\r\nWho replied to the survey in Week 14?\r\nThe Larry A. Green Center, the Primary Care Collaborative and 3rd Conversation are partnering...\r\nJune 18, 2020 | PCPCC Press Release\r\nWASHINGTON (June 18, 2020) – The Larry A. Green Center, in collaboration with the Primary Care Collaborative (PCC) and 3rd Conversation, today released new data showing that more than 80 percent of primary care clinicians say professional...\r\nJune 12, 2020 | The Commonwealth Fund\r\nOn this episode of The Dose podcast, health policy expert Farzad Mostashari, M.D., who advises and supports hundreds of primary care practices across the country, explains what it will take to ensure doctors can continue caring for...\r\nJune 12, 2020 | Primary Care Collaborative\r\nSix former leaders of the Centers for Medicare and Medicaid Services sent a joint letter June 10 to congressional leaders about the role of payment and regulatory flexibility in responding to the COVID-19 pandemic and addressing serious...\r\nJune 12, 2020 | PR Newswire\r\nSAN FRANCISCO, June 12, 2020 -- Innovaccer, Inc., a leading healthcare technology company [and a PCC Executive Member] released its research-based report, titled \"What COVID-19 Means to American Healthcare: Trends, Impacts, Predictions,...\r\nJune 10, 2020 | Primary Care Collaborative\r\nCheck back weekly for the latest survey results and updates.\r\nFor last week's data, see Week 12 Results.\r\nWho replied to the survey in Week 13?\r\nA primary care clinician survey (weekly) and a patient survey (generally every other week) are...\r\nJune 10, 2020 | PCPCC Press Release\r\nWASHINGTON (June 10, 2020) – The Larry A. Green Center, in collaboration with the Primary Care Collaborative (PCC) and 3rd Conversation, today released new data showing that a staggering 86 percent of Americans believe racism is impacting...\r\nJune 4, 2020 | PCPCC Press Release\r\nWASHINGTON (June 4, 2020) – New survey data released today by the Larry A. Green Center, in collaboration with the Primary Care Collaborative (PCC) and 3rd Conversation, shows that over 70% of primary care patients are comfortable using...\r\nJune 3, 2020 | Primary Care Collaborative\r\nCheck back weekly for the latest survey results and updates.\r\nFor last week's data, see Week 11 Results.\r\nWho replied to the survey in Week 12?\r\nA primary care clinician survey (weekly), and a patient survey (generally every other week) are...\r\nJune 1, 2020 | The Hill\r\nThe COVID-19 pandemic has unmasked many weaknesses in our public health and health care systems. But the outbreak also has accelerated, within weeks, useful health care innovations that would have normally taken years to develop. A strong...\r\nJune 1, 2020\r\nThe week of June 1 is a time of national advocacy for primary care. The PCC and many other organizations are part of this campaign, called #saveprimarycare. We are reaching out to Congress and the administration to call for dedicated...\r\nMay 27, 2020 | Primary Care Collaborative\r\nCheck back weekly for the latest survey results and updates.\r\nFor last week's data, see Week 10 Results.\r\nWho replied to the surveys?\r\nThe Larry A. Green Center is now fielding two separate surveys: one to primary care clinicians, and a...\r\nMay 27, 2020\r\nWASHINGTON (May 27, 2020) – In new data released today by the Larry A. Green Center, in collaboration with 3rd Conversation and the Primary Care Collaborative (PCC), Americans report feeling “panicked, upset, or heartbroken” at the...\r\nMay 21, 2020\r\nWASHINGTON, May 21, 2020—In a new survey of primary care clinicians and their response to the COVID-19 pandemic, conducted May 15-18, more than half (55%) fear they are unprepared for the next wave of the pandemic due to high stress among...\r\nMay 21, 2020 | Primary Care Collaborative\r\nCheck back weekly for the latest survey results and updates.\r\nFor last week's data, see Week 9 Results.\r\nWho replied to the survey in Week 10?\r\nThe week 10 sample was much smaller (736) than last week’s sample and of relatively different...\r\nPages\r\n\r\n ", "Any updates? ", "Looks like I've found an issue with:\r\n\"special token {} has to be either str or AddedTokenFast but got: {}\".format(key, type(value))\r\nTypeError: special token mask_token has to be either str or AddedTokenFast but got: <class 'dict'>\r\n\r\nThe issue is fixed. The problem was in my local cache so now it works. But it still fails for the summarization using the text above." ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "That's certainly possible. As you can see from my comment, and PR #5188 , I don't fully understand the motivation for the offset. It is very tricky.", "I figured out why. See here https://github.com/pytorch/fairseq/issues/1177\r\nSo basically the purpose is to make positional embedding = 0 on padding positions (positions where token is padding token), using the `padding_idx` parameter in torch.nn.Embedding. \r\n\r\nI think we can simply use masked_fill() to make positional embedding = 0 on padding positions, so the code is easier to understand (no need for the offset).", "Exactly! \r\nWould love to do that, but the migration of the existing bart state dicts is non trivial, since they already store the extra position embedding. Even if we tracked down all bart models with `config.static_position_embeddings=False` and resized their positional embeddings, we would break code that is not up to date w master (lots of code).\r\n\r\nSo I think we must settle for documenting what is going on better in `LearnedPositionalEmbedding` and accept the unfortunate reality that we are stuck with the offset forever (or until we have some futuristic model hub tooling to version state dicts).", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[ { "id": 1834056635, "node_id": "MDU6TGFiZWwxODM0MDU2NjM1", "url": "https://api.github.com/repos/huggingface/transformers/labels/Core:%20Tokenization", "name": "Core: Tokenization", "color": "FF4446", "default": false, "description": "Internals of the library; Tokenization." } ]

[]

[ "Yes, this was fixed on master today with https://github.com/huggingface/transformers/pull/5252\r\n" ]

[ { "id": 1838412367, "node_id": "MDU6TGFiZWwxODM4NDEyMzY3", "url": "https://api.github.com/repos/huggingface/transformers/labels/model%20card", "name": "model card", "color": "92d5f4", "default": false, "description": "Related to pretrained model cards" } ]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5283?src=pr&el=h1) Report\n> Merging [#5283](https://codecov.io/gh/huggingface/transformers/pull/5283?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/0e1fce3c0129d05b65a83cdd89e8eadded553f2e&el=desc) will **decrease** coverage by `0.01%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/5283?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #5283 +/- ##\n==========================================\n- Coverage 79.11% 79.09% -0.02% \n==========================================\n Files 138 138 \n Lines 24080 24080 \n==========================================\n- Hits 19050 19046 -4 \n- Misses 5030 5034 +4 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/5283?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/modeling\\_openai.py](https://codecov.io/gh/huggingface/transformers/pull/5283/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19vcGVuYWkucHk=) | `79.51% <0.00%> (-1.39%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5283/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl91dGlscy5weQ==) | `87.62% <0.00%> (-0.15%)` | :arrow_down: |\n| [src/transformers/modeling\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5283/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ191dGlscy5weQ==) | `91.26% <0.00%> (+0.12%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/5283?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5283?src=pr&el=footer). Last update [0e1fce3...a1c3ed8](https://codecov.io/gh/huggingface/transformers/pull/5283?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "(@julien-c approved offline)" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null }, { "id": 1845609017, "node_id": "MDU6TGFiZWwxODQ1NjA5MDE3", "url": "https://api.github.com/repos/huggingface/transformers/labels/seq2seq", "name": "seq2seq", "color": "fef2c0", "default": false, "description": "" } ]

[ { "login": "sshleifer", "id": 6045025, "node_id": "MDQ6VXNlcjYwNDUwMjU=", "avatar_url": "https://avatars.githubusercontent.com/u/6045025?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sshleifer", "html_url": "https://github.com/sshleifer", "followers_url": "https://api.github.com/users/sshleifer/followers", "following_url": "https://api.github.com/users/sshleifer/following{/other_user}", "gists_url": "https://api.github.com/users/sshleifer/gists{/gist_id}", "starred_url": "https://api.github.com/users/sshleifer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sshleifer/subscriptions", "organizations_url": "https://api.github.com/users/sshleifer/orgs", "repos_url": "https://api.github.com/users/sshleifer/repos", "events_url": "https://api.github.com/users/sshleifer/events{/privacy}", "received_events_url": "https://api.github.com/users/sshleifer/received_events", "type": "User", "site_admin": false } ]

[ "this will happen as part of TPU issue.", "Can you link the issue? Is there an open PR for this already? ", "This one: https://github.com/huggingface/transformers/pull/5960 , but it's broken afaict.", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[]

[]

[ "Bumping to `torch==1.5.1` fixes this issue. But it's still unclear why.", "I have also met the same issue and upgrading to torch1.5.1 also solves my problem.", "Possibly related to https://github.com/huggingface/transformers/issues/4857", "**Downgrade to sentencepiece==0.1.91 solve it.** \r\nI am using PyTorch 1.2.0 + transformers3.0.0", "> **Downgrade to sentencepiece==0.1.91 solve it.**\r\n> I am using PyTorch 1.2.0 + transformers3.0.0\r\n\r\nAlso PyTorch 1.4.0 + transformers 3.0.2", "Closing this as solved by #5418. Feel free to re-open if you still face an issue.", "For me either adding `sentencepiece==0.1.91 + torch==1.3.1 + transformers==2.4.1`\r\nor `torch==1.5.1 + transformers==2.4.1` worked.", "I come across the same problem too. \r\nMy solution is just to import torch before import the transformers", "> I come across the same problem too. My solution is just to import torch before import the transformers\r\n\r\nI followed your solution and it worked🤣. Before doing in this way, I downloaded almost every version of sentencepiece from 0.1.91 to 0.1.97. Although I do not know why, but it's something to happy about." ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5280?src=pr&el=h1) Report\n> Merging [#5280](https://codecov.io/gh/huggingface/transformers/pull/5280?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/0e1fce3c0129d05b65a83cdd89e8eadded553f2e&el=desc) will **decrease** coverage by `0.02%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/5280?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #5280 +/- ##\n==========================================\n- Coverage 79.11% 79.08% -0.03% \n==========================================\n Files 138 138 \n Lines 24080 24080 \n==========================================\n- Hits 19050 19043 -7 \n- Misses 5030 5037 +7 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/5280?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/modeling\\_openai.py](https://codecov.io/gh/huggingface/transformers/pull/5280/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19vcGVuYWkucHk=) | `79.51% <0.00%> (-1.39%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_pytorch\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5280/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9weXRvcmNoX3V0aWxzLnB5) | `88.05% <0.00%> (-1.26%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5280/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl91dGlscy5weQ==) | `87.62% <0.00%> (-0.15%)` | :arrow_down: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/5280?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5280?src=pr&el=footer). Last update [0e1fce3...49327ba](https://codecov.io/gh/huggingface/transformers/pull/5280?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5279?src=pr&el=h1) Report\n> Merging [#5279](https://codecov.io/gh/huggingface/transformers/pull/5279?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/7c41057d5090f5e665f2404878369ecb13939def&el=desc) will **decrease** coverage by `0.80%`.\n> The diff coverage is `37.29%`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/5279?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #5279 +/- ##\n==========================================\n- Coverage 78.34% 77.54% -0.81% \n==========================================\n Files 138 141 +3 \n Lines 23841 24085 +244 \n==========================================\n- Hits 18679 18676 -3 \n- Misses 5162 5409 +247 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/5279?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/modeling\\_dpr.py](https://codecov.io/gh/huggingface/transformers/pull/5279/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19kcHIucHk=) | `28.29% <28.29%> (ø)` | |\n| [src/transformers/configuration\\_dpr.py](https://codecov.io/gh/huggingface/transformers/pull/5279/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9jb25maWd1cmF0aW9uX2Rwci5weQ==) | `62.50% <62.50%> (ø)` | |\n| [src/transformers/\\_\\_init\\_\\_.py](https://codecov.io/gh/huggingface/transformers/pull/5279/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9fX2luaXRfXy5weQ==) | `99.23% <100.00%> (+0.01%)` | :arrow_up: |\n| [src/transformers/tokenization\\_dpr.py](https://codecov.io/gh/huggingface/transformers/pull/5279/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fZHByLnB5) | `100.00% <100.00%> (ø)` | |\n| [src/transformers/data/processors/squad.py](https://codecov.io/gh/huggingface/transformers/pull/5279/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9kYXRhL3Byb2Nlc3NvcnMvc3F1YWQucHk=) | `28.66% <0.00%> (-28.03%)` | :arrow_down: |\n| [src/transformers/tokenization\\_bert.py](https://codecov.io/gh/huggingface/transformers/pull/5279/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYmVydC5weQ==) | `89.95% <0.00%> (-0.92%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5279/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl91dGlscy5weQ==) | `85.12% <0.00%> (-0.89%)` | :arrow_down: |\n| [src/transformers/file\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5279/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9maWxlX3V0aWxzLnB5) | `76.42% <0.00%> (-0.39%)` | :arrow_down: |\n| [src/transformers/tokenization\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5279/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHMucHk=) | `91.50% <0.00%> (-0.32%)` | :arrow_down: |\n| ... and [3 more](https://codecov.io/gh/huggingface/transformers/pull/5279/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/5279?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5279?src=pr&el=footer). Last update [7c41057...7a90958](https://codecov.io/gh/huggingface/transformers/pull/5279?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "Looks very cool! \r\nI would have three general things:\r\n\r\n1) For all parameter names I would try to stick to the ones we already have `config` instead of `cfg`, `pad_token_id` instead of `pad_id`. For me `Bert` is always the gold standard and I would try to name everything as it is named in Bert. All these `hidden_states`, `output_embeddings`, ...\r\n\r\n2) I don't like single letter or very short variable names, it makes it very hard to understand it and impossible sometimes to run select and replace commands in such files. I do not mind having long parameter names at all. But also not sure what other think here @LysandreJik \r\n\r\n3) I would always favor composition over inheritance (there was only one case which I would have changed) \r\n\r\n4) IMO, we should not introduce new class methods and in general new design choices that the user doesn't know from other models. The class method `init_encoder` is not needed here IMO. Also, all these `make it super easy for the user ` methods are not always good if it makes the model less easy to understand. Would always try to keep models as \"thin\" as possible and not add any \"magic\" methods if not needed", "What do you think of having a special tokenizer for the `DPRReader` ? I find the current way to tokenize the inputs a bit weird.\r\n\r\nI can have a custom `DPRReaderTokenizer` with a new `__call__` method like\r\n```python\r\ndef __call__(self, question: str, titles: List[str], texts: List[str], ...):\r\n```", "Ok I think this one is ready to merge. Could you do a final pass to make sure everything is ok @LysandreJik @thomwolf ?\r\nI'll do another PR about the tokenization stuff.", "I did some changes @LysandreJik :\r\n- have 1:1 correspondances betwen model + tokenizers \r\n- change `base_model_prefix` to be the attribute of the model the classes are wrapping\r\n- remove the wrong `model_input_names `\r\n\r\nNot sure why the CI doesn't pass. It seems related to `test_tokenization_bert_japanese ` though :/", "I changed the tokenizers config names to match the pretrained model names.\r\nAbout the `.generate` method that could be in the tokenizer I totally agree. But as it is linked to the way I'm going to change the reader's tokenizer, I will do the change at the same time in the next PR if it's good for you.\r\n\r\nIs there anything else that needs to be improved ?", "Feel free to do another pass on the PR @thomwolf @LysandreJik to make sure that all the model+tokenizers aspect are all good now :)\r\nThere is still room for some improvements but I keep them for the next PR:\r\n- have a custom __call__ for the tokenizer of the reader\r\n- move the deocing stuff of `.generate` to the tokenizer or the reader", "Thanks for your comments @LysandreJik :)\r\nIf there is a 3.0.1 that's going to be shipped I'd rather have everything in this PR then as there will be big breaking changes", "Ok @LysandreJik I added the tests for the models and the tokenizers :)\r\nI couldn't use all the tests of `ModelTesterMixin` as some of them don't apply here, but I used those that are relevant.", "I merged your PR and updated the docs @LysandreJik \r\nThanks for your help ;)", "Very cool! Let's merge, thanks for iteration @lhoestq :)", "Is there a short working example on the full end-to-end retrieval to reader pipeline?", "If I may add to @weilin37 comment, fine tuning included" ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5278?src=pr&el=h1) Report\n> Merging [#5278](https://codecov.io/gh/huggingface/transformers/pull/5278?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/24f46ea3f3e5006ca38735306753a846a0823174&el=desc) will **increase** coverage by `0.38%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/5278?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #5278 +/- ##\n==========================================\n+ Coverage 79.08% 79.46% +0.38% \n==========================================\n Files 138 138 \n Lines 24078 24080 +2 \n==========================================\n+ Hits 19041 19135 +94 \n+ Misses 5037 4945 -92 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/5278?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/modeling\\_tf\\_pytorch\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5278/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9weXRvcmNoX3V0aWxzLnB5) | `88.05% <0.00%> (-1.26%)` | :arrow_down: |\n| [src/transformers/file\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5278/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9maWxlX3V0aWxzLnB5) | `76.42% <0.00%> (-0.39%)` | :arrow_down: |\n| [src/transformers/tokenization\\_utils\\_base.py](https://codecov.io/gh/huggingface/transformers/pull/5278/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHNfYmFzZS5weQ==) | `92.82% <0.00%> (-0.35%)` | :arrow_down: |\n| [src/transformers/modeling\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5278/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ191dGlscy5weQ==) | `91.26% <0.00%> (+0.12%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_bert.py](https://codecov.io/gh/huggingface/transformers/pull/5278/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9iZXJ0LnB5) | `98.76% <0.00%> (+0.41%)` | :arrow_up: |\n| [src/transformers/tokenization\\_bert.py](https://codecov.io/gh/huggingface/transformers/pull/5278/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYmVydC5weQ==) | `90.86% <0.00%> (+0.91%)` | :arrow_up: |\n| [src/transformers/tokenization\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5278/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHMucHk=) | `92.78% <0.00%> (+1.30%)` | :arrow_up: |\n| [src/transformers/data/processors/squad.py](https://codecov.io/gh/huggingface/transformers/pull/5278/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9kYXRhL3Byb2Nlc3NvcnMvc3F1YWQucHk=) | `56.68% <0.00%> (+28.02%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/5278?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5278?src=pr&el=footer). Last update [24f46ea...6f28be5](https://codecov.io/gh/huggingface/transformers/pull/5278?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "This looks obnoxiously large in the diff viewer. Should we do some fancy markdown instead of\r\n```markdown\r\n\r\n```\r\n", "The README view is fixed-width on GitHub so you should be fine.\r\n\r\nHowever, I would try to find a more permanent host/URL for your image, I suspect your fork's branch will get deleted at some point.", "#5394" ]

[]

[]

[]

[ { "id": 1838412367, "node_id": "MDU6TGFiZWwxODM4NDEyMzY3", "url": "https://api.github.com/repos/huggingface/transformers/labels/model%20card", "name": "model card", "color": "92d5f4", "default": false, "description": "Related to pretrained model cards" } ]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5276?src=pr&el=h1) Report\n> Merging [#5276](https://codecov.io/gh/huggingface/transformers/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/0e1fce3c0129d05b65a83cdd89e8eadded553f2e&el=desc) will **decrease** coverage by `1.46%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/5276?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #5276 +/- ##\n==========================================\n- Coverage 79.11% 77.64% -1.47% \n==========================================\n Files 138 138 \n Lines 24080 24080 \n==========================================\n- Hits 19050 18698 -352 \n- Misses 5030 5382 +352 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/5276?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/modeling\\_tf\\_pytorch\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5276/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9weXRvcmNoX3V0aWxzLnB5) | `8.17% <0.00%> (-81.14%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_openai.py](https://codecov.io/gh/huggingface/transformers/pull/5276/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9vcGVuYWkucHk=) | `19.92% <0.00%> (-75.00%)` | :arrow_down: |\n| [src/transformers/pipelines.py](https://codecov.io/gh/huggingface/transformers/pull/5276/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9waXBlbGluZXMucHk=) | `66.72% <0.00%> (-9.69%)` | :arrow_down: |\n| [src/transformers/modeling\\_auto.py](https://codecov.io/gh/huggingface/transformers/pull/5276/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19hdXRvLnB5) | `63.95% <0.00%> (-6.98%)` | :arrow_down: |\n| [src/transformers/modeling\\_ctrl.py](https://codecov.io/gh/huggingface/transformers/pull/5276/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19jdHJsLnB5) | `96.58% <0.00%> (-2.57%)` | :arrow_down: |\n| [src/transformers/modeling\\_xlnet.py](https://codecov.io/gh/huggingface/transformers/pull/5276/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ194bG5ldC5weQ==) | `76.35% <0.00%> (-2.30%)` | :arrow_down: |\n| [src/transformers/modeling\\_distilbert.py](https://codecov.io/gh/huggingface/transformers/pull/5276/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19kaXN0aWxiZXJ0LnB5) | `95.97% <0.00%> (-1.73%)` | :arrow_down: |\n| [src/transformers/configuration\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5276/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9jb25maWd1cmF0aW9uX3V0aWxzLnB5) | `94.92% <0.00%> (-1.45%)` | :arrow_down: |\n| [src/transformers/trainer.py](https://codecov.io/gh/huggingface/transformers/pull/5276/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90cmFpbmVyLnB5) | `38.20% <0.00%> (-1.42%)` | :arrow_down: |\n| [src/transformers/modeling\\_openai.py](https://codecov.io/gh/huggingface/transformers/pull/5276/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19vcGVuYWkucHk=) | `79.51% <0.00%> (-1.39%)` | :arrow_down: |\n| ... and [5 more](https://codecov.io/gh/huggingface/transformers/pull/5276/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/5276?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5276?src=pr&el=footer). Last update [0e1fce3...de13069](https://codecov.io/gh/huggingface/transformers/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n", "Well - this issue is still open IMO...", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n", "Maybe better to ask to the original RoBERTa authors or on the forum at https://discuss.huggingface.co?\r\n\r\nWe are trying to keep the issues for bug/features reports now.", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[]

[]

[]

[]

[]

[ "Hi, I tried reproducing with the following code, but couldn't get it to crash:\r\n\r\n```py\r\nfrom transformers import BertTokenizer, BertModel, BertConfig\r\n\r\nclass Args:\r\n bert_model = \"bert-large-uncased\"\r\n\r\nargs = Args()\r\n\r\nconfig = BertConfig.from_pretrained(args.bert_model, output_hidden_states = True, output_attentions = True)\r\ntokenizer = BertTokenizer.from_pretrained(args.bert_model, do_lower_case=True, output_hidden_states=True)\r\nbert = BertModel.from_pretrained(args.bert_model, config = config) # args.bert_model is 'bert-large-uncased'\r\n```\r\n\r\nCan you specify your environment? Are you sure your `args.bert_model` is `bert-large-uncased`?", "I made a stupid mistake. The bert model is used in two places in my code, and the second place is\r\n`\r\n config = BertConfig(args.bert_model, output_hidden_states = True, output_attentions = True)\r\n bert = BertModel.from_pretrained(args.bert_model, config = config)\r\n`\r\nwhere I forgot to use the from_pretrained function for config, the right code should be\r\n`\r\n config = BertConfig.from_pretrained(args.bert_model, output_hidden_states = True, output_attentions = True)\r\n bert = BertModel.from_pretrained(args.bert_model, config = config)\r\n`" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "Same, I can't replicate the results in the README file.", "> Same, I can't replicate the results in the README file.\r\n\r\nI also try to use BERT-large-uncased model and get 0.6209 eval_mnli/acc and 0.6281 eval_mnli-mm/acc.", "FYI, I can get 84.25 eval_mnli/acc by using a non-zero number of warmup steps. . \r\nSpecifically, adding these lines in `trainer.py`:\r\n```\r\nwarmup_steps = float(num_training_steps)*0.1\r\nscheduler = get_linear_schedule_with_warmup(optimizer, num_warmup_steps=warmup_steps, num_training_steps=num_training_steps)\r\n```", "> FYI, I can get 84.25 eval_mnli/acc by using a non-zero number of warmup steps. .\r\n> Specifically, adding these lines in `trainer.py`:\r\n> \r\n> ```\r\n> warmup_steps = float(num_training_steps)*0.1\r\n> scheduler = get_linear_schedule_with_warmup(optimizer, num_warmup_steps=warmup_steps, num_training_steps=num_training_steps)\r\n> ```\r\n\r\nMany thanks for your sharing. Cheers!", "> FYI, I can get 84.25 eval_mnli/acc by using a non-zero number of warmup steps. .\r\n> Specifically, adding these lines in `trainer.py`:\r\n> \r\n> ```\r\n> warmup_steps = float(num_training_steps)*0.1\r\n> scheduler = get_linear_schedule_with_warmup(optimizer, num_warmup_steps=warmup_steps, num_training_steps=num_training_steps)\r\n> ```\r\nHi, Chaitanya. I try to fix the code, but I got an error when running the new program. Here is a double check that does the path of the ``trainer.py`` is ``src/transformers/trainer.py``? And the lines you added are beginning from the line 312 in the ``trainer.py``? Does the original code is ``scheduler = get_linear_schedule_with_warmup(\r\n optimizer, num_warmup_steps=self.args.warmup_steps, num_training_steps=num_training_steps\r\n )``? Many Thanks.\r\n\r\n", "Adding a non-zero number of warmup steps in `src/transformers/trainer.py` is the only change I made. This error seems to occur because you have an output label that is outside the range [0, n_classes) while computing the loss. \r\nDid you make any other changes to the trainer/dataset? And are you training with the original MNLI dataset?", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[ { "id": 1936351150, "node_id": "MDU6TGFiZWwxOTM2MzUxMTUw", "url": "https://api.github.com/repos/huggingface/transformers/labels/Examples", "name": "Examples", "color": "d4c5f9", "default": false, "description": "Which is related to examples in general" } ]

[ { "login": "sshleifer", "id": 6045025, "node_id": "MDQ6VXNlcjYwNDUwMjU=", "avatar_url": "https://avatars.githubusercontent.com/u/6045025?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sshleifer", "html_url": "https://github.com/sshleifer", "followers_url": "https://api.github.com/users/sshleifer/followers", "following_url": "https://api.github.com/users/sshleifer/following{/other_user}", "gists_url": "https://api.github.com/users/sshleifer/gists{/gist_id}", "starred_url": "https://api.github.com/users/sshleifer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sshleifer/subscriptions", "organizations_url": "https://api.github.com/users/sshleifer/orgs", "repos_url": "https://api.github.com/users/sshleifer/repos", "events_url": "https://api.github.com/users/sshleifer/events{/privacy}", "received_events_url": "https://api.github.com/users/sshleifer/received_events", "type": "User", "site_admin": false } ]

[ "Seems to be coming from the --warmup_steps arg. If I set to 0, the model seems to learn as expected. If it is > 0 the model doesn't learn anything.", "Interesting. Could you link me to that dataset/instructions?\r\nI just reran cnn_dm with warmup_steps=0 and my loss curve looks very similar in wandb. pink is no warmup:\r\n\r\n\r\n\r\nAnyways, I will set default warmup_steps=0.\r\n", "Hmmm interesting, I agree yours both look normal. I am using Pubmed dataset and truncating input docs at 850 input tokens. I'm pretty sure my model wasn't learning anything when warmuo_steps>0 for the following reasons:\r\n- The generated summaries were identical across training\r\n- The target summaries begin with '\\<S\\>' token but I believe the CNN data the model was finetuned on didn't. As a result, the model learns to begin output summaries with '\\<S\\>' very quickly. However, for each case with warmup_steps > 0 the generated val summaries didn't begin with this token\r\n- Loss curves below (orange: warmup_steps>0, grey: warmup_steps=0):\r\n- When warmup_steps>0 model followed identical loss curves even after a changed hparams like learning rate\r\n\r\n<img width=\"561\" alt=\"Screenshot 2020-06-26 at 16 56 37\" src=\"https://user-images.githubusercontent.com/51463426/85877481-22e88b00-b7cf-11ea-8b21-11320c0737b4.png\">\r\n\r\nI played around with it quite a bit and this pattern repeated for any warmp_steps>0 (including =1).", "That is pretty compelling evidence.\r\nI will change the default to 0.\r\nNothing else changed between runs?\r\n\r\n", "Yes- I have tried across runs changing only this hparam.", "Interesting. I fixed master. Would love to hear your experimental results/developer experience as you continue!", "For sure, I'll pop in this library lots over the coming weeks I'm sure. Great library btw" ]

[ { "id": 1838412367, "node_id": "MDU6TGFiZWwxODM4NDEyMzY3", "url": "https://api.github.com/repos/huggingface/transformers/labels/model%20card", "name": "model card", "color": "92d5f4", "default": false, "description": "Related to pretrained model cards" } ]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5270?src=pr&el=h1) Report\n> Merging [#5270](https://codecov.io/gh/huggingface/transformers/pull/5270?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/0e1fce3c0129d05b65a83cdd89e8eadded553f2e&el=desc) will **decrease** coverage by `0.02%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/5270?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #5270 +/- ##\n==========================================\n- Coverage 79.11% 79.08% -0.03% \n==========================================\n Files 138 138 \n Lines 24080 24080 \n==========================================\n- Hits 19050 19043 -7 \n- Misses 5030 5037 +7 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/5270?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/modeling\\_openai.py](https://codecov.io/gh/huggingface/transformers/pull/5270/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19vcGVuYWkucHk=) | `79.51% <0.00%> (-1.39%)` | :arrow_down: |\n| [src/transformers/trainer.py](https://codecov.io/gh/huggingface/transformers/pull/5270/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90cmFpbmVyLnB5) | `38.44% <0.00%> (-1.18%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5270/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl91dGlscy5weQ==) | `87.77% <0.00%> (ø)` | |\n| [src/transformers/file\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5270/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9maWxlX3V0aWxzLnB5) | `77.18% <0.00%> (+0.76%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/5270?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5270?src=pr&el=footer). Last update [0e1fce3...67157e9](https://codecov.io/gh/huggingface/transformers/pull/5270?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[]

[]

[ "@LysandreJik Sorry for the inconvenience :(", "Will merge once the code quality passes", "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5269?src=pr&el=h1) Report\n> Merging [#5269](https://codecov.io/gh/huggingface/transformers/pull/5269?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/0e1fce3c0129d05b65a83cdd89e8eadded553f2e&el=desc) will **decrease** coverage by `0.07%`.\n> The diff coverage is `6.25%`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/5269?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #5269 +/- ##\n==========================================\n- Coverage 79.11% 79.03% -0.08% \n==========================================\n Files 138 138 \n Lines 24080 24102 +22 \n==========================================\n- Hits 19050 19049 -1 \n- Misses 5030 5053 +23 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/5269?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/trainer\\_tf.py](https://codecov.io/gh/huggingface/transformers/pull/5269/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90cmFpbmVyX3RmLnB5) | `17.85% <6.25%> (-0.84%)` | :arrow_down: |\n| [src/transformers/modeling\\_openai.py](https://codecov.io/gh/huggingface/transformers/pull/5269/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19vcGVuYWkucHk=) | `79.51% <0.00%> (-1.39%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5269/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl91dGlscy5weQ==) | `87.92% <0.00%> (+0.14%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/5269?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5269?src=pr&el=footer). Last update [0e1fce3...78562e2](https://codecov.io/gh/huggingface/transformers/pull/5269?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "All tests are ok!" ]

[]

[]

[]

[]

[]

[ "hi @y-rokutan, you are right, `DataCollator` is not a `Class` anymore, its a `callable` now, so remove subclassing and change `collate_batch` method to ` __call__` \r\n\r\nI'll update the notebook once new version of transformers is released", "hi @patil-suraj, thx for your quick reply. I appreciate your contributions.\r\nDo you have any idea about ValueError issue? I'm googling for fix but still have the same error.", "What is your nlp version ? Try using nlp==0.2.0", "`!pip install -U nlp==0.2.0` worked! nlp0.3.0 seems not for this notebook. Thx!", "hi i am running the notebook without any changes . But its very slow i think its not using TPU at all" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null }, { "id": 1834056635, "node_id": "MDU6TGFiZWwxODM0MDU2NjM1", "url": "https://api.github.com/repos/huggingface/transformers/labels/Core:%20Tokenization", "name": "Core: Tokenization", "color": "FF4446", "default": false, "description": "Internals of the library; Tokenization." } ]

[]

[ "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[ { "id": 1108649053, "node_id": "MDU6TGFiZWwxMTA4NjQ5MDUz", "url": "https://api.github.com/repos/huggingface/transformers/labels/Help%20wanted", "name": "Help wanted", "color": "008672", "default": false, "description": "Extra attention is needed, help appreciated" } ]

[ { "login": "sshleifer", "id": 6045025, "node_id": "MDQ6VXNlcjYwNDUwMjU=", "avatar_url": "https://avatars.githubusercontent.com/u/6045025?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sshleifer", "html_url": "https://github.com/sshleifer", "followers_url": "https://api.github.com/users/sshleifer/followers", "following_url": "https://api.github.com/users/sshleifer/following{/other_user}", "gists_url": "https://api.github.com/users/sshleifer/gists{/gist_id}", "starred_url": "https://api.github.com/users/sshleifer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sshleifer/subscriptions", "organizations_url": "https://api.github.com/users/sshleifer/orgs", "repos_url": "https://api.github.com/users/sshleifer/repos", "events_url": "https://api.github.com/users/sshleifer/events{/privacy}", "received_events_url": "https://api.github.com/users/sshleifer/received_events", "type": "User", "site_admin": false } ]

[ "note to self: enro also fails on cpu, and rerunning on commit where it was green now fails. So change is something S3 related.\r\n", "```python\r\ntests/test_pipelines.py:148: in _test_mono_column_pipeline\r\n set([o[key] for o in result]), set([o[key] for o in expect]),\r\nE AssertionError: Items in the first set but not the second:\r\nE '<s>My name is Chris</s>'\r\nE '<s>My name is John</s>'\r\nE Items in the second set but not the first:\r\nE '<s> My name is John</s>'\r\nE '<s> My name is:</s>'\r\n```" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[ { "id": 1936351150, "node_id": "MDU6TGFiZWwxOTM2MzUxMTUw", "url": "https://api.github.com/repos/huggingface/transformers/labels/Examples", "name": "Examples", "color": "d4c5f9", "default": false, "description": "Which is related to examples in general" }, { "id": 2009457320, "node_id": "MDU6TGFiZWwyMDA5NDU3MzIw", "url": "https://api.github.com/repos/huggingface/transformers/labels/translation", "name": "translation", "color": "b2d2f4", "default": false, "description": "machine translation utilities and models" }, { "id": 2039044877, "node_id": "MDU6TGFiZWwyMDM5MDQ0ODc3", "url": "https://api.github.com/repos/huggingface/transformers/labels/marian", "name": "marian", "color": "30cc95", "default": false, "description": "" } ]

[ { "login": "sshleifer", "id": 6045025, "node_id": "MDQ6VXNlcjYwNDUwMjU=", "avatar_url": "https://avatars.githubusercontent.com/u/6045025?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sshleifer", "html_url": "https://github.com/sshleifer", "followers_url": "https://api.github.com/users/sshleifer/followers", "following_url": "https://api.github.com/users/sshleifer/following{/other_user}", "gists_url": "https://api.github.com/users/sshleifer/gists{/gist_id}", "starred_url": "https://api.github.com/users/sshleifer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sshleifer/subscriptions", "organizations_url": "https://api.github.com/users/sshleifer/orgs", "repos_url": "https://api.github.com/users/sshleifer/repos", "events_url": "https://api.github.com/users/sshleifer/events{/privacy}", "received_events_url": "https://api.github.com/users/sshleifer/received_events", "type": "User", "site_admin": false } ]

[ "Surprised. Maybe the opus data overlaps the wmt test set?", "\r\n", "Opus #s are legit!", "@sshleifer do you using the default configuration in Readme ? I didn't get 37.1, and I have tried the configuration mentioned as original paper, I have got a 36.6 after postprocessing wmt_en_ro enro.\r\n\r\nIn addition, I have a confusion about the code. If I don't add extra parameters, there is a warning in the output log. I try to solve it. I can't set a breakpoint at the place where the warning is generated. It's difficult for me to locate the reason. Can you help me look at it?\r\n\r\n`Keyword arguments {'add_prefix_space': False} not recognized.\r\n`", "(1) Which split, val or test?\r\n(2) What was the score before post-processing?\r\n\r\nThe warning is from [here](https://github.com/huggingface/transformers/blob/master/src/transformers/tokenization_utils.py#L261), you can safely ignore it.\r\n", "### Results on wmt_en_ro/test\r\n```bash\r\npython run_eval.py Helsinki-NLP/opus-mt-en-ro wmt_en_ro/test.source enro_test_translations.txt --reference_path wmt_en_ro/test.target -\r\n-task translation --score_path mar_test_bleu.json --fp16 --bs 64\r\n{'bleu': 27.6865, 'n_obs': 1999, 'runtime': 85, 'seconds_per_sample': 0.0425}\r\n```\r\n```bash\r\nro_post_process enro_finetune/test_generations.txt wmt_en_ro/test.target\r\n# 37.4\r\n```\r\n\r\n### Postprocessing Setup\r\n```bash\r\ncd $HOME\r\ngit clone [email protected]:moses-smt/mosesdecoder.git\r\ncd mosesdecoder \r\ngit clone [email protected]:rsennrich/wmt16-scripts.git\r\nro_post_process () {\r\n sys=$1\r\n ref=$2\r\n export MOSES_PATH=$HOME/mosesdecoder\r\n REPLACE_UNICODE_PUNCT=$MOSES_PATH/scripts/tokenizer/replace-unicode-punctuation.perl\r\n NORM_PUNC=$MOSES_PATH/scripts/tokenizer/normalize-punctuation.perl\r\n REM_NON_PRINT_CHAR=$MOSES_PATH/scripts/tokenizer/remove-non-printing-char.perl\r\n REMOVE_DIACRITICS=$MOSES_PATH/wmt16-scripts/preprocess/remove-diacritics.py\r\n NORMALIZE_ROMANIAN=$MOSES_PATH/wmt16-scripts/preprocess/normalise-romanian.py\r\n TOKENIZER=$MOSES_PATH/scripts/tokenizer/tokenizer.perl\r\n\r\n\r\n\r\n lang=ro\r\n for file in $sys $ref; do\r\n cat $file \\\r\n | $REPLACE_UNICODE_PUNCT \\\r\n | $NORM_PUNC -l $lang \\\r\n | $REM_NON_PRINT_CHAR \\\r\n | $NORMALIZE_ROMANIAN \\\r\n | $REMOVE_DIACRITICS \\\r\n | $TOKENIZER -no-escape -l $lang \\\r\n > $(basename $file).tok\r\n done\r\n # compute BLEU\r\n cat $(basename $sys).tok | sacrebleu -tok none -s none -b $(basename $ref).tok\r\n}\r\n```\r\n\r\n\r\n```bash\r\nro_post_process enro_test_translations.txt wmt_en_ro/test.target\r\n```\r\n", "@sshleifer That's warning can be sefaly ignore it, that is great, I have try to figure out the reason for occuring.\r\n\r\nI using the test set, I have got 21.9 before post-processing. I'm using this postprocessing setup and run_eval.py, My analysis is that my model performance is not enough, maybe the fine-tuning parameters are inaccurate, or there are too many training steps during fine-tuning. \r\n\r\nI am using this version with following code link.\r\nhttps://github.com/huggingface/transformers/blob/b9772897ec9f54c1a83263b059bfd37acda936d5/examples/seq2seq/finetune.py#L371\r\n\r\nthis has been changed in lastest version. \r\nhttps://github.com/huggingface/transformers/blob/9e89390ce1e785e72452207139a334cd3bf745ff/examples/seq2seq/finetune.py#L396\r\n\r\nI am not a native English speaker, If my words is unclear, you can let me repeat it in time.\r\n", "I don't understand what code you ran, what you expected to happen, and what happened.\r\n\r\nThe change you highlight should not affect your results.", "my last comment has two question.\r\nthe first question is my results can not be 37.7.\r\nthe second question is I set save_top_k ==-1, I have solved it \r\n\r\nthe follows is my runing parameters for the first question.\r\n`bash train_mbart_cc25_enro_pap.sh --output_dir $OUTPUT_DIR --gpus 1 --sortish_sampler`\r\n\r\nwhere train_mbart_cc25_enro_pap.sh as follows :\r\n\r\n```\r\nBS=16\r\nMAX_LEN=128\r\npython finetune.py \\\r\n --learning_rate=3e-5 \\\r\n --do_train \\\r\n --val_check_interval=0.25 \\\r\n --adam_eps 1e-06 \\\r\n --num_train_epochs 4 --src_lang en_XX --tgt_lang ro_RO \\\r\n --data_dir $ENRO_DIR \\\r\n --max_source_length $MAX_LEN --max_target_length $MAX_LEN --val_max_target_length $MAX_LEN --test_max_target_length $MAX_LEN \\\r\n --train_batch_size=$BS --eval_batch_size=$BS \\\r\n --task translation \\\r\n --warmup_steps 2500 \\\r\n --freeze_embeds \\\r\n --model_name_or_path=$MODEL_PATH \\\r\n --label_smoothing 0.2 \\\r\n --dropout 0.3 \\\r\n \"$@\"\r\n```", "that's my transformers report bleu as follows, 21.9 is using sacrebleu before postprocessing. @sshleifer \r\n```{'bleu':` 26.0506, 'n_obs': 1999, 'runtime': 681, 'seconds_per_sample': 0.3407}```\r\n\r\nand I have try to using the configuration as README with using `--fp16`, and I get a error log as follows :\r\n```\r\n2020-09-15 15:58:46.000 [INFO] [Driver] RuntimeError: CUDA out of memory. Tried to allocate 490.00 MiB (GPU 0; 31.75 GiB total capacity; 29.17 GiB already allocated; 241.44 MiB free; 30.35 GiB reserved in total by PyTorch)\r\n```\r\n\r\nand I have see the README mentioned as follows\r\n\r\n> This should take < 6h/epoch on a 16GB v100 and achieve test BLEU above 26 To get results in line with fairseq, you need to do some postprocessing. \r\n", "+ 26.06 is definitely expected behavior, as the README indicates. \r\n+ The best I've ever scored from finetuning is 26.8 after training for 6 epochs. (Took 24h).\r\n+ `--save_top-k=-1`, I can look into.\r\n+ What command did you run with `sacrebleu` to get 21.9? The HF run_eval.py uses the `sacrebleu.corpus_bleu` python function.\r\n+ I would recommend playing with the Helsinki-NLP/ models for faster MT finetuning.", "> * 26.06 is definitely expected behavior, as the README indicates.\r\n> * The best I've ever scored from finetuning is 26.8 after training for 6 epochs. (Took 24h).\r\n> * `--save_top-k=-1`, I can look into.\r\n> * What command did you run with `sacrebleu` to get 21.9? The HF run_eval.py uses the `sacrebleu.corpus_bleu` python function.\r\n> * I would recommend playing with the Helsinki-NLP/ models for faster MT finetuning.\r\n\r\n@sshleifer Hi , Thank you for your kindness help. I have got a closer score 37.2 to 37.7, I have a curious question, why is `Helsinki-NLP/ models` faster ?\r\n\r\n", "They are way smaller: 74 million parameters (Marian) vs 610M (mBART)" ]

[ { "id": 1845609017, "node_id": "MDU6TGFiZWwxODQ1NjA5MDE3", "url": "https://api.github.com/repos/huggingface/transformers/labels/seq2seq", "name": "seq2seq", "color": "fef2c0", "default": false, "description": "" }, { "id": 2159774240, "node_id": "MDU6TGFiZWwyMTU5Nzc0MjQw", "url": "https://api.github.com/repos/huggingface/transformers/labels/wandb", "name": "wandb", "color": "f9e05e", "default": false, "description": "" } ]

[ { "login": "sshleifer", "id": 6045025, "node_id": "MDQ6VXNlcjYwNDUwMjU=", "avatar_url": "https://avatars.githubusercontent.com/u/6045025?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sshleifer", "html_url": "https://github.com/sshleifer", "followers_url": "https://api.github.com/users/sshleifer/followers", "following_url": "https://api.github.com/users/sshleifer/following{/other_user}", "gists_url": "https://api.github.com/users/sshleifer/gists{/gist_id}", "starred_url": "https://api.github.com/users/sshleifer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sshleifer/subscriptions", "organizations_url": "https://api.github.com/users/sshleifer/orgs", "repos_url": "https://api.github.com/users/sshleifer/repos", "events_url": "https://api.github.com/users/sshleifer/events{/privacy}", "received_events_url": "https://api.github.com/users/sshleifer/received_events", "type": "User", "site_admin": false } ]

[ "You should be able to do it with environment variables. See [these docs](https://docs.wandb.com/library/environment-variables)\r\nLet me know if that solves the issue.\r\n\r\nThe reason of the current implementation (and auto init of wandb) was to be able to instrument all example scripts without having to add custom wandb code.\r\n\r\nThere is [documentation on W&B related to transformers](https://docs.wandb.com/library/integrations/huggingface) that probably need to be updated to add this detail. We should probably also find a place to add documentation related to W&B integration in transformers repo. Let me know if I can be of any help.", "You could make `examples/wandb.md` with information and link to it from `examples/README.md`? Or just link to [this](https://docs.wandb.com/library/integrations/huggingface) in `examples/README.md`\r\n\r\nFor the lightning `WandbLogger` integration, does `$WANDB_PROJECT` take precedence over passing `WandbLogger(project='project_name')`?", "Thanks, that's a great idea!\r\n\r\nFor the lightning integration, any parameter you pass explicitly in `WandbLogger` should take precedence.\r\n", "@sshleifer it seems that the pytorch-lightning integration is commonly used so I also added a reference to it in my PR.\r\nJust curious, is it because you cannot do distributed computing with `Trainer` on multiple machines?\r\n\r\nWould it make sense to add an easier integration on `lightning_base` with a similar logic to `Trainer` and `TFTrainer`, ie by using `WandbLogger` on `generic_train` whenever wandb is installed and logged in (and ignore it otherwise)?", "As long as we can avoid\r\n(1) generating a lot of logs when I run the unittests on my local machine\r\n(2) enabling gradient watching by default\r\n\r\nThat sounds like a good change to me. @patil-suraj what do you think? do you use wandb?", "Yes, adding wandb integration on `lightning_base` makes sense to me given wandb is enabled by default in `Trainer` and `TFTraner` , this will enable wandb logging for `run_pl_ner` and `run_pl_glue`\r\n\r\nWith `Trainer` I can disable logging when I'm testing using `WANDB_DISABLED` env variable and gradient watching by setting \r\n`WANDB_WATCH` . \r\n\r\nenv variables should avoid excessive command line args", "Thanks for the feedback @sshleifer and @patil-suraj \r\nI can try to propose something similar for `lightning_base`. I'll wait for PR #5607 to be closed (feel free to comment if you think it's missing details) and I'll update the README accordingly when adding this functionality.", "Awesome. I had no idea that PR existed. Tag me next time and sorry for being so slow." ]

[ { "id": 2139563322, "node_id": "MDU6TGFiZWwyMTM5NTYzMzIy", "url": "https://api.github.com/repos/huggingface/transformers/labels/cleanup", "name": "cleanup", "color": "e7fc49", "default": false, "description": "" } ]

[ { "login": "sshleifer", "id": 6045025, "node_id": "MDQ6VXNlcjYwNDUwMjU=", "avatar_url": "https://avatars.githubusercontent.com/u/6045025?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sshleifer", "html_url": "https://github.com/sshleifer", "followers_url": "https://api.github.com/users/sshleifer/followers", "following_url": "https://api.github.com/users/sshleifer/following{/other_user}", "gists_url": "https://api.github.com/users/sshleifer/gists{/gist_id}", "starred_url": "https://api.github.com/users/sshleifer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sshleifer/subscriptions", "organizations_url": "https://api.github.com/users/sshleifer/orgs", "repos_url": "https://api.github.com/users/sshleifer/repos", "events_url": "https://api.github.com/users/sshleifer/events{/privacy}", "received_events_url": "https://api.github.com/users/sshleifer/received_events", "type": "User", "site_admin": false } ]

[ "I think that would be cool. Since we're testing the examples, it makes sense to not duplicate the exact same code.", "Sounds good to me" ]

[ { "id": 1834056635, "node_id": "MDU6TGFiZWwxODM0MDU2NjM1", "url": "https://api.github.com/repos/huggingface/transformers/labels/Core:%20Tokenization", "name": "Core: Tokenization", "color": "FF4446", "default": false, "description": "Internals of the library; Tokenization." } ]

[]

[ "Hi @jarednielsen, if you installed from source then padding is handled in a different way. You'll need to use the newly added `padding` argument. According to the docs \r\n\r\n`padding` (:obj:`Union[bool, str]`, `optional`, defaults to :obj:`False`):\r\n Activate and control padding. Accepts the following values:\r\n \r\n * `True` or `'longest'`: pad to the longest sequence in the batch (or no padding if only a single sequence if provided),\r\n * `'max_length'`: pad to a max length specified in `max_length` or to the max acceptable input length for the model if no length is provided (`max_length=None`)\r\n * `False` or `'do_not_pad'` (default): No padding (i.e. can output batch with sequences of uneven lengths)\r\n", "Yes, this works on master (both the old and new tokenizer API) and should work in the new release that will be out very soon.", "Thank you for the quick response! Reading https://github.com/huggingface/transformers/pull/4510 makes it much clearer.", "Yes, we even have a nice tutorial on the new tokenizer API now thanks to the amazing @sgugger:\r\nhttps://huggingface.co/transformers/master/preprocessing.html" ]

[ { "id": 1838412367, "node_id": "MDU6TGFiZWwxODM4NDEyMzY3", "url": "https://api.github.com/repos/huggingface/transformers/labels/model%20card", "name": "model card", "color": "92d5f4", "default": false, "description": "Related to pretrained model cards" } ]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5259?src=pr&el=h1) Report\n> Merging [#5259](https://codecov.io/gh/huggingface/transformers/pull/5259?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/d12ceb48bad126768e44d2bd958fa7638abd0f16&el=desc) will **decrease** coverage by `0.03%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/5259?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #5259 +/- ##\n==========================================\n- Coverage 79.10% 79.07% -0.04% \n==========================================\n Files 138 138 \n Lines 24073 24073 \n==========================================\n- Hits 19043 19035 -8 \n- Misses 5030 5038 +8 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/5259?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/modeling\\_tf\\_pytorch\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5259/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9weXRvcmNoX3V0aWxzLnB5) | `88.05% <0.00%> (-1.26%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5259/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl91dGlscy5weQ==) | `86.89% <0.00%> (-0.89%)` | :arrow_down: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/5259?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5259?src=pr&el=footer). Last update [d12ceb4...39fef05](https://codecov.io/gh/huggingface/transformers/pull/5259?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "Thanks for sharing 🤗 \r\n\r\n[model page](https://huggingface.co/moumeneb1/flaubert-base-cased-ecology_crisis)" ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5258?src=pr&el=h1) Report\n> Merging [#5258](https://codecov.io/gh/huggingface/transformers/pull/5258?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/efae6645e223f29cf05eeafe95105a9f869b66dd&el=desc) will **decrease** coverage by `0.51%`.\n> The diff coverage is `50.00%`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/5258?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #5258 +/- ##\n==========================================\n- Coverage 77.69% 77.17% -0.52% \n==========================================\n Files 138 138 \n Lines 24291 24300 +9 \n==========================================\n- Hits 18872 18754 -118 \n- Misses 5419 5546 +127 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/5258?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/pipelines.py](https://codecov.io/gh/huggingface/transformers/pull/5258/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9waXBlbGluZXMucHk=) | `75.13% <0.00%> (-0.32%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5258/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl91dGlscy5weQ==) | `87.39% <50.00%> (-0.10%)` | :arrow_down: |\n| [src/transformers/modeling\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5258/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ191dGlscy5weQ==) | `90.93% <50.00%> (-0.21%)` | :arrow_down: |\n| [src/transformers/tokenization\\_utils\\_base.py](https://codecov.io/gh/huggingface/transformers/pull/5258/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHNfYmFzZS5weQ==) | `92.39% <66.66%> (-1.32%)` | :arrow_down: |\n| [src/transformers/configuration\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5258/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9jb25maWd1cmF0aW9uX3V0aWxzLnB5) | `95.68% <100.00%> (+0.03%)` | :arrow_up: |\n| [src/transformers/tokenization\\_xlm.py](https://codecov.io/gh/huggingface/transformers/pull/5258/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25feGxtLnB5) | `16.26% <0.00%> (-66.67%)` | :arrow_down: |\n| [src/transformers/tokenization\\_transfo\\_xl.py](https://codecov.io/gh/huggingface/transformers/pull/5258/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdHJhbnNmb194bC5weQ==) | `33.56% <0.00%> (-8.93%)` | :arrow_down: |\n| [src/transformers/file\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5258/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9maWxlX3V0aWxzLnB5) | `79.26% <0.00%> (-0.34%)` | :arrow_down: |\n| ... and [4 more](https://codecov.io/gh/huggingface/transformers/pull/5258/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/5258?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5258?src=pr&el=footer). Last update [1af58c0...ac579a6](https://codecov.io/gh/huggingface/transformers/pull/5258?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "I'm favorable to this (I think I wanted to do it some time ago)\r\n\r\nIf we end up merging this, we should also clean up a lot of `os.makedir` calls \"upstream\" to this (example scripts, etc.)", "Awesome, I'll grep for makedirs and mkdir and see what I can delete tomorrow.", "Great change! ", "@thomwolf why did you guys put `logger.error` instead of the raising normal exceptions in the python tokenizer file?  Should I raise a `NotADirectoryException` if a save path is mis-specified as a file or keep the `logger.error`, `return None` logic?\r\n\r\nThis will be for calls like `tokenizer.save_pretrained(\"tokenizer.json\")`", "You should also clean up some calls to `os.makedir` in the Trainer, I think?" ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5257?src=pr&el=h1) Report\n> Merging [#5257](https://codecov.io/gh/huggingface/transformers/pull/5257?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/0148c262e79f5ca12140d7fc35a6d3e0d80d5d3b&el=desc) will **decrease** coverage by `0.90%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/5257?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #5257 +/- ##\n==========================================\n- Coverage 79.01% 78.10% -0.91% \n==========================================\n Files 138 138 \n Lines 24064 24064 \n==========================================\n- Hits 19013 18795 -218 \n- Misses 5051 5269 +218 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/5257?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/modeling\\_tf\\_t5.py](https://codecov.io/gh/huggingface/transformers/pull/5257/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl90NS5weQ==) | `49.30% <0.00%> (-42.12%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5257/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl91dGlscy5weQ==) | `85.71% <0.00%> (-2.07%)` | :arrow_down: |\n| [src/transformers/modeling\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5257/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ191dGlscy5weQ==) | `91.14% <0.00%> (-0.13%)` | :arrow_down: |\n| [src/transformers/trainer.py](https://codecov.io/gh/huggingface/transformers/pull/5257/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90cmFpbmVyLnB5) | `39.38% <0.00%> (+0.94%)` | :arrow_up: |\n| [src/transformers/modeling\\_openai.py](https://codecov.io/gh/huggingface/transformers/pull/5257/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19vcGVuYWkucHk=) | `80.90% <0.00%> (+1.38%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/5257?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5257?src=pr&el=footer). Last update [0148c26...7bf3c46](https://codecov.io/gh/huggingface/transformers/pull/5257?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[ { "id": 1834056635, "node_id": "MDU6TGFiZWwxODM0MDU2NjM1", "url": "https://api.github.com/repos/huggingface/transformers/labels/Core:%20Tokenization", "name": "Core: Tokenization", "color": "FF4446", "default": false, "description": "Internals of the library; Tokenization." } ]

[]

[ "For records for the new users: Now, it seemed to have been resolved. I tried to reproduce this in my notebook but getting same results for both of them:\r\n\r\n<img width=\"1383\" alt=\"image\" src=\"https://github.com/huggingface/transformers/assets/104596164/bde951ac-8b9c-4996-966b-1d11f4c12d35\">\r\n" ]

[]

[]

[]