message
stringlengths
6
474
diff
stringlengths
8
5.22k
Use flang rather than amdflang for test
set -x export AOMP - $AOMP/bin/amdflang \ + $AOMP/bin/flang \ -DCLOUDSC_GPU_OMP_SCC -DCLOUDSC_GPU_SCC -DCLOUDSC_STMT_FUNC -DHAVE_HDF5 \ -fpic -fPIE \ -fopenmp -fopenmp-targets=amdgcn-amd-amdhsa -Xopenmp-target=amdgcn-amd-amdhsa -march=gfx908 \ @@ -10,7 +10,7 @@ export AOMP -o cloudsc_gpu_omp_scc_mod.F90.o - $AOMP/bin/amdflang \ + $AOMP/bin/flang \ -DCLOUDSC_GPU_OMP_SCC -DCLOUDSC_GPU_SCC -DCLOUDSC_STMT_FUNC -DHAVE_HDF5 \ -fpic -fPIE \ -fopenmp -fopenmp-targets=amdgcn-amd-amdhsa -Xopenmp-target=amdgcn-amd-amdhsa -march=gfx908 \
build pedal image in CI
@@ -28,6 +28,10 @@ jobs: name: Build Panda STM image command: | docker run panda_build /bin/bash -c "cd /panda/board; make bin" + - run: + name: Build Pedal STM image + command: | + docker run panda_build /bin/bash -c "cd /panda/board/pedal; make obj/comma.bin" - run: name: Build NEO STM image command: |
Changed uintptr_t to size_t. WinCE6 doesn't seem it have the definition.
@@ -567,8 +567,8 @@ static int win32_pathbyaddr(void *addr, char *path, int sz) /* Enumerate the modules to find one which includes me. */ do { - if ((uintptr_t) addr >= (uintptr_t) me32.modBaseAddr && - (uintptr_t) addr < (uintptr_t) (me32.modBaseAddr + me32.modBaseSize)) { + if ((size_t) addr >= (size_t) me32.modBaseAddr && + (size_t) addr < (size_t) (me32.modBaseAddr + me32.modBaseSize)) { (*close_snap) (hModuleSnap); FreeLibrary(dll); # ifdef _WIN32_WCE
Warn user if files are excluded from search
@@ -193,6 +193,10 @@ class NameCheck(object): internal variable self.parse_result. """ self.log.info("Parsing source code...") + self.log.debug( + "The following files are excluded from the search: {}" + .format(str(self.excluded_files)) + ) m_headers = self.get_files("h", os.path.join("include", "mbedtls")) p_headers = self.get_files("h", os.path.join("include", "psa"))
Check for string truncation when creating the <probe>/id path
@@ -932,6 +932,9 @@ static void exit_mount_ns(int fd) { close(fd); } +/* Creates an [uk]probe using debugfs. + * On success, the path to the probe is placed in buf (which is assumed to be of size PATH_MAX). + */ static int create_probe_event(char *buf, const char *ev_name, enum bpf_probe_attach_type attach_type, const char *config1, uint64_t offset, @@ -1026,7 +1029,10 @@ static int bpf_attach_probe(int progfd, enum bpf_probe_attach_type attach_type, // (kernel < 4.12), the event is created under a different name; we need to // delete that event and start again without maxactive. if (is_kprobe && maxactive > 0 && attach_type == BPF_PROBE_RETURN) { - snprintf(fname, sizeof(fname), "%s/id", buf); + if (snprintf(fname, sizeof(fname), "%s/id", buf) >= sizeof(fname)) { + fprintf(stderr, "filename (%s) is too long for buffer\n", buf); + goto error; + } if (access(fname, F_OK) == -1) { // Deleting kprobe event with incorrect name. kfd = open("/sys/kernel/debug/tracing/kprobe_events",
fix unity 5.6 gen code error
@@ -32,6 +32,7 @@ namespace SLua using UnityEditor; using System.Text; using System.Text.RegularExpressions; + using System.Runtime.CompilerServices; public interface ICustomExportPost { } @@ -119,6 +120,11 @@ namespace SLua static bool filterType(Type t, List<string> noUseList, List<string> uselist) { + if (t.IsDefined (typeof(CompilerGeneratedAttribute),false)) { + Debug.Log (t.Name + " is filtered out"); + return false; + } + // check type in uselist string fullName = t.FullName; if (uselist != null && uselist.Count > 0) @@ -652,7 +658,7 @@ namespace SLua "Light.lightmappingMode", "MonoBehaviour.runInEditMode", "MonoBehaviour.useGUILayout", - + "PlayableGraph.CreateScriptPlayable", }; @@ -804,6 +810,10 @@ namespace SLua if (!t.IsGenericTypeDefinition && (!IsObsolete(t) && t != typeof(YieldInstruction) && t != typeof(Coroutine)) || (t.BaseType != null && t.BaseType == typeof(System.MulticastDelegate))) { + + if (t.IsNested && t.DeclaringType.IsPublic == false) + return false; + if (t.IsEnum) { StreamWriter file = Begin(t);
graph-store: remove-graph in keys
@@ -75,10 +75,12 @@ const addGraph = (json, state) => { const removeGraph = (json, state) => { const data = _.get(json, 'remove-graph', false); if (data) { + if (!('graphs' in state)) { state.graphs = {}; } let resource = data.ship + '/' + data.name; + state.graphKeys.delete(resource); delete state.graphs[resource]; } };
Decoder: add missing `ZYAN_FALLTHROUGH`
@@ -1862,6 +1862,7 @@ ZyanStatus ZydisDecodeOperands(const ZydisDecoder* decoder, const ZydisDecoderCo { case ZYDIS_SEMANTIC_OPTYPE_REL: ZYAN_ASSERT(instruction->raw.imm[imm_id].is_relative); + ZYAN_FALLTHROUGH; case ZYDIS_SEMANTIC_OPTYPE_IMM: ZYAN_ASSERT((imm_id == 0) || (imm_id == 1)); operands[i].type = ZYDIS_OPERAND_TYPE_IMMEDIATE;
update config-site file for my local linux box.
@@ -116,7 +116,7 @@ VISIT_OPTION_DEFAULT(VISIT_SZIP_DIR ${VISITHOME}/szip/2.1) ## ## ZLIB ## -VISIT_OPTION_DEFAULT(VISIT_ZLIB_DIR ${VISITHOME}/zlib/1.2.7) +VISIT_OPTION_DEFAULT(VISIT_ZLIB_DIR ${VISITHOME}/zlib/1.2.8) ## ## HDF5 @@ -139,8 +139,8 @@ VISIT_OPTION_DEFAULT(VISIT_CONDUIT_LIBDEP HDF5_LIBRARY_DIR hdf5 ${VISIT_HDF5_LIB ## ## FastBit ## -#SETUP_APP_VERSION(FASTBIT 2.0.3) -#VISIT_OPTION_DEFAULT(VISIT_FASTBIT_DIR ${VISITHOME}/fastbit/${FASTBIT_VERSION}) +SETUP_APP_VERSION(FASTBIT 2.0.3) +VISIT_OPTION_DEFAULT(VISIT_FASTBIT_DIR ${VISITHOME}/fastbit/${FASTBIT_VERSION}) ## ## GDAL
CLEANUP: refactored simply the NESTED_PREFIX code tag.
@@ -108,6 +108,7 @@ typedef struct { uint32_t hash; } PREFIX_STATS_elem; #endif + //#define PREFIX_HASH_SIZE 256 #define PREFIX_HASH_SIZE 1024 #define PREFIX_MAX_DEPTH 1 @@ -255,8 +256,7 @@ static PREFIX_STATS *do_stats_prefix_insert(const char *prefix, const size_t npr } } } -#endif -#if 0 // OLD_CODE +#else /* build a prefix stats entry */ pfs = calloc(sizeof(PREFIX_STATS), 1); if (pfs == NULL) { @@ -299,7 +299,7 @@ int stats_prefix_insert(const char *prefix, const size_t nprefix) return (pfs != NULL) ? 0 : -1; } -#ifdef NESTED_PREFIX // OLD_CODE for deleting multi-level prefixes +#ifdef NESTED_PREFIX static void do_stats_prefix_delete_children(const char *prefix, const size_t nprefix) { PREFIX_STATS *curr;
Force cleanup before return
@@ -223,7 +223,7 @@ int mbedtls_pkcs5_pbkdf2_hmac( mbedtls_md_context_t *ctx, unsigned int iteration_count, uint32_t key_length, unsigned char *output ) { - int ret, j; + int ret = 0, j; unsigned int i; unsigned char md1[MBEDTLS_MD_MAX_SIZE]; unsigned char work[MBEDTLS_MD_MAX_SIZE]; @@ -247,16 +247,16 @@ int mbedtls_pkcs5_pbkdf2_hmac( mbedtls_md_context_t *ctx, // U1 ends up in work // if( ( ret = mbedtls_md_hmac_update( ctx, salt, slen ) ) != 0 ) - return( ret ); + goto cleanup; if( ( ret = mbedtls_md_hmac_update( ctx, counter, 4 ) ) != 0 ) - return( ret ); + goto cleanup; if( ( ret = mbedtls_md_hmac_finish( ctx, work ) ) != 0 ) - return( ret ); + goto cleanup; if( ( ret = mbedtls_md_hmac_reset( ctx ) ) != 0 ) - return( ret ); + goto cleanup; memcpy( md1, work, md_size ); @@ -265,13 +265,13 @@ int mbedtls_pkcs5_pbkdf2_hmac( mbedtls_md_context_t *ctx, // U2 ends up in md1 // if( ( ret = mbedtls_md_hmac_update( ctx, md1, md_size ) ) != 0 ) - return( ret ); + goto cleanup; if( ( ret = mbedtls_md_hmac_finish( ctx, md1 ) ) != 0 ) - return( ret ); + goto cleanup; if( ( ret = mbedtls_md_hmac_reset( ctx ) ) != 0 ) - return( ret ); + goto cleanup; // U1 xor U2 // @@ -290,11 +290,12 @@ int mbedtls_pkcs5_pbkdf2_hmac( mbedtls_md_context_t *ctx, break; } +cleanup: /* Zeroise buffers to clear sensitive data from memory. */ mbedtls_platform_zeroize( work, MBEDTLS_MD_MAX_SIZE ); mbedtls_platform_zeroize( md1, MBEDTLS_MD_MAX_SIZE ); - return( 0 ); + return( ret ); } #if defined(MBEDTLS_SELF_TEST)
Add hack to avoid extra allocation at startup for auto grid size Temporary measures to avoid extra allocation until we factor out the resizing stuff -- probably for when we add "New file" support.
@@ -2396,9 +2396,20 @@ int main(int argc, char** argv) { heapstr_init_cstr(&file_name, input_file); } else { heapstr_init_cstr(&file_name, "unnamed"); + // Temp hacky stuff: we've crammed two code paths into the KEY_RESIZE event + // case. One of them is for the initial setup for an automatic grid size. + // The other is for actual resize events. We will factor this out into + // procedures in the future, but until then, we've made a slight mess. In + // the case where the user has explicitly specified a size, we'll allocate + // the Field stuff here. If there's an automatic size, then we'll allocate + // the field in the KEY_RESIZE handler. The reason we don't just allocate + // it here and then again later is to avoid an extra allocation and memory + // manipulation. + if (!should_autosize_grid) { field_init_fill(&ged_state.field, (Usz)init_grid_dim_y, (Usz)init_grid_dim_x, '.'); } + } ged_state.filename = file_name.str; ged_set_midi_mode(&ged_state, &midi_mode); @@ -2583,7 +2594,10 @@ int main(int argc, char** argv) { ged_state.is_draw_dirty = true; } // We might do this once soon after startup if the user specified neither - // a starting grid size or a file to open. + // a starting grid size or a file to open. See above (search KEY_RESIZE) + // for why this is kind of messy and hacky -- we'll be changing this + // again before too long, so we haven't made too much of an attempt to + // keep it non-messy. if (should_autosize_grid) { should_autosize_grid = false; Usz new_field_h, new_field_w; @@ -2591,18 +2605,14 @@ int main(int argc, char** argv) { content_h, content_w, softmargin_y, softmargin_x, (int)ged_state.ruler_spacing_y, (int)ged_state.ruler_spacing_x, &new_field_h, &new_field_w)) { - // Do this raw instead of with ged_resize_grid() since we don't need - // to save any undo history -- the user hasn't done anything in the - // file yet. Hopefully. - field_resize_raw(&ged_state.field, new_field_h, new_field_w); - memset(ged_state.field.buffer, '.', - new_field_h * new_field_w * sizeof(Glyph)); + field_init_fill(&ged_state.field, (Usz)new_field_h, (Usz)new_field_w, + '.'); mbuf_reusable_ensure_size(&ged_state.mbuf_r, new_field_h, new_field_w); - ged_cursor_confine(&ged_state.ged_cursor, new_field_h, new_field_w); - ged_state.needs_remarking = true; - ged_state.is_draw_dirty = true; ged_make_cursor_visible(&ged_state); + } else { + field_init_fill(&ged_state.field, (Usz)init_grid_dim_y, + (Usz)init_grid_dim_x, '.'); } } // OK to call this unconditionally -- deriving the sub-window areas is
mbedtls: added SOC_AES_SUPPORT_AES_192 check in esp_aes_gcm_setkey()
#include "esp_heap_caps.h" #include "soc/soc_memory_layout.h" +#include "mbedtls/error.h" #include <string.h> #define ESP_PUT_BE64(a, val) \ @@ -245,6 +246,11 @@ int esp_aes_gcm_setkey( esp_gcm_context *ctx, const unsigned char *key, unsigned int keybits ) { +#if !SOC_AES_SUPPORT_AES_192 + if (keybits == 192) { + return MBEDTLS_ERR_PLATFORM_FEATURE_UNSUPPORTED; + } +#endif if (keybits != 128 && keybits != 192 && keybits != 256) { return MBEDTLS_ERR_AES_INVALID_KEY_LENGTH; }
driver/ina2xx.c: Format with clang-format BRANCH=none TEST=none
@@ -24,8 +24,8 @@ uint16_t ina2xx_read(uint8_t idx, uint8_t reg) int res; int val; - res = i2c_read16(I2C_PORT_MASTER, INA2XX_I2C_ADDR_FLAGS | idx, - reg, &val); + res = i2c_read16(I2C_PORT_MASTER, INA2XX_I2C_ADDR_FLAGS | idx, reg, + &val); if (res) { CPRINTS("INA2XX I2C read failed"); return 0x0bad; @@ -38,8 +38,8 @@ int ina2xx_write(uint8_t idx, uint8_t reg, uint16_t val) int res; uint16_t be_val = (val >> 8) | ((val & 0xff) << 8); - res = i2c_write16(I2C_PORT_MASTER, INA2XX_I2C_ADDR_FLAGS | idx, - reg, be_val); + res = i2c_write16(I2C_PORT_MASTER, INA2XX_I2C_ADDR_FLAGS | idx, reg, + be_val); if (res) CPRINTS("INA2XX I2C write failed"); return res; @@ -110,8 +110,7 @@ static void ina2xx_dump(uint8_t idx) ccprintf("Configuration: %04x\n", cfg); ccprintf("Shunt voltage: %04x => %d uV\n", sv, INA2XX_SHUNT_UV((int)sv)); - ccprintf("Bus voltage : %04x => %d mV\n", bv, - INA2XX_BUS_MV((int)bv)); + ccprintf("Bus voltage : %04x => %d mV\n", bv, INA2XX_BUS_MV((int)bv)); ccprintf("Power : %04x => %d mW\n", pow, INA2XX_POW_MW((int)pow)); ccprintf("Current : %04x => %d mA\n", curr, curr);
DOC: fixed MR regression leading to doc build error
@@ -120,5 +120,5 @@ Enabling exception handling normally increases application binary size by a few If an exception is thrown, but there is no ``catch`` block, the program will be terminated by ``abort`` function, and backtrace will be printed. See :doc:`Fatal Errors <fatal-errors>` for more information about backtraces. -See :example:`system/cpp_exceptions` for an example of C++ exception handling. +See :example:`cxx/exceptions` for an example of C++ exception handling.
nivviks: Add keyboard config for recovery mode Add keyboard configs to enable entering recovery mode via 'Esc'/'Refresh'/power-btn. TEST=zmake build nivviks; flash & run BRANCH=none
@@ -19,6 +19,9 @@ CONFIG_PLATFORM_EC_ACCEL_LIS2DW12=y # Keyboard CONFIG_CROS_KB_RAW_NPCX=y CONFIG_PLATFORM_EC_KBLIGHT_ENABLE_PIN=y +# Ensure recovery key combination (esc+refresh+power) is reliable +CONFIG_PLATFORM_EC_KEYBOARD_PWRBTN_ASSERTS_KSI3=y +CONFIG_PLATFORM_EC_KEYBOARD_REFRESH_ROW3=y # TCPC+PPC: both C0 and C1 (if present) are RAA489000 CONFIG_PLATFORM_EC_USB_PD_TCPM_RAA489000=y
power/mt8192: remove unused variable TEST=makeall BRANCH=none Tested-by: Ting Shen
/* Maximum time it should for PMIC to turn on after toggling PMIC_EN_ODL. */ #define PMIC_EN_TIMEOUT (300 * MSEC) -/* Time delay in G3 to deassert EN_PP1800_S5_L */ -#define EN_PP1800_S5_L_DEASSERT_TIME (20 * MSEC) - /* * Time delay for AP on/off the AP_EC_WDT when received SYS_RST_ODL. * Generally it can be done within 3 ms.
chore: v1.0.0-beta.3
{ "name": "lcui", - "version": "1.0.0-beta.2", + "version": "1.0.0-beta.3", "description": "A small C library for building user interfaces with C, XML and CSS.", "main": "index.js", "directories": {
Allow r.skip32_fast!(actual: x, worst_case: x)
@@ -1060,7 +1060,9 @@ func (q *checker) bcheckExprCallSpecialCases(n *a.Expr, depth uint32) (bounds, e } actual := args[0].AsArg().Value() worstCase := args[1].AsArg().Value() - if err := q.proveBinaryOp(t.IDXBinaryLessEq, actual, worstCase); err == errFailed { + if actual.Eq(worstCase) { + // No-op. Proving "x <= x" is trivial. + } else if err := q.proveBinaryOp(t.IDXBinaryLessEq, actual, worstCase); err == errFailed { return bounds{}, fmt.Errorf("check: could not prove skip_fast pre-condition: %s <= %s", actual.Str(q.tm), worstCase.Str(q.tm)) } else if err != nil {
kano: Change C0 BBR FW address Change C0 BBR FW address to 0x54. BRANCH=brya TEST=make buildall -j succeeded.
/* * see b/174768555#comment22 */ -#define USBC_PORT_C0_BB_RETIMER_I2C_ADDR 0x56 +#define USBC_PORT_C0_BB_RETIMER_I2C_ADDR 0x54 #define USBC_PORT_C1_BB_RETIMER_I2C_ADDR 0x56 /* Enabling Thunderbolt-compatible mode */
ya tool: add strace
"bpftrace": { "description": "High-level tracing language for Linux eBPF" }, + "strace": { + "description": "the linux syscall tracer" + }, "iperf": { "description": "network load tester" }, } ] }, + "strace": { + "tools": { + "strace": { + "bottle": "strace", + "executable": "strace" + } + }, + "platforms": [ + { + "host": { + "os": "LINUX" + }, + "default": true + } + ] + }, "stress-ng": { "tools": { "stress-ng": { ] } }, + "strace": { + "formula": { + "sandbox_id": [ + 654255646 + ], + "match": "infra/kernel/tools/strace/build/strace-static.tar.gz" + }, + "executable": { + "strace": [ + "strace", + "strace" + ] + } + }, "stress-ng": { "formula": { "sandbox_id": [
libhfuzz: more debug info about module initialization
@@ -332,9 +332,11 @@ HF_REQUIRE_SSE42_POPCNT void __sanitizer_cov_trace_pc_guard_init(uint32_t* start /* If this module was already initialized, skip it */ if (*start > 0) { + LOG_D("Module %p-%p is already initialized", start, stop); return; } + LOG_D("Module initialization: %p-%p at %" PRId32, start, stop, n); for (uint32_t* x = start; x < stop; x++, n++) { if (n >= _HF_PC_GUARD_MAX) { LOG_F("This process has too many PC guards:%" PRIu32
tools/pydfu.py: Call set_configuration() on fresh USB device object. This call is required before using the device (some operating systems don't need it but others do). Fixes issue
@@ -81,6 +81,7 @@ def init(): if len(devices) > 1: raise ValueError("Multiple DFU devices found") __dev = devices[0] + __dev.set_configuration() # Claim DFU interface usb.util.claim_interface(__dev, __DFU_INTERFACE)
Use old fwidth estimation.
@@ -69,7 +69,6 @@ ChipmunkDebugDrawInit(void) pass_action = (sg_pass_action){ .colors = { - // [0] = {.action = SG_ACTION_CLEAR, .val = {0x07/255.0, 0x36/255.0, 0x42/255.0, 0.0}}, [0] = {.action = SG_ACTION_CLEAR, .val = {0x00/255.0, 0x2B/255.0, 0x36/255.0, 0.0}}, }, }; @@ -129,7 +128,8 @@ ChipmunkDebugDrawInit(void) void main(){ float len = length(FRAG.uv); - float mask = smoothstep(1, 1 - fwidth(len), len); + float fw = length(fwidth(FRAG.uv)); + float mask = smoothstep(1, 1 - fw, len); OUT_color = FRAG.color*mask; } ),
esp32/modsocket.c: fix copyright, socket_recv gets param and exception
/* * This file is part of the Micro Python project, http://micropython.org/ * + * Development of the code in this file was sponsored by Microbric Pty Ltd + * and Mnemote Pty Ltd + * * The MIT License (MIT) * - * Copyright (c) 2016 Nick Moore + * Copyright (c) 2016, 2017 Nick Moore @mnemote + * * Based on extmod/modlwip.c * Copyright (c) 2013, 2014 Damien P. George * Copyright (c) 2015 Galen Hazelwood @@ -60,6 +64,11 @@ STATIC mp_obj_t socket_close(const mp_obj_t arg0) { } STATIC MP_DEFINE_CONST_FUN_OBJ_1(socket_close_obj, socket_close); +static int exception_from_errno(int _errno) { + // XXX add more specific exceptions + mp_raise_OSError(_errno); +} + static int _socket_getaddrinfo2(const mp_obj_t host, const mp_obj_t portx, struct addrinfo **resp) { const struct addrinfo hints = { .ai_family = AF_INET, @@ -167,21 +176,25 @@ STATIC mp_obj_t socket_setblocking(const mp_obj_t arg0, const mp_obj_t arg1) { } STATIC MP_DEFINE_CONST_FUN_OBJ_2(socket_setblocking_obj, socket_setblocking); -STATIC mp_obj_t socket_recv(const mp_obj_t arg0) { +STATIC mp_obj_t socket_recv(mp_uint_t n_args, const mp_obj_t *args) { byte buf[1024]; - socket_obj_t *self = MP_OBJ_TO_PTR(arg0); - int x = lwip_recvfrom(self->fd, buf, sizeof(buf), 0, NULL, NULL); + socket_obj_t *self = MP_OBJ_TO_PTR(args[0]); + size_t len = (n_args > 1) ? MIN(mp_obj_get_int(args[1]), sizeof(buf)) : sizeof(buf); + int x = lwip_recvfrom(self->fd, buf, len, 0, NULL, NULL); if (x >= 0) return mp_obj_new_bytes(buf, x); - return mp_const_none; + if (errno == EWOULDBLOCK) return b''; + exception_from_errno(errno); } -STATIC MP_DEFINE_CONST_FUN_OBJ_1(socket_recv_obj, socket_recv); +STATIC MP_DEFINE_CONST_FUN_OBJ_VAR_BETWEEN(socket_recv_obj, 1, 2, socket_recv); STATIC mp_obj_t socket_send(const mp_obj_t arg0, const mp_obj_t arg1) { socket_obj_t *self = MP_OBJ_TO_PTR(arg0); mp_uint_t datalen; const char *data = mp_obj_str_get_data(arg1, &datalen); int x = lwip_write(self->fd, data, datalen); - return mp_obj_new_int(x); + if (x >= 0) return mp_obj_new_int(x); + if (errno == EWOULDBLOCK) return mp_obj_new_int(0); + exception_from_errno(errno); } STATIC MP_DEFINE_CONST_FUN_OBJ_2(socket_send_obj, socket_send);
Fix logstash not being initialized when analytics are disabled
@@ -95,10 +95,8 @@ if [[ "$NODETYPE" = *mono* ]]; then if [[ "$STATE" = *initialized* ]]; then - if [[ "$AnalyticsActivation" = *true* ]]; then cd $AS_HOME/scripts run_as ${DATAFARI_USER} "bash as-manager.sh init_logstash"; - fi cd $DIR
Cirrus: Install ZeroMQ on macOS
@@ -75,6 +75,7 @@ mac_task: yaep yajl yaml-cpp + zeromq - > # Try to install `checkbashisms` (The file server that hosts the package is unfortunately quite unreliable.) brew install checkbashisms || >&2 printf 'Warning: Unable to install `checkbashims`\n' - > # Start D-Bus session bus
NimBLE: fix compilation issue in nimble examples for ESP32H2
@@ -42,7 +42,7 @@ void periph_module_reset(periph_module_t periph) portEXIT_CRITICAL_SAFE(&periph_spinlock); } -#if CONFIG_ESP32_WIFI_ENABLED || CONFIG_BT_ENABLED +#if CONFIG_ESP32_WIFI_ENABLED IRAM_ATTR void wifi_bt_common_module_enable(void) { portENTER_CRITICAL_SAFE(&periph_spinlock);
Update Deployment.md "visiable" should be "visible", right?
@@ -15,7 +15,7 @@ Generally, for any existing TCP based deployments that are adding QUIC support, - QUIC is versioned and extensible, and thus is expected to be very dynamic on the network. - Network devices must not assume anything about the structure of a QUIC packet beyond what is stated in the [Invariants draft](https://tools.ietf.org/html/draft-ietf-quic-invariants). - QUIC is completely encrypted end to end. - - Most information that might have been viewable on a TCP connection is now only visiable to the endpoints. + - Most information that might have been viewable on a TCP connection is now only visible to the endpoints. - A single UDP flow or tuple (address + port) does not necessarily map to a single connection. - A single QUIC connection may span multiple flows. - Multiple QUIC connections may share a single flow.
Fix size_t vs uint64_t formating
@@ -393,13 +393,13 @@ int svg_packet_start(uint64_t time, uint64_t size, const picoquic_packet_header if (rxtx == 0) { fprintf(f, " <text x=\"%d\" y=\"%d\" text-anchor=\"end\" class=\"seq_%s\">%"PRIu64"</text>\n", x_pos - 4, y_pos - 4, dir, ph->pn64); - fprintf(f, " <text x=\"%d\" y=\"%d\" text-anchor=\"end\" class=\"arw\">%zu b</text>\n", 80, y_pos - 2, size); + fprintf(f, " <text x=\"%d\" y=\"%d\" text-anchor=\"end\" class=\"arw\">%"PRIu64" b</text>\n", 80, y_pos - 2, size); fprintf(f, " <text x=\"%d\" y=\"%d\" text-anchor=\"start\" class=\"frm\" xml:space=\"preserve\"> %s</text>\n", 80, y_pos - 2, ptype2str(ph->ptype)); fprintf(f, " <text x=\"%d\" y=\"%d\" text-anchor=\"start\" class=\"frm\" xml:space=\"preserve\">", x_pos + 30, y_pos + 10); } else { fprintf(f, " <text x=\"%d\" y=\"%d\" text-anchor=\"start\" class=\"seq_%s\">%"PRIu64"</text>\n", 600 - x_pos + 4, y_pos - 4, dir, ph->pn64); - fprintf(f, " <text x=\"%d\" y=\"%d\" text-anchor=\"start\" class=\"arw\">%zu b</text>\n", 600 - 80, y_pos - 2, size); + fprintf(f, " <text x=\"%d\" y=\"%d\" text-anchor=\"start\" class=\"arw\">%"PRIu64" b</text>\n", 600 - 80, y_pos - 2, size); fprintf(f, " <text x=\"%d\" y=\"%d\" text-anchor=\"end\" class=\"frm\" xml:space=\"preserve\">%s </text>\n", 600-80, y_pos - 2, ptype2str(ph->ptype)); fprintf(f, " <text x=\"%d\" y=\"%d\" text-anchor=\"end\" class=\"frm\" xml:space=\"preserve\">", 600 - x_pos - 30, y_pos + 10); }
lazor: reduce flash usage BRANCH=none TEST=board build no longer fails due to flash space overflow
#define GPIO_SWITCHCAP_PG_INT_L GPIO_DA9313_GPIO0 #define GPIO_SWITCHCAP_ON_L GPIO_SWITCHCAP_ON +/* Disable console commands to help save space */ +#undef CONFIG_CMD_BATTFAKE + #ifndef __ASSEMBLER__ #include "gpio_signal.h"
fix -Q option in picoquicdemo
@@ -1383,7 +1383,7 @@ int main(int argc, char** argv) /* Get the parameters */ int opt; - while ((opt = getopt(argc, argv, "c:k:P:C:G:p:v:14rhzi:s:l:m:n:t:q:")) != -1) { + while ((opt = getopt(argc, argv, "c:k:P:C:Q:G:p:v:14rhzi:s:l:m:n:t:q:")) != -1) { switch (opt) { case 'c': server_cert_file = optarg;
docs/library: Clarify that the arg to esp.deepsleep is in microseconds.
@@ -31,7 +31,7 @@ Functions The system enters the set sleep mode automatically when possible. -.. function:: deepsleep(time=0, /) +.. function:: deepsleep(time_us=0, /) **Note**: ESP8266 only - use `machine.deepsleep()` on ESP32
Remove obsolete low sample error propagate step. The codec has historically used a pass that uses a lower sample count's error for a higher sample count during compute_angular_endpoints. This is no longer beneficial, costing 2-3% performance and actually reducing image quality.
@@ -296,16 +296,13 @@ static void compute_angular_endpoints_for_quant_levels( float error_cut_high = error[i] + cut_high_weight_error[i]; float error_cut_low_high = error[i] + cut_low_weight_error[i] + cut_high_weight_error[i]; - vfloat4 best_result; - vfloat4 new_result; - // Check best error against record N - best_result = best_results[idx_span]; - new_result = vfloat4(error[i], (float)i, 0.0f, 0.0f); + vfloat4 best_result = best_results[idx_span]; + vfloat4 new_result = vfloat4(error[i], (float)i, 0.0f, 0.0f); vmask4 mask1(best_result.lane<0>() > error[i]); best_results[idx_span] = select(best_result, new_result, mask1); - // Check best error against record N-1 with both cut low and cut high + // Check best error against record N-1 with either cut low or cut high best_result = best_results[idx_span - 1]; new_result = vfloat4(error_cut_low, (float)i, 1.0f, 0.0f); @@ -316,23 +313,13 @@ static void compute_angular_endpoints_for_quant_levels( vmask4 mask3(best_result.lane<0>() > error_cut_high); best_results[idx_span - 1] = select(best_result, new_result, mask3); - // Check best error against record N-2 with cut low high + // Check best error against record N-2 with both cut low and high best_result = best_results[idx_span - 2]; new_result = vfloat4(error_cut_low_high, (float)i, 1.0f, 0.0f); vmask4 mask4(best_result.lane<0>() > error_cut_low_high); best_results[idx_span - 2] = select(best_result, new_result, mask4); } - // If we get a better error for lower sample count then use the lower sample count's error for - // the higher sample count as well. - for (unsigned int i = 3; i <= max_quant_steps; i++) - { - vfloat4 result = best_results[i]; - vfloat4 prev_result = best_results[i - 1]; - vmask4 mask(result.lane<0>() > prev_result.lane<0>()); - best_results[i] = select(result, prev_result, mask); - } - for (unsigned int i = 0; i <= max_quant_level; i++) { unsigned int q = quantization_steps_for_level[i];
BugID:20126589:White scan for deadcode
@@ -237,14 +237,6 @@ static int ota_download_start(void *pctx) } else { retry = 0; } - if (nbytes < 0) { - if (errno != EINTR) { - ret = OTA_DOWNLOAD_READ_FAIL; - break; - } else { - continue; - } - } if (!header_found) { if (!file_size) { char *ptr = strstr(http_buffer, "Content-Length:");
Add ksceBtHidVu NIDs
@@ -720,6 +720,14 @@ modules: ksceBtStopAudio: 0xCAE5A9F3 ksceBtStopInquiry: 0x6A1D9598 ksceBtUnregisterCallback: 0xBF72E1BE + ksceBtHidVuGetReportFeature: 0xCA9B885C + ksceBtHidVuGetReportInput: 0x3BBC1EE1 + ksceBtHidVuReadEvent: 0x3333A878 + ksceBtHidVuRegisterCallback: 0xAB57F8C1 + ksceBtHidVuSetInterruptOutput: 0xD2449052 + ksceBtHidVuSetReportFeature: 0x014A1D28 + ksceBtHidVuSetReportOutput: 0xAB2032A3 + ksceBtHidVuUnregisterCallback: 0x1AB31C7D SceCamera: nid: 0xEC26CAF9 libraries:
Update tasks.c Reopen this PR.
@@ -4133,10 +4133,10 @@ TCB_t *pxTCB; the mutex. If the mutex is held by a task then it cannot be given from an interrupt, and if a mutex is given by the holding task then it must be the running state task. Remove - the holding task from the ready/delayed list. */ + the holding task from the ready list. */ if( uxListRemove( &( pxTCB->xStateListItem ) ) == ( UBaseType_t ) 0 ) { - taskRESET_READY_PRIORITY( pxTCB->uxPriority ); + portRESET_READY_PRIORITY( pxTCB->uxPriority, uxTopReadyPriority ); } else {
Avoid overflows. This was brought to my attention in
static int connecting = 0; static int finish = 0; -static unsigned int +static uint64_t get_milliseconds_count(void) { #ifdef _WIN32 // obtain number of milliseconds since system started - return GetTickCount(); + return GetTickCount64(); #else struct timeval tv; - unsigned int milliseconds; gettimeofday(&tv, NULL); /* get current time */ - milliseconds = tv.tv_sec*1000LL + tv.tv_usec/1000; /* calculate milliseconds */ - return (milliseconds); + return (tv.tv_sec * 1000LL + tv.tv_usec / 1000); #endif } @@ -97,19 +95,19 @@ handle_events(int sock, struct socket* s, void* sconn_addr) fd_set rfds; struct timeval tv; - unsigned next_fire_time = get_milliseconds_count(); - unsigned last_fire_time = next_fire_time; - unsigned now = get_milliseconds_count(); - int wait_time; + uint64_t next_fire_time = get_milliseconds_count(); + uint64_t last_fire_time = next_fire_time; + uint64_t now = get_milliseconds_count(); + uint32_t wait_time; while (!finish) { - if ((int) (now - next_fire_time) > 0) { - usrsctp_handle_timers(now - last_fire_time); + if (now > next_fire_time) { + usrsctp_handle_timers((uint32_t)(now - last_fire_time)); last_fire_time = now; next_fire_time = now + TIMER_INTERVAL_MSECS; } - wait_time = next_fire_time - now; + wait_time = (uint32_t)(next_fire_time - now); tv.tv_sec = wait_time / 1000; tv.tv_usec = (wait_time % 1000) * 1000;
SOVERSION bump to version 4.1.6
@@ -35,7 +35,7 @@ set(SYSREPO_VERSION ${SYSREPO_MAJOR_VERSION}.${SYSREPO_MINOR_VERSION}.${SYSREPO_ # with backward compatible change and micro version is connected with any internal change of the library. set(SYSREPO_MAJOR_SOVERSION 4) set(SYSREPO_MINOR_SOVERSION 1) -set(SYSREPO_MICRO_SOVERSION 5) +set(SYSREPO_MICRO_SOVERSION 6) set(SYSREPO_SOVERSION_FULL ${SYSREPO_MAJOR_SOVERSION}.${SYSREPO_MINOR_SOVERSION}.${SYSREPO_MICRO_SOVERSION}) set(SYSREPO_SOVERSION ${SYSREPO_MAJOR_SOVERSION})
i2s: add mck pin definition in the example If the mck pin is not set to GPIO 0,1,3 or -1 the whole pin configuration fails. This fix corrects that. Merges
@@ -102,6 +102,7 @@ void app_main(void) .intr_alloc_flags = ESP_INTR_FLAG_LEVEL1 //Interrupt level 1 }; i2s_pin_config_t pin_config = { + .mck_io_num = I2S_PIN_NO_CHANGE, .bck_io_num = I2S_BCK_IO, .ws_io_num = I2S_WS_IO, .data_out_num = I2S_DO_IO,
error: reword
@@ -15,8 +15,10 @@ make sense to differentiate between `No Write Permission` and `No Read Permissio as the application just knows that it simply cannot access the desired resource and tells the user to grant it. -Categories are leaf based, so you cannot put an error into a node (branch) such -as `Permanent errors` (see below). +Categories are hierarchically structured. In some categories you cannot put an error such +as `Permanent errors` (see below) because they are too general and developers should choose +a more specific category. Please choose the most specific category as possible when trying +to assign an error to a category. If you feel for a new category, please forge a design decision document and make a PR to Elektra's repo.
BugID:17132184:White Scan warnings fix
@@ -108,6 +108,7 @@ int patch_flash_copy(int par, unsigned long dst_offset, unsigned long src_offset } pos += SECTOR_SIZE; } + return 0; } int patch_flash_copy_par(int dst_par, int src_par, unsigned long offset, size_t size) { @@ -134,5 +135,6 @@ int patch_flash_copy_par(int dst_par, int src_par, unsigned long offset, size_t } pos += SECTOR_SIZE; } + return 0; } #endif
replace a lookup table with an expression to determine 'stack_width' more efficiently.
@@ -4921,11 +4921,9 @@ ZyanStatus ZydisDecoderDecodeBuffer(const ZydisDecoder* decoder, const void* buf ZYAN_MEMSET(instruction, 0, sizeof(*instruction)); instruction->machine_mode = decoder->machine_mode; - static const ZyanU8 lookup[ZYDIS_ADDRESS_WIDTH_MAX_VALUE + 1] = - { - 16, 32, 64 - }; - instruction->stack_width = lookup[decoder->address_width]; + + // Calculate stack width from address width using a mapping process: [0, 1, 2] -> [16, 32, 64] + instruction->stack_width = 16 << decoder->address_width; ZYAN_CHECK(ZydisCollectOptionalPrefixes(&context, instruction)); ZYAN_CHECK(ZydisDecodeInstruction(&context, instruction));
S2S ocean: MARS levtype incorrect for 151131 and 151132
@@ -101,7 +101,6 @@ if (isHindcast == 1) { # ECC-891, ECC-1013 concept is_ocean2d_param(zero) { '1' = { discipline=10; typeOfFirstFixedSurface=160; scaleFactorOfFirstFixedSurface=0; scaledValueOfFirstFixedSurface=0; typeOfSecondFixedSurface=255; } - '1' = { discipline=10; typeOfFirstFixedSurface=160; scaleFactorOfFirstFixedSurface=missing(); scaledValueOfFirstFixedSurface=missing(); typeOfSecondFixedSurface=255; } '1' = { discipline=10; typeOfFirstFixedSurface=20; scaleFactorOfFirstFixedSurface=2; scaledValueOfFirstFixedSurface=29315; typeOfSecondFixedSurface=255; } '1' = { discipline=10; typeOfFirstFixedSurface=169; scaleFactorOfFirstFixedSurface=2; scaledValueOfFirstFixedSurface=1; typeOfSecondFixedSurface=255; } '1' = { discipline=10; typeOfFirstFixedSurface=160; scaleFactorOfFirstFixedSurface=0; scaledValueOfFirstFixedSurface=0; typeOfSecondFixedSurface=160; scaleFactorOfSecondFixedSurface=0; scaledValueOfSecondFixedSurface=300; }
asn.1: fix Coverity Logically dead code
@@ -348,12 +348,13 @@ static int asn1_template_ex_i2d(const ASN1_VALUE **pval, unsigned char **out, /* EXPLICIT tagging */ /* Find length of tagged item */ i = ASN1_item_ex_i2d(pval, NULL, ASN1_ITEM_ptr(tt->item), -1, iclass); - if (!i) - return 0; - if (i == 0 && (tt->flags & ASN1_TFLG_OPTIONAL) == 0) { + if (i == 0) { + if ((tt->flags & ASN1_TFLG_OPTIONAL) == 0) { ERR_raise(ERR_LIB_ASN1, ASN1_R_ILLEGAL_ZERO_CONTENT); return -1; } + return 0; + } /* Find length of EXPLICIT tag */ ret = ASN1_object_size(ndef, i, ttag); if (out && ret != -1) {
test/console_edit.c: Format with clang-format BRANCH=none TEST=none
@@ -258,8 +258,8 @@ static int test_output_channel(void) cputs(CC_TASK, "shouldn't see this either\n"); cflush(); test_capture_console(0); - TEST_ASSERT(compare_multiline_string(test_get_captured_console(), - "") == 0); + TEST_ASSERT(compare_multiline_string(test_get_captured_console(), "") == + 0); UART_INJECT("chan restore\n"); msleep(30); test_capture_console(1);
fix pandas dependence
@@ -13,5 +13,6 @@ Platform: Windows Platform: Unix Requires-Dist: six Requires-Dist: numpy +Requires-Dist: pandas This is CatBoost Python package. An open-source gradient boosting on decision trees library with categorical features support out of the box.
decision: add drawback
@@ -163,6 +163,8 @@ We also need to provide a simple API to plugins to register such callbacks for a As the transformations for existing keys will be applied before `kdbSet`, this will elimate false positives in changetracking. +A drawback to this solution is that it adds some complexity to `libelektra-core`. + ## Decision ## Rationale
Changed (long long*) casting to (int64_t*) casting inside orka_iso8601_to_unix_ms and changed size_t declaration from NULL to 0.
char* orka_load_whole_file(const char filename[], size_t *len) { - size_t size = NULL; + size_t size = 0; FILE *f = fopen(filename,"rb"); if (!f) { char *s = strerror(errno); @@ -90,7 +90,7 @@ int orka_iso8601_to_unix_ms(char *timestamp, size_t s, void *p) int tz_hour = 0; int tz_min = 0; int64_t result = 0; - int64_t *recipient = (long long*) p; + int64_t *recipient = (int64_t*) p; char *buf = NULL; memset(&tm, 0, sizeof(tm));
py/objstr: Remove duplicate % in error string. The double-% was added in (Jun 2014) when such errors were formatted with printf. But then (Dec 2018) changed mp_obj_new_exception_msg() to not format the message, as discussed in So such error strings are no longer formatted and a % is just that.
@@ -1555,7 +1555,7 @@ STATIC mp_obj_t str_modulo_format(mp_obj_t pattern, size_t n_args, const mp_obj_ size_t slen; const char *s = mp_obj_str_get_data(arg, &slen); if (slen != 1) { - mp_raise_TypeError("%%c needs int or char"); + mp_raise_TypeError("%c needs int or char"); } mp_print_strn(&print, s, 1, flags, ' ', width); } else if (arg_looks_integer(arg)) {
Inline declarations with first use
@@ -299,17 +299,12 @@ static void compute_color_error_for_every_integer_count_and_quant_level( // It is possible to get endpoint colors significantly outside [0,upper-limit] even if the // input data are safely contained in [0,upper-limit]; we need to add an error term for this - vfloat4 ep0_range_error_high; - vfloat4 ep1_range_error_high; - vfloat4 ep0_range_error_low; - vfloat4 ep1_range_error_low; - vfloat4 offset(range_upper_limit_rgb, range_upper_limit_rgb, range_upper_limit_rgb, range_upper_limit_alpha); - ep0_range_error_high = max(ep0 - offset, 0.0f); - ep1_range_error_high = max(ep1 - offset, 0.0f); + vfloat4 ep0_range_error_high = max(ep0 - offset, 0.0f); + vfloat4 ep1_range_error_high = max(ep1 - offset, 0.0f); - ep0_range_error_low = min(ep0, 0.0f); - ep1_range_error_low = min(ep1, 0.0f); + vfloat4 ep0_range_error_low = min(ep0, 0.0f); + vfloat4 ep1_range_error_low = min(ep1, 0.0f); vfloat4 sum_range_error = (ep0_range_error_low * ep0_range_error_low) +
haskell-cabal-sandboxing: add dini to the travis configuration
@@ -5,7 +5,7 @@ cache: $HOME/.m2 $HOME/.cabal $HOME/Library/Haskell - $TRAVIS_BUILD_DIR/../build/.cabal-sandbox + $TRAVIS_BUILD_DIR/.cabal-sandbox # # Define the build matrix @@ -138,7 +138,7 @@ before_script: fi # use a minimal configuration for the haskell bindings to give it enough time to compile dependencies - if [[ $HASKELL == ON ]]; then bindings="cpp;haskell"; fi - - if [[ $HASKELL == ON ]]; then plugins="resolver_fm_hpu_b;dump;haskell;ini;sync;error;spec;list;network;profile;glob;tracer;timeofday;binary;base64"; fi + - if [[ $HASKELL == ON ]]; then plugins="resolver_fm_hpu_b;dump;haskell;ini;dini;sync;error;spec;list;network;profile;glob;tracer;timeofday;binary;base64"; fi - if [[ $HASKELL == ON ]]; then tools="kdb"; fi - | if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then
Fix alphabetic ordering in typedefs.list
@@ -1025,6 +1025,7 @@ HeapScanDesc HeapTuple HeapTupleData HeapTupleFields +HeapTupleForceOption HeapTupleHeader HeapTupleHeaderData HeapTupleTableSlot @@ -2392,8 +2393,8 @@ SubPlanState SubTransactionId SubXactCallback SubXactCallbackItem -SubXactInfo SubXactEvent +SubXactInfo SubplanResultRelHashElem SubqueryScan SubqueryScanPath @@ -3597,4 +3598,3 @@ yyscan_t z_stream z_streamp zic_t -HeapTupleForceOption
Hopefully fixed release cycle artifacts
@@ -27,6 +27,13 @@ jobs: working-directory: ${{runner.workspace}}/libsurvive run: rm -rf .git + - name: Get release + id: get_release + if: github.event_name == 'release' + uses: bruceadams/[email protected] + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + - uses: actions/upload-artifact@v2 name: Upload with:
Correct typo in previous profile behaviour binding in bluetooth.md
@@ -66,7 +66,7 @@ The bluetooth behavior completes an bluetooth action given on press. 1. Behavior binding to select the previous profile: ``` - &bt BT_NXT + &bt BT_PRV ``` 1. Behavior binding to select the 2nd profile (passed parameters are [zero based](https://en.wikipedia.org/wiki/Zero-based_numbering)):
ip: Trace the packet from the punt node Type: feature
@@ -223,6 +223,7 @@ typedef struct { punt_client_t client; u8 is_midchain; + u8 packet_data[64]; } udp_punt_trace_t; static u8 * @@ -238,6 +239,9 @@ format_udp_punt_trace (u8 * s, va_list * args) s = format (s, "\n%U(buffer is part of chain)", format_white_space, indent); } + s = format (s, "\n%U%U", format_white_space, indent, + format_hex_bytes, t->packet_data, sizeof (t->packet_data)); + return s; } @@ -327,13 +331,6 @@ punt_socket_inline (vlib_main_t * vm, struct sockaddr_un *caddr = &c->caddr; - if (PREDICT_FALSE (b->flags & VLIB_BUFFER_IS_TRACED)) - { - udp_punt_trace_t *t; - t = vlib_add_trace (vm, node, b, sizeof (t[0])); - clib_memcpy_fast (&t->client, c, sizeof (t->client)); - } - /* Re-set iovecs */ vec_reset_length (ptd->iovecs); @@ -350,6 +347,16 @@ punt_socket_inline (vlib_main_t * vm, iov->iov_base = b->data + b->current_data; iov->iov_len = l = b->current_length; + if (PREDICT_FALSE (b->flags & VLIB_BUFFER_IS_TRACED)) + { + udp_punt_trace_t *t; + t = vlib_add_trace (vm, node, b, sizeof (t[0])); + clib_memcpy_fast (&t->client, c, sizeof (t->client)); + clib_memcpy_fast (t->packet_data, + vlib_buffer_get_current (b), + sizeof (t->packet_data)); + } + if (PREDICT_FALSE (b->flags & VLIB_BUFFER_NEXT_PRESENT)) { do
Remove reference to SNPRINTF macro as it no longer exists.
@@ -536,31 +536,15 @@ MyClass.C file contents: :: MyClass::MyClass() { } MyClass::~MyClass() { } -Include snprintf.h -~~~~~~~~~~~~~~~~~~ +Do not use 'sprintf' +~~~~~~~~~~~~~~~~~~~~ VisIt_ source code should not use *sprintf* into a static sized buffer due to the possibility of buffer overruns, which introduce memory problems and possible security threats. To combat this, the use of *sprintf* is deprecated and all new code should use *snprintf*, which behaves the same but also takes the size of the buffer as an argument -so buffer overruns are not possible. The *snprintf* function is not -supported in any of the Windows header files but there is a *\_snprintf* -function. Since some platforms can use *snprintf* and Windows must use -*\_snprintf*, there is an snprintf.h header file that defines an -*SNPRINTF* macro which evaluates to the proper symbol based on the -compiler being used. :: - - // Don't do this - const char *s = "This is a very long message " - "intended to overrun the buffer."; - char buf[20]; - sprintf(buf, "Message: %s", s); - - // Do this instead - #include <snprintf.h> - SNPRINTF(buf, 20, "Message: %s", s); - +so buffer overruns are not possible. Do not use variables called near or far ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
os/binfmt: cover all of configs with !BINFMT_DISABLE Currently BINFMT_CONSTRUCTORS and SYMTAB_ORDEREDBYNAME are outside of !BINFMT_DISABLE conditional. But they are valid in !BINFMT_DISABLE conditional. Let's cover them also.
@@ -58,8 +58,6 @@ if BUILTIN source binfmt/libbuiltin/Kconfig endif -endif - config BINFMT_CONSTRUCTORS bool "C++ Static Constructor Support" default n @@ -76,3 +74,4 @@ config SYMTAB_ORDEREDBYNAME the logic can perform faster lookups using a binary search. Otherwise, the symbol table is assumed to be un-ordered an only slow, linear searches are supported. +endif # !BINFMT_DISABLE
Fix paths of src/pluto, plann, plorc and inscop in polycc.sh.in
# Available under GNU GPL version 3 or (at your option) any later version # -pluto=@top_builddir@/src/pluto -plann=@top_srcdir@/plann -plorc=@top_srcdir@/plorc -inscop=@top_srcdir@/inscop +pluto=@abs_top_builddir@/src/pluto +plann=@abs_top_srcdir@/plann +plorc=@abs_top_srcdir@/plorc +inscop=@abs_top_srcdir@/inscop # Some additional setup here to ensure that variables are visible outside of the run function SOURCEFILE=""
newlib: init microseconds offset
// Offset between FRC timer and the RTC. // Initialized after reset or light sleep. #if defined(CONFIG_ESP_TIME_FUNCS_USE_RTC_TIMER) && defined(CONFIG_ESP_TIME_FUNCS_USE_ESP_TIMER) -uint64_t s_microseconds_offset; +uint64_t s_microseconds_offset = 0; #endif #ifndef CONFIG_ESP_TIME_FUNCS_USE_RTC_TIMER
Update gitbook link; fix
@@ -58,4 +58,4 @@ brew install oidc-agent ``` ### From Source -Refer to the [documentation](https://indigo-dc.gitbooks.io/oidc-agent/install.html#from-source) +Refer to the [documentation](https://indigo-dc.gitbook.io/oidc-agent/installation/install#from-source)
todo: run link checker before releases
@@ -36,6 +36,7 @@ Following shell expansions are used in this document: - Update contracts using update-infos-status - Shell recorder of release notes/highlights of release - regenerate dot of plugins +- run link checker: cd ~build && ~e/scripts/link-checker external-links.txt == Increment Version Number ==
Jest run 2 max workers
"make:all": "run-s make:mac make:win make:win32 make:linux", "publish": "electron-forge publish", "lint": "eslint --cache --color --ext .jsx,.js src", - "test": "jest", + "test": "jest --maxWorkers=2", "coverage": "jest --coverage --runInBand || true", "missing-translations": "node src/lang/list_missing.js" },
mmapstorage: fix Jenkinsfile
@@ -574,8 +574,8 @@ def generateFullBuildStages() { ) // Build Elektra with the mmap backend instead of the default - tasks << buildAndTestAsan( - "debian-stable-full-mmap-asan", + tasks << buildAndTest( + "debian-stable-full-mmap", DOCKER_IMAGES.stretch, CMAKE_FLAGS_BUILD_ALL + CMAKE_FLAGS_MMAP + @@ -584,6 +584,13 @@ def generateFullBuildStages() { [TEST.ALL, TEST.MEM] ) + tasks << buildAndTestAsan( + "debian-stable-full-mmap-asan", + DOCKER_IMAGES.stretch, + CMAKE_FLAGS_BUILD_ALL + + CMAKE_FLAGS_MMAP + ) + // Build Elektra with xdg resolver to see if we are compliant def xdgResolver = 'resolver_mf_xp_x' tasks << buildAndTest(
[awm2] Clicking a window moves it to the front of the Z-hierarchy
@@ -662,9 +662,11 @@ impl Desktop { .track_element(Rc::clone(&new_window) as Rc<dyn DesktopElement>); self.recompute_drawable_regions_in_rect(window_frame); + /* new_window.render_remote_layer(); self.compositor_state .queue_composite(Rc::clone(&new_window) as Rc<dyn DesktopElement>); + */ new_window } @@ -698,6 +700,13 @@ impl Desktop { MouseStateChange::LeftClickBegan => { self.interaction_state.dragged_window = self.interaction_state.window_under_mouse.clone(); + if let Some(dragged_window) = self.interaction_state.dragged_window.clone() { + if !Rc::ptr_eq(&self.windows[0], &dragged_window) { + println!("Moving clicked window to top: {}", dragged_window.name()); + self.move_window_to_top(&dragged_window); + self.recompute_drawable_regions_in_rect(dragged_window.frame()); + } + } } MouseStateChange::LeftClickEnded => { if self.interaction_state.dragged_window.is_some() { @@ -712,7 +721,8 @@ impl Desktop { let mut prev_frame = None; let mut new_frame = None; - if let Some(dragged_window) = &self.interaction_state.dragged_window { + let dragged_window = self.interaction_state.dragged_window.clone(); + if let Some(dragged_window) = &dragged_window { //println!("Dragged window moved {}", dragged_window.name()); //dragged_window.frame.origin = dragged_window.frame.origin + *rel_pos; prev_frame = Some(dragged_window.frame()); @@ -732,6 +742,16 @@ impl Desktop { } } + pub fn move_window_to_top(&mut self, window: &Rc<Window>) { + let window_idx = self + .windows + .iter() + .position(|w| Rc::ptr_eq(w, window)) + .unwrap(); + self.windows.remove(window_idx); + self.windows.insert(0, Rc::clone(window)); + } + pub fn handle_keyboard_event(&mut self, packet: &KeyboardPacket) { println!("Got keyboard packet {packet:?}"); if packet.key == 97 && packet.event_type == KeyEventType::Released {
elemi: Remove CONFIG_USB_PD_TBT_COMPAT_MODE BRANCH=firmware-volteer-13672.B-main TEST=make buildall
#define PD_MAX_CURRENT_MA 3000 #define PD_MAX_VOLTAGE_MV 20000 -/* Enabling Thunderbolt-compatible mode */ -#define CONFIG_USB_PD_TBT_COMPAT_MODE - /* USB Type A Features */ #define USB_PORT_COUNT 1 #define CONFIG_USB_PORT_POWER_DUMB
profile: update brushless whoop pids
@@ -58,9 +58,9 @@ const pid_rate_preset_t pid_rate_presets[] = { .index = 4, .name = "65mm 1s brushless whoop", .rate = { - .kp = {88, 88, 78.5}, - .ki = {70, 70, 70}, - .kd = {67, 67, 6}, + .kp = {95, 95, 92}, + .ki = {71, 71, 71}, + .kd = {75, 75, 12}, }, }, @@ -68,9 +68,9 @@ const pid_rate_preset_t pid_rate_presets[] = { .index = 5, .name = "65mm 1s brushless whoop - Hanfer Edition", .rate = { - .kp = {95, 95, 92}, - .ki = {71, 71, 71}, - .kd = {75, 75, 12}, + .kp = {103, 100, 100}, + .ki = {77, 77, 77}, + .kd = {76, 76, 13}, }, }, @@ -78,9 +78,9 @@ const pid_rate_preset_t pid_rate_presets[] = { .index = 6, .name = "65mm 2s brushless whoop", .rate = { - .kp = {94, 94, 86}, - .ki = {71, 71, 71}, - .kd = {52, 52, 9}, + .kp = {102, 100, 100}, + .ki = {77, 77, 77}, + .kd = {62, 62, 12}, }, },
re-implement tick interface for stm32f4xx HAL library and fixed typo
@@ -89,7 +89,7 @@ void SystemClock_Config(void) Error_Handler(); } - HAL_SYSTICK_Config(HAL_RCC_GetHCLKFreq()/1000); + HAL_SYSTICK_Config(HAL_RCC_GetHCLKFreq()/RT_TICK_PER_SECOND); HAL_SYSTICK_CLKSourceConfig(SYSTICK_CLKSOURCE_HCLK); @@ -105,30 +105,35 @@ void SysTick_Handler(void) { /* enter interrupt */ rt_interrupt_enter(); - /* tick for HAL Library */ - HAL_IncTick(); + rt_tick_increase(); /* leave interrupt */ rt_interrupt_leave(); } -/* re-implementat tick interface for STM32 HAL */ +/* re-implement tick interface for STM32 HAL */ HAL_StatusTypeDef HAL_InitTick(uint32_t TickPriority) { - /*Configure the SysTick to have interrupt in 1ms time basis*/ - HAL_SYSTICK_Config(HAL_RCC_GetHCLKFreq()/RT_TICK_PER_SECOND); - - /*Configure the SysTick IRQ priority */ - HAL_NVIC_SetPriority(SysTick_IRQn, TickPriority ,0); - /* Return function status */ return HAL_OK; } +uint32_t HAL_GetTick(void) +{ + return rt_tick_get() * 1000 / RT_TICK_PER_SECOND; +} + +void HAL_SuspendTick(void) +{ +} + +void HAL_ResumeTick(void) +{ +} + void HAL_Delay(__IO uint32_t Delay) { -// rt_thread_delay(Delay); } /** @@ -142,7 +147,7 @@ void rt_hw_board_init() /* Set the Vector Table base location at 0x10000000 */ SCB->VTOR = (0x10000000 & NVIC_VTOR_MASK); #else /* VECT_TAB_FLASH */ - /* Set the Vector Table base location at 0x00000000 */ + /* Set the Vector Table base location at 0x08000000 */ SCB->VTOR = (0x08000000 & NVIC_VTOR_MASK); #endif HAL_Init(); @@ -161,10 +166,6 @@ void rt_hw_board_init() mpu_init(); #endif - - - -// nand_hy27uf_hw_init(); } /*@}*/
Rename conn_send_pkt as conn_write_pkt
@@ -1195,7 +1195,7 @@ static int conn_should_send_max_data(ngtcp2_conn *conn) { } /* - * conn_send_pkt writes a protected packet in the buffer pointed by + * conn_write_pkt writes a protected packet in the buffer pointed by * |dest| whose length if |destlen|. * * This function returns the number of bytes written in |dest| if it @@ -1208,7 +1208,7 @@ static int conn_should_send_max_data(ngtcp2_conn *conn) { * NGTCP2_ERR_NOBUF * Buffer is too small. */ -static ssize_t conn_send_pkt(ngtcp2_conn *conn, uint8_t *dest, size_t destlen, +static ssize_t conn_write_pkt(ngtcp2_conn *conn, uint8_t *dest, size_t destlen, ngtcp2_tstamp ts) { int rv; ngtcp2_ppe ppe; @@ -1532,7 +1532,7 @@ ssize_t ngtcp2_conn_send(ngtcp2_conn *conn, uint8_t *dest, size_t destlen, } break; case NGTCP2_CS_POST_HANDSHAKE: - nwrite = conn_send_pkt(conn, dest, destlen, ts); + nwrite = conn_write_pkt(conn, dest, destlen, ts); if (nwrite < 0) { break; }
Fixes consistent search cycling and highlighting behavior when wholeword is toggled
@@ -549,16 +549,18 @@ void editor_apply_searchtag (GuEditor* ec) { gtk_text_tag_table_add (ec->editortags, ec->searchtag); while (TRUE) { + do { ret = gtk_source_iter_forward_search (&start, ec->term, (ec->matchcase? 0: GTK_SOURCE_SEARCH_CASE_INSENSITIVE), &mstart, &mend, NULL); + start = mend; + } while (ec->wholeword && ret && (!gtk_text_iter_starts_word(&mstart) || + !gtk_text_iter_ends_word(&mend))); - if (ret && (!ec->wholeword || (ec->wholeword - && gtk_text_iter_starts_word (&mstart) - && gtk_text_iter_ends_word (&mend)))) { + if (ret) { gtk_text_buffer_apply_tag (ec_buffer, ec->searchtag, &mstart, &mend); - start = mend; +// start = mend; } else break; } } @@ -569,6 +571,7 @@ void editor_search_next (GuEditor* ec, gboolean inverse) { editor_get_current_iter (ec, &current); + do { if (ec->backwards ^ inverse) { ret = gtk_source_iter_backward_search (&current, ec->term, (ec->matchcase? 0: GTK_SOURCE_SEARCH_CASE_INSENSITIVE), @@ -579,10 +582,11 @@ void editor_search_next (GuEditor* ec, gboolean inverse) { (ec->matchcase? 0: GTK_SOURCE_SEARCH_CASE_INSENSITIVE), &mstart, &mend, NULL); } + current = mend; + } while (ec->wholeword && ret && (!gtk_text_iter_starts_word(&mstart) || + !gtk_text_iter_ends_word(&mend))); - if (ret && (!ec->wholeword || (ec->wholeword - && gtk_text_iter_starts_word (&mstart) - && gtk_text_iter_ends_word (&mend)))) { + if (ret) { gtk_text_buffer_select_range (ec_buffer, &mstart, &mend); editor_scroll_to_cursor (ec); }
Fix frequency variables initialization
using namespace lime; -ADF4002::ADF4002() +ADF4002::ADF4002() : txtFref(10), txtFvco(30.72) { + SetDefaults(); } ADF4002::~ADF4002() @@ -23,6 +24,8 @@ ADF4002::~ADF4002() */ void ADF4002::SetDefaults() { + txtFref = 10; + txtFvco = 30.72; //Reference Counter Latch cmbLDP = 0; cmbABW = 0;
Updated azure-pipelines.yml: remove doxygen from the build (build infra, no code change)
@@ -5,8 +5,13 @@ queue: steps: - task: CmdLine@1 - displayName: 'Doxygen Generate cpp documentation' + displayName: 'Build Release (x86) and Run Tests' inputs: - filename: tools/doxygen.exe - arguments: cppDoxygenConfig - workingFolder: docs + filename: build-Win32Release.bat + workingFolder: . + +- task: CmdLine@1 + displayName: 'Build Release (x64) and Run Tests' + inputs: + filename: build-x64Release.bat + workingFolder: . \ No newline at end of file
remove unnecessary strlen call
@@ -63,7 +63,7 @@ static void swaynag_button_execute(struct swaynag *swaynag, } else if (pid == 0) { // Child of the child. Will be reparented to the init process char *terminal = getenv("TERMINAL"); - if (button->terminal && terminal && strlen(terminal)) { + if (button->terminal && terminal && *terminal) { sway_log(SWAY_DEBUG, "Found $TERMINAL: %s", terminal); if (!terminal_execute(terminal, button->action)) { swaynag_destroy(swaynag); @@ -143,7 +143,7 @@ static void update_cursor(struct swaynag_seat *seat) { const char *cursor_theme = getenv("XCURSOR_THEME"); unsigned cursor_size = 24; const char *env_cursor_size = getenv("XCURSOR_SIZE"); - if (env_cursor_size && strlen(env_cursor_size) > 0) { + if (env_cursor_size && *env_cursor_size) { errno = 0; char *end; unsigned size = strtoul(env_cursor_size, &end, 10);
data tree DOC mention binary value size units Refs
@@ -611,7 +611,7 @@ struct lyd_value_bits { */ struct lyd_value_binary { void *data; /**< binary value itself */ - size_t size; /**< size of the @p data value */ + size_t size; /**< size of the @p data value in bytes */ }; /**
Plasma: Use m_new to alloc buffer on gc_heap if not supplied. When no buffer was supplied it would fall upon the class to call "new" and allocate within C/C++'s (very small) heap. Ensure a MicroPython managed buffer (allocated from gc_heap) is always supplied to the APA102/WS2812 classes.
@@ -89,9 +89,11 @@ mp_obj_t PlasmaWS2812_make_new(const mp_obj_type_t *type, size_t n_args, size_t mp_buffer_info_t bufinfo; mp_get_buffer_raise(args[ARG_buffer].u_obj, &bufinfo, MP_BUFFER_RW); buffer = bufinfo.buf; - if(bufinfo.len < (size_t)(num_leds * 4)) { + if(bufinfo.len < (size_t)(num_leds * sizeof(WS2812::RGB))) { mp_raise_ValueError("Supplied buffer is too small for LED count!"); } + } else { + buffer = m_new(WS2812::RGB, num_leds); } self = m_new_obj_with_finaliser(_PlasmaWS2812_obj_t); @@ -294,14 +296,16 @@ mp_obj_t PlasmaAPA102_make_new(const mp_obj_type_t *type, size_t n_args, size_t if(bufinfo.len < (size_t)(num_leds * 4)) { mp_raise_ValueError("Supplied buffer is too small for LED count!"); } - // If a bytearray is supplied it'll be raw, uninitialized bytes + } else { + buffer = m_new(APA102::RGB, num_leds); + } + + // A supplied bytearray or new buffer will be raw, uninitialized bytes // iterate through the RGB elements and call "brightness" // to set up the SOF bytes, otherwise a flickery mess will happen! - // Oh for such niceties as "placement new"... for(auto i = 0; i < num_leds; i++) { buffer[i].brightness(15); } - } self = m_new_obj_with_finaliser(_PlasmaAPA102_obj_t); self->base.type = &PlasmaAPA102_type;
Check breakpoint stop condition in VM. Check breakpoint stop condition even after a message is processed. JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg
@@ -2410,7 +2410,9 @@ vm_loop (vm_frame_ctx_t *frame_ctx_p) /**< frame context */ continue; } - if (JERRY_CONTEXT (debugger_flags) & JERRY_DEBUGGER_VM_STOP) + if ((JERRY_CONTEXT (debugger_flags) & JERRY_DEBUGGER_VM_STOP) + && (JERRY_CONTEXT (debugger_stop_context) == NULL + || JERRY_CONTEXT (debugger_stop_context) == JERRY_CONTEXT (vm_top_context_p))) { jerry_debugger_breakpoint_hit (JERRY_DEBUGGER_BREAKPOINT_HIT); }
include for gettimeofday
#include "config.h" #include <stdlib.h> #include <fcntl.h> +#ifdef HAVE_TIME_H +#include <time.h> +#endif +#include <sys/time.h> +#include <sys/types.h> #include "sldns/sbuffer.h" #include "util/config_file.h" #include "util/net_help.h"
Fix crash on unload with NO_INIT_CONSTRUCTOR Better solution to
@@ -668,7 +668,11 @@ void initialize_gl4es() { #ifndef NOX11 void FreeFBVisual(); #endif +#ifdef NO_INIT_CONSTRUCTOR +__attribute__((visibility("default"))) +#else __attribute__((destructor)) +#endif void close_gl4es() { #ifdef GL4ES_COMPILE_FOR_USE_IN_SHARED_LIB SHUT_LOGD("Shuting down request\n");
fix typo for ecc
@@ -14,7 +14,7 @@ ecli: wget https://aka.pw/bpf-ecli -O ./ecli && chmod +x ./ecli ecc: - wget https://github.com/eunomia-bpf/eunomia-bpf/releases/latest/download/ecc && chmod +x ./ecli + wget https://github.com/eunomia-bpf/eunomia-bpf/releases/latest/download/ecc && chmod +x ./ecc clone_and_install_deps: ecli ecc
Fix Misra 17.8 on safety code
@@ -149,10 +149,11 @@ uint32_t get_ts_elapsed(uint32_t ts, uint32_t ts_last) { // convert a trimmed integer to signed 32 bit int int to_signed(int d, int bits) { + int d_signed = d; if (d >= (1 << (bits - 1))) { - d -= (1 << bits); + d_signed = d - (1 << bits); } - return d; + return d_signed; } // given a new sample, update the smaple_t struct
ames: prevent larval stage from possibly clobbering adult state
++ take ^take -- |% + ++ larval-core . :: +call: handle request $task :: ++ call ~|(%ames-larval-call-dud (mean tang.u.dud)) :: before processing events, make sure we have state loaded :: - =^ molt-moves adult-gate molt + =^ molt-moves larval-core molt :: ?: &(!=(~ unix-duct.ames-state.adult-gate) =(~ queued-events)) =^ moves adult-gate (call:adult-core duct dud task) ?^ dud ~|(%ames-larval-take-dud (mean tang.u.dud)) :: - =^ molt-moves adult-gate molt + =^ molt-moves larval-core molt :: ?: &(!=(~ unix-duct.ames-state.adult-gate) =(~ queued-events)) =^ moves adult-gate (take:adult-core wire duct dud sign) [(weld molt-moves moves) adult-gate] :: enqueue event if not a larval drainage timer :: - =? queued-events !=(/larva wire) - (~(put to queued-events) %take wire duct sign) - :: start drainage timer if have regressed from adult ames - :: - ?: ?& !=(/larva wire) - ?=(^ cached-state) - == - [[duct %pass /larva %b %wait now]~ larval-gate] - :: XX what to do with errors? - :: - ?. =(/larva wire) [~ larval-gate] + ?. =(/larva wire) + =. queued-events (~(put to queued-events) %take wire duct sign) + [~ larval-gate] :: larval event drainage timer; pop and process a queued event :: ?. ?=([%behn %wake *] sign) :: +molt: re-evolve to adult-ames :: ++ molt - ^- (quip move _adult-gate) - ?~ cached-state [~ adult-gate] + ^- (quip move _larval-core) + ?~ cached-state [~ larval-core] ~> %slog.0^leaf/"ames: molt" =? u.cached-state ?=(%5 -.u.cached-state) 6+(state-5-to-6:load:adult-core +.u.cached-state) 8+(state-7-to-8:load:adult-core +.u.cached-state) ?> ?=(%8 -.u.cached-state) =. ames-state.adult-gate +.u.cached-state - [moz adult-gate] + [moz larval-core(cached-state ~)] -- :: adult ames, after metamorphosis from larva ::
fix: initialize variables
@@ -394,14 +394,14 @@ static void gen_struct (FILE * fp, struct jc_struct *s) static void gen_open_namespace (FILE * fp, char ** p) { - for (int i; p[i]; i++) { + for (int i = 0; p[i]; i++) { fprintf(fp, "namespace %s {\n", p[i]); } } static void gen_close_namespace (FILE * fp, char ** p) { - for (int i; p[i]; i++) { + for (int i = 0; p[i]; i++) { fprintf(fp, "} // %s\n", p[i]); } }
chat-cli: forward-port
:: and trust it to take care of the rest. :: /- *chat-store, *chat-view, *chat-hook, - *permission-store, *group-store, + *permission-store, *group-store, *invite-store, sole-sur=sole /+ sole-lib=sole, chat-eval, default-agent, verb :: %poke cage == + :: +invite-card: build invite card + :: + ++ invite-card + |= [where=path who=ship] + ^- card + :* %pass + /cli-command/invite + %agent + [who %invite-hook] ::NOTE only place chat-cli pokes others + %poke + %invite-action + :: + !> + ^- invite-action + :^ %invite /chat + (shax (jam [our-self where] who)) + ^- invite + =; desc=cord + [our-self %chat-hook where who desc] + %- crip + %+ weld + "You have been invited to chat at " + ~(full tr [our-self where]) + == :: +set-target: set audience, update prompt :: ++ set-target |= [allow=? rw=?(%r %w %rw) =path ships=(set ship)] ^- (quip card state) :_ all-state + =; cards=(list card) + ?. allow cards + %+ weld cards + %+ turn ~(tap in ships) + (cury invite-card path) %+ murn ^- (list term) ?- rw (lth (lent path.one) (lent path.two)) :: if they're from different ships, neither ours, pick hierarchically. (lth (xeb ship.one) (xeb ship.two)) - :: +phat: render target fully + :: +full: render target fully, always + :: + ++ full + ^- tape + (weld (scow %p ship.one) (spud path.one)) + :: +phat: render target with local shorthand :: :: renders as ~ship/path. :: for local mailboxes, renders just /path.
Update changelog for 1.9.20
@@ -5,7 +5,15 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/). -## [1.9.20](https://github.com/ledgerhq/app-ethereum/compare/1.9.19...1.9.20) - 2022-XX-XX +## [1.9.20](https://github.com/ledgerhq/app-ethereum/compare/1.9.19...1.9.20) - 2022-09-19 + +### Added + +- (clone) XDCNetwork +- (clone) Meter +- (clone) Multivac +- (clone) Tecra +- (clone) ApothemNetwork ### Changed
Updated json.
}, "url": "https://github.com/ROBOTIS-GIT/OpenCR/releases/download/1.4.0/opencr_core_1.4.0.tar.bz2", "archiveFileName": "opencr_core_1.4.0.tar.bz2", - "checksum": "SHA-256:919e87e5c4b527ace52c3cbb15ec6a9ae4b0159e0891f95f46e09596dc9371d7", - "size": "2523950", + "checksum": "SHA-256:9da3b2f6cca60b3a8328354604799deac7498b20477ebcbb0dc345175ade51bf", + "size": "2507416", "help": { "online": "http://emanual.robotis.com/docs/en/parts/controller/opencr10/" },
port setting before header reset
@@ -274,9 +274,11 @@ for pe in pipeline_elements: #[ void handle_packet(${STDPARAMS}) #[ { #[ int value32; +#[ int res32; #[ EXTRACT_INT32_BITS_PACKET(pd, header_instance_standard_metadata, field_standard_metadata_t_ingress_port, value32) #[ debug("### HANDLING PACKET ARRIVING AT PORT %" PRIu32 "...\n", value32); #[ reset_headers(pd); +#[ MODIFY_INT32_INT32_BITS_PACKET(pd, header_instance_standard_metadata, field_standard_metadata_t_ingress_port, value32) #[ parse_packet(pd, tables); #[ emit_addr = pd->data; #[ process_packet(pd, tables);
[mock] Update grpc mock for test
@@ -180,13 +180,13 @@ func (mr *MockAergoRPCServiceClientMockRecorder) GetBlockTX(arg0, arg1 interface } // GetNameInfo mocks base method -func (m *MockAergoRPCServiceClient) GetNameInfo(arg0 context.Context, arg1 *types.SingleBytes, arg2 ...grpc.CallOption) (*types.Name, error) { +func (m *MockAergoRPCServiceClient) GetNameInfo(arg0 context.Context, arg1 *types.Name, arg2 ...grpc.CallOption) (*types.NameInfo, error) { varargs := []interface{}{arg0, arg1} for _, a := range arg2 { varargs = append(varargs, a) } ret := m.ctrl.Call(m, "GetNameInfo", varargs...) - ret0, _ := ret[0].(*types.Name) + ret0, _ := ret[0].(*types.NameInfo) ret1, _ := ret[1].(error) return ret0, ret1 }
sidk_s5jt200: register ADC driver at boot S5J supports 4 ADC channels that are exported through GPIO pins. This commit initializes the ADC driver and registers a device node at boot stage.
#include <chip.h> #include "s5j_rtc.h" +#include "s5j_adc.h" #include "up_internal.h" #include <apps/shell/tash.h> @@ -224,6 +225,41 @@ static void sidk_s5jt200_configure_partitions(void) #endif /* CONFIG_SIDK_S5JT200_FLASH_PART */ } +/**************************************************************************** + * Name: sidk_s5jt200_adc_setup + * + * Description: + * Initialize ADC and register the ADC driver. + * + ****************************************************************************/ +int sidk_s5jt200_adc_setup(void) +{ +#ifdef CONFIG_S5J_ADC + int ret; + struct adc_dev_s *adc; + uint8_t chanlist[] = { + adc_channel_0, + adc_channel_1, + adc_channel_2, + adc_channel_3, + }; + + /* Get an instance of the ADC interface */ + adc = s5j_adc_initialize(chanlist, sizeof(chanlist)); + if (adc == NULL) { + return -ENODEV; + } + + /* Register the ADC driver at "/dev/adc0" */ + ret = adc_register("/dev/adc0", adc); + if (ret < 0) { + return ret; + } +#endif /* CONFIG_S5J_ADC */ + + return OK; +} + /**************************************************************************** * Name: board_app_initialize * @@ -317,6 +353,8 @@ int board_app_initialize(void) #endif /* CONFIG_RTC_DRIVER */ #endif /* CONFIG_RTC */ + sidk_s5jt200_adc_setup(); + scsc_wpa_ctrl_iface_init(); #ifdef CONFIG_TASH
fix client_auth fail
@@ -1813,7 +1813,7 @@ static int ssl_tls13_parse_certificate_request( mbedtls_ssl_context *ssl, goto decode_error; } - ssl->client_auth = 1; + ssl->handshake->client_auth = 1; return( 0 ); decode_error: @@ -1861,7 +1861,7 @@ static int ssl_tls13_process_certificate_request( mbedtls_ssl_context *ssl ) } MBEDTLS_SSL_DEBUG_MSG( 3, ( "got %s certificate request", - ssl->client_auth ? "a" : "no" ) ); + ssl->handshake->client_auth ? "a" : "no" ) ); mbedtls_ssl_handshake_set_state( ssl, MBEDTLS_SSL_SERVER_CERTIFICATE );
PlatformIO needs 6.0.2 in library.json
{ "name": "lvgl", - "version": "6.0.1", + "version": "6.0.2", "keywords": "graphics, gui, embedded, littlevgl", "description": "Graphics library to create embedded GUI with easy-to-use graphical elements, beautiful visual effects and low memory footprint. It offers anti-aliasing, opacity, and animations using only one frame buffer.", "repository":
osd displaying adjustable callsign
@@ -116,7 +116,7 @@ int binding_while_armed = 1; //Flash Memory Feature defaults for a flash w/full chip erase int flash_feature_1 = 1; //SETUP WIZARD int flash_feature_2 = 0; //LVC -unsigned long osd_element[OSD_NUMBER_ELEMENTS] = { 0xAB, 0x43495551, 0x4C49534B, 0x3F524556, 0x3F3F3F3F, 0x3F3F3F3F, 0x704, 0x72D, 0x754 }; +unsigned long osd_element[OSD_NUMBER_ELEMENTS] = { 0xA7, 0x43495551, 0x4C49534B, 0x3F524556, 0x3F3F3F3F, 0x3F3F3F3F, 0x704, 0x72D, 0x754 }; // for led flash on gestures
Rework the track info
#include "../../color.h" #include "../../string-sizes.h" +// This extensions let the plugin query info about the track and device chain it's in. +// It is useful when the plugin is created, to initialize some parameters (mix, dry, wet) +// and pick a suitable configuartion regarding audio port type and channel count. +// +// The terminology used in this extension: +// A track is a channel. +// A channel contains one device chain and usually a mixer at the end. +// A device chain, contains a bunch of devices. +// A device may contain nested channels, return channels (for send FX) and device chains. +// +// For example, consider a Drum Machine device, each drum pads contains a channel which contains +// themselves device chains. Additionnaly a Drum Machine device can contain return channels for +// send FX. + static CLAP_CONSTEXPR const char CLAP_EXT_TRACK_INFO[] = "clap.track-info.draft/0"; #ifdef __cplusplus @@ -40,19 +54,12 @@ typedef struct clap_track_info { bool is_return_track; // Info relatives to the device chain owning the plugin instance. - // A track is a channel. - // A channel contains one device chain and usually a mixer at the end. - // A device chain, contains a bunch of devices. - // A device may contain nested channels, return channels (for send FX) and device chains. - // For example, consider a Drum Machine device, each drum pads contains a channel which contains - // themselves device chains. Additionnaly a Drum Machine device can contain return channels for - // send FX. // // device_chain_id: a host specific device_chain identifier, can be a uuid for example // device_chain_path: "/group1/group2/808 Legend/drum-machine/pads/808 Legend CLAP" // or "/group1/group2/808 Legend/drum-machine/returns/Delay" - // device_chain_color: the device chain's color, in our example, that could be the drum pad - // color. is_return_channel: true if the channel owning the plugin is a return channel, in which + // device_chain_color: the device chain's color, in our example, that could be the drum pad color. + // is_return_channel: true if the channel owning the plugin is a return channel, in which // case you may want to initialize your FX's 100% wet (no dry signal) char device_chain_id[CLAP_CUSTOM_ID_SIZE]; char device_chain_name[CLAP_NAME_SIZE];
when building hip we need to patch the installed includes always
@@ -188,7 +188,11 @@ if [ "$1" == "install" ] ; then fi # post install fix to hip headers to support hip+openmp # FIXME: Remove when this patch is added to ROCm HIP + save_patch_state=$AOMP_APPLY_ROCM_PATCHES + AOMP_APPLY_ROCM_PATCHES=1 patchfile=$thisdir/patches/hip.patch patchdir=$INSTALL_HIP patchrepo + AOMP_APPLY_ROCM_PATCHES=$save_patch_state + export AOMP_APPLY_ROCM_PATCHES fi
CI: do not install idf python env for integration test
@@ -828,6 +828,8 @@ component_ut_test_lan8720: extends: - .target_test_job_template - .rules:test:integration_test + # needn't install idf python env + - .before_script_minimal needs: - assign_test - build_ssc_esp32 @@ -846,6 +848,10 @@ component_ut_test_lan8720: - *define_config_file_name # first test if config file exists, if not exist, exit 0 - test -e $CONFIG_FILE || exit 0 + # prepare test utilities + - source tools/ci/setup_python.sh + - add_gitlab_ssh_keys + - fetch_submodules # clone local test env configs - retry_failed git clone $TEST_ENV_CONFIG_REPO - python $CHECKOUT_REF_SCRIPT ci-test-runner-configs ci-test-runner-configs @@ -873,6 +879,10 @@ nvs_compatible_test: - *define_config_file_name # first test if config file exists, if not exist, exit 0 - test -e $CONFIG_FILE || exit 0 + # prepare test utilities + - source tools/ci/setup_python.sh + - add_gitlab_ssh_keys + - fetch_submodules # clone local test env configs - retry_failed git clone $TEST_ENV_CONFIG_REPO - python $CHECKOUT_REF_SCRIPT ci-test-runner-configs ci-test-runner-configs
cmd/kubectl: Export SigHandler().
@@ -708,12 +708,12 @@ func waitForNoOperation(traceID string) (*gadgetv1alpha1.TraceList, error) { var sigIntReceivedNumber = 0 -// sigHandler installs a handler for all signals which cause termination as +// SigHandler installs a handler for all signals which cause termination as // their default behavior. // On reception of this signal, the given trace will be deleted. // This function fixes trace not being deleted when calling: // kubectl gadget process-collector -A | head -n0 -func sigHandler(traceID *string, printTerminationMessage bool) { +func SigHandler(traceID *string, printTerminationMessage bool) { c := make(chan os.Signal) signal.Notify(c, syscall.SIGHUP, syscall.SIGINT, syscall.SIGQUIT, syscall.SIGILL, syscall.SIGABRT, syscall.SIGFPE, syscall.SIGSEGV, syscall.SIGPIPE, syscall.SIGALRM, syscall.SIGTERM, syscall.SIGBUS, syscall.SIGTRAP) go func() { @@ -730,7 +730,7 @@ func sigHandler(traceID *string, printTerminationMessage bool) { os.Exit(1) } - sigHandler(traceID, printTerminationMessage) + SigHandler(traceID, printTerminationMessage) } if *traceID != "" { @@ -917,7 +917,7 @@ func PrintAllTraces(config *TraceConfig) error { func RunTraceAndPrintStream(config *TraceConfig, transformLine func(string) string) error { var traceID string - sigHandler(&traceID, config.CommonFlags.OutputMode != commonutils.OutputModeJSON) + SigHandler(&traceID, config.CommonFlags.OutputMode != commonutils.OutputModeJSON) if config.TraceOutputMode != gadgetv1alpha1.TraceOutputModeStream { return errors.New("TraceOutputMode must be Stream. Otherwise, call RunTraceAndPrintStatusOutput") @@ -938,7 +938,7 @@ func RunTraceAndPrintStream(config *TraceConfig, transformLine func(string) stri func RunTraceStreamCallback(config *TraceConfig, callback func(line string, node string)) error { var traceID string - sigHandler(&traceID, false) + SigHandler(&traceID, false) if config.TraceOutputMode != gadgetv1alpha1.TraceOutputModeStream { return errors.New("TraceOutputMode must be Stream") @@ -971,7 +971,7 @@ func RunTraceAndPrintStatusOutput( ) error { var traceID string - sigHandler(&traceID, false) + SigHandler(&traceID, false) if config.TraceOutputMode == gadgetv1alpha1.TraceOutputModeStream { return errors.New("TraceOutputMode must not be Stream. Otherwise, call RunTraceAndPrintStream")
Fixing invalid references in log statements. This fix the compile error due to the previous patch for this JIRA.
@@ -114,7 +114,7 @@ gpfs_hdfs_connect(PG_FUNCTION_ARGS) ccname = FSYS_UDF_GET_CCNAME(fcinfo); if (NULL == host) { - elog(WARNING, "get host invalid in %s" __func__); + elog(WARNING, "get host invalid in %s", __func__); retval = -1; errno = EINVAL; PG_RETURN_INT32(retval);
[cmake] improve PATH support
@@ -40,8 +40,13 @@ IF (PathFerris_LIBRARY) SET(HAVE_PATHFERRIS TRUE) endif() IF (NOT PathFerris_FIND_QUIETLY) + IF(${PathFerris_LIBRARY} MATCHES ".*-NOTFOUND") + MESSAGE(STATUS "Could not find library named path${PathFerris_VERSION} for PathFerris support") + MESSAGE(STATUS "Try setting either PathFerris_DIR or (DY)LD_LIBRARY_PATH to the directory where the library is") + ELSE() MESSAGE(STATUS "Found PathFerris: ${PathFerris_LIBRARY}") MESSAGE(STATUS "PathFerris_LIBRARIES: ${PathFerris_LIBRARIES}") + ENDIF() ENDIF (NOT PathFerris_FIND_QUIETLY) # Final check :
Forgot to check if the defines are configurable
@@ -43,9 +43,11 @@ def main(root, defines): if dependants != []: dependants.pop() elif preproc_cmd.startswith("ifdef"): + defines[preproc_cmd[5:].strip()] dependants.append("defined(" + preproc_cmd[5:].strip() + ")") elif preproc_cmd.startswith("ifndef"): - dependants.append("!defined(" + preproc_cmd[5:].strip() + ")") + defines[preproc_cmd[5:].strip()] + dependants.append("!defined(" + preproc_cmd[6:].strip() + ")") elif preproc_cmd.startswith("else"): before = dependants.pop() if before.startswith("!"):
BugID:17646749: delete unnecessary topo delete operation
@@ -946,44 +946,6 @@ static int _iotx_linkkit_slave_connect(int devid) return FAIL_RETURN; } - /* Subdev Delete Topo */ - res = iotx_dm_subdev_topo_del(devid); - if (res < SUCCESS_RETURN) { - return FAIL_RETURN; - } - msgid = res; - - semaphore = HAL_SemaphoreCreate(); - if (semaphore == NULL) { - return FAIL_RETURN; - } - - _iotx_linkkit_upstream_mutex_lock(); - res = _iotx_linkkit_upstream_sync_callback_list_insert(msgid, semaphore, &node); - if (res != SUCCESS_RETURN) { - HAL_SemaphoreDestroy(semaphore); - _iotx_linkkit_upstream_mutex_unlock(); - return FAIL_RETURN; - } - _iotx_linkkit_upstream_mutex_unlock(); - - res = HAL_SemaphoreWait(semaphore, IOTX_LINKKIT_SYNC_DEFAULT_TIMEOUT_MS); - if (res < SUCCESS_RETURN) { - _iotx_linkkit_upstream_mutex_lock(); - _iotx_linkkit_upstream_sync_callback_list_remove(msgid); - _iotx_linkkit_upstream_mutex_unlock(); - return FAIL_RETURN; - } - - _iotx_linkkit_upstream_mutex_lock(); - code = node->code; - _iotx_linkkit_upstream_sync_callback_list_remove(msgid); - if (code != SUCCESS_RETURN) { - _iotx_linkkit_upstream_mutex_unlock(); - return FAIL_RETURN; - } - _iotx_linkkit_upstream_mutex_unlock(); - /* Subdev Register */ res = iotx_dm_subdev_register(devid); if (res < SUCCESS_RETURN) { @@ -1256,7 +1218,6 @@ static int _iotx_linkkit_subdev_login(int devid) ((int (*)(const int))callback)(devid); } - return res; }
Prevent use after free for inbound cluster link
@@ -845,10 +845,15 @@ void setClusterNodeToInboundClusterLink(clusterNode *node, clusterLink *link) { /* A peer may disconnect and then reconnect with us, and it's not guaranteed that * we would always process the disconnection of the existing inbound link before * accepting a new existing inbound link. Therefore, it's possible to have more than - * one inbound link from the same node at the same time. */ + * one inbound link from the same node at the same time. Our cleanup logic assumes + * a one to one relationship between nodes and inbound links, so we need to kill + * one of the links. The existing link is more likely the outdated one, but it's + * possible the the other node may need to open another link. */ serverLog(LL_DEBUG, "Replacing inbound link fd %d from node %.40s with fd %d", node->inbound_link->conn->fd, node->name, link->conn->fd); + freeClusterLink(node->inbound_link); } + serverAssert(!node->inbound_link); node->inbound_link = link; link->node = node; }