status
stringclasses 1
value | repo_name
stringlengths 9
24
| repo_url
stringlengths 28
43
| issue_id
int64 1
104k
| updated_files
stringlengths 8
1.76k
| title
stringlengths 4
369
| body
stringlengths 0
254k
⌀ | issue_url
stringlengths 37
56
| pull_url
stringlengths 37
54
| before_fix_sha
stringlengths 40
40
| after_fix_sha
stringlengths 40
40
| report_datetime
timestamp[ns, tz=UTC] | language
stringclasses 5
values | commit_datetime
timestamp[us, tz=UTC] |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 1,063 |
["src/generators/dom/index.ts", "test/custom-elements/index.js", "test/custom-elements/samples/nested/Counter.html", "test/custom-elements/samples/nested/main.html", "test/custom-elements/samples/nested/test.js", "test/js/samples/css-shadow-dom-keyframes/expected-bundle.js", "test/js/samples/css-shadow-dom-keyframes/expected.js"]
|
Nested custom element fragments are created twice
|
Custom element constructors always call `this._fragment.c()`, because they don't need a `target`. But then if a custom element is referenced as a Svelte component...
```html
<ThisIsCompiledAsACustomElement/>
```
...then the parent will call `thisiscompiledasacustomelement._fragment.c()` as well. The result is that references to the elements that are actually in the DOM get nuked, meaning they don't respond to state changes.
|
https://github.com/sveltejs/svelte/issues/1063
|
https://github.com/sveltejs/svelte/pull/1064
|
b0d7dbcbad48b8cf62d84590c557e5b3fc0bea7a
|
8d0b4a17e4069a3de31b7c738304fbe0c2336326
| 2018-01-02T03:53:54Z |
javascript
| 2018-01-02T15:00:50Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 1,062 |
["src/generators/nodes/Attribute.ts", "test/runtime/samples/attribute-casing/_config.js", "test/runtime/samples/attribute-casing/main.html"]
|
case-sensitivity of SVG viewBox likely to cause silent errors
|
In most 'try online' tools, the SVG `viewBox` attribute is handled the same whether properly camel-cased or not (`viewbox`). Svelte only recognizes `viewBox`. This can make it difficult for developers new to SVG - especially when they are starting with random sample code from blogs/tutorials - as improper use simply doesn't show up. Either an compile-time warning or acceptance of both variants would be helpful.
Example:
When I try to render `<svg viewbox="-250 -250 500 500">` with the [Svelte](https://svelte.technology/repl?version=1.50.0&gist=3547a556f7fcdf284516a39d24fbff24), my image is cutoff. Whereas on W3Schools or [CodePen](https://codepen.io/anon/pen/opWRbY), it renders fine, indicating that `width` and `height` aren't inherently mandatory. I had the same results testing locally and with REPL.
When I try `<svg width=500 height=500 viewbox="-250 -250 500 500">` it will adjust the size correctly, but doesn't respect the viewbox.
Since I started with pasting a blog example, I mistakenly thought svelte couldn't handle viewbox.
|
https://github.com/sveltejs/svelte/issues/1062
|
https://github.com/sveltejs/svelte/pull/1095
|
ba770b69bc6d35caa58fd2128bc871d26f173131
|
664da84c5aaf1b61a1460a4a6f5c752ca264066e
| 2017-12-31T22:21:04Z |
javascript
| 2018-01-11T18:42:48Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 1,061 |
["src/validate/html/index.ts", "test/validator/samples/await-component-is-used/input.html", "test/validator/samples/await-component-is-used/warnings.json"]
|
Some await bugs
|
I've encountered some bugs with the new and fresh Await block.
There's a [repl here](https://svelte.technology/repl?version=1.50.0&gist=7280f4a4bc2a1843628bd6c3d7c0ad15).
- First of a minor issue, the Components used in the await block don't get registered as 'used', so a warning is incorrectly shown
- Then it appears a subcomponent in the await block won't call oncreate
- In another situation it does call oncreate (unsure how/why), but it's called in a state where the component isn't mounted yet (I notice this using refs, and them being undefined in a situation where I'm using await, and a working situation when I don't)
|
https://github.com/sveltejs/svelte/issues/1061
|
https://github.com/sveltejs/svelte/pull/1093
|
664da84c5aaf1b61a1460a4a6f5c752ca264066e
|
2537db90beeb582fb80f2abf323983612bd9d673
| 2017-12-31T13:18:15Z |
javascript
| 2018-01-11T18:43:01Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 1,044 |
["src/generators/server-side-rendering/index.ts", "test/js/samples/ssr-no-oncreate-etc/expected-bundle.js", "test/js/samples/ssr-no-oncreate-etc/expected.js", "test/server-side-rendering/index.js"]
|
SSR component render() toString method returns undefined
|
When using `${app.render()}` in a template literal, I get undefined. That seems to be caused by a bug in `toString()`:
```
var result = { head: '', addComponent: addComponent };
...
var html = AddToCart._render(result, state, options);
return {
html: html,
head: result.head,
css: { code: cssCode, map: null },
toString: function toString() {
return result.html; <-- probably should return html
}
};
```
Workaround: use `${app.render().html}` in template literals.
|
https://github.com/sveltejs/svelte/issues/1044
|
https://github.com/sveltejs/svelte/pull/1046
|
4202c56d8e886715eb653da489be41729f8703ce
|
84721421590f015db6e18c786070dbaa555588c7
| 2017-12-23T09:24:11Z |
javascript
| 2017-12-24T16:24:21Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 1,040 |
["src/generators/nodes/Component.ts", "test/runtime/samples/dynamic-component-bindings-recreated/Green.html", "test/runtime/samples/dynamic-component-bindings-recreated/Red.html", "test/runtime/samples/dynamic-component-bindings-recreated/_config.js", "test/runtime/samples/dynamic-component-bindings-recreated/main.html"]
|
Two-way data binding issue with dynamic components
|
REPL: https://svelte.technology/repl?version=1.49.1&gist=7e3783cd296545111c21728d131c1c06
Seems like when you do a two-way binding, it reverts back to the original data when a component is switched.
However, if it is just a one-way data binding, it works as expected, without reverting back to original data on switching.
|
https://github.com/sveltejs/svelte/issues/1040
|
https://github.com/sveltejs/svelte/pull/1047
|
84721421590f015db6e18c786070dbaa555588c7
|
db646945f8d6521a4f8e615deb74ba13db7653e7
| 2017-12-22T15:27:56Z |
javascript
| 2017-12-24T17:11:32Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 1,035 |
["src/generators/nodes/Element.ts", "test/runtime/samples/option-without-select/_config.js", "test/runtime/samples/option-without-select/main.html"]
|
Add support for HTML <datalist> tag
|
Seems, html datalist tag unsupported by Svelte now. Example:
https://svelte.technology/repl?version=1.49.1&gist=43345f32fd5d811d5d156d0116179572
<details>
<summary>Cannot read property 'name' of null</summary>
TypeError: Cannot read property 'name' of null
at Element.ts:58
at Array.forEach (<anonymous>)
at Element.ts:45
at Array.forEach (<anonymous>)
at Element.init (Element.ts:37)
at Node.ts:87
at Array.forEach (<anonymous>)
at EachBlock.Node.initChildren (Node.ts:84)
at EachBlock.init (EachBlock.ts:84)
at Node.ts:87
</details>
|
https://github.com/sveltejs/svelte/issues/1035
|
https://github.com/sveltejs/svelte/pull/1048
|
db646945f8d6521a4f8e615deb74ba13db7653e7
|
831cc411a1be0e56339ea76975831f35e785f461
| 2017-12-20T14:15:41Z |
javascript
| 2017-12-24T17:15:19Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 1,032 |
["src/generators/dom/Block.ts", "src/generators/nodes/AwaitBlock.ts", "src/generators/nodes/EachBlock.ts", "src/generators/nodes/Element.ts", "test/runtime/samples/await-then-catch-event/_config.js", "test/runtime/samples/await-then-catch-event/main.html"]
|
Methods in await block aren't bound to data
|
```
VM637:126 Uncaught TypeError: Cannot read property 'undefined' of undefined
at HTMLParagraphElement.click_handler (eval at n.createComponent (Viewer.html:241), <anonymous>:126:95)
click_handler @ VM637:126
```
Example here
https://svelte.technology/repl?version=1.49.1&gist=361d6d60d683f7a3572e54a30fcfd47c
|
https://github.com/sveltejs/svelte/issues/1032
|
https://github.com/sveltejs/svelte/pull/1049
|
831cc411a1be0e56339ea76975831f35e785f461
|
a3d8425ddccd1c69adf1dbef99cb7b8fbfa2cebc
| 2017-12-18T13:15:26Z |
javascript
| 2017-12-24T17:51:08Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 1,026 |
["src/generators/nodes/Text.ts", "test/js/samples/head-no-whitespace/expected-bundle.js", "test/js/samples/head-no-whitespace/expected.js", "test/js/samples/head-no-whitespace/input.html"]
|
Remove whitespace nodes inside <:Head>
|
Whitespace is irrelevant inside `<head>`, so it should be removed.
|
https://github.com/sveltejs/svelte/issues/1026
|
https://github.com/sveltejs/svelte/pull/1054
|
f7c68be15d0e76c7b1710b92af6d993c016a385e
|
316d32b08d14c881f11dc1fbfb7c161a4f59cfd7
| 2017-12-14T02:25:42Z |
javascript
| 2017-12-30T15:46:53Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 1,022 |
["src/generators/nodes/Element.ts", "test/runtime/samples/option-without-select/_config.js", "test/runtime/samples/option-without-select/main.html"]
|
<option> outside of <select> throws error
|
Using svelte 1.47.2 and 1.45.0.
REPL: https://svelte.technology/repl?version=1.47.2&gist=7d15de2a904b723c8c0395a1dee35df8
When an `<option>` element is not contained in a `<select>` (or any element for that matter), it throws an error as the special handling for `<option>` elements expects the parent to be a `<select>`. While there are few use cases for an option outside of a select, my use case is one where the option element needs its own component space for state subscription purposes.
|
https://github.com/sveltejs/svelte/issues/1022
|
https://github.com/sveltejs/svelte/pull/1048
|
db646945f8d6521a4f8e615deb74ba13db7653e7
|
831cc411a1be0e56339ea76975831f35e785f461
| 2017-12-13T04:37:56Z |
javascript
| 2017-12-24T17:15:19Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 1,015 |
["src/generators/Generator.ts", "src/generators/dom/index.ts", "src/generators/server-side-rendering/index.ts", "src/validate/js/propValidators/index.ts", "src/validate/js/propValidators/preload.ts", "test/js/samples/ssr-no-oncreate-etc/expected-bundle.js", "test/js/samples/ssr-no-oncreate-etc/expected.js", "test/js/samples/ssr-no-oncreate-etc/input.html", "test/runtime/samples/preload/_config.js", "test/runtime/samples/preload/main.html"]
|
preload
|
Another takeaway from the [Sapper Hacker News](https://github.com/sveltejs/sapper-hacker-news) experiment — we need a conventional way to preload data, to avoid flashes of unfetched content on initial render and on route changes.
Next.js has `getInitialProps`. I propose we add a `preload` property to components, which would be added as a static property to the constructor.
```html
<!-- routes/post/[slug].html -->
<h1>{{post.title}}</h1>
{{{post.html}}}
<script>
export default {
preload({ params }) {
return fetch(`/api/post/${params.slug}`)
.then(r => r.json())
.then(post => ({ post }));
}
};
</script>
```
On the server, this could be used like so:
```js
const data = Object.assign(
Component.preload ?
await Component.preload({ params, query, client: false }) :
{},
{ params, query }
);
const { html, title } = Component.render(data);
```
The data would also be sent to the client with the initial payload, so preloading wouldn't need to happen again upon hydration.
On the client, on route changes, preloading would happen before the previous component was torn down and the new one rendered in its place.
Any thoughts? (I realise the question implies a level of familiarity with Sapper, which doesn't really exist yet, but hopefully you get the idea.)
|
https://github.com/sveltejs/svelte/issues/1015
|
https://github.com/sveltejs/svelte/pull/1021
|
9bd98e72ace064fcaa0161c2e944e721ce8349d3
|
ca6a4a7708fd337d1c7b94c4d690d6e581247928
| 2017-12-12T16:35:02Z |
javascript
| 2017-12-13T23:23:07Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 1,014 |
["src/generators/nodes/AwaitBlock.ts", "src/generators/nodes/Text.ts", "test/runtime/samples/await-then-catch-in-slot/Foo.html", "test/runtime/samples/await-then-catch-in-slot/_config.js", "test/runtime/samples/await-then-catch-in-slot/main.html"]
|
await blocks break inside components
|
[REPL](https://svelte.technology/repl?version=1.47.1&gist=a27426d394dbea15e7100cac856936a9). If the `await` block is wrapped in an element, it works fine, but not as the direct child of a component.
|
https://github.com/sveltejs/svelte/issues/1014
|
https://github.com/sveltejs/svelte/pull/1018
|
05439df9c7308bc803a9dff55ef53a2f08856bd6
|
b252e3378f7298a076d383d203cd2646594aade3
| 2017-12-12T16:26:29Z |
javascript
| 2017-12-13T01:36:30Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 1,012 |
["src/generators/Generator.ts", "src/generators/nodes/Text.ts", "test/runtime/samples/computed-values-deconflicted/_config.js", "test/runtime/samples/computed-values-deconflicted/main.html"]
|
Regression: 'state' as a computed property name throws an exception
|
Svelte `1.47.1` seems to trip up when it encounters a computed property with the name `state`.
[This is demonstrated here.](https://svelte.technology/repl?version=1.47.1&gist=3c603fac2d04f82f48ba2cc96b8032a9)
I had been using a previous version of Svelte, but when I updated to `1.47.1`, this exception appeared.
Obviously, `state` means something to Svelte internally, but it was possible to use this as a property name prior to `1.47.1` (or an earlier version), and it is useful to be able to do.
I have also included a stack trace below if that is of any help.
<details>
<summary>
Stack Trace
</summary>
Uncaught TypeError: state is not a function
at Component._recompute (app.js:42181)
at new Component (app.js:42151)
at create_main_fragment (app.js:95787)
at new Component (app.js:96512)
at create_if_block (app.js:95365)
at Object.update [as p] (app.js:95269)
at Component._set (app.js:8411)
at Object.update [as p] (app.js:112328)
at Object.update [as p] (app.js:112272)
at Component._set (app.js:8411)
</details>
|
https://github.com/sveltejs/svelte/issues/1012
|
https://github.com/sveltejs/svelte/pull/1019
|
b252e3378f7298a076d383d203cd2646594aade3
|
bc7ade0bbddca0359daca3d0482100eeceb2139f
| 2017-12-12T14:34:57Z |
javascript
| 2017-12-13T02:29:18Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 1,008 |
["src/validate/html/a11y.ts", "test/validator/samples/a11y-anchor-in-svg-is-valid/input.html", "test/validator/samples/a11y-anchor-in-svg-is-valid/warnings.json"]
|
A11y: recognizing svg a links too
|
When using SVG elements, we need to use `xlink:href` attribute in anchors for greater compatibility (Safari doesn't work with just `href`):
```html
<svg>
<text><a xlink:href="/just_a_url">Just a text</a></text>
<svg>
```
But in this case, A11y inform this warning that isn't correct (since there is an anchor):
```
A11y: <a> element should have an href attribute
```
With time, I will try to submit a pull request, if you want :)
|
https://github.com/sveltejs/svelte/issues/1008
|
https://github.com/sveltejs/svelte/pull/1076
|
a3f59521215c881e5bbc32f4e83b332afc7793e2
|
135ba9334258c6d87f7c82364e81fdc749147554
| 2017-12-11T16:34:23Z |
javascript
| 2018-01-06T21:47:53Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 1,007 |
["src/generators/nodes/Element.ts", "src/generators/nodes/Text.ts", "src/generators/nodes/shared/Node.ts", "test/runtime/samples/component-slot-empty/Nested.html", "test/runtime/samples/component-slot-empty/_config.js", "test/runtime/samples/component-slot-empty/main.html"]
|
Regression in 1.47.0 with empty default slots
|
[This REPL](https://svelte.technology/repl?version=1.47.0&gist=9eef46e2ee66b098bfca26d29ab47017) fails with `Cannot read property 'default' of undefined`
but works in `<= v1.46.0`
The following ways of adding components in `v1.47.0` work:
```
<Person :data :foo :bar />
```
```
<Person :data :foo :bar ></Person>
```
The following ways fail:
```
<Person :data :foo :bar >
</Person
```
```
<Person
:data
:foo
:bar
>
</Person>
```
|
https://github.com/sveltejs/svelte/issues/1007
|
https://github.com/sveltejs/svelte/pull/1017
|
76356cef00b924fc2b9176eb3bf6f2acdd5ce695
|
05439df9c7308bc803a9dff55ef53a2f08856bd6
| 2017-12-11T14:34:20Z |
javascript
| 2017-12-13T01:35:10Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 1,005 |
["src/server-side-rendering/register.js", "test/helpers.js", "test/server-side-rendering/samples/sanitize-name/@foo.html", "test/server-side-rendering/samples/sanitize-name/_expected.html", "test/server-side-rendering/samples/sanitize-name/main.html"]
|
ssr/register should sanitize filenames
|
This doesn't work:
```js
require('svelte/ssr/register');
const Thing = require('./pages/:thing.html');
```
We get this error:
> options.name must be a valid identifier
|
https://github.com/sveltejs/svelte/issues/1005
|
https://github.com/sveltejs/svelte/pull/1006
|
8efd1a923e81128a3a85dd3506e47fa013520d1f
|
774caf42caf6abac01c4be98b63c32a607ccd9fa
| 2017-12-11T03:17:17Z |
javascript
| 2017-12-11T15:11:05Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 1,003 |
["package.json", "src/parse/read/script.ts", "test/parser/samples/dynamic-import/input.html", "test/parser/samples/dynamic-import/output.json", "yarn.lock"]
|
Support dynamic import()
|
Just started playing around with Svelte+webpack (probably something I should have tried to get my head round a long time ago), and immediately ran into an annoyance — because acorn doesn't support dynamic `import(...)`, neither does Svelte.
It'd be nice if that worked out of the box. There's a [plugin](https://www.npmjs.com/package/acorn-dynamic-import) for it, so it should be relatively straightforward.
Open question whether any other ESnext stuff should be supported, but I think `import(...)` passes whatever threshold we'd set.
|
https://github.com/sveltejs/svelte/issues/1003
|
https://github.com/sveltejs/svelte/pull/1004
|
a10cc11fc38fc178f3fcd9af95406cff1e4592c0
|
5904a647dbb1ecbbf6f7dfa605ea67b17e440966
| 2017-12-11T00:21:13Z |
javascript
| 2017-12-11T01:09:09Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 993 |
["src/generators/nodes/Component.ts", "test/runtime/samples/dynamic-component-inside-element/Bar.html", "test/runtime/samples/dynamic-component-inside-element/Foo.html", "test/runtime/samples/dynamic-component-inside-element/_config.js", "test/runtime/samples/dynamic-component-inside-element/main.html"]
|
<:Component> Inside other tag mount to null
|
Hi, thank for such wonderful project
just stumble upon Dynamic component bugs.
provided [REPL](https://svelte.technology/repl?version=1.46.0&gist=90b93d44b6713125767cd4941378325f) of bug
when <:Component> inside other
```html
<div>
<:Component {view}></:Component>
</div>
```
switching to other type causing null error as compiled code mount to `null.parentNode`
```js
m: function mount(target, anchor) {
insertNode(h1, target, anchor);
insertNode(text_1, target, anchor);
insertNode(div, target, anchor);
if (switch_instance) switch_instance._mount(div, null);
},
p: function update(changed, state) {
if (switch_value !== (switch_value = state.view)) {
if (switch_instance) switch_instance.destroy();
if (switch_value) {
switch_instance = new switch_value(switch_props(state));
switch_instance._fragment.c();
switch_instance._mount(null.parentNode, null);
}
}
},
```
|
https://github.com/sveltejs/svelte/issues/993
|
https://github.com/sveltejs/svelte/pull/994
|
a8eaa7e95c74208907a7f10317ab38c96a5d5b09
|
e20b38e7c02be9db5dec1314bc68ca9e11069e5c
| 2017-12-09T16:24:27Z |
javascript
| 2017-12-10T14:51:51Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 991 |
["src/validate/html/a11y.ts", "test/validator/samples/a11y-figcaption-right-place/input.html", "test/validator/samples/a11y-figcaption-right-place/warnings.json"]
|
Erroneous a11y warning
|
```html
<figure>
<img src='duck.jpg' alt='a duck'>
<figcaption>a picture of a duck</figcaption>
</figure>
```
This results in an odd warning:
> A11y: <figcaption> must be first or last child of <figure>
|
https://github.com/sveltejs/svelte/issues/991
|
https://github.com/sveltejs/svelte/pull/996
|
c799230164a979adc6b7efb5a5de01a78084b602
|
0be3211c4fabc809fa055796a48c7b2d8c07f942
| 2017-12-08T22:52:24Z |
javascript
| 2017-12-10T14:57:15Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 990 |
["src/shared/index.js", "test/runtime/samples/dev-warning-bad-set-argument/_config.js", "test/runtime/samples/dev-warning-bad-set-argument/main.html"]
|
Dev mode protection against this.set(<string>) doesn't work
|
In `dev` mode, svelte wraps `set` calls in `_setDev` which checks to ensure that the first arg is an object, to protect against `this.set("foo", 1)`. Which is great.
Except it doesn't currently work due to a quirk of the `set()` implementation.
[`set(newState)` uses `this._set(assign({}, newState))`](https://github.com/sveltejs/svelte/blob/master/src/shared/index.js#L138), which is calling out to the [`assign()`](https://github.com/sveltejs/svelte/blob/master/src/shared/utils.js#L3) function. So far so good.
Except that when the `newState` value is a string, `assign()` doesn't handle it very well.
So `_setDev()` ends up getting passed a nonsense object, which bypasses the check for a string value and the error is never shown.
```html
<h1>{{key}}</h1>
<script>
export default {
data() {
return { key : false };
},
oncreate() {
this.set("key", true);
}
}
</script>
```
Will end up invoking `_setDev()` with an arg like `{ 0 : "k", 1 : "e", 2 : "y" }`, which passes the `typeof` check and then does nothing useful.
|
https://github.com/sveltejs/svelte/issues/990
|
https://github.com/sveltejs/svelte/pull/1000
|
d10f7fbdbfcacd8c6624e0e028ea1be94899ff10
|
81f449093daea0a3a97e310ce94ead9b04c779bc
| 2017-12-08T18:05:45Z |
javascript
| 2017-12-10T15:08:55Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 983 |
["src/index.ts", "src/interfaces.ts", "test/preprocess/index.js"]
|
svelte.preprocess has no file path awareness
|
I am trying to get the new `svelte.preprocess` functionality working with my [`modular-css`](https://github.com/tivac/modular-css) project, but currently none of the hooks know anything about the file they're operating on. This is problematic for anyone who wants to do things that could involve external files because it makes file resolution in any sane sort of way impossible.
I could solve this with a slightly gnarly closure variable for the case where I'm using `svelte.preprocess` directly, but I don't think that is very likely. I'm using `rollup-plugin-svelte` currently and have no desire to write my own kludgy thing instead if I can avoid it.
I have a plan that seems pretty achievable and I'd love to get your thoughts, @Rich-Harris.
I could modify `svelte.preprocess` so that each of the hooks got passed the `options` object along with the `content` to manipulate. That would make it possible to pass around more context, like the file path being manipulated. Then `rollup-plugin-svelte` would be modified to pass the `id` into the call to `svelte.preprocess()` and anyone who wants to manipulate the sections could do it with enough context to resolve `@import` statements or anything else they want.
Thoughts? I'm happy to fumble my way through a PR for this, I **really** want to get `modular-css` working with `svelte.preprocess()` so I can shrink our bundles!
|
https://github.com/sveltejs/svelte/issues/983
|
https://github.com/sveltejs/svelte/pull/987
|
be8bc797d208722c34e81194ab63dd195548dcaf
|
0ae82f3c53bf096abc578e831af78e90a0e05fbe
| 2017-12-05T18:04:40Z |
javascript
| 2017-12-09T00:37:22Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 982 |
["src/generators/nodes/Attribute.ts", "test/js/samples/dont-use-dataset-in-svg/expected-bundle.js", "test/js/samples/dont-use-dataset-in-svg/expected.js", "test/js/samples/dont-use-dataset-in-svg/input.html"]
|
SVG data attributes cause error in Edge
|
Hi,
This example does not work in Edge:
https://svelte.technology/repl?version=1.44.2&gist=9c6e3507010663c0ef9e41901736c321
The problem was the attribute `data-name`. By removing it, I got the component to work in Edge. The error it gave was "Cannot set name on undefined or null reference".
TLDR:
SVGs in components with data-xxx attributes seem to not work in Edge. See here for why:
[https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/data-*](https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/data-*)
```
<p class="footer-text">
<svg class="footer-cart" xmlns="http://www.w3.org/2000/svg"
data-name="This attribute destroyed X-mas!"
viewBox="0 0 55.8 48.6">
<title>
cart_outline
</title>
<path class="cls-1" d="M54.8 16.3H13.6a1 1 0 0 1 0-2H54.8a1 1 0 1 1 0 2Z" ></path>
<path class="cls-1" d="M47.6 37.9H18.9a1 1 0 0 1-1-0.8L9.2 2H1A1 1 0 0 1 1 0h9a1 1 0 0 1 1 0.8l8.8 35.1H47.6a1 1 0 0 1 0 2Z" ></path>
<path class="cls-1" d="M20.7 48.6A4.6 4.6 0 1 1 25.3 44 4.6 4.6 0 0 1 20.7 48.6Zm0-7.2A2.6 2.6 0 1 0 23.3 44 2.6 2.6 0 0 0 20.7 41.5Z" ></path>
<path class="cls-1" d="M44 48.6A4.6 4.6 0 1 1 48.6 44 4.6 4.6 0 0 1 44 48.6Zm0-7.2A2.6 2.6 0 1 0 46.6 44 2.6 2.6 0 0 0 44 41.5Z" ></path>
<path class="cls-1" d="M52.4 23.6H22.5a1 1 0 0 1 0-2H52.4a1 1 0 0 1 0 2Z" ></path>
<path class="cls-1" d="M50 30.7H24.3a1 1 0 0 1 0-2H50a1 1 0 1 1 0 2Z" ></path>
</svg></p>
```
|
https://github.com/sveltejs/svelte/issues/982
|
https://github.com/sveltejs/svelte/pull/995
|
e20b38e7c02be9db5dec1314bc68ca9e11069e5c
|
c799230164a979adc6b7efb5a5de01a78084b602
| 2017-12-05T09:58:16Z |
javascript
| 2017-12-10T14:55:26Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 978 |
["src/css/Selector.ts", "test/css/samples/empty-class/_config.js", "test/css/samples/empty-class/expected.css", "test/css/samples/empty-class/input.html"]
|
class="" causes errors if classes exist in <style>
|
[This](https://svelte.technology/repl?version=1.44.1&gist=520041a3403b323f4290738b30d7073a)...
```html
<div class=""></div>
<style>
.x {
color: red;
}
</style>
```
...results in an error:
> Cannot read property 'type' of undefined
|
https://github.com/sveltejs/svelte/issues/978
|
https://github.com/sveltejs/svelte/pull/997
|
0be3211c4fabc809fa055796a48c7b2d8c07f942
|
36718e79bd24f51d39c03ee7ec970c7bc4d722d4
| 2017-12-04T22:46:13Z |
javascript
| 2017-12-10T15:01:26Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 976 |
["src/generators/server-side-rendering/index.ts", "test/js/samples/ssr-no-oncreate-etc/expected-bundle.js", "test/js/samples/ssr-no-oncreate-etc/expected.js"]
|
Remove trim() from SSR compiler output
|
There's really no need for it. Just don't include the whitespace in the string in the first place! D'oh.
|
https://github.com/sveltejs/svelte/issues/976
|
https://github.com/sveltejs/svelte/pull/998
|
36718e79bd24f51d39c03ee7ec970c7bc4d722d4
|
797165b5a86634eee2d52e05c630f2656acc008f
| 2017-12-04T21:10:52Z |
javascript
| 2017-12-10T15:04:22Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 972 |
["src/generators/Generator.ts", "test/runtime/samples/dev-warning-missing-data-excludes-event/_config.js", "test/runtime/samples/dev-warning-missing-data-excludes-event/main.html"]
|
<App> was created without expected data property 'event' warning in dev mode
|
[REPL](https://svelte.technology/repl?version=1.44.1&gist=1d6b28468b66f308e96f89756629e218)
`event` should be white listed in svelte but above REPL generate code block
```
function App(options) {
this._debugName = '<App>';
if (!options || (!options.target && !options._root)) throw new Error("'target' is a required option");
init(this, options);
this._state = assign({}, options.data);
if (!('cats' in this._state)) console.warn("<App> was created without expected data property 'cats'");
if (!('event' in this._state)) console.warn("<App> was created without expected data property 'event'");
.....
}
```
and then show warning in browser console when running in dev mode .
`<App> was created without expected data property 'event'`
|
https://github.com/sveltejs/svelte/issues/972
|
https://github.com/sveltejs/svelte/pull/999
|
797165b5a86634eee2d52e05c630f2656acc008f
|
d10f7fbdbfcacd8c6624e0e028ea1be94899ff10
| 2017-12-03T21:44:45Z |
javascript
| 2017-12-10T15:06:30Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 967 |
[".gitignore", "package.json", "rollup.store.config.js"]
|
Unable to use Store server-side due to ESM
|
I'm really liking `svelte/store`, but it's a little tricky to get it working server-side due to ES modules. I was able to get it working with the following, but I'm wondering if there are other possibilities:
```js
// Currently, store is exported as ES Module
const esm = require('@std/esm')(module, { esm: 'js' });
const { Store } = esm('svelte/store');
// Compile component
require('svelte/ssr/register')({ store: true });
const app = require('./src/App.html');
```
I was thinking there are a couple of possibilities:
- Bundle with compiler, use `const { Store } = require('svelte')` server-side
- Compile `svelte/store` with `svelte/ssr/register`
|
https://github.com/sveltejs/svelte/issues/967
|
https://github.com/sveltejs/svelte/pull/1045
|
88619016860ec293fc333ab2c680f86ec8b71f2b
|
40e04407e9751bf45409825baf57cea21f78fcb2
| 2017-12-02T02:55:06Z |
javascript
| 2017-12-24T13:52:28Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 962 |
["src/generators/dom/visitors/Element/addTransitions.ts", "test/runtime/samples/transition-js-parameterised-with-state/_config.js", "test/runtime/samples/transition-js-parameterised-with-state/main.html"]
|
Transitions broken in version 1.43.0
|
Maybe it's related to the work on #956
None of the transitions work anymore, and we get an error from rollup `Cannot read property 'snippet' of undefined`
[This](https://svelte.technology/repl?version=1.43.0&data=JTdCJTIyZ2lzdCUyMiUzQW51bGwlMkMlMjJjb21wb25lbnRzJTIyJTNBJTVCJTdCJTIybmFtZSUyMiUzQSUyMkFwcCUyMiUyQyUyMnNvdXJjZSUyMiUzQSUyMiUzQ2xhYmVsJTNFJTVDbiU1Q3QlM0NpbnB1dCUyMHR5cGUlM0QnY2hlY2tib3gnJTIwYmluZCUzQWNoZWNrZWQlM0QndmlzaWJsZSclM0UlMjB2aXNpYmxlJTVDbiUzQyUyRmxhYmVsJTNFJTVDbiU1Q24lN0IlN0IlMjNpZiUyMHZpc2libGUlN0QlN0QlNUNuJTVDdCUzQyEtLSUyMHVzZSUyMCU2MGluJTYwJTJDJTIwJTYwb3V0JTYwJTJDJTIwb3IlMjAlNjB0cmFuc2l0aW9uJTYwJTIwKGJpZGlyZWN0aW9uYWwpJTIwLS0lM0UlNUNuJTVDdCUzQ2RpdiUyMHRyYW5zaXRpb24lM0FmbHklM0QnJTdCeSUzQTIwJTdEJyUzRWhlbGxvISUzQyUyRmRpdiUzRSU1Q24lN0IlN0IlMkZpZiU3RCU3RCU1Q24lNUNuJTNDc2NyaXB0JTNFJTVDbiU1Q3RpbXBvcnQlMjAlN0IlMjBmbHklMjAlN0QlMjBmcm9tJTIwJ3N2ZWx0ZS10cmFuc2l0aW9ucyclM0IlNUNuJTVDbiU1Q3RleHBvcnQlMjBkZWZhdWx0JTIwJTdCJTVDbiU1Q3QlNUN0dHJhbnNpdGlvbnMlM0ElMjAlN0IlMjBmbHklMjAlN0QlNUNuJTVDdCU3RCUzQiU1Q24lM0MlMkZzY3JpcHQlM0UlNUNuJTIyJTdEJTVEJTJDJTIyZGF0YSUyMiUzQSU3QiUyMnZpc2libGUlMjIlM0F0cnVlJTdEJTdE) is a link directly from the [user guide examples for transitions](https://svelte.technology/guide#transitions)
You will see the error as soon as you open the example in the REPL.
|
https://github.com/sveltejs/svelte/issues/962
|
https://github.com/sveltejs/svelte/pull/970
|
832311a732f6fee1ae3854630935bacf1947a8e3
|
e0d00d07370a8fba1d6ee58bf2df817193250d7e
| 2017-11-27T11:30:35Z |
javascript
| 2017-12-03T18:57:31Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 961 |
["src/generators/Generator.ts", "test/runtime/samples/component-data-static-boolean-regression/Link.html", "test/runtime/samples/component-data-static-boolean-regression/_config.js", "test/runtime/samples/component-data-static-boolean-regression/main.html"]
|
TypeError: Cannot read property 'dependencies' of undefined
|
`[email protected]` throws `TypeError: Cannot read property 'dependencies' of undefined` when certain attributes don't have explicit values. I'm not 100% sure what causes it, but [this basic repro](https://github.com/EmilTholin/svelte-dependencies-undefined) illustrates the issue.
This works great:
```html
<Component exact={{true}} href="/cool"/>
```
This throws the error:
```html
<Component exact href="/cool"/>
```
<details>
<summary>Stack trace</summary>
TypeError: Cannot read property 'dependencies' of undefined
at error (/Users/emil/Code/svelte-dependencies-undefined/node_modules/rollup/dist/rollup.js:189:14)
at Object.error (/Users/emil/Code/svelte-dependencies-undefined/node_modules/rollup/dist/rollup.js:17549:6)
at promise.then.previous (/Users/emil/Code/svelte-dependencies-undefined/node_modules/rollup/dist/rollup.js:17558:32)
at <anonymous>
at process._tickCallback (internal/process/next_tick.js:188:7)
at Function.Module.runMain (module.js:678:11)
at startup (bootstrap_node.js:187:16)
at bootstrap_node.js:608:3
</details>
|
https://github.com/sveltejs/svelte/issues/961
|
https://github.com/sveltejs/svelte/pull/965
|
3843261e4585f8322c821a9cd69c20e751bcc8f5
|
3264b5160fc69792edd6f10d7ed9450100def638
| 2017-11-26T15:16:58Z |
javascript
| 2017-11-27T13:22:23Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 957 |
["src/parse/state/mustache.ts", "test/runtime/samples/await-then-shorthand/_config.js", "test/runtime/samples/await-then-shorthand/main.html"]
|
await...then shorthand
|
Follow-up to #952. This...
```html
{{#await promise then foo}}
<p>{{foo}}</p>
{{/await}}
```
...would be a nice shorthand for this:
```html
{{#await promise}}
<!-- no need to show a pending state -->
{{then foo}}
<p>{{foo}}</p>
{{catch error}}
<!-- promise is guaranteed to fulfil -->
{{/await}}
```
|
https://github.com/sveltejs/svelte/issues/957
|
https://github.com/sveltejs/svelte/pull/1001
|
81f449093daea0a3a97e310ce94ead9b04c779bc
|
b83afb0528af1bfcec71b99e23298ce3d017eeea
| 2017-11-25T22:32:04Z |
javascript
| 2017-12-10T15:12:01Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 956 |
["src/compile/nodes/AwaitBlock.ts", "src/shared/await-block.js", "test/runtime/samples/transition-js-await-block/_config.js", "test/runtime/samples/transition-js-await-block/main.html"]
|
transitions in await blocks
|
Follow-up to #952. This currently doesn't work:
```html
{{#await promise}}
<p transition:fade>loading...</p>
{{then value}}
<p class='content' transition:fade>{{value}}</p>
{{catch error}}
<div class='toast' transition:fly='{y: 100}'>{{error.message}}</div>
{{/await}}
```
|
https://github.com/sveltejs/svelte/issues/956
|
https://github.com/sveltejs/svelte/pull/1420
|
49c594e526156dc4cbafec4035730bcb844b0b0f
|
21bc182fe77206be006e60d9082b80f71cdef30a
| 2017-11-25T22:29:53Z |
javascript
| 2018-05-05T20:06:24Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 943 |
["src/generators/dom/preprocess.ts", "src/generators/dom/visitors/Element/meta/Window.ts", "test/js/samples/window-binding-scroll/expected-bundle.js", "test/js/samples/window-binding-scroll/expected.js"]
|
Whitespace following <:Window/>
|
Fairly minor issue, but whereas [this code](https://svelte.technology/repl?version=1.42.0&gist=decf7dc9db4bc76055a88cc707c920ed)...
```html
<!-- a comment -->
<p>whitespace before this element is ignored</p>
```
...is compiled to this...
```js
function create_main_fragment(state, component) {
var p;
return {
c: function create() {
p = createElement("p");
p.textContent = "whitespace before this element is ignored";
},
m: function mount(target, anchor) {
insertNode(p, target, anchor);
},
p: noop,
u: function unmount() {
detachNode(p);
},
d: noop
};
}
```
...[this code](https://svelte.technology/repl?version=1.42.0&gist=b62f6bbfaf9d850f7c531d37da781326)...
```html
<:Window bind:scrollX/>
<p>whitespace before this element is NOT ignored</p>
```
...is compiled to this:
```js
function create_main_fragment(state, component) {
var window_updating = false, text, p;
function onwindowscroll(event) {
window_updating = true;
component.set({
scrollX: this.scrollX
});
window_updating = false;
};
window.addEventListener("scroll", onwindowscroll);
component.observe("scrollX", function(x) {
if (window_updating) return;
window.scrollTo(x, window.scrollY);
});
return {
c: function create() {
text = createText("\n\n");
p = createElement("p");
p.textContent = "whitespace before this element is NOT ignored";
},
m: function mount(target, anchor) {
insertNode(text, target, anchor);
insertNode(p, target, anchor);
},
p: noop,
u: function unmount() {
detachNode(text);
detachNode(p);
},
d: function destroy() {
window.removeEventListener("scroll", onwindowscroll);
}
};
}
```
Note the `text = createText("\n\n");`, which also has to be mounted and detached etc.
|
https://github.com/sveltejs/svelte/issues/943
|
https://github.com/sveltejs/svelte/pull/946
|
4c06226a5c450791559eef9ad778d4dd1267615e
|
582315086f4692acbe77fb55d69998b89d6efb64
| 2017-11-23T15:05:06Z |
javascript
| 2017-11-23T17:43:33Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 938 |
["src/compile/render-dom/Renderer.ts", "src/compile/render-dom/wrappers/Window.ts", "test/js/samples/computed-collapsed-if/expected.js", "test/js/samples/dev-warning-missing-data-computed/expected.js", "test/js/samples/window-binding-scroll/expected.js"]
|
Initial data seems to be not affecting the window scroll binding
|
I should mentions it's by no means a problem for my real project but I decided it might be worth sharing.
It looks like if we bind a value to window's `scrollY` the components' initial data (both default or passed to the constructor) is thrown away and replaced with the actual scroll position which is usually 0;
Repro: https://svelte.technology/repl?version=1.42.0&gist=2afe785004bcdc4c1bcca6f03f2ed7f9
|
https://github.com/sveltejs/svelte/issues/938
|
https://github.com/sveltejs/svelte/pull/1382
|
8aef96bdab6481758756f1a99ffb22929701c1f2
|
ed2a01b069f665352742d9c7a484c3bbef55c7a0
| 2017-11-22T10:30:30Z |
javascript
| 2018-10-28T12:39:36Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 936 |
["src/validate/html/validateWindow.ts", "test/validator/samples/window-binding-invalid/errors.json", "test/validator/samples/window-binding-online/errors.json", "test/validator/samples/window-binding-online/input.html"]
|
<:Window bind:online/> doesn't work
|
Not sure how I missed this ([REPL](https://svelte.technology/repl?version=1.42.0&gist=72dd99d984ef7f7e7860d942a11f2e0a)). PR inbound
|
https://github.com/sveltejs/svelte/issues/936
|
https://github.com/sveltejs/svelte/pull/937
|
b5821b846a8890952c3f5af2baf29a7e4a42348f
|
60b883b066916cf92472c8b778ee2be818aa00b2
| 2017-11-22T02:15:33Z |
javascript
| 2017-11-22T04:15:35Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 934 |
["src/parse/state/mustache.ts", "src/utils/reservedNames.ts", "test/validator/samples/each-block-invalid-context-destructured/errors.json", "test/validator/samples/each-block-invalid-context-destructured/input.html", "test/validator/samples/each-block-invalid-context/errors.json", "test/validator/samples/each-block-invalid-context/input.html"]
|
Template syntax for each breaks with reserved words as single-item variables
|
<!--
Thanks for raising an issue! (For *questions*, we recommend instead using https://stackoverflow.com and adding the 'svelte' tag.)
To help us help you, if you've found a bug please consider the following:
* If you can demonstrate the bug using https://svelte.technology/repl, please do.
* If that's not possible, we recommend creating a small repo that illustrates the problem.
* Make sure you include information about the browser, and which version of Svelte you're using
Reproductions should be small, self-contained, correct examples – http://sscce.org.
Occasionally, this won't be possible, and that's fine – we still appreciate you raising the issue. But please understand that Svelte is run by unpaid volunteers in their free time, and issues that follow these instructions will get fixed faster.
If you have a stack trace to include, we recommend putting inside a `<details>` block for the sake of the thread's readability:
<details>
<summary>Stack trace</summary>
Stack trace goes here...
</details>
-->
I ran into an issue where an `{{#each}}` in my templating code wasn't outputting values I was passing through an array.
My code:
```
<div>
{{#each cases as case}}
<h2>{{case.title}}</h2>
{{/each}}
</div>
```
The shape of my data:
```js
export default [
{
title : "One",
options : {},
data : {
}
},
{
title : "Two",
options : {},
data : {
}
},
{
title : "Three",
options : {},
data : {
}
}
];
```
Looks like since `case` is a reserved word in javascript, I can't use it in my templating. 😢
Same goes for pretty much any other reserved word, You can remove the last letter in any of the REPL examples below and see it actually render properly.
[REPL repro with "case"](https://svelte.technology/repl?version=1.42.0&gist=e4dfd2f4b224f8c8197fec48f38a42e5)
[REPL repro with "class"](https://svelte.technology/repl?version=1.42.0&gist=feaa233dcbea1635594d2b211df08808)
[REPL repro with "default"](https://svelte.technology/repl?version=1.42.0&gist=6b6af9e80f338433eff98f27b7c5c9f1)
|
https://github.com/sveltejs/svelte/issues/934
|
https://github.com/sveltejs/svelte/pull/947
|
582315086f4692acbe77fb55d69998b89d6efb64
|
14b27b71e1194e101375cc3e75b7c9742c7e6774
| 2017-11-21T19:57:55Z |
javascript
| 2017-11-23T23:36:56Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 928 |
["src/generators/dom/preprocess.ts", "src/generators/dom/visitors/Element/Element.ts", "src/generators/server-side-rendering/preprocess.ts", "test/runtime/samples/binding-select-implicit-option-value/_config.js", "test/runtime/samples/binding-select-implicit-option-value/main.html", "test/runtime/samples/binding-select-initial-value-undefined/_config.js", "test/runtime/samples/binding-select-initial-value/_config.js", "test/runtime/samples/binding-select-late/_config.js", "test/runtime/samples/binding-select/_config.js"]
|
Bound `<select>` not initialized to proper value when using `<option>`s with implicit values
|
Compare [REPL](https://svelte.technology/repl?version=1.41.3&gist=1b006e3d29beeb5beee0a03b62c31912) vs [REPL](https://svelte.technology/repl?version=1.41.3&gist=ad200757e892b8397fe0661ec71fd8c7).
Svelte should probably treat a `value`-less `<option>` as being the same as one where the `value` is set to the same as its content.
|
https://github.com/sveltejs/svelte/issues/928
|
https://github.com/sveltejs/svelte/pull/931
|
08ed270b57baf5e195e6abcc691285743a9ff526
|
509fb1a6e395b8f0a0fcfdd113b36e38ec5610a0
| 2017-11-15T15:02:58Z |
javascript
| 2017-11-19T12:53:25Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 927 |
["src/generators/dom/visitors/EachBlock.ts", "test/runtime/samples/component-slot-each-block/Nested.html", "test/runtime/samples/component-slot-each-block/_config.js", "test/runtime/samples/component-slot-each-block/main.html"]
|
Each block inside slotted content does not get updated
|
I ran across a slight issue with each blocks and slotted content: if the each block outputs directly to a slot, the state updates are not rendered. If the each block is wrapped with an element, it works:
https://svelte.technology/repl?version=1.41.3&gist=64a25260abf9c36de5bb0b4d244499e7
|
https://github.com/sveltejs/svelte/issues/927
|
https://github.com/sveltejs/svelte/pull/932
|
0a01aa02433db8c9f724b1a215cd9c0239374de8
|
d32328ca69807de98d0910175a553485824eda57
| 2017-11-14T14:49:33Z |
javascript
| 2017-11-23T16:13:18Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 915 |
["src/generators/dom/preprocess.ts", "test/runtime/samples/binding-select-optgroup/_config.js", "test/runtime/samples/binding-select-optgroup/main.html"]
|
Binding broken on <select> within optgroup
|
2-way binding is broken on `<option>` elements that are nested within an `<optgroup>` tag:
https://svelte.technology/repl?version=1.41.2&gist=29dbb2651b80d111672cd74944b4bf57
Instead of "World", the value is set to undefined
|
https://github.com/sveltejs/svelte/issues/915
|
https://github.com/sveltejs/svelte/pull/925
|
077428459ae21d0d62287d159cf5c00f86dd804c
|
3ff208ffdd3cf36fecc28f2d9a9e527ed426e944
| 2017-11-08T15:56:06Z |
javascript
| 2017-11-18T18:06:52Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 914 |
["src/generators/Generator.ts", "src/generators/server-side-rendering/index.ts", "src/utils/getName.ts", "src/utils/removeNode.ts", "src/validate/js/index.ts", "src/validate/js/propValidators/components.ts", "src/validate/js/propValidators/methods.ts", "src/validate/js/utils/checkForDupes.ts", "test/validator/samples/method-quoted/errors.json", "test/validator/samples/method-quoted/input.html"]
|
quoted method names are treated as `undefined` when validating / checking for duplicates
|
This is broken:
```js
methods: {
'foo': () => {},
'bar': () => {}
}
```
[REPL](https://svelte.technology/repl?version=1.41.2&gist=c6f7b947ce8c4e7050563892c9408f85)
<details>
<summary>Stack Trace</summary>
bundle.35d793bc40a79d89436e63d8b274bfd88d0208bd.js:1 ValidationError: Duplicate property 'undefined'
at ValidationError.CompileError [as constructor] (https://unpkg.com/[email protected]/compiler/svelte.js:11347:28)
at new ValidationError (https://unpkg.com/[email protected]/compiler/svelte.js:12555:28)
at Validator.error (https://unpkg.com/[email protected]/compiler/svelte.js:12576:15)
at https://unpkg.com/[email protected]/compiler/svelte.js:11501:23
at Array.forEach (<anonymous>)
at checkForDupes (https://unpkg.com/[email protected]/compiler/svelte.js:11499:16)
at methods (https://unpkg.com/[email protected]/compiler/svelte.js:11685:5)
at https://unpkg.com/[email protected]/compiler/svelte.js:12067:21
at Array.forEach (<anonymous>)
at https://unpkg.com/[email protected]/compiler/svelte.js:12064:41
</details>
Admittedly, I encountered this whilst trying to hack svelte's static analysis of my method names. So, perhaps it is best that method names are not permitted to be quoted. I need to call some functions that are created at runtime, so I did this in oncreate `this.someFunctions = makeSomeFunctions(args)`, in the view `on:stuff="someFunctions.foo()", and `methods: { 'someFunctions.foo': noop }`. It was just a thought to get svelte to stop yelling at me. But quite hacky. Maybe it is good to prevent me and everyone from doing this.
|
https://github.com/sveltejs/svelte/issues/914
|
https://github.com/sveltejs/svelte/pull/933
|
4411ab116e71d40ee0aa07c47dbb14164e828fa5
|
08ed270b57baf5e195e6abcc691285743a9ff526
| 2017-11-08T02:46:33Z |
javascript
| 2017-11-19T12:53:05Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 896 |
["src/generators/dom/preprocess.ts", "src/generators/server-side-rendering/visitors/EachBlock.ts", "test/runtime/samples/each-block-destructured-array/_config.js"]
|
Updates to destructuring each block arrays not rendered
|
[Branch with failing test.](https://github.com/sveltejs/svelte/tree/destructure-each-updates)
I'm going to have to poke around some more with this. Representing the destructured array as additional contexts is convenient, but Svelte needs to know when to update those values.
cc @jacobmischka
|
https://github.com/sveltejs/svelte/issues/896
|
https://github.com/sveltejs/svelte/pull/897
|
bc8847184089e7040356e7de81a26e49ce94798e
|
b1e1c5c9bf44e8069aa1f79cb565505d46c3eb25
| 2017-10-18T13:08:15Z |
javascript
| 2017-10-20T19:23:20Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 888 |
["src/generators/dom/Block.ts", "src/generators/dom/preprocess.ts", "src/generators/server-side-rendering/visitors/EachBlock.ts", "src/parse/state/mustache.ts", "test/parser/samples/each-block-destructured/input.html", "test/parser/samples/each-block-destructured/output.json", "test/runtime/samples/each-block-destructured-array/_config.js", "test/runtime/samples/each-block-destructured-array/main.html"]
|
Nice-to-have: Destructuring in each blocks
|
It would be handy if we could destructure the target item of the iterated array, ie
```handlebars
{{#each Array.from(map.entries()) as [key, value]}}
...
{{/each}}
```
Currently, this results in `ParseError: Expected name`. [REPL](https://svelte.technology/repl?version=1.40.2&gist=3fe780d02e2a5ed8e4e64edaba44abde).
Vue supports this in their v-for directives, so it might be possible to reference that to get hints on how to properly parse it.
|
https://github.com/sveltejs/svelte/issues/888
|
https://github.com/sveltejs/svelte/pull/889
|
d01d7ee580f9d4bf90865d40bda8fc308d722281
|
c394aa7848f6f1c70fd51df7f001d4289bd2b607
| 2017-10-09T19:12:36Z |
javascript
| 2017-10-17T20:50:18Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 887 |
["src/compile/nodes/Component.ts", "test/runtime/samples/component-binding-invalid-identifier/Counter.html", "test/runtime/samples/component-binding-invalid-identifier/_config.js", "test/runtime/samples/component-binding-invalid-identifier/main.html", "test/runtime/samples/component-invalid-identifier/Widget.html", "test/runtime/samples/component-invalid-identifier/_config.js", "test/runtime/samples/component-invalid-identifier/main.html"]
|
Component arguments that are not valid JS identifiers
|
<!--
Thanks for raising an issue! (For *questions*, we recommend instead using https://stackoverflow.com and adding the 'svelte' tag.)
To help us help you, if you've found a bug please consider the following:
* If you can demonstrate the bug using https://svelte.technology/repl, please do.
* If that's not possible, we recommend creating a small repo that illustrates the problem.
* Make sure you include information about the browser, and which version of Svelte you're using
Reproductions should be small, self-contained, correct examples – http://sscce.org.
Occasionally, this won't be possible, and that's fine – we still appreciate you raising the issue. But please understand that Svelte is run by unpaid volunteers in their free time, and issues that follow these instructions will get fixed faster.
If you have a stack trace to include, we recommend putting inside a `<details>` block for the sake of the thread's readability:
<details>
<summary>Stack trace</summary>
Stack trace goes here...
</details>
-->
[REPL](https://svelte.technology/repl?version=1.40.2&gist=f9fc679ecfbaac72e859150fbd12149e)
When `b-c='2'` is changed to, say, `b_c='2'` it works.
The problem is the generated code has `data: {b-c: 2}`, where `b-c` is not quoted.
|
https://github.com/sveltejs/svelte/issues/887
|
https://github.com/sveltejs/svelte/pull/1555
|
6c20d147897d907b0fa40ab0ad131becbb6878a9
|
5c6e7e878c6b074558a0afb98102847f1f0e2206
| 2017-10-06T12:11:58Z |
javascript
| 2018-06-29T21:50:06Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 872 |
["src/generators/dom/index.ts", "test/custom-elements/index.js", "test/custom-elements/samples/escaped-css/main.html", "test/custom-elements/samples/escaped-css/test.js"]
|
CSS not properly escaped in custom elements
|
This code results in an **à** character normally:
```html
<span class='icon'></span>
<style>
.icon::before {
content: '\e0'
}
</style>
```
When compiled to a custom element, though, it comes out as **e0** because the `\` character isn't escaped.
|
https://github.com/sveltejs/svelte/issues/872
|
https://github.com/sveltejs/svelte/pull/873
|
8dd3bdf04584fdccfefd287812fee2ef62965d3d
|
bcad4171ceaa92ac5e13c6f9fdd4e15cf169362e
| 2017-09-27T17:37:00Z |
javascript
| 2017-10-04T00:54:08Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 871 |
["src/css/Stylesheet.ts", "test/css/samples/unknown-at-rule/expected.css", "test/css/samples/unknown-at-rule/input.html"]
|
CSS @apply Rule support
|
The [`@apply`](https://tabatkins.github.io/specs/css-apply-rule/) rule [isn't currently supported by any browser](http://caniuse.com/#feat=css-apply-rule) but in my opinion it is a very useful feature in order to keep styles reusable by sharing global custom sets down to scoped styles.
To overcome the lack of support of custom sets, I tried to use cascading mechanism between components but I encountered several troubles to avoid unwanted style overrides with root level shared classes.
At the end I found a way to process styles with PostCSS/nextcss but when I try to use the `@apply` rule in a component I get the following error: [Cannot read property 'toLowerCase' of undefined](https://svelte.technology/repl?version=1.40.1&gist=3be642fa5e37204571256533a713c5c2).
I was wondering if it is a known limitation of the parser and if there is a way to fix it.
|
https://github.com/sveltejs/svelte/issues/871
|
https://github.com/sveltejs/svelte/pull/874
|
bcad4171ceaa92ac5e13c6f9fdd4e15cf169362e
|
c7e06744418d4802ed667c1a1e7150eeb63ad0e2
| 2017-09-24T14:31:03Z |
javascript
| 2017-10-04T00:54:25Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 858 |
["src/generators/dom/visitors/Element/Attribute.ts", "test/js/samples/do-use-dataset/expected-bundle.js", "test/js/samples/do-use-dataset/expected.js", "test/js/samples/do-use-dataset/input.html", "test/js/samples/dont-use-dataset-in-legacy/_config.js", "test/js/samples/dont-use-dataset-in-legacy/expected-bundle.js", "test/js/samples/dont-use-dataset-in-legacy/expected.js", "test/js/samples/dont-use-dataset-in-legacy/input.html"]
|
Use el.dataset.foo = bar instead of setAttribute(el, 'data-foo', bar)
|
[REPL](https://svelte.technology/repl?version=1.39.3&gist=c9f289fc5bd3af71d2137b3a8315b320). `dataset` is supported in all current browsers — we should probably generate this code...
```js
div.dataset.foo = "bar";
```
...instead of this...
```js
setAttribute(div, "data-foo", "bar");
```
...unless the `legacy` option is set.
|
https://github.com/sveltejs/svelte/issues/858
|
https://github.com/sveltejs/svelte/pull/929
|
be0837e48011fc73e5a4b0d26a9a11cf8a9d41f4
|
077428459ae21d0d62287d159cf5c00f86dd804c
| 2017-09-17T17:10:08Z |
javascript
| 2017-11-18T18:06:33Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 850 |
["src/generators/dom/visitors/IfBlock.ts", "test/runtime/samples/component-slot-if-block-before-node/Nested.html", "test/runtime/samples/component-slot-if-block-before-node/_config.js", "test/runtime/samples/component-slot-if-block-before-node/main.html", "test/runtime/samples/component-slot-if-else-block-before-node/Nested.html", "test/runtime/samples/component-slot-if-else-block-before-node/_config.js", "test/runtime/samples/component-slot-if-else-block-before-node/main.html"]
|
Default slot conditional error
|
This is possibly related to #849.
When using a default slot, you have to either wrap conditionals with other tags or have them be the only content inside the component.
This fails:
https://svelte.technology/repl?version=1.39.2&gist=f30b005debb0daa771e7c612622c1344
But this works:
https://svelte.technology/repl?version=1.39.2&gist=91607f88a95c234ba4bd9cde6947531a
And so does this:
https://svelte.technology/repl?version=1.39.2&gist=0dd35c3da30ef0687d6e553b47537e2e
|
https://github.com/sveltejs/svelte/issues/850
|
https://github.com/sveltejs/svelte/pull/851
|
fbbaff5404908b6691bc71af99a52c81e90e5992
|
14463380f7667fca985fa035df9e44e66ab46e67
| 2017-09-16T01:17:47Z |
javascript
| 2017-09-16T18:46:19Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 849 |
["src/validate/html/index.ts", "src/validate/html/validateElement.ts", "test/validator/samples/component-slotted-each-block/errors.json", "test/validator/samples/component-slotted-each-block/input.html", "test/validator/samples/component-slotted-if-block/errors.json", "test/validator/samples/component-slotted-if-block/input.html"]
|
Conditional slot errors at runtime
|
Slot content added inside an if currently fails at runtime:
https://svelte.technology/repl?version=1.39.2&gist=d4a50532f6a783ada53f35a2b9a7f9e4
This can be easily fixed by moving the condition inside the slot:
https://svelte.technology/repl?version=1.39.2&gist=3bf75a560243feecdeaca013a0e7ad26
I don't know if it makes sense to allow slots inside conditionals, but if not, Svelte could at least error on their usage.
|
https://github.com/sveltejs/svelte/issues/849
|
https://github.com/sveltejs/svelte/pull/852
|
14463380f7667fca985fa035df9e44e66ab46e67
|
6ad8c38663992d48447a854267e1e1d2bd84d319
| 2017-09-16T01:10:17Z |
javascript
| 2017-09-16T18:46:31Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 843 |
["src/generators/dom/preprocess.ts", "test/runtime/samples/svg-each-block-anchor/_config.js", "test/runtime/samples/svg-each-block-anchor/main.html"]
|
Each blocks misbehaving inside SVGs
|
[REPL](https://svelte.technology/repl?version=1.39.1&gist=7bac07e911a5116432ff6436ba445916). Checking the checkbox causes the extra ticks to be rendered in front of the `<rect>` elements, incorrectly.
|
https://github.com/sveltejs/svelte/issues/843
|
https://github.com/sveltejs/svelte/pull/844
|
b64d95021a2b0d024520a8fdfe12f1cf8817f9b3
|
129fb150bbffdd1a45e58694228df3ae3fde820b
| 2017-09-12T20:52:30Z |
javascript
| 2017-09-12T21:21:46Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 840 |
["src/generators/dom/index.ts", "test/js/samples/css-shadow-dom-keyframes/_config.js", "test/js/samples/css-shadow-dom-keyframes/expected-bundle.js", "test/js/samples/css-shadow-dom-keyframes/expected.js", "test/js/samples/css-shadow-dom-keyframes/input.html"]
|
Missing '@' in Shadow DOM @keyframes CSS
|
Hi! Thanks for your help with #821. I have an issue [in the same repo](https://github.com/mattdsteele/polymer-cat-paw/tree/svelte); I'm noticing the CSS keyframe animation isn't working - it appears the CSS is stripping off the `@` in `@keyframes`, at least when I compile it to a custom element.
Authored CSS:
```css
@keyframes creepy {
0% {
transform: translateX(20px) translateY(20px);
}
25% {
transform: translateX(20px) translateY(0);
}
50% {
transform: translateX(10px) translateY(10px);
}
100% {
transform: translateX(0) translateY(0);
}
}
```
Output:
```
_this.shadowRoot.innerHTML = "<style>img{max-height:100%;max-width:50%;position:fixed;bottom:0;right:0;animation:creepy 3s infinite alternate ease-in-out}:host{display:block}keyframes creepy{0%{transform:translateX(20px) translateY(20px)}25%{transform:translateX(20px) translateY(0)}50%{transform:translateX(10px) translateY(10px)}100%{transform:translateX(0) translateY(0)}}</style>";
```
I'm wondering if it's related to https://github.com/sveltejs/svelte/issues/712?
|
https://github.com/sveltejs/svelte/issues/840
|
https://github.com/sveltejs/svelte/pull/845
|
129fb150bbffdd1a45e58694228df3ae3fde820b
|
446fff3878c5a0353d7223dcea2528b89837ad07
| 2017-09-12T01:50:49Z |
javascript
| 2017-09-13T18:34:24Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 830 |
["src/generators/dom/visitors/Element/Element.ts"]
|
getClaimStatement uses `class` as object property name
|
Another lame IE9 problem...
It appears that `getClaimStatement` is using `class` as a property name when constructing the `attributes` object. This causes an error in IE9.
https://github.com/sveltejs/svelte/blob/ad59771bbc382703bb067e3f5ec798a0bfe183b1/src/generators/dom/visitors/Element/Element.ts#L241-L257
|
https://github.com/sveltejs/svelte/issues/830
|
https://github.com/sveltejs/svelte/pull/831
|
b367cdac40611f43e762067de5708667bacd65f9
|
91e04da9525dccb991f86c7d34dcaa7be8cfb2ef
| 2017-09-08T16:23:01Z |
javascript
| 2017-09-08T17:12:11Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 827 |
["src/generators/dom/preprocess.ts", "src/generators/dom/visitors/Element/Element.ts", "src/generators/server-side-rendering/preprocess.ts", "src/generators/server-side-rendering/visitors/Element.ts", "src/generators/shared/utils/isChildOfComponent.ts", "test/runtime/samples/slot-in-custom-element/_config.js", "test/runtime/samples/slot-in-custom-element/main.html"]
|
custom elements can't contain slot='...' children
|
There are probably a few different ways we need to fix our handling of custom elements (e.g. always using props, instead of attributes, when passing data), this just happens to the be the first one I've run across:
```html
<custom-element>
<header slot='header'>header header header</header>
</custom-element>
```
This fails because Svelte thinks the slotted element should belong to a Svelte component, and it can't find one.
|
https://github.com/sveltejs/svelte/issues/827
|
https://github.com/sveltejs/svelte/pull/847
|
faa0f7a02194ace4db1396b1aa63c4a6f5b52836
|
049fe5908298c965eacebd37edfc9dfb2a44b474
| 2017-09-07T19:59:50Z |
javascript
| 2017-09-16T14:44:51Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 822 |
["src/generators/dom/preprocess.ts", "src/generators/dom/visitors/EachBlock.ts", "src/generators/dom/visitors/IfBlock.ts", "src/generators/dom/visitors/shared/isDomNode.ts", "test/runtime/samples/component-slot-if-block/Nested.html", "test/runtime/samples/component-slot-if-block/_config.js", "test/runtime/samples/component-slot-if-block/main.html"]
|
If condition in default slot or try mount to empty fragment
|
First - example:
https://svelte.technology/repl?version=1.37.0&gist=77279f780755dcecd28eb8899a08e22d
and working one:
https://svelte.technology/repl?version=1.31.0&gist=77279f780755dcecd28eb8899a08e22d
it's happening because Svelte generates next code:
```js
if_block = create_if_block( state, component );
if_block.create();
if_block.mount( modal._slotted.default, null );
```
but modal._slotted.default it's just empty fragment because in the _fragment you did:
```js
if (slot_content_default) {
appendNode(slot_content_default, div_1);
}
```
then slot_content_default it is our modal._slotted.default .
Anyway, we can't mount to slot we should find existent dom element for that.
Example with cycle "each" don't work at all:
https://svelte.technology/repl?version=1.37.0&gist=70649b67d9f75bc91f3cc5c883b2c9e5
|
https://github.com/sveltejs/svelte/issues/822
|
https://github.com/sveltejs/svelte/pull/835
|
52559576925996b73a0b15ddcf3020e15a8841b7
|
4776c41c6fad13e74744d3abda85500e2ca50ed2
| 2017-09-06T05:03:49Z |
javascript
| 2017-09-10T20:04:59Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 804 |
["src/generators/dom/visitors/Component.ts", "test/runtime/samples/observe-binding-ignores-unchanged/Nested.html", "test/runtime/samples/observe-binding-ignores-unchanged/_config.js", "test/runtime/samples/observe-binding-ignores-unchanged/main.html"]
|
Observe work incorrect if component has bindings from parent
|
Subj. REPL example: https://svelte.technology/repl?version=1.34.0&gist=f9ea84a2f4f0c6c1a2745244023e8ae8
just try change field.
Example with directly observed from parent:
https://svelte.technology/repl?version=1.34.0&gist=43722dc52a63412f3f89726b5aecc16a
|
https://github.com/sveltejs/svelte/issues/804
|
https://github.com/sveltejs/svelte/pull/809
|
e30ff542da4d0ffb48f1e23d995a146730a0e2ac
|
7510f9c92979ecb4e852c9f43a451a9ab582bc4b
| 2017-08-31T09:54:31Z |
javascript
| 2017-09-01T16:13:06Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 801 |
["src/generators/server-side-rendering/index.ts", "src/generators/server-side-rendering/interfaces.ts", "src/generators/server-side-rendering/visitors/Component.ts", "src/generators/server-side-rendering/visitors/Element.ts", "test/runtime/samples/component-slot-nested-component/Inner.html", "test/runtime/samples/component-slot-nested-component/Outer.html", "test/runtime/samples/component-slot-nested-component/_config.js", "test/runtime/samples/component-slot-nested-component/main.html"]
|
SSR bug with nested components
|
Looks like this arose with the `<slot>` changes. Compiling
```html
<Outer>
<Inner>Foo</Inner>
</Outer>
<script>
export default { components: { Outer, Inner } }
</script>
```
in SSR mode produces
<details>
<summary>click to expand</summary>
```javascript
'use strict';
var template = (function () {
return { components: { Outer, Inner } }
}());
var SvelteComponent = {};
SvelteComponent.filename = "SvelteComponent.html";
SvelteComponent.data = function () {
return {};
};
SvelteComponent.render = function ( state, options ) {
state = state || {};
return `
${template.components.Inner.render({}, { slotted: { default: () => `Foo` } })}
${template.components.Outer.render({}, { slotted: { default: () => `Foo`, null: () => `` } })}
`.trim();
};
SvelteComponent.renderCss = function () {
var components = [];
var seen = {};
function addComponent ( component ) {
var result = component.renderCss();
result.components.forEach( x => {
if ( seen[ x.filename ] ) return;
seen[ x.filename ] = true;
components.push( x );
});
}
addComponent( template.components.Outer );
addComponent( template.components.Inner );
return {
css: components.map( x => x.css ).join( '\n' ),
map: null,
components
};
};
var escaped = {
'"': '"',
"'": ''',
'&': '&',
'<': '<',
'>': '>'
};
function __escape ( html ) {
return String( html ).replace( /["'&<>]/g, match => escaped[ match ] );
}
module.exports = SvelteComponent;
```
</details>
`<Inner>` is rendered _before_ `<Outer>`, instead of being passed as a slot. This only happens when `<Inner>` has its own child when used inside `<Outer>` (i.e., just `<Outer><Inner/></Outer>` doesn't seem to experience this). Only an issue with SSR so far as I can tell.
|
https://github.com/sveltejs/svelte/issues/801
|
https://github.com/sveltejs/svelte/pull/806
|
223dbee98c9b8faca6ad17032c3a083e65eda06a
|
865e84b85608b6e4fd900ab791ca873d3ce04ee2
| 2017-08-30T00:26:33Z |
javascript
| 2017-08-31T16:42:47Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 798 |
["src/css/Selector.ts", "test/css/samples/attribute-selector-unquoted/_config.js", "test/css/samples/attribute-selector-unquoted/expected.css", "test/css/samples/attribute-selector-unquoted/input.html"]
|
[foo=bar] crashes
|
[REPL](https://svelte.technology/repl?version=1.34.0&gist=27d1a1b7aeb1d0fe4c5240cda1c08dad). `[foo='bar']` is fine, but `[foo=bar]` is not.
|
https://github.com/sveltejs/svelte/issues/798
|
https://github.com/sveltejs/svelte/pull/800
|
835a48bec5cb49cf2bba50c512076bb0fbf15d65
|
7a9ac95b34cb8e3d46725ec366757993c0ee33a4
| 2017-08-29T21:49:36Z |
javascript
| 2017-08-30T00:34:49Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 791 |
["src/validate/html/validateElement.ts", "test/validator/samples/transition-on-component/errors.json", "test/validator/samples/transition-on-component/input.html"]
|
Warn/error if transition directives are applied to component
|
Via https://github.com/sveltejs/svelte-transitions/issues/4
|
https://github.com/sveltejs/svelte/issues/791
|
https://github.com/sveltejs/svelte/pull/793
|
56677a2074f2a0c5df610e6a53e57ff9150d7a40
|
502f6b6d14454b92ce2f89285e5e6f1b9105ebca
| 2017-08-29T11:44:05Z |
javascript
| 2017-08-29T15:23:10Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 790 |
["src/generators/server-side-rendering/visitors/Slot.ts", "src/parse/state/tag.ts", "test/runtime/samples/component-slot-nested/Nested.html", "test/runtime/samples/component-slot-nested/_config.js", "test/runtime/samples/component-slot-nested/main.html", "test/server-side-rendering/index.js", "test/validator/samples/component-slot-nested/errors.json", "test/validator/samples/component-slot-nested/input.html"]
|
<slot> can be nested
|
I misread this — it turns out [you can nest](https://webkit.org/blog/4096/introducing-shadow-dom-api/) `<slot>` elements in web components, so we should too:
```html
<b>Name</b>:
<slot name="fullName">
<slot name="firstName"></slot>
<slot name="lastName"></slot>
</slot><br>
<b>Email</b>: <slot name="email">Unknown</slot><br>
<b>Address</b>: <slot name="address">Unknown</slot>
```
If no `slot='fullName'` element was provided, it would render the `slot='firstName'` and `slot='lastName'` ones instead. Should be straightforward, I *think* it's just a case of removing the validation.
|
https://github.com/sveltejs/svelte/issues/790
|
https://github.com/sveltejs/svelte/pull/792
|
87ef5ffefd6cd993acaf2dc8d9c4911112cd0c36
|
56677a2074f2a0c5df610e6a53e57ff9150d7a40
| 2017-08-29T02:18:21Z |
javascript
| 2017-08-29T15:22:52Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 783 |
["src/css/Stylesheet.ts", "test/css/samples/unused-selector-leading/_config.js", "test/css/samples/unused-selector-leading/expected.css", "test/css/samples/unused-selector-leading/expected.html", "test/css/samples/unused-selector-leading/input.html"]
|
CSS selector removal causing style errors
|
[REPL](https://svelte.technology/repl?version=1.31.0&gist=ad2b365b960c0273a8565114faebcf28):
```html
<!--<p class='foo'>foo</p>-->
<p class='bar'>bar</p>
<p class='baz'>baz</p>
<style>
.foo, .bar, .baz {
color: red;
}
</style>
```
The `.foo` gets removed, but not the following comma, so this is the resulting broken CSS:
```css
,.bar[svelte-680739708],.baz[svelte-680739708]{color:red}
```
|
https://github.com/sveltejs/svelte/issues/783
|
https://github.com/sveltejs/svelte/pull/786
|
d6f186ddec600cf4c1a3d6a296692ba7e6339ffe
|
b43bc83cd9c6f0fca19140ff533d4acfa72e7b84
| 2017-08-25T15:29:43Z |
javascript
| 2017-08-25T21:43:55Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 782 |
["src/generators/dom/visitors/Element/EventHandler.ts", "src/utils/validCalleeObjects.ts", "src/validate/html/validateEventHandler.ts", "test/runtime/samples/event-handler-console-log/_config.js", "test/runtime/samples/event-handler-console-log/main.html", "test/validator/samples/method-nonexistent-helper/warnings.json", "test/validator/samples/method-nonexistent/warnings.json", "test/validator/samples/window-event-invalid/warnings.json"]
|
Allow console calls in event handlers?
|
Via [Gitter](https://gitter.im/sveltejs/svelte?at=599c17a4578b44a046d6f717) — might be nice if `console` was a special case in event handlers:
```html
<button on:click='console.log(event)'>click me</button>
```
Would make it easier to understand the values of `this` and `event`. There might be some other globals we should whitelist (`alert`? jk jk... or am I) but `console` is the most obvious one.
|
https://github.com/sveltejs/svelte/issues/782
|
https://github.com/sveltejs/svelte/pull/854
|
f5f94c9a0c5b62a2b41f24d0b6a2d3b71dced8cf
|
64026c3ba9751aa68b47a274d23a0cdd0e2a2527
| 2017-08-22T12:43:55Z |
javascript
| 2017-09-19T01:03:07Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 781 |
["src/generators/dom/index.ts", "src/shared/index.js", "test/runtime/samples/dev-warning-missing-data-binding/_config.js", "test/runtime/samples/dev-warning-missing-data/_config.js", "test/runtime/samples/dev-warning-readonly-computed/_config.js", "test/runtime/samples/dev-warning-readonly-window-binding/_config.js"]
|
Runtime dev warnings should indicate the component in question
|
Via [Gitter](https://gitter.im/sveltejs/svelte?at=599adcfcee5c9a4c5fe3be0c). Bit confusing if you see this without a component name...
> Component was created without expected data property 'event'
|
https://github.com/sveltejs/svelte/issues/781
|
https://github.com/sveltejs/svelte/pull/812
|
dc48ae63586852fc0acff015a165bb7644195e52
|
2c8268bf1cb6e48d095c0475356612ed6561169b
| 2017-08-22T00:51:28Z |
javascript
| 2017-09-03T16:46:23Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 774 |
["src/css/Selector.ts", "src/css/Stylesheet.ts", "test/css/samples/cascade-false-keyframes-from-to/_config.js", "test/css/samples/cascade-false-keyframes-from-to/expected.css", "test/css/samples/cascade-false-keyframes-from-to/input.html"]
|
Keyframe 'from' and 'to' selectors erroneously removed
|
[REPL](https://svelte.technology/repl?version=1.29.3&gist=b75f144f9935068802c145e38fa9a122). Svelte is under the impression that these are unused element selectors:
```css
@keyframes fade-in {
from { opacity: 0; }
to { opacity: 1; }
}
```
|
https://github.com/sveltejs/svelte/issues/774
|
https://github.com/sveltejs/svelte/pull/775
|
64cedfad199a58128be8637133ad5e29b008dd1a
|
3e9465039711a7a4fe7acd7d6fdd8e23a0411e87
| 2017-08-16T01:09:04Z |
javascript
| 2017-08-16T14:35:41Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 773 |
["src/generators/dom/index.ts", "src/generators/dom/visitors/Element/Attribute.ts", "src/interfaces.ts", "src/shared/dom.js", "test/js/index.js", "test/js/samples/legacy-input-type/_config.js", "test/js/samples/legacy-input-type/expected-bundle.js", "test/js/samples/legacy-input-type/expected.js", "test/js/samples/legacy-input-type/input.html"]
|
Potentially catch input type assignment for older browsers?
|
The new input types are great for progressive enhancement in HTML because if an old browser doesn't support them it just renders a `type="text"` input, which is perfect. Unfortunately, doing this doesn't work in svelte because (at least in IE9) the `input.type = 'search'` assignment will throw an error.
If it doesn't make things too filthy it might be nice to try to catch this assignment and fall back to text, but I totally understand if this is considered out of scope and not worth doing.
As always, thank you for everything!
|
https://github.com/sveltejs/svelte/issues/773
|
https://github.com/sveltejs/svelte/pull/778
|
828fd3ad0e66e6d4b9b376218b783c9684794d22
|
cdb3713c0bd59fa235b8646a17c6b1051f212a28
| 2017-08-15T21:30:40Z |
javascript
| 2017-08-24T17:19:49Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 767 |
["src/css/Selector.ts", "test/css/index.js", "test/css/samples/descendant-selector-non-top-level-outer/_config.js", "test/css/samples/descendant-selector-non-top-level-outer/expected.css", "test/css/samples/descendant-selector-non-top-level-outer/expected.html", "test/css/samples/descendant-selector-non-top-level-outer/input.html"]
|
Descendant selector fails if outer element is not top-level
|
[REPL](https://svelte.technology/repl?version=1.29.2&gist=08f4e2525f02a822e9433c0bd288e1c5):
```html
<div>
<p>
<span>styled</span>
</p>
</div>
<style>
p span {
color: red;
}
</style>
```
The `<p>` element is not given the `svelte-xyz` attribute (but the `<div>` is, unnecessarily).
|
https://github.com/sveltejs/svelte/issues/767
|
https://github.com/sveltejs/svelte/pull/770
|
276b7998f93a1079ebcfb968ecbba9911c3db742
|
9ef7dbc021839b095fad41eb5d94848e79afa68f
| 2017-08-13T21:45:03Z |
javascript
| 2017-08-14T18:46:47Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 762 |
["src/generators/dom/visitors/EachBlock.ts", "test/runtime/samples/each-block-static/_config.js", "test/runtime/samples/each-block-static/main.html"]
|
Uncaught Error: NotFoundError: DOM Exception 8 in {{#each}}
|
<!--
Thanks for raising an issue! (For *questions*, we recommend instead using https://stackoverflow.com and adding the 'svelte' tag.)
To help us help you, if you've found a bug please consider the following:
* If you can demonstrate the bug using https://svelte.technology/repl, please do.
* If that's not possible, we recommend creating a small repo that illustrates the problem.
* Make sure you include information about the browser, and which version of Svelte you're using
Reproductions should be small, self-contained, correct examples – http://sscce.org.
Occasionally, this won't be possible, and that's fine – we still appreciate you raising the issue. But please understand that Svelte is run by unpaid volunteers in their free time, and issues that follow these instructions will get fixed faster.
If you have a stack trace to include, we recommend putting inside a `<details>` block for the sake of the thread's readability:
<details>
<summary>Stack trace</summary>
Stack trace goes here...
</details>
-->
`Uncaught Error: NotFoundError: DOM Exception 8`, stack trace:
The relevant code looks like
<div class='tbody'>
{{#each items as item, y}}
<div class='tr'>
{{y}}
</div>
{{/each}}
</div>
`items` is initially `[]`, then it's `this.set({items: someArray})`.
I tried to reproduce in the REPL but it works there. *(Managed to [repro in the REPL](https://svelte.technology/repl?version=1.29.1&gist=b8e1568c2c7d28ddb171f02ef560ba70))*
**Browser**: Chrome v27
**Svelte**: v`1.29.1`
Sorry I realise this bug report is not 100%, what other info would be helpful?
|
https://github.com/sveltejs/svelte/issues/762
|
https://github.com/sveltejs/svelte/pull/764
|
dff1cb5fe33acddd37e72769414b89e0e65c77c6
|
4aae9a797e9a990dbb9becede83c38014d198b8c
| 2017-08-11T19:18:36Z |
javascript
| 2017-08-13T18:18:59Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 759 |
["src/compiler/parse/utils/html.ts", "test/parser/samples/attribute-escaped/input.svelte", "test/parser/samples/attribute-escaped/output.json", "test/runtime/samples/html-entities/_config.js"]
|
CSS @media tags compiled incorrectly
|
<!--
Thanks for raising an issue! (For *questions*, we recommend instead using https://stackoverflow.com and adding the 'svelte' tag.)
To help us help you, if you've found a bug please consider the following:
* If you can demonstrate the bug using https://svelte.technology/repl, please do.
* If that's not possible, we recommend creating a small repo that illustrates the problem.
* Make sure you include information about the browser, and which version of Svelte you're using
Reproductions should be small, self-contained, correct examples – http://sscce.org.
Occasionally, this won't be possible, and that's fine – we still appreciate you raising the issue. But please understand that Svelte is run by unpaid volunteers in their free time, and issues that follow these instructions will get fixed faster.
If you have a stack trace to include, we recommend putting inside a `<details>` block for the sake of the thread's readability:
<details>
<summary>Stack trace</summary>
Stack trace goes here...
</details>
-->
ISSUE:
`@media` blocks are compiled such that the `@media` tag and any successive word have no space between. Browsers then throw away the erroneous block.
For example,
```
@media only screen and (min-width: 42em) {...}
```
compiles to
```
'...@mediaonly screen and (min-width: 42em) {...}...'
```
REPRO/REFERENCE:
https://gist.github.com/anonymous/3ae1fefbef1a4fe1deb280a7654fa3c3
|
https://github.com/sveltejs/svelte/issues/759
|
https://github.com/sveltejs/svelte/pull/3071
|
60914b86fdffedd2f87434a0a3f280851fbfe2d6
|
c9e3762638c0cd858b72cbb096b8b228c2e26b8e
| 2017-08-09T23:12:20Z |
javascript
| 2019-06-23T12:41:56Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 757 |
["src/css/Stylesheet.ts", "test/css/samples/css-vars/expected.css", "test/css/samples/css-vars/input.html"]
|
CSS variables cause build failure
|
Setting a CSS variable in a `<style>` section of a svelte template triggers a build error:
```html
<style>
.foo { --test: 10; }
</style>
```
```
Module build failed: Error: TypeError: Cannot read property '0' of undefined
```
- [**repl link**](https://svelte.technology/repl?version=1.29.0&gist=85a1cead27ae3861081a7ccc406181d9)
I don't have any experience using CSS variables, but it seems like this should work.
|
https://github.com/sveltejs/svelte/issues/757
|
https://github.com/sveltejs/svelte/pull/796
|
ce109f0eb374c863a798ebfd8e6374ec5da991f1
|
0efa2ac7d7ec0bb0596de3d717b6724fbae436f8
| 2017-08-07T23:09:28Z |
javascript
| 2017-08-29T15:23:50Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 743 |
["src/css/Stylesheet.ts", "test/css/samples/combinator-child/_config.js", "test/css/samples/combinator-child/expected.css", "test/css/samples/combinator-child/expected.html", "test/css/samples/combinator-child/input.html"]
|
Cannot split a chunk that has already been edited
|
<!--
Thanks for raising an issue! (For *questions*, we recommend instead using https://stackoverflow.com and adding the 'svelte' tag.)
To help us help you, if you've found a bug please consider the following:
* If you can demonstrate the bug using https://svelte.technology/repl, please do.
* If that's not possible, we recommend creating a small repo that illustrates the problem.
* Make sure you include information about the browser, and which version of Svelte you're using
Reproductions should be small, self-contained, correct examples – http://sscce.org.
Occasionally, this won't be possible, and that's fine – we still appreciate you raising the issue. But please understand that Svelte is run by unpaid volunteers in their free time, and issues that follow these instructions will get fixed faster.
If you have a stack trace to include, we recommend putting inside a `<details>` block for the sake of the thread's readability:
<details>
<summary>Stack trace</summary>
Stack trace goes here...
</details>
-->
Running into an odd error after upgrading from ~v1.14 to v1.27.0.
`Cannot split a chunk that has already been edited (458:12 – ".inline-dl > div")`
It's happening on any CSS line that has the child selector. Not sure why this is happening, but my CSS appears to be correct, it's never happened in the past.
Example CSS:
```html
<style>
dl {
padding-left: 20px;
}
dt {
margin-top: 1rem;
}
.inline-dl > div { /* <= breaks here */
display: flex;
flex-direction: column;
}
</style>
```
|
https://github.com/sveltejs/svelte/issues/743
|
https://github.com/sveltejs/svelte/pull/746
|
95606ad0f881bacfedb04350edf2ae9f7661aab7
|
736a2f1a3dcdc6bae054282bb20d26ad4b315513
| 2017-08-01T17:45:15Z |
javascript
| 2017-08-04T02:38:35Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 740 |
["src/generators/dom/visitors/Element/Binding.ts", "test/runtime/samples/binding-input-range-change/_config.js", "test/runtime/samples/binding-input-range-change/main.html"]
|
input[type=range] + bind + ie11
|
It appears that bind applied to range inputs does not work on ie11.
`on:change` does work though.
https://svelte.technology/repl?version=1.27.0&gist=6f651445c5cb4c374b986be8cf5dcc29
|
https://github.com/sveltejs/svelte/issues/740
|
https://github.com/sveltejs/svelte/pull/766
|
2b41b837529afd02baf6d0960a6dbbfefa05e670
|
3757e75d51facbbc3895cc45a615d62d2fde0d24
| 2017-07-31T11:42:09Z |
javascript
| 2017-08-13T18:21:51Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 722 |
["src/generators/dom/index.ts", "test/runtime/samples/css/Widget.html", "test/runtime/samples/css/_config.js"]
|
Fix for @ disappearing in CSS breaks colours CSS :(
|
It appears that the fix for `@` in CSS stops colours being rendered correctly.
I'm seeing:
```
background-color: \#009fdf;
border-bottom: 3px solid \#02719e;
```
rendered in my browser, and all my colours have disappeared.
Reproduction - inspect the `h1` element to see the broken CSS:
https://svelte.technology/repl?version=1.26.0&gist=69efbf45d04be6b8f3117cc5fa7025c8
|
https://github.com/sveltejs/svelte/issues/722
|
https://github.com/sveltejs/svelte/pull/725
|
e2980a898586ac301dac6340a5c40efaced321ea
|
f550035d9365cba534e6d5b9339f18d98e2cf532
| 2017-07-25T16:18:17Z |
javascript
| 2017-07-28T15:54:12Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 721 |
["src/generators/dom/visitors/Component/Component.ts", "test/runtime/samples/component-binding-blowback-c/Nested.html", "test/runtime/samples/component-binding-blowback-c/_config.js", "test/runtime/samples/component-binding-blowback-c/main.html"]
|
Some combination of keyed blocks and binding breaks array looping
|
Reproduction: https://svelte.technology/repl?version=1.26.0&gist=59c36b2a892a2e3be0d6b1441f5971f5
When the number is increased, on every other change, only the first two (after the reverse) elements are displayed.
Like the note in the repl says, if you remove any one of `bind:top="idToTop[object.id]"`, `position="{{object.id}}"`, or `.reverse()`, the issue doesn't happen.
|
https://github.com/sveltejs/svelte/issues/721
|
https://github.com/sveltejs/svelte/pull/728
|
dbf635b445460a89fa0f4a4e05413e041961d1b7
|
57e7f75eee95683c13b3a321b822242276bec0a0
| 2017-07-25T15:42:47Z |
javascript
| 2017-07-29T22:45:15Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 713 |
["src/compiler/compile/render-dom/wrappers/Fragment.ts", "test/runtime/samples/fragment-trailing-whitespace/_config.js", "test/runtime/samples/fragment-trailing-whitespace/main.svelte"]
|
Whitespace inside elements is not being preserved inside loops
|
Very related to bug #608.
Reproduction: https://svelte.technology/repl?version=1.25.0&gist=10dd087fc24ff3dbf326c06b04e0611a
|
https://github.com/sveltejs/svelte/issues/713
|
https://github.com/sveltejs/svelte/pull/3059
|
5d51d50613537c525c74ed37a7edb4363459380c
|
fee4d351e1f681db223d111274d3f857055dfb9e
| 2017-07-18T22:40:22Z |
javascript
| 2019-06-21T17:46:50Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 711 |
["src/generators/dom/visitors/Element/Binding.ts", "test/runtime/samples/binding-select-in-yield/Modal.html", "test/runtime/samples/binding-select-in-yield/_config.js", "test/runtime/samples/binding-select-in-yield/main.html"]
|
No select example?
|
I have a select box in my component which binds a value using two-way bindings.
```javascript
<select bind:value='duration'>
{{ #each durations as dur }}
<option value="{{ dur }}">{{ dur }} months</option>
{{ /each }}
</select>
```
The component is nested inside a modal component which can show and hide.
It seems that when I hide and re-show the modal, whilst the 'duration' value has been persisted, the select has reset to the initial list item.
It seems like the two-way binding doesn't bind the selected value correctly.
It also appears that there is no `<select>` example available in the REPL.
Is there another binding I require, or is this an issue?
|
https://github.com/sveltejs/svelte/issues/711
|
https://github.com/sveltejs/svelte/pull/720
|
5f09421a18e1bf454bdc7dbc85c332b3c90ea651
|
2ab266158500b2e853c34d3478a4d5e548543bb3
| 2017-07-12T14:34:44Z |
javascript
| 2017-07-25T15:21:43Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 706 |
["src/generators/dom/visitors/Element/Ref.ts", "test/runtime/samples/ondestroy-before-cleanup/Top.html", "test/runtime/samples/ondestroy-before-cleanup/_config.js", "test/runtime/samples/ondestroy-before-cleanup/main.html"]
|
Call ondestroy before cleanup
|
So that `this.refs` is still populated, etc. From [this Gitter convo](https://gitter.im/sveltejs/svelte?at=5963505876a757f808f5cc29)
|
https://github.com/sveltejs/svelte/issues/706
|
https://github.com/sveltejs/svelte/pull/727
|
5c4905a595ece6885dfed8c44b26be544130b6a6
|
dbf635b445460a89fa0f4a4e05413e041961d1b7
| 2017-07-10T18:41:46Z |
javascript
| 2017-07-29T22:44:53Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 703 |
["src/compile/nodes/EachBlock.ts", "src/parse/state/mustache.ts", "src/shared/keyed-each.js", "test/parser/samples/each-block-keyed/output.json", "test/runtime/samples/each-block-keyed-non-prop/_config.js", "test/runtime/samples/each-block-keyed-non-prop/main.html"]
|
{{#each things as thing by thing}}
|
As mentioned in #700, it's sometimes useful to be able to use a list item as the basis for keyed updates, rather than a property of each list item.
That could be done a few different ways, e.g.:
```html
{{#each things as thing @}}
{{#each things as thing @this}}
{{#each things as thing by thing}}
```
One potentially nice feature of the last option, apart from the fact that it doesn't have off-putting special characters, is that it could be more flexible — as well as `by thing` or `by thing.id` it could potentially be *any* expression:
```html
{{#each things as thing by getId(thing)}}
```
Haven't looked into whether that's feasible. Just wondering about whether it would be desirable if so. Thoughts?
|
https://github.com/sveltejs/svelte/issues/703
|
https://github.com/sveltejs/svelte/pull/1381
|
dbab1a886d3657d99445e275e7587a016f3d87dc
|
2c3f846623bee52be6d209931a34fa7a8045a856
| 2017-07-08T15:08:49Z |
javascript
| 2018-04-29T18:15:59Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 700 |
["src/generators/dom/visitors/EachBlock.ts", "test/runtime/samples/each-block-keyed-unshift/Nested.html", "test/runtime/samples/each-block-keyed-unshift/_config.js", "test/runtime/samples/each-block-keyed-unshift/main.html"]
|
oncreate issues with Nested Components in a loop of an array with items added before the end of the array
|
It seems like there are some tracking issues with a loop, changed arrays (unshifted item), & nested component (manifested in oncreate).
https://svelte.technology/repl?version=1.24.0&gist=3d12f2bbd599b5d73443c0ded72c808c
The expected output is:
```
title__oncreate=Title 0
title__oncreate=Title 1
title__oncreate=Title 2
```
|
https://github.com/sveltejs/svelte/issues/700
|
https://github.com/sveltejs/svelte/pull/704
|
b2dd6e3f21e6245dd9a288609327d57fcbcb967c
|
6a9e1d5db9c205fa104ad1d85881b340094ed4f3
| 2017-07-08T09:39:03Z |
javascript
| 2017-07-10T11:37:53Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 699 |
["src/generators/dom/visitors/Element/EventHandler.ts", "test/runtime/samples/event-handler-hoisted/_config.js", "test/runtime/samples/event-handler-hoisted/main.html"]
|
@foo/#foo processing not done correctly in hoisted event handlers
|
https://svelte.technology/repl?version=1.24.0&gist=05a1423a50952efb61eef851a79a3905
`{{#each foo as bar}}<div on:click='baz(a)'></div>{{/each}}`
produces
```
function click_handler ( event ) {
var component = this._svelte.component;
var state = #component.get();
component.baz(state.a);
}
```
|
https://github.com/sveltejs/svelte/issues/699
|
https://github.com/sveltejs/svelte/pull/701
|
b3dc57d18d6990ecab97054d951abdd7a817d0db
|
5eff188b55cf6115938817e513e30386eeff7e0a
| 2017-07-08T02:24:43Z |
javascript
| 2017-07-08T15:51:10Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 696 |
["src/css/Selector.ts", "src/css/gatherPossibleValues.ts", "test/css/index.js", "test/css/samples/unused-selector-ternary/_config.js", "test/css/samples/unused-selector-ternary/expected.css", "test/css/samples/unused-selector-ternary/expected.html", "test/css/samples/unused-selector-ternary/input.html", "test/css/samples/unused-selector/warnings.json"]
|
Analyse ternary expressions when detecting unused CSS
|
In 1.24, Svelte will warn on unused selectors, but cases like this result in a false negative:
```html
<button class='{{active ? "active" : "inactive"}}'>click me</button>
<style>
.active {...}
.inactive {...}
.irrelevant {...}
</style>
```
It's actually not very hard to determine that the button has two possible classes — `active` and `inactive` — and optimise accordingly.
|
https://github.com/sveltejs/svelte/issues/696
|
https://github.com/sveltejs/svelte/pull/734
|
608f8943f3b42e60a6d4f5f71b5d9343c9144adb
|
26f37c2da9ff03248360333a8a4181d2b42dee82
| 2017-07-07T16:18:12Z |
javascript
| 2017-07-30T00:13:17Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 686 |
["site/package-lock.json", "site/package.json"]
|
Warning about using refs in event binding
|
It is useful to call methods on nested components by making use of refs in event bindings. Whilst this is possible, and works well, Svelte issues a warning when compiling. I would expect Svelte to either not issue a warning, or to not work - right now it does both.
The error is:
```'refs.nested.toggleEggs' is an invalid callee (should be one of this.*, event.*, set, fire or destroy)```
The ideal resolution for me is to add 'refs.*' as an allowed callee.
Svelte REPL example - open the console to see the warning:
https://svelte.technology/repl?version=1.23.4&gist=b8cd68ce59240062798c647474e1782a
|
https://github.com/sveltejs/svelte/issues/686
|
https://github.com/sveltejs/svelte/pull/5377
|
6ecc288d94e02c89d21c10cff852b82a9ab34f51
|
d201c5bfb3388259ffc3bb7f5cb717aa43293015
| 2017-06-29T11:20:09Z |
javascript
| 2020-09-10T19:42:32Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 685 |
["src/generators/dom/visitors/Component/Binding.ts", "src/generators/dom/visitors/Element/Binding.ts", "src/generators/dom/visitors/Element/EventHandler.ts", "src/generators/dom/visitors/shared/binding/getSetter.ts", "test/runtime/samples/binding-select-in-each-block/_config.js", "test/runtime/samples/binding-select-in-each-block/main.html"]
|
Bind and select: Cannot read property '_svelte' of undefined
|
Problems if I start use bind for select but errors happen in the cycle only. Example:
https://svelte.technology/repl?version=1.23.4&gist=d4a94bef5e59ef527219132bf6d6054a
|
https://github.com/sveltejs/svelte/issues/685
|
https://github.com/sveltejs/svelte/pull/690
|
459ca953f4b455051b4d036b8467edd8b838056c
|
d817f09163b09c717678ea297beff0acb73a13a3
| 2017-06-29T07:19:19Z |
javascript
| 2017-07-07T15:41:31Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 667 |
["src/generators/dom/visitors/IfBlock.ts", "test/runtime/samples/transition-js-if-block-in-each-block-bidi-2/_config.js", "test/runtime/samples/transition-js-if-block-in-each-block-bidi-2/main.html"]
|
Another wacky transition regression bug
|
[REPL](https://svelte.technology/repl?version=1.23.2&gist=ea9b71e10a37221626ae9f563d7445e7). Fix inbound
|
https://github.com/sveltejs/svelte/issues/667
|
https://github.com/sveltejs/svelte/pull/668
|
096a2fb93b5b08099da1342d7600c9304b0f0d1f
|
73715b2ba61849d3776f016434d53ce4f52d9cac
| 2017-06-23T20:51:06Z |
javascript
| 2017-06-23T21:07:47Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 665 |
["src/generators/dom/visitors/IfBlock.ts", "test/runtime/samples/transition-js-if-block-in-each-block-bidi/_config.js", "test/runtime/samples/transition-js-if-block-in-each-block-bidi/main.html"]
|
Wacky transitions in 1.23
|
[This works](https://svelte.technology/repl?version=1.22.0&gist=a21e7cb64d0a4a61111b4cc332e6c2ef) (1.22), [this doesn't](https://svelte.technology/repl?version=1.23.0&gist=a21e7cb64d0a4a61111b4cc332e6c2ef) (1.23) — waggle the slider around.
|
https://github.com/sveltejs/svelte/issues/665
|
https://github.com/sveltejs/svelte/pull/666
|
3269ed49b2e874afc895c5bb5456a8a86404c984
|
e64ee93b9f1c0e62b2202b16228355a4395de526
| 2017-06-23T19:19:42Z |
javascript
| 2017-06-23T20:29:51Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 664 |
["src/generators/dom/index.ts", "test/runtime/index.js"]
|
Add dev mode warning if `hydrate` is true but `hydratable` was false
|
https://github.com/sveltejs/svelte/issues/664
|
https://github.com/sveltejs/svelte/pull/677
|
ee5a60fd71a69c4999fa7a732810bd0303707002
|
d23798337433734a2e549f6bf5dd496cb2483b51
| 2017-06-23T18:30:18Z |
javascript
| 2017-06-25T22:11:09Z |
|
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 662 |
["src/generators/dom/visitors/EachBlock.ts", "src/generators/server-side-rendering/visitors/EachBlock.ts", "test/runtime/samples/each-block-else-starts-empty/_config.js", "test/runtime/samples/each-block-else-starts-empty/main.html"]
|
each-else causes error
|
Regression in 1.23.0:
```html
{{#each [] as thing}}
<p>{{thing}}</p>
{{else}}
<p>no things</p>
{{/each}}
```
Causes this error:
> Failed to execute 'insertBefore' on 'Node': parameter 1 is not of type 'Node'.
|
https://github.com/sveltejs/svelte/issues/662
|
https://github.com/sveltejs/svelte/pull/663
|
f6f929bdedef495cb6f5c65185c59283607dd952
|
7b9ea711536f48b2bd2c992ce19cdb32d4710d7e
| 2017-06-23T18:09:39Z |
javascript
| 2017-06-23T18:39:00Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 658 |
["src/generators/shared/processCss.ts", "test/css/samples/cascade-false-pseudo-element/_config.js", "test/css/samples/cascade-false-pseudo-element/expected.css", "test/css/samples/cascade-false-pseudo-element/input.html"]
|
Pseudo-element selectors incorrectly transformed with cascade: false
|
Can't show in the REPL, because it doesn't use `cascade: false` (we need to add some compiler options to the UI), but this fails:
```html
<span></span>
<style>
span::after {
content: 'i am a pseudo-element';
}
</style>
```
The selector becomes `span::after[svelte-123xyz]` instead of `span[svelte-123xyz]::after`.
|
https://github.com/sveltejs/svelte/issues/658
|
https://github.com/sveltejs/svelte/pull/660
|
1ce6cfaa68235e6e56f313b9c51a842f490039b7
|
02e11f51cd430044ed71b0fd2f6c95cb0877656f
| 2017-06-22T18:31:01Z |
javascript
| 2017-06-23T13:50:59Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 655 |
["src/generators/Generator.ts", "src/generators/dom/index.ts", "src/generators/server-side-rendering/index.ts", "src/validate/index.ts", "test/helpers.js", "test/runtime/samples/deconflict-self/_config.js", "test/runtime/samples/deconflict-self/main.html", "test/runtime/samples/deconflict-self/nested/main.html", "test/runtime/samples/self-reference/_config.js", "test/server-side-rendering/index.js"]
|
Deconflict names in SSR components
|
If you import a component with a name that conflicts with the component you're generating, you generate invalid JavaScript. This means that for example [this file](https://github.com/sveltejs/svelte.technology/blob/47341260b48616b93b559b44a3676e58376d0549/universal/pages/guidePage.html) has to be called `guidePage.html` instead of just `guide.html` (reflecting its `/guide` URL), because it imports `Guide`. Ugh.
|
https://github.com/sveltejs/svelte/issues/655
|
https://github.com/sveltejs/svelte/pull/674
|
e582691c6122da9842276a9a26bb76d7481c6912
|
b1d1cea3a4e8294a8574f56324c93ca05a07e72a
| 2017-06-20T13:17:01Z |
javascript
| 2017-06-25T18:53:25Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 653 |
["site/package-lock.json", "site/package.json"]
|
Streaming SSR renderer
|
At present, you can only render a component if all the data is present. This wastes an opportunity to stream markup we can already generate — it's very likely that we can print out the doctype and (most of) the `<head>` immediately, for example, even if the server is waiting on a database or network request for everything else.
Perhaps this could just mean that top-level data properties *could* be promises, and they would get `Promise.resolve(...)`'d.
Would need a new API:
```js
// sync (current API)
const html = App.render({
foo: 1,
bar: 2
});
// async
const html = await App.renderAsync({
foo: 1,
bar: Promise.resolve(2)
});
// streaming
const stream = App.renderToStream({
foo: 1,
bar: Promise.resolve(2)
});
stream.pipe(res);
```
If we had some way for components to fetch their own data asynchronously, this would enable that to work with SSR as well:
```js
const html = AppWithAsyncData.render(); // throws error
const html = await AppWithAsyncData.renderAsync(); // works
```
Open to bike-shedding!
|
https://github.com/sveltejs/svelte/issues/653
|
https://github.com/sveltejs/svelte/pull/5377
|
6ecc288d94e02c89d21c10cff852b82a9ab34f51
|
d201c5bfb3388259ffc3bb7f5cb717aa43293015
| 2017-06-20T13:06:08Z |
javascript
| 2020-09-10T19:42:32Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 651 |
["src/generators/dom/index.ts", "test/runtime/samples/transition-js-initial/_config.js", "test/runtime/samples/transition-js-initial/main.html"]
|
Transitions don't run on initial render
|
[REPL](https://svelte.technology/repl?version=1.22.5&gist=42c1cb56b55ac1daf5256c021d74f927) — the text should fade in, but doesn't. Best guess is that it's because the transition is running before the element is mounted to the DOM.
|
https://github.com/sveltejs/svelte/issues/651
|
https://github.com/sveltejs/svelte/pull/675
|
b1d1cea3a4e8294a8574f56324c93ca05a07e72a
|
ee5a60fd71a69c4999fa7a732810bd0303707002
| 2017-06-17T21:31:00Z |
javascript
| 2017-06-25T21:24:23Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 645 |
["src/generators/dom/visitors/Element/Binding.ts", "test/js/samples/input-without-blowback-guard/expected-bundle.js", "test/js/samples/input-without-blowback-guard/expected.js", "test/js/samples/input-without-blowback-guard/input.html"]
|
Redundant input blowback guard?
|
First of a couple of random thoughts I just had:
If you have a template like [this](https://svelte.technology/repl?version=1.22.4&gist=814af8163ea6d4d7be709b7e55040d84)...
```html
<input bind:value>
```
...Svelte generates code like this:
```js
function input_input_handler () {
input_updating = true;
component._set({ value: input.value });
input_updating = false;
}
// later...
if ( !input_updating ) {
input.value = state.value;
}
```
IIRC the purpose of the `input_updating` check is to prevent the cursor jumping about if, say, you edit text at the beginning of the field (I think setting the value causes the cursor to jump to the end).
In inputs without cursors (range, color, etc etc) maybe that's unnecessary?
|
https://github.com/sveltejs/svelte/issues/645
|
https://github.com/sveltejs/svelte/pull/814
|
2c8268bf1cb6e48d095c0475356612ed6561169b
|
c2352fe14058dca914f57761283f2eaa0ab824a4
| 2017-06-16T13:21:53Z |
javascript
| 2017-09-03T17:06:40Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 639 |
["src/generators/dom/visitors/Element/Binding.ts", "test/runtime/samples/binding-select-initial-value-undefined/_config.js", "test/runtime/samples/binding-select-initial-value-undefined/main.html"]
|
Binding to properties of bindings fails
|
A couple of errors here (no REPL link, because I can't access the gist API — https://github.com/sveltejs/svelte.technology/issues/97):
```html
<select bind:value='selected'>
{{#each tasks as task}}
<option value='{{task}}'>{{task.description}}</option>
{{/each}}
</select>
<!-- there should always be something selected -->
{{#if selected}}
<label>
<input type='checkbox' bind:checked='selected.done'> {{selected.description}}
</label>
{{/if}}
<h2>Pending tasks</h2>
<!-- this updates correctly -->
<strong>{{tasks.filter(t => !t.done).map(t => t.description)}}</strong>
<!-- this does not -->
{{#each tasks.filter(t => !t.done) as task}}
<p>{{task.description}}</p>
{{/each}}
<script>
export default {
data () {
return {
tasks: [
{ description: "put your left leg in", done: false },
{ description: "your left leg out", done: false },
{ description: "in, out, in, out", done: false },
{ description: "shake it all about", done: false }
]
};
}
};
</script>
```
Firstly, `selected` should (I think) default to the first task if not otherwise specified, because otherwise there's a discrepancy between state and UI.
Secondly, toggling the `done` state of a given task would ideally cause the `each tasks...` block to update. Right now, it doesn't, because the generated code looks like this:
```js
// we don't update the `each` block, because it looks like
// 'tasks' hasn't changed
var each_block_value = state.tasks;
if ( 'tasks' in changed ) {
for ( var i = 0; i < each_block_value.length; i += 1 ) {
// ...
}
}
// we're setting `selected` — we should also set `tasks`
function input_change_handler () {
input_updating = true;
var state = component.get();
state.selected.done = input.checked;
component._set({ selected: state.selected });
input_updating = false;
}
```
Presumably, then, whenever we have a `<select bind:value='foo.bar.baz'>` binding, we need to add all the dependencies of the select's child `<option>` element values (just `tasks` in this case) as dependencies of `selected`, and any time we get the dependencies of `selected`, we also get *its* dependencies. In other words, we generate this code:
```diff
function input_change_handler () {
input_updating = true;
var state = component.get();
state.selected.done = input.checked;
- component._set({ selected: state.selected });
+ component._set({ selected: state.selected, tasks: state.tasks });
input_updating = false;
}
```
It may be less straightforward in practice. Let's find out!
|
https://github.com/sveltejs/svelte/issues/639
|
https://github.com/sveltejs/svelte/pull/641
|
d2d1b7576d1a6be501578037272f5921cf1a37f0
|
5c26f81f5367226d414b01ee0d3eb1b8f1f69286
| 2017-06-14T20:31:01Z |
javascript
| 2017-06-15T17:51:00Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 634 |
["src/generators/dom/index.ts", "src/utils/deindent.ts", "test/runtime/samples/empty-style-block/_config.js", "test/runtime/samples/empty-style-block/main.html"]
|
Having an empty style tag in a child component throws an error
|
The following nested component:
```
<style></style>
<p>And this is a nested component.</p>
```
will throw a `Uncaught ReferenceError: add_css is not defined`.
https://svelte.technology/repl?version=1.22.2&gist=9b5b0093a02236e4f76ede73027eebf7
If you have whitespace in the style tag of the nested component, all is well:
```
<style>
</style>
<p>And this is a nested component.</p>
```
https://svelte.technology/repl?version=1.22.2&gist=5d03bfc1e847d55af76f52db063524b0
|
https://github.com/sveltejs/svelte/issues/634
|
https://github.com/sveltejs/svelte/pull/635
|
61f5cbef54ce42b0e323147c81d485b8aa25241e
|
928f6030d1b3facdf468dbd3d7d62c0c09908672
| 2017-06-12T20:59:32Z |
javascript
| 2017-06-13T00:35:42Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 632 |
["src/generators/Generator.ts", "src/utils/clone.ts", "test/parser/index.js"]
|
Include AST in result of svelte.compile
|
For cases like https://github.com/sveltejs/svelte.technology/issues/103, it would be useful to have access to the component AST. Should probably sanitize it first (so that internal change-prone things like `_scope` don't accidentally become depended on) which would be relatively straightforward — if it turns out that has a non-trivial impact on speed (which I doubt) then it could be put behind an option.
```js
const { code, map, ast } = svelte.compile(source);
```
|
https://github.com/sveltejs/svelte/issues/632
|
https://github.com/sveltejs/svelte/pull/636
|
5dc12bbe84f22003ce888aa9cd0b76f78e6a067c
|
d2d1b7576d1a6be501578037272f5921cf1a37f0
| 2017-06-12T17:44:34Z |
javascript
| 2017-06-15T17:50:41Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 620 |
["src/generators/dom/visitors/Element/Attribute.ts", "src/validate/html/validateElement.ts", "test/runtime/samples/attribute-dynamic-type/_config.js", "test/runtime/samples/attribute-dynamic-type/main.html", "test/validator/samples/binding-input-static-type/errors.json", "test/validator/samples/binding-input-static-type/input.html"]
|
Can't set type for input tag.
|
I am tring to generate input tag:
```html
<input type="{{cond.field_type}}" placeholder="constant"
value="{{cond.const}}" on:change="setCondConst(index, this)">
```
but svelte plugin output:
```
'svelte' plugin: 'type must be a static attribute
```
|
https://github.com/sveltejs/svelte/issues/620
|
https://github.com/sveltejs/svelte/pull/630
|
6a4c0fb80db5a0b719ae67b09ba34a210ac57cae
|
61f5cbef54ce42b0e323147c81d485b8aa25241e
| 2017-06-06T12:31:56Z |
javascript
| 2017-06-12T01:33:51Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 612 |
["src/generators/dom/visitors/Element/EventHandler.ts", "test/runtime/samples/event-handler-sanitize/_config.js", "test/runtime/samples/event-handler-sanitize/main.html"]
|
Unsafe characters in event names
|
From @stalkerg - [chat](https://gitter.im/sveltejs/svelte?at=592fc1c0631b8e4e6132c526)
Handler names are being generated from the event name without sanitizing it first.
|
https://github.com/sveltejs/svelte/issues/612
|
https://github.com/sveltejs/svelte/pull/613
|
9bf9b51428ba8473aff7256454f8baa9e369fa37
|
4cd530383119df01b769fffb26a03a872657c69a
| 2017-06-01T11:07:57Z |
javascript
| 2017-06-01T12:33:43Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 593 |
["site/package-lock.json"]
|
Using Rollup with shared helpers always includes transitionManager
|
This is probably technically in Rollup's court, but if there's anything we can do here to make the bundler behave better, that would be nice to do.
If you import any of the helpers in `shared.js` and bundle with Rollup with default settings, the `transitionManager` comes along too. I assume this has to do with it being an object instead of a function, and Rollup can't tell that it has no side effects.
FWIW, UglifyJS is able to discern that this is unneeded code and remove it, but Butternut is not. So maybe this is even in Butternut's court.
|
https://github.com/sveltejs/svelte/issues/593
|
https://github.com/sveltejs/svelte/pull/6361
|
b295d68ec696a00e4d52cc7f86fed149b13062d2
|
7c4a08e10928deae03044c0e53c899371d7f934f
| 2017-05-23T21:00:34Z |
javascript
| 2021-05-26T18:07:55Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 590 |
["src/generators/dom/visitors/Element/Element.js", "test/runtime/samples/select-props/_config.js", "test/runtime/samples/select-props/main.html"]
|
#each+<select>+on:change are not working
|
You can see this bug here: https://svelte.technology/repl?gist=1c4a9db0b3ce319f4e893138e5a6398d
list0 - on:change is working without problems
lists inside #each block - on:change is not working (Uncaught TypeError: Cannot read property 'component' of undefined
at HTMLSelectElement.change_handler (eval at U (bundle.61a4bf9….js:6), <anonymous>:170:30)
change_handler @ VM816:170
)
inputs inside #each block - on:change is working without problems
|
https://github.com/sveltejs/svelte/issues/590
|
https://github.com/sveltejs/svelte/pull/591
|
7c2fd8e3cd10e1bdc8ccb8130c8d7e04daafd0ca
|
2194de9b2804b8eb0c6527a24f4c55d705be6541
| 2017-05-18T12:06:08Z |
javascript
| 2017-05-21T19:20:41Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 587 |
["src/generators/dom/shared.ts", "src/shared/transitions.js"]
|
Simple: Patch node.style.animation to work when undefined
|
In https://github.com/sveltejs/svelte/blob/master/src/shared/transitions.js:
```js
export function generateKeyframes ( a, b, delta, duration, ease, fn, node, style ) {
var id = '__svelte' + ~~( Math.random() * 1e9 ); // TODO make this more robust
var keyframes = '@keyframes ' + id + '{\n';
for ( var p = 0; p <= 1; p += 16.666 / duration ) {
var t = a + delta * ease( p );
keyframes += ( p * 100 ) + '%{' + fn( t ) + '}\n';
}
keyframes += '100% {' + fn( b ) + '}\n}';
style.textContent += keyframes;
document.head.appendChild( style );
node.style.animation = node.style.animation.split( ',' ) // <----- Change this line
.filter( function ( anim ) {
// when introing, discard old animations if there are any
return anim && ( delta < 0 || !/__svelte/.test( anim ) );
})
.concat( id + ' ' + duration + 'ms linear 1 forwards' )
.join( ', ' );
}
```
In PhantomJS (which is nearing end-of-life, but some of us still need to use it), the `node.style.animation = ...` line produces an error (see https://github.com/sveltejs/svelte-transitions/issues/2).
When this line is changed to:
```js
node.style.animation = (node.style.animation || '').split( ',' )
```
... PhantomJS runs as expected.
*I know this is a PhantomJS bug, but PhantomJS is no longer maintained*.
|
https://github.com/sveltejs/svelte/issues/587
|
https://github.com/sveltejs/svelte/pull/598
|
4f56b6553c098c3b4852b797785472387703d6fc
|
3e30b755a3f8acceae0ec186a50387d4015eca66
| 2017-05-16T02:38:52Z |
javascript
| 2017-05-27T17:40:41Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 586 |
["src/compiler/parse/state/tag.ts", "test/parser/samples/style-inside-head/input.svelte", "test/parser/samples/style-inside-head/output.json"]
|
Errors when trying to use components compiled with previous Svelte versions
|
It looks like new versions of Svelte are breaking compatibility with components compiled with previous versions of Svelte. For example, I have created a component _ScratchComponent_ that [works fine in the REPL with v1.18.1](https://svelte.technology/repl?version=1.18.1&gist=65210a9a013bd33b91b538101c752a5d) but [doesn't work with v1.19.1](https://svelte.technology/repl?version=1.19.1&gist=65210a9a013bd33b91b538101c752a5d) and [also doesn't work with the latest version](https://svelte.technology/repl?version=1.20.2&gist=65210a9a013bd33b91b538101c752a5d). Thoughts?
|
https://github.com/sveltejs/svelte/issues/586
|
https://github.com/sveltejs/svelte/pull/5487
|
e508fb7b8b811db54ccf684fa9eba0499d1ece36
|
aa759f44fc02cccc34f275fe2afb19f68e4cf945
| 2017-05-15T22:46:21Z |
javascript
| 2020-10-02T13:30:17Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 584 |
["src/generators/dom/visitors/Element/Binding.ts", "src/shared/dom.js", "test/runtime/samples/binding-input-number/_config.js"]
|
For input[type=number] bound value not equal event value
|
<!--
Thanks for raising an issue! (For *questions*, we recommend instead using https://stackoverflow.com and adding the 'svelte' tag.)
To help us help you, if you've found a bug please consider the following:
* If you can demonstrate the bug using https://svelte.technology/repl, please do.
* If that's not possible, we recommend creating a small repo that illustrates the problem.
* Make sure you include information about the browser, and which version of Svelte you're using
Reproductions should be small, self-contained, correct examples – http://sscce.org.
Occasionally, this won't be possible, and that's fine – we still appreciate you raising the issue. But please understand that Svelte is run by unpaid volunteers in their free time, and issues that follow these instructions will get fixed faster.
If you have a stack trace to include, we recommend putting inside a `<details>` block for the sake of the thread's readability:
<details>
<summary>Stack trace</summary>
Stack trace goes here...
</details>
-->
Reproduction of issue in this REPL: https://svelte.technology/repl?version=1.20.2&gist=348577339ab2e03462b1279b38d9975b
This issue occurs when using a bound value and the `on:change` event for an `<input type="number">` element.
* What I did: enter a value in the input element, kill focus by clicking away, clear contents of input element, kill focus by clicking away.
* What happens: the first value shows up as the bound value and the event value as expected, but after clearing the input element and killing focus, the bound value is `0` while the event value is `""`.
* What I expect to happen: when an input element is cleared, the emitted `on:change` event value should allow for the empty string, and not coerce the value to `0`.
|
https://github.com/sveltejs/svelte/issues/584
|
https://github.com/sveltejs/svelte/pull/606
|
66a1fd76ddbd1ebeb64d2318c774630220d07f5d
|
b5b484bd91bcf98f58b2fa5d8032a92467955f46
| 2017-05-15T16:25:46Z |
javascript
| 2017-06-01T02:32:49Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 579 |
["src/validate/html/validateEventHandler.js", "test/validator/samples/method-nonexistent-helper/warnings.json", "test/validator/samples/method-nonexistent/warnings.json", "test/validator/samples/window-event-invalid/warnings.json"]
|
Unnecessary error during build: "invalid callee"
|
I'm adding some methods at instantiation-time, ala #284.
This now causes an error at build-time: `Error: '[method name]' is an invalid callee (should be one of this.*, event.*, set, fire, destroy, complete or restore) while parsing file: [filename]`
This should probably just be a warning.
|
https://github.com/sveltejs/svelte/issues/579
|
https://github.com/sveltejs/svelte/pull/580
|
4e58bd06ff41ab908b5971554db83f444e0d8a83
|
7c2fd8e3cd10e1bdc8ccb8130c8d7e04daafd0ca
| 2017-05-09T15:44:58Z |
javascript
| 2017-05-21T19:19:53Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 578 |
["src/generators/dom/index.ts", "src/validate/js/propValidators/index.ts", "src/validate/js/propValidators/setup.ts", "test/js/samples/setup-method/expected-bundle.js", "test/js/samples/setup-method/expected.js", "test/js/samples/setup-method/input.html"]
|
Static properties on components
|
Currently as far as I can tell this is not possible.
I would imagine it would be something like:
```html
<p>Hello World</p>
<script>
export const meta = 'my meta data'
export default {...}
</script>
```
Then you could consume this programatically like so:
```js
import MyComponent, { meta } from './my-component.html'
console.log(meta)
```
I think this would be handy to have and am curious what others think and if there are other ways to achieve this effect (perhaps using methods as getters).
|
https://github.com/sveltejs/svelte/issues/578
|
https://github.com/sveltejs/svelte/pull/752
|
4874dc1d8947a0f9e05378fc1b107a0799b7aa3e
|
4be380744f07f5be73f48619c647a0a2b0853703
| 2017-05-07T18:56:19Z |
javascript
| 2017-08-06T01:25:48Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 575 |
["src/generators/Generator.ts", "src/validate/html/index.ts", "test/runtime/samples/helpers-not-call-expression/_config.js", "test/runtime/samples/helpers-not-call-expression/main.html", "test/validator/samples/helper-clash-context/input.html", "test/validator/samples/helper-clash-context/warnings.json"]
|
Can't access easing functions from helpers
|
This...
```html
<div in:fly='{x: -200, easing: elasticOut}'>
wheee!!!!
</div>
<script>
import fly from 'svelte-transitions-fly';
import { elasticOut } from 'eases-jsnext';
export default {
helpers: { elasticOut },
transitions: { fly }
};
</script>
```
...doesn't work, because `generator.contextualise` only uses `helpers` (instead of `state`) in case of CallExpression nodes. Proposal: any reference that matches a helper *always* uses that helper, and we add compile-time warnings if we detect conflicts (from an introduced context, and maybe by inspecting the return value of a data function where possible) and dev-mode runtime warnings to mop up the rest.
|
https://github.com/sveltejs/svelte/issues/575
|
https://github.com/sveltejs/svelte/pull/600
|
ecc9a9352c079175796af1313acc8a5f6dc156d0
|
1db0d465b09a9b7d9eeec638db2d497ff3494560
| 2017-05-07T15:11:17Z |
javascript
| 2017-05-28T17:56:04Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 574 |
[".gitignore", "src/generators/dom/shared.ts", "src/shared/transitions.js", "test/runtime/samples/transition-css-delay/_config.js", "test/runtime/samples/transition-css-delay/main.html"]
|
Delay on CSS transitions causes glitches
|
The CSS needs to be applied immediately (in [shared/transitions.js](https://github.com/sveltejs/svelte/blob/cfd5d3e3c78fc3ea5929d24edf65c748047e2803/src/shared/transitions.js#L40)) if there's a delay:
```diff
-if ( intro && obj.tick ) obj.tick( 0 );
+if ( intro ) {
+ if ( obj.tick ) obj.tick( 0 );
+ if ( obj.css ) node.style.cssText += ` ${obj.css( 0 )}`;
+}
```
Would also need to remove the styles once the transition starts.
|
https://github.com/sveltejs/svelte/issues/574
|
https://github.com/sveltejs/svelte/pull/601
|
1db0d465b09a9b7d9eeec638db2d497ff3494560
|
31d8ef66544f82b6dc4158dcf042b0ee343fab78
| 2017-05-07T15:00:42Z |
javascript
| 2017-05-28T17:56:17Z |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.